osmo-bts.git branch laforge/fsm-name created. 0.7.0-21-g7536823 - osmocom-commitlog

4 Dec 2017


      This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, laforge/fsm-name has been created
        at  7536823ea41a2cb7fc26b8c9a524b2b48a39dfee (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=7536823ea41a2cb7fc26b8c9a524b2b4...
commit 7536823ea41a2cb7fc26b8c9a524b2b48a39dfee
Author: Harald Welte laforge@gnumonks.org
Date:   Tue Oct 31 15:29:35 2017 -0400
DTX: avoid illegal character contained in DTX FSM allocation which causes BTS crash
Problem:
lchan->tch.dtx.dl_amr_fsm struct failed to allocate in l1sap_chan_act routine
     in l1sap.c due to illegal characters contained in lchan->name which are passed to
     osmo_fsm_inst_alloc routine. As a result, lchan->tch.dtx.dl_amr_fsm is NULL
     causing BTS crashed (SEG FAULT) when trying to access this struct.
Below is snapshot of crash log obtained by GDB:
     ...
     Fri Nov 24 18:13:55 2017 <0000> rsl.c:1653 payload type: 98
     Fri Nov 24 18:13:55 2017 <0000> rsl.c:1463 (bts=0,trx=0,ts=2,ss=0)
     RSL Tx IPAC_MDCX_ACK (local 127.0.0.1:11538, remote 127.0.0.1:30012)
     Program received signal SIGSEGV, Segmentation fault.
     0x00031930 in dtx_dl_amr_fsm_step (lchan=lchan@entry=0xb69592a8,
     rtp_pl=rtp_pl@entry=0x87ae8 " \024\351Y\363_\337\345\351f\177\373\300\210\201\200\210",
        rtp_pl_len=17, fn=1728481, l1_payload=0x10dd25 "", marker=marker@entry=true,
        len=len@entry=0x10ddc4 "\024", ft_out=0xbefff7d7 "\002",
        ft_out@entry=0xbefff7cf "\276\341_\032") at msg_utils.c:233
     233     msg_utils.c: No such file or directory.
     ...
Fix:
    * Use different formatting for lchan name passed to osmo_fsm_inst_alloc routine
    * Refuse channel activation if FSM could not be generated (as opposed to crash)
Related: OS#2606
    Reported-by: Minh-Quang Nguyen minh-quang.nguyen@nutaq.com
    Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c
-----------------------------------------------------------------------
hooks/post-receive
-- 
Osmocom BTS-side code (Abis, scheduling, ...)