This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via 33cbde9ced8f16181c6f71a4a890f4dc0976ba63 (commit)
via 671db90ac316665edb8894c204d44d26ba97e5c3 (commit)
from d3814b936b2ec9712561262be5a00320711ef249 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-hlr/commit/?id=33cbde9ced8f16181c6f71a4a890f4d…
commit 33cbde9ced8f16181c6f71a4a890f4dc0976ba63
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Nov 22 20:39:59 2017 +0100
return GMM_CAUSE_IMSI_UNKNOWN if there is no auth data
If we have a subscriber entry that lacks auth data, we currently return
GMM_CAUSE_NET_FAIL, which in the MSC log looks like the HLR is not connected or
something grave. Instead, return GMM_CAUSE_IMSI_UNKNOWN.
This changes the OsmoMSC log in this way:
Before:
DVLR <001e>
VLR_Authenticate(901700000014701)[0x5555558dabb0]{VLR_SUB_AS_NEEDS_AUTH_WAIT_AI}: GSUP: rx
Auth Info Error cause: 17: Network failure
After:
DVLR <001e>
VLR_Authenticate(901700000014701)[0x5555558dabb0]{VLR_SUB_AS_NEEDS_AUTH_WAIT_AI}: GSUP: rx
Auth Info Error cause: 2: IMSI unknown in HLR
A better cause value would be something that says "IMSI known, but we have no
auth data", but since such cause value is not defined, the plain "IMSI
unknown"
seems to be the best match.
Change-Id: I90df7b255317df1e5d968e7ce3b9d2c404b98db8
http://cgit.osmocom.org/osmo-hlr/commit/?id=671db90ac316665edb8894c204d44d2…
commit 671db90ac316665edb8894c204d44d26ba97e5c3
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Nov 22 20:38:19 2017 +0100
cosmetic: rx_send_auth_info(): decide error cause with switch()
Prepare for tweaking error handling in a subsequent patch: use switch() instead
of if().
Prepares-for: I90df7b255317df1e5d968e7ce3b9d2c404b98db8
Change-Id: I1f628aa9d62b778951726bebec8cf338444fc897
-----------------------------------------------------------------------
Summary of changes:
src/hlr.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT