This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/sysmocom_iu_before_cscn_rename has been created at 01fe3e15075a444b795b14c7dc79254212573a71 (commit)
- Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=01fe3e15075a444b795b14c7dc7925421...
commit 01fe3e15075a444b795b14c7dc79254212573a71 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Oct 21 01:32:10 2016 +0200
mgcp: log payload type change
Change-Id: Iee5fa667dece12174b1933345c1ed640a264ed97
http://cgit.osmocom.org/openbsc/commit/?id=3de62eb6ca740e5ce92e4403180edca18...
commit 3de62eb6ca740e5ce92e4403180edca1879de3f1 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon Jan 23 16:56:02 2017 +0100
comment: fixme: rab failure
Change-Id: I6e21f2d7dd560ab15675f3e432c37a13c4ab6792
http://cgit.osmocom.org/openbsc/commit/?id=8a6b7948ced234a0587630b96f8d56d6c...
commit 8a6b7948ced234a0587630b96f8d56d6c1c8d2a2 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Oct 18 20:20:51 2016 +0200
mgcp parsing, set port from mgcp response
Change-Id: I90e2c1aa7575d5fa6e0374f5022cbb25fc3f7699
http://cgit.osmocom.org/openbsc/commit/?id=07692b43bc666b3aef6a7cd67deca7af0...
commit 07692b43bc666b3aef6a7cd67deca7af0ab2cb58 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Oct 18 18:38:59 2016 +0200
mgcp parsing, mgcp test
Change-Id: Ibe2ab17b3fa3a506a2e841ba979ea4175e3a21e8
http://cgit.osmocom.org/openbsc/commit/?id=3859c8cd744fbe23b845f7a086a869fa5...
commit 3859c8cd744fbe23b845f7a086a869fa5e1f97f9 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Oct 14 17:56:17 2016 +0200
mgcp: handle responses from the MGCP GW
Change-Id: I5c0493feaec775461b5a017c36b93cc2ad63c896
http://cgit.osmocom.org/openbsc/commit/?id=2554ffa8b5492076aa0ca331d9657c861...
commit 2554ffa8b5492076aa0ca331d9657c8611a55d5a Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Oct 12 02:53:55 2016 +0200
IuPS: cosmetic: explicitly check RAN type; move comment
Change-Id: I8375ba42dd47d7ccd9ce9290767d6f8653a23b94
http://cgit.osmocom.org/openbsc/commit/?id=c502611d537f87785e72b451104395e7d...
commit c502611d537f87785e72b451104395e7da809d2d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Oct 12 01:39:25 2016 +0200
IuCS and IuPS: add VTY config for RAB Assignment address kind
To accomodate the ip.access nano3G without having to recompile, make the RAB Assignment's Transport Layer Address IE's format configurable, in both osmo-cscn and osmo-sgsn.
The long term perspective is to somehow detect which address encoding a given 3G cell prefers, but for the time being just configure it globally and set each ue_conn_ctx to the global setting upon creation.
Add VTY command to iu_vty.c, with args passed to iu_vty_init() to insert at an arbitrary VTY node, so that it can be used both for osmo-cscn and osmo-sgsn. Add generic iu_vty_config_write() to write out the config.
Call iu_vty_init() from cscn_vty_init(); cscn_vty_init() is in libmsc, hence linking of osmo-cscn now needs libiu to come after libmsc, so move that further down.
Change-Id: I93728314742b327336f3fb6de98e6457f687e1f9
http://cgit.osmocom.org/openbsc/commit/?id=dfcd63110a7fe2c7e3c3a08a296bf2e04...
commit dfcd63110a7fe2c7e3c3a08a296bf2e044631d2d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Oct 12 02:55:31 2016 +0200
IuCS, IuPS: move flag to use X.213 NSAP addr into ue_conn_ctx
The future perspective is to remember the preferred RAB Transport Layer Address encoding for each 3G cell that is connected, so store per UE conn instead of globally hardcoding.
Add rab_assign_addr_enc member to ue_conn_ctx. Thus the iu_rab_act_cs() and iu_rab_act_ps() functions no longer need the explicit use_x213_nsap argument.
Add include/openbsc/common.h in order to define the enum nsap_addr_enc, in a separate file to be able to easily include it in all of libmsc, libiu and gprs/* without creating include cycles.
Set the rab_assign_addr_enc when an MM ctx is created for iu, and whenever the ue_conn_ctx for an Iu MM ctx is updated. This looks a bit clumsy so far, the hope is that there will be a nice way to setup the ue_conn_ctx prior to that.
Change-Id: I49bb5736df7bdfdd55d3e7b74ee559595cfd2f7d
http://cgit.osmocom.org/openbsc/commit/?id=c77e503e29ae3280bc78b5de083a15433...
commit c77e503e29ae3280bc78b5de083a15433a8c4a71 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Oct 12 03:30:48 2016 +0200
sgsn init: pass sgsn_config pointer to sgsn_vty_init(), not sgsn_parse_config
It makes sense semantically, and prepares for an upcoming commit that uses the internal global config pointer in sgsn_vty_init(), which would not be defined yet without this.
Change-Id: Ie4cf1c0a1c9e6330a134ff4b7b2e6d5699c12bd7
http://cgit.osmocom.org/openbsc/commit/?id=53fcf56ea78667e4ac8081a1a324c3912...
commit 53fcf56ea78667e4ac8081a1a324c3912317c4bf Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Oct 12 01:29:33 2016 +0200
iu: sort out confusion around asn_debug and asn1_xer_print
Before, I confused asn_debug with asn1_xer_print. Have two distinct VTY commands and fix documentation.
Put the asn_debug and asn1_xer_print implementations in iu.c.
Since they are globally defined, don't pass a pointer to iu_vty_init() but just use it directly. Might be considered less clean, but is also less bloat.
Change-Id: Iccbadfe1585ba224f74cdfb5273b5ce29b6d78f0
http://cgit.osmocom.org/openbsc/commit/?id=f3012073a2126c20456dc9b0de24bf57c...
commit f3012073a2126c20456dc9b0de24bf57ca582c6b Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Oct 12 01:48:55 2016 +0200
iu.h: add missing includes and type defs
So far it was included only in files that also include all needed headers, but make it so that it can be included on its own.
Change-Id: I08a756031b995bd01a6e15c678b845fd98de960b
http://cgit.osmocom.org/openbsc/commit/?id=8dd8457efca5b512cac2a8cb923d2a4c3...
commit 8dd8457efca5b512cac2a8cb923d2a4c37c698f9 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Oct 11 02:24:53 2016 +0200
IuCS: rapidly release connections
Do the same as we do in 2G: release the connection as soon as nothing else is pending for a given subscriber.
Before, osmo-cscn would wait for the UE "to get bored" and send an Iu release. But the CN should stay lean on connections. Also, 25.413[1] in section 7, 6th point states: "While the Iu release is managed from the CN, the RNC has the capability to request the release of all Iu connection resources from the corresponding Iu connection." So far we did not manage Iu release from osmo-cscn at all.
Use the same mechanism we use in 2G: from msc_release_connection(), just before freeing the gsm_subscriber_conn, invoke a CN initiated Iu Release command to the UE.
This works around OS#1816 ("USSD only works when IuCS is released", on nano3G), because the Iu conn is now released right after every signalling, so that typically no two requests will use the same conn.
In iu.h/iu.c, add iu_tx_release(), absorbing almost all of the code from ranap_handle_co_iu_rel_req().
Add stub to db_test.c, necessary to build it without linking libiu.
[1] 3GPP TS 25.413 v12.4.0 Release 12 / ETSI TS 125 413 V12.4.0 (2015-04)
Related: OS#1816 Change-Id: Ic12bd6f3666f6fd42bd6d9fdae1c93abee3b6786
http://cgit.osmocom.org/openbsc/commit/?id=4f2217f01ed621b0ec53f0c4dd1333acd...
commit 4f2217f01ed621b0ec53f0c4dd1333acd76950de Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Oct 11 00:50:05 2016 +0200
IuCS: don't remove Iu conn until release
Don't remove the gsm_subscriber_connection without an Iu Release.
From the 2G paradigm to close a subscriber connection as soon as nothing else is pending, osmo-cscn frequently calls msc_release_connection() to see whether a conn has anything pending, or discards it.
In 3G however, we so far don't actively release IuCS connections from the MSC side, but wait until the IuCS is released from the UE side. So the conn is often discarded even though the IuCS stays open and valid, which confuses the situation: before the UE releases a bit later, we would try to page the subscriber unsuccessfully, because the UE expects to already be connected.
To first fix the discrepancy of Iu vs. subscr release, never discard gsm_subscriber_connections when msc_release_connection() is called.
This creates a "lazy" CN that keeps connections open as long as the UE will tolerate. It is really fast in sending many SMS in close succession, but is certainly a bad CN design choice: we should rather stay lean on connections.
A subsequent commit will change this, but I decided to keep this commit as a reference, for when we'd like to test situations that should re-use an established connection.
Change-Id: I012378cfa432d791146db387554ec1909de05297
http://cgit.osmocom.org/openbsc/commit/?id=523b9e96d031728c0204891341aa73815...
commit 523b9e96d031728c0204891341aa73815e5a3478 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Oct 11 01:05:22 2016 +0200
IuCS: detect whether a conn is already secure
If a CM Service Request is received on an already secure IuCS connection, we so far didn't notice and started to authenticate again. The UE would readily renew its authentication, but then our state got stuck since ciphering was already established. Instead, don't authenticate again when integrity protection is already established.
Change-Id: I3c01fe58276ba0ad918f2cd30cc3dca7c6663e68
http://cgit.osmocom.org/openbsc/commit/?id=c5122598862a25ef5e2b0249e3cf51ac4...
commit c5122598862a25ef5e2b0249e3cf51ac42e8405e Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Sep 20 18:18:26 2016 +0200
mgcp dbg log
Change-Id: I56fda48edaa92abfc6e3886cdfce733bb0686f73
http://cgit.osmocom.org/openbsc/commit/?id=9221321c4b557f10f192a30fa6797355f...
commit 9221321c4b557f10f192a30fa6797355f372627c Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Thu Sep 22 20:00:16 2016 +0200
sgsn_ranap_iu_event: handle some events without valid MM context
Change-Id: Ia7e74087d56996104b6d3935b1cf12166ff67f3a
http://cgit.osmocom.org/openbsc/commit/?id=030c4778783da36f761dcb20af23dbb98...
commit 030c4778783da36f761dcb20af23dbb98586f797 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon Sep 19 18:30:49 2016 +0200
IuCS: store assigned rab_id in gsm_subscriber_connection
Change-Id: I7fda4304631fc24bbd1bebe911b8403a942fcf53
http://cgit.osmocom.org/openbsc/commit/?id=9245b7ce593f0b1c51a3c1dee3ba1bf5d...
commit 9245b7ce593f0b1c51a3c1dee3ba1bf5d74a6c39 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Thu Sep 22 20:28:35 2016 +0200
bridge calls via mgcpgw
Change-Id: Ie259e30bc532fe9817c96562022ac33443d5747a
http://cgit.osmocom.org/openbsc/commit/?id=c3e30e6eef4b138e5387e84806aed1bda...
commit c3e30e6eef4b138e5387e84806aed1bda38a6736 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Thu Sep 22 20:29:30 2016 +0200
also do call assignment for MT calls, upon Call Confirmed
Change-Id: I863fa73948f61aaffd7f4472f3abc3e44228e31f
http://cgit.osmocom.org/openbsc/commit/?id=6ebde7c0299f73f2ff5854e7c2ca80247...
commit 6ebde7c0299f73f2ff5854e7c2ca80247bba82cc Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Sep 7 13:39:07 2016 +0200
IuCS: implement msc_call_assignment() for IuCS
Send IuCS RAB Activation upon MNCC_CALL_PROC_REQ.
Implement function msc_call_assignment(): decide between sending A-iface BSSMAP Assignment Request or IuCS RAB Assignment Request.
Implement iu_rab_act_cs() to send the IuCS RAB Assignment Request. The IP address and port of the MGCPGW sent in the RAB Assignment are still hardcoded.
The A-interface extension is not implemented yet.
Declare ranap_new_msg_rab_assign_voice() to avoid including ranap_msg_factory.h, which would require adding ASN1 CFLAGS to Makefile.am.
The mgcpgw_client as well as some more osmo-iuh functions are now linked from libmsc, hence add some dummy stubs to libiudummy and db_test.c.
Change-Id: Iaae51d1fbbfc28fad1c0b85e161d53d80a420a19
http://cgit.osmocom.org/openbsc/commit/?id=fcf3291e16d236170944944b04c615e7e...
commit fcf3291e16d236170944944b04c615e7e9818df6 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Thu Sep 22 20:21:10 2016 +0200
cscn: add mgcpgw client (with dummy read cb so far)
Store the mgcpgw client data in struct gsm_network. Initialize VTY and bind the client.
Change-Id: Ifc4efb1ca44fa34c29bf23b35addb54155296d68
http://cgit.osmocom.org/openbsc/commit/?id=88711ff148346fde094bae23f5b6bc191...
commit 88711ff148346fde094bae23f5b6bc191b6c04e2 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Sep 7 13:39:07 2016 +0200
libmgcp: add mgcpgw client API
Add an API to send MGCP messages to an MGCP GW, from the perspective of an MSC instructing the GW to setup RTP streams.
Rationale: the mgcp_protocol.h is mostly for the MGCP GW itself, other implementations forward incoming MGCP messages. So a simpler approach for an MGCP GW client is useful.
Add general VTY commands that can be used to configure mgcpgw_client.
osmo-cscn is going to use this to route RTP streams (for 3G at first).
Change-Id: I6fe365c4c89207f2172943cc456b508a207b1135
http://cgit.osmocom.org/openbsc/commit/?id=631d9ccbd56eda64aa0cee7ea05873fe1...
commit 631d9ccbd56eda64aa0cee7ea05873fe17ab3209 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Sep 7 13:39:07 2016 +0200
libmgcp: add value strings for mgcp_connection_mode
Add file mgcp_common.c to implement the value strings for the mgcp_connection_mode.
Add in a separate file because of the upcoming mgcpgw_client.c implementation, introducing a file that contains implementations commonly used in MGCP GW as well as its clients.
Change-Id: I6fe365c4c89207f2172943cc456b508a207b1135
http://cgit.osmocom.org/openbsc/commit/?id=a389a6152795f7b80106dcdd005b742d4...
commit a389a6152795f7b80106dcdd005b742d46c8cd0f Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Sep 20 18:16:35 2016 +0200
libmgcp: move mgcp_connection_mode to public header
mgcp_connection_mode will be used by the upcoming mgcpgw_client.h API.
Change-Id: I7a3f8905723320d968f1a53c1036904107b4fb2d
http://cgit.osmocom.org/openbsc/commit/?id=08e61880f79b3c3cd330ac5a6933a8753...
commit 08e61880f79b3c3cd330ac5a6933a8753a1092a0 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue Sep 6 20:08:58 2016 +0200
IuCS: cosmetic prep for msc_call_assignment()
Rename gsm48_cc_tx_call_proc() to gsm48_cc_tx_call_proc_and_assign() to mark the place where the A-interface will send a BSSAP Assignment Request / where the IuCS-interface will send a RAB Assignment Request.
Add function msc_call_assignment() to decide between A-iface and IuCS assignment, to be implemented in subsequent commit.
Change-Id: I0695e233d57d13658793b0e63bb7c3ff224909a0
http://cgit.osmocom.org/openbsc/commit/?id=6ce84ae0a201bea19068a29f903f561a1...
commit 6ce84ae0a201bea19068a29f903f561a1e95f304 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Sep 7 17:52:32 2016 +0200
IuCS: send RANAP CommonID
Add libiu function to send a CommonID message down a UE connection, iu_tx_common_id(); add also a corresponding stub to libiudummy for linking with tests.
Add libmsc function msc_tx_common_id() to call the above. Add this mostly to clearly indicate in msc_ifaces.h that libmsc is calling out of the MSC; also to do conn->via_iface checking.
Call msc_tx_common_id() after ciphering is established, in _gsm48_rx_mm_serv_req_sec_cb()'s GSM_SECURITY_SUCCEEDED case.
Change-Id: I576ddd5bbabfc989149debd2f8a9743db6d26043
http://cgit.osmocom.org/openbsc/commit/?id=221bd937ea9bb7d1d413395468fc2f5b7...
commit 221bd937ea9bb7d1d413395468fc2f5b78d58c32 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed Aug 31 15:40:18 2016 +0200
cosmetic: msc_handler, bsc_handler: drop extra whitespace
The extra ws made me not find these lines when grepping for 'dtap ='.
Change-Id: I45e5c9e7df4704546872aab15adf407298943435
http://cgit.osmocom.org/openbsc/commit/?id=fd0d60fda64be54ffc6d63672389de26b...
commit fd0d60fda64be54ffc6d63672389de26bafcde22 Author: Harald Welte laforge@gnumonks.org Date: Mon May 2 08:34:57 2016 +0200
SGSN: Don't indicate GERAN in Iu mode PDP CTX ACT REQ to GGSN
http://cgit.osmocom.org/openbsc/commit/?id=2238f8ee99fd7243c2e17224149e316ca...
commit 2238f8ee99fd7243c2e17224149e316cae864a01 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 9 13:20:54 2016 +0200
cosmetic: make gsm0408_loc_upd_rej() static
http://cgit.osmocom.org/openbsc/commit/?id=b4ad77884b56fc8dde0e620db12cd9fa7...
commit b4ad77884b56fc8dde0e620db12cd9fa74e1a31f Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 9 13:18:03 2016 +0200
LU counters: count completion and failure, not messages sent
From a human admin viewpoint it doesn't make sense to count the messages sent:
When we use TMSIs, we first send a LU Accept with a new TMSI, and then expect the MS to respond with a TMSI Realloc Complete message. When that fails to come through, the LU actually ends in failure, even though a LU Accept was sent.
In 3G, if a UE sends an Iu Release during LU (e.g. user enables flight mode), we cancel the LU without sending any reply at all, so nothing would be counted.
Instead, count Location Updating results, i.e. completion and failures.
http://cgit.osmocom.org/openbsc/commit/?id=9164ed6faa132aa94a1088c5457303573...
commit 9164ed6faa132aa94a1088c545730357364db845 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:21:52 2016 +0200
remove handle_abisip_signal()
Change-Id: I9cf80f9c2c8a53a29e42f000029e680a9922cb41
http://cgit.osmocom.org/openbsc/commit/?id=9adf4c7a40e2906e735ab2f00c265c066...
commit 9adf4c7a40e2906e735ab2f00c265c066b26d03f Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed May 4 15:35:37 2016 +0200
gsm0408_clear_request(): actually free the released conn
By having conn->in_release == 1, calling msc_release_connection() has no effect and thus never frees the conn. So, after all pending requests have been discarded, also discard and free the unused connection.
http://cgit.osmocom.org/openbsc/commit/?id=5b75a3983b26f6456826a2ce03275c89b...
commit 5b75a3983b26f6456826a2ce03275c89b171f376 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:24:12 2016 +0200
add iu.h to gsm_subscriber.c
Change-Id: I398aaa4a7328a58fb0d563725f3bea26482929ef
http://cgit.osmocom.org/openbsc/commit/?id=96f3034784c5f4a46751fe2e6dafea65a...
commit 96f3034784c5f4a46751fe2e6dafea65a0fc5036 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:11:39 2016 +0200
gsm_04_08.c: iu.h
Change-Id: I624612b5d5cd70770326347634aee2a42ba88945
http://cgit.osmocom.org/openbsc/commit/?id=506605e0a4d3faa8203304aed7cc9c055...
commit 506605e0a4d3faa8203304aed7cc9c05514b0381 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:09:47 2016 +0200
temporary dev: set debug log level almost everywhere
Change-Id: I0d5a36560e7edde27497de57e579f5b1d00eb525
http://cgit.osmocom.org/openbsc/commit/?id=68173bfc25765a6329ea489d5c7d80b9f...
commit 68173bfc25765a6329ea489d5c7d80b9fc36c9cc Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 13:26:47 2016 +0200
comment on mscsplit, indent comment
http://cgit.osmocom.org/openbsc/commit/?id=e8f30529746333f825b462cd202811352...
commit e8f30529746333f825b462cd202811352cadaeb2 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 13:44:39 2016 +0200
move to libbsc: lchan_next_meas_rep() -- TODO really?
Change-Id: I4ea799c5fa61f81c404e6ef1b9ac86a8faa1fb49
http://cgit.osmocom.org/openbsc/commit/?id=dae6b39b5915e962060b0f0402cb498d5...
commit dae6b39b5915e962060b0f0402cb498d5d2d46be Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 13:59:16 2016 +0200
move to libbsc: gsm_bts_neighbor() -- TODO really?
Change-Id: I63d4835dc7aabdf176e0ca634a6a4ca527612693
http://cgit.osmocom.org/openbsc/commit/?id=c85d4b87f59bd8c856c210063f84eaa7c...
commit c85d4b87f59bd8c856c210063f84eaa7c3208fe2 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed May 11 14:21:58 2016 +0200
gsm0408_test: use NULL for root ctx -- TODO really?
http://cgit.osmocom.org/openbsc/commit/?id=447e280fa2bbf48e4c7c2a47dce5d6be6...
commit 447e280fa2bbf48e4c7c2a47dce5d6be6ac0e789 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 9 21:30:26 2016 +0200
gsm_04_08: remove apply_codec_restrictions() -- TODO really?
This function is wrongly placed on the MSC level.
Unfortunately I cannot remember the very plausible details that hwelte had back in the days to argue for this change. (Refactoring an old commit that fails to explain in more detail.)
Change-Id: I82623847e652a59a921d2fb142b77cf22420a746
http://cgit.osmocom.org/openbsc/commit/?id=fcb6e195b1bd912723a82bbb1cff43e31...
commit fcb6e195b1bd912723a82bbb1cff43e311689abb Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Thu May 12 02:14:33 2016 +0200
move to libmsc: osmo_stats_vty_add_cmds() -- todo MSCSPLIT
http://cgit.osmocom.org/openbsc/commit/?id=e094126930aff2e8ecabeff981eb1f3cb...
commit e094126930aff2e8ecabeff981eb1f3cbe55f424 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 14:04:28 2016 +0200
include msc_ifaces.h in gsm_04_08.c
Change-Id: I11be1bdfe6993f89b34319e7d1526c729d6e0cde
http://cgit.osmocom.org/openbsc/commit/?id=f09f6e303f3143309e622ef42c2af4d96...
commit f09f6e303f3143309e622ef42c2af4d960391289 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:04:56 2016 +0200
complete IuCS paging implementation
Add paging timeout to struct gsm_subscriber. Previously, paging timeout was implemented only on BSC level, where each request has its own timeout value. The MSC will still send individual requests to BSC or RNC level, where they timeout individually. However, the MSC must also have an own timeout to be sure to discard stale pagings that the BSC or RNC never replied for.
Add handle_paging_resp(), copying the few libmsc relevant parts of gsm48_handle_paging_resp().
http://cgit.osmocom.org/openbsc/commit/?id=326a98e1872a5ecc4db53e05f6d1f52be...
commit 326a98e1872a5ecc4db53e05f6d1f52be196b259 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 13:57:25 2016 +0200
paging: add todo comments for paging and mscsplit
Change-Id: I7e72c9db2837ea5edf45f6037cb0288a264d492c
http://cgit.osmocom.org/openbsc/commit/?id=c34d654d91b9fad0cf9c8e32b6a3182c2...
commit c34d654d91b9fad0cf9c8e32b6a3182c2a36b225 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 2 15:57:53 2016 +0200
paging: actually verify subscriber authorization
Before this, any paging response would be accepted by the CN, without checking the database whether the subscriber is in fact authorized.
The probability that a subscriber would be able to take unauthorized action is slim, nevertheless checking authorization status with the database should happen before we accept a connection.
http://cgit.osmocom.org/openbsc/commit/?id=a435e34f0065c23339fcf95d8936feaaf...
commit a435e34f0065c23339fcf95d8936feaafc8325e1 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 2 15:55:22 2016 +0200
paging: change subscr_paging_cb() into subscr_rx_paging_response()
Remove one layer of callback indirection in paging. When a paging response arrives, we always want to first secure the connection, thus a fixed subscr_rx_paging_response() function is more appropriate and avoids having to store a cbfn. The actual actions to be taken upon successful paging are of course still in callback functions stored with each subscriber.
Remove paging_request_stop() call from subscr_paging_dispatch(), which stops paging on all BTSs, which is not the responsibility of libmsc.
Change-Id: Ic2c785c9cc48b2c2c6557cbe1060d25afa89e38d
http://cgit.osmocom.org/openbsc/commit/?id=383b8505289aa272a44ceb3bba5bfe169...
commit 383b8505289aa272a44ceb3bba5bfe169c19b56a Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:06:55 2016 +0200
move subscr auth check to gsm_subscriber.c
add subscr_authorized(), subscr_authorized_imsi()
Change-Id: If2ef06b1229351127c61477ca14653d6ae4cb6bb
http://cgit.osmocom.org/openbsc/commit/?id=2c750f19e0098827d30d99d87b8694586...
commit 2c750f19e0098827d30d99d87b869458658bf77b Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Aug 12 16:11:25 2016 +0200
auth log
Change-Id: Icd9f8505388a06ee768d2176cb2b9187953098ef
http://cgit.osmocom.org/openbsc/commit/?id=5f1cb5bfc3e041fcd91fd223ce60a1bfd...
commit 5f1cb5bfc3e041fcd91fd223ce60a1bfdcfad8f4 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Aug 12 16:09:46 2016 +0200
iu auth wip
Change-Id: Icc2522252cf15c54f1a1ea5255314a0de8bfba03
http://cgit.osmocom.org/openbsc/commit/?id=0648e796406489ce4a35ec54514451a32...
commit 0648e796406489ce4a35ec54514451a32db488ac Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Aug 12 16:03:09 2016 +0200
Iu auth wip
Change-Id: I44effcca80dc6850178174dc957bcd5608b0ae14
http://cgit.osmocom.org/openbsc/commit/?id=1bed088a4916e3761738c664a0ffc7117...
commit 1bed088a4916e3761738c664a0ffc711778cf9ba Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri Aug 12 16:21:32 2016 +0200
cosmetic prep: change int -> bool authorize_subscriber()
Upcoming function subscr_authorized() will flip this to bool, so separate this change cosmetically.
Change-Id: Iba0184a71afa01141ef06c474cb554e79ad8f5d5
http://cgit.osmocom.org/openbsc/commit/?id=baf9a1d6001342a82cc2383f1e2bcd16d...
commit baf9a1d6001342a82cc2383f1e2bcd16d1b55d12 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:07:23 2016 +0200
subscr_request_channel() -> subscr_request_conn()
Change-Id: Ife8e10b240693a8d369139881774f1892044aa65
http://cgit.osmocom.org/openbsc/commit/?id=169a8cf586cfde06002d4ea2878f4650b...
commit 169a8cf586cfde06002d4ea2878f4650be5808ba Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:05:13 2016 +0200
move subscr_request to gsm_subscriber.h
Change-Id: Idbbd39b0e068da17aafa97e315143509c69c50ea
http://cgit.osmocom.org/openbsc/commit/?id=2817e699ac312e03ce7a1715c22f1f3f0...
commit 2817e699ac312e03ce7a1715c22f1f3f0afd087f Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:01:01 2016 +0200
add gsm_encr to subscr_conn
Change-Id: Id5797cd1f1bfa2cca2d3fbabc1981aa75546421b
http://cgit.osmocom.org/openbsc/commit/?id=88f938aec27b079fc282d5942e3159819...
commit 88f938aec27b079fc282d5942e3159819fa31218 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 14:57:14 2016 +0200
osmo-nitb becomes osmo-cscn
Change-Id: I3787050b524954d8a4dd13495c458f3ee293807b
http://cgit.osmocom.org/openbsc/commit/?id=831daf51f42f57d61896101afcddbfe08...
commit 831daf51f42f57d61896101afcddbfe08e7cbfaa Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Wed May 11 17:13:28 2016 +0200
remove unneccessary linking from some tests
The recent shifts and cuts have made some library linking for bsc, channel and db tests unnecessary.
http://cgit.osmocom.org/openbsc/commit/?id=9f184d950cfdeef0c33cdb0dec768458c...
commit 9f184d950cfdeef0c33cdb0dec768458c3022f86 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 14:46:23 2016 +0200
msc_release_connection(): don't call gsm0808_clear()
gsm0808_clear() is all about clearing lchans. To be able to link libmsc without libbsc, don't call it directly.
Change-Id: I149146fc3cb99ef4a21ee2a798231bb070f398cd
http://cgit.osmocom.org/openbsc/commit/?id=a111e13671ae0017dbda5328bf9b8490a...
commit a111e13671ae0017dbda5328bf9b8490a14c2c70 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 21:44:32 2016 +0200
cut off libbsc paging, pending paging in libmsc
Temporarily disable all paging to be able to link libmsc without libbsc. Skip the paging part of channel_test because the paging is now disabled.
In osmo-nitb, paging is done on BSC level and MSC level "at the same time". When the new CSCN is fully operational, paging will be controlled separately on the MSC level, and the BSC (RNC) level will be instructed over an IuCS or A-interface to negotiate paging with the MS (UE). This MSC level paging does not yet exist and will be added in subsequent commits.
Change-Id: I8b6920ddc54fc3f2876a59664e6722666d8a8a4a
http://cgit.osmocom.org/openbsc/commit/?id=eafcf66a18ae450baee4b9e96406b28be...
commit eafcf66a18ae450baee4b9e96406b28be6718793 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 13:09:14 2016 +0200
libmsc: duplicate gsm0808 / gsm48 functions (towards BSC)
In osmo-nitb, libmsc would directly call the functions on the BSC level, not always via the bsc_api. When separating libmsc from libbsc, some functions are missing from the linkage.
Hence duplicate these functions to libmsc, add an msc_ prefix for clarity, also add a _tx to gsm0808_cipher_mode():
* add msc_gsm0808_tx_cipher_mode() (dummy/stub) * add msc_gsm48_tx_mm_serv_ack() * add msc_gsm48_tx_mm_serv_rej()
Call these from libmsc instead of
* gsm0808_cipher_mode() * gsm48_tx_mm_serv_ack() * gsm48_tx_mm_serv_rej()
Also add a comment relatd to msc_gsm0808_tx_cipher_mode() in two places.
Change-Id: I5b276853d3af71f5e3f0a031fd17b4fff0580020
http://cgit.osmocom.org/openbsc/commit/?id=a7319717947372a677d1dd8f0504cc8c9...
commit a7319717947372a677d1dd8f0504cc8c9926b364 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri May 20 20:40:34 2016 +0200
Use new msc_tx_dtap() instead of gsm0808_submit_dtap()
Aim: msc_tx_dtap() shall redirect to IuCS or A interfaces depending on subscr conn.
Change-Id: I30d961f16eb7b9c0ab9cc3f43198098d3f1a909f
http://cgit.osmocom.org/openbsc/commit/?id=4db381b3cc0b8f0357d5b41c2fa4e3b55...
commit 4db381b3cc0b8f0357d5b41c2fa4e3b55f054d3a Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri May 20 21:41:08 2016 +0200
add libiudummy, to avoid linking Iu deps in tests
Change-Id: I4a66c4122011dbc87c6fcb336ab0461b86522c98
http://cgit.osmocom.org/openbsc/commit/?id=e1707d48b2caf226dec515e709efdff51...
commit e1707d48b2caf226dec515e709efdff51868470d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 14:59:02 2016 +0200
move to libcommon-cs: gsm48_extract_mi(), gsm48_paging_extract_mi() -- TODO move to libfilter instead?
Change-Id: I00ca0caf8224de029f53f4dedb1146e3cf7650ec
http://cgit.osmocom.org/openbsc/commit/?id=7c30bc784a628db0a0ab439bc624df209...
commit 7c30bc784a628db0a0ab439bc624df209b18dae9 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 13:37:59 2016 +0200
msc_compl_l3(): publish in .h, tweak return value
Use new libmsc enum values for return val, to avoid dependency on libbsc headers.
Make callable from other scopes: publish in osmo_msc.h and remove 'static' in osmo_msc.c
Change-Id: If24007445899e9c75553a0dbf843ada3566b3380
http://cgit.osmocom.org/openbsc/commit/?id=4703561fc66dfb54ad9cf6811e5cf78ce...
commit 4703561fc66dfb54ad9cf6811e5cf78cebd034b5 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 14:58:46 2016 +0200
add cscn vty, remove nitb vty
Change-Id: I8f8980d6cfbf26f1b0e0197939833e55dbe521fb
http://cgit.osmocom.org/openbsc/commit/?id=5d7a713e32eda9f50d6c44cbbc7b8372f...
commit 5d7a713e32eda9f50d6c44cbbc7b8372fea63898 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 14:56:06 2016 +0200
add iucs.[hc]
Change-Id: I88e981f4c31393a98ae8d61176c65c9251a6f28b
http://cgit.osmocom.org/openbsc/commit/?id=6759ac79d86b1bf4592bdd6f4d506826d...
commit 6759ac79d86b1bf4592bdd6f4d506826dd5d271f Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Fri May 20 21:59:55 2016 +0200
add DIUCS debug log constant
Change-Id: Id347a3024fa495a1ab680db7320648d933a4018b
http://cgit.osmocom.org/openbsc/commit/?id=74d94e0aba37b3161eec176347741652d...
commit 74d94e0aba37b3161eec176347741652d345d15e Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:16:45 2016 +0200
gsm0408_loc_upd_rej(): remove bts use (used only for debug log)
Change-Id: I3ac38f4b701ad8308470573260fa91a4b04c2f18
http://cgit.osmocom.org/openbsc/commit/?id=9f6a41e0975e17677b6710a317e7bbc2e...
commit 9f6a41e0975e17677b6710a317e7bbc2e154511d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:05:43 2016 +0200
gsm_04_08, gsm_subscriber: decouple lac from bts
The idea is to not have a direct pointer to a bts struct (into BSC land), but a LAC to resolve the BSC or RNC depending on the appropriate A or IuCS interface.
subscr_update(): remove bts arg, add lac arg.
Pass conn->lac to gsm48_generate_lai() instead of bts->location_area_code.
Change-Id: I9f2b298a785bf4b2a1b3fcdd91b8256106b2d9de
http://cgit.osmocom.org/openbsc/commit/?id=67893249684b90eca5a4531c4654b164f...
commit 67893249684b90eca5a4531c4654b164f6cf0c4d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:06:35 2016 +0200
subscr_update_expire_lu(): remove bts arg
Change-Id: I26cafd9389aac65e53dc4280a1687c6b8bce3106
http://cgit.osmocom.org/openbsc/commit/?id=b6d6086d2bd9610ca1e0fb022c776d6c0...
commit b6d6086d2bd9610ca1e0fb022c776d6c0386c361 Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:03:18 2016 +0200
move t3212 to network level (periodic lu)
Set the T3212 default value in struct gsm_network and take that value when creating a BTS.
Adjust VTY accordingly.
Change-Id: Ifb730f9d0106fe195adc30459a39290a07313b50
http://cgit.osmocom.org/openbsc/commit/?id=248cc90f8de1f4d3017dfe123c884739d...
commit 248cc90f8de1f4d3017dfe123c884739da83940d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:11:50 2016 +0200
libmsc: iucs dev: disable large parts of the code
Change-Id: I3ef6ca26150b6102a0fa22a88a60d9a442d640b4
http://cgit.osmocom.org/openbsc/commit/?id=b583f7b07b7725a589eb53ef3d151ceee...
commit b583f7b07b7725a589eb53ef3d151ceee28e833c Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Tue May 10 12:50:31 2016 +0200
Prepare entry/exit point for MSC -> BSC and MSC -> RNC communication.
Add msc_ifaces.[hc], a_iface.c, with a general msc_tx_dtap() to redirect to different interfaces depending on the actual subscriber connection.
While iu_tx() is going to be functional fairly soon, the a_tx() is going to be just a dummy for some time (see comment).
Add via_iface marker to gsm_subscriber_connection with enum values IFACE_A and IFACE_IU so far.
Add Iu specific fields in a sub-struct: the UE connection pointer and an indicator for the Integrity Protection status on Iu (to be fully implemented in later commits).
Add lac member to gsm_subscriber_connection, to allow decoupling from bts->location_area_code. The conn->lac will actually be set in iu.c in an upcoming commit ("add iucs.[hc]").
Change-Id: Idf8020a30562426e8f939706bf5c2188d5a09798
http://cgit.osmocom.org/openbsc/commit/?id=aab55eaf8962446136fb47b7c03e9204c...
commit aab55eaf8962446136fb47b7c03e9204c340e67d Author: Neels Hofmeyr nhofmeyr@sysmocom.de Date: Mon May 30 15:13:32 2016 +0200
don't use lchan in libmsc
Change-Id: Ic7ed7faa2bcc7aae799f41ed4abc2c001bfb61b7
http://cgit.osmocom.org/openbsc/commit/?id=115b6a9b79e8fb622c01663ab3b7a541f...
commit 115b6a9b79e8fb622c01663ab3b7a541ffd52b1b Author: Harald Welte laforge@gnumonks.org Date: Thu Dec 24 17:06:42 2015 +0100
gsm_04_08.c: Don't set msg->lchan nor msg->dst
the BSC-side of the API behind gsm0808_submit_dtap() is doing this resolving again anyway. So let's avoid doing it twice, and avoid having more dependency of the MSC down into the lchan details.
Conflicts: openbsc/src/libmsc/gsm_04_08.c
Change-Id: I14254be68ee1a48e9f1ce968233414d86c6ba9d5
-----------------------------------------------------------------------
hooks/post-receive
osmocom-commitlog@lists.osmocom.org
-
gitosis＠osmocom.org