26 Feb
2018
26 Feb
'18
3:33 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via 0d6c3e811007be828207c0f69ff4e2dddeeb64db (commit)
via 3a80a56b9befe5f47cae5e4210ebc81d343b04f8 (commit)
from 6381900677001088b8f2a74905cd3ac1994f33ba (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=0d6c3e811007be828207c0f69ff4e2d…
commit 0d6c3e811007be828207c0f69ff4e2dddeeb64db
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Feb 23 14:06:27 2018 +0100
measurement.c: Don't silently copy "FULL" measurements to
"SUB"
The existing code contained an ugly hack that if we didn't have any
"SUB" measurements we would simply use the "FULL" values.
That's wrong
as TS 45.008 contains quite detailed rules on how the "SUB" values are
to be computed. In some cases, they are identical to "FULL", but in
most they are not.
Let's remove the hack and replace it with an ERROR message, as clearly
something is wrong if we ever encounter a measurement period end in
which no single "SUB" measurement was received. The only situation in
which this can occur is if the related uplink burst/block was missing,
so let's set BER to 100% and level to lowest possible.
Change-Id: I358f7b97fd4ea19264a77eff7abef13da7d5fbcd
http://cgit.osmocom.org/osmo-bts/commit/?id=3a80a56b9befe5f47cae5e4210ebc81…
commit 3a80a56b9befe5f47cae5e4210ebc81d343b04f8
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Feb 23 13:59:17 2018 +0100
measurement: Compute RX{LEV,QUAL}-SUB for SDCCH and non-AMR TCH
The rules on how to compute RX{LEV,QUAL}-SUB are rather convoluted, and
depend on the detailed channel type and mode.
For SDCCH and TCH/H in signalling mode, it's easy: No DTX is allowed,
and all measurements are used in SUB.
For non-AMR (TCH/F and TCH/H in non-signalling mode), we need to count
the SACCH block measurements, as well as any
SID/SID_UPDATE/L3_FILL/DUMMY blocks received in the blocks of table
8.3 of TS 45.008.
Only AMR (TCH/AFS + TCH/AHS) are more difficult, as there are no fixed
blocks/bursts/frames that always contain uplink messages, but the L1
will have to determine if a valid SID_UPDATE was received or not.
This patch implements the above rules (except AMR related) in the common
part of OsmoBTS. The AMR specific bits will have to follow as a later
patch, likely in a BTS specific way, i.e. separate changes to
sysmo/lc15/octphy/trx code.
Related: OS#2978
Change-Id: I16eb3747a1c23df935a4c50dafe46abce512a474
-----------------------------------------------------------------------
Summary of changes:
src/common/measurement.c | 109 ++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 104 insertions(+), 5 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)