openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-854-g0b1caf7

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards b392f1b1448b3eebf779457577fb439d533781c0 (commit) discards 6888fef2394ec6e7cf9fa1667f6d990ea3323d6f (commit) discards 4bddf37c8d4b54d94e2245250bdf44916f657ea2 (commit) discards af31f22589327f0c4a13587ead4b0413af95f845 (commit) discards 618dce764997e543cbe7e8b5c9313f981122f576 (commit) discards 1793b8df0dda07fcf29baf31b3b08c748103887f (commit) discards fa9af3fe29a549523a30e2af521f73b2f17819da (commit) discards 00ae6ee4ed6677cfe3ac10aeea76c1b0ac125f8e (commit) discards 50a3edc6c2cca52464c40dd24756365acf57680d (commit) discards 4cb99aad4fa93be5e4381152ae3fb1583b429b75 (commit) discards d0d5a90281f54b0ddcfa54a715b01a30045ede62 (commit) discards a4b21b7f740defe76e70fcb459667436da8bc8fd (commit) discards bcb60cccc36aa2b48abeec55081decdce623b9a1 (commit) discards cde63d0a32b7610ed077c7831b960c009e024b77 (commit) discards 95961dd1282789ddd55cbf1c32ea2ce62bec61f0 (commit) discards 694aad91d4b1bf658cfac767871ddffdcceb45d3 (commit) discards 4fe374421b460a0f023a4fd7fda048d675d793d1 (commit) discards 84c734570291d7e240ee473a614ac8f3af14771a (commit) discards 65f625f2283553497d7cc0d15a4c9ca8e6656442 (commit) discards 0163dbcc30575ee6953222183f2cbbd0741486b5 (commit) discards e14a5903e5d1c9fce9d13f91e9a08eeade42a541 (commit) discards 21aa2a90ea2f5cf10fb9db75c597b8fe572c51cd (commit) discards 5ca5699e61b2395fd822027c425be5f26bd33ac2 (commit) via 0b1caf7da499d1cbce53795cf9deee4643636327 (commit) via 7cfbae6fc6168148f937cf781bed962ed8ec1a32 (commit) via c6d308f59292adc572b680065192e9ed55ea19e9 (commit) via ba59d61d98064219b7618ffa254027b009201d80 (commit) via 7c2a048c2be60ea3e30bc755939503299b720904 (commit) via 5428ff90b1260769cc918a585abdb1c292d67f7f (commit) via 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 (commit) via 6231ed289064f453b5d2bb56d70afe7a992dfe77 (commit) via 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 (commit) via 65f35a28038ec7ed310a2fca5015b3018c5455e8 (commit) via 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 (commit) via 45292a23631fdb943c7aaec0dc1d1af2ce013792 (commit) via 424d584f82f8240c1325ca25ed186f446997de58 (commit) via 5c455ae7a7326c19545258a6e247fe2f6b4c3e01 (commit) via 3d0895483f0d543af485413dedb40294b0efd9b4 (commit) via 79571191f2c526e18dc1257a3273a7235582d2a6 (commit) via ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 (commit) via 9f2e178f07b7d15733e862fca7c140b1475899ee (commit) via 847bf670e354fbd11bedbadf63deb0577a0a380b (commit) via 62068f8848f5c851a06053265b311dca9042b103 (commit) via 2ad5544bee5062301797a86a6adb44513abe27d2 (commit) via 5636470b9fa12827e190f3f38386f2824edfcf61 (commit) via 4e8a698c1173d71f9e0ee6eef182f5884c181493 (commit) via a67704753a6328f725d38d61af8bfbe29012fcbc (commit) via 0c4e400d2fdd6445da4dc24851945119517d8083 (commit) via c598e6e0a6d00827c2c974010d582815d66d0f14 (commit) via a9e420e93dca43b92b608a819ea782445eef52e0 (commit) via 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 (commit) via e5d2c60ae661e801b7049a2c9526712ded895cc1 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (b392f1b1448b3eebf779457577fb439d533781c0) \ N -- N -- N (0b1caf7da499d1cbce53795cf9deee4643636327) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0b1caf7da499d1cbce53795cf9deee46… commit 0b1caf7da499d1cbce53795cf9deee4643636327 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Handle GSUP errors (WIP) Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7cfbae6fc6168148f937cf781bed962e… commit 7cfbae6fc6168148f937cf781bed962ed8ec1a32 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c6d308f59292adc572b680065192e9ed… commit c6d308f59292adc572b680065192e9ed55ea19e9 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ba59d61d98064219b7618ffa254027b0… commit ba59d61d98064219b7618ffa254027b009201d80 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7c2a048c2be60ea3e30bc75593950329… commit 7c2a048c2be60ea3e30bc755939503299b720904 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5428ff90b1260769cc918a585abdb1c2… commit 5428ff90b1260769cc918a585abdb1c292d67f7f Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4cd6d2a4763b2b6a2d8aa0ea73ee9e69… commit 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6231ed289064f453b5d2bb56d70afe7a… commit 6231ed289064f453b5d2bb56d70afe7a992dfe77 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=26f2c6a6846ab959d9e6f8fdf6f229dd… commit 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=65f35a28038ec7ed310a2fca5015b301… commit 65f35a28038ec7ed310a2fca5015b3018c5455e8 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8f4fa5fc5f8225a5fb55fa2c4b12eace… commit 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=45292a23631fdb943c7aaec0dc1d1af2… commit 45292a23631fdb943c7aaec0dc1d1af2ce013792 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=424d584f82f8240c1325ca25ed186f44… commit 424d584f82f8240c1325ca25ed186f446997de58 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5c455ae7a7326c19545258a6e247fe2f… commit 5c455ae7a7326c19545258a6e247fe2f6b4c3e01 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3d0895483f0d543af485413dedb40294… commit 3d0895483f0d543af485413dedb40294b0efd9b4 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=79571191f2c526e18dc1257a3273a723… commit 79571191f2c526e18dc1257a3273a7235582d2a6 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ed3d6a6020fee411cca3cb7564a4b0cb… commit ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9f2e178f07b7d15733e862fca7c140b1… commit 9f2e178f07b7d15733e862fca7c140b1475899ee Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 18 12:28:21 2014 +0100 sgsn: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=847bf670e354fbd11bedbadf63deb057… commit 847bf670e354fbd11bedbadf63deb0577a0a380b Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Dec 15 10:16:02 2014 +0100 sgsn/doc: Add IPA default parameters This commit adds the default protocol identifiers that should be used for GSUP by the IPA protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=62068f8848f5c851a06053265b311dca… commit 62068f8848f5c851a06053265b311dca9042b103 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 12 15:01:37 2014 +0100 gprs: Add subscriber functions to create/handle GSUP messages This patch extends gprs_subscr_query_auth_info and gprs_subscr_location_update to create GSUP messages with the help of a static gprs_subscr_tx_gsup_message function. A corresponding gprs_subscr_rx_gsup_message is added which takes a messages, gets the subscr, and updates it accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2ad5544bee5062301797a86a6adb4451… commit 2ad5544bee5062301797a86a6adb44513abe27d2 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 11 16:54:14 2014 +0100 gprs: Add encoder/decoder for the Subscriber Update Protocol This patch adds functions to encode and decode GSUP messages. This does not include the layer 1 framing (IPA). The messages so far supported are: send_auth_info_*, update_location_*, location_cancellation_*. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5636470b9fa12827e190f3f38386f282… commit 5636470b9fa12827e190f3f38386f2824edfcf61 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 11 15:14:14 2014 +0100 sgsn/doc: Add protocol specification for remote subscriber update This is the first version of the specification for the GPRS Subscriber Update Protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4e8a698c1173d71f9e0ee6eef182f588… commit 4e8a698c1173d71f9e0ee6eef182f5884c181493 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Jan 5 09:43:51 2015 +0100 sgsn: Fix VTY command error handling (Coverity) Currently the result of the osmo_hexparse function in update_subscr_insert_auth_triplet is not handled correctly. There is a misplaced leading exclamation mark in a few conditional expressions. This effectively disables the error checks, as it is noticed by Coverity ("Missing parentheses" followed by "Logically dead code"). This patch removes the exclamation marks. Fixes: Coverity CID 1260435 and CID 1260434 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/abis_rsl.c | 4 ++-- openbsc/src/libmsc/sms_queue.c | 2 +- openbsc/src/utils/meas_pcap2db.c | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)