6 Apr
2016
6 Apr
'16
9:23 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via adb86759daa80a484eef4b5a24bc0ce0de0a0763 (commit)
via 2826df56b2af5a6a0f20e5a9bcf1d50a1130f0ba (commit)
via de392254ff05a5304ef0bbd351314d74b2ffd1e3 (commit)
from 7dd2eed6d3426ce27dc168e46a4db8b705608de4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=adb86759daa80a484eef4b5a24bc0ce0…
commit adb86759daa80a484eef4b5a24bc0ce0de0a0763
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Apr 1 20:31:11 2016 +0200
db: If creating a subscriber in the db fails, return NULL
We should not return a subscriber in case it was not written to
the database. Instead free the memory allocated and return NULL.
Callers in gsm_04_08.c are prepared to have the creation fail.
Related: OS Issue #1657
http://cgit.osmocom.org/openbsc/commit/?id=2826df56b2af5a6a0f20e5a9bcf1d50a…
commit 2826df56b2af5a6a0f20e5a9bcf1d50a1130f0ba
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Apr 1 20:21:03 2016 +0200
subscr: Make db_create_subscriber fail on duplicates
The issue of db_create_subscriber updating an already existing subscr
is that the same subscriber will then have two entries in the active
subscribers list. In general this will break assumptions that a subscr
can be compared by comparing the pointer.
In the case of the VTY this was not an issue as the created subscr
was immediately destroyed again but it is better to avoid this problem.
Change the VTY command to find the subscriber and then call sync to
have the updated time set. The side-effect is we will now have two
queries for the subscriber. Once through subscr_get_by_imsi and once
through db_create_subscriber.
Change the db_create_subscriber to fail if a subscriber already exists,
and add a testcase for this behavior and do not updated the 'updated'
timestamp of an already existing subscriber.
Add a testcase for this behavior.
Related: OS Issue #1657
http://cgit.osmocom.org/openbsc/commit/?id=de392254ff05a5304ef0bbd351314d74…
commit de392254ff05a5304ef0bbd351314d74b2ffd1e3
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Apr 1 19:44:00 2016 +0200
subscr: Add testcase creating an already created subscriber
Add testcase to issue the subscriber create twice. db_create_subscriber
in db.c will first try to find the subscriber and if it exists, it will
update the "updated" column in the database.
Related: OS Issue #1657
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libmsc/db.c | 15 ++++++-------
openbsc/src/libmsc/vty_interface_layer3.c | 16 +++++++++-----
openbsc/tests/db/db_test.c | 6 +++++-
openbsc/tests/vty_test_runner.py | 36 +++++++++++++++++++++++++++++++
4 files changed, 58 insertions(+), 15 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)