libosmocore.git branch master updated. 0.10.2-27-gfe1ed398

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via fe1ed39846c6537ebfe19d22500ee2e38587c143 (commit) via e750980d6c89cf7052daa62745366a743badd384 (commit) via 85f5a2cd9c46ffd165f9244b4e219bfc03aa5e0e (commit) via cd325efae564384c74b4af6163303ddc81c7a3c1 (commit) via 0128c78ffe25196f53fbbc0884a9c4587f493224 (commit) via 9541a683780d23b260c5c0f6b9a9572a7ac16a66 (commit) via 568f8e20175a21da4e4537a2f5a4f7fedec8c6d6 (commit) from 10ee73a7b39b2867fde2a827b199f6264149c75c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=fe1ed39846c6537ebfe19d22500e… commit fe1ed39846c6537ebfe19d22500ee2e38587c143 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Fri Nov 17 00:15:44 2017 +0100 sercomm_test: sanitize: fix msgb mem leak This should fix the last current remaining sanitizer build failure in libosmocore regression tests. Helps fix sanitizer build on debian 9. Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043 http://cgit.osmocom.org/libosmocore/commit/?id=e750980d6c89cf7052daa6274536… commit e750980d6c89cf7052daa62745366a743badd384 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 23:34:33 2017 +0100 tlv_put: guard against NULL val and 0 len For example encode_auth_info() from gsup.c calls msgb_tlv_put(msg, iei, 0, NULL) to put a tag and len with content data following later. However, this would cause a memcpy() from a NULL pointer, in tlv_put(). Allow passing NULL and len = 0 for cases like the above: If val is NULL, use memset(0) instead of memcpy(). If len is zero, do not copy nor memset anything. Hence make tlv_put() behave in a well-defined and valid way for any and all input args; no negative fallout is possible from this patch. Add proper API doc comment. Fixes a sanitizer build failure in gsup_test: ../../../../src/libosmocore/include/osmocom/gsm/tlv.h:99:2: runtime error: null pointer passed as argument 2, which is declared to never be null Helps fix sanitizer build on debian 9. Change-Id: I13dce9cd1228817890d3e81edeeb660c893c1d64 http://cgit.osmocom.org/libosmocore/commit/?id=85f5a2cd9c46ffd165f9244b4e21… commit 85f5a2cd9c46ffd165f9244b4e219bfc03aa5e0e Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:31:57 2017 +0100 bssgp_fc_test: sanitize: free fc struct when done Helps fix sanitizer build on debian 9. Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181 http://cgit.osmocom.org/libosmocore/commit/?id=cd325efae564384c74b4af616330… commit cd325efae564384c74b4af6163303ddc81c7a3c1 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate). Callers could theoretically catch the -ENOSPC return value and discard the msgb. However, in other code paths, a callback's return value is returned, which is expected to free the msgb, so such callback would have to never return -ENOSPC when it freed the msgb. Much simpler semantics would be to free the msgb in every code path, no matter which kind of error occurred. Who is currently calling bssgp_fc_in and how do they handle the return value? - bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer build failure if the queue is full). - fc_timer_cb() ignores the return value. - bssgp_tx_dl_ud() returns the bssgp_fc_in() rc. - which is returned by a cascade of functions leading up to being returned, for example, by gprs_llgmm_reset(), which is usually called with ignored return code. At this point it is already fairly clear that bssgp_fc_in() should always free the msgb, since the callers don't seem to distinguish even between error or success, let alone between -ENOSPC or other errors. bssgp_fc_test: assert that no msgbs remain unfreed after the tests. Adjust expected results. Helps fix sanitizer build on debian 9. Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df http://cgit.osmocom.org/libosmocore/commit/?id=0128c78ffe25196f53fbbc0884a9… commit 0128c78ffe25196f53fbbc0884a9c4587f493224 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:32:36 2017 +0100 bssgp_fc_test: sanitizer: free msgb context when done Print remaining msgbs when done, then free the entire tall_msgb_context. To be able to do that, call msgb_talloc_ctx_init() and use its return value. A subsequent patch will fix a known mem leak and add assertions for 0b in 1 blocks remaining in the tall_msgb_context. Helps fix sanitizer build on debian 9. Change-Id: I67d347ab2642b0bfc27b21b44231a7f3146ff641 http://cgit.osmocom.org/libosmocore/commit/?id=9541a683780d23b260c5c0f6b9a9… commit 9541a683780d23b260c5c0f6b9a9572a7ac16a66 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:55:02 2017 +0100 bssgp_fc_test: clarify by outputting ok / failure messages The test fills up the queue / sends too large PDUs on purpose. Make that obvious by outputting returned errors in the expected output. Cosmetic: - fc_in()'s return value is ignored, hence don't return anything. - add comment. Change-Id: I57d6fce2515a65f6dd037e75af5397079215cb46 http://cgit.osmocom.org/libosmocore/commit/?id=568f8e20175a21da4e4537a2f5a4… commit 568f8e20175a21da4e4537a2f5a4f7fedec8c6d6 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Thu Nov 16 22:29:38 2017 +0100 bssgp_fc_test: remove rounding to deciseconds Ever since this test was changed to use osmo_gettimeofday_override, the times it sees are exact every time and don't need rounding to pass the expected output. Change-Id: I4a9a5d31fc02eb55caf7ba9c141426d8115bb740 ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/tlv.h | 15 ++++++-- src/gb/gprs_bssgp.c | 6 +++- tests/gb/bssgp_fc_test.c | 43 ++++++++++++++++------- tests/gb/bssgp_fc_tests.ok | 84 ++++++++++++++++++++++++++++++++++++++++++++ tests/sercomm/sercomm_test.c | 1 + 5 files changed, 133 insertions(+), 16 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications