2 Sep
2016
2 Sep
'16
4:17 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via bf6bae2b2363a182bb1b95574c2922bf4257c4d9 (commit)
from 8a148613b4c93f5a25dd2a2d9929de75882adbc5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=bf6bae2b2363a182bb1b95574c2922b…
commit bf6bae2b2363a182bb1b95574c2922bf4257c4d9
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Aug 22 18:23:03 2016 +0200
common/rsl: move decision whether to chan act ack/nack to common function
Prepare for a dyn TS patch that needs to call rsl_tx_chan_act_ack() directly
without the rel_act_kind decision.
Add function rsl_tx_chan_act_acknack() to wrap rsl_tx_chan_act_ack() and
rsl_tx_chan_act_nack(). Move the decision whether to drop the ack/nack, based
on lchan->rel_act_kind, to the new function, losing some code dup.
Change all callers to use the new function; drop the two older ones from rsl.h
and make them static.
Note: for nack, the exception for dyn TS in PDCH mode was missing
(rsl_tx_chan_act_nack() had only the rel_act_kind != LCHAN_REL_ACT_RSL
condition, but should also have had the dyn TS exception as in
rsl_tx_chan_act_ack()). I already know that this exception will again be
removed in an upcoming commit, but for patch readability it logically makes
sense to add it here. To easily include the nack case, drop the check for which
pchan the dyn TS is operating as, because a rel_act_kind == LCHAN_REL_ACT_PCU
implies that it is either already in or trying to become PDCH mode.
Change-Id: I57ba60c670730c6d7877a6a9b96ece0a7679a0bb
-----------------------------------------------------------------------
Summary of changes:
include/osmo-bts/rsl.h | 3 +--
src/common/l1sap.c | 5 +----
src/common/rsl.c | 58 ++++++++++++++++++++++++++------------------------
3 files changed, 32 insertions(+), 34 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)