osmo-pcu.git branch jerlbeck/wip/fix-pacch-alloc created. 0.2-596-g88782dd

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip/fix-pacch-alloc has been created at 88782ddb8f2cfd3f00ee58672e2ba448a58f589c (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=88782ddb8f2cfd3f00ee58672e2ba44… commit 88782ddb8f2cfd3f00ee58672e2ba448a58f589c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Aug 20 11:48:30 2015 +0200 WIP tests and fixes TODO TODO: - check whether the semantics have not changed an put it away http://cgit.osmocom.org/osmo-pcu/commit/?id=31af0ad11b3486d8f989a43479c7aec… commit 31af0ad11b3486d8f989a43479c7aecdc7a9254a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Aug 26 11:19:49 2015 +0200 l1: Add prim logging (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=c8cbfc2c9800929a46ffa71e3bd0f34… commit c8cbfc2c9800929a46ffa71e3bd0f34aa9b42f33 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 1 11:38:40 2015 +0200 bts: Start a DL TBF if needed after establishment of an UL TBF Currently an existing DL TBF can get lost in the process of establishing an UL TBF via RACH. This can lead to stalled connections until the network sends more LLC frames. This commit adds a check for a non-empty LLC queue after the UL TBF has been established to rcv_control_ack (GPRS_RLCMAC_UL_ASS_WAIT_ACK path) to eventually establish a new DL TBF on the UL TBF's PACCH. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ae0a799f4472a75912b444cc2f09361… commit ae0a799f4472a75912b444cc2f09361aaea27963 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 1 11:28:25 2015 +0200 bts: Release DL TBF instead of killing in rcv_resource_request Currently an existing DL TBF is freed immediately, when a resource request is received. This makes sense since the MS might have dropped it when switching to the PDCH signaled via the AGCH for the SBA. But if the TBF still is assumed to exist on the MS side, there might be TFI collisions if the old TBF object is not kept to block its TFI for some time. This commit changes rcv_resource_request to call release() instead of tbf_free() on the DL TBF object (if it exists). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=91ff7d1864f0248ab5f45047069c09d… commit 91ff7d1864f0248ab5f45047069c09d7843212ca Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 1 11:20:29 2015 +0200 tbf: Refactor reuse_tbf into releasing and DL TBF establishment Currently reuse_tbf (partly) resets the old DL TBF and uses its PACCH to establish a new DL TBF. The method can not be used with UL TBFs. This commit replaces the reuse_tbf method into a gprs_rlcmac_dl_tbf:release method which triggers the TBF's timer based deletion (so that the TFI is still reserved for some time) and a gprs_rlcmac_tbf::establish_dl_tbf_on_pacch which can establish DL TBFs on existing PACCHs of either DL or UL TBFs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9659d593073dfb6711f2ed9ad7bee4c… commit 9659d593073dfb6711f2ed9ad7bee4ca454db784 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 1 11:06:14 2015 +0200 tbf: Keep the old MS object alive in extract_tlli Currently when a second MS object has been created for an MS, because the TLLI was not known yet, the will be detected in gprs_rlcmac_tbf::extract_tlli and the two objects will be merged by update_ms. But when the dl_tbf is moved from the old to the new (second) MS object, the old MS object can get idle and be removed before the object are merged. This can cause LLC frame loss when the MS object is deleted immediately after getting idle (no timeout configured). This commit adds a guard to keep the MS object until extract_tlli has been executed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=cf6ae9d12f9bf406a8f164f8109410d… commit cf6ae9d12f9bf406a8f164f8109410d01328d913 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Aug 31 14:32:05 2015 +0200 Revert "tbf: Do not kill DL TBF on Packet Resource Request" This reverts commit e91bd3babd5c04a154f296607b401a5050dcba31. That commit seems to cause hanging DL TBFs when there was a RACH based UL TBF establishment while it that TBF is active. This could be caused by the use of a different PDCH for the SBA. Conflicts: tests/tbf/TbfTest.cpp tests/tbf/TbfTest.err ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT