24 Oct
2017
24 Oct
'17
10:22 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 0b3db5039d25fca3d15ec3375ede77161257db4a (commit)
via 9818664315a514b187719792d77723ad9e18dcdf (commit)
from ea66852a62319901dc198ea1dc8cbfbf77217347 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=0b3db5039d25fca3d15ec3375ede…
commit 0b3db5039d25fca3d15ec3375ede77161257db4a
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Oct 18 13:48:10 2017 +0200
Replace bitvec_set_uint() with bitvec_set_u64()
Old bitvec_set_uint() uses "unsigned int" as input parameter which
length is not guaranteed. It does not allow to specify which bit_value
to set and does not check for incorrect length. Overall this makes it
harder to re-use and more error-prone.
Let's replace it with extended implementation which uses fixed type
length parameters and extra checks. The additional parameter allows
caller to explicitly indicate the need to use L/H instead of 0/1 for bit
vector elements. It's necessary to properly encode some of the messages
from 3GPP TS 44.018, for example §10.5.2.16 IA Rest Octets.
The old function is left for backward compatibility as a tiny wrapper
around new function and will be deprecated in follow-up patches.
Change-Id: I1b670dacb55fb3063271d045f9faa10fccba10a6
Related: OS#1526
http://cgit.osmocom.org/libosmocore/commit/?id=9818664315a514b187719792d777…
commit 9818664315a514b187719792d77723ad9e18dcdf
Author: Max <msuraev(a)sysmocom.de>
Date: Wed Oct 18 13:14:49 2017 +0200
Add tests for bitvec_write_field()
This function is actively used by OsmoPCU but have not been covered by
tests so far. The test code is based on
Minh-Quang Nguyen <minh-quang.nguyen(a)nutaq.com> submission with some
modifications.
The test's FIXME will be addressed in follow-up patches.
Change-Id: I2ee544256b8675bc62a42493aab66a8eeee54f90
Related: OS#1526
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/core/bitvec.h | 2 +
src/bitvec.c | 35 ++++++---
tests/Makefile.am | 6 +-
tests/bits/bitfield_test.c | 164 ++++++++++++++++++++++++++++++++++++++++++
tests/bits/bitfield_test.ok | 36 ++++++++++
tests/testsuite.at | 6 ++
6 files changed, 239 insertions(+), 10 deletions(-)
create mode 100644 tests/bits/bitfield_test.c
create mode 100644 tests/bits/bitfield_test.ok
hooks/post-receive
--
An utility library for Open Source Mobile Communications