12 Mar
2015
12 Mar
'15
6:29 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via 7c44415d785422b8f7e02059420e7c6feb89f4e9 (commit)
from 0eabffdc35bef3bb678014d4c377ab8a2ac5951f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=7c44415d785422b8f7e02059420e7c6…
commit 7c44415d785422b8f7e02059420e7c6feb89f4e9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Mar 12 12:08:54 2015 +0100
tbf: Fix scheduling for DL Ack/Nack request
Currently the DL Ack/Nack is not requested, if the last chunk of the
final LLC frame in the TBF fits exactly into the remaining space of
the RLC block. It is also not requested, if the RRBP flag cannot be
set due to scheduling issues (single block allocation, polling
already pending for this TBF, ...). So up to POLL_ACK_AFTER_FRAMES
(20) RLC data blocks will have to be resent, before requesting the
Ack/Nack will be retried.
This commit removes the first_fin_ack parameter of
create_dl_acked_block entirely and adds a request_dl_ack() method
that should be called, when the TBF's state changes to FINISHED. This
request will be reset, when the block has been scheduled
successfully. Since the first_fin_ack hasn't been set if chunk ==
space, calling request_dl_ack() on both places in create_new_bsn()
when the state is changed to FINISHED will also fix the first issue
described above.
Note that DL scheduling might not be fair concerning access to
first_ts when multiple TS are used for a TBF. In theory, a TBF might
never get access to first_ts in the worst case.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/tbf.h | 4 +++-
src/tbf_dl.cpp | 31 +++++++++++++++++++------------
2 files changed, 22 insertions(+), 13 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT