17 Feb
2018
17 Feb
'18
2:09 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 4a8a9f4210b01c3b8b75eb3b984c9127e90d8c54 (commit)
via a4952aa43625140ec7e9f2e892d938d16ee7ae88 (commit)
via 90539ac30b6201a93b7c4e5b9747e603e64565af (commit)
via c9a4ce600afc5a11f36c78302f017db9918b4c36 (commit)
from b0c43a606334cb6d0796e9fb102823ce040224f6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=4a8a9f4210b01c3b8b75eb3b984c…
commit 4a8a9f4210b01c3b8b75eb3b984c9127e90d8c54
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Feb 16 01:26:30 2018 +0100
memleak: _gsmtap_raw_output(): free msg in case of vsnprintf failure
Don't just return, free the allocated msg first.
Change-Id: I51431ae7baca33ce5bab085cc3efe25f1a10b6d1
http://cgit.osmocom.org/libosmocore/commit/?id=a4952aa43625140ec7e9f2e892d9…
commit a4952aa43625140ec7e9f2e892d938d16ee7ae88
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Feb 16 01:26:00 2018 +0100
memleak: fix all libosmocore callers of gsmtap_sendmsg() to free on failure
gsmtap_sendmsg() does not free the msgb if it returns a failure rc, so the
callers must check the rc and free the msg.
Change-Id: I7cf64ed9b14247298ed8b4ab8735627f8235a499
http://cgit.osmocom.org/libosmocore/commit/?id=90539ac30b6201a93b7c4e5b9747…
commit 90539ac30b6201a93b7c4e5b9747e603e64565af
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Feb 16 01:24:03 2018 +0100
memleak: gsmtap_sendmsg(): don't return 0 when no data was written
If less than the msgb size was written by write(), we want to return -EIO.
Hence do not return zero when write() wrote zero bytes, return -EIO in that
case as well.
Previously, if write() returned zero, gsmtap_sendmsg() would return zero
*without* freeing the msg, hence neither would the (ideal) caller. So this
fixes a corner-case memleak.
Change-Id: I099ae1c663c018da5db884f7e9d52c45af3ed817
http://cgit.osmocom.org/libosmocore/commit/?id=c9a4ce600afc5a11f36c78302f01…
commit c9a4ce600afc5a11f36c78302f017db9918b4c36
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Fri Feb 16 01:23:29 2018 +0100
gsmtap_sendmsg(): clarify API doc concerning msgb ownership
Not freeing on error does enable callers to try to re-send as well, so it is a
kind of useful feature, even though I find it likely for callers to either
forget about freeing the msg on error or double-free by accident...
I considered changing gsmtap_sendmsg() to always free, but since it is public
API, I chose to keep and document its current behavior properly instead. We
don't know what callers may exist out there.
Change-Id: Id3266ce36442024f16eaf6afa3f516d201930c41
-----------------------------------------------------------------------
Summary of changes:
src/gsmtap_util.c | 11 +++++++++--
src/logging_gsmtap.c | 8 ++++++--
2 files changed, 15 insertions(+), 4 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications