openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-859-g1371326

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 0b1caf7da499d1cbce53795cf9deee4643636327 (commit) discards 7cfbae6fc6168148f937cf781bed962ed8ec1a32 (commit) discards c6d308f59292adc572b680065192e9ed55ea19e9 (commit) discards ba59d61d98064219b7618ffa254027b009201d80 (commit) discards 7c2a048c2be60ea3e30bc755939503299b720904 (commit) via 13713264aa539ce1343ad6c7dd0f8308b242a892 (commit) via f30d7455f17f8488b03d8727f33dfaa39e812107 (commit) via 917d8e33aa0f6f14d459124ab63961a1876b7379 (commit) via b0f9aae0e08b65ce2636218379853f88f33134fa (commit) via 033dacd0be40045485ce85fe6d736dad56277b97 (commit) via df41492476d1134f907c9eeaa8da592223012e30 (commit) via d255302af01073748213504bd65692941b30c01c (commit) via 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 (commit) via 67014fd5657394534326c99554f89ec85970e509 (commit) via e8978ac39c5e96877960f0df07644efc8a0bc321 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (0b1caf7da499d1cbce53795cf9deee4643636327) \ N -- N -- N (13713264aa539ce1343ad6c7dd0f8308b242a892) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=13713264aa539ce1343ad6c7dd0f8308… commit 13713264aa539ce1343ad6c7dd0f8308b242a892 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f30d7455f17f8488b03d8727f33dfaa3… commit f30d7455f17f8488b03d8727f33dfaa39e812107 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=917d8e33aa0f6f14d459124ab63961a1… commit 917d8e33aa0f6f14d459124ab63961a1876b7379 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b0f9aae0e08b65ce2636218379853f88… commit b0f9aae0e08b65ce2636218379853f88f33134fa Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=033dacd0be40045485ce85fe6d736dad… commit 033dacd0be40045485ce85fe6d736dad56277b97 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 5 16:20:47 2015 +0100 gprs: Pass GMM causes related to the MSC connection Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and CONGESTION are silently dropped to force the MS to continue. On the other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5, require the MS to retry the attachment procedure for cause codes above 15 instead of disabling GPRS. All of the mentioned GMM causes have codes above 15, so using a REJECT message including the cause code is a better choice. This way, the retry algorithm based on T3311 (15s, 5 times) and T3302 (default 12min) could be used. This patch modifies gprs_subscr_handle_gsup_auth_err and gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access has beed denied, except that the corresponding subscriber's information fields are not cleared. This has been successfully tested which an iphone which enters a retry loop as it is being described in the specification. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=df41492476d1134f907c9eeaa8da5922… commit df41492476d1134f907c9eeaa8da592223012e30 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Use LOGMMCTX for logging To unify the layout of the logging messages, this patch replaces some calls to LOGP by calls to LOGMMCTXP. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d255302af01073748213504bd6569294… commit d255302af01073748213504bd65692941b30c01c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 5 18:57:32 2015 +0100 gprs: Let GSUP parser functions return GMM causes on errors Currently the GSUP message handling function in gprs_subscriber.c and the functions in gprs_gsup_messages.c are not consistent with respect to the return codes if an error happens. Albeit all error return codes are negative, the semantics of the absolute value are not clearly defined. In addition, some return codes are not passed to the calling function. This path changes these functions to always return a negated GMM cause value in case of errors. Return values of called parser functions are not longer ignored. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9230f1a7537821dff9b5cd6f65fd77cf… commit 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 5 18:38:41 2015 +0100 gprs: Use the cause value in GSUP error messages Currently always a cause with the meaning of 'access denied' is assumed. gprs_subscr_handle_gsup_auth_err just clears the auth triplets and the authorized flag before calling the update function. gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag and calls the update function. This means, that an MS will not retry to attach even on temporary network errors. This patch changes these functions to use the GSUP error cause value to decide, whether to clear the corresponding subscriber fields, to just continue with the corresponding update function, or to log, ignore and not pass the cause to the MS in case the error is directly related to the GSUP protocol. The subscriber's error_cause field is updated, if the update function is going to be called. The error_cause fielt is reset on non-error GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=67014fd5657394534326c99554f89ec8… commit 67014fd5657394534326c99554f89ec85970e509 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 5 17:51:17 2015 +0100 gprs: Pass subscriber error causes to the GMM layer This patch extends gsm0408_gprs_access_denied and gsm0408_gprs_access_cancelled to accept GMM cause codes. These are then passed to the MS, unless gsm0408_gprs_access_cancelled is called with cause 0 (no error -> updateProcedure). Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if the cause is not set, and the subscriber's error_cause is never set (and thus always 0), the SGSN's behaviour does not change with this patch. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e8978ac39c5e96877960f0df07644efc… commit e8978ac39c5e96877960f0df07644efc8a0bc321 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 5 17:30:02 2015 +0100 gprs: Move protocol value_strings to gsm_04_08_gprs.c Currently the mapping between GSM 04.08 (GPRS) protocol specific numbers and their textual description was put into gprs_gmm.c and not exported. This commit moves the mappings to a new file gsm_04_08_gprs.c, renames some of them, and exports them via gsm_04_08_gprs.h. The following identifiers are renamed to match the corresponding type names: - gmm_cause_names -> gsm48_gmm_cause_names - gsm_cause_names -> gsm48_gsm_cause_names Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_04_08_gprs.h | 11 +++ openbsc/src/gprs/Makefile.am | 3 +- openbsc/src/gprs/gprs_gmm.c | 134 +++++------------------------ openbsc/src/gprs/gprs_gsup_messages.c | 4 +- openbsc/src/gprs/gprs_subscriber.c | 20 ++++- openbsc/src/gprs/gsm_04_08_gprs.c | 141 +++++++++++++++++++++++++++++++ openbsc/tests/sgsn/Makefile.am | 1 + 7 files changed, 192 insertions(+), 122 deletions(-) create mode 100644 openbsc/src/gprs/gsm_04_08_gprs.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)