14 Sep
2016
14 Sep
'16
3:26 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via 024152683646f1b68c85de74f783b81db51d16b5 (commit)
via 9f5f008aedc910ff0ce18bf3f92b9b74f0438bf8 (commit)
from 8d2d9e89850e961affc998e984c3fc6ac7b8f7b1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=024152683646f1b68c85de74f783b81…
commit 024152683646f1b68c85de74f783b81db51d16b5
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Sep 2 02:15:26 2016 +0200
Fix CSN1 decoding: CSN_LEFT_ALIGNED_VAR_BMP bounds
Fix attempted read past vector boundaries in case of a starting bit offset !=
0, so that the last amount of bits read should be < 8. In the case of
CSN_LEFT_ALIGNED_VAR_BMP, the mod-8 calculation was flawed, and in the final
step, 8 bits were read instead of the remainder < 8. This lead to -EINVAL being
returned by bitvec_get_bit_pos() and bogus resulting data.
Instead, read 8 bits only as long as at least 8 bits remain, and read any
remaining bits < 8 in a final step. Drop unneeded nB1 variable and an obvious
comment.
Adjust the unit test assertion in testCsnLeftAlignedVarBmpBounds() in
RLCMACTest.cpp.
Based on a fix by Aravind Sirsikar <Arvind.Sirsikar(a)radisys.com>om>, but
implemented differently.
Related: OS#1805
Change-Id: I490498c8da6b531f54acb673379379f7b10907c0
http://cgit.osmocom.org/osmo-pcu/commit/?id=9f5f008aedc910ff0ce18bf3f92b9b7…
commit 9f5f008aedc910ff0ce18bf3f92b9b74f0438bf8
Author: Aravind Sirsikar <Arvind.Sirsikar(a)radisys.com>
Date: Tue Aug 30 13:20:23 2016 +0530
CSN1 decoding: add test to show bug in CSN_LEFT_ALIGNED_VAR_BMP
CSN1 decoding currently contains an attempted read past vector boundaries in
case of a starting bit offset != 0, so that the last amount of bits read should
be < 8. In the case of CSN_LEFT_ALIGNED_VAR_BMP, the mod-8 calculation is
flawed, and in what should be the final step of reading n < 8 bits, 8 bits are
read instead of n (with an extraneous read of n bits following after that).
This leads to -EINVAL being returned by bitvec_get_bit_pos() and bogus
resulting data.
Add testCsnLeftAlignedVarBmpBounds() in RLCMACTest.cpp to show and expect this
bug. The test's expectation shall be corrected along with the bug fix in a
subsequent commit.
Related: OS#1805
Tweaked-by: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Change-Id: I4641f5d1d49f66cb1a5cd813befb3a2a266001b0
-----------------------------------------------------------------------
Summary of changes:
src/csn1.cpp | 11 +++++------
tests/rlcmac/RLCMACTest.cpp | 18 +++++++++++++++++-
2 files changed, 22 insertions(+), 7 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT