13 Aug
2015
13 Aug
'15
7:52 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, je/master has been updated
discards 81f2d449be7ab8c0d4b955b6c24a8cf646278ed3 (commit)
via 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (81f2d449be7ab8c0d4b955b6c24a8cf646278ed3)
\
N -- N -- N (04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=04e72d34f5cf885a4d6e2e6b2f2575a…
commit 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 13 18:36:56 2015 +0200
tbf: Always start T3193 when changing state to GPRS_RLCMAC_WAIT_RELEASE
Currently when receiving a PACKET DL ACK/NACK message with the Final
Ack Indicator bit set, the TBF's state is set to
GPRS_RLCMAC_WAIT_RELEASE but T3193 is only started when the LLC queue is
empty. Otherwise the reuse_tbf() method is called to establish a new
DL TBF. In that case, the timer is not started. This will leave the
current TBF without a timer so it is potentially not released later
on.
This is recognisable by sticky entries in the output of the
'show tbf all' command and possibly allocation failures if there are
too many of them.
This commit changes the code to always start T3193 to make sure, that
a timer is always active when the the state is set to
GPRS_RLCMAC_WAIT_RELEASE.
Note that TS 44.060, 9.3.2.6 requests to release the 'old' TBF
immediately in some cases, which is not implemented by this change.
This will lead to a longer reservation period of the TFI only, which
is safer than reassigning it too early.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
tests/tbf/TbfTest.err | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
hooks/post-receive
--
UNNAMED PROJECT