17 Dec
2015
17 Dec
'15
2:22 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, zecke/release/0.7-dev has been updated
via fe2aa68db819d73aec1e98eaa6054d01efb22bd1 (commit)
from 52354dd78567e898d5dd114380a17990ce1608f8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=fe2aa68db819d73aec1e98eaa605…
commit fe2aa68db819d73aec1e98eaa6054d01efb22bd1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 17 13:22:36 2015 +0100
ns: Force a defined state when sending NS RESET
Currently the state is assumed to remain the same while the reset
procedure is active. While this works correctly in general, a single
unexpected BLOCK_ACK or UNBLOCK_ACK can change the state but will not
stop the reset procedure. The leads to repeated RESET messages, where
the corresponding RESET_ACK is ignored. This is a stable state which
can only be left by manual intervention or by reception of a RESET
message from the peer.
This commit changes the RESET timeout handler to set the state to
BLOCKED/RESET when sending the new NS RESET message.
Note that this should ensure a clean restart even if the state has been
screwed up. It does not fix the handling of BLOCK_ACK or UNBLOCK_ACK
in abnormal cases.
Addresses:
gprs_ns.c:349 NSEI=8895 Tx NS RESET (NSVCI=8895, cause=O&M intervention)
gprs_ns.c:878 NSVCI=8895 Rx NS RESET ACK (NSEI=8895, NSVCI=8895)
gprs_ns.c:887 NS RESET ACK Discarding unexpected message for NS-VCI 8895 from SGSN
NSEI=8895
Ticket: OW#1551
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/gb/gprs_ns.c | 6 ++++
tests/gb/gprs_ns_test.c | 18 +++++++++++
tests/gb/gprs_ns_test.ok | 84 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 108 insertions(+)
hooks/post-receive
--
An utility library for Open Source Mobile Communications