23 Feb
2018
23 Feb
'18
12:11 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 218c4de84f6d94a882e3a945332f53732bf2e134 (commit)
from 92decf2aa916353564a9dabe6871ab00e0f06a80 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=218c4de84f6d94a882e3a945332f…
commit 218c4de84f6d94a882e3a945332f53732bf2e134
Author: Stefan Sperling <ssperling(a)sysmocom.de>
Date: Thu Feb 22 18:16:29 2018 +0100
ensure that osmo_fsm vty commands are only installed once
There is a desire to install osmo_fsm vty commands automatically in
a library context, rather than requiring every application which
directly or indirectly uses osmo_fsm to run osmo_fsm_vty_add_cmd().
However, the function install_element_ve() asserts that elements
about to be installed have not already been installed.
This means we cannot shift responsibility into a library context
without first making sure that osmo_fsm commands are only installed
once per combined application+library context, because applications
won't know which commands any of its libraries has already installed.
A simple solution is to use a global flag which is checked by
osmo_fsm_vty_add_cmd() before installing osmo_fsm commands, and
is set once the commands have been installed. This way, no harm
is done if osmo_fsm_vty_add_cmd() is called multiple times.
Change-Id: I10b0b1c1c1bf44c3b8eafc465c1ee06ea2590682
Related: OS#2967
-----------------------------------------------------------------------
Summary of changes:
src/vty/fsm_vty.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
hooks/post-receive
--
An utility library for Open Source Mobile Communications