openbsc.git branch neels/auth_failed created. 0.15.0-319-gf5e0c6c

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/auth_failed has been created at f5e0c6c9f1a82a51d2e9e470bb3db1f05e7ef2a1 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=f5e0c6c9f1a82a51d2e9e470bb3db1f0… commit f5e0c6c9f1a82a51d2e9e470bb3db1f05e7ef2a1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 7 17:19:19 2016 +0100 Remove unused auth code and add comment The GSM_SECURITY_AUTH_FAILED path is never invoked by the gsm48_secure_channel() function as it is today. Keep the GSM_SECURITY_AUTH_FAILED case, since the upcoming Iu auth will use it. But rather return an error, which will lead to a timeout, and a LU Reject will be sent. If the GSM_SECURITY_AUTH_FAILED code path removed by this patch were invoked, it would never send out a LU Reject, since a call to release_loc_updating_req() only releases the connection. To reject, a call to gsm0408_loc_upd_rej() would be necessary, as seen in loc_upd_rej_cb(). Arguably, it may be desirable to omit a LU Reject in case of an auth failure, to be less friendly to auth attackers? So far that was not the case (since that code path was never used), so not adding this behavior now. Change-Id: I44aac24811785c4b6f95f830b8b35d5fbe644e0f ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)