18 Dec
2017
18 Dec
'17
12:29 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Open Source GSM Base Band stack".
The branch, fixeria/trx has been updated
via feec102aea039c4091fa9cf6075d45fd23448bd3 (commit)
via 44838f79a2408feca664980d4b42a5c86b17db07 (commit)
via 255f25ef25c5ce1deefcfbe63844bc47d524c377 (commit)
via 32c2a1d74c1bb3f1cfa9a56b2e15b93fa321f942 (commit)
via a403215beab8f92f7bd90fe8f80535bd61841b30 (commit)
via 15d512d301545e10f69ade0562d5ea86832066b4 (commit)
via e17bb11c3b29919799b3637dece1c7c0273af304 (commit)
from 60ff614446fedc7b12767d9520abfc529a65fc7e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmocom-bb/commit/?id=feec102aea039c4091fa9cf6075d4…
commit feec102aea039c4091fa9cf6075d45fd23448bd3
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Dec 18 05:47:28 2017 +0700
trxcon/scheduler: implement A5/X ciphering support
This change implements the A5/X ciphering support transparently
for the logical channel handlers. In other words, a DL burst is
deciphered before being passed to a handler, and an UL burst is
ciphered before being sent to transceiver.
The implementation mostly relays on the libosmocore's A5 API.
Change-Id: Ib53418d8c0f394fdece09cf5cc240887cb0bb5af
http://cgit.osmocom.org/osmocom-bb/commit/?id=44838f79a2408feca664980d4b42a…
commit 44838f79a2408feca664980d4b42a5c86b17db07
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Dec 18 05:45:27 2017 +0700
trxcon/scheduler: preprocess UL bursts before sending
Having a possibility to preprocess UL burst before sending to
transceiver is required for the further ciphering support
integration and probably some other tasks.
Change-Id: Ia6eead5d4f51d7c0bf277b9d5ebb0a74676df567
http://cgit.osmocom.org/osmocom-bb/commit/?id=255f25ef25c5ce1deefcfbe63844b…
commit 255f25ef25c5ce1deefcfbe63844bc47d524c377
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Sat Dec 16 17:52:31 2017 +0700
L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info
Previously, the L1CTL_CRYPTO_REQ message contained only a ciphering
algorithm and actual Kc key to be used. The key length was
calculated manually using the MSGB API.
Let's avoid manual calculations here, as it may cause unexpected
behavior if the message structure is changed. Also, let's fill
the UL header with minimal information about a channel, which
is going to be encrypted.
Change-Id: I1813a188e755141241273479b17896415abcc3f1
http://cgit.osmocom.org/osmocom-bb/commit/?id=32c2a1d74c1bb3f1cfa9a56b2e15b…
commit 32c2a1d74c1bb3f1cfa9a56b2e15b93fa321f942
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Dec 18 04:39:27 2017 +0700
trxcon/scheduler: prioritize FACCH correctly
Previously we used to compare two consecutive first primitives,
taken from a transmit queue. This approach may cause some delay,
which is critical for FACCH e.g. in case of handover.
Let's walk through a whole transmit queue to find a pair of
both FACCH frames, and only then decide what to do.
Change-Id: I925cca77bfaa255dd095bc882c901d41c9bc4633
http://cgit.osmocom.org/osmocom-bb/commit/?id=a403215beab8f92f7bd90fe8f8053…
commit a403215beab8f92f7bd90fe8f80535bd61841b30
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Dec 18 03:47:23 2017 +0700
trxcon/scheduler: move prim management outside lchan handlers
Previously, each lchan handler used to obtain and delete primitives
from a timeslot's tranmit queue itself. This approach entails many
potential problems and bugs:
- The lchan handlers shall not do that by definition, they
should encode and decode frames according to GSM 05.03.
- In some cases (e.g. TCH), a single transmit queue may contain
primitives of different types (e.g. TCH, FACCH and SACCH). At
the same time, the lchan handlers don't care and don't even
know about each other. So, this could cause an unexpected
behaviour in some cases.
This change separates all primitive management routines,
providing a new API for obtaining and dropping them.
"Write programs that do one thing and do it well."
Change-Id: I29503ece51903784bc53541015285234471c8d15
http://cgit.osmocom.org/osmocom-bb/commit/?id=15d512d301545e10f69ade0562d5e…
commit 15d512d301545e10f69ade0562d5ea86832066b4
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Dec 18 02:13:41 2017 +0700
trxcon/scheduler: separate primitive management code
It's good to write, keep and make the source code as much modular
as possible. So, Tte primitive management code was separated to
the 'sched_prim.c' and going to be extended in the near future.
Change-Id: Ifec8c9e4f2c95c72b00772688bcb5dc9c11d6de7
http://cgit.osmocom.org/osmocom-bb/commit/?id=e17bb11c3b29919799b3637dece1c…
commit e17bb11c3b29919799b3637dece1c7c0273af304
Author: Vadim Yanitskiy <axilirator(a)gmail.com>
Date: Mon Dec 18 01:23:03 2017 +0700
trxcon/scheduler: BUGFIX: distinguish between SACCH and FACCH
Both SACCH and FACCH messages have the same 23-byte length, both
are being queued together within a single transimt queue. So,
previously a SACCH frame could be picked by TCH burst handler,
and then sent as a FACCH frame. Let's fix this.
A FACCH primitive may have one of the TRXC_TCH* logical channel
types, while SACCH primitives have one of the TRXC_SACCH*.
Change-Id: Ia7090384f3ff74c9d94997265135acbceffa0ffe
-----------------------------------------------------------------------
Summary of changes:
include/l1ctl_proto.h | 1 +
src/host/layer23/include/osmocom/bb/common/l1ctl.h | 4 +-
src/host/layer23/src/common/l1ctl.c | 8 +-
src/host/layer23/src/mobile/gsm48_rr.c | 12 +-
src/host/trxcon/Makefile.am | 1 +
src/host/trxcon/l1ctl.c | 58 ++++-
src/host/trxcon/sched_lchan_common.c | 46 ----
src/host/trxcon/sched_lchan_rach.c | 25 +-
src/host/trxcon/sched_lchan_sch.c | 1 -
src/host/trxcon/sched_lchan_tchf.c | 58 ++---
src/host/trxcon/sched_lchan_xcch.c | 38 +---
src/host/trxcon/sched_prim.c | 251 +++++++++++++++++++++
src/host/trxcon/sched_trx.c | 206 +++++++++--------
src/host/trxcon/sched_trx.h | 18 +-
src/target/firmware/layer1/l23_api.c | 5 +-
15 files changed, 500 insertions(+), 232 deletions(-)
create mode 100644 src/host/trxcon/sched_prim.c
hooks/post-receive
--
The Open Source GSM Base Band stack