18 Oct
2016
18 Oct
'16
7:26 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via 4ea452689d545c455cf9c3ade87a3e2c86bf7771 (commit)
from e4727a3591c4c4d769d890806b159ade9af3f6aa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=4ea452689d545c455cf9c3ade87a3e2…
commit 4ea452689d545c455cf9c3ade87a3e2c86bf7771
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Jun 8 15:27:40 2016 +0200
Revert "tbf: Add state WAIT_ASSIGN"
This reverts commit f1a7b8fc6651f92a8b7f3f27b7ca05d07f4e44e0.
Conflicts:
tests/tbf/TbfTest.err
The commit broke GPRS service at least for osmo-bts-sysmo on a SysmoBTS 1002
with current master of osmo-bts (ef30f50d5d6d5f863fc147d05ccdceb89284934e).
The error observed is the following log output (was viewing both osmo-bts-sysmo
and osmo-pcu logs interleaved):
<0002> tbf.cpp:874 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=WAIT ASSIGN) T3169
timeout during transsmission
<0002> tbf.cpp:893 - Assignment was on CCCH
<0002> tbf.cpp:899 - No uplink data received yet
<0007> l1sap.c:904 RACH for packet access
<0001> pcu_l1_if.cpp:311 RACH request received: sapi=1 qta=0, ra=121, fn=13653
[repeat]
When removing this single commit from current osmo-pcu master, GPRS service
works well on SysmoBTS, with current osmo-bts master.
The TbfTest.err expected output needed adjustment after the revert.
Disclaimer: I am not aware of adverse effects this commit may have. I have no
idea what the WAIT_ASSIGN state is used for -- further review is required.
Change-Id: I1532f8e93194368cdc1e3846f82afa6d68cd5fbd
-----------------------------------------------------------------------
Summary of changes:
src/bts.cpp | 9 +-
src/tbf.cpp | 13 +--
src/tbf.h | 10 +-
tests/tbf/TbfTest.cpp | 2 +-
tests/tbf/TbfTest.err | 291 +++++++++++++++++++++-----------------------------
5 files changed, 134 insertions(+), 191 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT