8 Nov
2017
8 Nov
'17
5:17 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".
The branch, master has been updated
via 67ca5941407729f5a4b92ca43f7980c2b8080481 (commit)
via 12715e8e995b51e6d904a9dd8f4abf09fadc335c (commit)
from 8914a2f0fac5e0f9554076acd6af01f25675a7a3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmo-sccp/commit/?id=67ca5941407729f5a4b92ca43f7…
commit 67ca5941407729f5a4b92ca43f7980c2b8080481
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Nov 8 03:07:08 2017 +0100
sccp vty: be fatal for addressbook entry errors
So far, the config would log an error upon config parsing, and then continue to
use defaults, which is super easy to miss. On errors, return CMD_ERR_INCOMPLETE
to abort the program in a config parsing error.
Be fatal for re-using an already defined addressbook entry in another cs7
instance, and for having a too long addressbook entry name.
Though it is mixing in cosmetic changes, add "Error:" to the output and
arrange
the erratic name to the end of the message, as is customary for error messages.
Related: osmo-bsc Ia4e58902a2d3757b266cf35ac89f256cfb8f0eec
Change-Id: I2f71b9c4dd30f919d2054da81283dd7035f44f60
http://cgit.osmocom.org/libosmo-sccp/commit/?id=12715e8e995b51e6d904a9dd8f4…
commit 12715e8e995b51e6d904a9dd8f4abf09fadc335c
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Nov 8 02:27:36 2017 +0100
add osmo_sccp_inst_addr_name(), a variant of osmo_sccp_addr_name()
It can be cumbersome to derive the ss7 instance needed to pass to
sccp_addr_name(), because struct osmo_sccp_instance is opaque and only
available in sccp_internal.h, within libosmo-sccp.
Add osmo_sccp_inst_addr_name() which derives the ss7 instance from the internal
knowledge of the osmo_sccp_instance struct. This can save calls to
osmo_ss7_instance_find() just to do some logging of an sccp address.
Naming: first I thought to pick osmo_sccp_addr_name2(), but for some of the
string composing functions, adding a 2 already means that it is identical but
using a second static buffer (to be used twice within the same printf).
Change-Id: I70ec5c8b42682a23f11a5820431c7e34e225709b
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/sigtran/sccp_helpers.h | 1 +
src/osmo_ss7_vty.c | 11 ++++++-----
src/sccp_helpers.c | 7 +++++++
3 files changed, 14 insertions(+), 5 deletions(-)
hooks/post-receive
--
SCCP Library