openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-784-g70c53a6

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards e0169171146427b06d6c20759a6f3046cfb11f70 (commit) discards a3e82404e23458222d2ef9209a2e0dfcd645bc99 (commit) discards 266b34c4f1fe97c9547c5290f0351b18ed476e2a (commit) discards dc30dedcb857c9cfa9efb451a725ed83c0774def (commit) discards aa78094b4bc11caff7b3c3c90366448a75269d84 (commit) discards 4d1f467f4b78c5d630dc5aa0da847d7124e5b645 (commit) discards 2b8b8aeb85f20782be66e7968b63f0bb94139483 (commit) discards e920272bb4ef66dbc662c81ef852dec03bf3c124 (commit) discards 230c37ff165ee2cff7d9098fd15c7989861421df (commit) discards a464776f1513218645c5b4284c0b1fc1e1a17b59 (commit) discards 51ad560afe535d4c7528eca2aebb9e9de8a12df7 (commit) discards deddfdb54f878e64df11a8151239efd70b975015 (commit) discards 95617192e94c178ac36f3f379cbbcbfbaadb9939 (commit) via 70c53a622635f1770b2eef375c260ac731d40780 (commit) via 674fe423e6e9eb11bc787a5976943554d3f0fb82 (commit) via 5d97e6bf73833e024ee84cb348a2680c3ecc112b (commit) via 9c98d0a61cf5ca78e21031c5bcad86b778a054cb (commit) via c973693742619eaf999f56c5e3a9c08c1190eb9d (commit) via 6e80ec48a7dbe901072695876f2df6f1876cf79c (commit) via 9b083d517b832440b9245781180c946940673d11 (commit) via 590b5bd38ca5def9ff9e05f3e9f4dd6ba4baa792 (commit) via b1a65e9430115771a9ae14a06b21172910011937 (commit) via 62c9877ecd1586769eb354a047938a84e194fcd6 (commit) via 7b84828af0982f52de7eb8327d874cb97560605b (commit) via 0dffd57ce21d3966677097ac6fce831f9ece97cb (commit) via 31780d3e9eb0a901178368efee950fffdfbe76d6 (commit) via f76452152dcfae0982446c7188a06e6288557ada (commit) via a52ec93f5a243e72a4951c3c8dc8d6d8a0afd2d5 (commit) via 0185390bec605d0b9f024259fc27c6acc09bd332 (commit) via 2aa3e6c3f74f9b6353cd8b484615481ff8ba207a (commit) via d3e3eeb00557c9dbd10fef8c62556efc631cf5d6 (commit) via f95603d7e77982ecb2e63704b1276ae23136d695 (commit) via de4bbc714600b9db0b913705efc3064defacae18 (commit) via aec03a1f136abcd9bf59f4ec7cce9bd490fe8c81 (commit) via 59ac49dc1fd3b1435ef2eeb0b5daf555a946cde6 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (e0169171146427b06d6c20759a6f3046cfb11f70) \ N -- N -- N (70c53a622635f1770b2eef375c260ac731d40780) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=70c53a622635f1770b2eef375c260ac7… commit 70c53a622635f1770b2eef375c260ac731d40780 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 28 14:55:25 2014 +0100 sgsn: Work on 2 phase authorization (WIP) This implements the MAP way of subscriber validation when the MS tries an Attach Request: 1. perform authentication (optionally invoke the sendAuthInfo procedure), starts the AuthAndCiph procedure 2. perform update location 3. insert subscriber data 4. finish the update location 5. Attach Accept / Attach Reject This is currently accessible via the VTY interface. TODO: - Apply this to (periodic) RA Update Req - Delete Subscriber Data - Improve on procedure collisions (repeated Attach Req is sometimes not handled properly) - PDP info - Commit cleanup Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=674fe423e6e9eb11bc787a5976943554… commit 674fe423e6e9eb11bc787a5976943554d3f0fb82 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 2 11:35:41 2014 +0100 gsn: Auth and Ciph (WIP) TODO: - split this commit into several smaller ones (fixes, integration, triplet management, ...) - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5d97e6bf73833e024ee84cb348a2680c… commit 5d97e6bf73833e024ee84cb348a2680c3ecc112b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 2 11:28:38 2014 +0100 sgsn: Put SGSN related subscriber data into separate struct (TODO) TODO: - commit message - remove _alloc entirely (also in 'Add gprs_subscriber.c' patch) - also move mm into this struct Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9c98d0a61cf5ca78e21031c5bcad86b7… commit 9c98d0a61cf5ca78e21031c5bcad86b778a054cb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 2 09:47:26 2014 +0100 sgsn: Integrate Auth & Ciph into gsm48_gmm_authorize Currently the Authentication and Ciphering procedure is not yet invoked by the GMM layer. This patch starts this procedure from within gsm48_gmm_authorize when the mm->auth_state has been set to SGSN_AUTH_AUTHENTICATE and a call to gsm0408_gprs_authenticate has been issued directly or indirectly by the call to sgsn_auth_request. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c973693742619eaf999f56c5e3a9c08c… commit c973693742619eaf999f56c5e3a9c08c1190eb9d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 1 12:44:24 2014 +0100 sgsn: Do authentication based on SRES values Currently the SRES value in the Auth & Ciph Response is ignored. This patch checks the SRES value in response against the value stored in mm->auth_triplet.sres. If they don't match, an Auth & Ciph Reject message is sent to the MS. If they match, the mm->is_authenticated flag is set. Note that the procedure will not be started yet. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6e80ec48a7dbe901072695876f2df6f1… commit 6e80ec48a7dbe901072695876f2df6f1876cf79c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 1 12:33:33 2014 +0100 sgsn: Change Auth&Ciph timer handling Currently mmctx_timer_start is called from within gsm48_tx_gmm_auth_ciph_req which differs from the way e.g. the identification procedure is implemented. It also makes it more difficult to restart the procedure after timeout, which is not implemented yet. In addition, the timer is not properly stopped when an AUTH & CIPH response is received. This patch removes this timer start from gsm48_tx_gmm_auth_ciph_req, adds the retransmission of Auth & Ciph requests to the timer callback function, and properly stops the timer in gsm48_rx_gmm_auth_ciph_resp. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9b083d517b832440b9245781180c9469… commit 9b083d517b832440b9245781180c946940673d11 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 1 10:36:17 2014 +0100 sgsn: Fix and enable auth/ciph message generation Currently gsm48_tx_gmm_auth_ciph_req/_rej are commented out. In addition, gsm48_tx_gmm_auth_ciph_req uses a wrong encoding (two byte TV instead of two nibbles TV) of the CKSN information element. This patch fixes the encoding of the CKSN IE and enables the functions mentioned above. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=590b5bd38ca5def9ff9e05f3e9f4dd6b… commit 590b5bd38ca5def9ff9e05f3e9f4dd6ba4baa792 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b1a65e9430115771a9ae14a06b211729… commit b1a65e9430115771a9ae14a06b21172910011937 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 12:44:15 2014 +0100 sgsn: Notify an affected MM context if an ACL rule is removed (TODO) Currently if an ACL access rule is removed, MS already attached are not affected until they try to reattach to the SGSN. This patch adds sgsn_auth_update_all() that iterates through allMM contexts and calls sgsn_auth_update() on each of them. This function is then called when 'imsi-acl del IMSI' is executed after the ACL has been removed. TODO: - decide, whether ito replace that by a dedicated update command in the VTY ENABLE node Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=62c9877ecd1586769eb354a047938a84… commit 62c9877ecd1586769eb354a047938a84e194fcd6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7b84828af0982f52de7eb8327d874cb9… commit 7b84828af0982f52de7eb8327d874cb97560605b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:01:48 2014 +0100 sgsn: Add VTY commands to manage subscriber cache This adds the following commands to the ENABLE node: - show subscriber cache - update-subscriber imsi IMSI insert authorized (0|1) - update-subscriber imsi IMSI cancel These commands are mainly testing tools and maintenance helpers. The update commands work asynchronously and can be used to complete a pending update request or to terminate an existing connection. Note that the subscriber cache is not stored persistently and will always be empty after an SGSN restart. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0dffd57ce21d3966677097ac6fce831f… commit 0dffd57ce21d3966677097ac6fce831f9ece97cb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:47:38 2014 +0100 sgsn: Add gsm0408_gprs_access_cancelled (TODO) This function is called to delete an established MM context without invoking a detach procedure that could disable the GPRS functionality of the MS until the next power cycle. It is called when a subscriber is cancelled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=31780d3e9eb0a901178368efee950fff… commit 31780d3e9eb0a901178368efee950fffdfbe76d6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:18:09 2014 +0100 sgsn: Integrate subscriber handling into the SGSN (TODO) This commit adds a new authorization policy 'remote' and uses the subscriber cache for authorization when this policy is being used. Note that there is no remote backend implemented yet. TODO: - tests - decide, whether 'remote' could be named better, e.g. sth based on 'subscriber' Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f76452152dcfae0982446c7188a06e62… commit f76452152dcfae0982446c7188a06e6288557ada Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:12:11 2014 +0100 sgsn: Add gprs_subscriber.c This patch adds GPRS specific functions for gsm_subscriber objects (allocation, retrieval, deletion) and subscriber data requests/updates. The sgsn_update_subscriber_data callback is used to notify the sgsn about updates and is extended by a parameter that passes a reference to a gsm_subscriber. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a52ec93f5a243e72a4951c3c8dc8d6d8… commit a52ec93f5a243e72a4951c3c8dc8d6d8a0afd2d5 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 3 11:08:23 2014 +0100 msc: Add per subscriber keep flag Currently the keep_subscr flag refers to a whole group of subscribers which makes it difficult to really delete single entries if the flag is set. This patch adds a force_no_keep field to gsm_subscriber which allows for deleting single subscribers even if group->keep_subscr is set. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0185390bec605d0b9f024259fc27c6ac… commit 0185390bec605d0b9f024259fc27c6acc09bd332 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 3 13:05:16 2014 +0100 bsc/test: Add tests for gsm_subscriber base This commit adds test for the generic part of gsm_subscriber like reference counting and flag usage. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2aa3e6c3f74f9b6353cd8b484615481f… commit 2aa3e6c3f74f9b6353cd8b484615481ff8ba207a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 3 09:28:24 2014 +0100 msc: Add and use gsm_subscriber_group Currently every subcriber object directly refers to the gsm_network which contains a flag shared by every related subscriber (keep_subscr). This adds a dependency on gsm_network even if only the function defined in gsm_subscriber_base.c are used. This patch adds a new struct gsm_subscriber_group which contains the keep_subscr flag and a back reference to the network object. The latter is not dereferenced in gsm_subscriber_base.c, so it can safely be set to NULL when only that part of the gsm_subscriber API is being used. It also changes that API to use gsm_subscriber_group instead of gsm_network parameters. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d3e3eeb00557c9dbd10fef8c62556efc… commit d3e3eeb00557c9dbd10fef8c62556efc631cf5d6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 2 14:22:53 2014 +0100 msc: Don't use the subscriber to access the net object (TODO) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f95603d7e77982ecb2e63704b1276ae2… commit f95603d7e77982ecb2e63704b1276ae23136d695 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 2 11:58:00 2014 +0100 msc: Add net back pointer to gsm_trans Currently the net pointer is obtained from trans->subscr->net. On the other hand, the list gsm_trans object is managed by the net object. This patch adds the back pointer to the structure and replaces all trans->subscr->net by trans->net expressions. In trans_alloc() the trans->net pointer is obtained from the subscr object. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/configure.ac | 1 + openbsc/include/openbsc/gprs_sgsn.h | 2 - openbsc/include/openbsc/gsm_data.h | 3 +- openbsc/include/openbsc/gsm_subscriber.h | 31 +++++--- openbsc/include/openbsc/transaction.h | 7 +- openbsc/src/gprs/gprs_gmm.c | 6 +- openbsc/src/gprs/gprs_subscriber.c | 22 +----- openbsc/src/libbsc/bsc_vty.c | 4 +- openbsc/src/libbsc/chan_alloc.c | 2 +- openbsc/src/libbsc/net_init.c | 7 ++ openbsc/src/libbsc/paging.c | 2 +- openbsc/src/libcommon/gsm_subscriber_base.c | 24 +++--- openbsc/src/libmsc/ctrl_commands.c | 6 +- openbsc/src/libmsc/db.c | 4 +- openbsc/src/libmsc/gsm_04_08.c | 104 +++++++++++++----------- openbsc/src/libmsc/gsm_04_11.c | 12 +-- openbsc/src/libmsc/gsm_subscriber.c | 35 +++++---- openbsc/src/libmsc/silent_call.c | 2 +- openbsc/src/libmsc/smpp_openbsc.c | 4 +- openbsc/src/libmsc/sms_queue.c | 8 +- openbsc/src/libmsc/token_auth.c | 6 +- openbsc/src/libmsc/transaction.c | 14 ++-- openbsc/src/libmsc/vty_interface_layer3.c | 14 ++-- openbsc/src/osmo-bsc/osmo_bsc_bssap.c | 2 +- openbsc/src/osmo-bsc/osmo_bsc_filter.c | 5 +- openbsc/src/osmo-bsc/osmo_bsc_grace.c | 7 +- openbsc/src/osmo-nitb/bsc_hack.c | 2 +- openbsc/tests/Makefile.am | 2 +- openbsc/tests/channel/channel_test.c | 2 +- openbsc/tests/db/db_test.c | 10 ++- openbsc/tests/sgsn/sgsn_test.c | 6 +- openbsc/tests/subscr/Makefile.am | 18 +++++ openbsc/tests/subscr/subscr_test.c | 118 ++++++++++++++++++++++++++++ openbsc/tests/subscr/subscr_test.ok | 3 + openbsc/tests/testsuite.at | 6 ++ 35 files changed, 336 insertions(+), 165 deletions(-) create mode 100644 openbsc/tests/subscr/Makefile.am create mode 100644 openbsc/tests/subscr/subscr_test.c create mode 100644 openbsc/tests/subscr/subscr_test.ok hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)