17 Jan
2018
17 Jan
'18
1:29 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 5e518b5b4c9abb404055f38c2fc5061bf5530493 (commit)
from e653472573323a9abf910555fe38eb34b1f42840 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=5e518b5b4c9abb404055f38c2fc5…
commit 5e518b5b4c9abb404055f38c2fc5061bf5530493
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Jan 17 13:20:02 2018 +0100
fix -Werror build: logging.c: always use literal with snprintf
A recent commit added an snprintf that passes a pointer to a literal directly
to snprintf. Since passing pointers to printf formats is a vulnerability in
case user supplied data may be passed in the format, modern compilers warn
against that, which breaks our -Werror builds. Even though this is just a
pointer to a literal, it needs to be an actual literal to make compilers happy.
Use printf("%s", c) instead of printf(c).
Note that our current build slave's gcc does not enforce that yet, while newer
compilers do.
logging.c:338:4: warning: format not a string literal and no format arguments
[-Wformat-security]
ret = snprintf(buf + offset, rem, c_subsys);
Change-Id: Ifa4eb8a9fab66dcd987986065351b4a06421f1ec
-----------------------------------------------------------------------
Summary of changes:
src/logging.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications