11 Sep
2017
11 Sep
'17
8:18 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom network interface library".
The branch, master has been updated
via 14af167a5553519d8164f4a21556888535eeefeb (commit)
from 9c5f01e7b2cb1455314443ceaeb035326354d280 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmo-netif/commit/?id=14af167a5553519d8164f4a215…
commit 14af167a5553519d8164f4a21556888535eeefeb
Author: Pablo Neira Ayuso <pablo(a)gnumonks.org>
Date: Mon Sep 4 20:35:36 2017 +0200
osmux: fix buffer management mess in snprintf() calls
SNPRINTF_BUFFER_SIZE() looks too complex, previous version maintains two
different variables to account for the remaining space in the buffer,
one of them is always decremented based on what snprintf() returns,
which may result in underflow. These variables are swapped - not used
consistently - all over this code.
Replace this macro by a simplified version, with one single parameter to
account for remaining space. This macro also deals with two corner
cases:
1) snprintf() fails, actually never happens in practise, but
documentation indicates it may return -1, so let's catch this case
from here to stick to specs.
2) There is not enough space in the buffer, in that case, keep
increasing offset, so we know how much would have been printed, just
like snprintf() does.
Thanks to Pau Espin for reporting, and Holger for clues on this.
I have run osmux_test and, at quick glance, it looks good.
Change-Id: I5b5d6ec57a02f57c23b1ae86dbd894bad28ea797
-----------------------------------------------------------------------
Summary of changes:
src/osmux.c | 52 +++++++++++++++++++++++-------------------------
src/rtp.c | 27 +++++++++++++------------
tests/osmux/osmux_test.c | 8 ++++----
3 files changed, 43 insertions(+), 44 deletions(-)
hooks/post-receive
--
Osmocom network interface library