openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-763-g24b1a8b

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards f61013282c9aee2287bc901261c025f55cc34399 (commit) discards d568ce8d2e751553edb2e39c101a813572720b5b (commit) discards 90a1647f413b5113f9e3e0fd8dabf78a00e984c9 (commit) discards a14c0882329fbb1bf139bc5d9945758c3d06d575 (commit) discards 56f869d67f8ae3160a5821df28b688f8b16beace (commit) discards 25a2b945cee417df29ce14d8b92744416db2611b (commit) discards b7def117ed68d8e99e1488bab2dbcb80ea60b2e6 (commit) discards 42ae521031e8d705baf5132471d51780310fb787 (commit) discards 66789456de5982e1caa053a59037cc45cd853d8a (commit) discards 6d65e861ac5d955ed3746ea513b41a4600bd6ed7 (commit) discards e4537ac238e033dc04606139489ee94571fcb991 (commit) discards 6a41825bd4f3d222bae2bf34593c50dcda671882 (commit) via 24b1a8bf002583822cae8726e7ae2c3574421f35 (commit) via 7cef2c1fa8c7a59ea46781166d2fd067b44b6f8d (commit) via 170b60d84192ccc65ed480490220d2f829212b99 (commit) via 7158c0d5c7ecb5a3fe45704dd0adf932e492fecb (commit) via 83aba155f4bbab37aa9e5036018feb33fb780f1f (commit) via cea90341104665f67680d262ea49a4e7e34f5fb4 (commit) via 97e2eb3ad1305d35c59be88ce544684386a19998 (commit) via e981df3e20d9ec9f7c83b0b359b5f093df42a8fa (commit) via 9cc7a20c65bc881ea8e0f4084efac7180266b239 (commit) via e99d24e9f00bc55e3c215fb3c0380171ccacebfd (commit) via 744c7874f51c98c1ccf33814b2a88e0aeab34472 (commit) via 2b35c1709abf42c9d250e280a18eb7886a3f4b37 (commit) via 5465f915bf4dcebb89171a9cf9f78a9e1b7c4f7f (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (f61013282c9aee2287bc901261c025f55cc34399) \ N -- N -- N (24b1a8bf002583822cae8726e7ae2c3574421f35) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=24b1a8bf002583822cae8726e7ae2c35… commit 24b1a8bf002583822cae8726e7ae2c3574421f35 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7cef2c1fa8c7a59ea46781166d2fd067… commit 7cef2c1fa8c7a59ea46781166d2fd067b44b6f8d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 12:44:15 2014 +0100 sgsn: Notify an affected MM context if an ACL rule is removed (TODO) Currently if an ACL access rule is removed, MS already attached are not affected until they try to reattach to the SGSN. This patch adds sgsn_auth_update_all() that iterates through allMM contexts and calls sgsn_auth_update() on each of them. This function is then called when 'imsi-acl del IMSI' is executed after the ACL has been removed. TODO: - decide, whether ito replace that by a dedicated update command in the VTY ENABLE node Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=170b60d84192ccc65ed480490220d2f8… commit 170b60d84192ccc65ed480490220d2f829212b99 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7158c0d5c7ecb5a3fe45704dd0adf932… commit 7158c0d5c7ecb5a3fe45704dd0adf932e492fecb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:01:48 2014 +0100 sgsn: Add VTY commands to manage subscriber cache This adds the following commands to the ENABLE node: - show subscriber cache - update-subscriber imsi IMSI insert authorized (0|1) - update-subscriber imsi IMSI cancel These commands are mainly testing tools and maintenance helpers. The update commands work asynchronously and can be used to complete a pending update request or to terminate an existing connection. Note that the subscriber cache is not stored persistently and will always be empty after an SGSN restart. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=83aba155f4bbab37aa9e5036018feb33… commit 83aba155f4bbab37aa9e5036018feb33fb780f1f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:47:38 2014 +0100 sgsn: Add gsm0408_gprs_access_cancelled (TODO) This function is called to delete an established MM context without invoking a detach procedure that could disable the GPRS functionality of the MS until the next power cycle. It is called when a subscriber is cancelled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cea90341104665f67680d262ea49a4e7… commit cea90341104665f67680d262ea49a4e7e34f5fb4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:18:09 2014 +0100 sgsn: Integrate subscriber handling into the SGSN (TODO) This commit adds a new authorization policy 'remote' and uses the subscriber cache for authorization when this policy is being used. Note that there is no remote backend implemented yet. TODO: - tests - decide, whether 'remote' could be named better, e.g. sth based on 'subscriber' Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=97e2eb3ad1305d35c59be88ce5446843… commit 97e2eb3ad1305d35c59be88ce544684386a19998 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:12:11 2014 +0100 sgsn: Add gprs_subscriber.c (TODO) This adds GPRS specific functions for gsm_subscriber objects. The sgsn_update_subscriber_data callback is extended by a parameter that passes a reference to a gsm_subscriber. TODO: - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e981df3e20d9ec9f7c83b0b359b5f093… commit e981df3e20d9ec9f7c83b0b359b5f093df42a8fa Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 09:53:45 2014 +0100 sgsn: Extend gsm_subscriber and sgsn_mm_ctx by references This adds a field mm to struct gsm_subscriber that will be used by the SGSN to store a reference to the current MM context (or NULL if there is none). This also adds a field subscr to struct sgsn_mm_ctx that reversely points to a gsm_subscriber (or NULL if there is none). Either both fields are NULL or both fields are non-NULL. Note that subscr is being reference counted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9cc7a20c65bc881ea8e0f4084efac718… commit 9cc7a20c65bc881ea8e0f4084efac7180266b239 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 13 10:48:39 2014 +0100 sgsn: Remove explicit sgsn_instance parameters Currently the function in sgsn_auth.c either have an sgsn_config or an sgsn_instance parameter. Since then global sgsn variable is already being used in that file and since other parts of the SGSN related code also rely on a global sgsn singleton, these parameters pretend to provide a flexibility that is not really supported. Therefore this patch removes these parameters except for the ACL related functions, which do not call code that uses the sgsn variable. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e99d24e9f00bc55e3c215fb3c0380171… commit e99d24e9f00bc55e3c215fb3c0380171ccacebfd Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 7 14:17:44 2014 +0100 sgsn: Refactor sgsn_auth to separate request and authorization Currently the authorization is done in sgsn_auth_request for ACL based authorization. This doesn't match the way remote authorization would work, so that there is a second call to sgsn_auth_state already present in sgsn_auth_update. This patch removes the autorization check completely from sgsn_auth_request which in turn calls sgsn_auth_update directly now. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=744c7874f51c98c1ccf33814b2a88e0a… commit 744c7874f51c98c1ccf33814b2a88e0aeab34472 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 15:43:10 2014 +0100 sgsn: Don't assign a new P-TMSI if one is pending Currently every time an RA Update Req or an Attach Req is processed, a new P-TMSI is allocated. When an MS issues another of these messages before it has completed the first procedure, old_ptmsi is replaced by ptmsi (and thus lost) and ptmsi is replaced by the newly allocated P-TMSI. This can confuse the gbproxy, which can loose track of the logical link then. At least a Blackberry emits a double set of RA Upd Req messages from time to time which may be just 20ms apart. This patch adds a check whether mm->ptmsi or mm->old_ptmsi are set. If both are set, the P-TMSI is not re-allocated. This is only the case, when the Complete message has not been received yet, since that message will reset old_ptmsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2b35c1709abf42c9d250e280a18eb788… commit 2b35c1709abf42c9d250e280a18eb7886a3f4b37 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 08:55:13 2014 +0100 sgsn: Don't send XID reset after Detach Accept Currently when a Detach Accept is received for an unknown TLLI (which is in general the case afer the SGSN has requested the detachment), an XID reset is sent to the BSS, causing a BSSGP Status message. This happens in gsm0408_rcv_gmm. This patch moves the corresponding call to gprs_llgmm_reset downwards so that it is not being called in that case. Addresses: SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Request BSS->SGSN TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Accept SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, U, XID (Reset, IOV-UI) BSS->SGSN TLLI: --- BSSGP STATUS (Unknown MS) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5465f915bf4dcebb89171a9cf9f78a9e… commit 5465f915bf4dcebb89171a9cf9f78a9e1b7c4f7f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 13:43:41 2014 +0100 sgsn: Cleanup after RA Update Reject / Attach Reject Currently, the LLME is not cleanup up after sending an RA Update Reject. This happens after entering a routing area from outside, since in that case the SGSN sends an RA Update Reject (implicitly detached) which causes the MS to restart the attach procedure. The LLME is also not updated if an Attach Request with message errors (encoding, invalid MI type) is received or if an MM context cannot be allocated. This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req to unassign the LLME or free the MM context (if available) after a Reject message has been sent. Ticket: OW#1324 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 10 +- openbsc/src/gprs/gprs_gmm.c | 6 +- openbsc/src/gprs/gprs_sgsn.c | 2 +- openbsc/src/gprs/sgsn_auth.c | 29 +++--- openbsc/src/gprs/sgsn_main.c | 2 +- openbsc/src/gprs/sgsn_vty.c | 7 +- openbsc/tests/sgsn/sgsn_test.c | 194 +++++++++++++++++++++++++++++++++++- openbsc/tests/sgsn/sgsn_test.ok | 4 + 8 files changed, 224 insertions(+), 30 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)