2 Jun
2017
2 Jun
'17
10:50 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via d36b3a84638d6db940387f0e18c98855202f554d (commit)
from e91cd2b0887b0ed41a3bb4c49e4478defd208554 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=d36b3a84638d6db940387f0e18c9885…
commit d36b3a84638d6db940387f0e18c98855202f554d
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Jun 2 19:38:07 2017 +0200
Revert "Add version to phy_instance"
This reverts commit 9eeb0b1a136fc8c24a86cb4d832c264674c10db0.
This commit caused osmo-gsm-tester test runs for the sysmoBTS to fail with
SIGABRT consistently. See below redmine issues.
In osmo-bts-sysmo/l1_if.c, it uses talloc_asprintf to write to the char
version[MAX_VERSION_LENGTH]; talloc_asprintf() however is intended to work on
string buffers allocated by talloc, and attempts to reallocate version[].
Furthermore, it is not clear why the patch passes a 'data' arg to
app_info_sys_compl_cb() that is not used.
Hence I will revert this instead of trying to fix. Please resolve issues and
re-submit.
Related: OS#2316 OS#1614
Change-Id: I2c9fd5e6739c1750365c0241476ce4b1aa2df3d4
-----------------------------------------------------------------------
Summary of changes:
include/osmo-bts/phy_link.h | 2 +-
src/osmo-bts-octphy/l1_oml.c | 5 ++---
src/osmo-bts-sysmo/l1_if.c | 4 ----
3 files changed, 3 insertions(+), 8 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)