21 Feb
2018
21 Feb
'18
12:41 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, neels/mnc3 has been updated
discards ad815da6ef13fab95fd8238dffa5879b0e18da3e (commit)
discards 962c4ac6718b043d4e5bea65c0ae4f13a9d7e06b (commit)
discards f211a785b6ff71f6fa40aa4d57471b3b1cf21c92 (commit)
discards b0c5bd269f5e6cbc3ad8bf57b5ad7287a4a4b623 (commit)
discards 55a64364d4fed1010e26e173b9fa8cb989a43026 (commit)
discards 1286a1d07682fe9cc0728ebf97a8f27f418729b0 (commit)
discards 208d5facc06135ad4b655b39cbb3bab406437b08 (commit)
discards 9406a9a1b2554f32bbdd81ba82d6ef94b8423085 (commit)
discards 3fcdbf574323379683b6f9fd9fd3645764f22a0a (commit)
discards c0e4c4fdd55a5ce96e8c0e58165824953c6d2f79 (commit)
via ab26997fa3b8a999b18a4c4977fc049044a180a7 (commit)
via a1fa6488ad0c02753a4d7026e90f23f3e31edd4f (commit)
via a689ce7ff408b621809b0a96f3a722bcf7853b81 (commit)
via c328958e74dee88b550b085f5a074be13fbc26fa (commit)
via 67d34280264c954a18b12dc7861d7f27c277c577 (commit)
via 5aa8115fa87b860a9920b5b709eb5bb7fb50d117 (commit)
via 1e4a480d5b2d545ab191e66d5ca3d54f4cf247fe (commit)
via 9b0f7c1d66c48bfec919b951c97357709ab1d029 (commit)
via 901b5f9e6c6e256bb48cf0f8bb446a0a5683d100 (commit)
via 0bf93a6482e620b773fe3eea926c70c15d95b962 (commit)
via 22da145e4cbfee53039562b318516b3d8d1a49d0 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (ad815da6ef13fab95fd8238dffa5879b0e18da3e)
\
N -- N -- N (ab26997fa3b8a999b18a4c4977fc049044a180a7)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=ab26997fa3b8a999b18a4c4977fc…
commit ab26997fa3b8a999b18a4c4977fc049044a180a7
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:14:14 2018 +0100
GSM_MNC_INVALID
Change-Id: Ieee7add0bd6d94cf84743a49794bbcd38561b72f
http://cgit.osmocom.org/libosmocore/commit/?id=a1fa6488ad0c02753a4d7026e90f…
commit a1fa6488ad0c02753a4d7026e90f23f3e31edd4f
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 21:38:00 2018 +0100
gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing.
gsm48_mnc_cmp() will be used by osmo-sgsn.git
http://cgit.osmocom.org/libosmocore/commit/?id=a689ce7ff408b621809b0a96f3a7…
commit a689ce7ff408b621809b0a96f3a722bcf7853b81
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 22:20:42 2018 +0100
gsm0408_test: add test cases for MNC with leading zeros
Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
http://cgit.osmocom.org/libosmocore/commit/?id=c328958e74dee88b550b085f5a07…
commit c328958e74dee88b550b085f5a074be13fbc26fa
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 22:19:56 2018 +0100
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
http://cgit.osmocom.org/libosmocore/commit/?id=67d34280264c954a18b12dc7861d…
commit 67d34280264c954a18b12dc7861d7f27c277c577
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:12:23 2018 +0100
gsm0408_test: check for new mnc_3_digits flag
Note that on the input side, the 3-digits flag may be left false when the MNC
is >99 anyway. On the decoded side, the flag is set accurately.
Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
http://cgit.osmocom.org/libosmocore/commit/?id=5aa8115fa87b860a9920b5b709eb…
commit 5aa8115fa87b860a9920b5b709eb5bb7fb50d117
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 13:47:08 2018 +0100
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually different; so far we treated both as 23. Re-encode an incoming BCD or
string of 023 as it were, i.e. not dropping the leading zero as 23.
Break ABI compatibility by changing the size and ordering of struct gprs_ra_id.
Ordering is changed because the canonical oder is {Mobile Country Code, Mobile
Network Code}, so have the mcc member first. Change size (and ordering) by
inserting a flag to indicate a three-digit MNC after the mnc member. ABI
compatibility cannot be maintained, since struct gprs_ra_id is a direct member
of structs bssgp_bvc_ctx and bssgp_paging_info, and even just adding a flag to
the end would cause ABI changes of those structs.
Add new API to set and read this additional flag to preserve leading zeros:
- gsm48_mcc_mnc_to_bcd2(), gsm48_mcc_mnc_from_bcd2() after
gsm48_mcc_mnc_to_bcd() and gsm48_mcc_mnc_from_bcd().
- gsm0808_create_layer3_aoip2() after gsm0808_create_layer3_aoip().
- gsm48_decode_lai2(), gsm48_generate_lai2() after
gsm48_decode_lai(), gsm48_generate_lai().
- The equivalent of gsm0808_create_layer3() for preserving leading zeros is
gsm0808_create_layer3_aoip2() with the scl argument passed as NULL; instead
of introducing a new shim function like gsm0808_create_layer3_2(), indicate
such in the API docs, only.
- gsm48_mnc_from_str() to encode leading zeros from string, useful for VTY
config parsing.
- gsm48_mnc_cmp() to compare MNC values including leading zeros.
In various log output, include the leading MNC zeros.
Mark one TODO in card_fs_sim.c, I am not sure how to communicate a leading zero
to/from a SIM card FS. The focus here is on the core network / BSS.
To indicate ABI incompatibility, bump libosmogsm and libosmogb LIBVERSIONs;
adjust debian files accordingly.
Implementation choices:
- The default behavior upon zero-initialization will be the mnc_3_digits flag
set to false, which yields exactly the previous behavior.
- I decided against packing the mnc with the mnc_3_digits field into a
sub-struct because it would enlarge this patch; plus, with a separate flag,
current code can decide when to start heeding leading zeros.
Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221
http://cgit.osmocom.org/libosmocore/commit/?id=1e4a480d5b2d545ab191e66d5ca3…
commit 1e4a480d5b2d545ab191e66d5ca3d54f4cf247fe
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 21:48:07 2018 +0100
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai()
Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
http://cgit.osmocom.org/libosmocore/commit/?id=9b0f7c1d66c48bfec919b951c973…
commit 9b0f7c1d66c48bfec919b951c97357709ab1d029
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:14:03 2018 +0100
gsm0408_test: RA test: include min/max value cases
(Preparation for adding 3-digit MNC)
Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
http://cgit.osmocom.org/libosmocore/commit/?id=901b5f9e6c6e256bb48cf0f8bb44…
commit 901b5f9e6c6e256bb48cf0f8bb446a0a5683d100
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:13:18 2018 +0100
gsm0408_test: include BCD and leading zeros in test output
(Preparation for adding 3-digit MNC)
Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
http://cgit.osmocom.org/libosmocore/commit/?id=0bf93a6482e620b773fe3eea926c…
commit 0bf93a6482e620b773fe3eea926c70c15d95b962
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 22:06:56 2018 +0100
gsm0408_test: cosmetically re-order MCC to come before MNC
For consistency in human readability, MCC simply should come first, always.
Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee
http://cgit.osmocom.org/libosmocore/commit/?id=22da145e4cbfee53039562b31851…
commit 22da145e4cbfee53039562b318516b3d8d1a49d0
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:11:25 2018 +0100
cosmetic: gsm0408_test: RA test cases as array-of-struct
(Preparation for adding 3-digit MNC)
Change-Id: Ic6c645ebf82d5f8d9d51c4c4cc804a0172008156
-----------------------------------------------------------------------
Summary of changes:
debian/control | 12 +-
debian/{libosmogb5.install => libosmogb6.install} | 0
.../{libosmogsm8.install => libosmogsm9.install} | 0
include/osmocom/gsm/gsm48.h | 6 +-
src/gb/Makefile.am | 2 +-
src/gsm/Makefile.am | 2 +-
src/sim/card_fs_sim.c | 1 +
tests/gsm0408/gsm0408_test.c | 66 ++++----
tests/gsm0408/gsm0408_test.ok | 169 +++++++++++----------
9 files changed, 143 insertions(+), 115 deletions(-)
rename debian/{libosmogb5.install => libosmogb6.install} (100%)
rename debian/{libosmogsm8.install => libosmogsm9.install} (100%)
hooks/post-receive
--
An utility library for Open Source Mobile Communications