openbsc.git branch laforge/coverity created. 0.15.0-564-g3679ea8

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, laforge/coverity has been created at 3679ea8fb2e8323f0493357503d82ea0ce34aace (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3679ea8fb2e8323f0493357503d82ea0… commit 3679ea8fb2e8323f0493357503d82ea0ce34aace Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 14:35:46 2016 +0100 Replace local make_sock() function with libosmocore osmo_fd_init_ofd() The local 'make_sock()' function should have been deprecated since 2011, when we started to have general socket related utility functions in libosmocore. Fixes: Coverity CID 57645 Change-Id: I2329da82d2b6612e281086ca67c7836b97e03d3d http://cgit.osmocom.org/openbsc/commit/?id=3d7230b2a2bb5e49192ee316418b0e15… commit 3d7230b2a2bb5e49192ee316418b0e1572882555 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 25 23:59:43 2016 +0100 libmsc/db: Prevent subscr->extension without NULL termination Change-Id: Ic1ae7b2d9dde8dab8f7795e5baa8918424f5f393 Fixes: Coverity CID 57622 http://cgit.osmocom.org/openbsc/commit/?id=1bda28c70911d47f129227daf34f1c7e… commit 1bda28c70911d47f129227daf34f1c7e1a059744 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:16:14 2016 +0100 channel_mode_from_lchan(): Add missing break statement GSM48_CMODE_DATA_6k0 was not properly terminated and thus resulted in a bug. Change-Id: I4000f06d0b49c4afb0446beddd150521c4ba3cf0 Fixes: Coverity CID 148207 http://cgit.osmocom.org/openbsc/commit/?id=e5f36899efc582a5de9e303313ffa924… commit e5f36899efc582a5de9e303313ffa924a727fe59 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:08:00 2016 +0100 gsm0408_test.c: Don't pass negative value to strerror() Change-Id: I4fcf24ec1bc974a3189486d2372b9713d7fdab70 Fixes: Coverity CID 135192 http://cgit.osmocom.org/openbsc/commit/?id=faab54200d13bc1a0f1f1618650a21e5… commit faab54200d13bc1a0f1f1618650a21e53ffaaea7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:06:37 2016 +0100 bsc_vty: Fix missing break statements in switch() Change-Id: Ifd48e8d56c845603d320748144b4d7c3c24022a0 Fixes: Coverity CID 135188 Fixes: Coverity CID 135190 http://cgit.osmocom.org/openbsc/commit/?id=c5c3a176f0ef275b19a2b00d7de405b2… commit c5c3a176f0ef275b19a2b00d7de405b27569f1c9 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:04:39 2016 +0100 cfg_bts_si2quater_neigh_add(): Don't call strerror() on negative value Change-Id: I1300eede3f22df812b7e83902327ce4cde21aa35 Fixes: Coverity CID 135185 http://cgit.osmocom.org/openbsc/commit/?id=84562fe6a85a289d177f94e1539e8094… commit 84562fe6a85a289d177f94e1539e80943b23f33f Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:03:02 2016 +0100 mgcp_protocol: Ensure we don't call strtok_r with NULL data Change-Id: I1dce4df6a49fe95db592b0598194e3a8b8b1b994 Fixes: Coverity CID 135181 http://cgit.osmocom.org/openbsc/commit/?id=2fd99175f8e45edb5c0f5959f3d05474… commit 2fd99175f8e45edb5c0f5959f3d054743dc786f6 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:00:08 2016 +0100 bsc_ctrl: Ensure we don't pass NULL string into strtok_r() Change-Id: I03bea132377c0136b55b6fdad99a5d92da12e692 Fixes: Coverity CID 135180 http://cgit.osmocom.org/openbsc/commit/?id=7da7d468b5624f5862c9abd63babfb64… commit 7da7d468b5624f5862c9abd63babfb64f077f9ca Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 14:58:36 2016 +0100 sgsn_test: Fix missing = in == type check Change-Id: I696a7d25d2f4d19922e05a7e83c4aeec5c44fb07 Fixes: Coverity CID 135156 http://cgit.osmocom.org/openbsc/commit/?id=84466b28f575166dea529effc0898d96… commit 84466b28f575166dea529effc0898d964f3d4d63 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 14:57:23 2016 +0100 abisip-find: check bsc_fd_register() result Change-Id: I72d713725d287d32ec90506099751aeb9b15ef15 Fixes: Coverity CID 70462 http://cgit.osmocom.org/openbsc/commit/?id=456f68b16041f9cb30281e428744a12a… commit 456f68b16041f9cb30281e428744a12a372a5b73 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 14:39:47 2016 +0100 mgcp_network.c: Use libosmocore socket functions Use libosmocore osmo_sock_init_ofd() in mgcp_create_bind(), rather than using a hand-coded version using OS socket functions. The locally implemented verison of the code didn't check setsockopt() return value. Change-Id: I1de4de12245847a6d30d1bf7c91dc813d2178dee Fixes: Coverity CID 57646 ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)