21 May
2015
21 May
'15
7:20 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/wip/ms-struct has been updated
discards a54b06f3d9dc22faeb52105dbb20acdb90437c8b (commit)
discards b8aa36e7eb7a9e880207c6e42bff463a109df227 (commit)
discards d177f269ec59f3c273508b1b18a63ef27b482877 (commit)
discards ce37488fcddc9e225335b2309f61d2135300a5ef (commit)
via 4f459799e31ee8fe34ae5f7b584860f699019cfc (commit)
via be0cbc1b7ede65ff6c5390905fc956d52a5d88b1 (commit)
via 87597358cfe216a80405c21559ba640eedf44ad2 (commit)
via 939904672961fa7e28397e27f942a7d1fff4bbdf (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (a54b06f3d9dc22faeb52105dbb20acdb90437c8b)
\
N -- N -- N (4f459799e31ee8fe34ae5f7b584860f699019cfc)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=4f459799e31ee8fe34ae5f7b584860f…
commit 4f459799e31ee8fe34ae5f7b584860f699019cfc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon May 18 15:21:36 2015 +0200
tbf: Just pass the MS object in reuse_tbf
Currently the MS will be searched based on the TLLI in resue_tbf().
Since the MS object is already known in the TBF when the TLLI is set,
it can just be passed to the new TBF.
This commit removes the call to update_ms() and just adds
new_tbf->set_ms(ms()) which will also work as expected if ms() == NULL.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=be0cbc1b7ede65ff6c5390905fc956d…
commit be0cbc1b7ede65ff6c5390905fc956d52a5d88b1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon May 18 14:35:11 2015 +0200
tbf: Explicitly pass the direction to update_ms()
The type of the TBF update_ms() is being called on does not always
reflect whether the TLLI has been signaled by the MS or the SGSN.
This commit adds an additional parameter to tell the method, in which
direction the TLLI has been passed.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=87597358cfe216a80405c21559ba640…
commit 87597358cfe216a80405c21559ba640eedf44ad2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon May 18 11:56:50 2015 +0200
tbf: Get the TLLI from the MS object
Since the synchronisation of the TBF's concerning the TLLIs has been
removed in 'Support new and old TLLI's', gprs_rlcmac_tbf::tlli() can
return the old TLLI which is probably different to ms()->tlli() in
that case. This can lead to a wrong TLLI being used in BSSGP messages.
This commit modifies the TBF's tlli() method to get the current TLLI
from the MS object.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=939904672961fa7e28397e27f942a7d…
commit 939904672961fa7e28397e27f942a7d1fff4bbdf
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri May 15 15:50:43 2015 +0200
ms: Support new and old TLLIs
According to the specification (GSM 04.08/24.008, 4.7.1.5) after a
new P-TMSI has been assigned, the old P-TMSI must be kept basically
until it has been used by both sides. Since the TLLI will be derived
from the P-TMSI, the old TLLI must also be kept until the new TLLI
has been used by both MS and SGSN.
This commit modifies the TLLI handling of GprsMs accordingly.
set_tlli() is only used with TLLIs derived from MS messages,
confirm_tlli() is used with TLLIs derived from messages received from
the SGSN. tlli() returns the value set by the MS. check_tlli()
matches each of the TLLI used by either MS or SGSN as well as the old
TLLI until it has been confirmed.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/gprs_ms.cpp | 59 +++++++++++++-------------------
src/gprs_ms.h | 9 ++---
src/tbf_dl.cpp | 7 ++--
tests/ms/MsTest.cpp | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++
tests/ms/MsTest.err | 17 ++++++++++
tests/ms/MsTest.ok | 2 ++
tests/tbf/TbfTest.err | 1 -
7 files changed, 145 insertions(+), 44 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT