17 Dec
2015
17 Dec
'15
2:12 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, jerlbeck/fixes/gb has been updated
discards 7afec7ee7471e54bcf8f22c8ba3095a19221f650 (commit)
via ef3ab6b546707f856e3951aedd2d737602c3d434 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (7afec7ee7471e54bcf8f22c8ba3095a19221f650)
\
N -- N -- N (ef3ab6b546707f856e3951aedd2d737602c3d434)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=ef3ab6b546707f856e3951aedd2d…
commit ef3ab6b546707f856e3951aedd2d737602c3d434
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 17 13:22:36 2015 +0100
ns: Force a defined state when sending NS RESET
Currently the state is assumed to remain the same while the reset
procedure is active. While this works correctly in general, a single
unexpected BLOCK_ACK or UNBLOCK_ACK can change the state but will not
stop the reset procedure. The leads to repeated RESET messages, where
the corresponding RESET_ACK is ignored. This is a stable state which
can only be left by manual intervention or by reception of a RESET
message from the peer.
This commit changes the RESET timeout handler to set the state to
BLOCKED/RESET when sending the new NS RESET message.
Note that this should ensure a clean restart even if the state has been
screwed up. It does not fix the handling of BLOCK_ACK or UNBLOCK_ACK
in abnormal cases.
Addresses:
gprs_ns.c:349 NSEI=8895 Tx NS RESET (NSVCI=8895, cause=O&M intervention)
gprs_ns.c:878 NSVCI=8895 Rx NS RESET ACK (NSEI=8895, NSVCI=8895)
gprs_ns.c:887 NS RESET ACK Discarding unexpected message for NS-VCI 8895 from SGSN
NSEI=8895
Ticket: OW#1551
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
tests/gb/gprs_ns_test.c | 5 -----
1 file changed, 5 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications