libosmocore.git branch master updated. 0.9.6-8-ga4842af

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via a4842afc83334f97653e6cca6220b19f53696509 (commit) via 748022694c57ce7b9412469b8190c7d232818a69 (commit) via d1a145e5e782d07140422b85da9f55dd4b35a206 (commit) via ca13574ba4eeb2c9e3ad865a570e6b5d3f05a3b6 (commit) via a280b82f8ea9ef5fc1aa6e2357d27d9d91219173 (commit) via 42240de04ce95e458b7b05cfa8357dae40e90b35 (commit) via 85b42c46184118db2aaa50e44e97966523dd0269 (commit) via 9adf32fb60206065026e9c3ef7088ef6bcc013be (commit) from 3cc757df1822114bf446dc2d5f6a95da92321a25 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a4842afc83334f97653e6cca6220… commit a4842afc83334f97653e6cca6220b19f53696509 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 14:11:31 2016 +0100 show bug in logging: log_set_category_filter on DL* categories Add a check to logging_test.c to show a bug: passing an internal DL* category constant to log_set_category_filter() results in a negative array index and undefined behavior. A sanitize build should catch this. The bug is confirmed by the fact that logging_test.err stays the same (hopefully) although a logging output should appear from this patch. The test could as well segfault or anything else, it's a bit of a gamble. This bug will be fixed along with the expectation in a subsequent patch. Change-Id: Ie2da77c642a84cafc0f528985930697ec167183b http://cgit.osmocom.org/libosmocore/commit/?id=748022694c57ce7b9412469b8190… commit 748022694c57ce7b9412469b8190c7d232818a69 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 16:00:24 2016 +0100 fix logging: out-of-bounds check should end with user categories To check category bounds, rather use num_cat_user, to redirect all semantically unknown categories to DLGLOBAL. Adjust logging_test expectations accordingly: "(d)" is now also shown. Note: subsys is and needs to be signed, while num_cat* are unsigned. Thus for a negative subsys, 'subsys >= num_cat_user' practically always yields true. Pay close attention to signedness and check upper bound only for positive values. Change-Id: I4a952b759f30d90fbfb81fedcfc56a8092ea18c1 http://cgit.osmocom.org/libosmocore/commit/?id=d1a145e5e782d07140422b85da9f… commit d1a145e5e782d07140422b85da9f55dd4b35a206 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 15:53:51 2016 +0100 show bug in logging: out-of-bounds check should end with user categories In the background osmo_log_info array, the user's logging categories are enhanced by the library internal ones. So far logging category range checking only checked for the larger array bounds, although passing a logging category DLGLOBAL. Add a check to logging_test.c to show that this isn't happening. Instead of DLGLOBAL, a logging category that happens to be at that index is queried. The bug is confirmed by logging_test.err only showing "(e)" and not "(d)": "(e)" is shown because the first category after the user ones happens to be DLGLOBAL. "(d)" is omitted since it hits a category that's not on debug level. This bug will be fixed along with the expectation in a subsequent patch. Change-Id: I397278714018ee9a0ae5101515f31ddddf79c2ec http://cgit.osmocom.org/libosmocore/commit/?id=ca13574ba4eeb2c9e3ad865a570e… commit ca13574ba4eeb2c9e3ad865a570e6b5d3f05a3b6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 14:18:54 2016 +0100 fix logging: also catch first out-of-bounds logging cat In map_subsys(), fix the '>' condition to '>=' for array bounds checking. Also make the bounds checking more strict: after both invocations of subsys_lib2index(), re-check validity of the array index. If the final index is still wrong, which should never happen, exit by assertion. Change-Id: I7ca1a1d47724e40350f1c4dfebe90bad01c965f9 http://cgit.osmocom.org/libosmocore/commit/?id=a280b82f8ea9ef5fc1aa6e2357d2… commit a280b82f8ea9ef5fc1aa6e2357d27d9d91219173 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 14:42:56 2016 +0100 show bug in logging: erratic redirection to DLGLOBAL for first invalid category Add a check to logging_test.c to show a bug: when a logging category value that is the first out-of-bounds value is passed to the logging system, the internal map_subsys() fails to redirect to DLGLOBAL due to a flawed conditional. This results in a too large array index and undefined behavior. A sanitize build should catch this. The bug is confirmed by the fact that logging_test.err stays the same (hopefully) although a logging output should appear from this patch. The test could as well segfault or anything else, it's a bit of a gamble. This bug will be fixed along with the expectation in a subsequent patch. Change-Id: I12bf38b6c1f85e2d7bf5a15f942dfe0beed41eba http://cgit.osmocom.org/libosmocore/commit/?id=42240de04ce95e458b7b05cfa835… commit 42240de04ce95e458b7b05cfa8357dae40e90b35 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 15:13:56 2016 +0100 fix logging: redirection to DLGLOBAL for invalid categories For out-of-bounds logging categories, redirect to the proper DLGLOBAL array index instead of returning -1. Adjust test expectation which shows that the bugs tested for are fixed. Note: there are separate bounds checking problems, left for another patch. Change-Id: I6ea9a59e005a22e0305454291714fdb9531c346b http://cgit.osmocom.org/libosmocore/commit/?id=85b42c46184118db2aaa50e44e97… commit 85b42c46184118db2aaa50e44e97966523dd0269 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 14:34:41 2016 +0100 show bug in logging: erratic redirection to DLGLOBAL for invalid categories Add a check to logging_test.c to show a bug: when a logging category value that is out-of-bounds is passed to the logging system, the internal map_subsys() function should remap that to DLGLOBAL. But in fact DLGLOBAL is -1 and the function fails to map this to a proper positive array index, directly returning -1 instead. This results in a negative array index and undefined behavior. A sanitize build should catch this. The bug is confirmed by the fact that logging_test.err stays the same (hopefully) although a logging output should appear from this patch. The test could as well segfault or anything else, it's a bit of a gamble. This bug will be fixed along with the expectation in a subsequent patch. Note: osmo_log_info->num_cat + 0 is also out-of-bounds, but there is a separate bug there, so leaving this for another patch. Change-Id: I161b6550fa204a872bad1abefee1a6155393fafd http://cgit.osmocom.org/libosmocore/commit/?id=9adf32fb60206065026e9c3ef708… commit 9adf32fb60206065026e9c3ef7088ef6bcc013be Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Dec 12 14:22:59 2016 +0100 logging test: cosmetic: print target and don't print color Prepares for upcoming modifications of the logging test to show and fix bugs in the logging system. Change-Id: I9461b987adf85d87469a6af55de5f1aa478f6ebb ----------------------------------------------------------------------- Summary of changes: src/logging.c | 18 ++++++++++++++++-- tests/logging/logging_test.c | 21 +++++++++++++++++++++ tests/logging/logging_test.err | 12 ++++++++---- 3 files changed, 45 insertions(+), 6 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications