26 Nov
2015
26 Nov
'15
11:30 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
discards b9d5c9b7922965469a6304fa65bd96c9ce8a50eb (commit)
discards dabb2430cfe8e176bcf83a1cef0a7607c2f72577 (commit)
discards 8c02ef0a2dd678dd8bf63c15c77c350ad6104e56 (commit)
via 346d506d0b2eebe93ae06f9b432c5f38f9f683ee (commit)
via e4837989e63b7f51ae811f151ffc933c5f5c73cc (commit)
via 8326885067301fd8c8c566eeea346d9aff035f0a (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (b9d5c9b7922965469a6304fa65bd96c9ce8a50eb)
\
N -- N -- N (346d506d0b2eebe93ae06f9b432c5f38f9f683ee)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=346d506d0b2eebe93ae06f9b432c5f38…
commit 346d506d0b2eebe93ae06f9b432c5f38f9f683ee
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 22:19:22 2015 +0100
gtphub: implement restart counter properly.
Force passing a restart counter, by adding such arg to gtphub_start() (test
suite is not affected by this).
In gtphub_main.c, add -r,--restart-file <path> and next_restart_count() to
maintain the counter file. While at it, tweak the cmdline help to unify the
formatting (mostly commas and a missing line break).
Send gtphub's own restart counter. So far, the sender's restart counter was
copied through, which would break as soon as more than one GSN would talk to
the same peer with differing restart counters.
Also fix the in-mem restart counter data type (one octet, not two).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e4837989e63b7f51ae811f151ffc933c…
commit e4837989e63b7f51ae811f151ffc933c5f5c73cc
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 05:20:18 2015 +0100
gtphub: complain about excess cmdline args.
http://cgit.osmocom.org/openbsc/commit/?id=8326885067301fd8c8c566eeea346d9a…
commit 8326885067301fd8c8c566eeea346d9aff035f0a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:31:06 2015 +0100
gtphub: track tunnels explicitly.
So far, gtphub worked perfectly by only tracking single TEIs ... for probably
most uses. But a Ctrl plane tunnel may have expired despite a still active
corresponding User plane tunnel. The User plane would continue to work
indefinitely, but if any Ctrl messages followed after more than six hours of
Ctrl silence, they would have been dropped due to an expired TEI mapping.
We want to
- combine expiry of a user TEI with its ctrl TEI. (done in this patch)
- upon delete PDP context, remove both user and ctrl TEI mappings. (future)
- when a peer indicates a restart counter bump, invalidate its tunnels.
(future)
To facilitate these, track tunnels, complete with both SGSN's and GGSN's
address, original and replaced TEIs, all for both user and ctrl plane, in a
single struct. A single expiry entry handles the entire tunnel, instead of
previously four separate expiries for each endpoint identifier.
Add the concept of a "side", being either GGSN or SGSN, to index tunnel
endpoint structs, and so on.
Track the originating side in the gtp_packet_desc.
Add header_tei_rx: set_tei() overwrites header_tei, but the originally received
header TEI is still needed to match a Create PDP Context Response up with its
Request (and for logging).
Adjust the test suite to expect tunnel listing strings instead of TEI mappings,
with a bonus of making it a lot easier to grok, and including the IP addresses.
Add regression test for refreshing tunnel expiry upon use.
Note: the current implementation is as slow as can possibly be, iterating all
the tunnels all the time. Optimizations are kept for a future commit, on
purpose.
BTW, the sequence number mapping/unmapping structures remain unchanged.
Sponsored-by: On-Waves ehi
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gtphub.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)