8 Mar
2017
8 Mar
'17
2:03 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 6d804b1a7e375213cb4b3e437c2b9b8c68872164 (commit)
from abf53d87b6648f2d42562c5699e9035afd92e608 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=6d804b1a7e375213cb4b3e437c2b9b8c…
commit 6d804b1a7e375213cb4b3e437c2b9b8c68872164
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sat Feb 18 22:20:46 2017 +0100
add struct bsc_subscr, separating libbsc from gsm_subscriber
In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will
not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC
subscriber: struct bsc_subscr.
Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no
longer have a backpointer to gsm_network (used to be via subscr->group).
Create a separate logging filter for the new BSC subscriber. The implementation
of adjusting the filter context is added in libbsc to not introduce
bsc_subscr_get/_put() dependencies to libcommon.
During Paging Response, fetch a bsc_subscr from the mobile identity, like we do
for the gsm_subscriber. It looks like a duplication now, but will make sense
for the VLR as well as for future MSC split patches.
Naming: it was requested to not name the new struct bsc_sub, because 'sub' is
too ambiguous. At the same time it would be fine to have 'bsc_sub_' as
function
prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to
match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast
to type, relatively short, unambiguous, and the naming is consistent.
Add bsc_subscr unit test.
Related: OS#1592, OS#1594
Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
-----------------------------------------------------------------------
Summary of changes:
openbsc/.gitignore | 1 +
openbsc/include/openbsc/Makefile.am | 1 +
openbsc/include/openbsc/bsc_subscriber.h | 43 ++++++++
openbsc/include/openbsc/debug.h | 3 +-
openbsc/include/openbsc/gsm_04_08.h | 4 +-
openbsc/include/openbsc/gsm_data.h | 12 +++
openbsc/include/openbsc/osmo_bsc_grace.h | 6 +-
openbsc/include/openbsc/paging.h | 17 +--
openbsc/src/libbsc/Makefile.am | 1 +
openbsc/src/libbsc/abis_rsl.c | 4 +-
openbsc/src/libbsc/bsc_subscriber.c | 168 ++++++++++++++++++++++++++++++
openbsc/src/libbsc/bsc_vty.c | 12 ++-
openbsc/src/libbsc/gsm_04_08_utils.c | 20 ++--
openbsc/src/libbsc/paging.c | 88 ++++++++--------
openbsc/src/libcommon-cs/common_cs.c | 3 +
openbsc/src/libcommon/debug.c | 12 ++-
openbsc/src/libmsc/gsm_04_08.c | 29 +++++-
openbsc/src/libmsc/gsm_subscriber.c | 30 +++++-
openbsc/src/libmsc/vty_interface_layer3.c | 14 ++-
openbsc/src/osmo-bsc/osmo_bsc_bssap.c | 11 +-
openbsc/src/osmo-bsc/osmo_bsc_filter.c | 26 ++---
openbsc/src/osmo-bsc/osmo_bsc_grace.c | 21 ++--
openbsc/src/osmo-bsc/osmo_bsc_vty.c | 15 ++-
openbsc/tests/channel/Makefile.am | 2 +-
openbsc/tests/channel/channel_test.c | 3 +-
openbsc/tests/subscr/Makefile.am | 19 ++++
openbsc/tests/subscr/bsc_subscr_test.c | 130 +++++++++++++++++++++++
openbsc/tests/subscr/bsc_subscr_test.err | 17 +++
openbsc/tests/subscr/bsc_subscr_test.ok | 11 ++
openbsc/tests/testsuite.at | 7 ++
30 files changed, 615 insertions(+), 115 deletions(-)
create mode 100644 openbsc/include/openbsc/bsc_subscriber.h
create mode 100644 openbsc/src/libbsc/bsc_subscriber.c
create mode 100644 openbsc/tests/subscr/bsc_subscr_test.c
create mode 100644 openbsc/tests/subscr/bsc_subscr_test.err
create mode 100644 openbsc/tests/subscr/bsc_subscr_test.ok
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)