1 Nov
2017
1 Nov
'17
11:41 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 74aa0258269296f078e685e21fb08b115567e814 (commit)
from 38a49f62760a832dcc15c7a47e1c678402ea02da (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=74aa0258269296f078e685e21fb0…
commit 74aa0258269296f078e685e21fb08b115567e814
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 1 22:35:37 2017 +0000
Revert "vty: Fix bad use of vector_slot()"
The patch seemed sensible, but introduces a segfault when hitting tab
on the interactive VTY. Reproduction example:
osmo-msc
telnet 127.0.0.1 4254
OsmoMSC> enable <TAB>
So we need to understand what that line of code actually intends to do.
Until then, revert this to avoid the segfault.
The segfault happens at:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7bc0894 in cmd_complete_command_real (vline=0x5555558d59e0,
vty=0x5555558d57b0, status=0x7fffffffe024) at
../../../../src/libosmocore/src/vty/command.c:1953
1953 if (*(char *)vector_slot(vline, index) == '\0')
This reverts commit e9e9e427b78271941a25a63567fc2ec2bb9e4433.
Change-Id: I3fe213bdfb96de9469aae64e67000dafee59302e
-----------------------------------------------------------------------
Summary of changes:
src/vty/command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications