26 Sep
2016
26 Sep
'16
2:35 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 8319a6799ffc9d4c5e7e094b96af30cbebf89f65 (commit)
via 4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6 (commit)
from e31cf8057f65ec0d8d141eb8f64d5c0e61204f6c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=8319a6799ffc9d4c5e7e094b96af…
commit 8319a6799ffc9d4c5e7e094b96af30cbebf89f65
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Sep 21 18:30:01 2016 +0200
bitrev_test: don't omit last byte from test result check
The osmo_hexdump of the output in sh_chk() omitted the last byte of the
returned bytes from the osmo_nibble_shift_*() functions.
Determine the number of bytes from nibbles divided by two plus one for any odd
nibble number. Output this number of bytes of output data.
Memset the output buffer to get well-defined bytes for unwritten places.
Also assert that we have enough buffer length for all nibbles.
Change-Id: I011f42bca555caec0dfe8688ff1f28303fa04fad
http://cgit.osmocom.org/libosmocore/commit/?id=4fd6023b0383e7efa3b7b0211104…
commit 4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Sep 20 16:33:50 2016 +0200
Fix ASAN failure in bitrev_test
Previously while testing osmo_nibble_shift_left_unal() following error was
triggered by AddressSanitizer upon offs == 12 and the last sh_chk line, i.e.
shift left of 12 nibbles from in2:
==3890== ERROR: AddressSanitizer: stack-buffer-overflow on address 0xbff5b5b6 at pc
0xb6186862 bp 0xbff5b4a8 sp 0xbff5b49c
READ of size 1 at 0xbff5b5b6 thread T0
#0 0xb6186861
(/home/msuraev/source/gsm/libosmocore/src/.libs/libosmocore.so.7.0.0+0xc861)
#1 0x8049d8b
(/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x8049d8b)
#2 0x804a9d1
(/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x804a9d1)
#3 0xb5fe3af2 (/lib/i386-linux-gnu/libc-2.19.so+0x19af2)
#4 0x8048a30
(/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x8048a30)
Address 0xbff5b5b6 is located at offset 38 in frame <main> of T0's stack:
This frame has 3 object(s):
[32, 38) 'in2'
[96, 104) 'out'
[160, 168) 'in1'
The reason is incorrect range in test cycle. Fix it and adjust test
output accordingly.
Tweaked-by: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Fixes: OW#1589 ("undefined behavior in libosmocore triggered by tests")
Change-Id: I5eb3f600290c05b4ab9ac2450a28d616e6b415fd
-----------------------------------------------------------------------
Summary of changes:
tests/bits/bitrev_test.c | 9 +++++++--
tests/bits/bitrev_test.ok | 50 +++++++++++++++++++++++------------------------
2 files changed, 31 insertions(+), 28 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications