19 Dec
2017
19 Dec
'17
11:24 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "wireshark with Osmocom specific dissectors".
The branch, laforge/gsup has been created
at 3bf54bd2874f0858ff3c2ff154873595df87772d (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/wireshark/commit/?id=3bf54bd2874f0858ff3c2ff1548735…
commit 3bf54bd2874f0858ff3c2ff154873595df87772d
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Dec 19 23:22:23 2017 +0100
Dissector for the Osmocom GSUP Protocol
The Osmocom GSUP protocol is a light-weight alternative to the
classic GSM MAP protocol. It operatest between (MSC|SGSN) and HLR.
Change-Id: I954c7e332dce3a8855f7f4ace0b878f66da6f02e
http://cgit.osmocom.org/wireshark/commit/?id=12e25c1a86d5a4b67213af89fa3b2d…
commit 12e25c1a86d5a4b67213af89fa3b2d6a0bcaa634
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Dec 19 15:08:03 2017 +0000
plugin: fix extra ';' outside of a function [-Wextra-semi]
Change-Id: I923e4a4f84e8786523333daf372fc5d7cc7ad729
Reviewed-on: https://code.wireshark.org/review/24897
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=106e0b4ee0b5bac403a174aff7266d…
commit 106e0b4ee0b5bac403a174aff7266d17c7b1b43e
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Dec 19 10:31:44 2017 +0100
Qt: add initializers (CID: 1426703).
Change-Id: Ib75685a099449672b55d63b647fd0f579ad1e5f6
Reviewed-on: https://code.wireshark.org/review/24893
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c9b6887d8469251b15204dffcd7105…
commit c9b6887d8469251b15204dffcd7105490b574e27
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 19 09:40:08 2017 +0100
wslua: Fix logger after g6a5e90f2
The Qt log output changes in g6a5e90f2 changed the Qt message handler
to use g_log. Lua logging already used g_log. The Qt variant of
funnel logger, which is used by Lua as g_log backend, is currently
using qDebug and this gives recursive calls to g_log and thus an assert.
Rewrite the lua logging to not use g_log.
Change-Id: Icf4f0022a11cb32d2b4f413f76d946f2506e283d
Reviewed-on: https://code.wireshark.org/review/24888
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5b596fa871b58948dacd18859dad61…
commit 5b596fa871b58948dacd18859dad61e692ab973e
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Dec 19 09:47:21 2017 +0100
[SIP] Add dissection of oc-seq as time stamp.
Change-Id: I0273f8bff7693a7dc7416932649c083c360bc098
Reviewed-on: https://code.wireshark.org/review/24890
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4db038aa28023867dcdae403d79b0a…
commit 4db038aa28023867dcdae403d79b0a0b5506e991
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Dec 19 10:06:13 2017 +0100
Qt: Fix sorting of enabled protocols description
Change-Id: Ifa7b6e61927615c342839b6c2e7d012198a5f939
Reviewed-on: https://code.wireshark.org/review/24892
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d6eb9631f26176d00d6bef69569d1…
commit 0d6eb9631f26176d00d6bef69569d1d2911bd233
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Dec 16 21:51:33 2017 -0500
Convert Enabled protocols dialog to use model.
Change-Id: I618df2f2608adcd1be5da02262c5296e4d86cfba
Reviewed-on: https://code.wireshark.org/review/24866
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6e4a6364154f4e880f2bb6111d6759…
commit 6e4a6364154f4e880f2bb6111d6759e51a686bb4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Dec 18 16:42:12 2017 -0500
Bugfix capture_info_open() folded into ui/capture.c
Id302e88bed4da8b9b457049fb78b0bc7d7ffabe3 forgot to add brackets around
functionality
Change-Id: I3aa2ed6e927a6daca93846650645d76b0d62043e
Reviewed-on: https://code.wireshark.org/review/24885
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7cb6255f17b90863d863ad995d7bca…
commit 7cb6255f17b90863d863ad995d7bca5921b7c517
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Dec 18 21:02:52 2017 +0100
Qt: Resolve duplicate keyboard shortcuts
Two Edit->Copy methods are using the same keyboard shortcut as other
functionality:
1. Ctrl+Shift+D is used for "Copy this item's description" and
"Ignore All Displayed packets"
2. Ctrl+Shift+F is used for "Copy this item's field name" and
"Reload as File Format/Capture"
Resolve this by changing the Copy methods to use Ctrl+Alt+Shift as modifier.
Add a keyboard shortcut for "Copy all visible items" while here.
Change-Id: I0d963501055e63963d93e211f592aa9e82801d3c
Reviewed-on: https://code.wireshark.org/review/24884
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9f7b8713fa8286611e84a68f82adc2…
commit 9f7b8713fa8286611e84a68f82adc2d494b21173
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Dec 18 10:25:03 2017 +0100
Qt: Add Collapse Subtrees
This item is missing from the Qt port.
Change-Id: Iacc18a7c2eb2368d6566622788a4e900868d446e
Reviewed-on: https://code.wireshark.org/review/24879
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5ebc3277ed98c39b24d971470d1aea…
commit 5ebc3277ed98c39b24d971470d1aea0efe042351
Author: Florian Bezold <florian.bezold(a)esrlabs.com>
Date: Thu Dec 7 09:00:13 2017 +0100
androiddump: Fix adb tcpdump PTY CR/LF handling
Devices running Android >= 7 have a different adb shell handling than
before:
- Before Android 7, adb always runs shell commands in a PTY
(pseudoterminal), which automatically converts all \n to \r\n
- Since Android 7, adb no longer uses a PTY if a command is directly
started (like 'tcpdump' in our case).
The original androiddump code reversed the PTY \r\n handling as for
older devices. Commit 66507b9 for bug 13510 removed that which supported
newer devices while breaking all older devices.
This fix tries to support both by first trying to use the new
"shell,raw:" adb command syntax. If that succeeds, adb/device must
support non-PTY shells and we don't reverse any \r\n.
If that fails, it's most likely an older device, and we fall back to the
original "shell:" command and enable \r\n reversal.
(To prevent misleading error popups in Wireshark, the warning log in
adb_send when the first attempt fails is changed to a debug log).
Ping-Bug: 13510
Change-Id: I7e0a4f594ebe5dde682cceb667330459337a0c9c
Reviewed-on: https://code.wireshark.org/review/24721
Reviewed-by: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=09ad8456906172c384a01df49a7eba…
commit 09ad8456906172c384a01df49a7eba5716ebfa8e
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 18 10:18:05 2017 +0100
[SIP] Make a filter for Overload Control Value.
Change-Id: I8ee552d331388a1fa748bff765afe5b53508f63f
Reviewed-on: https://code.wireshark.org/review/24878
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b37aedb47a61f6b16339ce2e4d75f5…
commit b37aedb47a61f6b16339ce2e4d75f57e16b6ea31
Author: Marko Hrastovec <marko.hrastovec(a)gmail.com>
Date: Fri Dec 8 12:12:38 2017 +0100
asterix: special processing for field item I021/150
There is a problem where one field decodes differently
depending on another fields content.
A code has been added to save information for 021_150_IM field.
When the next field 021_150_ASPD is decoded, the
stored information determines how it shall be scaled.
This is a special case for I021/150 only.
The same way as this change, other changes shall be done for
fields that are dependent on other fields.
Bug: 14076
Change-Id: I51f2c8f79bc6bde9efc0429e54fbea36818e9b36
Reviewed-on: https://code.wireshark.org/review/24734
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=786a73b80d6cc7d59060de50fef3fe…
commit 786a73b80d6cc7d59060de50fef3feba04684869
Author: Florian Bezold <florian.bezold(a)esrlabs.com>
Date: Mon Dec 4 17:38:46 2017 +0100
Fix SOCKS5 state machine for authentication, two-pass dissection
1. SOCKSv5 dissection was broken if authentication was used since the
used state machine states were initialized, but not saved correctly, and
the first server state transition was wrong.
I also fixed the GSSAPI variant analogously, but could not verify this
since I have no traces of this.
2. SOCKSv5 actually has a different "subnegotiation field" for the
authentication messages. This is added, and the original SOCKS version
is added as a generated field (i.e. for filtering).
3. Info column setting is moved to the *_display_socks_* routines to fix
two-pass dissection (as used by GUI Wireshark), since only here the
correct per-packet state is used. The hash_info (as used by the
*_state_machine_* functions) is already fully populated on second pass.
Change-Id: Ib39434dafce08188cd2da347118d0509a7613915
Reviewed-on: https://code.wireshark.org/review/24712
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3c87991c28dda0ee2e64c73e3df6c6…
commit 3c87991c28dda0ee2e64c73e3df6c671a19ab42c
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Dec 15 13:40:34 2017 -0800
-1 is a valid tree_type value.
Adjust tree_expanded and FieldInformation::treeType accordingly.
Change-Id: I9b12c28550ba2639f636531a7ea1841df0638b5e
Reviewed-on: https://code.wireshark.org/review/24844
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=67a49eb2ece34494a0fe1efd76d36c…
commit 67a49eb2ece34494a0fe1efd76d36c9b4d46d11e
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Sun Dec 17 16:05:51 2017 -0800
ieee80211: Remove notices about D3.1 of IEEE802.11ac.
These items are now in 802.11 2016 so they are no longer draft items.
Change-Id: I89b694f30700e08d9edc2e3707f36f8cf30dd0f2
Reviewed-on: https://code.wireshark.org/review/24877
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9761e279392ee996137c0d1d34a68b…
commit 9761e279392ee996137c0d1d34a68ba13f43ae02
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 17 14:40:06 2017 -0800
Qt: Process our event loop less often at startup.
Add back info_update_freq_ and use it to skip event loop processing.
Change-Id: Id36b4786c5ff1458abbf12f4e9ded13c56e14d57
Reviewed-on: https://code.wireshark.org/review/24876
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=50be2bde1a79a2a710a063cca23e51…
commit 50be2bde1a79a2a710a063cca23e51a67a95d63b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 17 12:51:36 2017 -0800
Qt: Handle RecentFileStatus destruction manually.
Restore the "deleteLater" behavior removed in 889aacae6e so that we
don't trigger an assert in debug builds.
Move the itemStatusFinished connection to RecentFileStatus while we're
here.
Bug: 14279
Change-Id: I79bc74d77fb3ad970c7c8a71037f680d55eac47c
Reviewed-on: https://code.wireshark.org/review/24875
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f6d5b5fc107b67b2094abe6b7c5642…
commit f6d5b5fc107b67b2094abe6b7c56425d92dd0f91
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sun Dec 17 10:47:30 2017 +0100
QT: Fix qUtf8Printable error
macro qUtf8Printable() has been defined with QT 5.4
therefore we need qt_ui_utils.h included
Change-Id: I6301d5eda124d2033033c6a91447b15736cdc8c2
Reviewed-on: https://code.wireshark.org/review/24870
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=c9f54aa1c3a71c330c30ebc7a17892…
commit c9f54aa1c3a71c330c30ebc7a178922d179f912e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Dec 17 12:44:50 2017 +0000
autotools: Fixup plugins Custom.*.example
plugin_ldadd was removed in 262a84c384353b2a88a6e81cdc499ab94a8316c2.
Change-Id: I516aa1be3466433bf8db83ab3d1773bf88082e8c
Reviewed-on: https://code.wireshark.org/review/24850
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=6159c2be18429e69096645946a2cbb…
commit 6159c2be18429e69096645946a2cbb507d49cbc5
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Dec 17 12:26:26 2017 +0000
CMake: Replace generator expression with variable
Should fix OSX buildbot.
Change-Id: I52abdeab8c547079edc8aec6a0c6e12e928838c6
Reviewed-on: https://code.wireshark.org/review/24873
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f3444ed0f9c1d6e48b4b383afdd2b9…
commit f3444ed0f9c1d6e48b4b383afdd2b9fca9a8966c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 15 00:49:31 2017 +0000
plugins: Remove moduleinfo.h
Micro version bump for mate to homogenize it between CMake and autotools.
The cmake macro doesn't handle the "a" suffix and it doesn't seem
worth
implementing.
Change-Id: Ib022c6aa170623b83a9700e4fa098c60a9cddfab
Reviewed-on: https://code.wireshark.org/review/24847
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=ee8ca2e1d793e039bdd7304ad3c2c0…
commit ee8ca2e1d793e039bdd7304ad3c2c0cb42a69624
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 15 22:13:59 2017 +0000
plugin.rc.in: Cleanup some unnecessary code
Also add comment noting that MSVC_VARIANT is not the same thing as
CMAKE_GENERATOR.
Change-Id: Icc0f4a491786e4045c650509957655ef41352b29
Reviewed-on: https://code.wireshark.org/review/24846
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f37e759f41da97a2121934d17b0ec2…
commit f37e759f41da97a2121934d17b0ec2d895c3af15
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 17 08:16:56 2017 +0000
[Automatic update for 2017-12-17]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ideac9831381dbf6411af0e1d8bfa4fef6a1d7769
Reviewed-on: https://code.wireshark.org/review/24867
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=889aacae6e549c9cbbbd4ce3a371de…
commit 889aacae6e549c9cbbbd4ce3a371de0b042f7a37
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sat Dec 16 14:24:24 2017 -0800
Qt: Update our recent status sooner at startup.
Update our recent file status as soon as we read recent_common.
Run recent stats updates in the global thread pool.
Revert 15a97b5986 since it's no longer needed.
Change-Id: If1b08ea640dfcad26affab5d20c80c90fbf133f2
Reviewed-on: https://code.wireshark.org/review/24862
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cd573915eafd49cd3cb41e40a0d59a…
commit cd573915eafd49cd3cb41e40a0d59acab4f49583
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat Dec 16 21:01:19 2017 +0000
LTE RLC graph: export graph as image, like TCP stream does
Change-Id: I8709f7c09528a44a9729a06ea2ba4d6f99dbeccb
Reviewed-on: https://code.wireshark.org/review/24864
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b1f558ae278cb1b90f6e06a9cc4031…
commit b1f558ae278cb1b90f6e06a9cc4031227b47fd31
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Sat Dec 16 09:52:01 2017 -0800
ieee80211: Bring VHT Capabilities IE into conformance with IEEE802.11-2016
IEEE802.11-2016 standardized those bits, so it's no longer a draft standard.
I am slowly getting these things correct as I prepare for support for
IEEE802.11ax D2.0.
Change-Id: I3fc4497f2b85bae78043b9fd997379a44898f3db
Reviewed-on: https://code.wireshark.org/review/24860
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f4b2263a0b753984c3ce97f2709ed4…
commit f4b2263a0b753984c3ce97f2709ed4e435afe9ff
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat Dec 16 10:33:28 2017 +0000
Simple statistics export: fill in callback to get item data
Bug: 13942
Change-Id: Ie7d13b1c17083d0a5b98282f04e6ac30319352a7
Reviewed-on: https://code.wireshark.org/review/24853
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6a5e90f2d91892248f5f7defe1c610…
commit 6a5e90f2d91892248f5f7defe1c610e00298d789
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sat Dec 16 14:15:28 2017 -0800
Log output updates.
Add a Qt message handler that calls g_log. Add milliseconds to the
g_log_message_handler timestamp.
Change-Id: I5b1c1d902b6b05cd8daa01741b19d6c2048dfb9a
Reviewed-on: https://code.wireshark.org/review/24865
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=18c42e1dca9631b336dd2a8b813aad…
commit 18c42e1dca9631b336dd2a8b813aad782569f69a
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sat Dec 16 21:55:18 2017 +0100
Kerberos: Update and fix KDCOptions and TicketFlags
Fix and update KDCOptions and TicketFlags.
Used references:
* https://github.com/heimdal/heimdal/blob/master/lib/asn1/krb5.asn1#L330
* https://msdn.microsoft.com/en-us/library/cc246090.aspx
* https://tools.ietf.org/html/rfc8062#section-3
Bug: 14261
Change-Id: I0e34425fc35e0eba14c700f82cbf2441365b139d
Reviewed-on: https://code.wireshark.org/review/24863
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0b88544b07075741e6f89666867f09…
commit 0b88544b07075741e6f89666867f0926c45fa419
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Dec 16 10:03:55 2017 -0500
Fix memory leaks in Expert Info dialog
Models and children weren't deleted which leaked memory all over the place.
Change-Id: I961016b2501ad8cc8c75cf5fa5b0c86756a29382
Reviewed-on: https://code.wireshark.org/review/24858
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=68668b785c73a1676ef4573290be7b…
commit 68668b785c73a1676ef4573290be7b50abb1c5a8
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Dec 14 13:44:05 2017 -0500
Convert Supported Protocols dialog to use model
Also have search file search name, filter and description columns
Change-Id: Id519c5b1deb4a80e3b95437cf2e6d3e9510e4b11
Reviewed-on: https://code.wireshark.org/review/24857
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2b4322ceba7e8f8679ef955efb6a6a…
commit 2b4322ceba7e8f8679ef955efb6a6ab3e12adab0
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Thu Dec 14 21:45:56 2017 +0100
BGP: add Open message error/unsupported capability
According to RFC 5492 [1], paragraph 5, Data field of BGP
notification for Open message error/unsupported capability must
list the set of unsupported capabilities
Bug: 14274
Change-Id: Iacd33b5c83bc234652d2a5444f0029640d33e1c5
Reviewed-on: https://code.wireshark.org/review/24829
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b2e6d615c2817a25d74e1b25629e54…
commit b2e6d615c2817a25d74e1b25629e547586dbfa47
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 15 19:18:00 2017 +0100
qt: follow stream: prevent duplicate close
621498f88e882dbe8cc3a2c8373bb342bb0dbe77 fixed a crash that's caused by
closing the follow stream dialogue multiple times. Another way to get a
similar crash is to press the Back or "Filter out this stream" buttons
again while we're already about to close.
Ignore the two buttons in this case.
Change-Id: Ia8d7b3ca500db2519a784b42c0744e2527b9d5f6
Reviewed-on: https://code.wireshark.org/review/24839
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3d086e638dc0a1713328c231616715…
commit 3d086e638dc0a1713328c23161671555dfa4faaf
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 15 19:26:00 2017 +0100
wslua: Fix crash in Dir.open()
Do not give an uninitialised error pointer to g_dir_open(), this
will give a crash if g_dir_open() fails.
Remove wslua_dir.dummy because it is not used by anyone.
Change-Id: I044eee021393f2ea2aa022138bbf6fd099eb0908
Reviewed-on: https://code.wireshark.org/review/24840
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=621077309506ec65cb99b4f3aeffb9…
commit 621077309506ec65cb99b4f3aeffb99bcba69393
Author: Andrei Cipu <acipu(a)ixiacom.com>
Date: Fri Nov 17 17:00:01 2017 +0200
Rework address matching to work with string input.
Currently, the function assumes the input is represented as
a string representation of the hex string of the addresses.
Instead, the parameters are sent as plain text IPs.
We reactivate the helper functions that convert the addresses
from the latter to th former representation and add support
for handling masks in the input.
Bug: 14229
Change-Id: I750a546b39404a1fbc86cee604a33e506f7240d8
Reviewed-on: https://code.wireshark.org/review/24469
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=03375e0c288dcad62b33fae2ce508d…
commit 03375e0c288dcad62b33fae2ce508d8dd906e169
Author: Robert Grange <robionekenobi(a)bluewin.ch>
Date: Fri Dec 15 08:13:04 2017 +0100
packet-mq: Improve some display by adding CONST values
Change-Id: I66f9dc050735fd0a73b9938a9db0c5978cec40a4
Reviewed-on: https://code.wireshark.org/review/24834
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=28ba56667599c7a90c8492052b438f…
commit 28ba56667599c7a90c8492052b438f58aa963902
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 15 21:38:30 2017 +0100
wslua: Fix memory leakages
Free some variables in error handling.
Change-Id: I0d0653962b11f760c31872aa7e5b5f1d20c54dcb
Reviewed-on: https://code.wireshark.org/review/24842
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=183b9119dc4caa491cf58bc673a310…
commit 183b9119dc4caa491cf58bc673a3109a7ef8bcfd
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 16 00:24:40 2017 +0100
6LowPAN: always build IPv6 address whatever the tree state
Bug: 14277
Change-Id: I320def755076ef8c52d4e5e0dbedf06ea88f25a7
Reviewed-on: https://code.wireshark.org/review/24848
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=15a97b5986e9a5f23ebce233ecc844…
commit 15a97b5986e9a5f23ebce233ecc84401a5495abc
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Dec 15 15:35:29 2017 -0800
Qt: Show our recent files earlier.
Show the recent file list before it's been scanned so that the welcome
screen layout will be complete by the time we're done initializing.
Change-Id: I09f0a68c6d36f30e7cdb2958f82af38f52444c34
Reviewed-on: https://code.wireshark.org/review/24849
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=3071356d9e3d07d3c0132af88e4e8a…
commit 3071356d9e3d07d3c0132af88e4e8af785deb3ee
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 15 22:49:18 2017 +0100
Qt: A node without a child can not be expanded
Change-Id: I28bb5797e8eab69c761e257b90a11c646d06cf68
Reviewed-on: https://code.wireshark.org/review/24845
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=adde937ed74926323b084713caf6fb…
commit adde937ed74926323b084713caf6fbba871d8791
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 15 00:04:32 2017 +0000
plugins: Remove redundant plugin.rc.in files
plugin.rc is Windows specific, also add condition to reflect that.
Change-Id: Ibbb7dab77dd1f277e2302c8f931218ca433f8c72
Reviewed-on: https://code.wireshark.org/review/24833
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cf5a58f72a58c36744878cd6eb640d…
commit cf5a58f72a58c36744878cd6eb640de669341a55
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Dec 15 10:59:11 2017 -0800
Qt: Initialize QFontDatabase in a worker thread.
QFontDatabase uses an internal list of system fonts which might take a
while to initialize depending on your platform and hardware. On my
notebook here it takes about 45 to 50 ms. Create a worker thread for
QFontDatabase initialization similar to QMimeDatabase.
Change-Id: Ieff683b023537a6c104a80f2611ea1e966b65610
Reviewed-on: https://code.wireshark.org/review/24841
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=2acaf0a47a643ff929ecf9354d62a6…
commit 2acaf0a47a643ff929ecf9354d62a642794bbbd1
Author: Matej Tkac <matej.tkac.mt(a)gmail.com>
Date: Wed Dec 13 16:47:19 2017 +0100
[ISAKMP] Added support for new Notify EMERGENCY_CALL_NUMBERS Payload
In accordance with the latest 3GPP TS 24.302 (Section 8.2.9.8)
3GPP TS 24.008 (Section 10.5.3.13)
Bug: 14273
Change-Id: Ib5a24fa33633764f6bfb034250c309c1f4af9914
Reviewed-on: https://code.wireshark.org/review/24793
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=774a986ec07be46263e7acbbec4fbb…
commit 774a986ec07be46263e7acbbec4fbb69563a95a1
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 15 13:41:21 2017 +0100
epan: Add default type handling for custom column
Add default type handling in proto_custom_set() to prevent crashes when
trying to use FT_IPXNET, FT_AX25 or FT_VINES items as custom columns.
This will also work as a safeguard when adding new types.
Change-Id: Iaf3b48aec72f0e5c10332b0e6d5f7221b0196e15
Reviewed-on: https://code.wireshark.org/review/24836
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bdb6baa7405d259fa2cd2f6f7d2fb2…
commit bdb6baa7405d259fa2cd2f6f7d2fb21e13315885
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 7 08:15:30 2017 -0800
Qt: Switch ProtoTree to a treeview+model.
Add a ProtoTreeModel and use it in ProtoTree. This should make the UI
more responsive when we have lots of items in the tree.
Change-Id: Id26e6bcff84663867a8da17fd9ae86ff639b633f
Reviewed-on: https://code.wireshark.org/review/24774
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0909580a7e98c134785a96829b5807…
commit 0909580a7e98c134785a96829b58076534b477b6
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Tue Dec 12 09:21:40 2017 -0800
ieee80211: Add handling of the ANQP Neighbor Report.
Change-Id: I857cdcc3a15cd01c3b5cc7e31be043048ef5f1ed
Reviewed-on: https://code.wireshark.org/review/24784
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1651371d17e56a9f77270aa2c6d623…
commit 1651371d17e56a9f77270aa2c6d6239a6506b16e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 15 15:48:50 2017 +0100
epan: Whitespace fixes
Change-Id: I859c7bf5cfaf23b46d2cda7ff9c7e1ddd164832a
Reviewed-on: https://code.wireshark.org/review/24838
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a51ac8d398aeedf9a678188147a89b…
commit a51ac8d398aeedf9a678188147a89bf1ee035443
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 15 14:35:44 2017 +0100
Qt: Fix translating some texts
Change-Id: I8267bfd96efe9d9d086913ff418a74a68e63b8da
Reviewed-on: https://code.wireshark.org/review/24837
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8a4436e97eaddca301e8b258f7a1c…
commit a8a4436e97eaddca301e8b258f7a1ca9688af4f9
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 15 09:19:24 2017 +0000
debian/rules: Fix typo
Change-Id: I3fea8e42af2f51700f283cbcdc45ac3420979cd9
Reviewed-on: https://code.wireshark.org/review/24835
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=90102ad12ec601abcc2270e4779f8d…
commit 90102ad12ec601abcc2270e4779f8d2fc1c0c937
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 14 14:13:39 2017 -0800
Remove a plugin_if_gui_cb type conversion.
We always pass a GHashTable * to plugin_if_gui_cb so don't cast it to a
gconstpointer. This should fix the following and related warnings:
main_window.cpp: In function ‘void plugin_if_mainwindow_apply_filter(gconstpointer)’:
main_window.cpp:121:44: warning: cast from type ‘gconstpointer {aka const void*}’ to
type ‘GHashTable* {aka _GHashTable*}’ casts away qualifiers [-Wcast-qual]
GHashTable * data_set = (GHashTable *) user_data;
Fix another const warning while we're here.
Change-Id: Ia9225188bfb913feb4fef4369f10fd5791fc8dc9
Reviewed-on: https://code.wireshark.org/review/24830
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=afc6e773dc84ddcf57af59e0fd87ab…
commit afc6e773dc84ddcf57af59e0fd87ab1625204786
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Dec 14 23:58:00 2017 +0100
Fix registration of wiretap plugins
Change-Id: I1277870cab348feda7e23cffb277410bd4b10a0e
Reviewed-on: https://code.wireshark.org/review/24832
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=db140dd500227c1a7c2223c1c86881…
commit db140dd500227c1a7c2223c1c868812e08253493
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Aug 27 20:53:23 2017 +0100
Add new dissector callback signature with data pointer
This is useful to implement language bindings (Lua, Python, etc) and
good practice in general.
Non-breaking change to the API.
Change-Id: I8d16c14880e5aa53212af8418c468a6ec3aa8954
Reviewed-on: https://code.wireshark.org/review/24814
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=cebb8ea20ec2d4c1c1c000304c6cc6…
commit cebb8ea20ec2d4c1c1c000304c6cc6e7e9ccb8ad
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Aug 29 15:34:31 2017 +0100
Add new plugin type for libwireshark
Allow epan itself to be extended by plugins. Adds the following new plugin
interfaces:
void plugin_epan_init()
void plugin_epan_dissect_init(epan_dissect_t *)
void plugin_epan_dissect_cleanup(epan_dissect_t *)
void plugin_epan_cleanup()
void plugin_epan_register_all_protocols(register_cb, gointer) [OPTIONAL]
void plugin_epan_register_all_handoffs(register_cb, gointer) [OPTIONAL]
Any one of these can be an empty function but the first four must be
present.
The motivation for the change is a better way to implement a language binding
other than registering a fake protocol and stuffing everything into a single
dissector call (and maybe require an extra packet_info field) but I expect
there would be other interesting use cases.
Change-Id: I215d50750ac7561fe25fdcdcfbc6a3f351984785
Reviewed-on: https://code.wireshark.org/review/24813
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=629596ebefa34a2677c341ab899e51…
commit 629596ebefa34a2677c341ab899e51cecbe254f0
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 14 16:53:59 2017 +0000
Qt: Constify a variable.
Change-Id: Icb3ce93d24ffbdf4ac6d3b70e7baa1f991169ac3
Reviewed-on: https://code.wireshark.org/review/24823
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=db740987fffeb7e8122a6cd40e25f1…
commit db740987fffeb7e8122a6cd40e25f16244af5721
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 14 10:29:48 2017 -0800
Qt: Add and use qUtf8Printable.
Qt 5.4 introduced qUtf8Printable, a convenience macro for converting
QString to a UTF-8 const char *. Add a compatibility definition and
start using it.
Change-Id: I3cf88611b1ed1a34082cb2ba82394954e2e6c461
Reviewed-on: https://code.wireshark.org/review/24828
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=4cf7cd3ed20c57dc5977be5be37ced…
commit 4cf7cd3ed20c57dc5977be5be37ced0bd1706d61
Author: Derick Rethans <github(a)derickrethans.nl>
Date: Thu Dec 14 17:14:32 2017 +0000
Register the MongoDB dissector as SSL capable.
Bug: 14275
Change-Id: Ia0d8d0b333f69e59ba54b0d788587484dfae950e
Reviewed-on: https://code.wireshark.org/review/24827
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fe4cf449c9787bcfd234db22674a0f…
commit fe4cf449c9787bcfd234db22674a0f49fee04ff0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Dec 14 17:13:23 2017 +0000
fp_mux: fix 'data' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: Ieac1b7a19d50c35d565421e1012dfb4001b6dd44
Reviewed-on: https://code.wireshark.org/review/24826
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0ffee1526be20b3791cececfbfa490…
commit 0ffee1526be20b3791cececfbfa490ed2d22dece
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Dec 14 17:11:10 2017 +0000
ciscodump(extcap): fix 'packet' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: I04a52c37404fe6a91740b766de1482376d7128fa
Reviewed-on: https://code.wireshark.org/review/24825
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=83b052562096830b024aff83046908…
commit 83b052562096830b024aff830469086b1ec933d1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Dec 14 17:10:02 2017 +0000
firewall_rules(ui): fix 'ptype' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: Iadc3717cdbdbde8d863ed822ef3ad29256e099f0
Reviewed-on: https://code.wireshark.org/review/24824
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=11a948dd121f04448ff765ec36dafb…
commit 11a948dd121f04448ff765ec36dafbf8e8415fb5
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Dec 14 10:30:27 2017 +0100
[ISUP] Update value strings from specification amendment.
Change-Id: Ib3dff9c438b9adbec4533f1a66f1bf07f51dbd07
Reviewed-on: https://code.wireshark.org/review/24821
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9401571a244366d74f4998ffb0b9ac…
commit 9401571a244366d74f4998ffb0b9acb7365cd57d
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Thu Dec 14 11:25:29 2017 +0100
Qt: Add QtCreator generated files to gitignore
Change-Id: Id3ba4eede12de954bdc34d906abf2a84dc3e1cdd
Reviewed-on: https://code.wireshark.org/review/24822
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=995812c5f1add94df1c23759693913…
commit 995812c5f1add94df1c237596939130c1704b099
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 1 00:56:03 2017 +0100
Refactor plugin registration and loading
Put different types of plugins (libwiretap, libwireshark) in different
subdirectories, give libwiretap and libwireshark init routines that
load the plugins, and have them scan the appropriate subdirectories
so that we don't even *try* to, for example, load libwireshark plugins
in programs that only use libwiretap.
Compiled plugins are stored in subfolders of the plugin folders, with
the subfolder name being the Wireshark minor version number (X.Y). There is
another hierarchical level for each Wireshark library (libwireshark, libwscodecs
and libwiretap).
The folder names are respectively plugins/X.Y/{epan,codecs,wiretap}.
Currently we only distribute "epan" (libwireshark) plugins.
Change-Id: I3438787a6f45820d64ba4ca91cbe3c8864708acb
Reviewed-on: https://code.wireshark.org/review/23983
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=a9821caab8a1f2c6e265bd5b63a060…
commit a9821caab8a1f2c6e265bd5b63a060f1f241c704
Author: Pavel Moravec <pmoravec(a)redhat.com>
Date: Sat Nov 25 15:57:57 2017 +0100
Add dissector for ActiveMQ Artemis Core Protocol
So far decode just packet headers
Change-Id: I7a01f3c83b97882f4c669122ad94b2bdab0ab251
Signed-off-by: Pavel Moravec <pmoravec(a)redhat.com>
Reviewed-on: https://code.wireshark.org/review/24583
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=862a0b6472529ef6676c8bc56dd8f0…
commit 862a0b6472529ef6676c8bc56dd8f0be5166fd7c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 13 11:36:37 2017 +0100
epan: Make expert info summary text mandatory
This will make the code easier and removes the use of a generic
"Expert Info" as name.
Change-Id: I57ad2adb851726106ddc5009f3c6ca61721f647a
Reviewed-on: https://code.wireshark.org/review/24792
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=11ccd830685e4037c3cce04a3dbfd2…
commit 11ccd830685e4037c3cce04a3dbfd2d05a5145f7
Author: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Date: Sat Dec 2 17:42:16 2017 -0500
Fix detection of Lua when there's no pkgconfig file.
Linking with liblua requires libdl on Linux; if the test link with liblua
fails try including libdl.
Fixes the problem reported in:
https://www.wireshark.org/lists/wireshark-dev/201711/msg00102.html
Change-Id: I8561f15f8d9adbab52d668d102811fb821b45034
Reviewed-on: https://code.wireshark.org/review/24678
Petri-Dish: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a9f50164298d641be3d107261e8ec1…
commit a9f50164298d641be3d107261e8ec1166a6fcf2a
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Tue Dec 12 19:20:18 2017 -0800
ieee1905: Fix an incorrect flags dissection.
Change-Id: Iebb434875eac08aeabab6b9179a882817149012c
Reviewed-on: https://code.wireshark.org/review/24820
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c662615ab4c0ecb48443412a27b769…
commit c662615ab4c0ecb48443412a27b769e73ed084d4
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Wed Dec 6 18:51:03 2017 -0800
ieee1905: Fix for a malformed packet with a Steering request.
If the mode bit is zero, we have to do different things than if
it is 1.
Change-Id: I5ed8bec1d350c02b736818cad5ab864748145686
Reviewed-on: https://code.wireshark.org/review/24775
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6af7b9a63ad8c7ce7b57e0d8adcb5e…
commit 6af7b9a63ad8c7ce7b57e0d8adcb5e61d70a2123
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Dec 13 19:16:28 2017 -0800
Register the UDS dissector by name.
See
https://ask.wireshark.org/question/891/use-uds-dissector-inside-doip-dissec…
Change-Id: I608b4ffb90e65fd31e9f3e421f4c473f4e66bebd
Reviewed-on: https://code.wireshark.org/review/24818
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7539469d79d80944ab2daa389aade7…
commit 7539469d79d80944ab2daa389aade7991302835d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Dec 13 18:44:17 2017 -0800
Fix types.
ftell() returns a long; assign its value to a variable of that type.
size_t is unsigned, so checking that it's >= 0 always succeeds.
We can cast the variable's value to size_t once we've determined that
it's
non-negative; do so, to avoid other warnings.
Change-Id: I0da6a220ce140ebf073df5f5bcd0c9526bf9c3c3
Reviewed-on: https://code.wireshark.org/review/24817
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6d30df0cdd83b051e02b1e90a905b7…
commit 6d30df0cdd83b051e02b1e90a905b7e51031cd22
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Dec 13 18:38:23 2017 -0800
Replace a comma with a semicolon, which it presumably was intended to be.
Change-Id: I308752a50b465a2772172c3500f6417a3ae19f11
Reviewed-on: https://code.wireshark.org/review/24816
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c781bd41100fa2080c4062dc34b5bf…
commit c781bd41100fa2080c4062dc34b5bfb4e4175180
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Dec 13 16:40:41 2017 -0800
Qt: Fix a cast.
Just use a const_cast instead of messing with compiler settings.
Change-Id: I35d3498ac4c2817d02cbf11497a70f72b60b58bb
Reviewed-on: https://code.wireshark.org/review/24815
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=cb748178feffd35146222fad14b898…
commit cb748178feffd35146222fad14b898cb4604f7cb
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Dec 12 01:05:39 2017 +0000
Add doc/README.build-system with CMake and autotools information
Currently more autotools than CMake.
Change-Id: I167f0bdd49d70d72f6155a4d978975c034ce3b4a
Reviewed-on: https://code.wireshark.org/review/24773
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=801ee01affeac724c063c8c643fde9…
commit 801ee01affeac724c063c8c643fde9459b4f0ceb
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Wed Dec 13 17:03:15 2017 +0100
Qt: Add ui, qrc and qm files to source
Autogen had the resulting effect, that IDE's no longer see
those files as part of the source tree, and therefore do not
show them. This fixes it.
Change-Id: Ia1f259743ba5b63f5bc47da79afca90a9fabc07b
Reviewed-on: https://code.wireshark.org/review/24794
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b0112e60ada68646b3e304f73f8321…
commit b0112e60ada68646b3e304f73f8321f5fb1ddc01
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Jun 28 20:00:38 2017 -0400
Add a model to use for Expert Info dialog.
With the model (and proxy), the following features were added/fixed.
1. Expert severities can be filtered by type
2. Search filter expanded to include summary, protocol and column info
3. Expert info starts with all items collapsed.
4. Context menus for collapse/expand all
Bug: 11753
Bug: 13831
Bug: 13842
Change-Id: I8e89c7be441e1f08e18915ef8805609e5c5d0bd1
Reviewed-on: https://code.wireshark.org/review/22458
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f945b85391976bc59da4b542fe84cb…
commit f945b85391976bc59da4b542fe84cb58033bd22e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 12 23:34:03 2017 +0100
epan: Use expert info summary text as field name
Change the expert info registry to use summary text as field name instead
of blurb to show the correct column header tooltip in custom columns.
Preserve backward compability by not use empty summary text.
Change-Id: Ibbaf142165be0d9f42d1e2476f39f8d251ea0593
Reviewed-on: https://code.wireshark.org/review/24788
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e4750105b23c2e19cfa4fbb79679b4…
commit e4750105b23c2e19cfa4fbb79679b4a045ec0ebe
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 12 23:29:24 2017 +0100
epan: Show a check mark in custom columns for FT_NONE types
This is valuable when adding a expert info field as custom column,
but will also make sense for other FT_NONE types.
Change-Id: Ib1a14c59a5450f2e713f190aecf3484586d116c4
Reviewed-on: https://code.wireshark.org/review/24787
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=2c36df54a34494015772d3342cc981…
commit 2c36df54a34494015772d3342cc9819cad0669b1
Author: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Date: Sat Dec 2 18:32:23 2017 -0500
Fix RPM build: include the User Guide.
The User Guide has been installed by default since
I9dd539c737cb3777dc1351707b9e45a3a6764aaa.
Fixes problem reported in:
https://www.wireshark.org/lists/wireshark-dev/201711/msg00162.html
Change-Id: I462c7c18869e8df93785e1898364e248e897de50
Reviewed-on: https://code.wireshark.org/review/24679
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=158d9298840434f2770c96bd3b8d2f…
commit 158d9298840434f2770c96bd3b8d2f44792932d1
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 12 15:36:26 2017 +0100
epan: Use check mark in protocol custom column
Change from the text "Yes" to a utf8 check mark to indicate the
precense of a protocol in custom columns.
Change-Id: I9510333fc12148bf1f61aa2ddea2c6d390a9491a
Reviewed-on: https://code.wireshark.org/review/24783
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=16e5d73ecc6630411153b4f46b0d13…
commit 16e5d73ecc6630411153b4f46b0d137fb78c1240
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 12 20:27:38 2017 +0100
nfapi: Add missing expert info summary
Change-Id: Iba6330f9c7f27e82adfa967fe9b082920a5b0afa
Reviewed-on: https://code.wireshark.org/review/24785
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=326591ef6da8f5024a6c93721ea896…
commit 326591ef6da8f5024a6c93721ea896cad0578f4c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Dec 12 09:19:03 2017 +0100
fuzzer: add check for ftell return value (CID: 1426073).
Change-Id: I9b619c79433f267d87f6680eeb78a25daa169f4d
Reviewed-on: https://code.wireshark.org/review/24778
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=91f63908df560e0ed22cad12ba6cc4…
commit 91f63908df560e0ed22cad12ba6cc43f81d60f9f
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 12 09:18:57 2017 +0100
cmake: Remove -Wcomma for C++ when using Qt >= 5.10
The Qt team introduced a lot of "Possible misuse of comma operator here"
warnings in qstring.h and qstringview.h in version 5.10. Now we need to
fix the Qt source again.
Change-Id: I948ba5a224d4dca1ebb6a758100c064d501c1d4a
Reviewed-on: https://code.wireshark.org/review/24779
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=621498f88e882dbe8cc3a2c8373bb3…
commit 621498f88e882dbe8cc3a2c8373bb342bb0dbe77
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Dec 9 18:34:31 2017 +0100
qt: follow stream: fix crash during close
The Follow Stream dialogue's button "Filter out this stream" filters
out
the stream's packets and then closes the Follow Stream dialogue. This may
take a moment. If the user presses the Close button while the filtering
is still running, the dialogue will be closed twice. This causes a crash
which can be seen in ASAN builds.
==9485==ERROR: AddressSanitizer: SEGV on unknown address 0x60205e80001b (pc
0x7f923e672b8c sp 0x7fff73104600 bp 0x7fff73104600 T0)
#0 0x7f923e672b8b in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
(/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2d9b8b)
#1 0x7f924f46010b in QApplicationPrivate::notify_helper(QObject*, QEvent*)
(/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x13f10b)
#2 0x7f924f4655ff in QApplication::notify(QObject*, QEvent*)
(/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x1445ff)
#3 0x7f923e672dca in QCoreApplication::notifyInternal(QObject*, QEvent*)
(/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2d9dca)
#4 0x7f924f49ae54 in QWidgetPrivate::close_helper(QWidgetPrivate::CloseMode)
(/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x179e54)
#5 0x55f3e249582f in FollowStreamDialog::close()
/media/sf_wireshark.git/ui/qt/follow_stream_dialog.cpp:327
#6 0x55f3e236e534 in FollowStreamDialog::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**) ui/qt/moc_follow_stream_dialog.cpp:155
...
SUMMARY: AddressSanitizer: SEGV ??:0
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*)
==9485==ABORTING
Ignore the Close button if we know that we'll be closing the dialogue shortly.
Change-Id: Ibf1684fd75937e6b24fcb9ea62ae6acb038260e6
Reviewed-on: https://code.wireshark.org/review/24777
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5aa50639acc774a65df9be99ed44d9…
commit 5aa50639acc774a65df9be99ed44d90e7615646a
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Mon Dec 11 20:18:00 2017 -0800
ieee80211: Add additional ANQP IEs defined in IEEE802.11-2016.
Dissect the Venue URL element. More to come.
Change-Id: I64330b3f90f9f6222df0fb00d3ea277f59424e98
Reviewed-on: https://code.wireshark.org/review/24776
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=34b62c60bfad56275dca48242c7e47…
commit 34b62c60bfad56275dca48242c7e477f33b691ef
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Dec 11 14:41:58 2017 -0800
Revert "Move fill_in_local_interfaces to a thread."
Calling scan_local_interfaces ends up calling fork via extcap. Doing so
from a thread is ill-adivsed:
https://rachelbythebay.com/w/2014/08/16/forkenv/
http://www.linuxprogrammingblog.com/threads-and-fork-think-twice-before-usi…
This reverts commit 5b4894b7959f44e077f36194c490cbf402e1e659.
Revert "fix compilation without pcap." as well.
This reverts commit 51300b3c834a3877d567fb57ae78ec74ec8ba80d.
Change-Id: Ic80582b52398c44af73c6d74dbb3216c4d1b37fc
Reviewed-on: https://code.wireshark.org/review/24772
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=10e98462520b5dcfa1e5d7b80e53a9…
commit 10e98462520b5dcfa1e5d7b80e53a95725d91d94
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Mon Dec 11 22:33:11 2017 +0000
SIP statistics: use flipped indices for tables when incrementing stats
Change-Id: I22ed38b1c2d7849e8930149fb39ee14fa198a6e1
Reviewed-on: https://code.wireshark.org/review/24771
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7617af1d8994289da23402b67ccea7…
commit 7617af1d8994289da23402b67ccea79e32881888
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Dec 11 19:32:31 2017 +0000
Fix make distcheck
Change-Id: I0c5a31d423d19071dc6ed0a42b064271e5f63fd2
Reviewed-on: https://code.wireshark.org/review/24769
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=51300b3c834a3877d567fb57ae78ec…
commit 51300b3c834a3877d567fb57ae78ec74ec8ba80d
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Dec 11 11:29:07 2017 +0100
fix compilation without pcap.
Fix a regression introduced by I09beab751c9c2917f017b6c082166d86ca693544.
Change-Id: I57b971086470e836f4147500143c35494118e754
Reviewed-on: https://code.wireshark.org/review/24765
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c9546dfceb778dcabe7a830272add6…
commit c9546dfceb778dcabe7a830272add62e6ae1403e
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 11 13:56:12 2017 +0100
[capture_info] Move capture_info_new_file() to capture.c
Change-Id: I9137af6461921d7553a8968743f61f2265424061
Reviewed-on: https://code.wireshark.org/review/24767
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=84f905786ed2b2aabaec9a0c1045da…
commit 84f905786ed2b2aabaec9a0c1045daeda66358ba
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 11 13:10:30 2017 +0100
[capture_info] Fold the code of capture_info_open() into ui/capture.c
Change-Id: Id302e88bed4da8b9b457049fb78b0bc7d7ffabe3
Reviewed-on: https://code.wireshark.org/review/24766
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=397e2a2d74e9c6ea103d3b4c307945…
commit 397e2a2d74e9c6ea103d3b4c30794552041e39c2
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Dec 7 22:29:38 2017 +0100
gitlab-ci: restyle the gcc builds
The gcc builds now take the package from the official
gcc ppa and use the ubuntu 16.04 docker image. The
gcc docker image was shipped with a old Qt version
that caused some errors.
Change-Id: Ieefbda99cd0931ff3043de6caa4cccd163589759
Reviewed-on: https://code.wireshark.org/review/24736
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=faa4a6a5f12b507e12232ceefb9ceb…
commit faa4a6a5f12b507e12232ceefb9cebdaf6b7ee24
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Dec 10 23:06:40 2017 +0000
SIP statistics: fix problems with invalid items
Change-Id: Ide21489cad66e4bebaafe5ef813a000db2956a2e
Reviewed-on: https://code.wireshark.org/review/24759
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5b4894b7959f44e077f36194c490cb…
commit 5b4894b7959f44e077f36194c490cbf402e1e659
Author: Gerald Combs <gerald(a)zing.org>
Date: Sat Dec 9 17:52:08 2017 -0800
Move fill_in_local_interfaces to a thread.
Move fill_in_local_interfaces to a worker thread and start it as early
as possible. Add a mutex for global_capture_opts.
Change-Id: I09beab751c9c2917f017b6c082166d86ca693544
Reviewed-on: https://code.wireshark.org/review/24757
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d5ad701b494c29dd5ae5e44ecb5f9…
commit 0d5ad701b494c29dd5ae5e44ecb5f9a42c423f5b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Dec 11 03:37:44 2017 +0000
Fix make distcheck
Change-Id: Ie0e6ef4595be4f981b919ed609cc62a0595c3320
Reviewed-on: https://code.wireshark.org/review/24764
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=5fc43fe63a07062587bc3d76256f42…
commit 5fc43fe63a07062587bc3d76256f4240221e8bc7
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Dec 10 17:29:40 2017 +0000
Rewrite make-tap-reg.py in C
Change-Id: Ief5b1fffecc9712c01ff10292c403b7c84a5908a
Reviewed-on: https://code.wireshark.org/review/24756
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=224e24884a8b37732105bd40a0ee85…
commit 224e24884a8b37732105bd40a0ee85d5feaaeab1
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Dec 10 23:09:54 2017 +0100
NTP: fix authenticator dissection when padding is used
Bug: 14269
Change-Id: Ifdc9af7524a0566e33acbedff3757cff416ce8fb
Reviewed-on: https://code.wireshark.org/review/24758
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7d383637865e2f1f0de7a8921261f4…
commit 7d383637865e2f1f0de7a8921261f406f42af4bf
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Dec 10 22:17:04 2017 +0100
NTP: fix parsing of multiple comma separated identifiers
Bug: 14268
Change-Id: Id1d6040052d34d3f8bdfe49d20f4f3f8efbe001b
Reviewed-on: https://code.wireshark.org/review/24755
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=91548948bbe2bba844a65c62975dad…
commit 91548948bbe2bba844a65c62975dada05dd4c03e
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 10 08:16:48 2017 +0000
[Automatic update for 2017-12-10]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: If3becbd6b66f0a7a49a80c4ff2dc2a2a6015fa16
Reviewed-on: https://code.wireshark.org/review/24752
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=d0d1eaadf0c92e37b6ed2883583f71…
commit d0d1eaadf0c92e37b6ed2883583f71b7b9ec3a7e
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Dec 8 10:44:44 2017 -0800
Win32: Add checks for _WIN32_WINNT and NTDDI_VERSION.
Check to see if we're the source of truth for _WIN32_WINNT and
NTDDI_VERSION in config.h and emit a compiler error if we aren't.
Rearrange the #includes in ui/qt/data_printer.cpp so that config.h is
included first. This fixes the following:
136>C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\config.h(411):
warning C4005: 'NTDDI_VERSION': macro redefinition (compiling source file
C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp)
[C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\ui\qt\qtui.vcxproj]
C:\Program Files (x86)\Windows
Kits\10\Include\10.0.15063.0\shared\sdkddkver.h(223): note: see previous definition of
'NTDDI_VERSION' (compiling source file
C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp)
136>C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\config.h(412):
warning C4005: '_WIN32_WINNT': macro redefinition (compiling source file
C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp)
[C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\ui\qt\qtui.vcxproj]
C:\Program Files (x86)\Windows
Kits\10\Include\10.0.15063.0\shared\sdkddkver.h(213): note: see previous definition of
'_WIN32_WINNT' (compiling source file
C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp)
Change-Id: I90886cb9450463d768d6529ccd678ca11508cde2
Reviewed-on: https://code.wireshark.org/review/24744
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3d673da88c5ff4e56cbb3cf713b8c4…
commit 3d673da88c5ff4e56cbb3cf713b8c49704e62923
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Dec 9 22:24:10 2017 -0500
Convert to using use SPDX identifier on wsutil directory
Change-Id: Id73e641499e75bc1afc1dea29682418156f461fe
Reviewed-on: https://code.wireshark.org/review/24751
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8225159e336610c25fb4d4129b0be1…
commit 8225159e336610c25fb4d4129b0be156ed487c49
Author: Derick Rethans <github(a)derickrethans.nl>
Date: Mon Dec 4 18:31:03 2017 +0000
Add support for MongoDB OP_COMPRESSED packets
Bug: 14259
Change-Id: Iab6b494bebaa913267f94d41b7950b67dd406cb6
Reviewed-on: https://code.wireshark.org/review/24705
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=22a7d8fa8d8b8c7171ede55e7f413d…
commit 22a7d8fa8d8b8c7171ede55e7f413d004cb7b099
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Fri Dec 8 18:21:04 2017 +0100
SOCKS: Display right version in pseudo header
Use the previous recorded version as version and set field as generated.
Bug: 14262
Change-Id: I0872ed826ccd8a5a1b75b071d810404d08ddc7b3
Reviewed-on: https://code.wireshark.org/review/24741
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8cb9a094bf1d08ffb100a384de03a9…
commit 8cb9a094bf1d08ffb100a384de03a9774f7183c0
Author: Marko Hrastovec <marko.hrastovec(a)gmail.com>
Date: Fri Dec 8 20:41:16 2017 +0100
asterix: wrong presentation of fields I009/080 in CAT009.
Fields I009/080 were wrongly represented for CAT009. 8 and 16 bit
long fields were represented as 24 bit.
Change-Id: I5bd1c1f006292f58d0290ced80dde22324cb4002
Reviewed-on: https://code.wireshark.org/review/24746
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=abd703c4b80e47d5097a74cbba4911…
commit abd703c4b80e47d5097a74cbba4911e9ef83d2fb
Author: Anton Glukhov <anton.a.glukhov(a)gmail.com>
Date: Fri Dec 8 12:37:25 2017 +0100
LLDP: Add 802.3 TLV Additional Ethernet Capabilities (Subtype 7)
Bug: 14267
Change-Id: I23eb82a2f9bb2d57952f71870cc0fc8f12f036df
Signed-off-by: Anton Glukhov <anton.a.glukhov(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24735
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c79fb9d0285fbf51d6cdc3770396a8…
commit c79fb9d0285fbf51d6cdc3770396a8add08321ec
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Dec 9 12:00:52 2017 +0000
make-dissectors: Indent and cleanup #include
Change-Id: I395d0c168a6ba2fc8fad85598e6355493b897a7a
Reviewed-on: https://code.wireshark.org/review/24748
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=514e607dd911d8bc5eabcadb8840b3…
commit 514e607dd911d8bc5eabcadb8840b34fd238b745
Author: Matej Tkac <matej.tkac.mt(a)gmail.com>
Date: Fri Dec 8 16:11:21 2017 +0100
[MIPv6] Fixed IPv4 Home Address Option
Change-Id: I1c09ac390d5a40c92fc30cf114a3a13359b46eee
Reviewed-on: https://code.wireshark.org/review/24738
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d96ef7ed05a9f3219742699988faae…
commit d96ef7ed05a9f3219742699988faae3889334c85
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Dec 3 13:49:36 2017 +0000
Allow switching direction in LTE RLC graph
Change-Id: I1681089aebe7f00b2b84ece00c53a3bf8769d50b
Reviewed-on: https://code.wireshark.org/review/24682
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f8203771ec1580013e8de21e6286a3…
commit f8203771ec1580013e8de21e6286a33c330f08e3
Author: Marko Hrastovec <marko.hrastovec(a)gmail.com>
Date: Fri Dec 8 20:36:10 2017 +0100
Typing error correction for CAT002 settings selection.
Two settings had the same string "Select the CAT001 version".
One should be CAT002.
Change-Id: Iee6204a1064af786338d1b53c7b983763b985a0c
Reviewed-on: https://code.wireshark.org/review/24745
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=157ea91f2eb583a1f5815b4fb076ce…
commit 157ea91f2eb583a1f5815b4fb076ce78498617b8
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Dec 8 18:52:34 2017 +0100
oss-fuzzshark: fix compilation.
/src/wireshark/tools/oss-fuzzshark/fuzzshark.c:268:58: error: too few arguments to
function call, expected 2, have 1
fuzz_handle = get_dissector_handle(FUZZ_DISSECTOR_TARGET);
~~~~~~~~~~~~~~~~~~~~ ^
/src/wireshark/tools/oss-fuzzshark/fuzzshark.c:133:1: note:
'get_dissector_handle' declared here
Change-Id: I6c6e25017f0045b833d9249c9648145893fe0439
Reviewed-on: https://code.wireshark.org/review/24742
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=2cee4f432feddc5deb48154a97fcb6…
commit 2cee4f432feddc5deb48154a97fcb63823b4e6b4
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Dec 8 19:29:33 2017 +0100
Try to fix win32 build, add ui/packet_range.h include.
add ui/packet_range.h include to try to fix win32 build, compilation log:
export_sslkeys.c
99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73):
error C2143: syntax error: missing ')' before '*' (compiling source file
C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c)
[C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj]
99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73):
error C2081: 'packet_range_t': name in formal parameter list illegal (compiling
source file
C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c)
[C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj]
99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73):
error C2143: syntax error: missing '{' before '*' (compiling source file
C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c)
[C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj]
99>C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui/win32/file_dlg_win32.h(73):
error C2059: syntax error: ')' (compiling source file
C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\ui\gtk\export_sslkeys.c)
[C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\ui\gtk\gtkui.vcxproj]
Change-Id: I58c77fdcbe3fe2e738601c4ef97596c7774704ec
Reviewed-on: https://code.wireshark.org/review/24743
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=5d6315fefe6f2ffb1cafb3ad12522a…
commit 5d6315fefe6f2ffb1cafb3ad12522a57b43876ba
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Dec 8 16:01:33 2017 +0100
[SCTP] Export of reassembled PDU uses wrong tvb.
Change-Id: I87ff6ef54dff5900a4a92406c87693fec6d9f692
Reviewed-on: https://code.wireshark.org/review/24737
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8aa14236f8b0ea69901ea9ed87ebab…
commit 8aa14236f8b0ea69901ea9ed87ebabd0d278e973
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Dec 8 00:30:55 2017 -0800
Have the frame_tvbuff.c routines not use the global cfile.
Have the routines that create them take a pointer to a struct
packet_provider_data, store that in the tvbuff data, and use it to get
the wtap from which packets are being read.
While we're at it, don't include globals.h in any header files, and
include it in source files iff the source file actually uses cfile. Add
whatever includes that requires.
Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229
Reviewed-on: https://code.wireshark.org/review/24733
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f29b3deb6d867b16fb8bc4bd5f66a5…
commit f29b3deb6d867b16fb8bc4bd5f66a5b6326a6727
Author: Gizem Yurdagül <gizemnuryurdagul(a)gmail.com>
Date: Thu Dec 7 09:16:53 2017 +0300
PROFINET: AdjustMAUType-Extension and CheckMAUTypeExtension
disections are added.
According to specification,
AdjustMAUTypeExtension is a subblock for adjusting MAUTypeExtension.
CheckMAUTypeExtension is a subblock for checking MAUTypeExtension.
Change-Id: Ia90f204887a2e9871bc71e24978ab0095cc0fe1f
Reviewed-on: https://code.wireshark.org/review/24718
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Birol Capa <birol.capa(a)siemens.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=48e65c4af4e35c90d7cbc9fb789ecc…
commit 48e65c4af4e35c90d7cbc9fb789ecc6e740b300b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Dec 7 20:33:22 2017 -0800
Hand the packet provider functions to epan_new().
Have separate packet_provider_data structures and packet_provider_funcs
structures; the latter holds a table of functions that libwireshark can
call for information about packets, the latter holds the data that those
functions use.
This means we no longer need to expose the structure of an epan_t
outside epan/epan.c; get rid of epan/epan-int.h.
Change-Id: I381b88993aa19e55720ce02c42ad33738e3f51f4
Reviewed-on: https://code.wireshark.org/review/24732
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=797d2f6a87607b146a2ef62e1ff501…
commit 797d2f6a87607b146a2ef62e1ff501031dce8212
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Dec 7 19:31:43 2017 -0800
Move the frame_set stuff back into the capture_file structure.
libwireshark now expects an epan_t to be created with a pointer to a
"packet provider" structure; that structure is opaque within
libwireshark, and a pointer to it is passed to the callbacks that
provide interface names, interface, descriptions, user comments, and
packet time stamps, and that set user comments. The code that calls
epan_new() is expected to provide those callbacks, and to define the
structure, which can be used by the providers. If none of the callbacks
need that extra information, the "packet provider" structure can be
null.
Have a "file" packet provider for all the programs that provide packets
from a file.
Change-Id: I4b5709a3dd7b098ebd7d2a7d95bcdd7b5903c1a0
Reviewed-on: https://code.wireshark.org/review/24731
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0baa4458c5780b143ad4479d387202…
commit 0baa4458c5780b143ad4479d387202ddf4add06f
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Thu Dec 7 21:56:11 2017 +0100
sharkd: add sharkd_get_frame() to get frame_data, optimize.
Add sharkd_get_frame() wrapper to limit number of cfile usage.
Don't get frame_data when not needed.
Change-Id: I24b96b5b184196e9dbf632c0891b2954c8281eed
Reviewed-on: https://code.wireshark.org/review/24728
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=847585f938a525fb32ee4a0227cc50…
commit 847585f938a525fb32ee4a0227cc500316facc34
Author: Gerald Combs <gerald(a)zing.org>
Date: Thu Dec 7 18:20:19 2017 -0800
More QVector fixes.
Change-Id: I710f9c9d5391a8f1252cc02fdd263a8dfedb31f6
Reviewed-on: https://code.wireshark.org/review/24730
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=683087628b5ef63343f6e572289b8e…
commit 683087628b5ef63343f6e572289b8e90a3dd245b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 7 14:52:34 2017 -0800
Qt: Fix ByteViewText compilation for Qt < 5.5.
Older versions of Qt don't let you pass a QVector to QVector::append.
Change-Id: I58d62c44aa915d4ffb8319e08db85eee069ecbb2
Reviewed-on: https://code.wireshark.org/review/24729
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=038aa2a616db5ba658bee25dee5e55…
commit 038aa2a616db5ba658bee25dee5e55a716d4984a
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Dec 6 21:10:29 2017 +0100
Add fuzzshark to cmake/autotools.
Add fuzzshark target to make sure that oss-fuzzshark always build.
Change-Id: I802b679c18023daa1475a54bae722b5e90c72a59
Reviewed-on: https://code.wireshark.org/review/24716
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=8687fca8a821f95075e8c365c7422f…
commit 8687fca8a821f95075e8c365c7422f157845787b
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Thu Dec 7 20:37:54 2017 +0100
sharkd: fix coding style.
Change-Id: I62ff3f358d1efa3065077b0a913ba614f67f3fd7
Reviewed-on: https://code.wireshark.org/review/24727
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=42b191a65770dbad2d418dc62d0a58…
commit 42b191a65770dbad2d418dc62d0a58b9dd4e5f31
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Dec 7 17:06:33 2017 +0100
wsjsmn: use SPDX identifier.
Change-Id: Iefdfd06b3b063a0d497587142996f2cd986d413f
Reviewed-on: https://code.wireshark.org/review/24724
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=be8a40005328d74815491b3536b85f…
commit be8a40005328d74815491b3536b85fe9e532243e
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Nov 25 12:50:46 2016 -0600
Qt: Use QTextLayout in ByteViewText.
Use QTextLayout to draw each line in ByteViewText instead of drawing
fragments ourselves. Build our pixel-to-byte-offset map when we draw our
first line, which should hopefully make it more accurate. This should
fix layout and hover issues on some systems.
Start moving common code to DataPrinter.
Mark prefs.gui_hex_dump_highlight_style GTK+ only.
Bug: 11844
Change-Id: Ifda16ae7dc1a5ea22570c0bfd0eb20cee621bfc9
Reviewed-on: https://code.wireshark.org/review/24717
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f8b19c6eecbf241ecede5b85811a77…
commit f8b19c6eecbf241ecede5b85811a772469cea0df
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Dec 7 09:33:27 2017 +0000
transum(plugins): no previous prototype for function 'is_dcerpc_stream'
[-Wmissing-prototypes]
Change-Id: I3f60eae17b305e2d8982bba5f56d41121676555c
Reviewed-on: https://code.wireshark.org/review/24723
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=024e7dc8afb1d84365eeaaeadf029b…
commit 024e7dc8afb1d84365eeaaeadf029b242eac827f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Dec 7 09:28:39 2017 +0000
mongo: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I60ee2a37ff166b80ce11cf1c12e9c575bba85529
Reviewed-on: https://code.wireshark.org/review/24722
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Derick Rethans <github(a)derickrethans.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=244aab31ee83c72aa0cefae650abec…
commit 244aab31ee83c72aa0cefae650abec40ff1fd753
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Dec 6 22:29:19 2017 +0100
profinet: removed unused var.
Some compilers complain about it:
- clang (all)
- gcc 6
- gcc 7
../plugins/profinet/packet-dcerpc-pn-io.c:2608:27: error: unused variable
'pn_io_mau_type_extension' [-Werror,-Wunused-const-variable]
static const range_string pn_io_mau_type_extension[] = {
Change-Id: Iaffdad31c4ecd7459d07a74e3e2665058c9ff9ba
Reviewed-on: https://code.wireshark.org/review/24715
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b59c39b271e1cb39e4faa54f1af4bf…
commit b59c39b271e1cb39e4faa54f1af4bfcc2a602807
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Dec 6 19:51:18 2017 +0100
frame user comments: move to epan, add support for user comments in sharkd.
Change-Id: Id15edc60177b160fd09cae99de1c9e01e17d9421
Reviewed-on: https://code.wireshark.org/review/24714
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=038fe4c2d44da58ca626cc0fb63c48…
commit 038fe4c2d44da58ca626cc0fb63c482ced660f84
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Dec 6 19:06:34 2017 +0100
oss-fuzzshark: fix handler of epan->get_frame_ts to fix build.
Fix oss-fuzzshark build after [1834dca3654ccec238bae130715871be3d8fa344]: Move the
parts of a capture_file used by libwireshark to a new structure.
I really need to integrate oss-fuzzshark with build system...
Change-Id: I75595db392acfbdb7885975e458d8b434830cfec
Reviewed-on: https://code.wireshark.org/review/24713
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=2a385334eafb4385c25845ab611433…
commit 2a385334eafb4385c25845ab6114338cc160c27e
Author: Kevin Cernekee <cernekee(a)chromium.org>
Date: Sun Dec 3 16:09:17 2017 -0800
netlink-netfilter: Add NFQA_CT and NFEXP conntrack dissectors
Add support for the netlink messages used by userspace conntrack
helpers.
Change-Id: I37d3829399834f578a0ab0f08eab99f119445ff5
Reviewed-on: https://code.wireshark.org/review/24695
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=27f7bbbec20966c671eeb094caad03…
commit 27f7bbbec20966c671eeb094caad0399f54d8203
Author: gizem.yurdagul <gizemnuryurdagul(a)gmail.com>
Date: Tue Dec 5 13:14:06 2017 +0300
PROFINET: AdjustPeerToPeerBoundary disection is added.
According to specification, AdjustPeerToPeerBoundary is
a subblock for adjusting the peer to peer boundary.
Change-Id: I4036aa08509300e0b8533c94b991c9a21077f634
Reviewed-on: https://code.wireshark.org/review/24710
Reviewed-by: Birol Capa <birol.capa(a)siemens.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=99ea13988da6a6e5234aa4f5f3614b…
commit 99ea13988da6a6e5234aa4f5f3614b9aacfe1c5b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Dec 5 11:31:05 2017 -0800
Qt: Speed up the splash overlay.
Instead of blurring the main welcome screen during startup, draw a dark
band under the progress bar. This reduces the startup time a bit here.
Port over a date check from the GTK+ UI.
Change-Id: I997d0fd2e4320702fe85ee2aea02ce835a423df9
Reviewed-on: https://code.wireshark.org/review/24711
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=abcb7ec8750a263d0307bc41d86b79…
commit abcb7ec8750a263d0307bc41d86b798e5ae02966
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Nov 29 17:25:53 2017 -0800
Convert the file set dialog treewidget to a treeview+model.
Add a FilesetEntryModel and use it in FileSetDialog. This should be
faster than using a QTreeWidget. Move dialog updates and date
calculations out of the "add file" loop.
Bug: 11280
Bug: 14242
Change-Id: I702cef4fe91e739695fe805dc5e496bf3db411f1
Reviewed-on: https://code.wireshark.org/review/24708
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=5eb07b35d430b68c6d816476190035…
commit 5eb07b35d430b68c6d816476190035e0774f18d2
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Dec 5 09:28:16 2017 +0100
[profile.c] glist_fre_full() is 2.28, include glib-compat.h
Change-Id: I4b4e39de55a30352aa965653bcdf2429efb9e146
Reviewed-on: https://code.wireshark.org/review/24709
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9b7dd3ca2045ad1187311197abe003…
commit 9b7dd3ca2045ad1187311197abe003161c816b5c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Dec 4 21:57:08 2017 +0100
dumpcap.c: cap_pipe_read() returns a ssize_t whatever the platform (CID 1424899)
Change-Id: I9c157e1ed7264d787c26ca60bbbe32edfc99bff8
Reviewed-on: https://code.wireshark.org/review/24706
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a7603a1f684f0ae5a2084530d44e37…
commit a7603a1f684f0ae5a2084530d44e37f29ee9e41f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 4 13:44:09 2017 -0800
Fix loop bounds check.
Fix indentation while we're at it.
Change-Id: If8acaa944fd4c1aae848faa3a99f7566e003e801
Reviewed-on: https://code.wireshark.org/review/24707
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b3f0004af7e203df2d5d887a72fe7a…
commit b3f0004af7e203df2d5d887a72fe7af7b9c217e2
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 4 13:20:19 2017 +0100
Use g_list_prepend() it's faster.
Change-Id: I950901c56df230826a6011a6dcf34195b11fa61a
Reviewed-on: https://code.wireshark.org/review/24702
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=48841d0b5b10382ac7064c0704c5e3…
commit 48841d0b5b10382ac7064c0704c5e346100fb08f
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Mon Dec 4 12:08:52 2017 +0100
DOCSIS: Fixing typos
Change-Id: I25684534dee48158ea0cc1e960808e30cc1376d5
Reviewed-on: https://code.wireshark.org/review/24701
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=585a57ea1ec547a26a335a56db3c68…
commit 585a57ea1ec547a26a335a56db3c68c2789cdd11
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 4 10:54:07 2017 +0100
[decode_as.c] Use g_list_prepend() insted of g_list_append, it's faster.
Change-Id: I56c4a7948da48d02c81c5cf30187a6eeb973db77
Reviewed-on: https://code.wireshark.org/review/24700
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d747900bc88d2f40b434a7c5b5d876…
commit d747900bc88d2f40b434a7c5b5d8762e789087ea
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 4 10:37:32 2017 +0100
[tap-rtp-common.c] Change g_list_append() to g_list_prepend().
Change-Id: I6ecc6658f75056db55dc68497956019a52fad0e6
Reviewed-on: https://code.wireshark.org/review/24699
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=72c2256633e37b7bbec0ea72e90e27…
commit 72c2256633e37b7bbec0ea72e90e27a0267bef8d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Dec 4 07:28:49 2017 +0000
make-dissectors: Fix null pointer dereference for error condition
Found by scan-build.
Change-Id: I89b56bac951ccb7054d494592928306a860f9e5e
Reviewed-on: https://code.wireshark.org/review/24697
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d3a3b0ba27fc46a48273f8f311e1b7…
commit d3a3b0ba27fc46a48273f8f311e1b7fd751fcbc5
Author: Pavel Strnad <pavel_strnad(a)hotmail.com>
Date: Sun Dec 3 10:28:35 2017 +0100
tshark: fix pdml export for LUA cases
- bug fix for wrong level introduced in SHA-1:b8ead953
- fix indent for Close off fake wrapper protocol
Change-Id: Iccb10af8f3ac1604fc5582d730f2fd39ffaeb1c0
Reviewed-on: https://code.wireshark.org/review/24681
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=7a957952dc03cd0283a7e8a9fc8ff1…
commit 7a957952dc03cd0283a7e8a9fc8ff1daaf012713
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 22:12:23 2017 -0800
Let a "past the on-the-network length" exception terminate dissection.
Don't make sure we have the full server entry before trying to dissect
it; that way, a malformed frame that was really too short on the network
(as opposed to being cut short by a snapshot length) will get reported
as such.
Change-Id: Ib7f0d909645a698162ebcd9b3fe8dd2d520983b7
Reviewed-on: https://code.wireshark.org/review/24696
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3944f881f4fea1c7e94ed77d5723a4…
commit 3944f881f4fea1c7e94ed77d5723a41f495c880b
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Fri Dec 1 12:56:47 2017 +0100
RTPS: Added new PIDs to Security
Change-Id: I91ffb48ac5435d4eb45b60f8083762b2151de2c3
Reviewed-on: https://code.wireshark.org/review/24671
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e5f884c8b0a1af4a84a7f4aeb0b22d…
commit e5f884c8b0a1af4a84a7f4aeb0b22d033fd1c6fb
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Fri Dec 1 20:14:49 2017 +0000
Show retx prev and next framenum types as chevrons
Change-Id: I1641c70130a7562db9ea099770d8b5a7fe6e5532
Reviewed-on: https://code.wireshark.org/review/24676
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5350fd741f0ceafdea69b3ec6b0456…
commit 5350fd741f0ceafdea69b3ec6b04565b47146822
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Dec 3 20:26:05 2017 +0000
RLC LTE graph: add comments clarifying tracer limitation
Change-Id: Ib6a79689ced9377b1ac00513810db2e86d26d83f
Reviewed-on: https://code.wireshark.org/review/24690
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f411ab39886c5b372371b939311d9c…
commit f411ab39886c5b372371b939311d9cab54a9a183
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 21:37:25 2017 -0800
Get rid of cfile-int.h.
Change-Id: I6e2349a082e542e4020afafe4cf65b596259e868
Reviewed-on: https://code.wireshark.org/review/24694
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ccc55bc80cb8965a73fae980d6e1ba…
commit ccc55bc80cb8965a73fae980d6e1babf6d8a8823
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 21:33:59 2017 -0800
Put the structure of a capture_file back in cfile.h.
The split isn't necessary now that epan no longer uses the capture_file
structure.
Change-Id: Ia232712a2fb5db511865805518e8d03509b2167f
Reviewed-on: https://code.wireshark.org/review/24693
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1834dca3654ccec238bae130715871…
commit 1834dca3654ccec238bae130715871be3d8fa344
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 21:01:18 2017 -0800
Move the parts of a capture_file used by libwireshark to a new structure.
Embed one of those structures in a capture_file, and have a struct
epan_session point to that structure rather than to a capture_file.
Pass that structure to the routines that fetch data that libwireshark
uses when dissecting.
That separates the stuff that libwireshark expects from the stuff that
it doesn't look at.
Change-Id: Ia3cd28efb9622476437a2ce32204597fae720877
Reviewed-on: https://code.wireshark.org/review/24692
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=02944c412b4d9d7661c0a2b3eb9df4…
commit 02944c412b4d9d7661c0a2b3eb9df44d632878ee
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 19:18:38 2017 -0800
Use cfile fields for some frame_data pointers.
Those fields weren't being used in TShark/TFShark/rawshark/sharkd, so we
can use them, instead of defining our own static variables.
This makes the non-Wireshark code paths a bit more like the Wireshark
code paths.
Change-Id: I55da4cf525e37598f314efca22f20d3e80cb547c
Reviewed-on: https://code.wireshark.org/review/24691
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=461c8a7b44a2853d2ad3ae3d0586b4…
commit 461c8a7b44a2853d2ad3ae3d0586b4f21b9feab8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 12:23:12 2017 -0800
This also looks inside a capture_file structure.
Change-Id: I6c4de5212028643fa34c5d939608b592f554f2bd
Reviewed-on: https://code.wireshark.org/review/24689
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dc64ce86719ab634f7f05b785f9ebe…
commit dc64ce86719ab634f7f05b785f9ebe154ec886d4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 12:19:23 2017 -0800
Clean up dissection of server entries in SAP responses.
Have the top-level protocol tree item for a server entry cover the
entire entry, rather than just the server name. Have the server name be
just another entry under that top-level item.
Change-Id: I8089f3e132a0f388c87ba04caa3d15f5146c2303
Reviewed-on: https://code.wireshark.org/review/24688
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8ffc939b54cbfdda4698bafb60ebd0…
commit 8ffc939b54cbfdda4698bafb60ebd0856a575853
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 11:08:18 2017 -0800
Add cfile-int.h.
Change-Id: I6132dc0322d3ac85e89ac853ab6139244d610dd5
Reviewed-on: https://code.wireshark.org/review/24687
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=eb8ffb74e27523492855268abf5cb4…
commit eb8ffb74e27523492855268abf5cb45927ffdb04
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 3 10:53:58 2017 -0800
Use cfile.h to define the capture_file type.
Have cfile-int.h declare the structure, and use it in files that
directly access the structure.
Have cfile.h just incompletely declare the structure and include it
rather than explicitly declaring it in source files or other header
files.
Never directly refer to struct _capture_file except when typedeffing
capture_file.
Add #includes as necessary, now that cfile.h doesn't drag in a ton of
Change-Id: I7931c8039d75ff7c980b0f2a6e221f20e602a556
Reviewed-on: https://code.wireshark.org/review/24686
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=114c989fb37b25671d8886458b206f…
commit 114c989fb37b25671d8886458b206f11471b3277
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 3 16:56:44 2017 +0000
[Automatic update for 2017-12-03]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I4a3a5f62e5024a4df19c12296ddd67012c9ff5c7
Reviewed-on: https://code.wireshark.org/review/24683
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=40fc796818ffa8476ff0868c39ecb2…
commit 40fc796818ffa8476ff0868c39ecb2375a4e6ace
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Dec 2 22:23:39 2017 -0800
Fix the configuration check for remote-capture support in libpcap.
In autotools, if we find pcap_open(), define HAVE_PCAP_REMOTE, so we
build the remote capture support.
In both autotools and CMake, only check for pcap_setsampling() if we
have pcap_open(), as the compile fails if we have pcap_setsampling() but
don't have remote capture.
Change-Id: I0e7b78a2d372ea658a19ed2f6493532928c36872
Reviewed-on: https://code.wireshark.org/review/24680
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0455040c0e26b9b76d10efa8c32109…
commit 0455040c0e26b9b76d10efa8c321099989dc7b7e
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sat Dec 2 21:50:58 2017 +0100
LDP: Add support for MP2MP FEC
As stated in https://tools.ietf.org/html/rfc6388#section-3.2
MP2MP uses the same structure as the P2MP FEC element.
Bug: 13171
Change-Id: Ia619deac6075f5eb27dff2144edbbb60b440cc46
Reviewed-on: https://code.wireshark.org/review/24677
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c4af29ceb2485a356f97ce7d3b1d16…
commit c4af29ceb2485a356f97ce7d3b1d1693c76588f6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Nov 23 22:38:34 2017 +0100
MPLS: Add Media Access Control (MAC) Address Withdrawal over Static Pseudowire (RFC
7769
Bug: 14208
Change-Id: I80beda971b3727566c107dba0efdee0291529c42
Reviewed-on: https://code.wireshark.org/review/24560
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Francesco Fondelli <francesco.fondelli(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e77dac09f14623d41050a9652e6a79…
commit e77dac09f14623d41050a9652e6a79fd12bbb28a
Author: gizem.yurdagul <gizemnuryurdagul(a)gmail.com>
Date: Fri Dec 1 15:38:06 2017 +0300
PROFINET: AdjustDCPBoundary disection is added.
According to specification, AdjustDCPBoundary is
a sub block for adjusting the DCP boundary.
Change-Id: I2515e2b3592ff0e5e67487b1785db41015964b21
Reviewed-on: https://code.wireshark.org/review/24673
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=28b6616ea0d39cc699e4db9bccbb79…
commit 28b6616ea0d39cc699e4db9bccbb7948a55c7239
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Dec 1 11:13:18 2017 -0800
Get rid of some void pointers.
Explictly struct _capture_file * in epan_session and its callbacks.
Change-Id: I63703015c661a08f3350a7448a7bcdaf98f119dc
Reviewed-on: https://code.wireshark.org/review/24675
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=219c5463d121a2ed51820fdda60a48…
commit 219c5463d121a2ed51820fdda60a48e3fa27c6ca
Author: Craig Jackson <cejackson51(a)gmail.com>
Date: Thu Nov 30 00:33:10 2017 -0500
TDS: Improve TDS7 Prelogin request/response handling
- Fix detection of TDS7 Prelogin responses to have fewer false positives.
This was causing regular responses to be recognized as Prelogin responses if they
happened to begin with a DONEINPROC token.
- Define symbolic constents for the Prelogin options.
- Apply the version_convert processing to the relevant prelogin options as well as
to the loginack_progversion.
- Correct the display of the program version in version_convert.
- Factor out the setting of tds7_version so it can be called from the
dissect_tds7_login
as well as dissect_tds_login_ack_token. This is needed to correctly handle tokens
which come before the loginack token in the login response.
- Fix the wording of a comment in my last commit.
Change-Id: I57615bbb1e780db37cda25d8d5d7f964f68b337e
Reviewed-on: https://code.wireshark.org/review/24664
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c9348e1a703949def837c3a07f4ecb…
commit c9348e1a703949def837c3a07f4ecb019d87eba2
Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com>
Date: Fri Dec 1 15:54:22 2017 +0100
ZigBee: Correct Smart Energy Publish Block Thresholds and endianess
Change-Id: I1007fdff01b370c06a8ccfb1145fd162ffde9a94
Reviewed-on: https://code.wireshark.org/review/24674
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5320bdd00e8139a833e67dae228f44…
commit 5320bdd00e8139a833e67dae228f444761c02391
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Fri Dec 1 13:30:32 2017 +0100
RTPS: Fixed a quick typo in a hf item
Change-Id: I71315900a4fd5130ab051854bc70dbc4ba9afc2b
Reviewed-on: https://code.wireshark.org/review/24672
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=290fd76af6d2bd1dbc07f4f0b20f71…
commit 290fd76af6d2bd1dbc07f4f0b20f71ee8d6e73b3
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Dec 1 12:34:27 2017 +0100
[glib-compat] #include "ws_attributes.h" needed to handle _U_
Change-Id: Ie7aa8ef0a2ec8e65947e214488809d0df0ee015b
Reviewed-on: https://code.wireshark.org/review/24670
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8606062cb38373f7e594bbaa812fb1…
commit 8606062cb38373f7e594bbaa812fb19719d7e6ef
Author: James Ko <jck(a)exegin.com>
Date: Wed Nov 22 11:05:48 2017 -0800
dumpcap: enable capture of pcapng from pipe
Reads pcapng blocks from a pipe. Section header blocks are parsed for
endianess. All other blocks only have the general block header parsed
for type and length, and then endianess converted if necessary.
Outputs all blocks using the original endianess format so none of the
other block types or options require parsing.
Change-Id: I2f4f0175013d8fc2cda42a63e7deacad537951e3
Bug: 11370
Reviewed-on: https://code.wireshark.org/review/24536
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1683dd11e76f01760665ab15cd9204…
commit 1683dd11e76f01760665ab15cd9204fa19923238
Author: Darien Spencer <cusneud(a)mail.com>
Date: Thu Nov 30 20:20:29 2017 +0200
RRC: Improve C-RNTI resolving
Now also trying to resolve C-RNTIs in FACH from the global RNTIs map
Change-Id: If9ce5b73d6855271c15001fd73d8acaaaf9d1864
Reviewed-on: https://code.wireshark.org/review/24665
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a3a906d663cdda569ab09ce71742d0…
commit a3a906d663cdda569ab09ce71742d0f470f26d74
Author: Pau Espin Pedrol <pespin(a)sysmocom.de>
Date: Thu Nov 30 15:07:17 2017 +0100
packet-rsl.c: Use value-string in RXLEV and RXQUAL fields
RXLEV and RXQUAL fields in RSL "Uplink Measurements" use same scale
format (0-63, 0-7) as RXLEV and RXQUAL in RR. RXQUAL value-string is
moved to packet-gsm_a_common.c in order to use it in both protocols.
Change-Id: Idadd9505225353fec76b9605e2045a5222669475
Reviewed-on: https://code.wireshark.org/review/24663
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=48e68367d9d0de933648c93fba9996…
commit 48e68367d9d0de933648c93fba9996993848aa5f
Author: Darien Spencer <cusneud(a)mail.com>
Date: Thu Nov 30 15:43:00 2017 +0200
rrc: Remove unused GTree
Change-Id: I137ac55cd99e659db9d9a496cc82f4427300765d
Reviewed-on: https://code.wireshark.org/review/24662
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a6d0ffca86662357893c2ba6986964…
commit a6d0ffca86662357893c2ba6986964cb341a73d1
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Nov 30 09:31:43 2017 +0100
RRC: reset strbuf pointer after its use
While we are at it, let's add a partial dissection of
PLMN-IdentityWithOptionalMCC-r6 IE.
Bug: 14248
Change-Id: I20b76bc74c248914db21629f8ce77799fccb1612
Reviewed-on: https://code.wireshark.org/review/24661
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6a00fa767fec78020203e1f53062c6…
commit 6a00fa767fec78020203e1f53062c6a2e5a117c6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Nov 30 03:39:14 2017 +0000
http2: select fields from Decompressed header tab when possible
The "Decompressed header" tab contains some human-readable text, but no
field was associated with it. Instead, the fields were attached to raw
compressed headers which, all with the same offset and length.
Ensure that each byte in the decompressed header tab is accounted for.
The only fields that are still pointing to the raw compressed buffer is
the http2.header field (covering a full raw header), the representation
type (a few bits, at most 1 octet) and the index length (guessed length,
an exact value is probably not worth the cpu cycles).
Change-Id: Ic0118e9ed583841a2d353f8b8c28dcafea3401f2
Reviewed-on: https://code.wireshark.org/review/24660
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bb4726abf220e5223a8eee8120bae1…
commit bb4726abf220e5223a8eee8120bae14ef2f1a4a4
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Nov 30 01:10:07 2017 +0000
Qt: fix crash when selecting field with composite data
The HTTP2 decompressed headers tab is composed from multiple TVBs, these
have a null "real_data" pointer. Do not access it directly but use an
accessor which Does The Right Thing™.
Change-Id: Ib974fed9782d60aa2b91e3e712ba737000b79b4b
Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView")
Reviewed-on: https://code.wireshark.org/review/24658
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Alexander Gryanko <xpahos(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=3d6da018e7969c23b172b37a9f5566…
commit 3d6da018e7969c23b172b37a9f556696783ca9b1
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Nov 29 20:03:22 2017 -0500
CIP Safety: base packet length can be used
Slight adjustment to I394fa91a5cfa1700fb12441d4884c0367b39df8b
Change-Id: Id097a39265f49a79f3d39855ef6b5c95ffe8c4f1
Reviewed-on: https://code.wireshark.org/review/24654
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f6521b295dbb1c5a53dd4d43743b81…
commit f6521b295dbb1c5a53dd4d43743b8165010de34f
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Wed Nov 29 10:06:30 2017 +0100
RTPS: Added link to the DCPSPublicationData frame number
Added a link inside the Topic Information feature so users can
quickly go to the discovery data associated with the writer sending
this submessage.
Change-Id: I3a89630a275e5d857e8bbf86dc5171c9f0921d5b
Reviewed-on: https://code.wireshark.org/review/24646
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=aeb864e685d608183b53113816a8aa…
commit aeb864e685d608183b53113816a8aa1ba0409080
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Wed Nov 29 10:42:47 2017 +0100
RTPS: Added new endpoints for the Security spec
Change-Id: Ia827c43b161a2b64804b0eac220b428eb853d255
Reviewed-on: https://code.wireshark.org/review/24647
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ec0ffc043fac4792ccf3055ea18190…
commit ec0ffc043fac4792ccf3055ea18190894a520577
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Nov 29 14:17:54 2017 -0800
RRC: Fixup wmem_strbuf usage.
Instead of calling wmem_strbuf_finalize, which frees the strbuf
structure and makes it unsuitable for reuse, call wmem_strdup +
wmem_strbuf_truncate. This fixes a heap-use-after-free.
Bug: 14248
Change-Id: I498e10ed9f9afa7fa72b607eb43f68c710de777e
Reviewed-on: https://code.wireshark.org/review/24650
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3ed5b4fb67edc6829ece7adf542f44…
commit 3ed5b4fb67edc6829ece7adf542f44e9a75185af
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Nov 28 16:03:11 2017 -0800
Reformat some top-level ui files.
Make sure each ui/*.[ch] file uses identical (4-space) indentation.
Remove ui/.editorconfig. Fix up other formatting where needed.
SPDX-abbreviate the license blurb in the files we modify.
Change-Id: I5faa1c1eae9a4b6220422ad8e4ba7a341c7deb1f
Reviewed-on: https://code.wireshark.org/review/24632
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b59dc97dfef3bcce71cd393f4d2493…
commit b59dc97dfef3bcce71cd393f4d2493e7ba1a8f82
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Nov 29 14:46:10 2017 -0800
NetBIOS: Don't write past the beginning of a buffer.
Make sure process_netbios_name doesn't write past the beginning of its
buffer.
Bug: 14249
Change-Id: Idb294ba2362e48b879bc4c0c0ddaf64fcf1b5d72
Reviewed-on: https://code.wireshark.org/review/24651
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=52365a55e4e726176e884e510123fb…
commit 52365a55e4e726176e884e510123fbbfe7801346
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Nov 26 20:41:50 2017 +0000
LTE L2 protocols: add FT_FRAMENUM_TYPE for most FT_FRAMENUM fields.
Missed out some that would probably result in too many links.
Added FT_FRAMENUM_RETRANS_PREV and FT_FRAMENUM_RETRANS_NEXT to enum,
these display as arrows like REQUEST and RESPONSE do.
Change-Id: I6e8d222955f2ba59a713e8a389837b55a1c7f262
Reviewed-on: https://code.wireshark.org/review/24600
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=986a084de361d2d3844f9af8874b7e…
commit 986a084de361d2d3844f9af8874b7e3a2a636b46
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Nov 18 15:19:01 2017 +0000
Update .gitignore
Change-Id: I3b5f343f241a7d0571ddd7a0647c45c2bef28c73
Reviewed-on: https://code.wireshark.org/review/24648
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=d1a6742d9bcd76c0d4e52c7353d074…
commit d1a6742d9bcd76c0d4e52c7353d0740463e45bb0
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Nov 29 09:18:10 2017 +0100
[L2TP] Enhance info col layout.
Change-Id: Ib16b71b47f97516db55412f1881d995706e723b1
Reviewed-on: https://code.wireshark.org/review/24645
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=140282cbf012fb3eac20d24c388d12…
commit 140282cbf012fb3eac20d24c388d12e8a875501e
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Nov 29 02:55:32 2017 +0000
cmake: fix build with cmake 2.8.11.2
"file(GENERATE ...)" is only supported since 2.8.12, since the list of
sources is fixed at cmake time, just use "file(WRITE ...)".
Change-Id: If4a547803ab536cf8d131045692d3e58301b0cd2
Fixes: v2.5.0rc0-1763-gfe0c2b0485 ("Rewrite make-dissector-reg.py in C")
Reviewed-on: https://code.wireshark.org/review/24638
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d7bab0b46e72eb30e50ad1b6a0b562…
commit d7bab0b46e72eb30e50ad1b6a0b56275394406b4
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Nov 29 09:14:32 2017 +0100
[packer-ehdlc.c] Mark some fields as generated, enhance info col.
Change-Id: I10241389dbd3c463b36c5dfcd7a4fa929a1bbf6a
Reviewed-on: https://code.wireshark.org/review/24644
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e1850de29442f4de75e43544dfadd8…
commit e1850de29442f4de75e43544dfadd855e36dd6b3
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Nov 29 02:54:47 2017 +0000
autotools: remove unnecessary include directory for epan
Since v2.1.0rc0-2202-g6b54fbf3bf, wslua is also not necessary in the
include path, so remove that too.
Change-Id: Ib227b71b08da9fc397d6618b60100ab819570b86
Reviewed-on: https://code.wireshark.org/review/24640
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3c6cb2f85646b12562a596bd5dbd8f…
commit 3c6cb2f85646b12562a596bd5dbd8f2b9e672606
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Nov 8 02:49:38 2017 +0000
cmake: match include directories with autotools
Match closer the behavior of autotools which does not include epan in
its include paths by default.
Change-Id: I885bc7942490a5674c6ac75f9a8ea221555e3784
Reviewed-on: https://code.wireshark.org/review/24639
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=952dc3ae323a5e39ffce19252784ac…
commit 952dc3ae323a5e39ffce19252784ace1f17d24ab
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Nov 28 19:57:09 2017 +0000
make-dissectors: Use g_file_set_contents()
Also add some more errors checks, we only pass valid files to make-dissectors.
Change-Id: I9c068e47f35ee6c3da0112ee9ce905af35030475
Reviewed-on: https://code.wireshark.org/review/24625
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9cd82c3753d9d0241b89801dc10f9b…
commit 9cd82c3753d9d0241b89801dc10f9baaa4dd5d4f
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Thu Nov 23 16:31:43 2017 +0100
RTPS: Added DataWriter QoS to topic information feature
Change-Id: Ib8d9c4f75543ed05c1bf69589069ed2425e3394e
Reviewed-on: https://code.wireshark.org/review/24555
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f10237f0a512139c44f840bf363353…
commit f10237f0a512139c44f840bf363353c755aa8818
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Mon Nov 27 15:40:52 2017 +0100
RTPS: Added locator and product version to Micro DDS
Change-Id: Icfb1c505865f5a32152cc056173baae8f7d01f36
Reviewed-on: https://code.wireshark.org/review/24603
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=67ffa3cf7da172df53a821d5cd4c1a…
commit 67ffa3cf7da172df53a821d5cd4c1a6a849f4087
Author: Gerald Combs <gerald(a)zing.org>
Date: Tue Nov 28 11:04:16 2017 -0800
Threads: Set lifetimes and add a compatibility routine.
Join the protocol registration threads so that they call g_thread_unref
which in turn detaches/terminates the thread. This gets rid of many TSan
and DRD errors here. The remaining ones appear to be false positives.
Add g_thread_new to glib-compat (untested).
Change-Id: I4beb6746ed08656715cf7870ac63ff80cf1ef871
Reviewed-on: https://code.wireshark.org/review/24619
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=041e3e7c27c78308d0d515171f52a3…
commit 041e3e7c27c78308d0d515171f52a39f8260782b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Nov 28 22:08:18 2017 +0100
CIP Safety: check packet length before dissecting
Otherwise we can call CRC functions with a negative value, leading to
a segmentation fault.
Bug: 14250
Change-Id: I394fa91a5cfa1700fb12441d4884c0367b39df8b
Reviewed-on: https://code.wireshark.org/review/24621
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e29378b030dc58948263abead03f7e…
commit e29378b030dc58948263abead03f7e1a49e3f415
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Nov 29 03:00:34 2017 +0000
Qt: fix role check in AStringListListUrlProxyModel::data
Change-Id: I7c683449155f7dcb63731e6575cf92c30be78934
Fixes: v2.5.0rc0-1841-gd865871627 ("Qt: About Dialog move to QTreeView and fix
copy")
Reviewed-on: https://code.wireshark.org/review/24637
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=18b240d7d2d8a138a1837dcbcd3b07…
commit 18b240d7d2d8a138a1837dcbcd3b0706353a007f
Author: Gerald Combs <gerald(a)zing.org>
Date: Tue Nov 28 17:48:59 2017 -0800
Normalize ui/win32 indentation and switch to SPDX.
Switch ui/win32/console_win32.[ch] to 4-space indentation to match the
other files in that directory. Remove ui/.editorconfig. SPDX-abbreviate
the license blurb in all files in that directory.
Change-Id: I68aa5a3ae7ae184ea8d27d9dba06b968ac3d2472
Reviewed-on: https://code.wireshark.org/review/24636
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d1a79a6cac7a4d5a3f3fd3f9233068…
commit d1a79a6cac7a4d5a3f3fd3f92330686047e34d2c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Nov 28 17:39:54 2017 -0800
Get rid of --with-pcap-remote; always check for pcap_open.
No need to make it an option; it's not an option in CMake.
Change-Id: I43dd25b9b73e6f372bd6612aea6372b950b0ca74
Reviewed-on: https://code.wireshark.org/review/24635
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e74800d3479a937692114aa026522f…
commit e74800d3479a937692114aa026522ff4768d9ad2
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Nov 28 17:28:55 2017 -0800
Use a separate Boolean to indicate whether we have a duration.
Reserved values are a bit of a hack. (If this were Swift....)
Change-Id: I243e8f497345f44d94af6106287556b8831fba92
Reviewed-on: https://code.wireshark.org/review/24633
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ae65dc20eae7e21010b6e33b2cb117…
commit ae65dc20eae7e21010b6e33b2cb11724d403acd9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Nov 28 15:06:13 2017 -0800
Report the actual *error* for CANT_GET_INTERFACE_LIST.
CANT_GET_INTERFACE_LIST does *NOT* mean "No remote interfaces found.",
as in "there are no remote interfaces"; a NULL return from
get_remote_interface_list() and an err value of 0 means that.
CANT_GET_INTERFACE_LIST means "something bad happened and the error
string says what it is". Display that error string, so when people
report problems:
https://github.com/the-tcpdump-group/libpcap/issues/666
they'll give the actual error message, and I'll fix my breakage of the
rpcap protocol negotiation:
https://github.com/the-tcpdump-group/libpcap/commit/2972769d03dd60d4bce233a…
rather than just wondering what the problem was and asking the reporter
of the problem for more information.
Report anything other than "there are no remote interfaces" as an error,
not a warning.
Change-Id: Ia9381953d080e037254f21e47ee7ecc4619b7254
Reviewed-on: https://code.wireshark.org/review/24627
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2fdbeb0d785db8d63849f0205313ae…
commit 2fdbeb0d785db8d63849f0205313aed4d085f3ec
Author: Gerald Combs <gerald(a)zing.org>
Date: Tue Nov 28 14:37:46 2017 -0800
Gen-bugnote: Replace backslashes with {backslash}.
Change-Id: I12b479fedf9ca54b600919a4586c4b4c43464589
Reviewed-on: https://code.wireshark.org/review/24626
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1e892a1db65ebfb7ea49bf7e605d2c…
commit 1e892a1db65ebfb7ea49bf7e605d2c2d9dfbe9c3
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 28 14:36:09 2017 +0100
Qt: Small layout improvement in preferences
Make PacketList settings look like the StatusBar settings.
Remove unneeded QVBoxLayout.
Change-Id: Id1910b2cf4cc5d3ab52d2abd781045ad4033469a
Reviewed-on: https://code.wireshark.org/review/24618
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e73135a9f1a275d940b8e97060b3c2…
commit e73135a9f1a275d940b8e97060b3c25d92176948
Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com>
Date: Tue Nov 28 10:42:57 2017 +0100
ZigBee: Add remaining attributes from Smart Energy Metering cluster
Change-Id: I7ca67ceaf72a1e4cc1c7b3ccc8fed79fafefe575
Reviewed-on: https://code.wireshark.org/review/24614
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9c6d2af0aef5b13cb739794ccabc09…
commit 9c6d2af0aef5b13cb739794ccabc09d27241fde0
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jul 25 16:01:42 2017 -0400
Qt: Add support for DCE/RPC in Decode As
DCE/RPC is a FT_GUID type, but has some special handling. "Regular"
FT_GUID dissector tables still not supported.
Bug: 13122
Change-Id: I328776ffe5bbe87ecfbe6719f04d18b1b237a583
Reviewed-on: https://code.wireshark.org/review/24602
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da910203539afc7fa37caa17ccf416…
commit da910203539afc7fa37caa17ccf41674d7953ab0
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 28 12:52:27 2017 +0100
ui: Sort profile names
Not all file systems returns a sorted list of filenames, so we need
to sort the entries before using the list in the Profile popup and
the Manage Profiles dialog.
Change-Id: Ic1f2bfa77fb47fb8c406d891aee49b484876b4f7
Reviewed-on: https://code.wireshark.org/review/24615
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=87a8877007471c0e3113c21c8675bf…
commit 87a8877007471c0e3113c21c8675bfe5d81b1289
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 28 13:58:51 2017 +0100
gitignore: Add packaging/macosx/PkgInfo
Change-Id: I630fa8ae0c3d5f078922b4d6cb2ee064c31bd35e
Reviewed-on: https://code.wireshark.org/review/24616
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=944a3c3a582864ca7cbe2bbb1af729…
commit 944a3c3a582864ca7cbe2bbb1af7291089ecda9c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 26 08:28:36 2017 +0000
make-plugin-reg: Update modification time to plugin.c
Let the build system handle the dependencies. Make sure to update the file
even if nothing has changed to avoid re-running the script every time.
Change-Id: I2229c13578a6278a04152825c98d8b889081dcb7
Reviewed-on: https://code.wireshark.org/review/24597
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=d8658716277bbb2378819d25997ce0…
commit d8658716277bbb2378819d25997ce0646b72c9c2
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Fri Nov 24 15:46:30 2017 +0100
Qt: About Dialog move to QTreeView and fix copy
- Fix an issue, where the url was opened twice on Linux
- Make the filter case insensitive if so wished for
- Allow the copy to either copy the selected column (just Copy) or copy the complete
row, with tab separation
- Move to QTreeView instead to make it similar to the rest of the tables
Change-Id: Ie6064f2ad2014e24546553c5febe63358e2f69ec
Reviewed-on: https://code.wireshark.org/review/24570
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jim Young <jim.young.ws(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d35ed012ce62fae4344e80a0df3742…
commit d35ed012ce62fae4344e80a0df3742619a4eaa0f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Nov 11 04:29:15 2017 +0000
TLS13: update for draft -22 (Server Hello, HRR, CCS, NST)
Draft -22 moved the server version to an extension and makes HRR look
like a SH. SH is now interpreted as TLS 1.2. Detecting TLS 1.3/HRR
requires scanning SH extensions before parsing the message, so do that.
Changes:
- Add draft 22 version identifier.
- Recognize special Server Hello magic for HRR.
- Dissect SupportedVersions for SH/HRR, rename the field to match spec.
- Recognise new Server Hello format (including legacy fields).
- Move version detection up to handshake message dissection to allow
HRR (disguised as SH) to be detected as such. DTLS does not have HRR
and fragmentation makes it harder, so use its version as usual.
- Ignore ChangeCipherSpec again for draft 22 (do not add expert info).
- Allow NST ticket_nonce to be empty.
Change-Id: I9d5f7dba173e1b5c901bf9a6917c65520ee60a2f
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/24340
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7eb2c7dbc7b0cddb18297268677e3d…
commit 7eb2c7dbc7b0cddb18297268677e3dc9a073f320
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Nov 26 01:31:56 2017 -0800
*Always* set pinfo->p2p_dir from the wtap_pkthdr.
Don't just do it if we're actually creating protocol tree information
for the "Frame" protocol; that information is used even when we're
*not*
creating protocol tree information for "Frame".
Bug: 14245
Change-Id: Ie3754e15754fb6a73529e20d8fa68956e206a994
Reviewed-on: https://code.wireshark.org/review/24593
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=78ed5f34f574d6400e63b7f8c4f358…
commit 78ed5f34f574d6400e63b7f8c4f358c7c69a24fa
Author: Peter Hamilton <qmear55(a)protonmail.com>
Date: Fri Nov 24 18:08:16 2017 +0200
NBAP: Always map NB-CC to CRNC-CC
Now maps for all channels and not only E-DCH
Change-Id: I51099e887830e5142b58fd624775d395e354b012
Reviewed-on: https://code.wireshark.org/review/24572
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c0514ac4330695c66d346067d99a42…
commit c0514ac4330695c66d346067d99a429c2bb6abbe
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Nov 25 23:42:47 2017 -0500
Bugfix DCE/RPC Decode As for GTK.
An attempt at optimization broke GTK DCE/RPC Decode As because DCE/RPC
dissector tables aren't FT_UINT type. The "optimization" was trying
to retrieve dissector handle from FT_UINT typed dissector table.
Move retrieval of dissector handle to under FT_UINT check
Change-Id: Id81cd79db60263155392aaac0c796a6484ef7504
Reviewed-on: https://code.wireshark.org/review/24589
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9b7ad9c20e3dd81b66251a058874a2…
commit 9b7ad9c20e3dd81b66251a058874a2c63e42b458
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Nov 26 08:16:15 2017 +0000
[Automatic update for 2017-11-26]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I2963633f86a87209eca574db52663ebbe732f9d9
Reviewed-on: https://code.wireshark.org/review/24590
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=076fee6e636db2123744c1ecf004e9…
commit 076fee6e636db2123744c1ecf004e9c6ff9b0a8c
Author: Erwin Rol <erwin(a)erwinrol.com>
Date: Sat Nov 25 17:34:24 2017 +0100
artnet: Fix ArtPollReply spare/style field order
In the ArtPollReply the field order of the style and 3 spare bytes
was wrong, according artnet spec 1.4 page 25 the order should be
spare, spare, spare, style.
Change-Id: I5683e5a8e97643a7bb1962178178c175d485098c
Signed-off-by: Erwin Rol <erwin(a)erwinrol.com>
Reviewed-on: https://code.wireshark.org/review/24584
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=18657caf8d5c5388190b29c0cc1b4b…
commit 18657caf8d5c5388190b29c0cc1b4b94c997d5dc
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Nov 25 14:18:06 2017 -0500
Add information about pre-commit script to Developer Guide.
Bug: 9553
Change-Id: I19505c3c05585a05877e9f0db06400ebb8b33985
Reviewed-on: https://code.wireshark.org/review/24585
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fdeaaa362a84f49af176b1beb47533…
commit fdeaaa362a84f49af176b1beb4753396dee8ea18
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat Nov 25 15:08:08 2017 +0000
LTE MAC stats: make display filter field work
Change-Id: I76b97f4f67ba63f7479dffc1cf1267b39cefa4fa
Reviewed-on: https://code.wireshark.org/review/24582
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=89ae2826d6158e62fe3db9c18d0172…
commit 89ae2826d6158e62fe3db9c18d01721a2168e9cc
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Nov 24 19:17:55 2017 +0100
Qt: AccordionFrame users keyPressEvent() fixes
- Declare keyPressEvent() virtual.
- Give keyPressEvent() to parent when done.
Change-Id: If1c05e86a5ab71dd239c025cdb2bcfb1ef484811
Reviewed-on: https://code.wireshark.org/review/24573
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e1f3d9dcbee7dac3ad06d9a0ca2e63…
commit e1f3d9dcbee7dac3ad06d9a0ca2e63896e1f7305
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Fri Nov 24 21:07:38 2017 +0000
LTE RLC Stats: make display filter field work.
Change-Id: Ic3c9ebb176bcc7c3973aca382c270aacac7283af
TODO: the same for LTE MAC Stats..
Reviewed-on: https://code.wireshark.org/review/24577
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cf110add653b5c0ed531f306b8d429…
commit cf110add653b5c0ed531f306b8d429a41c860d0a
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Fri Nov 24 19:24:32 2017 +0000
RLC LTE stats: show UE and channel bw properly
Change-Id: I49edf405d61b15ba451f291c32b8fc3126a7e9d7
Reviewed-on: https://code.wireshark.org/review/24575
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f23a6e193f90a02542c85cad07cb07…
commit f23a6e193f90a02542c85cad07cb073abd6eb678
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Nov 25 00:32:23 2017 -0500
packet-iwarp-mpa.c: Stop FPDU dissection if the ULPDU_LENGTH field does NOT contain
what is expected
Bug: 14236
Change-Id: I15f1bc70978d1e5ae3b4bba1ff87b590726cfaa1
Reviewed-on: https://code.wireshark.org/review/24578
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d2a7a806ff811628eb75e415c88116…
commit d2a7a806ff811628eb75e415c8811600420b14d5
Author: Martin Heusse <martin.heusse(a)imag.fr>
Date: Fri Nov 24 20:15:04 2017 +0100
Re-sync with osmocom version of the file with new types
Change-Id: Iae231de172eabe135ca3acd7f82b1683eebaee38
Reviewed-on: https://code.wireshark.org/review/24574
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1ecad014202cff8f5f32bb91767240…
commit 1ecad014202cff8f5f32bb91767240978a276ed0
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Fri Nov 24 11:14:23 2017 +0100
Qt: About - implement copy&paste and urls
Make the URLs clickable again, and allow the copy/paste of
selected entries via context menu
Change-Id: I619059ca77c54314df31364de8ee7fce9dbc3ed3
Reviewed-on: https://code.wireshark.org/review/24569
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1392b92d7cfd28a3491596a92ee38b…
commit 1392b92d7cfd28a3491596a92ee38be73d1a5fcd
Author: Craig Jackson <cejackson51(a)gmail.com>
Date: Fri Nov 17 14:05:57 2017 -0500
TDS: Fix packet reassembly for TDS 4.x/TDS5.x streams.
The existing TDS "netlib" packet reassembly code only handles situations
where the
netlib header has a valid non-zero packet number. This does not always occur for
older
clients, in particular when TDS 7 is not in use.
This has been tested with:
DB-Library 4.6 talking to Sybase
CT-Library 5.0 talking to Sybase
jConnect 5.0 talking to Sybase
.NET 4.5 talking to SQL Server with TLS login
Freetds CT-Library talking to SQL Server with unencrypted login
- I'm not sure of the version of this, in the protocol it appears as 8.0.341.
Change-Id: I1690ba191ba3f4bd10569ab1a26dae82c5bbf260
Reviewed-on: https://code.wireshark.org/review/24470
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0074855364047c362c6161ddd68cb2…
commit 0074855364047c362c6161ddd68cb206c221c893
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Nov 24 00:03:53 2017 +0000
DTLS: fix decryption with EMS and client auth
Similar to the TLS fix in v2.5.0rc0-1805-gd790c524b4, ensure that the
correct master secret is calculated when extended_master_secret is
enabled with client auth and a decrypted RSA premaster secret.
Bug: 14243
Change-Id: I3d8cecef0f0cc3ec73537053489adc2d0d45c947
Reviewed-on: https://code.wireshark.org/review/24564
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9ac02f18c981c175be83b41bded746…
commit 9ac02f18c981c175be83b41bded7462aef128a3d
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Nov 24 00:05:05 2017 +0000
packet: ensure consistent layer number for heuristics dissector
DTLS decryption works for single-pass dissection, but breaks in the
second pass. Turns out that "curr_layer_num" has decremented in the
second pass, resulting in a failure to lookup the decrypted data.
This decryption issue was triggered by v2.3.0rc0-3740-ge1f84f985e
("Fix Decode As for protocols that may use tunneling.").
The first time the UDP dissector invokes "dissector_try_heuristic", the
second time "call_heur_dissector_direct". The first one increments
"curr_layer_num", so do the same in the second case.
Change-Id: I62679b817b02f42d073cfc07b88ec36d5bec5f04
Bug: 14243
Fixes: v1.11.4-rc1-468-g2cfda31ff0 ("Change the signature of
dissector_try_heuristic() to return hdtbl_entry")
Reviewed-on: https://code.wireshark.org/review/24565
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b99677dea95a8886429574713d5a78…
commit b99677dea95a8886429574713d5a78dde9181959
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Nov 23 13:18:37 2017 +0100
Qt: Add key event to reject changes in AddressEditorFrame
Also give focus to the name field.
Change-Id: I409d48e513c04b510f1e3d838c05e1518e6d2e9d
Reviewed-on: https://code.wireshark.org/review/24547
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=73c01d6d0562f138b3aad83b6b2dcf…
commit 73c01d6d0562f138b3aad83b6b2dcf8d3f09dcee
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Wed Nov 22 16:54:32 2017 +0100
Qt: Rewrite the About dialog to use models
Rewrite of the about dialog, to use QTableView and Models
instead of HTML files.
Everything is now model based, and the model is generic enough
to support any variation which can be put into a QStringList row.
Change-Id: Ie32bf66b2fe2a7754c0bf07205a7b068d46b0070
Reviewed-on: https://code.wireshark.org/review/24534
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8fa4a440a8f85ff9078c7c28e3747d…
commit 8fa4a440a8f85ff9078c7c28e3747decede0848e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 23 02:06:35 2017 +0000
GTK: Remove packet editor
Removes limited experimental feature for deprecated UI.
Change-Id: Ib3ccfae89dd2a674ebbde346a442fa1cf6587f26
Reviewed-on: https://code.wireshark.org/review/24563
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e7b12d85502e2827aacde3efd08212…
commit e7b12d85502e2827aacde3efd0821298bd8284ce
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Thu Nov 23 21:44:01 2017 +0000
LTE RLC graph: 'r' should reset, not zoom out
Change-Id: I34ad795b5c4f3f5d47b357d3af1de1f4b5fe481b
Reviewed-on: https://code.wireshark.org/review/24561
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cb80d6c97bbcfe6260ed64d3d747ca…
commit cb80d6c97bbcfe6260ed64d3d747ca26047ce1b4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 23 22:12:44 2017 +0000
make-dissectors: Use more shell for build recipe
Change-Id: Ib7b5c74c0cca5bd6b9036a36a2df85ed0d0dcabb
Reviewed-on: https://code.wireshark.org/review/24562
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=cd6e56e03a6a26805f64140003f149…
commit cd6e56e03a6a26805f64140003f149732309966f
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Thu Nov 16 19:22:24 2017 +0300
ZigBee ZCL Price Cluster dissector
Added Price cluster payload dissectors.
Change-Id: I4771221e1260e446a7708adb9c862cddb8755d59
Reviewed-on: https://code.wireshark.org/review/24549
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=76d7b7a519792fb51ad6694ddc11a5…
commit 76d7b7a519792fb51ad6694ddc11a506247aba40
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Nov 23 14:22:45 2017 -0500
Qt: Add menu option to remove all packet comments
Bug: 14186
Change-Id: I8793078ea50379b2f9697787e6b7a8ab2d9e3e0e
Reviewed-on: https://code.wireshark.org/review/24558
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea6204cab695d5a9d15fc5b26379a8…
commit ea6204cab695d5a9d15fc5b26379a8eb8a8fc463
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 16:11:55 2017 +0100
BGP: display ESI 10bytes value (and not a decoded value)
Bug: 14200
Change-Id: I6d8ac6aae952db21e69fa323fb1e74782d95d1c4
Reviewed-on: https://code.wireshark.org/review/24362
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ef17ead7723676ba4719a08af25dac…
commit ef17ead7723676ba4719a08af25dacb449f8695b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Nov 23 10:04:20 2017 -0500
BGP: Add Path Identifier to IPv6 NLRI
Bug: 14241
Change-Id: I5e66b034cf5cd14e2557e5b7bfa3045c2232d1ae
Reviewed-on: https://code.wireshark.org/review/24553
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6cc3abfc55ed4c7db7e423c4552c4f…
commit 6cc3abfc55ed4c7db7e423c4552c4f3c16749fa4
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Nov 23 17:31:38 2017 +0100
[make-dissectors] Need to link with wsutil
Change-Id: I033352dfb1836d646db5a3db04b125d2058867c9
Reviewed-on: https://code.wireshark.org/review/24556
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0780975703887f4fb21cfaa0c5869c…
commit 0780975703887f4fb21cfaa0c5869cb49daea482
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Nov 20 11:31:18 2017 +0000
make-dissectors: Another attempt to use newlines instead of spaces
Change-Id: I7ff5a0ea3eb3f7f56debc54aee6d5147815acc1b
Reviewed-on: https://code.wireshark.org/review/24552
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=121654beb22b6e16023da17fff5474…
commit 121654beb22b6e16023da17fff54743fb555d37d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 23 13:08:17 2017 +0000
checkAPIs: Skip make-dissectors.c
Change-Id: Ief976c2958b98dc2a5b637bc20dd5f7f993b7124
Reviewed-on: https://code.wireshark.org/review/24551
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=3a80970f12e829a26aa558385c508c…
commit 3a80970f12e829a26aa558385c508c19c9374d24
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 23 12:13:55 2017 +0000
make-dissectors: Fallback to the newly introduced glib-compat replacement
Change-Id: Ieb7ea23d8109a60dce7dd0c848438e93d671a3c9
Reviewed-on: https://code.wireshark.org/review/24546
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=80424d135f105d236438e89d9b60f3…
commit 80424d135f105d236438e89d9b60f30209574c87
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Nov 23 13:34:19 2017 +0100
Qt: Make InterfaceFrame use QFrame
It's no need for InterfaceFrame to use AccordionFrame.
Change-Id: Iccef1bcf919d7e5ec2bf818802ef68c1faf4e4a3
Reviewed-on: https://code.wireshark.org/review/24548
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=243fa8c4416c00ff1958fe837c4010…
commit 243fa8c4416c00ff1958fe837c401028ef7ca901
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Nov 23 14:06:34 2017 +0100
[glib-compat] g_async_queue_timeout_pop() needed for older glibs
(2.31.18)
Change-Id: I727c8548c29b3409fab819dce072e86153232911
Reviewed-on: https://code.wireshark.org/review/24550
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b6f5ee68f646715db094e55aa33b08…
commit b6f5ee68f646715db094e55aa33b0810d0da1814
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 23 02:42:05 2017 +0000
make-dissectors: Don't use stdout
This will prevent the file from being created with shell redirection
in case of error and allow printing informational messages to stdout
instead of stderr.
Also improve dissectorc.c Makefile recipe to abort on errors.
Change-Id: I64722927721887b57a7dbe69fd2625c2e4648ad4
Reviewed-on: https://code.wireshark.org/review/24545
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=db811a699d3238425a22f6b8b129c2…
commit db811a699d3238425a22f6b8b129c259e97262cf
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Nov 23 10:51:53 2017 +0100
[glib-compat] Add g_ptr_array_new_full().
Change-Id: Ic0e054cbb28106cc02f229ad4f2476b39e544378
Reviewed-on: https://code.wireshark.org/review/24544
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fe76be0b5bcbb465d4b510135922ea…
commit fe76be0b5bcbb465d4b510135922ea3302c8c705
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Nov 22 17:22:52 2017 +0100
[make-dissectors] g_ptr_array_new_full() is glib 2.30.0 which we do not
require.
Add alternate code to fix the build for our minimum required version.
Change-Id: Ia0911c5a6be3af68330ac41a3336d7d47b87b7a9
Reviewed-on: https://code.wireshark.org/review/24535
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d790c524b41907ebaa0f29afec19ee…
commit d790c524b41907ebaa0f29afec19ee6913173129
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Nov 23 01:55:27 2017 +0000
TLS: fix decryption with EMS and client auth
When extended_master_secret is enabled with client authentication,
decryption using an RSA private key file would fail because the wrong
master secret is derived. This happens due to an excess
CertificateVerify message in the handshake hash.
Bug: 14243
Change-Id: I02f8302ac4a85422f7df52a234bdddfcb5fe3307
Reviewed-on: https://code.wireshark.org/review/24543
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b4419eacce6d76f0e854280f8c20d4…
commit b4419eacce6d76f0e854280f8c20d4849ba2c067
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Nov 22 19:15:18 2017 -0500
zbee_parse_uint -> proto_tree_add_item[_ret_uint]
We don't need to unnecessarily wrap proto_tree_* functions.
Change-Id: Id2853cfb9059cd90af81e529bcec57eba10e6ab3
Reviewed-on: https://code.wireshark.org/review/24540
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c369db08eaecfd1ad6b87d43b1b99b…
commit c369db08eaecfd1ad6b87d43b1b99be0224752f4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 23 01:05:34 2017 +0000
Add comment with motive for dissectors.c.in
Change-Id: I825d4654aa76fee7288dc98eb7a92fe136d7542e
Reviewed-on: https://code.wireshark.org/review/24542
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2add5e701f3d7e397ef46f144e206f…
commit 2add5e701f3d7e397ef46f144e206fe4c127e9cb
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 22 19:34:28 2017 +0000
make-dissectors: Print the number of functions successfully parsed
Change-Id: I7364571ddc9b86efd41dcade97f843037e09f0ac
Reviewed-on: https://code.wireshark.org/review/24541
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f5bc86df043d93bb76226f0bbb2c4e…
commit f5bc86df043d93bb76226f0bbb2c4ef5613f226e
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Wed Nov 15 13:00:51 2017 +0100
RTPS: Topic Information feature now available for all the submessages
Before, the topic information feature showed the topic information
only for DATA submessages. Now it is working for all the submessages.
Change-Id: Ic2fe0ac1de2377a1db627f6498ac6d5159c9cb13
Reviewed-on: https://code.wireshark.org/review/24442
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a55a96a13ad60785f41f70a67cec2b…
commit a55a96a13ad60785f41f70a67cec2b321670b5de
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Nov 22 22:08:28 2017 +0100
ssl(-utils.h): fix parameter 'src' not found in the function declaration
[-Wdocumentation]
Change-Id: I922a1a12d2b562594354a18af5f92b21df3ce906
Reviewed-on: https://code.wireshark.org/review/24539
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=053b41dda37d45f4fad121a272ecdf…
commit 053b41dda37d45f4fad121a272ecdf7468696d03
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Nov 22 22:17:14 2017 +0100
wisun: fix no previous prototype for function
'proto_register_wisun/proto_reg_handoff_wisun' [-Wmissing-prototypes]
Change-Id: I44751363b2e1f16a2463d7e798bedb6f59995e13
Reviewed-on: https://code.wireshark.org/review/24538
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5e17502d395f489b3a630f5538f7e7…
commit 5e17502d395f489b3a630f5538f7e78abde8e140
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Nov 22 22:12:29 2017 +0100
802154: fix no previous prototype for function 'ieee802154_create_psie_tree'
[-Wmissing-prototypes]
Change-Id: I7755753aab9737967c355f4969cefc7871406b9c
Reviewed-on: https://code.wireshark.org/review/24537
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=462048b2d337fd35175767762c2f67…
commit 462048b2d337fd35175767762c2f67b0726c5ecd
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Tue Nov 14 15:22:54 2017 +0300
ZigBee ZDP cluster display
Added cluster names to binding requests and match descriptor. Cluster IDs now display
in HEX.
Change-Id: I1be4339e324ba4c98ce65016f5a2e60590235d71
Reviewed-on: https://code.wireshark.org/review/24437
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bceae3cff2c8a635ef112b3ac11f36…
commit bceae3cff2c8a635ef112b3ac11f36679d77ed20
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Tue Oct 31 17:13:58 2017 +0300
ZigBee ZCL Calendar Cluster dissector
Added dissectors for payloads of Calendar cluster.
Change-Id: I5c71078714521e25ad4db82b7ffe5166965d5280
Reviewed-on: https://code.wireshark.org/review/24201
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b993c6f05c3a9c3bd8748ffe57928a…
commit b993c6f05c3a9c3bd8748ffe57928a8d790371f7
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Nov 22 10:20:44 2017 +0100
sshdump: remove extra option check.
This looked a bit odd since the capture filter is variable length.
Removing it makes sshdump work.
Change-Id: I454c6263c04019d5e8ecbecd2490dd10185f5c67
Reviewed-on: https://code.wireshark.org/review/24531
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c58aed9b73d8989ef82145626e1701…
commit c58aed9b73d8989ef82145626e1701769b21e705
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Nov 22 10:18:25 2017 +0100
sshdump: add option to prevent promiscuous mode.
Bug: 14237
Change-Id: I5cecca8ed638c3935c7c77e3a304e4b0527d7fa3
Reviewed-on: https://code.wireshark.org/review/24530
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=36372a2465c94784240ba8c38b53b4…
commit 36372a2465c94784240ba8c38b53b4eedb234868
Author: Paul Offord <paul.offord(a)advance7.com>
Date: Mon Nov 20 09:49:38 2017 +0000
TRANSUM: Fix DNS-related bug and improve performance
These changes significantly improve the speed and accuracy of TRANSUM.
I have removed the concept of rrpd status as it wasn't being used in any
significant way and created unnecessary code.
The find_latest_rrpd(...) function was becoming very complex which made it
difficult to optimise performance for certain protocols. To overcome
this, I have introduced an equivalent function for each protocol e.g.
find_latest_rrpd_smb2(...). each of these new functions has a loop that
steps through the rrpd_list. I could have placed this loop one level up
in the nested call and so had one loop in the code that calls the new
function. However, I have found that this area is the prime cause of
delays in TRANSUM execution and so I want to avoid calling these new
functions with each step through the rrpd_list.
Finally, I have added code to improve the handling of retransmissions.
Bug: 14210
Change-Id: I038097f22a45ee74173aad1ae5732347f769b9bd
Reviewed-on: https://code.wireshark.org/review/24506
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=871f75ce85b7c3d0c58e05e90d3479…
commit 871f75ce85b7c3d0c58e05e90d34791042a8d5b8
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 22 09:45:03 2017 +0000
make-dissectors: Remove dependency on GNU Make >= 4.0
The $(file ...) function is only available since version 4.0.
Until something breaks or someone complains use the shell to
write dissectors.c.in.
Change-Id: Icfe260004ca04d825c370bb642fcdc4b4be8516f
Reviewed-on: https://code.wireshark.org/review/24532
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2f2c2b06e2f43c2a18bf1033253ee0…
commit 2f2c2b06e2f43c2a18bf1033253ee07c4b2b427e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Nov 13 08:25:49 2017 -0500
Add Zigbee encoding, ENC_ZIGBEE
Add the "special handling" of length = 0xFF for single byte or 0xFFFF
for uint16 value means size of field to follow is 0.
Ping-Bug: 14138
Change-Id: I0baa40f63152b9420a6569ca6cc5eba638fbc790
Reviewed-on: https://code.wireshark.org/review/24428
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Craig Jackson <cejackson51(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8d5726dccc6851aa99707f4ff3cf9d…
commit 8d5726dccc6851aa99707f4ff3cf9d11128cd822
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Nov 21 14:47:21 2017 -0500
Add support to handle DNS retransmissions
Add a preference to the DNS dissector to specify how many seconds can
elapse before a DNS query is considered a retransmission because the
transaction ID is shared with a previous request.
If retransmission is found, add expert info and hf_ field linking to
the original request.
If a retransmission of a response is found, add expert info and hf_ field
linking to the original response.
Bug: 14178
Bug: 13313
Change-Id: Idd77ab7f7638f5056d5690633c787a4d52285aee
Reviewed-on: https://code.wireshark.org/review/24525
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a501321cbbe2a23faa04031ba1567b…
commit a501321cbbe2a23faa04031ba1567be3d305daee
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Nov 21 18:08:05 2017 -0500
Enable TCP Calculate Conversation Timestamp by default
It doesn't appear to be too expensive of a calculation, so
have preference enable it by default.
Bug: 14182
Change-Id: I330dc99d871424d17c60ab8cff59ba0828dd069a
Reviewed-on: https://code.wireshark.org/review/24529
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=86919416eefb021630a869afa1da59…
commit 86919416eefb021630a869afa1da59bbb2cbb9c3
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Wed Nov 15 14:35:02 2017 +0300
ZigBee ZCL DRLC Cluster dissector
Added DRLC cluster dissector: cluster, attribute and command names.
Change-Id: Ic678052aaecffce3a4b8fd99d4e2b1eb91051f11
Reviewed-on: https://code.wireshark.org/review/24440
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1ae41459943496528fc5d2d54a7f94…
commit 1ae41459943496528fc5d2d54a7f945ccf9e0f89
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Wed Nov 15 15:21:55 2017 +0300
ZigBee ZCL Energy Management Cluster dissector
Added Energy Management cluster dissector: cluster, attribute and command names.
Change-Id: If6985ca59c314de4eb3d439999ea31fe167bb3e7
Reviewed-on: https://code.wireshark.org/review/24441
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=641e2fc573b98917916245bfdaf346…
commit 641e2fc573b98917916245bfdaf3461ea82c2565
Author: Derick Rethans <github(a)derickrethans.nl>
Date: Thu Nov 16 14:58:51 2017 +0000
Add support for MongoDB 3.6's OP_MSG to dissector
Bug: 14230
Change-Id: I008a0fb60c441c5f71788d695b398b73b76c0d69
Reviewed-on: https://code.wireshark.org/review/24450
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=454a7647f54743b0986b729c8956da…
commit 454a7647f54743b0986b729c8956da84e436f5dc
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Nov 21 22:15:29 2017 +0000
CMake: Remove duplicate PIDL files from CMakeLists.txt
Change-Id: I108a95aa4da80de6c96bf83d083b5ac4acd1a6ab
Reviewed-on: https://code.wireshark.org/review/24528
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=9a1a8f77e93601fa140b7d83058394…
commit 9a1a8f77e93601fa140b7d8305839455effccfff
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Nov 13 16:07:34 2017 +0100
BGP: enhance display
Display LACP Port Key/root Bridge Priority in Dec and Hex
mSTP => MSTP
Change-Id: I7079250da134e4bb60d2d5373bfdf2f31235f07a
Ping-Bug: 14200
Reviewed-on: https://code.wireshark.org/review/24401
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7540ac69381518661065b33096bd44…
commit 7540ac69381518661065b33096bd448d1b4100e5
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Nov 21 18:38:44 2017 +0000
Move the protocol registration routines back into libwireshark
Follow-up to b695b3e2f72998d66ca4b7a6826d4ce1688060c8.
Change-Id: I7e36519f2c3806c1205d05437671325080974257
Reviewed-on: https://code.wireshark.org/review/24524
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=4e63ec305bd7e8196561be58d12ee9…
commit 4e63ec305bd7e8196561be58d12ee99f54eca371
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Nov 21 19:56:27 2017 +0000
configure: Downgrade GNU Make message to a warning
There might be compatible make versions installed or the program
might have a non-standard name.
Change-Id: Ie9304e07da71f1f55522a0dfc539fbe9f557731d
Reviewed-on: https://code.wireshark.org/review/24526
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2ad15073446ebaf59f1a9186bf1f6a…
commit 2ad15073446ebaf59f1a9186bf1f6a5e55613d68
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Tue Nov 21 18:47:18 2017 +0100
oss-fuzzshark: fix linking issues due to register_all_protocols() removed from -lepan
During compilation of oss-fuzzshark (https://github.com/google/oss-fuzz/issues/1003):
Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to
`register_all_protocols'
Step #3: /src/wireshark/tools/oss-fuzzshark/fuzzshark.c:213: undefined reference to
`register_all_protocol_handoffs'
After cleanup of make-dissector-reg.py [b695b3e2f72998d66ca4b7a6826d4ce1688060c8]
these functions are no longer part of epan library (I really wonder why...).
oss-fuzzshark need to compile and link register.c on their own.
Change-Id: I79adf5c1513a0934f140bbf501c181bf14d7619b
Reviewed-on: https://code.wireshark.org/review/24523
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=0b2ecccd863b577335c1c87a902783…
commit 0b2ecccd863b577335c1c87a902783d3de158839
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Nov 20 12:44:17 2017 -0800
Add ThreadSanitizer configure-time options.
Add ENABLE_TSAN and enable-tsan options to CMake and Autotools
respectively which enable ThreadSanitizer, similar to AddressSanitizer
and UndefinedBehaviorSanitizer.
Change-Id: I79adf5c1516b0938f140bbf501c181bf14d7619b
Reviewed-on: https://code.wireshark.org/review/24515
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=8cbde93146bfd72e98b942fe81d693…
commit 8cbde93146bfd72e98b942fe81d69300f9488dac
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Nov 19 17:00:35 2017 +0100
gitlab-ci: add clang 5 and 6 builds.
Change-Id: I732cee0ced4c38298660716bf8d027f6b22be885
Reviewed-on: https://code.wireshark.org/review/24494
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4a125fb183a5944693854edb8cf07a…
commit 4a125fb183a5944693854edb8cf07a7bd57b90df
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Nov 21 04:09:09 2017 +0000
configure: Check for minimum required GNU Make version
Change-Id: Ifb76a8426f3233e277a129e1d4e4a5ac0c832503
Reviewed-on: https://code.wireshark.org/review/24518
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=1470aeef4cd4b1660d68c2907dc7b5…
commit 1470aeef4cd4b1660d68c2907dc7b58f9d16df58
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Nov 21 10:46:26 2017 +0100
Qt: Remove merge issue from Drag Drop
Remove a remissent merge artefact
Change-Id: I4c53d4b2adef124712091c40efccc1cad3db3301
Reviewed-on: https://code.wireshark.org/review/24521
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3cf73671d10a9c8f6505c57397dd83…
commit 3cf73671d10a9c8f6505c57397dd833c7e3efc4f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Nov 21 00:30:07 2017 -0800
From looking at the OpenAFS source, the RX abort code is signed.
Change-Id: I79f578ee5fe4e63d5bb6adc9d90f24fac5f82b02
Reviewed-on: https://code.wireshark.org/review/24520
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4a08c63e88715656e1d6294a8978f9…
commit 4a08c63e88715656e1d6294a8978f9573e516286
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Nov 20 15:15:27 2017 +0100
mqtt: Add sanity checks for MQTT v5.0 Reason Codes
Check if mqtt_msg_type is within boundaries of hf_rcode and gives
a valid hfindex.
Change-Id: Ib8ea710d7cd6c61ec493e218d64b50f6faa720c4
Reviewed-on: https://code.wireshark.org/review/24509
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=90e236fd09d68bab09edb7b93227fc…
commit 90e236fd09d68bab09edb7b93227fc02de561a38
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Nov 20 21:13:21 2017 +0100
Qt: Main Welcome hover sparkline color fix.
Use the default text color for sparkline in hovered items. This makes
the selected item look the same as non-selected items when hovering.
This is related to g1ed38dc2.
Change-Id: I96ba349067cf7d398d11425cfa5ada5e5b4d587c
Reviewed-on: https://code.wireshark.org/review/24516
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=23b6028e1d729e67af5be1bb4bdbb5…
commit 23b6028e1d729e67af5be1bb4bdbb5c88c284393
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Nov 20 15:42:05 2017 -0800
Qt: Remove an unused variable.
Change-Id: Iba1abe66cfa4d39e95cf85b9fc866789151127f9
Reviewed-on: https://code.wireshark.org/review/24517
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=dd562b503f2ff089968283b1593496…
commit dd562b503f2ff089968283b1593496c007f854a6
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Nov 20 09:18:59 2017 -0800
Qt: Move the MIME init thread to WiresharkApplication.
The Qt 4.8 "Starting a Thread" document at
http://doc.qt.io/qt-4.8/threads-starting.html says,
"Note that you must create the QApplication (or QCoreApplication) object
before you can create a QThread."
It looks like this changed some time around Qt 5.5 or 5.6, e.g.
https://codereview.qt-project.org/#/c/120793/, but just to be safe move
the MIME database initialization thread to WiresharkApplication. We
start reading the database later than I'd like, but it's still early
enough to make a difference here.
QMimeDatabase was added in Qt 5.0. Add version checks.
Change-Id: Ic80ebb8692e93b1e4aea7a8670f4fcf45e385b29
Reviewed-on: https://code.wireshark.org/review/24512
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=5968fc1cae5028002d4f974e046460…
commit 5968fc1cae5028002d4f974e0464608f73204b60
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Nov 20 19:58:46 2017 +0000
Rename UseMakeDissectorReg.cmake
Change-Id: I2723e7f0309dbe21f23b65818fbea3a7eadf13d4
Reviewed-on: https://code.wireshark.org/review/24514
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=fdc3023bece20993237f8e5ae959f2…
commit fdc3023bece20993237f8e5ae959f23fff437d69
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Nov 20 10:06:28 2017 -0800
OpenAFS always puts out 3 bytes of padding in an ack packet.
Change-Id: Ia956ac7df43c307a8d5adac5c78c894017f7f7ec
Reviewed-on: https://code.wireshark.org/review/24513
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6917ec769e4d23fe2fa212bec69c9c…
commit 6917ec769e4d23fe2fa212bec69c9ce9b65c1671
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Mon Nov 20 09:56:26 2017 +0100
Qt: Fix various smalles issues with drag-drop
Cleanup adding a filter and implement some
sanity checks in the drop code
Change-Id: I1778be16abdea3f93ed11fc610962c4a23f10a2f
Reviewed-on: https://code.wireshark.org/review/24505
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4fbb2df3cd160aba589dc0a576b44c…
commit 4fbb2df3cd160aba589dc0a576b44c2a63b4a6fe
Author: João Valverde <j(a)v6e.pt>
Date: Mon Nov 20 14:47:51 2017 +0000
Revert "make-dissectors: Be more resilient with whitespace"
This reverts commit ed9d08552049d061a8951f2dee5bc7b73173c14d.
It's causing a segfault on our Windows buildbots.
Change-Id: I3cdd31955bdec7be3ad91cff4af8dc3efdc9e8b7
Reviewed-on: https://code.wireshark.org/review/24510
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c26ad500ecf2cd04e9f0ba41402047…
commit c26ad500ecf2cd04e9f0ba41402047fa1cbae678
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 13 13:58:32 2017 -0500
dissector/mqtt: Add the MQTT v5.0 Reason Codes
RCs and their text descriptions are added by this
patch. We use defines for the values and descriptions
because they are shared by many Control Packets, so
in this patch we parameterize them to avoid writing
the descriptions multiple times.
Change-Id: I0afc2cbe69e8cfffa4f65df0b72f09045bb9b3a1
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24263
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=ed9d08552049d061a8951f2dee5bc7…
commit ed9d08552049d061a8951f2dee5bc7b73173c14d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Nov 20 11:31:18 2017 +0000
make-dissectors: Be more resilient with whitespace
Preemptively try to be more resilient for files with spaces in them
(for Windows).
Use newlines to separate file list. Clean up duplicate PIDL file entries.
Change-Id: Ib506cca785836e05e4665e911de0d45ab4da1165
Reviewed-on: https://code.wireshark.org/review/24507
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=496797f0dc414ede3e0e6ac297ab7d…
commit 496797f0dc414ede3e0e6ac297ab7d7ed966d76a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Nov 15 14:24:58 2017 +0100
ieee1905: fix typo bandwith => bandwidth
found by lintian
Change-Id: Id9b113eddae5bcbcfb0c9b3d1dfb6008aa3d7269
Reviewed-on: https://code.wireshark.org/review/24502
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=93e7bed24ef7ddbaeac915eedf820e…
commit 93e7bed24ef7ddbaeac915eedf820eb0b19a62e7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Nov 15 14:23:21 2017 +0100
ieee1905: fix typo addres => address
found by lintian
Change-Id: Idb5ee47b709e10d53192ac966b638e160cec60ea
Reviewed-on: https://code.wireshark.org/review/24501
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=fe0c2b04853226b64a1aa17fbef625…
commit fe0c2b04853226b64a1aa17fbef6257c856e3fd9
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 19 00:20:20 2017 +0000
Rewrite make-dissector-reg.py in C
The output compares equal to make-dissector-reg.py and the regex
should be more robust (multiline, complete start of function definition).
The primary motivation is to clean up the python script. This small
binary results in much cleaner code. The python script is used only
to generate plugin code, therefore it is renamed.
Also in my casual measurements the C code is much faster (without cache)
than the python script with the cache.
Change-Id: Id4e8cac3c836d56775aba4819357a95ef19bcb85
Reviewed-on: https://code.wireshark.org/review/24497
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=129cb60f56f42e58b9e589d79ac3ee…
commit 129cb60f56f42e58b9e589d79ac3ee317066d43e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 19 10:15:29 2017 +0000
Remove unused dissector registration prototypes, fix typo
Change-Id: Ide5d7f2241db4ac87ed516f91f0bcaca347bb546
Reviewed-on: https://code.wireshark.org/review/24496
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d17633892c9c3d25f3398487ca6359…
commit d17633892c9c3d25f3398487ca63592fdc973bc4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Nov 19 20:26:06 2017 -0500
packet-tds.c: Correct encoding for hf_tds_colmetadata_maxbytesize
It's just a FT_UINT16, not need for 2 encodings.
Change-Id: I502a61a2ff2a1fd05f1efa48912119f98d10e636
Reviewed-on: https://code.wireshark.org/review/24498
Reviewed-by: Craig Jackson <cejackson51(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5b5584878998ed602f560fffda3266…
commit 5b5584878998ed602f560fffda326670ac1c9083
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Nov 19 20:26:50 2017 -0500
README.dissector: Add note to add 2 encodings for FT_UINT_BYTES in
proto_tree_add_item
Change-Id: I728091998c531c992aa1b741b03e653460a0e77f
Reviewed-on: https://code.wireshark.org/review/24499
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=51ff1df443c02f03d93a68a989255a…
commit 51ff1df443c02f03d93a68a989255aa90740acc6
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Nov 19 19:06:40 2017 +0100
file-elf: remove unuseful check (found by Clang 6).
error: comparison 'guint32' (aka 'unsigned int') <= 4294967295 is
always true [-Werror,-Wtautological-constant-compare]
Change-Id: Id1f6a0a01dd897d263f7133a0d95aaecfba31e14
Reviewed-on: https://code.wireshark.org/review/24495
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=262a84c384353b2a88a6e81cdc499a…
commit 262a84c384353b2a88a6e81cdc499ab94a8316c2
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 1 20:22:32 2017 +0000
Fix (and chop) static build option
This sets the scope of the static build option to Wireshark support
libraries only.
Before the patch:
Static plugins don't work with CMake and autotools.
autotools static build is broken, and most likely will always be, as
building Wireshark all-static is difficult and time-consuming.
After the patch:
For CMake Wireshark will be built with static or shared libraries and
dynamic plugins. Everything just works. CMake apparently doesn't want
you building static and shared libraries at the same time.
For autotools Wireshark will be built with shared libraries by default.
--disable-shared and --enable-static options work as usual. Dlopened
plugins are not built if --disable-shared is given to configure (to
disable shared libraries). This is a limitations imposed by libtool.
Tested on Linux. This removes broken support for building plugins
statically.
Change-Id: Ib8e8176976f136eea93a2ce8f9857b6cf9bec64c
Reviewed-on: https://code.wireshark.org/review/24241
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=61bd626d5d10a7cd0e2dac667bbb26…
commit 61bd626d5d10a7cd0e2dac667bbb262452fe906f
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 19 17:43:02 2017 +0100
Qt: Fix Activation of menus
Fixes the bug, where submenu items are not properly activated
Bug: 14232
Change-Id: I007010310dfa8a6c7eba3ba8cdf3eac74701b0ba
Reviewed-on: https://code.wireshark.org/review/24493
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e9d8eba4163b515b58bfc0b8614a34…
commit e9d8eba4163b515b58bfc0b8614a34876b2628a8
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Nov 19 10:11:37 2017 -0500
packet-h223.c: Ensure conversation data exists
There is more potential for conversation data than previous circuit data
so ensure h223 conversation data exists in retrieved conversation.
Bug: 14233
Change-Id: I7074b1c110d40b4727812d0ef4f5391b6d2c0c33
Reviewed-on: https://code.wireshark.org/review/24492
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d6b3fcfeabdec2fee8804e2e7a7796…
commit d6b3fcfeabdec2fee8804e2e7a779606dba432bd
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Sun Nov 19 12:17:17 2017 +0000
CMake: Fix error from bab9abfb7d259e1daaf84776ed9d4d09e2469293
Fix a cut and paste error
Change-Id: I28fa3644d5b7969c8009f5722f270c8fa566dd34
Reviewed-on: https://code.wireshark.org/review/24491
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=1b79315aac6f42aaff8b286792af0b…
commit 1b79315aac6f42aaff8b286792af0b53a1b61a5a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Nov 19 08:17:12 2017 +0000
[Automatic update for 2017-11-19]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I52c4830ef81733156fa4ce0de65330c8aacd8932
Reviewed-on: https://code.wireshark.org/review/24487
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=bb47a68e0983fa4da5b607dd775e22…
commit bb47a68e0983fa4da5b607dd775e227528da1955
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Nov 18 22:31:45 2017 -0500
Move dissect_leb128 to file-elf.c
This allows for the removal of epan/dwarf.[ch]
Functionality could probably be handled by an encoding (like dissect_uleb128),
but for now keep it in file-elf.c as that's the only functionality
currently using it.
Change-Id: I84cf6af02abb3d53ea7d9b774e3313d77a1ff497
Reviewed-on: https://code.wireshark.org/review/24486
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=752d0ef753983b45142e76a71dcdf3…
commit 752d0ef753983b45142e76a71dcdf3ab3c082439
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Oct 11 21:55:55 2017 -0400
dissect_uleb128 -> tvb_get_varint/proto_tree_add_item_ret_length
Also update ENC_VARINT_PROTOBUF documentation while we're at it
Change-Id: I72e1f9175adc0c6a8bb03ceddba04ffd4844a12e
Reviewed-on: https://code.wireshark.org/review/24485
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ce8f8719004045497f95d1729f3305…
commit ce8f8719004045497f95d1729f33053da43f69f8
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Sat Nov 18 21:53:46 2017 +0000
CMake: Fix package requirements for building docs
Make ASCIIDOC and XSLTPROC packages required if building any of
the HTML, PDF or CHM guides.
Don't attempt to build the release notes if ASCIIDOC isn't found.
Change-Id: Id61653a635f91cbaffa32fb26ddbdbc568b74528
Reviewed-on: https://code.wireshark.org/review/24483
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1097e8020ab06bbcde3e3ce6f1e324…
commit 1097e8020ab06bbcde3e3ce6f1e324535990547b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Nov 18 17:43:27 2017 +0000
autotools: Library build products don't need explicit cleaning
Change-Id: I5d68c05f2844d6c9ae486531b189dbf10bc09cff
Reviewed-on: https://code.wireshark.org/review/24484
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f902981b2d0f845b57aa939d8c160d…
commit f902981b2d0f845b57aa939d8c160d3bc74499ef
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Nov 18 21:51:17 2017 +0000
Fix indentation
Change-Id: I558f23572dc36ba96fd1c2f904b1ac6b6c343297
Reviewed-on: https://code.wireshark.org/review/24482
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=23234ac87218ac69acb8ac2509127a…
commit 23234ac87218ac69acb8ac2509127af4c0ff088d
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Thu Nov 16 17:13:33 2017 +0300
ZigBee ZCL Device Management Cluster dissector
Added Device Management cluster dissector: cluster, command names.
Change-Id: I1ed9c53a09aed10584cd372630fbec5e661cacd8
Reviewed-on: https://code.wireshark.org/review/24449
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Boye Petersen <mbpflonidan(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bab9abfb7d259e1daaf84776ed9d4d…
commit bab9abfb7d259e1daaf84776ed9d4d09e2469293
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Sat Nov 18 20:16:32 2017 +0000
CMake: Clean up Windows build
Remove options that aren't supported on Windows
Don't use pkgconfig on Windows
Change-Id: I79718a1c43f56a9ec88f690490931b80b727dd68
Reviewed-on: https://code.wireshark.org/review/24481
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=adc1aff0a54bb54d313ea82cfeb3cb…
commit adc1aff0a54bb54d313ea82cfeb3cb928d8f1974
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Nov 18 10:36:54 2017 -0800
The header is host-endian, not little-endian. Note that.
Change-Id: I7fc2874026430c3d7e8633c48ee0558ad69d5c9a
Reviewed-on: https://code.wireshark.org/review/24480
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c42878bea8ea41954d3bae75ab749a…
commit c42878bea8ea41954d3bae75ab749ac7881201c9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Nov 18 10:27:11 2017 -0800
Reformat comment giving Kerberos 4 specification.
Change-Id: I06350d56aeedf0c0cb1c72f3597a093a6f97847c
Reviewed-on: https://code.wireshark.org/review/24479
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=241008c8611dc9bdcfe26af4f9d425…
commit 241008c8611dc9bdcfe26af4f9d4258126d9b261
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Nov 18 10:22:45 2017 -0800
URL for the document.
Change-Id: I9b381f923599f7b4750b21053cdfb3b1d72bce22
Reviewed-on: https://code.wireshark.org/review/24478
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7d4e0870708fc72df281214e3a6284…
commit 7d4e0870708fc72df281214e3a6284c7a6aba282
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Nov 18 15:02:16 2017 +0000
Update .gitignore
Change-Id: Ia066511bc27618ee8e0a55e046a6d9437a4c3175
Reviewed-on: https://code.wireshark.org/review/24477
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=b695b3e2f72998d66ca4b7a6826d4c…
commit b695b3e2f72998d66ca4b7a6826d4ce1688060c8
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 16 23:55:57 2017 +0000
Begin cleanup of make-dissector-reg.py
Move registration code to a new register.c file so it is readable.
Dissector load points are stored in a generated function pointer
array instead.
Simplify python script somewhat by not interleaving the plugin and
dissector logic.
Change-Id: I5ec21270f4e1550a5c911efa7f0dc4fc7fcb13a5
Reviewed-on: https://code.wireshark.org/review/24474
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d8e2bee9ea84ec5123d2023f32c0f0…
commit d8e2bee9ea84ec5123d2023f32c0f0d191834d32
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Nov 13 08:16:07 2017 +0100
.mailmap: update (of November)
Change-Id: Ia42fe05bbc250944441576a3b7894839f4fe6ed2
Reviewed-on: https://code.wireshark.org/review/24452
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=925214a3e750eefb62630cf68e168c…
commit 925214a3e750eefb62630cf68e168c31b014fd72
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Fri Nov 17 20:55:53 2017 -0800
ieee1905: Fix the incorrect dissection of radio operation restriction
The dissection was really wrong. Fixed now I have seen captures.
Change-Id: I038fbf8786306fad9c65c87aa5d58c155113c442
Reviewed-on: https://code.wireshark.org/review/24476
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c2b9c90367e2182bc7eea4832e5a23…
commit c2b9c90367e2182bc7eea4832e5a235c97b18133
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Nov 17 15:13:48 2017 -0800
Qt: Use QThreadPool instead of QThread.
I'm not sure how many Qt worker threads we're going to create at
startup, but using a thread pool is simple enough.
Change-Id: I66c3e1e628f8c38c8e3322e0c01ee5fccda2a98e
Reviewed-on: https://code.wireshark.org/review/24473
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a398a9573d36285fc4c6c8ddf5e8d4…
commit a398a9573d36285fc4c6c8ddf5e8d42a150e0fc8
Author: Cedric Izoard <cedric.izoard(a)ceva-dsp.com>
Date: Wed Nov 15 18:52:33 2017 +0100
ieee80211: Complete fixed size fields for SAE authentication
SAE authentication (used for mesh-point) introduced new non IE
fields (aka fixed size fields) that require explicit parsing.
The tricky part is that some of those fields don't have a fixed size...
- 'scalar' and 'finite field element' size depend of the group used.
Retrieve size of all groups supported by wpa_supplicant.
- 'anti-clogging token' size is not specified.
Bug: 14222
Change-Id: Id0aa8790c55b21b2797ba131de9e46c32519e2cc
Reviewed-on: https://code.wireshark.org/review/24446
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=18d49f467d21741394190c0b15f943…
commit 18d49f467d21741394190c0b15f9430df14f4c19
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Fri Nov 17 14:39:03 2017 +0100
Qt: Properly reset the byteview
Reset the byteview on every load of a capture file, and on every
start/reset of a capture
Change-Id: I0edd30ffddc64484bc6f009d99dfc6fc1a3ceb59
Reviewed-on: https://code.wireshark.org/review/24468
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ed68e05014018672ba6675c8b970b4…
commit ed68e05014018672ba6675c8b970b4471fbb68c5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Nov 17 23:09:09 2017 +0100
IEEE 802.11: fix an infinite loop
Presumably the element length is unsigned, otherwise it can be negative
and reincrement tag length.
Bug: 14231
Change-Id: I26d339aea7588a489b4252b67c212810029bff0e
Reviewed-on: https://code.wireshark.org/review/24472
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=658578a5b935d12c86b4181f9949da…
commit 658578a5b935d12c86b4181f9949da54a4ba7e0f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Nov 17 11:18:02 2017 -0800
Qt: Initialize QMimeDatabase in a worker thread.
As part of its initialization, QMimeDatabase parses the freedesktop.org
shared-mime-info database, which is a large-ish (2 - 4 MB) XML file.
This takes about 85 - 90 ms here.
We first access QMimeDatabase in our startup sequence when we load the
normal and capture application icons. Create a worker thread that
initializes QMimeDatabase as early as possible and load load the normal
and capture icons as late as possible.
Change-Id: I27e3d65d8ee1308a62d12d3ff7e1b95f82c2e75a
Reviewed-on: https://code.wireshark.org/review/24471
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=71cec74ccb626edd6255d5bbf7cf95…
commit 71cec74ccb626edd6255d5bbf7cf95c01c32430b
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Mon Nov 13 13:42:03 2017 +0100
Qt: Fix selection of elements
If two elements existed with the same filter expression, the first
element got selected allways. This is much more secure, as it only
takes the label into account. If the user by accident created two
buttons with the same filter expression, but different label and
wants to remove the second button, the first one no longer will be
removed instead of the second one.
Change-Id: I16130aa69cb853aedb9a5c9b0bbbb3eb64b467d1
Reviewed-on: https://code.wireshark.org/review/24399
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=584c478751db133ee416393a77edfc…
commit 584c478751db133ee416393a77edfc8c32b8101d
Author: Darien Spencer <cusneud(a)mail.com>
Date: Fri Nov 17 13:09:39 2017 +0200
fp: Fix mac TVB for edch t1
Using the '_caplen' function with length of -1 leads to a "truncated
RLC" error.
Change-Id: I5a5f650b244de1167ff7110558ad0559d0422103
Reviewed-on: https://code.wireshark.org/review/24462
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7f327cc5800817b7c443616235c91b…
commit 7f327cc5800817b7c443616235c91ba2c82e7860
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Nov 17 13:01:14 2017 +0100
3GPP NAS: fix dissection of PCO MSISDN container ID
3GPP 24.008 is not very explicit regarding the encoding, but after
rereading 3GPP 23.003 and 3GPP 29.272, it is most likely the E.164
number in TBCD encoding (so without TON/NPI byte).
Change-Id: Iae58ccc2919d28cb802015205b3b5fb97a1c4abe
Reviewed-on: https://code.wireshark.org/review/24463
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=252ea22b97c0c0fe7a7ab1c712f275…
commit 252ea22b97c0c0fe7a7ab1c712f275d52f1df2cd
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Fri Nov 17 12:03:03 2017 +0000
WSDG: Improve VS2015 chocolatey install
Created an AdminDeployment.xml file for use with the chocolatey
package for VS2015 Community Edition and updated the WSDG to
include it.
Bug: 14147
Change-Id: Id2a701067bf38874cf0bf534cca55dba9cfd30d4
Reviewed-on: https://code.wireshark.org/review/24464
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=2114923ec1a133e44ebd9403f19a07…
commit 2114923ec1a133e44ebd9403f19a07e1a0e539d4
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Nov 17 10:44:16 2017 +0100
[Juniper ST] Dissect the "known" parts of the Juniper header.
Ping Bug: 14195
Change-Id: I7ab05857c054a0d914db9373d182008215d67367
Reviewed-on: https://code.wireshark.org/review/24461
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=848cd4e291782ae9a59a3d4719d384…
commit 848cd4e291782ae9a59a3d4719d384870e2dddd8
Author: Darien Spencer <cusneud(a)mail.com>
Date: Fri Nov 17 10:39:47 2017 +0200
rrc: fixed incorrect constants
The macinf->content field should be compared to MAC_CONTENT_* and not MAC_*
Change-Id: I0dee7855938095c5d1c53f4db13003b90cf7ba91
Reviewed-on: https://code.wireshark.org/review/24460
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=00e217a732dc7d8c38ea5fac93dd81…
commit 00e217a732dc7d8c38ea5fac93dd81fcc0bc0ef2
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Nov 16 21:40:54 2017 +0100
ieee80211: Add dissection of BSS Transition Query
Bug: 14220
Change-Id: Iec155a6fbb179bd0e0aaf8b10fd7d420dc1a69bb
Reviewed-on: https://code.wireshark.org/review/24453
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=83cf4feaa980fb9d49e42bb3363c21…
commit 83cf4feaa980fb9d49e42bb3363c21357dbed6a3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Nov 17 08:14:01 2017 +0100
register(.h): fix parameter 'register_cb' not found in the function
declaration [-Wdocumentation]
Change-Id: I78afc76dcef56e46e296988299cab58c93eaeb03
Reviewed-on: https://code.wireshark.org/review/24459
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=81b246c040ab9310bf4fd96953b8fa…
commit 81b246c040ab9310bf4fd96953b8fa8717976c4e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Nov 16 21:31:48 2017 -0800
No need for a read/write descriptor for the output file.
Change-Id: I66539b27f09d3a5acaae2c0ee080bca984c17468
Reviewed-on: https://code.wireshark.org/review/24457
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bbeb5acb07132335fa7ccf89166429…
commit bbeb5acb07132335fa7ccf89166429359cf1be37
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Nov 16 20:23:33 2017 -0800
Allow dumpcap to write to a named pipe.
We didn't actually bother *opening* the named pipe if it wasn't named
"-" (meaning "use standard output"). Hilarity^WRandom failure
behavior
ensued.
Change-Id: If73cea232b13de664630d587167167ef53a95cba
Reviewed-on: https://code.wireshark.org/review/24454
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d9f8ddd78049eea607e052c562813e…
commit d9f8ddd78049eea607e052c562813e95475e8c44
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Thu Nov 16 17:31:07 2017 +0100
[PFCP] add port 8805
Port assigned by IANA
Change-Id: Ic04bc41878561239c83025ff2d5573daf7947b5b
Reviewed-on: https://code.wireshark.org/review/24451
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e2deb54414d4b54bf44f8369ccc9a0…
commit e2deb54414d4b54bf44f8369ccc9a0ad8fc7c172
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Nov 15 09:53:20 2017 +0100
gitlab-ci: add clang builds.
From clang 3.5 to 4.0, using official ubuntu docker image.
Change-Id: I60f41f2eb83990e4298ece27027413994d4f6440
Reviewed-on: https://code.wireshark.org/review/24405
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ac1d52aff5bdf74600ddc2f8f06cec…
commit ac1d52aff5bdf74600ddc2f8f06ceccf9d2037a6
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Nov 14 15:58:32 2017 -0800
Register protocols and handoffs in separate threads.
Instead of interleaving protocol registrations and status callbacks in
the main thread, move protocol registrations to a worker thread. Do the
same with protocol handoffs. This *should* be safe since the status
callbacks only update the UI.
This reduces startup time by about 200ms on my laptop:
Run OS Thread? Time
1 macOS N 340 ms
2 macOS N 260 ms
3 macOS N 252 ms
4 macOS Y 147 ms
5 macOS Y 146 ms
6 macOS Y 142 ms
7 Win 7 N 80 samples
8 Win 7 N 56 samples
9 Win 7 N 75 samples
10 Win 7 Y 31 samples
11 Win 7 Y 2 samples
12 Win 7 Y 0 samples
macOS was sampled using Instruments. Windows 7 was sampled using the
Visual Studio 2015 profiler.
We should do the same thing with our capture and tap event loops, but
that will likely require quite a bit more work.
Change-Id: Iac9a81d8f71668f5979b524744a03f6d80aee893
Reviewed-on: https://code.wireshark.org/review/24447
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=665eb78729c91b4056b3e58af4407f…
commit 665eb78729c91b4056b3e58af4407f51df603f55
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 14 13:44:27 2017 +0100
Qt: Add UAT move up and down buttons
Add two new buttons for moving entries up and down in the list.
Change-Id: I90e5c5812754391651885e2a622148cecc124099
Reviewed-on: https://code.wireshark.org/review/24413
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8ee4920c76fe690142482e22148f1e…
commit 8ee4920c76fe690142482e22148f1e2f14cae01f
Author: Martin Peylo <wireshark(a)izac.de>
Date: Wed Nov 15 16:24:33 2017 +0200
Registering CMP PKIMessage as BER dissector
Decoding ASN.1 BER as PKIMessage enables to examine a CMP (RFC 4210) message
which was saved as file.
Along the way, improving dissect_cmp_pdu function parameters to match required
API for register_ber_syntax_dissector(), factoring in creation of asn1_ctx.
Change-Id: I3284e6de9255e2b3cbf142c2904226b7e45b31f8
Reviewed-on: https://code.wireshark.org/review/24445
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9b93e7e5b2fb898fff1815345ac0a6…
commit 9b93e7e5b2fb898fff1815345ac0a63087a74758
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 15 19:58:39 2017 +0000
Explain where GeoIP_free comes from
Change-Id: I0a354cde4587a041bdb1fa4147bd88eed24ceb76
Reviewed-on: https://code.wireshark.org/review/24356
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=8d9fbdf8515b89f4739a4bddb80d94…
commit 8d9fbdf8515b89f4739a4bddb80d944d2a53b459
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 15 13:57:25 2017 +0100
Qt: Show as much as possible of UAT pathLabel
Remove the horizontal spacer between buttons an path label in UAT
views to show as much as possible of the path label.
Change-Id: I99d21ff6a1d151c9fcf83200a88b34b2e0c8eb5d
Reviewed-on: https://code.wireshark.org/review/24444
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f4e958c2ea08e1552a05e69d2a4098…
commit f4e958c2ea08e1552a05e69d2a409862077557d2
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Nov 15 11:07:29 2017 +0100
udpdump: add space.
Change-Id: I44960f64f16434ccdf033eaa2bfa96579da7cc4b
Reviewed-on: https://code.wireshark.org/review/24439
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ca8e9a84a905c51c1d426460c99bee…
commit ca8e9a84a905c51c1d426460c99beed6c833a9d0
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 15 08:47:31 2017 +0100
kerberos: Don't generate unused _vals tables
Put PA-FX-FAST-REPLY and PA-FX-FAST-REQUEST in .NO_EMIT ONLY_VALS
Change-Id: If0476c6d2bb78a15e3b984a7edafc3a7800fa490
Reviewed-on: https://code.wireshark.org/review/24436
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=256622cb710a3c8096d5d24b49cf45…
commit 256622cb710a3c8096d5d24b49cf45deb76e0772
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Nov 15 07:42:37 2017 +0100
QUIC: fix STOP_SENDING length
Change-Id: I954425bb54f9511ba2cea50adfa8c69ea322267c
Reviewed-on: https://code.wireshark.org/review/24429
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=129ffaf11b704141b9d1049b4bd293…
commit 129ffaf11b704141b9d1049b4bd293744493d4ad
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 14 19:12:46 2017 +0100
Qt: Update UAT clear button enabling
Check for enabling the clear button when loading a UatFrame.
Change-Id: Id9bbe4f99314d2798c4bccf10b57db99431a00fd
Reviewed-on: https://code.wireshark.org/review/24412
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=435a8fb79ce4a482ede1764ef77ccf…
commit 435a8fb79ce4a482ede1764ef77ccfe8eb7f931d
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Nov 8 10:58:41 2017 +0000
JXTA: Remove some assertions.
g4d2e653901 in 2009 removed some "if (tree)" checks, which in turn
exposed some DISSECTOR_ASSERTs which trigger on short packets. Add an
expert info field for truncated media data and comment out the
assertions.
The jxta-spec.dev.java.net specification link is dead. Add what appears
to be the current location.
Change-Id: Ic669c6631c6058a853d69ecd38ef4d2065c7eb24
Reviewed-on: https://code.wireshark.org/review/24426
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=21d96b04443a63e6e0b5fdffd19017…
commit 21d96b04443a63e6e0b5fdffd19017ace057ee25
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Nov 14 13:50:10 2017 -0800
JXTA: Simplify some expressions.
The sizes of guint8, guint16, and guint32 are always 1, 2, and 4 bytes
respectively. Just use 1, 2, and 4.
Change-Id: I857d33873cc5831ba23544475f721e485b8bd817
Reviewed-on: https://code.wireshark.org/review/24427
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1810801a688eb5d15fb4a6bdaeb03a…
commit 1810801a688eb5d15fb4a6bdaeb03a497abfdc47
Author: Anders <anders.broman(a)ericsson.com>
Date: Tue Nov 14 15:41:32 2017 +0100
Handle LINKTYPE_JUNIPER_ST 200.
Bug: 14195
Change-Id: Ic6be8e1f8169968c48376984c0d1a1a69c67f32a
Reviewed-on: https://code.wireshark.org/review/24415
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=88d8fa7440f923905849338ee1bd70…
commit 88d8fa7440f923905849338ee1bd70d238e799cd
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Nov 14 20:11:09 2017 +0100
UI: Fix seg fault of software update language init
Set only software update language when language is configured.
Change-Id: If3f0e304b95863a30fb7bb69197addf4bad689c7
Reviewed-on: https://code.wireshark.org/review/24414
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5d1328c5285e1cd3f4e1620dd33bab…
commit 5d1328c5285e1cd3f4e1620dd33babda47bafe92
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Sep 24 08:29:07 2016 -0400
Kerberos - Add support for RFC 6113
Bug: 8974
Change-Id: I43998a64fc34dfeb1c0a8d702d5bdc5aa74d57de
Reviewed-on: https://code.wireshark.org/review/17879
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=27011d312343a0dac06736087d1a94…
commit 27011d312343a0dac06736087d1a94ffd7ab763e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 14 19:08:56 2017 +0100
Qt: Change delete_list icon transparent value
Update the delete_list icon to have same transparent value as the
other icons used in UAT handling.
Change-Id: I5de7f3d6c0292e6ffde7d8cfd08a899e135fe108
Reviewed-on: https://code.wireshark.org/review/24411
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f2ee064bbbdc6f00466d0705401fbd…
commit f2ee064bbbdc6f00466d0705401fbdaeaa965702
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Nov 14 19:05:57 2017 +0100
mqtt: Copy UAT match_criteria value
Change-Id: Ifdb743bcf1f644d412d1ac35801347b5355d1754
Reviewed-on: https://code.wireshark.org/review/24410
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b0b5bda7cb97ccf3ae5e0052b8d5c0…
commit b0b5bda7cb97ccf3ae5e0052b8d5c05b69f23f9f
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Tue Nov 14 17:45:44 2017 +0000
Revert "Windows tests:"
This reverts commit b4fc532372f0add6bf1434a54aa1a3a457ab3a88.
No longer required.
Change-Id: I0ec135d7b54f2aa1b8369fe8192fd2e725ffd5a8
Reviewed-on: https://code.wireshark.org/review/24409
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=c43c58c434cced3df2e208094d1891…
commit c43c58c434cced3df2e208094d1891e8447e0cfc
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Tue Nov 14 15:36:57 2017 +0000
CMake: Make Qt5 packages required if building Qt version
This stops folks failing when they don't have Qt
but are still attempting to build the Qt version.
Change-Id: I31eb9433b25ca9a717cd10bc165f3820ae31687e
Reviewed-on: https://code.wireshark.org/review/24406
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=b4fc532372f0add6bf1434a54aa1a3…
commit b4fc532372f0add6bf1434a54aa1a3a457ab3a88
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Tue Nov 14 16:24:42 2017 +0000
Windows tests:
Add some debug info to the failing tests by displaying
the LANG var.
Change-Id: I0a7316d06a6aca035b46c3e6211ac8e93425e295
Reviewed-on: https://code.wireshark.org/review/24407
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=3006ffa615d02dabe7431394b07e8b…
commit 3006ffa615d02dabe7431394b07e8b2d9888ca41
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Nov 13 23:43:10 2017 +0000
CMake,editcap: avoid noise with editcap -F and -T options
Avoid printing a noisy "option requires an argument" error when using
'-T' and '-F' as documented. Fix warning that started showing on
macOS
with CMake 3.9.4 about CMP0058 since v2.5.0rc0-1180-g799f4f0e14.
Change-Id: Ie0cc352c6b0b2724997e7fe6b49fd5b1f02d1e07
Reviewed-on: https://code.wireshark.org/review/24404
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Ahmad Fatoum <ahmad(a)a3f.at>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=a595d7326b4a42f15a7b3109a6e81b…
commit a595d7326b4a42f15a7b3109a6e81b4de02bbc14
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Nov 13 21:58:33 2017 +0100
MPLS: use directly proto_tree_add_item for display PW ACH Channel Type
Ping-Bug 14208
Change-Id: Idefa2611fd6725b65c1994ef1f4ff4b00fcf67c7
Reviewed-on: https://code.wireshark.org/review/24403
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b1302f0f28e8af4f3b3f47bd0a6962…
commit b1302f0f28e8af4f3b3f47bd0a6962e514af7b56
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Nov 13 08:27:52 2017 -0500
Remove circuit_id from Lua tests
It was removed from packet_info when circuit API was removed. Remove
tests that call circuit_id for testing.
Change-Id: I88e54b288d9d8f99b63e0828663b3025c57e0ec8
Reviewed-on: https://code.wireshark.org/review/24400
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0bba9fb60f832dcc475b0de25e1453…
commit 0bba9fb60f832dcc475b0de25e14537d61e11a0f
Author: Erwin Rol <erwin(a)erwinrol.com>
Date: Sun Nov 12 18:44:02 2017 +0100
RDM: Add ACK timer and ACK overflow handling
Change-Id: I1531e84b91becba97300cf30f8bbfd12290ced61
Signed-off-by: Erwin Rol <erwin(a)erwinrol.com>
Reviewed-on: https://code.wireshark.org/review/24396
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=65bab716bee4f537f6dd63ec9dba3b…
commit 65bab716bee4f537f6dd63ec9dba3b5df2393672
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Mon Nov 13 10:27:46 2017 +0100
[PFCP] minor corrections
Change-Id: I981c7bb9b601a38abeeb21d67ff4f7af824c234e
Reviewed-on: https://code.wireshark.org/review/24398
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=800b26edbe34e135cc9be1d4395db2…
commit 800b26edbe34e135cc9be1d4395db2c13ae1213f
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Nov 11 17:16:13 2017 -0500
Remove circuit API
Replace with conversation API that limits the "endpoint" to a single
uint32 value.
The intention is to eventually have "layered" endpoints, because circuit_id
was used in cases where src/dest port have already been populated (and
are used for layers above). Those src/dest ports should just be treated
as just another endpoint, but we currently only have support for one.
Change-Id: Ic6aa7ef0241275aa4dfde9459194369b48c72960
Reviewed-on: https://code.wireshark.org/review/24369
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7c40580584eac67a23633e58810028…
commit 7c40580584eac67a23633e58810028dddc58781c
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 12 21:39:25 2017 +0100
Qt: Really fix the packet list selection
Really fix the selection of a row in the packet list
Change-Id: I87ab36146bd9b2a130f443717ce73609a1c0b656
Reviewed-on: https://code.wireshark.org/review/24397
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=58a44aef230c2d9ddcdca6c892d22e…
commit 58a44aef230c2d9ddcdca6c892d22e0bd836c9d5
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 12 11:41:09 2017 +0100
Qt: ToolbarMimeData and display
Implement the mime data for the toolbar in the same fashion as it
has been done for the drag-drop of the field filter.
Change-Id: I2b1ac7f82b637c999f458700c9ab24a9e4dcbcb8
Reviewed-on: https://code.wireshark.org/review/24378
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7deb2b432b08a5bae7c138eae1a0b2…
commit 7deb2b432b08a5bae7c138eae1a0b2a2a50a35b8
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Nov 12 20:33:35 2017 +0100
mqtt: Use proto_tree_add_item_ret_uint()
Change-Id: Iccbbb007b4d733b812e2a2cb528477b1417bed6e
Reviewed-on: https://code.wireshark.org/review/24394
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Flavio Santes <flavio.santes(a)1byt3.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=3105382bed06a17f993421e2889e66…
commit 3105382bed06a17f993421e2889e66189f2551ca
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Nov 12 20:46:31 2017 +0100
Qt: Show ByteView for first packet
Change-Id: Ie5b09f0ac8db0adb999633f3367339b8f50eabe9
Reviewed-on: https://code.wireshark.org/review/24395
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b5a1145cf15b51dc6d6a5614c5304c…
commit b5a1145cf15b51dc6d6a5614c5304cbe74cbf556
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Nov 12 20:28:36 2017 +0100
Qt: Select correct packet from list
Change-Id: Id29d74506f7f009b7f14a86d8fc7c299711c4c2c
Reviewed-on: https://code.wireshark.org/review/24393
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e38c89d3a7aef37c404a616c493ca3…
commit e38c89d3a7aef37c404a616c493ca31c10a5afbb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Nov 12 10:55:58 2017 -0800
Link with ZLIB_LIBRARIES if you link with wiretap.
Wiretap may use zlib; if it does, ZLIB_LIBRARIES is set to refer to
zlib. On UN*X, you may be able to get away with linking a
dynamically-linked shared library with other dynamically-linked shared
libraries and not linking programs linked *with* that shared library
with those other shared libraries, but that may not work on Windows.
We link most programs that use wiretap with ZLIB_LIBRARIES; do so with
androiddump and randpktdump as well.
Bug: 14207
Change-Id: I8e94197e06f5fd0ff8c95aa509dbcc2ff2a44cd4
Reviewed-on: https://code.wireshark.org/review/24389
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5be009d48d4ae869347309b6713d1e…
commit 5be009d48d4ae869347309b6713d1e3a206e0398
Author: Anders <anders.broman(a)ericsson.com>
Date: Sun Nov 12 19:37:18 2017 +0100
Fix typo.
Change-Id: I99f122fb154aedce7c129043d55661ce4de09bbc
Reviewed-on: https://code.wireshark.org/review/24388
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=54e54c64bdfb11186e8930396be664…
commit 54e54c64bdfb11186e8930396be664796080ed6c
Author: Anders <anders.broman(a)ericsson.com>
Date: Sun Nov 12 19:22:31 2017 +0100
[Diameter] Fix typo avp name="OC-Feature-Vector" code="622"
Change-Id: I678d6f4aa563630db1abdfe03474166de18b2a01
Reviewed-on: https://code.wireshark.org/review/24387
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66b5afa2168e6957dd5f4b55b00b65…
commit 66b5afa2168e6957dd5f4b55b00b65bde4a35693
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Nov 12 16:01:34 2017 +0100
extcap: use SPDX identifiers for licences.
Change-Id: Id56687f86f4c60494dad0b6d58550ee45b0b203c
Reviewed-on: https://code.wireshark.org/review/24381
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2b03b41bd0a894576b59c2dc6bf1d5…
commit 2b03b41bd0a894576b59c2dc6bf1d581c970cf16
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Nov 12 16:49:56 2017 +0100
ssl-utils: Add export ssl_data_alloc
For reuse on QUIC dissector
Change-Id: I005fc3fe7a559fdb7a62e3d40450a4a6b25bf2f5
Reviewed-on: https://code.wireshark.org/review/24383
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d283939303f9ebad95ccd845930417…
commit d283939303f9ebad95ccd845930417f18851c6b9
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sun Nov 12 16:55:31 2017 +0100
Fix "might be clobbered by 'longjmp' or 'vfork' warning
Change-Id: I51ec17b5eabe7b0f9fc68f4cf599ca55b8e4631d
Reviewed-on: https://code.wireshark.org/review/24385
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3d77e1bbcdbc5064fc8b2c971a4cbf…
commit 3d77e1bbcdbc5064fc8b2c971a4cbfc4cd5e2f72
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sun Nov 12 13:51:00 2017 +0100
[PFCP] Update to 3GPP TS 29.244 V14.1.0 (2017-09)
Change-Id: I69ad8c9a852f400e2918c4eca7365c719df734f5
Reviewed-on: https://code.wireshark.org/review/24380
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e13e2df9a1278903c66292a4f7b823…
commit e13e2df9a1278903c66292a4f7b823c707b30cb3
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 12 11:29:13 2017 +0100
Qt: Rename packetSelection to frameSelected
In order to consolidate the interfaces between certain parts of the UI,
the signal emitted after a frame change has occured, has to include the
number of the frame. This led to two signals for frame change, and therefore
packetSelection is to be removed.
Change-Id: I24e0e0890291d2243935b0c48387beb66904bfa3
Reviewed-on: https://code.wireshark.org/review/24377
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=447291d84a63d3e707fd00111ba465…
commit 447291d84a63d3e707fd00111ba465e5c230c849
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 12 11:16:34 2017 +0100
Qt: Fix DragDrop on ProtoTree
Fix two issues, first that you could not move the scrollbar as it would
initiate a drag-drop operation. Second, if you start a drag-drop operation
at the top of a field, it would select the field you move over as well.
Change-Id: I553785b1b6c586919e025d3042a876701f36860d
Reviewed-on: https://code.wireshark.org/review/24376
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8e5436687a46de93ee40f4e8ab510c…
commit 8e5436687a46de93ee40f4e8ab510cdc5768f9a5
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 12 11:56:10 2017 +0100
Qt: Clear up the label
The modifier key is a hidden option for now, with the label only
showing the filter expression and the description
Change-Id: I4c983ed0d4fadbd69f0836ecfc85ea8e1109478e
Reviewed-on: https://code.wireshark.org/review/24379
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=98ca698a3705336a75020e03ba2ec5…
commit 98ca698a3705336a75020e03ba2ec5e6d80e34cc
Author: Roland Knall <rknall(a)gmail.com>
Date: Sun Nov 12 11:09:38 2017 +0100
Qt: Add Modifier to drop only field
Add a modifier to the drag-drop operation, to only drop the field
name as filter, instead of the complete filter expression
Change-Id: I9da96906575397191e821e3494a42e0f10d51f45
Reviewed-on: https://code.wireshark.org/review/24375
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e95623cd6b46552eb7dd97cfbbb472…
commit e95623cd6b46552eb7dd97cfbbb47292ba002fde
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Nov 12 04:00:56 2017 +0000
Qt: do not crash when selecting a field without tvb
If no tvb is attached to a field, crashing is not the expected result.
Change-Id: Ica0e95326cfcfeb015016770d1b930a9f0447066
Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView")
Ping-Bug: 14205
Reviewed-on: https://code.wireshark.org/review/24370
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5bd8fb4131a92848614590fe5d7aa2…
commit 5bd8fb4131a92848614590fe5d7aa28fc000fdb2
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Nov 12 08:11:13 2017 +0000
[Automatic update for 2017-11-12]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I18adb8aceae2a8962697284087d43e3b30d133f1
Reviewed-on: https://code.wireshark.org/review/24371
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=bd130e92733db5069331021f5be4cb…
commit bd130e92733db5069331021f5be4cb4717603375
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Sat Nov 11 16:03:33 2017 -0800
ieee1905: Use BASE_UNIT_STRING and &units_dbm rather than appending
the string 'dBm'.
Change-Id: I5f4ddcf98902c53f6f014e64b51eb4c3c263e7e1
Reviewed-on: https://code.wireshark.org/review/24368
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=95d62171934dfcebc0df44ca15e894…
commit 95d62171934dfcebc0df44ca15e894c6db0269ad
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Nov 11 20:35:08 2017 +0100
mqtt: Whitespace and indent fixes
Change-Id: Ie6470cd20871b0aac17d19c67aba4b7229f906e6
Reviewed-on: https://code.wireshark.org/review/24367
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b032b338010830fd9994a5530f743d…
commit b032b338010830fd9994a5530f743dbd3112a3ae
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Nov 10 22:23:47 2017 +0000
autotools: rename libui_dirty to libui_generated
Change-Id: I382fbc2af5c42772e4feb65f33ea2a326b9b5c62
Reviewed-on: https://code.wireshark.org/review/24351
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fa6dc7b3fb60e38869f01c73fc240a…
commit fa6dc7b3fb60e38869f01c73fc240a07a7db1eda
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Nov 10 18:56:38 2017 +0000
autotools: Be more consistent with variable names
Change-Id: I644fbe7796a83c98861a4ebb9200ee41de27c897
Reviewed-on: https://code.wireshark.org/review/24350
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3f11c2f7c53ff07aa2d402eda01325…
commit 3f11c2f7c53ff07aa2d402eda013259706f257f8
Author: Owen Kirby <osk(a)exegin.com>
Date: Thu Nov 9 18:33:51 2017 -0800
Wi-SUN Protocol dissection and IEEE 802.15.4 IE cleanup.
This patch adds dissection for the Wi-SUN Field Area Network standard. Wi-SUN
packets are encoded as a collection of IEEE 802.15.4 information elements. This
required a bit of refactoring in how the IE dissector table is handled so that
external protocols could supply their own dissectors.
While I was working with the IEs, I also added support for the TSCH Timeslot and
Global Time IEs from the IEEE 802.15.4 standard in addition to some general
cleanup.
Change-Id: I2858e4ab577756568e33b86adfe282967899abd5
Reviewed-on: https://code.wireshark.org/review/24331
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=499ae4ab573fbfefdb1c200e3177e1…
commit 499ae4ab573fbfefdb1c200e3177e18844e545b5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 16:25:16 2017 +0100
address(.h): fix commas at the end of enumerator lists are a C++11 extension
[-Wc++11-extensions]
Change-Id: Ibfc95e085b2712f7a71f6559ae205de87aab12f6
Reviewed-on: https://code.wireshark.org/review/24365
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2092b66a0bbcef2764e3d708a44af2…
commit 2092b66a0bbcef2764e3d708a44af2f378b39dba
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 16:20:42 2017 +0100
WPS: no previous prototype for ‘proto_reg_handoff_wps’ [-Wmissing-prototypes]
Change-Id: Icb5220af362a25f081f0b5d33f92a9013723bca9
Reviewed-on: https://code.wireshark.org/review/24364
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=81805717dea0f1f2048748165e9681…
commit 81805717dea0f1f2048748165e968147f0b9cd7a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 16:19:45 2017 +0100
RIP: no previous prototype for ‘proto_reg_handoff_rip’ [-Wmissing-prototypes]
Change-Id: I49e6ecec2e3998ff212069e88618bea36935c894
Reviewed-on: https://code.wireshark.org/review/24363
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fea67da276df03ed39fe552d6df2f3…
commit fea67da276df03ed39fe552d6df2f3304a03e7c1
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sat Nov 11 15:44:33 2017 +0100
[PFCP] OHC: fix Port number field present
Port number should only be included with UDP/IP header
Change-Id: Ie2655d2b6f1b755bff47e74723f36b1ee87170f9
Reviewed-on: https://code.wireshark.org/review/24361
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=13581e6acaab7f0d98b530a1db1e0b…
commit 13581e6acaab7f0d98b530a1db1e0b80c7c6a938
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sat Nov 11 15:47:11 2017 +0100
[PFCP] display changes
For readability, DEC<->HEX and "IE length"
Change-Id: I753d8f6cba43a6b34fd06b49b1ffa96f13790c67
Reviewed-on: https://code.wireshark.org/review/24360
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bb69464e4c5d88a175025a79c23636…
commit bb69464e4c5d88a175025a79c23636d7628576b0
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sat Nov 11 15:41:12 2017 +0100
[PFCP] F-TEID: add missing TEID
Change-Id: I4668208b5bf1d2cc168c7aa8f593510d55f27c23
Reviewed-on: https://code.wireshark.org/review/24359
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da24baf510df4e5273da57d3b867a4…
commit da24baf510df4e5273da57d3b867a4ffbc64bde1
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Nov 11 17:55:26 2017 +0100
asciidoc.conf, sort-and-group: (trivial) fix a comment
sort-and-group produces a comma-separated list, the last two entries are
separated by "and"
Change-Id: I3e6c153c764641664453c4d091fdb84bb308e689
Reviewed-on: https://code.wireshark.org/review/24366
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=ac41b0a94153dd5b7c1ca946b74f2e…
commit ac41b0a94153dd5b7c1ca946b74f2ee3f81ff932
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sat Nov 11 15:38:43 2017 +0100
[PFCP] IPv4, IPv6 address present
Change-Id: I4efedb43a8a3688931c4815ea5fa82bd01248b98
Reviewed-on: https://code.wireshark.org/review/24358
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=29c32812b42a8983cb2210833cd9c3…
commit 29c32812b42a8983cb2210833cd9c3e0001d5d03
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 15:17:16 2017 +0100
RTLS: Add link to doc about this protocol
Change-Id: Ib0207bb10c948637359f4afb853003065e3ca1bd
Reviewed-on: https://code.wireshark.org/review/24344
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4ec8ebcebbbd67a54429d3d18982aa…
commit 4ec8ebcebbbd67a54429d3d18982aaefb6118b91
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sat Nov 11 12:14:09 2017 +0000
SPDX: Convert doc and docbook.
Replace the GPLv2+ blurbs in the doc and docbook directories with SPDX
headers as appropriate. This includes example code such as
packet-PROTOABBREV.c.
Remove dfilter2pod.pl and dfilter2xml.pl. We haven't used them since
2010.
Change-Id: I4adec02a9a4bc3e71e32bdf89f2754edaf696938
Reviewed-on: https://code.wireshark.org/review/24343
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=92be91f57a162136523f40b6f9eefd…
commit 92be91f57a162136523f40b6f9eefddacf7a3328
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 15:38:01 2017 +0100
[o|t]wamp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Idfa33bb194a491e2b97cc7e4a95f4da8c30a5f58
Reviewed-on: https://code.wireshark.org/review/24349
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1cf6d365b2e4c0e97411698ba027d6…
commit 1cf6d365b2e4c0e97411698ba027d62de4437523
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 15:37:01 2017 +0100
mqtt: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ibd0041e0031c92073c89a1535677167e4fc90443
Reviewed-on: https://code.wireshark.org/review/24348
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fdc8845803d15bc55fe8673bec2229…
commit fdc8845803d15bc55fe8673bec22290f77cceed1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 15:34:46 2017 +0100
ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I67b2d6f7d6e12f541780dfb17f5bbfe20bae3cf4
Reviewed-on: https://code.wireshark.org/review/24347
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ff302a283d2654105143377823dc6f…
commit ff302a283d2654105143377823dc6fafb88885c3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 11 15:30:38 2017 +0100
btmesh: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I7218d74e1dc4d014dadd86f55b7805ba1581f9c3
Reviewed-on: https://code.wireshark.org/review/24346
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=73329d786ba6643784dc0c31cede88…
commit 73329d786ba6643784dc0c31cede88ad4da7db4a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Nov 11 15:14:45 2017 +0100
DVB-CI: ensure that conversation_t stucture exists before using it
Bug: 14202
Change-Id: Ie0cad9c1cd1d0ea1392a61194567e80bb2b5a566
Reviewed-on: https://code.wireshark.org/review/24345
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=eaee0678ce2566d3bef43d83acc746…
commit eaee0678ce2566d3bef43d83acc7463c737f8ae3
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Nov 11 11:06:53 2017 +0100
mqtt: Use guint for offset
Change-Id: Ie7b4a540e68121dbe5cd14a9aac80a1f9aae90b3
Reviewed-on: https://code.wireshark.org/review/24342
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f35aa91c1a07e420b4d4a9c51342bd…
commit f35aa91c1a07e420b4d4a9c51342bddb8d3640c9
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Fri Nov 10 12:35:49 2017 -0500
dissector/mqtt: Dissect the UNSUBACK payload
MQTT v5.0/UNSUBACK includes a payload conformed
by a list of reason codes. There is no length
field for this payload, so it must be computed
as the difference between the full message size
and the current offset.
Change-Id: Ibf7ef4131408e26e2389c3ab89107c22c16412a1
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24337
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d337f4c5b74a2824bc7de34161ac30…
commit d337f4c5b74a2824bc7de34161ac30b54a3b0e4e
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Thu Nov 9 18:34:04 2017 -0500
dissector/mqtt: Payload length computation
This patch modifies how the payload length is
computed. With this patch we want to simplify
and reduce the number of operations.
Change-Id: Ie1c9a3f26c689e92fbbd57c34e4f68abd3ea7d02
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24336
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bce5b50f734bfd63b29ce44bfce29c…
commit bce5b50f734bfd63b29ce44bfce29cb2d0d094b9
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Nov 11 03:25:36 2017 +0000
Qt: Fix use-after-free crashes when changing packets
QTabWidget::clear() is documented to remove all tabs without deleting
them. As a result, findByteViewTextForTvb will still find ByteViewText
children with freed tvbs. Fix this by deleting the tabs too.
Change-Id: I5b4fdc7154a3804e3bd5f360749e95d178ffe580
Bug: 14199
Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy")
Reviewed-on: https://code.wireshark.org/review/24339
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=7cbbbe0bde475786d661fe887ee234…
commit 7cbbbe0bde475786d661fe887ee2340a269f1063
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Nov 11 01:15:32 2017 +0000
Qt: avoid undefined behavior in ProtoTree::eventFilter
UBSan complains about "ev" being a "QEvent" rather than a
QMouseEvent.
Change-Id: I9e59ffbe16df2ef20b7856e6dd2d9ef246632de6
Fixes: v2.5.0rc0-1608-g4d6454e180 ("Qt: Drag n Drop Filter expression from Packet
Tree")
Reviewed-on: https://code.wireshark.org/review/24338
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=0c382106f8504315039510e4adc67e…
commit 0c382106f8504315039510e4adc67e0e5c2003cd
Author: Helmut Buchsbaum <helmut.buchsbaum(a)gmail.com>
Date: Fri Nov 10 12:13:05 2017 +0100
dissector/amqp: fix TLS/SSL payload dissection
To enable TLS/SSL payload dissection for AMQPS traffic add the
AMQP handle as SSL dissector for the actual AMQPS port.
Thus we have successfully decrypted our AMQPS traffic using
a pre-master-key file.
Change-Id: I63dec2217fb5645007da010f651846834abacdbc
Reviewed-on: https://code.wireshark.org/review/24335
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6ef9538770e95bfcdda8422281013a…
commit 6ef9538770e95bfcdda8422281013a517f92df3a
Author: Matej Tkac <matej.tkac.mt(a)gmail.com>
Date: Fri Nov 10 10:50:09 2017 +0100
[PFCP] PDN Type Dissection and minor fixes
Added PDN Type dissection (3GPP 29.244 Section 8.2.79)
Fixed bit order in dissect_ue_ip_address
Added "Encoding error" message if MBR or GBR has different format
than specified in doc.
Change-Id: I3b8b096fa490a2b4a16b3e6e9a640f92e389be1f
Reviewed-on: https://code.wireshark.org/review/24334
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cb7e896a4a450294dde70f01dc7cc1…
commit cb7e896a4a450294dde70f01dc7cc105a883ef44
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Nov 9 20:58:38 2017 -0500
Add frame number to packet comment dialog
Bug: 14185
Change-Id: I9f52999339d3c34502d4e046e22f05a83fa773bb
Reviewed-on: https://code.wireshark.org/review/24330
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fd46a58581d0e5bacfb8bf5e57670a…
commit fd46a58581d0e5bacfb8bf5e57670adaacaf18ab
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Nov 9 20:29:30 2017 -0500
packet-twamp.c: General improvements
1. Always wait for Greeting packet, otherwise packet must not be TWAMP control
2. Dissect packets on first pass
3. Use value_string for control state
Ping-Bug: 14171
Bug: 14196
Change-Id: I642c6fd61d29744ac4fd4185a9081eba27138c0a
Reviewed-on: https://code.wireshark.org/review/24329
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e935e902d6ca1ce3265edd944bfe04…
commit e935e902d6ca1ce3265edd944bfe045b05706ee1
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Thu Nov 9 05:10:11 2017 -0800
ieee802.11: Fix the display of the Cisco Aironet DTPC value.
The DTPC value is in dBm, so make it so.
There is a second byte that we are looking for a spec on.
Bug: 14193
Change-Id: I69f0af295954958fde38b74e965f6fb66063513b
Reviewed-on: https://code.wireshark.org/review/24322
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=19a46ba774b127ca0b6a96772310f1…
commit 19a46ba774b127ca0b6a96772310f149f2ff198a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Nov 9 18:56:31 2017 +0100
RIP: do not register proto_reg_handoff_rip() callback
Bug: 14197
Change-Id: Ib6a46e09622d85fabbf8465a9234af3a959b9663
Reviewed-on: https://code.wireshark.org/review/24327
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=775bbbcded718ffe6d429bb68e1170…
commit 775bbbcded718ffe6d429bb68e1170b2ef3f7778
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Nov 8 15:43:53 2017 +0000
Start using SPDX license identifiers.
A while back Graham pointed out the SPDX project (spdx.org), which is
working on standardizing license specifications:
https://www.wireshark.org/lists/wireshark-dev/201509/msg00119.html
Appendix V of the specification describes a short identifier
(SPDX-License-Identifier) that you can use in place of boilerplate in
your source files:
https://spdx.org/spdx-specification-21-web-version#h.twlc0ztnng3b
Start the conversion process with our top-level C and C++ files.
Change-Id: Iba1d835776714deb6285e2181e8ca17f95221878
Reviewed-on: https://code.wireshark.org/review/24302
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=50b91d0b4dd057608e521d0a6e82bf…
commit 50b91d0b4dd057608e521d0a6e82bf08eacff812
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Nov 9 18:39:55 2017 +0100
qt: add constructor to proto_tree (CID: 1420705).
Change-Id: I60a07ef6c8006ad8f4b6a5f25c2b4f2b1cb32766
Reviewed-on: https://code.wireshark.org/review/24326
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=784ad7297ecc603390797d4c4c5500…
commit 784ad7297ecc603390797d4c4c5500610a9093e8
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Nov 7 23:28:19 2017 +0100
UI: Use configured language for software update dialog
The software update dialog should use the language configured
with preferences.
Change-Id: If7a4b39d47ce9af505540555a653eb4a3aed8b94
Reviewed-on: https://code.wireshark.org/review/24325
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=645dff11e1c59c3e6c5893127d7442…
commit 645dff11e1c59c3e6c5893127d74427dd633778a
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Wed Nov 8 23:30:40 2017 -0500
dissector/mqtt: Replace proto_tree_add_uint64 by proto_tree_add_uint
Change-Id: I51d5dfdcbf13cca79ca354d0a63bf7dc328e5dc9
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24312
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=414a63f16099b37eac5f90f51bfbc6…
commit 414a63f16099b37eac5f90f51bfbc64589a48170
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Nov 9 13:30:20 2017 +0100
extcap: rename interface names.
The new names better reflect the utility.
Change-Id: I54105fc8be6735d3febbcc68837990758a5e52c3
Reviewed-on: https://code.wireshark.org/review/24320
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3bc743a9fdae56ee6be71feec31486…
commit 3bc743a9fdae56ee6be71feec314864bec91f28e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Nov 9 16:05:55 2017 +0000
autotools: Fix build for unknown Qt interface
Change-Id: Ibba717da1fa6cf9b87fc1972e83b0e637e54fd80
Reviewed-on: https://code.wireshark.org/review/24324
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=39967011836c1e23dff188ffaadb74…
commit 39967011836c1e23dff188ffaadb747d9dcda062
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 8 14:02:08 2017 +0000
Replace inet_addr() with our inet_pton() wrapper
Error checking omitted like in original code.
Change-Id: If8b4181d30ddf5717951aaf7ec61db25c0bc5322
Reviewed-on: https://code.wireshark.org/review/24309
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2ebc41050e43c508edbc8c0fa8cccb…
commit 2ebc41050e43c508edbc8c0fa8cccb9797c463cf
Author: Matej Tkac <matej.tkac.mt(a)gmail.com>
Date: Thu Nov 9 13:58:47 2017 +0100
[PFCP] Dissect Node ID and minor fixes
Fixed FQDN Field in Dissect Node ID according to 3GPP 29.244 Section 8.2.38
Added "Encoding error" message if the value in field is in dotted
form contrary to the doc.
Minor fix: Decreased F-TEID Flags spare bits (fix of
dc269fcd6f1ebc41d4e164f14dbb2a078bbb6265)
Change-Id: I7e9ba53a7deed7af1305f5c445bf4b2a9212e115
Reviewed-on: https://code.wireshark.org/review/24321
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e7e4dc5d98869f91af3e649324d726…
commit e7e4dc5d98869f91af3e649324d726217b2a8861
Author: bat <stefan.battmer(a)matrix-vision.de>
Date: Wed Nov 8 12:05:06 2017 +0100
gvcp:
- Added support for new registers:
- GVCP_IEEE_1588_EXTENDED_CAPABILITY (0x00000974)
- GVCP_IEEE_1588_SUPPORTED_PROFILES (0x00000978)
- GVCP_IEEE_1588_SELECTED_PROFILE (0x0000097C)
- Added support for missing/new error codes (0x8013 - 0x8017)
- Added dissector code for 'current link configuration' part of device mode
register
- Added support for proper event dissection with the length field in event commands is
used as recommended by the GEV 2.1 specification
- Added dissector code for new capability/configuration bits (iee1588 profile,
multi-part, large leader/trailer, ieee extended capabilities)
- BUGFIX: In multi-zone mode, zone directions where decoded as 'Receiver' and
'Transmitter' instead of 'Bottom Up' and 'Top-Down'
- BUGFIX: Commands that received at least one 'PENDING_ACK' before the final
acknowledge where always reported with '(Failed)' in the Wireshark main window
- Fixed some typos
gvsp:
- Added full multi-part dissection support
- Replaced some hard-coded numbers by numerical constants
- Added support for missing/new error codes (0x8013 - 0x8017)
- BUGFIX: In multi-zone mode, zone directions where decoded as 'Receiver' and
'Transmitter' instead of 'Bottom Up' and 'Top-Down'
- Combined 'AddressOffsetHigh/Low' for multi-zone/part into a single more
readable 64-bit value
Change-Id: I55862204ef71f69bc88c79fe2259f7cb8365699a
Reviewed-on: https://code.wireshark.org/review/24299
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=74936320a43c18a2ad538c8235e410…
commit 74936320a43c18a2ad538c8235e410f4912f6e4c
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Thu Nov 9 02:44:36 2017 -0800
802.11: Correctly handle Wi-Fi Alliance Multi-AP subtype decoding.
Introduce a dissector table and fix a bug so that it now works
by calling through a dissector table.
Change-Id: Ifa3f01b3f306101b3144604a51806eaccc436373
Reviewed-on: https://code.wireshark.org/review/24319
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc269fcd6f1ebc41d4e164f14dbb2a…
commit dc269fcd6f1ebc41d4e164f14dbb2a078bbb6265
Author: Matej Tkac <matej.tkac.mt(a)gmail.com>
Date: Thu Nov 9 11:34:19 2017 +0100
[PFCP] Improvements to Dissect F-TEID function
Added Bit 4 - CHID as described in 3GPP 29.244 Section 8.2.3.
Added "Encoding error" msg if documentation conditions aren't met.
Change-Id: Ia5e6d8bb2bf635fa695a2bfcba3877c2ecf52d87
Reviewed-on: https://code.wireshark.org/review/24318
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f2727b571a4d413857c027867735d2…
commit f2727b571a4d413857c027867735d23fa1f28c62
Author: Anders <anders.broman(a)ericsson.com>
Date: Tue Nov 7 16:12:22 2017 +0100
TWAMP dissector for RFC 5357
From https://github.com/demirten/twamp-dissector cleaned up a bit.
Change-Id: I3736e2ef09bd84ba30a63fee8bf07771f07bfe6c
Reviewed-on: https://code.wireshark.org/review/24283
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=43678551636f9845da4d52f48f8e82…
commit 43678551636f9845da4d52f48f8e82931f6b1c80
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Wed Nov 8 22:55:30 2017 -0500
dissector/mqtt: Rewrite the SUBSCRIBE payload size computation
- FIX: subtract the property length from the message length
- Replace the 'for' loop by a 'while' loop, now that the
arithmetic is done before.
TODO: It's a protocol error (v5.0)/violation (v3.1.1) not to
include the payload in the SUBSCRIBE control packet. It would
be nice to display a "malformed packet legend" in such that
case.
Change-Id: I99ef3862aa19b3a31ea03d1c194e54f489674115
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24313
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=afb252355bebee80673ea904c6b510…
commit afb252355bebee80673ea904c6b510aeaf10feb5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Nov 9 00:25:43 2017 -0500
ISDN: Convert circuit API to conversation API
Change-Id: I8752123a740c47f9328e0144624d4fbf4e200165
Reviewed-on: https://code.wireshark.org/review/24314
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=78665f5211fa9eeb3031dae2de8e55…
commit 78665f5211fa9eeb3031dae2de8e551bcb2369ea
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Nov 8 23:12:50 2017 -0500
ISO 14443: Convert circuit API to conversation API
Change-Id: Id007a3df5442cf4d21263acb17303b6d735aaa7d
Reviewed-on: https://code.wireshark.org/review/24311
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=82891e37e926040e89d4e761f93ec5…
commit 82891e37e926040e89d4e761f93ec5c6cc0ca52a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Nov 8 20:02:06 2017 -0500
DVB-CI: Convert circuit API to conversation API
Add the few necessary conversation APIs to make conversion possible.
Change-Id: I775f23005c48cacd2be342bdc704af4738f0789c
Reviewed-on: https://code.wireshark.org/review/24310
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c57ab694eca2e3d0bc6c7e8c01df8d…
commit c57ab694eca2e3d0bc6c7e8c01df8dce20c3631e
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 8 21:35:11 2017 +0100
Qt: Give focus to preference value in PreferenceEditorFrame
Select the preference value text and give focus when editing
a single preference.
Ping-Bug: 14191
Change-Id: I8d5f91c40118b9d74f1a65f5311aa92dfeb3e1b7
Reviewed-on: https://code.wireshark.org/review/24306
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=25c5d830c95872630ca87d21a3d9e3…
commit 25c5d830c95872630ca87d21a3d9e3a7e084e0db
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 8 21:10:42 2017 +0100
Qt: Give focus to Title in ColumnEditorFrame
Select the title text and give focus to the title when Edit Column.
Bug: 14191
Change-Id: I04fc5f6bcc830a15ef43fa2d06a1a729df52e370
Reviewed-on: https://code.wireshark.org/review/24305
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=35a1907fe6a5f7d630223ba38adabc…
commit 35a1907fe6a5f7d630223ba38adabc28eeeed971
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Sep 3 00:33:54 2017 +0100
iograph: Use default graph values if io_graphs UAT file doesn't pass validation
Change-Id: I70c8ca7b5b31d284a12220fc6ce2a764ea9fbe6b
Fixes: v2.5.0rc0-631-g5b3e3ee587 ("Use UAT model for I/O graph")
Reviewed-on: https://code.wireshark.org/review/23366
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1c25b71c7b4a6a993f5957c9adc1f5…
commit 1c25b71c7b4a6a993f5957c9adc1f598f51d4cd5
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 8 21:41:16 2017 +0100
mqtt: Rename mqtt_conv to mqtt_conv_t
This will clarify that it's a type. Also remove unneeded init values.
Change-Id: If61b32a264ff60a26e775dc99f1c06d0aa555a4d
Reviewed-on: https://code.wireshark.org/review/24307
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=428b354f0d4262b47855ccace409ca…
commit 428b354f0d4262b47855ccace409ca21d92faab5
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 8 22:02:52 2017 +0100
btmesh: Remove a debug g_warning
Change-Id: Ifc822efccfff5de32a54ca1f148a09ac3be4d0e3
Reviewed-on: https://code.wireshark.org/review/24308
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=8a6ea0e454dddcc1d9c14ad1e02a43…
commit 8a6ea0e454dddcc1d9c14ad1e02a43a53a4ef667
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Mon Oct 30 13:58:28 2017 +0100
Qt: Further cleanup ByteView
This further separates ByteView and the rest of the system.
Using FieldInformation and DataPrinter, this is the final cleanup
of the ByteViewTab
Change-Id: If41521167527cf5664c2564cdd0d45fea0f3f612
Reviewed-on: https://code.wireshark.org/review/22783
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=87431fef2836c8d77ea694844cd5df…
commit 87431fef2836c8d77ea694844cd5dff0e8b801f8
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 22:01:22 2017 -0500
dissector/mqtt: Add 'Subscription Options/Retain Handling' text descriptions
Change-Id: I6dea2e9c190095105dc1441197ad00c9b3a66f89
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24272
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=af285603ee82ae9644340c2f2871b2…
commit af285603ee82ae9644340c2f2871b293a8480c39
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 15:18:42 2017 -0500
dissector/mqtt: Dissect the User Property field
Change-Id: I0a0e484a814a11b785d20fda6eba5c251db98188
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24269
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=9f67e0a0d628209f6f979b6adf4a0f…
commit 9f67e0a0d628209f6f979b6adf4a0f58e39afb77
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 15:01:53 2017 -0500
dissector/mqtt: Dissect MQTT v5.0 String/Binary Properties
Add routines to dissect the following MQTT v5.0 String/Binary Data
Property fields:
- Content Type
- Response Topic
- Correlation Data
- Assigned Client Identifier
- Authentication Method
- Authentication Data
- Response Information
- Server Reference
- Reason String
Change-Id: Ia0ad0597d32bacc58228376bb738b7092f4a1ad6
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24268
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=d5759b72e60418df09a99b627f13ca…
commit d5759b72e60418df09a99b627f13cae6c4baa70a
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 21:34:06 2017 -0500
dissector/mqtt: Add the 'Subscription Options' dissector
Change-Id: I400430ca59c7492ae64dba6c4cca2485553988b9
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24271
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=36faf3203af3a5b77cbe19f232ee77…
commit 36faf3203af3a5b77cbe19f232ee77b7ddd2cd50
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Nov 8 13:01:26 2017 +0100
udpdump: don't call inet_addr() for every packet.
Change-Id: Id3d9229f5d61390f2f4127c8dfdf445935297e85
Reviewed-on: https://code.wireshark.org/review/24300
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8730b2037a6a999af28594607a4c27…
commit 8730b2037a6a999af28594607a4c27c3837f8f83
Author: Orgad Shaneh <orgads(a)gmail.com>
Date: Wed Nov 8 13:50:33 2017 +0200
tshark/tfshark: Replace global prefs with a boolean
This partially reverts dc0e6ccc9f9aaad7139c1edd3b723c4b939b15da in favor
of a cleaner solution.
Change-Id: Ie57329020b5a7d15eb7d99aad3103843a14f07a6
Reviewed-on: https://code.wireshark.org/review/24278
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2125275c7cc261e101731162ac1eeb…
commit 2125275c7cc261e101731162ac1eeba7626ce9e8
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Wed Nov 8 02:26:19 2017 -0800
smb2: Fix bug 6027 to correct SRT computations.
Fix a problem where SMB2 cancel and break messages
are included in SRT computations when it should not be.
Bug: 6027
Change-Id: I690fe6d9e14f26d85fe5c71830869780046d5d12
Reviewed-on: https://code.wireshark.org/review/24295
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3f189bed2f343893a4b9df626875a9…
commit 3f189bed2f343893a4b9df626875a930e03c91e1
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 14:54:02 2017 -0500
dissector/mqtt: Dissect the Subscription Identifier Property
Change-Id: Ia60b9c344fd572193374f57299b1829f17dfa24e
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24267
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=ca7bffbfc3341f6ff9b5dbd4efa15b…
commit ca7bffbfc3341f6ff9b5dbd4efa15bccefcfd744
Author: Anders <anders.broman(a)ericsson.com>
Date: Wed Nov 8 11:06:53 2017 +0100
[Diameter 3GPP] Sub dissect AVP Code: 1677 Group-PLMN-Id.
Change-Id: I69ac8210dfcb43f9fc15e49c75dfb917976f0770
Reviewed-on: https://code.wireshark.org/review/24294
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6565923eb30c9421992bea3a4cba28…
commit 6565923eb30c9421992bea3a4cba28d0eddb6c2d
Author: Matej Tkac <matej.tkac.mt(a)gmail.com>
Date: Wed Nov 8 13:25:11 2017 +0100
[PFCP] Fixed apply action flags bits referenced in register info.
In accordance with 3GPP 29.244 8.2.26 Apply Action.
Change-Id: Icef9bc9807efc255ece8fbde5e4c244d5f1fc525
Reviewed-on: https://code.wireshark.org/review/24301
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1a3bd52e9107d37c004bc094b633d2…
commit 1a3bd52e9107d37c004bc094b633d2ce4455d150
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Nov 8 11:34:09 2017 +0100
btmesh: Fix building without gcrypt
Change-Id: If77b36d764c07acd87a553134cebff246b8368fe
Reviewed-on: https://code.wireshark.org/review/24296
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=465f75b5292e4c57762200ca1b87cd…
commit 465f75b5292e4c57762200ca1b87cdb225dd6484
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Nov 8 11:46:59 2017 +0100
MQTT: add a missing break
Change-Id: I0a17fd44607a5a7452a7c2789140cce7cdcbd17b
Reviewed-on: https://code.wireshark.org/review/24298
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=4a1f8f5f27e165aeba0b1441f7f185…
commit 4a1f8f5f27e165aeba0b1441f7f1858a9c60fff7
Author: Roland Knall <rknall(a)gmail.com>
Date: Wed Nov 8 08:37:48 2017 +0000
Qt: ReleaseNotes and reformatting of Drag n' Drop
Added ReleaseNotes and changed the representation
Change-Id: Ica927368ef6c5d912a29e06733ad0a95e1886077
Reviewed-on: https://code.wireshark.org/review/24291
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=bf8d8ebfa43366bff4edd9f16eb1af…
commit bf8d8ebfa43366bff4edd9f16eb1af078ce36985
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Tue Nov 7 16:53:45 2017 -0500
dissector/mqtt: DISCONNECT and AUTH may not include the Property field
From the spec:
3.14.2.2.1 Property Length: The length of Properties in the DISCONNECT
packet Variable Header encoded as a Variable Byte Integer. If the
Remaining Length is less than 2, a value of 0 is used
In this commit we also assume that AUTH may not include the Property
field, given that DISCONNECT and AUTH share the same structure.
Change-Id: I5f55151df6b2066d924b2c16fb08a63b0903ef46
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24288
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=76eab87c7de02a6586c3fedf913db8…
commit 76eab87c7de02a6586c3fedf913db820f4fc3cf2
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 14:40:35 2017 -0500
dissector/mqtt: Dissect MQTT v5.0 Four Byte Properties
Add routines to dissect the following MQTT v5.0 Four Byte
Property fields:
- Publication Expiry Interval
- Session Expiry Interval
- Will Delay Interval
- Maximum Packet Size
Change-Id: Ie902f679c5424f85f98c9ed113951ed0ee6411be
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24266
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=9e7cfd32dde5f222d59e78b3acf1d3…
commit 9e7cfd32dde5f222d59e78b3acf1d3128d63a91e
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Nov 6 13:45:37 2017 -0500
dissector/mqtt: Dissect MQTT v5.0 Two Byte Properties
Add routines to dissect the following MQTT v5.0 Two Byte
Property fields:
- Server Keep Alive
- Receive Maximum
- Topic Alias Maximum
- Topic Alias
Change-Id: I90b43cd315f31a34b10bf6065ea51549307e95f3
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24265
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=458f97b1ebced604ec9acf5690f3c9…
commit 458f97b1ebced604ec9acf5690f3c9438169b5b0
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Sat Nov 4 10:27:07 2017 -0400
dissector/mqtt: Dissect MQTT v5.0 Byte Properties
Add routines to dissect the following MQTT v5.0 Byte
Property fields:
- Payload Format Indicator
- Request Problem Information
- Request Response Information
- Maximum QoS
- Retain Available
- Wildcard Subscription Available
- Subscription Identifier Available
- Shared Subscription Available
Change-Id: I28b95174ce811a92d8f22bf51c331169b5e4b925
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24264
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=96735846beb4d067eac220c48f5d8c…
commit 96735846beb4d067eac220c48f5d8c18f178e4c1
Author: Roland Knall <rknall(a)gmail.com>
Date: Tue Nov 7 15:51:43 2017 +0000
Qt: Clean Drag-n-Drop Mimetype for toolbar
Cleans up the mime type to use a class instead of a mimetype
string
Change-Id: I122ba9b39de86d8e263f2204715911a2b0ac75cd
Reviewed-on: https://code.wireshark.org/review/24286
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4d6454e18027a7265138e16ef95b52…
commit 4d6454e18027a7265138e16ef95b52000825aa47
Author: Roland Knall <rknall(a)gmail.com>
Date: Tue Nov 7 15:51:43 2017 +0000
Qt: Drag n Drop Filter expression from Packet Tree
Drag and Drop a field from the packet tree to the displayfilteredit
or the toolbar and drop it there to either apply the filter (or prepare
it by holding down the Shift key) or create a new toolbar button
Change-Id: I42645a02223c71315e91e0d58eb1b54ebab4fd58
Reviewed-on: https://code.wireshark.org/review/24280
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=371b5c526b439824ffd0eb2b11f766…
commit 371b5c526b439824ffd0eb2b11f76689436dc6c3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Nov 7 17:44:55 2017 -0500
Have circuit functionality more closely mirror conversation functionality
This will allow for a smoother transition for refactoring because circuit
functionality can now be represented as a strict subset of conversation
functionality.
Change-Id: I323d7facad707c81b8e35b33143fa1102d6b5976
Reviewed-on: https://code.wireshark.org/review/24290
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f8a1878202f46dda8194fb56af7619…
commit f8a1878202f46dda8194fb56af7619c887cec806
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Nov 7 18:04:45 2017 +0100
proto.c: fix field display test in hfinfo_number_value_format_display64()
While we are at it, let's use the FIELD_DISPLAY() macro everywhere.
Bug: 14169
Change-Id: I685cb7eb4b9c52f836762c92baeb636570a6d12f
Reviewed-on: https://code.wireshark.org/review/24285
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0e85c0ad1e61e8bf9bebedbdd643c2…
commit 0e85c0ad1e61e8bf9bebedbdd643c237391d5eb5
Author: Jeff Widman <jeff(a)jeffwidman.com>
Date: Tue Nov 7 16:41:56 2017 -0800
Fix typo: Heatbeat --> Heartbeat
Change-Id: I864850b29f9c816a4d1592cd5bba2b9d0159b139
Reviewed-on: https://code.wireshark.org/review/24289
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b6d6eb90970993a6342834317cb70e…
commit b6d6eb90970993a6342834317cb70e2519cbeff1
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Tue Nov 7 16:15:01 2017 +0000
CMake: Detection of HTMHelp
CMake erroneously reports that HTMLHelp wasn't found
The override of FindHTMLHelp.cmake now uses
FIND_PACKAGE_HANDLE_STANDARD_ARGS to do this correctly.
Change-Id: I1bd24964365dea00af213092872e24cbfb5ee07d
Reviewed-on: https://code.wireshark.org/review/24281
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0c1ea1cee1a3b5f3ad9e176591bbad…
commit 0c1ea1cee1a3b5f3ad9e176591bbad58b2b01ad0
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Nov 7 15:16:23 2017 +0100
fcp: create conversation if it doesn't exist.
Change-Id: I0bcc17900a9379d9f9d1828b834c2116e1199bf6
Ping-Bug: 14168
Reviewed-on: https://code.wireshark.org/review/24277
Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=62e81c5846afab51757eb48826ac02…
commit 62e81c5846afab51757eb48826ac02522e9864f3
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Tue Nov 7 13:35:34 2017 +0000
Open Windows CHM Help from Help menu.
Renable the link between the Menu help command and the locally
installed CHM help file.
This allows the user to acces the appropriate help built for their
specific version rather than the latest version on the Wireshark
web site.
Change-Id: I7bb3d418ba405d6c7614ab6d52f7b0eda843d0de
Reviewed-on: https://code.wireshark.org/review/24276
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc0e6ccc9f9aaad7139c1edd3b723c…
commit dc0e6ccc9f9aaad7139c1edd3b723c4b939b15da
Author: Orgad Shaneh <orgads(a)gmail.com>
Date: Mon Oct 30 15:42:43 2017 +0200
tshark/tfshark: Do not apply console.log.level before it is set
The user has no way to apply this setting while loading dissectors in order
to enable g_debug messages during init for example.
Change the behavior to be as documented in the comment.
Change-Id: I9317f12b207d4621508212b02ca1ebd46b55aadc
Reviewed-on: https://code.wireshark.org/review/24184
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5dd6a9cef95daf6ccee5007d766f10…
commit 5dd6a9cef95daf6ccee5007d766f10864f7dcc34
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Tue Nov 7 12:24:20 2017 +0100
isobus-vt: make sure to close the id file (CID-1413873)
Part of dissector init is reading the object ID file.
This file should be closed afterwards to not leak the resource.
Change-Id: Icf5e229315a2c1c61a169e576ec51d38a1c350a1
Reviewed-on: https://code.wireshark.org/review/24275
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=99a53b2b95b7a297134007f5a6ebc6…
commit 99a53b2b95b7a297134007f5a6ebc6114db32d15
Author: Simon Barber <simon.barber(a)meraki.net>
Date: Wed Sep 13 16:06:56 2017 -0700
packet-ieee80211: all frames have address 1 = RA
Change-Id: Ie4785376eae278713e998e23c96d8435e4dc07f2
Reviewed-on: https://code.wireshark.org/review/23526
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3593f0953fc0cffbe1999fc7f4b036…
commit 3593f0953fc0cffbe1999fc7f4b03656cc36e761
Author: Martin Kacer <kacer.martin(a)gmail.com>
Date: Tue Nov 7 07:33:15 2017 +0100
Fix Elasticsearch hex dump
Removing duplicated double quote.
Bug: 12958
Change-Id: I17f443efd8572e1d17ced5b8ec8f743253be859b
Reviewed-on: https://code.wireshark.org/review/24273
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1344e707b7e8aabc3b12ffd00e5595…
commit 1344e707b7e8aabc3b12ffd00e5595310e5508cb
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Tue Nov 7 01:25:32 2017 -0500
dissector/mqtt: Disconnect and Auth variable header
Apply 'Disconnect' (3.14.2) and 'Auth' (3.15.2-1) notes to simplify
and fix the variable header :).
Change-Id: I169a69a0da5b2d5ee338c0f45af978217986f37a
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24274
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d84d43372c3aee0ae5a1dd30edff82…
commit d84d43372c3aee0ae5a1dd30edff8243acf41f14
Author: Paul Offord <paul.offord(a)advance7.com>
Date: Sun Nov 5 10:39:54 2017 +0000
Improvement to plugin_if_get_ws_info(...) functionality
A plugin can register an initialisation function to be called each time
Wireshark opens a new capture file. If plugin_if_get_ws_info(...) is
called from within the initialisation function it does not return the
name of the file being opened. This is because
plugin_if_get_ws_info(...), through calls to a number of other
functions, gets the file name details from a capture_file structure. At
the time of the call to the plugins initialisation function, the
capture_file structure in question has not yet been created.
This change ensures that if plugin_if_get_ws_info(...) is called from a
plugin's initialisation function, the name of the file to be open is
correctly returned. The change also fixes a bug where
plugin_if_ws_get(...) returns an incorrect file state if called from a
plugin initialisation function.
Bug: 14165
Change-Id: I28c85e480db96852e11bbaa14fb1f434b457ed52
Reviewed-on: https://code.wireshark.org/review/24251
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fa2649ac61755b462ec49ea0a2bbfb…
commit fa2649ac61755b462ec49ea0a2bbfb8569dd0bad
Author: Simon Barber <simon.barber(a)meraki.net>
Date: Wed Nov 1 11:51:37 2017 -0700
wireless_timeline: fix blank display
Sometimes when a file opens the timeline does not display, also sometimes when
zooming it disappears.
Change-Id: I141eaef5f332a1de9af133abbeccede7c1cf5502
Reviewed-on: https://code.wireshark.org/review/24209
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=19b2ddcce1cdfc947220acfceefd0e…
commit 19b2ddcce1cdfc947220acfceefd0e3b98401909
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Sat Nov 4 08:35:10 2017 -0400
dissector/mqtt: Update license notice
Change-Id: Iefd0bead04cc54c55d39b682b7879620c022afb1
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24262
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e2179a2ac55829c59cb49a81934c1c…
commit e2179a2ac55829c59cb49a81934c1ccfa65110e7
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Sat Nov 4 08:25:45 2017 -0400
dissector/mqtt: Add partial support for MQTT v5.0
This patch adds partial support for the MQTT v5.0 protocol.
The relevant changes are:
- A new MQTT control packet: AUTH (15)
- The Variable Header is extended with a new section: 'Properties'
Currently, the 'Properties' section is not dissected although
its length is parsed.
Change-Id: I059b91304e953d69e4781b170e61057cb38dde19
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/24261
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea97b3364cba57cd041dde1f6348d0…
commit ea97b3364cba57cd041dde1f6348d029ae3851bf
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Nov 6 20:30:43 2017 -0500
Add AMR WB pino to make Decode As happy.
Change-Id: I7150db30ce52ab4398ed977197f200070fca1d8c
Reviewed-on: https://code.wireshark.org/review/24270
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1e707e33fa88f720e09a5d0cc0ebee…
commit 1e707e33fa88f720e09a5d0cc0ebee27d86582d8
Author: Anders <anders.broman(a)ericsson.com>
Date: Mon Oct 30 14:03:25 2017 +0100
[BT Mesh] Add Bluetooth Mesh dissector.
Bug: 14161
Change-Id: Ia76d283c6c8e00526948a0ee9cda9e35b4ca0e2a
Reviewed-on: https://code.wireshark.org/review/24216
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4405c5d769d254ef6b28c0e3df5304…
commit 4405c5d769d254ef6b28c0e3df53041ddfe1499c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Nov 6 13:26:38 2017 -0800
Fix white space.
Change-Id: I8a50391dcfb113c251f24f64486828d5d8a1d0c0
Reviewed-on: https://code.wireshark.org/review/24260
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9705f653daa134cbf63098ff44d5ce…
commit 9705f653daa134cbf63098ff44d5cebb021bffb4
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Nov 6 16:26:34 2017 +0100
print: add fi check.
Change-Id: Ica20efe7122476af55b70c72d8af40244c25f902
Reviewed-on: https://code.wireshark.org/review/24259
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=147e491025ff8ca590e28fb066a833…
commit 147e491025ff8ca590e28fb066a833fddda87291
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Nov 5 21:34:58 2017 -0500
Convert PT_EXCHG into using conversation endpoints
Change-Id: Id5857a58513c38dd0ab5b30b61113bcc14e1ecee
Reviewed-on: https://code.wireshark.org/review/24258
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0dfff8c4b4e4ea26b3a22ef6800213…
commit 0dfff8c4b4e4ea26b3a22ef6800213ba8a9f4f03
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Sun Nov 5 18:27:03 2017 -0800
IEEE1905: Add a break to fix a malformed packet issue and dissect Multi-AP
Extension types in EAPWPS.
Change-Id: Ib7dca0f83897839072eaaeb9c95f406f6ad5c8e6
Reviewed-on: https://code.wireshark.org/review/24256
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8b79187b6613b7b984ff85de85a225…
commit 8b79187b6613b7b984ff85de85a225f8a1f33a5a
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Mon Nov 6 02:04:06 2017 -0800
ieee802.11: Add support for the Measurement Pilot Interval IE and
fix dissection of the actual measurement pilot interval. It is an
8-bit field according to IEEE802.11 2016.
Change-Id: I44c9a732ae3074e865f7ad63b554f7a031542e5a
Reviewed-on: https://code.wireshark.org/review/24257
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=156a0b62eb9dee2423b6d7d7f5aed1…
commit 156a0b62eb9dee2423b6d7d7f5aed1a5b6cb33ae
Author: Martin Kacer <kacer.martin(a)gmail.com>
Date: Sat Nov 4 08:49:54 2017 +0100
Tools: json2pcap script update
Updated script to support duplicated json fields
and --no-duplicate-keys tshark flag.
Bug: 12958
Change-Id: Id20885baacbfd26124cb82716df6829225be6de8
Reviewed-on: https://code.wireshark.org/review/24236
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ba6dd97081c7490db0d6e98c9e8cd3…
commit ba6dd97081c7490db0d6e98c9e8cd3b819b9dd6f
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 5 13:05:20 2017 +0000
Remove epan win32 x86 assembly
Not used. Remove also weird pre-hash hash optimization in proto.c.
Change-Id: Ibebc12dbe90ac1d05fb1ba601d32fe98797fbd56
Reviewed-on: https://code.wireshark.org/review/24254
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=93bda0b18d68d07f7601811687e448…
commit 93bda0b18d68d07f7601811687e44811d14e97f4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Nov 4 19:28:33 2017 -0400
Add conversation/endpoint statistics for Linux SLL
Bug: 14048
Change-Id: I320380c492b83f0e45bfbf20505deb3c5f11ae67
Reviewed-on: https://code.wireshark.org/review/24243
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=23afd28daf7a8ccbdba395e83fed79…
commit 23afd28daf7a8ccbdba395e83fed79c0ca352f50
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Nov 2 20:55:23 2017 -0400
Convert TIPC to use endpoint conversations
Change-Id: Iab03ebbfc982bf7182851f63c17fa59bc71d7709
Reviewed-on: https://code.wireshark.org/review/24219
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=08bf89f4877b65a6a31c33023d8022…
commit 08bf89f4877b65a6a31c33023d8022bf9d94d1b6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Nov 5 10:59:39 2017 +0100
zbee zcl se: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I169f7815eecfcdfbbdca78d4ab038fb032c3b691
Reviewed-on: https://code.wireshark.org/review/24250
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=10cc91f83db602878e9a811a20dde4…
commit 10cc91f83db602878e9a811a20dde4ca66fe4140
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sat Nov 4 11:48:51 2017 +0200
RLC: Replaced g_malloc with tvb_memdup
Also updated some comments and a string
Change-Id: Ib8c079a34f21614047262900b0a4c1547d5df0b3
Reviewed-on: https://code.wireshark.org/review/24237
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2ef00337c4c95e15f8f75bdd0c7902…
commit 2ef00337c4c95e15f8f75bdd0c7902271c7c8336
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 5 14:15:04 2017 +0000
CMake: Remove "compress" remnant
Change-Id: I6feeb2f5873562a09159cf55446652628aa97e78
Reviewed-on: https://code.wireshark.org/review/24255
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=dc18da434b04f8cf01f940bd4f13a3…
commit dc18da434b04f8cf01f940bd4f13a37e19a96e8b
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Fri Oct 27 18:35:19 2017 +0200
packet-infiniband: Proper parsing of ClassPortInfo attribute
ClassPortInfo is a common attribute for general service (GS)
management classes.
SA ClassPortInfo is currently parsed as PortInfo although
these are different attributes.
Also, added support for PerfMgt ClassPortInfo.
Bug: 14164
Change-Id: I652ba8ed2e0222db41ce2eb2e01a9c4b446e5bd4
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24235
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f891603a47cb99fd842fb06a6b0712…
commit f891603a47cb99fd842fb06a6b0712fa92041fc8
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 5 12:44:40 2017 +0000
autotools: Eliminate spurious libwireshark_asmopt library
Change-Id: I96e03f136efd90892fbcf812ea37e36a2bed5ab9
Reviewed-on: https://code.wireshark.org/review/24253
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=ff3bd8c7ce5197ec533c8115a96655…
commit ff3bd8c7ce5197ec533c8115a96655a4829d9c82
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Nov 5 10:08:12 2017 +0100
conversation_table(.h): fix parameter 'ptype/port_type_val' not found in the
function declaration [-Wdocumentation]
Oups not good fix last time...
Change-Id: I55f565a8d4dde83304a8437be3dc35c2fad1fb07
Reviewed-on: https://code.wireshark.org/review/24249
Tested-by: Petri Dish Buildbot
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=72c2e53981a204d746737d8c01c4ad…
commit 72c2e53981a204d746737d8c01c4ad3738cd4880
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Nov 5 12:05:43 2017 +0000
autotools: Use pkg-config to configure Libsmi
Change-Id: Icecea743739aa7e1a65753f623f311514260d373
Reviewed-on: https://code.wireshark.org/review/24252
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=62f705e8445336e73a81e1df10987e…
commit 62f705e8445336e73a81e1df10987e24529bf418
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 1 09:23:22 2017 +0000
autotools: Try to be clearer about --with-ssl and remove cruft
Change-Id: Iaf8c8a83ead1d6671bb9cadb6add56481ed98aaa
Reviewed-on: https://code.wireshark.org/review/24242
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=711f69c807a5566060bea94ac7042b…
commit 711f69c807a5566060bea94ac7042b43bf3cbeab
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Nov 4 16:59:17 2017 +0000
CMake: Don't offer unsupported options
Change-Id: I45872dad3c7133453790fb284121fb4eaf9fac67
Reviewed-on: https://code.wireshark.org/review/24240
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=68ead1d025bd63079ea5eebbb5d767…
commit 68ead1d025bd63079ea5eebbb5d767f8d0f98459
Author: Roland Knall <rknall(a)gmail.com>
Date: Sat Nov 4 16:11:08 2017 +0100
Qt: Fix drag-n-drop in toolbar
Fixing two crashes in the toolbar, first one only appeared on mac,
the second one happens every time the toolbar is removed or updated
Change-Id: Ic3075a5af1b4a566e09bbce9712c968c053cc727
Reviewed-on: https://code.wireshark.org/review/24244
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=aed3e66672083940f94e0b33f5b2e9…
commit aed3e66672083940f94e0b33f5b2e9d25776a4d4
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Nov 5 08:16:09 2017 +0000
[Automatic update for 2017-11-05]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I4abb96429b1ad8c6d78a129efd453f3019669f4f
Reviewed-on: https://code.wireshark.org/review/24245
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=7e6f6562fa1cef1ad67c0839477767…
commit 7e6f6562fa1cef1ad67c0839477767ba5c0e43ce
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sat Nov 4 19:13:07 2017 +0100
TCP: cleanup Riverbed option
Remove duplicate length field to adjust to the other options.
tcp.options.rvbd.probe.len has already reported by tcp.option_len
Add missing space between "Transparency" and IP address.
Change-Id: I8b4260b34d760b73ee529a687418c4b6adcfaa0e
Reviewed-on: https://code.wireshark.org/review/24239
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fc318e6a1f2da11e3429e58cd9d289…
commit fc318e6a1f2da11e3429e58cd9d2893899f547af
Author: Eliot Lear <lear(a)cisco.com>
Date: Thu Nov 2 17:10:13 2017 +0100
Better instructions on building with Qt on macOS.
Change-Id: I23bb91970dd7e3f59166310114cca84846d7164d
Reviewed-on: https://code.wireshark.org/review/24165
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1741b6b23c39d1f38956d005d70cbe…
commit 1741b6b23c39d1f38956d005d70cbef2ee5e5f79
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat May 6 08:15:24 2017 -0400
oss-fuzzshark: force direct malloc
Set two environment variables (needs to be done before epan_init and
before the first g_slice_alloc call) to force direct memory allocation
without another layer that could hide bugs.
Change-Id: I0d72092c239e2e7f42b0b7849c01471407e785e2
Reviewed-on: https://code.wireshark.org/review/21195
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d11f5dff8ef9e615a8d5d01ee8b882…
commit d11f5dff8ef9e615a8d5d01ee8b88241fea42f09
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Mon Oct 30 19:57:14 2017 -0400
TCP: Fix Riverbed probe option tvb handling
With commit f30b1e3b3bc4cec85296c280cdae88d3d17fae04 TCP options are handled
in an own dissector table. Therefore we can't read ahead or behind to get
the SYN flag or the CFE flag.
Bug: 14150
Change-Id: Ibbf1836104d32216ddfa2d4e07dccbcf948bb26c
Reviewed-on: https://code.wireshark.org/review/24181
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Uli Heilmeier <openid(a)heilmeier.eu>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=802517e91793fc69f834b40109f36b…
commit 802517e91793fc69f834b40109f36b64c3fb4b7e
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 15:33:51 2017 +0200
packet-infiniband: SM class does not support ClassPortInfo or InformInfo attributes
Change-Id: I1fbe7a93e8a208a1a4abaf0b64e674536b642733
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24229
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=834c65a1f885e630a4ac5b2a585b41…
commit 834c65a1f885e630a4ac5b2a585b41f5715e09c1
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Thu Oct 26 21:13:38 2017 +0200
packet-infiniband: Make unknown GS class attributes show up in wireshark Info column
The following GS classes are now displayed there:
BM
DEV_MGT
SNMP
VENDOR
APP
RESERVED
Change-Id: I94822784a7027afa1d5e99ca20467721a98cfe0a
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24234
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0cd40887d4963cf20b1118eba40856…
commit 0cd40887d4963cf20b1118eba4085670d5cf1b01
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Thu Oct 26 19:54:59 2017 +0200
packet-infiniband: Better variable naming
Rather than use PERF_header_item for all classes,
use acronym for class appended with _header_item
Change-Id: I52ac46000c20b7f51c87c8dc4a8dfc85c20f31f3
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24233
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b4856927eb2593795f114df8606f16…
commit b4856927eb2593795f114df8606f16136fb5048c
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Thu Oct 26 19:24:47 2017 +0200
packet-infiniband: DETH Queue Key should be hex rather than decimal
as it is in other places where there is Q_Key
Was:
DETH - Datagram Extended Transport Header
Queue Key: 2147549184
Now:
DETH - Datagram Extended Transport Header
Queue Key: 0x0000000080010000
Change-Id: I64d4b485e2a511c30b0e4a2849f529438591a122
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24232
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=002133c606b3ae9b4253614f69250d…
commit 002133c606b3ae9b4253614f69250dbf306f358b
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Thu Oct 26 19:05:41 2017 +0200
packet-infiniband: Make unknown PerfMgt attributes show up as PERF in wireshark Info
column
Change-Id: I9f6a60adaa0744d13d6c000d1a4e20f3b526355b
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24231
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b70429427f8264ca726d19910fef23…
commit b70429427f8264ca726d19910fef23b0ae77f347
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 15:41:30 2017 +0200
packet-infiniband: Fix commentary typo (for consistency)
Change GuidInforecord -> GuidInfoRecord
Also, change VLArbitrationTableRecord comment to be consistent
Change-Id: Ia7cc844779a8751bd7675354b71239922327d0e8
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24230
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3c2f2179403f3f0c983f251b45f0cd…
commit 3c2f2179403f3f0c983f251b45f0cd5fe1be9a13
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Thu Oct 26 08:23:27 2017 +0200
packet-infiniband: Add missing SA methods into mad_method_str
so they are not indicated as Method: Unknown under
MAD Header - Common Management Datagram
Change-Id: I8e8fe918eea86e7095967d0b82772a813eafe2a5
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24228
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9b82c6b21e02fb0a2af37ed5f0847d…
commit 9b82c6b21e02fb0a2af37ed5f0847de59b63f9d1
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 17:30:56 2017 +0200
packet-infiniband: Fixed some PortInfo:CapabilityMask bit names
to be consistent with IBA volume 1 spec
IsOptionalIPDSupported
IsCommunicationManagementSupported
Change-Id: I55b29b7f291f49a9d0c3e104bda4d7d7aa78b42b
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24227
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c04c92fbf9986931d437371bdf2522…
commit c04c92fbf9986931d437371bdf2522f191d496ce
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 14:27:43 2017 +0200
packet-infiniband: Add first and last to RMPP_Flags
RMPP flags 7 indicates that packet is both first and last
packet in transfer
Change-Id: Idf0e8783372296a7c276c8c0c80e4905afbe6c9a
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24226
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b3f4ca6077993450a2373e0ebb2c72…
commit b3f4ca6077993450a2373e0ebb2c72e0f73d487b
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 15:26:42 2017 +0200
packet-infiniband: Fix some SM class attribute IDs
LinkSpeedWidthPairsTable is 0x001C
SMInfo is 0x0020
VendorDiag is 0x0030
LedInfo is 0x0031
Change-Id: I93197590930a97c8538ef69d08213b1076a9f66a
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24225
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=92dc84cff9dcbf1bcd6b9ebb3827f0…
commit 92dc84cff9dcbf1bcd6b9ebb3827f0f7a9c1d1a5
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 14:12:20 2017 +0200
packet-infiniband: Fix SA MCMemberRecord attribute name
rather than MCMembersRecord
Change-Id: I96bf3ac45255295cf85b9faf0547df4df26f11c3
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24222
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8894195a47e78c8f85744cc9f52b98…
commit 8894195a47e78c8f85744cc9f52b98a03e1da77b
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Tue Oct 24 14:32:39 2017 +0200
packet-infiniband: Use SA rather than SMA as Subnet Administration header
SMA is acronym for Subnet Management Agent not Subnet Administration
so change this from SMA to SA
Change-Id: I1a293fff5de4796fe337daa133943bfa059cc9ff
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24224
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b9c5601dd8f16a45b120c1f64994d1…
commit b9c5601dd8f16a45b120c1f64994d1335a282b09
Author: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Date: Thu Oct 26 01:01:26 2017 +0200
packet-infiniband: Removed erroneous MadHeader comments
as it is not parameter in these APIs
Also, fixed commentary typo
Change-Id: I1ce53b9aae9837688e756b2e665f3b1df74b572c
Signed-off-by: Hal Rosenstock <hal.rosenstock(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/24223
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=71389177e44d6335c891f6f7733e3d…
commit 71389177e44d6335c891f6f7733e3df799dec8a3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 28 14:17:02 2017 -0400
Add Decode As support for RTP payload
Change-Id: I568c0e6980d7649f9cd82ac46420e7db70722fc6
Reviewed-on: https://code.wireshark.org/review/24150
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cd3948f99e02cb48af37785176cd92…
commit cd3948f99e02cb48af37785176cd9261ee01c2cd
Author: Thomas Dreibholz <dreibh(a)iem.uni-due.de>
Date: Fri Nov 3 21:11:25 2017 -0400
Add backslashes to definition of WSUG_TOOLS_HELP_FILES in docbook/Makefile.am
Bug: 14152
Change-Id: If1d89afd5dbf62adae4cd84e3fc44bd37a8a2176
Reviewed-on: https://code.wireshark.org/review/24221
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6f382fed37fec0a8ee40bd06da861f…
commit 6f382fed37fec0a8ee40bd06da861ff3e94a33ae
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Fri Nov 3 13:39:09 2017 +0100
DOCSIS: RNGRSP: formatting of equalization coefficients
Change-Id: I6745bee84b096a7008d258a39d99370b1fea29a0
Reviewed-on: https://code.wireshark.org/review/24217
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b227943e66c7839dca713be60f6cda…
commit b227943e66c7839dca713be60f6cdaf70ba9413e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Nov 3 17:42:56 2017 +0100
Exported PDU: apply EXP_PDU_TAG_COL_PROT_TEXT whatever the next_prot_type tag
The include file suggests that it will always fill the protocol column if
present. Let's make that happen.
Change-Id: I265e2f4d1c2dcd7cf2ff121499694cde14a595f3
Reviewed-on: https://code.wireshark.org/review/24220
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e00162301b243aff8d0e2760367243…
commit e00162301b243aff8d0e2760367243edf222a150
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Nov 1 07:45:42 2017 -0400
Ensure endpoint members of packet_info structure are initialized in packet.c
Change-Id: I4c7a4f9888c8bdc87ded88fa997aa2aad9530fd7
Reviewed-on: https://code.wireshark.org/review/24218
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f6edbcd6439666319a875c5b4d4fd8…
commit f6edbcd6439666319a875c5b4d4fd80b7834c57c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Nov 2 12:42:37 2017 +0100
mqtt: Simplify message decode matching
Change-Id: I93da46808de8a978d49ad0aa3f78c4a1790e7952
Reviewed-on: https://code.wireshark.org/review/24210
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=be625b9be781e469456d01053336b1…
commit be625b9be781e469456d01053336b18cfba63ede
Author: Christoph Wurm <wurm(a)elastic.co>
Date: Thu Nov 2 19:14:28 2017 +0000
Fix Elasticsearch hex dump
Change-Id: I5b2006a74e95759afce518aaadfe47c54978476a
Reviewed-on: https://code.wireshark.org/review/24215
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5d9c8ecbc1fe53aa17eba0b29d7f5c…
commit 5d9c8ecbc1fe53aa17eba0b29d7f5c397f86c514
Author: Eliot Lear <lear(a)cisco.com>
Date: Thu Nov 2 17:11:25 2017 +0100
Remove eroneous DoD association by deleting IANA entry.
Change-Id: Ib623391235c1cbbfadd540d2ae24fdc36c2b0b96
Reviewed-on: https://code.wireshark.org/review/24214
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=78ee8c419fe7ef07a7ff90b5b763a9…
commit 78ee8c419fe7ef07a7ff90b5b763a96d406c215c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Nov 2 15:21:52 2017 +0100
Do not register proto_reg_handoff_XXX callback when not required
None of those protocols need to be notified of a preference change and
their proto_reg_handoff_XXX functions do not differentiate the initial
call from susequent ones, leading to an assert
Bug: 14157
Change-Id: Iac4d88ebef7688bced8daae857eb5c836a6babd6
Reviewed-on: https://code.wireshark.org/review/24211
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dd1f75a53ed113454fb7c6d1cfb3a9…
commit dd1f75a53ed113454fb7c6d1cfb3a9463da0ffb4
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Tue Oct 31 16:50:40 2017 +0300
ZigBee ZCL Sub-Ghz Cluster dissector
Added Sub-Ghz cluster dissector.
Change-Id: I6d189400298def693969004b6fc2942fd8b70ba0
Reviewed-on: https://code.wireshark.org/review/24199
Reviewed-by: Martin Boye Petersen <mbpflonidan(a)gmail.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c571e692085b4c119d9ebf5c526bd3…
commit c571e692085b4c119d9ebf5c526bd3be77135361
Author: Anders <anders.broman(a)ericsson.com>
Date: Wed Nov 1 10:40:50 2017 +0100
[GTPv2] Add dissection of 8.127 Header Compression Configuration.
Change-Id: Iace27ebf536cad73d9aaf4abceb6d235f34d68f6
Reviewed-on: https://code.wireshark.org/review/24208
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dd4f8d08b2e1db8f12cb3deabf2b81…
commit dd4f8d08b2e1db8f12cb3deabf2b81ab5d86c4fb
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Tue Oct 31 16:16:44 2017 +0300
ZigBee ZCL Keep-Alive Cluster Dissector
Added Keep-Alive Cluster dissector.
Change-Id: I5a2c24a4f13171b26efc860470b4d9c42f54ef89
Reviewed-on: https://code.wireshark.org/review/24198
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=062ca10cff8203330dc8c56e99a52e…
commit 062ca10cff8203330dc8c56e99a52e0b8e4155ee
Author: Ivan Ermakov <iermakov(a)yahoo.com>
Date: Tue Oct 31 17:06:52 2017 +0300
ZigBee ZCL MDU Pariring Cluster dissector
Added dissectors for commands and payloads of MDU Pairing cluster.
Change-Id: I842ddf50f91d0ecc46605325048971d1eeba6df6
Reviewed-on: https://code.wireshark.org/review/24200
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=93c358cb5d2a6620d997862ef39e10…
commit 93c358cb5d2a6620d997862ef39e1082e47e8329
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Mon Oct 30 21:28:44 2017 +0000
FTP: links between setup and command frames
Change-Id: I8a231f8616952ed119b85126d6d25af7512e6cd8
Reviewed-on: https://code.wireshark.org/review/24194
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66b441f3d63e21949530d672bf1406…
commit 66b441f3d63e21949530d672bf1406dea94ed254
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Oct 30 15:57:34 2017 -0400
Add ability to create endpoints through conversations
Add endpoint information to the packet_info structure for dissectors
to potentially use as their data to create conversations.
This patch includes a simple "example" of using
conversation_create_endpoint
with TDMoP. The assignment of the PT_TDMOP "port type" has been replaced
by
setting ENDPOINT_TDMOP within the endpoint structure. Then when subdissectors
of TDMoP call find_or_create_conversation(), it implicitly picks up the
conversation information set by TDMoP
Change-Id: I11dc29989cccd3b0f0349ee901babb455ca02d19
Reviewed-on: https://code.wireshark.org/review/24190
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Andrew Chernyh <andrew.chernyh(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d518f28b395a7d1c8588c8f321ad5a…
commit d518f28b395a7d1c8588c8f321ad5ade194fb423
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Nov 1 00:20:04 2017 +0000
configure: Fix pcap-config --cflags command substitution
Change-Id: I654dd34d229b4cd69b5e3a0c77d8958d12bceead
Reviewed-on: https://code.wireshark.org/review/24207
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=7e4723a589bd266d50bff10cab34d2…
commit 7e4723a589bd266d50bff10cab34d2b6838f6412
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Tue Oct 31 13:44:12 2017 +0100
DOCSIS: add burst descriptor types. Fixed some bugs.
Change-Id: I9f7df2f62197c574087dbcce2c7b0ba7e6c8c56b
Reviewed-on: https://code.wireshark.org/review/24197
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=50c337f40a55e5b27d3442899bda60…
commit 50c337f40a55e5b27d3442899bda60edebe38691
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Oct 31 11:28:05 2017 +0100
mqtt: Add message decoding
Add support for configuring message decoding based on topic.
Matching criteria is equal-to, contains, starts-with, ends-with
or regular expression.
Change-Id: I677d869716eb1d2798974e2c65605a454421a66c
Reviewed-on: https://code.wireshark.org/review/24196
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e8c7975b6f0a83826b13b407b84f94…
commit e8c7975b6f0a83826b13b407b84f941124767080
Author: Thomas Wiens <th.wiens(a)gmx.de>
Date: Sun Oct 29 17:54:39 2017 +0100
s7comm: Several minor improvements
This patch includes several minor improvements:
- Special (only for Sinumerik NC): allow NCK address description in
data-part
- Userdata parameter part: add text definition for second req/res
- Don't add data tree in userdata telegrams, when there is no data in
there
- Cyclic functions: add new subfunction
- Alarming: add SCAN message decoding
- Improve info column display when there are multiple PDUs in one frame
Change-Id: Ib9afd0c6b14cf97ed645084e095f79fb40b07f43
Reviewed-on: https://code.wireshark.org/review/24170
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5bea387c2c7fd37dd0fe1784d6f84e…
commit 5bea387c2c7fd37dd0fe1784d6f84e400ad4ff09
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Oct 31 15:23:19 2017 +0100
HTTP: Update status codes
Updated status codes to include "103, Early Hints".
s. https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
Change-Id: Ic00285c0ffafeb689bbc30533fcbdeb688528c62
Reviewed-on: https://code.wireshark.org/review/24203
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=649c81b83c295ef96460554e8e02c0…
commit 649c81b83c295ef96460554e8e02c091bd6ae815
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Oct 31 15:40:50 2017 +0100
Qt: ByteViewTab Fix tabs creation
Fix creation of tabs
Change-Id: I11b22a3964f7c25c0c88b8ecd4eec1ad480fe800
Reviewed-on: https://code.wireshark.org/review/24202
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=56a130a152db73ea37f91d39be7d72…
commit 56a130a152db73ea37f91d39be7d72f814013236
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Wed Oct 25 15:39:35 2017 +0200
ByteViewText: Remove epan dependancy
Remove all dependancy for the byte_view_text from the epan system,
and therefore cleanly separate data and display for further separation
of dissection and view
Change-Id: Id1ee91b93da4511afa95f24da4cbbf39cbb89b1f
Reviewed-on: https://code.wireshark.org/review/24050
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c5165f325b6742f407a951f9c7d959…
commit c5165f325b6742f407a951f9c7d959314f15a6b5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 31 07:14:55 2017 +0000
conversation_table(.h): fix parameter 'ptype/port_type_val' not found in the
function declaration [-Wdocumentation]
Change-Id: Iea18cc73d28af68e14f7b9516b630b0987fe5731
Reviewed-on: https://code.wireshark.org/review/24195
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ec43b0faa6d8106205073c7c8596ed…
commit ec43b0faa6d8106205073c7c8596ed7ae4c64abc
Author: Christoph Wurm <wurm(a)elastic.co>
Date: Sun Oct 29 17:51:42 2017 +0000
Deduplicate Elasticsearch output
Collects multiple values of the same field into an array.
Empty protocols are now written as empty objects to not conflict
with the same protocols in other packets.
Remove _score since it has no effect.
Bug: 12958
Change-Id: Ibe8ea9bc1e3e63dea1fe4eaf522fa38cad88a17f
Reviewed-on: https://code.wireshark.org/review/24171
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e14f1ad37ded19188e864b82ed236b…
commit e14f1ad37ded19188e864b82ed236b1eb11eebf3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Oct 6 08:08:30 2017 +0200
.mailmap: update (of October)
Change-Id: I3b8d693c288edd61ec1bd9e9161919ac3ab35f52
Reviewed-on: https://code.wireshark.org/review/23850
Reviewed-by: Florian Fainelli
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6d8661ceef654b7857caff35f27b71…
commit 6d8661ceef654b7857caff35f27b71ec364f7f1d
Author: Christoph Wurm <wurm(a)elastic.co>
Date: Sun Oct 29 01:33:46 2017 +0000
Fix segfault in Elasticsearch output
When using the Elasticsearch output but only printing the packet
summary with -P a segfault will occur because the empty packet
tree is not properly handled in this case.
Change-Id: I0c91314ae013785ae6dceabd6af33db4b836d1b2
Reviewed-on: https://code.wireshark.org/review/24153
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3a1f958cf87f15cac3b92738d019eb…
commit 3a1f958cf87f15cac3b92738d019eb11046fc580
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 21:52:24 2017 +0000
Remove unused netdb.h #includes
Change-Id: Ia46903586219ee79210a980a04024af02acb0db0
Reviewed-on: https://code.wireshark.org/review/24189
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d887d76f277be4aad9c0e86292d2f7…
commit d887d76f277be4aad9c0e86292d2f7b5b8537abc
Author: Anders <anders.broman(a)ericsson.com>
Date: Mon Oct 30 22:01:16 2017 +0100
[BSSMAP-LE] Correct dissection of 10.20 Positioning Data.
Change-Id: Ia0c3b688dfdcd9fdad4f65df12ef97db99bdb095
Reviewed-on: https://code.wireshark.org/review/24192
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=90867dd8e37c3e348ad2ecac9f3067…
commit 90867dd8e37c3e348ad2ecac9f30679666fb9fbe
Author: Anders <anders.broman(a)ericsson.com>
Date: Mon Oct 30 22:23:07 2017 +0100
[BSSGP] Add PEI
Change-Id: I64d1924aba3c11fa72fbb12121bd09bcf21d598d
Reviewed-on: https://code.wireshark.org/review/24193
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d21eb05ebadd011083b3f9da3dfd32…
commit d21eb05ebadd011083b3f9da3dfd320a55c7bc52
Author: Anders <anders.broman(a)ericsson.com>
Date: Mon Oct 30 21:41:59 2017 +0100
[BSSGP] Fix IE numbering in PERFORM-LOCATION messages.
Change-Id: If767d905177b8d78f6b5d3c4e7b8d32a9e8a596a
Reviewed-on: https://code.wireshark.org/review/24191
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9a464fd9bd9b43bb4f7fbe8a9e5e0c…
commit 9a464fd9bd9b43bb4f7fbe8a9e5e0c6c34ffec50
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Oct 30 08:42:26 2017 +0000
Avoid asserting with EAFNOSUPPORT
We require support for AF_INET/AF_INET6 to run and assume this is available
on all supported platforms. If and when reality clashes with that assumption just
avoid aborting. Errors are to be expected as long as they don't produce a crash.
Change-Id: I5c107b1a8fd64441eb96f48381412e180b66feb7
Reviewed-on: https://code.wireshark.org/review/24187
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=e4ac91091d874129737ec797e6a932…
commit e4ac91091d874129737ec797e6a932962e6946cd
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Mon Oct 30 19:22:44 2017 +0000
tshark doc updates
After other changes, add info about -G help
and update output from -G dissector-tables.
Change-Id: I339d5c31a606720ef92e641e59ec5a45114321a8
Reviewed-on: https://code.wireshark.org/review/24188
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=0de8c6f4c70728f803de7a47bccd98…
commit 0de8c6f4c70728f803de7a47bccd982ec48b691e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Oct 30 11:28:21 2017 -0700
FT_IPv4 fields' values are 4-byte integers, not structures with a pointer.
Fix a tpyo while we're at it.
Change-Id: I1bde763ec2bd188c0f8afd1069db5a9f23963e8e
Reviewed-on: https://code.wireshark.org/review/24186
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bbae1d25c2b9502566715764828965…
commit bbae1d25c2b950256671576482896561995ba42c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Oct 30 11:00:02 2017 -0700
Fix indentation.
Change-Id: I0cc9d31cbe5dc7a95908a43c093f62e13b969eec
Reviewed-on: https://code.wireshark.org/review/24185
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e73571117cc991bea4e485e201809a…
commit e73571117cc991bea4e485e201809a6a0ae07247
Author: Anders <anders.broman(a)ericsson.com>
Date: Mon Oct 30 12:49:07 2017 +0100
[BSSGP] Fix decoding of Paging Attempt Information in PAGING PS.
Change-Id: I46770e4e50c34f13eaf6244de0ac6345b12646b5
Reviewed-on: https://code.wireshark.org/review/24182
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9008d7f867acbef624cc9522513d39…
commit 9008d7f867acbef624cc9522513d39521b3ce2b9
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Oct 30 10:40:46 2017 +0100
Fix assert when trying to display an IPv4 address
Follow-up of gdd1c18dd
Change-Id: Ifa6fc2e68f866540184a29a5fb61c3b7033bc8b2
Reviewed-on: https://code.wireshark.org/review/24180
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d597b5d61ec941df2c1a3bd56c125d…
commit d597b5d61ec941df2c1a3bd56c125dd70aa7d47c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Oct 29 15:24:27 2017 -0400
Remove port_type values not set in pinfo->ptype
NCP and SBCCS values used for conversation (endpoints) and not
to pass "type" to subdissectors.
Change-Id: I56a13d2bb7d718b340e9b5a102c43f6e0012bfb9
Reviewed-on: https://code.wireshark.org/review/24174
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=39ba9d4e7fb52ca8017bd4e934d6e6…
commit 39ba9d4e7fb52ca8017bd4e934d6e6f8acba8d4c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Oct 29 19:10:46 2017 -0700
Add wsutil/inet_ipv4.h.
It defines a ws_in4_addr type, which is intended to hold IPv4 addresses
in network byte order, and some macros to test for IPv4 addresses in the
local network control block and multicast IPv4 addresses.
Use those macros in places where dissectors had their own code for that
purpose.
Change-Id: I4252b410e37207157be85119a332e2a6913b332f
Reviewed-on: https://code.wireshark.org/review/24178
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dd1c18dd031038cbee7e219e322cbe…
commit dd1c18dd031038cbee7e219e322cbea1eafc87ca
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Oct 29 18:39:41 2017 -0700
Make FT_IPv4 a bit more like FT_IPv6.
FT_IPv6 doesn't expose the prefix, which is used only for values in
filter expressions, not values in protocol fields; do the same for
FT_IPv4, hiding the netmask, and using fvalue_get_integer() to get the
value, having it return a network-byte-order value for the address.
(This also makes it opaque whether the address and netmask are stored in
host or network byte order.)
Change-Id: I4285a87f6ccef2c0ccec040490ddcd15d787326e
Reviewed-on: https://code.wireshark.org/review/24177
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=734c5b35a5491794dc9cb31ed07a8d…
commit 734c5b35a5491794dc9cb31ed07a8d0d5576d4f5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Oct 29 17:49:34 2017 -0700
Get rid of ipv4_get_net_order_addr() and ipv4_get_host_order_addr().
Just directly use the addr field, converting from host to network byte
order if necessary.
Change-Id: Ie1cd9ea5527b7824014dc315225ad2a6adb61c38
Reviewed-on: https://code.wireshark.org/review/24176
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3630a447d9e73f3e04cfe37dd578d2…
commit 3630a447d9e73f3e04cfe37dd578d22a452fbbe6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Oct 29 15:29:31 2017 -0700
Get rid of unused #defines.
Change-Id: I6d4f56cddbe4378a3a7d4feb5ac16933675ac83b
Reviewed-on: https://code.wireshark.org/review/24175
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=62b870a72261f71f66ece9cb3b892d…
commit 62b870a72261f71f66ece9cb3b892d9999e805e3
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 19:22:39 2017 +0000
Do not assert in ws_inet_ntop()
Change-Id: I9d420c5f6bc29ce94855017739169dc8e8ce4d48
Reviewed-on: https://code.wireshark.org/review/24173
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=bebd79aae9ccaf5c96666d38665b69…
commit bebd79aae9ccaf5c96666d38665b69484f1f3eda
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon May 16 20:16:53 2016 +0100
parlay: Add another pragma to disable warning
Use our DIAG_OFF macros instead while at it.
Change-Id: I01d8d71a42fb108be156a68f8552ce537a1e2484
Reviewed-on: https://code.wireshark.org/review/15467
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=63966ec5d5b65cde2297f1f7417d28…
commit 63966ec5d5b65cde2297f1f7417d288f884a80b2
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Oct 29 14:29:27 2017 -0400
Use endpoint_type in conversation tables and hostlists
Follow up to having conversions use endpoint_type instead of
port_type.
Change-Id: Ifd59a33bd8b9a013c242bce5fcceb09533f02c17
Reviewed-on: https://code.wireshark.org/review/24172
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=765a67b68af28a6dbbb5c79d350896…
commit 765a67b68af28a6dbbb5c79d350896efbaa7adf4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Oct 29 12:38:41 2017 -0400
"Hardcode" the port types used by Export PDU functionality
The "internal" port type has been serialized by export PDU functionality
and nettrace_3gpp_32_423 wiretap. To better support "endpoint"
functionality
the port types will be removed/updated and that changes the implicit values
from the port_type enum.
Take a snapshot of the current port_type values and use those specific values
when reading/writing export PDU data and provide conversion functions that can
be modified when port_types are removed. Do the same for nettrace_3gpp_32_423
wiretap.
Change-Id: I770bd0cab22e84f3cf49032fc86c5927bf85263f
Reviewed-on: https://code.wireshark.org/review/24169
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1e8e9a807fd18c070489988c03e4ae…
commit 1e8e9a807fd18c070489988c03e4ae5b4701667a
Author: Gerald Combs <gerald(a)zing.org>
Date: Sun Oct 29 09:47:12 2017 -0700
make-manuf: Fix a comment.
make-manuf lives in the "tools" directory.
Change-Id: I9be2d44178f27d46629c439ff61f624d8d99e681
Reviewed-on: https://code.wireshark.org/review/24168
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=abfb6441177961fbdfa9648fdd2c40…
commit abfb6441177961fbdfa9648fdd2c40ef0ef3cefd
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Oct 29 10:12:59 2017 -0400
Add conversation endpoint type
For the moment this mirrors the port_type enumeration (PT_XXX), but the
intent is to move away from using "port types", eliminating most (if not
all)
Added conversation_pt_to_endpoint_type() so that conversations deal with the
correct enumeration. This is for dissector that use pinfo->ptype as input
to conversation APIs. Explicit use of port types are converted to using
ENDPOINT_XXX type.
Change-Id: Ia0bf553a3943b702c921f185407e03ce93ebf0ef
Reviewed-on: https://code.wireshark.org/review/24166
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1bc6d4e96573f89ecdd719cb3cac92…
commit 1bc6d4e96573f89ecdd719cb3cac92754b91f52c
Author: Jeff Dyer <jmasterfunk(a)gmail.com>
Date: Fri Oct 27 12:33:50 2017 -0600
Diameter: Add Huawei DCC AVPs
Change-Id: I480e58a1676677bb362bb4e9dc866c5d5f0814e1
Reviewed-on: https://code.wireshark.org/review/24111
Reviewed-by: Jeff Dyer <jmasterfunk(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fe8d897e2557f109b252ce83421d92…
commit fe8d897e2557f109b252ce83421d929c1ac039c6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 12:21:27 2017 +0000
sizeof(buf) is not what you want here
Change-Id: Iaf3463006b93c9acdc27f59fcbbea92df1d2fd7d
Reviewed-on: https://code.wireshark.org/review/24164
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=7507b11ec4440b8183a10113f5b33f…
commit 7507b11ec4440b8183a10113f5b33f56e6202c0e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 11:25:30 2017 +0000
Improve our ip6_to_str_buf() implementation
Change-Id: I02b5d01797e526299a6dc5a031662cb78e4f8423
Reviewed-on: https://code.wireshark.org/review/24163
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=de1b26a3c6fa27b29157e86a6da03f…
commit de1b26a3c6fa27b29157e86a6da03f354586badb
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 11:09:55 2017 +0000
More ws_inet_ntop() tweaks.
Change-Id: I8f77f189337f9299e566a4149ae6ea481d3dbed6
Reviewed-on: https://code.wireshark.org/review/24162
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=a25af02ef7c3dee6d83f5d61fdb62e…
commit a25af02ef7c3dee6d83f5d61fdb62ec8ebec971c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Oct 29 01:25:24 2017 -0700
Clean up processing of encoded addresses.
Allocate the buffer at the point we fill it in, and pick the appropriate
size or let the wmem_strXXX routine do it for us.
If we aren't using an address table, just fetch the value as an IPv4
address and hand it to ip_to_str_buf() - don't fetch it in host byte
order and then *fix* it by byte-swapping (hint: on a big-endian machine,
host byte order *is* network byte order and you don't want to swap it;
not all the world's an x86).
Change-Id: I966b107271ba166ff76a5600fbc4922808e7ead1
Reviewed-on: https://code.wireshark.org/review/24159
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=930f6345157659fca89d922612bfbb…
commit 930f6345157659fca89d922612bfbb69d8a8b53e
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Oct 29 08:18:09 2017 +0000
[Automatic update for 2017-10-29]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ia316bd89a4a8d08237b0e5eb9f0036dc5a6bad61
Reviewed-on: https://code.wireshark.org/review/24157
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=78f9a07f0a43cdd4dd9716c8599780…
commit 78f9a07f0a43cdd4dd9716c8599780609d00c390
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 01:09:36 2017 +0100
Remove unused epan/compress/ source code
Change-Id: I8f3bd41ff35f00b7a423751bc312725b7e7ae316
Reviewed-on: https://code.wireshark.org/review/24152
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e1ef732c11da520262476b782bc73b…
commit e1ef732c11da520262476b782bc73bfaf6e9ef1d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Oct 28 22:50:33 2017 -0700
Get rid of MAX_IP_STR_LEN and MAX_IP6_STR_LEN.
We have WS_INET_ADDRSTRLEN and WS_INET6_ADDRSTRLEN; use them.
Change-Id: Idade0da9fae70d891901acd787b06d21e2ddbc5f
Reviewed-on: https://code.wireshark.org/review/24156
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=83a4eadc070bcfda137b0f44e02712…
commit 83a4eadc070bcfda137b0f44e02712b46e5cb1d0
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 29 01:26:56 2017 +0000
wtap.h: Replace literal buffer size with WS_INET_ADDRSTRLEN
Bug: 14149
Change-Id: Ib7d60f93373eb23f5c950607f4cf6fc832c79670
Reviewed-on: https://code.wireshark.org/review/24154
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ce25b358a94205c92e3b2612abf121…
commit ce25b358a94205c92e3b2612abf12119c50af1c4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Oct 28 22:30:37 2017 -0700
Go with the RFC 2133-and-successors values for IPv4 and IPv6 address strings.
Add a comment explaining why Windows has different, larger values for
INET_ADDRSTRLEN and INET6_ADDRSTRLEN.
Change-Id: I4ad53c6cffae46d108f778460ce653dcc9343c64
Reviewed-on: https://code.wireshark.org/review/24155
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0527747e23f85bb9d3cf4ca69364e6…
commit 0527747e23f85bb9d3cf4ca69364e615bd22e1e9
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Oct 24 23:09:19 2017 +0100
Retire use of getprotobynumber()
Dead weight. If this feature is wanted getprotobynumber()
should be called once on startup.
Change-Id: I0358bacdc60466f676fa1aab7f4b7c9e588d8d74
Reviewed-on: https://code.wireshark.org/review/24045
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=18237cfd1513e10bc02599c263fbd8…
commit 18237cfd1513e10bc02599c263fbd855551da628
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 25 22:59:19 2017 +0100
configure: Display ssh_user_agent as a libssh sub-option
Change-Id: I19e38015d1395b021bc5169a6bf37fba0c5b1fe9
Reviewed-on: https://code.wireshark.org/review/24116
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=7dbc520d57b8567738a15f617a11d9…
commit 7dbc520d57b8567738a15f617a11d9b5b70f40a7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 28 13:26:51 2017 -0400
Privatize the conversation_key structure
The intention is to make it more transparent when making a switch
to an "endpoint" over address/port combination.
Change-Id: Ic424c32095ecb103bcb4f7f4079c549de2c8d9c4
Reviewed-on: https://code.wireshark.org/review/24148
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=db3be9f850446c1a1c4894f5d08d67…
commit db3be9f850446c1a1c4894f5d08d67a370abf94a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 28 11:47:52 2017 -0400
Remove display of "old" key in GTK configuration hashtable dialog
The information was for internal debugging, presumably as conversations
were converted to use the new algorithm. The algorithm has been in
place for a few years now and GTK is deprecated.
Change-Id: Ice0d0611bfbc0970089c671ab2cca15bfa5bf2fa
Reviewed-on: https://code.wireshark.org/review/24147
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=051dcd1086ad98d4c604740a6f95fd…
commit 051dcd1086ad98d4c604740a6f95fd8eec9a75d3
Author: Nikolai Ipatyev <wallprime(a)yandex.com>
Date: Sat Oct 28 20:30:24 2017 +0300
Fix bug in FMPUX heuristic dissector
The variables in the check were reversed
Change-Id: Idc7fc2b88ac1cde699b76423890918ce4b0ac086
Reviewed-on: https://code.wireshark.org/review/24149
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7df5fcdc51cb2616dc7ec97187e73a…
commit 7df5fcdc51cb2616dc7ec97187e73ab7ecccc7b3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 28 11:15:44 2017 -0400
Share use of conversation_hash_exact
It was duplicated in GTK, so just make it public (at least for now)
Change-Id: I89d985b2d42f0edb1c535a65a97b132920dedbcd
Reviewed-on: https://code.wireshark.org/review/24146
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=23afd9a18453c23cfbbc6a63f52b2e…
commit 23afd9a18453c23cfbbc6a63f52b2e6e64e0056c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 28 09:58:28 2017 -0400
Convert to using find_conversation_pinfo where appropriate
This makes it easier to identify the simpler/common conversations
Change-Id: I7094f23e49156ee27f5f72c8e130308470f3e462
Reviewed-on: https://code.wireshark.org/review/24145
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=27c10ed72ea2451bfbb6c0eb50af42…
commit 27c10ed72ea2451bfbb6c0eb50af4280e65a3fcf
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 16:41:18 2017 -0400
AMQP: Add dissector table for versions so they can be dissected with Decode As
Bug: 14113
Change-Id: I73c4962597d8f8bab83f089c9821269e0b7b1568
Reviewed-on: https://code.wireshark.org/review/24109
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Magnus Henoch <magnus.henoch(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5907d17b9a36133a13a11e1aa437e1…
commit 5907d17b9a36133a13a11e1aa437e178b6c12b72
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Oct 22 19:02:32 2017 +0200
QUIC: Display Connection ID (CID) on hexa
Ping-Bug: 13881
Change-Id: I7b97e27b6d2091a18e5fc3fd27251523a446cfde
Reviewed-on: https://code.wireshark.org/review/24020
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b0edc623b12a60ef6afdf9bdf9f762…
commit b0edc623b12a60ef6afdf9bdf9f762d61748df58
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Oct 28 13:29:56 2017 +0200
IEEE 1905.1a: fix an infinite loop (CID 1420355)
Change-Id: Iaa8e82cb5dc9f32e5c9dbf1db1068868d6fd3f18
Reviewed-on: https://code.wireshark.org/review/24144
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=695d8fc3183898d9d63c017b0b8271…
commit 695d8fc3183898d9d63c017b0b82716126a461f9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Oct 27 22:25:15 2017 -0700
MOAR PRE-ALLOCATED FIELDS.
Do what the errors in the master buildbots say to do.
Change-Id: I2b926bd9a75a1490390c42b8080f29e48096a3b4
Reviewed-on: https://code.wireshark.org/review/24143
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2b615cf32250173e21b36960b48c29…
commit 2b615cf32250173e21b36960b48c290298b360ca
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Oct 27 21:25:50 2017 -0700
Also display the protocol with -G dissector-tables.
Change-Id: If5c61195ad6bfb86c8e047428abaa6b0d48e7d74
Reviewed-on: https://code.wireshark.org/review/24142
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=985c0594a57317dbc612228f423fd3…
commit 985c0594a57317dbc612228f423fd38967c677bf
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Oct 27 21:17:52 2017 -0700
Indicate Decode As support in the -G dissector-tables output.
Change-Id: I95535ba11fdcac37057d1441e850ddf5455d32cf
Reviewed-on: https://code.wireshark.org/review/24141
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a1218446d9990fd2710c3f9fe56590…
commit a1218446d9990fd2710c3f9fe565907c202393a9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Oct 27 20:29:25 2017 -0700
Put all the 11n vs. 11ac stuff together.
Also, there's no need to zero out the NSS values for 11ac - we zero out
the entire pseudo-header at the beginning. We only need to set them if
we *have* them.
Change-Id: I9ebda7e246c24941ca77314bba6f86dea41e5992
Reviewed-on: https://code.wireshark.org/review/24135
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7ddfee9aead225465cbcdd5a29d7af…
commit 7ddfee9aead225465cbcdd5a29d7af5332bdccb7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 21:07:05 2017 -0400
tshark: Use -G help instead of -G ?
Not all platforms handle ? or -? *predictably* at the command line.
As long as "?" isn't replaced with a file name, it works, but if it
gets replaced by a file name...
Bug: 13984
Change-Id: I4496bb27fdef121967e7baf7b7f4a1bb0a44b00a
Reviewed-on: https://code.wireshark.org/review/24125
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7c9ec1d13cdb29725c6d093b7cb213…
commit 7c9ec1d13cdb29725c6d093b7cb21357fd43b5f9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Oct 27 19:43:47 2017 -0700
Don't add for "Decode As" if the dissector table doesn't support
it.
While we're at it, consistently use "name" as the name of the argument
giving the dissector table name.
Change-Id: Ied54c88d0d3dd467fe9067b008b49ead754c31a2
Reviewed-on: https://code.wireshark.org/review/24131
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=89e40fad2975fe8d1fcec8f786b19e…
commit 89e40fad2975fe8d1fcec8f786b19e45057938a5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 20:36:09 2017 -0400
packet-knxnetip.c: Fix bitmask
Bug: 14115
Change-Id: I836ee337f4727b0592cda074975c20a68fe7a27d
Reviewed-on: https://code.wireshark.org/review/24124
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6c709490c5a38f7e45ef06843d30b…
commit c6c709490c5a38f7e45ef06843d30b0f8b40636a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 20:09:19 2017 -0400
Q931: Fix Q931_ISO_IEC_STANDARDIZED_CODING value
It's typically masked with 0x60 without any bit shifting,
so make the value reflect it
Bug: 14116
Change-Id: I677c609a8e19a66ee557ac24c721ecb2312131a5
Reviewed-on: https://code.wireshark.org/review/24123
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ce181cbc87f8c9012d6df79b1e9280…
commit ce181cbc87f8c9012d6df79b1e9280908a78ec51
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Fri Oct 27 17:22:46 2017 +0200
DOCSIS: DPD: adding modulation list to info column
Change-Id: I5d99692d897f17e6e14952db8e4736ca65aa1373
Reviewed-on: https://code.wireshark.org/review/24106
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=087faa248845059203de152b6c1cc8…
commit 087faa248845059203de152b6c1cc806f89a8599
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 19:21:16 2017 -0400
Always provide value for Decode As selector column
Previous logic required multiple values from the decode as structure in
order to provide an initial value. This was incorrect and led to
values from protocol not selected showing in the selector column.
Change-Id: If1ad5085f4a6eb8d79fc5dd72be968188051ec4e
Reviewed-on: https://code.wireshark.org/review/24122
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=86302a7622a1fe529abb042033a856…
commit 86302a7622a1fe529abb042033a856bcf25602fe
Author: Thomas Wiens <th.wiens(a)gmx.de>
Date: Fri Oct 27 14:18:01 2017 +0200
s7comm: Syntax-id decoding of frequency inverter parameters
Add Syntax-id decoding for accessing frequency inverter parameters.
Moved the decoding of all other syntax-ids to separate functions.
Change-Id: Iba41f0631c4aeaf31a4ec6f73ffc42ca0b76f00d
Reviewed-on: https://code.wireshark.org/review/24102
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=86cb152b2fa95adbac629a65398f4b…
commit 86cb152b2fa95adbac629a65398f4b9b9949c95f
Author: Nicolas Darchis <ndarchis(a)cisco.com>
Date: Thu Oct 26 08:32:56 2017 -0400
peekremote: Support properly 11ac MCS rates.
The spatial streams amount support is still to be added.
Bug: 14136
Change-Id: I58b4ff4febcbd871c063a7add6a1e6b79ef23683
Reviewed-on: https://code.wireshark.org/review/24079
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3a6552744f2e44954a9e378dd076c8…
commit 3a6552744f2e44954a9e378dd076c8758bb5f1bb
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 16:39:50 2017 -0400
Add find_conversation_pinfo
Convenience function to add the same parameters to find_conversation as
find_or_create_conversation.
Change-Id: I3a92541cb9c1e827a9de8248825636debbd989cd
Reviewed-on: https://code.wireshark.org/review/24118
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f24651493d04b974722b0b70179bcb…
commit f24651493d04b974722b0b70179bcb6b9150a605
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 27 13:56:13 2017 -0400
OSPF: dissect_ospf_bitfield -> proto_tree_add_bitmask
Change-Id: Iaaa76ac8a5aad457258de3c23828cf3738f612c2
Reviewed-on: https://code.wireshark.org/review/24110
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4c8dfe6f6ef54e9b413a31f5f4bc18…
commit 4c8dfe6f6ef54e9b413a31f5f4bc18703a6c114e
Author: Magnus Henoch <magnus.henoch(a)gmail.com>
Date: Fri Oct 27 17:20:15 2017 +0100
Autodetect more AMQP 0-9 captures
When an capture file containing AMQP 0-9 traffic is missing the
protocol header, and the first packet contains more than one AMQP
frame, we'd fail to detect the protocol version properly, since we'd
check for the frame size being equal to the PDU size. Fix this case
by checking if the frame fits within the PDU instead.
While it's possible that 0-10 and 1.0 captures could be misdetected as
0-9, this seems highly unlikely. See details in comment in
packet-amqp.c.
Bug: 14113
Change-Id: I98978ed3919be3daf7fe9a972b87e09f27ba20e3
Reviewed-on: https://code.wireshark.org/review/24108
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c59601eeeab2b6e8778a0f9f0afd03…
commit c59601eeeab2b6e8778a0f9f0afd03d9cbfbf3c4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 25 22:07:48 2017 +0100
Remove AC_PROG_GCC_TRADITIONAL from configure.ac
Apparently this macro is (was?) used for CPP and some esoteric old non-ISO C headers,
which we don't use.
(Introduced with the very first Wireshark git commit.)
Change-Id: I22c32161aaa8df450d36d145b03cfcd62aa6268a
Reviewed-on: https://code.wireshark.org/review/24119
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=398dc811273b54d14e6965bb1af9cf…
commit 398dc811273b54d14e6965bb1af9cfe1360650f0
Author: Jeff Dyer <jmasterfunk(a)gmail.com>
Date: Fri Oct 27 13:04:43 2017 -0600
Change NewCo to new Company name, Aliv
Change-Id: I84c06a7f168da0f65b7c76360f38f39ecf1024d0
Reviewed-on: https://code.wireshark.org/review/24112
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e2afd06e6514721d2b9142269bd2bf…
commit e2afd06e6514721d2b9142269bd2bf1eb97393c0
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Oct 27 07:26:58 2017 +0100
YACC is set to the missing script if not found
Change-Id: I38ce7542e96c7571fa179e550cfba39d16dc417f
Reviewed-on: https://code.wireshark.org/review/24117
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=764431f8825ce628a01f14ca83a8bd…
commit 764431f8825ce628a01f14ca83a8bd29b094a8b1
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Oct 27 14:23:03 2017 +0100
autotools: Fix LN_S usage
"cp" always takes two arguments.
Change-Id: I6183988a24a38b1091d31a4e533b329f89f35dac
Reviewed-on: https://code.wireshark.org/review/24113
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=42f5aa4566d4a933270cdd50138d34…
commit 42f5aa4566d4a933270cdd50138d34262e192ada
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Oct 27 17:42:54 2017 +0200
IEEE 1905.1a: fix an infinite loop (CID 1420356)
Change-Id: I39b75acbf3598ad4e32e268f4b4378f16ca273c6
Reviewed-on: https://code.wireshark.org/review/24107
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=33d28030b1721c847780ee7d563515…
commit 33d28030b1721c847780ee7d563515cb661746ca
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Oct 27 15:58:07 2017 +0200
[AMR] Change the Payload type preference to a range and have separate
ranges for AMR and AMR-WB.
Change-Id: If5dca10b226a09168f1b1f834d97b826f8b777d6
Reviewed-on: https://code.wireshark.org/review/24105
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=395c54c4894dc7cc9d0dfb430e657c…
commit 395c54c4894dc7cc9d0dfb430e657c357075ab63
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Oct 27 15:52:24 2017 +0200
[BSSGP] Fix decoding of PERFORM-LOCATION-REQUEST.
Change-Id: I5039c93bd4f572599386a314a16230d7c1aaaf23
Reviewed-on: https://code.wireshark.org/review/24104
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bb7511bccf5427a25dc26b14ba7fe7…
commit bb7511bccf5427a25dc26b14ba7fe76d464e8e2f
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Oct 27 15:47:42 2017 +0200
[BSSMAP-LE] Add dissection of 10.18 Location Type.
Change-Id: I54900e13eca61cd1f190934a77cb0e704c877dfe
Reviewed-on: https://code.wireshark.org/review/24103
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4ee492e9109c95171bd425b4ac327c…
commit 4ee492e9109c95171bd425b4ac327c613ce56f00
Author: Taisuke Sasaki <taisasak(a)cisco.com>
Date: Thu Oct 26 13:08:34 2017 +0900
OSPFv2 Segment Routing extention support with RFC7684.
- RFC7684
- draft-ietf-ospf-segment-routing-extensions-20
Bug: 12297
Change-Id: I3acafe95ae2ef44a433c38c2495169d77e3c955d
Reviewed-on: https://code.wireshark.org/review/24070
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=545f20022419affa1ad71824b43414…
commit 545f20022419affa1ad71824b434141551359cc3
Author: Marius Paliga <marius.paliga(a)gmail.com>
Date: Fri Oct 27 13:21:50 2017 +0200
PFCP: Dissect Node ID: Fix length of FQDN Node Id Type
Octet 5 (Spare Node/ID Type) is included in the IE length
and FQDN uses just remainding length
Change-Id: I9c6e1de850bda0af315cbf801e757af6b25ed33e
Reviewed-on: https://code.wireshark.org/review/24101
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0a033cdc653b0ce4ec921312b4a34c…
commit 0a033cdc653b0ce4ec921312b4a34c7a028039f8
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Oct 27 09:08:54 2017 +0200
IEEE 1905.1a: remove an unused hf variable
Change-Id: I03d37495937020407783d366d01e3ad353889e80
Reviewed-on: https://code.wireshark.org/review/24098
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b085418501ee1222b75cd424e4a076…
commit b085418501ee1222b75cd424e4a076c0ca99ec91
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Oct 27 09:07:56 2017 +0200
IEEE 1905.1a: add what seems to be missing breaks
Change-Id: I60b41e503bc8933fb2efb2016b565caa0ec3bb97
Reviewed-on: https://code.wireshark.org/review/24097
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4330b268b22be9ccd54ef5e8a64469…
commit 4330b268b22be9ccd54ef5e8a64469a39a6045bf
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Oct 27 10:00:52 2017 +0200
debian: add ws_compiler_tests.h to libwsutils-dev.install
Change-Id: Ia2db7069a22c4786b0628fd554038b3091388963
Reviewed-on: https://code.wireshark.org/review/24099
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=db41ccd009ab01179f8629ba962e76…
commit db41ccd009ab01179f8629ba962e76ba7a6fda61
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Sun Sep 10 18:17:20 2017 -0700
Device provisioning protocol: Fix a last issue with DPP and Configuration
commands not being searchable.
Change-Id: I28cf212b3eacb16572ce9d1ff2dbf45040046b00
Reviewed-on: https://code.wireshark.org/review/24069
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=42a9e893fb95f8f8612b52d4be00f7…
commit 42a9e893fb95f8f8612b52d4be00f7bbf6f7546b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 19:00:20 2017 -0700
Clean up a bit.
If we're using Clang, use either _Pragma("clang diagnostic XXX") or
nothing; don't use _Pragma("GCC diagnostic XXX"). If we're using
something other than Clang that is, or claims to be, GCC, use
_Pragma("GCC diagnostic XXX") or nothing.
Explain why we're only using _Pragma("GCC diagnostic XXX") with GCC 4.8
or later, even though it's supported in GCC 4.2 and later, and even
though 4.6 an later support _Pragma("GCC diagnostic {push,pop}").
Change-Id: I7a5f46ec419b945663d473cb4ae435ab7fdcf0ef
Reviewed-on: https://code.wireshark.org/review/24096
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1ceab868cd0c86e1a64e0b80150163…
commit 1ceab868cd0c86e1a64e0b80150163a5b87b51ea
Author: Paul Offord <paul.offord(a)advance7.com>
Date: Thu Oct 26 23:08:43 2017 +0100
TRANSUM: File loading slow with transum enabled
This change improves performance through better handling of SYN -
SYN/ACK pairs.
Bug: 14094
Change-Id: Ie479f1b69fa48f85a2ed9f8f173533db25582bbd
Reviewed-on: https://code.wireshark.org/review/24090
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4e4f1debb75bece8f0a130d2f356f1…
commit 4e4f1debb75bece8f0a130d2f356f12bd5be0f00
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 18:26:35 2017 -0700
Fix typo.
Change-Id: I27373dd3823d3527ad3ebf272169feb7323b1a83
Reviewed-on: https://code.wireshark.org/review/24094
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e82adfba74957948781c0518088bd1…
commit e82adfba74957948781c0518088bd16365740c18
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 26 22:47:19 2017 +0200
proto.c: do not set an item length longer that the remaining tvb length
Ping-Bug: 14128
Change-Id: Iae5cb2f85d5d2fa3f2b6051aa57390a3f73d724a
Reviewed-on: https://code.wireshark.org/review/24087
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ed20250c132c5855dcb0df991c31ab…
commit ed20250c132c5855dcb0df991c31ab4de6b47a61
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 26 23:23:17 2017 +0200
proto.c: protect against buffer overflow in proto_find_undecoded_data()
Bug: 14128
Change-Id: I01aadf2dc9a3f714caaef273a7e012c6f1840726
Reviewed-on: https://code.wireshark.org/review/24088
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a0973d0f947df731e9e182c8b03d6e…
commit a0973d0f947df731e9e182c8b03d6e351591f457
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 14:59:40 2017 -0700
Move the compiler version tests to ws_compiler_tests.h and use them elsewhere.
While we're at it, sort some header file lists, and clean up white
space.
Change-Id: If737dda45334fedf1df7295d8719ad9381daf7a1
Reviewed-on: https://code.wireshark.org/review/24089
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ea49c337c59ac9a8d0b868581f3410…
commit ea49c337c59ac9a8d0b868581f341092f4b61814
Author: Christopher Maynard <Christopher.Maynard(a)igt.com>
Date: Sat Jul 29 12:18:26 2017 -0400
Include VLAN ID in key for ICMP request/response tracking
Add global preference to allow for "stricter" conversation tracking
Bug: 13518
Change-Id: I166a084c402374fa76dac7bb54f941e2e9c9325a
Reviewed-on: https://code.wireshark.org/review/22842
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=05b1d35586aee37dad7d84fa27531f…
commit 05b1d35586aee37dad7d84fa27531fc9794a41c9
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Wed Oct 25 19:38:33 2017 -0700
Initial coding of the ieee1905 dissector with Multi-AP support.
Change-Id: I94da228cba6baf20a2cd02bafc9704492f2cfc9f
Reviewed-on: https://code.wireshark.org/review/23956
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b4a6f4e2441153ffa8c6df7d790bc9…
commit b4a6f4e2441153ffa8c6df7d790bc9cb66df0a9e
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Thu Oct 26 20:46:35 2017 +0200
oss-fuzzshark: add missing include to fix implicit declaration of
color_filters_init()
/src/wireshark/tools/oss-fuzzshark/fuzzshark.c:218:7: warning: implicit declaration of
function 'color_filters_init' is invalid in C99 [-Wimplicit-function-declaration]
if (!color_filters_init(&err_msg, NULL))
^
1 warning generated.
Change-Id: I37dbc4521b6a3cda271e6e33a290ed35911e7dda
Reviewed-on: https://code.wireshark.org/review/24086
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6d092c134477ae1bd081a0ce8d79d9…
commit 6d092c134477ae1bd081a0ce8d79d964eb5f28eb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 11:38:49 2017 -0700
Whitespace cleanups.
Change-Id: Ic19c143fc9143da230f286f1fe4aecc0fe8b08be
Reviewed-on: https://code.wireshark.org/review/24085
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=985a8f297b5107bdd29df561fce1cf…
commit 985a8f297b5107bdd29df561fce1cfce5c541863
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 11:24:22 2017 -0700
Move a comment to where it belongs, expand another comment.
Change-Id: I04eff374132cbe4b93271c7a43303db406998bcb
Reviewed-on: https://code.wireshark.org/review/24084
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6ddee4aab22a96c444ace755fe3340…
commit 6ddee4aab22a96c444ace755fe33402f65e9f775
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Oct 26 10:50:25 2017 -0700
We don't need to define sockaddr_storage.
Winsock2.h will do that for us via packet32.h.
Change-Id: Ie834d49b052c3db6784481bb85d94d4eecff8287
Reviewed-on: https://code.wireshark.org/review/24082
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=fb160e53c8a9423ff78688bc9ef1ad…
commit fb160e53c8a9423ff78688bc9ef1ad5e1ec1edb1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 11:19:13 2017 -0700
Use more than just "does it claim to be GCC?" to test for attributes.
Not all versions of GCC or Clang have the returns_nonnull function
attribute, so use the same technique used in current master branch
libpcap - use __has_attribute() if it's available, otherwise use
compiler version tests.
This also lets us use WS_NORETURN on some non-GCC compilers.
Change-Id: I6ca4a81797ebfca9f743e16f83839c49d303da81
Reviewed-on: https://code.wireshark.org/review/24083
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b7f7bee8cf6ecb04a4dec86b80ce20…
commit b7f7bee8cf6ecb04a4dec86b80ce2065d4192da7
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Oct 26 09:05:06 2017 -0700
CMake: Set the Windows build target to Vista.
Set NTDDI_VERSION and _WIN32_WINNT to their Vista values so that
ws2tcpip.h will define inet_pton and inet_ntop. Remove the associated
compiler version checks so that everyone is on the same page.
Add breadcrumbs to the various parts of the code where we set a minimum
Windows version.
Change-Id: I83bba5fa1024bfbc02e07b120412807ad259e291
Reviewed-on: https://code.wireshark.org/review/24080
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=de6fcf2f21ee0a69b1d4d418f0c6d1…
commit de6fcf2f21ee0a69b1d4d418f0c6d184b161a203
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Oct 26 18:19:53 2017 +0100
Fix indentation
Change-Id: I81892f2624920ccf3e2f18734665b9b2e99de5cf
Reviewed-on: https://code.wireshark.org/review/24081
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=ac804b59e242c57e225c390eb8d6be…
commit ac804b59e242c57e225c390eb8d6bec359a7003f
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Oct 26 08:51:55 2017 +0100
Improve our inet_ntop() wrapper
Also fix buffer length define, as it is not guaranteed to be 46 on
Windows (it never was guaranteed anyway for the libc implementation,
but the likelyhood of being greater was small).
Change-Id: I2db705d86f825765ed32ec70b8d22058b5d629e8
Reviewed-on: https://code.wireshark.org/review/24074
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=296a36698b9ff2ab1beb3c21dc8409…
commit 296a36698b9ff2ab1beb3c21dc8409c3a276001c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 22 07:28:17 2017 +0100
configure: Remove profile-build option
Developers should know how to instrument the code for profiling with a given
toolchain. This particular case is trivially replaced with:
./configure CFLAGS="-pg" LDFLAGS="-pg"
Change-Id: Icc4bca9a8dc5d3ae59a3ff5a8d155f8dc868fcdd
Reviewed-on: https://code.wireshark.org/review/24054
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=3bafae200f5b08d386b5a3503023c0…
commit 3bafae200f5b08d386b5a3503023c0e3e2800947
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Thu Oct 26 11:57:15 2017 +0200
DOCSIS: added Energy Management and CM Status Ack modem capabilities
Change-Id: Ieef2cbf34e32f0730af03acc65ebe3499e1fe1f3
Reviewed-on: https://code.wireshark.org/review/24076
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=52332e3f9a98c618f9300d8c88955c…
commit 52332e3f9a98c618f9300d8c88955ca9d11627b5
Author: Marius Paliga <marius.paliga(a)gmail.com>
Date: Thu Oct 26 14:57:39 2017 +0200
PFCP: Fix offset after decoding Message Length
Change-Id: I163b4b1dfcad68e392fbddc3327ad081ca304a85
Reviewed-on: https://code.wireshark.org/review/24078
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=91ae90ba82709a534d160dd35392dc…
commit 91ae90ba82709a534d160dd35392dc60274ad3c1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 03:03:23 2017 -0700
ipv4_get_net_order_addr() is no longer an exported function.
At least not exported from libwireshark - it's now a static inline
function defined in a header.
Change-Id: Ic3eb397226459c7c8fb296f23777cbd0678a0a2f
Reviewed-on: https://code.wireshark.org/review/24077
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b1147a60337ff7a6f24daacfbfabb6…
commit b1147a60337ff7a6f24daacfbfabb681bf031fd5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 02:23:37 2017 -0700
Rename some IPv6 address test functions.
They test where the address is XXX, for various values of XXX, so name
them accordingly.
Change-Id: I437175f02b3f97fecee77e8bb9416bb5b71cd0d0
Reviewed-on: https://code.wireshark.org/review/24075
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=458c3c026ed03d17ec7803c6198127…
commit 458c3c026ed03d17ec7803c61981274ee4574f89
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 01:50:00 2017 -0700
Add a ws_in6_addr typedef for struct e_in6_addr.
That allows a parallel typedef of ws_in4_addr for guint32.
Change-Id: I03b230247065e0e3840eb87635315a8e523ef562
Reviewed-on: https://code.wireshark.org/review/24073
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0a99d3ef31611db7020d062216c856…
commit 0a99d3ef31611db7020d062216c856923ed29fac
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 00:35:35 2017 -0700
Fix comments, remove a no-longer-needed include.
Change-Id: I58cc8db41b474e937eb806510c277fe1830204fb
Reviewed-on: https://code.wireshark.org/review/24072
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b331641f98a1e55f7bd325e1a6e552…
commit b331641f98a1e55f7bd325e1a6e55206ecfc8094
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Oct 25 16:58:36 2017 -0700
CMake: Remove unused header checks.
Remove the following unused header checks and defines:
HAVE_INTTYPES_H
HAVE_STDINT_H
HAVE_STRINGS_H
HAVE_SYSCONF
Change-Id: I9f1307ead09c6800697004e7f79f5ac637eea3f7
Reviewed-on: https://code.wireshark.org/review/24067
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f97befbaa57ff432958d014b007c90…
commit f97befbaa57ff432958d014b007c909e04cd8ff9
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sat Oct 21 17:48:40 2017 +0300
RANAP: Associate RTP dissector with CS streams
Change-Id: If02b8cc5110c70e50ae04d245c45b1d133ee7fd3
Reviewed-on: https://code.wireshark.org/review/24010
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bfad9c56f9e65eafba00f97e5e6498…
commit bfad9c56f9e65eafba00f97e5e649842782eb2e1
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Oct 25 17:42:15 2017 -0700
CMake: Don't check for windows.h or winsock2.h.
If we're building on Windows we're going to have windows.h and
winsock2.h. Don't bother checking for them.
Change-Id: I0004c44d7364ab3f41682f34b8c84cd8617c9603
Reviewed-on: https://code.wireshark.org/review/24068
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=859405fd2dd7b76e00d650e1674db2…
commit 859405fd2dd7b76e00d650e1674db2378e05beff
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 26 00:03:09 2017 -0700
Swallow up the stuff from epan/ipv4.c into epan/ftypes/ftype-ipv4.c and epan/ipv4.h.
Most of it doesn't need to be public; pull it into epan/ipv4.c. Pull
the two routines that *are* used outside epan/ftypes/ftype-ipv4.c into
epan/ipv4.h as static inline functions.
This allows some optimization, and makes epan/ipv4.h more like epan/ipv6.h.
Change-Id: I80229acde559d810aecec2acd5c995076440c181
Reviewed-on: https://code.wireshark.org/review/24071
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e7abfc397bfa8981b3813c19a64c36…
commit e7abfc397bfa8981b3813c19a64c36cfb275f21d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 25 15:58:21 2017 -0700
Clean up white space.
Change-Id: If082be21933ea6e01ea2126d4aafa6c931d4674d
Reviewed-on: https://code.wireshark.org/review/24064
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f46d4d6e3b0c1802829785222e17e6…
commit f46d4d6e3b0c1802829785222e17e6f3ea081303
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 25 15:56:01 2017 -0700
Use a union for the IPv4/IPv6 address.
That way, the compiler ensures proper alignment. In practice, the
alignment was probably proper anyway, but this makes sure.
Change-Id: I5ddc028c97d6961692a297cac17236206b61169d
Reviewed-on: https://code.wireshark.org/review/24061
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=16309e41c8b61e20307af9de40ff97…
commit 16309e41c8b61e20307af9de40ff9742bb19cc6d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 25 23:08:19 2017 +0100
configure: Fix --with-libssh argument name mismatch
Change-Id: I38a55f9354f400ebe7a9acdf28a52a0068d9f745
Reviewed-on: https://code.wireshark.org/review/24058
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=93fba33e95006e18d1e16e3e32cbfd…
commit 93fba33e95006e18d1e16e3e32cbfde3a2457a38
Author: Pavel Strnad <strnadp(a)tiscali.cz>
Date: Wed Oct 25 10:34:47 2017 +0200
asn2wrs.py: use 64 bits variant for constrained integers using MIN or MAX keywords
Change-Id: Iffc7c81e9653e8c1cd938de8f4fc26c5912eceec
Reviewed-on: https://code.wireshark.org/review/24049
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=eae216ef1db4b22e533231c8766cf4…
commit eae216ef1db4b22e533231c8766cf4fad148eda6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 25 00:29:14 2017 +0100
Remove replacement inet_pton/inet_ntop
Should be available on every platform we support.
Change-Id: Ib65d78e351d22d581b427e5e93fc8d5e5348b260
Reviewed-on: https://code.wireshark.org/review/24047
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4dc02b2fcfa97e953e1ffc2c1a13f3…
commit 4dc02b2fcfa97e953e1ffc2c1a13f35f4a132965
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 25 12:58:55 2017 -0700
We're using inet_pton(), so we don't need to worry about non-dotted-quad
addresses.
inet_pton(), and thus ws_inet_pton(), won't accept hex or
fewer-than-four-component IPv4 addresses, at least on Single UNIX
Specification-compliant systems - the SUSv4 explicitly says
The inet_pton() function does not accept other formats (such as
the octal numbers, hexadecimal numbers, and fewer than four
numbers that inet_addr() accepts).
so we don't need to check for "inet_atons that accept strings such as -
"130.230" as valid addresses".
That also means that, "if there are any places where this needs to
support the hex-address form for IPv4 addresses, or to support fewer
than 4 components for a network address", those places were hosed even
before we stopped using inet_aton(), so there are presumably no such
places. (Itojun's comment was probably just an expression of general
concern, rather than a note of a known problem.)
Change-Id: Id16b6ebd3550dc3bf5a0fc283898a99b7abc163c
Reviewed-on: https://code.wireshark.org/review/24057
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=14080744dba2c170b6bc718aef1c89…
commit 14080744dba2c170b6bc718aef1c89e1e175eefe
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 25 12:51:33 2017 -0700
Get rid of a no-longer-needed variable.
We don't need a temporary IPv4 address variable in get_host_ipaddr(), we
can just use the pointer we've been handed.
Change-Id: Id7cbd0c14b2eeb3efde5a556f3414bd635411908
Reviewed-on: https://code.wireshark.org/review/24056
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6537c996a62ac0540fb21e4b046211…
commit 6537c996a62ac0540fb21e4b0462119422dd6ad6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 25 12:36:02 2017 -0700
Clean up and expand comments.
Note the dropping of support for hex IPv4 addresses and addresses with
fewer than four components, and indicate that, if there are any places
where that support is expected, we should change those places (i.e.,
don't just change get_host_ipaddr() and, if there aren't any such
places, just leave everything as it is).
It's not clear that get_host_ipaddr() is "Used more in the dfilter
parser rather than in packet dissectors"; that may depend on whether
you're counting number of calls executed from those places or the number
of lines of code making those calls. Just drop the claim, which is
absent in the comment for get_host_ipaddr6().
Also ask whether we're using get_host_ipaddr{6}() in any places where it
should *only* support numeric addresses rather than names.
Change-Id: Ib5d8730ca703339342f308081a68309479f842c5
Reviewed-on: https://code.wireshark.org/review/24055
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=90644c83725f979f82e7990792faaf…
commit 90644c83725f979f82e7990792faaf6e847f74ea
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Oct 24 21:04:19 2017 +0100
Remove inet_aton() usage everywhere
Including where it says not to in comments. Use IPv4 dotted-decimal
notation.
Change-Id: Iafe1f6fbd2bd5867c41642dc27411f47dff8ce6a
Reviewed-on: https://code.wireshark.org/review/24044
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c5529dd7f1269e88b4c122fa3c755d…
commit c5529dd7f1269e88b4c122fa3c755d5696b58a70
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Oct 25 20:57:58 2017 +0200
debian: Update symbols
Change-Id: I4360c3f819a3fc3254cecf862e5c084cb5a4162e
Reviewed-on: https://code.wireshark.org/review/24051
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=749447fc803770759600e14e9fb42e…
commit 749447fc803770759600e14e9fb42e31bafa73f7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 25 12:06:39 2017 -0700
Use "not installed for development" for libgcrypt.
This is similar phrasing to what I used for some other libraries;
hopefully it will keep people from asking "Why am I getting this error?
I installed libgcrypt" questions by making it clear that "installing
libgcrypt" might not be enough.
Also, don't give a package name, because the package might not be called
"libgcrypt-devel" - it might be called "libgcrypt20-dev" of
something
such as that.
Change-Id: I486a239e346955666d08cad3b1f8e3a961120e76
Reviewed-on: https://code.wireshark.org/review/24052
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=091607f8eb336ff51f875918574c12…
commit 091607f8eb336ff51f875918574c12256382c49e
Author: Ryan Mullen <rmmullen(a)gmail.com>
Date: Tue Oct 24 23:08:49 2017 -0400
rdm: Support NACK_REASON and fix a PD dissector
- Introduce support for the NACK_REASON response type
- Tweak the PD dissector for DMX_PERSONALITY_DESCRIPTION, which
misinterpreted the "Personality Requested" field and used the wrong
length for the "DMX512 Slots Required" field
Change-Id: If5bc64f82e531e6cfb03a508c335b0468bf6e836
Reviewed-on: https://code.wireshark.org/review/24048
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0e7d2542b0fdc12ef4e0c223d5fe3e…
commit 0e7d2542b0fdc12ef4e0c223d5fe3ecf2b5d669c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Oct 24 17:43:33 2017 -0400
Add 32x32 png file for UAT "clear list" icon
Change-Id: Ifff401d9014d58c3848e1fcb2f09f09d4391e61e
Reviewed-on: https://code.wireshark.org/review/24043
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7318d8337aa0f9466e08c8667b14fa…
commit 7318d8337aa0f9466e08c8667b14fa9473b41a6b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Oct 24 23:41:24 2017 +0100
Remove leftover #define.
Change-Id: Ic18094a487a941a8c76c722afe8e22194b069993
Reviewed-on: https://code.wireshark.org/review/24046
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=e1ef8e5f7555a1608d0cddde6c824c…
commit e1ef8e5f7555a1608d0cddde6c824c5a897f6e58
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Oct 23 19:00:27 2017 +0100
Test g_printf() thousands grouping flag at runtime
This tests the runtime environment so avoid hard-coding it during the build.
For now we avoid messing with locales for the test, unless it turns out to
be necessary (ISO C printf behaviour with invalid conversion specifier is
undefined).
Change-Id: I341c2ab5e716973689cf9002f13435404a41369f
Reviewed-on: https://code.wireshark.org/review/24038
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=08a490328387eafb7f9d20293a2a5e…
commit 08a490328387eafb7f9d20293a2a5e97e6cf4268
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Oct 24 12:03:19 2017 -0700
Fix registration of SIP atop SSL/TLS.
See https://ask.wireshark.org/questions/64151/sip-tls-is-only-shown-as-tcp.
Change-Id: Ife182136601007ff6a5713666d9fada5abcd00b9
Reviewed-on: https://code.wireshark.org/review/24041
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=15ce2db13afa087be8a0329e72411f…
commit 15ce2db13afa087be8a0329e72411f7d1b2b77f6
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Oct 22 11:35:12 2017 -0400
mqtt: Use proto_tree_add_bitmask
Change-Id: I8e9cd64edcabf810e70b134ecce7a771babafebc
Reviewed-on: https://code.wireshark.org/review/24017
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=14e687c1dd17e7a39a7cf3293e3397…
commit 14e687c1dd17e7a39a7cf3293e3397ac36117e49
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 22 20:30:07 2017 +0100
Make plugin support a runtime property
Keep the option to disable at compile-time but use AC_ARG_ENABLE instead.
Change-Id: Ie8c3f5ba0db1eb6d9d4ffd742cd3aa049ead5007
Reviewed-on: https://code.wireshark.org/review/24026
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=12d63c428f973b1f7e04ad58d432d7…
commit 12d63c428f973b1f7e04ad58d432d778e2035a9a
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Oct 23 19:46:16 2017 +0100
configure: Remove ancient inet_pton test for brokenness
Change-Id: Idac71883b6a1c6c78ae79e929f1c67a295ed9035
Reviewed-on: https://code.wireshark.org/review/24037
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6014bfe6fc06786cd074bd66cda210…
commit 6014bfe6fc06786cd074bd66cda210b9aafa7d36
Author: Eliot Lear <lear(a)cisco.com>
Date: Mon Oct 23 14:44:12 2017 +0200
Get program to the right working directory.
Otherwise patches breaks.
Change-Id: Ief735dc949eaefa3515cc0a5936e0a2735cb0241
Reviewed-on: https://code.wireshark.org/review/24035
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bc924b628365480f1b2dd5281b8657…
commit bc924b628365480f1b2dd5281b8657a3ad3d1eac
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Mon Oct 23 10:35:53 2017 +0200
DOCSIS: fixed TLV name
Change-Id: Ibfc8310e1a150fb2e04f7dad9a68d08e8d0364b7
Reviewed-on: https://code.wireshark.org/review/24032
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c7918da8a6b28fc515d273c16a9ffc…
commit c7918da8a6b28fc515d273c16a9ffca2a4b9e119
Author: Eldon Stegall <wireshark-gerrit(a)eldondev.com>
Date: Tue Oct 17 14:55:52 2017 +0000
Improve http object export for URLs with long extensions
This allows the export of objects with extensions that may be longer
than the allowed file name of an export (due to underlying filesystem, etc).
The extension detection mechanism previously preserved everything in the file
name after the final ".", but in some cases (especially with long query
strings)
this would exceed the allowed maximum file length, and simply refuse to export
the object. Now, if the length of the extension and duplicate number is longer
than the allowable file length, the extension is ignored, and the entire string
is truncated to allow an acceptable export filename.
Bug: 14130
Change-Id: I6fa0281519d031c07a9ac621002ac328f34f54cc
Reviewed-on: https://code.wireshark.org/review/23960
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b74af851471687e258fa7624a49898…
commit b74af851471687e258fa7624a498981b77ebdba6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Oct 22 18:35:49 2017 +0200
ssl-utils: Add export tls13_hkdf_expand_label
for reuse on QUIC dissector
Change-Id: Ic1d6b875e1e1944bb2aa6c7a85bfdd984c00948c
Reviewed-on: https://code.wireshark.org/review/24018
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6e3133c41ca760e9c3156f641236af…
commit 6e3133c41ca760e9c3156f641236af54c7464c48
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 22 14:16:53 2017 +0100
AirPcap is Windows only, reflect that in about dialog
Change-Id: Iecde2ada76a63da47e80cf0188945dab2a7e5b89
Reviewed-on: https://code.wireshark.org/review/24023
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=182d9deb08125f9c595bcb32dcb28f…
commit 182d9deb08125f9c595bcb32dcb28f745989d615
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 21 22:50:16 2017 -0400
Add "Apply as filter" button to Coloring Rules Dialog
Add a button to apply currently selected color as the display filter.
Bug: 14100
Change-Id: Ife3edeb577075f1fe30b649a5655ef5887684d8a
Reviewed-on: https://code.wireshark.org/review/24012
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a16126fffbaa8ee854b32cc80f94d6…
commit a16126fffbaa8ee854b32cc80f94d6233ee3ef4f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Oct 22 18:40:47 2017 +0200
QUIC: Add draft-07 value_string
Change-Id: Icc4cfc4ce007eac29d9a502eae76527713e93e05
Ping-Bug: 13881
Reviewed-on: https://code.wireshark.org/review/24019
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=de066346a649906e7105b18d9f7a5f…
commit de066346a649906e7105b18d9f7a5f823ace43e2
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Oct 22 21:28:05 2017 +0200
mqtt: Fix some mistakes from previous commit
- PUBREL, SUBSCRIBE and UNSUBSCRIBE does use QoS for v3.1
- CONNACK is also different between v3.1 and v3.1.1
- DUP flag is not reserved, it's Retain which is reserved
- Use proto_tree_add_item for reserved fields
- Use uniform layout and fixed indent (2 spaces in this file)
Change-Id: I26337ad63cd67d832db84993349fa3406e305b72
Reviewed-on: https://code.wireshark.org/review/24025
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=89fe6629b73cea803d6bd803cd9131…
commit 89fe6629b73cea803d6bd803cd9131a9f39d8ccd
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Sun Oct 15 06:18:38 2017 -0400
[RFC] dissector/mqtt: Fix handling of fixed header flags
According to the MQTT v3.1 and v3.1.1 specifications,
the fixed header flags (DUP, QoS and RETAIN) are only set by
the PUBLISH message.
The DUP flag is also set by the PUBREL, SUBSCRIBE and
UNSUBSCRIBE messages but only when version 3.1 is used.
Currently, the MQTT dissector shows the header flags for
all the v3.1 and v3.1.1 messages.
This patch fixes the issues mentioned above.
To track the protocol version used during the connection handshake
a conversation is used. For subsequent messages, the way the header
flags are displayed is determined by this variable.
Change-Id: Iad808f77a2c379f9786152c26d3aa86e24be1b16
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/23939
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=535ac5832dd39055328b8c211aacf7…
commit 535ac5832dd39055328b8c211aacf77d654d5282
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 22 19:07:29 2017 +0100
Fix make distcheck
Change-Id: Ie6b49429a5a72a4ed7b76fa74b1a6f33b6811254
Reviewed-on: https://code.wireshark.org/review/24022
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=ce3ce9e70eb6a2b9400a56d592d75d…
commit ce3ce9e70eb6a2b9400a56d592d75df23682a40b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Oct 22 17:06:12 2017 +0000
[Automatic update for 2017-10-22]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I973703f2a82c96e47ec15512e223766404a6d3a1
Reviewed-on: https://code.wireshark.org/review/24021
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b91089befc50b838853f1f2b7b0bda…
commit b91089befc50b838853f1f2b7b0bdad51537aaf3
Author: Eliot Lear <lear(a)cisco.com>
Date: Sun Oct 22 11:35:33 2017 +0200
Add IANA arc and first entry (MUDURL) for lldp.
PCAP file:
https://github.com/the-tcpdump-group/tcpdump/blob/master/tests/lldp_mudurl.…
Change-Id: If1f4946f8a8ade44dbab33a877bf7449f9ea2a6f
Reviewed-on: https://code.wireshark.org/review/23982
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b913bcc13a9a6213902691a8d73bba…
commit b913bcc13a9a6213902691a8d73bba1427ab407b
Author: Cal Turney <cturney111(a)gmail.com>
Date: Sat Oct 7 22:06:12 2017 -0400
NFSv4: Fix for duplicate StateId hashes
In WS v11.4.0 released In May, 2014, "tvb_get_string_enc()" was added to
dissect_nfs4_stateid() which treats the numeric stateid as a string and
converted it to UTF-8. Invalid UTF-8 chars were replaced with the
"REPLACEMENT CHARACTER" which are actually three characters: 0xef, 0xbf,
and 0xbd (0xefbfbd). A hash was made of the first 16 chars of the returned
array although the string was often much larger due to 1 to 16 invalid
chars. This has often caused duplicate hashes for different files and
locks. That routine has been removed. In addition, the size of the hash
has been reduced from 32 to 16 bits which affords a 99.9984% chance of
unique hashes. Finally, hf_nfs4_seqid, used for the stateid hash seqid
has been changed to hf_nfs4_seqid_stateid because in CLOSE requests the
seqid has nothing to do with the stateid seqid.
Change-Id: I3bf7caefc3341887a4c9137500dfeac0115af8cf
Reviewed-on: https://code.wireshark.org/review/23966
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=aa04d2355effb1cf611831b0a260cf…
commit aa04d2355effb1cf611831b0a260cf1aff199b9a
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 20:11:24 2017 +0100
autotools: Build and install user guide
Installs the WSUG to $docdir, unless the --disable-guides option is given
to the configure script.
This will open the Help->Contents menu action using the locally installed
guide. It will also point to the correct version for this Wireshark release.
The wireshark.org link only provides the guide for the master branch.
Change-Id: I9dd539c737cb3777dc1351707b9e45a3a6764aaa
Reviewed-on: https://code.wireshark.org/review/23906
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: João Valverde <j(a)v6e.pt>
Tested-by: João Valverde <j(a)v6e.pt>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b0432442c607c7d71e40c55ffd0bf4…
commit b0432442c607c7d71e40c55ffd0bf46f43ef3d1a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Oct 22 08:13:29 2017 +0000
[Automatic update for 2017-10-22]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I2bc1e987630e05d2942e9405ab45e4c2f7452263
Reviewed-on: https://code.wireshark.org/review/24013
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=61380f950428dc7166647e6b597341…
commit 61380f950428dc7166647e6b5973415b691e1b70
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Oct 17 13:57:04 2017 -0400
Add button in Qt UAT dialog/frame to remove all UAT entries at once.
Change-Id: If5a172cd69beeb0b9a22eb7f6b9e7cb25f350b49
Reviewed-on: https://code.wireshark.org/review/23968
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4e3114d01dd2ddbf4044bcd5c91812…
commit 4e3114d01dd2ddbf4044bcd5c91812d3bd3f7fbd
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 21 10:22:43 2017 -0400
Eliminate #include <epan/oui.h> from dissectors that don't need it.
Correct include patch for packet-lldp.c
Change-Id: I5e2a267943ccd39616ef323848104fdba23c8f38
Reviewed-on: https://code.wireshark.org/review/24009
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=85820a835426059b31479107ddfb66…
commit 85820a835426059b31479107ddfb660ff5067807
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Oct 21 13:25:06 2017 +0200
Diameter 3GPP: call XML dissector for Civic-Address AVP payload
Bug: 14142
Change-Id: Iccf5c375087cabd08aa551af8e6586e18684252a
Reviewed-on: https://code.wireshark.org/review/24008
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d9b8eaf088628255e64343462ac0e…
commit 0d9b8eaf088628255e64343462ac0e2e90c66c67
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Oct 20 16:10:34 2017 -0700
Warn the developer if we're building with GTK+.
Move The Slowest Migration In The History Of Ever a little further
along.
Change-Id: Ib8b49708e7036dd412a7ffc8660ded9f681374c0
Reviewed-on: https://code.wireshark.org/review/24006
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b289699ace2075c934f7009dea3071…
commit b289699ace2075c934f7009dea307156f9296071
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Oct 21 00:00:46 2017 -0400
Remove oui_vals value_string and epan/oui.c
oui.c is a very small subset of what comes from
http://standards.ieee.org/regauth/oui/oui.txt,
so use the "full" OUI list (and more) out of the manuf file and convert
hf_ fields to just use BASE_OUI.
Change-Id: Ic0c2ff618d8a6212f498e3b7475e0a7856c22b5b
Reviewed-on: https://code.wireshark.org/review/24007
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0f868cfeb0260fc30f8fe071031210…
commit 0f868cfeb0260fc30f8fe0710312102dac6972fd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Oct 20 11:26:09 2017 +0000
nfapi: fix 'nfapi.p7_message_header.m_segment_sequence' exists multiple times
with NOT compatible types: FT_UINT8 and FT_BOOLEAN
Change-Id: I221315e6dc28835ce976caf167962847d536edc6
Reviewed-on: https://code.wireshark.org/review/24001
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0088d010edb1dc9704efa1ad11e7d0…
commit 0088d010edb1dc9704efa1ad11e7d0975b6878ba
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Oct 20 03:43:03 2017 +0100
Qt: fix crash after loading SRT dialog
TapParameterDialog::on_applyFilterButton_clicked first calls fillTree to
populate the table and endRetapPackets to add the results to GUI. The
table data must remain valid until closing the dialog since the user can
still interact with the GUI.
Change-Id: Ie3105be78d39c562af52f2b49081552063afcada
Ping-Bug: 14141
Reviewed-on: https://code.wireshark.org/review/23994
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c23e3761a550ca5e44cb3878fa47d7…
commit c23e3761a550ca5e44cb3878fa47d7c00f469424
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Oct 20 10:51:04 2017 +0200
file_util.c: do not leak service handle
Follow-up of gd64c30052
Change-Id: I620b3fb44fe3090120f2d29809961623e00d55a4
Reviewed-on: https://code.wireshark.org/review/23999
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0a6c51e4a0319ca62fb41664da4eac…
commit 0a6c51e4a0319ca62fb41664da4eac7482844227
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 11:00:38 2017 +0100
autotools: Improve SUBDIRS usage
Change-Id: Ia40970c37f4b60f8b820c334c3c728a0ac33f228
Reviewed-on: https://code.wireshark.org/review/23996
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=e6e8b7b662419466a264201a6d08af…
commit e6e8b7b662419466a264201a6d08af2dc9a737e9
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 18 23:37:49 2017 +0100
autotools: Sort out how we handle plugin.c
Change-Id: Ie9570a63a1479021753807f76dd5e98fbbec7b86
Reviewed-on: https://code.wireshark.org/review/23995
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=d64c300522ffa830e061adeb81e752…
commit d64c300522ffa830e061adeb81e75255b3f955ac
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Oct 18 10:11:56 2017 +0200
Do not add Npcap path if npf.sys service is found
Otherwise you can end with 2 Packet.dll (the one from WinPcap and the one
from Npcap) being loaded at the same time, which can create incompatibilities.
Bug: 14134
Change-Id: Ia06066fd54b60296e55dbfce6c6f2ddd99367479
Reviewed-on: https://code.wireshark.org/review/23969
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4273eced0c24442e5e713762e97cba…
commit 4273eced0c24442e5e713762e97cba5457b23284
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Oct 20 01:13:31 2017 +0100
cmake: fix Qt build with CMake 3.0.0 and 3.0.1
AUTOUIC fails to generate some ui_*.h files because of a bug that was
fixed in CMake 3.0.2: https://cmake.org/Bug/view.php?id=14981
Change-Id: I964d991c7edefcea55ae43b0768a7fd3503f94a9
Fixes: v2.5.0rc0-1366-gdfa893b1cf ("cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to
avoid CMP0071 warning")
Reviewed-on: https://code.wireshark.org/review/23993
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=fd1d13567d07bb429f9209c4c11a97…
commit fd1d13567d07bb429f9209c4c11a97c7ba02dab8
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 19 21:30:25 2017 +0200
LCSAP: fix retrieval of XML dissector handle
Bug: 14131
Change-Id: Ie77ade9d54f9d0a5fa0183cedc154e6595a489cf
Reviewed-on: https://code.wireshark.org/review/23991
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea1476c4f03845fa054cf590089ec3…
commit ea1476c4f03845fa054cf590089ec33dd3999f5d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Oct 19 11:53:50 2017 -0700
Suggest using CMake rather than autotools.
The configure script 1) can't find newer versions of Qt, thanks to the
Qt developers not supplying any .pc files and 2) doesn't look for useful
frameworks, so it's not the best way to build Wireshark on macOS any
more. Discuss CMake instead.
Change-Id: I28befffab010221e2e17e37f5beaf8b732974190
Reviewed-on: https://code.wireshark.org/review/23990
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7aa5630d1eeb4b25d2467b9eb12f52…
commit 7aa5630d1eeb4b25d2467b9eb12f52c56df7c96d
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Oct 19 09:08:02 2017 -0700
TCP: Add a documentation note.
Note that changes to tcp_analyze_sequence_number should be synced with
docbook/wsug_src/WSUG_chapter_advanced.asciidoc#ChAdvTCPAnalysis.
Change-Id: Iac72d2cf808d84c17fa5f12012675e0af1895cd1
Reviewed-on: https://code.wireshark.org/review/23989
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=c1807eec7800c7b6ab8f99a42b1edc…
commit c1807eec7800c7b6ab8f99a42b1edca741d5da0b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Oct 19 08:24:58 2017 -0700
Add more notes about Asciidoctor.
Change-Id: I7fd12b9189448a637d1bebac6687168f017d8d8d
Reviewed-on: https://code.wireshark.org/review/23987
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=0870f8586a1aef45d668127d0f3628…
commit 0870f8586a1aef45d668127d0f3628a70bd0623d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Oct 19 07:39:47 2017 -0400
Remove duplicate values in pfcp_pr_time_unit_vals
** (process:8955): WARNING **: Field 'Uplink Time Unit' (pfcp.ul_time_unit)
has a conflicting entry in its value_string: 3 is at indices 3 (Day) and 4 (Week))
** (process:8955): WARNING **: Field 'Downlink Time Unit' (pfcp.dl_time_unit)
has a conflicting entry in its value_string: 3 is at indices 3 (Day) and 4 (Week))
Change-Id: I870af4a53721e0ffe0f9f778c8287e090f2b2929
Reviewed-on: https://code.wireshark.org/review/23985
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2323b20779d1af74057b3e3a52b3f4…
commit 2323b20779d1af74057b3e3a52b3f42b39ef91c4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Oct 19 07:41:20 2017 -0400
Correct duplicate values for csi_rs_class_vals
** (process:8955): WARNING **: Field 'Class' (nfapi.csi.rs.class) has a
conflicting entry in its value_string: 1 is at indices 1 (Class A) and 2 (Class B))
Change-Id: I6063fd5fe0094efe776a3a04556c633a4e495a9a
Reviewed-on: https://code.wireshark.org/review/23986
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=15c4382f1706512fc5f4695b7d30ec…
commit 15c4382f1706512fc5f4695b7d30ec4a195f2ced
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 19 10:35:02 2017 +0200
FP Mux: disable heuristic dissector by default
Without any specific pattern, it is too weak and catch a lot of
unrelated UDP packets.
Change-Id: Iacac5ae65de59da1d46a06184517834edd91eb18
Reviewed-on: https://code.wireshark.org/review/23984
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d291d1a4239ed744c65b64d62aebaa…
commit d291d1a4239ed744c65b64d62aebaae88ceed552
Author: Graham Shanks <graham.shanks(a)blueyonder.co.uk>
Date: Thu Oct 19 00:03:27 2017 +0100
Update enumerations for SISO-REF-010 v22
Change-Id: Icb326dac7cfe0478df3d892df279ad0f241c7ba6
Reviewed-on: https://code.wireshark.org/review/23981
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5fd13dac123f1a31ad2aad7e1c7338…
commit 5fd13dac123f1a31ad2aad7e1c7338ba25527b11
Author: Nikolai Ipatyev <wallprime(a)yandex.com>
Date: Wed Oct 18 23:07:16 2017 +0300
fpmux: Fix error string and comment
Change-Id: If4620a43d706f7067a018eb964e4db3733d65210
Reviewed-on: https://code.wireshark.org/review/23980
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bc880f6c3e71c1e1ce4eb19f6cfa40…
commit bc880f6c3e71c1e1ce4eb19f6cfa404ae4e6cda5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Oct 18 21:23:42 2017 +0200
FP Mux: reject empty tvb
Bug: 14140
Change-Id: I43c635e97f33c190e2a4a7f42e58f4274bd03f2b
Reviewed-on: https://code.wireshark.org/review/23978
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=288973ff7485d910fbef60ed2875ed…
commit 288973ff7485d910fbef60ed2875edfd387f1a4f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Oct 18 21:18:00 2017 +0200
FP Mux: create conversation if it does not exist
Change-Id: Ib26145c30f6f3ba20e26d52f1e4b90825029809d
Ping-Bug: 14140
Reviewed-on: https://code.wireshark.org/review/23977
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b580bbfdd275e6151e2d67d8a03da6…
commit b580bbfdd275e6151e2d67d8a03da6c9dae0b36b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Oct 18 21:15:15 2017 +0200
FP Mux: do not register UDP port 44955 by default
It is not registered by IANA
Change-Id: Iff462ee0a2366ae72681b34e4e7e107c8c479822
Reviewed-on: https://code.wireshark.org/review/23976
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e5755a62130246e6f5e5163f766579…
commit e5755a62130246e6f5e5163f766579084a58f2dc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Oct 18 21:14:38 2017 +0200
FP Mux: fix a typo in preferences
Change-Id: I19ba1bb223a3356b4048448f0bb908f23e7364c0
Reviewed-on: https://code.wireshark.org/review/23975
Reviewed-by: Nikolai Ipatyev <wallprime(a)yandex.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d8fdc135c4a075dde57d18e696216b…
commit d8fdc135c4a075dde57d18e696216b53e934fba1
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 18 14:52:18 2017 +0100
Update packet-kerberos.c
Change-Id: I86387e4f8ebf7f7cd2f3b9e01e9b4cfe91a7357e
Reviewed-on: https://code.wireshark.org/review/23974
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2196fcb0088040f5ad48797fb234c4…
commit 2196fcb0088040f5ad48797fb234c41eb561b5af
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Oct 17 23:17:15 2017 +0100
Refresh wsutil/Makefile.am
Change-Id: I6a70a2dc45257826c930f57a59cdd9bf5b4c3c73
Reviewed-on: https://code.wireshark.org/review/23973
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=45fbb287b42c47d9fc84c1abc9158a…
commit 45fbb287b42c47d9fc84c1abc9158a7d24333c79
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Oct 5 17:37:27 2017 +0100
autotools: Remove abi-compliance-checker code
It's been broken for over a year, needs to be modernized and as
implemented it's a maintenance nightmare. Get rid of it.
Ping-Bug: 13036
Change-Id: I34a6e4c28b6d3b96dd6550dd21e9cbeaf050d58f
Reviewed-on: https://code.wireshark.org/review/23967
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c703ba52adc02c83245a5d428e6943…
commit c703ba52adc02c83245a5d428e6943d4a4a0f995
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Wed Oct 18 11:54:46 2017 +0200
DOCSIS: Fixed bug where OCD TLVs are nested
Change-Id: I3b6a7c6dabfe017eb6c223ab2491e0a3cda8c56c
Reviewed-on: https://code.wireshark.org/review/23970
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2575a2e9a8928025a28d6873094c22…
commit 2575a2e9a8928025a28d6873094c22c867ad5ab5
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Oct 18 11:54:15 2017 +0100
autotools: Sort out how we handle register.c
register.c is a built source. It should not be included in the distribution
and should be removed with the distclean target.
Remove XXX comment suggesting adding the cache to the distribution; let's
not do that.
Change-Id: I20f9467a93e2b5ad3ee56a5fa83381095b1d28c6
Reviewed-on: https://code.wireshark.org/review/23971
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=dfa893b1cfd8491a3563ad2c29a0df…
commit dfa893b1cfd8491a3563ad2c29a0dfaf44d960cf
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Oct 14 23:40:30 2017 +0100
cmake: set CMAKE_AUTOUIC and CMAKE_AUTORCC to avoid CMP0071 warning
CMake 3.10 adds CMP0071 which results in warnings about applying AUTOMOC
and AUTOUIC on generated files. It somehow tries to do this for files
generated by QT5_ADD_RESOURCES and QT5_WRAP_UI.
As a workaround, just convert from the legacy macros to the new method.
Autogenerated ui_*.h and moc_*.h will now also be shown in the "External
Dependencies" tab in Visual Studio
Change-Id: I36df2212bbf0f938fcd4560000031b6137db93ca
Reviewed-on: https://code.wireshark.org/review/23917
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b85b946a94e0c27ef22084bfc39079…
commit b85b946a94e0c27ef22084bfc390798c8c205057
Author: Nikolai Ipatyev <wallprime(a)yandex.com>
Date: Fri Oct 6 15:01:43 2017 +0300
Add FP-Mux dissector
Change-Id: I58a9a0cf0364c8ce5f173ed28c054fd05738f690
Reviewed-on: https://code.wireshark.org/review/23868
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5a85f5a40b265a5bd9d4a015ccf1ed…
commit 5a85f5a40b265a5bd9d4a015ccf1edcee44914af
Author: Aurelien Aptel <aaptel(a)suse.com>
Date: Tue Oct 17 16:31:00 2017 +0200
SMB2: accept and save empty filenames on CREATE requests
[MS-SMB2] 2.2.13 CREATE Request, NameOffset:
A zero length file name indicates a request to open
the root of the share.
This also ends up enabling the parsing of missing
fields (InputBufferLength, AdditionalInformation, Flags) in QUERY_INFO
requests, which required a non-NULL saved->extra_info.
Change-Id: I9af3933cc6bb93247bad23c7dd82a52787595f69
Signed-off-by: Aurelien Aptel <aaptel(a)suse.com>
Reviewed-on: https://code.wireshark.org/review/23959
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bbb13097417ce268cfa25a920ed85b…
commit bbb13097417ce268cfa25a920ed85b59515f283e
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Tue Oct 17 10:18:00 2017 +0200
Added default for every switch statement
Change-Id: Ie74dec4d854f65835a4e7e68dac609290a84d791
Reviewed-on: https://code.wireshark.org/review/23957
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1ac9db4ca67b47da79d55e0cf309f1…
commit 1ac9db4ca67b47da79d55e0cf309f1a40ca084f5
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Oct 17 21:05:07 2017 +0200
Protobuf: Fix format error
Fixes error: format '%lu' expects argument of type
'long unsigned int', but argument 4 has type 'guint64'
Change-Id: I431ab2e1920b7856ff686bd79bc881dee494706f
Reviewed-on: https://code.wireshark.org/review/23965
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=070e561ed99aca1b5dcc4f47f246f3…
commit 070e561ed99aca1b5dcc4f47f246f3a761876422
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Oct 17 08:54:07 2017 +0100
autotools: Smaller cleanups
ps.c is already correctly cleaned in epan/Makefile.am. make distclean also
works well with tarballs so I think the other comment can also be removed.
ldconfig may be needed for tshark.
The installation step seems to do all the right things so just drop the
rather verbose description of the XDG Base Directory Spec.
Add the MKDIR_P and INSTALL variables for consistency and to address some
of the portability concerns raised in the comment (INSTALL usage still
needs to follow a standard form common for portable automake).
Remove redundant plugin_ldadd else clause.
Change-Id: Ic2cb04556f28622a8979b057e0abbe64256ed3c9
Reviewed-on: https://code.wireshark.org/review/23964
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=96d6267e2d18a04decd7fe6998d20b…
commit 96d6267e2d18a04decd7fe6998d20b94ea5fb56d
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Tue Oct 10 23:02:29 2017 +0200
ZCL SE Octet Strings: Dissect zcl se octet strings as length and data
Implemented a function to dissect zcl octet strings in a similar way as attributes
that have a data type of zcl octet string.
Currently the function is used for event data (publish event and publish event log),
as well as top up code (consumer top up and publish top up log).
Bug: 14138
Change-Id: Idae6240312bedeaa12f10777e1009b110d5f834d
Reviewed-on: https://code.wireshark.org/review/23881
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7cfbd2b9ba356aa7a0de2eb2cf06ae…
commit 7cfbd2b9ba356aa7a0de2eb2cf06ae37fd6ae55e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Oct 17 12:16:17 2017 -0700
Suggest CMake if Qt not found on Darwin; say "not installed for
development".
Hopefully this will allow more people to figure out how to compile
Wireshark without 1) e-mailing wireshark-dev, 2) asking in
ask.wireshark.com, or 3) filing a bug, if the underlying problem is that
1) they didn't install the appropriate xyzzy-dev package for
something Wireshark uses
or
2) they're trying to use autotools on macOS and they've
installed a recent, and not-very-pkg-config-friendly, version
of Qt.
Change-Id: I69236558f207ed0bf81d2acdc0230630f6069dec
Reviewed-on: https://code.wireshark.org/review/23963
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=55b0c251a0379a5a0a0d713c487170…
commit 55b0c251a0379a5a0a0d713c48717019acc965c6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 12:16:46 2017 +0100
autotools: remove macOS Frameworks support
This treats macOS/OSX like any other Unix-like build target (Darwin),
thus removing autotools support for macOS-specific build options.
Anyone needing that is advised to use the fully-supported-on-macOS CMake
build.
Change-Id: I88e2fa7a8eea42241efcf84223ac2362d38b1e12
Reviewed-on: https://code.wireshark.org/review/23951
Petri-Dish: João Valverde <j(a)v6e.pt>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=1d238ec636ff051635a7ed194df5c4…
commit 1d238ec636ff051635a7ed194df5c49752788d69
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 22:54:24 2017 +0100
autotools: Remove setuid-root.pl
It seems to be some sort of development helper, and since CMake doesn't
use it presumably it is not useful anymore.
Change-Id: I23e4ab24199f21310ebd09064c3ae53e48673e4d
Reviewed-on: https://code.wireshark.org/review/23945
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=ca7f204576d43e36275dad02cbf6e4…
commit ca7f204576d43e36275dad02cbf6e414447df03d
Author: Adam Wujek <adam.wujek(a)cern.ch>
Date: Mon Oct 16 17:30:54 2017 +0200
dissector/ptp: fix typo - should be ptp.as.sig.tlv.flags
Change-Id: I31be23516d7fb169daa827b505bcde04426e84dc
Signed-off-by: Adam Wujek <adam.wujek(a)cern.ch>
Reviewed-on: https://code.wireshark.org/review/23961
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f6915bef29bd3a2f452ace0a3b3f47…
commit f6915bef29bd3a2f452ace0a3b3f47255fd041b6
Author: Aurelien Aptel <aaptel(a)suse.com>
Date: Tue Oct 17 16:27:26 2017 +0200
SMB2: rename QUERY_INFO buffer input fields and parse Reserved field
Since the packet has an output and input buffer, having a field just
called "size" or "offset" was confusing.
Change-Id: Iadb45fa50e6ea6ffaa7c3b041704837641f64ab6
Signed-off-by: Aurelien Aptel <aaptel(a)suse.com>
Reviewed-on: https://code.wireshark.org/review/23958
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8a0d5ff98e008a11ea9851f4bb09b…
commit a8a0d5ff98e008a11ea9851f4bb09bd3663e248b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 8 17:54:50 2017 +0100
autotools: Fix bogus checkAPI targets
Change-Id: Ifc8884fc0f0e4548db79a68e3fbc35c7e5fb9be9
Reviewed-on: https://code.wireshark.org/review/23947
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=6f9630561f0a0ae2842d90043b4ccc…
commit 6f9630561f0a0ae2842d90043b4ccc595ef06f3e
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Oct 16 17:53:13 2017 +0200
[Bluetooth] Prepare for adding a BT Mesh dissector.
Change-Id: I79140a15c93e7bfada5036fd3fbb1bb94d99a655
Reviewed-on: https://code.wireshark.org/review/23940
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f19a2c0b8c000d5d7ea6fd9d48cbad…
commit f19a2c0b8c000d5d7ea6fd9d48cbad606f8fdfb6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Oct 17 01:40:14 2017 +0100
CMake: increase minimum required version to 2.8.11
Due to the use of target_include_directories (when sshdump or ciscodump
are enabled), the minimum required version is 2.8.11. The supported OS
versions do not change, but Debian Wheezy users must enable backports.
Change-Id: I883c81e5e81425ca1869f442686faf1e66a638f3
Reviewed-on: https://code.wireshark.org/review/23955
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a3ba3ba94337007a458e2d4c40f3a3…
commit a3ba3ba94337007a458e2d4c40f3a36ad4b0e9c1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Oct 17 03:34:35 2017 +0100
CMake: fix Qt build with CMake 2.8.12 and before
The Qt5Widgets_EXECUTABLE_COMPILE_FLAGS option is only needed for CMake
before 2.8.12 and before as documented by Qt, so this ugly piece can be
restricted to older CMake versions. That also helps avoiding exposing
the Qt 5.5.0 in Windows since that requires a much newer CMake version.
For those older versions, use COMPILE_FLAGS such that -fPIC is added
after -fPIE (the latter is enabled by CMAKE_POSITION_INDEPENDENT_CODE).
Tested with CMake 2.8.11, 2.8.12.2, 3.0.2 and 3.9.4 using Qt 5.9.2 and
GCC 7.2.0.
Change-Id: I4962f7f5a087ee5b8c79905dd3b2cce17c731bdf
Fixes: v2.1.0rc0-566-gd66d379ac8 ("Try retroactively applying the Qt folks'
fix for QTBUG-47942.")
Reviewed-on: https://code.wireshark.org/review/23954
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=731434cbca7404d5e9f9ecd1cc6a32…
commit 731434cbca7404d5e9f9ecd1cc6a32e6635fd684
Author: Tigran Mkrtchyan <tigran.mkrtchyan(a)desy.de>
Date: Tue Sep 26 15:11:41 2017 +0200
nfs: fix nfs dissector to show correct mirror and data server counts
nfs dissector wrongly have used proto_tree_add_item to display a
counter, by assuming that last argument is a value.
Replace proto_tree_add_item with proto_tree_add_uint or
proto_tree_add_subtree_format when a loop counter must be
displayed. Update tree item size calculation.
Change-Id: I4137e42673fa33cae61494effe1195206fbf7f28
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan(a)desy.de>
Reviewed-on: https://code.wireshark.org/review/23748
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=560945336c8ad46eadde6439955abd…
commit 560945336c8ad46eadde6439955abd67cb52e4e5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Oct 16 21:44:21 2017 -0400
Bugfix Decode As dissector table selection.
Need to use UI name to select between different tables.
Change-Id: I2f25435e6ac1a2f1a15e651cd3ef1bbc9e860d89
Reviewed-on: https://code.wireshark.org/review/23952
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3d78077f7a3e72722407649768f1b6…
commit 3d78077f7a3e72722407649768f1b677b4e63180
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Oct 17 01:24:44 2017 +0100
CMake: fix build regression with CMake 3.0
This kind of generator expressions do not seem to work in CMake 3.0. It
works fine in CMake 3.1.0 and later versions.
Change-Id: I262566a5ea831ae0fbe4b6a3249b59401f9d3b15
Fixes: v2.5.0rc0-1334-gd3f636ece0 ("cmake: fix CMP0026 deprecation warning in
CMake 3.9")
Reviewed-on: https://code.wireshark.org/review/23949
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=b6ab30127583d38dcf0d49548e842c…
commit b6ab30127583d38dcf0d49548e842c410ae2c69a
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Oct 17 03:00:04 2017 +0100
Remove GTK ige mac integration remnant from configure.ac
Follow-up to 356d6b8db04bfc15a1d0a5fabbc79aad0e81d592.
Change-Id: Ibfe2e890eb2e41b962c5a045a8d84c5431c0f336
Reviewed-on: https://code.wireshark.org/review/23953
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=b5505fd4512456f85188a81e9b6478…
commit b5505fd4512456f85188a81e9b6478ecce65504b
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Oct 17 00:23:28 2017 +0100
ssl: regression fix for decryption with renegotiation
A renegotiated session with decrypted records has !maybe_encrypted which
means that the plaintext buffer is passed to dissect_ssl3_handshake. Do
not assume that this plaintext buffer might be encrypted, it is
definitely not the case.
Change-Id: I2ce9a5305e5cbc24b5c7e93077f7e796bf8cb406
Fixes: v2.5.0rc0-1314-g9d189c7e20 ("ssl: assume everything after CCS is
encrypted")
Ping-Bug: 14117
Reviewed-on: https://code.wireshark.org/review/23948
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=46f4664b29a685a43dd5dd4c18b60e…
commit 46f4664b29a685a43dd5dd4c18b60e8bc1a5c34f
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 8 17:33:16 2017 +0100
checkAPI: error out on empty filelist
This will help detect some bogus checkapi runs in the future.
Change-Id: I43345e3a0a5471e9655f34e36ccf1562d6526758
Reviewed-on: https://code.wireshark.org/review/23946
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9cfb746e65c42fafb1a94009fcf5d8…
commit 9cfb746e65c42fafb1a94009fcf5d8e2bdf7c00d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Oct 16 20:51:46 2017 +0200
nfapi: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Value stored to 'offset' is never read
Change-Id: Ia7f651edec36a75c60816a3803e53dc86d749262
Reviewed-on: https://code.wireshark.org/review/23942
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4acce81d127d56bdf62c2c7e6f321c…
commit 4acce81d127d56bdf62c2c7e6f321c2a458643e1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Oct 16 20:50:38 2017 +0200
nfapi: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Value stored to 'item' is never read
Change-Id: I964c06d1a3896e9e5c52dfcb2f17478f15350910
Reviewed-on: https://code.wireshark.org/review/23941
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ba92b90f8b9a1f3331ab10c2c49883…
commit ba92b90f8b9a1f3331ab10c2c49883ac32f577c9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Oct 16 20:51:50 2017 +0200
lorawan: Fix Join Request and Join Accept
Use correct start offset for Join Request and Join Accept.
Always show the MAC Header fields (and add the RFU).
Add subtree for Join Request and Join Accept.
Register the dissector to be able to "Decode As" and calling the
dissector from Lua.
Change-Id: I644530f2ae36f5a9d2ea89e4446995a5caa4eea4
Reviewed-on: https://code.wireshark.org/review/23944
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Erik de Jong <erikdejong(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=356d6b8db04bfc15a1d0a5fabbc79a…
commit 356d6b8db04bfc15a1d0a5fabbc79aad0e81d592
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 19:58:55 2017 +0100
GTK: Remove OSX integration library support
Only Wireshark Qt is officially supported on macOS.
Change-Id: Id0e3429891173d4b91e99061bcf11df2e38bc0bf
Reviewed-on: https://code.wireshark.org/review/23931
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0a3cf5d5cf09c17afd06c64172780b…
commit 0a3cf5d5cf09c17afd06c64172780b4a02acdb62
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Oct 16 20:56:11 2017 +0200
protobuf: no previous prototype for ‘sint64_decode/sint32_decode’
[-Wmissing-prototypes]
Change-Id: I85be2eb645ab00d711f525d711ebf90f200595cc
Reviewed-on: https://code.wireshark.org/review/23943
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dbbaa41362647569c0087c212e908c…
commit dbbaa41362647569c0087c212e908c2ac570cbb7
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 12:16:46 2017 +0100
autotools: remove some macOS specific build options
This treats macOS/OSX like any other Unix-like build target, thus removing
autotools support for macOS-specific build options.
Anyone needing that is advised to use the fully-supported-on-macOS CMake
build.
Change-Id: I631464a90e16e3db89538801c741657a0a4a7451
Reviewed-on: https://code.wireshark.org/review/23911
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0d6c5a79eb75e10f1d13b160c18a32…
commit 0d6c5a79eb75e10f1d13b160c18a32c0bf57a2d7
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Sun Oct 15 05:15:13 2017 -0400
dissector/mqtt: Fix some inline comments
There are some issues with the inline comments. Rephrase those
comments. Furthermore, use the MQTT v3.1 and v3.1.1 specification
language to fix some inline comments.
Change-Id: Ia3864e1b66ef1eb4bbd8cb90aed674c7d9c4b7be
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/23937
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1a8143172c973fb74fa7b329a8b698…
commit 1a8143172c973fb74fa7b329a8b698cbb42ef865
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Mon Oct 16 01:11:48 2017 -0400
dissector/mqtt: Add the protocol version string
Add the protocol version string:
- 3 maps to MQTT v3.1
- 4 maps to MQTT v3.1.1
Change-Id: I8cf1ba0c1bcabd5718467946b33082e4eb5a37ed
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/23938
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=5967621d19204947021932ea86f1e5…
commit 5967621d19204947021932ea86f1e55fbe810124
Author: Flavio Santes <flavio.santes(a)1byt3.com>
Date: Sun Oct 15 02:33:56 2017 -0400
dissector/mqtt: Add the MQTT protocol description
The packet-PROTOABBREV.c template recommends to provide a short
description of the protocol below the license header. Currently,
this information is not present in the packet-mqtt.c dissector.
This patch adds the protocol description taken from the official
specification. Links to the v3.1 and v3.1.1 specifications are
also provided by this patch.
Change-Id: I9bb85aa3b78c8804c923f77c163904a7949f6899
Signed-off-by: Flavio Santes <flavio.santes(a)1byt3.com>
Reviewed-on: https://code.wireshark.org/review/23936
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f7054dcf0569756ad4f0f1fe32d785…
commit f7054dcf0569756ad4f0f1fe32d785b91c4c05a4
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Oct 16 07:12:52 2017 +0200
RSVP: fix some typo
Bug: 13977
Change-Id: I1caa721fe9e5c27354fbf6c07ebd2fa3c0c0d91a
Reviewed-on: https://code.wireshark.org/review/23935
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d3f636ece0ab60e2b8edc8648fa05e…
commit d3f636ece0ab60e2b8edc8648fa05e83338b60c6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Oct 14 20:13:52 2017 +0100
cmake: fix CMP0026 deprecation warning in CMake 3.9
Since CMake 3.9, all policies before CMP0036 emit a warning. Fix the
warning by not relying on the old behavior (existence of the LOCATION
property).
Tested with Ninja, the cmake output, rules.ninja and build.ninja output
is identical (minus the deprecation warning).
Change-Id: I058699380b01a9c02d9b98fd485ce6ded427abe3
Reviewed-on: https://code.wireshark.org/review/23915
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=282b59a853f95c7bf463b617f8d409…
commit 282b59a853f95c7bf463b617f8d40949b8f8b3ef
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Wed Aug 16 11:20:19 2017 +0200
[RFC]androiddump: Support extcap-dlts option
According to README.extcap documentation all extcap tools must
support the --extcap-dlts option. For performance reasons support
for this option was removed by commit:
9328eb6 androiddump: Register interfaces when list interfaces
A side effect of not implementing the option is that dumpcap is
then also called to try to retrieve interface capabilities
for all androiddump interfaces. As extcap interfaces are not
local network interfaces errors like these are logged
whenever the interface list is refreshed:
Capture Dbg sync_if_capabilities_open
Capture Info sync_pipe_run_command() starts
Capture Dbg argv[0]: /usr/local/bin/wireshark/dumpcap
Capture Dbg argv[1]: -i
Capture Dbg argv[2]: android-tcpdump-wlan0...
Capture Dbg argv[3]: -L
Capture Dbg argv[4]: -Z
Capture Dbg argv[5]: none
Capture Dbg sync_pipe_open_command
Capture Dbg read 25 ok indicator: E len: 333 msg: E
Capture Dbg sync_pipe_wait_for_child: wait till child closed
Capture Dbg sync_pipe_wait_for_child: capture child closed after 0.000s
Capture Info sync_pipe_run_command() ends, taking 0.012s, result=-1
Capture Msg Capture Interface Capabilities failed. Error -1, The
capabilities of the capture device "android-tcpdump-wlan0..."
could not be obtained (android-tcpdump-wlan0...:
SIOCETHTOOL(ETHTOOL_GET_TS_INFO) ioctl failed: No such device).
Please check to make sure you have sufficient permissions, and
that you have the proper interface or pipe specified. ()
To avoid error prints and to fulfil the documented equirements for extcap
tools register a fake interface with what would be the properties of such
an interface.
Change-Id: If174adbb64c66132be4225f854bbf9f66d2f5ed1
Reviewed-on: https://code.wireshark.org/review/23093
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2cb717ec78e3479943dfe235e0c29c…
commit 2cb717ec78e3479943dfe235e0c29c085a19ebfc
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Oct 13 22:08:21 2017 +0100
cmake: remove and reorder unused cmake policies
Current minimum CMake version has everything up to CMP0017 enabled by
default, remove older policies. CMP0011 had not effect, our
link_directories are already absolute paths.
Change-Id: I3af08ca75700de4a860fb4afd664824031e2c5f5
Reviewed-on: https://code.wireshark.org/review/23914
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1dd0111f5e2426390d36626f075254…
commit 1dd0111f5e2426390d36626f07525470d8b9a9d9
Author: Simon Long <hobei(a)whitedoor.plus.com>
Date: Thu May 4 11:01:20 2017 +0100
Initial submission of the nfapi dissector
Bug: 13726
Change-Id: I630d73c4c90b6fe6019a7ff6a38f9a3b4657eac3
Reviewed-on: https://code.wireshark.org/review/21493
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=21c030ca752cdc9eaf3c5da4a0ade5…
commit 21c030ca752cdc9eaf3c5da4a0ade533f24cf1c2
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Oct 16 00:34:48 2017 +0100
packaging: Fix RPM spec file
Change-Id: Ib05cfeb9ef553ebd69e388e6ba00ddf751deb686
Reviewed-on: https://code.wireshark.org/review/23934
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=55e050383082907c3054f65063f7ba…
commit 55e050383082907c3054f65063f7ba77f609ab2b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 14:54:10 2017 +0100
autotools: refresh rpm-package target
There's only so much we can/should do here, so dispense with the _topdir
test.
Change-Id: Ibf1170ea2cbb7c536df901db42d67da668fd64b2
Reviewed-on: https://code.wireshark.org/review/23912
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=cb89fdd1f664d68dcf3ed5251a4d3d…
commit cb89fdd1f664d68dcf3ed5251a4d3d43fe9504e4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Oct 9 15:17:32 2017 -0400
Add support for BASE_OUI
Modeled after BASE_PT_XXX, this will format a FT_UINT24 to look a OUI, in the form
of:
XX:XX:XX (Manufacturer Name) for display.
For display filtering, it will treat the value as hexadecimal.
It requires that FT_UINT24 be the field type.
Change-Id: I8716ae4dfcd4e854764a2425e2ff13c50f571d52
Reviewed-on: https://code.wireshark.org/review/23869
Reviewed-by: Richard Sharpe
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2663881c378913d5c9cd123c469e1b…
commit 2663881c378913d5c9cd123c469e1bb29a5e39be
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sun Oct 15 21:57:06 2017 +0300
rlc: Fix bug in 'RLC over UDP' dissector
Reassembly of AM/UM packets doesn't work when the URNTI tag is missing and the
default value of 0 is kept. This patch makes the default value 1 for those cases.
Bug: 14129
Change-Id: Id13121b5de63da4318214871b8963ceef5d28cf0
Reviewed-on: https://code.wireshark.org/review/23930
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6aba76666da060f12b379cf8786686…
commit 6aba76666da060f12b379cf8786686e545007f2a
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sat Oct 14 20:22:29 2017 +0300
rrc: Dissect algorithm capabilities
asn2wrs created fields for several BITSTRING bits but does not actually uses them.
This changeset calls them for the umts ciphering/integrity algorithms and gsm algorithms
Change-Id: I88ddc2aec6805a77fcb3f3d547efda4d513ec919
Reviewed-on: https://code.wireshark.org/review/23899
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d0a4a614f9116d97cdb202607135e7…
commit d0a4a614f9116d97cdb202607135e7f1b3b8e3cd
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 11:55:29 2017 +0100
plugins: Remove COPYING and NEWS
We don't need to be this strict for bundled plugins about following
the GNU Coding Standards.
Change-Id: I18ed1b81d428eea15ea387102823f588287daf81
Reviewed-on: https://code.wireshark.org/review/23918
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=52bcdda04ec658a307575460930c71…
commit 52bcdda04ec658a307575460930c71777e7cf4df
Author: Brenton Rothchild <brentonr(a)dorm.org>
Date: Fri Oct 6 11:32:22 2017 -0500
ZigBee ZCL: Add additional On/Off cluster commands
Adds support for additionally defined On/Off cluster
commands and attributes.
Bug: 14109
Change-Id: I148722a5f36800d8778c721a6c60cab17a030b0c
Reviewed-on: https://code.wireshark.org/review/23852
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9764cd0a830e87c8acf13b4d494ea7…
commit 9764cd0a830e87c8acf13b4d494ea7fe4df72f85
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 14:35:06 2017 +0100
autotools: make maintainer-clean should allow rerunning 'configure'
Change-Id: Iedae94ffefe27b13b1967d69cacb757b5aa4576d
Reviewed-on: https://code.wireshark.org/review/23928
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f89b8ccff4d2172a8c244d46d1c559…
commit f89b8ccff4d2172a8c244d46d1c559018b5ce917
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Oct 15 10:53:54 2017 +0200
Makefile(.am/dissectors): fix indent (always use tabs)
Change-Id: I652bd3657e335edd9f0c27a29fd360f0bc7d1c12
Reviewed-on: https://code.wireshark.org/review/23923
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2563f9dd797e93f932ef66554b5bff…
commit 2563f9dd797e93f932ef66554b5bff9e5948a322
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 13:00:39 2017 +0100
plugins: Fix -Wmissing-prototype for plugin_register()
Change-Id: I03d5ca01fb3bc8fdae86b44e857a4b9a3c7f48d2
Reviewed-on: https://code.wireshark.org/review/23927
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=9d49e1316689ae05d31efc866f04ac…
commit 9d49e1316689ae05d31efc866f04ac12cd051085
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sat Aug 26 10:30:47 2017 +0200
Remove superfluous null-checks before strdup/free
NULL checks were removed for following free functions:
- g_free "If mem is NULL it simply returns"
https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free
- g_slist_free(_full)? "NULL is considered to be the empty list"
https://developer.gnome.org/glib/stable/glib-Singly-Linked-Lists.html
- g_strfreev "If str_array is NULL, this function simply returns."
https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#…
- g_slice_free "If mem is NULL, this macro does nothing."
https://developer.gnome.org/glib/stable/glib-Memory-Slices.html#g-slice-free
- g_match_info_free "not NULL... otherwise does nothing"
https://developer.gnome.org/glib/stable/glib-Perl-compatible-regular-expres…
- dfilter_free defined in Wireshark code. Returns early when passed NULL
epan/dfilter/dfilter.c
They were also removed around calls to g_strdup where applicable:
- g_strdup "If str is NULL it returns NULL."
https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html#…
Change-Id: Ie80c2db89bef531edc3aed7b7c9f654e1d654d04
Reviewed-on: https://code.wireshark.org/review/23406
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=37ccb77a1ab845075465c2d86eea9e…
commit 37ccb77a1ab845075465c2d86eea9e8e21abc273
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 12:17:37 2017 +0100
Fix comment
Change-Id: Idebca52f2dbebbfc9edb132c3e8ca8d6e1ef79f4
Reviewed-on: https://code.wireshark.org/review/23926
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=9ac61baa862e4008ef8fd5326c9d86…
commit 9ac61baa862e4008ef8fd5326c9d8602f52f8ae9
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 11:25:17 2017 +0100
autotools: Make some installation hints more visible
Change-Id: I347f2983f5d8f11791d0ed0e51ba51de36b1d11f
Reviewed-on: https://code.wireshark.org/review/23925
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f053b082cde9e6fdc8e2bf789ca80b…
commit f053b082cde9e6fdc8e2bf789ca80bcad779b136
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 15 11:23:00 2017 +0100
Revert "autotools: dispense with some installation warnings/notes"
This reverts commit 79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db.
Change-Id: I019a037e399859b613456283e35cf81f5932b21c
Reviewed-on: https://code.wireshark.org/review/23924
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=79cdf3a8201ca27abf2bea29e9b9c6…
commit 79cdf3a8201ca27abf2bea29e9b9c6b3107ea5db
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 12:00:26 2017 +0100
autotools: dispense with some installation warnings/notes
These are not (easily) visible during installation and are better
suited for documentation anyway, as implied in the Makefile comments.
Change-Id: Id2581f6e8dfc05f1a6c0de918a0f687f025e6d12
Reviewed-on: https://code.wireshark.org/review/23910
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2ef359cdae0e816db112565899c1ca…
commit 2ef359cdae0e816db112565899c1ca0f349b4c5a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Oct 15 08:14:02 2017 +0000
[Automatic update for 2017-10-15]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ic0da94f81172212f1688ccb8213f3ee912256600
Reviewed-on: https://code.wireshark.org/review/23919
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=9d189c7e20de37f95b2ad70725ab65…
commit 9d189c7e20de37f95b2ad70725ab65b9bf863227
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Oct 14 18:43:58 2017 +0100
ssl: assume everything after CCS is encrypted
After ChangeCipherSpec, record fragments are encrypted. Use this strong
hint to fix misinterpreting the explicit nonce as a handshake message.
One edge case remaing unsolved though, if an encrypted Finished message
follows the CCS in the same TCP packet, then it could still be
misinterpreted.
Bug: 14117
Change-Id: Ie54bb5335f115d0fd8f05a13d1c826e3807cbbd3
Reviewed-on: https://code.wireshark.org/review/23900
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b5948a042a9925619a464cde7b0de2…
commit b5948a042a9925619a464cde7b0de245fab45594
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 11:55:29 2017 +0100
autotools: dispense with desktop-file-install
Change-Id: I20717e669709bde6c7b1ff7d10f928e2ec2cc263
Reviewed-on: https://code.wireshark.org/review/23909
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=5842fe4afe9b5feeeef8cd78a82fa3…
commit 5842fe4afe9b5feeeef8cd78a82fa32bcefc1a39
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 11:48:07 2017 +0100
autotools: dispense if-else shellcheck test
Change-Id: I1fd63442b27460ef21b2aaf4e3639a7d12c72c6e
Reviewed-on: https://code.wireshark.org/review/23908
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=d4b0fb5773c874e14be91f861eae24…
commit d4b0fb5773c874e14be91f861eae24fa60237fa6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 11:40:54 2017 +0100
autotools: remove unused variables
Change-Id: I1636358f76c7c230b8b464a17dddf520b723b36b
Reviewed-on: https://code.wireshark.org/review/23907
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=1dea7f3dc17de6ac189f8d185d2c4c…
commit 1dea7f3dc17de6ac189f8d185d2c4c4294fed950
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Oct 14 21:14:14 2017 +0100
Rename ui_util.h -> ws_ui_util.h
In preparation for possibly using AUTOUIC in CMake which treats "ui_*.h"
files specially, rename ui_util.h. No other changes.
Change-Id: Id026572c000b713ff0e9388dc7fff8d81d4df73e
Reviewed-on: https://code.wireshark.org/review/23916
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=af09db8bd3f0defb319df00fa69cd8…
commit af09db8bd3f0defb319df00fa69cd82044ac1007
Author: Christoph Wurm <wurm(a)elastic.co>
Date: Wed Jul 19 14:24:47 2017 +0000
Tshark: Optional packet summary for Elasticsearch
Currently, the Elasticsearch output exports the packet details and,
if -x is specified, the raw hex data.
This change adds the option of exporting the packet summary as well.
The default stays the same (packet details only), but now the existing
-P switch turns on printing of the packet summary. It also turns off
printing packet details, which can be turned back on with -V to print
both, and combined with -x to print all three: summary, details and
raw hex.
The packet summary is especially useful when exploring and visualizing
the data in Kibana, e.g. by displaying the summary "Info" field/column
in a table, as in the Wireshark GUI.
Change-Id: I2030490cfdd905572397bc3d5457ba49d805a5c4
Reviewed-on: https://code.wireshark.org/review/22716
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ddf65262562052ae132b2a4c9cf89b…
commit ddf65262562052ae132b2a4c9cf89b69ed9f1d5f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Oct 15 00:12:53 2017 +0100
FindPOD.cmake: look for pod2man.bat
Strawberryperl 5.26.1.1 installs "pod2man.bat" but not "pod2man"
so
find_program cannot locate it.
Change-Id: Iebfe2efec220085b15a4d73681da9cc7ea6a5360
Reviewed-on: https://code.wireshark.org/review/23913
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c4fbd43adedd0dcb3d7252efd34039…
commit c4fbd43adedd0dcb3d7252efd340391948196d54
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Oct 14 19:07:10 2017 +0100
configure: Fix PCAP_LIBS without pcap-config
Also remove XXX comment (answer: no, using package flags is preferable).
Change-Id: I05e7c0a40db9f1e1931b0fc585fed49cd7409526
Reviewed-on: https://code.wireshark.org/review/23901
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2ecc51f28f42644c655d2d86790b90…
commit 2ecc51f28f42644c655d2d86790b90f7a5ba81c7
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat Oct 14 21:04:14 2017 +0100
Some trivial fixes from running cppcheck.
The packet-per.c intialisation of ext_length is not really
needed - idx could be -1 with or without extension_flag
being set. But it'd be best not to have someone need to
think this through again.
Change-Id: If07f98ac7d7f2619149e35a2a0d75b765839a7ba
Reviewed-on: https://code.wireshark.org/review/23905
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c2f1ab1cbcc07af13935c037534148…
commit c2f1ab1cbcc07af13935c037534148b132aec46b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Oct 14 11:55:58 2017 -0700
Update comment.
Red Hat, at one point, provided a /usr/include/pcap/pcap.h without
bothering to also provide a /usr/include/pcap.h that linked to it or
included it, breaking source compatibility. That's what we're working
around when we search in both the top-level include directories and, if
they exist, pcap subdirectories of those directories.
libpcap 1.0 and later also put pcap.h in a pcap subdirectory, but also
provided a pcap.h in the top-level include directory that included
pcap/pcap.h, preserving source compatibility, so that's not the reason
we're searching in the top-level include directories and their pcap
subdirectories.
Change-Id: I8f427d46ce8293d278be9005ee623cda1ea5d691
Reviewed-on: https://code.wireshark.org/review/23902
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0943d6ee9da6d2691493600e82c6f4…
commit 0943d6ee9da6d2691493600e82c6f4d938ddb3b2
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sat Oct 14 13:59:35 2017 +0300
FP Fixed bug in heuristic dissector
Change-Id: I6960c7b9a2fa1b9f86e06df5036b4e0bcf1dcfe0
Reviewed-on: https://code.wireshark.org/review/23898
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9bba3866ffc0d382d511d298d2460c…
commit 9bba3866ffc0d382d511d298d2460c618bfa6c0d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 24 02:30:08 2017 +0100
CMake: Allow user build flags to override default build flags
Autotools has the very useful feature by design of allowing the user
to override the default build flags (you break it you keep it).
Apparently CMake applies COMPILE_OPTIONS target property after
CMAKE_{C,CXX}_FLAGS so that doesn't work here. Prepend our flags to those
variables instead to make it work then.
Specific target flag overrides can still be added with COMPILER_OPTIONS
(e.g: generated files with -Wno-warning) but this is less effective and
then we're back at the point where this overrides user flags. It's less
of a concern though.
Change-Id: I44761a79be4289238e02d4e781fef0099628817b
Reviewed-on: https://code.wireshark.org/review/23675
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=68ef8797118b6015ac47130c789cd9…
commit 68ef8797118b6015ac47130c789cd93e73b03597
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Oct 13 14:01:56 2017 +0200
docsis: fix
'docsis_vsif.gex.sav.spr.static_prefix_address/.gex.imja.imja_ssr_source_prefix_address/.imja.imja_ssr_group_prefix_address'
exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4
Change-Id: I7c978870eb3cc54e718fe3c810f7b4e7f6ea67c9
Reviewed-on: https://code.wireshark.org/review/23897
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1e0dcf8dafafd2261c863471e191c6…
commit 1e0dcf8dafafd2261c863471e191c65c768e02ea
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Oct 13 14:00:38 2017 +0200
docsis: fix
'docsis_vsif.gex.extended_cmts_mic_hmac_type' exists multiple times with NOT
compatible types: FT_BYTES and FT_UINT8
Change-Id: Ic3a0f7f6edf5a28ffde6703276d4747d138081c7
Reviewed-on: https://code.wireshark.org/review/23896
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=337f49243faeab6796c12e43492882…
commit 337f49243faeab6796c12e434928823606dda195
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Oct 13 00:28:50 2017 -0400
Add ptvcursor APIs that return the values it retrieves
ptvcursor_add_ret_uint
ptvcursor_add_ret_int
ptvcursor_add_ret_string
ptvcursor_add_ret_boolean
Change-Id: I41fa91b1ab805778d34a61215830b12a1331e864
Reviewed-on: https://code.wireshark.org/review/23895
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=32d31e55ae7ed3b2b3e184e64fa82f…
commit 32d31e55ae7ed3b2b3e184e64fa82f1cda5604c4
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Oct 11 22:19:56 2017 +0000
WiMAX ASN CP: Leak less memory.
Replace some g_new()s, g_strdup()s and GArrays used in prefix
registration with their epan_scoped wmem equivalents. This reduces
the amount of memory we leak so that we come in below the Valgrind
fuzzer's current threshold (102400).
Bug: 14106
Change-Id: I7308ac89465316c06773552253dabc876b6c2425
Reviewed-on: https://code.wireshark.org/review/23891
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f3ba040479f35e8b6f630553159b1b…
commit f3ba040479f35e8b6f630553159b1b799fbae665
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Oct 12 12:58:18 2017 -0700
win-setup: Don't bother downloading UPX.
We haven't used UPX since g85eec7f603 (2014). Don't bother downloading it.
Change-Id: Id86ca6ae8f29adab3eb40a2ea3bd1de5ff45d868
Reviewed-on: https://code.wireshark.org/review/23894
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=99fd0cfb05a465d7846f1d1b65086f…
commit 99fd0cfb05a465d7846f1d1b65086fa5f35fa297
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Tue Oct 10 21:44:32 2017 +0100
FTP: setup conversation properly for PASV sessions
Also keep track of last frame of data response, and work out duration of
ftp-data stream.
Change-Id: I460aaa5c8736e044410eab428707651cede39d7e
Reviewed-on: https://code.wireshark.org/review/23880
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5ad0579bebcccfa3fce6549b1b7f98…
commit 5ad0579bebcccfa3fce6549b1b7f986681e2bea2
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 12 11:45:31 2017 +0200
IEEE 802.11: fix a segmentation fault introduced in gd6eda2a3
Bug: 14114
Change-Id: Ie377b1b3ccf29014935b9e5796567cdb8bb466a3
Reviewed-on: https://code.wireshark.org/review/23893
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2a8ab239bdcec408971b48b3c6ee08…
commit 2a8ab239bdcec408971b48b3c6ee08c68c8798e2
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Oct 12 10:48:32 2017 +0200
[TCAP] Make "tid" a generated item rather than hidden to make it obvious
that it exists.
Change-Id: I1986b7678193f3b4c9ed8cabff7e411cef5bf185
Reviewed-on: https://code.wireshark.org/review/23892
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da8dbd247157caea874320be6e182b…
commit da8dbd247157caea874320be6e182beb584e57bf
Author: Jorge Mora <jmora1300(a)gmail.com>
Date: Tue Oct 10 09:41:27 2017 -0600
infiniband: add PSN and RETH DMA length to infinibandinfo struct
Expose the PSN (packet sequence number) and the RETH DMA length
to protocol's dissectors.
Change-Id: Ied53a8964d7cd5c3d148ec7c7642017951e56118
Reviewed-on: https://code.wireshark.org/review/23886
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b363e46ad48a8a2b340dd6792fdce1…
commit b363e46ad48a8a2b340dd6792fdce1800a8cee44
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Oct 11 21:31:42 2017 +0200
IEEE 802.11: add missing breaks
Change-Id: Ie26b0c869a778f7e27cb6d944c2e32ced0d3337e
Reviewed-on: https://code.wireshark.org/review/23889
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9551aca9a685e97a03d58eb63e4b79…
commit 9551aca9a685e97a03d58eb63e4b791416ba4c63
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Oct 11 12:31:16 2017 -0700
Add --print as an alias for -P, to match tcpdump.
tcpdump just got a --print option, which causes packet information to be
printed even if the raw packets are being saved to a file with -w. We
have -P for the same purpose; make --print another name for it.
While we're at it:
document --help and --version;
just speak of -P/--print as causing printing even of the packet
details, even though -V forces printing with -w, for consistency
with how --print is documented for tcpdump;
fix the description of -h/--help.
Change-Id: Idf650a202a09a2d1682edbd9d76123f1b1412b55
Reviewed-on: https://code.wireshark.org/review/23888
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b2467fddb1d83a0667970968493a9d…
commit b2467fddb1d83a0667970968493a9dad1dfb0be1
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Oct 11 08:54:12 2017 -0700
ProtoBuf: Remove an unused variable.
Remove protobuf_message_direction_type:
../epan/dissectors/packet-protobuf.c:125:20: error: unused variable
'protobuf_message_direction_type' [-Werror,-Wunused-const-variable]
VALUE_STRING_ARRAY(protobuf_message_direction_type);
^
Have dissect_one_protobuf_field return a gboolean while we're here.
Change-Id: I5d9d2e3414b5668ca26d5c0a450225c3cdf5da56
Reviewed-on: https://code.wireshark.org/review/23887
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=95c50e3dd766e919953def30f65ba5…
commit 95c50e3dd766e919953def30f65ba5496226a660
Author: Jason Uher <jason.uher(a)jhuapl.edu>
Date: Wed Oct 4 11:46:00 2017 -0400
Decode SNR in Compressed MIMO Beamforming report per ieee80211at_2013 sections
8.4.1.{29,48}
Change-Id: I4f3af7e06169461a15507ed8ecce8f15075b9667
Reviewed-on: https://code.wireshark.org/review/23835
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6ef693dec1fd189d0995d8ad6a06c2…
commit 6ef693dec1fd189d0995d8ad6a06c29c05823ce8
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Oct 11 10:57:43 2017 +0200
[Solaredge] Fix SuSE 11.4 build packet-solaredge.c:1013: error:
declaration of rand shadows a global declaration
Change-Id: I98f4edb14cd241bd709d50e8ac9151448773a658
Reviewed-on: https://code.wireshark.org/review/23884
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8fbad3dd56b45874463f9d811b8000…
commit 8fbad3dd56b45874463f9d811b80006314413c0e
Author: Huang Qiangxiong <qiangxiong.huang(a)qq.com>
Date: Mon Jul 31 15:26:57 2017 +0000
Start of adding Protobuf (Protocol Buffers) dissector.
1. Protobuf dissector supports the almost all basic protobuf types of
varint, sint, string, and so on.
2. Protobuf messages are not self-described protocol, for example,
varint in protobuf may be int32, int64, uint32, uint64, sint32,
sint64, bool or enum. Currently dissector will dissect field without
detail definition in common way, for numeric field it show uint32 or
uint64, for length-delimited field it just show as bytes. But user
turn the try_dissect_all_length_delimited_field_as_string or
show_all_possible_field_types options on, that dissect will show all
possible value for each field according to wire type. (for example,
a numeric field will parsed in int32, uint32, sint32, sint64 and so
on).
Ping-Bug: 13932
Change-Id: Idfe49307b1c84fe461603756f75daeb3e410a905
Reviewed-on: https://code.wireshark.org/review/23814
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3444d41fd0d425aca79c9eeaadff1a…
commit 3444d41fd0d425aca79c9eeaadff1a7f647e7b13
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Oct 10 10:24:28 2017 +0200
[GSM SMS] If the digits are E164 International number add an E.164
filter.
Change-Id: Idcfa53d1db9e9f7b5501ca92592fb0fa0790ffe9
Reviewed-on: https://code.wireshark.org/review/23873
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=698aa24165d0a51b06117d6d9133c0…
commit 698aa24165d0a51b06117d6d9133c04839fbe40e
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Oct 9 15:45:43 2017 -0400
Change FI_VARINT to account for FI_BITS_XXX flags
FI_BITS_XXX were using bits 5-15 of the field_info->flags bitmask.
Move FI_VARINT to be outside of that range.
Change-Id: I92efcb5644cdbb562537d2813b611e583315874b
Reviewed-on: https://code.wireshark.org/review/23871
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6b466a9e4fccae694c2ae6607ad5c5…
commit 6b466a9e4fccae694c2ae6607ad5c5b28dfff303
Author: Felix Ruess <felix.ruess(a)roboception.de>
Date: Mon Oct 9 17:01:24 2017 +0200
[gvcp] fix extendedblockids check and resend cmd parsing
Change-Id: I9e0314ae2e975a1c50cfaf2b00e469ad7f640357
Reviewed-on: https://code.wireshark.org/review/23866
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d72a18faad55d6f47af47acfb9d927…
commit d72a18faad55d6f47af47acfb9d9270015bad2e2
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Oct 9 15:10:27 2017 -0700
Fuzz: Limit the number of packets we process with Valgrind.
Estimating the effort required to process a capture based on its size
isn't very reliable. Instead of rejecting files that are too large, just
limit Valgrind fuzzing to the first 100,000 packets in each file. This
should fix a timeout issue we're seeing on the master fuzzer.
Change-Id: I0117735341d3a183c6131f5f05dbd1d559fc4b3f
Reviewed-on: https://code.wireshark.org/review/23872
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=95ce7daf65beb1864cbcb7bd984952…
commit 95ce7daf65beb1864cbcb7bd984952eabb0308da
Author: Jorge Mora <jmora1300(a)gmail.com>
Date: Mon Oct 9 10:54:37 2017 -0600
infiniband: fix OpCodeMap string for UC_RDMA_WRITE_MIDDLE
Make string mapping for UC_RDMA_WRITE_MIDDLE consistent with
all other mappings in the OpCodeMap table.
Remove extra blank lines in the OpCodeMap table.
Change-Id: Ifb3e242a89458103f3db3b5718d5d939dffb6dae
Reviewed-on: https://code.wireshark.org/review/23867
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e8dbf386d8a830d822ff5f2857c633…
commit e8dbf386d8a830d822ff5f2857c63338a7998abb
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Oct 9 12:19:02 2017 -0700
Fuzz: Write memory leak info to the error log.
When we exit due to excessive memory leaks make sure we say so in the
error log.
Change-Id: I03f60271f3e4bb467fbaa5b9ac17431eed96f300
Reviewed-on: https://code.wireshark.org/review/23870
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=3bfb9aabe0e525ad76251190289c1e…
commit 3bfb9aabe0e525ad76251190289c1ea3417fb1aa
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Oct 9 12:52:13 2017 +0200
[Diameter 3GPP] Fix bitmask in feature list B26 and add B27.
Change-Id: I0f035da3f5305ce6935c79e0c1b5f63f955d099d
Reviewed-on: https://code.wireshark.org/review/23865
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d8d60b4980882e37b73df3bfead8c2…
commit d8d60b4980882e37b73df3bfead8c2b09daba091
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Sep 23 09:05:21 2017 -0400
Add ENC_VARINT_PROTOBUF
Encoding of integer datatypes of Protocol buffers
https://developers.google.cn/protocol-buffers/docs/encoding
Change-Id: I9f6d65ddca099c15c0634984e9394131f98d35a9
Reviewed-on: https://code.wireshark.org/review/23813
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6a0e2a7916a689dfb642b004d07f6…
commit c6a0e2a7916a689dfb642b004d07f6fc76fd04f3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 5 21:39:10 2017 +0200
packet.c: fix a control flow issue reported by Coverity (CID 1418671)
Let's perform the check before potentially breaking the loop.
While we are at it, let's update the test to remove the last layer so as to
match the one used to add it.
Change-Id: I5807219de75c4e2c23b9435d6271ad60aec45783
Reviewed-on: https://code.wireshark.org/review/23844
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1df866d99e99346bf61d0f7c496000…
commit 1df866d99e99346bf61d0f7c49600000048fa393
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Oct 8 11:54:54 2017 +0200
ftypes(.h): fix indent (use tabs)
Change-Id: Ic824910d4ec8c9987e8deec8d61809feb9849b9b
Reviewed-on: https://code.wireshark.org/review/23863
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=14107eec716f5f438273018ec0ddad…
commit 14107eec716f5f438273018ec0ddad9638934bf7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Oct 8 11:59:06 2017 +0200
proto(.h): fix indent (use spaces)
Change-Id: I029a9db40c8ca5a67bb1db69c50d8f08b7f59ab2
Reviewed-on: https://code.wireshark.org/review/23864
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6628fdf54b635a216fdd83eb7d4f39…
commit 6628fdf54b635a216fdd83eb7d4f392512073787
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Oct 8 08:13:30 2017 +0000
[Automatic update for 2017-10-08]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I700244d357bcb8d37866b296ea7c6bb671f983af
Reviewed-on: https://code.wireshark.org/review/23859
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=ddb754243e6ba3290ed098d15834a0…
commit ddb754243e6ba3290ed098d15834a0b9d2d65d50
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Oct 7 22:53:43 2017 +0200
X2AP: fill gaps in extended value string array
Change-Id: I6d8594de78dd46d679072cc17211e940155f0012
Reviewed-on: https://code.wireshark.org/review/23858
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=eb5b2a211d5065af21e9949c81d8d9…
commit eb5b2a211d5065af21e9949c81d8d9ce6920ba12
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Oct 7 22:42:48 2017 +0200
S1AP: upgrade dissector to v14.4.0
Change-Id: I1124a691ec004507e6e144038b13f9d432d88c5f
Reviewed-on: https://code.wireshark.org/review/23857
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=750eb3637e360b8a8e0ec7665d8165…
commit 750eb3637e360b8a8e0ec7665d8165b2ed4baa5d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 3 10:39:06 2017 +0000
tap-flow (ui): fix no previous prototype for ‘register_tap_listener_flow’
[-Wmissing-prototypes]
Change-Id: I6031600ee3d764a7b2690ff88dbbfb01a1d6244b
Reviewed-on: https://code.wireshark.org/review/23824
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=53706c80d61003d05dc0116d4a171d…
commit 53706c80d61003d05dc0116d4a171d554e04dbe4
Author: Jorge Mora <jmora1300(a)gmail.com>
Date: Fri Oct 6 09:40:01 2017 -0600
RPC-over-RDMA: fix write list chunk count
Add the chunk_size to the offset to get the correct write list
count, this issue was introduced by the fix for Bug: 13558
Change-Id: I306a9c0c9d601f7bdf4cc0e49eacd5466a6adb89
Reviewed-on: https://code.wireshark.org/review/23851
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=471736ece003e80bb47e9a9b29099d…
commit 471736ece003e80bb47e9a9b29099d7ab6200d04
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Thu Oct 5 10:34:18 2017 +0200
DOCSIS: added vsif general extension dissection
Change-Id: Ic61815b967fac412fb1a324c470ff5171b97acbb
Reviewed-on: https://code.wireshark.org/review/23840
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6172627534168bb31415fa31a7cecd…
commit 6172627534168bb31415fa31a7cecdb15bcca4ab
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Oct 4 16:27:08 2017 -0700
Make osx-app.sh a configured file and remove Autotools targets.
Rename osx-app.sh to osx-app.sh.in and add the version to the plugin
path at configure time.
Instead up updating Autotools accordingly just remove the macOS
packaging targets. gf61c381b5a removed support for Autotools in
osx-app.sh and if anyone wants to build macOS packages I'd prefer that
they use the same toolchain as the buildbot.
Change-Id: Ide5205265bf8859a85b1afab68fa8f8285952bd3
Reviewed-on: https://code.wireshark.org/review/23839
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ae794fc5f24e893b20f4161ac3cfb2…
commit ae794fc5f24e893b20f4161ac3cfb20e018e9b96
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 5 22:18:32 2017 +0200
M3AP: avoid appending m3ap multiple times to frame.protocols field
Change-Id: Iff7cc711ae1fba0a7c239dec47d83d5b4ac84e2c
Reviewed-on: https://code.wireshark.org/review/23849
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fa8fd247cf7e038ee3cfcac6ce13c9…
commit fa8fd247cf7e038ee3cfcac6ce13c97542bf3abc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 5 22:15:36 2017 +0200
M2AP: avoid appending m2ap multiple times to frame.protocols field
Change-Id: I4e9fee5ae98cd776d168006c4119aff5767dfa16
Reviewed-on: https://code.wireshark.org/review/23848
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0a4c646cbc9df5d16a5041b7b4d94a…
commit 0a4c646cbc9df5d16a5041b7b4d94a98955e6fff
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 5 22:12:53 2017 +0200
LPPa: avoid appending lppa multiple times to frame.protocols field
Change-Id: I89557fc4ee5bce4802cc2b34e020d567ab34c79b
Reviewed-on: https://code.wireshark.org/review/23847
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=155f8d5288b50badc560dc87a10108…
commit 155f8d5288b50badc560dc87a1010874cf84f57a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 5 22:09:48 2017 +0200
X2AP: avoid appending x2ap multiple times to frame.protocols field
Change-Id: I521ffa43ff81b9a41f8e3f01a0d39e18f590a050
Reviewed-on: https://code.wireshark.org/review/23846
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=82acd85bcca0a79cd04ddfab40eec1…
commit 82acd85bcca0a79cd04ddfab40eec1112e507486
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Oct 5 22:08:26 2017 +0200
S1AP: avoid appending s1ap multiple times to frame.protocols field
Change-Id: Ide44391bf18d2f301f32cd6a65b246e9a1cc5891
Reviewed-on: https://code.wireshark.org/review/23845
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=561914bd20913407f6344e4081c2e4…
commit 561914bd20913407f6344e4081c2e483d3e53bc4
Author: Vladimir Rutsky <rutsky(a)google.com>
Date: Thu Oct 5 11:09:03 2017 -0400
gRPC: Several bugfixes
1. fix returing new offset value
dissect_grpc_message() is called with the offset to the message that
needs to be parsed and returns new offset (e.g. offset to the next
message in stream).
Before this change length of the parsed message (including 5 bytes
header) were returned which was incorrect and may lead to infinite
loops.
2. fix reported length in case of invalid packet
3. fix typo in comment: "streaam"
Change-Id: I577cdcc0203a87122a4d8d8c660f43295609e8aa
Signed-off-by: Vladimir Rutsky <rutsky(a)google.com>
Reviewed-on: https://code.wireshark.org/review/23843
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5a99830e211901e498e036b9adb00b…
commit 5a99830e211901e498e036b9adb00b0c33c7904d
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Sun Oct 1 00:52:48 2017 +0200
Qt: Free dynamic menu actions at shutdown
Some menu actions registered at startup are not freed at shutdown
making Valgrind complain. Fix by clearing the lists holding them
and making sure all actions have a parent to free them.
Bug: 14071
Change-Id: I8d99d062d394a7262b0f9b7ddea4ed71049636ac
Reviewed-on: https://code.wireshark.org/review/23793
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=867e6f0e006ae633ab7928a20919e0…
commit 867e6f0e006ae633ab7928a20919e0011bc0c63f
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Tue Sep 26 13:14:02 2017 +0200
qt: Fix leaked dialogs
Some dialogs are allocated on heap but not freed when the dialog
boxes are closed. This means one dialog instance is leaked each
time opened/closed. Also dialogs being subclasses of
GeometryStateDialog means they might lack a parent reference and
are not automatically freed on application shutdown either.
Fix these leaks by letting the dialogs automatically destroy
themselves on close (via WA_DeleteOnClose).
Capture filter, display filter and capture interfaces dialogs are
also leaked on application shutdown. These dialogs are protected by
a NULL check that at least prevent multiple instances. Though
none of them are freed on application shutdown. Fix leaks by
freeing when main window is destroyed.
Bug: 14071
Change-Id: I8c5c5a75ad3c89abb5996941875ba5d616a22d9c
Reviewed-on: https://code.wireshark.org/review/23747
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3c9f440ac60ba83f155a89a851f9a1…
commit 3c9f440ac60ba83f155a89a851f9a1d3cc947f8d
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Oct 4 22:41:19 2017 +0200
sharkd: export field filter string.
This extra parameter allows to use wireshark functionality like: prepare as filter,
and also apply quick filter in protocol tree (for instance show only TCP protocol
fields: tcp.),
Change-Id: I1f380b79e3802e6aaf646fdd4770c903ee9f3781
Reviewed-on: https://code.wireshark.org/review/23837
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7219f6467feb8ce767689aa456fe8f…
commit 7219f6467feb8ce767689aa456fe8ff2f711e22a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Oct 4 15:58:31 2017 -0700
HTTP: Add http.file_data based on the captured length.
Switch the file_data handling to use the captured length. In a test
capture here this lets us call the GIF dissector in a truncated packet.
Fixup a variable type and some whitespace.
Change-Id: I21b64519ad84f730e1412115035125c2bf1f361c
Reviewed-on: https://code.wireshark.org/review/23838
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8804ddbe2a35a9e8bc1340912e7347…
commit 8804ddbe2a35a9e8bc1340912e73479cb2f31390
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Apr 27 16:24:54 2017 +0200
gsm_sim: fix conflicting entry in its value_string
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
24384 is at indices 72 (DF.EIA/TIA-533) and 78 (DF.WLAN))
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
28421 is at indices 31 (EF.LP) and 80 (EF.LI))
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
28472 is at indices 37 (EF.SST) and 89 (EF.USI))
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
28481 is at indices 41 (EF.PUCT) and 96 (EF.PUCI))
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
28489 is at indices 23 (EF.SDN) and 103 (EF.SIN))
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
28494 is at indices 28 (EF.EXT4) and 107 (EF.EXT5)
Field 'File ID' (gsm_sim.file_id) has a conflicting entry in its value_string:
28495 is at indices 29 (EF.ECCP) and 108 (EF.CCP2))
Change-Id: I4bde0cc644131e9b088fca07837fa1b909f30f44
Reviewed-on: https://code.wireshark.org/review/21381
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1961297a55f0b7a2ff6acc1ab7909d…
commit 1961297a55f0b7a2ff6acc1ab7909d50e4b80f70
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Oct 4 08:12:23 2017 +0200
sharkd: check if JSON value is string or primitive (true/false/null/number).
Add extra check for token type, previously it was possible to pass for example:
{"columns":["one","two","three"]}. Such format
is not supported.
Change-Id: I6ac2e3ca9eba868cd72ed886ad40745ebbc43d73
Reviewed-on: https://code.wireshark.org/review/23834
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ea6e4b577f08f88e0d5cabb7cb38e1…
commit ea6e4b577f08f88e0d5cabb7cb38e17b236e513a
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Sep 27 22:24:54 2017 +0200
sharkd: support for user column-set in "frames" request.
Change-Id: If6a10cc252f2ad362ba3a91318cedd15d954db2b
Reviewed-on: https://code.wireshark.org/review/23768
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=70996dc669305da1c5f7a305d67b59…
commit 70996dc669305da1c5f7a305d67b5976fde75073
Author: cheloftus <cheloftus(a)gmail.com>
Date: Wed Jun 28 22:52:41 2017 +0100
Qt: add preference to restore display filter after Follow Stream
Added new user preference 'restore_filter_after_following_stream',
defaults to false.
When true, the current display filter is restored after following a stream.
Change-Id: I153107761003658c6d7f1464711da7b3adeb60a8
Reviewed-on: https://code.wireshark.org/review/22455
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0553cda6dab3f69ccd32adb6d60723…
commit 0553cda6dab3f69ccd32adb6d60723e9baf56d4a
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Wed Sep 27 22:03:43 2017 +0200
Instroduce col_finalize(), to allow creating column_info based not only on
preferences.
Change-Id: I417e6accff3390a9b1839cd6b44266b76aa754c3
Reviewed-on: https://code.wireshark.org/review/23767
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f61c381b5a019b3fc8756fd5c19989…
commit f61c381b5a019b3fc8756fd5c199894886eb2492
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Oct 3 15:44:38 2017 -0700
Remove unused code from osx-app.sh
Remove Autotools-specific code from osx-app.sh. The official builders
have used CMake for a while and as far as I know no one else uses our
packaging scripts.
Change-Id: I6fc20114b42e10dacc69346c379055b68184b85c
Reviewed-on: https://code.wireshark.org/review/23833
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3cddb369d57e8ef7b310edea7ba5d7…
commit 3cddb369d57e8ef7b310edea7ba5d7b2be19e777
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Oct 3 02:54:28 2017 +0100
TLS: enable OCSP status dissection for TLS 1.3 and DTLS
In TLS 1.2, the "certificate_status" extension in the CH would result in
a response in the CertificateStatus handshake message. In TLS 1.3, the
response appears in a SH extension instead. Refactor the code to use
ssl_add_vector and hook it up with SH extensions dissection.
Do not stop dissection on a non-empty Responder ID list. Remove
misleading "CertificateStatus" tree item, it only covered the
"OCSPResponse" vector, now its two children (just OCSP Response Length
and the OCSP Response tree) are displayed directly.
Enable DTLS support, the spec does not forbid it and there is a user:
https://mta.openssl.org/pipermail/openssl-users/2016-August/004306.html
Tested with tls-sct.pcap (bug 13372) which now shows one tree item less
and tls13-18-cert-sct-ocsp.pcap (bug 12779) which now dissects the OCSP
response in the Certificate Extensions.
Change-Id: I2ccde84cb1e3bcb1bc47676eadc5cb542248cd92
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23819
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=064038bb1bf12d992e8083517f37ae…
commit 064038bb1bf12d992e8083517f37ae2acfa782a8
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Tue Oct 3 11:44:42 2017 +0200
DOCSIS: added dissection of IPv6 classifier TLV
Change-Id: I49a920c2d93dbbc0ae9f8152922485a14225ea9e
Reviewed-on: https://code.wireshark.org/review/23822
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5826a8532ed4e2a0387aa8a2857bca…
commit 5826a8532ed4e2a0387aa8a2857bca62b8d2371f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Oct 3 15:28:40 2017 -0700
macOS: Fixup app bundle rpathification.
rpathify_dir is not recursive so the plugin path fix in g94af9724d1
wasn't sufficient. Make sure $pkgplugin is set to the versioned plugin
subdirectory so that both rpathification and code signing work.
Find the Qt frameworks directory using qmake while we're here. This
should be more reliable than calling pkg-config (which doesn't work on
my laptop).
Bug: 14096
Change-Id: I0196015f849fd27994a439359cddd88c21106fde
Reviewed-on: https://code.wireshark.org/review/23832
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=2c89e6c448101de562844ac6ca0fa0…
commit 2c89e6c448101de562844ac6ca0fa0890964321c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Oct 3 22:12:21 2017 +0200
E.212: update list to Operational Bulletin No. 1133 (1.X.2017)
Change-Id: I954d18107a5743f148388cc2356458aeddca162f
Reviewed-on: https://code.wireshark.org/review/23828
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dcf7ca7abd57c231b02881a4a2b9cc…
commit dcf7ca7abd57c231b02881a4a2b9cc223b8db99a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 3 10:40:34 2017 +0000
interface_toolbar (Qt): fix commas at the end of enumerator lists are a C++11
extension [-Wc++11-extensions]
Change-Id: I36ea982656e45855b357e071bcca7c6f3d12d03f
Reviewed-on: https://code.wireshark.org/review/23825
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ec485f3f52f76814146b3f032b9b28…
commit ec485f3f52f76814146b3f032b9b28549fe61c57
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 3 10:41:23 2017 +0000
wimax(-int.h): no newline at end of file [-Wnewline-eof]
Change-Id: I863fe195f314301e2ecd92638e42a0f11dd2af9b
Reviewed-on: https://code.wireshark.org/review/23826
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1d29691bb6e0290ae61df63004eb33…
commit 1d29691bb6e0290ae61df63004eb3389dfb3f637
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 3 10:42:55 2017 +0000
prefs_filter_expressions (GTK): fix no newline at end of file [-Wnewline-eof]
Change-Id: Icf660a4c27ff169576115905882cad1af547b99f
Reviewed-on: https://code.wireshark.org/review/23827
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c09c6531ba7b434c4b0a7f1f9ee13f…
commit c09c6531ba7b434c4b0a7f1f9ee13ffc3ad4dc8d
Author: Gregor Jasny <gjasny(a)googlemail.com>
Date: Tue Oct 3 11:15:47 2017 +0200
conversation_table: Export all functions for external plugin use
Change-Id: I5e42ceb5013a9ec629845953051cdeaf8b94112d
Reviewed-on: https://code.wireshark.org/review/23821
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=27c7aa38aa6d96aa9b3bfb889330cb…
commit 27c7aa38aa6d96aa9b3bfb889330cba107836c1f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 3 10:36:59 2017 +0000
infiniband: fix ISO C does not allow extra ‘;’ outside of a function [-Wpedantic]
Change-Id: I892e7a92c231293f1977cba4513b49afda8c676c
Reviewed-on: https://code.wireshark.org/review/23823
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2777003e121a5d764b54c62590e7ce…
commit 2777003e121a5d764b54c62590e7ceb46ae2c157
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 29 19:49:51 2017 +0100
Add version check for plugin compatibility
Only plugins built for the same feature release (X.Y) are assured binary
compatibility. Make sure we don't try to run unsuitable code and, if so,
warn the user. This might happen for example if the user manually copies
a binary plugin to the wrong folder, intentionally or by accident.
I'm using "release version" to loosely mean not a patch release
(i.e: a feature release).
Change-Id: I896e9cbbd2d3843623fff6af8ef51002ec06f1f8
Reviewed-on: https://code.wireshark.org/review/23807
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=d477ea35a946c2935974edb3fea45c…
commit d477ea35a946c2935974edb3fea45cf23513a03c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Oct 3 08:03:26 2017 +0200
nfs: fix typo on new xattrs attribut
Change-Id: I4872334e73df8a71690400e7f0690eecc02d8270
Reviewed-on: https://code.wireshark.org/review/23820
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5d672c469d2218a2f845e1eadccf2b…
commit 5d672c469d2218a2f845e1eadccf2b581365a370
Author: Tom Haynes <loghyr(a)primarydata.com>
Date: Mon Oct 2 17:12:00 2017 -0700
nfs4: Add ACCESS_MASK support for xattrs
See: https://datatracker.ietf.org/doc/draft-ietf-nfsv4-xattrs/
Change-Id: Ia9238bf96562f95eb56d25a1f8051b4e4fca5ba4
Signed-off-by: Tom Haynes <loghyr(a)primarydata.com>
Reviewed-on: https://code.wireshark.org/review/23817
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e670f9c80be87e4b81f4cd4dafc3d3…
commit e670f9c80be87e4b81f4cd4dafc3d3dd9ea183e9
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Tue Oct 3 02:42:19 2017 +0100
TLS13: fix SCT dissection since draft -17
Since draft -17, SCT has moved from EE to Certificate extensions.
Decryption failed for a boringssl test suite capture because it tests
with an unknown version and a small SerializedSCT which resulted in a
malformed packet exception. Ignore the SCT following RFC 6962, sect 3.3.
Change-Id: I894d51447f28ca121ea7f3fcef2b711a0debc1fb
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23818
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=83cb6ff625a403b6d505c3b2f0fc23…
commit 83cb6ff625a403b6d505c3b2f0fc23cebbd479bd
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Oct 2 22:32:23 2017 +0200
GTPv2: fix out of bounds access when decoding Private Extension IE
Bug: 14095
Change-Id: I85e481be269ee3103209668e2c924faef6f5b1ec
Reviewed-on: https://code.wireshark.org/review/23816
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=96c07c6471176082b8aff7ec6df650…
commit 96c07c6471176082b8aff7ec6df650aebaaace0e
Author: Eugene Adell <eugene.adell(a)gmail.com>
Date: Sun Oct 1 05:21:38 2017 -0700
HTTP: fix for ICY responses which were displayed as HTTP requests
Bug: 14091
Change-Id: Ic8d37e29f02dc9751c60e827aa773d915cabc088
Reviewed-on: https://code.wireshark.org/review/23802
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a6dec130a963753bd7431f71394b0f…
commit a6dec130a963753bd7431f71394b0f527147006d
Author: Birol Capa <birol.capa(a)siemens.com>
Date: Mon Oct 2 09:49:00 2017 +0300
PROFINET: Fix undecoded signal value in DCP Set Request.
According to specification, when suboption is CONTROL,
signal value is FLASH_ONCE.
Change-Id: I942579cdf3d642e636d02b778ffaad99022678e3
Reviewed-on: https://code.wireshark.org/review/23812
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ab01a1eab1c56e131171ece6624fec…
commit ab01a1eab1c56e131171ece6624fec9797fb42d0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Oct 2 08:10:29 2017 +0200
QUIC: rename Stream ID Needed by Stream ID Blocked (draft-06)
Change-Id: I9aba424fc9df5030befac31373dc759249d936c5
Reviewed-on: https://code.wireshark.org/review/23810
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=06548c905ee7346c4b00ded643e5ba…
commit 06548c905ee7346c4b00ded643e5bae2d849bdaa
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Oct 2 08:05:14 2017 +0200
QUIC: Add draft-06 version (value_string)
Change-Id: Iabfa1045a7c8db3b154a9f827f2a2f130bb4fae4
Reviewed-on: https://code.wireshark.org/review/23809
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6a083c125631016302d8313488f942…
commit 6a083c125631016302d8313488f9426710845f56
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Fri Sep 29 13:11:59 2017 +0200
ZCL Events Dissector: Increase number of subtrees
Increase number of subtrees for PublishEventLog so we can dissect
the 100 event logs that are specified as the maximum
in the Great Britain Companion Specification (GBCS).
Change-Id: I23b1729abd58168772e1937e1f52552fab2187a7
Reviewed-on: https://code.wireshark.org/review/23782
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e3ea990450aee7d9ef97fa8690773d…
commit e3ea990450aee7d9ef97fa8690773db196c0880b
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Oct 1 20:15:02 2017 +0200
btle: Add preference to detect retransmission
In cases with missing frames, frames with incorrect CRC or unknown
direction it must be possible to turn off detecting retransmissions.
Change-Id: Ia5a1194004f768986b939b4195a21c6e7a2ac4c8
Reviewed-on: https://code.wireshark.org/review/23803
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1f8e7c45e12b33619fb123aeee1bf9…
commit 1f8e7c45e12b33619fb123aeee1bf9e238cf0304
Author: Christoph Wurm <wurm(a)elastic.co>
Date: Sun Sep 3 05:33:12 2017 +0000
Tshark: Prepare Elasticsearch output deduplication
Refactors the ES output to use hash tables and lists in preparation
of deduplicating fields. ES 5.x allows those, but will only store
the last instance and discard any other without warning.
ES 6.x altogether refuses to accept documents containing
duplicate fields.
This change should not change the output of Tshark in any way.
A subsequent change will introduce the actual deduplication.
Bug: 12958
Change-Id: I329ef0878e33b42d65a53bcac977429d87cde3ca
Reviewed-on: https://code.wireshark.org/review/23042
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ed49b3dcfe51b8b18d8834f7fc8e0e…
commit ed49b3dcfe51b8b18d8834f7fc8e0e8e3c49237f
Author: Erik de Jong <erikdejong(a)gmail.com>
Date: Fri Sep 22 11:24:05 2017 +0200
Dissector: SolarEdge inverter monitoring protocol
Adds support for the SolarEdge inverter monitoring protocol. Based on the work
done by https://github.com/jbuehl/solaredge
bug: 14079
Change-Id: Ia0102c057e4cd27c187b01c7fd28053678f22727
Reviewed-on: https://code.wireshark.org/review/23653
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f54d07b01977bacfde2a61d2fd5019…
commit f54d07b01977bacfde2a61d2fd5019b3a5a26537
Author: Darien Spencer <cusneud(a)mail.com>
Date: Fri Sep 29 17:58:53 2017 +0300
FP: Add heuristic FACH 1 dissector
Note that FACH 1 and FACH 2 are official terms as documented in TS 25.944
Change-Id: I1afbd99d5603df442dce903ad08ba071961f0586
Reviewed-on: https://code.wireshark.org/review/23785
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4d563d8f107f388a61acde462f2ede…
commit 4d563d8f107f388a61acde462f2ede72e6793a64
Author: Gerald Combs <gerald(a)zing.org>
Date: Sun Oct 1 14:19:23 2017 -0700
Remove the SVR4 packaging assets.
Remove the svr4-package and solaris-package targets along with their
associated files and directories. We used to use this to build Solaris
packages but we haven't shipped those in years. Given that the last
substantive change to packaging/svr4 was in 2008 it's likely that this
has been unused for a while.
Change-Id: Ib9153c99f503200ea8c48d3ef81ad688ee55c09f
Reviewed-on: https://code.wireshark.org/review/23808
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5c2a5dbdcdb21c259821a6aea70813…
commit 5c2a5dbdcdb21c259821a6aea70813813bb2cd21
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 1 10:47:35 2017 +0100
plugins: Improve output format
And some minor code style changes.
Change-Id: I97e53848db42c3981af69152b171b3a77f831da5
Reviewed-on: https://code.wireshark.org/review/23806
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=b7107bdf9d39fd267358e4d1c52611…
commit b7107bdf9d39fd267358e4d1c526112b8bc5b138
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 1 21:13:09 2017 +0100
CMake: Fix extcap plugin directory
Fixes a338f87f33559bb9c915a97b614987736d07ff8f.
Change-Id: Ib1d36a43828bd5896b327e49693485288a536342
Reviewed-on: https://code.wireshark.org/review/23805
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=90d32f83139c7e9aa66a87c37726f3…
commit 90d32f83139c7e9aa66a87c37726f317ac9fcbfd
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Oct 1 20:34:21 2017 +0100
Fix WiX installer
Change-Id: I27af4758393c12962edab10267ae41bd2f11a07e
Reviewed-on: https://code.wireshark.org/review/23804
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=6e24d5f69059dd10fd7b5752a9050b…
commit 6e24d5f69059dd10fd7b5752a9050b79d936a1d4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Sep 30 17:48:00 2017 +0100
Unsplit "m2m" plugin (wimax mac-to-mac encapsulation)
... not to be confused with "machine-to-machine".
M2M seems to be a simple Wimax encapsulation protocol developed by Intel.
It's not documented publicly anywhere that I can find. The boilerplate to
code ratio is huge and it even includes a complete source file from the Wimax
dissector (yuck). Put it in the Wimax plugin instead.
Minor version number bump for wimax plugin.
Change-Id: I2694339dfe89be334093b257a5b34d1577f4dc20
Reviewed-on: https://code.wireshark.org/review/23790
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e155e9159988a96a85ad1f495a7ce2…
commit e155e9159988a96a85ad1f495a7ce24473e08456
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Sep 29 20:48:35 2017 +0200
stats tree: (trivial) reformat assignments
a= b; looks a bit strange. Replace such assignments with a = b;
Change-Id: I09534e0201906490daeb5cd35c55df00e139cf30
Reviewed-on: https://code.wireshark.org/review/23800
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9ab17810bcc334ca76e4b470f73020…
commit 9ab17810bcc334ca76e4b470f7302013dc0bd261
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Sep 29 20:55:23 2017 +0200
stats_tree: fix the comparison routine for COL_AVERAGE
Generally, the average is calculated as node->total / node->count.
The curent code does not handle the case where we compare two nodes
and both have count == 0. It defines one of the nodes to be bigger.
This triggers (at least on Windows) an assertion about invalid operator<.
To fix this, we define average = 0 for a node with count == 0.
We can then simply compare the two averages.
Change-Id: Ie7d9cd590deddcdb9214c4a2693c2eb47c66b287
Reviewed-on: https://code.wireshark.org/review/23799
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d8903ce3975b57c3f4cbd24d58994a…
commit d8903ce3975b57c3f4cbd24d58994a1db8c572c8
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Sep 29 17:36:55 2017 +0200
simplify some include file paths
For both autotools and cmake, the top-level source directory is always
part of the search path for include files. For include files in this
directory, we can simply use the file name. There's no need for a
relative path.
Change-Id: Ibf46265d91b5cb9bff4fa791e5b1d69ee3c1e165
Reviewed-on: https://code.wireshark.org/review/23798
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=be3b1291d4f3e1b2fbd6e075ffd42c…
commit be3b1291d4f3e1b2fbd6e075ffd42c60fbe4f739
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sun Oct 1 13:31:27 2017 +0200
GTPv2: Add individual IEs to subtree array
Change-Id: Ia12dae5869d5ae554d4bd1a3647738e56ed0ce2b
Reviewed-on: https://code.wireshark.org/review/23801
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=797a9bf67dac1b35fa076a44ca8194…
commit 797a9bf67dac1b35fa076a44ca81944875be6f1b
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Oct 1 08:13:39 2017 +0000
[Automatic update for 2017-10-01]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I5ba654c9fade87decd26995b5a2d38734dcfba3b
Reviewed-on: https://code.wireshark.org/review/23794
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=23e2b1f948af100c93fb52e73be0a0…
commit 23e2b1f948af100c93fb52e73be0a0602d7a0b4c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Sep 30 21:18:57 2017 +0100
Fix make distcheck
Change-Id: I6fc298c5c320fcdbc117ff2ec261e6fe335e178c
Reviewed-on: https://code.wireshark.org/review/23792
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=cf79a87705c3b22233b252705bb357…
commit cf79a87705c3b22233b252705bb3570ce357bbd4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 29 23:31:48 2017 +0100
WiMAX: Fix possible crash during protocol registration
proto_register_wimax() cannot be assumed to run before all other dissectors
that depend on the global proto_wimax variable. It happens to work now but
registration order is never guaranteed and cannot be relied upon. Wireshark
will crash with a null pointer dereference if proto_register_wimax() is not
run first.
Have proto_register_wimax() call the registration routine for the other dissectors
that depend on proto_wimax to impose the hard-coded order.
Change-Id: I3e9a9ea742f3feeb5b802ad79cfc9ed916264d2f
Reviewed-on: https://code.wireshark.org/review/23788
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=bf580c066a52ce86226f40cfb32a48…
commit bf580c066a52ce86226f40cfb32a48a819c160f8
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Sep 30 11:59:01 2017 +0100
Make make-dissector-reg.py pay attention to word boundaries
Change-Id: Ia96c7b86994b9b5ab58735722f97e2c46cdfb54e
Reviewed-on: https://code.wireshark.org/review/23787
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=73504255fb3a521fc207e960c9b34f…
commit 73504255fb3a521fc207e960c9b34f23f898581e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Sep 28 02:08:55 2017 +0100
Fix typo in make-dissector-reg.py
Change-Id: Ia4c0cd07e1a0e570db440bd05877fc760aae5f54
Reviewed-on: https://code.wireshark.org/review/23786
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=6106196232d9640b233ac4b6c6faf8…
commit 6106196232d9640b233ac4b6c6faf81d39e37e52
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 29 14:46:20 2017 +0200
btle: Don't ignore frames with incorrect CRC when detecting retransmission.
The retrans detection using SN must use all available frames to make a best
effort. The probability for having error in the SN bit is little compared
to reassembly errors occuring when discarding frames with incorrect CRC.
Change-Id: I40f89e69b19600939b6e0a85a2e655b6681ea5b2
Reviewed-on: https://code.wireshark.org/review/23783
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=4ef7894862769bfea39ea74ec16d42…
commit 4ef7894862769bfea39ea74ec16d42a150bc2545
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 29 10:58:56 2017 +0200
btle: Improve retransmit detection
Only use SN to detect retransmission.
Lower retransmit expert info severity to Note.
Change-Id: I4604903cce9cc58a6fcffff6597e7e99d228aa80
Reviewed-on: https://code.wireshark.org/review/23780
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=d3e34586c5e75685f9792b9104363c…
commit d3e34586c5e75685f9792b9104363c684fc3e174
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Sep 28 15:11:10 2017 +0200
btle: Ignore retransmitted frames in reassembly
Change NESN/SN check to detect retransmit pr. connection.
Frames with same SN in one direction is retransmit.
Ignore retransmit frames when doing reassembly (btle and l2cap).
Also ignore frames with incorrect CRC when doing reassembly.
This fix is related to g95e09a60.
Change-Id: I6386b42758ec3abada07ec1964d3e1b7ba7400e4
Reviewed-on: https://code.wireshark.org/review/23771
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fbcd64deb836e0ec21d3ca7671d6e6…
commit fbcd64deb836e0ec21d3ca7671d6e6f8f37090eb
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Sep 28 15:49:17 2017 -0700
PortableApps: Don't ship development files.
Exclude .exp and .lib files when we run xcopy.
Change-Id: I913a1360507a8812a678efcd35d9afe58167d11b
Reviewed-on: https://code.wireshark.org/review/23777
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=ec9e555456ef5217ace606bf31ded3…
commit ec9e555456ef5217ace606bf31ded35d45bf55d3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Sep 28 12:23:12 2017 -0700
Have dissect_7bit_string() return a const gchar *.
Nobody needs to modify the string, and nobody needs to free it - which
is good, because it could be a string constant which can neither be
modified nor freed.
Change-Id: I13d4239557698e4631e8f8b062d436a2e94d5eca
Reviewed-on: https://code.wireshark.org/review/23773
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
(cherry picked from commit e209b4c5274766a92b1ae3daff57bf5ca21dfc0f)
Reviewed-on: https://code.wireshark.org/review/23774
(cherry picked from commit 54f1a4f285260d12d8da834637631e4020cf7786)
Reviewed-on: https://code.wireshark.org/review/23776
http://cgit.osmocom.org/wireshark/commit/?id=0419deb63bdc8e5685f0bf4022ff4c…
commit 0419deb63bdc8e5685f0bf4022ff4cf8f7acf1ff
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Wed Sep 27 00:34:18 2017 +0200
radius: display in same fashion as Diameter
* Change order to display AVP name/type first
* Added "val=" before value
* Added "vnd=" before vendor
Change-Id: Iabafa6de5bc4b77dfa475cba390bc5c99da71d3f
Reviewed-on: https://code.wireshark.org/review/23760
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9cb1892f387a7cfdb8fd0aee64bbe7…
commit 9cb1892f387a7cfdb8fd0aee64bbe7d6842fc40d
Author: Christoph Schlosser <christoph.schlosser(a)br-automation.com>
Date: Thu Sep 28 13:08:06 2017 +0200
epl: fix od_idx display in tree
The idx value was set to the sod_index value when the previous value of idx
was still needed to correctly set the text of the proto item.
Change-Id: I1130678aaf5f623ab30814310ac14360d13b84b7
Reviewed-on: https://code.wireshark.org/review/23770
Reviewed-by: Christoph Schlosser <christoph(a)schlosser.xyz>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f0e12f0fd301476378719d8268f13d…
commit f0e12f0fd301476378719d8268f13d53b14aaf1b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 21:45:16 2017 +0100
Remove TPG plugin and dependencies
It doesn't build with autotools and CMake.
Under-documented and unmaintained. Seems to be a work-in-progress
that stalled.
Introduces spurious CMake dependency on yapp.
Change-Id: I0dca1ccbdfd683586c05765437d4b7804ab5cc70
Reviewed-on: https://code.wireshark.org/review/23758
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=13184fbf3a1490e2ba7c27cf34e458…
commit 13184fbf3a1490e2ba7c27cf34e458a77bfcc337
Author: Eugene Adell <eugene.adell(a)gmail.com>
Date: Wed Sep 27 14:49:13 2017 -0700
HTTP: fix the Response Version
Add a distinct field for a version in a response packet,
http.response.version
Bug: 14085
Change-Id: Ib255acf7fc329566869bfb82108826931368701d
Reviewed-on: https://code.wireshark.org/review/23769
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b30119471711b1aa47d2509a1bec73…
commit b30119471711b1aa47d2509a1bec73468990eb66
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Wed Sep 27 21:05:53 2017 +0200
ZigBee ZCL SE comments: Fixed comments and descriptions in ZCL SE.
There are no functional changes.
Change-Id: I19532d04d9cd428a86f04456ff402d36877be3bf
Reviewed-on: https://code.wireshark.org/review/23766
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cd90f732a1354f4615fa51c1362559…
commit cd90f732a1354f4615fa51c136255991f362b5bf
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Sep 11 15:11:45 2017 -0700
Improve frame.protocols accuracy.
During single-pass tshark dissection we can end up adding "Protocols in
frame: ...:tcp:http" to the tree even though we haven't dissected HTTP.
This may be true of other protocols as well.
Remove our last layer when we haven't added any items to the tree.
Decrement curr_layer_num as well. Update the layer logic in
dissector_try_heuristic to match call_dissector_work.
Change-Id: Ibc0591e774761e9496d056080c980243a0447066
Reviewed-on: https://code.wireshark.org/review/23508
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=3d661f2fe5851cb84fd6953774bb71…
commit 3d661f2fe5851cb84fd6953774bb71ee5071c597
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 27 14:48:06 2017 +0200
GRPC: fix character check (CID 1418526)
Change-Id: I998ca90149ec65529d79b294a6d00624858fc94a
Reviewed-on: https://code.wireshark.org/review/23763
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6ab87ad77d735b753c81f7ce4f82dd…
commit 6ab87ad77d735b753c81f7ce4f82dd2de03474d8
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 27 16:16:48 2017 +0200
LTE RRC: upgrade dissector to v14.4.0
Change-Id: If835450380263a012c3716cf2f2b6ee36a3201a0
Reviewed-on: https://code.wireshark.org/review/23765
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f83587549942332ed08b51f4e7d21e…
commit f83587549942332ed08b51f4e7d21e03ccdcf022
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 27 14:49:04 2017 +0200
GRPC: fix a control flow issue (CID 1418525)
If no HTTP2 path is retrieved, we cannot really guess the direction.
Let's not append it then.
Change-Id: Ib06b103079cea8a82dbd45a7d4ac4d6a8e673857
Reviewed-on: https://code.wireshark.org/review/23764
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dc527152a8d01eef5868c625d327f6…
commit dc527152a8d01eef5868c625d327f6291f3b09ad
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 27 14:34:32 2017 +0200
RRC: upgrade dissector to v14.4.0
Change-Id: I49cf3e5981efe5b28eb012bab50cf55636636a38
Reviewed-on: https://code.wireshark.org/review/23762
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=492da78a2c59a134597fc732109580…
commit 492da78a2c59a134597fc732109580f857d8d50d
Author: Tom Haynes <loghyr(a)primarydata.com>
Date: Tue Sep 26 13:11:27 2017 -0700
nfsv4: Implement the xattr support for NFSv4
See: https://datatracker.ietf.org/doc/draft-ietf-nfsv4-xattrs/
Change-Id: I775eb2ec994409717f5d4ab9feb07cb4201617f1
Signed-off-by: Tom Haynes <loghyr(a)primarydata.com>
Reviewed-on: https://code.wireshark.org/review/23756
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c634f2b184f3160a879c72c79e1dd9…
commit c634f2b184f3160a879c72c79e1dd906d8ecc566
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Sep 26 14:23:51 2017 -0700
Capinfos: Add SHA256. Remove MD5.
Print the SHA256, RIPEMD160, and SHA1 hashes for each file instead of
SHA1, RIPEMD160, and MD5. SHA256 seems to be the preferred file hashing
algorithm these days and MD5 is actively discouraged. Note that we might
remove SHA1 (which is also discouraged) as well.
Change-Id: I74d972ae5f3484c83175cd3f3c7a55f99c171e20
Reviewed-on: https://code.wireshark.org/review/23761
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5ecfe0c565e106960c3a13a6e835bd…
commit 5ecfe0c565e106960c3a13a6e835bd09f0b3e244
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Tue Sep 26 23:42:20 2017 +0200
sharkd: support for frame comments.
Change-Id: If51cd6a7f4989fee16563809a997dc2f46f67c22
Reviewed-on: https://code.wireshark.org/review/23759
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e8492934d6cf1f7d71b8d3cd10e5fd…
commit e8492934d6cf1f7d71b8d3cd10e5fd257f0d8fc0
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Sep 26 12:08:28 2017 -0700
WSUG: More tools updates.
Add links to the online man page for each tool. Make sure tshark
generates pre-commit-compatible output on Linux.
Change-Id: I00d2973475f27460065bc8a65471abef152ded33
Reviewed-on: https://code.wireshark.org/review/23754
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f48c2cb5d46884e13c472d75556793…
commit f48c2cb5d46884e13c472d75556793b185d9183a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 26 22:42:30 2017 +0200
LPP: upgrade dissector to v14.3.0
Change-Id: I0d571e277c4ec00d3da9dfabfc9cd80689763f69
Reviewed-on: https://code.wireshark.org/review/23757
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0e639797309c3bb62171d6c226c197…
commit 0e639797309c3bb62171d6c226c197e63b0cea59
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 20:43:39 2017 +0100
plugins: Move the build dir scanning code to a separate function
Change-Id: Iee476ac84d530810e5b70547c462050f1c03ee1b
Reviewed-on: https://code.wireshark.org/review/23755
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=9515fba1fa0d51a97abd02e0869f42…
commit 9515fba1fa0d51a97abd02e0869f42bfc2201c2d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 02:47:34 2017 +0100
Remove "easy_codec" source
It's dead, unmaintained and unfinished.
Not in a good enough state to live in the tree.
Change-Id: I6a5c391503b5237638f8362fb9f0492c4cf36223
Reviewed-on: https://code.wireshark.org/review/23745
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=a1969dd6f608685e53c9e28992bc92…
commit a1969dd6f608685e53c9e28992bc928f09a18849
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 19:17:52 2017 +0100
plugins: No need to allocate a new struct
Change-Id: Ic39cf1c7f199dc5e4879d954a649d21453dcc5e5
Reviewed-on: https://code.wireshark.org/review/23753
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=a269ae1b6a0a65d3e28a4c59487f7f…
commit a269ae1b6a0a65d3e28a4c59487f7fd9b8a5685c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 15:04:56 2017 +0100
Rename "ws_version_info.h", also .c
It's not installed so like most other files it doesn't need or benefit
from the prefix.
Change-Id: I01517e06f12b3101fee21b68cba3bc6842bbef5c
Reviewed-on: https://code.wireshark.org/review/23751
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=221a2bcbd0bd9fc04eacbe223f9118…
commit 221a2bcbd0bd9fc04eacbe223f9118cabecccac1
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 16:28:02 2017 +0100
Move some DIAG_OFFs to make code less ugly
Change-Id: I0f343ab69a6592a466e12e5d258f0878b9c32c25
Reviewed-on: https://code.wireshark.org/review/23752
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=cd6ca0da41ce2af151670486e724d4…
commit cd6ca0da41ce2af151670486e724d47870705d44
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Tue Sep 26 15:32:03 2017 +0200
DOCSIS: Adding Attribute masks to Service Flow
Change-Id: I626b8a1d85e3062c58f9e3bd7bd6c6123c4b8272
Reviewed-on: https://code.wireshark.org/review/23749
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=85c0a7807333d379ca1e0d747b9a42…
commit 85c0a7807333d379ca1e0d747b9a424daea2352e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 14:13:48 2017 +0100
plugins: Use g_slist_prepend() instead.
Change-Id: If145137bfd44025ccab762b67960072777efd302
Reviewed-on: https://code.wireshark.org/review/23750
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=a0eb34232f909207282396ce961207…
commit a0eb34232f909207282396ce9612078627ed358b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 26 13:29:43 2017 +0200
GTP: fix display of GTP Prime in frame.protocols field
Bug: 14083
Change-Id: Ieabdfd2399df9136f6fd9d556ea3b96230710860
Reviewed-on: https://code.wireshark.org/review/23743
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e60319e54bcc487f9d5baded335f51…
commit e60319e54bcc487f9d5baded335f516cd77fa931
Author: Anton Butenko <ant.butenko(a)gmail.com>
Date: Tue Sep 26 12:23:29 2017 +0300
coap: Added dissection for LWM2M JSON inside CoAP protocol
Change-Id: I29429f731b7e2f25568d44de455816ac70e079b6
Reviewed-on: https://code.wireshark.org/review/23740
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f2404376f807712d55e339a075d02d…
commit f2404376f807712d55e339a075d02d6f9a454a0a
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 26 00:15:24 2017 +0100
plugins: Build the description string while loading
Change-Id: Ia67133c1c9d005fc4a81b0727a7b1849571ab29c
Reviewed-on: https://code.wireshark.org/review/23742
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c5c05911c62f0524c3b88086cf20de…
commit c5c05911c62f0524c3b88086cf20dedb3d6ef769
Author: Huang Qiangxiong <qiangxiong.huang(a)qq.com>
Date: Mon Jul 31 15:22:59 2017 +0000
Add GRPC dissector
GRPC dissector register it self to media_type dissector table using
patterns "application/grpc", "application/grpc+proto" and
"application/grpc+json".
GRPC stack (at least in grpc-java) can send JSON over GRPC using
content-type = "application/grpc" which normally means default protobuf
format. A preference is added to detect the message body, if it starts
with '{', and ends with '}', will force to use JSON subdissector
instead
of searching in 'grpc_message_type' table.
Ping-Bug: 13932
Change-Id: I910961ca06370e678d19b78cac533ca566d87628
Reviewed-on: https://code.wireshark.org/review/22891
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b89726db6d0bbadd607e8d43c0528d…
commit b89726db6d0bbadd607e8d43c0528d3e6e053531
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Mon Sep 25 22:22:35 2017 +0200
ZigBee ZCL SE Events: Dissect commands within ZCL SE Events Cluster
Change-Id: I6baf02fc0a194a776fb02fc265902b0eafd710e9
Reviewed-on: https://code.wireshark.org/review/23734
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0b76a4957de610fc065c4956094ba0…
commit 0b76a4957de610fc065c4956094ba068c27b2ef1
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 25 20:42:29 2017 +0100
plugins: Sort the descriptions
Change-Id: I8113ba9782962856ce86475cddf40d69ed267fb4
Reviewed-on: https://code.wireshark.org/review/23733
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f022a629f1a028c368758430a07091…
commit f022a629f1a028c368758430a07091ff02a06342
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 25 19:05:40 2017 +0100
plugins: Use hash table for book-keeping
Avoid having to walk the list to check for existence on every file
load.
Now the binary plugin description list in About Wireshark is randomized
instead of sorted by load order. We may want to change that.
Add missing "const" to plugin->version.
Fix an apparent trivial leak where the GModule handle was not closed on
exit.
Change-Id: I774215a84b080bbe889f88cc6a9b777bcf60b335
Reviewed-on: https://code.wireshark.org/review/23732
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b45a7ba7df9d2583baba37cf941cab…
commit b45a7ba7df9d2583baba37cf941cab0f66885c8a
Author: Huang Qiangxiong <qiangxiong.huang(a)qq.com>
Date: Sun Jul 30 13:39:11 2017 +0000
HTTP2: Store all packets' header indexes in header_stream_info struct
Store all packets' headers indexes of oneway stream in its header_stream_info
struct.
(Just store pointers refer to each HEADERS or CONTINUATION packets' header
arrays)
Add http2_get_header_value() function to allow other dissectors to get HTTP2
headers of this stream later in DATA frames.
Ping-Bug: 13932
Change-Id: I9f623f66045845c338cd6233d4c6da3f6875fc69
Reviewed-on: https://code.wireshark.org/review/22859
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5e2c08c5d0a1c49a9f03dd3e150854…
commit 5e2c08c5d0a1c49a9f03dd3e15085433e62d24a5
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Mon Sep 25 19:06:26 2017 +0200
ZigBee PP Dissector: Increase number of subtrees
Increase number of subtrees from 10 to 30 for PublishTopUpLog and PublishDebtLog.
Before the total APS size of PublishDebtLog could only be about 132 bytes.
Same goes for PublishTopUpLog.
Change-Id: I7e70977526de2f6d6e84af178bee91eabb132962
Reviewed-on: https://code.wireshark.org/review/23731
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=799f4f0e142675fab45fe1d00e5d0e…
commit 799f4f0e142675fab45fe1d00e5d0eba3c3ff8cd
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Sep 25 16:18:21 2017 -0700
Editcap: Don't treat plain -F and -T as errors.
The editcap man page says that you can pass in -F and -T without
arguments in order to get a list of valid capture and encapsulation
types. Instead of treating these as errors just print the information to
stdout and return 0.
Adjust the docbook _tools_help targets accordingly.
Change-Id: I590cbd59059dd8965299bef4434f522eff8a4e2c
Reviewed-on: https://code.wireshark.org/review/23741
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8a3903e55af23bdce550a95ffe14a…
commit a8a3903e55af23bdce550a95ffe14a398fd1204c
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Mon Sep 25 23:18:31 2017 +0200
Qt: Free MainWindow at shutdown
MainWindow is allocated on heap on startup but not freed on shutdown.
Free the object at shutdown mainly to silent Valgrind.
When at it also fix two problems with the MainWindow destructor:
- Deleting main_ui_ triggers a currentChanged signal which in turn
calls mainStackChanged that references the freed main_ui_ object.
Prevent use after free error by disconnecting from the signal before
freeing.
- Explicitly free file_set_dialog_ as no rparent perform the cleanup.
Bug: 14071
Change-Id: I9c1fbef04cf68bfffffea57ef298f4896d6583f9
Reviewed-on: https://code.wireshark.org/review/23739
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e2d43e7d4b352206bac6bdd42f2c8f…
commit e2d43e7d4b352206bac6bdd42f2c8f04d1e126b2
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Sep 25 14:06:37 2017 -0700
Docbook: Automatically generate the tools help output.
Add a CMake target that dumps the help output for our command line tools
to individual files. Include those files in the tools appendix instead
of pasting them in manually.
Fixup the output of some tools so that they pass the pre-commit checks.
Change-Id: I925f24818422a190927a96531c21f4d16d3fe5b5
Reviewed-on: https://code.wireshark.org/review/23737
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=f3d9766cbc83316544aae7fdd0f0f8…
commit f3d9766cbc83316544aae7fdd0f0f854160eafa3
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Mon Sep 25 16:55:21 2017 +0200
Qt: Fix leaked interfaces array in Wireless frame
The array of ws80211_interface:s is not freed when the wireless
frame is destroyed causing minor leaks. Fix leaks by freeing the
array using appropriate utility function.
Bug: 14071
Change-Id: I35ec578062bfee4a4f0d0ac05a6d7613996a8822
Reviewed-on: https://code.wireshark.org/review/23738
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=a9b4f31d4a76cd3c3ffeb78581d0f5…
commit a9b4f31d4a76cd3c3ffeb78581d0f5cf24b78e3b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Sep 25 22:48:39 2017 +0200
NAS EPS: upgrade dissector to v14.5.0
Change-Id: I0cf79dc37804db60b50cfb87355d0537361e214f
Reviewed-on: https://code.wireshark.org/review/23736
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4efa11528ee924dbd910c20f001eb0…
commit 4efa11528ee924dbd910c20f001eb07c52ffec6d
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Sep 25 22:26:53 2017 +0200
3GPP NAS: upgrade dissector to v14.5.0
Change-Id: Ibf45c6b5930ee122004afc8d2ac84a751491f3a4
Reviewed-on: https://code.wireshark.org/review/23735
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8615081a0910797a8dfab5ea60583f…
commit 8615081a0910797a8dfab5ea60583f8f5da8d020
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 25 12:51:27 2017 +0100
plugins: Fix crash loading binary module twice
If a plugin is repeated we destroy the GModuleHandle in plugins_scan_dir()
but we have already added the entry points to the list of registered
plugins.
Check for repeated plugins before adding it to the list of registered
plugins, not after.
Don't check for both name and version, check only for repeated names.
Give the plugin callback a more descriptive name.
Change-Id: I22cbbb059b8029877580fc33517310496c93e5d5
Reviewed-on: https://code.wireshark.org/review/23726
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=8b5b843fcbc3e03e0fc45f3caf8cf5…
commit 8b5b843fcbc3e03e0fc45f3caf8cf5fc477e8613
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Mon Sep 25 18:10:01 2017 +0200
udpdump: Add missing include for timeval struct.
struct timeval is defined in <sys/time.h>, include it.
It should fix building with musl:
udpdump.c: In function 'setup_listener':
udpdump.c:126:9: error: variable 'timeout' has initializer but incomplete
type
struct timeval timeout = { 1, 0 };
Change-Id: Id9be579e50ea2845ca609708e8ec4d1a3858ecc0
Reviewed-on: https://code.wireshark.org/review/23728
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=94af9724d140fd132896b650d10c4d…
commit 94af9724d140fd132896b650d10c4d060788e4f0
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Sep 25 09:36:38 2017 -0700
macOS: Fixup plugin signing.
Use `find` to find plugins.
Change-Id: I6df8877547ecbd19644a846e5cb02e8b65f19e61
Reviewed-on: https://code.wireshark.org/review/23730
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=33c00a6741b7cd31e28b7034bf25fc…
commit 33c00a6741b7cd31e28b7034bf25fc2f4b2ad767
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Sep 25 17:51:05 2017 +0200
text2pcap: fix crash when there is no argument
Bug: 14082
Change-Id: Ifd8b2bf9bee817967e3b00e01b8b4ae90970e984
Reviewed-on: https://code.wireshark.org/review/23727
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f64906413067f59b7bce5d149fd86b…
commit f64906413067f59b7bce5d149fd86b22ec392952
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Sep 23 22:50:28 2017 +0100
Add toy plugin to doc/ as an out-of-tree build example
Change-Id: I9b7abb27d30dbe83996a01b7f722693a974948c5
Reviewed-on: https://code.wireshark.org/review/23665
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=625bab309d9dd21db2d8ae2aa35118…
commit 625bab309d9dd21db2d8ae2aa3511810d32842a8
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Sep 23 22:22:28 2017 +0200
Docsis: fix an infinite loop
Add missing decrement of concatlen based on master-2.2 version.
Bug: 14080
Change-Id: I00f7e34f8e599718316a4ce8916d91b780ec7c14
Reviewed-on: https://code.wireshark.org/review/23663
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=194d30badf547edd9f3f86f2de8732…
commit 194d30badf547edd9f3f86f2de87322e13a0fa8a
Author: Florian Fainelli <f.fainelli(a)gmail.com>
Date: Sat Sep 16 21:45:49 2017 -0700
packet-brcm-tag: Add Broadcom tag dissection
Add support for dissecting the old-style Broadcom tag with Ethertype 0x8874,
this was supported by switches like Broadcom BCM5325. Newer switches use a
different tag format (with no Ethertype) which will be supported later.
Change-Id: Iec26f8d13058399a35fb258ccadc48f7f5ac8474
Reviewed-on: https://code.wireshark.org/review/23592
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dc011cc53ebb424ed4fd1383282d92…
commit dc011cc53ebb424ed4fd1383282d929f8688e8e1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Sep 25 00:20:04 2017 -0700
pidl: fix field2name wireshark dissector test.
Pick up change from Samba:
commit 82778a6d04580fc05f3f83d44f57f221ad4e8ac4
Author: Günther Deschner <gd(a)samba.org>
Date: Tue Sep 6 22:37:12 2016 +0200
pidl: fix field2name wireshark dissector test.
Guenther
Signed-off-by: Guenther Deschner <gd(a)samba.org>
Reviewed-by: Stefan Metzmacher <metze(a)samba.org>
Autobuild-User(master): Günther Deschner <gd(a)samba.org>
Autobuild-Date(master): Wed Sep 7 16:05:26 CEST 2016 on sn-devel-144
Change-Id: Ia02de7d36b2fcb0e7a5145361548acae844f73ed
Reviewed-on: https://code.wireshark.org/review/23724
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c1a5531b71208c8270f7d969f4aebd…
commit c1a5531b71208c8270f7d969f4aebdfbfb5ad12e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Sep 25 00:16:26 2017 -0700
pidl: Fix array range checks in python output
Pick up change from Samba:
commit 67040cf61232dd1cdcc820237919ac1e073c31c2
Author: Volker Lendecke <vl(a)samba.org>
Date: Tue Jun 20 15:31:18 2017 +0200
pidl: Fix array range checks in python output
Without this, we generated code like
if (ndr_table_dnsserver.num_calls < 0) {
PyErr_SetString(PyExc_TypeError, "Internal Error,
ndr_interface_call missing for py_DnssrvOperation_ndr_pack");
return NULL;
}
call = &ndr_table_dnsserver.calls[0];
This does not really make sense, and Coverity found comparing the unsigned
num_calls against <0 a bit pointless.
Should fix 138 Coverity findings and make the code a bit more correct.
Signed-off-by: Volker Lendecke <vl(a)samba.org>
Reviewed-by: Jeremy Allison <jra(a)samba.org>
Change-Id: I401e3771e6f3c1125ff847749073693af23884fc
Reviewed-on: https://code.wireshark.org/review/23723
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a98d1089166cc90ebf7c82b938ae0a…
commit a98d1089166cc90ebf7c82b938ae0add478b921d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Sep 25 00:13:58 2017 -0700
python3: Use "y#" instead of "s#" for binary data in
PyArg_ParseTuple
Pick up change from Samba:
commit 40e409bf9e89a163c771b2a58493d2c1b496fae7
Author: Petr Viktorin <pviktori(a)redhat.com>
Date: Wed May 3 16:57:07 2017 +0200
python3: Use "y#" instead of "s#" for binary data in
PyArg_ParseTuple
The "s#" format code for PyArg_ParseTupleAndKeywords and
Py_BuildValue
converts a char* and size to/from Python str (with utf-8 encoding under
Python 3).
In some cases, we want bytes (str on Python 2, bytes on 3) instead. The
code for this is "y#" in Python 3, but that is not available in 2.
Introduce a PYARG_BYTES_LEN macro that expands to "s#" or
"y#", and use
that in:
- credentials.get_ntlm_response (for input and output)
- ndr_unpack argument in PIDL generated code
Signed-off-by: Petr Viktorin <pviktori(a)redhat.com>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Change-Id: If4d9cdabc5016127f60682caf300f6801a360083
Reviewed-on: https://code.wireshark.org/review/23722
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=141637d327c6c7529b44e43e8530b6…
commit 141637d327c6c7529b44e43e8530b6304b5a12ee
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Sep 25 00:11:53 2017 -0700
pidl: Fix Coverity warnings from duplicate NULL checks.
Pick up change from Samba:
commit 9703464b942fdddbf7bc4380cbd26d1803f9bc00
Author: Jeremy Allison <jra(a)samba.org>
Date: Tue May 2 08:10:40 2017 -0700
pidl: Fix Coverity warnings from duplicate NULL checks.
Pair-Programmed-With: Stefan Metzmacher <metze(a)samba.org>
Signed-off-by: Jeremy Allison <jra(a)samba.org>
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet(a)samba.org>
Autobuild-Date(master): Sat May 6 16:03:17 CEST 2017 on sn-devel-144
Change-Id: I25c6ae984c6a963c05f33d9a649b64f9795c7292
Reviewed-on: https://code.wireshark.org/review/23721
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5ea8c70c05240009e2fe1f3f71636f…
commit 5ea8c70c05240009e2fe1f3f71636fddc0feb7eb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 22:10:02 2017 -0700
python: pidl: Port Python interface generator
Pick up change from Samba:
commit 2de5fa45e0abfdb50f604f87e494bf334c39003a
Author: Lumir Balhar <lbalhar(a)redhat.com>
Date: Mon Jan 23 21:03:17 2017 +0100
python: pidl: Port Python interface generator
Port PIDL generator of Python interfaces to generate interfaces in
Python 3 compatible form.
Python 2.7 is now required, so we can use PyCapsule in both versions.
Signed-off-by: Lumir Balhar <lbalhar(a)redhat.com>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall(a)catalyst.net.nz>
Pair-programmed-by: Andrew Bartlett <abartlet(a)samba.org>
Change-Id: I981993e326132a1911bfbb686ca5ae033dd1df49
Reviewed-on: https://code.wireshark.org/review/23720
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=097de92cfbb5dfa6baaee8c2122ca5…
commit 097de92cfbb5dfa6baaee8c2122ca504ac09473b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 22:08:23 2017 -0700
pidl:Python: use of pytalloc_GenericObject_reference*() for pyrpc_{ex,im}port_union()
wrapping
Pick up change from Samba:
commit 2170f556299c6ab4ce33f22169ca26ecad3440e3
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Feb 20 18:02:09 2017 +0100
pidl:Python: use of pytalloc_GenericObject_reference*() for
pyrpc_{ex,im}port_union() wrapping
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet(a)samba.org>
Autobuild-Date(master): Sat Feb 25 06:33:33 CET 2017 on sn-devel-144
Change-Id: I4d3cb70c79531e5faf5249b67948cc6d354c1bd0
Reviewed-on: https://code.wireshark.org/review/23719
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4861fbe121301a3e5b519f719f3447…
commit 4861fbe121301a3e5b519f719f3447290001cb00
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 22:02:41 2017 -0700
pidl:Python: replace pytalloc_CObject_FromTallocPtr() with
pytalloc_GenericObject_reference_ex()
Pick up change from Samba:
commit 1ee0c0f8280393c708f23361ebcba0776e8b4d33
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Wed Feb 22 09:07:54 2017 +0100
pidl:Python: replace pytalloc_CObject_FromTallocPtr() with
pytalloc_GenericObject_reference_ex()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Change-Id: I19d04a1a248d35799ec41a79113fe588cd05e3de
Reviewed-on: https://code.wireshark.org/review/23718
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=75f78cd49ad0ec6307376492640713…
commit 75f78cd49ad0ec63073764926407135732f677ce
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 22:01:11 2017 -0700
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601
Pick up change from Samba:
commit d62eb3cc9f97b203d21ec6e75c48c739a43bc163
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Wed Feb 22 10:08:46 2017 +0100
pidl:Python: make sure print HASH references for STRUCT types
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12601
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Change-Id: Ieef766844ce66160eaaacecc73a51f94f69319fb
Reviewed-on: https://code.wireshark.org/review/23717
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5bda9bd4cb07c8b754202ce5950f99…
commit 5bda9bd4cb07c8b754202ce5950f9917db293222
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:56:47 2017 -0700
pidl:Python: add PyTypeObject objects for function structs
Pick up change from Samba:
commit 57539c84416aeb8fc8e3a8653f790b329e6fa9a1
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Sep 12 09:20:44 2016 +0200
pidl:Python: add PyTypeObject objects for function structs
They provide get/set methods for the in_* and out_* elements
and the magic __ndr_{push,pull,print}_{in,out}__ hooks to enable
the marshalling via ndr_{push,pull,print}_{in,out}().
This provides an easy way to generate and parse the payload of
DCERPC requests and responses, which is very useful for writing
tests.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I8f0e70fb771a91ba9590e2e92b5713b48313d2de
Reviewed-on: https://code.wireshark.org/review/23716
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=fd81dea208b42a0aa174810e82f2d0…
commit fd81dea208b42a0aa174810e82f2d0fe24d0251e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:51:46 2017 -0700
pidl:Python: split out a PythonElementGetSet() helper function
Pick up a change from Samba:
commit a546124f10d1e2bee29bc06c0b8754257d2bdc23
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Sep 12 09:20:04 2016 +0200
pidl:Python: split out a PythonElementGetSet() helper function
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: Ica8b699189b69833abfa6049dd3c4e489788ce54
Reviewed-on: https://code.wireshark.org/review/23715
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1dd1a13e9f2a6c3ebd51c883bac5a8…
commit 1dd1a13e9f2a6c3ebd51c883bac5a8c2e1eeb4d3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:50:25 2017 -0700
pidl:Python: the py_{import,export}_*() functions can be static now.
Pick up change from Samba:
commit 40175613519e7405a16e8f896dfdc2949430bc4b
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Tue Sep 13 01:06:18 2016 +0200
pidl:Python: the py_{import,export}_*() functions can be static now.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I6e06c97b44a04cab36d134916eddf4c501ccc35d
Reviewed-on: https://code.wireshark.org/review/23714
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=484d114b361162325405d5437be3fe…
commit 484d114b361162325405d5437be3fe6f1342932f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:49:05 2017 -0700
pidl:Python: make use of the pyrpc_{import,export}_union() functions
Pick up a change from Samba:
commit f7707c04a5e039e757b288ad67a0c3cac9c6466a
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Sep 12 16:33:38 2016 +0200
pidl:Python: make use of the pyrpc_{import,export}_union() functions
This avoids the linking problems at C shared object level.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I62c1d03b10e965552a4d598fa2370692ee0cd12a
Reviewed-on: https://code.wireshark.org/review/23713
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0517a05b54b1ddbddca53291d873af…
commit 0517a05b54b1ddbddca53291d873af39ff578d88
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:47:37 2017 -0700
pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and __export__()
hooks
Pick up a change from Samba:
commit e0324c0cf7e7c363a5791c2e35c8820b79640a47
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Sep 12 16:33:38 2016 +0200
pidl:Python: provide a PyTypeObject with METH_CLASS __import__() and
__export__() hooks
These are wrappers around the currently public C functions
'py_import_*() and 'py_export_*().
In order to let other python module use these function, we should
resolve the needed type object and call the __import__() or __export__()
hooks instead of linking to the other shared module at C level.
We already do the same for structs.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I47813a544365085407a31d174ee180778674e42b
Reviewed-on: https://code.wireshark.org/review/23712
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1373f619f9772d30d6aef104a0d706…
commit 1373f619f9772d30d6aef104a0d7063f660195b1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:46:05 2017 -0700
pidl:Python: provide the abstract syntax as
<module>.<interface>_abstract_syntax
Pick up change from Samba:
commit 3a0ce3e41d9fdab58273c239955862b03396ea19
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Sun Sep 25 00:48:29 2016 +0200
pidl:Python: provide the abstract syntax as
<module>.<interface>_abstract_syntax
The <module>.abstract_syntax alias is only kept as legacy for
the first interface in a module.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: Ie6d3d48ea3012bd328eb20e2e6693928fe24ead8
Reviewed-on: https://code.wireshark.org/review/23711
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=aff94cf8f52057b76ce57736e0f64d…
commit aff94cf8f52057b76ce57736e0f64d29e06ceecc
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:44:27 2017 -0700
pidl:Python: prettify names of constants
Pick up change from Samba:
commit 1bebccaeb93f7fb7b6e2538d63223f01587ed14d
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Fri Sep 23 06:49:13 2016 +0200
pidl:Python: prettify names of constants
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: If9905b914c0d559bd6e7808fadbd154ae56ae2b1
Reviewed-on: https://code.wireshark.org/review/23710
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d7311431b2c0bc82f7fb4e5815379e…
commit d7311431b2c0bc82f7fb4e5815379e482d3b7a48
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:42:58 2017 -0700
pidl:Python: improve the .doc string for the get/set elements
Pick up change from Samba:
commit a560116aa5228885e5f52fc46fa92151357de69c
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Tue Sep 13 09:07:32 2016 +0200
pidl:Python: improve the .doc string for the get/set elements
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I8ecb22fd88298ecd4e350b1815d8720b493aac27
Reviewed-on: https://code.wireshark.org/review/23709
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1cbb04eaf15508df8b1aa5b38b5abb…
commit 1cbb04eaf15508df8b1aa5b38b5abb4613e827c1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:41:38 2017 -0700
pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS()
Pick up change from Samba:
commit 47b40ac96afbd4fb28e519b9658256ecaa304e71
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Sep 12 15:12:24 2016 +0200
pidl:Python: make use of NDR_ERR_CODE_IS_SUCCESS()
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I550b83596fe27bad5ba4f7d91eb0ac62380f4eac
Reviewed-on: https://code.wireshark.org/review/23708
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e3acb2e3ebfadddec77dd7c2cd72db…
commit e3acb2e3ebfadddec77dd7c2cd72db83fe5de91c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:39:47 2017 -0700
pidl:Python: __ndr_print__ functions don't get arguments and need METH_NOARGS
Pick up change from Samba:
commit d4660e869790c7da1cb97e9d95a995e5a32b34ef
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Sun Sep 25 01:07:14 2016 +0200
pidl:Python: __ndr_print__ functions don't get arguments and need
METH_NOARGS
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: Ic0648f65b8c3f60e614361778d2c0bf72d61be35
Reviewed-on: https://code.wireshark.org/review/23707
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=856ce750606cb85427d65e67905091…
commit 856ce750606cb85427d65e67905091998e4f5976
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:17:03 2017 -0700
pidl:Python: check the return values of talloc_ptrtype()
Pick up change from Samba:
commit b728c63bcb5860aed2db43139d191bc149ceba83
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Sep 12 15:12:50 2016 +0200
pidl:Python: check the return values of talloc_ptrtype()
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: Icfe8837b5b998e3c5c4ea98df21cf620f53cdcd7
Reviewed-on: https://code.wireshark.org/review/23706
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=da01add6622688a682cec5d89a99f5…
commit da01add6622688a682cec5d89a99f58e90f8e5fc
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:12:25 2017 -0700
lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *)
Pick up change from Samba:
commit 306783d6f5d577a0b8bd31d659d8c802f22f0333
Author: Jeremy Allison <jra(a)samba.org>
Date: Thu Apr 20 12:24:43 2017 -0700
lib: modules: Change XXX_init interface from XXX_init(void) to
XXX_init(TALLOC_CTX *)
Not currently used - no logic changes inside.
This will make it possible to pass down a long-lived talloc
context from the loading function for modules to use instead
of having them internally all use talloc_autofree_context()
which is a hidden global.
Updated all known module interface numbers, and added a
WHATSNEW.
Signed-off-by: Jeremy Allison <jra(a)samba.org>
Signed-off-by: Ralph Böhme <slow(a)samba.org>
Autobuild-User(master): Jeremy Allison <jra(a)samba.org>
Autobuild-Date(master): Sat Apr 22 01:17:00 CEST 2017 on sn-devel-144
Change-Id: I549e24e2e1fec12d8e7d3f3304cdac29882892a5
Reviewed-on: https://code.wireshark.org/review/23705
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3183465351871c40176e361349fc63…
commit 3183465351871c40176e361349fc634403e1fa06
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:09:13 2017 -0700
s4-rpc_server: Allow each interface to declare if it uses handles
Pick up change from Samba:
commit ffb8b50e3c07c833fb7b1a583d21f9dc1166a0a6
Author: Andrew Bartlett <abartlet(a)samba.org>
Date: Mon Nov 14 11:24:03 2016 +1300
s4-rpc_server: Allow each interface to declare if it uses handles
This will allow the NETLOGON server in the AD DC to declare that it does not
use
handles, and so allow some more flexibility with association groups
Signed-off-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Stefan Metzmacher <metze(a)samba.org>
Change-Id: Ic09452d27493ff913f5a5c064a038e3783e91df2
Reviewed-on: https://code.wireshark.org/review/23704
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=07a21ba6f6957acf3aa2c9337367fa…
commit 07a21ba6f6957acf3aa2c9337367fac265f29934
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:07:04 2017 -0700
s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionally
Pick up change from Samba:
commit 31d625bcd2b0cb33dd98a37c202f5b371b871362
Author: Andrew Bartlett <abartlet(a)samba.org>
Date: Tue Dec 13 09:06:25 2016 +1300
s4-rpc_server: Add back support for lsa over \\pipe\\netlogon optionally
The idea here is that perhaps some real client relies on this (and not just
Samba torture
commands), so we need a way to support it for the 4.6 release.
If no such client emerges, it can be deprecated and removed in the normal
way.
Signed-off-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Stefan Metzmacher <metze(a)samba.org>
Change-Id: Id20f98ffbc5eb4752bebee455e7b2b2c0f5017e0
Reviewed-on: https://code.wireshark.org/review/23703
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=dc7a03486c888467502bdd2bd03ba4…
commit dc7a03486c888467502bdd2bd03ba4ae40348d8f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:05:11 2017 -0700
pidl: Make dcesrv\_$name\_interface "static const"
Pick up change from Samba:
commit 50dff7e094d48793b432992a28571a6f7e5cc73c
Author: Andrew Bartlett <abartlet(a)samba.org>
Date: Mon Nov 21 11:21:50 2016 +1300
pidl: Make dcesrv\_$name\_interface "static const"
This moves it out of the global namespace
Signed-off-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Stefan Metzmacher <metze(a)samba.org>
Autobuild-User(master): Stefan Metzmacher <metze(a)samba.org>
Autobuild-Date(master): Thu Dec 8 13:25:57 CET 2016 on sn-devel-144
Change-Id: Ifa9fca377dc217b131f87cef4463624a679660f9
Reviewed-on: https://code.wireshark.org/review/23702
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a19fdccf51383c6a34eaeba674cc96…
commit a19fdccf51383c6a34eaeba674cc961bd51f6794
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 21:03:40 2017 -0700
pidl: Use a static const initialised struct in dcerpc_server_$name_init(void)
Pick up change from Samba:
commit 778fc58eb281e38eb1a3346b58cfdf9682f104c4
Author: Andrew Bartlett <abartlet(a)samba.org>
Date: Mon Nov 21 11:38:24 2016 +1300
pidl: Use a static const initialised struct in dcerpc_server_$name_init(void)
Signed-off-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Reviewed-by: Garming Sam <garming(a)catalyst.net.nz>
Change-Id: I5bbc8cfdd94f4c13250fc3b1cb0a61351220116c
Reviewed-on: https://code.wireshark.org/review/23701
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ad0417cb78f207b26fa6a2115e86be…
commit ad0417cb78f207b26fa6a2115e86be7a01656d73
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 20:58:08 2017 -0700
libndr/compression: pass down compressed length in ndr_pull_compression_start
Pick up change from Samba:
commit a44bce6dfab59a6440ccc30ef0968d59b9f43fd3
Author: Günther Deschner <gd(a)samba.org>
Date: Tue Sep 20 00:18:43 2016 +0200
libndr/compression: pass down compressed length in ndr_pull_compression_start
Guenther
Signed-off-by: Guenther Deschner <gd(a)samba.org>
Reviewed-by: Jeremy Allison <jra(a)samba.org>
Change-Id: I038c28cafce1248f4208119ba47f1c94ce970067
Reviewed-on: https://code.wireshark.org/review/23700
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7c56a5affbea32db0e2ee1ffd6b72a…
commit 7c56a5affbea32db0e2ee1ffd6b72acf462326de
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 20:51:44 2017 -0700
pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint()
Pick up change from Samba:
commit 81bbfb010599b65308aca89cc50532372ca4cb00
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Jun 12 18:58:49 2017 +0200
pidl:NDR/Parser: add missing {start,end}_flags() to ParseElementPrint()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12782
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: Iaf4192083c49a15eaf722da1a3b55ad987bdbc82
Reviewed-on: https://code.wireshark.org/review/23699
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8fdcc9545630a4ea87313c078e99db…
commit 8fdcc9545630a4ea87313c078e99db12da2485c0
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 20:04:54 2017 -0700
pidl:NDR/Parser: initialize [skip] values in ndr_pull_*
Pick up change from Samba:
commit 823bc4c07add242a5a1d0cd25942ebaab3cd0e23
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Tue Jun 13 09:57:33 2017 +0200
pidl:NDR/Parser: initialize [skip] values in ndr_pull_*
It's too dangerous to leave values uninitialzed!
[skip_noinit] can be used if required.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Volker Lendecke <vl(a)samba.org>
Change-Id: I85a173e21fca509fc417ff2532097fd9a220ccd9
Reviewed-on: https://code.wireshark.org/review/23698
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=67522b613000dab600d4ceaca0edc1…
commit 67522b613000dab600d4ceaca0edc172d5723a02
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 20:03:07 2017 -0700
pidl:NDR/Parser: add "skip_noinit" element
Pick up change from Samba:
commit b922472fd683235fde3abc69ee09d9d8bfdb8644
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Wed Jun 21 15:05:35 2017 +0200
pidl:NDR/Parser: add "skip_noinit" element
In future "skip" will be changed to initialize the element
with ZERO_STRUCT() on ndr_pull_*.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Volker Lendecke <vl(a)samba.org>
Change-Id: I4b886c18c9eff27ae446e68fb7220e812721c4e0
Reviewed-on: https://code.wireshark.org/review/23697
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d037bc66c11a6df6525287ce51e4e9…
commit d037bc66c11a6df6525287ce51e4e998a2478fbd
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 20:00:16 2017 -0700
pidl:NDR/Parser: fix "skip" for pointers
Pick up change from Samba:
commit 3bc6b55385894691792962ecc15978a3b158eca4
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Mon Jun 19 12:15:21 2017 +0200
pidl:NDR/Parser: fix "skip" for pointers
We should handle the "skip" at the element level before
we traverse trough the element levels.
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Volker Lendecke <vl(a)samba.org>
Change-Id: I8b52e1ad0e0ad2c8a4fc20b94f07441b458e5638
Reviewed-on: https://code.wireshark.org/review/23696
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7bb3df70b12efb697fdcec0eaabf87…
commit 7bb3df70b12efb697fdcec0eaabf879120db8dfa
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 19:57:35 2017 -0700
pidl: use ndr_push_charset_to_null() when [to_null] keyword is used in IDL
Pick up change from Samba:
commit d30b008a642c9bb0d85519f42aef56a53e44cc77
Author: Günther Deschner <gd(a)samba.org>
Date: Mon Jan 23 14:50:45 2017 +0100
pidl: use ndr_push_charset_to_null() when [to_null] keyword is used in IDL
Guenther
Signed-off-by: Guenther Deschner <gd(a)samba.org>
Reviewed-by: Stefan Metzmacher <metze(a)samba.org>
Change-Id: I26d53e3c4d0aa9fc959f2d9f0455e480c6cd45e2
Reviewed-on: https://code.wireshark.org/review/23695
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2558728ff9b22c42db7f82d4d8c82f…
commit 2558728ff9b22c42db7f82d4d8c82f3cec75aa64
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 19:54:34 2017 -0700
s4: COM: Remove talloc_autofree_context() from (unused) COM code.
Pick up change from Samba:
commit fe2ac3e304201d18ca15d388b622a4f15f72ad0a
Author: Jeremy Allison <jra(a)samba.org>
Date: Mon Jul 24 12:00:21 2017 -0700
s4: COM: Remove talloc_autofree_context() from (unused) COM code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12932
Signed-off-by: Jeremy Allison <jra(a)samba.org>
Reviewed-by: Andrew Bartlett <abartlet(a)samba.org>
Change-Id: I44a4e3794569957c3cdf0721e78e73972ba06085
Reviewed-on: https://code.wireshark.org/review/23694
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c73e940526f8d6724da236c51f8461…
commit c73e940526f8d6724da236c51f84615bc55aeb3a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 19:45:41 2017 -0700
pidl: Make static struct api_struct also const
Pick up change from Samba:
commit c6c1463852533ed8234911835b8b1fce29b2d3d8
Author: Andrew Bartlett <abartlet(a)samba.org>
Date: Mon Nov 21 11:58:07 2016 +1300
pidl: Make static struct api_struct also const
This moves the table to read-only memory
Signed-off-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Reviewed-by: Garming Sam <garming(a)catalyst.net.nz>
Change-Id: I2a7ce154dff4584c5db445cfd789a8c4f928a338
Reviewed-on: https://code.wireshark.org/review/23693
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=18d258ac46d11d584901537ac1f5e9…
commit 18d258ac46d11d584901537ac1f5e9341eff379e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 19:43:42 2017 -0700
pidl: Change *_get_pipe_fns() to return const struct api_struct *
Pick up change from Samba:
commit d368ee2298bc472caca940a3db7a4f855df6ca21
Author: Andrew Bartlett <abartlet(a)samba.org>
Date: Mon Nov 21 11:57:48 2016 +1300
pidl: Change *_get_pipe_fns() to return const struct api_struct *
This will allow the table to be made static const in the next commit
Signed-off-by: Andrew Bartlett <abartlet(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Reviewed-by: Garming Sam <garming(a)catalyst.net.nz>
Change-Id: Ib8cecaf695ccf70a78f97152e3286723cbc233ec
Reviewed-on: https://code.wireshark.org/review/23692
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f6d956cf92366e47470b63d366eb03…
commit f6d956cf92366e47470b63d366eb03ae26aa034a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 18:33:56 2017 -0700
pidl:NDR: add ReturnTypeElement() helper function
Pick up change from Samba:
commit d5e4707e98f3613acebb9d0de7e6f944f0b1efaf
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Tue Sep 13 09:06:50 2016 +0200
pidl:NDR: add ReturnTypeElement() helper function
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I3f4c8fb9b18ee10b031d9c58209d1c6c45bbec63
Reviewed-on: https://code.wireshark.org/review/23691
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9ab7b538f0ccd2b1cd35689cff4c28…
commit 9ab7b538f0ccd2b1cd35689cff4c280e18a97e7d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 18:32:09 2017 -0700
pidl:NDR: keep interface->{ORIGINAL}
Pick up change from Samba:
commit 7423d8106ef08b94821f5fc666892234feff6f05
Author: Stefan Metzmacher <metze(a)samba.org>
Date: Tue Sep 13 07:57:25 2016 +0200
pidl:NDR: keep interface->{ORIGINAL}
Signed-off-by: Stefan Metzmacher <metze(a)samba.org>
Reviewed-by: Andreas Schneider <asn(a)samba.org>
Change-Id: I8f088a7bbbdbd756a0d28169f8ed00f99d9a8cc3
Reviewed-on: https://code.wireshark.org/review/23690
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=181d9b1d26728a75a5e999571e7cec…
commit 181d9b1d26728a75a5e999571e7cec1e28ef1d34
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 24 23:07:13 2017 +0200
Windows: fix NSIS and WiX installers
Change-Id: I10f21de6ee9cf403690c66d02cbbd43ebb9d52bc
Reviewed-on: https://code.wireshark.org/review/23689
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1f3e36534175853a3c4849d60396bf…
commit 1f3e36534175853a3c4849d60396bf67dd1f46ce
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 24 19:05:42 2017 +0100
GTK: Fix warning for missing action
(wireshark-gtk:17990): Gtk-WARNING **: 29WestUIMStreamFlowGraph: missing action
/Statistics/29West/UIM/StreamFlowGraph
Change-Id: I02bd6a172390ac072485cf2158b7c5205fd11ee2
Fixes: b5759cafae8f1cf852f39fe68accd126d40955cb
Reviewed-on: https://code.wireshark.org/review/23678
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=15b67769922c32bddc66c90ca44808…
commit 15b67769922c32bddc66c90ca4480817e757b193
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Sep 24 17:00:29 2017 +0200
sharkd: close server file descriptor in child.
Change-Id: I65713f6d49fccb2045a99636d0d2f1aa5be44b83
Reviewed-on: https://code.wireshark.org/review/23677
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=7517b73e74bd3a425406e08fa0ce66…
commit 7517b73e74bd3a425406e08fa0ce667a655ee049
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 13:01:49 2017 -0700
Replace DISSECTOR_ASSERT(hfinfo->type == FT_STRING) with
DISSECTOR_ASSERT_FIELD_TYPE.
That produces better error messages, giving the name of the offending
field.
Change-Id: I155ac29c68ecd7811cc9752980db9cdc37fea72e
Reviewed-on: https://code.wireshark.org/review/23685
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a9963c45e79440094df221dfcb34b1…
commit a9963c45e79440094df221dfcb34b11ba94f0882
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 12:36:53 2017 -0700
Move DISSECTOR_ASSERT_FIELD_TYPE_IS_TIME after
__DISSECTOR_ASSERT_FIELD_TYPE_IS_TIME().
That's consistent with the other DISSECTOR_ASSERT_FIELD_TYPE... macros.
Change-Id: I1f5711b29ae8a440b0529373eb7903ff122ea18e
Reviewed-on: https://code.wireshark.org/review/23681
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bb9e8d109efb91c0af46f51846388d…
commit bb9e8d109efb91c0af46f51846388d4487ca1690
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 24 12:03:31 2017 -0700
Use proto_tree_add_ipv4(), not proto_tree_add_uint(), to add FT_IPV4 fields.
Change-Id: I178171e03d0ab7bedfeb9f04be01de22f7c177d4
Reviewed-on: https://code.wireshark.org/review/23679
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=21f6dca753c6e562eda6dae0dd754f…
commit 21f6dca753c6e562eda6dae0dd754f7b96026383
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sun Sep 24 13:08:13 2017 +0200
sharkd: don't go to background when using stdin and stdout.
Patch will allow to use stdin/stdout on other than windows platforms.
Change-Id: I729ebd4efaa1675956b085e74b413805125a7d7a
Reviewed-on: https://code.wireshark.org/review/23676
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=d7ec2cbc38dc12b27bae3d043ae93a…
commit d7ec2cbc38dc12b27bae3d043ae93aafe94caf91
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Aug 31 14:39:30 2017 +0100
autotools: Use package flags to configure libpcap
Change-Id: Icd64014b597a8e60d2aff9d180c441c6ffccff26
Reviewed-on: https://code.wireshark.org/review/23329
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=69bfcbc67ece916630d212a9cc0946…
commit 69bfcbc67ece916630d212a9cc094694182df4f6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 24 09:19:54 2017 +0100
CMake: Print build flags just before feature summary
Change-Id: I79cc1df1eb04c5ed9bed722f07fdea7db2adcede
Reviewed-on: https://code.wireshark.org/review/23674
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=cf4abe137661c7bd6ac5d1fd194969…
commit cf4abe137661c7bd6ac5d1fd194969f2debfcaac
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 24 09:31:12 2017 +0100
CMake: Pretty print PACKAGELIST
Change-Id: Ib87e0d4111f466e660435acf871036c0f1bb1555
Reviewed-on: https://code.wireshark.org/review/23673
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=dcf52a16954719906abcaf94d8a739…
commit dcf52a16954719906abcaf94d8a7391ba2cfeb43
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Sep 23 21:47:02 2017 +0100
Install libwiretap and libwscodecs headers
Change-Id: Ie7376ac5fd8a950e3c1c744ce4701b14ee1849ea
Reviewed-on: https://code.wireshark.org/review/23664
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=b44b7dee03a344822fbc38092b5e9d…
commit b44b7dee03a344822fbc38092b5e9dd6d84939bb
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Sep 24 08:06:56 2017 +0000
[Automatic update for 2017-09-24]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Iad48b3a81e83cf56ccec6cfb9075169379a775f4
Reviewed-on: https://code.wireshark.org/review/23669
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=26a8b576f41ea0e00834fc0f228173…
commit 26a8b576f41ea0e00834fc0f2281732f5817f388
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 24 08:14:03 2017 +0200
megaco: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ie85aa5806d3766c386970e8285a0755b61fca489
Reviewed-on: https://code.wireshark.org/review/23668
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=12684c7e4eb78a0ed665e09c4a7f6d…
commit 12684c7e4eb78a0ed665e09c4a7f6d9c454a932d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Sep 23 23:01:15 2017 -0700
Don't use proto_tree_add_uint() with FT_BYTES.
Change-Id: Ic647f39824e3d18a1a8d1aaef997ccd41db445c0
Reviewed-on: https://code.wireshark.org/review/23667
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e345d19b95adf0af37949c866636cd…
commit e345d19b95adf0af37949c866636cd8381451095
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sat Sep 23 13:32:10 2017 +0200
GPRSCDR: decoding of PDPType
Change-Id: Iec007c5276e30c982e776263ef753c002e2a9c72
Reviewed-on: https://code.wireshark.org/review/23660
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b13d5eac26db21d3b8682e861575bf…
commit b13d5eac26db21d3b8682e861575bf5344740f99
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Sep 23 17:35:54 2017 -0700
Don't look at the comment or process table with pre-2.2 files.
NetMon apparently didn't zero out the file header, so those fields have
random values in pre-2.2.
Change-Id: I3aeede6ab273d57ca937a5e18e67223fb4ed18da
Reviewed-on: https://code.wireshark.org/review/23666
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a065bb586e2334f5f1f1f4f0a247f3…
commit a065bb586e2334f5f1f1f4f0a247f309f7a04f46
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Sep 23 21:56:24 2017 +0200
WebSocket: remove useless pointer checks (CID 1418346)
websocket_conv is always allocated
Change-Id: Ic119e22ee37703ccea2a42e53d6616faa0901cf9
Reviewed-on: https://code.wireshark.org/review/23662
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c0fc66c67095f10a4dd4a22f3c5aaa…
commit c0fc66c67095f10a4dd4a22f3c5aaadcb7b245c2
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Sep 23 21:47:48 2017 +0200
PFCP: fix a typo (CID 1418345)
Change-Id: If87fa31dc4933f0b54946910559b4260424848e7
Reviewed-on: https://code.wireshark.org/review/23661
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c5403b6c1ec1c905ea0add21a25e61…
commit c5403b6c1ec1c905ea0add21a25e617cd2e76a6e
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Fri Sep 22 14:50:38 2017 +0200
Add lcap file extension to nsis and wix installers.
Also add ntar file extention to wix installer to match nsis
Change-Id: Idb6f660fda27c6ad3c3cd70acd482eafa2c14307
Reviewed-on: https://code.wireshark.org/review/23656
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=fd4dc6f115868f18e787f4bffaf8f8…
commit fd4dc6f115868f18e787f4bffaf8f8c5ceccff82
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 22 19:13:33 2017 +0100
plugins: Fixups for g9260461f4f
Put plugins in CMake build dir with a version subdir. This avoids some
weird special cases, however running with autotools from build dir
displays the wrong global folder in about->folders. Unfortunately
the hack to run from the autotools build dir is troublesome.
Various fixes for Windows builds.
Try to fix also build dir issue loading plugins on macOS with
ENABLE_APPLICATION_BUNDLE (blind).
Change-Id: Ic3c7c21f5850c12a53844202d61fa0592b45739c
Reviewed-on: https://code.wireshark.org/review/23657
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=caa9b19107a097a64552e5fc071f4d…
commit caa9b19107a097a64552e5fc071f4d7fd218b59e
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Thu Sep 21 17:04:23 2017 +0200
ZigBee ZCL SE Metering: Dissect functional notification flags and notification flags 2
to 5
Change-Id: Ia79c3e2609247846731a4b375b198702f06954de
Reviewed-on: https://code.wireshark.org/review/23649
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e7cc0279ab9a11319de521dfdf2505…
commit e7cc0279ab9a11319de521dfdf25057d1ff7ab7f
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Sep 22 21:57:50 2017 -0400
Have sequence analysis properly use filters from taps.
Sequence analysis has its own "filtering" system that required its
tap functions to look for some "filter flags". register_tap_listener()
already comes with a filter argument, so use that to simplify logic
of tap functions in dissectors.
Also have Qt GUI for Flow Graph look like other dialogs that have a
"Limit to display filter" checkbox.
Change-Id: I91d9d9599309786892f5b50c98692e52651e7174
Reviewed-on: https://code.wireshark.org/review/23659
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3c8750dfb3b9cef1af2e29159782b4…
commit 3c8750dfb3b9cef1af2e29159782b443dfcd32ff
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Sep 22 22:08:26 2017 +0000
Revert "CMake: Print a warning if CCACHE_CPP2 is unset."
CCACHE_CPP2 / run_second_cpp is enabled by default in ccache 3.3 and later.
(Unfortunately our builders have 3.2.4 installed.)
This reverts commit ed1ecfb39cf0f3344810fabb7a1b855d373aa0a8.
Change-Id: I3cc88fa70bb04db5ae254bc9b878ce379e47527d
Reviewed-on: https://code.wireshark.org/review/23658
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=ed967507848f09ea4320c3bde36cf9…
commit ed967507848f09ea4320c3bde36cf9020731793d
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 22 12:46:29 2017 +0200
nsis: Always create the extcap directory
Change-Id: I6955c242036c3aa76be4ceb545905ffeef906518
Reviewed-on: https://code.wireshark.org/review/23654
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b4fc86d2d5cd293c19b8c1e9db3d50…
commit b4fc86d2d5cd293c19b8c1e9db3d50e5fe0283ab
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Thu Sep 21 23:46:33 2017 +0200
ZigBee ZCL Attributes: Set length of attribute subtrees
Set length of attribute subtree by setting the end after the attribute has been
dissected
Change-Id: Ic8bb66206658525635c08f807651a37369d16f6a
Reviewed-on: https://code.wireshark.org/review/23651
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ed1ecfb39cf0f3344810fabb7a1b85…
commit ed1ecfb39cf0f3344810fabb7a1b855d373aa0a8
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Sep 20 16:19:04 2017 -0700
CMake: Print a warning if CCACHE_CPP2 is unset.
If we're compiling with clang and ccache, print a warning if CCACHE_CPP2
is unset. Doing so avoids generating a bunch of unwanted output when
warnings are enabled.
Change-Id: I6a796e8b910074ffa028ea45bc639b9461e1629e
Reviewed-on: https://code.wireshark.org/review/23646
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5f667694d3bbd57f13c26d3588d567…
commit 5f667694d3bbd57f13c26d3588d5671dfd30d09a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Sep 21 23:20:03 2017 -0400
Add Flow Graph functionality to TShark
Add flow graph functionality to tshark through -z option.
Output is same as ASCII format saved from GUI.
Change-Id: Iee0bfea7215858e6488b4728581be28287e9ea1a
Reviewed-on: https://code.wireshark.org/review/23652
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=620d54b1e3a4fcad1994409013f6a5…
commit 620d54b1e3a4fcad1994409013f6a5b2b76913b4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Sep 21 11:28:26 2017 -0400
Complete move of tap-sequence-analysis.c functionality to sequence_analysis.c
Since dissectors are now populating the timestamp of the seq_analysis_item_t
structure within the tap function, don't have the sequence_anaylsis redo it
when writing an ASCII file. This removes the need for the capture_file
parameter and simplifies the logic a bit.
Also just have GUI register the tap itself. It will provide for some more
flexibility in the future.
Change-Id: I55b2f951b977ea70ac9f7eb4929245b0779e5f0e
Reviewed-on: https://code.wireshark.org/review/23650
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bd28737d7f0e4cd30f68f16ee94dcc…
commit bd28737d7f0e4cd30f68f16ee94dcc0dfcf33ea3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Sep 21 15:40:40 2017 +0200
Diameter 3GPP: update S6a/S6d/S13/S13' AVPs
Change-Id: Ief76bcd529576ccd5324efb042acc4cad7d79c9b
Reviewed-on: https://code.wireshark.org/review/23648
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7ec31d06177d9c9c4356ad0403b04f…
commit 7ec31d06177d9c9c4356ad0403b04f4ea98db53f
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Sep 21 15:07:27 2017 +0200
[PFCP] Add more IE dissection.
Change-Id: I6fa21972bf937e92a0907c3cc544239e759659f9
Reviewed-on: https://code.wireshark.org/review/23647
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=137a4456d9c7d4fba5b6aa99bf6542…
commit 137a4456d9c7d4fba5b6aa99bf654232dbbb3d87
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Sep 20 15:11:50 2017 +0200
packetlogger: Add Syslog and Config types
Change-Id: I2b023283a004c4dd80e0afb1077493612c1cecc6
Reviewed-on: https://code.wireshark.org/review/23642
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ed158952210f79dab7365e325d3c18…
commit ed158952210f79dab7365e325d3c180fea26631e
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Aug 27 14:39:50 2017 +0100
cmake: look for Qt5 from Homebrew on macOS
When Qt5 is installed using Homebrew on macOS, Qt5 is not available in
the default prefix. Remove the hack from macos-setup-brew.sh and adjust
the search path instead. Note that is needed for development, "brew
install" has already set this option in the environment.
See https://github.com/Homebrew/homebrew-core/issues/8392
Change-Id: I57ea09b649a94c9a4cb18b1b2d334808e47ec27e
Reviewed-on: https://code.wireshark.org/review/23232
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=e2a2618d9bbad3be872b0f7b98647f…
commit e2a2618d9bbad3be872b0f7b98647fc901bcf93d
Author: Darien Spencer <cusneud(a)mail.com>
Date: Fri Aug 18 10:03:06 2017 +0300
UMTS RLC: Removing unused 'is ciphered' function
All calls to this function were commented out in a previous commit.
Also dealing with the state of the payload (ciphred or not) should be done within the
RLC dissector
Change-Id: Ice3a3ca8392d73c7b67308537d7568ab71a98b5e
Reviewed-on: https://code.wireshark.org/review/23644
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8a2a8776be41563b5c063a23e39d1…
commit a8a2a8776be41563b5c063a23e39d1e9aca052a0
Author: Darien Spencer <cusneud(a)mail.com>
Date: Wed Sep 20 22:48:22 2017 +0300
FP: Removed unused code
Removed old code which checked if frames are
ciphered and was '#if 0'ed.
Corresponding logic was implemented in the
RLC dissector in a previous commit.
Change-Id: Ie362771277b5c0b41e790c0297ded5ed91f813e2
Reviewed-on: https://code.wireshark.org/review/23645
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6be572006e5618aae3c59cb1b9a56c…
commit 6be572006e5618aae3c59cb1b9a56cdf6e1e49a1
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 19 12:12:31 2017 +0100
plugins: Add backward compatibility for personal lua scripts
Relax requirements for upgrades and make running side-by-side installations
more convenient.
Change-Id: I5299eed005a4748c54465dec90f477adb577e056
Reviewed-on: https://code.wireshark.org/review/23619
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=25ba538bc50ff3a824185cca532f4e…
commit 25ba538bc50ff3a824185cca532f4e0feb4f8ec4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 18 16:25:20 2017 +0100
plugins: Be more descriptive in "about wireshark"->"folders"
Display separate entries for binary plugins and lua scripts.
This is explained in the user guide, that the binary folder is
a subfolder of the lua folder, but it's probably a good idea to be more
explicit about it, at the risk of cluttering the interface a bit.
Move GeoIP information down because it seems the least important.
Add helper functions to provide plugin version subdir.
Change some #ifdefs while at it for legibility.
Change-Id: Ieb8665df029b3c14de19e2c973bd9b1cc4ec4621
Reviewed-on: https://code.wireshark.org/review/23609
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f1501b82a7354de76a8d3833db2aa8…
commit f1501b82a7354de76a8d3833db2aa8fa8b9d62e0
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Sep 20 16:08:56 2017 +0200
[MEGACO] In dissect_megaco_eventsdescriptor() check for dm(DigitMap) not
only d as it may get confused with dt(delayTime).
Change-Id: Ie5ac2a117f2d9e4a231d8ee15c795b3abdc4da07
Reviewed-on: https://code.wireshark.org/review/23643
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b1395ce1f70889b07075e6d6841fe3…
commit b1395ce1f70889b07075e6d6841fe3e91474084c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Sep 20 11:46:01 2017 +0000
tibia: fix 'tibia.vip' exists multiple times with NOT compatible types:
FT_BOOLEAN and FT_UINT32
Change-Id: Icd9171d01ba06faf2e109879de2f5685ac5964bc
Reviewed-on: https://code.wireshark.org/review/23638
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a5ed8266bf6c05544a1610923c3a85…
commit a5ed8266bf6c05544a1610923c3a857b3f12997e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Sep 20 11:54:55 2017 +0000
messageanalyzer: fix 'etw.ndis.packet_metadata.wifi_channel' exists multiple
times with NOT compatible types: FT_INT32 and FT_UINT32
Change-Id: I402eb393da5a4cfd4fa19e4f3166bcf9ee058f96
Reviewed-on: https://code.wireshark.org/review/23641
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fd0e0513f03514399bd4c3634778de…
commit fd0e0513f03514399bd4c3634778de9b3f8051ab
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Sep 20 11:47:33 2017 +0000
PFCP: fix 'pfcp.mp' exists multiple times with NOT compatible types: FT_UINT24
and FT_BOOLEAN
Change-Id: I3099da21dedec71b0ebf130420f83234300339b3
Reviewed-on: https://code.wireshark.org/review/23639
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1768cea96f233d36e3c5a2f539128f…
commit 1768cea96f233d36e3c5a2f539128f029139d872
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Sep 20 11:49:12 2017 +0000
GTPv2: fix 'gtpv2.uli_lai_flg' exists multiple times with NOT compatible
types: FT_BOOLEAN and FT_UINT8
Change-Id: I14fbe09aad243d65da0af5ab623a1ec67eeac893
Reviewed-on: https://code.wireshark.org/review/23640
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ee4c70b92cfa0b44eed3d0d07078f9…
commit ee4c70b92cfa0b44eed3d0d07078f943ce34c56a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Aug 31 23:56:25 2017 +0000
Add version.conf to git-export-release.
Create and stash version.conf before archiving our repository. This
makes git-export-release behave more like the current Autotools dist
target.
Make sure the `git describe` command in git-export-release and
make-version.pl use the same match pattern and abbreviation length.
Abbreviate to 8 characters. That's our current unique minimum according
to the git-unique-abbrev script at
https://blog.cuviper.com/2013/11/10/how-short-can-git-abbreviate/ :
516409 objects
4: 516194 / 65293
5: 200900 / 92205
6: 15979 / 7957
7: 1038 / 519
8: 74 / 37
9: 0 / 0
Change-Id: Id2279a59a2e24a9ecd816458f399bcd2b4c94185
Reviewed-on: https://code.wireshark.org/review/23344
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=72415b50661c639d0f1fb7e261241d…
commit 72415b50661c639d0f1fb7e261241da73cd4867c
Author: Darien Spencer <cusneud(a)mail.com>
Date: Wed Sep 20 09:47:54 2017 +0300
FP: Comments Fixes
Consistant usage of "UE ID"
Consistant usage of "reassembly"
Removed unused commented code
Change-Id: I9e03d439d75443f8fc0a5eb5a7ef10f6ae54e3f4
Reviewed-on: https://code.wireshark.org/review/23633
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6db17741e49b6b7d519f5044971065…
commit 6db17741e49b6b7d519f50449710658c54a58dbc
Author: Unknown <cusneud(a)mail.com>
Date: Wed Sep 20 08:58:54 2017 +0300
FP: Properly configure standalone PS RAB DCHs
Added a check based on transport format to spot DCHs carrying a single
PS RAB and configure them properly.
Also renamed "special case dch 24" with it's actual meaning - a muxed
CS & PS RABs
Change-Id: I730b6d617d9e15bcbb5d7fde09dcd2273d943e18
Reviewed-on: https://code.wireshark.org/review/23632
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=eefec698611d7a982ce55eb7343df5…
commit eefec698611d7a982ce55eb7343df5e8eb0343c9
Author: Darien Spencer <cusneud(a)mail.com>
Date: Fri Sep 15 18:47:32 2017 +0300
UMTS RLC: Hide deciphering preference by default
Unless wireshark is compiled with a KASUMI implementation, trying to decipher RLC will
always fail.
Change-Id: I0d44514579fbfcd21fe8c2b74c566c54f94e4698
Reviewed-on: https://code.wireshark.org/review/23557
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e27870eaa6efa1c2dac08aa41a67fe…
commit e27870eaa6efa1c2dac08aa41a67fe9f0839e6e0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 20 10:14:56 2017 +0200
RTSP: fix stack use after scope error reported by ASan
Bug: 14077
Change-Id: I9fa0e62fe354b1c18687ba9041029de97719343c
Reviewed-on: https://code.wireshark.org/review/23635
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f9207b0f6c9d5aa5a1dfd774836548…
commit f9207b0f6c9d5aa5a1dfd7748365483795293a5d
Author: Kevin Hogan <kwabena(a)google.com>
Date: Sun Sep 3 07:07:37 2017 -0700
Qt: Restore ability to display RTT by sequence number
Adds a checkbox to the TCP Stream Dialog's "Round-trip-time"
graph tab that allows user to choose sequence number
on the x-axis rather than time.
Bug: 13740
Change-Id: Iaf881318437c7eecd16cf6c1f8745283ce9b4a7d
Reviewed-on: https://code.wireshark.org/review/23376
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ded1d1089adfa969f660d0ddbb9439…
commit ded1d1089adfa969f660d0ddbb94394b27fa4b0f
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Aug 30 23:20:21 2017 +0200
CMake: fix extcaps dependency list
When compiling the list of dependencies for the extcaps target, add only
those targets that we're actually building. If we skip an extcap, e.g.
because we're missing libraries to build it, don't add this extcap to
the dependency list.
This issue was observed on a Debian box that had no libssh-gcrypt-dev
package installed. Running cmake would create a warning about
non-existent dependencies of the extcaps target.
-- Configuring done
CMake Warning (dev) at CMakeLists.txt:3217 (add_dependencies):
Policy CMP0046 is not set: Error on non-existent dependency in
add_dependencies. Run "cmake --help-policy CMP0046" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
The dependency target "ciscodump" of target "extcaps" does not
exist.
This warning is for project developers. Use -Wno-dev to suppress it.
Change-Id: I7335173fce9833423b0e9443589143cc1a122ac0
Reviewed-on: https://code.wireshark.org/review/23321
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4458d0b59f41382783820d90b99a56…
commit 4458d0b59f41382783820d90b99a5687ca0ccd33
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Sep 10 18:03:14 2017 +0100
Snort: check executable and config files exist before trying to run.
Change-Id: I63986a61b392a74406ccefeaa001c110793c340a
Reviewed-on: https://code.wireshark.org/review/23469
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a17bbc184170cf2faf4752f63f4dce…
commit a17bbc184170cf2faf4752f63f4dce0bba9e0dd5
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Sun Sep 17 23:48:12 2017 +0200
qt: Fix some leaked menu objects
Calling QPushButton.setMenu and QMenu.addMenu does not transfer ownership
of the menu. Fix some leaks by letting "receiving" object act parent
for the menu object.
Bug: 14071
Change-Id: Id4edaf895503ef5dd4597eac99c2cdd6ad09b2ff
Reviewed-on: https://code.wireshark.org/review/23600
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3ce30eb1fd395251696c4cbf42b52c…
commit 3ce30eb1fd395251696c4cbf42b52cfd5b150404
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Thu Sep 14 14:53:18 2017 +0200
Fix leaks related to recent settings
Fix leaks related to recent settings reported by Valgrind simply after
starting/stopping
application.
Bug: 14071
Change-Id: Ib4f205218945c8776724899c0dd99cc81b79a41d
Reviewed-on: https://code.wireshark.org/review/23599
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8f4692f6f94d06d3fa3926333d3ffd…
commit 8f4692f6f94d06d3fa3926333d3ffd3354066f96
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Sep 19 17:31:11 2017 -0400
Explicitly add ICMP and ICMPv6 to Flow graph.
Functionality for ICMP was "hidden" in the frame/"any" flow.
Pull it out into its own using the new sequence analysis API.
Change-Id: I2035f1a59a9e46ea1086443ad4b4a9723dc13883
Reviewed-on: https://code.wireshark.org/review/23625
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b5759cafae8f1cf852f39fe68accd1…
commit b5759cafae8f1cf852f39fe68accd126d40955cb
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Sep 19 21:49:55 2017 -0400
Integrate LBM UIM Flow dialog into "regular" Flow diagram.
Reduce all of the code duplication and just register the sequence
analysis functionality in LBM dissector.
Change-Id: I6cb5a7f0a92b04357334bbae301fa2d730a21994
Reviewed-on: https://code.wireshark.org/review/23630
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8db4ddd40c6858109369156f6ae7b1…
commit 8db4ddd40c6858109369156f6ae7b14c40c3b8df
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 18 15:45:17 2017 +0100
Rename get_plugin_dir() for consistency
WS_DLL_PUBLIC const char *get_plugin_dir(void);
WS_DLL_PUBLIC const char *get_plugins_pers_dir(void);
Opt for the plural form consistently (for public functions at least).
Change-Id: I8a5861ad7f90f9c87168bd3275bd9dbc5c83b749
Reviewed-on: https://code.wireshark.org/review/23608
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bbbec5552d44fde57e57f529460591…
commit bbbec5552d44fde57e57f52946059182482ab987
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Sep 19 23:16:44 2017 +0200
windows-common: remove volatile qualifier from num_aces
A variable in a dissector must only be volatile if it's used inside a
CATCH block. This is not the case for num_aces.
Change-Id: I3aedb9ad2f8b96f56c9be2120276b552602658a1
Reviewed-on: https://code.wireshark.org/review/23624
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=70263eade4cadd157f0322d6df3dd7…
commit 70263eade4cadd157f0322d6df3dd79bfec26242
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Sep 19 23:13:34 2017 +0200
Qt: main window slots: don't connect setCaptureFile to DecodeAsDialog
The refactored DecodeAsDialog class has no setCaptureFile slot any more.
It seems it's always in the foreground and there's no way to change the
capture file while the DecodeAsDialog is active.
The dangling connection caused a warning
QObject::connect: No such slot
DecodeAsDialog::setCaptureFile(capture_file*)
in ../ui/qt/main_window_slots.cpp:2881
QObject::connect: (sender name: 'MainWindow')
QObject::connect: (receiver name: 'DecodeAsDialog')
Change-Id: Ibb12b9cdded3c6b7cca40ce08874bc4f1af4eec7
Reviewed-on: https://code.wireshark.org/review/23623
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=253fcfa22182e123d4adfb54c2610e…
commit 253fcfa22182e123d4adfb54c2610e579f54a6db
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Sep 19 15:53:05 2017 +0200
6lowpan: Create ifcid from AT_ETHER
This will reassemble source and destination addresses from Bluetooth
and Bluetooth LE.
Change-Id: I563ef7b411488a2ba99fe2284eca0445208cf7e1
Reviewed-on: https://code.wireshark.org/review/23618
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0d869dae1e17804b79142565e1c938…
commit 0d869dae1e17804b79142565e1c938339446b81e
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Tue Sep 19 18:51:36 2017 +0200
Sequence (flow) analysis: fill timestamp when creating item.
Change-Id: Ie1b82d016b632162a91e2ed54a964662bc25e9d5
Reviewed-on: https://code.wireshark.org/review/23620
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4930772178a779d57d694b71b5786f…
commit 4930772178a779d57d694b71b5786ff4ca792c3c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 19 22:28:55 2017 +0200
WebSocket: check websocket_extensions pointer validity
Bug: 14075
Change-Id: I825a30e5b8bfa57a020ae208a3a6ee67ee1a58d3
Reviewed-on: https://code.wireshark.org/review/23622
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=941fac1be27fa81737446bed9de0df…
commit 941fac1be27fa81737446bed9de0dfba526752ac
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Tue Sep 19 15:30:56 2017 +0400
IXIA lcap support
IXIA^WKeysight Technologies's vitual IxNetwork version 8.30 will
create capture files in a modified format: It uses a different magic
and adds the total size of all records, i.e. the filesize minus the
headersize. Add support for this.
v2: Different file types use different magic numbers.
Not yet tested/supported: The default fileending is .lcap
Bug: 14073
Change-Id: Ida90b188ca66a78ff22dca237e4fd6b22e02dc14
Reviewed-on: https://code.wireshark.org/review/23614
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dae91bcb9048711d788affea3a5fee…
commit dae91bcb9048711d788affea3a5fee02f24df275
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Sep 19 16:09:35 2017 +0200
[PFCP] Add more IE dissection.
Change-Id: Ib055d43fa13aa826ce449ad93cecaab9617d75db
Reviewed-on: https://code.wireshark.org/review/23617
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1783a3b7df3b5fae62b40617eda6db…
commit 1783a3b7df3b5fae62b40617eda6db8368b1085f
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Sep 19 15:49:06 2017 +0200
btle: Use bd_addr as link-layer address in data PDU
This can be used in a higher layer 6LoWPAN to recreate the source
and destination addresses.
Change-Id: I967c3ac7c3a50526a10bec067521419d0aed8b4f
Reviewed-on: https://code.wireshark.org/review/23616
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8615e78630e8deace183d150e2c1e5…
commit 8615e78630e8deace183d150e2c1e5fc60d561ba
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Aug 18 20:11:47 2017 +0100
Disable flex-generated [-Wsign-compare] warnings
Change-Id: Iace0462e6bb50573f3e4603f7a19e4b7ee1f9733
Reviewed-on: https://code.wireshark.org/review/23541
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=dd5875c487dea7e75b3653485d153c…
commit dd5875c487dea7e75b3653485d153c0dab909699
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 18 22:48:11 2017 -0400
Sequence analysis (flow graph) optimizations for dissectors
1. Remove protocol member from seq_analysis_item_t.
It's not used by any GUI, so don't burden dissectors with populating it.
2. Allow any dissector to change colors display by flow graph
3. Provide helper functions that may be common if other dissectors
want to create sequence analysis.
Change-Id: I04fa3c9f3cf6879ab9a8d7d6f4896b4979d010d7
Reviewed-on: https://code.wireshark.org/review/23613
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8a25ac7306b9eef5c7d75ee1c610eb…
commit 8a25ac7306b9eef5c7d75ee1c610eb2b0a8144fe
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Mon Sep 18 15:22:18 2017 +0200
qt: Fix leaked style for OverlayScrollBar
The QWidget::setStyle method does not transfer ownership of supplied
style object. Fix leak by letting OverlayScrollBar free styles
created.
Bug: 14071
Change-Id: Ibc14cadfc6d012e8a909be21b4f8974009fa75f5
Reviewed-on: https://code.wireshark.org/review/23601
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=16fc1903037dead72d5f6ff1457552…
commit 16fc1903037dead72d5f6ff1457552d23b4a423f
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Thu Sep 14 10:19:12 2017 +0200
prefs: Fix leak when parsing empty pref string
Fix minor leak. When parsing preference string lists and preference
is empty a buffer is allocated to hold the string but is then never
inserted into the string list as it is empty. This causes a minor leak
as no reference is kept to allocated buffer and won't be freed by
corresponding clear string list function call.
Bug: 14071
Change-Id: I1edcc77095c0f430e03a49491e5281730fbceb95
Reviewed-on: https://code.wireshark.org/review/23598
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6bc4de9a2674f86e70bb5fdff48e86…
commit 6bc4de9a2674f86e70bb5fdff48e861f3f5e48c5
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Sep 18 20:24:20 2017 +0200
Qt: Add key events to accept and reject changes in FilterExpressionFrame
Change-Id: Iba3fe50b3ca4953fc59ebd6235d04f6878d183a4
Reviewed-on: https://code.wireshark.org/review/23607
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f68185573703ad5457dfd8198b779b…
commit f68185573703ad5457dfd8198b779bb25b8e5023
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Sep 18 19:56:54 2017 +0200
Qt: Fix FilterExpressionFrame layout
- Use QToolButton for "Filter Buttons Preferences..." button
- Remove QVBoxLayout layout for Cancel and OK buttons
Change-Id: Ic5d4e96ca1c421750dc45f81a7d15f8ad637649d
Reviewed-on: https://code.wireshark.org/review/23606
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=59fce46d01582e0d2ffd3a606fdd8b…
commit 59fce46d01582e0d2ffd3a606fdd8b50c713f6a1
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Sep 18 19:20:50 2017 +0200
Qt: Add key events to accept and reject changes in PreferenceEditorFrame
Change-Id: I4a9c4b80b0438cd33c38b274a24a3b1b5db46cb8
Reviewed-on: https://code.wireshark.org/review/23605
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=939ea8c8ed2b96b2959a1c9869ac5f…
commit 939ea8c8ed2b96b2959a1c9869ac5fe6237808f9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Sep 17 19:40:44 2017 +0200
Qt: Make ColumnEditorFrame use FieldFilterEdit to get a autocomplete list
Change-Id: I81d5f46d572aa3f0fa1b5b94741697fc72554d2e
Reviewed-on: https://code.wireshark.org/review/23587
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=3cb95b0521222766890fdd77d3f629…
commit 3cb95b0521222766890fdd77d3f6294c98644321
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Sep 17 18:57:25 2017 +0200
Qt: Add key events to accept and reject changes in ColumnEditorFrame
Change-Id: I5f9ee01ee3aca5b2d75136fff3d8dc3e90ca1a4e
Reviewed-on: https://code.wireshark.org/review/23585
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=adf170c23d179dcec29c86c22151ed…
commit adf170c23d179dcec29c86c22151ed19684f6209
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 12 14:48:43 2017 +0200
WebSocket: add permessage-deflate extension support
Bug: 14054
Change-Id: Ib6fbb58cab4d9eb140c0911391a9c330a036cfd1
Reviewed-on: https://code.wireshark.org/review/23515
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e79320f2a02169569998447a59c54a…
commit e79320f2a02169569998447a59c54a9d0ef38fcb
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Sep 18 10:05:52 2017 +0200
automake: Add -Wcomma as a warning flag.
Change-Id: I93a8cefe08068f8028de01b3312f04cc05eb4f5c
Reviewed-on: https://code.wireshark.org/review/23597
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=96100963afbfb4ae1f6584eb47d0e9…
commit 96100963afbfb4ae1f6584eb47d0e9f64eb3e432
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Sep 18 15:56:25 2017 -0700
TDS: Fix some URLs and add a note about our heuristic check.
Wayback-ize a couple of URLs. Note that we might be able to improve our
heuristic check by checking various string lengths. (I didn't add the
checks myself because I don't have any TDS captures with login packets.)
Change-Id: I3d67c66a292fd02035a15e1e047227f55314737a
Reviewed-on: https://code.wireshark.org/review/23612
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b365a3e19ab7449579898a8563468a…
commit b365a3e19ab7449579898a8563468a0f0301320f
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Sep 16 17:46:15 2017 +0200
sharkd: support flows (sequence analysis)
Change-Id: Ie85295dbcfab3efe7ba05c5c9c7ae22d0c6eedec
Reviewed-on: https://code.wireshark.org/review/23572
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c41bab1f667cfe51b09b80869497a2…
commit c41bab1f667cfe51b09b80869497a2db68abecce
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Sep 16 16:52:23 2017 +0200
Move most of sequence analysis code from ui/ to epan/
Create registration system to allow creation of analysis items
to be localized to the dissector. For now only frame (all) and
TCP are supported.
VOIP functionality will be covered in a separate patch.
Change-Id: I5b05ef6d5afff8d0b162b03a0f451ab810602e81
Reviewed-on: https://code.wireshark.org/review/23571
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a593fce94cb7fd0fa3f5eef7fae9c0…
commit a593fce94cb7fd0fa3f5eef7fae9c0128cb6f7e3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Sep 18 12:48:00 2017 -0700
Update list of symbols for Debian.
Change-Id: I4ba02f37fcfbae01d43d7fdf5e5361373a2b0391
Reviewed-on: https://code.wireshark.org/review/23611
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e1933093187a9e48eb51a536110ff2…
commit e1933093187a9e48eb51a536110ff2b313617f70
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Sep 18 17:20:36 2017 +0200
[PFCP] Dissect more IEs.
Change-Id: Ic3a32f3317af81289da0be73474f4a8882d4bf43
Reviewed-on: https://code.wireshark.org/review/23603
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=88b88a0e809029c7f74f97c22ae9ee…
commit 88b88a0e809029c7f74f97c22ae9ee449bf4f749
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 17 19:21:01 2017 +0100
Qt: Fix -Wimplicit-fallthrough with GCC
../../../ui/qt/models/decode_as_model.cpp: In member function ‘virtual QVariant
DecodeAsModel::data(const QModelIndex&, int) const’:
../../../ui/qt/models/decode_as_model.cpp:155:13: error: this statement may fall
through [-Werror=implicit-fallthrough=]
Change-Id: I29654a0f6ce6cce7bc778231bc8d6e602875104f
Reviewed-on: https://code.wireshark.org/review/23589
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0a5205b412b6b7d2a8062b3f31e10f…
commit 0a5205b412b6b7d2a8062b3f31e10f883bd8d9aa
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Sep 13 17:22:05 2017 +0200
[PFCP] Add more IE dissection.
Change-Id: I26a75055d0a4fee209d2d118dd9403d614739d76
Reviewed-on: https://code.wireshark.org/review/23525
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8240518f91fb0215c6e031bd8761e7…
commit 8240518f91fb0215c6e031bd8761e72dd755da5f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Sep 15 00:09:48 2017 +0100
TLS13: restore draft -18 support for HRR
Draft 18 is still the most current boringssl version, avoid a malformed
packet exception by recognizing a draft -18 HelloRetryRequest.
Change-Id: I43cf91350a8a2ebfad6c1e0e35eb9621a3b3e44b
Fixes: v2.3.0rc0-2789-g18c4d1bb1f ("TLS13: update HRR for draft -19")
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23544
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=aa2b59cf5e9cc4a60e839652124376…
commit aa2b59cf5e9cc4a60e839652124376e65818b885
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Sep 15 00:14:00 2017 +0100
TLS13: restore draft -18 support for CertificateRequest
Prevent a malformed packet exception with draft -18 CertificateRequest
message which would break further decryption. Tested with
tls13-18-certreq.pcap from the linked bug.
Change-Id: I00be21935370d0f0be66d2dbc87ee9fea3bb889a
Fixes: v2.3.0rc0-2761-g0e244e01fe ("TLS13: update CertificateRequest dissection
for draft -19")
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23543
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ecb6c88c073798635b55195c2e2dd7…
commit ecb6c88c073798635b55195c2e2dd7e9cff60b20
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Sep 17 18:52:10 2017 +0200
Qt: Improved ColumnEditorFrame validation checks
Use common validation checks for fieldsNameLineEdit and occurrenceLineEdit.
No need to check for COL_CUSTOM and empty occurrence because this will
give a valid value anyway.
Change-Id: I8981a15954e9a55a9a43e4a5760b34d83aa2e1ca
Reviewed-on: https://code.wireshark.org/review/23584
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=40f737dabea1a973fc969cc1d6950c…
commit 40f737dabea1a973fc969cc1d6950c1ad2ff1ec3
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Sep 17 04:26:31 2017 +0400
Update ldp TLVs from iana webpage (scripted).
Change-Id: I1cb4210d4af93303298485c86627027adecd6052
Reviewed-on: https://code.wireshark.org/review/23578
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=b40ad7c2ffb3776c7002ce7b3c4aad…
commit b40ad7c2ffb3776c7002ce7b3c4aade42de319c7
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Sep 17 18:51:06 2017 +0100
ZigBee: fix buffer overrun in zbee_sec_add_key_to_keyring
"key" is a guint8 array of ZBEE_APS_CMD_KEY_LENGTH, compare its value
and not the pointer.
Bug: 14070
Change-Id: I8add2bbcc04f9bbbc9502a07aa34d35b5a67e1c1
Fixes: v2.5.0rc0-1007-gf63fc33362 ("ZigBee: implemented a dissector for ZBOSS key
dump")
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3408
Reviewed-on: https://code.wireshark.org/review/23588
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8dbb21dfde14221dab09b6b9c7719b…
commit 8dbb21dfde14221dab09b6b9c7719b9067c1f06e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 17 21:46:09 2017 +0200
DMP: check 7bit string length before decoding it
Bug: 14068
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3372
Change-Id: Ib9ff63e2ef8d3c2546f357534c374a662e70e43c
Reviewed-on: https://code.wireshark.org/review/23591
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=e77d4dffff3eb189cd9e1cbb7ee9c7…
commit e77d4dffff3eb189cd9e1cbb7ee9c7561f439999
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 17 21:15:08 2017 +0200
RRC: check wmem_strbuf_t pointer before using it
Digit field is also ussed by other fields than PLMN-Identity and
IMSI-GSM-MAP
Bug: 14069
Change-Id: Ic8cf4dc148fecf24e28ef1be21c3968d46e4b456
Reviewed-on: https://code.wireshark.org/review/23590
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=17651065a57f912ebb11d731d50a22…
commit 17651065a57f912ebb11d731d50a2245cbeda494
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Sep 16 12:47:30 2017 +0200
cmake: Add option to disable -Wframe-larger-than
In some editors (like Xcode) it's possible to turn on and off
ASAN and UBSAN independent of the settings in CMake.
This option will disable the -Wframe-larger-than= flag even if
ASAN or UBSAN are not turned on in CMake.
Change-Id: I70b1ae544fe87093d0f5ce7ceb191f33399191ea
Reviewed-on: https://code.wireshark.org/review/23567
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=66d39cc60b59b4e8cedd8c46deb32a…
commit 66d39cc60b59b4e8cedd8c46deb32a0ec2a35d98
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 17 18:04:25 2017 +0100
Add comment to docinfo.xml to note make-version.pl update
Change-Id: I71e4352c94515e4edc3a7bda6851ecfd404800ef
Reviewed-on: https://code.wireshark.org/review/23586
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0bfafb3e7a41876805922d87a52307…
commit 0bfafb3e7a41876805922d87a52307305e2bc8d0
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 11 02:20:03 2017 +0100
plugins: Change personal plugin dir path on Unix
Installing machine code to XDG_CONFIG_HOME is problematic.
Use ~/.local/lib/wireshark/plugins instead.
XDG_CONFIG_HOME should be architecture independent. This allows copying the
configuration between different architectures safely.
Reference: https://www.freedesktop.org/software/systemd/man/file-hierarchy.html
Change-Id: I1b18f64aab4dd351d611cfbea3b9333f23c98bfa
Reviewed-on: https://code.wireshark.org/review/23498
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=9260461f4fcc78ed7d4ac9936508dc…
commit 9260461f4fcc78ed7d4ac9936508dcd57ed40e6b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 10 23:08:14 2017 +0100
plugins: Use minor version number for plugin install path
Wireshark patch releases (X.Y.Z) are binary compatible so reflect
that in the plugin installation path.
By installing to $pkglibdir/plugins/X.Y out-of-tree plugins don't
need to be reinstalled with every patch release.
Change-Id: I9d1728e6fb12bcb51d2a723af22c750cb7a966cf
Reviewed-on: https://code.wireshark.org/review/23497
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=978f6b4e1a94c831fa90421b6127e1…
commit 978f6b4e1a94c831fa90421b6127e14f6ec9de17
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 12 10:51:46 2017 +0100
plugins: Fix paths to match WSUG
The Wireshark User Guide seems to say:
Global lua plugins are in $pkglibdir/plugins
Personal lua plugins are in XDG_CONFIG_HOME/plugins
Global binary plugins are in $pkglibdir/plugins/$version
Personal binary plugins are in XDG_CONFIG_HOME/plugins/$version
Fix code to match that. This is a backward-incompatible change
for global lua plugins and personal binary plugins.
Adds a version subfolder to the personal plugin folder for binary plugins.
This allows for safe upgrades and side-by-side installations
with different prefixes (they no longer use the same personal dir).
Change-Id: Ie0f039113628a257625a9a9fb2cb30e532f5dd47
Reviewed-on: https://code.wireshark.org/review/23516
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=e8e8b0d0b46941f79535c020f5464c…
commit e8e8b0d0b46941f79535c020f5464c372d0138a7
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Sep 17 08:07:02 2017 +0000
[Automatic update for 2017-09-17]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I0b157ca377ef2e8f1a2502e51b542322dc0d36b2
Reviewed-on: https://code.wireshark.org/review/23580
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=21d2158a0bf39c08af6c5a24ef9895…
commit 21d2158a0bf39c08af6c5a24ef9895f819cd3af3
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 3 00:42:00 2017 +0100
CMake: Initial work to install headers for the benefit of plugins
To be continued incrementally to fix gaps and omissions.
If we are willing to reorganize the source tree to have one or two header
include folders this could be simplified considerably.
It would also force developers to give more consideration to API issues,
which is a good thing.
See also e7ef19efc0e928b50644b37772ccbf176e74f766.
Bug: 14062
Change-Id: I0759da2f9793cfb5cf92c9e231457bba43df4353
Reviewed-on: https://code.wireshark.org/review/23548
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=6c4b9360e59eb94e3219c6c1bf9a72…
commit 6c4b9360e59eb94e3219c6c1bf9a72a1c35a674d
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sun Sep 17 05:11:27 2017 +0400
Fix the trivial fix.
Change-Id: I95743eb53a3f30206a496163dea3b79f92a54b4e
Reviewed-on: https://code.wireshark.org/review/23579
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=51aaffb5f680ebea44b31b911dd716…
commit 51aaffb5f680ebea44b31b911dd71694a40254fe
Author: Masashi Honma <masashi.honma(a)gmail.com>
Date: Sun Sep 17 08:24:20 2017 +0900
ieee802.11: Add Element ID Extension dissector framework
The IEEE Std 802.11ai-2016 and 802.11-2016 defines Element ID Extensions.
This patch add the dissector framework of it.
Change-Id: I47b21959cc115743d6b2f0c691bc41f3059d45cd
Signed-off-by: Masashi Honma <masashi.honma(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/23577
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a5c79b8ec8ff147c94e17eeb131947…
commit a5c79b8ec8ff147c94e17eeb131947a57f461ec7
Author: Masashi Honma <masashi.honma(a)gmail.com>
Date: Sun Sep 17 08:23:25 2017 +0900
ieee802.11: Add FILS authentication algorithm number
The IEEE Std 802.11ai-2016 defines new algorithm number for FILS(IEEE 802.11ai)
at "9.4.1.1 Authentication Algorithm Number field" section.
Change-Id: I4351682d38efab2727e3a36741fe2f49508bba14
Signed-off-by: Masashi Honma <masashi.honma(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/23576
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4b8504f39a07e19f40b9df1548f840…
commit 4b8504f39a07e19f40b9df1548f8400ef6ae61a8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Sep 16 13:23:34 2017 -0700
Inquire what frame_size < msdu_length means.
Change-Id: Ie618ed61fb098bfe55529e31e9cc3f6bfe7d4ac0
Reviewed-on: https://code.wireshark.org/review/23575
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b93ef37da21699336273e846651dd4…
commit b93ef37da21699336273e846651dd4e7c499f4dc
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sat Sep 16 18:35:01 2017 +0400
_U_ is wrong in c++, as is Q_UNUSED (in most cases).
The correct way is to not name the variable.
interface_tree_cache_model.cpp is one of the exceptions: Use Q_UNUSED in a conditional
compile, instead of unconditionally.
Change-Id: If561e632a3a60d2424f454202f233e9a63926e78
Reviewed-on: https://code.wireshark.org/review/23570
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=be995cc12075e3ecbc3aeb2356835d…
commit be995cc12075e3ecbc3aeb2356835df8c75a220b
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Sat Sep 16 18:19:23 2017 +0400
_U_ is wrong in c++, as is Q_UNUSED (in most cases).
The correct way is to not name the variable.
Change-Id: Ic016f1b9161db6b4cc3f6534c853a1f50e31aa2b
Reviewed-on: https://code.wireshark.org/review/23569
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=27b074a61580fbf0e53debf58d49f2…
commit 27b074a61580fbf0e53debf58d49f2728cffe735
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 15 15:58:21 2017 +0100
make-version.pl: Update Wireshark version in User/Developer Guides
Change-Id: I5b14a6ae815e9e6e9c1705a8e38945e19dba479a
Reviewed-on: https://code.wireshark.org/review/23554
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=ec1a412cbd72570d0a7cd34fc68154…
commit ec1a412cbd72570d0a7cd34fc68154d4368d2509
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Fri Sep 15 20:41:38 2017 +0200
GTPv2: improve APN restriction IE
Change-Id: Id5fd2a0c6b09a1127ab867bf2e5bc44a0cd2acd6
Reviewed-on: https://code.wireshark.org/review/23565
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=800c179dfa4a3576e48141f9324b7a…
commit 800c179dfa4a3576e48141f9324b7abd47ef6d61
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Sep 16 12:21:04 2017 +0200
cmake: Add -Wcomma as a warning flag.
Change-Id: I90827ac2cd2277a969d25996392ad1627fc6c530
Reviewed-on: https://code.wireshark.org/review/23566
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=69250aa51eac68015e520f5680970d…
commit 69250aa51eac68015e520f5680970ded2db1ee14
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jul 9 13:44:06 2017 -0400
Add support for dissector tables of type FT_NONE.
This is for dissectors that have "payloads" that don't have
a unique identifier to determine a sub dissector.
For the command line parameter -d, specifying a selector is no longer
required for dissector tables of type FT_NONE.
Change-Id: I3370d9e0dc147deeca4f26b842fe35dc3bda876e
Reviewed-on: https://code.wireshark.org/review/22574
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7d65b573f2734017be416f31852c4e…
commit 7d65b573f2734017be416f31852c4ede42bd987b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jul 9 13:47:59 2017 -0400
Have register_decode_as_next_proto create dissector table.
For protocols that have don't have a unique identifier for their
payload, have register_decode_as_next_proto be a one stop shop to
create Decode As functionality and a dissector table of type FT_NONE.
Change-Id: Ic1f2e9ed0aee0554a4eb8f232630b99c0604dfc0
Reviewed-on: https://code.wireshark.org/review/22575
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d992e85fe8e9192cb730abf8796336…
commit d992e85fe8e9192cb730abf8796336d3b6d6fd50
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Jul 14 15:21:37 2017 -0400
Refactor Decode As dialog to use a model/delegate
The model provides a lot more flexibility and abstracting the
data from the view (dialog)
Noticeable changes from user perspective:
1. Value column doesn't always have a combobox. If registered decode as
structure doesn't support multiple values, a simple edit box is used.
2. Existing value will always be a choice (default) in the Value combobox.
3. Duplicate values in Value combobox have been removed (for things like
UDP port where source port and dest. port are same)
4. When adding/copying a decode as item, only first column (table) is
editable, not the whole column.
5. Separator always present in Current protocol column to distinguish
"none" from rest of protocols.
6. "Current" protocol defaults to "default value" when first added
to the
list instead of "none".
Noticeable changes from developer perspective:
1. Code is much more spread out, but most new additions (like DCE/RPC support)
should be limited to the model class (maybe delegate). The dialog class
probably won't change much anymore.
2. decode_as_dialog.ui is much less useful because information is provided through
model and delegate.
Change-Id: I70a667cab2c07d251ab370430bc51e5c1f4a3a02
Reviewed-on: https://code.wireshark.org/review/22625
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c98a7363dafdb1a261068a3e7312e6…
commit c98a7363dafdb1a261068a3e7312e66dcdf2c329
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Fri Sep 15 14:00:07 2017 +0200
gtp: add readable numbers
Change-Id: I95f814d2a92d8c585db57f8ab32e6a84a8eeeb6d
Reviewed-on: https://code.wireshark.org/review/23564
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=060eaaee51f4beb4605e96e5b22f8a…
commit 060eaaee51f4beb4605e96e5b22f8af1abe8b292
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Fri Sep 15 13:32:30 2017 +0200
gtp: correct order of eARP
Change-Id: Idc6d4d9c7f12521fa878f25ef66187fd286f017b
Reviewed-on: https://code.wireshark.org/review/23563
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2a89dff8f6f7930db3b9efb5d10b10…
commit 2a89dff8f6f7930db3b9efb5d10b103ae6fa4e66
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Fri Sep 15 13:26:49 2017 +0200
gtp: update of MS Not Reachable Reason
Change-Id: I48c056ba7a532148275f6c1cea9cd3a916c70952
Reviewed-on: https://code.wireshark.org/review/23562
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7cc677e561b9e40e87f9fbeb64b443…
commit 7cc677e561b9e40e87f9fbeb64b443ce5f1b52e4
Author: Simon Barber <simon.barber(a)meraki.net>
Date: Tue Sep 12 15:35:47 2017 -0700
wireless-timeline: handle generators that report incorrect MCS for some frames
Macbook and QCA generators sometimes report the minimum MCS for subframes
in an aggregate that have FCS errors.
Change-Id: I77d1a81f5b3d0e3d0755adcb889f1237b0257814
Reviewed-on: https://code.wireshark.org/review/23521
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=de1798aefc5233c6980ef45ec1eb02…
commit de1798aefc5233c6980ef45ec1eb027e2541a135
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Sep 14 10:47:26 2017 +0200
btle: Add Bluetooth 5.0 LL Control PDUs
* Dissect LL_PHY_REQ, LL_PHY_RSP, LL_PHY_UPDATE_IND and LL_MIN_USED_CHANNELS_IND.
* Add Control Feature Set values.
* Change Advertising Header Length from 6 bits to 8 bits (and removed RFU).
* Change Data Header Length from 5 bits to 8 bits (and removed RFU).
Change-Id: I453583fbb8c36dc87642c3c5087ab6dd77c46e45
Reviewed-on: https://code.wireshark.org/review/23536
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ccc5b44deaa312bf2963994d9ed25a…
commit ccc5b44deaa312bf2963994d9ed25a98087c67ef
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 20:41:02 2017 +0200
wslua: Disable -Wunreachable-code in lua_bitop.c
Some code is unreachable in some configurations.
Change-Id: I23ff9a6032f4f7f6eb8e6607c6473a77a8bb6ac6
Reviewed-on: https://code.wireshark.org/review/23561
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=875a46d1b54da3b2dcf0deb586de77…
commit 875a46d1b54da3b2dcf0deb586de7745cabfa51f
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sun Aug 27 22:10:48 2017 +0300
UMTS RRC: Call E.212 Dissector
Calling E.212 dissector for MCC-MNC pairs/IMSIs found in RRC messages
Change-Id: I1cbb4fe552323b65c761cdf7a721e8b93f297106
Reviewed-on: https://code.wireshark.org/review/23520
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e84c2e03e47cac0682ba03323ee0d7…
commit e84c2e03e47cac0682ba03323ee0d7f6ff7d7b10
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 20:35:28 2017 +0200
wslua: Avoid possible misuse of comma operator warning
Change-Id: I441359741332aa49fb91ded438cf2ec3d70b5e0f
Reviewed-on: https://code.wireshark.org/review/23560
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3f8384d7797cb07f220cad998620aa…
commit 3f8384d7797cb07f220cad998620aa2b1ee11960
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 20:28:24 2017 +0200
epan: Fix misuse of comma operator
Change-Id: I349dc9896db0bd306bc92f92eb9d4a65d98d309c
Reviewed-on: https://code.wireshark.org/review/23558
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=8b11e37f81d567921faacc5302f4b8…
commit 8b11e37f81d567921faacc5302f4b87268912484
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 20:29:49 2017 +0200
Qt: Use Q_UNUSED macro for unused arguments
Change-Id: I4bf7fe4ba3e3e6575e6537a8ec2b6024c253e776
Reviewed-on: https://code.wireshark.org/review/23559
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=619c89dbd721c39a1bff81a82d2726…
commit 619c89dbd721c39a1bff81a82d27269d93aa4145
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Sep 15 00:23:38 2017 +0100
TLS13: add ticket_early_data_info extension (draft -18)
Code point 46 was used for "ticket_early_data_info" in draft -18 but
removed in draft -19 since it was merged into "early_data".
Change-Id: Ic382c697b55424fd4eb90f9a3d59b76ac0a2dd8a
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23542
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=98d5174e1a82723bee99774294ff00…
commit 98d5174e1a82723bee99774294ff00e40154ad5e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Sep 15 14:33:37 2017 +0200
Qt: initialize srt_data_ in constructor (CID 1417727)
Change-Id: I4977ff102f1ffb11a5ea956537dde3230b4323f7
Reviewed-on: https://code.wireshark.org/review/23550
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=72355a081795a0a5d4a984ba04633d…
commit 72355a081795a0a5d4a984ba04633da30debe9d9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 14:49:56 2017 +0200
epan: Avoid possible misuse of comma operator warning
Change-Id: I73044cd71d21b5eef2e8350cf034f7801e169c16
Reviewed-on: https://code.wireshark.org/review/23552
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b96b145f5846c0f8e34aa6f77ab080…
commit b96b145f5846c0f8e34aa6f77ab0803f73bb27c2
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 14:48:45 2017 +0200
epan: Fix misuse of comma operator
Change-Id: Ie088dea1239286cb413ddcfc2a82e4a5e3fb9e0f
Reviewed-on: https://code.wireshark.org/review/23551
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=7c23f56a4d08f33becca50df67c51d…
commit 7c23f56a4d08f33becca50df67c51d1d5b6793e2
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Fri Sep 15 07:35:59 2017 +0200
Fix compilation errors when configured --without-plugins and without lua.
filesystem.c: In function ‘init_plugin_pers_dir’:
filesystem.c:1041:5: error: ‘plugin_pers_dir’ undeclared (first use in this function)
plugin_pers_dir = get_persconffile_path(PLUGINS_DIR_NAME, FALSE);
^~~~~~~~~~~~~~~
filesystem.c:1041:5: note: each undeclared identifier is reported only once for each
function it appears in
filesystem.c: In function ‘get_plugins_pers_dir’:
filesystem.c:1062:10: error: ‘plugin_pers_dir’ undeclared (first use in this
function)
if (!plugin_pers_dir)
^~~~~~~~~~~~~~~
Change-Id: I9ace17da42665d135b9432b1f19970491589e3bf
Reviewed-on: https://code.wireshark.org/review/23545
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=577671a160285b0252cb4ac85b195e…
commit 577671a160285b0252cb4ac85b195e902f85253c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Sep 15 14:12:16 2017 +0200
Qt: Don't show text as invalid in disabled widgets
In Interface Toolbar the text widget should not be shown as invalid
when the widget is disabled.
Change-Id: I100a338216b34874064cb9f808a36703157811a4
Reviewed-on: https://code.wireshark.org/review/23549
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e7ef19efc0e928b50644b37772ccbf…
commit e7ef19efc0e928b50644b37772ccbf176e74f766
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 3 00:42:00 2017 +0100
autotools: Initial work to install headers for the benefit of plugins
Install public headers required to build plugins for libwireshark (taps and
dissectors).
The source tree is organized to serve the CLI/GUI parts of wireshark.
Plugins are built in tree. This change is intende to allow plugins to be built
out-of-tree but we want to avoid dumping all headers into /usr/include.
To be continued incrementally to fix errors and omissions.
Change-Id: Iaa0def0ba3de4b456a29114c315544d2d64fa748
Reviewed-on: https://code.wireshark.org/review/23374
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c52a702ae81b1ae7311a8b58e625f8…
commit c52a702ae81b1ae7311a8b58e625f86fb211e7c5
Author: Sergey Avseyev <sergey.avseyev(a)gmail.com>
Date: Thu Sep 14 13:37:42 2017 +0300
couchbase: detect XERROR responses and dissect them as JSON
Change-Id: Ia2565090f8dc30e17cd6a16614136d237577d282
Reviewed-on: https://code.wireshark.org/review/23535
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=afb9ff7982971aba6e42472de0db4c…
commit afb9ff7982971aba6e42472de0db4c1bedfc641b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Sep 14 14:35:32 2017 +0200
MBIM: stop pre sizing wmem arrays
In case of malformed packet, this can lead to an insane amount of
memory.
Instead let's use the automatic growth mecanism. This way the malformed
packet is caught by the dissection engine.
Bug: 14056
Change-Id: I7bf5b80a516210b341356f5d495f08d1dba05805
Reviewed-on: https://code.wireshark.org/review/23537
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f63fc333625480d241a1265992ab34…
commit f63fc333625480d241a1265992ab34b389dd9ed6
Author: dsrsupport <eugene.exarevsky(a)dsr-company.com>
Date: Wed Sep 13 16:18:05 2017 +0300
ZigBee: implemented a dissector for ZBOSS key dump
Implemented dissecting of ZBOSS keys dump (debug stuff)
and adding a key into NWK keys ring.
Move adding key to keyring from dissect_zbee_aps_transport_key
into separate function.
Change-Id: If0e414765350ec5131d0f815edf70cc224aef732
Reviewed-on: https://code.wireshark.org/review/23524
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f3cf2ffd3af2b9d6315c19473bc109…
commit f3cf2ffd3af2b9d6315c19473bc1091bfe71b89c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Sep 13 22:13:59 2017 -0700
Move a test.
If we're not going to subtract 4 from actual_octets, there's no reason
to treat actual_octets < 4 as an error.
This makes the "subtract 4 octets of crap" code similar in all cases,
hopefully further reducing the opacity of the code.
Change-Id: I41cda101b321422ce5fd4474fb6903bfe471cb63
Reviewed-on: https://code.wireshark.org/review/23534
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9e905abe54bdc5a9409cd4b6f34090…
commit 9e905abe54bdc5a9409cd4b6f340909ae1bb3b91
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Sep 13 21:58:02 2017 -0700
Replace a magic constant with an expression that represents what it is.
(In the hope of making the code slightly less opaque.)
Change-Id: Ic635eedac4eb9fb764b3633c9003608b9b4ae3df
Reviewed-on: https://code.wireshark.org/review/23533
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1e26510a6a795402f77ba5cb94f102…
commit 1e26510a6a795402f77ba5cb94f102fe6d0000bd
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Sep 13 19:29:47 2017 -0700
Fix comments.
Change-Id: Ie9fe895a2763e74a5f1e25f3f1b9d63e02c0bd71
Reviewed-on: https://code.wireshark.org/review/23532
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4f34f4296c9335ddc9bb3cc8fec69b…
commit 4f34f4296c9335ddc9bb3cc8fec69b6bb1b5a079
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Sep 13 19:13:59 2017 -0700
Remove the 4 octets of junk even if that leaves no octets.
Be consistent in the treatment of those 4 octets.
Change-Id: If35c94bd299c3e7ec76306daf325d5aa5e3a19b9
Reviewed-on: https://code.wireshark.org/review/23530
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2b0e08378f6d2633e27645f5695cda…
commit 2b0e08378f6d2633e27645f5695cdae528eb23b7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Sep 13 21:19:38 2017 -0400
Allow distinction between bitmasked 32bit and 64bit unsigned integers in
proto_tree_set_representation_value.
IS_FT_UINT includes both 32 and 64 bit unsigned integers, but fvalue_get_uinteger
only allows 32-bit values, so add IS_FT_UINT32 macro for distinguishing between
using fvalue_get_uinteger and fvalue_get_uinteger64.
All other cases that use fvalue_get_uinteger vs fvalue_get_uinteger64 are done
first with switch statements and don't rely on IS_FT_UINT to distinguish
between 32 and 64 bit values
Bug: 14063
Change-Id: I9d1400259e7c2661c2b5ebf96aaa0e9d773651fe
Reviewed-on: https://code.wireshark.org/review/23528
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=df85480630a21d840427d564e40c91…
commit df85480630a21d840427d564e40c91b878606ba3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Sep 13 17:22:49 2017 -0700
Fix builds without pcap.
Change-Id: I5e327a8147ccd02e4fc689b321718b1910344b33
Reviewed-on: https://code.wireshark.org/review/23527
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=bdf10a239fcf873e1fff955f0fb6d8…
commit bdf10a239fcf873e1fff955f0fb6d8fd41aefcf3
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sat Aug 19 17:33:14 2017 +0300
UMTS RLC: Mark ciphered frames
- Updated RRC dissector to always collect ciphering sequence numbers
from Security Mode Command/ Security Mode Complete
- Updated RLC dissector to seek the collected info when deciding if
the frame is ciphered
Change-Id: I44bc61736968ef9f420782048e15ba27d6c6267f
Reviewed-on: https://code.wireshark.org/review/23132
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ba957234735b9a65ff831cf9a6b0ed…
commit ba957234735b9a65ff831cf9a6b0ed1a230c19ea
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 13 12:32:12 2017 +0200
PFCP: reapply gc2057c08f8 that was removed by g84272725b4
Change-Id: Ie49cd18a551dde78dbac82b67d6a6590eacfab86
Reviewed-on: https://code.wireshark.org/review/23523
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=84272725b441d49ea26f5c96e6b8b3…
commit 84272725b441d49ea26f5c96e6b8b37b2831b5ea
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Sep 13 09:30:48 2017 +0200
[PFCP] Dissect more IEs
Change-Id: I7aa19cbb4b9f74b95b8ab0d81c262009ad77fc88
Reviewed-on: https://code.wireshark.org/review/23522
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dafb529a389c8c60b3cbd04aba42c7…
commit dafb529a389c8c60b3cbd04aba42c7b65803134e
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Sep 12 15:34:19 2017 +0200
[Bluetooth] Update value string.
Change-Id: I9b877644ff091f9f548b760211ca2e3fa2392fde
Reviewed-on: https://code.wireshark.org/review/23518
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=75853200c6f6b4b16d661c9e9bd64d…
commit 75853200c6f6b4b16d661c9e9bd64d76ccbeafcc
Author: Joerg Mayer <jmayer(a)loplof.de>
Date: Mon Sep 11 06:56:14 2017 +0400
A number of 0 for actual_octets may just be an end of record instead of an error.
Also fix some whitespace "errors".
Change-Id: Ic1dc1bad6dafbbc21a87665675e654cd322178a0
Bug: 14051
Reviewed-on: https://code.wireshark.org/review/23476
Reviewed-by: Jörg Mayer <jmayer(a)loplof.de>
http://cgit.osmocom.org/wireshark/commit/?id=a7621ca4891819c59b30c5402d390a…
commit a7621ca4891819c59b30c5402d390a6d52ddcf97
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 12 13:28:26 2017 +0200
windows-common: fix compilation with GCC 7.1.1
Change-Id: I27eb245b52e0a7a61dd196e8781addc59fb6b61d
Reviewed-on: https://code.wireshark.org/review/23511
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b4d8b68d7c9c0e3280a204dcfca9b5…
commit b4d8b68d7c9c0e3280a204dcfca9b57e66bffddd
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Aug 17 20:30:01 2017 -0400
Fix: Segfault when "Update list of packets in real time" is unchecked
capture_file structure is not populated with "fixed" captures. Qt menu
presumes it has a populated capture_file structure. Just have menu
items be disabled until capture file is reloaded for display.
Bug: 13024
Change-Id: I9dfb5355c5d421f5344f97e1e9d5b4dd08b11c6e
Reviewed-on: https://code.wireshark.org/review/23095
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c2057c08f8ecd29faead6a99217228…
commit c2057c08f8ecd29faead6a99217228da421de91b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 12 13:05:25 2017 +0200
PFCP: try to fix compilation with GCC 7.1.1
Change-Id: Ic9b5601b68a5ce780a77d5d1124338fdaca6ae3c
Reviewed-on: https://code.wireshark.org/review/23510
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d141bc13c3dd3cc3dd48ff603b9f44…
commit d141bc13c3dd3cc3dd48ff603b9f44223397b41b
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Sep 11 17:57:39 2017 +0200
[PFCP] Add more IE dissection.
Change-Id: Ic211a395671a932a65319118e6f37fddea1ef296
Reviewed-on: https://code.wireshark.org/review/23500
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2b8bd222b07428c1442b38779425aa…
commit 2b8bd222b07428c1442b38779425aad44aeb5fbb
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Sep 12 09:45:29 2017 +0200
Qt: fix a segmentation fault when opening a capture using the menu entry
Regression introduced in g38b40acb2d
Change-Id: I48377345730eb52b03a2016407afda4bc0ff8a79
Reviewed-on: https://code.wireshark.org/review/23509
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1f759e3b63c3d8ab5127c474cfb5a4…
commit 1f759e3b63c3d8ab5127c474cfb5a4e5ca095fc2
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 16:04:18 2017 +0200
infinibnand: remove multi space before tvb (on proto_tree_add_item)
Change-Id: Ie94127b42cb6fbd08fa17c8dcfaffff65a21aee6
Reviewed-on: https://code.wireshark.org/review/23460
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=293df7cccbc3092a1cebf8ad9b7ed2…
commit 293df7cccbc3092a1cebf8ad9b7ed289f1a7decb
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Aug 13 19:12:36 2017 +0200
iso14443: reassemble APDUs from I-blocks
Extract the payload from I-blocks and support reassembly of APDUs that
are encapsulated in I-blocks. ISO14443 assumes that the fragments arrive
in order and no fragments are missing.
For now, we pass the reassembled APDU to the data dissector.
Change-Id: I526f6e6d699b2a1dfc4593536154bc9b58dea96e
Reviewed-on: https://code.wireshark.org/review/23506
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8c74580773e52b3de1b97c42cb4251…
commit 8c74580773e52b3de1b97c42cb425131f041b9cc
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sun Sep 10 15:23:26 2017 +0200
gtp: cleaner printout of IE Selection Mode
Change-Id: I799efc1892448d4c4f1fad6d9f88f188a5c9be0e
Reviewed-on: https://code.wireshark.org/review/23471
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=adf8236da7c7ee69c474a942d6bcc2…
commit adf8236da7c7ee69c474a942d6bcc2292e045082
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Sep 10 18:28:16 2017 +0200
windows-common: don't THROW() an exception from a dissector
Bring up an expert info instead of throwing an exception. Point to the
item that contains the invalid offset. Exit normally, returning the
number of bytes we consumed so far.
Change-Id: I97826a41c6713a97404ca437b9be60c77e009918
Reviewed-on: https://code.wireshark.org/review/23507
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f5b7fcee5b89382c9fa12d6545a249…
commit f5b7fcee5b89382c9fa12d6545a249bc95da80d5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Sep 11 10:54:09 2017 -0700
Qt: SequenceDialog no longer emits goToPacket.
SequenceDialog no longer emits goToPacket as of g7fe45cc0ec. Don't try
to connect it in MainWindow.
Change-Id: I0f3e47a3cf7c1e29a64da7462c85179e29828c49
Reviewed-on: https://code.wireshark.org/review/23501
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=d6dff9bc96c59be8ad81d1659c2da2…
commit d6dff9bc96c59be8ad81d1659c2da2f0e4d33c2d
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Sep 11 17:45:52 2017 +0200
reordercap: initialize command-line argument errors functions
Bug: 14055
Change-Id: I76959d97c45fb92473825b4a1ba708b0094d400a
Reviewed-on: https://code.wireshark.org/review/23499
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=83aabe5500fda8fda8a5eb09982361…
commit 83aabe5500fda8fda8a5eb09982361f0df860e6f
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 11 15:14:01 2017 +0100
CMake: Fix RPATH after ga338f87f33
GNUInstallDirs uses lib64 on x86_64.
Change-Id: I4e124a6b501bf2166e7270abbff53d52c9115f45
Reviewed-on: https://code.wireshark.org/review/23496
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c4528780732825267d2eebac482762…
commit c4528780732825267d2eebac4827625f39e33e5d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Sep 11 14:02:18 2017 +0000
gtpv2(.h): fix redundant redeclaration of ‘dissect_gtpv2_arp’ [-Wredundant-decls]
Change-Id: Ib2b3e2116ea806c8198b99a2d5e992b24907b684
Reviewed-on: https://code.wireshark.org/review/23491
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=7c258eedea0786e2dfccfc4002e3de…
commit 7c258eedea0786e2dfccfc4002e3de599bf29413
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Sep 11 11:46:16 2017 +0100
WSUG: Fix global plugin installation path
Change-Id: I28a1259ab30b7b86989f307d89461c26aec878da
Reviewed-on: https://code.wireshark.org/review/23493
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=69f0cb0cef3e8cc6b49073768f76ff…
commit 69f0cb0cef3e8cc6b49073768f76ff1046ded8b5
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 10 23:38:36 2017 +0100
wsutil: Initialize and store plugin personal dir
Obviate allocation on every call to get_plugins_pers_dir().
Change-Id: I089ae499f93739d490d4552f59b5db5996f7d26f
Reviewed-on: https://code.wireshark.org/review/23495
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=e7aa63746ba630d88032394f4869fc…
commit e7aa63746ba630d88032394f4869fca2c87853a8
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 11 09:28:42 2017 -0400
packet-zep.c: zep.lqi_mode is FT_BOOLEAN, not a FT_UINT, so use
proto_tree_add_item_ret_boolean
Change-Id: I7926baf5e0b7d50ca6ab5c3c1af5fba7e906202d
Reviewed-on: https://code.wireshark.org/review/23492
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=766a3a0332c1d7eec08eadb8bbcc89…
commit 766a3a0332c1d7eec08eadb8bbcc8911bdea6421
Author: Krishnamurthy Mayya <krishnamurthymayya(a)gmail.com>
Date: Mon Sep 11 06:43:17 2017 -0700
Bundle Age Extension Block: Type-20 decoding changes
Bug: 14053
Change-Id: I47f38c6b0b4517792b03236c1ee3f2fdc14fb07c
Reviewed-on: https://code.wireshark.org/review/23490
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=09b3af8f91324c7e3f86884c791acd…
commit 09b3af8f91324c7e3f86884c791acdcffc505cf9
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Sep 11 13:47:30 2017 +0200
[SCTP] Update SCTP Payload Protocol Identifiers from IANA registry.
Change-Id: I72652e5654b9cd6464f8b07f48093a4ea30ebf7d
Reviewed-on: https://code.wireshark.org/review/23489
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=36018de81a83bad289e202c7847ae2…
commit 36018de81a83bad289e202c7847ae2e89fcb0259
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Sep 11 12:34:20 2017 +0200
[GPRSCDR] Fix display of iPBinV4Address and iPBinV6Address as IPAddr.
Change-Id: Idccc291916597fbc97b8adab4f5f32f3af1a9cc3
Reviewed-on: https://code.wireshark.org/review/23488
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9bc8307867939078583818a2af2f0f…
commit 9bc8307867939078583818a2af2f0fe341e8820c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Sep 9 19:50:52 2017 -0400
Remove the OUIs in manuf.tmpl that cause obvious conflicts with IEEE list
This allows for less "skipping" when processing the list
Bug: 13784
Change-Id: I40fb5d5a82e51238751dd6785502ea259de9bc03
Reviewed-on: https://code.wireshark.org/review/23445
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4a56c6a728f1452891498402564662…
commit 4a56c6a728f1452891498402564662e0ef239176
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Sep 11 09:26:21 2017 +0200
[PFCP] More IEs dissected.
Change-Id: If51b5b3b935fe2f36c69bb98f0ee24cf8a1c0e5c
Reviewed-on: https://code.wireshark.org/review/23477
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3689dc1db36037436b1616715f9a3f…
commit 3689dc1db36037436b1616715f9a3f888fc9a0f6
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 19:20:30 2017 +0200
BTATT: add curr_layer_num to key tracking request / response
Otherwise in case of frames containing multiple BTATT packets at
different levels of encapsulation, we can retrieve the wrong structure
and start using the union with a wrong opcode based type
Bug: 14049
Change-Id: Ica5d8af8e84161d6f9daebbb90334f20082c5fa4
Reviewed-on: https://code.wireshark.org/review/23470
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1d3ca5ad41fc3a725442439464f9ea…
commit 1d3ca5ad41fc3a725442439464f9ead944b21779
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Sep 11 00:59:37 2017 +0100
TLS13: add new Signature Algorithms
Add support for dissecting new TLS 1.3 Signature Algorithms (like
RSASSA-PSS) and add the text to the tree item to prevent expanding the
item. The field names are preserved for backwards compatibility.
Change-Id: Ieb8c7a86f6e19b8d6c89590d87d59a01d9bb1351
Ping-Bug: 12779
Reviewed-on: https://code.wireshark.org/review/23474
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=845835b8dba71bb248238dcb8ae18d…
commit 845835b8dba71bb248238dcb8ae18d59e4e543f0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 15:20:56 2017 +0200
srt_table.c: free table dynamic memory when calling free_srt_table()
Change-Id: I21c259aa0649bcfac5e345f4e41ad1beea0446c1
Reviewed-on: https://code.wireshark.org/review/23455
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=18de993b7c29ad2d3840ff4b1b02f1…
commit 18de993b7c29ad2d3840ff4b1b02f132c23c4777
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 00:21:03 2017 +0200
Qt: free SRT table once the tree is filled
Change-Id: Ic1c55852399190f3a3c5b5bf90cf6d90517b247f
Reviewed-on: https://code.wireshark.org/review/23444
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=02b20a5a699a557ab0696ebb024b6a…
commit 02b20a5a699a557ab0696ebb024b6a3b1d39c41e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Sep 9 22:49:45 2017 +0200
Qt: fix Diameter SRT statistics display
Diameter dynamically create the SRT entries during runtime.
Delay the SRT table addition to the end of dissection to properly handle
this use case.
Bug: 13442
Change-Id: Id498f8d9bb4a1d7c632c9a556239bf74d0530f2a
Reviewed-on: https://code.wireshark.org/review/23443
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=06584b7a43101dca05f5a3040dbb26…
commit 06584b7a43101dca05f5a3040dbb26898a6c812f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Sep 10 18:28:37 2017 -0700
Sort the Ethertypes.
Change-Id: I7793e152da225965817844b727880a26e64051d3
Reviewed-on: https://code.wireshark.org/review/23475
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=38b40acb2dc2567d3ddda35f4ed7d6…
commit 38b40acb2dc2567d3ddda35f4ed7d6523a9a9bd0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 19:56:24 2017 +0200
Qt: fix a memory leak when exporting packets
Change-Id: I3c99ca838b3def4437ba92794881630b8cdd8cbd
Reviewed-on: https://code.wireshark.org/review/23472
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=55dcb6455872a40c0f36a6bb198428…
commit 55dcb6455872a40c0f36a6bb198428baf1d31afe
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 16:00:42 2017 +0200
infiniband: always return line for offset
Change-Id: I34d631ac913620dbc661b9d56d4e34502c9b7d35
Reviewed-on: https://code.wireshark.org/review/23459
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5f5a898541a541f5230831fcef4675…
commit 5f5a898541a541f5230831fcef46751e330fec1a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 15:59:31 2017 +0200
infiniband: always display reserved field...
Change-Id: If6976b2e1990ae562579134dbab3550faae8cfe3
Reviewed-on: https://code.wireshark.org/review/23458
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=27865070e0244a8f5c3fa46341d449…
commit 27865070e0244a8f5c3fa46341d449d7078d0d4e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 15:45:00 2017 +0200
infiniband: merge all reserved field
Change-Id: I31a0d84e9f9e811cc0568d171c6bd6f1fa3397c6
Reviewed-on: https://code.wireshark.org/review/23457
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e7ec9c5538d34fb3a732bdc2adc2f2…
commit e7ec9c5538d34fb3a732bdc2adc2f2311589e165
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 15:31:38 2017 +0200
infiniband: always return line for local_offset
Change-Id: I8bd9e76e44254c45be26c616bf22f712bcf50881
Reviewed-on: https://code.wireshark.org/review/23456
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=53c9d25694c2859061e46f3df97d9f…
commit 53c9d25694c2859061e46f3df97d9f89c8cca5c9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 14:56:30 2017 +0200
Revert "infiniband: fix bitmap for Local CM Response Timeout / Retry Count"
This reverts commit e624445adff8aa10ca6663e653b13ecd5c7db8d2.
Bug: 13997
Change-Id: I80c6842f890c7c6e9674a6f51732bf0eadec1de8
Reviewed-on: https://code.wireshark.org/review/23454
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=74436b5ace977279b659dc2420305e…
commit 74436b5ace977279b659dc2420305ea5a423e9ee
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Thu Aug 24 00:36:03 2017 -0700
ssl: fix subdissection with multiple TLS records per packet
Decrypted TLS records must be stored in a single SslPacketInfo or else
plaintext will go missing (in Follow SSL or when subdissectors need
reassembly). As this structure is currently keyed by the layer number
(pinfo->curr_layer_num) which is changed by call_dissector, it must be
copied and propagated before calling subdissectors.
Change-Id: Ic42ba6c0854154272058f9bf9796e06ad7f94bfd
Fixes: v2.3.0rc0-3740-ge1f84f985e ("Fix Decode As for protocols that may use
tunneling.")
Bug: 13885
Reviewed-on: https://code.wireshark.org/review/23190
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6bcf405338d498c76005223190a591…
commit 6bcf405338d498c76005223190a591048922f18d
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 17:54:16 2017 +0200
Thread: replace g_strsplit by wmem_strsplit
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Ib25c6a82b90ca541db121a79515a087d8d2c332f
Reviewed-on: https://code.wireshark.org/review/23468
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1a89b51e413f164d4a25d44d8c61be…
commit 1a89b51e413f164d4a25d44d8c61beea8498a09a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 17:52:14 2017 +0200
RTPproxy: replace g_strsplit by wmem_strsplit
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Ic1ce27800e699b01492f1d40ce720fc82416cfbc
Reviewed-on: https://code.wireshark.org/review/23467
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=350676f2723e1898e689d3026b62a8…
commit 350676f2723e1898e689d3026b62a8ea26409f4f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 17:50:51 2017 +0200
ISObus VT: fix a memory leak when using g_strsplit
Change-Id: I8cfbca97b9b5915f0fe38eda1d73f5483481aca7
Reviewed-on: https://code.wireshark.org/review/23466
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=124cf779f0c0d3a856a9c1793cb165…
commit 124cf779f0c0d3a856a9c1793cb165eb56512705
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 17:49:08 2017 +0200
HTTP: replace g_strsplit by wmem_strsplit
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Ic63a8ad7923c81c7c7d7f0c471e304d8a5224212
Reviewed-on: https://code.wireshark.org/review/23465
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=85d742ef26970e35d16f16a9bea04a…
commit 85d742ef26970e35d16f16a9bea04a12ff618e17
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 17:47:36 2017 +0200
DNS: replace g_strsplit by wmem_strsplit
It avoids leaking memory in case an exception is thrown during
dissection
Change-Id: Iab72bcb4cc1ac56e7ce5ff2693e3111aead03e7d
Reviewed-on: https://code.wireshark.org/review/23464
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4a2923d78b69e11e09c5cc3943f23c…
commit 4a2923d78b69e11e09c5cc3943f23cf40588dc37
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Sep 10 17:44:34 2017 +0200
JXTA: replace g_strsplit by wmem_strsplit
It avoids leaking memory in case an exception is thrown during
dissection
Bug: 14050
Change-Id: Ia17855646774ffa7bd93e0c8d578fa30f4df1394
Reviewed-on: https://code.wireshark.org/review/23463
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d4df5b8ee5337061a039cb8856439c…
commit d4df5b8ee5337061a039cb8856439c89776f6a08
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 16:19:47 2017 +0200
pfcp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ie31d7338934c77a713b0af495d6a4a5dd5fca2fe
Reviewed-on: https://code.wireshark.org/review/23461
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=81b4957f5a5219f4fe40e598620d25…
commit 81b4957f5a5219f4fe40e598620d2579907e603b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 16:26:14 2017 +0200
netmon: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I9ba8e7e73c40e8baac7ef761b6a1c0b6b4ad5525
Reviewed-on: https://code.wireshark.org/review/23462
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2154cb12a91464e78b359cb235a8f8…
commit 2154cb12a91464e78b359cb235a8f8b9c3181b58
Author: Julian Renz <julian(a)renz.cloud>
Date: Sat Sep 9 10:25:19 2017 +0200
ISAKMP: Added support for the accepted Diffie-Hellman group number in the
INVALID_KE_PAYLOAD
Notify payload according to RFC 5996.
Also fixed a bug where the dissection of the previously
added support for the SIGNATURE_HASH_ALGORITHMS Notify payload would not work
properly.
Change-Id: I54ffe6b0d8b52189af3dc2e879e6665739fc36a4
Reviewed-on: https://code.wireshark.org/review/23439
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f662b1dac904f51aefdcba5fddb1a6…
commit f662b1dac904f51aefdcba5fddb1a6c72ff03c4b
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sun Sep 10 14:37:16 2017 +0200
Tibia: Remove UAT error dialog in GnuTLS-less builds
Remove the RSA UAT completely when built without GnuTLS,
because we require GnuTLS for parsing PEM and PKCS #12 keys.
RSA encrypted packets can still be decoded if they are using the
standard OTServ RSA key, which is hard-coded.
Bug: 13959
Change-Id: I6bfc2bebaf8a49933d55fb5c3fcb8efbf58f1e6e
Fixes: g62c9a8a865
Reviewed-on: https://code.wireshark.org/review/23453
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Joakim Karlsson <oakimk(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=80351694c168795e08259a8f63e143…
commit 80351694c168795e08259a8f63e143c50c5a7bd4
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 28 06:34:21 2017 +0200
.mailmap: update (of August)
Change-Id: I77d50bedf1cb78e84c551413db8dab9223f45ed7
Reviewed-on: https://code.wireshark.org/review/23254
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c6e3fe5957f6df20d17db9dd95cb4b…
commit c6e3fe5957f6df20d17db9dd95cb4bde80304086
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Sep 10 10:54:20 2017 +0200
infiniband : Add value string for BTH opcode
Bug: 13998
Change-Id: Idd369e364bd2464b278fb4abcc1e77a0f8892641
Reviewed-on: https://code.wireshark.org/review/23452
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=371436cf4d96687fd5d69ef6c146cd…
commit 371436cf4d96687fd5d69ef6c146cd859fc4f832
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Sep 10 08:06:53 2017 +0000
[Automatic update for 2017-09-10]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I501b06b6c00354f921cfdb0d8239266577645a08
Reviewed-on: https://code.wireshark.org/review/23448
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=0414dae7ec5fefadb89fc03bd140b6…
commit 0414dae7ec5fefadb89fc03bd140b6c9f3d6dbb2
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sun Sep 10 01:56:51 2017 +0200
Tibia: Fix malformed packet exceptions on first pass
The first pass and other passes with NULL proto_tree caused a malformed packet
exception. This was due to an outdated if (tree) check that is now removed.
While we are at it, adjust documentation to reflect the actual maximum version
supported: 11.00 and add the new (yet unused) version traits.
Bug: 13959
Fixes: g62c9a8a865
Change-Id: If3e1093c881c0eb5070fefc9877cf5f0c61a7572
Reviewed-on: https://code.wireshark.org/review/23446
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f2f281e90e5a4b9f8f249ae89d6364…
commit f2f281e90e5a4b9f8f249ae89d6364bd7dc48785
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Sep 9 13:18:51 2017 -0400
Cleanup packet-zep.c
1. Remove packet-zep.h and incorporate into packet-zep.c
2. Use proto_tree_add_item_ret_uint to get fields that are used to populate
columns and appended items.
3. Intermix tree and column logic for more straightforward logic.
Change-Id: If0f050307ece51260d43e5e98867b0f914492c12
Reviewed-on: https://code.wireshark.org/review/23442
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b9746b6833e0dc7d0a7f9afd1b3a5b…
commit b9746b6833e0dc7d0a7f9afd1b3a5b80252d76b6
Author: Gerald Combs <gerald(a)zing.org>
Date: Sat Sep 9 09:21:10 2017 -0700
Redirect to /dev/null, not /devnull.
Change-Id: I9d14244cc14fac4d8857177686b9fd869d8a3b3c
Reviewed-on: https://code.wireshark.org/review/23441
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=26a5cd2d7837a08f5d5c2f1b5abec3…
commit 26a5cd2d7837a08f5d5c2f1b5abec34b4b22a596
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sat Sep 9 11:04:04 2017 +0200
ws_cpuid: include ws_attributes
Otherwise _U_ is not defined.
Change-Id: I221f64c7d89c221e5a63a573e06457699d0a177e
Reviewed-on: https://code.wireshark.org/review/23440
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=84ee66b9bc97bfa294f11b4083f8f0…
commit 84ee66b9bc97bfa294f11b4083f8f09b115c17e0
Author: shqking <shqking(a)gmail.com>
Date: Fri Sep 8 21:23:43 2017 -0400
packet-dcerpc-pn-io.c: Fix potential resource leak
Bug: 13826
Change-Id: I01674d5a31281508686bc06e222d6a87926d1c83
Reviewed-on: https://code.wireshark.org/review/23436
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a24f366ceb8eccf2e3a0501a394653…
commit a24f366ceb8eccf2e3a0501a394653c9eb6bed83
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Sep 8 21:43:08 2017 -0400
Correct instructions for choco package for VS2015.
Bug: 14039
Change-Id: Ic19c77bb091cd8ee8f824b82463d8b4bae37f625
Reviewed-on: https://code.wireshark.org/review/23437
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=64f53c90b7b81e252eef8c08d0aa01…
commit 64f53c90b7b81e252eef8c08d0aa01c5ff9796ef
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Sep 7 16:16:52 2017 -0400
Netmon: Add support for process and system config type events.
Ping-Bug: 6694
Change-Id: If11e96fce56c5dc92c92765b4fd5632de53060cd
Reviewed-on: https://code.wireshark.org/review/23430
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1c6f6c691f52bc3c0a660e6f824538…
commit 1c6f6c691f52bc3c0a660e6f82453844135acb30
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Sep 2 21:47:14 2017 +0200
sharkd: implement proper JSON string unescaping, based on JSON dissector.
Change-Id: I749b78b759f98c78526840b8bb1cbccfc17a5611
Reviewed-on: https://code.wireshark.org/review/23365
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
http://cgit.osmocom.org/wireshark/commit/?id=585297b189ba7f39db34f66f57d254…
commit 585297b189ba7f39db34f66f57d25429c8daf570
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Thu Sep 7 23:20:34 2017 +0200
GPRSCDR: decoding of EPS QoS/aRP
* Decoding of Allocation/Retention Priority (ARP)
* Fix order of ARP in GTPv2
Change-Id: Ica24877f3518b5e0b6883ba535ffe09be8f446c2
Reviewed-on: https://code.wireshark.org/review/23431
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=df21aa90250c29d7466d55d9e0eda2…
commit df21aa90250c29d7466d55d9e0eda2cddd0dfbd8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Sep 8 04:32:04 2017 -0700
Use cmake_push_check_state() and cmake_pop_check_state().
Change-Id: I70528d5f54f62a51bf6f438669cd70d5f0296ae5
Reviewed-on: https://code.wireshark.org/review/23435
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=935c055c18c8e33021c4062d22d4b8…
commit 935c055c18c8e33021c4062d22d4b87fe5577662
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Sep 7 22:12:46 2017 -0400
DOCSIS: Fix compiler warning on macOS.
Previous functionality presumed cat = 0, so initialize cat to it.
Change-Id: Ic0fdccc8222dfb435178416911d35bac105c6c03
Reviewed-on: https://code.wireshark.org/review/23434
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=6a67ba5677b28d8ce4e8b775ee9357…
commit 6a67ba5677b28d8ce4e8b775ee93573297784e0a
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Fri Aug 25 14:22:32 2017 +0200
Add basic Tibia game protocol dissection
Bug: 13959
Change-Id: Idec9c020d372c3b84af7024e2df4da4f9380f74d
Reviewed-on: https://code.wireshark.org/review/23055
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1c777ec044473c644135c2a96576ac…
commit 1c777ec044473c644135c2a96576ac575e5a704c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Sep 7 21:10:42 2017 -0400
DOCSIS: Ensure docsis_ucd has a registered dissection function
Bug: 14038
Change-Id: I36fbaa591a7ebf5da7d2e7be837e8fcca30c7f98
Reviewed-on: https://code.wireshark.org/review/23432
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=62c9a8a865779299d5e06cb929680e…
commit 62c9a8a865779299d5e06cb929680e4bba92d4e7
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sun Aug 6 23:59:31 2017 +0200
Add Tibia login protocol dissector
Tibia (https://tibia.com) is a Massively Multiplayer Online Role-Playing
Game (MMORPG) by Cipsoft GmbH.
This patch provides login protocol (session layer) support for Tibia
versions 7.0 (Dec. 2001) till current 11.42 (2017-08-12).
Most importantly, RSA-encrypted login packets are parsed and symmetric
XTEA session keys are extracted.
Bug: 13959
Change-Id: Id9d0dfa283cc604d66a6e6d1f3811cdcd7ff99db
Reviewed-on: https://code.wireshark.org/review/23054
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8dedebbf30253add7886d508850af7…
commit 8dedebbf30253add7886d508850af7e53d6ae3de
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Tue Sep 5 10:04:25 2017 +0200
DOCSIS: Added support for version 5 MAPs (dissect_map_v5)
Change-Id: Icc43fdc341a8f263af5d7b9e1bc14e13b5361dd0
Reviewed-on: https://code.wireshark.org/review/23392
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=765fc1d53374a0c9177bc634f5b928…
commit 765fc1d53374a0c9177bc634f5b928371fb98110
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Sep 7 21:04:43 2017 +0200
NAS EPS: update version info
Change-Id: Ic7f6353af47b494e3853d16c93cbcddff025888c
Reviewed-on: https://code.wireshark.org/review/23429
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b4cd63921c7134ab27da71369b50e2…
commit b4cd63921c7134ab27da71369b50e26109d485cd
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Aug 8 18:32:43 2017 +0100
RADIUS: Use two dictionaries (personal + system)
Instead of choosing one or the other.
Ping-Bug: 6466
Change-Id: Ia95b79190d12ad0fa8af06a12743f042f73a7602
Reviewed-on: https://code.wireshark.org/review/23029
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=db63f75eab219c16c450d4fcd57bfe…
commit db63f75eab219c16c450d4fcd57bfeae1bcb8cb6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Sep 7 13:02:22 2017 +0100
More [-Wmaybe-uninitialized] fixes with -Og
There may be some amount of bogosity involved but initialize the
variables and add a default case to prevent the noise and the build
from breaking with -Werror.
Change-Id: I20432ea74a1e5edc28be75a97077c9aa7bc87a35
Reviewed-on: https://code.wireshark.org/review/23426
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=d38197bb676d8937f5d9acd5342001…
commit d38197bb676d8937f5d9acd534200195b2e541bc
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Sep 7 13:27:41 2017 +0200
Qt: Construct QRegExp only once
In Interface Toolbar lineedit the QRegExp only needs to be
constructed once, not for every validity check.
Change-Id: I39e9ab9c57b4ac64a0b9b601fa72646d8c420274
Reviewed-on: https://code.wireshark.org/review/23425
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=b57010039bbbf01f7fa16c1a3a7890…
commit b57010039bbbf01f7fa16c1a3a78907558eb9f97
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Sep 7 16:23:59 2017 +0200
[NAS EPS] Update Request type value_string.
Change-Id: Ie92d2c0d91cd91974400327e0beba6aa9d995bff
Reviewed-on: https://code.wireshark.org/review/23427
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f091ed83f7e051f0618391dc791687…
commit f091ed83f7e051f0618391dc791687235c4a0abd
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Sep 7 06:49:12 2017 +0100
CMake: Try to fix build error with i18n.qrc dependency order
Change-Id: I7006b435508e72457413cd1b7c5bdf1b7b41ee5b
Reviewed-on: https://code.wireshark.org/review/23424
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=09a9d2265595ca317136c85975da31…
commit 09a9d2265595ca317136c85975da318ef29f84c6
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Sep 7 07:42:50 2017 +0200
Message Analyzer: use G_GUINT64_CONSTANT() macro
Change-Id: Ifbcc8e9c04d9da9829a653dffb92a25ea787749a
Reviewed-on: https://code.wireshark.org/review/23423
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6c87b5fdaa4ee746caf883382b3c74…
commit 6c87b5fdaa4ee746caf883382b3c74f3faf952b5
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Sep 6 17:38:12 2017 +0200
[PFCP] Add more IE dissection.
Change-Id: I98fa0b38c0872e26ae84f11dfa06d582e3e2e527
Reviewed-on: https://code.wireshark.org/review/23416
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da01b0b5dca05571d08ad71302aad6…
commit da01b0b5dca05571d08ad71302aad66ac7ee3181
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 6 22:56:08 2017 +0200
USB: use G_GUINT64_CONSTANT() macro
Change-Id: I2c3d2956be898c767afc19b2c63f2e84b5e79ed0
Reviewed-on: https://code.wireshark.org/review/23422
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c4901ca31f484c88a7947a6c2354ae…
commit c4901ca31f484c88a7947a6c2354ae194694599a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 6 22:39:28 2017 +0200
MBIM: add multiflow extension dissection
Change-Id: I9892df3984baf1ecf241b6d3f426a8633bf39b33
Reviewed-on: https://code.wireshark.org/review/23420
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8b9dc8c00c5d598aad0c8eb2b9623d…
commit 8b9dc8c00c5d598aad0c8eb2b9623d533a001835
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 6 22:54:40 2017 +0200
Netmon: fix indentation
Change-Id: I68683bf6b257bc4311bba47f0a5d6f4d80d0078f
Reviewed-on: https://code.wireshark.org/review/23421
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e728e28f6eb4ffaa661a0c8356215e…
commit e728e28f6eb4ffaa661a0c8356215eac64b9ebfb
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Sep 6 17:31:42 2017 +0200
caputils: fix compilation without pcap.
Change-Id: I074d027cd2528b0438015ddd098c9f4f6542090a
Reviewed-on: https://code.wireshark.org/review/23415
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d9477abd754d80eb95d1bf0886ef1b…
commit d9477abd754d80eb95d1bf0886ef1bda0b7ac1df
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Sep 6 14:45:54 2017 -0400
Bugfix NetMon System Trace dissection
Use opcode, not event id for dissection
Change-Id: I1df6067e8e7e6efb201f9131fc71113cb5a174d3
Reviewed-on: https://code.wireshark.org/review/23417
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=40481a1e393fdca7198031177e75b2…
commit 40481a1e393fdca7198031177e75b21e97e612ce
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Sep 6 14:47:02 2017 -0400
NetMon: Add support for WiFi Message
It's just a WTAP_ENCAP_IEEE_802_11
Change-Id: I7369fac06a7d63812bb7ce7b3c16b9fe606f544c
Reviewed-on: https://code.wireshark.org/review/23418
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ecc3828be56ba77757e40effacb6e4…
commit ecc3828be56ba77757e40effacb6e4fed6a85b98
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Sep 5 17:04:33 2017 -0400
Add ETW Ndis (NetMon) support
Ping-Bug: 6694
Change-Id: I7515177a37bd62efc019c7472c35efd384ffd7f9
Reviewed-on: https://code.wireshark.org/review/23407
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ee258b61a4eb51ec70afa4a3ae57bd…
commit ee258b61a4eb51ec70afa4a3ae57bd30b1957150
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Sep 6 15:55:15 2017 -0400
packet-usb.c: Add support for USBPort Keyword
Change-Id: I29e0a7bf81b1f6cf2f84cccb212e223089dd918a
Reviewed-on: https://code.wireshark.org/review/23419
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c1ef4693de99e56e182f7e8406f08a…
commit c1ef4693de99e56e182f7e8406f08a734e2e43b5
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Sep 6 11:55:40 2017 +0100
CMake: Make plugin installation path use PLUGIN_INSTALL_LIBDIR
Change-Id: I47f248f6ef56aba400054fa3ade2bf4d29eeb895
Reviewed-on: https://code.wireshark.org/review/23411
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=c6f99aea466319d02006808f35069d…
commit c6f99aea466319d02006808f35069da7f87a5c1b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Sep 6 11:49:12 2017 +0100
CMake: Move CPACK remnants and remove stale comment
Move required variables for better context.
Remove TODO comment. "To do" is "everything" to re-implement CPack
because
(incomplete) support was dropped in g0831becc1a.
Change-Id: Ie21001940794e264527f35b5d4638830de02d97e
Reviewed-on: https://code.wireshark.org/review/23410
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=7b6296ac5affa85687e6af8f5000cd…
commit 7b6296ac5affa85687e6af8f5000cd3ed18b7cd4
Author: Julian Renz <julian(a)renz.cloud>
Date: Tue Sep 5 17:05:53 2017 +0200
ISAKMP: Added dissection of the RFC7427 Notify Payload
"SIGNATURE_HASH_ALGORITHMS" according to
iana IKEv2 parameters
Change-Id: Ie10d0a8a076d65f60590b4fac0b36be7b87dec2a
Reviewed-on: https://code.wireshark.org/review/23396
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d022091acfd4c9513a4f13973d7cdc…
commit d022091acfd4c9513a4f13973d7cdc7d7785c09e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Sep 6 15:14:44 2017 +0200
Qt: fix RTP/IAX2 reverse stream export to CSV
Bug: 14040
Change-Id: Idadfbd3b60124b5f7ac4ace275db94b10daf010a
Reviewed-on: https://code.wireshark.org/review/23409
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=40869e6e50a1157314e75aa5be2ba2…
commit 40869e6e50a1157314e75aa5be2ba2fd887318d3
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Mon Sep 4 13:40:23 2017 +0200
openSAFETY: Add transport protocol for UDP
Adding a transport protocol for UDP, which replaces the
never used current implementation and adding also additional
header information for the transport
Change-Id: I943ac789bdc7355c114295dd1c8f1c1b475a5f8b
Reviewed-on: https://code.wireshark.org/review/23408
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d0a91b27f26762e9c998cc5e6fe717…
commit d0a91b27f26762e9c998cc5e6fe71767de5d32c7
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 5 17:18:00 2017 +0100
plugins: config.h must not be included by public headers
For a sane plugin build environment. Include config.h as the first
header in the .c file instead.
Fix by moving required compiler attribute macros to a new
"ws_attributes.h" API header.
Change-Id: I34f58a927f68c1a0e59686c14d214825149749e1
Reviewed-on: https://code.wireshark.org/review/23400
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=143bc04ca7c11b4f5a0feef4c01627…
commit 143bc04ca7c11b4f5a0feef4c01627c9aee6bcd4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 4 20:36:00 2017 -0400
Add NetMon System Trace support
Change-Id: I1ecf16db1b0a10b1a43112cc1225507e08250ace
Reviewed-on: https://code.wireshark.org/review/23405
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5672ab00d2c10322b0cc7d94f2537b…
commit 5672ab00d2c10322b0cc7d94f2537b5083b8c376
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 4 16:38:12 2017 -0400
MessageAnalyzer: Add support for ETW WFP Capture type.
Change-Id: Ic197e032621284de950843a6d086bb7c8c2787d4
Reviewed-on: https://code.wireshark.org/review/23402
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=494ede2aca686aaf69fb7ea7bc776d…
commit 494ede2aca686aaf69fb7ea7bc776dce48612868
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 4 17:32:23 2017 -0400
packet-netmon.c: Add Provider ID to INFO column.
Useful since it feeds dissector table.
Change-Id: I7fec9f37f9b2b480d82a713599f0818ad3dd32bb
Reviewed-on: https://code.wireshark.org/review/23404
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e4084f7bcdb7f05ae954d909c6dafa…
commit e4084f7bcdb7f05ae954d909c6dafa7a26ff631c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 4 17:31:48 2017 -0400
Ensure process info offset is "seek"ed when process info exists in NetMon
file.
Change-Id: I85fd990781a47e738c22bff0218aabdc04122e15
Reviewed-on: https://code.wireshark.org/review/23403
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=299bd4628a9aa8e6ea2c8772576e17…
commit 299bd4628a9aa8e6ea2c8772576e171f100da001
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Sep 5 12:39:09 2017 +0100
Fix unitialized variable warnings that popped up with -Og
Using GCC version 7.1.1.
Change-Id: I7447a48fc97efb1eb15a016a29165f69d37f40a6
Reviewed-on: https://code.wireshark.org/review/23399
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0dee5c1911337e1cb8d8836eb6aec8…
commit 0dee5c1911337e1cb8d8836eb6aec8b8abd72fa0
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Tue Sep 5 18:41:19 2017 +0200
Fix memory leak in wimaxasncp
Remove unnecessary null-check before free as well.
Change-Id: Ic54459149b40fd8c8f58c643bbd6cfc81ee8b923
Reviewed-on: https://code.wireshark.org/review/23398
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=970ed78492db50e7229c29530ba8aa…
commit 970ed78492db50e7229c29530ba8aa658a0ae72a
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Sep 5 17:22:14 2017 +0200
[PFCP] Add more IE dissection.
Change-Id: I71037d31283b1a2758617e6cdc6c3b58048e017d
Reviewed-on: https://code.wireshark.org/review/23397
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5c4a96b58b2f29c2ff4588b86fc443…
commit 5c4a96b58b2f29c2ff4588b86fc443b4b6b0f820
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Sep 1 16:42:53 2017 +0200
QUIC (TLS): Add stateless_reset_token parameter
Ping-Bug: 13881
Change-Id: I0332ebae69d8b25b1ac8617742cff02744a30f2a
Reviewed-on: https://code.wireshark.org/review/23389
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a6ad0a0191cd98f4c3f7c2a7bc6550…
commit a6ad0a0191cd98f4c3f7c2a7bc655049109f01e1
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Sep 5 14:00:06 2017 +0200
[GTPv2] Correct packet_flow_id length.
Change-Id: I90b4a405ea8e55d4897d39c30b15289e09da89eb
Reviewed-on: https://code.wireshark.org/review/23395
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0fb62a5fd0b7c1282c7d64c61b9d80…
commit 0fb62a5fd0b7c1282c7d64c61b9d806f94cf3f07
Author: Anton Kharchenko <astotal(a)gmail.com>
Date: Sun Sep 3 16:52:45 2017 +0700
LLDP 802.3 LAG TLV has been deprecated since 02-Dec-2011
Change-Id: I191b257a6dea2961c23dc68a329a07f4aa1428d1
Reviewed-on: https://code.wireshark.org/review/23373
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2698324d2852157e0b45e4ccd07369…
commit 2698324d2852157e0b45e4ccd0736989b74fb6e5
Author: Dmitry Bravikov <dmitry(a)bravikov.pro>
Date: Tue Sep 5 11:02:30 2017 +0500
Fix unit of measurement in category 048 of ASTERIX protocol.
Change-Id: Icdd39166059c080e7844968219f2a8f387c587a6
Reviewed-on: https://code.wireshark.org/review/23391
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4275f3de77be054c143076bf5b6e78…
commit 4275f3de77be054c143076bf5b6e78e0f983a70f
Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com>
Date: Tue Sep 5 09:50:05 2017 +0200
ZigBee ZCL SE PP: Subtrees not registered and dissect error
Subtrees for PublishTopUpLog and PublishDebtLog was not registered.
Missing timestamp field in PublishTopUpLog.
Change-Id: I3fedffccfceba7dcb6c2696c39b481b6f5cd1c75
Reviewed-on: https://code.wireshark.org/review/23394
Reviewed-by: Kenneth Soerensen <knnthsrnsn(a)gmail.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1cee1c95cc8b0ff30419b08d477c8f…
commit 1cee1c95cc8b0ff30419b08d477c8f512615cd99
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Sep 4 20:02:00 2017 +0200
dumpcap: Detect extcap pipe from correct interface
When capturing from multiple interfaces the extcap pipe detection
must be done based on the correct interface, not the first one.
Change-Id: I7428388d84ee18d0bfa693ffc9ddae98126ceca4
Ping-Bug: 13653
Reviewed-on: https://code.wireshark.org/review/23390
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d4efbc410165a3cad9e587b09e336b…
commit d4efbc410165a3cad9e587b09e336ba1226fd3aa
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Sep 3 10:36:40 2017 -0400
Add NetMon Event Provider ID dissector table
The provider ID appears to be the hook into dissecting NetMon Event
user data.
Since capture file with USB data was provided, that was used as the
example for how to hook into the provider ID dissector table.
Bug: 6520
Change-Id: Ie41719b6a28826869cd1672619949ea1f6981268
Reviewed-on: https://code.wireshark.org/review/23377
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8faa84d38ba8f83acf68653ef98007…
commit 8faa84d38ba8f83acf68653ef9800738dfd8bfbc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Sep 1 16:29:23 2017 +0200
QUIC: Add STOP_SENDING frame
Ping-Bug: 13881
Change-Id: I039e7a3eb1572721553a067f0d3db44e9cd4d7bd
Reviewed-on: https://code.wireshark.org/review/23388
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f7ff38bc782340b1e2540f59c0138f…
commit f7ff38bc782340b1e2540f59c0138f7fa56bc5dd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Sep 1 16:06:22 2017 +0200
QUIC: Add Statess Reset Token field on NEW CONNECTION ID Frame
Adding on draft-05
and also fix typo on NEW_CONNECTION_ID column
Ping-Bug: 13881
Change-Id: I838069d6a19f85772cbbb6346853a2ba64d056fd
Reviewed-on: https://code.wireshark.org/review/23387
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=83f727d73dfda95623b9094cb817cf…
commit 83f727d73dfda95623b9094cb817cf8564cbe54e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 16 13:26:15 2017 +0200
QUIC(IETF): Remove GOAWAY
Ping-Bug: 13881
Change-Id: Ieacfb6a9f63ec17f4377652a396e7bcfd54c101d
Reviewed-on: https://code.wireshark.org/review/23257
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8bd04c8be3304731dc319a35d1e697…
commit 8bd04c8be3304731dc319a35d1e6974193bcd3c1
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Sep 3 20:50:40 2017 +0100
IMF: preserve carrying protocol (e.g. SMTP, POP, IMAP) in protocol column
Change-Id: I8331040bbc9866878e74ad4c5f6b986dd94603fc
Reviewed-on: https://code.wireshark.org/review/23381
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a2b084f6c507d96fe6f07761545372…
commit a2b084f6c507d96fe6f0776154537268d60e9428
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Sep 4 10:16:49 2017 -0400
Add support for WPFCapture "formats" from Microsoft Analyzer.
Normally a .cap file contains a network type that when masked with 0xFFF
will convert to a pcap LINKTYPE_ value. However, Microsoft Analyzer
used 0xE080-0xE08A for their own purposes within a .cap file.
Add support for the WPFCapture formats and give a "not supported" error
message to the few left unsupported.
Bug: 10556
Change-Id: I321a75ce769fdec75bdc6b595936c25932950a97
Reviewed-on: https://code.wireshark.org/review/23386
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9f1c73edac06821987760e03f103c4…
commit 9f1c73edac06821987760e03f103c49bb9588d1f
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Sep 4 13:40:00 2017 +0200
[PFCP] Have an ett var per IE, add the grouped IEs Cause and Node Id.
Change-Id: I1c6bae4a9d46950e59209e72cd799272fa4f1c2c
Reviewed-on: https://code.wireshark.org/review/23384
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0393c108bcd548fecc9ad6e0d7f97c…
commit 0393c108bcd548fecc9ad6e0d7f97caf09997876
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Fri Sep 1 17:25:05 2017 +0200
Extra decodings for DOCSIS MDD message
Change-Id: I8765c96717d80f2b340428eb025e0a1e52a6e495
Reviewed-on: https://code.wireshark.org/review/23353
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2a9cab649e90f85cc7b40440ad2114…
commit 2a9cab649e90f85cc7b40440ad211438c8bb212f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Sep 4 14:51:00 2017 +0200
LTE RRC: add MBMS SIB messages to info column
Change-Id: Id238182ab19c9490d0e1cab852338fafdc2e1b66
Reviewed-on: https://code.wireshark.org/review/23385
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ab39fac52ea7448fd03ffe6d7d9894…
commit ab39fac52ea7448fd03ffe6d7d98947393b224c5
Author: Yury Gargay <yury.gargay(a)gmail.com>
Date: Mon Sep 4 16:38:18 2017 +0700
Diameter: NAS-Identifier and Acct-Multi-Session-Id are UTF8String
They should be UTF8String not OctetString according these specifications:
* https://tools.ietf.org/html/rfc4005#section-9.3.1
* https://tools.ietf.org/html/rfc6733#section-9.8.5
Change-Id: I96ddc6f5a98ff945dbde34f9844b582a7db924ad
Reviewed-on: https://code.wireshark.org/review/23383
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ed75d67394d0641a5b1141cf4e35e8…
commit ed75d67394d0641a5b1141cf4e35e86824230e92
Author: Anders <anders.broman(a)ericsson.com>
Date: Sun Sep 3 15:38:23 2017 +0200
[PFCP] Add basic dissector for Packet Forwarding Control Protocol (PFCP) 3GPP TS
29.244 V14.0.0 (2017-06)S
Change-Id: Id377870caa7649e19832ea3fd3484ed805c2c9cf
Signed-off-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/23375
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=78a14e4c577af3ef0ceb49b53cb495…
commit 78a14e4c577af3ef0ceb49b53cb495692820cbed
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Dec 18 11:57:39 2016 -0500
packet-nfs.c: Minor cleanup
Change-Id: Id1b522ae912a05442426d2acc1a036d1ba5689e2
Reviewed-on: https://code.wireshark.org/review/23380
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=209a78ea822cce413ba5dfd31469dd…
commit 209a78ea822cce413ba5dfd31469ddd2ff6c9d65
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Sep 2 20:35:54 2017 +0200
Qt: Interface Toolbar log dialog for each control
Have separate log dialogs for each control logger button.
Bug: 14033
Change-Id: Iaabcbe38da196ebed1302f66b77864f880121856
Reviewed-on: https://code.wireshark.org/review/23364
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=a338f87f33559bb9c915a97b614987…
commit a338f87f33559bb9c915a97b614987736d07ff8f
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 3 16:22:17 2017 +0100
CMake: Use GNUInstallDirs module instead of our own
Change-Id: I42f62824f226b091ff9bb86ce5c222333f98d783
Reviewed-on: https://code.wireshark.org/review/23379
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=8390744957984e074b270edb4e996d…
commit 8390744957984e074b270edb4e996de274ce3a07
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Sep 3 15:03:31 2017 +0100
Add function to return version number at run-time
For use by plugins using libwireshark to check compatibility.
Change-Id: I66a9d41644da7efce01cbed30d2a1f76fbc3754d
Reviewed-on: https://code.wireshark.org/review/23378
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=1d157ebeef0d5eb82e30ff7d7e64b7…
commit 1d157ebeef0d5eb82e30ff7d7e64b797be86a3ef
Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com>
Date: Fri Sep 1 17:43:14 2017 +0200
Extra decodings for DOCSIS RNGRSP
Change-Id: I27ad1143dc5c568a3c7cced4f61c11e45485c7f4
Reviewed-on: https://code.wireshark.org/review/23354
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=20d0a90115fb650c852a5ff1a6c3e7…
commit 20d0a90115fb650c852a5ff1a6c3e7cf488ad673
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 1 15:02:37 2017 +0100
IPv6: Add routing extension header dissector table
Change-Id: I1cf462179f8c6cf8c8c881d2cbda8ebe667d9055
Reviewed-on: https://code.wireshark.org/review/23362
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=3a68f85f910ce427ab540554b4fe7f…
commit 3a68f85f910ce427ab540554b4fe7ff5fcac2257
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Jul 30 12:18:10 2017 +0100
IPv6: Add dissection for PDM destination option
Performance and Diagnostic Metrics (ietf-ippm-6man-pdm-option-13)
Change-Id: Ic5e395c931b149cdadd777ab4ea6470c20d7b023
Reviewed-on: https://code.wireshark.org/review/23363
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=08c3681e7eba6f32283f0d1548f535…
commit 08c3681e7eba6f32283f0d1548f53586ae9b9354
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Aug 31 15:14:54 2017 +0100
configure: Restore --with-pcap=<DIR> option
Fixes g265a41e14d.
Bug: 14019
Change-Id: I785bba88db5feb9e4c694d6fff2f718ea9ec8a3a
Reviewed-on: https://code.wireshark.org/review/23367
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0f233e24d8da9cbc96b997a242b6a6…
commit 0f233e24d8da9cbc96b997a242b6a61a47de475a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Sep 3 08:07:26 2017 +0000
[Automatic update for 2017-09-03]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: If786bb3b1ebced2d34dbcd813bf30251b43524ba
Reviewed-on: https://code.wireshark.org/review/23369
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b5a54c341612eff3ca455b6da8095f…
commit b5a54c341612eff3ca455b6da8095f737d421e44
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Aug 25 23:46:23 2017 +0100
manuf.tmpl: mark comments
Comments were discarded based on a fourth column using tab separators.
Use a pound sign instead.
Change-Id: Icb5dd33c4a2c9c441eebda74bc8d813443efe1b6
Reviewed-on: https://code.wireshark.org/review/23351
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=be42b2bdeac66256c66cec8da5dab1…
commit be42b2bdeac66256c66cec8da5dab1204e0c0b8b
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Sep 2 14:48:41 2017 +0100
IPv6: Split p_update_ipv6_pinfo() into parts
For better flexibility when dissecting.
Change-Id: I7bd7644d1b466510d670e3f19ee88f28a14b4ed3
Reviewed-on: https://code.wireshark.org/review/23361
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=501f30ce5fb3f105519aedd4ddb869…
commit 501f30ce5fb3f105519aedd4ddb8693c119a63c3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Sep 1 07:13:56 2017 +0200
RSVP: Add Session IPv4/6 P2MP LSP info
Bug: 13977
Change-Id: Ia43d746e7be1d24046c755fadb2454eba39dbe58
Reviewed-on: https://code.wireshark.org/review/23347
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=692b1175e4d0493fcda0fbe8dd71ca…
commit 692b1175e4d0493fcda0fbe8dd71ca33c2773a89
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Aug 31 18:49:15 2017 +0100
Have a single IPv6 tap
Optimize code and open possibility for enriching IPv6 tap data.
Change-Id: I5a204d7464cde32123d5bfe664cc9b6bcf08dbe1
Reviewed-on: https://code.wireshark.org/review/23340
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2330ba1b3d6e62272dbaf0d5b3b5e8…
commit 2330ba1b3d6e62272dbaf0d5b3b5e8481040a45f
Author: Sergey Avseyev <sergey.avseyev(a)gmail.com>
Date: Fri Sep 1 11:12:37 2017 +0300
couchbase: fix full-doc commands of subdoc
They do not have path, so the min_spec_size should be smaller
Change-Id: I5a77bcf742be5f8a00f0cf7a215f386a845673fa
Reviewed-on: https://code.wireshark.org/review/23349
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Dave Rigby <daver(a)couchbase.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6fb8aa9a81ac7fcda4733d48555b09…
commit 6fb8aa9a81ac7fcda4733d48555b09ca27dfacad
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Sep 2 13:17:04 2017 +0200
WSP: allocate content type string in wmem pool
Let's use the pinfo pool as the string can be added to pinfo structure.
Bug: 14032
Change-Id: I195b6e216c89e22c8011886826adbbbd1cd32b11
Reviewed-on: https://code.wireshark.org/review/23358
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a66a216820f877881217485388b86c…
commit a66a216820f877881217485388b86c73722b351d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Sep 1 19:33:24 2017 -0700
Don't export structures used internally by dissectors for Export Objects.
They're not used anywhere other than inside the dissectors, so make them
private to the dissectors.
Change-Id: I9946713f34f95a8173fd7748055fd4aa2e870f70
Reviewed-on: https://code.wireshark.org/review/23357
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1ef38667197289f585c7315beacb87…
commit 1ef38667197289f585c7315beacb87179c21b1b6
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Sep 1 00:22:26 2017 +0100
CMake: prevent unnecessary rebuilds due to version.h
Ninja (but not Unix Makefiles or others) require an explicit BYPRODUCTS
command to ensure that the target is executed before evaluating others.
Change-Id: Iccbeb2516f7bf22ffdb444f3261ca58d22897891
Reviewed-on: https://code.wireshark.org/review/23342
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=e1a591fc746b6d32b68a48b5d80846…
commit e1a591fc746b6d32b68a48b5d80846677ca0fffb
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Sep 1 14:43:54 2017 -0700
Get rid of no-longer-needed patches to PortAudio.
The version of PortAudio we now specify has both of those problems
fixed.
Change-Id: I7364a5dfac1aac4799347a88f3e89fcb52f57d32
Reviewed-on: https://code.wireshark.org/review/23356
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8f555e43351517f1eb51f04a960936…
commit 8f555e43351517f1eb51f04a960936c9fef9a02a
Author: Dhiru Kholia <dhiru.kholia(a)gmail.com>
Date: Fri Sep 1 11:15:29 2017 +0530
Kerberos: Add support for new etype values from RFC 8009
These new etype values (19 and 20) are described in RFC 8009.
https://tools.ietf.org/html/rfc8009
The krb5 package in Red Hat Enterprise Linux 7.4 already supports these
new etype values.
Change-Id: Ic8d0b60b08ac1b48361c80adc28d8c408bf7666a
Reviewed-on: https://code.wireshark.org/review/23348
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4b6a26d9521ef9eb63706be5ca1440…
commit 4b6a26d9521ef9eb63706be5ca144037d1d009f2
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Aug 31 23:20:02 2017 +0200
btatt: Fix show handle with unknown service/characteristic/attribute
Show correct formatted handle item text when having unknown or
missing service, characteristic or attribute.
Change-Id: I4c5dec11b07956df3ee6f8dd1653835b8e4a42d7
Reviewed-on: https://code.wireshark.org/review/23337
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ed254720fe2dcc612b49a2ef25db20…
commit ed254720fe2dcc612b49a2ef25db2061f8cb85ff
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Aug 31 12:45:46 2017 -0400
Add support for NetMon NetmonFilter and NetworkInfoEx frame types.
Bug: 4221
Change-Id: I59aff777c364af1a064e1e99ea9ac6692a4cedfa
Reviewed-on: https://code.wireshark.org/review/23333
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2d93c4c06fabf8b8e6c8a4c85c4cf8…
commit 2d93c4c06fabf8b8e6c8a4c85c4cf818dfd4a5d2
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Aug 31 08:12:28 2017 +0200
RSVP: Add S2L_SUB_LSP (Class = 50) Object
Bug: 13977
Change-Id: I10ce2d7403d6783a1f232e53df6a279ffcde7fd9
Reviewed-on: https://code.wireshark.org/review/23319
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6821e0ea6f2e069ef75be58dc8f7bf…
commit 6821e0ea6f2e069ef75be58dc8f7bff50c961a7a
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 1 00:07:49 2017 +0100
Remove IP "dummy" protocol number
Change-Id: I3e6a1ec6b98028ff0a5d0bd0f7c8784651ed31da
Reviewed-on: https://code.wireshark.org/review/23341
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f16f6a3ef28754408548ff4ae16698…
commit f16f6a3ef28754408548ff4ae1669856aec172b4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Sep 1 01:25:53 2017 +0100
Avoid use of global protocol variables
Change-Id: I006d872a83649e72a6c83abac68cbae064457162
Reviewed-on: https://code.wireshark.org/review/23346
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5870352d8f388347750d8445a80be9…
commit 5870352d8f388347750d8445a80be92e0fab6504
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Aug 25 21:50:02 2017 +0100
Fix comment in addr_resolv.c
Fixes g55724db3db.
Change-Id: Idf9d5293fcd0e91698305da1cec5b8771c0a6a91
Reviewed-on: https://code.wireshark.org/review/23345
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=b7a9c02a50cc6fe5562204d09cb66e…
commit b7a9c02a50cc6fe5562204d09cb66e556d2f6ce9
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Aug 31 21:59:53 2017 +0200
H248: check that exported_pdu tap is listening before tapping packets
It prevents a memory leak
Bug: 14025
Change-Id: Ica4dd81aad38046a858988e8b30e3d7e40d0d721
Reviewed-on: https://code.wireshark.org/review/23336
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b974952b4cdb954e9b7fe4dda56d8f…
commit b974952b4cdb954e9b7fe4dda56d8ffec584f323
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Aug 31 21:50:19 2017 +0200
endpoint_dialog.cpp: remove a useless break
Change-Id: I0aafbe27b54969e77ba4df3106b9f35809d848a4
Reviewed-on: https://code.wireshark.org/review/23335
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=05ad9c79b80e5ae39ff63efc9b782e…
commit 05ad9c79b80e5ae39ff63efc9b782eb0b34b3edf
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Aug 31 15:39:05 2017 +0200
bluetooth: Update bluetooth_uuid_vals
Change-Id: Idd3767f0b7fbd8cec606f7e3be138f310c6113eb
Reviewed-on: https://code.wireshark.org/review/23328
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=74deaf895aa52ecd94ce1953bdde52…
commit 74deaf895aa52ecd94ce1953bdde525fda09fdf7
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Aug 31 15:16:22 2017 +0200
bluetooth: Update bluetooth_company_id_vals
Change-Id: I5c9761eacdfd3a668d5deb8aad46b0d3bee70051
Reviewed-on: https://code.wireshark.org/review/23327
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=45823736e8a8c050a9cbcd299fc512…
commit 45823736e8a8c050a9cbcd299fc512be940ed19c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Aug 31 13:37:31 2017 +0200
btle: Add Channel Selection Algorithm
Change-Id: I4d215bfb991ecf057ee9f6dda346b2fe6cee0bad
Reviewed-on: https://code.wireshark.org/review/23324
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f89cedcd434daab36fbc96db22a096…
commit f89cedcd434daab36fbc96db22a0963e313b7ec6
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Aug 31 13:36:22 2017 +0200
btle: Add Version 5.0 to ll_version_number_vals
Change-Id: I427da1f56a69785b70e965e08696fa24b114bb9c
Reviewed-on: https://code.wireshark.org/review/23323
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=e9b8a5839f026b4047895b8dc869e0…
commit e9b8a5839f026b4047895b8dc869e075da0bcf45
Author: Jens Kilian <jens.kilian(a)advantest.com>
Date: Thu Aug 31 08:28:02 2017 +0200
Qt: Fix errors when compiling for Qt4.
This allows Wireshark to be built on RedHat EL 7.2, with Qt 4.8.5.
Bug: 13909
Change-Id: Ia39a288cc342afa2bd0217cb59dac84c3227086c
Reviewed-on: https://code.wireshark.org/review/23322
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5f1f891e2a8cb6a5241854884fae2a…
commit 5f1f891e2a8cb6a5241854884fae2aa8d69f28e6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Aug 31 07:50:39 2017 +0200
RSVP: fix 'filter/host/rsvp_class/ti' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: I48e4eebe81c77d8b22bb7357ec13192bb04b59a9
Reviewed-on: https://code.wireshark.org/review/23318
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6f28f1a59e143fc94ea1bc4d46dc98…
commit 6f28f1a59e143fc94ea1bc4d46dc9818e0d16e14
Author: Jim Young <jyoung(a)gsu.edu>
Date: Wed Aug 30 23:38:05 2017 -0400
Fix MacOS build
Commit 8d13f14f958b9ee00b59fd869bd1630f76e6fa65 introduced a
preprocessor buglet affecting MacOS builds. Change #if to #ifdef.
Change-Id: I3d76c83428658abcf382e18066be0e24309ecbba
Reviewed-on: https://code.wireshark.org/review/23317
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jim Young <jim.young.ws(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=588590c539b5660e71660645305cb6…
commit 588590c539b5660e71660645305cb639cb35dc92
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Aug 30 16:01:48 2017 -0400
Read process info table from Netmon files
There isn't a place at the moment that uses it, but prepare
that use by parsing out the process info table and placing
it the netmon private data.
Bug: 4224
Ping-Bug: 1184
Change-Id: I6186b3dce0333042357089d8517c8b47b5ff7f70
Reviewed-on: https://code.wireshark.org/review/23316
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c199952f5c66c61d908c5052de9172…
commit c199952f5c66c61d908c5052de9172fe11a3f260
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 30 15:24:49 2017 +0200
extcap: fix parameters save in preferences file
Since g583150198b, extcap_arg structures holds a pointer to the current
preference value. So let's not update its value outside of the prefs API
otherwise the call to prefs_set_string_value() with pref_current done
afterwards will never notify the change and the updated value will not
be written in the preference file.
Moreover update ExtcapArgument::resetValue() method to have an empty
string instead of a NULL pointer. Otherwise prefs_set_string_value()
will not notify the change and save the restored default value in the
preference file either.
Change-Id: Ie70e79d471c75e25705c7654e420a7706ebc4032
Reviewed-on: https://code.wireshark.org/review/23308
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=51789050633fc4554413a6f79439c9…
commit 51789050633fc4554413a6f79439c9162c1c8cfb
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Aug 23 22:16:08 2017 +0200
rpc: remove two unnecessary DISSECTOR_ASSERT()s
Their conditions are always true. Both tvb_captured_length_remaining()
and tvb_reported_length_remaining() return a gint which is always >= 0.
Change-Id: Ic0c13d17361389053466573fafff44b2c2b478ed
Reviewed-on: https://code.wireshark.org/review/23186
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=63b66cc7c8a6ec4e28eabd0bea135a…
commit 63b66cc7c8a6ec4e28eabd0bea135a70ed707754
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Aug 30 22:49:11 2017 +0200
vxi11: remove some unnecessary NULL checks
Change-Id: I6a188a8c3f84284bb9dee406aee124f7e581f643
Reviewed-on: https://code.wireshark.org/review/23315
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8d13f14f958b9ee00b59fd869bd163…
commit 8d13f14f958b9ee00b59fd869bd1630f76e6fa65
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Aug 30 12:16:51 2017 -0700
Qt: Temporarily disable DP scaling on non-macOS systems.
Enable device pixel scaling in QCustomPlot only on macOS. Blind attempt
at diagnosing / fixing bug 14012.
Change-Id: I95e38eaa072d69aef0fe1d642951603800c3a280
Ping-Bug: 14012
Reviewed-on: https://code.wireshark.org/review/23314
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=541817f63ca3e57bc8b8302602c42d…
commit 541817f63ca3e57bc8b8302602c42d6b745d73ef
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Aug 30 17:21:12 2017 +0100
IPv6: Undo 'ipv6_ws' tap change
Previously tapping data did not depend on ipv6_pinfo.
Minor code cleanup.
Follow up to 71697c5dab92e5be15180c6fb4420fd847e1e539.
Change-Id: I2d8ef9603119ceada64a3c64d5f9d6dfffde399d
Reviewed-on: https://code.wireshark.org/review/23312
Petri-Dish: João Valverde <j(a)v6e.pt>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=63628636af9bf43291711d51e38dc6…
commit 63628636af9bf43291711d51e38dc6f5933291ef
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 30 18:41:43 2017 +0200
LTE RRC: add SCPTMConfiguration-BR-r14 message to info column
Change-Id: I82a5625aecadc670c2b15a0ea21e3e796bcb5e63
Reviewed-on: https://code.wireshark.org/review/23313
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=94ce35a9f9877d3e48db3d800f2493…
commit 94ce35a9f9877d3e48db3d800f2493f9944e1b5e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 30 16:48:30 2017 +0200
Qt: check QVector size before accessing its content and not after
Bug: 14017
Change-Id: Ied38551c78b4593f60165d9e3b04bb3913d6b258
Reviewed-on: https://code.wireshark.org/review/23310
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=71697c5dab92e5be15180c6fb4420f…
commit 71697c5dab92e5be15180c6fb4420fd847e1e539
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Aug 30 15:14:29 2017 +0100
IPv6: Move duplicate code to update IPv6 dissection state to a function
Also make sure to protect ipv6_pinfo access with NULL checks.
Change-Id: I9495421c6bf970cb7eaa0415aa1af7effd3e7c79
Reviewed-on: https://code.wireshark.org/review/23309
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=324658271690d7ce4482e039a205dd…
commit 324658271690d7ce4482e039a205ddaca3e1d18c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Aug 30 10:45:57 2017 +0200
dmp: Improve a sanity check
Bug: 14016
Change-Id: I7dd830b143160ddd609013517f1ee3d51aac3c10
Reviewed-on: https://code.wireshark.org/review/23305
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=445c0bb74722d23cac9c61b3f01df6…
commit 445c0bb74722d23cac9c61b3f01df6917e01a0be
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Aug 30 10:35:51 2017 +0200
[GSM MAP] Propagate top_tree to external message handlers.
Change-Id: Ib3d0a43c0cdeca0ed32ff4dfef13c66e485fb0fb
Reviewed-on: https://code.wireshark.org/review/23304
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b2a24177e94ba7302735db68cfc4af…
commit b2a24177e94ba7302735db68cfc4aff50532a474
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 30 08:00:10 2017 +0200
Add P2MP LSP Tunnel IPv4/IPv6 SENDER_TEMPLATE Object
Bug: 13977
Change-Id: I716598adbb2a75368d331cd5f705e4d737e55b08
Reviewed-on: https://code.wireshark.org/review/23301
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5830e890bc3612145fcc169fa28548…
commit 5830e890bc3612145fcc169fa28548848cea75e1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 30 07:15:02 2017 +0200
RSVP: fix some missing ctype...
Change-Id: Ief081f410b6c26b4db3402d63429eba404d05144
Reviewed-on: https://code.wireshark.org/review/23300
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f6b196546546a5c658fb2d8303147f…
commit f6b196546546a5c658fb2d8303147f6b7f77e9f6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 30 07:09:31 2017 +0200
RSVP: Add value_string for all ctype
Change-Id: I47154026ce77e550de2abecdc9092806418c6137
Reviewed-on: https://code.wireshark.org/review/23299
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc64d738005a42aba8d4ba21e9f95c…
commit dc64d738005a42aba8d4ba21e9f95c154530de64
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 30 07:06:19 2017 +0000
Revert "Add -Wused-but-marked-unused as an extra warning flag."
This reverts commit 1aaa904622245200c179d53d638bdf256cda71ab.
Change-Id: I6c783ffa40e5df9a3174cf768906e6d89ad909ef
Reviewed-on: https://code.wireshark.org/review/23303
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b0f253e07c2a90e49166445d165432…
commit b0f253e07c2a90e49166445d165432b4e4cfa17f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 30 07:04:48 2017 +0000
Revert "Add -Wused-but-marked-unused as an extra warning flag."
This reverts commit d846a3e8b9908caa65d182b680efb82c56c8103f.
Change-Id: I0fb9c44dbbeb2ad0f2a0a57671ca08920fb1af2a
Reviewed-on: https://code.wireshark.org/review/23302
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=52823805b29a44a83eacd0e5b415b1…
commit 52823805b29a44a83eacd0e5b415b11227ec313b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Aug 25 15:29:17 2017 -0400
Add support for reading comments in Network Monitor files
The NetMon wiretap reads the title and description comment fields from a
NetMon file and saves it in the wiretap private structure. Then when
it's time to make a frame, the comment fields are added to a NetMon
pseudoheader with a new WTAP ENCAP type, with the potential for netmon
pseudoheader to contain pseudoheader data from "base" wiretap. Then the
netmon_header dissector displays the comment fields and passes any "base"
wiretap pseudoheader data when calling the wtap_encap dissector table
that the frame dissector normally calls.
Bug: 4225
Change-Id: I8f772bc9494364c98434c78b61eb5a64012ff3b9
Reviewed-on: https://code.wireshark.org/review/23210
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=32b27bf19d181e4b2b227d13450a9d…
commit 32b27bf19d181e4b2b227d13450a9dee9582af2c
Author: Chris Brandson <chris.brandson(a)gmail.com>
Date: Tue Aug 29 16:08:00 2017 -0700
ZigBee add missing ZCL status code
Change-Id: I3b7ec4758b32057e0a5ea8f23088dabdd7183ec2
Reviewed-on: https://code.wireshark.org/review/23298
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1e0dc0637b33314c14897ea00e2eb3…
commit 1e0dc0637b33314c14897ea00e2eb32b146141ea
Author: Deep Datta <deepdatta2010(a)yahoo.co.in>
Date: Wed Aug 9 12:00:52 2017 -0500
Adding new Ixia netflow fields for DNS hostnames and class
Change-Id: I850c008f1bd96f313811cf6404acae35496e0c3c
Reviewed-on: https://code.wireshark.org/review/23272
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=8f3a3914fe3a01001fd1062ac693a5…
commit 8f3a3914fe3a01001fd1062ac693a5e41a466b59
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Aug 28 21:40:31 2017 -0400
Add Network Monitor Event Tracing event
Assigned a WTAP_ENCAP value (WTAP_ENCAP_NETMON_NET_NETEVENT) for the
dissection of Event Tracing records inside a NetworkMonitor file.
Ping-Bug: 6520
Ping-Bug: 6694
Change-Id: Ib100f3779095842e78f9b7741e80258aa866d818
Reviewed-on: https://code.wireshark.org/review/23278
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f05f4893fa57ceac0ecb6266b9e536…
commit f05f4893fa57ceac0ecb6266b9e536266f93aa1b
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Aug 29 17:03:05 2017 +0200
[ACSE] Get rid of global variable top_tree.
Change-Id: I2084c313e778f0895a4f7a58dee445f0e742e78e
Reviewed-on: https://code.wireshark.org/review/23290
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Tomáš Kukosa <tomas.kukosa(a)ixperta.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ed6239d17ec995ab5eaa51319c1f13…
commit ed6239d17ec995ab5eaa51319c1f13fac8ae3a06
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Aug 29 13:33:01 2017 +0200
[GSM MAP] Get rid of a global variable and use the new
dissector_try_uint_new() interface.
Change-Id: I714ca04f43c00017969e8655614566df4c53e5e9
Reviewed-on: https://code.wireshark.org/review/23288
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Tomáš Kukosa <tomas.kukosa(a)ixperta.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=37d06faed3bc3c4d8ff908993b5f9c…
commit 37d06faed3bc3c4d8ff908993b5f9cfb91e3c1a4
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Aug 29 17:29:20 2017 +0200
[ANSI TCAP] Get rid of global variable top_tree.
Change-Id: Ib3f7794be4c8f38ce556d2e4d61f7df02ba8df1e
Reviewed-on: https://code.wireshark.org/review/23291
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=64eea6bb03ec8b861c5e336815e5a6…
commit 64eea6bb03ec8b861c5e336815e5a6b8233aadcd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 29 07:35:07 2017 +0200
gsm_a_dtap: fix 'pinfo/len/add_string/string_len' was marked unused but was
used [-Wused-but-marked-unused]
Change-Id: I6f384e510ac77c41b3891958ec5a1b224c040e5d
Reviewed-on: https://code.wireshark.org/review/23283
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=91caa91adf42b21945345aee03b68c…
commit 91caa91adf42b21945345aee03b68c4e5d881a63
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 29 07:19:50 2017 +0200
gsm_a_common: fix 'pinfo/len' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: I831565d624711ebbcaf84b05e3a34dae58e1e064
Reviewed-on: https://code.wireshark.org/review/23282
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4402b67d7de47c52b0d54fcfc0a845…
commit 4402b67d7de47c52b0d54fcfc0a845609fecba17
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 28 19:33:27 2017 +0200
RSVP: Add value_string for all ctype
Part 3
Change-Id: I7560f62124a7f20057195c7b3dfde7e6ce4c8f73
Reviewed-on: https://code.wireshark.org/review/23285
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b9ec3e71f647422b0748c3417b5111…
commit b9ec3e71f647422b0748c3417b511146ba5a688d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 29 07:16:12 2017 +0200
gsm_a_bssmap: fix 'len' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: Ia575e0a7d036852254327f00129d9060209411a0
Reviewed-on: https://code.wireshark.org/review/23281
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e608345e060d03d63491d40a8a4c3b…
commit e608345e060d03d63491d40a8a4c3b2291ef0940
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 29 07:07:03 2017 +0200
fcoib: fix 'data' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: I5b24af66d982b00bcb0532d8fe31175ca18956cc
Reviewed-on: https://code.wireshark.org/review/23280
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6d5fcb7378b89790ab2d3feac0a657…
commit 6d5fcb7378b89790ab2d3feac0a6579c59b97bef
Author: Jim Young <jyoung(a)gsu.edu>
Date: Mon Aug 28 23:32:43 2017 -0500
MIME based pcapng dissector: Fixup apparent copy-and-pasteos.
The MIME based pcapng dissector incorrectly displayed the EPB
Flags option's link layer error bits.
Change-Id: Ia14eec39e2a9c4432e6b3d1c0cee718ad2da1cac
Reviewed-on: https://code.wireshark.org/review/23279
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fa8a6a3eee3a6ce938cec4c1d8cc05…
commit fa8a6a3eee3a6ce938cec4c1d8cc0540b27c451a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Aug 28 21:36:37 2017 +0200
extcap: check that argument parameter is not null before adding it to command line
Without this test, we add an argument with an empty parameter
Bug: 14006
Change-Id: I7e5313f652691808735f54b533cf5a7f7adeeae1
Reviewed-on: https://code.wireshark.org/review/23271
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7a71ec887ce78a48933d02e55d3b6d…
commit 7a71ec887ce78a48933d02e55d3b6d2b3ac49cfb
Author: Jim Young <jyoung(a)gsu.edu>
Date: Sat Aug 26 22:35:51 2017 -0500
tshark: Add delimiter to both sides of packetlist arrows
Depending on how packetlist columns are arranged certain columns may have a
Unicode arrow character inserted between it and the subsequent column to
indicate source vs destination column directionality when displayed in
tshark. Currently any inserted Unicode arrow characters are
unconditionally prefaced with an ASCII SPACE character.
Tshark's `-T tabs` option causes the various packetlist columns to be
delimited with ASCII TAB characters. The unconditional use of the SPACE
character before any inserted Unicode arrows makes it difficult to directly
compare a -T tabs report of column N values to column N+1 values without
dealing with the SPACE/Unicode Arrow suffix appended to all of the column
N values.
The inserted Unicode directionality arrows are effectively another
packetlist column of data that should be delimited like all other columns.
This patch ensures that any Unicode directionality arrows inserted between
packet list columns are delimited on both sides of the arrows with the
selected delimiter character.
Change-Id: I4eb7c6015a538afdc2c41be746eca4eec1ace36f
Reviewed-on: https://code.wireshark.org/review/23222
Petri-Dish: Jim Young <jim.young.ws(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c7290277311f5189e4341c7684e141…
commit c7290277311f5189e4341c7684e14118f9f21c8b
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Aug 28 12:42:59 2017 +0100
epan: Properly cleanup registered postdissectors
wanted_hfids member was never properly freed. Fix indentation too.
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2198
Bug: 13996
Change-Id: I8297df2158fd0ae8123223f4622ae952a218a07a
Reviewed-on: https://code.wireshark.org/review/23167
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1f9990b7657332daad0680107d5230…
commit 1f9990b7657332daad0680107d5230e18437f1da
Author: Darien Spencer <cusneud(a)mail.com>
Date: Tue Aug 1 21:53:06 2017 +0300
NBAP: Refactor information storing per-packet
Migrating from static variables to a single struct for
information 'carried' between different field in a NBAP packet.
Bug: 13879
Bug: 13712
Change-Id: Ie35619d64c4b9a3d5459d528788f74f952e75c11
Reviewed-on: https://code.wireshark.org/review/22902
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f8d0a7f003c2916f08092da01c7372…
commit f8d0a7f003c2916f08092da01c737294f1944eb8
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 28 16:10:25 2017 -0700
CMake: We no longer support Visual C++ 2005 or 2008.
Change-Id: Ide3688366aa3c38d48ff29224dbfc0fdb7bf1b7a
Reviewed-on: https://code.wireshark.org/review/23277
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a303bc1f2982e59885c9787d3f81e1…
commit a303bc1f2982e59885c9787d3f81e1ced4b5f342
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Mon Aug 28 12:40:38 2017 +0100
transum: clear the list of wanted hfids in file cleanup routine
Be sure to disable the wanted hfids list when the transum dissector is
cleaned up, otherwise it will leak memory when reloading a file while
the transum dissector is enabled.
Change-Id: I2af8edab89da8b3cfb65e19726e1d2546a1dc8d4
Reviewed-on: https://code.wireshark.org/review/23261
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6cd7d99cb98c17c593948753d2a3b2…
commit 6cd7d99cb98c17c593948753d2a3b2a65d4f6040
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Aug 25 18:37:25 2017 -0700
snort: do not unconditionally prime tcp.reassembled_in
Priming has some side-effects, do not do it unless the user explicitly
enables a preference. This transfers the owernship of wanted_hfids to
set_postdissector_wanted_hfids.
Ping-Bug: 13996
Change-Id: I77389f54d9a505cf6f2e4deb5f6ee6e508417270
Reviewed-on: https://code.wireshark.org/review/23231
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b3f5700ed4f3d5913d94dd0920fbc9…
commit b3f5700ed4f3d5913d94dd0920fbc9df57adb090
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Mon Aug 28 20:24:08 2017 +0200
sharkd: handle PREF_SAVE_FILENAME, PREF_OPEN_FILENAME, PREF_DIRNAME in dumpconf.
Change-Id: I17c13c274ebd31da7d7a7ebe02821cf09f77f66c
Reviewed-on: https://code.wireshark.org/review/23268
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c9d05548405c6cc5c58dbede2e531c…
commit c9d05548405c6cc5c58dbede2e531c46732e009a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 28 10:30:05 2017 -0700
PNIO: Fix another potential OOB write.
Bug: 13847
Change-Id: I62bb519b8e37112a59a7d209b39780f034dbcd0c
Reviewed-on: https://code.wireshark.org/review/23267
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0f9935e9a145535a7bb996fbfd8b1d…
commit 0f9935e9a145535a7bb996fbfd8b1d24c762210c
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 28 14:02:46 2017 -0700
WSDG: Fix up some markup.
Change-Id: I1484e63fd9626ed507ff0077073c944cf85e3602
Reviewed-on: https://code.wireshark.org/review/23273
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=26de091d1be961570fade436de18f8…
commit 26de091d1be961570fade436de18f8422b89358f
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Aug 27 22:07:55 2017 +0100
cmake: add ENABLE_NGHTTP2 option
Allow nghttp2 to be disabled, similar to --without-nghttp2.
Change-Id: Id27ab12ef7c24a535824f762ce2feb20fba9e065
Reviewed-on: https://code.wireshark.org/review/23247
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=464679f80f60173589b6f3476abc1e…
commit 464679f80f60173589b6f3476abc1e6177d1a43f
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Aug 28 15:27:41 2017 +0200
extcap: Close control handles when done
Ensure the event handles are closed when done to avoid leakages.
Also improved the control reader to use WaitForSingleObject().
Change-Id: I1679d9c09e247b28117ec05c3e1b0f3ba0e99674
Ping-Bug: 13833
Reviewed-on: https://code.wireshark.org/review/23263
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=287221e8d9591bf252392ec34959e2…
commit 287221e8d9591bf252392ec34959e24c49fcd275
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Mon Aug 28 15:26:42 2017 +0200
Free interface_options elements on cleanup
At shutdown the array keeping all interface_options is freed.
The array elements however are not making valgrind and ASAN
complain. Make sure the elements are freed on cleanup.
Ping-Bug: 13864
Change-Id: If8b810ea5f4f11c5ce770a9ffa6c2c791bc561fe
Reviewed-on: https://code.wireshark.org/review/23265
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=879920a2ebaacf33e554ab47e340c3…
commit 879920a2ebaacf33e554ab47e340c34fe2e878d8
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Mon Aug 28 10:38:31 2017 +0200
iface_lists: Remove locked field
It seems the locked field of interface_t was used to avoid
simultaneous updates of interface entries from either multiple
threads or most likely the recursive UI update callbacks
case later identified.
Since 802362e ("Avoid recursive scan_local_interfaces operation")
the recursive callback behavior is no longer happening. And as
code does not have consistent checks the locked field can anyway
hardly protect a multi-threaded case if such a case exists.
Remove the unnecessary locked field.
Ping-Bug: 13864
Change-Id: Idc393f702b82aa6014dd636572d00f0d67120bf3
Reviewed-on: https://code.wireshark.org/review/23262
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=8646596829494dbe054a18958eac68…
commit 8646596829494dbe054a18958eac68682ba42721
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Fri Aug 25 13:58:20 2017 +0200
Fix leaks when active capture interface goes down
If an interface goes down while packet capture is ongoing
related interface_option element is not freed properly. Fix
by using the appropriate free function that both remove the
element and frees element members.
Ping-Bug: 13864
Change-Id: I66a11d64615dc9648441b532e4ff658ea42a5acf
Reviewed-on: https://code.wireshark.org/review/23205
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=752c48f8643935cd859a794e53e4a9…
commit 752c48f8643935cd859a794e53e4a9f4fba73b03
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 28 09:05:12 2017 -0700
Remove README.vmware
The issues it discusses were relevant in 2000 but have long since been
fixed.
Change-Id: I6284950670eba86849288bf9c88f3d22c622bdd0
Reviewed-on: https://code.wireshark.org/review/23266
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=f763a7d15407d289ba8356ff7528a5…
commit f763a7d15407d289ba8356ff7528a53c6f0ae6ce
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Aug 22 17:20:32 2017 -0700
Note that we probably don't support HP-UX.
(The bulk of this was written between 1999 and 2005, and hasn't been
updated since. Should we just remove it?)
Change-Id: I6c43a876cf1b4db0b1b2761323fee67377b384c3
Reviewed-on: https://code.wireshark.org/review/23166
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=3b16cc8b219e087e6b8cc8898ed8e4…
commit 3b16cc8b219e087e6b8cc8898ed8e4d58263d326
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Fri Aug 25 11:27:38 2017 +0200
iface_lists: Access ifaces member by reference
Change access of ifaces elements from by val to by reference.
With this change unnecessary copying of the whole struct is avoided
but even more important is that elements no longer have to be
removed and inserted whenever data is updated.
This change aims to make it more clear that ifaces elements shall
never directly be removed from the array. Instead use function
capture_opts_del_iface
NOTE: Code for GTK UI not updated
Ping-Bug: 13864
Change-Id: I04b65d5ee36526b30d959b8e5a2a48a3c7c4f15b
Reviewed-on: https://code.wireshark.org/review/23204
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=81c48eacccbeb3466e607c0f708f38…
commit 81c48eacccbeb3466e607c0f708f38869da70491
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Fri Aug 25 10:24:36 2017 +0200
Fix leak when removing interfaces from manage interfaces dialog
When removing interfaces from the manage interfaces dialog the
interface elements where not freed properly causing leaks.
Free the interface element when removed from the array.
Ping-Bug: 13864
Change-Id: I6beb222a5475278cfc6cb454a7c8b2c86f636f38
Reviewed-on: https://code.wireshark.org/review/23203
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e26926432d163cd835b7f8f1ab51e0…
commit e26926432d163cd835b7f8f1ab51e084c04050b7
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Fri Aug 25 10:14:15 2017 +0200
Free interface elements on cleanup
At shutdown the array keeping all network interfaces is freed.
The array elements however are not making valgrind and ASAN
complain. Make sure the elements are freed on cleanup.
Ping-Bug: 13864
Change-Id: I1efeb03f42fb6f0b87dada8ef50d85f47f93e0dc
Reviewed-on: https://code.wireshark.org/review/23202
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8873c7e494018637449a17a7f7ddaf…
commit 8873c7e494018637449a17a7f7ddaf88ad43f3c6
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Thu Aug 24 16:16:34 2017 +0200
iface_lists: Access all_ifaces member by reference
Change access of all_ifaces elements from by val to by reference.
With this change unnecessary copying of the whole struct is avoided
but even more important is that elements no longer have to be
removed and inserted whenever data is updated.
This change aims to make it more clear that all_ifaces elements
shall never be removed from the array without freeing resources
via the capture_opts_free_interface_t function.
NOTE: Code for GTK UI not updated
Ping-Bug: 13864
Change-Id: I36742cb1d5c8daa136c9d3732a044a7c8e5c7fe7
Reviewed-on: https://code.wireshark.org/review/23201
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=76c231bd683410bed4fa803bcbc91e…
commit 76c231bd683410bed4fa803bcbc91e613e201ab0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 28 06:52:03 2017 +0200
OSPF: fix LSA type filter
Bug: 13979
Change-Id: Ibf0229aba48cdb8d2d4c30c17723be4bb9cca476
Reviewed-on: https://code.wireshark.org/review/23253
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=405a5335ef12e4f2e7b661e9a7b3d5…
commit 405a5335ef12e4f2e7b661e9a7b3d5b33ab99629
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 22 11:29:20 2017 +0200
RSVP: Add value_string for all ctype
Change-Id: I1bbbbceccaa6883f36741b0e4c3d5b8cfb0204fc
Reviewed-on: https://code.wireshark.org/review/23252
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=12c04e05294d86d7c036cb3e866ae6…
commit 12c04e05294d86d7c036cb3e866ae62f50ac5ba9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Aug 28 08:36:03 2017 +0200
Qt: Fix build without libpcap
Change-Id: I9b9b5de1beb23486ccc000feda54c2b20a33f4ad
Reviewed-on: https://code.wireshark.org/review/23251
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=74a79b28b0a8c43ff6e198fc1993a4…
commit 74a79b28b0a8c43ff6e198fc1993a40032a3d907
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 17:50:53 2017 +0200
infiniband: fix bitmap for Remote CM Response Timeout / Transport Service Type
Issue reported by Yao Lin
Ping-Bug: 13997
Change-Id: Ia90e58826c228500da0177fa2b8b90ec9ec2ff74
Reviewed-on: https://code.wireshark.org/review/23237
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=db04fef13fb57050f47994beaad311…
commit db04fef13fb57050f47994beaad3115dc174746e
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Aug 25 18:32:59 2017 -0700
prefs: fix memleaks with obsolete preference modules
ASAN reported a memleak in the USB CCID dissector due to the use of
prefs_register_protocol_obsolete which caused prefs_cleanup to skip
freeing preferences inside such modules.
Change-Id: Ib4aecb3a722f958a8a1c5fc636703c1ec977f0cd
Reviewed-on: https://code.wireshark.org/review/23230
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=018f6bff18785a1c3971a1ccfe3b1b…
commit 018f6bff18785a1c3971a1ccfe3b1b5243d4d154
Author: Håkon Øye Amundsen <haakon.amundsen(a)nordicsemi.no>
Date: Fri Aug 25 11:28:34 2017 +0200
extcap: Interface Toolbar support on Windows
Add support for extcap control pipes on Windows.
Improved read loop in InterfaceToolbarReader.
Delay opening control pipes until extcap has opened the fifo pipe.
Make extcap_example.py work on Windows.
Bug: 13833
Change-Id: I4b47d25452637759b8a3be53be48eee5365bc0e4
Reviewed-on: https://code.wireshark.org/review/23211
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7aeff4fb904e67ce8f81053f595b8a…
commit 7aeff4fb904e67ce8f81053f595b8a8b0340cb52
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 12:22:22 2017 +0200
Revert "infiniband: swap Local CM Response Timeout / Retry Count field"
Follow the order of spec
This reverts commit 4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3.
Change-Id: Ifeaf2c68813f8c452b6ab0247cd7a4313c95f619
Reviewed-on: https://code.wireshark.org/review/23236
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=231f3ea77440714384b9b2b0291736…
commit 231f3ea77440714384b9b2b0291736e5334b7f0e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 19:21:00 2017 +0200
gsm_a_bssmap: fix 'pinfo' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: I041b7c9363e75f0ec54ea29ea3d39e92f6ce8b6a
Reviewed-on: https://code.wireshark.org/review/23239
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1aaa904622245200c179d53d638bdf…
commit 1aaa904622245200c179d53d638bdf256cda71ab
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 27 14:19:39 2017 -0700
Add -Wused-but-marked-unused as an extra warning flag.
We can't just turn it on yet, because that would require generators to
know which generated functions use which parameters and mark only the
unused ones as such. The generator that turns PIDL files into DCE RPC
dissectors is one that would have to be fixed.
Change-Id: I7b0e9b08de6e7e9e611143de7307d3323a5c913e
Reviewed-on: https://code.wireshark.org/review/23249
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d846a3e8b9908caa65d182b680efb8…
commit d846a3e8b9908caa65d182b680efb82c56c8103f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 27 13:55:14 2017 -0700
Add -Wused-but-marked-unused as an extra warning flag.
We can't just turn it on yet, because that would require generators to
know which generated functions use which parameters and mark only the
unused ones as such. The generator that turns PIDL files into DCE RPC
dissectors is one that would have to be fixed.
Change-Id: I42013c8983d01fd3eca4026358b37ba043f12190
Reviewed-on: https://code.wireshark.org/review/23246
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ef3b7a3394d918a7abebbd410a3525…
commit ef3b7a3394d918a7abebbd410a3525fd3b212ba3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 27 13:49:04 2017 -0700
err_info is used, so don't mark it unused.
Change-Id: Ibd89fcb8e9fc2aa7e368eb8723fb367db5e8d11e
Reviewed-on: https://code.wireshark.org/review/23245
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1dc62c573e0c0a90ce34b6cbf2735c…
commit 1dc62c573e0c0a90ce34b6cbf2735c929f970c31
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 27 13:47:22 2017 -0700
pinfo is used, so don't mark it unused.
Change-Id: Ife237343cdf051be836c2e2d3de1b00fc3902708
Reviewed-on: https://code.wireshark.org/review/23244
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=837c42d264ace217d23ca3a67ad19b…
commit 837c42d264ace217d23ca3a67ad19bf819e0690b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 19:24:14 2017 +0200
diameter_3gpp: fix 'pinfo' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: Iefec98b1bbb47eec4df684933df4b44197dd9164
Reviewed-on: https://code.wireshark.org/review/23242
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=74d39b2aa6360f2a5313901c861b0f…
commit 74d39b2aa6360f2a5313901c861b0faa098b4c48
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 19:25:57 2017 +0200
dpnet: fix 'tree' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: Ib90069304e384b707fc64fd68ef52db108758917
Reviewed-on: https://code.wireshark.org/review/23243
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=af66f17fb463ece6f7b5ef28bc99d9…
commit af66f17fb463ece6f7b5ef28bc99d98f413f12e7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 19:22:29 2017 +0200
cfm: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: I046a37a07cdaad6db2132efbfbbc9dbfa0055bec
Reviewed-on: https://code.wireshark.org/review/23240
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8d42f0fd09ddd6039c6c9344157668…
commit 8d42f0fd09ddd6039c6c9344157668cfd44c21cb
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 27 19:23:20 2017 +0200
devicenet: fix 'buf_len' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: Id16edc055ed675076fe015b84bf37f1bef90ddbf
Reviewed-on: https://code.wireshark.org/review/23241
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f3ba318e099f62aea51718b73e8e81…
commit f3ba318e099f62aea51718b73e8e817482beab51
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Fri Aug 25 11:19:06 2017 -0700
Lua: fix crash on invalid Dissector.list("food") invocation
The Dissector.list, Listener.list and Field.list functions do not accept
a parameter. Passing one however results in a crash because the first
element is not the expected table, but the first function parameter.
Change-Id: I8483d0aa20716045472f30f5b41a449bed549b05
Reviewed-on: https://code.wireshark.org/review/23209
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=22252978a4ec46ce8a0186dc317612…
commit 22252978a4ec46ce8a0186dc31761293932a8abc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Aug 26 10:17:16 2017 +0200
nvme: fix wrong encoding for SQ Header Point
Need to use LITTLE_ENDIAN
Bug: 14008
Change-Id: I3697bb53e0832a9465e8be465b3587e9b78d2f0d
Reviewed-on: https://code.wireshark.org/review/23229
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9bb96969bab1e3fcadd7ee74df69c5…
commit 9bb96969bab1e3fcadd7ee74df69c5079bbe6235
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Aug 27 08:07:00 2017 +0000
[Automatic update for 2017-08-27]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ia4e22a8679dc08ee4f260fe6168678f7dd11f2eb
Reviewed-on: https://code.wireshark.org/review/23224
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=fb1acc778d6e71cbeb5f512a8f8fb1…
commit fb1acc778d6e71cbeb5f512a8f8fb179b4fdf46e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Aug 26 22:32:58 2017 +0200
Update USBPcap to 1.2.0.3
Change-Id: Ie5dbe818e214738ea8e82fe7d72fc8a20b30691b
Reviewed-on: https://code.wireshark.org/review/23221
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a08e998ca2e7a8229da7f8b292dad9…
commit a08e998ca2e7a8229da7f8b292dad94734977f33
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sun Aug 20 21:38:32 2017 +0300
NBAP: Replaced a comment
Edited a comment to explain the usage of the 'hs-dsch physical layer category'
field
Change-Id: I400eabd764818bbc39ab1128500b8700647175e3
Reviewed-on: https://code.wireshark.org/review/23218
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9cd114fbe5d622ef7345259d143b4e…
commit 9cd114fbe5d622ef7345259d143b4e09f5c0e6eb
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Aug 26 11:21:52 2017 +0200
wiretap: Add WTAP_ENCAP_NORDIC_BLE
Use this for nordic_ble dissection.
Change-Id: I5323cbd8c244c4e3b645825c60d040e1ae8f3b81
Reviewed-on: https://code.wireshark.org/review/23219
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=50227b0f6efb9ef56ff8a7fa85a9d6…
commit 50227b0f6efb9ef56ff8a7fa85a9d6011012a201
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Aug 25 13:50:42 2017 +0200
infiniband: fix infiniband: sIP and dIP inside IP CM Private Data are decoded in the
wrong order
Issue reported by Yao Lin
Bug: 14002
Change-Id: Ib49f74edbaac4830340fb9d7dba5105f0bdeb2f1
Reviewed-on: https://code.wireshark.org/review/23200
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=166d95e7cbe9b27b070ac03829f4d8…
commit 166d95e7cbe9b27b070ac03829f4d8add3a1945e
Author: Darien Spencer <cusneud(a)mail.com>
Date: Fri Aug 25 17:22:14 2017 +0300
FP: Refactored duplicate code
The 'get packet info from conversation' code was shared in both the
'if' and 'else' cases
Also fixed a comment about the packet's direction
Change-Id: I83568a5be7cba094aea925bdbc70479e50377477
Reviewed-on: https://code.wireshark.org/review/23207
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b1a041898333a8d38387dca4fa6d50…
commit b1a041898333a8d38387dca4fa6d509881845072
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Fri Aug 25 14:05:42 2017 +0200
Fix leaked timestamp records
Valgrind reports leaked timestamp records.
A comment stated that the timestamp info members only contain
static data. That claim was only true for some cases, not all so
make all cases allocate memory and have them properly freed when
removed.
Fixes: aca55a2 ("Add hardware timestamping support")
Change-Id: I31e4689070019ad1f531008394e7d6e48318c70c
Reviewed-on: https://code.wireshark.org/review/23206
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9ae80aea082384605e647f55fbc4d2…
commit 9ae80aea082384605e647f55fbc4d2910811a929
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 25 10:20:59 2017 -0700
CMake: Package list updates.
Move gcrypt to the required package section. Fold the various
xxx_REQUIRED variables into xxx_OPTIONS.
Change-Id: Ib4220d7344e2bbac9062465d175921733bb0fe52
Reviewed-on: https://code.wireshark.org/review/23208
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=659b95765cd0fd213ba301c2162ec5…
commit 659b95765cd0fd213ba301c2162ec525422f8ff3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Aug 25 11:35:25 2017 +0000
zbee-zcl: fix parameter 'cluster_id/dir' not found in the function declaration
[-Wdocumentation]
Change-Id: I9b0f7d0eefe932e00629269a85ede612438354cf
Reviewed-on: https://code.wireshark.org/review/23199
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=29e92fef556c8abd2e94fc0cf552a6…
commit 29e92fef556c8abd2e94fc0cf552a651a4788163
Author: Sergey Avseyev <sergey.avseyev(a)gmail.com>
Date: Fri Aug 25 10:51:49 2017 +0300
couchbase: update HELLO features
Change-Id: Icff1932cd41334fcf04016f3616a99ac4293ebef
Reviewed-on: https://code.wireshark.org/review/23198
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1e2c0ed5ea08fa32b2f89ba34c9cf6…
commit 1e2c0ed5ea08fa32b2f89ba34c9cf63fe07de281
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Aug 25 07:56:21 2017 +0200
802.11: fix display of PMK-KO (R0KH-ID)
Issue reported by Spice Boy
Bug: 14004
Change-Id: If49ec807ee54b8991653b7a3584baade59069894
Reviewed-on: https://code.wireshark.org/review/23197
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4b8fee9da8c19cb64a8ee0c6ab4588…
commit 4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Aug 24 08:05:01 2017 +0200
infiniband: swap Local CM Response Timeout / Retry Count field
Change-Id: Id693a83292ac7c3683a8e24a58dd452d828125d7
Ping-Bug: 13997
Reviewed-on: https://code.wireshark.org/review/23189
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a101aa9d99849b2316c0f9a59ca265…
commit a101aa9d99849b2316c0f9a59ca265511a72185a
Author: Dylan Ulis <daulis0(a)gmail.com>
Date: Thu Aug 24 21:56:45 2017 -0400
btatt: Fix request response arrows
Change-Id: I40f61a8b8319605035f2a5c3685a3e8561d76921
Reviewed-on: https://code.wireshark.org/review/23196
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2d1bb2b66195c9cae7599f2333755f…
commit 2d1bb2b66195c9cae7599f2333755fd1bd0f9395
Author: Chris Bontje <cbontje(a)gmail.com>
Date: Thu Aug 24 08:41:44 2017 -0600
[packet-selfm] - Fix dissection of multiple PDUs in single packet with no Fast Meter
config data present.
Change-Id: I69cc2430e2f75d297f4bee3397c191d6f8e9091f
Reviewed-on: https://code.wireshark.org/review/23194
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cf6a3deae44c8ff8f5b6a21e590ab7…
commit cf6a3deae44c8ff8f5b6a21e590ab7956b24fd27
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Aug 24 08:00:25 2017 +0200
GTP: fix wrong bitmap for gtp.ext_comm_flags_II_pmtsmi field
Issue reported by Sudarshan Chettri
Bug: 14001
Change-Id: I03a37adb6e77201191f424b300fa917bf11afac4
Reviewed-on: https://code.wireshark.org/review/23188
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b9307c1ac86019ae94e190f6b195b9…
commit b9307c1ac86019ae94e190f6b195b9f55129a4d8
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Aug 24 09:51:04 2017 +0200
nordic_ble: Fix calculating delta time start to start
The calculation must be based on the length of the previous packet,
not the last packet selected in the list.
Also mark this entry as generated.
Change-Id: I2e0a30ce28f5824f73ffe2d90d3043ff309292dc
Reviewed-on: https://code.wireshark.org/review/23191
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=155ffc993d61cc6cd9be09d07fc148…
commit 155ffc993d61cc6cd9be09d07fc148dfff01c27c
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Aug 24 09:57:36 2017 +0200
[BSSGP] Handle Overload msg and code cleanup.
Change-Id: I625030263675b014b2d42cc04aef6794354b2893
Reviewed-on: https://code.wireshark.org/review/23192
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=274bbd5fab970c5a2048f9d00bb4e4…
commit 274bbd5fab970c5a2048f9d00bb4e441cd68d04a
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Aug 20 13:33:53 2017 -0400
Extract the "long name" out of the manuf file and use it for some
resolution
Some places (like MAC resolution) want to keep a fixed length, but for places
that want to display "full organization name", save the long name that is
treated as a comment in the manuf file.
Have make-manuf convert companies with all caps to mixed case so we're not
screaming the company name at the user.
Convert the manuf.tmpl to be tab delimited without a comment for the "long
name"
so it can match the format now created by make-manuf.
Remove uint_get_manuf_name as it was unnecessary.
Bug: 3666
Change-Id: If2af5a1ce64e2784fe3941eeae8d8093d4f1467b
Reviewed-on: https://code.wireshark.org/review/23150
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e624445adff8aa10ca6663e653b13e…
commit e624445adff8aa10ca6663e653b13ecd5c7db8d2
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 23 21:01:17 2017 +0200
infiniband: fix bitmap for Local CM Response Timeout / Retry Count
Issue reported by Yao Lin
Ping-Bug: 13997
Change-Id: I84fbf70b1871ce740f52b1b9dd9c1b8ed2af41e3
Reviewed-on: https://code.wireshark.org/review/23183
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9dbfa6a1ea5a12bbb899a2e1ada032…
commit 9dbfa6a1ea5a12bbb899a2e1ada032e227289677
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Aug 23 21:53:42 2017 +0200
rpc: remove some unnecessary NULL checks
Change-Id: I956f0dbbd6b3cdbf8c0e4b9d81e0bd6408874b5b
Reviewed-on: https://code.wireshark.org/review/23185
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=af180cc7d050e821825f3f4a2e9660…
commit af180cc7d050e821825f3f4a2e96607b67704a39
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Aug 23 14:46:24 2017 -0700
Update the AsciiDoc button macro name.
Change the name of the button macro to "btn" in order to be compatible
with AsciiDoctor.
Change-Id: I673e0fe0ae7b343abeb1afba0b9b11402efdf0d6
Reviewed-on: https://code.wireshark.org/review/23187
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=f8ea11ff461c266e8f3746de12ba29…
commit f8ea11ff461c266e8f3746de12ba293932dcff0c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Wed Aug 23 15:29:58 2017 +0100
RADIUS: Add comment for RFC 6929 preference
Change-Id: I084923204cd1017f9e50052b41106ab44dc9b1af
Reviewed-on: https://code.wireshark.org/review/23176
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=41d94798a941f0df6ae1a647cee267…
commit 41d94798a941f0df6ae1a647cee2671f4e03929d
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Aug 23 11:49:28 2017 -0700
Docbook: Fix a couple of include paths.
Change-Id: I1b06658f516a17516782df57943d7082badba755
Reviewed-on: https://code.wireshark.org/review/23182
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=dd83b24f222a2a935cad3b6a646fec…
commit dd83b24f222a2a935cad3b6a646fecaf6790afbd
Author: Phil Beeson <bugzilla(a)philbeeson.com>
Date: Wed Aug 23 08:08:55 2017 +0200
BTLE: fix bitmap for link data Hop / Sleep Clock Accuracy
Bug: 13990
Change-Id: I4d5acaf580adbe2c5bff1aac3d2837a8842cd519
Reviewed-on: https://code.wireshark.org/review/23172
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7e21263d0b86c221d27f17922f4632…
commit 7e21263d0b86c221d27f17922f46322b08308268
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Aug 23 09:32:05 2017 -0700
Update WinSparkle to 0.5.6.
Change-Id: I93d95bba740bb3e0a4754ec71460f30ef1e45a9a
Reviewed-on: https://code.wireshark.org/review/23178
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=45401950257ec58d01efefdbc53149…
commit 45401950257ec58d01efefdbc53149739c7785e4
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Aug 19 23:39:21 2017 +0200
extcap: Create unique pipe names for each interface
On Windows the pipe names does not get random characters appended.
Add the interface name and pipe type to make it unique.
This partly fixes the issue with capturing from multiple extcap
interfaces on Windows.
Ping-Bug: 13653
Ping-Bug: 13833
Change-Id: I4290b37cf789bf77608993682a803aca29513d28
Reviewed-on: https://code.wireshark.org/review/23158
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5574b78dae2f607d4ace66ab60d516…
commit 5574b78dae2f607d4ace66ab60d516d0c569357d
Author: Ulf <ulf33286(a)gmail.com>
Date: Tue Aug 22 21:52:29 2017 -0400
Fix potential oob write crashes
Bug: 13847
Change-Id: I3a706db25204fe4c1fd1b7be3b17b8c55365dccf
Reviewed-on: https://code.wireshark.org/review/23169
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5c27cb5f83cb2c89cf470a6203fe05…
commit 5c27cb5f83cb2c89cf470a6203fe057d3fa7e322
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Aug 22 20:38:55 2017 -0400
packet-bgp.c: using wmem_packet_scope() for decode_evpn_nlri_esi
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=2736
Bug: 13995
Change-Id: Ia304251249e023a77a8fa3a650ef1640c3c2f314
Reviewed-on: https://code.wireshark.org/review/23168
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f61c45acf145d9d0782d3c1b2a7290…
commit f61c45acf145d9d0782d3c1b2a729097983582aa
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Aug 22 10:33:49 2017 -0700
Fix a typo.
Change-Id: I26fb82c00ef3ac1343930e473294a3aa338f3f96
Reviewed-on: https://code.wireshark.org/review/23164
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=257f738a0da4e03b97b7f58c9363d9…
commit 257f738a0da4e03b97b7f58c9363d991c5537dab
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 22 10:37:46 2017 -0700
Use the Wayback Machine for the PDML spec.
It's not available at the old URL any more.
Change-Id: Id8baba5e02cf0e3227365f53a11caa054ef2c40f
Reviewed-on: https://code.wireshark.org/review/23165
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b3f6e8cb78ed7c87cdb0e65a406f2d…
commit b3f6e8cb78ed7c87cdb0e65a406f2d32f627a63c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Aug 22 16:09:48 2017 +0200
commandline: fix compilation without pcap.
Change-Id: I37b9dd3f9515948a5ccf72cd2fd76fc1251c9294
Reviewed-on: https://code.wireshark.org/review/23161
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7b44ff084a49a09dcbe10872f4302f…
commit 7b44ff084a49a09dcbe10872f4302f3a4232edc9
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Aug 22 16:10:06 2017 +0200
Qt: fix compilation without pcap.
Change-Id: I277059e018a41ea011043d255508db4c5f05f63d
Reviewed-on: https://code.wireshark.org/review/23162
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=be69761c78d0c285f88ea6b2da0399…
commit be69761c78d0c285f88ea6b2da0399fcecf9d782
Author: Ahmad Fatoum <ahmad.fatoum(a)siemens.com>
Date: Tue Aug 22 11:00:28 2017 +0200
Fix requesting hardware timestamps without -k
The interface_options struct passed to dumpcap is populated
differently when running Wireshark with and without -k.
Previously, only with -k was there a valid pointer in
interface_opts.timestamp_type
Fixes: aca55a2 ("Add hardware timestamping support")
Signed-off-by: Ahmad Fatoum <ahmad.fatoum(a)siemens.com>
Change-Id: Ic7ecc5a1190c28197d6a7271f1b353f74d43ca61
Reviewed-on: https://code.wireshark.org/review/23160
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a34445c1cf340a5e617464aec4042d…
commit a34445c1cf340a5e617464aec4042df447327de5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 18 12:32:17 2017 -0700
WSUG+WSDG: Add a typographic conventions section.
Create a common_src directory for common guide content. Add a
typographic convention section. Update some of the content accordingly.
Change-Id: I4f69c0f52a985c48e07fa0628b19734ec691f74e
Reviewed-on: https://code.wireshark.org/review/23131
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=aca55a29f7b982e7a0bd9911d1d176…
commit aca55a29f7b982e7a0bd9911d1d176561c8d7a84
Author: Ahmad Fatoum <ahmad.fatoum(a)siemens.com>
Date: Mon Aug 7 16:38:52 2017 +0200
Add hardware timestamping support
pcap provides a pcap_set_tstamp_type function, which can be used to request
hardware timestamps from a supporting kernel.
This patch adds support for aforementioned function as well as two new
command line options to dumpcap, wireshark and tshark:
--list-time-stamp-types
List time stamp types supported for the interface
--time-stamp-type <type>
Change the interface's timestamp method
Name choice mimics those used by tcpdump(1), which already supports this
feature. However, unlike tcpdump, we provide both options unconditionally.
If Wireshark was configured without pcap_set_tstamp_type being available,
--list-time-stamp-types reports an empty list.
Change-Id: I418a4b2b84cb01949cd262aad0ad8427f5ac0652
Signed-off-by: Ahmad Fatoum <ahmad.fatoum(a)siemens.com>
Reviewed-on: https://code.wireshark.org/review/23113
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2845f6be8db0b1720e23db0877ec83…
commit 2845f6be8db0b1720e23db0877ec837f00967bdc
Author: Ryan Doyle <ryan(a)doylenet.net>
Date: Sun Aug 20 15:15:28 2017 +1000
HTTP2: pass in the media type parameters to the media type dissector
A full media type could be "text/html; charset=utf-8". The the media type
dissector wasn't being called properly with only the "text/html" but
instead the whole string.
Additionally, make sure that the media type parameters are passed in
correctly which is important for things like multipart/* which should
have a boundary.
Most of the string parsing code was adapted from
packet-spdy.c:spdy_parse_content_type().
Change-Id: Ide59da8f65264dc142e0f9bb67671ce2af66c8a2
Reviewed-on: https://code.wireshark.org/review/23140
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9d27248cdfce6720639707170d59c5…
commit 9d27248cdfce6720639707170d59c5725033276d
Author: Darien Spencer <cusneud(a)mail.com>
Date: Sat Aug 19 21:28:28 2017 +0300
GSMTAP: Add UMTS RRC message type field
Showing a description of the 'sub_type' in the
fields tree for RRC payloads.
Change-Id: Ie4fd4498690db27d4b996fff99fa74b676be9ddb
Reviewed-on: https://code.wireshark.org/review/23133
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c11ceb3a0da74711f8fd9fa6598d5d…
commit c11ceb3a0da74711f8fd9fa6598d5d6fab5ff57b
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Mon Aug 21 22:34:50 2017 +0200
rpc: remove unnecessary NULL check
call_dissect_function() does already check internally
if dissect_function is NULL
Change-Id: I4780733ee38bcde74b498bedb1031eefa3c07da4
Reviewed-on: https://code.wireshark.org/review/23159
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a0b2a5989d80486916438a42364f50…
commit a0b2a5989d80486916438a42364f50b46d1b0645
Author: Diederik de Groot <dkgroot(a)talon.nl>
Date: Sun Aug 20 23:24:22 2017 +0200
[skinny]: minor changes to xml file
- Fix/syncronise spelling for similar field types
- Fix cog.py script invocation
Change-Id: Iab6d8ac6414c1ba9b97c49d7d0a4d2609eb1a55b
Reviewed-on: https://code.wireshark.org/review/23153
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fa390fa8f388efbc1859d22663e169…
commit fa390fa8f388efbc1859d22663e1694739ad77eb
Author: Anthony Coddington <anthony.coddington(a)endace.com>
Date: Fri Aug 18 20:51:14 2017 +1200
Fix bit depth of color psml and pdml xml attributes
color_t is 16-bit per channel, the print string assumes the usual 8-bit.
Use 8-bit per channel as per older patches proposed for bug 6682 via
color_t_to_rgb().
Change-Id: I7d71bc04e52376c0ecb598aedafa066f982de840
Ping-Bug: 6682
Reviewed-on: https://code.wireshark.org/review/23154
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5939c7417d1f2e24b6e9b78160fe75…
commit 5939c7417d1f2e24b6e9b78160fe7588d634e7e1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 20 21:05:07 2017 +0200
RSVP: Add value_string for ctype session
Need to add for other ctype value too...
Change-Id: I815fee790403d848fed4c3501dae9951dbcb93a3
Ping-Bug: 13977
Reviewed-on: https://code.wireshark.org/review/23152
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4afbd656b48a6463736cc3aeb10567…
commit 4afbd656b48a6463736cc3aeb1056761b31e0fd9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 20 20:37:01 2017 +0200
RSVP: fix length of PSMP ID (2 -> 4)
Ping-Bug: 13977
Change-Id: I162d967d4d38296231d5a16d651f848d600d49bc
Reviewed-on: https://code.wireshark.org/review/23151
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b66bdbd4268566f454d73fa92a4607…
commit b66bdbd4268566f454d73fa92a46079c180d1e71
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 20 17:38:25 2017 -0700
More explanation in the comments.
Change-Id: I1e5597ac291d38370e8b1537a75f3ba1d9a86bc9
Reviewed-on: https://code.wireshark.org/review/23156
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=940903c6492b68d5d9aea247bfadb7…
commit 940903c6492b68d5d9aea247bfadb709ddaf20f5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 20 17:09:56 2017 -0700
Use a Wayback Machine URL for the PPI documentation.
It's not available from cacetech.com any more.
Change-Id: I6627a9102235f07731c55a2fe3cd82adc1899450
Reviewed-on: https://code.wireshark.org/review/23155
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a26fb9072917d0c48a0dc926001896…
commit a26fb9072917d0c48a0dc9260018967eaf11c352
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 20 19:25:38 2017 +0200
802.11: Add Neighbor Sublement ID dissection
BSS Transition Candidate Preference (Figure 9-299)
BSS Termination Duration (Figure 9-300)
From 802.11-2016
Bug: 13985
Change-Id: I352a41c46ff741070c51f4ddc661e26a40d21570
Reviewed-on: https://code.wireshark.org/review/23149
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a03e4ea191b0937fdfd5337cb93043…
commit a03e4ea191b0937fdfd5337cb9304392056723d0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 20 19:07:17 2017 +0200
802.11: Update subelement IDs for Neighbor report
Table 9-151 from 802.11-2016
Ping-Bug: 13985
Change-Id: Ie2b0650feb03b984b2ac3c42ca46f4b5b8ed923c
Reviewed-on: https://code.wireshark.org/review/23148
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=61d45acfb580d9fe93ed1c6e66266c…
commit 61d45acfb580d9fe93ed1c6e66266cd0af485da7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 20 18:52:19 2017 +0200
802.11: Add new flags on BSSID Info in neighbor report field (from 802.11-2016)
Ping-Bug: 13985
Change-Id: I4188767021455002119b64862264e1540314f8cc
Reviewed-on: https://code.wireshark.org/review/23147
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ad085e567e97a65ec8c4d402014374…
commit ad085e567e97a65ec8c4d402014374b3022e85f4
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Aug 20 18:41:35 2017 +0200
802.11: Add always Data of Subelement (on Neighbor Report)
Fix also typo on Neighbor Report Subelement length filter display name
Ping-Bug: 13985
Change-Id: I924cadddb0d5f060d8af08cf0f27cab40f3bd6bd
Reviewed-on: https://code.wireshark.org/review/23146
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=edc63f5ef7d0655093bb01b0accb13…
commit edc63f5ef7d0655093bb01b0accb130fd4de8dd8
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Aug 20 08:07:21 2017 +0000
[Automatic update for 2017-08-20]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: I676dc2814760f711a3d3b8b4979ef8a0077e26a1
Reviewed-on: https://code.wireshark.org/review/23141
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1a38472d047893bc91fb9fd82d1e64…
commit 1a38472d047893bc91fb9fd82d1e641a7b1c03ad
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Aug 19 23:59:02 2017 +0200
nordic_ble: Preserve legacy version support
Change-Id: I8354955f802ba47158b78358084cd4211c1c6d79
Reviewed-on: https://code.wireshark.org/review/23137
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=50510a670d1ba15973d6c895eccfc0…
commit 50510a670d1ba15973d6c895eccfc0754af2852d
Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Date: Sat Aug 19 22:24:56 2017 +0200
sharkd: minor changes in comments, fix style.
Change-Id: I72d856bf223cea966bd505031417bc2b4dd12f82
Reviewed-on: https://code.wireshark.org/review/23136
Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7a9b9fd136430287e583ed323c8c7f…
commit 7a9b9fd136430287e583ed323c8c7f12292913ba
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Aug 19 22:02:43 2017 +0200
nordic_ble: Add packet format description
Also move "Length of packet" to correct position.
Change-Id: I2efd5087396a8904eb16bcc3191cc9ea3beac2e9
Reviewed-on: https://code.wireshark.org/review/23135
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0831becc1a650399b5cc417f65f564…
commit 0831becc1a650399b5cc417f65f5649a9cd76270
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Jun 19 10:37:29 2017 -0400
Remove support for CPack.
It's very incomplete and we already have installation makers for supported OSes.
Change-Id: Ide6332b9b6d69b66e7262662d781b548526ab752
Reviewed-on: https://code.wireshark.org/review/22226
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7981d4bf0edc69ceea28914ae78899…
commit 7981d4bf0edc69ceea28914ae78899b0ef3850be
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Aug 18 13:52:48 2017 +0200
gitlab-ci: add gcc 7.
Change-Id: I3b03c9fcbe67cca5c818f40875dc4828baa05012
Reviewed-on: https://code.wireshark.org/review/23118
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=25631a44ac1524ad1dbed444a8fc44…
commit 25631a44ac1524ad1dbed444a8fc44bdf08c1ea5
Author: Chris Brandson <chris.brandson(a)gmail.com>
Date: Fri Aug 18 09:37:12 2017 -0700
ZigBee scenes cluster scene valid attribute displaying incorrect bit
During validation it was discovered that the incorrect bit was displayed,
verified against the ZigBee test tool that bit 0 is used for validity
Change-Id: Iaaa2f8021b2aa269f660626fdd252cade732b60f
Reviewed-on: https://code.wireshark.org/review/23124
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9e21f4b8ee27480cce4bc0e4dc3d0c…
commit 9e21f4b8ee27480cce4bc0e4dc3d0c5eefe24e1c
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 18 08:44:21 2017 -0700
WSUG: Update the TCP analysis section.
Clarify and fix some items.
Change-Id: I1f9f8a32ceaa1de4c1ec2936913c87c08ba63c88
Reviewed-on: https://code.wireshark.org/review/23123
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=4f76eb002d65d801d5c262f7b21594…
commit 4f76eb002d65d801d5c262f7b21594d1421de4fd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 16 17:18:30 2017 +0200
RSVP: add Session C-type RSVP_SESSION_TYPE_P2MP_LSP_TUNNEL_IPV6
Change-Id: I493771df32b83691fa587b9a725c15df6057fb52
Ping-Bug: 13977
Reviewed-on: https://code.wireshark.org/review/23104
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=96dd97f9ba37ae0e708d2917e78c1a…
commit 96dd97f9ba37ae0e708d2917e78c1a61d385266b
Author: Sergey Avseyev <sergey.avseyev(a)gmail.com>
Date: Fri Aug 18 14:42:40 2017 +0300
couchbase: update status codes
Change-Id: I7f0950d82c50c8f019d844d726ffe7a0015618c5
Reviewed-on: https://code.wireshark.org/review/23117
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6020f0f93d4cce75b08d9a6ecb51de…
commit 6020f0f93d4cce75b08d9a6ecb51de08975b197f
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Fri Aug 18 13:27:49 2017 +0100
WSDG: More VS 2015 fixes
Change-Id: I5f0d543032f62bd0c57c14a56771a63fe1bed3a3
Reviewed-on: https://code.wireshark.org/review/23122
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=b8fb78c5ac719d9ec03cf1923d750d…
commit b8fb78c5ac719d9ec03cf1923d750d1a8b507aa9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 16 16:34:46 2017 +0200
RSVP: fix name of PSMP ID field (SESSION object C-Type 13/14)
Also display PSMP ID in decimal
Ping-Bug: 13977
Change-Id: If6b87ab87339038d763dcc1c97353aaf9d69a02c
Reviewed-on: https://code.wireshark.org/review/23103
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=581461bb3458c4c89ac8700bafb666…
commit 581461bb3458c4c89ac8700bafb6669449f326ae
Author: Paul Offord <paul.offord(a)advance7.com>
Date: Fri Aug 18 08:30:11 2017 +0100
TRANSUM fails with DCE-RPC request Packet Type 0
TRANSUM fails to calculate RTE figures for DCE-RPC where request Packet
Type is zero
Bug: 13988
Change-Id: I1dd7aee0283042703530a6d72fff063279e6147e
Reviewed-on: https://code.wireshark.org/review/23115
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b1a6f11e4271265e4de9722c020158…
commit b1a6f11e4271265e4de9722c020158d2c075ff9d
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Fri Aug 18 13:14:44 2017 +0100
WSDG: Remove obsolete VS 2010 info from quick setup
Change-Id: I767e04538d17702346e9343e136fc0ea4c2f9ec3
Reviewed-on: https://code.wireshark.org/review/23120
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=b62eee0d7f150cdf840efff175888e…
commit b62eee0d7f150cdf840efff175888eacde993622
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Fri Aug 18 13:09:35 2017 +0100
WSDG: Update Qt installation info
Change-Id: I9da1c68949ac48e3e88227e9c4f4d4930dbd3268
Reviewed-on: https://code.wireshark.org/review/23119
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=e02ca799d966ed2054bbd78742fd0a…
commit e02ca799d966ed2054bbd78742fd0a61f8bd959e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 8 08:41:31 2017 +0200
msdp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ie98f0c70190206b4682bf1b1b13add51c52303db
Reviewed-on: https://code.wireshark.org/review/23009
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b8c22283218b36853c70620037973f…
commit b8c22283218b36853c70620037973ff271f0273a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 8 22:59:42 2017 +0200
ws.css: fix invalid color
use the same like original http://www.methods.co.nz/asciidoc/docbook-xsl.css
Reported by Jay Turner
https://www.wireshark.org/lists/wireshark-dev/201707/msg00141.html
Change-Id: Ia44d7cbd24c1b2f3b9b011d3ed07619d2fa733cd
Reviewed-on: https://code.wireshark.org/review/23022
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=21672e51e43db1fbb3936234626481…
commit 21672e51e43db1fbb39362346264815a5bba0f16
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Aug 18 12:56:27 2017 +0200
WSDG: Reference to an existing Qt version
Change-Id: Ia1c61cabf1bf3378bf993501dc1362163f33f1ed
Reviewed-on: https://code.wireshark.org/review/23116
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f76e1c8c84eeaee504db9bb7510109…
commit f76e1c8c84eeaee504db9bb7510109247655e372
Author: Chris Brandson <cjb(a)exegin.com>
Date: Mon Jul 17 18:33:35 2017 -0700
ZigBee fix Default Response dissection
The ZCL Default Response command can be sent in response to any profile-wide or
cluster specific command. The Default Response command is itself a profile-wide
command so the Default Response frame control is of no help in deciding whether
the original request is profile-wide or cluster-specific. The simplest solution
is to not attempt interpretation. A more sophisticated solution would be to cache
all ZCL frame counters and match Default Responses based on sequence number, but
this is problematic because sequence numbers repeat. At least for now we can
always display the information correctly.
Change-Id: I827e2d2f9d6e5f7c9dfa572d2ee2ac3c9f170d70
Reviewed-on: https://code.wireshark.org/review/22688
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6726d9e0cd61634c6bae95857efb2e…
commit 6726d9e0cd61634c6bae95857efb2e549ab8f7be
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Aug 17 16:54:29 2017 +0200
[GSM MAP] Dissect Ext2-QoS-Subscribed, Ext3-QoS-Subscribed and
Ext4-QoS-Subscribed
Change-Id: Ic6a0f80d5f2339fd90284d1fddffe57b66c6771d
Reviewed-on: https://code.wireshark.org/review/23108
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5f52e655002de5fa4ff29d32869cfc…
commit 5f52e655002de5fa4ff29d32869cfca2b7eda214
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Tue Aug 15 09:12:31 2017 +0200
androiddump: Support 802.11 monitor and nlmon interfaces
Some Android devices support 802.11 monitor mode and nlmon
interfaces. Add linktype defines to be able to capture frames
from such interfaces.
Change-Id: I8b8b444ac2821542fc946694b71c8d9fb7ba1238
Reviewed-on: https://code.wireshark.org/review/23080
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e13a81c62a1312ab39f228c70a0c04…
commit e13a81c62a1312ab39f228c70a0c0479af8782ec
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Aug 17 12:12:18 2017 -0700
WSDG: More VS 2015 updates.
Switch the Command Prompt instructions back to using the
platform-specific variants. Switch back to setting WIRESHARK_BASE_DIR.
Change-Id: Ie9f865e5fac1312f2eb3762e439d53ab9a038bd4
Reviewed-on: https://code.wireshark.org/review/23112
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6e6bcacb72db2db6baada7b00924c9…
commit 6e6bcacb72db2db6baada7b00924c96ff05c5ca2
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Aug 17 14:38:54 2017 -0700
Fix some comments.
"The release mode (CMAKE_BUILD_TYPE=release) defines NDEBUG" isn't
Linux-specific; it's true in the Unix Makefile generator, and possibly
in other generators. (The Visual Studio generator, at least for newer
versions of VS, lets you specify at *build* time what type of build to
do, so the generated build files don't unconditionally define, or not
define, NDEBUG, they do so based on the build type.)
The RPATH stuff is done on Unix-like systems *except* for macOS.
Change-Id: Ieffbaaa9a8e11a1a30b34036a2412c6735baa0c8
Reviewed-on: https://code.wireshark.org/review/23114
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1e659474c93d48e07e3908814bd423…
commit 1e659474c93d48e07e3908814bd423c228d38f2f
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Thu Aug 17 18:54:28 2017 +0200
GTPv2: Fix length of EPS Bearer ID (EBI)
Field is only 1 not 2 bytes long.
Bug: 13987
Change-Id: If22e19e917bd41907248a497b30883e89fc9ff4b
Reviewed-on: https://code.wireshark.org/review/23109
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f04cb33494a4b3009390cfc01e9a72…
commit f04cb33494a4b3009390cfc01e9a7247c8a132ae
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 16 12:58:32 2017 +0200
TLS: Add new cipher suite from draft-ietf-tls-ecdhe-psk-aead
Change-Id: I256496618e67df70ce02ee90f21bc0cd556b0b5a
Reviewed-on: https://code.wireshark.org/review/23105
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8625c1902d41735a34a3698f4cbbba…
commit 8625c1902d41735a34a3698f4cbbbac6cc21290a
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Aug 17 13:26:35 2017 +0200
802.11: Add dissection of BSS Transition candidate List entries
It is a list of Neighbor report (for request and response)
Missing dissection of Neighbor Sublelement 0x03 (BSS Transition Candidate Preference)
Issue reported by Mark Williams
Bug: 13985
Change-Id: Ic3871866ba4779ee69e91d6d57b46926466b340c
Reviewed-on: https://code.wireshark.org/review/23107
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d56de21d6a56b1897c420802294359…
commit d56de21d6a56b1897c420802294359b1678bc40a
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Thu Aug 17 10:21:19 2017 +0200
androiddump: Fix bt snoop capturing
Recent changes had the bt snoop capturing function stop working for
Android API versions >= 21. One of the command strings used for
detecting btsnoop server socket interface got messed up when
refactoring code. Fix by using the correct command strings again.
Fixes: faf100ec ("androiddump: Introduce adb_connect_transport helper
function")
Change-Id: Id645d24cfb0cb23f36484cfd6416768c89bce51b
Reviewed-on: https://code.wireshark.org/review/23106
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fc6f7b9021abd604f0d8650881885a…
commit fc6f7b9021abd604f0d8650881885a5443c2ecb2
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 16 17:52:55 2017 -0700
Fix capitalization.
Change-Id: I43017bae5bc74678113377d0b4aad3d712647c5d
Reviewed-on: https://code.wireshark.org/review/23099
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4136bff2d0f2a805ea2b7f8b75f78f…
commit 4136bff2d0f2a805ea2b7f8b75f78ff48ec79da0
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Aug 16 19:26:42 2017 +0000
CMake: Switch back to shipping README.txt on Windows.
Instead of trying to ship README.md, convert its line endings and make
sure the result is named README.txt.
Change-Id: I4e081587c73342b01633b3a31ea03068e3fc1733
Reviewed-on: https://code.wireshark.org/review/23098
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=62d60108543bab32c4299e0aa90299…
commit 62d60108543bab32c4299e0aa90299975e435b64
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Aug 16 21:18:44 2017 +0200
[GTPv2] Add dissection of Message Priority
Change-Id: I86e3097a322a4a354235ce941e52e6d4c6baf8ca
Reviewed-on: https://code.wireshark.org/review/23097
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c4e957b9746407c07efbb937d21b7c…
commit c4e957b9746407c07efbb937d21b7c31894d269e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 16 12:09:19 2017 -0700
Fix build.
That's a separate README file for this directory, and its name is
README, not README.md like the top-level README file.
Change-Id: I9ec920de6a844441e00d4608608563bc4ddd8349
Reviewed-on: https://code.wireshark.org/review/23096
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7df594c92efaa777598f23fe22e005…
commit 7df594c92efaa777598f23fe22e005c09103fd6f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 16 11:09:24 2017 -0700
Update URL for Visual Studio Community Edition.
The old URL fetched VS 2013 when I tried it; update to a link that
fetches VS 2015.
Change-Id: Ib33e8f09bef51a532c986e70ae6ac5d9d1f1dabe
Reviewed-on: https://code.wireshark.org/review/23094
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e7284adcdfc5302c46587890c62a28…
commit e7284adcdfc5302c46587890c62a28eaac5aedd7
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Aug 6 16:03:00 2017 +0100
RADIUS: Remove some shortcuts in how we handle Ascend-Data-Filter
Do it via type "abinary" like the comment suggests.
Note: VSA "abinary" code path untested.
Ping-Bug: 11630
Change-Id: Ie8ebbb2fdbc9f04faad40150652277f1396ea030
Reviewed-on: https://code.wireshark.org/review/22973
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=71dd3658b727489a75c068d7bc8170…
commit 71dd3658b727489a75c068d7bc8170078c9582a6
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Jul 27 19:01:02 2017 +0100
RADIUS: Add preference to disable RFC 6929 extended attributes
This is an ugly workaround for the fact that attributes 241-246 are
currently hardcoded as extended type. This is to restore previous
functionality to dissect some Ascend AVPs that shouldn't be using the
IANA allocation space.
Ping-Bug: 11630
Change-Id: I6bebefd21fe5149f5f57b3280c9992a0eca85e62
Reviewed-on: https://code.wireshark.org/review/22972
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4319b35e2bdf7aede32db3e81830b6…
commit 4319b35e2bdf7aede32db3e81830b68ef37fa4b9
Author: Darien Spencer <cusneud(a)mail.com>
Date: Tue Aug 15 19:55:39 2017 +0300
RNSAP: Call RANAP dissector for RANAP-RelocationInformation
This IE is a transparent container of a RANAP message
according to TS 25.413 - Section 11.2
Change-Id: I2080c9a75ce2acc947eade9c60b12c49080f8ee8
Reviewed-on: https://code.wireshark.org/review/23085
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2f0bd7b1f1493c4805c172f2202598…
commit 2f0bd7b1f1493c4805c172f2202598efc1f1c8c0
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Aug 15 19:58:18 2017 -0400
UDP: Bugfix handling UDP checksum of 0.
Copy/pasteo made it "unverified", when it should have been labeled
"Not present"
Bug: 13955
Change-Id: If3b8dea276ae38ba8169762ed7ed8e764022b5d7
Reviewed-on: https://code.wireshark.org/review/23091
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ff5280906cd6de3cd86bd9c5c63fe2…
commit ff5280906cd6de3cd86bd9c5c63fe2aaf372aa70
Author: Sam Cisneros <Sam.Cisneros15(a)protonmail.com>
Date: Sat Aug 5 11:58:24 2017 +0300
NBAP over SCTP heuristic dissector
Bug: 13866
Change-Id: I895266a6aa7458aa3ab18742bcd981986c2fd17c
Reviewed-on: https://code.wireshark.org/review/23074
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8c89de612feaf89e430798870cc0ff…
commit 8c89de612feaf89e430798870cc0ff15b432ff74
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Aug 15 20:25:55 2017 +0200
TCAP: fix infinite loop introduced in g35f9349396
Bug: 13926
Change-Id: I6bb06639f1226d6f5faee614858f5f09953d3ff5
Reviewed-on: https://code.wireshark.org/review/23087
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=88484ab05103cc51746c8c3d8d80f7…
commit 88484ab05103cc51746c8c3d8d80f7304d5e5245
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 15 11:31:05 2017 -0700
Update RFC and I-D references.
Give draft-frascone-xml-dictionary for the dictionary syntax.
Give RFC numbers and I-D names, rather than URLs to the plain text
versions of them; that way, you can more easily go to the HTML versions,
which give more information.
The "more information" for I-Ds may include later drafts and the final
RFCs, and for RFCs may give newer RFCs obsoleting the older ones; add
the RFC numbers for the I-Ds and the RFC number for the current Diameter
RFC.
Change-Id: If01ea341af3ae892755a243bd1dd66acfdfd5062
Reviewed-on: https://code.wireshark.org/review/23086
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f49ae745c1774213600bc054cb08d9…
commit f49ae745c1774213600bc054cb08d949286d9314
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Aug 3 14:36:47 2017 +0200
extcap: use options as they are shown in the dialog.
Bug: 13051
Change-Id: I287a4e1d529cc281aaae4a786010358c108d5f93
Reviewed-on: https://code.wireshark.org/review/22933
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=719adb4fdc61e5187efefdfeb25a41…
commit 719adb4fdc61e5187efefdfeb25a41d60d40be7f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 11 12:43:48 2017 -0700
Convert README to README.md.
Convert the contents of the top-level README to Markdown and give it a
.md extension. Most of our documentation is plain text or AsciiDoc, but
the top-level README file in a Git repository is special in that many
online browsers will show the README contents along with the directory
listing and those browsers tend to favor Markdown. This is true of
GitHub (which we're currently mirroring to), Gerrit via its Gitiles
plugin (which we're not yet using but likely will), and other places.
Add "foreign" to AM_INIT_AUTOMAKE. There is probably a joke to be
made here about the FSF and border walls.
Change-Id: I87c306d74864e1f0a432225b160a1b4483ee946c
Reviewed-on: https://code.wireshark.org/review/23049
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f4ca61220aa65e42d880c947ce9c01…
commit f4ca61220aa65e42d880c947ce9c01dfe5bc8d4b
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Tue Aug 15 09:03:45 2017 +0200
androiddump: Avoid linktype/encap conversion
Let androiddump's internal definition of encap types directly
use linktype values from libpcap/wiretap. This way back and forth
conversion between internal and public values can be avoided.
Change-Id: I67522283cc3eb15cbdb1bfdd829bb1ff0031bb82
Reviewed-on: https://code.wireshark.org/review/23079
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bc9bf64f8dc7053ebe3ae75152472d…
commit bc9bf64f8dc7053ebe3ae75152472d7149e077ce
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Aug 14 23:08:56 2017 +0200
Qt: fix compilation without pcap.
Change-Id: Ib8d21d63730ea6e18032b89ba0042ee7521645a8
Reviewed-on: https://code.wireshark.org/review/23078
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=35f9349396d4dfbcccdf977cf9d7f3…
commit 35f9349396d4dfbcccdf977cf9d7f3096df5aa0e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Aug 11 21:40:20 2017 +0200
TCAP: more fixes for SRT analysis
- when building the END hash entry, always use the BEGIN destination
address. If no match is done, we will search using the BEGIN entry anyway
- add the source PC to the END hash entry. As it will be used for
messages initiated by the host that sent the BEGIN, we probably can
assume that the PC will not change
Bug: 13926
Change-Id: Iaa8b09bf6821961d1eab22683600f36d77bd2cc5
Reviewed-on: https://code.wireshark.org/review/23048
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9f7f401f325d2e92016e99cc39992d…
commit 9f7f401f325d2e92016e99cc39992d9ee34f73bf
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 14 13:02:34 2017 -0700
CMake: Remove an unused variable.
Remove a variable apparently left over from the DocBook→AsciiDoc
transition.
Change-Id: Ieb6e2fd282ab71227bc5d33c200f04051acf529b
Reviewed-on: https://code.wireshark.org/review/23077
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=01449b849e55e9cb599a9a9c5c3d0e…
commit 01449b849e55e9cb599a9a9c5c3d0ef0db4181d3
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 14 11:40:39 2017 -0700
WSUG: Remove the protocol help section
The protocol help feature was completely removed in g09efa5fb8b and
deprecated long before that.
Change-Id: Ia0bde785002025c0cf9e3f783a5cad7f784938a2
Reviewed-on: https://code.wireshark.org/review/23076
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=7ff66471fa4a314021a6fbdb9f9f32…
commit 7ff66471fa4a314021a6fbdb9f9f32989779fd93
Author: olivermd <oliver.downard(a)couchbase.com>
Date: Thu Aug 10 15:13:44 2017 +0100
Couchbase: Add doc flag support to dissector
This patch makes required changes to be able to dissect packets that use
the new subdoc doc flags. This involved modifying the existing subdoc
flags, creating the new docs flags and modifying the extras dissector.
Change-Id: Iaaf5e58d778ca5f54f76c9d27680df68eee8b7bd
Reviewed-on: https://code.wireshark.org/review/23032
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e347139d3fcac13ab84e8cc50242ad…
commit e347139d3fcac13ab84e8cc50242ad4b0d4a2f11
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Mon Aug 14 06:23:47 2017 -0700
ieee802.11: Replace an incorrect fall through with a break.
Table 8-216—GAS Initial Request frame body format (page 752 of the
2012 version) suggests that the only thing that comes after the length
is the actual request and since the default just inserts the bytes for
req_len, it looks like the fall-through should not be there and it
should be a break.
Change-Id: I8e5afb24fedffea869829dc9f5bf3d42b20121eb
Reviewed-on: https://code.wireshark.org/review/23075
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=691bec3c09cb8c834dcec1f21aa700…
commit 691bec3c09cb8c834dcec1f21aa700b5a342503d
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 14 10:46:16 2017 +0200
ieee80211: fix dpp doesn't match PROTOABBREV of ieee80211
and also with conflict check: 'dpp' exists multiple times with NOT compatible
types: FT_PROTOCOL and FT_UINT8
Change-Id: I98e2f7e8abbee5423e2bfa7b71b5259edd4711e4
Reviewed-on: https://code.wireshark.org/review/23071
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=34d3ad990cdcebe9f1630e805e41b0…
commit 34d3ad990cdcebe9f1630e805e41b037bca3cb17
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 14 10:43:55 2017 +0200
wifi-dpp: fix dppi.[init|resp].hash doesn't match PROTOABBREV of wifi-dpp
Change-Id: I7132f40aaed8ee217af66ec89a3ccce61a359554
Reviewed-on: https://code.wireshark.org/review/23070
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=97e0eb3ec6f3ded3549a768897a86c…
commit 97e0eb3ec6f3ded3549a768897a86cd09cae3a2e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 14 10:54:13 2017 +0200
Makefile.am (dissectors): fix align indent
Change-Id: Ifde626095a61bb3aca3f9cc101023aa4bbf3341b
Reviewed-on: https://code.wireshark.org/review/23072
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2c58885e94c7052931bace093b680f…
commit 2c58885e94c7052931bace093b680fba9cc19ddb
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Aug 14 11:10:28 2017 +0200
ieee80211: fix typo specfic => specific
Change-Id: Ic071dcccf5aab5d3a45dd6354f3cd6eedbc1a84f
Reviewed-on: https://code.wireshark.org/review/23073
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3298a5294316c51d0a77e07dbfc187…
commit 3298a5294316c51d0a77e07dbfc187148a328485
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Aug 13 23:17:21 2017 -0700
wifi: fix "multiple definition of wifi_display_ie_handle" linker error
Change-Id: I4aee15cbf241d31c274dc511be2f86b8bfeae5b8
Fixes: v2.5.0rc0-683-g3c0ff67a9c ("ieee80211: Make a few dissector tables for
vendor specific functionality")
Reviewed-on: https://code.wireshark.org/review/23069
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d6eda2a3a398b5747717b6dbc13337…
commit d6eda2a3a398b5747717b6dbc13337a6d5314416
Author: Richard Sharpe <realrichardsharpe(a)gmail.com>
Date: Sun Aug 13 21:58:39 2017 -0400
ieee80211 : Implement Wi-Fi DPP spec
Including attributes in Public Action frames and those that can appear in GAS
frames.
Change-Id: I8d2a717984295592952b8fff82879197ace2a4b2
Reviewed-on: https://code.wireshark.org/review/22615
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3c0ff67a9ca7e9c71785fa9d97cc1c…
commit 3c0ff67a9ca7e9c71785fa9d97cc1c1c13908774
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Aug 13 10:57:55 2017 -0700
ieee80211: Make a few dissector tables for vendor specific functionality
This allows vendors to more easily expand functionality.
Change-Id: Iaa6a0626f3ab3c80a3ea90ca09c90284705d0221
Reviewed-on: https://code.wireshark.org/review/23066
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=329cccfc7b3adabbcd961cc328609f…
commit 329cccfc7b3adabbcd961cc328609f23058e5a12
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Aug 13 13:50:58 2017 -0400
packet-ieee80211.c: Add dissector table for vendor specific actions
Gives a little more flexibility for vendor implementations
https://www.wireshark.org/lists/wireshark-dev/201708/msg00053.html
https://ask.wireshark.org/questions/56816/ieee-80211-vendor-specific-action
Change-Id: I0345e43140a8ac99b26932b72d08a99ca0036389
Reviewed-on: https://code.wireshark.org/review/23065
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=35a6a1396fa8b0a6fa094b39bccac7…
commit 35a6a1396fa8b0a6fa094b39bccac7c1e81a7fd3
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Aug 8 21:46:10 2017 +0200
iso14443: fix the request-response tracking
Distinguish between Waiting Time Extension (WTX) messages and other
messages. Use a composite key for the wmem tree that consists of a
boolean wtx flag and the request packet number.
Change-Id: I7783aabb231fe145a8d8c0d65c88b553d5a5b533
Reviewed-on: https://code.wireshark.org/review/23063
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f49cc4d95287859475d164890ab1e2…
commit f49cc4d95287859475d164890ab1e27847d57ccf
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Aug 13 18:33:00 2017 +0100
RADIUS: Initialize vendor attribute type to zero
Change-Id: Ic43363d93f6d573ddb8d3de3e0bd62624124d104
Reviewed-on: https://code.wireshark.org/review/23064
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=292708ab32ec46279fefb045161606…
commit 292708ab32ec46279fefb045161606037ed89330
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Aug 13 13:41:55 2017 +0200
CMake: allow CMAKE_INSTALL_RPATH to be overridden
By default CMake sets the RPATH for built binaries to the build
directory. To enable relocatable build directories, I override this
RPATH as follows during development:
-DCMAKE_BUILD_WITH_INSTALL_RPATH=1
-DCMAKE_INSTALL_RPATH='$ORIGIN:$ORIGIN/../extcap/..'
To make work (again), do not overwrite CMAKE_INSTALL_RPATH in
CMakeLists.txt.
Change-Id: I7f238af07926ea706a3f999c5b1e13286ca53a66
Fixes: v2.5.0rc0-664-g55dd9b16d5 ("CMake: Update RPATH during
installation.")
Reviewed-on: https://code.wireshark.org/review/23062
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=84b86bdfa2ef7186ede9c416a61d86…
commit 84b86bdfa2ef7186ede9c416a61d8682bf818bb7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 13 01:48:45 2017 -0700
Get rid of trailing blanks.
Change-Id: Ic236b307a0d9d81a0c906fa33599706165d4360d
Reviewed-on: https://code.wireshark.org/review/23061
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=de3a563d6698de8e45708e9d056f94…
commit de3a563d6698de8e45708e9d056f948c8eab7c8c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 13 01:46:51 2017 -0700
Clean up configuration file and plugin folder description.
Have a separate section, before all the others, giving the top-level
directories under which those folders are placed, with names for use in
later sections.
Update the example personal application data folder on Windows to the NT
6.x-and-beyond standard.
Don't give the pathnames for configuration files in the table, just give
the name and the description.
For the global files, distinguish between macOS and other Unix-like
systems, and, for the latter, mention both /usr/XXX and /usr/local/XXX.
The preferences file isn't "wireshark.conf", and hasn't been that
for
quite a while.
For all the configuration files, give the details of personal vs. global
files - they're different for different files.
Have separate sections for configuration files and plugin folders. For
plugin folders, note both the use of the top-level plugin folder for Lua
scripts and the use of the per-Wireshark-version subfolder for compiled
plugins.
Use fixed-format text for the non-variable parts of pathnames, and
italics for the variable parts.
This should, among other things, make it easier for other documents,
such as the Lua documentation in the Wireshark wiki, to refer to folders
such as the configuration file and plugin folders.
Change-Id: I133c1e159e992827458bee64c4f37be5b50f9b6f
Reviewed-on: https://code.wireshark.org/review/23060
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f2a3a705e667b1c6858391a1139d08…
commit f2a3a705e667b1c6858391a1139d08e41950e7d0
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Aug 13 08:10:56 2017 +0000
[Automatic update for 2017-08-13]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ie0e554e42e96a8b8f8c8ce7f4a9ea615276b49fb
Reviewed-on: https://code.wireshark.org/review/23056
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=e871a3ffb432095a92f11c11024b0e…
commit e871a3ffb432095a92f11c11024b0e96e23b9f7c
Author: John Keeping <john(a)metanate.com>
Date: Sat Aug 12 16:23:27 2017 +0100
ZigBee ZCL IAS: decode IAS Zone Enroll Request
Add missing decoding for the Enroll Request command in the IAS Zone
cluster.
Change-Id: I8dc0875912c87601f610173014879e13cad0820c
Reviewed-on: https://code.wireshark.org/review/23050
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=aa2117a8f250b4b0ca08b133d847aa…
commit aa2117a8f250b4b0ca08b133d847aa6768a3ce5a
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sun Jul 30 17:05:02 2017 +0200
Include xtea.[hs] in CMakeLists.txt and Makefile.am
CMake part was missing. Autotools part didn't include header.
Change-Id: I5a642a80d30b02bb16eb48e0e4e1f8e0e8332a75
Reviewed-on: https://code.wireshark.org/review/23051
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=537b083e028c636b8f8afc4a847e18…
commit 537b083e028c636b8f8afc4a847e186f4abca59f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Aug 10 10:20:30 2017 -0700
Sync some CMake and Autotools install behaviors.
Adjust the following CMake and Autotools behaviors in order to
synchronize their respective install behaviors:
- Disable tfshark by default in CMakeOptions.txt
- Add profiles/Bluetooth/preferences to Makefile.am
- Add missing captype and ciscodump entries to doc/Makefile.am
- Install help/faq.txt on all platforms in CMakeLists.txt
- Add BUILD_corbaidl2wrs, BUILD_dcerpcidl2wrs, and BUILD_xxx2deb
options to CMake and use them to adjust the corresponding parts
of the build.
- Pull the DCERPC idl2wrs build steps into the top-level
CMakeLists.txt.
This change doesn't sync everything. Some installed content still
diverges, including the following:
- CMake installs a bunch of modules into lib/wireshark:
FindGLIB2.cmake
FindWireshark.cmake
FindWSWinLibs.cmake
LocatePythonModule.cmake
UseAsn2Wrs.cmake
UseMakeDissectorReg.cmake
WiresharkConfig.cmake
WiresharkConfigVersion.cmake
Do we need any or all of these? If so, should the Autotools behavior
be synced accordingly?
- Autotools installs libtool .la files. It also installs
wireshark-gtk.desktop unconditionally.
Change-Id: I7846efe08f7139c31b6ceca6f08a1fa5168b3e22
Reviewed-on: https://code.wireshark.org/review/23041
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dc2a2424b48086ac2f79abc322070a…
commit dc2a2424b48086ac2f79abc322070a4498d01607
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jul 28 09:16:56 2017 +0200
uma: avoid global variable
Change-Id: Icc179c00b5b2bee6dc69d843de784c7519360206
Reviewed-on: https://code.wireshark.org/review/22830
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6bdd072803b4f9964416c89a36be66…
commit 6bdd072803b4f9964416c89a36be66f8643fd4c7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Jul 24 21:14:30 2017 +0200
TLS: Add QUIC Transport Parameters
See https://tools.ietf.org/html/draft-ietf-quic-tls
Bug: 13881
Change-Id: Id8ae5cdc2f7232e5db28846e528ae378fc0ac58d
Reviewed-on: https://code.wireshark.org/review/22780
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c09538e48c6fe241cec0af29294f4f…
commit c09538e48c6fe241cec0af29294f4f7eaf4a3b83
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 11 09:54:25 2017 -0700
Tools: Check for ASan directly.
Check for ASan by testing tshark directly instead of trying to infer it
from the build environment.
Change-Id: I05813161cd8c20f0c105d976706f8b62fd360cb9
Reviewed-on: https://code.wireshark.org/review/23047
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=fd2777b13887a785bd2ce722b4795a…
commit fd2777b13887a785bd2ce722b4795aab50752afa
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 11 01:01:58 2017 +0000
CMake: Make PLUGIN_INSTALL_DIR absolute.
CMAKE_INSTALL_LIBDIR is a relative path. Prefix it with
CMAKE_INSTALL_PREFIX so that PLUGIN_INSTALL_DIR is absolute.
This matches our Autotools behavior.
Change-Id: Ib42cea8745615686e0c7e8473bdb1975a3b9eccd
Reviewed-on: https://code.wireshark.org/review/23043
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=5a0aa773c1e5f1102c1a0124554794…
commit 5a0aa773c1e5f1102c1a0124554794672eaca931
Author: Sontol Bonggol <sonbonggol(a)gmail.com>
Date: Thu Aug 10 23:35:16 2017 -0700
Do not allow -m option to be larger than our allocated buffer
Specifying -m larger than our allocated buffer may result in segfault.
This patch protects it from happening and exits early.
Change-Id: I2197605d90c98fc9d12b69a68fe533aaf6457df2
Reviewed-on: https://code.wireshark.org/review/23044
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ef24608db1e4b881667ca7a670a768…
commit ef24608db1e4b881667ca7a670a76842ae52853d
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sat Aug 5 12:18:43 2017 +0100
Link forward to ftp-data from ftp commands
Change-Id: I57013fefed2e588749a208bb3e3562ca4bbef0ac
Reviewed-on: https://code.wireshark.org/review/22953
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=108b9b869bfe7475be0218d5f96828…
commit 108b9b869bfe7475be0218d5f9682818dd3f4e8b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 8 09:11:33 2017 +0200
debian: Update symbols
Change-Id: I21d6dbadb78367f58dce09f97bb6e41ab81ec67a
Reviewed-on: https://code.wireshark.org/review/23011
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=06ab7f5a4e0643c2baade6ed4c3bab…
commit 06ab7f5a4e0643c2baade6ed4c3babc2fd3e2ce0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Jul 4 13:42:03 2017 +0000
.mailmap: update (of July and Mid-August)
Change-Id: I53c3dab6f83cce138a06bb95f1f3bacec681a2a2
Reviewed-on: https://code.wireshark.org/review/23021
Reviewed-by: cedric izoard <cedric.izoard(a)ceva-dsp.com>
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=55dd9b16d5c9f3641bcb236282fb06…
commit 55dd9b16d5c9f3641bcb236282fb06983df1a5dd
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Aug 10 16:35:21 2017 +0000
CMake: Update RPATH during installation.
If we're installing into a non-system prefix on UNIX or Linux, make
sure CMake updates our RPATHs accordingly.
Change-Id: Ia6eaa6533c996a8228cff25e9d2032b223781681
Reviewed-on: https://code.wireshark.org/review/23040
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=d619a4239e3d4bc5b1f7d4829aad87…
commit d619a4239e3d4bc5b1f7d4829aad87004db37c07
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jun 23 07:45:10 2017 +0200
Add QUIC Transport IETF (draft-05) protocol
Bug: 13881
Change-Id: I9007800060dfc503a1039f652d53c9cb1cd42211
Reviewed-on: https://code.wireshark.org/review/22366
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=61eb3f0b7552b426951a99755bed59…
commit 61eb3f0b7552b426951a99755bed5983593b6243
Author: Nicolas Bertin <nicolas.bertin(a)al-enterprise.com>
Date: Thu Aug 10 14:47:37 2017 +0200
ua3g: fixed VTA type display for 8018, 8028S and 8008
Change-Id: I24158599831e432b62ff2ec0f36eeb1350c18a4b
Reviewed-on: https://code.wireshark.org/review/23031
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=21cb715dbea71c7865107503fddf3a…
commit 21cb715dbea71c7865107503fddf3ae24010fe85
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Aug 10 17:36:07 2017 +0200
SML: fix checksum verification
The checksum is stored in little endian format. Regression introduced in gad6fc87d64
Change-Id: Ic5dd58f645fbe9d791b367d5777e07acb135d38c
Reviewed-on: https://code.wireshark.org/review/23034
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=de2a738cbd4df919b8bdb3e6c824d5…
commit de2a738cbd4df919b8bdb3e6c824d55670869f36
Author: olivermd <oliver.downard(a)couchbase.com>
Date: Thu Aug 10 11:00:20 2017 +0100
Couchbase: Add get error map cmd
Change-Id: I9ca47fa0f77edd0ce94d2fe4cb098b5ff2786749
Reviewed-on: https://code.wireshark.org/review/23030
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8c72e01a318ae9946ea42211e16af5…
commit 8c72e01a318ae9946ea42211e16af5ce4772ffa9
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Aug 10 17:28:26 2017 +0200
MTP2: fix checksum verification
The checksum is stored in little endian format. Regression introduced in gad6fc87d64
Change-Id: I0fd7c972eb365e7deddd07a70e5f95fcaf006618
Reviewed-on: https://code.wireshark.org/review/23033
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f4781f3655c083cc915cc626d2e397…
commit f4781f3655c083cc915cc626d2e397da64635d90
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Aug 9 15:03:02 2017 +0200
editor_file_dialog (qt/widgets): fix indent (use 4 spaces)
Change-Id: I507737879c2e24cdca6d305b8e3775967071f1c3
Reviewed-on: https://code.wireshark.org/review/23028
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b66b4a96e3a70264ca39775219cd7e…
commit b66b4a96e3a70264ca39775219cd7eb3e7f150e3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 8 20:33:33 2017 -0700
Handle older lz4 versions.
lz4 switched from sequentially numbered releases, named rN, to
vX.Y.Z-numbered releases.
The old sequentially-numbered releases were in tarballs at
https://github.com/lz4/lz4/archive/rN.tar.gz, which extract into an
lz4-rN directory.
THe new vX.Y.Z-numbered releases are in tarballs at
https://github.com/lz4/lz4/archive/vX.Y.Z.tar.gz, which extract into an
lz4-X.Y.Z directory - no, not lz4-vX.Y.Z, just lz4-X.Y.Z.
We expect LZ4_VERSION to be set to rN for the sequentially- numbered
releases and X.Y.Z - not vX.Y.Z - for the vX.Y.Z- numbered releases.
Change-Id: Icb0275aa69b96eea43bf3a8645748a86cec81c94
Reviewed-on: https://code.wireshark.org/review/23026
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5580b3beb70ba51c5d4074e1bf6918…
commit 5580b3beb70ba51c5d4074e1bf691858ec09de0c
Author: Balint Reczey <balint.reczey(a)canonical.com>
Date: Sat Aug 5 12:32:37 2017 +0200
debian: Add script for updating shared library package names
It should be run prior to major release after the new shared library
versions are set for cmake.
Change-Id: I5cf2a3a9121672c8be14e57a318c9eaf5105e622
Signed-off-by: Balint Reczey <balint.reczey(a)canonical.com>
Reviewed-on: https://code.wireshark.org/review/22967
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
Petri-Dish: Balint Reczey <balint(a)balintreczey.hu>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6a23a4b72c57eb3e81b96563e6a8f…
commit c6a23a4b72c57eb3e81b96563e6a8faa3a810aa5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 10:32:10 2017 +0200
ofcs2: fix 'data' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: Ic04842280e829b30230c7196ab0ba1f49462f295
Reviewed-on: https://code.wireshark.org/review/23016
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4d798e62ec7740a45fa2b82ecdcb10…
commit 4d798e62ec7740a45fa2b82ecdcb102ca02d154c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 10:33:17 2017 +0200
obex: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: Id791b880d24f3ec948016c6bf00c00ac8f9cd6fb
Reviewed-on: https://code.wireshark.org/review/23017
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=591d7ec817162687bee8a278c06689…
commit 591d7ec817162687bee8a278c066891d86448e31
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 10:34:58 2017 +0200
openflow (v1): fix 'pinfo/length' was marked unused but was used
[-Wused-but-marked-unused]
Change-Id: Ie74d079cfe63dcdb5f59a576d64c93d4452edeb2
Reviewed-on: https://code.wireshark.org/review/23018
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b6d080a04e3553caa08af276881863…
commit b6d080a04e3553caa08af276881863948472fc19
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 10:36:28 2017 +0200
pcp: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: I2cd58b58ff53951044ac13caffdc901d8c1b65bd
Reviewed-on: https://code.wireshark.org/review/23019
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b4320e6662be0594beab5d9ab075e9…
commit b4320e6662be0594beab5d9ab075e9b42867b5c7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jul 28 14:18:47 2017 +0200
bootp: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused]
Change-Id: Ia711b3954aded55470d92d0787368a555481367d
Reviewed-on: https://code.wireshark.org/review/23020
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=01f2e2b2012e09210104910646feee…
commit 01f2e2b2012e09210104910646feee98128b458f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 8 15:05:37 2017 -0700
We really only need one range_foreach routine.
Rename range_foreach_r() to range_foreach(), getting rid of the old
range_foreach().
If your callback doesn't require an additional argument, just pass NULL
when calling range_foreach(), and declare the argument as unused.
Change-Id: I49a56f90610e39cf2ddc398c9e30ed11a6ca90db
Reviewed-on: https://code.wireshark.org/review/23025
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3bcd0e142a3540ed8fa7a339728d0c…
commit 3bcd0e142a3540ed8fa7a339728d0c10bacadcc8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 8 14:04:53 2017 -0700
Fix a comment.
\, not /, is the standard pathname separator on Windows.
Change-Id: Ia1f1be5e4bd76519e27df430e8ef46967ffe35f5
Reviewed-on: https://code.wireshark.org/review/23024
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ae3fd56b20b1e1c0b2b9871827ed2f…
commit ae3fd56b20b1e1c0b2b9871827ed2f3529576717
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 8 14:02:45 2017 -0700
Check for errors running the Lua scripts.
Also, fix error messages reported for lua_load() to speak of
precompilation, not execution (the script isn't *executed* until
lua_pcall() is called).
Change-Id: I7ac9ee6e5df7612f9af141e51958fbfad38a4083
Reviewed-on: https://code.wireshark.org/review/23023
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6d8f3ddc7c0147f0a316b53ce3c5f8…
commit 6d8f3ddc7c0147f0a316b53ce3c5f852d5eb5921
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Tue Aug 8 08:50:58 2017 -0400
checkAPIs.pl: Don't check prefs.[ch] for duplicate registered variables
Change-Id: I389aa31db4da11b2b1e8d009a4cfeca03b587f45
Reviewed-on: https://code.wireshark.org/review/23014
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Ahmad Fatoum <ahmad(a)a3f.at>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=aae0f13b7e6223afe589e63e3fb77b…
commit aae0f13b7e6223afe589e63e3fb77b8e95b00219
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Aug 8 10:29:32 2017 +0200
mrcpv2: fix bug in use of ws_strtou32.
Bug: 13952
Change-Id: I374343368c629b7f063c922f0aa8de32e21a95e8
Reviewed-on: https://code.wireshark.org/review/23012
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a8b018b71cf2732254f4f2512f0371…
commit a8b018b71cf2732254f4f2512f03719d2686f7b3
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Wed Apr 19 18:14:00 2017 +0200
Bump versions of macOS dependencies
Versions were bumped to the newest available by Homebrew.
Change-Id: I8f3f405d3644dff91035353e6f83131a507602cd
Reviewed-on: https://code.wireshark.org/review/21224
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=956ebf371940bd176ce31b8ce72445…
commit 956ebf371940bd176ce31b8ce72445ad702a7ccf
Author: Junpei Yoshino <junpei.yoshino(a)gmail.com>
Date: Sat Aug 5 15:16:44 2017 +0900
Support multiple labels with bgp
Passing multiple labels information with BGP has come to be used
together with segment routing.
Change-Id: Ifd45eb0a875ed4a166e44441955e5e42ce84a7ca
Reviewed-on: https://code.wireshark.org/review/22944
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=59e6c628931e041624607dfa67ae87…
commit 59e6c628931e041624607dfa67ae876376d23333
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Aug 7 18:36:30 2017 -0400
io_graph_dialog.cpp: Remove graph_enabled_vs.
No longer necessary with model
Change-Id: If1516f264013fabe1211aa04fe054b15e235b36a
Reviewed-on: https://code.wireshark.org/review/23007
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8d37cab5812780e7e4738e68ed7b8a…
commit 8d37cab5812780e7e4738e68ed7b8a5980a9e9b0
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Mon Aug 7 23:25:52 2017 +0100
SMTP: show text lines within a PDU fragment.
Change-Id: I49ef553c29742ba18d477a61183ce8b6f5e23233
Reviewed-on: https://code.wireshark.org/review/23006
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=300be929de03281a31c0cf5e91302a…
commit 300be929de03281a31c0cf5e91302ad5baba1cd2
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 8 00:11:18 2017 +0200
dns: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I1bb25125d9bd7b62b5784bd43d933dc5ff13987c
Reviewed-on: https://code.wireshark.org/review/23005
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=24f0e6fe8a1741d8d8267e8c47cc6d…
commit 24f0e6fe8a1741d8d8267e8c47cc6dc79babecc7
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 8 00:07:20 2017 +0200
dns: remove extra semicolon
Change-Id: I710d9c519ccf012d3e74e7c2087d0f9fc5cfca12
Reviewed-on: https://code.wireshark.org/review/23004
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f5332121ef787684093ed46fd2e01c…
commit f5332121ef787684093ed46fd2e01c754c4ef946
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Aug 8 00:01:39 2017 +0200
XFP: use switch for adress_family
Change-Id: Id0f9fd6d49669f5d4606448788658e5a8ed89f8d
Reviewed-on: https://code.wireshark.org/review/23003
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1089bdb7d4911a5508f86a0eea5941…
commit 1089bdb7d4911a5508f86a0eea59418b424b265c
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Sun Aug 6 19:00:54 2017 +0200
checkAPIs.pl: Detect multiple preferences with same variable
Catches mistakes where the same variable is populated by multiple preferences:
prefs_register_bool_preference(epl_module, "show_soc_flags",
"text1", "desc1",
&show_soc_flags);
prefs_register_bool_preference(epl_module, "show_soa_flags",
"text2", "desc2",
&show_soc_flags);
Change-Id: I77a9432d9b518e951166c93a890a948d3f228162
Reviewed-on: https://code.wireshark.org/review/22974
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e63db3ce0ec2e92d69b5e452f71f5c…
commit e63db3ce0ec2e92d69b5e452f71f5c44cd205272
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Mon Aug 7 17:44:06 2017 +0200
Rename reentrant range_foreach2 to range_foreach_r
to avoid mistaking it for a range function that operates on pairs.
Change-Id: If9117c195ba21d55a476c3b9deb2a2ca7a1056ed
Reviewed-on: https://code.wireshark.org/review/22994
Reviewed-by: João Valverde <j(a)v6e.pt>
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c6963b1c2f87c5f7a9123aa9e8e843…
commit c6963b1c2f87c5f7a9123aa9e8e843540c18ff41
Author: Balint Reczey <balint.reczey(a)canonical.com>
Date: Sun Aug 6 19:02:35 2017 -0400
debian: Update PO files about debconf templates
Change-Id: I2880957bcff90f8fba3d5c880f7e059589191e84
Reviewed-on: https://code.wireshark.org/review/22978
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
Petri-Dish: Balint Reczey <balint(a)balintreczey.hu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b44fb245f5cef586fae8a4d3d2492d…
commit b44fb245f5cef586fae8a4d3d2492d50b0f90c93
Author: Balint Reczey <balint.reczey(a)canonical.com>
Date: Sat Jun 10 13:12:40 2017 -0700
debian: Use debconf messages instead of "echo" in postinst/postrm
Change-Id: Ice41c3a723c2606c047ad59a1fde17dfe65f3ce7
Signed-off-by: Balint Reczey <balint.reczey(a)canonical.com>
LP: #1687344
Reviewed-on: https://code.wireshark.org/review/22968
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
Petri-Dish: Balint Reczey <balint(a)balintreczey.hu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=44e117bf7340298584b449d0a313a2…
commit 44e117bf7340298584b449d0a313a2f7f388d1af
Author: Balint Reczey <balint.reczey(a)canonical.com>
Date: Sat Aug 5 17:08:53 2017 +0200
debian: Make d/copyright machine-readable
The machine-readable format is recommended by the Debian Policy Manual:
https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightformat
It also allows uscan to omit files from repacked upstream tarballs.
In wireshark package's case it allows removing the debian/ directory
from the tarball.
Change-Id: I0d56efaff26bb61048de795e109c9f5d26cbffc4
Signed-off-by: Balint Reczey <balint.reczey(a)canonical.com>
Reviewed-on: https://code.wireshark.org/review/22969
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
Petri-Dish: Balint Reczey <balint(a)balintreczey.hu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=2ca4c5d756b7f7f507b7949bc31682…
commit 2ca4c5d756b7f7f507b7949bc31682839cb3e2b8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Aug 7 12:13:56 2017 -0700
Fix lz4 and libssh uninstall.
We have to remove the lz4 build tree as root.
We can't do "make uninstall" for libssh, so manually remove the stuff
it
installs. Also, remove the -done file, and remove the downloaded
tarball and build tree if we're supposed to do so.
Change-Id: If594ab241a9955229dfbc12e4f5e0c517add6daa
Reviewed-on: https://code.wireshark.org/review/22996
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a0ee5d6e42a00d76ff8d98b8877867…
commit a0ee5d6e42a00d76ff8d98b8877867927896c165
Author: Ahmad Fatoum <ahmad(a)a3f.at>
Date: Mon Aug 7 17:42:10 2017 +0200
Fix -Wdocumentation warning about range_foreach2
Mismatch between parameter name in comment and prototype
Change-Id: Ia458362a3cc8cd073dbb0a184f28b28f12b19b9f
Reviewed-on: https://code.wireshark.org/review/22993
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=5b3e3ee58748ac1fd9201d2d3facbe…
commit 5b3e3ee58748ac1fd9201d2d3facbed1b9b1e800
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jul 23 10:53:43 2017 -0400
Use UAT model for I/O graph
Convert from using TreeWidgetItems to UAT model/delegate. More of the GUI
is "just handled" within the table.
Required to add support for "colors" and "protocol fields" to UAT
types.
Also needed to add some hacks for "custom" UAT field handlers for
backwards compatibility with the existing UAT structure used.
Because UAT functionality was switched completely to the model, some
information in the table was "lost in translation" because the UATs
themselves aren't translated to other languages.
TODO:
2. Better "order of operations"? A bunch of NULL/size checks needed to be
added to prevent crashing.
Now with model/"view" should events/functions be reordered?
Bug: 13585
Change-Id: I2bbba78182317c4fada07b927c05d0c6f4cdc0fe
Reviewed-on: https://code.wireshark.org/review/22766
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f63b0241c9eeb1ef3dc1e915820c44…
commit f63b0241c9eeb1ef3dc1e915820c440119c30526
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Aug 7 10:08:43 2017 -0700
Fix SpanDSP build with older versions of Xcode.
Older versions of Xcode don't support -Wunused-but-set-variable, so
remove it from the list of options with which to compile SpanDSP.
Change-Id: Idd298e19eaf770980da179412480e17a00514d36
Reviewed-on: https://code.wireshark.org/review/22991
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4053bde54b9c356bdee4f4e7548790…
commit 4053bde54b9c356bdee4f4e7548790ce5a06e9a5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Aug 7 15:42:37 2017 +0000
Qt: Restrict AA_EnableHighDpiScaling to Windows.
Setting Qt::AA_EnableHighDpiScaling on X11 causes problems:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13877#c20
Limit its use to Windows.
Change-Id: I8c11c575b2680402689644bcc5c224da876bba67
Ping-Bug: 13877
Reviewed-on: https://code.wireshark.org/review/22988
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=82ef9377fe88c213c5e5a02279d271…
commit 82ef9377fe88c213c5e5a02279d2714f88add665
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Aug 7 17:51:08 2017 +0100
RADIUS: Minor cleanup
Have "avp_is_extended" fully control extended attribute properties.
including "long-extended".
Change-Id: I73b3636b08fe088b7dc4113b1b4144a97bc59efa
Reviewed-on: https://code.wireshark.org/review/22989
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=4855ae29508e8a659b3620fab93c41…
commit 4855ae29508e8a659b3620fab93c4138fd7ed4f6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 20 15:45:18 2017 +0200
debian: Update symbols
Change-Id: Id65e57766d8f31615f210cfe8ac3e03a16f180c8
Reviewed-on: https://code.wireshark.org/review/22987
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5d0cf59d06cbe62fc15c2256b7a864…
commit 5d0cf59d06cbe62fc15c2256b7a86417fc0dff80
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Aug 7 10:00:53 2017 +0200
nsis: Fix typo in installer
Change-Id: Ic958729517dda653fc3f511379aa48956d87d225
Reviewed-on: https://code.wireshark.org/review/22986
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=d81f907aea269b12dc383911bfb469…
commit d81f907aea269b12dc383911bfb469addfaffade
Author: Balint Reczey <balint.reczey(a)canonical.com>
Date: Sat Aug 5 17:11:00 2017 +0200
debian: Refresh patches
Change-Id: Ib31e658cfa87f31fad9750f1ba2cf326d0944689
Signed-off-by: Balint Reczey <balint.reczey(a)canonical.com>
Reviewed-on: https://code.wireshark.org/review/22970
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ff7a6305a7eaa3c3815e813acc78a1…
commit ff7a6305a7eaa3c3815e813acc78a1660ae82293
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jul 30 23:30:59 2017 -0400
Use proper tab order for "file types" in UAT "table".
Directory and File "UAT types" have been using a separately launched
dialog, instead of an "editor", so it breaks "tab rules". Create
and
treat (File) dialog as an editor.
Change-Id: I983728abefb0cdd79899468a800328f1b56e2910
Reviewed-on: https://code.wireshark.org/review/22886
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4dc835c9c6b7af68cd63ae9efa26ac…
commit 4dc835c9c6b7af68cd63ae9efa26ac23ee3d9365
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 6 18:20:40 2017 -0700
-Wcast-align will warn about legitimate code.
Maybe there's some way to say "yes, I know that the pointer being cast
is appropriately aligned", or maybe some platforms say "yes, I know,
this is a struct sockaddr *, but those are aligned well enough for any
other socket address types", in which case we might be able to turn that
on by default in some cases.
Change-Id: I6b8cff7ebfe27785b20adbbc2f855e859b090236
Reviewed-on: https://code.wireshark.org/review/22983
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=98ff0410c83ae9868803bb81319a34…
commit 98ff0410c83ae9868803bb81319a3476dfb2c8f1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 6 18:04:43 2017 -0700
Minor comment style tweak.
Change-Id: I58359c5a7c38e61cc7c024f1c74951679522101f
Reviewed-on: https://code.wireshark.org/review/22982
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=fde17d9ba0c2d12434b26f5f0cb158…
commit fde17d9ba0c2d12434b26f5f0cb158093acfbfcf
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 6 18:03:14 2017 -0700
Separate the C-only and C-and-C++ extra compiler options.
Move -Wduplicated-branches, which is C-and-C++, above
-Wbad-function-cast, which is C-only.
This matches CMakeLists.txt.
Change-Id: I7c60695252645524f80461575ce3e92572e0efa7
Reviewed-on: https://code.wireshark.org/review/22981
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a511b7159123704c5c6e488b96c4ff…
commit a511b7159123704c5c6e488b96c4ff3311498423
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 6 17:58:00 2017 -0700
Sync up a bit with configure.ac.
Move -Wunused-const-variable after -Wc++-compat.
Move -Wduplicated-branches after -Wdocumentation.
Add some comments for the warning flags for which the configure script
does a test to make sure the compiler doesn't mishandle them.
Add some other comments.
Change-Id: I7f648ff78eb932feef34aeccfff179bd0a2e5d49
Reviewed-on: https://code.wireshark.org/review/22980
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9c3899bbf45ec3bdbb78f5249a3f7e…
commit 9c3899bbf45ec3bdbb78f5249a3f7ea05d793966
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 6 17:34:52 2017 -0700
Add a comment explaining why ASan and UBSan are involved.
Change-Id: I31a429c247ed9f8efb97560d517423b0bf2d82f1
Reviewed-on: https://code.wireshark.org/review/22979
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=cd7c47e6389d7641e65bef8215f2c1…
commit cd7c47e6389d7641e65bef8215f2c101a9977465
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Aug 6 15:49:13 2017 -0700
Fix setting COMMON_WARN_FLAGS.
If we want to add -Wframe-larger-than=16384, *append* it, don't
*overwrite* it.
Indent that code properly while we're at it.
Change-Id: Iae8894e6663500620a07589fd6ba3d00f9eac7ba
Reviewed-on: https://code.wireshark.org/review/22977
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=b0b874815d7c31057a13c062ea7e97…
commit b0b874815d7c31057a13c062ea7e973e18bde9a7
Author: Balint Reczey <balint.reczey(a)canonical.com>
Date: Sat Aug 5 12:15:35 2017 +0200
debian: Fix typo in d/control
Change-Id: Iaec804825f3d85b4b6ed4fa82300cd41849ed23d
Reviewed-on: https://code.wireshark.org/review/22966
Reviewed-by: Balint Reczey <balint(a)balintreczey.hu>
http://cgit.osmocom.org/wireshark/commit/?id=c09f3ed774a8a124eb1710cc332677…
commit c09f3ed774a8a124eb1710cc332677627da04aff
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Aug 6 10:41:42 2017 +0100
Make the services dictionary ordering stable
Change-Id: I1d148fc5bc58998818043885615965eecc86b3de
Reviewed-on: https://code.wireshark.org/review/22965
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=912542f7bec16dd3ca9aa47933b94a…
commit 912542f7bec16dd3ca9aa47933b94a395b8f5868
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Aug 6 08:08:04 2017 +0000
[Automatic update for 2017-08-06]
Update manuf, services enterprise numbers, translations, and other items.
Change-Id: Ie6f7676ccde9337cb479e448884b0240e3fd238c
Reviewed-on: https://code.wireshark.org/review/22961
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=839032dff87ae4ad5533fc275719f3…
commit 839032dff87ae4ad5533fc275719f3ee72186cbc
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Aug 5 21:01:04 2017 -0400
simple_dialog.cpp: Fix missed Qt version wrapper.
check_box_ member was missing a #if (QT_VERSION > QT_VERSION_CHECK(5, 2, 0))
wrapper
Change-Id: Ibdddbe523b8e15c0af31fddfd3f251c24114d11a
Reviewed-on: https://code.wireshark.org/review/22959
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f63b68f7078a482d31d6bc22569756…
commit f63b68f7078a482d31d6bc22569756c09a0a2202
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Aug 5 15:50:46 2017 -0700
Further cleanups.
If a variable is initialized in a loop body or an if clause or a switch
clause, declare it inside the loop body/clause, and de-initialize it
before leaving the loop body/clause.
De-initialize the gnutls_pkcs12_t before leaving rsa_load_pkcs12(), so
as not to leak it.
Always leave the per-bag loop by "goto done", even if we're not within
an inner loop, to make it clearer what we're doing.
We initialize the bag structure at the beginning of that loop body;
de-initialize it at the end.
If we leave the loop without a private key, and we don't have an error
message, the error is "we didn't find a PKCS8 key"; report that.
Change-Id: I87cf296876c8f1879f69d01ce67ca2829b4f8d16
Reviewed-on: https://code.wireshark.org/review/22958
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=1d457701c5d969f3912d763c3e912b…
commit 1d457701c5d969f3912d763c3e912b913497b97c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Aug 5 13:01:29 2017 -0400
rsa.c: strerror -> g_strerror
Pacify checkAPIs.pl
Change-Id: I637a6cd678b99d05cd1b26fd3cba6ad4dd19e8d2
Reviewed-on: https://code.wireshark.org/review/22957
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=92adb99d00eca0ff23e9c791053d93…
commit 92adb99d00eca0ff23e9c791053d93d6310faa99
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Wed Aug 2 08:53:35 2017 +0200
QT: Add shortcuts for "Follow XXX Stream"
Add shortcut Ctrl+Alt+Shift+
T for "Follow TCP Stream"
U for "Follow UDP Stream"
H for "Follow HTTP Stream"
S for "Follow SSL Stream"
Bug: 13047
Change-Id: I0fdd5b4d20b976b56694821a9c11424eab40b2b3
Reviewed-on: https://code.wireshark.org/review/22930
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c57da453bab14048f419eae6b9e9ff…
commit c57da453bab14048f419eae6b9e9ff7a332a32f0
Author: John Keeping <john(a)metanate.com>
Date: Sat Aug 5 15:13:40 2017 +0100
ZigBee: fix OTA File Version bitfield
Commit ffea2f8a24 ("ZigBee: fix endian for File Version field in OTA")
fixed the endianness of the file version field but did not update the
masks for the sub-elements of this field now that they are compared
against the value decoded as little-endian.
Change-Id: Icdb9d56cc29da19b9fc26da84979f15936c930d4
Reviewed-on: https://code.wireshark.org/review/22955
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=15c0c8db5e0aac50e44eb3e2cd6eb5…
commit 15c0c8db5e0aac50e44eb3e2cd6eb5c0b3585220
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Aug 5 12:19:02 2017 +0200
Lua: Check for PseudoHeader.none
Don't dereference pointer when using PseudoHeader.none.
Bug: 13944
Change-Id: I4e509269ac4983531912f3f9b2cc6b7cf00fbeae
Reviewed-on: https://code.wireshark.org/review/22945
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=4b4ce9fb35a46447796252cbfd1af4…
commit 4b4ce9fb35a46447796252cbfd1af4ea6b889d55
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Aug 5 12:29:33 2017 +0200
Lua: Fix error message in Dumper:dump()
Change-Id: I9cdf8ecaf5129a30091b9b4d109f70cfdd7fca1b
Reviewed-on: https://code.wireshark.org/review/22946
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=7dbc022b373c26b48b2a68106fafa3…
commit 7dbc022b373c26b48b2a68106fafa3dd25d9e7e3
Author: Robert Grange <robionekenobi(a)bluewin.ch>
Date: Fri Aug 4 19:22:48 2017 +0200
packet-mq: Improve ECapFlag display + CapFlag3 Add new Flag
Improve dispaly of Error Cap Flags
Add new Flag for Cap Flag
Misc coding aligmement
Change-Id: I9ad593dbe8bcc116057af9a6324f25451bac2a88
Reviewed-on: https://code.wireshark.org/review/22938
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b9b7389e21010b19110c0591b6639d…
commit b9b7389e21010b19110c0591b6639d334d15f019
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Aug 4 18:18:01 2017 -0700
Lines being processed are not null terminated, they're counted.
Pass the remaining line length to process_pwd_success(), and don't treat
the string passed to it as a null-terminated string, check the length
value.
Also, make sure the line is long enough before even calling
process_pwd_success().
Bug: 13946
Change-Id: I67d015854046bbaaa6f55d4221f314e1446e7398
Reviewed-on: https://code.wireshark.org/review/22943
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=cdeb6f122a80c8ae39418897346b20…
commit cdeb6f122a80c8ae39418897346b20b2c26acc00
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Aug 4 13:53:14 2017 -0700
WSDG: Update the Windows docs and add a CMake section.
Update the Windows section for Visual Studio 2015. Copy the content from
README.cmake to its own WSDG section and remove README.cmake.
Remove the PowerShell sections. Our required version (2.0) ships with
every supported version of Windows. Remove the sed section.
Change-Id: Id37c6e71bacc247a3ed1992adb1408ec13f6a187
Reviewed-on: https://code.wireshark.org/review/22940
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1cabeea9b8ab109c7a731c0f61c7b9…
commit 1cabeea9b8ab109c7a731c0f61c7b9788077ffea
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Aug 4 15:26:40 2017 -0700
Fix up indentation.
Change-Id: I99445d9934dbb4c97c4c41192c8fe908441f2843
Reviewed-on: https://code.wireshark.org/review/22942
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a25d477fa7969f6311bc8df0ff4df8…
commit a25d477fa7969f6311bc8df0ff4df8208e80fa6f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Aug 4 15:25:22 2017 -0700
Clean up private key file error reporting.
Ensure that rsa_load_pem_key() and rsa_load_pkcs12() always return an
error message string if they fail, so that
1) they don't return NULL without supplying an error string;
2) they don't supply an error string if they succeed.
If either of them fails, report the error; if there's no error string,
report an unknown error (that shouldn't happen, but the wsutil/rsa.c
code needs more cleanup before I'll believe it can't happen).
While we're at it, clean up some of those error strings, return NULL
rather than 0 as the failure case from rsa_load_pkcs12() as we do in
rsa_load_pem_key() (they mean the same thing, but NULL makes it a bit
clearer), and de-initialize the private key structure in
rsa_load_pem_key() if we fail (so that we don't leak memory).
Change-Id: Id9dd331800d87b017a500a6f579df446057f555b
Reviewed-on: https://code.wireshark.org/review/22941
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8d09f2a3adc4ac3d394ca07e5a1260…
commit 8d09f2a3adc4ac3d394ca07e5a12607ed0368d60
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Aug 4 13:12:10 2017 -0700
Don't assume that we have a last_command value in an FTP conversation.
Nothing ensures that will be the case, and if we assume it is the case,
we can crash.
Bug: 13945
Change-Id: I7f6cb47da81efe219e87b06f8def65a332273480
Reviewed-on: https://code.wireshark.org/review/22939
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=97dcf87a868a51502e1ea6a90cd7a9…
commit 97dcf87a868a51502e1ea6a90cd7a9ee3bbc59cf
Author: Olivier Verriest <verri(a)x25.pm>
Date: Sun Jul 30 14:07:43 2017 +0000
SNMP: add support for USM SHA-2 algorithms (RFC 7860)
Generlize the USM handling and add support for HMAC-SHA-2 authentication
protocols.
Change-Id: I7cca2f24db61620423fded078c680322aff86400
Reviewed-on: https://code.wireshark.org/review/22846
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dc69a8446ee47fd6d38d4fb4416db8…
commit dc69a8446ee47fd6d38d4fb4416db89ef5487696
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Aug 3 22:36:11 2017 +0000
CMake: Don't look in WOW6432Node.
CMake should check both the 32-bit and 64-bit views automatically.
Change-Id: I856814efcd660260c734c7956ad00ee43a8f666f
Reviewed-on: https://code.wireshark.org/review/22936
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f155beb0946391ea633936647b4c68…
commit f155beb0946391ea633936647b4c68998ecf01bb
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Aug 3 08:39:13 2017 -0700
Qt: Fixup the welcome screen stylesheet.
Pass in a QString argument only when we have a placeholder. Fixes a
QString::arg: Argument missing: MainWelcome { ...
warning on Windows.
Change-Id: I42dd155252bd9fd4f21f0112b62044c7397c9810
Reviewed-on: https://code.wireshark.org/review/22934
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ce7b994383a8089e7c05b7c88132fe…
commit ce7b994383a8089e7c05b7c88132fe78de9a1be9
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 2 21:32:30 2017 +0200
proto.c: fix use of proto_tree_add_text(_valist)_internal() with length = -1
When using a length of -1, use the tvb remaining length instead of 0.
Change-Id: I569e9c9f57531914a3b613c3a6a9bff076fba362
Reviewed-on: https://code.wireshark.org/review/22931
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=733c19a0720035c1aa19d79f765d72…
commit 733c19a0720035c1aa19d79f765d72b085d58bdd
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Jul 18 19:47:58 2017 +0100
Optimize the "services" dictionary
Remove assignee and other miscellaneous information that changes more
frequently than service name and can be consulted directly in the IANA
registry.
Allow merging identical transports into a single line for convenience
and size/speed optimization (a backward-compatible change).
Remove obsolete make-services.pl.
Change-Id: I3ecbd1a6a68d87c084d77498a0eeb44b7afdab67
Reviewed-on: https://code.wireshark.org/review/22872
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=936a8f1cf8c314993f7fca6f193764…
commit 936a8f1cf8c314993f7fca6f193764cb53652924
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Jul 16 19:02:41 2017 +0100
FTP: track current working directory and show as generated field
Change-Id: Ib43f0a7c96f4a2dfd931224b536a8ff5d17b0a36
Reviewed-on: https://code.wireshark.org/review/22651
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e3d0bf0bb2aea5e6f18cce32ad0e75…
commit e3d0bf0bb2aea5e6f18cce32ad0e75e14169c413
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Aug 3 13:39:26 2017 +0200
extcap: skip custom log if filename is space.
Change-Id: I98b890316af05d9c5359dc38a30d07ac55f262fe
Reviewed-on: https://code.wireshark.org/review/22932
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f978465fb36cc8ea799ba5553f5c67…
commit f978465fb36cc8ea799ba5553f5c6722c7cf241a
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Jul 23 22:54:31 2017 +0200
extcap: add debug log file feature to extcap-base.
Change-Id: I3bfc9b2fd7b73dcfef52c5101360384d205c0d12
Reviewed-on: https://code.wireshark.org/review/22835
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=03f9bd4091ef42e7dc42ef8fb275bc…
commit 03f9bd4091ef42e7dc42ef8fb275bc26cd619d5a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 2 18:17:19 2017 +0200
MAC LTE: upgrade dissector to v14.3.0
Change-Id: Icd3b12b7d89df2050b9365b9b173949a7cdc455a
Reviewed-on: https://code.wireshark.org/review/22928
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e4a8c71da8f742e3b1cadf70069554…
commit e4a8c71da8f742e3b1cadf70069554cc0ef1f8c1
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 2 16:11:53 2017 +0200
RLC LTE: update header to reflect the correct version
Change-Id: Ic9146d4679fc4af0800bbc1bdf40ec54d1809f1a
Reviewed-on: https://code.wireshark.org/review/22927
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f524eb4dc114cc297d68a42ed9ed57…
commit f524eb4dc114cc297d68a42ed9ed57fcebcde4f0
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Aug 2 15:57:11 2017 +0200
PDCP LTE: upgrade dissector to v14.3.0
Change-Id: I96d2a9e703f1c9403f09d77e6b8ee06658b9c40f
Reviewed-on: https://code.wireshark.org/review/22926
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ddb373ecb0510a0e52c030fce4ff04…
commit ddb373ecb0510a0e52c030fce4ff0485b1d0345b
Author: Marius Paliga <marius.paliga(a)gmail.com>
Date: Wed Aug 2 13:40:50 2017 +0200
mpeg descriptor: dissect ac3 system a: Respect descriptor length
Bug: 13939
Change-Id: I3fbbbb4e806e0732c2d11a7fd5048528c5f6f328
Reviewed-on: https://code.wireshark.org/review/22923
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=31dc0310e2303deb9eec4824632683…
commit 31dc0310e2303deb9eec4824632683313d0d8699
Author: Mike Lugo <mlugo.apx(a)gmail.com>
Date: Wed Aug 2 10:10:23 2017 -0400
Added AVP definitions for the following AVPs:
132017 - Override-Control
132019 - Override-Charging-Action-Parameters
132021 - Override-Charging-Action-Exclude-Rule
132022 - Override-Charging-Parameters
132024 - Override-Rating-Group
132026 - Override-Online
132027 - Override-Offline
For reference, page 51:
http://www.cisco.com/c/en/us/td/docs/wireless/quantum-policy-suite/R13-0-0/…
Change-Id: I397dfad5ea0bd7d06d8b06034c44cc676c293416
Reviewed-on: https://code.wireshark.org/review/22925
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1da9d28edc9eae3414d4d04880add6…
commit 1da9d28edc9eae3414d4d04880add60a7e8e0c6d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 2 00:44:07 2017 -0700
Distribute macos-setup-brew.sh in the source tarball.
Change-Id: I9521810d7e9d8b3b13f7949256fa409eafd1cc2c
Reviewed-on: https://code.wireshark.org/review/22920
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0147a74becb2020850d75a611c6529…
commit 0147a74becb2020850d75a611c65294520bd6c64
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 2 00:41:49 2017 -0700
Remove trailing white space.
Change-Id: I6b650521e86a64526db75f38bfb93ea1b890f6a1
Reviewed-on: https://code.wireshark.org/review/22919
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2a17c33928eba4ee0e383ee838b598…
commit 2a17c33928eba4ee0e383ee838b5980748448730
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 2 00:39:58 2017 -0700
Move macosx-setup.sh to tools and remove the "x".
The OS is now called just macOS, and the rest of the setup scripts are
in tools, so move this one there as well.
Update the documentation to reflect the change.
Change-Id: I4d9ebf0797ffe8862e82c4bcfdeec1d2eabae6ae
Reviewed-on: https://code.wireshark.org/review/22918
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c5569cfa0b985b763608231fe4b2fc…
commit c5569cfa0b985b763608231fe4b2fc976422aa33
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Aug 2 00:30:28 2017 -0700
Note that newer versions of various distributions won't have these problems.
Change-Id: Ib5f0d9ffe4a2a574c5cc2299271d3c5f9828dede
Reviewed-on: https://code.wireshark.org/review/22914
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=778117c502d9e702327f592784c8d7…
commit 778117c502d9e702327f592784c8d7b94212302c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 1 17:41:03 2017 -0700
macosx-setup.sh doesn't build Qt, it just installs a binary.
Say it builds "as needed".
Change-Id: I85ce2062da7f168785d0d22160b8f19b85d554e3
Reviewed-on: https://code.wireshark.org/review/22909
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e23e28da225fc51493f1694f9f61bc…
commit e23e28da225fc51493f1694f9f61bc23df1b9ad9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 1 17:04:15 2017 -0700
Add bcg729.
Change-Id: I5ee7a2a9027f67e003744f3e076429ef2eda0a4b
Reviewed-on: https://code.wireshark.org/review/22908
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=25b9d31526beb75fe8f96bd2db2a09…
commit 25b9d31526beb75fe8f96bd2db2a09affef17204
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Aug 1 16:36:01 2017 -0700
Add SpanDSP to the set of libraries to download and install.
Change-Id: I23c22aff1f4fadeaac120e01e5b222d2da5cb1f2
Reviewed-on: https://code.wireshark.org/review/22906
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7c5ff646dc6328233da09d9fc9b68c…
commit 7c5ff646dc6328233da09d9fc9b68c25eec8a9ba
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jul 31 10:09:32 2017 -0700
Look for Cygwin in one more place.
Add "HKLM\SOFTWARE\WOW6432Node\Cygwin\setup" to the Cygwin search paths.
Change-Id: I302ecea67dd580449b450136c027ac37adf586d3
Reviewed-on: https://code.wireshark.org/review/22893
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=f24c1564bd9e71176bbff781e0e38c…
commit f24c1564bd9e71176bbff781e0e38cd0e29e9fa3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Aug 1 21:30:19 2017 +0200
Update USBPcap to 1.2.0.2
Change-Id: I0f318cdd3644ef4eb2195bed3d0bd561dde7f6dc
Reviewed-on: https://code.wireshark.org/review/22903
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fb052a637fe41ab87af98753593a8c…
commit fb052a637fe41ab87af98753593a8cd5a07735de
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Tue Jul 18 00:22:25 2017 +0100
Use g_build_filename() instead, fix indentation
Change-Id: I459208eed4a76b104bc28aa44ab05374e57043de
Reviewed-on: https://code.wireshark.org/review/22873
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=eeab5f48fe6da19f1519149a5ea57b…
commit eeab5f48fe6da19f1519149a5ea57b1ab7466e0d
Author: Hassan Sultan <sultah(a)amazon.com>
Date: Thu Jul 27 11:43:48 2017 -0700
SMB2: Move the blob offset & length fields
from under the security blob since they're physically placed before the blob.
Also renamed them to clarify their link to the blob
Change-Id: I896ce8eea3f5f41c1887a685247e7fa168cc9061
Reviewed-on: https://code.wireshark.org/review/22823
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=81b8d014567c7957da86e820c2b61f…
commit 81b8d014567c7957da86e820c2b61fe003aca3b3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Aug 1 19:57:47 2017 +0200
CMS, ESS: regenerate ASN.1 dissectors after g49e920bc21
Change-Id: I518e94cba90a4d2ad9f5f3e787279de358adabc5
Reviewed-on: https://code.wireshark.org/review/22901
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c79382e69b37b3ff854ab88999a3dc…
commit c79382e69b37b3ff854ab88999a3dc6df0baf8f5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Aug 1 19:52:51 2017 +0200
SNMP: regenerate ASN.1 dissector after g7466880e8a
Change-Id: Ie6f93ed3c5c98d7a5df8d6fdc678551d53feee71
Reviewed-on: https://code.wireshark.org/review/22900
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6893f7a5c7d223e9e3ef9966ce9757…
commit 6893f7a5c7d223e9e3ef9966ce9757588196c66a
Author: Marius Paliga <marius.paliga(a)gmail.com>
Date: Tue Aug 1 10:52:54 2017 +0200
E212: Check MNC length before trying 3-digits length
Bug: 13935
Change-Id: Ib3f86c7a70d065cf7d5659a2fbc9c34047efcb56
Reviewed-on: https://code.wireshark.org/review/22894
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4e9085696b0a0354b4ece9aa322309…
commit 4e9085696b0a0354b4ece9aa32230952608b3fa4
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Jul 31 10:43:58 2017 +0200
CMake: do not check stack size when compiling with ASan or UBSan
Instrumentation code increases the stack usage. Let's deactivate the
check when compiling with ASan or UBSan as the objective here is not
to check the stack consumption and its usage is out of our control.
Change-Id: I9d6e269a0d404dc1833183a070fdbbb7fb0446e0
Reviewed-on: https://code.wireshark.org/review/22888
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6cff9c8da6a8190258f3b392312297…
commit 6cff9c8da6a8190258f3b392312297ca2ac11e33
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Jul 25 22:12:52 2017 +0200
Netflow: Reassemble flows spanning multiple PDUs
Flows records can span multiple PDUs (e.g when using TCP).
This commit adds the preference to reassemble flows.
Bug: 13915
Change-Id: I10eb0d9ee5ff5cc06ff52d0d0c8c468140e0273b
Reviewed-on: https://code.wireshark.org/review/22792
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=38b7660eeddbda98d406dd130f2a3b…
commit 38b7660eeddbda98d406dd130f2a3bda08ca1977
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Jul 28 19:23:15 2017 +0200
gprs-llc: Don't attempt to decode Dummy UI Command
As explained by 3GPP TS 44.064 Section 6.4.2.2 there are Dummy UI
Commands which are never generated by a LLC entity, but nevertheless
received by a LLC entity. They are generated by the underlying
network-side RLC/MAC entity a as a means to artificially delay the
release of a downlink TBF.
We introduce a new "llcgprs.dummy_ui" boolean field on which the user
can match to filter our such messages, if needed.
Change-Id: Ie8fcb42cbd66a7e5b77849f0bc5a3630d0d54a9c
Reviewed-on: https://code.wireshark.org/review/22862
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c9cb01adbb24c91b665c6c219573f8…
commit c9cb01adbb24c91b665c6c219573f8ee96e1986c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Jul 31 08:36:46 2017 +0200
IrCOMM: check string length before appending it to item
Bug: 13929
Change-Id: I33f3fec77014949fcc15df72c42ffcb25158562f
Reviewed-on: https://code.wireshark.org/review/22887
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4af5e1a5c3fef04bd6e8131cbfad66…
commit 4af5e1a5c3fef04bd6e8131cbfad6617238d5f91
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jul 30 18:27:35 2017 -0700
Don't force people to do a Web search to find the header layout.
Change-Id: Ie71db56327e1cb17b46da0d0675e3485bebd2439
Reviewed-on: https://code.wireshark.org/review/22885
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4ad98cc3f53073d5d726619f6bb03e…
commit 4ad98cc3f53073d5d726619f6bb03e0679ff9bdc
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jul 30 18:06:14 2017 -0700
Use proto_tree_add_item_ret_uint().
Change-Id: I006bb0f2cf7e215d24c5eaa6f208cdd6d563d36a
Reviewed-on: https://code.wireshark.org/review/22883
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=fe29cb3bb0b291ef354996b2e32fa3…
commit fe29cb3bb0b291ef354996b2e32fa3bdb724b152
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jul 30 17:57:24 2017 -0700
Add expert infos for too-long or too-short TLVs.
Also, process the packet to the end, even if there are fewer than 3
bytes left; we'll throw an exception if we can't fetch the type and
length, which will report the packet as malformed (which it is).
Change-Id: Iddd5be4be635553ac77bdb7fe232c2edb0e4404c
Reviewed-on: https://code.wireshark.org/review/22882
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=c254f3a13bc21868dba0163584a89d…
commit c254f3a13bc21868dba0163584a89d31483ee647
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 30 15:52:38 2017 +0200
GSMTAP: Treat PDTCH identical to PACCH (hand into packet-gsm-rlcmac.c)
The RLC/MAC dissector decodes both signalling (PACCH) and data (PDTCH)
RLC/MAC blocks, so let's make sure we dispatch both logical channels
into that dissector.
Change-Id: Ia26a1ba74468a49da071185cc5ee876ade907207
Reviewed-on: https://code.wireshark.org/review/22861
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=990192872d30120e0e54cb6da7b150…
commit 990192872d30120e0e54cb6da7b150b7b883528b
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 30 15:49:21 2017 +0200
GSMTAP: Proper name for PDTCH (not PDCH)
PDCH is the physical channel name, while PDTCH is one of the logical
channels (goether with PTCCH and PACCH) on the PDTCH. Let's call it
by its proper name, rather than keeping the misnomer.
Change-Id: I724fcfba595c9c861b64a30d5510468ec007424c
Reviewed-on: https://code.wireshark.org/review/22860
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=64b5a38bd9ac83bfc36062eb0c4f7f…
commit 64b5a38bd9ac83bfc36062eb0c4f7f384930176c
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Jul 30 23:51:07 2017 +0100
dns: add missing break
Change-Id: Iec47e262beb9600fc6596242c4ce0d56162be74f
Reviewed-on: https://code.wireshark.org/review/22881
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=74210f07fd86b03bed5ca9db57ec46…
commit 74210f07fd86b03bed5ca9db57ec46e63ac1185b
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jul 30 14:50:23 2017 -0700
Make the protocol column read-only, too.
The original code made all columns read-only; making only the info
column read-only makes the packet summary look weird, with the contained
protocol shown but the info from MSDP shown.
Change-Id: Iaa8afcb98a26a94230d5f344261f202ea658d077
Reviewed-on: https://code.wireshark.org/review/22878
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7e03e6b4eae2cc5871dda97462d1d4…
commit 7e03e6b4eae2cc5871dda97462d1d43ec4b975b5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jul 30 14:32:06 2017 -0700
Do more checks for extra data at the end of a TLV.
Change-Id: I013b21184f8e539d194b6d7ad880e50674958f32
Reviewed-on: https://code.wireshark.org/review/22874
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=33b95883aa4ef7391c05e563243992…
commit 33b95883aa4ef7391c05e563243992d35846a633
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Jul 30 12:01:07 2017 -0700
Clean up MSDP dissection.
It's now an RFC; mention the RFC number.
There are no message types in MSDP; the message consists solely of a
sequence of TLVs. Don't speak of TLV types as message types.
When dissecting a TLV, don't go past the end of the TLV. (We should add
a bunch of expert infos for length errors.)
Note that the Notification TLV was in an I-D but isn't in the RFC.
Don't use tvb_new_subset_length_caplen() - tvb_new_subset_length()
suffices; let *it* check for the captured length.
Clean up dissection of the Notification TLV.
Bug: 13933
Change-Id: Ia39b98f061957085c9f15fe6b31cd9c18058df35
Reviewed-on: https://code.wireshark.org/review/22868
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6f12bf215fb6cd86a0105c87c72076…
commit 6f12bf215fb6cd86a0105c87c72076840ca7f5b6
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jul 30 11:44:11 2017 -0400
Fix copy/pasteo so Qt Model Source is displayed properly in Visual Studio
Change-Id: I81dbc6947f0d878d2c214541cf0d540444ea1592
Reviewed-on: https://code.wireshark.org/review/22867
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a1ce51dcb0b105765a0245a9c48d96…
commit a1ce51dcb0b105765a0245a9c48d96ff1583b73e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Jul 30 12:15:02 2017 +0200
Indicate G.729 playback in the release notes
Change-Id: Iebf5419bad38b706c8dc0adb91f7c1cc1d36f3b5
Reviewed-on: https://code.wireshark.org/review/22858
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5d3d9656451ae86fd1a20b19a3ea21…
commit 5d3d9656451ae86fd1a20b19a3ea21c0931d24c5
Author: Arjen Zonneveld <arjen(a)bz2.nl>
Date: Thu Jul 27 16:03:02 2017 +0200
DNS dissector support for draft-bellis-dnsop-xpf
Add support for draft-bellis-dnsop-xpf to the DNS dissector:
- Parse the XPF additional RR (currently using a temp value of 65422)
Bug: 13928
Change-Id: I2d4fa23a8d3828db483bc41fafe6cbd8885514dc
Reviewed-on: https://code.wireshark.org/review/22803
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3e54cabf8193e6a8cd607b1671defb…
commit 3e54cabf8193e6a8cd607b1671defb8b6800b53d
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Jul 26 23:23:12 2017 +0200
Add G.729 decoding based on bcg729 library
Bug: 13635
Change-Id: Ic22a0719a59da13e51425aeb747e88caca0d6512
Reviewed-on: https://code.wireshark.org/review/22808
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=32b446d5a8f146565b81324d1a18bc…
commit 32b446d5a8f146565b81324d1a18bcb053e07c5f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Jul 24 11:59:50 2017 +0000
Define Q_NULLPTR as NULL if not already defined
it is not supported with Qt 4.x
Change-Id: Ie98d5e03d471869e08f5354a509c3317c7c780d7
Reviewed-on: https://code.wireshark.org/review/22831
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=28c874da179a520b1cb5113eb33e2e…
commit 28c874da179a520b1cb5113eb33e2e8b3cb8f48d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jul 29 20:26:06 2017 -0400
Expand Merge file dialog on Windows
Resize so all options can be seen
Bug: 13924
Change-Id: I1e347e83432305cc30f54f61efdb6e4c92e98d5a
Reviewed-on: https://code.wireshark.org/review/22850
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ff1bdfa0bcdb24326d0f12f41e256a…
commit ff1bdfa0bcdb24326d0f12f41e256a57b2a03d36
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jul 29 18:57:01 2017 -0400
Verify IP checksum even if in ICMP error packet
Bug: 10579
Change-Id: I18cac02f81465598451e0cf8f6729a26faf8c176
Reviewed-on: https://code.wireshark.org/review/22849
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e3b46bc48a6808d52b492a43e96ded…
commit e3b46bc48a6808d52b492a43e96ded6eb31114c3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Jul 29 18:47:15 2017 -0400
Fix IP Security option dissection
"offset" no longer needed (since using dissector table for options),
and since it should always be 0, just remove it.
Change-Id: Icc2802b76bc99a17d60d1deff75e1dc65761e8ed
Reviewed-on: https://code.wireshark.org/review/22848
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c50945989daa47802e30851b543ab5…
commit c50945989daa47802e30851b543ab5c69005a343
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Sun Jul 30 00:44:14 2017 +0200
DNS: Apply LOC record angle cap
The LOC records LATITUDE and LONGITUDE angle values may become too
large. Find these and stop conversion into invalid values.
Bug: 13914
Change-Id: Ia01ac1ecf5080350454f06536c9be1cf758d6f3c
Reviewed-on: https://code.wireshark.org/review/22847
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=76762d69b55065af69df075ca8bd34…
commit 76762d69b55065af69df075ca8bd3425b5b3ca84
Author: Ike Gilbert <ike(a)imgilbert.com>
Date: Fri Jul 28 17:23:48 2017 +0200
Windows: fix generation with CMake 3.9.0
By using CMake FindPerl.cmake module, CYGWIN_INSTALL_PATH variable
gets overwritten, bypassing our modified FindCygwin.cmake.
Let's package our own version FindPerl.cmake to avoid this.
Bug: 13922
Change-Id: If68e96ba312c2c6fa417721e7aec2ae6e5179a81
Reviewed-on: https://code.wireshark.org/review/22834
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f461a3a743750421ec377357687f65…
commit f461a3a743750421ec377357687f65c2c007a63a
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Sat Jul 29 13:12:19 2017 +0200
DNS: Fix APL record IPv4 address presentation
When getting the (partial) IPv4 address make sure to pass the full
32 bits of the address when adding the proto tree item.
Bug: 13923
Change-Id: I5b849705e723efd1269a64ee28b8d93724ab769a
Reviewed-on: https://code.wireshark.org/review/22838
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=168065dad763121f9f9630cac9aed1…
commit 168065dad763121f9f9630cac9aed184098d53a4
Author: Arjen Zonneveld <arjen(a)bz2.nl>
Date: Thu Jul 27 14:49:52 2017 +0200
Add initial RFC2780 IP Version lookup support
Add support for https://www.iana.org/assignments/version-numbers/version-numbers.xhtml
IP Version lookups.
Change-Id: I58a330ab9acba17356344df3ffeb94cc1b2b1443
Reviewed-on: https://code.wireshark.org/review/22821
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b16d487cbc70a441d26a1052b22d1b…
commit b16d487cbc70a441d26a1052b22d1bb0132b1cbc
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jul 28 17:59:52 2017 +0200
Modbus: do not trigger an exception before saving pkt_info structure
Otherwise on second pass pkt_info is null, leading to a segmentation fault
Bug: 13925
Change-Id: I61cfbee894506fb6c4205c9a2ad19e6973821f23
Reviewed-on: https://code.wireshark.org/review/22833
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=621ff8e6166f448d807ebabed58281…
commit 621ff8e6166f448d807ebabed582810adc42cd57
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Fri Jul 28 21:01:48 2017 +0200
MKA: Track offset correctly in Dist. SAK dissection
When handling a Distributed SAK parameter set with long SAK tracking
the offset was done incorrectly. Fix proposed by Rich Dubrawski.
Also remove the mask from XPN suspension time, it has none.
Bug: 13927
Change-Id: Iba1018632c719a86eaa24a304e1743210b3b3a1c
Reviewed-on: https://code.wireshark.org/review/22836
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66fff5df49520ac6e43f24aba3308f…
commit 66fff5df49520ac6e43f24aba3308f1c3e0ad205
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Thu Jul 27 23:10:42 2017 +0200
Qt: Add preference for show file load time in the status bar
This will leave more room for messages on smaller screens. Set the
default OFF because this is probably only useful for developers.
Group Status Bar settings in the Layout frame.
Change-Id: Iea9a55b6c088aac10ee7680b1e8a882ed00c73be
Reviewed-on: https://code.wireshark.org/review/22824
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=04748779e4d5c2aff7b59adba7034b…
commit 04748779e4d5c2aff7b59adba7034bc6cf56d254
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Fri Jul 28 15:35:53 2017 +0200
RTPS: Added Secure DDS PID parameter + small fix for endianness
Change-Id: I8d9c53cee9c7eff0f46c61c63bc3a46859ad7577
Reviewed-on: https://code.wireshark.org/review/22832
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c348f19786fddc4464cef4b507cce1…
commit c348f19786fddc4464cef4b507cce18173ad8dbb
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jul 28 09:15:36 2017 +0200
uma: align indent of hf
Change-Id: I0234252e112cbb0e7e30a5b9b76ddb74a5754a1c
Reviewed-on: https://code.wireshark.org/review/22829
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5db3a263c3fe21ccea6af4d42b2a34…
commit 5db3a263c3fe21ccea6af4d42b2a34d421ed76a7
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jul 28 06:59:25 2017 +0000
Revert "dis: Dead reckoning others Parameters display in wrong location"
This reverts commit ad0a3834a12aa038bcbf157304a84e6fd1f6f004.
Change-Id: I3a4ef0e3501e83a858f0a98f0c75e758ab245bba
Reviewed-on: https://code.wireshark.org/review/22828
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c23a42e6ae287e7c4e683cae245ceb…
commit c23a42e6ae287e7c4e683cae245cebdd0fcf7e96
Author: Julien Staub <atsju2(a)yahoo.fr>
Date: Thu Jul 27 13:14:06 2017 +0200
ZigBee Green Power : Update according to latest spec
MS extension becomes application information, remove unneeded define, move packet data
copy, warning instead error when no outgoing frame counter
Bug: 13919
Change-Id: If2f390a07df362487d18307a334d3b402ca51793
Reviewed-on: https://code.wireshark.org/review/22802
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ad0a3834a12aa038bcbf157304a84e…
commit ad0a3834a12aa038bcbf157304a84e6fd1f6f004
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 15:52:55 2017 +0200
dis: Dead reckoning others Parameters display in wrong location
Ping-Bug: 13917
Change-Id: I362c14fefcc62b8d19789a13d319fba323836846
Reviewed-on: https://code.wireshark.org/review/22818
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1c8ec368f03e78978cb13a6bbf6a41…
commit 1c8ec368f03e78978cb13a6bbf6a413a264141cc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 16:12:28 2017 +0200
dis: it is more logic sub_tree2 is the subtree of sub_tree
Ping-Bug: 13917
Change-Id: Ic0b6408b9e0c2a21187b5fe01b8ebfd7493ba7c3
Reviewed-on: https://code.wireshark.org/review/22820
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b8a33b25ac92d0ce0eb21d09dd3324…
commit b8a33b25ac92d0ce0eb21d09dd3324f12eced7ef
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 15:40:57 2017 +0200
metamako: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ibd3f06969a6a39533090134aeaa352d13f69231a
Reviewed-on: https://code.wireshark.org/review/22817
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=13bd996e8f41fefeb0dfe6a71083e4…
commit 13bd996e8f41fefeb0dfe6a71083e44b8ab5eaaf
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Wed Jul 26 18:21:00 2017 +0200
RTPS: Fixed Secure DDS minor details
Change-Id: I896764009887fedddbd41183f9b0d292119939d1
Reviewed-on: https://code.wireshark.org/review/22804
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=cf0870ad2102dd632a12f6093184f3…
commit cf0870ad2102dd632a12f6093184f3faae9f6712
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Jul 27 16:42:25 2017 -0700
Qt: Set AA_EnableHighDpiScaling at startup.
Set Qt::AA_EnableHighDpiScaling before creating wsApp so that various UI
elements are scaled properly on Windows.
Change-Id: Iee4ff2d97b0834756c805fb3812d556ad3480436
Ping-Bug: 13877
Reviewed-on: https://code.wireshark.org/review/22826
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a4788324cb8b8674062659310fe483…
commit a4788324cb8b8674062659310fe483543f5450e5
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jul 27 15:59:04 2017 +0200
dis: proto_tree_add_bitmask return a item (and not a tree)
(item and tree is the same but avoid mistake)
Ping-Bug: 13917
Change-Id: Ica5cc1b62aa8d359aea19a8292bfcd2cc5c4ae9b
Reviewed-on: https://code.wireshark.org/review/22819
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=82e2ad37a05d4f6ec125ffadbd0029…
commit 82e2ad37a05d4f6ec125ffadbd00295283b355a7
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Jul 24 17:47:18 2017 +0200
cmake: add a group target for all extcaps.
Change-Id: Ic97a96261056fd639c968eb29026d67636bad741
Reviewed-on: https://code.wireshark.org/review/22777
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4aae9331bc735411fe931a49c6d7bd…
commit 4aae9331bc735411fe931a49c6d7bdbcfa7a972f
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Jul 26 23:18:07 2017 +0200
Qt: Add preference for show selected packet number
The information about the selected packet number is available from
the Number column and from the Frame entry in the Packet Details
so make the entry in the status bar optional.
Also remove duplicate "Packet:" entry, add the UTF8_MIDDLE_DOT
separator and rename the prefix to "Selected Packet:".
Bug: 13902
Change-Id: I0e7ba884bdcbdc87a5738223ef92f52e4ac195e5
Reviewed-on: https://code.wireshark.org/review/22807
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=963707ab3c7ba57e52c28f0dd396d9…
commit 963707ab3c7ba57e52c28f0dd396d97b37446063
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Wed Jul 26 21:48:44 2017 +0200
extcap: add command line debug function to extcap-base.
This function is helpful to debug the interaction between the
calling UI and the extcap itself.
All extcaps have been changed accordingly.
Change-Id: I358caf4c50797501672bf77fdd91f7276897078c
Reviewed-on: https://code.wireshark.org/review/22806
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f86f54eb9070effb6216861749523d…
commit f86f54eb9070effb6216861749523d3a32932d47
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Jul 26 10:10:09 2017 -0700
Qt: SimpleDialog fixes and updates.
Add WiresharkApplication::mainWindow and use it to move the C
simple_dialog routines to simple_dialog.cpp.
In SimpleDialog, make sure our checkbox is initialized. Don't store our
parent widget (which might go away) in a static variable, just use
wsApp->mainWindow(). Make sure we use check boxes only in Qt 5.2 or
later.
Bug: 13275
Change-Id: I72a9715c59f2efd50f722197f416179e87bb6a8b
Reviewed-on: https://code.wireshark.org/review/22805
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ea233921b46b3eeda51865bb530691…
commit ea233921b46b3eeda51865bb5306919b16202872
Author: Marius Paliga <marius.paliga(a)gmail.com>
Date: Thu Jul 27 10:14:50 2017 +0200
PMIPv6: Fix of valid length of GRE Key Option
Change-Id: Ie212874a9eb9b7f9ad0dc502611d135210c9f259
Reviewed-on: https://code.wireshark.org/review/22810
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=76a3a6797ceb93535a06ca4d17b3a4…
commit 76a3a6797ceb93535a06ca4d17b3a454f5728cca
Author: Christoph Schlosser <christoph(a)schlosser.xyz>
Date: Thu Jul 27 13:06:29 2017 +0200
EPL: Fix Multiparamwrite response text
The text for the MultiParamWrite response was the same as for the
MultiParamRead.
Change-Id: I285f4f33877ac4bb1e48f36704ecb22ad7be1de4
Reviewed-on: https://code.wireshark.org/review/22811
Reviewed-by: Christoph Schlosser <christoph(a)schlosser.xyz>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c3a91e51d06f4ad81969fcbde4bcac…
commit c3a91e51d06f4ad81969fcbde4bcacead321f357
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Jul 26 06:50:17 2017 +0000
dis: Appearance Record displayed in wrong location
Bug: 13917
Change-Id: I26211dfcb15fe5e4ffc69ae297c64e380cd7b128
Reviewed-on: https://code.wireshark.org/review/22799
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fbc4d83ae7b844aa0ea6ec60af4f0a…
commit fbc4d83ae7b844aa0ea6ec60af4f0a238110858a
Author: KasperDeng <kasper.deng(a)ericsson.com>
Date: Wed Jul 26 16:50:25 2017 +0800
update diameter dictionary for t6a/t6b/s6t
Change-Id: I795efa89c59d2ba84398fc3e42ecc917405ca236
Reviewed-on: https://code.wireshark.org/review/22800
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=02e80019f2dc8f01e51d8bdc62a1ca…
commit 02e80019f2dc8f01e51d8bdc62a1cabff69fd51e
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Jul 25 16:47:16 2017 +0200
Qt: Create models directory
Following the move for widgets and utils directory, moving models
and delegates to the utils directory. Guidelines for this directory are:
- Implementation of a model
- Implementation of a delegate
- Utility class for data storage used by a model
Note: additionally all includes affected by this move have been changed
to absolute path includes, instead of relative ones.
Change-Id: I3bb868af7d3570437682b722a0cd46c906628570
Reviewed-on: https://code.wireshark.org/review/22790
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea998190cfe5a051224490172cfaed…
commit ea998190cfe5a051224490172cfaedc69b777ff6
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Wed Jul 26 12:28:50 2017 +0200
Qt: Fix Makefile.am for utils dir change
Fix Makefile.am
Change-Id: I31cdbc2af0659b247d22af7438300c44acfff63e
Reviewed-on: https://code.wireshark.org/review/22801
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ddfc1d37ccb5e2a6aeef5cce47479d…
commit ddfc1d37ccb5e2a6aeef5cce47479ddc36684f33
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Jul 25 16:15:18 2017 +0200
Qt: Move utils to separate utils directory
Following the move for widgets directory, moving utils
to the utils directory. Guidelines for this directory are:
- Generic use but not a widget
- Utility functionality used by many classes
Note: additionally all includes affected by this move have been changed
to absolute path includes, instead of relative ones.
Change-Id: I019ae4b6e6f6d06a5745a63ed195edbd36fb936b
Reviewed-on: https://code.wireshark.org/review/22602
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=95930c2d1fa356d5301b7c5e53b200…
commit 95930c2d1fa356d5301b7c5e53b20035876bb436
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jul 23 15:19:24 2017 -0400
Add current packet to the status bar.
For users with lots of columns, they may loose track of the current frame/packet.
Bug: 13902
Change-Id: I4d937dc437e254a09d938733aef5f5678ede1095
Reviewed-on: https://code.wireshark.org/review/22772
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=07d8fad852babaf9d1b02e7f13eb18…
commit 07d8fad852babaf9d1b02e7f13eb188f34ff58f5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Jul 25 19:07:04 2017 -0400
WirelessTimeline: move signals out of setPacketList().
Start to remove the dependency on PacketList by moving the signals
out of setPacketList and into MainWindow.
Change-Id: Ibbe5a5619e06809eb71aee5145c4b0f7d54382a2
Reviewed-on: https://code.wireshark.org/review/22798
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b376aa05eaa47bf679691a5031b002…
commit b376aa05eaa47bf679691a5031b00255712807f4
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Tue Jul 25 21:49:04 2017 +0200
GPRSCDR: decoding of RATType
Change-Id: I2524bc008ad35e39890c6b846928f1183f7f9627
Reviewed-on: https://code.wireshark.org/review/22791
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f50d9fe1d6ebf7ac8ecf615e0e7947…
commit f50d9fe1d6ebf7ac8ecf615e0e79476bc824f4c0
Author: Darien Spencer <cusneud(a)mail.com>
Date: Tue Jul 25 23:28:56 2017 +0300
Update heuristic dissectors documentation
Remove grep output of explict count of heuristic protocols because
it changes too often to bother updating.
Change-Id: I69b0dfbae32f9eb9ffef6c3200238819ddf522e6
Reviewed-on: https://code.wireshark.org/review/22793
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=efbefe2f4c46bf50c6df7e06a06476…
commit efbefe2f4c46bf50c6df7e06a06476e3f91e1ba7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jul 25 15:42:46 2017 -0700
Make hf_mysql_request cover the *entire* request.
The request doesn't correspond to the request command coe, it
corresponds to the entire request; create it as an item covering the
rest of the packet, and finish it up by setting the length appropriately.
Change-Id: Ib0c044c0c878f1cb2fa0d11deb04b4d31a8a825f
Reviewed-on: https://code.wireshark.org/review/22796
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=9c80c4d5a246b8f95dfbc28fbf14ca…
commit 9c80c4d5a246b8f95dfbc28fbf14ca899531630f
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Jul 25 13:31:49 2017 -0700
CMake: Don't pass /WX to rc.exe
Rc.exe doesn't have a /WX flag. Passing it /WX apparently results in
setting the /W flag, which warns about invalid code pages, and the /X
flag, which ignores %INCLUDE%. The latter is necessary in our case for
locating winver.h.
Change-Id: I6d757a547fedfa49d078a7bb5f15518c69760f72
Reviewed-on: https://code.wireshark.org/review/22794
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a62c6d56b13390d216a8b6096a9c9e…
commit a62c6d56b13390d216a8b6096a9c9e809b3c4e93
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Jul 25 15:18:12 2017 +0200
cmake: remove duplicate libraries from sshdump and ciscodump.
Change-Id: I35ce9e10921a5cbf97f2cd00036b1b6b3c87c03f
Reviewed-on: https://code.wireshark.org/review/22788
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=615685e852d7aa9b48b117b0335a33…
commit 615685e852d7aa9b48b117b0335a337d542f847f
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Jul 25 08:31:05 2017 +0200
VNC: Get Bytes before adding raw values to tree
Make sure to have bytes before adding raw values to tree
Bug: 13910
Change-Id: I9c6fe679df12e0358df80caf01268acb75ee424c
Reviewed-on: https://code.wireshark.org/review/22782
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=7fadc161724cb5d3e1d3f8aa449c80…
commit 7fadc161724cb5d3e1d3f8aa449c8078e5ffa9e1
Author: Christoph Schlosser <christoph(a)schlosser.xyz>
Date: Tue Jul 25 08:11:45 2017 +0200
EPL: Add padding to size calculation for last frame
The padding was not part of the size calculation of the last subpayload in a
multiple read/write by index.
Change-Id: Ibbd3ded345352ea1ceaea7b871fc2d1a0e1a6832
Reviewed-on: https://code.wireshark.org/review/22781
Reviewed-by: Christoph Schlosser <christoph(a)schlosser.xyz>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c6ed05ec73e1b1e22ea890fc95ec5e…
commit c6ed05ec73e1b1e22ea890fc95ec5e067726cbe8
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jul 24 10:55:56 2017 -0700
Qt: Make SimpleDialog a plain, non-QObject class.
Don't assume that the application is initialized when we create a
SimpleDialog.
Bug: 13275
Change-Id: Ieeb52430500570db88463069833855c3789f686b
Reviewed-on: https://code.wireshark.org/review/22778
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=17f72a0b2273e8c45296711d245499…
commit 17f72a0b2273e8c45296711d2454997e74e2734c
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Jul 23 23:11:42 2017 +0200
randpkt: choose a random type if the empty string has been selected as type.
Fixes a bug when calling randpktdump without the dialog. Reproducer:
Open wireshark
Double click on randpktdump
Stop the capture
No packets have been generated.
Change-Id: I43d1d3c02afbb44f88620a696a7d25aa4e45889a
Reviewed-on: https://code.wireshark.org/review/22775
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1e584b8a13cd6514f2ec5d117d055f…
commit 1e584b8a13cd6514f2ec5d117d055f3270c944d5
Author: Huang Qiangxiong <qiangxiong.huang(a)qq.com>
Date: Mon Jul 24 15:47:53 2017 +0000
HTTP2: Fix an access invalid memory address error.
The tree may be NULL, so tree->parent may cause access invalid memory address
error
which will report 'Dissector bug ... STATUS_ACCESS_VIOLATION' in info column.
Change-Id: I37d4aca2287e77a046e553221a6a824de60aae9c
Reviewed-on: https://code.wireshark.org/review/22776
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=be502d221a416ad271e4d13231cd79…
commit be502d221a416ad271e4d13231cd796f8da32ca4
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 24 11:16:48 2017 -0700
There's no wka.tmpl file any more, it's just wka.
Change-Id: Ia44a02c92995a47357a3fded7131199117ad6425
Reviewed-on: https://code.wireshark.org/review/22779
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=690cb8ff65f3336cb8e72a55944f97…
commit 690cb8ff65f3336cb8e72a55944f974d0fd40f05
Author: Christoph Schlosser <christoph(a)schlosser.xyz>
Date: Mon Jul 24 13:45:10 2017 +0200
EPL: Add Modular device flag
Add detection for the modular device flag in POWERLINK.
Change-Id: I3e21eec383f1bdf2fa491d415631cda146a0fdef
Reviewed-on: https://code.wireshark.org/review/22774
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7a4c9d267bd245f19796a5fea3b21b…
commit 7a4c9d267bd245f19796a5fea3b21b18ed57f870
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jul 21 00:07:31 2017 +0200
print: use assert before dereference (CID 1412973).
Change-Id: I82602ceb735a055602a18c2c52e0669c4efd7773
Reviewed-on: https://code.wireshark.org/review/22748
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=877caf478bae1e7f64084a8f2a7d6f…
commit 877caf478bae1e7f64084a8f2a7d6fe61f63b5e9
Author: Joakim Karlsson <oakimk(a)gmail.com>
Date: Sun Jul 23 16:56:39 2017 +0200
GPRSCDR: decoding of ULI in GGSN/SGW/PGW CDRs
Change-Id: Id87920c5099553e51cfaa9ab0cb0c41cec6a127b
Reviewed-on: https://code.wireshark.org/review/22767
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8ee06279fff744a1d7f235df9b570e…
commit 8ee06279fff744a1d7f235df9b570e0c25a91b1f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Jul 23 19:42:59 2017 +0200
LTE RRC: upgrade dissector to v14.3.0
Change-Id: Ia64095a8a9bdd3b31589842809d8a5313b829f8e
Reviewed-on: https://code.wireshark.org/review/22770
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f2ffcdf3aa5cf3b02d674411270df0…
commit f2ffcdf3aa5cf3b02d674411270df072f3a1eded
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Jul 22 20:30:07 2017 +0200
Qt: Compile InterfaceToolbar with Qt4
The InterfaceToolbar does not currently work with Qt4 because usage
of some Qt 5.2 features, but this should at least make it compile.
Change-Id: Id610e04d6c266556bfb84da5399e57a6c1fe9938
Ping-Bug: 13909
Reviewed-on: https://code.wireshark.org/review/22761
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=68f295d6052d49200f9ad3e06909b1…
commit 68f295d6052d49200f9ad3e06909b1157e7a82be
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jul 21 00:16:35 2017 +0200
tshark: assert edt before calling print_packet (CID 1405107).
Change-Id: Iacde5514dc355cbb06fe45f5e342ddd45700999d
Reviewed-on: https://code.wireshark.org/review/22749
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=14d94e174a230e66d7d75c774435d7…
commit 14d94e174a230e66d7d75c774435d77f3d8aa22e
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Jul 20 02:32:40 2017 +0100
Put the well-known addresses into a separate file from OUIs
Having two distinct logical concepts (OUI and Well Known Address)
concatenated to a single "manuf" file is needlessly obfuscating
the WKA feature.
Have a distinct "wka" file instead and just skip the cat.
Change-Id: I46f53b0015a37331d65f8cfac7cbbd499dd0c5b8
Reviewed-on: https://code.wireshark.org/review/22742
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=88fbc26175d8f32b01fac69828b754…
commit 88fbc26175d8f32b01fac69828b7549a5ec53166
Author: Lars Christensen <larsch(a)belunktum.dk>
Date: Tue Jul 18 10:17:53 2017 +0200
Inhibit unhandled Ctrl key presses being redirected to the display filter
Pressing the display filter shortcut Ctrl-/ inserts a '/' into the
LineEdit. On Windows QKeyEvent::text() contains a
printable character when Ctrl is held down and are being redirected
in MainWindow::eventFilter(). This patch filters events that has the
CtrlModifier.
Change-Id: Iefed962b7a2cc944a39b09de9d84b4522a39ff13
Reviewed-on: https://code.wireshark.org/review/22697
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=daae7dbb1ff08b5f88953ddb77ef71…
commit daae7dbb1ff08b5f88953ddb77ef71454f3b1a3f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sun Jul 23 14:09:13 2017 +0200
RRC: upgrade dissector to v14.3.0
Change-Id: I3c15b26430e8159d10d5d7a52e3b5644fb76c7ae
Reviewed-on: https://code.wireshark.org/review/22765
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=40d158eee35c3d10858593587c6ddc…
commit 40d158eee35c3d10858593587c6ddc999b9b9329
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Jul 21 19:12:52 2017 -0400
Have UatFrame send out proper notifications.
UatFrame was originally written for filter expressions, so it still
had some "filter expression specific" functionality in it.
Move the "filter expression notifications" to the preferences dialog
and add support for proper notification if UAT affects fields or
dissection (like expert info UAT).
Change-Id: I84cd0c7923450692916bbc6c2cdce93a9830d722
Reviewed-on: https://code.wireshark.org/review/22758
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4107f6bca7b2bc58e6570501123f3d…
commit 4107f6bca7b2bc58e6570501123f3d500ec3905b
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Sat Jul 22 13:19:24 2017 +0200
HTTP2: Fix missing ifdef HAVE_NGHTTP2
media_type_dissector_table is only defined with HAVE_NGHTTP2
Change-Id: I489e04f3d3066f2edf5c656b158c38c3dae84fb6
Reviewed-on: https://code.wireshark.org/review/22760
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=04ba4bc070466c302b994968d527da…
commit 04ba4bc070466c302b994968d527da5dbe390287
Author: Simon Graham <simgrxp(a)gmail.com>
Date: Thu Jul 13 17:00:59 2017 -0400
Fix crash in UDT dissector when long NAK packet is dissected
Change is to limit the number of entries from the NAK message included in the
summary line (and add ellipsis if there are more than will fit).
In addition, add checks to make sure we dont read beyond the end of the
captured packet when parsing NAKs.
Change-Id: I60db4b62d86c05329eb7c79ae1927eeb1b7e11ba
Reviewed-on: https://code.wireshark.org/review/22733
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6dfdb0160c0ad6b7b71edb3c5f41c1…
commit 6dfdb0160c0ad6b7b71edb3c5f41c1e8e5868667
Author: Huang Qiangxiong <qiangxiong.huang(a)qq.com>
Date: Wed Jul 19 14:10:50 2017 +0000
HTTP2: Dissect reassembled http2.data.data according to content-type (as text/html,
png, application/grpc and etc) and some enhancement for displays.
Change Details:
1. Just like HTTP1.1, dissect reassembled http2.data.data according to content-type
header value (searching media_type dissector table).
With this feature, we can add new dissector that based HTTP2 (for example
application/grpc), or old text/html, image/png, image/jpeg dissectors.
2. Append stream id after frame type on info column, like: HEADERS[1], DATA[1],
HEADERS[3], DATA[3]
3. Append request :method and :path inforamtion to info column, like: HEADERS[1]: GET
/demo/1.jpg. (and also append :method and :path info to Stream Node in tree)
4. Append response status and reason-phrase to info column, like: HEADERS[1]: 200 OK
One HTTP2 package file's info column will look like:
10.10.10.123 23.13.190.101 Magic
10.10.10.123 23.13.190.101 SETTINGS[0]
10.10.10.123 23.13.190.101 WINDOW_UPDATE[0]
10.10.10.123 23.13.190.101 HEADERS[1]: GET /demo
23.13.190.101 10.10.10.123 SETTINGS[0]
23.13.190.101 10.10.10.123 SETTINGS[0]
10.10.10.123 23.13.190.101 SETTINGS[0]
23.13.190.101 10.10.10.123 HEADERS[1]: 200 OK
23.13.190.101 10.10.10.123 DATA[1], DATA[1], DATA[1], DATA[1] (text/html)
10.10.10.123 23.13.190.101 HEADERS[3]: GET /demo/tile-0.png
10.10.10.123 23.13.190.101 HEADERS[5]: GET /demo/tile-1.png
10.10.10.123 23.13.190.101 HEADERS[7]: GET /demo/tile-2.png
10.10.10.123 23.13.190.101 HEADERS[9]: GET /demo/tile-3.png
10.10.10.123 23.13.190.101 HEADERS[11]: GET /demo/tile-4.png
23.13.190.101 10.10.10.123 SETTINGS[0]
23.13.190.101 10.10.10.123 SETTINGS[0]
10.10.10.123 23.13.190.101 SETTINGS[0]
23.13.190.101 10.10.10.123 HEADERS[5]: 200 OK
23.13.190.101 10.10.10.123 DATA[5]
23.13.190.101 10.10.10.123 HEADERS[7]: 200 OK
23.13.190.101 10.10.10.123 DATA[5], DATA[5] (PNG), DATA[5]
23.13.190.101 10.10.10.123 HEADERS[11]: 200 OK
23.13.190.101 10.10.10.123 DATA[7], DATA[7] (PNG), DATA[11], DATA[11] (PNG)
23.13.190.101 10.10.10.123 HEADERS[3]: 200 OK
23.13.190.101 10.10.10.123 DATA[3], DATA[3] (PNG)
23.13.190.101 10.10.10.123 HEADERS[7]: 200 OK
23.13.190.101 10.10.10.123 DATA[9], DATA[9] (PNG)
Change-Id: I4452dadeeefc49806e3036a44d44b5f5186096b9
Reviewed-on: https://code.wireshark.org/review/22715
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=921723d07585b41c96b295e30a74df…
commit 921723d07585b41c96b295e30a74df43626224af
Author: Robert Sauter <sauter(a)locoslab.com>
Date: Wed Jul 12 11:31:26 2017 +0200
IEEE 802.15.4: dissector tables for Information Elements
Rationale: The IEs are a generic mechanism that allows higher level protocols to
transport additional data in the header and some IDs have already been assigned
to external organisations. Using dissector tables enable looser coupling.
Refactor existing internal IE dissectors to be called via the table as well
based on a suggestion by Michael Mann.
More consistent display and code for Header IEs and Payload IEs.
Change-Id: Ib9c225245fc8dd989200d6ff6aeae8ca5c0f792c
Reviewed-on: https://code.wireshark.org/review/22600
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8dd29939ef79acd5fdfdf90c08d53c…
commit 8dd29939ef79acd5fdfdf90c08d53c83706a24d3
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Jul 21 20:14:47 2017 -0700
c-ares isn't required.
Don't fail if it's not present.
Change-Id: I7183ce6e1f2af822ebeed219be0f2ca7dd0bab0f
Reviewed-on: https://code.wireshark.org/review/22759
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=28dce11948523f80d6eb76ef6a1d95…
commit 28dce11948523f80d6eb76ef6a1d95df78f9c870
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Fri Jul 21 11:03:04 2017 -0700
Qt RTP: Add the default device and adjust sample rates.
In the RTP player dialog, list the default audio device first, ensure
it's selected by default and ensure that the list items are unique.
According to
http://code.qt.io/cgit/qt/qtmultimedia.git/tree/src/plugins/windowsaudio/qw…
the default device on Windows uses the special WAVE_MAPPER id, which
appears to support various sample rates even when the underlying
hardware doesn't.
Ensuring the names are unique fixes an issue I'm seeing on a test
machine here.
When decoding, check to see if our sample rate is supported by our
output device and adjust accordingly.
Bug: 13906
Change-Id: Iddc0beb2459bfac42276ff29d227c2619b0a8d90
Reviewed-on: https://code.wireshark.org/review/22756
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=d22b54a00587d6a4a5227b93f0461a…
commit d22b54a00587d6a4a5227b93f0461ab4549ea94c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jul 21 13:25:17 2017 +0000
cql: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I74f4d33ad1805bd233190e7cb9ee1610ae628af5
Reviewed-on: https://code.wireshark.org/review/22755
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b8b9bbcbd3dc8e7bebd2f7c74996a8…
commit b8b9bbcbd3dc8e7bebd2f7c74996a80f7620d77e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Jul 21 03:43:11 2017 -0700
*Always* write out the trailing pcapng block total length in host byte order.
In the fast-path "no options" case for writing an Enhanced Packet Block,
just copy the block total length to the buffer, don't put it into the
buffer in little-endian byte order. If we're running on a big-endian
machine, and thus *should* be writing out multi-byte integral block
fields in big-endian byte order, that'll write out a corrupt pcapng
file.
Bug: 13802
Change-Id: I33958e3fc1d205ca6df3ef4057d92b461831c50e
Reviewed-on: https://code.wireshark.org/review/22753
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3e9b25623877afb9854b2f3cae84e4…
commit 3e9b25623877afb9854b2f3cae84e47ffb52c9a8
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Jul 21 00:22:47 2017 +0200
androiddump: check return value of localtime() before dereference (CID 1400829).
Change-Id: I03c851e56f5bd967a35c668bcbc4e98170251b2c
Reviewed-on: https://code.wireshark.org/review/22750
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=9ea364c389fc92bcd8efc800c9b8e8…
commit 9ea364c389fc92bcd8efc800c9b8e852958c169a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Jul 21 03:11:14 2017 -0700
Require at least c-ares 1.5.0 when configuring.
That way, if you have an older version, we fail at configure time, with
what should be a message indicating that your c-ares is too old, rather
than at compile time, with what might provoke users to ask "what am I
doing wrong?" or "what do I need to fix?" or "why is my compile
failing?" or....
Change-Id: I911574c4d90174b6bd074c5ef537557d47b199dc
Reviewed-on: https://code.wireshark.org/review/22752
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=725b7ef17598076911da9c68efbf8c…
commit 725b7ef17598076911da9c68efbf8c0efd593191
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Jul 21 12:05:45 2017 +0200
androiddump: add a cast to please MSVC x64
Change-Id: I43cf913d48afabd826f7d6f861876e1cb62e7e7a
Reviewed-on: https://code.wireshark.org/review/22751
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7799b1ceabb9baf4c88f0013b9b2bc…
commit 7799b1ceabb9baf4c88f0013b9b2bcd3e60b1750
Author: Russell Lowes <russelll(a)metamako.com>
Date: Wed Jul 19 13:18:06 2017 +1000
Add support for Metamako trailer extensions.
Update dissector heuristic to match.
Bug: 13898
Change-Id: I84445b3a6e6c903a51faae2757eb6002db835a31
Reviewed-on: https://code.wireshark.org/review/22711
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d238160a22ed3e7c9d2235002e3051…
commit d238160a22ed3e7c9d2235002e3051afe162e662
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Jul 20 19:03:45 2017 +0100
Require c-ares >= 1.5
Version 1.5 was released on 21-nov-2007. RHEL, Suse, etc supported versions
are all above c-ares v1.5.
We don't bother testing for it at build time for now, because it's
non-trivial
(times two build systems).
Change-Id: I9253256d8d905da0c75d80b2b0fa4527df2b1420
Reviewed-on: https://code.wireshark.org/review/22741
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9e419f62bde6c86bc7dd35c71e0a29…
commit 9e419f62bde6c86bc7dd35c71e0a29321f3cb3ea
Author: Simon Graham <simgrxp(a)gmail.com>
Date: Sat Dec 3 16:58:34 2016 -0500
Support heuristic sub-dissectors for UDT
Change-Id: Ief9d02dd3cf70dc37ad25061ce38bb1a570b2946
Reviewed-on: https://code.wireshark.org/review/22727
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ac0af07083727a958e468e6d6fca04…
commit ac0af07083727a958e468e6d6fca044c73de0a80
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Jul 20 11:36:59 2017 -0400
ENIP: Add support for CIP Security Information in ListIdentity
Add tfs_open_closed to general tfs collection (tfs.[ch])
Change-Id: I79b22b591128c33084489880842e19e9a0d80560
Reviewed-on: https://code.wireshark.org/review/22730
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=421085cc4c1834e6b27f3cb2432786…
commit 421085cc4c1834e6b27f3cb2432786aff657ab77
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Jul 7 13:42:25 2017 +0200
.gitignore: move ui/qt/gitignore to root gitignore
Change-Id: I303c6998b7b825ebb89aa1a81296b1ad69786ec1
Reviewed-on: https://code.wireshark.org/review/22538
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fe8508b8b359689c927bb062ee37f7…
commit fe8508b8b359689c927bb062ee37f79c52930b19
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Jul 20 14:53:52 2017 -0700
More precise error message.
"Missing newline after '}'" suggests either that the "}"
is the line
character in the file or that it's followed by a character other than a
newline. What it actually appears to mean is "you didn't put a blank
line between one author entry and the next author entry".
Change-Id: Ic0e4dd02f04680ab84fbfcf1183c911d049ee2d2
Reviewed-on: https://code.wireshark.org/review/22746
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=27c6b12626d6e7b8e4d7a11784c2c5…
commit 27c6b12626d6e7b8e4d7a11784c2c5e2bfb87fde
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jul 20 23:46:54 2017 +0200
AUTHORS: add newline after bracket.
Get rid of the error:
Missing newline after '}', found: Ben Stewart
<bst[AT]google.com> {
Change-Id: Ic8c83c23e5215032a9e06d4ad089be85f7b98b0d
Reviewed-on: https://code.wireshark.org/review/22744
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=420aab387f706610d17cb51b3574f0…
commit 420aab387f706610d17cb51b3574f03fd370719a
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Jul 20 23:37:16 2017 +0200
androiddump: use actual buffer length instead of pointer sizeof.
Change-Id: I3481c98377a31fbef2ef8ad931e2a8d66f507e58
CID: 1414110
CID: 1414058
Reviewed-on: https://code.wireshark.org/review/22743
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=55724db3db49e7ed5180305600733d…
commit 55724db3db49e7ed5180305600733d6a9253c65d
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Jul 20 03:39:09 2017 +0100
Remove dead code for address reverse-mapping
Removed get_ipxnet_addr(), get_ether_addr(). If this feature is desired at
a minimum it should use an efficent data structure (and no disk-based
lookups mid-dissection).
Change-Id: Ie72449c631f21f4a3d82ec435bb5e1d7892f122c
Reviewed-on: https://code.wireshark.org/review/22729
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=543c101d4b98c947b7bfc66cac6d49…
commit 543c101d4b98c947b7bfc66cac6d49d177ed4fc0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Jul 19 15:00:22 2017 +0200
DICOM: Add User Identify
See ftp://dicom.nema.org/MEDICAL/dicom/2016a/output/chtml/part07/sect_D.3.3.7.h…
Bug: 13875
Change-Id: If5b55ef45b1dd7115a2eaf4a3d1a02bc2b1a5b93
Reviewed-on: https://code.wireshark.org/review/22714
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3669a8cc8f64a1874a3d370abccfc6…
commit 3669a8cc8f64a1874a3d370abccfc6e815b46514
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Jul 20 11:03:18 2017 -0700
Give some references.
Change-Id: Iaa4912fa50ffde8d5408527f3b4b28a0d2a56cde
Reviewed-on: https://code.wireshark.org/review/22737
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ab0b3ecf867223d8aeeb9c405dfc72…
commit ab0b3ecf867223d8aeeb9c405dfc7204114b0dbe
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Jul 20 09:37:15 2017 -0700
CMake: Escape shell command quotes.
Escape shell command quotes so that what appears to be "unquoted_legacy"
behavior doesn't kick in.
Ping-Bug: 12305
Change-Id: I4763df2fbc58b80d6e4e3ec15f78c16fa1cf3853
Reviewed-on: https://code.wireshark.org/review/22732
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=9ab8133bf8959c80167f85ffb4c12c…
commit 9ab8133bf8959c80167f85ffb4c12c37f3b4c2ed
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Jul 20 09:36:27 2017 -0700
Update the release notes.
Change-Id: Ia6a5994b8728251a11a111f29f60455e8076dfb9
Reviewed-on: https://code.wireshark.org/review/22731
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=558fe23226b69665dd66ee15bed2f7…
commit 558fe23226b69665dd66ee15bed2f7492653aa09
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Jul 20 16:02:54 2017 +0200
[IP] Simplify paring of flags field by using
proto_tree_add_bitmask_with_flags().
Change-Id: If8e9f9956543f253f4f59d8204c9536f444dbcd5
Reviewed-on: https://code.wireshark.org/review/22728
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=990ac64516223f1ffa9728b01b47d0…
commit 990ac64516223f1ffa9728b01b47d08b7954de2c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Jul 19 13:47:03 2017 +0200
DICOM: Add display of Unknown item type
Ping-Bug: 13875
Change-Id: Ic1de11aa7307f13cf6ba53f61477091fd37bf2a2
Reviewed-on: https://code.wireshark.org/review/22713
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3e37292c382d8f48554af5a0aa10e3…
commit 3e37292c382d8f48554af5a0aa10e3ce2d16363f
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sun Jul 16 20:10:50 2017 +0100
Remove line numbers (locations) from .ts files
To make translation updates less noisy.
Change-Id: I3efee819ea10bb326862e0f818bfd3cd7eff48e3
Reviewed-on: https://code.wireshark.org/review/22654
Reviewed-by: João Valverde <j(a)v6e.pt>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f26778c9c6265fae59a35413d9a2d7…
commit f26778c9c6265fae59a35413d9a2d735190cff22
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Jul 20 09:24:42 2017 +0200
Add udpdump documentation to distribution
Bug: 13903
Change-Id: I7e7aadfbec3e66ebac892e20b5632afa9f7e5923
Reviewed-on: https://code.wireshark.org/review/22725
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5473d2582cbc8943ead50550ef7293…
commit 5473d2582cbc8943ead50550ef72936e0b99a945
Author: Simon Graham <simgrxp(a)gmail.com>
Date: Tue Jul 4 10:38:54 2017 -0400
Display relative sequence numbers when dissecting UDT.
Note that this is only done if sufficient bytes are captured from the
handshake packet to include the initial sequence number field.
Change-Id: Ie92ec2ccaa5021c07c8666d6fdc46613d24d0da1
Reviewed-on: https://code.wireshark.org/review/22573
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=79e801806aedbbb74f642fafd9f54c…
commit 79e801806aedbbb74f642fafd9f54c02e60677f5
Author: Owen Kirby <osk(a)exegin.com>
Date: Fri Jun 23 15:15:46 2017 -0700
ZigBee: Add touchlink commissioning dissectors.
Change-Id: I745fa77626dd242d9a6f1bd79c6ae52d507f844a
Reviewed-on: https://code.wireshark.org/review/22380
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=07f27d8238021b6e485699369383a5…
commit 07f27d8238021b6e485699369383a58f95984a4e
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Jul 19 18:00:37 2017 -0700
Update WinSparkle.
Change-Id: Ia0b717165b258fdc891b5d876b4acd31345ec00e
Reviewed-on: https://code.wireshark.org/review/22722
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=3fa8776a68404d4bea8c2fa8295748…
commit 3fa8776a68404d4bea8c2fa82957488c448b4e20
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Jul 19 19:27:19 2017 +0200
dcerpc-pn-io (profinet): fix typo for pn_io.iops display filter
Change-Id: I8422005703c9e0a04d067dfe5ba501fe7417ff8a
Reviewed-on: https://code.wireshark.org/review/22718
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6fdf043e6ee8ce9766f0b41a1c65ef…
commit 6fdf043e6ee8ce9766f0b41a1c65ef0996ce7db3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Jul 19 14:41:40 2017 +0200
X2AP: update version info in header
Change-Id: I5e5faf6cc389bc334c31ef0277858c9e99245b67
Reviewed-on: https://code.wireshark.org/review/22712
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ee7d2a6010a2c6745630a53e58a6e4…
commit ee7d2a6010a2c6745630a53e58a6e4601114b530
Author: Chris Brandson <cjb(a)exegin.com>
Date: Fri Jul 14 18:18:50 2017 -0700
ZigBee make ZCL Frame Control direction more descriptive
Using just client or server as a direction is a source of confusion so made a more
discriptive item
Change-Id: I8675aba555b04f6ae8848cf9e1c720eb4b44b553
Reviewed-on: https://code.wireshark.org/review/22628
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=62d5476740a8afb90eb67177fd1aec…
commit 62d5476740a8afb90eb67177fd1aece74cd3f8ec
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Jul 18 17:40:52 2017 +0200
ICMPv6: RA: Add Captive Portal Option (RFC7710)
RFC 7710 (https://tools.ietf.org/html/rfc7710#section-2.3) defines
option 37 Captive Portal URI for Router Advertisments.
Change-Id: I257412ef1cf22d47018974cd0ef9000b748d01ac
Reviewed-on: https://code.wireshark.org/review/22703
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d0e8b26ee2695246a4e3baa37d4384…
commit d0e8b26ee2695246a4e3baa37d4384e6c2e634d3
Author: Marie Janssen <jamuraa(a)google.com>
Date: Mon Jul 10 13:14:07 2017 -0700
AVRCP: fix parsing of Media Player Items
From the AVRCP 1.6.1 spec, page 76, the "Player ID" is two octets.
Also, the Play Status field comes before the Feature Bit Mask.
Change-Id: Ifd0ad82650d395395b16f9441f02b8835befa360
Reviewed-on: https://code.wireshark.org/review/22709
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=abfa43aa270d92219f0784c725fe31…
commit abfa43aa270d92219f0784c725fe31cad1cdbc69
Author: Robert Sauter <sauter(a)locoslab.com>
Date: Fri Jul 14 15:27:51 2017 +0200
IEEE 802.15.4: MPX dissect IEEE 802.11 4WH/GKH with EAPOL dissector
Change-Id: I8972a9a9efef31ab77571f333fb040569fb7de9a
Reviewed-on: https://code.wireshark.org/review/22622
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=da0ae7e19b0a3514756f6d0a762b48…
commit da0ae7e19b0a3514756f6d0a762b480d744425ac
Author: Uli Heilmeier <uh(a)heilmeier.eu>
Date: Tue Jul 18 20:32:00 2017 +0200
ICMPv6: Fix data length for unknown option
The length value includes the Type and Length fields. Therefore the
length of the Data field is two bytes smaller.
Change-Id: I93878a016ace083f4e766bee6e16e301d6903967
Reviewed-on: https://code.wireshark.org/review/22702
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0e0c9a1a7a3e4c9a6bb33d65dbc091…
commit 0e0c9a1a7a3e4c9a6bb33d65dbc0918184b8fb30
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Jul 18 16:01:49 2017 -0700
Qt: Don't clobber the itemview hover behavior on Windows.
Change-Id: I47a8087a1d3303baec9b598135c3f8a3021dadbe
Reviewed-on: https://code.wireshark.org/review/22707
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=b92c8a2e56f0e4dba1627e86077e56…
commit b92c8a2e56f0e4dba1627e86077e56c63457e85c
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Jul 18 15:12:23 2017 +0200
[Diameter] Add a couple of command codes from IANA.
Bug:13895
Change-Id: Icaffd828eef2853d73da807040e5f550548d2804
Reviewed-on: https://code.wireshark.org/review/22698
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=279a2762dc9f11a68afa3cb84e6ccd…
commit 279a2762dc9f11a68afa3cb84e6ccd9047ede1eb
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Mon Jul 17 20:47:38 2017 +0100
Extend enterprises.tsv to accept spaces as separators
We can do so easily because the format is so simple. This makes it
more convenient for a user to hand-edit a dictionary in the personal
config folder. We still use tabs in the system file for a small space
gain.
Also add a brief description of the format as a comment.
Change-Id: If3f741bff16f1f42c8ef07d643dc6463caaad1a5
Reviewed-on: https://code.wireshark.org/review/22678
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e46bd2827f581f1c5b18c4e166c137…
commit e46bd2827f581f1c5b18c4e166c13741fa6a99a8
Author: Chris Brandson <cjb(a)exegin.com>
Date: Mon Jul 17 16:54:06 2017 -0700
ZigBee cleanup minor errors
Alarm Code now correctly displayed as a byte
Missing ZCL status codes from ZCL 6 and ZCL 7 have been added
Input and Output Cluster Lists now displayed in hex as they are everywhere else
The term Device is no longer used, instead Nwk Addr and Address are used as
applicable
Change-Id: I552f4b64974bf44088a1c8f90d44e5459a0f81a6
Reviewed-on: https://code.wireshark.org/review/22683
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=aec147efa1f27518f6927ca5078e05…
commit aec147efa1f27518f6927ca5078e0547dd1a234d
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Jul 17 23:26:40 2017 +0200
LPP: upgrade dissector to v14.2.0
Change-Id: I445c5ef34c1a688310042634eb38bed9b17cadaf
Reviewed-on: https://code.wireshark.org/review/22679
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6d025eff1b41cb99a60b50c36de158…
commit 6d025eff1b41cb99a60b50c36de15803f6e8076f
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 17 21:34:11 2017 -0700
Do the meta-tag stuff the same way in all three cases.
Undo most of the changes, but turn the return at the end of the default
case into a break.
Change-Id: I022b62a85254ff188f19fd3d7c3fe40b0789b3d2
Reviewed-on: https://code.wireshark.org/review/22695
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5fd255424fda27b1ca9ded48a83da3…
commit 5fd255424fda27b1ca9ded48a83da31405ae1731
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jul 18 04:27:53 2017 +0000
Revert "Don't byte-swap an 1-byte value."
This reverts commit 74a2ae4abac3be78d140d9671fa79977de449ed1.
No, that's just Coverity not understanding macros *again*, and thinking a
particular expanded instance of a macro is the result of some human being silly rather
than of the arguments being such that some computations can be elided at compile time.
Change-Id: I40f2ad8bf018b0df02d90ed0e272505be68dae7e
Reviewed-on: https://code.wireshark.org/review/22693
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e934fad6389da228ae33e5fb83c298…
commit e934fad6389da228ae33e5fb83c29807a315ee77
Author: Simon Vans-Colina <simon(a)monzo.com>
Date: Mon Jul 17 18:35:02 2017 +0100
CQL: Fixes the dissector so PREPARE Results have the Query ID
Change-Id: I518335dc317ac5fb3c1339686579ff44b73c2546
Reviewed-on: https://code.wireshark.org/review/22675
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=541b9a93871892b0ad1732406f59f2…
commit 541b9a93871892b0ad1732406f59f2196ae76cf9
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Jul 17 19:46:28 2017 +0200
Qt: Fix "Filter Button Preferences" shortcut
When Expert preference UAT was promoted to main preference tree
the entry for Filter Buttons was moved and the code for handling
prefs_pane_to_item_ was wrong.
This should be rewritten to a bulletproof solution.
Change-Id: I1d98aa75da7107ac2e50b29ff19c52dc516053a6
Fixes: v2.5.0rc0-386-gd4d30faeb8
Reviewed-on: https://code.wireshark.org/review/22676
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=30f8ceebbad01f1040b492599d26e0…
commit 30f8ceebbad01f1040b492599d26e0f01e0824f1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 17 18:56:38 2017 -0700
Remove unnecessary test.
The default case ends with return, so the pointer won't be null by the
time out exit the case statement - either a non-default case is
processed and tag_ptr hasn't been set to null, or the default case is
processed and you return before getting there.
That also means we don't need to set tag_ptr to null in that case.
Fixes CIDs 1415436.
Change-Id: I21ada7a308d888b4cbb8557197a2e30bda118f44
Reviewed-on: https://code.wireshark.org/review/22691
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=74a2ae4abac3be78d140d9671fa799…
commit 74a2ae4abac3be78d140d9671fa79977de449ed1
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 17 18:43:44 2017 -0700
Don't byte-swap an 1-byte value.
Convert it to a 4-byte value and byte-swap *that*.
Fixes CID 1415438.
Change-Id: I5cf0b5905f5dd2086c5d8ed6b13b1921bdb69a84
Reviewed-on: https://code.wireshark.org/review/22689
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d35bb66516b25a4adf3f0471a1c625…
commit d35bb66516b25a4adf3f0471a1c6256680e4491a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 17 18:32:39 2017 -0700
Remove unnecessary test.
The default case ends with return, so the pointer won't be null by the
time out exit the case statement - either a non-default case is
processed and tag_ptr hasn't been set to null, or the default case is
processed and you return before getting there.
That also means we don't need to set tag_ptr to null in that case.
Fixes CID 1415439.
Change-Id: Id2609c0828561c560820f9cb5e6b5a0ae614aead
Reviewed-on: https://code.wireshark.org/review/22686
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8dcb530de6372580fa08659f1b230a…
commit 8dcb530de6372580fa08659f1b230a86ac53d553
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 17 18:22:53 2017 -0700
Copy no more than MAX_ERF_EHDR - 1 additional extension headers.
The array of headers has MAX_ERF_EHDR entries, and the additional
entries are appended after the first entry, so that leaves room for at
most MAX_ERF_EHDR - 1.
Fixes CID 1415440.
Change-Id: Iaa2c3577bbff429bcc1301e4cfdf1961f067be93
Reviewed-on: https://code.wireshark.org/review/22684
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=47c9cf8925123bbfc68fd581981601…
commit 47c9cf8925123bbfc68fd5819816016e488da165
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Jul 17 12:43:30 2017 -0700
Qt: Simplify some version checks.
We require Qt5 at configure time on macOS, so we no longer need to
exclude Qt4 + macOS in the code.
Change-Id: I9e233f963526b0051bd846d171105c1d33d1c4cc
Reviewed-on: https://code.wireshark.org/review/22677
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=2ca2cc16b1c4710726ba82908e735f…
commit 2ca2cc16b1c4710726ba82908e735f5b27a95184
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Jul 17 09:52:53 2017 -0700
Use time_t for the seconds part of a time stamp.
A packet time stamp is an nstime_t, and the seconds part of an nstime_t
is a time_t.
Change-Id: Id2452ceb2f33f43e4a040436d7b3ea1a5c4a0be3
Reviewed-on: https://code.wireshark.org/review/22673
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
-----------------------------------------------------------------------
hooks/post-receive
--
wireshark with Osmocom specific dissectors