osmo-bts.git branch neels/dyn_no_pcu updated. 0.4.0-259-g42edba5

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, neels/dyn_no_pcu has been updated discards 061e66121f107a3c3a00d4f0657effab0b81ee1d (commit) discards 244db5514fbdcc684ac64c19e4b3e268eea5d027 (commit) via 42edba5fe67ac96d4dde6ebb5f5d84fea9124f4f (commit) via 370a91c4eac99948376c2175ef9e352c70be2b53 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (061e66121f107a3c3a00d4f0657effab0b81ee1d) \ N -- N -- N (42edba5fe67ac96d4dde6ebb5f5d84fea9124f4f) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=42edba5fe67ac96d4dde6ebb5f5d84f… commit 42edba5fe67ac96d4dde6ebb5f5d84fea9124f4f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Aug 22 23:07:09 2016 +0200 dyn TS: if PCU is not connected, allow operation as TCH Before this patch, Osmocom style TCH/F_TCH/H_PDCH dyn TS were paralyzed if no PCU was running. The state of the dyn TS would lock up in the PDCH activation phase since the PCU never completed the process. Make more robust, i.e. don't concern the BSC with PDCH activation failures. This matches the way plain PDCH TS work: besides declaring the TS as PDCH, the BSC is not involved and is not told about errors. During PDCH deactivation, still wait for the PCU to tear down the PDTCH SAPIs, but in case no PCU is connected, send a rel ack right away. Thus, the BSC will happily switch Osmocom style dynamic timeslots to and from PDCH mode, using the dyn TS as voice channels as needed, and not caring about possible PDCH failures. GPRS starts working right away as soon as a PCU connects, regardless of dyn TS having been used for voice any number of times, and without another switchover needed. In detail: In rsl_rx_chan_activ(), upon receiving a PDCH activation, send an RSL chan act ack right away, unconditionally (with an explaining comment). Do not concern the Abis link with PDCH activation failures. Since we're acking right away now, drop the chan act ack that would follow after the PCU activation: as before dyn TS, only send acks and nacks for rel_act_kind == LCHAN_REL_ACT_RSL (PDCH runs as LCHAN_REL_ACT_PCU). In dyn_ts_pdch_release, indicate that the PCU is not connected by means of returning 1. In rsl_rx_rf_chan_rel(), use this indicator to send a rel ack right away if the PCU is not connected. Change-Id: I2a0b9730197786b99ff3bc1f08c75f7d279cb1f7 http://cgit.osmocom.org/osmo-bts/commit/?id=370a91c4eac99948376c2175ef9e352… commit 370a91c4eac99948376c2175ef9e352c70be2b53 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Aug 22 18:23:03 2016 +0200 common/rsl: move decision whether to chan act ack/nack to common function Prepare for a dyn TS patch that needs to call rsl_tx_chan_act_ack() directly without the rel_act_kind decision. Add function rsl_tx_chan_act_acknack() to wrap rsl_tx_chan_act_ack() and rsl_tx_chan_act_nack(). Move the decision whether to drop the ack/nack, based on lchan->rel_act_kind, to the new function, losing some code dup. Change all callers to use the new function; drop the two older ones from rsl.h and make them static. Note: for nack, the exception for dyn TS in PDCH mode was missing (rsl_tx_chan_act_nack() had only the rel_act_kind != LCHAN_REL_ACT_RSL condition, but should also have had the dyn TS exception as in rsl_tx_chan_act_ack()). I already know that this exception will again be removed in an upcoming commit, but for patch readability it logically makes sense to add it here. To easily include the nack case, drop the check for which pchan the dyn TS is operating as, because a rel_act_kind == LCHAN_REL_ACT_PCU implies that it is either already in or trying to become PDCH mode. Change-Id: I57ba60c670730c6d7877a6a9b96ece0a7679a0bb ----------------------------------------------------------------------- Summary of changes: src/common/rsl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)