16 Mar
2017
16 Mar
'17
1:54 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via d80a217f7f20c8af38f938a85dd62f1809c09709 (commit)
from e0cb0eeb3f04745cd5b17d5aa7c63ad7fea988f0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=d80a217f7f20c8af38f938a85dd6…
commit d80a217f7f20c8af38f938a85dd62f1809c09709
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Mar 1 14:49:58 2017 +0100
contrib: add script to find unterminated value_string arrays
Unterminated value_string arrays are dangerous since get_value_string() and
get_string_value() need to know where the struct ends. If the terminator is
missing, they might run through and return arbitrary memory locations.
Employ some regexes to find such unterminated value string arrays and return
nonzero if any are found.
This can be used in our jenkins build jobs to avoid committing unterminated
value_string arrays. In fact I've found one in current libosmocore:
gsm0808_bssap_names in gsm/gsm0808.c, fixed in a separate patch.
Change-Id: I2bc93ab4781487e7685cfb63091a489cd126b1a8
-----------------------------------------------------------------------
Summary of changes:
.../verify_value_string_arrays_are_terminated.py | 33 ++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100755 contrib/verify_value_string_arrays_are_terminated.py
hooks/post-receive
--
An utility library for Open Source Mobile Communications