10 Dec
2017
10 Dec
'17
2:23 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SCCP Library".
The branch, master has been updated
via 9af7028ebe72bb5bf47713f11b4e111ed83c0693 (commit)
from 081ac9c0292298f7992916d8f1b64faf764d4174 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmo-sccp/commit/?id=9af7028ebe72bb5bf47713f11b4…
commit 9af7028ebe72bb5bf47713f11b4e111ed83c0693
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Dec 10 14:13:33 2017 +0100
sccp_helpers: don't return msgb with l2h set
It's a bad idea to use sccp_msgb_alloc() for SCCP User Primitive msgbs.
The rationale is quite simple: The SCU msgb's are used for wrapping
osmo_prim. The user payload data (e.g. BSSAP) in such primitives is
found at msgb->l2h. However, user payload data is optional. So in a
SCU primitive without user data, we must have msgb->l2h == NULL.
The old behavior resulted in bogus data (actually the sccp_user_prim)
to be contained in the DATA section of SCCP messages such as RLSD/RLC.
Also, the old implementation of scu_msgb_alloc() discarded the 'name'
argument and replaced it with a static "SCU" which was of course another
bug.
Change-Id: I19cb83302aaa404ab1a2d92e6f2aec43d0380426
Related: OS#2732
-----------------------------------------------------------------------
Summary of changes:
src/sccp_helpers.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
hooks/post-receive
--
SCCP Library