- osmocom-commitlog - lists.osmocom.org

libosmocore.git branch master updated. 0.8.0-14-gf8699ca
by gitosis＠osmocom.org 28 Mar '15

28 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via f8699ca51eeb4f3d34336501abcaf071b4a95a47 (commit) from 249a81b7ff57d39af843cd267b60c0ce0400ce8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=f8699ca51eeb4f3d34336501abca… commit f8699ca51eeb4f3d34336501abcaf071b4a95a47 Author: Max <max.suraev(a)fairwaves.co> Date: Wed Mar 25 17:20:31 2015 +0100 gsm: Add A5/3-4 cipher support Signed-off-by: Max <max.suraev(a)fairwaves.co> Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/a5.h | 2 +- src/gsm/a5.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++-- tests/Makefile.am | 3 +- tests/a5/a5_test.c | 67 +++++++++++++++++++++++++++++++++++---------- tests/a5/a5_test.ok | 24 ++++++++++++++++ 5 files changed, 148 insertions(+), 19 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch master updated. 0.14.0-9-gfd603ed
by gitosis＠osmocom.org 28 Mar '15

28 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via fd603ed9e2f87d05b2261a25e11aceb01814dfbe (commit) from cf7557a7e756af54350fb9bcf1a19429848a17de (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=fd603ed9e2f87d05b2261a25e11aceb0… commit fd603ed9e2f87d05b2261a25e11aceb01814dfbe Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Mar 28 18:09:31 2015 +0100 write_queue: Check the result of osmo_wqueue_enqueue and free The write_queue is designed to have a maximum amount of pending messages and will refuse to take new messages when it has been reached. The caller can decide if it wants to flush the queue and add the message again, create a log. But in all cases the ownership of the msgb has not been transferred. Fix the potential memory leak in the failure situation. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libmsc/meas_feed.c | 3 ++- openbsc/src/libmsc/smpp_smsc.c | 8 +++++++- openbsc/src/utils/smpp_mirror.c | 8 +++++++- 3 files changed, 16 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.14.0-8-gcf7557a
by gitosis＠osmocom.org 28 Mar '15

28 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via cf7557a7e756af54350fb9bcf1a19429848a17de (commit) via 37b5ce56a0650eeb8a3c6b788d1c9ba16139b313 (commit) via 9967a57587b9dcc1eeeaa710159447eb098380f3 (commit) from cea35aecdc846edf125ac7e7d0407967d4778ccb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=cf7557a7e756af54350fb9bcf1a19429… commit cf7557a7e756af54350fb9bcf1a19429848a17de Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Fri Mar 16 08:14:23 2012 +0100 rtp: Fixed problem of mute audio on some calls When reading from RTP socket, the first read() may fail right after connecting to remote socket. Subsequent read() will work as it should. If the remote socket does not open fast enough, the transmitted RTP payload can cause an ICMP (connection refused) packet reply. This causes the read to fail with errno=111. In all other error cases, the errno is logged at debug level. In all error cases, reading is not disabled. Conflicts: openbsc/src/libtrau/rtp_proxy.c [hfreyther: Fix typo, stop reading in all cases but ECONNREFUSED] http://cgit.osmocom.org/openbsc/commit/?id=37b5ce56a0650eeb8a3c6b788d1c9ba1… commit 37b5ce56a0650eeb8a3c6b788d1c9ba16139b313 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Mar 28 17:30:31 2015 +0100 rtp: Fix memory leak fixed by Andreas without mentioning it We allocate the msgb at entry of the method and we always need to msgb_free it. http://cgit.osmocom.org/openbsc/commit/?id=9967a57587b9dcc1eeeaa710159447eb… commit 9967a57587b9dcc1eeeaa710159447eb098380f3 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Fri Jan 20 20:33:37 2012 +0100 rtp: Add handling of BFI (Bad Frame Indicatior) of received TRAU frames If a bad TRAU frame is received, it is forwarded to MNCC application as GSM_BAD_FRAME. The application can now handle the GAP of missing audio. (e.g. by extrapolation) If TRAU frames are forwarded via RTP, bad frames are dropped, but frame counter and timestamp of RTP sender state is incremented. Conflicts: openbsc/src/libtrau/rtp_proxy.c [hfreyther: Merge without testcase, fix typo] ----------------------------------------------------------------------- Summary of changes: openbsc/src/libtrau/rtp_proxy.c | 27 +++++++++++++++++++++++++-- openbsc/src/libtrau/trau_mux.c | 5 ++++- 2 files changed, 29 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.14.0-5-gcea35ae
by gitosis＠osmocom.org 28 Mar '15

28 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via cea35aecdc846edf125ac7e7d0407967d4778ccb (commit) from 7ce72c1be8e10add6dc84b85a29f7e2b924c6464 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=cea35aecdc846edf125ac7e7d0407967… commit cea35aecdc846edf125ac7e7d0407967d4778ccb Author: Max <max.suraev(a)fairwaves.co> Date: Sat Mar 28 16:13:14 2015 +0100 ignore debian build byproducts Signed-off-by: Max <max.suraev(a)fairwaves.co> ----------------------------------------------------------------------- Summary of changes: .gitignore | 1 + openbsc/.gitignore | 1 + 2 files changed, 2 insertions(+) create mode 100644 .gitignore hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch zecke/release/0.7-dev created. 0.7.0-29-g52354dd
by gitosis＠osmocom.org 27 Mar '15

27 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, zecke/release/0.7-dev has been created at 52354dd78567e898d5dd114380a17990ce1608f8 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=52354dd78567e898d5dd114380a1… commit 52354dd78567e898d5dd114380a17990ce1608f8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Mar 17 10:21:17 2015 +0100 bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=3a5991ef2f495f0010f9a7ba9079… commit 3a5991ef2f495f0010f9a7ba9079a826e94f8e81 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Mar 17 10:21:16 2015 +0100 bssgp: Don't reply with STATUS when receiving a PtP STATUS message Currently each incoming PtP BSSGP STATUS message is handled as 'not yet implemented' and a BSSGP STATUS message (cause BSSGP_CAUSE_PROTO_ERR_UNSPEC) is sent back to the peer. This will cause endless messages loops if both peers use this BSSGP stack implementation. This does not apply to signalling messages. This commit changes the implementation of bssgp_rx_ptp() to just do logging in this case. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=bdbb54b31379d61529bf351ca8de… commit bdbb54b31379d61529bf351ca8de134d85654d61 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 10 08:27:15 2014 +0100 bssgp: Fix VTY command 'show bssgp nsei N' Currently this command segfaults (at least when ASAN is enabled), because when getting the NSEI the index to argv is wrong and out of bounds. This patch fixes the offset. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=fabe7d51bef1b4d3e8ec6d74de5d… commit fabe7d51bef1b4d3e8ec6d74de5d6143d27fcce0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Sep 10 12:43:28 2014 +0200 gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=7ced8f71cd61115b593b78cb7795… commit 7ced8f71cd61115b593b78cb779553f1c7df3071 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 14 14:49:37 2014 +0200 gprs/test: Add BSSGP tests This patch adds a test suite for the BSSGP protocol. The first (and only) test checks the handling of BSSGP SUSPEND/RESUME. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=3de27490ceb8172363169358b7c4… commit 3de27490ceb8172363169358b7c4fcbcb26f4b11 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Oct 9 11:07:56 2014 +0200 gprs-ns/test: Check the nsvc state explicitely This patch extends test_sgsn_reset_invalid_state by assertions to check that nscv->state and nsvc->remote_state have been set as expected. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=8301a09dcc60ed7d72f8ccab0551… commit 8301a09dcc60ed7d72f8ccab0551ec794559ed7e Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Oct 9 16:07:37 2014 +0200 gprs-ns/test: Re-add return value check for gprs_nsvc_reset The return value check has been removed in the commit 'Use gprs_nsvc_reset instead of gprs_ns_tx_reset', because gprs_nsvc_reset had no return value then. Since a compatible return value has been added by 'Let gprs_nsvc_reset return a value', the former patch is partly reverted by this commit. The printf is now an OSMO_ASSERT. The commit message was taken from Jacob. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=99e06370517f24f59dbfdfc52acd… commit 99e06370517f24f59dbfdfc52acd2a67c34a727a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 7 14:12:30 2014 +0200 gprs-ns: Fix reset state handling Currently the NS-VC's state is updated from within gprs_ns_tx_reset, which can lead to an inconsistent state when the RESET_ACK is lost. In this state, the NSE_S_RESET bit is set but the Tns-reset timer is not started. This patch moves the state update into gprs_nsvc_reset. This way, the state flags are consistent with the timer. Addresses: SGSN -> BSS NS_ALIVE BSS -> SGSN NS_ALIVE_ACK BSS -> SGSN BVC_RESET SGSN -> BSS NS_STATUS, Cause: NS-VC blocked, NS VCI: 0x65 and there is no BSS->SGSN NS_ALIVE Ticket: OW#1213 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=337c1a86c2a8407e65713602d4ae… commit 337c1a86c2a8407e65713602d4ae4182df8af7bb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 8 11:47:36 2014 +0200 gprs-ns: Let gprs_nsvc_reset return a value Currently gprs_nsvc_reset does not return any value. This patch changes the function to return an integer, where a value less than zero indicates an error. The value is taken from the gprs_ns_tx_reset function. In case of failure, an error message is logged. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=7d5dd15188bd54b8bf5380f7802a… commit 7d5dd15188bd54b8bf5380f7802abbabea5ada9c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 7 14:07:39 2014 +0200 gprs-ns/test: Add test_sgsn_reset_invalid_state This tests the behaviour for a certain combination of messages and packet losses that can put the NS-VC object into an undefined state. In that state, the peer's ALIVE messages are properly answered, but the local test procedure has stopped, incoming unitdata PDUs are answered by STATUS(NS-VC blocked) and the unblocking procedure is not initiated. Ticket: OW#1312 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=be9a26caa66232c6794cbf8c71d1… commit be9a26caa66232c6794cbf8c71d16f88382c7945 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 7 14:03:44 2014 +0200 gprs-ns/test: Add expire_nsvc_timer This function forces the expiration of the timer within struct gprs_nsvc. It is meant to be used for controlled (and faster) timer expiration in unit tests. The timer_mode of the expired timer is returned (or -1 if the timer wasn't active). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=0eb6a8c02eaa4a2ce6a6402be8a4… commit 0eb6a8c02eaa4a2ce6a6402be8a4e339f7541f31 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 7 13:59:30 2014 +0200 gprs-ns/test: Save the last PDU type sent This records the PDU type of the last message sent to the remote peer in the global variable sent_pdu_type, which can then be used in assertions. Note that sent_pdu_type will remain unchanged if no message has been sent via sendto. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=45415119faa06e6252ae66b7516b… commit 45415119faa06e6252ae66b7516b5c3fde86c0d1 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 7 13:52:07 2014 +0200 gprs-ns/test: Use gprs_nsvc_reset instead of gprs_ns_tx_reset Currently gprs_ns_tx_reset is used to let the NS stack generate NS_RESET message. This is not adjusting the nsvc state properly. This patch uses gprs_nsvc_reset instead which starts the full reset procedure. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-pcu.git branch master updated. 0.2-395-g502bd1f
by gitosis＠osmocom.org 26 Mar '15

26 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 502bd1feea9441938498b92405220437dc3a91bf (commit) via e25b5b91f60f20f61096bc6199a05b58ee6c6328 (commit) via 2cbe80b53e54b1ca832b2b30722ffacfa92f6117 (commit) via 3bed5d11d210b599f56a1df3a5339b0a74cedcff (commit) via cbb1e70554a08c7d6d1307d68883bc38a92fe4f3 (commit) via c4952091223e10d9e99fa035e6942656d233aa16 (commit) via 005ee7f8626d4733e8fa01f3589154287ed163ed (commit) via 2493c660e9cbede4ac43f2584c0a8e6d8625e1dd (commit) via a3e4509ff9b6ce2de574eaec7d085fc914cfeaab (commit) via eceb910fef8b6ebfba5aa9b13ffbccfe322d9706 (commit) via 95340242ed1089e30b9a3045ea55bc9068432e0b (commit) via 612e93e36031ab2d50dd66d148f289b2e3580850 (commit) from 39645b824a08b355fa48361491d5a1c3e9e6bd4d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: src/bts.h | 5 + src/gprs_rlcmac_sched.cpp | 41 +++++-- src/llc.cpp | 20 ++++ src/llc.h | 1 + src/{decoding.h => pcu_utils.h} | 22 +--- src/pcu_vty.c | 30 +++++ src/tbf.cpp | 3 + src/tbf.h | 11 ++ src/tbf_dl.cpp | 200 +++++++++++++++++++++++-------- tests/tbf/TbfTest.cpp | 166 +++++++++++++++++++++----- tests/tbf/TbfTest.err | 256 ++++++++++++++++++++++++++++++++++++---- tests/tbf/TbfTest.ok | 2 + 12 files changed, 634 insertions(+), 123 deletions(-) copy src/{decoding.h => pcu_utils.h} (62%) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-bts.git branch master updated. 0.3.0-282-g0ddd4b6
by gitosis＠osmocom.org 25 Mar '15

25 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 0ddd4b6c25dcb1cf85809b190afd6ac4d95890ea (commit) via 24839068f5c7e044e82afaa3b88d08a07e123ee7 (commit) from b631bd21d21b10f8e0344dc47af34ef09306d0fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=0ddd4b6c25dcb1cf85809b190afd6ac… commit 0ddd4b6c25dcb1cf85809b190afd6ac4d95890ea Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Mon Jul 29 09:37:07 2013 +0200 Add header file of PH-/MPH-/TCH-SAP interface to common part of osmo-bts Instead of handling primitives directly at layer 1 specific code, osmo-bts handles primitives at common code. When all primitive are moved, the l1sap interface will: - receive PH-DATA indications and forward them to layer 2. - check for RF link loss and notify BSC. - receive TCH indications and forward them via RTP. - receive PH-RTS indications and send PH-DATA requests with content according to its logical channel. - receive TCH-RTS indications and send TCH requests with content received via RTP or loopback from TCH indications. - send MPH-INFO requests to activate, deactivate and modify logical channels and handle their confirms. - receive MPH-INFO indications with measurements from tranceiver. - forward received and transmitted PH-DATA to GSMTAP. http://cgit.osmocom.org/osmo-bts/commit/?id=24839068f5c7e044e82afaa3b88d08a… commit 24839068f5c7e044e82afaa3b88d08a07e123ee7 Author: Andreas Eversberg <jolly(a)eversberg.eu> Date: Sun Jul 28 11:48:40 2013 +0200 sysmo-bts: Use correct boundaries of L1 msg when forwarding to L1 proxy In case of a headroom in a message, the 'head' pointer will not point to the actual data. ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/Makefile.am | 2 +- include/osmo-bts/l1sap.h | 71 ++++++++++++++++++++++++++++++++++++++ src/osmo-bts-sysmo/l1_transp_fwd.c | 2 +- 3 files changed, 73 insertions(+), 2 deletions(-) create mode 100644 include/osmo-bts/l1sap.h hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

osmo-pcu.git branch jerlbeck/wip created. 0.2-398-g068a5b3
by gitosis＠osmocom.org 25 Mar '15

25 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip has been created at 068a5b3cf79528f2d05f9a6bd7216aefba2ae95c (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=068a5b3cf79528f2d05f9a6bd7216ae… commit 068a5b3cf79528f2d05f9a6bd7216aefba2ae95c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Mar 24 15:03:47 2015 +0100 bssgp: log lifetime WIP http://cgit.osmocom.org/osmo-pcu/commit/?id=35bf6d836a82ea1976532ce39e37862… commit 35bf6d836a82ea1976532ce39e37862e60c45b45 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Mar 10 11:03:49 2015 +0100 l1: Add log messages and RACH gsmtap (TODO) TODO: - commit message - split http://cgit.osmocom.org/osmo-pcu/commit/?id=b4c16cabaebe0fad6266aec222007d0… commit b4c16cabaebe0fad6266aec222007d0a52ddd1fe Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Mar 20 12:02:42 2015 +0100 tbf: Use DL discard hysteresis (TODO) Currently single LLC blocks are discarded when the expire. If an IP packet has been fragmented and is therefore distributed over several LLC frames, the kept fragments are transmitted and then discarded by the MS. This can cause massive IP packet loss when there are many fragmented packets (e.g. when trying 'ping -s1800'). Also TCP recovery algorithms (default, SACK) seem to work better, if a single block of a few packets is missing instead of many single packets scattered over the TCP stream. On the other hand, discarding too many packets might disturb the congestion handling of TCP. Dropping plain TCP ACKs might also hinder flow control and congestion avoidance. This commit adds a hysteresis algorithm to the LLC discard loop. If an LLC message's age reaches the high water mark, further message's with an age above the low water mark are discarded, too. This is aborted, if a GMM, a non-UI, or a small message is detected. In these cases, that message is kept. TODO: - make low and high expiry watermarks configurable - make the keep threshold configurable http://cgit.osmocom.org/osmo-pcu/commit/?id=502bd1feea9441938498b9240522043… commit 502bd1feea9441938498b92405220437dc3a91bf Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Mar 20 14:26:05 2015 +0100 tbf: Poll MS on idle DL TBFs If an MS wants to open a new UL TBF, it can either use (P)RACH or request one in a Ack/Nack message for a DL TBF (PACCH). When a TBF becomes idle (LCC queue is empty but the TBF is kept open), there aren't any Ack/Nack requests that can be used by the MS to ask for an UL TBF, therefore it has to use the RACH. This leads to many RACH requests even for a single HTTP transaction, so it takes some time to retrieve even a simple web page. This commit modifies the scheduler to regularly send Ack/Nack requests on idle DL TBFs. It does so by extending the priority based scheduling algorithm to have 5 priority levels (highest priority first): - Control block is pending - High age (100%) threshold reached (-> request Ack/Nack) - Data is waiting or there are pending Nacks - Low age (200ms) threshold reached (-> request Ack/Nack) - Pending Nacks that have been resent already - None of the above (-> send DL dummy control block) The 'age' refers to the time since since the last control block has been sent on the TBF. This high age threshold is set to dl-tbf-idle-time or to 50% of T3190 (whichever is smaller), aiming for at least a poll (and TBF shutdown) after the TBF has expired and to safely prevent expiry of T3190. So if dl-tbf-idle-time > 200ms, there will be a poll every 200ms and a final poll after dl-tbf-idle-time. On high load, the interval between polls can get higher, but the 'high age' poll should be in place. This commit implements the scheduling with respect to GSM 44.060, 9.3.1a ("Delayed release of downlink TBF"). Ticket: #556 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=e25b5b91f60f20f61096bc6199a05b5… commit e25b5b91f60f20f61096bc6199a05b58ee6c6328 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Mar 19 14:21:33 2015 +0100 tbf: Only create dummy frames if necessary Currently a lot of LLC dummy commands will be generated while waiting for an ACK for the DL TBF, even if there are blocks that could be resent instead. This patch modifies create_dl_acked_block to only call create_new_bsn() if there is unsent LLC data or m_window is empty. If the TBF is in state FLOW, no unsent LLC data is left, but there are blocks left in m_window, those are resent instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=2cbe80b53e54b1ca832b2b30722ffac… commit 2cbe80b53e54b1ca832b2b30722ffacfa92f6117 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Mar 25 10:48:52 2015 +0100 tbf/test: Add test for delayed release This tests checks the implementation of the delayed release of an downlink TBF. Ticket: #556 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=3bed5d11d210b599f56a1df3a5339b0… commit 3bed5d11d210b599f56a1df3a5339b0a74cedcff Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Mar 19 11:22:38 2015 +0100 tbf: Implement delayed release of a downlink TBF Currently a DL TBF is immediately closed, when the LLC queue is drained. This will lead to a new DL assignment if data is received afterwards. In addition, it is not possible to keep the PACCH open to poll the MS for UL establishment requests there. GSM 44.060, 9.3.1a suggests to delay the release of an inactive TBF for some time (max 5s). This commit mainly changes create_new_bsn() to send LLC dummy commands as filler if no LLC data is available until keep_open() returns false. The keep_open() functions returns true unless a configurable time has passed after the LLC data store drained. By default, that time is not set which causes keep_open() to always return false, so that delayed release is effectively disabled. The following VTY commands are added: - dl-tbf-idle-time <1-5000> to set the delay in ms - no dl-tbf-idle-time to disable delayed release Ticket: #556 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=cbb1e70554a08c7d6d1307d68883bc3… commit cbb1e70554a08c7d6d1307d68883bc38a92fe4f3 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Mar 25 12:21:55 2015 +0100 tbf: Insert LLC dummy command if no frame is available If a BSN is going to be created but there is no frame stored in m_llc, an empty LLC message would be created. This shouldn't happen currently, but this will be a common case, when delayed TBF release is implemented. This commit changes create_new_bsn() to create an LLC dummy command in that case and to put it into the frame buffer. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=c4952091223e10d9e99fa035e694265… commit c4952091223e10d9e99fa035e6942656d233aa16 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Mar 24 11:04:19 2015 +0100 tbf: Use put_frame in append_data if the TBF has no data Currently if append_data() is used when there is no LLC data in the DL TBF, it will either call reuse_tbf() which in turn will call put_frame(), or it will append the LLC message to the queue, even if the queue and the frame buffer are empty. This only happens with the test case so far, but this would change when idle DL TBFs are kept open for some time. It results in empty LLC message being sent to the MS (see log below). This commit changes append_data to check for this case and to eventually use put_frame() instead of appending the LLC data to the queue. Addresses: TBF(TFI=0 TLLI=0x00000000 DIR=DL STATE=FLOW) downlink (V(A)==0 .. V(S)==0) - Sending new block at BSN 0 -- Chunk with length 0 is less than remaining space (20): add length header to to delimit LLC frame Complete DL frame for TBF(TFI=0 TLLI=0x00000000 DIR=DL STATE=FLOW)len=0 - Dequeue next LLC for TBF(TFI=0 TLLI=0x00000000 DIR=DL STATE=FLOW) (len=200) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=005ee7f8626d4733e8fa01f35891542… commit 005ee7f8626d4733e8fa01f3589154287ed163ed Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Mar 20 14:53:54 2015 +0100 tbf: Add frames_since_last_poll method This functions calculates the number of frames that have passed since the last DL poll (RRBP flag set) has been sent. It returns a value less than zero (fn_now - fn_sched) if the block has been scheduled but not yet sent. If the function is called before the first data block has been sent it will return -1. If the function is called before the first DL poll is sent, it returns the number of frames since the first data block has been sent. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=2493c660e9cbede4ac43f2584c0a8e6… commit 2493c660e9cbede4ac43f2584c0a8e6d8625e1dd Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Mar 25 10:05:34 2015 +0100 tbf/test: Fix fn/block_nr in test_tbf_final_ack Currently fn and block_nr are not incremented correctly. In addition, the comments around the sending of blocks are not accurate either. This commit introduces the send_rlc_block helper function which takes care of the increments, updates the comments to reflect what is really happening, and adds assertion to verify at least some aspects of what is now stated in the comments. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=a3e4509ff9b6ce2de574eaec7d085fc… commit a3e4509ff9b6ce2de574eaec7d085fc914cfeaab Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Mar 25 09:11:24 2015 +0100 tbf/test: Put BTS setup and DL TBF creation into helper functions Put the generic parts of test_tbf_final_ack into helper functions to reduce the size of the test and to avoid too much code duplication when creating new tests. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=eceb910fef8b6ebfba5aa9b13ffbccf… commit eceb910fef8b6ebfba5aa9b13ffbccfe322d9706 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Mar 20 14:41:50 2015 +0100 tbf: Add helper functions for DL TBFs Some properties of a DL TBF are explicitly calculated within modules using DL TBFs. This commit introduces the methods need_control_ts(), have_data(), is_control_ts() to hide internals of the DL TBF implementation. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=95340242ed1089e30b9a3045ea55bc9… commit 95340242ed1089e30b9a3045ea55bc9068432e0b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Mar 19 13:22:07 2015 +0100 tbf: Refactor create_dl_acked_block Turn the big nested if statement into a sequence of smaller ones. The call to create_new_bsn is moved upwards. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=612e93e36031ab2d50dd66d148f289b… commit 612e93e36031ab2d50dd66d148f289b2e3580850 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Mar 20 13:57:27 2015 +0100 llc: Add put_dummy_frame to create an LLC dummy command The LLC dummy command is needed for RLC block stuffing, e.g. when a TBF should be kept open if no LLC data is available. The RLC block headers do not support stuffing, only the last block of a TBF can be used partially. LLC dummy commands are discarded by the receiver immediately, because the have an invalid FCS checksum. This commit adds the function put_dummy_frame, which puts a LLC dummy command into the frame buffer. The requested length is given as an argument, but the real length might be adjusted according to the specification (see GSM 44.064, 6.4.2.2). Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

cellmgr-ng.git branch zecke/m3ua updated. 1.3.0-39-g3161682
by gitosis＠osmocom.org 24 Mar '15

24 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Cellmanager NG, intended to interface with BSplus". The branch, zecke/m3ua has been updated discards 55cd4b017dfdca79192473b82a643f540ae86f5e (commit) discards 8e855c30a2c2b74831d3d315b1d25456ad7c5017 (commit) discards d558219b69c79b03ff88b8b64edb59135ac0b464 (commit) via 316168249f25e46d802edcfed2461845000a066d (commit) via ebdbc1140388255b27479f752d0813d986ca1c03 (commit) via d1df399a972ce2b96b0d3ef9e90d17a7c16a93b5 (commit) via 6a20bae1f9adee67829ade0f20d9626deb98eee6 (commit) via d2f21e079613a7c0ed4f245fb14a6b3d20eefdfc (commit) via 679a8d0b75fe2db44cacdcd56b11aec3803ca521 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (55cd4b017dfdca79192473b82a643f540ae86f5e) \ N -- N -- N (316168249f25e46d802edcfed2461845000a066d) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cellmgr-ng/commit/?id=316168249f25e46d802edcfed2461… commit 316168249f25e46d802edcfed2461845000a066d Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:24:22 2015 +0100 all: Use the libosmo-sccp version of mtp_level3.h http://cgit.osmocom.org/cellmgr-ng/commit/?id=ebdbc1140388255b27479f752d081… commit ebdbc1140388255b27479f752d0813d986ca1c03 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:21:01 2015 +0100 m3ua: Use the MTP_READ_DPC/MTP_READ_OPC for using the right PC Make the code work for both ISUP and SCCP and let the address handling still be part of the linkset/mtp3 code. http://cgit.osmocom.org/cellmgr-ng/commit/?id=d1df399a972ce2b96b0d3ef9e90d1… commit d1df399a972ce2b96b0d3ef9e90d17a7c16a93b5 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 18:51:02 2015 +0100 m3ua: Implement link bring-up and sending/receiving of data the opc/dpc for ISUP is currently wrong. The send/recv path for actual SCCP data is not tested. http://cgit.osmocom.org/cellmgr-ng/commit/?id=6a20bae1f9adee67829ade0f20d96… commit 6a20bae1f9adee67829ade0f20d9626deb98eee6 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Mar 23 16:59:18 2015 +0100 m3ua: Implement connect and re-connect handling http://cgit.osmocom.org/cellmgr-ng/commit/?id=d2f21e079613a7c0ed4f245fb14a6… commit d2f21e079613a7c0ed4f245fb14a6b3d20eefdfc Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Mar 23 16:19:37 2015 +0100 m3ua: Begin to create a m3ua client connection Implement a basic M3UA state machine on a SCTP connection. http://cgit.osmocom.org/cellmgr-ng/commit/?id=679a8d0b75fe2db44cacdcd56b11a… commit 679a8d0b75fe2db44cacdcd56b11aec3803ca521 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 18:36:24 2015 +0100 mtp: Allow to skip SLTM on links (e.g. m3ua) For M3UA links we can't send SLTM messages but we can assume that the link is fine. Add a flag that a link can set in case SLTM should be skipped. The linkset will then directly wait for routable DPCs and bring the SCCP part up. ----------------------------------------------------------------------- Summary of changes: include/Makefile.am | 2 +- include/mtp_data.h | 6 + include/mtp_level3.h | 180 ------------------------------ include/sctp_m3ua.h | 3 +- src/isup.c | 2 +- src/links.c | 2 +- src/main.c | 2 +- src/main_stp.c | 2 +- src/mtp_layer3.c | 10 +- src/mtp_link.c | 11 +- src/sccp_state.c | 2 +- src/sctp_m3ua_client.c | 269 ++++++++++++++++++++++++++++++++++++++++++--- tests/mtp/Makefile.am | 2 +- tests/mtp/mtp_parse_test.c | 10 +- 14 files changed, 286 insertions(+), 217 deletions(-) delete mode 100644 include/mtp_level3.h hooks/post-receive -- Cellmanager NG, intended to interface with BSplus

1 0

libosmo-sccp.git branch master updated. 0.0.6.3-22-ge0cd6c4
by gitosis＠osmocom.org 24 Mar '15

24 Mar '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via e0cd6c4d3b7388ec20f8cec9d997429941d4d1b0 (commit) via e48db7f497a378e62b98d26157b7e5b2f3185d3f (commit) via 6bdea1491597b2cb3ed82e9c1892a727b62daf34 (commit) via 837beea52c8d10aa9ca31ca36779755c78e84242 (commit) via 80565cd8c339a2a72244d599c39b1a1aaac923a6 (commit) via 0a8308764c6e1a309842629b23e6ed17cfc755c7 (commit) via 953d4eda472c7b28b1f5d24dbd71247a80c0f08b (commit) from 7046633c02d15939d4953f1860f38be28f42667e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=e0cd6c4d3b7388ec20f8cec9d99… commit e0cd6c4d3b7388ec20f8cec9d997429941d4d1b0 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:19:46 2015 +0100 mtp: Correct the pointcode mask Taken from libosmocore http://cgit.osmocom.org/libosmo-sccp/commit/?id=e48db7f497a378e62b98d26157b… commit e48db7f497a378e62b98d26157b7e5b2f3185d3f Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:13:05 2015 +0100 mtp: Add missing defines from cellmgr-ng http://cgit.osmocom.org/libosmo-sccp/commit/?id=6bdea1491597b2cb3ed82e9c189… commit 6bdea1491597b2cb3ed82e9c1892a727b62daf34 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:12:54 2015 +0100 mtp: Add implementation from cellmgr http://cgit.osmocom.org/libosmo-sccp/commit/?id=837beea52c8d10aa9ca31ca3677… commit 837beea52c8d10aa9ca31ca36779755c78e84242 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:09:13 2015 +0100 mtp: Convert to pragma once This already fixes a clash of filenames in cellmgr-ng http://cgit.osmocom.org/libosmo-sccp/commit/?id=80565cd8c339a2a72244d599c39… commit 80565cd8c339a2a72244d599c39b1a1aaac923a6 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:08:56 2015 +0100 mtp: Error about unknown endian as well http://cgit.osmocom.org/libosmo-sccp/commit/?id=0a8308764c6e1a309842629b23e… commit 0a8308764c6e1a309842629b23e6ed17cfc755c7 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 19:01:40 2015 +0100 mtp: Implement reading the OPC/DPC for little endian http://cgit.osmocom.org/libosmo-sccp/commit/?id=953d4eda472c7b28b1f5d24dbd7… commit 953d4eda472c7b28b1f5d24dbd71247a80c0f08b Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Mar 24 18:34:57 2015 +0100 m3ua: Add the definition of the protocol data header ----------------------------------------------------------------------- Summary of changes: include/mtp/mtp_level3.h | 24 ++++++++++++++++++++---- include/sigtran/m3ua_types.h | 15 +++++++++++++++ tests/mtp/mtp_parse_test.c | 10 ++++++++++ 3 files changed, 45 insertions(+), 4 deletions(-) hooks/post-receive -- SCCP Library

1 0