This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, zecke/release/0.7-dev has been created at 52354dd78567e898d5dd114380a17990ce1608f8 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=52354dd78567e898d5dd114380a17... commit 52354dd78567e898d5dd114380a17990ce1608f8 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Mar 17 10:21:17 2015 +0100 bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=3a5991ef2f495f0010f9a7ba9079a... commit 3a5991ef2f495f0010f9a7ba9079a826e94f8e81 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Mar 17 10:21:16 2015 +0100 bssgp: Don't reply with STATUS when receiving a PtP STATUS message Currently each incoming PtP BSSGP STATUS message is handled as 'not yet implemented' and a BSSGP STATUS message (cause BSSGP_CAUSE_PROTO_ERR_UNSPEC) is sent back to the peer. This will cause endless messages loops if both peers use this BSSGP stack implementation. This does not apply to signalling messages. This commit changes the implementation of bssgp_rx_ptp() to just do logging in this case. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=bdbb54b31379d61529bf351ca8de1... commit bdbb54b31379d61529bf351ca8de134d85654d61 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Mon Nov 10 08:27:15 2014 +0100 bssgp: Fix VTY command 'show bssgp nsei N' Currently this command segfaults (at least when ASAN is enabled), because when getting the NSEI the index to argv is wrong and out of bounds. This patch fixes the offset. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=fabe7d51bef1b4d3e8ec6d74de5d6... commit fabe7d51bef1b4d3e8ec6d74de5d6143d27fcce0 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Wed Sep 10 12:43:28 2014 +0200 gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=7ced8f71cd61115b593b78cb77955... commit 7ced8f71cd61115b593b78cb779553f1c7df3071 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Oct 14 14:49:37 2014 +0200 gprs/test: Add BSSGP tests This patch adds a test suite for the BSSGP protocol. The first (and only) test checks the handling of BSSGP SUSPEND/RESUME. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=3de27490ceb8172363169358b7c4f... commit 3de27490ceb8172363169358b7c4fcbcb26f4b11 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Thu Oct 9 11:07:56 2014 +0200 gprs-ns/test: Check the nsvc state explicitely This patch extends test_sgsn_reset_invalid_state by assertions to check that nscv->state and nsvc->remote_state have been set as expected. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=8301a09dcc60ed7d72f8ccab0551e... commit 8301a09dcc60ed7d72f8ccab0551ec794559ed7e Author: Holger Hans Peter Freyther <holger@moiji-mobile.com> Date: Thu Oct 9 16:07:37 2014 +0200 gprs-ns/test: Re-add return value check for gprs_nsvc_reset The return value check has been removed in the commit 'Use gprs_nsvc_reset instead of gprs_ns_tx_reset', because gprs_nsvc_reset had no return value then. Since a compatible return value has been added by 'Let gprs_nsvc_reset return a value', the former patch is partly reverted by this commit. The printf is now an OSMO_ASSERT. The commit message was taken from Jacob. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=99e06370517f24f59dbfdfc52acd2... commit 99e06370517f24f59dbfdfc52acd2a67c34a727a Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Oct 7 14:12:30 2014 +0200 gprs-ns: Fix reset state handling Currently the NS-VC's state is updated from within gprs_ns_tx_reset, which can lead to an inconsistent state when the RESET_ACK is lost. In this state, the NSE_S_RESET bit is set but the Tns-reset timer is not started. This patch moves the state update into gprs_nsvc_reset. This way, the state flags are consistent with the timer. Addresses: SGSN -> BSS NS_ALIVE BSS -> SGSN NS_ALIVE_ACK BSS -> SGSN BVC_RESET SGSN -> BSS NS_STATUS, Cause: NS-VC blocked, NS VCI: 0x65 and there is no BSS->SGSN NS_ALIVE Ticket: OW#1213 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=337c1a86c2a8407e65713602d4ae4... commit 337c1a86c2a8407e65713602d4ae4182df8af7bb Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Wed Oct 8 11:47:36 2014 +0200 gprs-ns: Let gprs_nsvc_reset return a value Currently gprs_nsvc_reset does not return any value. This patch changes the function to return an integer, where a value less than zero indicates an error. The value is taken from the gprs_ns_tx_reset function. In case of failure, an error message is logged. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=7d5dd15188bd54b8bf5380f7802ab... commit 7d5dd15188bd54b8bf5380f7802abbabea5ada9c Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Oct 7 14:07:39 2014 +0200 gprs-ns/test: Add test_sgsn_reset_invalid_state This tests the behaviour for a certain combination of messages and packet losses that can put the NS-VC object into an undefined state. In that state, the peer's ALIVE messages are properly answered, but the local test procedure has stopped, incoming unitdata PDUs are answered by STATUS(NS-VC blocked) and the unblocking procedure is not initiated. Ticket: OW#1312 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=be9a26caa66232c6794cbf8c71d16... commit be9a26caa66232c6794cbf8c71d16f88382c7945 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Oct 7 14:03:44 2014 +0200 gprs-ns/test: Add expire_nsvc_timer This function forces the expiration of the timer within struct gprs_nsvc. It is meant to be used for controlled (and faster) timer expiration in unit tests. The timer_mode of the expired timer is returned (or -1 if the timer wasn't active). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=0eb6a8c02eaa4a2ce6a6402be8a4e... commit 0eb6a8c02eaa4a2ce6a6402be8a4e339f7541f31 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Oct 7 13:59:30 2014 +0200 gprs-ns/test: Save the last PDU type sent This records the PDU type of the last message sent to the remote peer in the global variable sent_pdu_type, which can then be used in assertions. Note that sent_pdu_type will remain unchanged if no message has been sent via sendto. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/libosmocore/commit/?id=45415119faa06e6252ae66b7516b5... commit 45415119faa06e6252ae66b7516b5c3fde86c0d1 Author: Jacob Erlbeck <jerlbeck@sysmocom.de> Date: Tue Oct 7 13:52:07 2014 +0200 gprs-ns/test: Use gprs_nsvc_reset instead of gprs_ns_tx_reset Currently gprs_ns_tx_reset is used to let the NS stack generate NS_RESET message. This is not adjusting the nsvc state properly. This patch uses gprs_nsvc_reset instead which starts the full reset procedure. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications