March 2018 - osmocom-commitlog

libosmocore.git branch master updated. 0.10.2-214-gd86055b4

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via d86055b431275cedb73bce32cb18dfc41dff0d15 (commit) from c9bebbd325e567333486a90b92d16ee464a4458a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d86055b431275cedb73bce32cb18… commit d86055b431275cedb73bce32cb18dfc41dff0d15 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Mar 17 10:32:07 2018 +0100 abis_nm: Introduce abis_nm_dump_foh() This is a more modern way of printing the Abis OML Formatted Object Header, without assuming that it would be used in a log statement or prescribing the log level to be used. Change-Id: I9b2c2afec28882b817d104d5b062651ade7aadd8 ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/abis_nm.h | 8 +++----- src/gsm/abis_nm.c | 15 +++++++++++---- src/gsm/libosmogsm.map | 1 + 3 files changed, 15 insertions(+), 9 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

op25.git branch max updated. bd95950d8ca8e31a1c8a785d4add132aa7a202f6

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via bd95950d8ca8e31a1c8a785d4add132aa7a202f6 (commit) via e572cfe8022b2d2fd0d591bf90324c18c30090dc (commit) via 9d344f283b9a595b35c6b6e9a7e6b514838ed974 (commit) via 411d385125ce2db960501c8894877128bee8b63c (commit) via abf9b4f06c95f864187c7a2f01141bfadfe46191 (commit) via 5ea5186c5dcf02280848b5cba91fc37d39f8dcc4 (commit) from 4630e585649b45bb9171f55be3867d18333e5cc2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=bd95950d8ca8e31a1c8a785d4add132aa7a… commit bd95950d8ca8e31a1c8a785d4add132aa7a202f6 Author: Max <ikj1234i(a)yahoo.com> Date: Fri Mar 16 16:56:15 2018 -0400 main.js edits http://cgit.osmocom.org/op25/commit/?id=e572cfe8022b2d2fd0d591bf90324c18c30… commit e572cfe8022b2d2fd0d591bf90324c18c30090dc Author: Max <ikj1234i(a)yahoo.com> Date: Fri Mar 16 16:38:26 2018 -0400 configuration additions http://cgit.osmocom.org/op25/commit/?id=9d344f283b9a595b35c6b6e9a7e6b514838… commit 9d344f283b9a595b35c6b6e9a7e6b514838ed974 Author: Max <ikj1234i(a)yahoo.com> Date: Fri Mar 16 16:29:54 2018 -0400 add config directory http://cgit.osmocom.org/op25/commit/?id=411d385125ce2db960501c8894877128bee… commit 411d385125ce2db960501c8894877128bee8b63c Author: Max <ikj1234i(a)yahoo.com> Date: Fri Mar 16 16:28:37 2018 -0400 temp.png http://cgit.osmocom.org/op25/commit/?id=abf9b4f06c95f864187c7a2f01141bfadfe… commit abf9b4f06c95f864187c7a2f01141bfadfe46191 Author: Max <ikj1234i(a)yahoo.com> Date: Fri Mar 16 16:26:42 2018 -0400 configuration additions http://cgit.osmocom.org/op25/commit/?id=5ea5186c5dcf02280848b5cba91fc37d39f… commit 5ea5186c5dcf02280848b5cba91fc37d39f8dcc4 Author: Max <ikj1234i(a)yahoo.com> Date: Fri Mar 16 16:14:43 2018 -0400 byteify ----------------------------------------------------------------------- Summary of changes: op25/gr-op25_repeater/apps/http.py | 158 ++++++++- op25/gr-op25_repeater/apps/multi_rx.py | 22 +- op25/gr-op25_repeater/www/config/README | 1 + op25/gr-op25_repeater/www/images/temp.png | Bin 0 -> 75597 bytes op25/gr-op25_repeater/www/www-static/index.html | 190 ++++++++++- op25/gr-op25_repeater/www/www-static/main.css | 91 ++++++ op25/gr-op25_repeater/www/www-static/main.js | 410 ++++++++++++++++++++++-- 7 files changed, 833 insertions(+), 39 deletions(-) mode change 100644 => 100755 op25/gr-op25_repeater/apps/http.py create mode 100644 op25/gr-op25_repeater/www/config/README create mode 100644 op25/gr-op25_repeater/www/images/temp.png hooks/post-receive -- Software-defined analyzer for APCO P25

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-213-gc9bebbd3

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via c9bebbd325e567333486a90b92d16ee464a4458a (commit) from 483f386fd40bc2715a6e2c91b34e44ac1e0ae666 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=c9bebbd325e567333486a90b92d1… commit c9bebbd325e567333486a90b92d16ee464a4458a Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Fri Mar 16 15:59:01 2018 +0100 add a regression test for TLV parsing with repeated IEs Since commit bf383a1d83661af26ccd6521c49b655fb22531d4 tlv_parse() will return the first occurrence of a repeated IE. Add a test to verify this behaviour. This test passes with the current code and fails if bf383a1d83661af26ccd6521c49b655fb22531d4 is reverted. While here, fix lies in documentation about the return value of tlv_parse() and fix a typo in another comment. Change-Id: I041f38548c5e4236920991d6c681c1c1e04de9ca Related: OS#2904 ----------------------------------------------------------------------- Summary of changes: src/gsm/tlv_parser.c | 4 ++-- tests/tlv/tlv_test.c | 31 +++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-212-g483f386f

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 483f386fd40bc2715a6e2c91b34e44ac1e0ae666 (commit) via ed4327c470c69a626a081bc91de1a5ad5e248f5a (commit) via 9c62fc69a8eb9f72da054f908704acbb14a6caa6 (commit) from 2338145d5b4e27447bb9026c0bb8251a59d7c20d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=483f386fd40bc2715a6e2c91b34e… commit 483f386fd40bc2715a6e2c91b34e44ac1e0ae666 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Fri Mar 16 12:21:26 2018 +0100 add a test for CELL_IDENT_WHOLE_GLOBAL cell identifier lists Add a regression test which encodes and decodes a cell identifier list of type CELL_IDENT_WHOLE_GLOBAL. Change-Id: Ie633d9e55c6a30555c0153d35aaf9f982d6e0088 Depends: If0fafbc7171da2a3044bfa9a167208a1afa1c07b Related: OS#2847 http://cgit.osmocom.org/libosmocore/commit/?id=ed4327c470c69a626a081bc91de1… commit ed4327c470c69a626a081bc91de1a5ad5e248f5a Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Fri Mar 16 11:02:59 2018 +0100 fix parse_cell_id_lac_and_ci_list() The implementation was entirely broken, reading data from wrong offsets and always writing to the first element of the decoded list. Also, add a new test for this function which found the problems. Change-Id: If0fafbc7171da2a3044bfa9a167208a1afa1c07b Related: OS#2847 Depends: Ife4e485e2b86c6f3321c9700611700115ad247b2 http://cgit.osmocom.org/libosmocore/commit/?id=9c62fc69a8eb9f72da054f908704… commit 9c62fc69a8eb9f72da054f908704acbb14a6caa6 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Fri Mar 16 10:23:34 2018 +0100 fix bug in parse_cell_id_ci_list() Cell ID lists with CI were misparsed because parse_cell_id_ci_list() failed to report the amount of consumed bytes to its caller. Also add a regression test which uncovered the bug. Change-Id: Ife4e485e2b86c6f3321c9700611700115ad247b2 Depends: If6b941720de33dca66b6b1aa2cb95a3275708b7f Related: OS#2847 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm0808_utils.c | 15 ++--- tests/gsm0808/gsm0808_test.c | 138 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 146 insertions(+), 7 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

osmo-ci.git branch master updated. 196402ac657f86a94b86a12b07dfeaf7d3a0a273

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 196402ac657f86a94b86a12b07dfeaf7d3a0a273 (commit) from 07653276019511efe7e188a80c307225ac78230d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=196402ac657f86a94b86a12b07dfeaf7… commit 196402ac657f86a94b86a12b07dfeaf7d3a0a273 Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Tue Mar 6 14:07:16 2018 +0100 add ansible playbooks Introduce playbooks to do: - setup-jenkins-slave - setup a usualy or special jenkins-slave - setup-gsm-tester - setup the gsm-tester Change-Id: I7007a4e6c38f73843390ec2b3b91133aff21e36a ----------------------------------------------------------------------- Summary of changes: ansible/.gitignore | 5 + ansible/files/README.md | 23 ++ ansible/hosts | 11 + ansible/roles/docker/README.md | 1 + ansible/roles/docker/defaults/main.yml | 4 + ansible/roles/docker/tasks/main.yml | 28 +++ ansible/roles/gsm-tester-modems/README.md | 1 + ansible/roles/gsm-tester-modems/tasks/main.yml | 45 ++++ ansible/roles/gsm-tester-network/README.md | 7 + ansible/roles/gsm-tester-network/defaults/main.yml | 3 + ansible/roles/gsm-tester-network/tasks/main.yml | 6 + .../gsm-tester-network/templates/interface.j2 | 56 +++++ ansible/roles/gsm-tester/defaults/main.yml | 7 + .../gsm-tester/files/dbus_osmo-gsm-tester.conf | 9 + .../files/osmo-gsm-tester_setcap_net_admin.sh | 2 + .../files/osmo-gsm-tester_setcap_net_raw.sh | 3 + ansible/roles/gsm-tester/tasks/main.yml | 244 +++++++++++++++++++++ .../gsm-tester/templates/quad_modem_power_cycle.sh | 16 ++ ansible/roles/install-coverity/README.md | 4 + ansible/roles/install-coverity/defaults/main.yml | 4 + ansible/roles/install-coverity/tasks/main.yml | 39 ++++ ansible/roles/install-poky-sdk/README.md | 10 + ansible/roles/install-poky-sdk/defaults/main.yml | 7 + ansible/roles/install-poky-sdk/tasks/main.yml | 42 ++++ ansible/roles/osmocom-jenkins-slave/README.md | 2 + .../roles/osmocom-jenkins-slave/defaults/main.yml | 8 + .../roles/osmocom-jenkins-slave/files/gitconfig | 3 + .../files/jenkins.osmocom.org.pub | 2 + .../roles/osmocom-jenkins-slave/tasks/debian.yml | 39 ++++ .../osmocom-jenkins-slave/tasks/generic-slave.yml | 15 ++ ansible/roles/osmocom-jenkins-slave/tasks/main.yml | 102 +++++++++ ansible/setup-gsm-tester.md | 21 ++ ansible/setup-gsm-tester.yml | 39 ++++ ansible/setup-jenkins-slave.yml | 35 +++ 34 files changed, 843 insertions(+) create mode 100644 ansible/.gitignore create mode 100644 ansible/files/README.md create mode 100644 ansible/hosts create mode 100644 ansible/roles/docker/README.md create mode 100644 ansible/roles/docker/defaults/main.yml create mode 100644 ansible/roles/docker/tasks/main.yml create mode 100644 ansible/roles/gsm-tester-modems/README.md create mode 100644 ansible/roles/gsm-tester-modems/tasks/main.yml create mode 100644 ansible/roles/gsm-tester-network/README.md create mode 100644 ansible/roles/gsm-tester-network/defaults/main.yml create mode 100644 ansible/roles/gsm-tester-network/tasks/main.yml create mode 100644 ansible/roles/gsm-tester-network/templates/interface.j2 create mode 100644 ansible/roles/gsm-tester/defaults/main.yml create mode 100644 ansible/roles/gsm-tester/files/dbus_osmo-gsm-tester.conf create mode 100644 ansible/roles/gsm-tester/files/osmo-gsm-tester_setcap_net_admin.sh create mode 100755 ansible/roles/gsm-tester/files/osmo-gsm-tester_setcap_net_raw.sh create mode 100644 ansible/roles/gsm-tester/tasks/main.yml create mode 100755 ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh create mode 100644 ansible/roles/install-coverity/README.md create mode 100644 ansible/roles/install-coverity/defaults/main.yml create mode 100644 ansible/roles/install-coverity/tasks/main.yml create mode 100644 ansible/roles/install-poky-sdk/README.md create mode 100644 ansible/roles/install-poky-sdk/defaults/main.yml create mode 100644 ansible/roles/install-poky-sdk/tasks/main.yml create mode 100644 ansible/roles/osmocom-jenkins-slave/README.md create mode 100644 ansible/roles/osmocom-jenkins-slave/defaults/main.yml create mode 100644 ansible/roles/osmocom-jenkins-slave/files/gitconfig create mode 100644 ansible/roles/osmocom-jenkins-slave/files/jenkins.osmocom.org.pub create mode 100644 ansible/roles/osmocom-jenkins-slave/tasks/debian.yml create mode 100644 ansible/roles/osmocom-jenkins-slave/tasks/generic-slave.yml create mode 100644 ansible/roles/osmocom-jenkins-slave/tasks/main.yml create mode 100644 ansible/setup-gsm-tester.md create mode 100644 ansible/setup-gsm-tester.yml create mode 100644 ansible/setup-jenkins-slave.yml hooks/post-receive -- CI scripts

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-209-g2338145d

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 2338145d5b4e27447bb9026c0bb8251a59d7c20d (commit) from e1a86748a2c7f6154644deee0477f629a86ca8ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=2338145d5b4e27447bb9026c0bb8… commit 2338145d5b4e27447bb9026c0bb8251a59d7c20d Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Thu Mar 15 19:38:15 2018 +0100 use gsm48_decode_lai2() in gsm0808_dec_cell_id_list() This makes gsm0808_dec_cell_id_list() properly decode 3-digit MNCs. Add a test which encodes/decodes a LAI_AND_LAC list with 3-digit MNCs. Change-Id: If6b941720de33dca66b6b1aa2cb95a3275708b7f Related: OS#2847 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm0808_utils.c | 15 +++++------- tests/gsm0808/gsm0808_test.c | 57 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+), 9 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

openbsc.git branch fixeria/milenage created. 1.0.0-24-gc5c84b690

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, fixeria/milenage has been created at c5c84b69021bc75ef905075056609ab233349859 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c5c84b69021bc75ef905075056609ab2… commit c5c84b69021bc75ef905075056609ab233349859 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 16 05:21:56 2018 +0700 libmsc/auth.c: add Milenage algorithm support Change-Id: I519e6bb4eb37a5ac70556d580a18fcae62730a76 http://cgit.osmocom.org/openbsc/commit/?id=068e11a51ff675d486976fef0b589a85… commit 068e11a51ff675d486976fef0b589a85fb0f8f4a Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 16 05:09:19 2018 +0700 libmsc/auth.c: use libosmogsm auth API Change-Id: I08dae631bcfc1bb3a4817084723e04a59c745329 http://cgit.osmocom.org/openbsc/commit/?id=83ad7e3ff6d0afc578a7eeb028134e3c… commit 83ad7e3ff6d0afc578a7eeb028134e3cc181c720 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 16 04:31:35 2018 +0700 libmsc/VTY: clean up the a3a8 command Change-Id: Ia21d4c97c30505e1826aa401c5da180dd2ba27d2 ----------------------------------------------------------------------- hooks/post-receive -- Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

6 years, 1 month

1
0
0 0

op25.git branch max updated. 4630e585649b45bb9171f55be3867d18333e5cc2

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software-defined analyzer for APCO P25". The branch, max has been updated via 4630e585649b45bb9171f55be3867d18333e5cc2 (commit) from c17443d9ac36f21b59a4f9392f94b1c1d3ded301 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/op25/commit/?id=4630e585649b45bb9171f55be3867d18333… commit 4630e585649b45bb9171f55be3867d18333e5cc2 Author: Max <ikj1234i(a)yahoo.com> Date: Thu Mar 15 14:43:57 2018 -0400 json trunking additions ----------------------------------------------------------------------- Summary of changes: op25/gr-op25_repeater/apps/terminal.py | 4 +- op25/gr-op25_repeater/apps/trunking.py | 83 +++++++------------------------ op25/gr-op25_repeater/apps/tsvfile.py | 91 ++++++++++++++++++++++++++++++++++ 3 files changed, 112 insertions(+), 66 deletions(-) create mode 100644 op25/gr-op25_repeater/apps/tsvfile.py hooks/post-receive -- Software-defined analyzer for APCO P25

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-208-ge1a86748

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via e1a86748a2c7f6154644deee0477f629a86ca8ec (commit) from 2873bf1f331dc07e6c92b4f6a0b45f26683a0f0b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=e1a86748a2c7f6154644deee0477… commit e1a86748a2c7f6154644deee0477f629a86ca8ec Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Thu Mar 15 18:05:02 2018 +0100 fix cell identifier decoding in libosmocore The cell ID list decoder merged in 11a4d9dd91216fe353e94bfdbbab53bc4f891c0d has a bug which was introduced part-way through the review process in gerrit at https://gerrit.osmocom.org/#/c/6509/ When Neels suggested "why not just {...}id_list[MAXLEN] once?" I changed the cell identifier list from a union of arrays to an array of unions. After this change, elements smaller than the largest type in the union were not laid out consecutively in memory anymore. E.g. uint16_t lac values now occur at offsets of sizeof(id_list[0]) instead of offsets of sizeof(uint16_t). The problem is that I forgot to adjust the decoder accordingly, so the decoder writes to the wrong offsets and returns cell identifier lists which appear to contain uninitialized values when read back by API consumers. I found this problem while adding new regression tests to libosmocore to test encoding and decoding. This commit adds one such tests for LAC list decoding, which failed due to the above bug. I plan to write more tests, however because this first test already uncovered a severe issue I chose to submit a fix now and work on additional tests in later commits. Change-Id: Ie1a5a9d858226be578cf11a03cf996d509bd51fb Related: OS#2847 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm0808_utils.c | 31 ++++++++++++++++--------------- tests/gsm0808/gsm0808_test.c | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 15 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

openbsc.git branch master updated. 1.0.0-21-g8469818e3

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 8469818e33ef81e9f707a0c4dd13d7b91ecf83f5 (commit) via c425351e74d162c0794828c0e9a1e8c15395cae2 (commit) from 4be40b4f1d2a82cfcd39881ac8a23577369353e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=8469818e33ef81e9f707a0c4dd13d7b9… commit 8469818e33ef81e9f707a0c4dd13d7b91ecf83f5 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Wed Mar 14 20:57:23 2018 +0100 Add support for Access Control Class ramping. Access Control Class (ACC) ramping is used to slowly make the cell available to an increasing number of MS. This avoids overload at startup time in cases where a lot of MS would discover the new cell and try to connect to it all at once. Ramping behaviour can be configured with new VTY commands: [no] access-control-class-ramping access-control-class-ramping-step-interval (<30-600>|dynamic) access-control-class-ramping-step-size (<1-10>) (The minimum and maximum values for these parameters are hard-coded, but could be changed if they are found to be inadequate.) The VTY command 'show bts' has been extended to display the current ACC ramping configuration. By default, ACC ramping is disabled. When enabled, the default behaviour is to enable one ACC per ramping step with a 'dynamic' step interval. This means the ramping interval (time between steps) is scaled to the channel load average of the BTS, i.e. the number of used vs. available channels measured over a certain amount of time. Below is an example of debug log output with ACC ramping enabled, while many 'mobile' programs are concurrently trying to connect to the network via an osmo-bts-virtual BTS. Initially, all ACCs are barred, and then only one class is allowed. Then the current BTS channel load average is consulted for scheduling the next ramping step. While the channel load average is low, ramping proceeds faster, and while it is is high, ramping proceeds slower: (bts=0) ACC RAMP: barring Access Control Class 0 (bts=0) ACC RAMP: barring Access Control Class 1 (bts=0) ACC RAMP: barring Access Control Class 2 (bts=0) ACC RAMP: barring Access Control Class 3 (bts=0) ACC RAMP: barring Access Control Class 4 (bts=0) ACC RAMP: barring Access Control Class 5 (bts=0) ACC RAMP: barring Access Control Class 6 (bts=0) ACC RAMP: barring Access Control Class 7 (bts=0) ACC RAMP: barring Access Control Class 8 (bts=0) ACC RAMP: barring Access Control Class 9 (bts=0) ACC RAMP: allowing Access Control Class 0 (bts=0) ACC RAMP: step interval set to 30 seconds based on 0% channel load average (bts=0) ACC RAMP: allowing Access Control Class 1 (bts=0) ACC RAMP: step interval set to 354 seconds based on 59% channel load average (bts=0) ACC RAMP: allowing Access Control Class 2 (bts=0) ACC RAMP: step interval set to 30 seconds based on 0% channel load average (bts=0) ACC RAMP: allowing Access Control Class 3 (bts=0) ACC RAMP: step interval set to 30 seconds based on 0% channel load average Port of osmo-bsc commit a5c1e8727c391bc56847a00b2ecc08787573b91f Change-Id: Idd5c4fd7ea2e10086d9b26deee3a71f9469d1280 Related: OS#2591 http://cgit.osmocom.org/openbsc/commit/?id=c425351e74d162c0794828c0e9a1e8c1… commit c425351e74d162c0794828c0e9a1e8c15395cae2 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Wed Mar 14 20:46:48 2018 +0100 Add stat items for the BTS's channel load average and T3122. In addition to logging the current values of a BTS's channel load average and T3122 override, maintain stat items for these values. This allows for plotting these values over time, for instance. These values show up in the VTY under 'show stats' like this: base transceiver station: Channel load average.: 25 % T3122 IMMEDIATE ASSIGNMENT REJECT wait indicator.: 32 s Port of osmo-bsc commit 4e9d40db2f86bfbd4d9c8bf9e3d9196f5ddf22c6 Change-Id: I766bd51f539dd96236b9c81d661e9d31f5027db4 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/Makefile.am | 1 + openbsc/include/openbsc/acc_ramp.h | 149 +++++++++++++++++++ openbsc/include/openbsc/gsm_data.h | 5 + openbsc/include/openbsc/gsm_data_shared.h | 8 + openbsc/src/libbsc/Makefile.am | 1 + openbsc/src/libbsc/acc_ramp.c | 236 ++++++++++++++++++++++++++++++ openbsc/src/libbsc/bsc_init.c | 15 +- openbsc/src/libbsc/bsc_vty.c | 113 ++++++++++++++ openbsc/src/libbsc/chan_alloc.c | 4 + openbsc/src/libbsc/system_information.c | 11 ++ openbsc/src/libcommon/gsm_data_shared.c | 21 ++- 11 files changed, 562 insertions(+), 2 deletions(-) create mode 100644 openbsc/include/openbsc/acc_ramp.h create mode 100644 openbsc/src/libbsc/acc_ramp.c hooks/post-receive -- Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-207-g2873bf1f

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 2873bf1f331dc07e6c92b4f6a0b45f26683a0f0b (commit) from 11a4d9dd91216fe353e94bfdbbab53bc4f891c0d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=2873bf1f331dc07e6c92b4f6a0b4… commit 2873bf1f331dc07e6c92b4f6a0b45f26683a0f0b Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Wed Mar 14 18:38:41 2018 +0100 fix a cell identifier parsing bug in libosmocore Global and LAI+LAC cell IDs were being misparsed due to an off-by-one. This code was incorrectly converted from osmo-bsc, where an additional offset of one byte was needed to skip the cell identifier field. In libosmocore, these parsing routines receive a buffer pointer which is already positioned at the start of the cell identifier field. Change-Id: I7f3e8ace26176e9cbfe2542961d2a95662aa4d97 Related: OS#2847 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsm0808_utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

osmo-trx.git branch master updated. 0.2.0-69-gc0c6d70

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via c0c6d70fe9d4122e6142b0a9785a44a7f3d0cf0d (commit) via 8c6c5d2bcd3f37e132b73a12e6a83cf07e15260f (commit) via a62fcf786a0484e55e98861d52e31a83353373d6 (commit) via 4d9b59c3efb269a6e2c9046ae3653f1c8fbdb3f6 (commit) via bd0efb0bea27b63a7dd9003dc36e4388978499b6 (commit) from 8fbbd656c76eecff1a99432f6f54272c3884bc84 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=c0c6d70fe9d4122e6142b0a9785a44a… commit c0c6d70fe9d4122e6142b0a9785a44a7f3d0cf0d Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 05:08:23 2018 +0700 Transceiver.cpp: prevent out-of-range array access There was no a simple range check for both (NO)HANDOVER commands, so an out-of-range access was possible. For example, a command: CMD HANDOVER 0 -3 might enable EDGE at run-time, because: a[i] == *(a + i) Let's fix this. Change-Id: I24a5f70e8e8097f218d7cbdef8cb10df2c35416f http://cgit.osmocom.org/osmo-trx/commit/?id=8c6c5d2bcd3f37e132b73a12e6a83cf… commit 8c6c5d2bcd3f37e132b73a12e6a83cf07e15260f Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 05:01:21 2018 +0700 Transceiver.cpp: fix incorrect format string for SETTSC Change-Id: If69a478121a31aa7df945548cc17271c476d6a6b http://cgit.osmocom.org/osmo-trx/commit/?id=a62fcf786a0484e55e98861d52e31a8… commit a62fcf786a0484e55e98861d52e31a83353373d6 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 03:24:08 2018 +0700 Transceiver.cpp: use pointer arithmetics for CMD parsing It looks like the author of control command parsing code was not familar with simple pointer arithmetics, so excessive amount of memory and useless memcopying was used to parse a single command. Let's introduce two pointers, one of which will point to the beginning of a command, another to the beginning of its arguments. Also, let's simplify the command matching by using a separate function called 'MATCH_CMD'. Change-Id: I226ca0771e63228cf5e04ef9766057d4107fdd11 http://cgit.osmocom.org/osmo-trx/commit/?id=4d9b59c3efb269a6e2c9046ae3653f1… commit 4d9b59c3efb269a6e2c9046ae3653f1c8fbdb3f6 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 02:54:45 2018 +0700 Transceiver.cpp: properly zero-terminate received commands Previously it was assumed that a sender should zero-terminate each command being sent. Otherwise, this could cause to printing garbage. Let's do this manually, using the length of received data as a position for '\0'. Change-Id: I69f413f33156c38a853efc5a8cdc66fbfb0ca6af http://cgit.osmocom.org/osmo-trx/commit/?id=bd0efb0bea27b63a7dd9003dc36e438… commit bd0efb0bea27b63a7dd9003dc36e4388978499b6 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 02:45:07 2018 +0700 Transceiver.cpp: use a define for the MAX_PACKET_LENGTH No need to keep this value on stack. Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7 ----------------------------------------------------------------------- Summary of changes: Transceiver52M/Transceiver.cpp | 151 +++++++++++++++++++++++------------------ 1 file changed, 86 insertions(+), 65 deletions(-) hooks/post-receive -- OpenBTS' transceiver retro-fit

6 years, 1 month

1
0
0 0

openbsc.git branch master updated. 1.0.0-19-g4be40b4f1

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 4be40b4f1d2a82cfcd39881ac8a23577369353e4 (commit) via 99805db3c30f5d9b1f6913407545a75ab41d7065 (commit) from 55d172617c2b6df3abdd430bf5751ddbd4420551 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4be40b4f1d2a82cfcd39881ac8a23577… commit 4be40b4f1d2a82cfcd39881ac8a23577369353e4 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Wed Mar 14 20:27:49 2018 +0100 bts chan_load: ignore unusable BTS For unconnected BTS, the channel load would report a "bogus channel load sample" every second (on RLL debug). Instead, skip unusable BTS. This follows up on commit 6cee893a0f2c4e53155a2631aff12a5f615b973d / I57e38f6d6ba3b23cc6e1f9520b90261dbb1f1cec 'Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.' Port of omo-bsc commit f802f7fd7aec1d91084231a80bbce6f2ed7bd299 Change-Id: Icd50d101244641a6ffdde17e60d7a89719225c65 http://cgit.osmocom.org/openbsc/commit/?id=99805db3c30f5d9b1f6913407545a75a… commit 99805db3c30f5d9b1f6913407545a75ab41d7065 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Wed Mar 14 20:15:24 2018 +0100 Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic. The IMMEDIATE ASSIGN REJECT message contains a wait indicator which tells an MS requesting a channel to wait for a specified amount of time before trying to request a channel again, i.e. the wait indicator controls the T3122 timeout value in the MS. Previously, the wait indicator was fixed to 10 seconds. This is not sufficient if there are a lot of MS requesting channels because the MS will retry too soon. Instead of using a fixed value, maintain a dynamic wait indicator value based on average channel load. The load (used vs. available channels on a BTS) is sampled once per second, and once 8 samples have been collected we update a BTS-specific T3122 wait indicator based on the measured load. While the wait indicator could go up to 255 seconds, this initial implementation keeps it in the range from 10 to 128 seconds. Further experimentation and testing will show whether higher wait indicator values are desirable, if the sampling rate needs to change, or if the function mapping the load measurement to a wait indicator value should change (currently we map the load average linearly into the range [10, 128] inclusive). Port of osmo-bsc commit 6cee893a0f2c4e53155a2631aff12a5f615b973d Change-Id: Id9df0e790ece8108212b2ddf718cf2953f5b9bd4 Related: OS#2592 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/chan_alloc.h | 6 +-- openbsc/include/openbsc/gsm_data.h | 3 ++ openbsc/include/openbsc/gsm_data_shared.h | 13 +++++ openbsc/src/libbsc/abis_rsl.c | 38 ++++++++------- openbsc/src/libbsc/bsc_init.c | 2 + openbsc/src/libbsc/bsc_vty.c | 2 +- openbsc/src/libbsc/chan_alloc.c | 80 +++++++++++++++++++++++++++++++ openbsc/src/libbsc/net_init.c | 24 ++++++++++ openbsc/src/libcommon/gsm_data_shared.c | 3 ++ openbsc/tests/channel/Makefile.am | 5 ++ openbsc/tests/channel/channel_test.c | 11 +++-- 11 files changed, 158 insertions(+), 29 deletions(-) hooks/post-receive -- Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

6 years, 1 month

1
0
0 0

osmocom-bb.git branch master updated. osmocon_v0.0.0-1903-gd49a748c

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, master has been updated via d49a748cbbf7d7b5bb77f3d906179da9b462e6d1 (commit) via a4d255269a7d4e58d2ec0fbb42483495b8c247c9 (commit) from 8b9d3170ff265c934f6271bd445ff5a6788ffffb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=d49a748cbbf7d7b5bb77f3d906179… commit d49a748cbbf7d7b5bb77f3d906179da9b462e6d1 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Thu Dec 14 04:03:59 2017 +0700 common/l1ctl.c move TCH bit-ordering to the firmware Previously, TCH frames coming from L1 were reordered to the RTP format. Moreover, the implementation had a few problems: - L1CTL is not the best place for such manipulations; - payloads with other than FR codec were corrupted. Let's use RTP-ordered payloads on the L1CTL interface, performing TCH frame reordering at the firmware. Please note, that actual FR reordering was moved to the firmware as is, without any codec determination. This could be fixed in a separate change. Change-Id: I81ec8ed3c9e72a62b22c1720c299cdc68b733cf1 http://cgit.osmocom.org/osmocom-bb/commit/?id=a4d255269a7d4e58d2ec0fbb42483… commit a4d255269a7d4e58d2ec0fbb42483495b8c247c9 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Sat Dec 16 17:52:31 2017 +0700 L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info Previously, the L1CTL_CRYPTO_REQ message contained only a ciphering algorithm and actual Kc key to be used. The key length was calculated manually using the MSGB API. Let's avoid manual calculations here, as it may cause unexpected behavior if the message structure is changed. Also, let's fill the UL header with minimal information about a channel, which is going to be encrypted. Change-Id: I5fab079907c5276322d3ec2b46cab81f10c7ed09 ----------------------------------------------------------------------- Summary of changes: include/l1ctl_proto.h | 1 + src/host/layer23/include/osmocom/bb/common/l1ctl.h | 4 +- src/host/layer23/src/common/l1ctl.c | 47 +++---------------- src/host/layer23/src/mobile/gsm48_rr.c | 12 +++-- src/target/firmware/Makefile | 3 +- src/target/firmware/layer1/l23_api.c | 5 +-- src/target/firmware/layer1/prim_tch.c | 52 ++++++++++++++++++++++ 7 files changed, 73 insertions(+), 51 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmo-bts.git branch master updated. 0.7.0-156-gfbf0eac

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via fbf0eac21b0acdbc35eb978b1edf77c2075c546e (commit) from 5b8889ce6b4661a14e79c6103fdd0eaf57a872b0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=fbf0eac21b0acdbc35eb978b1edf77c… commit fbf0eac21b0acdbc35eb978b1edf77c2075c546e Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Tue Mar 13 15:17:38 2018 +0700 common/main.c: track talloc NULL contexts by default In order to be able to introspect not only the root application context, but also all other contexts, e.g. allocated within libosmocore or other libraries, let's enable tracking the use of NULL contexts using the corresponding talloc API. In order to obserbe all existing contexts, use the following VTY command: OsmoBTS# show talloc-context all ... Example of usage: OsmoBTS# show talloc-context all brief talloc report on 'null_context' (total 1302808 bytes in 5185 blocks) lapd context contains 129 bytes in 5 blocks struct signal_handler contains 40 bytes in 1 blocks struct pcu_sock_state contains 120 bytes in 1 blocks struct lookup_helper contains 24 bytes in 1 blocks struct signal_handler contains 40 bytes in 1 blocks struct signal_handler contains 40 bytes in 1 blocks abis contains 49065 bytes in 19 blocks struct signal_handler contains 40 bytes in 1 blocks struct signal_handler contains 40 bytes in 1 blocks struct signal_handler contains 40 bytes in 1 blocks vty contains 93690 bytes in 5008 blocks logging contains 2862 bytes in 7 blocks OsmoBTS context contains 1156678 bytes in 137 blocks Change-Id: I5e9381902dace7dfd37f98b657e4697b5afcff96 ----------------------------------------------------------------------- Summary of changes: src/common/main.c | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

sdrangelove.git branch master updated. fcc6956cbd57457928332eae01a5ff518db24499

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Repository for OsmoSDR UI". The branch, master has been updated via fcc6956cbd57457928332eae01a5ff518db24499 (commit) from 64a1d97017aaa769d8181645cd198616fb2a105b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/sdrangelove/commit/?id=fcc6956cbd57457928332eae01a5… commit fcc6956cbd57457928332eae01a5ff518db24499 Author: Steve Markgraf <steve(a)steve-m.de> Date: Tue Mar 13 20:23:29 2018 +0100 fix build with GCC 7 Signed-off-by: Steve Markgraf <steve(a)steve-m.de> ----------------------------------------------------------------------- Summary of changes: CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) hooks/post-receive -- Repository for OsmoSDR UI

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-206-g11a4d9dd

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 11a4d9dd91216fe353e94bfdbbab53bc4f891c0d (commit) from b10ec0be5ffcd8759bb8b1461549a7eaf570bd9b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=11a4d9dd91216fe353e94bfdbbab… commit 11a4d9dd91216fe353e94bfdbbab53bc4f891c0d Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Thu Feb 15 18:28:04 2018 +0100 support for more cell ID list types in libosmocore Introduce gsm0808_dec_cell_id_list2() with supports additional types of cell identifier lists. The new parsing routines are based on similar routines used by the paging code in osmo-bsc's osmo_bsc_bssap.c. Likewise, introduce gsm0808_enc_cell_id_list2() with support for the same additional types of cell identifier lists. The old API using struct gsm0808_cell_id_list is deprecated. The previous definition was insufficient because it assumed that all decoded cell ID types could be represented with a single uint16_t. It was declared in a GSM protocol header (gsm/protocol/gsm_08_08.h) despite being a host-side representation of data in an IE. The only user I am aware of is in osmo-msc, where this struct is used for one local variable. osmo-msc releases >= 1.1.0 make use of this API. While here, fix a small bug in a test: test_gsm0808_enc_dec_cell_id_list_bss() set the cell ID type to 'LAC' but obviously wants to use type 'BSS'. Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb Related: OS#2847 ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/gsm0808.h | 7 +- include/osmocom/gsm/gsm0808_utils.h | 29 +++- include/osmocom/gsm/gsm23003.h | 7 + include/osmocom/gsm/protocol/gsm_08_08.h | 7 +- src/gsm/gsm0808.c | 36 ++++- src/gsm/gsm0808_utils.c | 258 +++++++++++++++++++++++++++++++ src/gsm/libosmogsm.map | 3 + tests/gsm0808/gsm0808_test.c | 47 +++--- 8 files changed, 360 insertions(+), 34 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

osmo-trx.git branch master updated. 0.2.0-64-g8fbbd65

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, master has been updated via 8fbbd656c76eecff1a99432f6f54272c3884bc84 (commit) via b35cba613ab2295ec99c897c9a80660ac2738491 (commit) from 8dffadb8da92e7b0af97362936a117ebfbd9323d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-trx/commit/?id=8fbbd656c76eecff1a99432f6f54272… commit 8fbbd656c76eecff1a99432f6f54272c3884bc84 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Wed Mar 7 20:21:06 2018 +0100 Build Transceiver52M/common as an .la lib Stop picking files from that directory on different places as it causes dependency issues during make distclean/maintainer-clean. Fixes: OS#3029 Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b http://cgit.osmocom.org/osmo-trx/commit/?id=b35cba613ab2295ec99c897c9a80660… commit b35cba613ab2295ec99c897c9a80660ac2738491 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Wed Mar 7 14:39:26 2018 +0100 Makefile.am: Avoid using subdir if arch is not required There's no need in going a level deeper if we already know nothing's going to be done. This way we also get cleaner make outputs. Reference: https://www.gnu.org/software/automake/manual/html_node/Conditional-Subdirec… Related: OS#3029 Change-Id: I3ff57ab14edc575904e8137929a0ef02c95e03af ----------------------------------------------------------------------- Summary of changes: Transceiver52M/Makefile.am | 17 ++++++++--------- Transceiver52M/arm/Makefile.am | 5 ++--- Transceiver52M/common/Makefile.am | 15 +++++++++++++++ Transceiver52M/x86/Makefile.am | 6 +----- configure.ac | 1 + 5 files changed, 27 insertions(+), 17 deletions(-) create mode 100644 Transceiver52M/common/Makefile.am hooks/post-receive -- OpenBTS' transceiver retro-fit

6 years, 1 month

1
0
0 0

libosmocore.git branch neels/inter_bsc_ho created. 0.10.2-207-g780971e9

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/inter_bsc_ho has been created at 780971e9fb9654ebee53d6044cc6c7eee09011eb (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=780971e9fb9654ebee53d6044cc6… commit 780971e9fb9654ebee53d6044cc6c7eee09011eb Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Tue Mar 13 03:40:53 2018 +0100 add support for gsm0808 HANDOVER REQUIRED message Change-Id: Idb6dc3eab0282158a17091d97ed77c1e2e3eb3c2 http://cgit.osmocom.org/libosmocore/commit/?id=d97bcebd64b604efbe8502a81fb2… commit d97bcebd64b604efbe8502a81fb2fc504903b4a9 Author: Stefan Sperling <ssperling(a)sysmocom.de> Date: Thu Feb 15 18:28:04 2018 +0100 support for more cell ID list types in libosmocore Introduce gsm0808_dec_cell_id_list2() with supports additional types of cell identifier lists. The new parsing routines are based on similar routines used by the paging code in osmo-bsc's osmo_bsc_bssap.c. Likewise, introduce gsm0808_enc_cell_id_list2() with support for the same additional types of cell identifier lists. The old API using struct gsm0808_cell_id_list is deprecated. The previous definition was insufficient because it assumed that all decoded cell ID types could be represented with a single uint16_t. It was declared in a GSM protocol header (gsm/protocol/gsm_08_08.h) despite being a host-side representation of data in an IE. The only user I am aware of is in osmo-msc, where this struct is used for one local variable. osmo-msc releases >= 1.1.0 make use of this API. While here, fix a small bug in a test: test_gsm0808_enc_dec_cell_id_list_bss() set the cell ID type to 'LAC' but obviously wants to use type 'BSS'. Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb Related: OS#2847 ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

osmo-pcu.git branch master updated. 0.4.0-101-g5a59194

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 5a5919435ef85933456b50dc32f3c92802730efa (commit) from bdc55fad62e333951a0eb1fc7b96aaaec16dd6ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=5a5919435ef85933456b50dc32f3c92… commit 5a5919435ef85933456b50dc32f3c92802730efa Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:44:11 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: I0f735913fc3bbda695c4e66449dcfc94f417dafb ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) hooks/post-receive -- UNNAMED PROJECT

6 years, 1 month

1
0
0 0

osmo-iuh.git branch master updated. 0.2.0-56-g666121a

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via 666121a9d971bc2c94b4418db22f767eace28271 (commit) from 3050864b7360cc7a168a850f7a1d839a805c54a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=666121a9d971bc2c94b4418db22f767… commit 666121a9d971bc2c94b4418db22f767eace28271 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:43:10 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Id659512d2d9fb3f28584ec5f071907f6b6e72e0d ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) hooks/post-receive -- Osmocom code for Iuh interface

6 years, 1 month

1
0
0 0

osmo-hlr.git branch master updated. 0.1.0-33-g70e7f21

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via 70e7f21cb1748dbc766361d139d8854f7f63ceb0 (commit) via 2e78858756015fbacb059d2d43532f2c41e32255 (commit) from 3f2a9a2ab1cf3c4059ed8a5f81c969375a1c2627 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-hlr/commit/?id=70e7f21cb1748dbc766361d139d8854… commit 70e7f21cb1748dbc766361d139d8854f7f63ceb0 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:54:54 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I5fe776cf9ccb5d462c3c1fbbb1e31abe6f42bde6 http://cgit.osmocom.org/osmo-hlr/commit/?id=2e78858756015fbacb059d2d43532f2… commit 2e78858756015fbacb059d2d43532f2c41e32255 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:42:57 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Id5c0740a37067cbe8986d52d63c6134769c71c47 ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ contrib/jenkins.sh | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT

6 years, 1 month

1
0
0 0

osmo-ggsn.git branch master updated. 1.1.0-77-g9f98822

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenGGSN project". The branch, master has been updated via 9f9882225524138d87721aafadaa59f02e0da001 (commit) via fc8357a2db96a89c8e12588d370dd7e8b1d14ac8 (commit) from 3e443ca502f82b7c2ce453143866e5f2ed82a91f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ggsn/commit/?id=9f9882225524138d87721aafadaa59… commit 9f9882225524138d87721aafadaa59f02e0da001 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:53:20 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I64e542ad4da34a7ac3bc1b599a122ecff47e892d http://cgit.osmocom.org/osmo-ggsn/commit/?id=fc8357a2db96a89c8e12588d370dd7… commit fc8357a2db96a89c8e12588d370dd7e8b1d14ac8 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:42:45 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Ifcde5a110cbed0eaa250dd946927e3b0f4f9bd13 ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ contrib/jenkins.sh | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenGGSN project

6 years, 1 month

1
0
0 0

osmo-bts.git branch master updated. 0.7.0-155-g5b8889c

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 5b8889ce6b4661a14e79c6103fdd0eaf57a872b0 (commit) from 7d648b46579a557bd6bd96fceaf2f8c53b10cb1b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=5b8889ce6b4661a14e79c6103fdd0ea… commit 5b8889ce6b4661a14e79c6103fdd0eaf57a872b0 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:42:31 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: I5b37602a117350159183fb53ac330294b94f4195 ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

libsmpp34.git branch master updated. 1.12.0-19-g0cad3b4

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom fork of the Open SMPP 3.4 library". The branch, master has been updated via 0cad3b4538710a91881ddbb80424c2d7c62de962 (commit) via 7fb2a408d78857de581d32d32990be833702b854 (commit) from 8f7946f30a95a45c04ca5eb58650b9b6ec4d7f8e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libsmpp34/commit/?id=0cad3b4538710a91881ddbb80424c2… commit 0cad3b4538710a91881ddbb80424c2d7c62de962 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:52:50 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: Ib09a4aa3167e5dc24d02e3e59307baa6f7ee3f2c http://cgit.osmocom.org/libsmpp34/commit/?id=7fb2a408d78857de581d32d32990be… commit 7fb2a408d78857de581d32d32990be833702b854 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:41:40 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: I5280a692eaf8f626523e0fd929d1febaa2859104 ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ contrib/jenkins.sh | 4 ++-- 2 files changed, 23 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom fork of the Open SMPP 3.4 library

6 years, 1 month

1
0
0 0

libosmocore.git branch master updated. 0.10.2-205-gb10ec0be

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via b10ec0be5ffcd8759bb8b1461549a7eaf570bd9b (commit) via 09ecbb76745b4189f07e339131c1df4f46a03531 (commit) from 10959cdea2104a6e8c592d590d5b6acf656eb630 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=b10ec0be5ffcd8759bb8b1461549… commit b10ec0be5ffcd8759bb8b1461549a7eaf570bd9b Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:51:49 2018 +0100 jenkins_amd64.sh: use --enable-werror configure flag, not CFLAGS Note that the jenkins_arm.sh passes various CFLAGS and potentially overwrites ./configure internal CFLAGS like that. I'm staying out of that for now. Change-Id: I81b50c39cd6e908c4c95651829b679425de87a28 http://cgit.osmocom.org/libosmocore/commit/?id=09ecbb76745b4189f07e339131c1… commit 09ecbb76745b4189f07e339131c1df4f46a03531 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:40:05 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Ic5c8e68b64cd890b3309b4b26c7f22bde1edba83 ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ contrib/jenkins_amd64.sh | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

6 years, 1 month

1
0
0 0

libosmo-sccp.git branch master updated. 0.8.1-41-g58fcc53

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SCCP Library". The branch, master has been updated via 58fcc5344ea0e914c7f9be69c309998d243142bd (commit) via 2d5026b92b98f72b03254e42823983ba0da1e319 (commit) from 3137be99ef2e75bd5bdd616a6c435513a64125ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-sccp/commit/?id=58fcc5344ea0e914c7f9be69c30… commit 58fcc5344ea0e914c7f9be69c309998d243142bd Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:51:22 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I5c3f11586d48a076479eb19ed80a11caad4251d8 http://cgit.osmocom.org/libosmo-sccp/commit/?id=2d5026b92b98f72b03254e42823… commit 2d5026b92b98f72b03254e42823983ba0da1e319 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:39:36 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Idb579d546d6f228e86bd49ca15aa87b86978205a ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ contrib/jenkins.sh | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- SCCP Library

6 years, 1 month

1
0
0 0

libosmo-netif.git branch master updated. 0.1.1-17-g9d726d0

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via 9d726d0e56665b4439bb4efe782be06be2e83ffb (commit) via 9f4a9232e791e60ca93a3a79f03efd8ca01cec9c (commit) from ce439fc945afbefb9f1762cb6a4ee1b74cbd8ae7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=9d726d0e56665b4439bb4efe78… commit 9d726d0e56665b4439bb4efe782be06be2e83ffb Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:51:03 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I739f4562a96b7b6031075d47d94f46af7a37b4b4 http://cgit.osmocom.org/libosmo-netif/commit/?id=9f4a9232e791e60ca93a3a79f0… commit 9f4a9232e791e60ca93a3a79f03efd8ca01cec9c Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:38:57 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: I68e4781ec5dfaf1dac46510a092a87e35691f082 ----------------------------------------------------------------------- Summary of changes: configure.ac | 18 ++++++++++++++++++ contrib/jenkins.sh | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom network interface library

6 years, 1 month

1
0
0 0

libosmo-abis.git branch master updated. 0.4.0-16-gd3b8b69

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via d3b8b69977207235056f6033e5828796e5620049 (commit) via bb83e6f7eb7fa3910586a182ed93d69a850e3e21 (commit) from 61460fd6431d6ea62752d74ad05425f132d7abbe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=d3b8b69977207235056f6033e58… commit d3b8b69977207235056f6033e5828796e5620049 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:50:38 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I487ab6f2e391aa57404725de2c8ab5447ca9f725 http://cgit.osmocom.org/libosmo-abis/commit/?id=bb83e6f7eb7fa3910586a182ed9… commit bb83e6f7eb7fa3910586a182ed93d69a850e3e21 Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:37:13 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: I20d5f18cf05c9e277d914ada259a95187b73fe39 ----------------------------------------------------------------------- Summary of changes: configure.ac | 20 ++++++++++++++++++++ contrib/jenkins.sh | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom A-bis protcol interface library

6 years, 1 month

1
0
0 0

libasn1c.git branch master updated. 0.9.28-7-g202022e

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "asn1c runtime code as shared library". The branch, master has been updated via 202022eaa9c36d1209cf024830b99d7d2463663e (commit) via 6e152f258226ddc5233fbb8c4f9e222fc90a161d (commit) from bd2173796d90db181c22034e4acbe391d2cb57ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libasn1c/commit/?id=202022eaa9c36d1209cf024830b99d7… commit 202022eaa9c36d1209cf024830b99d7d2463663e Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 20:50:26 2018 +0100 jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id: I4791c6a32d983869692df36172f93adee819debb http://cgit.osmocom.org/libasn1c/commit/?id=6e152f258226ddc5233fbb8c4f9e222… commit 6e152f258226ddc5233fbb8c4f9e222fc90a161d Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Mon Mar 5 19:46:44 2018 +0100 configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"', but that actually *overwrites* all the other CFLAGS we might want to have set. Maintain these exceptions from -Werror: a) deprecation (allow upstream to mark deprecation without breaking builds); b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) As a last configure step before generating the output files, print the complete CFLAGS and CPPFLAGS by means of AC_MSG_RESULT. Change-Id: Ibcc8238584a585434b39a046cd2d7e18ddaf7f8c ----------------------------------------------------------------------- Summary of changes: configure.ac | 21 +++++++++++++++++++++ contrib/jenkins.sh | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) hooks/post-receive -- asn1c runtime code as shared library

6 years, 1 month

1
0
0 0

osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-2066-g23914b9c

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via 23914b9cf855de8e847d450c70494626da2216e6 (commit) via c08ddc73838b08f9538a966d6ad8f9f8bc856cf9 (commit) from 4ccb2261b1ac2e207303393fe509878f160dd96b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=23914b9cf855de8e847d450c70494… commit 23914b9cf855de8e847d450c70494626da2216e6 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Tue Mar 13 01:09:56 2018 +0700 Rename 'fake_trx' to 'trx_toolkit' This toolkit has branched out into several different tools for TRX interface hacking, and creating a virtual Um-interface (FakeTRX) is only one of its potential applications. Change-Id: I56bcbc76b9c273d6b469a2bb68ddc46f3980e835 http://cgit.osmocom.org/osmocom-bb/commit/?id=c08ddc73838b08f9538a966d6ad8f… commit c08ddc73838b08f9538a966d6ad8f9f8bc856cf9 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Mon Mar 12 20:48:24 2018 +0700 fake_trx: unify the GPL license header There is no need to manually put the license header as a variable in each application in order to print it. Let's use a common one. Change-Id: I1a6e8716a9069e7ade3ae15f2c04fd45d18e223c ----------------------------------------------------------------------- Summary of changes: src/target/{fake_trx => trx_toolkit}/.gitignore | 0 src/target/{fake_trx => trx_toolkit}/README | 11 +++-------- src/target/{fake_trx => trx_toolkit}/burst_fwd.py | 2 +- src/target/{fake_trx => trx_toolkit}/burst_gen.py | 16 +++++----------- src/target/{fake_trx => trx_toolkit}/burst_send.py | 16 +++++----------- src/target/{fake_trx => trx_toolkit}/clck_gen.py | 20 ++++++++------------ src/target/trx_toolkit/copyright.py | 13 +++++++++++++ src/target/{fake_trx => trx_toolkit}/ctrl_cmd.py | 13 +++++-------- src/target/{fake_trx => trx_toolkit}/ctrl_if.py | 2 +- src/target/{fake_trx => trx_toolkit}/ctrl_if_bb.py | 2 +- src/target/{fake_trx => trx_toolkit}/ctrl_if_bts.py | 2 +- src/target/{fake_trx => trx_toolkit}/data_dump.py | 0 src/target/{fake_trx => trx_toolkit}/data_if.py | 2 +- src/target/{fake_trx => trx_toolkit}/data_msg.py | 2 +- src/target/{fake_trx => trx_toolkit}/fake_pm.py | 2 +- src/target/{fake_trx => trx_toolkit}/fake_trx.py | 19 ++++++------------- src/target/{fake_trx => trx_toolkit}/gsm_shared.py | 2 +- .../{fake_trx => trx_toolkit}/rand_burst_gen.py | 2 +- src/target/{fake_trx => trx_toolkit}/trx_sniff.py | 13 +++++-------- src/target/{fake_trx => trx_toolkit}/udp_link.py | 2 +- 20 files changed, 60 insertions(+), 81 deletions(-) rename src/target/{fake_trx => trx_toolkit}/.gitignore (100%) rename src/target/{fake_trx => trx_toolkit}/README (71%) rename src/target/{fake_trx => trx_toolkit}/burst_fwd.py (99%) rename src/target/{fake_trx => trx_toolkit}/burst_gen.py (94%) rename src/target/{fake_trx => trx_toolkit}/burst_send.py (93%) rename src/target/{fake_trx => trx_toolkit}/clck_gen.py (86%) create mode 100644 src/target/trx_toolkit/copyright.py rename src/target/{fake_trx => trx_toolkit}/ctrl_cmd.py (91%) rename src/target/{fake_trx => trx_toolkit}/ctrl_if.py (98%) rename src/target/{fake_trx => trx_toolkit}/ctrl_if_bb.py (99%) rename src/target/{fake_trx => trx_toolkit}/ctrl_if_bts.py (98%) rename src/target/{fake_trx => trx_toolkit}/data_dump.py (100%) rename src/target/{fake_trx => trx_toolkit}/data_if.py (96%) rename src/target/{fake_trx => trx_toolkit}/data_msg.py (99%) rename src/target/{fake_trx => trx_toolkit}/fake_pm.py (97%) rename src/target/{fake_trx => trx_toolkit}/fake_trx.py (93%) rename src/target/{fake_trx => trx_toolkit}/gsm_shared.py (96%) rename src/target/{fake_trx => trx_toolkit}/rand_burst_gen.py (98%) rename src/target/{fake_trx => trx_toolkit}/trx_sniff.py (95%) rename src/target/{fake_trx => trx_toolkit}/udp_link.py (97%) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

openbsc.git branch master updated. 1.0.0-17-g55d172617

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 55d172617c2b6df3abdd430bf5751ddbd4420551 (commit) from 14cd21417f8774a92900cb707064d650ea769615 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=55d172617c2b6df3abdd430bf5751ddb… commit 55d172617c2b6df3abdd430bf5751ddbd4420551 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Mar 12 00:24:22 2018 +0100 sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6 Fixes a regression in the code generating SI5* and SI6 on SACCH, where the L2 pseudo-length is not part of the 'struct' definition we have in gsm_04_08.h and hence has to be encoded manually into the first byte of the SI buffer. We were doing this correctly until April 2017, when the following patch was merged: > commit 6f0e50c8337355eb59033903ede9ab6528890835 > Author: Max <msuraev(a)sysmocom.de> > Date: Wed Apr 12 15:30:54 2017 +0200 > > Prepare for extended SI2quater support This patch cacidentially overwrote the l2_plen that was just enoded, as the 'struct' was no longer pointing to 'output' (si_buf+1), but now directly to the start of the si_buf. NOTE: The Wireshark RSL dissector (and more recently also LAPDm) contain a similar bug, so the SACCH will not be decoded correctly after applying this patch. Nevertheless, it's correct. back-port of OsmoBSC Change-Id: Ie8c907b1317566670aeb68f933ceefd552c17565 Closes: #3059 Related: #2963 Change-Id: Iaf5feefc1bb3194dd491955fee418795c61787f7 ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/system_information.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- Legacy: The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

6 years, 1 month

1
0
0 0

wireshark.git branch laforge/pending updated. 1ed88ce36dd9a7e0dc07d04cb2836f9b8ea4a304

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "wireshark with Osmocom specific dissectors". The branch, laforge/pending has been updated discards c75d41451966d864ab722c4f31a018a2c55bd526 (commit) discards ec80140b6bcc53275611773ef584545a14e66df6 (commit) discards 65e07b4809ba4133634739ed00ade8744660a87c (commit) discards e11e253268826d0b9cde4f0e45ecc041f6f6f525 (commit) discards 292f117299f972630651f46a7ddb73c843a5f65f (commit) discards 85d9379b0b984b820c164b6425266bccef13bbf4 (commit) discards e80122498eba10ac5de986b52d71580b8fe1ff03 (commit) discards 445aeb71627197eb769aca9e28c5ffa6a528c43c (commit) via 1ed88ce36dd9a7e0dc07d04cb2836f9b8ea4a304 (commit) via 5b13126fd99b8917d6e6c59a6807cdd8fbf4a54e (commit) via b50500b542630a695d370fb215ecbfde9bbb9ef1 (commit) via 7d1d6f24d2c40c885761deb31a2c066758eecf81 (commit) via b21bcb2b69c1f641cb8241da34b5f12752efdec4 (commit) via a7cf245eb515c546e57037f37535d76c13d2afdc (commit) via 57af17e3ee6bb08a608e99f8e0ecdea5265512a1 (commit) via 07f2f909746821f86b3de87d4c1897caca1c3ea5 (commit) via 6e75a0b2774401fb184fc92db779aa6defab10aa (commit) via ba179a7ef7e660d788cbaade65982ffc7249b91f (commit) via 7e842fa5514c79046d7d1986b0b379c3d4f9ce2c (commit) via f2f7f7e5577dee645ae52b36a0795934624c24eb (commit) via 68efae8588dc88254e5b0ee2a4009012be332381 (commit) via 2a3b58d1333df1d505c4947c22b2388d5491b689 (commit) via 85c4d2f583d6a84047fca40ed39d9129ab4ffca7 (commit) via 55573495c83e21ed41f94ceb57c13da3f99ad599 (commit) via cbe424b27dbcf51c9d5c6c35ec927ecf4e60a25a (commit) via 45366965071840698a3fa11aace1d8eadae1802c (commit) via fc6b725b18d9d627534c3b61720f5be93315ce09 (commit) via 3ceff6751471edc205894f8f2b6d050f3a803502 (commit) via 2a9097046e51d67794780bb57e94229e769fc01b (commit) via ab7fbb73951716ee08406fc1a51fc522da2c420d (commit) via 2ecb33c039d75d851bb4fc4e72c8f8a389c9ab55 (commit) via 6a819d9950e41244b742073f0962e2c5a80eb735 (commit) via 5564c222e27740166ec36f0cc1e858bcb429f68c (commit) via aae6b8442cca8373d77980144b1421474fee5c3d (commit) via 957b4a67efe716c31a8a54453ed62f02738ff984 (commit) via b9f203c1da43ba0e11bf8e1c6cc4c74e60f49402 (commit) via b8375119e39bebed34344cf1a6953af1532d2b62 (commit) via dcc3875847d691776affae66dcfdb2ccfa5674e7 (commit) via 5213c30f3b27c0e501ca7543dfae948651da6277 (commit) via 986c6b2e77b5493d5b718febab4e9086afbee12f (commit) via 28da001090d3de12f30f4f5392338e10c3972d20 (commit) via 66a1fefac416136b96b7a1683293d6a06f5c00e8 (commit) via 190b2e89c3767b3a5b87afc58d45d58d5d848f27 (commit) via 5a4468ccafed43749a48a839ce227e030304745b (commit) via 8acf0305a3bdb6ee3b37c5a9b6f5cb3e342abe20 (commit) via c2639090de67e0100653741680b70f2ae17a3fa4 (commit) via 6c077a081870653268331a848f2543778d372028 (commit) via a395a8b9939bd48858efbd3da5897a59d4697eba (commit) via 02085c80ab10507f6a75d75fe1e43facade98a0e (commit) via b91f7f1a0cf014d1f838595d85161a13ebe157b2 (commit) via 66eed04afe08bf9120cf22d1885191c281086325 (commit) via cc795d4ddfaca382bcd0e6b4862a432eddd06f54 (commit) via 1ac90d5254e9e303196c100039b7dd26d23841d1 (commit) via 446d9486ae897692fb3e02e90501e38790ac37c8 (commit) via fe2355e061845902400ab5e1447a936e727972a5 (commit) via ce07a363378acdf838ee2bedae82a955c9a6fdd5 (commit) via 4e6d989df43af78439fccd24a176a14c534aea99 (commit) via 572f78a8610282151e7d165b11e0bf5092efbb5a (commit) via 4495d8fbfdc680b37671f8139664463e84b7e0bf (commit) via c9cb93acfc230cad1d0c27a8454645c079f4ac9e (commit) via e7ab7a907c16be8eabb426958b459aefc0631549 (commit) via fdd426e410325db3f33a16f77739f8f73575af2c (commit) via 0ae769adc10a97dfd2114d747094881ca7870b87 (commit) via ea754b6761116133b506b782c079793d37d744a6 (commit) via 7ffc4f96ebe2fac503cb251a848441ad8d4bad8c (commit) via 6e32335be61851592d8158772b743c55ae132eb9 (commit) via 5f35b041c2d731297cdd4d780d029743fd49b9b4 (commit) via dbfd53cd60ed9f748b25a293a36893ee828f89d4 (commit) via ce46a023cf233b376107f46709f7b2a42a0c3c3f (commit) via 32365383a9f13c2da6dfe1aff6de891b95ca4a50 (commit) via 5c25e1b2c1e986df36ea95047a891e1d54070694 (commit) via b91ef7da5168143ff558785b6bc04a68f72b19ec (commit) via 7ddfccec199f21bb9d9f23ff99e663299371a395 (commit) via 6a62e2d22d5f83455aba2b619714409983498fc8 (commit) via c4d2ad476d09029255669319eb2931727adce597 (commit) via e5de1f199499219b297d581d60546f2c5b51a87a (commit) via 3905c0d5d5532d10fa79b0481c9ce01e6752983d (commit) via 8a677354bd14eb1cff01c01bc9a303c502074d56 (commit) via 241b274b5f8e6f7e3ea22f7598a271f48ccd3191 (commit) via 695fbb9be0122e280755c11b9e0b89e9e256875b (commit) via e7cf995b1e0a9b434782adf0e2ee40bfb721aac2 (commit) via e5cc633ee49823ac56350fd57fea3e54717d85f7 (commit) via 957845f5a4ed8919164dfd469890732b65b40831 (commit) via 39a65995ccaa45322b7ee870fe21a0daa6157242 (commit) via eefa76a7c810bd74d95d571362f0ad5fda691e70 (commit) via cc45082635c9cfed0112727b1b10a0f863bce13c (commit) via fbb042336af42635eedabd7f1bb2eb5c6bd35d5f (commit) via a3e1967d8e6e3825c341cd39c48f31a5bc8cbe24 (commit) via e1790da88cb02dcc0764e58cc8b67afe9d8543a1 (commit) via 1592587e6f9fd8c8aa8fc7f67989690d0c6882c4 (commit) via 7dd7a05d480226736696aed4a6530b0e84526aea (commit) via 3132a504489944b41522125f8e7aaba8ae50a66f (commit) via 692cef88c7f68af53e9487e3e2264de8d98b230b (commit) via 5375283f9294d444fcda14df74fed77160bf1d1d (commit) via 4f36a28acbc06781740cf4105375ae7759b6606b (commit) via fe71e26af27a01173f3029a7d848b9ba65a0defb (commit) via 71f36379aef2ff9fcf092619011f02f68ce9d3b2 (commit) via 8a5385b9c9ec4ccfd692263eb7c59b09f9bc1a15 (commit) via 830adb2a02c3ef5209bf79c933879b49b12b7902 (commit) via 3a54fd1d7d5d0ee1635e7100635ad3cad0ffbcd1 (commit) via f7897365213111fa86fa940ddea6c3e191b0b429 (commit) via 9a5217bdd4680e36f2e92838348bd4ea010d28a0 (commit) via 37723968d2b37c52f5809398b85adffdc815ce9d (commit) via 6db59affd9c9b20f2ce725cd2ce7a88c71982a07 (commit) via 8a5cd7a5c67cdca5eed91ec6a36ba310772e795f (commit) via 99a329891dca9e1e033313aad2a8445e2d5206af (commit) via f38e895dfc0d97bce64f73ce99df706911d9aa07 (commit) via 68216fa2da7bf608441356593a5059913c7e1a97 (commit) via b94d3af3039b8bdfbd4d760fda412fdfa121b732 (commit) via 035f49d2c85ff9e0bab74e5af4c990ab2beea170 (commit) via 8f81eb2cf671573461ccba3bde6ce5ec99016afa (commit) via 89a715eba45d89bd65ee9a190bb1300ac6ea6fd4 (commit) via 05c4705a19448646ca316ba3b1eb333a05482956 (commit) via 4581eb2de2e5aacfc9a2224df181010dc8e6141b (commit) via bf4e620e2d15689e8582425224160f39dcc8589c (commit) via 4945c50d3f8269c56d9d087d16d080144de146dc (commit) via cc764b92acc65f7727fc53180a09ba2088a8751b (commit) via 1b18b1dd0e171ec660ad1ce5d47bab80ddc3da86 (commit) via f46d129f21ee0c2b43545c500a8ea4dbc4d59815 (commit) via fd62e506b93cb2d9d7d77d7282e522532c70025b (commit) via e3c263c01236e7c31ec23f6c3d8750d7e92fb5a3 (commit) via f0fb6ee50c953ac07eb76d47036a761a57f35491 (commit) via 0ddaec13a162c01928e310c4f92532cdb70d45c0 (commit) via 98ab887a2d4ffbe7b255655c510b676c32e93608 (commit) via 76267f4bc5d8c62eaf72af6a8a2fbadeb75730c2 (commit) via f0f4adc9d9962376b545a72f5448be8f51676725 (commit) via b0b87e4b5f8dbdd69c515d63fa4413347179beb4 (commit) via 99240e62bfad757cd50ac0fc38ce6e75ea3debc0 (commit) via f52bb2bf27cc55285398bbf6acb1884b10b8d3a4 (commit) via 2eb6f3b5de46bb4d52775df919e2a55a3f606d9c (commit) via a1da75c554881667dd92e11f098630f2d604872b (commit) via b2d3680558d19998c55b48e9807a26e145756eba (commit) via 69ddfecb7605683ddb194a9d0e19dedeffbd4a08 (commit) via 186714314d546c2155cb0942724e8bafb9bd879f (commit) via 063277032130721ab9513b3525b24914db41ca7a (commit) via 4d3721b1db229b985d6f45b5bd0813a6ab5a63d1 (commit) via 0d9d69a1e639ece0ad3218851771d662e2528d45 (commit) via b434e0a03be45ed796af7271972672a0b43cffa8 (commit) via c39dbd68d472046cf97211c86267e0305630d934 (commit) via 60f2c8e5885f48cd8e884ea2edefec17f539acbc (commit) via c4f224c092c470bd1d8a1f4a0d6a28c24af87b2d (commit) via dd21b8130c6470d2d5076fcc46d5e9c3866f4609 (commit) via cde7cc54a33659222ee8ee05d346918da45e4c82 (commit) via df83de9b6442e02047ca9c68d55cfc314788f00e (commit) via 6bb0d8b7ff64ef7f6afba1a03cac6a4894a5db64 (commit) via b99b9b81dd436826128dc6dbaf5d9796bbe261ab (commit) via 5e03b4e3427e1c49241f14fa51daea82aa0acb2b (commit) via 5a05aa238ca69adfffcad21c755464bafa24249f (commit) via cf373df7963d9ed6afee8285e2e1633ff6f7d93f (commit) via 5b079291c41ae4f8abe7a33fa7b886ae0a314a30 (commit) via c37eeafe8100624fb0c315ac607db32f7ad2c941 (commit) via 0fcfc634ddf7b54ca1352eb7413f93aedc2b54df (commit) via 177962a5b4a05759b40fb6fc07a4a6eec306a9bf (commit) via b70eb189bb906d0b03ca95219a4c9c82eee43f97 (commit) via 4630b4fcf835b91d043ad12818d666c7321e28a4 (commit) via 59af408e9ead20d96fb2991a7c629534939475d0 (commit) via 41f18ae7f5c13d55ada84e3895f0cb656043e826 (commit) via b475758123fde5fae476cd275958ac16d8eac7bd (commit) via b580bdb9ddd5459bcdac95948ec41eae55be734f (commit) via 7b7e53e6bd7e7610b71ba3a5f9ddc87f5c583004 (commit) via eccbc4bade52bdd557a5c416693536ca08a293b5 (commit) via 432166de1e115df93b606378372855cee4ba8ffc (commit) via 302fa6881751e5a8f9c8c197ab0008ee336e821a (commit) via 07cb624e48a8606ba4b603f94caa0e92853a1559 (commit) via c7872232e5661af50368d5d6154db13047320673 (commit) via 39dfda115ae1f89158cc56936db3c110ce1d7ff2 (commit) via aeed520cd88a713d7eacd2fdc7e38ca8b5f783cd (commit) via 5bac06f00b6efa36fb497db4fb82f6c06286886c (commit) via d95d6a59c74c3e3e60d6de2159679e46b78c46e0 (commit) via f529ab5d0a27173ed68aa017a638b36b3dcf585f (commit) via 84c7246e4c086f7bcfd7646a1d9f0c08c13dd41b (commit) via 0de7313fe24f96eaf48983906b8dbf3702f88470 (commit) via 80d652f06e205be070ba151158042c12adbb2d7e (commit) via 184ef021110d52d123104c77863df92f7ecc5f6e (commit) via 51165cfcb741319925322d3779d7e2214b890fd7 (commit) via 8451a8efdacc4a43d9df10571c7b09610eca7295 (commit) via 59b0d22ec00154a6a314a7f988e4b393d1f966ee (commit) via 13bb4911af9e36d9b95a9db5d6d9e9058b710cff (commit) via e8088329ec35ad7c178695594996e6ea102ba7ea (commit) via 24b5a55393bba27327998f2d608706dc73902aa9 (commit) via 68e16ab05b7d6e726bd6adb7fab48875f28a6631 (commit) via 1fa2781b7a2e97a77b8ef7ddb3b3c48a93f2516d (commit) via 6e09b8b3913df943377b7710bbd0598f296be8fd (commit) via 1a0987904fa571dc5abce03726e4ca3e17793574 (commit) via bf4c2fd82b30d8b088fcb1235263dce9173d4cd7 (commit) via 92bb9ec9da549991f402082794638a4458e77a81 (commit) via 363ebc01ee5c4cf7bf75dd1a21b322aa31d4772b (commit) via 85e7e61e5f001210af0b6d8f63315cf3317a4d0e (commit) via cca89ca8375328981c0d8373974e8891c01092e0 (commit) via 9e02ae10d51cb6e5c8d6fd8be62f119ee0a00b59 (commit) via 4b4d11e4c350380be2f99f28bfec0a4058f51dd8 (commit) via cd83fc508793a01998ae04fbdde25d70d9b7a179 (commit) via b5b5f08be1ec26340235b5b7eed411a2083f73dc (commit) via e70e560cab016f5170dc0d00726e80ff0de1b11a (commit) via c332f6e1f9f90df90cd62c4108f95a85515f34a4 (commit) via 8c85f0c35c4383919e0467b44cd3f208f280404d (commit) via 1e26cb242fc4e52b3c99663fa1abd3a187aa8d7d (commit) via 00373a1fd4f4cd75a0fb2f2c21b7d9fd567a41b9 (commit) via efd8beff4f9a6b39a7b43b18716bceb4a9f07e1f (commit) via 620f69a74b18908e3424920c7bb01cb5e4cbd8b1 (commit) via 94d3f0afc5ad2cdcbba126ed9c16eb933e86cc54 (commit) via 7df07eb9227fc35cf82d7edacf4a3d792c368314 (commit) via 9226ea8dee19d509b7c430970d29055cc199b2dd (commit) via 16ac61e2a353fbf940cf8eeee9d5018ea2a12641 (commit) via ea0b580b978834a4ce0ea8c29cf02da1a3512c0a (commit) via 03474c1303faeed68631e4074ba692bdc193323d (commit) via d11f43a30e89dbeb56115824b9a1329b0d77f95e (commit) via 9f2dff98f6526412e8065a8c9ade811dcb1974fe (commit) via 7eff18a997a81935f22833b69af730f786865204 (commit) via 07bb8fc04794a1d8e76bb1bee3401122d054b32d (commit) via 87dfaa72cfa24b92fdd1e60deccfda3b3eb2fd78 (commit) via 389a680cf766436e261c369243e8f58728801990 (commit) via 0fb38879af867b147d2ad73616f0c0ec08a0fc92 (commit) via b405a9f0d2af056dd0c0e4d15271ff7dfdd5c928 (commit) via b8101ed9a905460050d5dfc1ad03e2af6c24fea2 (commit) via 2db0957d49df502b556adf99c88fcaba646ec165 (commit) via dfd0e65e3087548bb7216dce7ad2e332292f9d14 (commit) via 5488c29b15cc505a048283f6292ade8e41129840 (commit) via 417028073a037fa4fb5daac6cc9c168354675619 (commit) via d8e73722185f5876adf0524dc4e48f6e858872f4 (commit) via eb15a1ed19bb4be5c03aaf39e87cd5c25fe1d907 (commit) via faf6ee9ada079e80d03b937df0d8285a84bd2c37 (commit) via d023a7b2311e5094fa3e4d541a0200901a4a7a7f (commit) via fe363c540e0a16d7d27891030dbd15ab241046ea (commit) via 768488d21e0de005b61026a1d234ad52b5b632cf (commit) via 48a4ed105882684e58d01d8edb7b3ebdacf1e975 (commit) via d4ef22db8f21f7ed5ebf16bfcf335e32102bfe8d (commit) via ac69a67112a776f857614e7a11ffd7012d7e80e8 (commit) via 7176b321660fe70ca1fa6706cc184af8e4cb80ea (commit) via bbb6bcbbab9c35caecc8e0ff997b6da6b2e91210 (commit) via 7a79a6019e21257a7d6f275ce8d6441034a945ab (commit) via 2024eb1fbcb025e79f777db01e16cf9a55cf2a8d (commit) via 04c2cbc9a8b34fd875470053a7e332f5a544469a (commit) via 1055a6a76decc40e5d9233909303b1f0f507ad7b (commit) via 32e99b355dca8a047259819942e6c0bdbdfe219a (commit) via 8f4ea952b4a962453f279c7259baad9ce98feee7 (commit) via c7c034172ed4fc4e8d6982f598db82c80d930ee2 (commit) via 9a512f7aa69fd82841d2367c0bb63cecd45ff315 (commit) via b0328ae52e95fb0eae14e11c7b13d3591836db60 (commit) via 4314ac72c1ecfee5b39d5d9af12711dd39ee4ab3 (commit) via 1653ea5fcedf369452c0cf41e09e57666525615c (commit) via ba0f4b9d9f954c985cd260feeae4560b5f54668a (commit) via 61d033645d7b146c2535fce8ed1cbb6272dde2d7 (commit) via 30692e2f3a872a91d5c41cf59badf3eb393c5734 (commit) via 5cbc09e937a9827219938165a6920079737a643e (commit) via 15c261e94b888b0ae4e6122fb11fba2219c932fa (commit) via 21b4d6ecf1e287658565092720870f0b6aba1c15 (commit) via 629e68828c3fe751c1e00d033227f23ccc3bb0f8 (commit) via f31bc46948695d7156f2f130733a29706b900621 (commit) via 0a113beceabcc0cd731874cc482dbb83e9bcdf4e (commit) via c4521c24f6bfb727d0ff77506cc926b3f9d98e06 (commit) via 7dc9392deaee381b0b3e9c7855a68b0caf54d1cb (commit) via 09765707a7a65c9ff3fc89899647e977c230d9bf (commit) via 6b66e764eeb864e559c9c87d427f98b3848fd78f (commit) via 1c1498834d0bb14a1d53db5fd0b39acada71bf66 (commit) via 7b3ce599ece41d9199965069488f00bf30edc4dd (commit) via 12f8f43893ea3d31e4f18b356af581e14becd8a3 (commit) via 74641daaae226adf2b248ada91697cf3e244ec74 (commit) via ef0e8416d58d7ff9be336f26f183c27a3387e71b (commit) via 43038830050fddeb2bed423bbe3fdd62f9429309 (commit) via 73e9605adb42f2b6955104a39e2d66573d8d9792 (commit) via 7fadcdb7ac5b19c50e7f2f78a4485d6d9577082e (commit) via be1c9336000c0941fd763f9bceb39bf6958165cb (commit) via f220073eec4b951d6d0179068d5d4ffb59537881 (commit) via e9ffd03be350fcb1c6710e8a40c2591629553500 (commit) via 9e487bc46511b1044d11e42ec42672753360cffb (commit) via f5cd52c0fb8933973003e07ab130fefbdabfb4f4 (commit) via 03718fee4dfc3a711532a9ddf9bf250255d2944c (commit) via 331ffaf3238708fdc28a6fa903c4116210c3ee62 (commit) via c1e5e6c92d7a2af922bbfd7e5b474baf122cf9d5 (commit) via 1585aa950ccfb3a564aa263de5f01c4ab01cc5f1 (commit) via 8b810d2d4214371084124089f2dff3b69a059701 (commit) via 3fb9882a207d281ac9a28a718ef6018990d7b510 (commit) via a29d697a25bca1e0ce6109f705f43db05e4d6f97 (commit) via a35592eb20ae4371da99788e3c5a8796616390f3 (commit) via 6580e3f19f66b1d8873944a434041c3f843538a6 (commit) via d7e1970cbeb1107b058adbd3bdafcbea5013c89b (commit) via 20d7254cb6b30324b76355c76c1852e802edd647 (commit) via ba4ff84e94f5e1edcc520a06d0dbafbede59b437 (commit) via b4368e14b0f082313de17e29f7cd62a251c0c9a9 (commit) via ec99b833d2569ecfcbec11bb0ea72444e2e10caf (commit) via b3bc6dcc02a7851000d58417f81d75d918ab34f8 (commit) via ee2bfbf7b4f9ddcc7446756608f7aca89726bfbb (commit) via 852e3378b6c0eb73ee453d77f7f4ac20469f10e7 (commit) via c316799e49faac41e8629ce32a46b3b25b01206a (commit) via c0b2d82fc4462370f7a280c14c61e57bc5a7f239 (commit) via f07d295fcf89f5a9bb58fd09bb875d56260faaab (commit) via e73e3580f6050e98cf5affa8f23d941845e77ecc (commit) via 3785f53089eb4197d93574ebe7ff8eba51bc7266 (commit) via 6c7a5b488902e4420f864afe6f14009e942b3673 (commit) via 6a2ec55d6e7f69161b003a0f2f19be01cafd35ca (commit) via c3c053ba1c9e7c7a6f4b446e742ad5ca3e04e097 (commit) via 53744af1821137df82ba415524e3ec9fa2f605e1 (commit) via 656439db2612878b52422d209443c17ebbb70c47 (commit) via e3db7c581cd9facc01015d81e5c63a24032556a7 (commit) via a8ed879d7e9cae014d768ae10c7f407c3831ef10 (commit) via 24ba73ccf0bd850ea7d423f7f07f150b7e43c676 (commit) via 38425dd78d5fc38921b1b7aec98339c2bfdd97af (commit) via 794b1e75697363aa289cbbfb21629775bf509f6d (commit) via 1248c658d115a4c4908824c9c392ecf6859fd6c3 (commit) via 9c11de60de8d3294b1933a710887dd9487fa2ad5 (commit) via 4d3b39938d88c782bd146da59866df89aaf9b80f (commit) via 017167fb34220a17af361d50b2d239927acac7c1 (commit) via 86f329aa940388d981b25c2b3c966313335c2ed9 (commit) via 1ccfef8b3fca63cbdd7839ebf205bd6d1f7193bb (commit) via 51cd1db521131239af212ac0424eb7b2319cdd5f (commit) via 3a79b6f87c806b83932eae15bde6ae1dce983285 (commit) via e3fcac94b8f3cadc75dc53e08f4c7f7757766a2f (commit) via 06bb9450ddd644707c2913c2cf43053867bc5d7e (commit) via 4031e19e124bef499fab82c9762edbce5085101e (commit) via eb2e9101243fed7f47bf7ade9eacbca0b1ac4c7e (commit) via dfe22ab861e7f2b618bbe65b0fca32898433216d (commit) via 316b858d28092bb1c55ff50cfe68ae51f34425de (commit) via 434d1c975979bd39f42a16622db4c94f04ab66ce (commit) via 529bb0491043cc716c9e8e72e78492bed6dbb076 (commit) via 9dcded61a1f5634861d9abfcddc45ab972fe30a3 (commit) via 727c815ad2b22aeb183c40e8fa78c640cff56f99 (commit) via f14f76d12a3107f0a89884f084640925ba033b28 (commit) via 380381ce72e00db3e845eb6507c55b61739d783a (commit) via 4c8c59ca7d1fd7be949e8dc32697ba67b3541e88 (commit) via eb2b8dd98ae8c298c484e61ddc4ad1fcf632ad5b (commit) via 2e139a15fab0206403e66abaf435456007cb5e1f (commit) via 05cd2b6c1cc52aca95a822096f77aec203f34622 (commit) via ba58d62cd13b2dfe39d62022cc066687019685de (commit) via 21124903d5c6ffbddfe54db9b9490c095428909e (commit) via 032cb4b79fdb207e18bf121140d7c7c66f9b5cf2 (commit) via 01e8f509d7425dbc5fb4f467087a70b3e8f7f4ea (commit) via e57ecf4acd280e972449558e58d57307338bca86 (commit) via e510ceed0563a5b37481339beb1a8cb61809d164 (commit) via 818b58da97d55af5fe0a0d7de72518f865730f20 (commit) via 1f95d39b623a3127e493446f773a22289637e6f1 (commit) via ba72f731c3e8cbeb698ec17beecf599c24dea1cc (commit) via c95424a8a41af26fbae90e8ebbbc652c4a7ba071 (commit) via 0f4495079639a9a6baf97d2eada68b9ae5f59349 (commit) via b443d4646e57012661c40011e287cb9d67245ca7 (commit) via b293c97ad3f128eb25e3af8d34549368544df708 (commit) via c76b37845333a62b66a570e59edef976cfae7cf9 (commit) via 205424287b0ff732ad555ddc2026f1422633cb12 (commit) via 5d45b69b590cabc5127282d1ade3bca1598e5f5c (commit) via 85bbda514af5bac1042dd2fd2f869021e2afcaa1 (commit) via 5aaf741c812bc6f21b6014c7b549089bfd20920f (commit) via 0161a5ba52db4e499e471d6482dc923b495b9989 (commit) via 95e33c7097fb5c858e1fc34ee9e92c15b788c0db (commit) via 7802bbb09163e3a91cf68e2ba9ef03dc18c99372 (commit) via 4c9cb5220dab050f9160e990375a0816eee7d3ac (commit) via 70554429a6aaeab8302766ed878b981404d16e7e (commit) via 9788199a61f201cf0347400e05cc10a62bb7b3e6 (commit) via 566d20f444f1a526910e4c78579e8703c63c19aa (commit) via 0a3c713d8c87ef64761027012e33f54507521fc4 (commit) via acb6781012409b391592096127460fcfd9b648d7 (commit) via 62d34fcc2cecf560b0b8f3c897cb3f0f8df31b99 (commit) via b96eba436b8e4b2028e7764c1757fd34ab1c4d38 (commit) via 9efce5c916535211643a3faeef2d0a05dcb6aa17 (commit) via a888bf7e68ac0ff178b8fc77fbcac64415c0cf9d (commit) via 748ea162c3f870271c2f180fdc1b6123ae8dfe57 (commit) via d0b07245ec7878fceba1cb6b272d3efb333b7dd6 (commit) via 238550b9c5aad47448cc5ac537108ee23125a252 (commit) via 1c5e6a1b3470b23554ddbd3718bc815f19bf8684 (commit) via dc1ab9f32b9bdf3135a377ebec0a0c944d577f47 (commit) via 65aa59d28ab5f41a06dbfcf25b191f2b3547b78e (commit) via 2b74b5c4c8836f413c675d8f7f80c8356b6b1722 (commit) via 9c5803ff7618002b8d18cfcd65fa44ec20fb1c76 (commit) via c9a081c3dcf1d66d1117a67b45e7ad7fcf9e065f (commit) via bc43d687f0751cb95ecd9446589e7b37506ff1c6 (commit) via e788fac9fa13b2e5977c27ada03bbe9ff934d9f6 (commit) via cb31f5620458420eba8857247caf33925a42465f (commit) via bc4e15b57901c74d844545ab40123188625fd23d (commit) via 95cb454355be5b9de7582d2e0e2af30bf816dd60 (commit) via b00e7fc088df2865fa918b4c73705d0e725fc7f2 (commit) via ba7657cb19f3a221c842bbf12b1efc2ac12c9dc0 (commit) via 442e06d9c67434fa60df82abefc4005a36fb102e (commit) via 209f7700b3c281c3819d16f9f1ef7b4990f7304b (commit) via 4e857ad20cccd7d4c5d9076e19bd690f06033ac0 (commit) via 3366317943ad7d135bbd8b5db13fd80edfd811a1 (commit) via d209fe6e18b44d98e3760d542acf61b2d82f056f (commit) via fc9ee03ada78922be31977126263e047077f98e8 (commit) via 224215cb42e24dc23a26e491ca8fe11d8d64687e (commit) via 1044d56e3dd2b029a13964badc28da7d16d19b00 (commit) via f7c8f0c8a5bfb04052b7084b00c5d85b756f14db (commit) via fa1635f5b077caca91021389c6ef029528b8bab5 (commit) via 647e5b449a9af1b553698f2f62e70afd05850bf9 (commit) via 0a8152c260b7939633e91202ae6f5c8075405f97 (commit) via a82621eecb45b2928800643741681556d6b1ea03 (commit) via 91409213ad111fb1607636dcb0b69dac9fb2d0c5 (commit) via 8a173c9812dd2396258012ddbd13c37ea9c61a18 (commit) via a8ff1335f99e91569ad8eaf497bc565f980dd8e4 (commit) via dc6b9dfcd635a1ca97a218bcdaf16a2ee5f7b693 (commit) via e4787a9190c82dadae7e57c0847e2529bb2a9bbf (commit) via 5c0cf42243e02ca5a6a4efb1005738beb1879601 (commit) via a806389e50abdbbb5dbdd2071c04ad73beaaadf9 (commit) via 3576ca2cd8325175f84698b5b158309481d55c04 (commit) via e2fbca05bc382a0b9c966ab67689850749cba434 (commit) via cf2a29f0838699e16d273b50bde02fa9c33795d5 (commit) via e2d5c537df39f35628c25e148f2a9238b74e1a45 (commit) via 70608effe4d23bb5f05dc783b21c1ab9d2e5aa66 (commit) via 8da569b6ad5beb9fa8c6aa49279e8a805ffbdfda (commit) via dbb5c73fec950c8909726ad471a204a951a03756 (commit) via 042cfea07c8fd723a763d52378ae197a53b444fe (commit) via c61b543e97f85fbe6a30f0368a7c6975bdd21fc8 (commit) via 6a0a56ed078ef8a51b7c7b26acd0baa700b5c8d4 (commit) via f81f2c4a6ff405fcdeb1866d2bcb2d3018f39c6e (commit) via ca7ac05cf00bca96a0123540beceb206a788906f (commit) via 44a6e2dea8be8e02cdc62a2a89dc79f734ab9f9b (commit) via bd9d79fcd7b1e950c3e27d5b26e90688056d4d01 (commit) via e090683aff0763c4604d8ea8d060cf9a1a8cfc79 (commit) via 0347538758f29b056c2e04959539bdc32f0291b6 (commit) via da861e431135c620a879358b32731125b3e7b495 (commit) via 22dc113852fb512f81c68ae1eb6914f27f616f12 (commit) via d9d6106044065ed748748ba2135a9ac3cd6c5108 (commit) via 47726eafe572686e5b36ea2e8798096cf1a07bf9 (commit) via 8760999f646fb398fa0c824f3539cee4a4911d13 (commit) via b6328eba6a3d33930489709ee1e47140dcc30dfb (commit) via 95affa1ef1484741156a34aface45aa5e16c02c9 (commit) via bee04353b91cbec90c9377f74ceeefa374757c65 (commit) via aef93dba8c44c010a598cde60a5bf25226c25676 (commit) via 632c6261caa68405f67495ee71593654e7e23177 (commit) via fcea7205a471c4353847bebaafec7d0c2a72618f (commit) via 38d784d54734a4f8e561f6df3460d02aac53015e (commit) via 5d99febe66e96b55a1defa58a906be254bad3a51 (commit) via cae52d27d646c04734726b54edf9aacddc3153e8 (commit) via e61257988e3024b6ee21a99f32d82bc2a7ab5c8e (commit) via 16348cbddb604b267b63c84f30bb2b0a72778dcc (commit) via 04704e289fbc0b06dc1352da8416488425650cc2 (commit) via 137da3f1064c89c98cdd9fe66a707a7d3fe05e00 (commit) via 2530b75e1da0f715a6b712ee9b12beb6e7d604e4 (commit) via 55042dc15b9b6611c01f8eacf193d2fb6556afc9 (commit) via 23b8d11546c3c05e967b7d00e5dbb2659200eb4f (commit) via ef96c91060d31d546f96adfeef779f79c75c36da (commit) via 92f3a0f3e9c0480abb6f1cc2e51e5e32a17ae155 (commit) via a14c6a849090e32fcdf8136be8ba9360c371bf5c (commit) via 1c5d6881de42d9093933718e7bec6211222fb7d6 (commit) via 9826cde91d56be3cbbaf7609a29e2bbb3478835c (commit) via 4fe475492cfd94df8542edc20b22bc6a531cad32 (commit) via 397d32b863b640ccded140acd6eec94da367264b (commit) via 86f2ff6ec027514d067fd6ec054b6b2fa7c3afe1 (commit) via cd443126a4d73612f27286b0f548a07b63553a5c (commit) via 8b9dfbaba9f10cffd41b0cca1446a7a6c5b6eb90 (commit) via dc8bd7c3a9efd30651c5c31b37ae27b2169592db (commit) via 5bf8da8a4cd5381d1d206ce7074690dba463dba0 (commit) via f0393a5975e96665c6d828ec2d7d103372e18acd (commit) via 306c1c85cdf321ba81e5ccf0c6299182f66ea34c (commit) via 6be0444caf472125fd765107be5b04c6c50dc928 (commit) via 49e331c4cec96a1ca2637eed48f67553bc53a5b9 (commit) via 0fa1176c22d83728b83111d984751093c46a4106 (commit) via a9823dddf3dfdf0f048fcc1ecc0b951c87b91c6b (commit) via d0b9db8cd8f9290173860f8cc52e89834b253331 (commit) via 459bd4646d15c56b14f9f10d86c6f5d342174c98 (commit) via 5f0d50690ae01427ae310e15989cbe3780a241ad (commit) via 0ac5c797fec5759483dd7b48816f836f8c1beeea (commit) via eb6eee72d616d7edf962d913463bc70995caa76c (commit) via a931f49dbb489c9062154df0fcc4cd9222003c99 (commit) via 0ee6e43478912f2aad6c24bb54b9f2c3a89279a3 (commit) via f4cd45f6fea693f8ab82fb3264bea717b32d4947 (commit) via 4a69d10920c47fbbb5522adbb478cfeb8f6785dc (commit) via c881ee37d955428cea8f377aaa0a66d5c0b0e60d (commit) via 72b57ac4ef653c1909e4c1d1daf40de2357b77e8 (commit) via 09671923adcb745381fc4b276085d0ac7cb8ee94 (commit) via cfafb915d1f4741996b085336ac13998e573d9cd (commit) via 1b574b907f8ce97b00d402e0374b8943c83543d4 (commit) via 8bc1c6e3e8c0a84ee656d1e1d68530fc9bf2e35d (commit) via b6bec7d1fdf537f12968276344e6191394249b8b (commit) via 08754c3893befe1bc2377b8b30abef00aa5e52d0 (commit) via a5094050e4f024a17f3abaab1c406fcf18244155 (commit) via 11e0df5e3aa1644eefd3e3ed5d8d419b6d61f138 (commit) via 364d9a999d697c4aa0304733e363454f17ab5fba (commit) via d45bd7cb2424d4f99924aacf415c92cd7e61329a (commit) via 7ae954c7ac934ea5748b6d65f1c04e8c9b90e27f (commit) via a660215deab1ce881e9066e0d89ba93445fff7bf (commit) via 010c73daa65847035cab3f64367300b6cba2d038 (commit) via 6325ceb5e5cc58a8ed57029a6f4c984e669e59fd (commit) via 2934683aa1887e247f15bc04ab705c52fbb225df (commit) via bfedd74e99a04fb4ef802fb8a663e3bf76721992 (commit) via 7da66f8676cc663d8898b5ff9cf41cad80df4900 (commit) via 6c00182e1aab846ab45ff5043cc94a42b5f86b96 (commit) via f7e90534fa66244c1c4cf00c4131f805924a4541 (commit) via 9198448f9db7b77af8d19f8265d6785fb005dc58 (commit) via f0db412f57effe6234edc78e1f438b735efae805 (commit) via a3e14cb514976a9354676a2caa7b001e50dc6189 (commit) via 30841256963df53292a6904952ed4288e85d0ff6 (commit) via 6f2d4c27126f3d1a73494ceafc464df99e081494 (commit) via 944e661514feca102e49e2d776f0a484e24fc597 (commit) via 4904dd5517dd1b9f7096a3b61d91f32c8ea14331 (commit) via 621d1496d70951bedc19adb1f5a1854ba4fd60ea (commit) via 2bff4c197b9bb9c60de37cc036af9cd60a17245a (commit) via af6433196edb6bd86764e851a4960667c3eeacc4 (commit) via 8c814239128c813445fcf10d43869d0ca920f03e (commit) via c82abe48a54cd7cdf589dda6cbbe5fd2d7b9ab5f (commit) via b4dc30ce73b2bc1da842a66420b89cd70f296935 (commit) via 6a910946cd5f921500abe806621407fd5086398f (commit) via 9eee872f8aaa7d50205983b3ce1c892c49389d6e (commit) via feb8f6b14d7e342db369656ab44c38546b0140bb (commit) via 048c4373e15a401a8700bc57b403282c7830d27e (commit) via d332507ef2771f5c623a6768caadcabe6dd5583d (commit) via bb9e26eb49ef33ca00a3f85fa15de862677688ec (commit) via 765015131124bd54492bbda11aadb75a1fa3b60f (commit) via 3db1c064045cb496a31adf5a2bc2faddaff4bdad (commit) via bc72f7cf5808d17e66b38fa4b98043efc5f1ce29 (commit) via 7fd6abc1eb7e3b2a5f3ea1a587f6cd7e2c582c75 (commit) via d2af01684cc445e98fb10666ba42c8a9e4b79d81 (commit) via 0b1e354458c9df6498d8a4065ee0d77eb250b4b0 (commit) via 9cc4a3b9674c2b5b53bd32b54dfe863bb08b81ed (commit) via d1ce1baf63c96f9bddfe8577a82568b21295fd96 (commit) via 2cf6517ec088cadf60dec1f1c93b8575e4a4f40a (commit) via 045c48e81e0a74d5bf82d77c778a14cd4fee421d (commit) via 8ebbf99173984bf44e78ff7fec2a8ab082c1c8ae (commit) via 3b940d2a83a8d51f3de1284acec28171f6cac8c9 (commit) via fe219637a6748130266a0b0278166046e60a2d68 (commit) via e9376e47307daf4dd81658b8d0c356e0936b692c (commit) via 27b571e62f6a672804c6f8e7b0558ccfb589cf9b (commit) via ae91f43155662d857b6e4e07a67c244f921e0a8b (commit) via d2016c6a1bb9a1688da684825cbda889d95238a6 (commit) via a958533c6a2bd3e971352a5bcad490526c34f6ea (commit) via 0bd863ae4696858b67b72bf1b0a32377877a5a38 (commit) via ba3cfb403a403647241062b933ff82808ac62a59 (commit) via 620647a3e01d65fef985093cefb9352e21603261 (commit) via 5e8391ff900db18ccf8663918919b16085406874 (commit) via 0c425e857aa9b0c81b38404f78b4d613cc9167a1 (commit) via 32ab83436d29754479e584c9a2c6a322cce794cd (commit) via 443921983ee20c1fa0bc7f0a44ad56e5d19714a6 (commit) via 86376e8447aef9ee182dc34b98d61bb37f3bb841 (commit) via 94a0f7c6414cb83535e89557ce3cce47a1808fec (commit) via 5a674d05c900be0007b71d11ff52e7f972359b5d (commit) via 04df34909f02013c36bc1e9ab33a52b34f374f80 (commit) via e438cf2e89e3336d0d882b86ffb54872ec478e34 (commit) via fa258523a939fe68b4c8ad6d4103e6033c389087 (commit) via 991974db7f71f2441d8ba674989035fe13c184a8 (commit) via aee743f9edde1f0a575d8384c54c23376d00865c (commit) via d16308c89a4399897874ea660267f0c6303872dc (commit) via 9ff64c8d7c43cc7c819e0fdce4476b606e1cb28b (commit) via 6176441f6157cfbd537dd2b61bab269a32fcb2fa (commit) via 02a3056af383f4230873d7cd1a76654e1ab19969 (commit) via bfef57ebb708445c55876b8768aad1a0b98cd29d (commit) via 78b7da77164298343ad92de5b9dfef2f7d46b7d6 (commit) via 0b649a09100813151555308d6ccdbd18ec43accd (commit) via 9797f340747e3f47191fe6b8df2dee657aa2179d (commit) via 794596d9367526a34eb9f8bdefbcc0675c07535d (commit) via 25d90cb13c6f4296fd0c698ea8b2b67766bfbc88 (commit) via be38102eea170403b66d57d3f8f01ea4d49eaf29 (commit) via 5a94c7d14e992590c7ca7336821b8368b8559e09 (commit) via a9733b5cd536c0cd37d7be82152328e2a4d7c112 (commit) via d2d1f793f81904b26d4cfc4525abe52aba18341d (commit) via ff6e2fbb1bd49e0e6d1f748092eb0d3102262689 (commit) via 99e645bfdb48349c3adcbe1fe22b97ef801c944b (commit) via 12cc2ca8f4fcc74e4de9905f2f6650855abeaf0e (commit) via 589aa9070ae6d77a52018fc34605cfe5c2e56b22 (commit) via f73ae69ba917abd34db434b7ead03d4bc0e9c279 (commit) via bd41b8e417e2f769ca318388a8cdccb1a5064bae (commit) via b5113126338b7d16b08a5b0a482b07e856818f33 (commit) via 228b122dc973916b7ee532567945845c50ff27fa (commit) via 9425d6e9014895fca1301a2d4f5689cead37f1a2 (commit) via 1f5f63f8ef98bfe9c4d734674cee0df64855555d (commit) via e4c5efafb7da2d25b7d47fe2dac3b1556c0b67b0 (commit) via 60c5ec67f81393d979534c47a069c154277e477b (commit) via 41812f2d685d6a4f6d586972db1e10102e2f3021 (commit) via 55c68ee69cce06fbe1b9549e27e5ff524bed22fd (commit) via fc082fa2a9908a150fe6c44a63eb0852221c65f6 (commit) via 1a9c364198e8b576dc554a904ff8576b83c51c36 (commit) via 544f7a26da096586992fee32faf4991cb4fda943 (commit) via 1d6ce5af723fc0ad6df966fd4ca99a7ddbe7b4b1 (commit) via 16b07fa6bcaa3a3618222de9d080565e60cfeb82 (commit) via ec2d31049f2236746b238cc5682081ea3151a7cf (commit) via 8cd389e16166fa4c075fbddfe69f26653a0169b3 (commit) via bfd2dbcf25749d9f1481c479af4aab098069c303 (commit) via f814c40ad3d60529fd16ee43464aa45b5c5bdcb8 (commit) via 8eed71f53974a0274f901edb63e9476c452e9eaa (commit) via a2265f73b58ea91c3ae13ed5b863f844936f61d3 (commit) via a56d9ba30ebeeca4ea12d4ee5f5d45ddec2a450d (commit) via 58d5baf3c081b5d6aa795cd9e05d547927d89001 (commit) via 0f721985f1d8e75a7db419402436bcf0637b23e6 (commit) via 390e80ee58cf528f6d06459569366799d449dda4 (commit) via a0e76588bb9162ddccc56cd61127ce009c3511cc (commit) via e5ac9e4cf00e2efe6872177e81f7f0d655c80021 (commit) via 18bbdb478e8b3ffa353810d6df19b2b217a2c24d (commit) via 600b84f4c1f35252f8d748098b838c3f4ca20d09 (commit) via 62fc862bc60f2a044dcae2191aca7f6bd54f3afc (commit) via 32923b94a140ecbe39a419e71d828c5a1cf9bc48 (commit) via c0a00038246ed89bae04554b84b20ad275b10e15 (commit) via 8ae0467e61cbf8a6256826ba0aac2cb5b8734c26 (commit) via 80a1dd70295ce06d55ba1b9e7b58647c74ae77c0 (commit) via 22824478d1bdab6b8b62c8d9a43952279abf5064 (commit) via 28960d79cca262ac6b974f339697b299a1e28fef (commit) via 7ee8ead85cbde1724b672f7723eadaeeebf8e4be (commit) via 40a533abe1cc7c9992a20842ef84cc75dea1dc5a (commit) via 908e25d5aaba5496e73940709e921f45870b849e (commit) via 782054c2d54d5d4bc79c602ee01b5f79a4941662 (commit) via cd8c73a35591d409b3efaba648584418bc8bb540 (commit) via 71844ed50a35d8bfb03e10061846f726d7f9af9e (commit) via c1f37d25c3aafcf6d84e757df849bad5ea184eb6 (commit) via 0fdbc5e2474c4f857cf8503c2ca7fa7e837f4a98 (commit) via c4a6016be24b922c1f7399134acd2a6d4908be2a (commit) via 9beab2d89f624389643a38a9a5af9104209fc833 (commit) via b13678fd3703607953fc4627461d069314f7e990 (commit) via 32ce1fd3ddd4b9d218302c699c9514045f9a4bf5 (commit) via f4f44caa3525bb382f903f3abda387ccc0cad806 (commit) via f29bafff465a072bb9c819598b1d900f50fea59c (commit) via fa76cd57ff169510e59836b5e71844832c3fda3e (commit) via c061522765a5553c25f51792d0dc3ede45e9abe9 (commit) via 59e4311fadead99523eef7a4454f86d5e02fd517 (commit) via 61cc7691691c5f8bd2e11b2caffe52cd8e14aab2 (commit) via 5df9b1d5d7ef35b529d5a7d4f21cee50683a8240 (commit) via cb1a6528f968c3cd97660217abc1a6725ff5ba92 (commit) via 6db88da7f7ffd7f75bb2e06e269bd28537f10ac1 (commit) via 7e76e5f2c865fa868b551fb974f71dade1972383 (commit) via 395016356cca7f9c162ac974c3b889461965a5ba (commit) via e6c0f03a42a3dda02066537c481e96eed98fd486 (commit) via 64c32c672c938b4a412fcb81d8e18447acf3cb3c (commit) via 41b571f9bdef6ea310fde062634245d3f48de8ea (commit) via 3eb8784140dd6f3dfdf4865caa338f7434141620 (commit) via ea7a5bd02ca43d738c33b6f7dcf60db5f5e2e163 (commit) via 3ec83384977a6711e6c43906bf6118187be0bdde (commit) via dcfc57486de36a0cbef9b102b24011230b62f5cb (commit) via ab202adb0ae95de3d63b7ba43a062133f38ee299 (commit) via 8ab3060aace7b20c2845f2f725d4f306cca61dd4 (commit) via 5fcf5b9cc37160ef071206d8cf0ec84a5c1a2205 (commit) via 1bed07558c6de2d8311c91b2735dd4da48e8a697 (commit) via d4e974553f425f7adf6109a47f4591d2c3a5e284 (commit) via 4f9f1011db084c6d1e7ed381909cd7d6c6a4b556 (commit) via 746511d5ba415fb6e90bed31e4a5a5ff67e61c66 (commit) via 0420088e9f5100852e51c0d1df9ad4be825b7fba (commit) via e4a6383cafa83c025bdffe1f29795d9a3d6fd028 (commit) via 4adb67fc163f1094e14083cb6183b8e882a81767 (commit) via 80150df416910ceb2669e406b78b0cfc59c9949e (commit) via 1d999dea5c441131abfcfd8464f766f649f9a10f (commit) via 90b3e725d48686b6de40bc409e94b5babcb841b8 (commit) via b8121932e9be9d61e3dff8f608d1d438dd163f27 (commit) via 8556f65e0740af647482a6fca86371bbc498b68e (commit) via f53750ac930216b4fdbc3b16d6c8d0b340104c17 (commit) via dabb19572d954ac9d7b0771d79bdb594fcaadcde (commit) via 444cac45b2f845dc0e0baf9110b8ad5b9bd2709d (commit) via a44eece9aaea9a4e6a854d7897fc0c4cebf65084 (commit) via 7b169cdedd93d5bc072e6582dde6430457ece505 (commit) via df088de18b9a2375f6797ac4c62a6d29aa49d00f (commit) via bb2680d9b45275b6c9ada4c55cb0678a8e79b95a (commit) via d447467eb5a7b609d1594d9efacbd91e4ffad50d (commit) via 551f6bdd8c2fe9ab5655f403c92667d759276a70 (commit) via ad76b31c3f26ab1427920936b22ee0d8fcdc8d68 (commit) via 3aff56076167c5ea8fbed9eba32b0f81b6fe3aca (commit) via ffc200ade3789dc4a8c8b14dfa5bbd4a0754de29 (commit) via c2debddb2cd2ab8b0eff87ce37578c1f78f6864d (commit) via 676d4668c83f8c78f35098d9c4ef8851729460fc (commit) via 2385ec8776eb3d04fd29b40f7bc8029f5390c652 (commit) via 121abba1a237fba2c9a9377ced3ca7a47b5eef25 (commit) via ebef0b0dda3dd6aba4e81bb583b0128a6032e451 (commit) via 656c42646a5b22ee4068e1b0fa6405bdd9d9d2f9 (commit) via 0c781eeef7a5322de2e96bb77b1029db35b4b2bc (commit) via 3d574a4b2b462e42d767635db9a76f4c10c521c8 (commit) via 6fd153181402f897577aebb3943a23c2666c2864 (commit) via ebb471f2116494f2c56124b03a5f21818e8cc71b (commit) via d5f52cfaf51e81db8b268da0b4c572d19b809432 (commit) via d8551c42473bc345840cccc3a5ba710ab1649b55 (commit) via 2fecc9686864a7ef346220825eecbba1c3304987 (commit) via 2d8606b584025bb80c3935aa3ecc57b512c61360 (commit) via a4bb6c2d395ac1e30e116bc2780fa143df2dc1ab (commit) via e3a76761861cf3baad8e9c998345be59bc725a2b (commit) via f244742b46af8ec402761dee9240e25c2856cb77 (commit) via d8565d8f1b8bf9653e0ff8847b72765861eff5c2 (commit) via 5cb7a729d3a33fe219317f61e7da41d46a836153 (commit) via 8604242e8f84a2526bca13e9c8571f3b5fc2e766 (commit) via 819b8174a909db13a36637ede5835e29aa2efe8f (commit) via d93db54dc0dcdbf4931e3b491de6232f844f8629 (commit) via e52172c775dd057eec74b659a2403a04d7ac3e9d (commit) via e5f4ef0c42219e45498dd8a418464ab5d5263d22 (commit) via d9368545f40e2b1b309976a8ed720437d7ea69fa (commit) via 45e7297c3ae900a8149d4b7ad27aa43e4b53640f (commit) via 016e407702a7b0e308d4beb9aff8cdd4e9291806 (commit) via c55974facc30d1bc6a07599bb17a27fa1399afdc (commit) via 6c13f7070c138ca4a21eea6e71af072c009d57e1 (commit) via bec60fa461dc2f225929cbcec33308b430f55a08 (commit) via 0fda778b45bc2d6977a87404bc3fac5c30826b8a (commit) via dc86a285c1c7c23309728d587c3aaeeef3db6238 (commit) via 8bf837eddc0ab120ad16273b773fa6cd8ec5c9f4 (commit) via 6adc7550a800142a82cc66da3cc4b305f6a985fc (commit) via 4a417149d42517037ee7a6c8aebc7b792f00260f (commit) via 5c511d23e36b098c93ed1b3070a445c8e16185d2 (commit) via d7be8465b9defa2a54946892dbc389d222ad2d1f (commit) via 142c03516ec93948ad30191730ace09baa57aa8d (commit) via d1b1575f6d1e0f922aead77b2933f9be55d1107b (commit) via d25e7885e6652525525a81d2b876d2998ed0daf0 (commit) via 3f93c6e7996a12cdb50c37e73a662863061697a2 (commit) via d4b5943ba895c2d96c360ef6f1785f1940592ea3 (commit) via c84b0aeead7cfaf595b546b99ff8bb73f73c8fc5 (commit) via d3e50fedf744a7fbef9535c750f0eafe5f6f83b7 (commit) via dd3b82ebc87bee5bb61d64d1a1417364e013a505 (commit) via 40f0f6885f5d14e5e66f5f3237a0001612f781b5 (commit) via 0c7bbc75364ce21e6e911c93da748abf854999b1 (commit) via b14e32cc77ded4a4db6f9cc6e207ce39f55637e9 (commit) via 66af843eb502a16a2428e899b44939cfe3925863 (commit) via 85fed81b6360078127a1f3fbd6b3c7e6ae005c04 (commit) via 8398488b8cb52518d4ad6271cc95e56e8513fa55 (commit) via 1e05b8c894d9a3699ffa22a21492d39634c8c8c3 (commit) via f23feb339ea40192c05cb29a4123adcc67c9a918 (commit) via 210db80a54c998fe78cb2ca6493ed4efc62a5feb (commit) via f5a8711ef195d1bc538a05a4602ee9388da81561 (commit) via 47e1798762478ae19354297e5a95d46487cafd42 (commit) via 55e74ba841126797b2a5b82142fb1db8f61a1288 (commit) via 043b45e840bf742bb54749b2f4cec2a722109b79 (commit) via eda5c950b61486770ad5c3ddc78fe3860d03e8a7 (commit) via b81c5ad26f879bc0e949a4dc42cb5e234c2ad371 (commit) via 18f16c8b93cea32d617e7e846b45a16f00b02018 (commit) via 228a919366993c70ae13581079dd261df667d7e4 (commit) via 461fb517d1f75f607eb3cb670b87754bc24b82ca (commit) via 709757e996b88aa2995c65e7030d5fd440078ef8 (commit) via fc6c5be22972d7193ca8ec1bfddd00acb7241aea (commit) via 9d87994b671e099b31525e92085fcde0a503b3ab (commit) via cdcf9d0817f8e789d667ef41730d59f0723d39e6 (commit) via 7207c82464a225a1d167c397dcef1232b0224467 (commit) via c9d98323f62d3fd1a1a3ee598c991a03a1fdb3af (commit) via a584eab239d55e441433ead40c993e08a24c59fe (commit) via 27ae22bd2538ff7391a5e56723715932ecf80b0e (commit) via 94d7500a7d2589548f210ef0e9cb6d9eba796239 (commit) via d328a58fc6ef90db94bb591b949802abbc91a332 (commit) via 3dd5574800f6043a87926fb1b0445d01ad2306cf (commit) via 42322ac8cf2d99cb15d60a8d6d4053b19f6b60a5 (commit) via 8342e5f97b7564ec423507453f7b5e4e5f48fffe (commit) via 38c0ffe4c6683a4ed8493f42dbe8658098a921aa (commit) via 6d29434c3ff737de9f66f66213827b7eddb56ce6 (commit) via 8333c02731b23d364dd84b210d3cd0f0a164f7da (commit) via c21b2e7f94feabd35672c3a56f3ec17fa6675c9e (commit) via f8bb0757f33e00b33fda174910c2cfcf8f12f9bc (commit) via 67b28510029b88e5a26b98602b71a551b4d26c0b (commit) via bc36e2a113112c7ee1abe9044347237c626a2161 (commit) via 907d8ff41f37f8eaed5e4c64ab322f33ea2c6802 (commit) via 5c1247301461b842d8a624195bb057b534e0a17e (commit) via 20d4c7bb62fc8641643e1101b215bd4c2e6e23b0 (commit) via 3d94f624d152068cd597e139d5807357fa285ac6 (commit) via 1b467b11add2fdf7a40bb86ffb78b63a28b27f87 (commit) via 66f85c65d55df62fffb9e9acf99f882e7c664b2d (commit) via 5d1687e449a8441f606a4559734f2fae5879f4f5 (commit) via 285a0f5a967fd0a473611599a1677bf96038d6fe (commit) via 15d9ab22c33ffcd02bcad33866ccd7899e2f17f0 (commit) via 10b9472659722d8f390170dae8b5ee8612925c53 (commit) via 21ee658f91aaf33241c230c59536132992f65281 (commit) via baca10e725d312d067c45b5394d32f32a4f11ac6 (commit) via 9972110f319c1525412cbc7e06783d6dd19dbd56 (commit) via ea6c209758da5a55dadf8cceb192d1eaf1486e96 (commit) via 557f6a4aed085ec21981ae842b84d0061d519171 (commit) via 98a218dcd350b420f57faa10e79525a12bda6089 (commit) via 31769615bbea590cd98b8f1926641a2ddbe04de7 (commit) via ad6ab481519fb57cd96111ab7069eb4cb3d95c8d (commit) via 98d1069066724477156aedf1d18e0dc72c204ead (commit) via 4762b78e452d636ba2262d1e3ca7b29ed459dfff (commit) via 4398a92be20289e900bbf229f209b718af1ec668 (commit) via 0d5cbc7303dec4c7239b1df8fd152b58ce99a098 (commit) via fb2fa4d7769c025c9328562bf51cf9fa44d1dce5 (commit) via 9be01dc6161acb0b11ce82d1e0475d06f8cc1c40 (commit) via 6bd9be470e9c78ed8dfff31912c12eb138f5bf5f (commit) via 77a665a75c140585946db663e50fe42ee5ee0975 (commit) via 8022f12151fdfc9d23e2a2ca7c884729ebe66587 (commit) via 350ca99d1797a2701e40d198a8ff17cfb19d0adc (commit) via ba3f29b62fcb362b5385b7e35691f0c466d811fd (commit) via 9149af994817b89fdb37be963596828cb2b27a1b (commit) via 686aad42e9d650fb321adf58b359dcd44675f8c3 (commit) via 55fbeec607013a681dbb0e60645dca6c89b8df80 (commit) via 369f8195e8ce054c457ebca29ed6581d11ac7e69 (commit) via ae5e83a25c7a75dea3553a32de8bae1cc036f7f9 (commit) via 50b4ff6db8b1d66caa17307d79375695dccb212a (commit) via 66a9f27dd1790deae574c3198aa61742ba18ba5d (commit) via fe007542268e0261aceb698d5f6d64384167695e (commit) via b3cf908ffe567c9da124c3056dddab0c3cb0d5b8 (commit) via ccd2b53f40ffbd0a29741203febd8cf7c701ff8f (commit) via 0ef0f4ceb589051d6be769afe6325abedb12300f (commit) via 92af82aaa76a081130798893f1b752ba17efbc26 (commit) via fa26a00876167346f5aae7d1968c9ea9ebb66b7f (commit) via 954fd253e4633a3be080c386e10e6f4ba41350d5 (commit) via 289cbd76d9171b804d601c30d1438d579f4b1c6a (commit) via 0d584d9fedb1050d4b8a1ec024f36cff1ca48935 (commit) via 7e37a7db558563e665f7b356d6ee4e8a1bd82f9c (commit) via d672ee93724999d93763fa513dcefef5858e919c (commit) via cde023c3c5a08131495eb2574c00ff1f34cdce55 (commit) via 99b7776d5f4ec28120cb3d3fd77220c8707b405d (commit) via 59c958d7cb58f003371826ec72f0cd93c3e7a7a6 (commit) via c9a89e29e8c156c1c7edf8c0c1703f072bdc8554 (commit) via 958ef99edf4d32acb8db5878fa8f7eed4acd26e4 (commit) via 787b93fd071e1537b33e8d2f894bbc3cc0ed5595 (commit) via 6605d844afa3d804da89970ee46845cfa986994b (commit) via 7ecf93c83334867b9040bf147e249a5118275fad (commit) via 5d5482e2e6504a04c092341aa60eb9d0008cce8c (commit) via c2daa6bc73148aaa2ae2eb3f762f2d2f39a0f491 (commit) via 3a9da2e707924ba0be453c65274d881cb845c4b1 (commit) via e6eb4815cd426d8ea30d0ef3225bc27f39dab776 (commit) via 862c881318b80070d4394726a64feb538999269f (commit) via 6e31943cd4f21a31602eafb59ac07a1df3b67a91 (commit) via 257e7d19fd204d5a27a8adcdf50602738891b5c0 (commit) via 98305ba621f0e50199372fb31e4675b594830af9 (commit) via ebc01bcce5f022662a516d0035bfda2e1a6b9bad (commit) via a6ae7f75714d6a7cb0f8d0ea2b1a4e649da59533 (commit) via 3e14d3b440eb85fce8e48d5d0326c60dff7fe10a (commit) via 6358aadfd62ffe24e3b8ba5b8b6b6ac50d633f80 (commit) via 4d639b6f0e78602678c59a0d6270d89835f3980e (commit) via f0e1faac66b94f162a47623dc2ee1673ad0c7606 (commit) via 34a02eb70b892e06b2f33b8df6885aa46ed56b33 (commit) via 68b20efb49ae90dc31f68783d0b8bfe88560cef9 (commit) via 00a528f1231a819ca06eda45b3d59de9bd0221ac (commit) via 145e3a5dc3ad2c8191696fa4748b1f3d8352252c (commit) via 73f5afb75fa211a6c5a4ca189b5f4a15c87c9d73 (commit) via 3efcc9bd53c65844397fa81c96c2a86e71ac8ec4 (commit) via 064bec879791122aa8411de021d7c2a9444f8b33 (commit) via 903c143769da90b78502971951e6a1d681b7f8b7 (commit) via 47351fb617aaa1be83d2b1db60dc31344c1d01d2 (commit) via 5242dd48b447d3151714aad4f8457c05f0649a9c (commit) via c440a24b1b076ef71fbcc33565dbefc3d0d763ed (commit) via 9e3e02f5e5662b4edb4cd273305f82000d84e039 (commit) via 731a901a3e25839ef3e0d89a0a21edc69ae474df (commit) via 655892c0a673bb3893b502c2bdab63dcb663fc08 (commit) via 8d06115dbf72f652d464ea80ffdabe2b1a0cb67e (commit) via 804c4b1653ff8d4f8f5471aa4c6f114423ed5a66 (commit) via 24cd7a9a1fc0d5a845e99029647604877b492fdc (commit) via 8631ceaefc44bb2246f05cfbe5db8aedbcdefa78 (commit) via 3438092b27b52c561dc2e5a8ca0b322b0320658c (commit) via 6d82ea91fd86bd2400617645b0937c1581a1f81c (commit) via 1b5624a71814baa38d9019d2c2d2a7e9d3437aeb (commit) via a8d40532c328282a04d2dc940e902f51bcf5adfd (commit) via 4444561ef83df484bb098af87afbe1299f0c4f24 (commit) via b31cda28f7329a76b5eec1583a18441e8e7f86e4 (commit) via ceddf703883eedb26df1ee6f5e010ba879733b05 (commit) via 1ea4abd838923b605b11401ad8a0e2fd085de6e0 (commit) via 5b9e9b3fe3fdf2094405d88617a1debfbb2d5d73 (commit) via ecced16299baab9d3066308c577577b8422a0eb0 (commit) via 0870d4665d17ce2e7a1fe53362fb89fb0231be38 (commit) via 3eb253b74811992ea2ac0e0db4f4897a6f83220d (commit) via b0c0490fe073b19e1d67d928bc22c64666f8a48b (commit) via 682fe39422b01fe850a8718766766f5f32ecf908 (commit) via c5560babbd2656f49b5dc8a32f6c2ea67a276d57 (commit) via dcacea5c1542611bbd8ca3a403f9099508aef67f (commit) via a6e64bfc78f2e8502dc616c5d23dd28186656291 (commit) via 8791e0b61ff9a5b460932b16e77c7091a23f9c4e (commit) via de0872971ad613b865464e160f30c4c4f0519bc7 (commit) via 2996ef23044dc1e082c14675a9f3fee80661b7ad (commit) via 3a93855b05009a2ce679360dd52551ed589bbc9e (commit) via be958a71160f09b537871712edda417eae0c4464 (commit) via 6efce7db7c487a506230ac774965b77a624ca54d (commit) via c327f7d599d417cef0c80be2a6127654d6562282 (commit) via d9158e680a6c9f3380190eadd3d049c3d398898a (commit) via afcff2dcd1c5e10e634c8310791d59969e70045e (commit) via 48b4b3bdad38d0a2c597b50cea1e18c60614d091 (commit) via c3e6597f2034c183f74258c1dd03146c98d4688b (commit) via e6d47cb7b3319f134dcc2a38885d1917218f6e7a (commit) via a6167ef73d8eb458996a20ec530f003a994d283f (commit) via eec528cc70632469b94896474644e1b67d7b37dd (commit) via ab6d2c6ac364577e49baa52b7b00d1a91d3a1a50 (commit) via 0bb501a6554bd54540abada98936d1f5ce8ae4c1 (commit) via 0aad2bbc360d8a3ad7b610067c9f04ab0f681b91 (commit) via d86f8202067e3671d2039a315e1abbd8cd6f1db9 (commit) via d1254247b7db596cc3863652e2093f7d0e79d402 (commit) via 34381ed20c7e1005dec1e13ab90edd736238f2d7 (commit) via f3b71f597c0da82217643ff8ae37354308070134 (commit) via 2f759ce7a7afb58f86006aaefcf475941e5a9e05 (commit) via 634ba24b0aca74a547503556f89a6928cb89ee20 (commit) via d77d5c9d206a1c395ac4762938d6ddf19e92f314 (commit) via 107a91a8cc283f648552a4924fade2216670fb23 (commit) via 96e865b4b80595b49edfe294729ac7de054fe33c (commit) via 5352ef42f94b5c14a24eb2e5559440c71fdcae8f (commit) via a069a4f856c29b25bae05f2a91d7b2b71e1905f3 (commit) via a165a80452a49ef383a313b21ebc02925104abaf (commit) via e861a112103ed4d1f2fa153932bcf86f120e3907 (commit) via d3c6cdde5bf5ade070f3d3ecf66b74f32e8ad9a8 (commit) via 9937973431a01b9711a17fbe8aa0d2f6f2755032 (commit) via 6b2764a41e5b7aac4a161d4dd8309dfb3b48e333 (commit) via e502d933c5d0c116b3c3a3f9a25b1547392c3689 (commit) via ef7d5daf420f2932da5f82396b3e258d8bec21e6 (commit) via 1b9de188ff78beaaac89aca32ca0e0f98dd98503 (commit) via 282436a762927a5a5831c78de6133add25b5d566 (commit) via 43833239fc2fc0e109743abc69dd39226b0caf7b (commit) via 56a991710bf6dbd64080c5795eec4609c9360f4e (commit) via 2f31016e6c292899c36f90c736c0c84fbe9ee539 (commit) via e2ab8151b6255dce8f3e841f9b17e487f4ba05d2 (commit) via 39e612dee8ab97c1361f174ffdb3608189be0631 (commit) via df9044794ab9f842d45babc04dcc110354158e71 (commit) via 1d1e511ed9e2312f7f2b667e4b7b8b48a33a1556 (commit) via 6b4d1cf931c31edcd6dc27a4c20fb90a76bf122f (commit) via 9cc00c562369fe0b9149eb2aeee090cf52167285 (commit) via c3190d9d70febdd1dbc15269e970f32aeda33f76 (commit) via 2cfceb2700c9af0ea0f6429f214116e9d90b43d8 (commit) via 2c3c49cd374050bcc30145c929a1dd9eef019cc5 (commit) via e8089003caf0ab2eb1f2afa2d548422cb4377ab9 (commit) via d06b60db7151a6d79697866da15afa23cd99c703 (commit) via 9922dc263ea7f5584dc20003e998ad69812a8988 (commit) via db5d4e10de0b603330523b4ef9b81d6fdce18ecc (commit) via 57230a2e8ca2287beeefff93477aca344af845d4 (commit) via df45d5b1acb0ed76c06d09ae82a46fbaf3795593 (commit) via 73f26e4d24b5b05d816cd5c301c958b6049c550a (commit) via 7bf0620eb5848cf0a13e4a3b6eee45f880d8dd01 (commit) via ae199f2eb9f7b104e5aeaeea6301cc025dba23e3 (commit) via c634a73c95ee11a09e84dbc40e10aec24ffddc36 (commit) via bd857b6a9cddffa0412044bad85d88db5b3c0468 (commit) via d1db7f1edfabdc4da52b46b7251e8118fec7a57d (commit) via 98f41223981f667deeae57aea200c12d6e108900 (commit) via 55553f1a38d6e016affcacd0d406aedbb77692b2 (commit) via 9dfd17b104fd048aa07ab2ae5b87bfd94b07c807 (commit) via 4fdf79332798732a18dbf1877c46353cd1b6250b (commit) via e5eb3e480dd2d1212e969a39ae238df8c59c79e8 (commit) via 807a6c93d8c04403c10196ae3ba2b96136899e96 (commit) via 777932efc61a62d6ad56ecd620a76972e438478a (commit) via 554d3c9cd206827d066bc65010907750fdd01199 (commit) via 3fb92333aeb8134b2afaacf4c721704947552b82 (commit) via 7ff58d9bca21271910571fbb11bed80cfac16083 (commit) via 42100cb868eb3c50c7752f2adaf396bda6e894a1 (commit) via f98cf967bd38eb52a321321cb555c0c302a14318 (commit) via 2d7c2421f6f87440332617870b620e6ecb16a031 (commit) via b08dc851c768f9f365127546f66414a00eca46bd (commit) via ac9c89de65f29411c435a3ed38abf333fd7b1b09 (commit) via c1301a486217f0027e11ae90816006f723bf4b9e (commit) via 9b705928c2088a2c380800eed72c04b5b730ff92 (commit) via f942ad09f67f1467b11f678d9c17ecedb0b3db45 (commit) via 4df45ca7ced59a0d6dcc603d898e6cc41bfc2aed (commit) via ddf8d8704d333454ca0e8ba3650835aa86f6abfc (commit) via a106c762efecc9ed00cae26dac02b19359b8dcf8 (commit) via 690f1c3c400f46a19bef82aeeb15210667ad0843 (commit) via 2aa826095739b5357350895b57dd9980fc06f8a0 (commit) via 4e13791a09a034c043f6296c001566b6ab33b668 (commit) via 997cf938bd56c83642e39e517de7f6c077683076 (commit) via a6f58356dcaf09c3fffaad1c4ec1e3488840a43c (commit) via 72edf4e2506f20f0d3ade69582c48f1b7521c610 (commit) via eb5d12c4b97b11c3dcf16cc9d245b631f4389e59 (commit) via 3d38b87d86736a976dd28f03b989282e093191bb (commit) via 93ea677ec4bc61966966cc71a67bbbca4125d607 (commit) via c7217638586c0f12ac02f4cf424f3eae070dcd2d (commit) via c1719a8bf385fc1919b814d2ba37464691fa82b4 (commit) via 5639b8014afd467ddf25b18dcfe993b497c97caa (commit) via 841e24d304312cf89c5841f6624ae99f7ed0a589 (commit) via d122ba3a53d33d08b92ec5436ea819a1ee52be42 (commit) via 37e364b2411a9bead0d35192f7f9bbb7d66bc775 (commit) via 182112c10de7ad8082f2fce02d714cb8fb8c7b27 (commit) via 2a368b3ab6ae4197141b386e669956530c74aa8f (commit) via 83e8adccde258256aae115e684be6ebeebb02d2b (commit) via 85c9780f43fb215258f66ab6a55d1ed4ba0af474 (commit) via bcefb0c8e6d9f87430cdee5ec966443f1c6cbfcf (commit) via 5dbc1d8d1c14aea4fda820567d6ac0e226027ed3 (commit) via 33708998b4e0fdc47132f00b6d1e081c86fdbf6a (commit) via 7c6f5c9172734c044a02ed15330021be49d47cfa (commit) via 80cd3859d1db72d77a85035d572d8a02aa3d8d84 (commit) via be143963f6de7f33ec9c3f300efabf156596b7d7 (commit) via 88abff68df5fcea46e1f7f0a32d7fe8718fd67c0 (commit) via fb4953a13c1ac6e5b54a347769c5f05e8fd6ab28 (commit) via fc9af81a13ec53ca15cbd28ce1896d407ab2bf8a (commit) via a7e29d8b66dd7c1cb691966938404dafc6b89689 (commit) via 369cdcc5533e46cb28437557d6827ba0172710c3 (commit) via c51560985a43592a79c29baba4f79f399a8e15dd (commit) via d769b7cb7ae203b784a4f440d93624bb5c6bae81 (commit) via 3f2f16411fb2f9582294227594549fb8fdd9a227 (commit) via 4e87f6c01a7bd0dc29959492e758eb6fae0a9fc9 (commit) via 5f24a78113ab01b68d36dc7263e23adb39dc1707 (commit) via 21c0ba7bfe41df434e0896d3c42a8d2c816911fb (commit) via 22b5ffad861b2efede6d64d16e38710d2c713ba1 (commit) via 0a8d6cf97e0dccc02cb36f2636feb053725118da (commit) via 958374f352c0d1c238355a6434e0222e754f43f1 (commit) via 7c56f4776b0e78ae0581e5df672e20f6ee1bf56d (commit) via 8934ddfe73762e6226c2c8b7b21119e3d0b13604 (commit) via af0f49e80dce20b50ca757b52c2454e137ce1c74 (commit) via 94479aded162aecce6289bdf26f95073bed0dc55 (commit) via 7ec5dead2ffc03f009398a0a30217052e6749ad0 (commit) via 51e0d22ec6db124abca69a1cc35905c9342c884a (commit) via aaa980e356a844b89f0a25ce34bd88956d8fc79d (commit) via 7a911f29271d1e075ff1861eafa9393589c9896a (commit) via 69e1bdd62bcb32291b9ba4ac414be5bfab34de2b (commit) via bde402840f9930e8930d2f31ce19229e00496954 (commit) via 0655931f606efc086e8526c7f4a687ac6477686e (commit) via a6a5b552ece22737d04cdd92b05edacc0a3accf6 (commit) via 15746e5922159265468e3d5d19b2feb7b769a57a (commit) via 7a19320df18adae30d974949f20cbae976b4b0ed (commit) via b5e744bca246072d4d2c446752f909dd1081bfcf (commit) via 8738b3e45ac131322ed6f1700b1ce77f8e8f5d8f (commit) via c53412f7db226b99e6e747364ff75e7788ed3575 (commit) via 985f7d023e1461b5e58b37b4e207b3665278df51 (commit) via 5699243ce1bea325e552566ac75472254bf75ee0 (commit) via e80b40adbe823be084fb49cd84336939916120bb (commit) via 6f93baced0fba7d07425e14ea698f4607964c6ed (commit) via b3394a76ab58d7e604e67e4b6f54ad3c6d157b4e (commit) via f5f6ceeb66a1d81ef4e10059dae9c713eb8cded2 (commit) via e429e9ac7ed044c361d2306bdd1c30290daf1814 (commit) via 603bb5097d01740edc20c279d8d8f7aea1949710 (commit) via 7165b608794566d6bdb973bdc20706dc0aaeab51 (commit) via 2941018a721b362d13e7fd854dff56221aac00f7 (commit) via eef3c8434d556ad4d3fd9b0f4fdf912145f2670d (commit) via a65391f9014acd5cb8e4fe09ef8b2fac4716c024 (commit) via 29798bb8c931ca6a999bc5fccf14877f6ffcc1fb (commit) via 929553522037cfd909f8aada07adec1a6b582612 (commit) via ae2e9d669be1f769105580ae6faf1270bc1543c5 (commit) via 5a5d9348b0c3aa7780afc588293233133a063636 (commit) via 3b64fc008f17d9a35120897f838874e821423bee (commit) via 82b26b686e49dcb0fa15f8d585d47a569f798403 (commit) via c0226ea401fd13f4f368ddf1d7013aaf6049978f (commit) via f0681d01759a876101c3210c8a5b8bbb0e4d22a2 (commit) via ae613193856c363c3492ec20cfd8af6543271f3b (commit) via d19fa312475089553a47be9057082b10b633679d (commit) via 1a07d97fd70d1d0f2f22ccf41d09a1a5e0050666 (commit) via 1e16be7556eddc913fb1d5410a22f95a77cb37ff (commit) via fdfa22979374b9790667232f33347a08c297aba4 (commit) via fb9abcf2d4c50c2ff528ee2ed5750fbab48743bf (commit) via 4690aa119c4a94d85b18e34828cb9016574ecd77 (commit) via 3b2e9998132d28b73f311727b7b2fd6803f42a66 (commit) via 96cb041ea3e62ca557514ee3a05a0b13a104465b (commit) via c29da51613747278bd1a3744cdc191de68d7933b (commit) via 3a622f976405402cc5f0db4d8dcfa182f08f646d (commit) via 58e4910ee70ba5dbcbc2e0dbaf2b4673ec70af90 (commit) via cc040d88c8c16b7560faeef0cc800513dd3e2e5a (commit) via 0f3aa8522e966205039a88f1ce7faae4adaefa23 (commit) via dbe9be2f0628914491e3e4265511b6c3026ed6ac (commit) via 6b22e4e85af3f8df9e1d1bc71a95c3f8898324e5 (commit) via dce8682e10622aa24ee1d7bbe499d8107e429011 (commit) via 0b997f3a3aa63224f4a4578c34cee4f074d66876 (commit) via 8bf24f51cbb285c31a6b7101f63257d2010f7082 (commit) via d239da264c5d0ca2ecfd609ae3eccced939a4c46 (commit) via a79b7986cddf40a8ade57638916951323fff581e (commit) via 7ade1695baf1f32333bc2a3498c35ef7659af77f (commit) via ba3830e03bad6e5e5cfb9d88342e9953efba520b (commit) via 5a9edf2a91476453aaee3137b704a1af80b33a44 (commit) via 1e05c57cca59c0469e19b74ec6a47a1669059d41 (commit) via 51d83583c1b6fcaafa8c31e76568b861d1144787 (commit) via 8a08237d23017644336fa895b5bbde1a3d18fe57 (commit) via e0d04a752aebd91bc368932364c086576962c26d (commit) via e7b50f47519637d4e21eb25d7ef30f14cf5d10fc (commit) via 61c6f1a62227c75464beb39f184ea8e658a6c763 (commit) via c6a065ee7ae37449a5491a12f2956119a2095a28 (commit) via 6bd539d51f45a756f40ee2a5c3712845c6f5a1a4 (commit) via e3ce3a6f793ab995b48766533f0a0d25356d09bf (commit) via a3857b2f6f47928f2d9f4bbdeb57ca26a3728981 (commit) via f1c87809deceacb59f61055f674c7778376f2d6e (commit) via b10179faf2706cc4182534f93b571b30fef4505b (commit) via df6b67d54d1bd8d7dbba132d9d58dc50afbb1116 (commit) via d1fe22d14e6a4cbc27728bcd45b5f646dc59a5ac (commit) via f71b148eddc49ab59409999a497b88db488f0fe9 (commit) via a382ed35fed2b1104fc588e5d665be76af42cd98 (commit) via 4f146fa95f21f01ad09e62a3dcc557b1a355a64c (commit) via 5dc7ce6cccd8c4671ca609ae24cdb28c77ea811b (commit) via 9b4c96334d18dec20f19e4db174f2eef28d03522 (commit) via 07e8707d7346fc359a342877f919f2a8c231a47b (commit) via ea60ed427e00232c306ae3e5ffd5ea0ddccb8160 (commit) via 3d846aceabb6426d1ec8f21761234ed384003ecb (commit) via d20629e0f087c8e1aff261a7a15d0a8aac83e54b (commit) via 5bb763a9187397d3a6dd81c50cfc5f1a9db7eff5 (commit) via 4ac11e0fa1ed1aea6853693aea04d0c691ef7127 (commit) via 08fda63936f044e5e61f48f11067f5b80eac045c (commit) via 7a2fae2b796550eecaa03cf5e6631fa6a73ff7b5 (commit) via d383e34408a2183a1e97273ea2789511e0a7d1ae (commit) via 8c87af98801626cb557eb3b06ab47cda853ec3e2 (commit) via 1a7d65d08557c2b1ad9a4a563fc4dc86ed1af269 (commit) via c8c268626c3219bbb20c639b88f18656081869e2 (commit) via 0bde3e96f0c51ed141e94ae82eed24f1a38f712c (commit) via af6dee35715a4079acaa7d9a413b6f7d859c8c8b (commit) via 487eae350743ede43432ebef49268cc670d82fb2 (commit) via 7dcf57719f6470cdfab4e3972d30097840b6fb11 (commit) via 4b7700db4b4a352db05e59e48cb729045e805295 (commit) via 098fbc70ee43f0b38208068e842325a252770fda (commit) via 9aa42e89c3fdc83ad2fa4ab17a2686d79be44a62 (commit) via 404d004907228c14fe66959f5d34d52d0cae3f13 (commit) via 3d58a16038731bfe3f234756830ab300cf5c4dea (commit) via 296f1f35d87935869f8b646c86430f39a1904ba2 (commit) via 25a0583ec8d760bb6aacf52b672556e57029727b (commit) via 077124097d457514fdffa77209e6615b97dc6753 (commit) via 564a3fae124afaaf6b2d7f2b9cda716fbd7f6f14 (commit) via 3ab56e1c2af911ad532f77dd03653d82aeadd0ea (commit) via 9b5e56802309f04eb7172cf94927c8caa3bfb401 (commit) via 1fa22c2ee9afd8e2d2b39c24428779b7ca815aa2 (commit) via 3c35f278b99ad3f6b4ab6d58bc3405e008c2021e (commit) via 771e581b94b66c17033e5490f6d1fd591da9026f (commit) via b9210c72f547b5f9b0fb84f28c68a801acaa54fe (commit) via a8088cce8806d78eb6f9c20300969901c9258068 (commit) via 1fcc10c17e78617dad08fa32e692ac03988cc12c (commit) via de1017462905748e92c328559683d55569f0b68f (commit) via 6f84e1b5f3a87489785a7ee31049d83823ceb0b9 (commit) via f9307105855036231db67a840b9d1be464750990 (commit) via d17c26eafb44a5d2b9728285e018a6b984d4cb14 (commit) via 5daead33aedc5df06da0aacfeb05136fdfd625a0 (commit) via 3b4aabe8181a7636d09aae7b926e9d3b00be0294 (commit) via 998507d327b9c57d5b3a9627bc5a1dcd40e4756d (commit) via ea8d0c51b3a7ec0331e7c09c45a8d05267f6163a (commit) via 5bdd3332407e22d044df97dfa4e4e08e66352d60 (commit) via c7c5e2abb1d75d252f0b48e98ba1de1f2b40e8cc (commit) via 727fac4559402b0efbe64309355db1c86babb9fc (commit) via 0b124bff9b5e6c185e941520624e7c4cd43dcbae (commit) via d5f0157c0967eb547de1799331163ce5cbd88b00 (commit) via 0c4a307ee5d94bedf7410c5b0d0e18ae502561f5 (commit) via d089cca16b56fd72a69373e97b79eaca8f9e154b (commit) via f31e9b31545b814e77e30b9a0f70e2f0e3f0afa4 (commit) via 95bb65ff258e2c818a1233887f3932fa9a0e856a (commit) via b60a60717f8d3ac23253f5cc1767c8a8c58f06a3 (commit) via ead32b56281f2f33b4b9bdc69df79516e515860b (commit) via c693522e3312d4b7c4e4f68409e39f1000644631 (commit) via c791549a778aa34d83154b27fc9cd272e0d14881 (commit) via 9bf40d4a6e507e10c8429a758ac190146caf48d6 (commit) via c5dbcca2e4f3613f04e74715269c611dbb5259d1 (commit) via 26222c96bb5708fdff87d1d8ebbab57f8b4b1fef (commit) via 2677b07073c6b45a286532b05b9fc26c9e1b4d70 (commit) via fb8b28005f53909e5b5a2ad8dc083b1a9e2a0fed (commit) via 422f1c0fb1daa84cb14982defe62c067bf8e5342 (commit) via 456c3ff4a3fb10d959fea5d8a277e13fb0a76b62 (commit) via 2980e2523ada89017037e2125cebbfb47e2f3578 (commit) via 005ddc1d8b2aa079a39ace6cd65a5d2ed24aed11 (commit) via f8670a96c8c23af062f08a218fc160219412ea9d (commit) via 02f7c444691239a79520e1420035e4bf215b4d1a (commit) via b9341ad2d98af1a2c22b339dd2990f527d339a91 (commit) via 6aa3502306ca6acc7f15f894731b847bd75f6a4b (commit) via e3329cdc313e2a4c1e35a0f9d4f8777e3f9a77e1 (commit) via fbeca26f035fe6a2a9632dee6d691629a6003d28 (commit) via 25425839cfe06b6d6b3dbd5a0fc6c4ed6fed9546 (commit) via 538f0883f73d385922a47ac7a2cd13f0e5c5ec9e (commit) via 9b9f3098aca13e76eed16d085bb8bf156f630558 (commit) via ccc931b0a7568b468d4eac613334000de82ded90 (commit) via bdccb597fee6dc6a8455c6727ca81ddcc912acf4 (commit) via a094154abefe7edced12cc06ded5563756847f83 (commit) via 3a2773c9efd9da84c807150e32819b2c4afe6286 (commit) via 5c52ab7e45241af5c936ac391cac386d224f2e86 (commit) via 22f17f918c20c6934edfdffd96942e45c0b2e28b (commit) via 9715aff0bd9c84a76e0dd364829cecde2a8a3610 (commit) via 3939ebe2738f85962d2a6152174d6e555aa82ff0 (commit) via e65ce97f1ad432519a6dc2e6618683d9f7dbf27b (commit) via e641846837477b6cefa3e70d25ee45f4713096b2 (commit) via f1edf22602cf5bdab93c4e1f6362419a0c261200 (commit) via 4b1bd4742ce8049b9c349ce155c1da7d0f18fa59 (commit) via 777acc73daaaca7bfe040354a6bacbc905329e45 (commit) via cb7eef8ff8a33ff2513e2e28a63922003e0cf9c3 (commit) via 71c68662c85cdc786068d7c784d459cf2c14c4a9 (commit) via 137ab7d5681486c6d6cc8faac4300b7cd4ec0cf1 (commit) via 5153a7aba255cfcecb6e766e6dfc90ab82e8f8f7 (commit) via 6e844dc46ad56d5ea9439c7e49c67251fdfb9900 (commit) via 9578e70d72c392d3491f1caead54fa8b1cc44165 (commit) via 540cdaf54c19ab11b93fa8b25da6009fb53d8961 (commit) via 971333665c1c74f22c3c6cd211f3edc5c0b28e00 (commit) via c18bc1291d42423e907d2ce0b3d4f39ecd59e675 (commit) via 62f06b71962063736bfa359074802e3a51271308 (commit) via b8ea5eb69df28601affec012dd3ae93799e6293b (commit) via 588bcb172312d3e178ef8627b2fd2eee4bcd0c0f (commit) via e0ccf38585115aa6c3ebe14f41353d5d78e2d039 (commit) via 56f1feb678c7dc1f3a26dfbad921bbc2605e0711 (commit) via 5a3addd8eb3f7d2d8c8ceaf2789881ff9540bf31 (commit) via 5f0f2d610fe0a53ff15d60821f77b3aec0f75b22 (commit) via 8bc43e66a90b60a10d78a18b0a2f9caf55378435 (commit) via 340fc6f08aa4282440df4038721a2153fc7ebb12 (commit) via 7ca62cc8159ba6e62a81aba712e79792f78318f8 (commit) via 4d0e0da64f19c40c1ebef0b1511e17272bcd33a8 (commit) via 5f6571913b74c251abb45d2fec8c66f3c7cbe36d (commit) via bad83f249fa583e1f26224a9bd7b557f6d790c08 (commit) via 8642d72f36239267c474ef096252dc64ac6fd710 (commit) via f5e7f273c98aadc26cd2549df84a24ead50182dc (commit) via f8b67cb931a94ba3e2e2bd252b05c4779cc0ecda (commit) via 28b463649fcc02fa5e639b5ae65313ad2f6fb0d1 (commit) via c7ce426f84a8fb5f7f4739b15d85f68ef2a05e03 (commit) via 5bb5158b2e58614daa1226154a5b72caa3c8bf03 (commit) via 386f354f878c1a72ef3c3eba708f936261fb7e09 (commit) via 5fcb223263880ad71b86b164d6dbc020c75e0549 (commit) via 8d6202df4559d144bc8edc6fdf4bfa6112fe746f (commit) via e30374d1691c5728cc979e9682ad4e99ea5c8252 (commit) via c2dee336304a0bfb4e53ec3786c637b5c96903ba (commit) via b1a2bef8bda4e8472757549b567fe5b775d481aa (commit) via 59688d3ec68818db7649b8cab9127f09ff6f5a1c (commit) via 6a949ed1556f239a84a7ccb8d3b207f99cdf71c8 (commit) via 13a9c636a52ae2c6e2bc2070f4a4f047afe6a6ef (commit) via 5f1ed2b221758c317b639dd1823b3d7b957c0c8f (commit) via c60d7bb199afbd752aaa3640cfee222585dd3e25 (commit) via 7d88ca5cf98d8b3dab93e02f4e9136ca699a0400 (commit) via 5e202c026803954b8e3b709e335b10da6bc93dbc (commit) via 22d791d0aa2b80bb44aa9bcfbbc8b20c545bf1eb (commit) via 04685ac8fc200cec4582e923db0d0989b59d6d21 (commit) via 65276a4ebb734ffcd3e33defed23af9e637ec116 (commit) via d5d815189d98745e3b33a6caadd4c2dc5648a114 (commit) via d41d0f71485fdad56b27eac08c06cd3d0235013d (commit) via 7c149491452e605bdd1df225abf11de7b5e61ccf (commit) via 14009cefe89df8e50224c44887482842668b9dab (commit) via 271d6c14ef598e18e335a932d466265376ac6c6f (commit) via 8a83e4d9ea7f75030e41396ce66abbec4c6e8be4 (commit) via 54f6df525e57513398e348b76cd7395e6a4b1298 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c75d41451966d864ab722c4f31a018a2c55bd526) \ N -- N -- N (1ed88ce36dd9a7e0dc07d04cb2836f9b8ea4a304) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/wireshark/commit/?id=1ed88ce36dd9a7e0dc07d04cb2836f… commit 1ed88ce36dd9a7e0dc07d04cb2836f9b8ea4a304 Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Feb 22 21:50:13 2018 +0100 Add dissector for OsmoTRX protocol Change-Id: I31f5071d08eff1731f1d602886e204c87eed107c http://cgit.osmocom.org/wireshark/commit/?id=5b13126fd99b8917d6e6c59a6807cd… commit 5b13126fd99b8917d6e6c59a6807cdd8fbf4a54e Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Dec 19 23:22:23 2017 +0100 Dissector for the Osmocom GSUP Protocol The Osmocom GSUP protocol is a light-weight alternative to the classic GSM MAP protocol. It operates between (MSC|SGSN) and HLR. Change-Id: I954c7e332dce3a8855f7f4ace0b878f66da6f02e http://cgit.osmocom.org/wireshark/commit/?id=b50500b542630a695d370fb215ecbf… commit b50500b542630a695d370fb215ecbfde9bbb9ef1 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Jan 7 18:08:21 2017 +0100 WIP: Qualcomm DIAG Protocol support Change-Id: I0bd06c46e00570005a1148860954a77c8f5445a8 http://cgit.osmocom.org/wireshark/commit/?id=7d1d6f24d2c40c885761deb31a2c06… commit 7d1d6f24d2c40c885761deb31a2c066758eecf81 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Dec 2 16:44:20 2016 +0100 WIP: RSL Ericsson support Change-Id: I1e9b3c08848f4feb60361e629d7225b6d2e1dcbd http://cgit.osmocom.org/wireshark/commit/?id=b21bcb2b69c1f641cb8241da34b5f1… commit b21bcb2b69c1f641cb8241da34b5f12752efdec4 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Oct 26 22:38:20 2016 +0200 HACK: Hand GPRS RLC payload to GPRS LLC dissector this is an ugly hack, as there is no code for packet re-assembly in betwween, i.e. we only get proper dissection if the LLC message was fitting entirely into one RLC block. Nevertheless, sufficient to see things like RAU, ATTACH, IDENTITY procedures. Change-Id: I1fc488aa58353e5f4264b940f9f4c18987148a7d http://cgit.osmocom.org/wireshark/commit/?id=a7cf245eb515c546e57037f37535d7… commit a7cf245eb515c546e57037f37535d76c13d2afdc Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Oct 26 20:09:31 2016 +0200 WIP: Jacob's EGPRS patch ... with add_new_data_source() to visualize the re-aligned bits Change-Id: I1604dceaf3d91228e87712e099c8a209ff812f4a http://cgit.osmocom.org/wireshark/commit/?id=57af17e3ee6bb08a608e99f8e0ecde… commit 57af17e3ee6bb08a608e99f8e0ecdea5265512a1 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jul 17 16:22:19 2016 +0200 l2tp: Introduce preference for default pseudowire In some cases, the establishment of the L2TP session is not captured in the pcap file, and thus wireshark cannot determine the l2tp pseudowire to be used for decode. So rather than using a ocmpile-time hard-coded default of cisco hdlc, let's introduce a prference where the user can select the default pseudowire in such cases. Change-Id: I44a6373d4812c9ab5a919514273a41a2ab57142c http://cgit.osmocom.org/wireshark/commit/?id=07f2f909746821f86b3de87d4c1897… commit 07f2f909746821f86b3de87d4c1897caca1c3ea5 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Jul 16 15:39:17 2016 +0200 L2TP: Add preference to select Ericsson HDLC flavor At some point over the wireshark last years, the connection between the L2TP dissector and the Ericsson HDLC dissector (packet-ehdlc.c) got broken. I cannot poinpoint the exact change when it broke. However, traces with Ericsson L2TP that used to display correctly no longer do so. The problem with Ericsson L2TP is that they simply re-use the HDLC pseudowire (0x0006), but then have frames completely different than what's specified in the RFCs for that. To address this, let's add a protocol preference to allow the user to choose. Change-Id: Idce022ef0f233c01ecffc67dca7f428bde31ef6b http://cgit.osmocom.org/wireshark/commit/?id=6e75a0b2774401fb184fc92db779aa… commit 6e75a0b2774401fb184fc92db779aa6defab10aa Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 27 14:08:35 2018 +0100 ber/per: assert actx to avoid null dereference (found by clang). Change-Id: I4efc6d30060bf8842d5facdd3151385b805fe22b Reviewed-on: https://code.wireshark.org/review/26136 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba179a7ef7e660d788cbaade65982f… commit ba179a7ef7e660d788cbaade65982ffc7249b91f Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Mar 11 19:49:44 2018 +0100 eth: fix null pointer dereference when called from Lua At the moment, Lua dissectors always pass a NULL data parameter, so dissectors like eth should gracefully handle that. Bug: 14293 Change-Id: Ida4d0530a9c417db5960475274315d4acc3704a8 Fixes: v2.1.0rc0-1575-g8ec153f938 ("Have the "maybe an FCS" version of the Ethernet dissector take a data argument.") Reviewed-on: https://code.wireshark.org/review/26431 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7e842fa5514c79046d7d1986b0b379… commit 7e842fa5514c79046d7d1986b0b379c3d4f9ce2c Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Mar 11 07:52:56 2018 -0400 F5ETHTRAILER: Initial cleanup from submission The dissector had been a plugin since at least 1.3 (based on comments in the dissector). Not all of the most current APIs were used for functionality and there was some cruft left over. Also disable F5ETHTRAILER by default since it doesn't have a discriminating heuristic. Change-Id: I8c977167a906eafd6fbb663d2fe6c44f080f2209 Reviewed-on: https://code.wireshark.org/review/26428 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f2f7f7e5577dee645ae52b36a07959… commit f2f7f7e5577dee645ae52b36a0795934624c24eb Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Mar 10 17:10:25 2018 -0500 Add wmem alloc parameter to ws_find_media_type_parameter. All current uses of ws_find_media_type_parameter need wmem_packet_scope(), but there is no sense in limiting what other dissectors may want to do. Change-Id: I35b0dd2a024a0ae0a8345577dd92a1a21ddd2cc4 Reviewed-on: https://code.wireshark.org/review/26427 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=68efae8588dc88254e5b0ee2a40090… commit 68efae8588dc88254e5b0ee2a4009012be332381 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Wed Jan 24 04:00:07 2018 +0100 Adapt to current WS code base to make it compile and run without warnings or errors Change-Id: I135df8b0e49346e32a19620d52cd1a9a44b4ac08 Reviewed-on: https://code.wireshark.org/review/26426 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=2a3b58d1333df1d505c4947c22b238… commit 2a3b58d1333df1d505c4947c22b2388d5491b689 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Sat Mar 10 08:36:31 2018 +0100 Resolve the F5PROTO_TREE_ADD... macros: They render our check-scripts ineffective. Change-Id: Iea46eb7d20702ee07e13f75469014d468f36ad85 Reviewed-on: https://code.wireshark.org/review/26425 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=85c4d2f583d6a84047fca40ed39d91… commit 85c4d2f583d6a84047fca40ed39d9129ab4ffca7 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Wed Jan 24 03:30:40 2018 +0100 Import f5 Wireshark plugin for the f5 ethernet trailer Version 1.11 for WS 2.4 from https://devcentral.f5.com/d/wireshark-plugin (login required). Change-Id: I00872793061ff23bce41fe71b2ae6c31f064bafd Reviewed-on: https://code.wireshark.org/review/26424 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=55573495c83e21ed41f94ceb57c13d… commit 55573495c83e21ed41f94ceb57c13da3f99ad599 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Mar 11 08:19:53 2018 +0000 [Automatic update for 2018-03-11] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Iac7e2b50ed60639dde90946632811753288110d6 Reviewed-on: https://code.wireshark.org/review/26421 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=cbe424b27dbcf51c9d5c6c35ec927e… commit cbe424b27dbcf51c9d5c6c35ec927ecf4e60a25a Author: Robert Sauter <sauter(a)locoslab.com> Date: Thu Mar 8 14:30:02 2018 +0100 IEEE 802.15.4: show MIC and key number for decryption - show the MIC of the received packet - show only payload (without) MIC as data when decryption failed - show key number (UAT row index) used for decryption - small cleanups Change-Id: I7815349e99b178c219a0e649d3d65f0b6eaa7201 Reviewed-on: https://code.wireshark.org/review/26362 Reviewed-by: Ed Beroset <beroset(a)ieee.org> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=45366965071840698a3fa11aace1d8… commit 45366965071840698a3fa11aace1d8eadae1802c Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Mar 11 07:36:49 2018 +0100 DOF: restore correct memory scope for decrypted buffer Change-Id: I143f73f7921187bac5de46cd07344b015a06a578 Reviewed-on: https://code.wireshark.org/review/26420 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fc6b725b18d9d627534c3b61720f5b… commit fc6b725b18d9d627534c3b61720f5be93315ce09 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sat Mar 10 23:14:12 2018 +0100 tfs: Add high_normal and low_normal Change-Id: Ie56e3546fc1bc5da61f95456e15544a2880c819d Reviewed-on: https://code.wireshark.org/review/26418 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3ceff6751471edc205894f8f2b6d05… commit 3ceff6751471edc205894f8f2b6d050f3a803502 Author: Dario Lombardo <lomato(a)gmail.com> Date: Sat Mar 10 19:33:46 2018 +0100 maxmind: check val_start before using it. Change-Id: Id3ee8e8d4c54c02d68048ec677fdda599b329713 Reviewed-on: https://code.wireshark.org/review/26417 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=2a9097046e51d67794780bb57e9422… commit 2a9097046e51d67794780bb57e94229e769fc01b Author: Dario Lombardo <lomato(a)gmail.com> Date: Sat Mar 10 19:23:17 2018 +0100 maxmind: use ws_strtou32 to convert AS numbers. Change-Id: I0578f8a674feee6e4763d5481a2285b7b2a054dc Reviewed-on: https://code.wireshark.org/review/26416 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ab7fbb73951716ee08406fc1a51fc5… commit ab7fbb73951716ee08406fc1a51fc522da2c420d Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Mar 10 10:14:25 2018 +0100 gryphon: fix 'gryphon.usdt.action_flags' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT8 Change-Id: Id273b1f80728042122b6bfa3053d263b25f6bdbe Reviewed-on: https://code.wireshark.org/review/26412 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2ecb33c039d75d851bb4fc4e72c8f8… commit 2ecb33c039d75d851bb4fc4e72c8f8a389c9ab55 Author: Dylan Ulis <daulis0(a)gmail.com> Date: Thu Feb 15 14:11:06 2018 -0500 ENIP packets are not decoded as ENIP anymore The length check in dissect_enip_tcp() was previously removed but it's necessary to filter out one byte messages that are mostly likely TCP keep alives. Bug: 14434 Change-Id: I44c10aaf0a2e06870ad82f87aab9d72548b77f9f Reviewed-on: https://code.wireshark.org/review/25807 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6a819d9950e41244b742073f0962e2… commit 6a819d9950e41244b742073f0962e2c5a80eb735 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Mar 10 09:18:03 2018 -0800 MaxMindDB: Add country ISO codes. Add and dissect country ISO codes. Prefer them when printing summary information. Change-Id: I3ce2bde88fa5ca2604c8bb745c42f239660252ff Reviewed-on: https://code.wireshark.org/review/26415 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=5564c222e27740166ec36f0cc1e858… commit 5564c222e27740166ec36f0cc1e858bcb429f68c Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Mar 10 09:20:12 2018 -0800 MaxMind DB: Fixup IPv6 address interning. Intern IPv6 addresses into their own hash table. Change-Id: I1ad60bf56585fcd89964e949e8754af3c7512a75 Reviewed-on: https://code.wireshark.org/review/26414 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=aae6b8442cca8373d77980144b1421… commit aae6b8442cca8373d77980144b1421474fee5c3d Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Mar 8 17:17:15 2018 -0800 Process MaxMind DB data one line at a time. Use fgets instead of ws_read + g_strsplit. Change-Id: I9d13183cc129e0c749742779f9c48fdfba21a8fc Reviewed-on: https://code.wireshark.org/review/26374 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=957b4a67efe716c31a8a54453ed62f… commit 957b4a67efe716c31a8a54453ed62f02738ff984 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sat Mar 10 13:52:04 2018 +0100 Add tfs_activated_deactivated Change-Id: I383ee93ec2a06ed2c2d07b702436035566591348 Reviewed-on: https://code.wireshark.org/review/26413 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b9f203c1da43ba0e11bf8e1c6cc4c7… commit b9f203c1da43ba0e11bf8e1c6cc4c74e60f49402 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 21:19:26 2018 -0800 Don't put a comma after the last item in an enum list. C prior to C99 and C++ prior to C++11 don't allow a comma there; we require C99, at least on UN*X, but don't require C++11. Change-Id: Ia652de44315d4d87e75f583317b7b1069c8804e7 Reviewed-on: https://code.wireshark.org/review/26411 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b8375119e39bebed34344cf1a6953a… commit b8375119e39bebed34344cf1a6953af1532d2b62 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 17:51:51 2018 -0800 Avoid the realloc() warning from VS Code Analyzer. It's not just worrying about the lack of a check for a null return, it's worried about the leak. Assign the result to a different variable and, if the result is null, free the old data before exiting, and if it's not null, assign the new variable to the one we're using as a pointer to the array. Change-Id: Ia1d5d271293e13708c35a7562a1f40671304c417 Reviewed-on: https://code.wireshark.org/review/26410 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dcc3875847d691776affae66dcfdb2… commit dcc3875847d691776affae66dcfdb2ccfa5674e7 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Mar 9 10:25:40 2018 -0800 Add ws_pipe_kill_child_on_exit. Add ws_pipe_kill_child_on_exit, which associates a child process handle with a job object that has the JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE flag set. Call it when we create a process in ws_pipe_spawn_sync and ws_pipe_spawn_async. Note that we might want to use it elsewhere. Change-Id: Ia0f6863ea4df0ab8623bb923a49da7776d83bd33 Reviewed-on: https://code.wireshark.org/review/26398 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=5213c30f3b27c0e501ca7543dfae94… commit 5213c30f3b27c0e501ca7543dfae948651da6277 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 12:13:36 2018 -0800 Regenerate dissector from updated template. Change-Id: I929cc88942548b537b2faeb641d582c1dcb2ed27 Reviewed-on: https://code.wireshark.org/review/26406 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=986c6b2e77b5493d5b718febab4e90… commit 986c6b2e77b5493d5b718febab4e9086afbee12f Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 12:11:30 2018 -0800 Regenerate dissector. Change-Id: I87888e6c7cca4be4d973134be05581fb1cddbbe8 Reviewed-on: https://code.wireshark.org/review/26405 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=28da001090d3de12f30f4f5392338e… commit 28da001090d3de12f30f4f5392338e10c3972d20 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 11:57:55 2018 -0800 Put a variable inside the block in which it's used. Change-Id: I8fcd694924458c124b43734fe5ded42cdf2d0174 Reviewed-on: https://code.wireshark.org/review/26404 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=66a1fefac416136b96b7a1683293d6… commit 66a1fefac416136b96b7a1683293d6a06f5c00e8 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Mar 9 18:47:51 2018 +0100 kerberos: remove leak (found by clang). Change-Id: I70242960466b276cf9ffb62fda62dcb40c17c1fe Reviewed-on: https://code.wireshark.org/review/26396 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=190b2e89c3767b3a5b87afc58d45d5… commit 190b2e89c3767b3a5b87afc58d45d58d5d848f27 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 11:28:00 2018 -0800 entry_data.type is unsigned, so print it with %u. This should squelch a warning from VS Code Analyzer. Change-Id: I69e528c3dfd851d287b1faebc1469cd700fa9ef5 Reviewed-on: https://code.wireshark.org/review/26402 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5a4468ccafed43749a48a839ce227e… commit 5a4468ccafed43749a48a839ce227e030304745b Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 9 11:09:49 2018 -0800 Check for realloc() failing. Unlikely, but not impossible, and should squelch a VS Code Analyzer warning. Change-Id: I399c08896a3f08962ca46483d47ba5f6cbe4f28e Reviewed-on: https://code.wireshark.org/review/26400 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8acf0305a3bdb6ee3b37c5a9b6f5cb… commit 8acf0305a3bdb6ee3b37c5a9b6f5cb3e342abe20 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Fri Mar 9 15:41:17 2018 +0100 spdx: use consistent formatting for GPL-2.0-or-later Change-Id: If8ffe67f6b624d7f1bcaa278a146e41247720226 Reviewed-on: https://code.wireshark.org/review/26393 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c2639090de67e0100653741680b70f… commit c2639090de67e0100653741680b70f2ae17a3fa4 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Mar 9 17:38:59 2018 +0100 maxminf_db.c: ad an explicit cast to please gcc 7.3.1 Change-Id: Ie97008ece77e485948a3a8d418a49b77c1a52a33 Reviewed-on: https://code.wireshark.org/review/26395 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6c077a081870653268331a848f2543… commit 6c077a081870653268331a848f2543778d372028 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Mar 9 15:36:49 2018 +0100 mmdbresolve: remove leak (found by clang). Change-Id: I7de7707d75c80bc12ec2c4a30a19f6988932b0b7 Reviewed-on: https://code.wireshark.org/review/26392 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=a395a8b9939bd48858efbd3da5897a… commit a395a8b9939bd48858efbd3da5897a59d4697eba Author: Peter Wu <peter(a)lekensteyn.nl> Date: Fri Mar 9 15:17:02 2018 +0100 GeoIP: avoid closing random file descriptors Previously there were three different pipe validity checks: PID != WS_INVALID_PID, PID != 0 and stdin != 0. This resulted in using/closing file descriptors which might be owned by something else. When no GeoIP databases are defined, mmdb_resolve_stop would be called to close the pipe and set PID to WS_INVALID_PID. stdin is however not cleared and future invocations would try to close the previous fd. Change-Id: I1d15da29208efb41098ee6a4edeeabf61f84c2b3 Fixes: v2.5.1rc0-466-ga1da75c554 ("Transition from GeoIP Legacy to MaxMindDB.") Reviewed-on: https://code.wireshark.org/review/26391 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=02085c80ab10507f6a75d75fe1e43f… commit 02085c80ab10507f6a75d75fe1e43facade98a0e Author: Robert Sauter <sauter(a)locoslab.com> Date: Fri Mar 9 13:53:08 2018 +0100 IEEE 802.15.4: fix wmem_free instead of g_free; fix outdated comments Change-Id: Idfb2b5a9d6fd1c571a5a9edeb91e7f9281a06df0 Reviewed-on: https://code.wireshark.org/review/26363 Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b91f7f1a0cf014d1f838595d85161a… commit b91f7f1a0cf014d1f838595d85161a13ebe157b2 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Mar 9 15:21:20 2018 +0100 QUIC: Replace cleartext by handshake from draft-08 (07 ?) it is now handshake secret (and no cleartext secret) Bug: 13881 Change-Id: I03983c13f0c37839e1a41b6beb20f6e133adc8f8 Reviewed-on: https://code.wireshark.org/review/26390 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=66eed04afe08bf9120cf22d1885191… commit 66eed04afe08bf9120cf22d1885191c281086325 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Mar 9 15:19:29 2018 +0100 QUIC: Remove last long packet type about old draft (< 08) Bug: 13881 Change-Id: I9fae21b62b7394a8ae52c5fa551aea2da17fbff5 Reviewed-on: https://code.wireshark.org/review/26389 Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=cc795d4ddfaca382bcd0e6b4862a43… commit cc795d4ddfaca382bcd0e6b4862a432eddd06f54 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Mar 9 13:47:42 2018 +0100 WSP: check tvb_get_guintvar() success 4630b4fcf8 sets octetCount to 0 in case of error. Let's check this return value to avoid an infinite loop Bug: 14519 Change-Id: Ie3519067d609afb1bbf9e67f7f15f95911d2b173 Reviewed-on: https://code.wireshark.org/review/26388 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1ac90d5254e9e303196c100039b7dd… commit 1ac90d5254e9e303196c100039b7dd26d23841d1 Author: Paul Zander <p.j.zander(a)lighting.com> Date: Wed Mar 7 09:09:35 2018 +0100 Register and initialize the ZCL clusters in a uniform way. The cluster registration and initialisation is done in the functions 'proto_reg_handoff_zbee_zcl_XXX'. In these functions the 1st step was to register the dissector. Then the cluster was initialised via the function 'zbee_zcl_init_cluster'. In this patch the registration and initialisation is now done by the function 'zbee_zcl_init_cluster'. In this way we have a more uniform way of registration. Change-Id: If865d904ea51c299a48e5c0004f3f280b7479d49 Reviewed-on: https://code.wireshark.org/review/26325 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=446d9486ae897692fb3e02e90501e3… commit 446d9486ae897692fb3e02e90501e38790ac37c8 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Mar 8 15:53:58 2018 +0100 spdx: convert files with multiple licenses. Change-Id: Iac29428b5a6d26896e559f06acf202f03fa8ec90 Reviewed-on: https://code.wireshark.org/review/26366 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fe2355e061845902400ab5e1447a93… commit fe2355e061845902400ab5e1447a936e727972a5 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Mar 9 09:50:52 2018 +0100 licensecheck: handle multiple licenses. Change-Id: I1df4406e4bfcdcea99dc1c1446f1863c0a4522a0 Reviewed-on: https://code.wireshark.org/review/26386 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ce07a363378acdf838ee2bedae82a9… commit ce07a363378acdf838ee2bedae82a955c9a6fdd5 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Fri Mar 9 10:46:02 2018 +0100 SIP: Add a filter for icid-value. Change-Id: If049f0a86999ddaa23d4ad9ec8f6a4679c7623e2 Reviewed-on: https://code.wireshark.org/review/26387 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4e6d989df43af78439fccd24a176a1… commit 4e6d989df43af78439fccd24a176a14c534aea99 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Mar 7 22:10:31 2018 +0100 Add MaxMindDB 1.3.2 library to Windows Change-Id: I328b6a05cc356be59ac63e80eae55a832bf76a47 Reviewed-on: https://code.wireshark.org/review/26347 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=572f78a8610282151e7d165b11e0bf… commit 572f78a8610282151e7d165b11e0bf5092efbb5a Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Mar 9 09:48:37 2018 +0100 LACP: protect a possible infinite loop Offset should not go backwards. Bug: 14518 Change-Id: I03a64ae9a99f1ca095f0bc710f93f0f6ba2248e6 Reviewed-on: https://code.wireshark.org/review/26384 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4495d8fbfdc680b37671f813966446… commit 4495d8fbfdc680b37671f8139664463e84b7e0bf Author: KasperDeng <kasper.deng(a)ericsson.com> Date: Fri Mar 9 16:09:50 2018 +0800 update AVPs of diameter dictionary for diameter t6a/t6b/t4 and add OFR in SGd interface of Ts 29.338 Change-Id: I7311ce976a6f020da49eb8d0eb9e83080ae1358d Reviewed-on: https://code.wireshark.org/review/26383 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c9cb93acfc230cad1d0c27a8454645… commit c9cb93acfc230cad1d0c27a8454645c079f4ac9e Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Mar 9 09:50:04 2018 +0100 wsutil: add CR to license. Change-Id: Ibef7761410cd4d653be0d87c2bd39c040da62e08 Reviewed-on: https://code.wireshark.org/review/26385 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e7ab7a907c16be8eabb426958b459a… commit e7ab7a907c16be8eabb426958b459aefc0631549 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Mar 8 11:18:49 2018 +0100 spdx: more licenses converted. Change-Id: I8f6693108c43959e54911d35b4fbf730c59add60 Reviewed-on: https://code.wireshark.org/review/26361 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fdd426e410325db3f33a16f77739f8… commit fdd426e410325db3f33a16f77739f8f73575af2c Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Mar 7 15:28:51 2018 +0100 spdx: more licenses converted. Change-Id: Ia1650bc02511f7bd47fb90be91b623177f05bcbd Reviewed-on: https://code.wireshark.org/review/26337 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0ae769adc10a97dfd2114d74709488… commit 0ae769adc10a97dfd2114d747094881ca7870b87 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Fri Mar 9 00:23:33 2018 +0100 IEEE 802.15.4: fix uninitialized variable warning "status" is set by decrypt_ieee802154_payload, but GCC 7.3 is unaware: epan/dissectors/packet-ieee802154.c: In function 'ieee802154_decrypt_payload': epan/dissectors/packet-ieee802154.c:1912:9: error: 'status' may be used uninitialized in this function [-Werror=maybe-uninitialized] switch (status) { ^~~~~~ Change-Id: Ia66e6a80f277470f8b242107275ea7467c37e212 Reviewed-on: https://code.wireshark.org/review/26372 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ea754b6761116133b506b782c07979… commit ea754b6761116133b506b782c079793d37d744a6 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Mar 8 18:12:33 2018 -0800 Plug a leak. "field" might be allocated even if the calculation type is CALC_TYPE_BYTES, CALC_TYPE_FRAMES, or CALC_TYPE_FRAMES_AND_BYTES. Change-Id: I0c70397a89e32172769c277bebfd950f1d21c679 Reviewed-on: https://code.wireshark.org/review/26378 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7ffc4f96ebe2fac503cb251a848441… commit 7ffc4f96ebe2fac503cb251a848441ad8d4bad8c Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Mar 8 18:02:21 2018 -0800 When looking up response codes, just keep the key on the stack. We don't need to dynamically allocate a guint variable to hold the response code value - and then not bother to free it! - if we're just doing a lookup; we can use an automatic variable and pass a pointer to it. Change-Id: I6edbb352f0aa33c91ede0f4e1bbb962fa921bea2 Reviewed-on: https://code.wireshark.org/review/26375 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6e32335be61851592d8158772b743c… commit 6e32335be61851592d8158772b743c55ae132eb9 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Mar 8 23:50:28 2018 +0000 Intern MaxMinDB IPv6 addresses. Make sure our IPv6 addresses are unique and allocated, similar to our strings. Bug: 14514 Change-Id: I602b3b0ec4674fb2bc8cbaa973a73a6f3188e0c3 Reviewed-on: https://code.wireshark.org/review/26371 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=5f35b041c2d731297cdd4d780d0297… commit 5f35b041c2d731297cdd4d780d029743fd49b9b4 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Mar 8 13:31:23 2018 -0800 MaxMind DB fixups. Make sure the text we read is null terminated. Properly strip our lines and chunked strings. Copy over cast and strtod fixes from change 26347. Change-Id: I0695e35c446c1bd277c53b458b07e428cdd90fb8 Reviewed-on: https://code.wireshark.org/review/26370 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=dbfd53cd60ed9f748b25a293a36893… commit dbfd53cd60ed9f748b25a293a36893ee828f89d4 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Mar 8 09:32:51 2018 -0800 epan: Ignore SIGPIPE. We need to ignore SIGPIPE whenever we use maxmind_db. Do so in epan_init. Ping-Bug: 14494 Change-Id: I4372935e371a94c02a79050d59b2e3ee1ba04fee Reviewed-on: https://code.wireshark.org/review/26369 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ce46a023cf233b376107f46709f7b2… commit ce46a023cf233b376107f46709f7b2a42a0c3c3f Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Wed Mar 7 17:04:16 2018 -0800 ieee80211: A few cleanups of the HotSpot 2.0 dissection. Change-Id: I9f3eda15612e8b90993a731e5576c311250f93aa Reviewed-on: https://code.wireshark.org/review/26348 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=32365383a9f13c2da6dfe1aff6de89… commit 32365383a9f13c2da6dfe1aff6de891b95ca4a50 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Thu Mar 8 15:13:41 2018 +0100 GTPv2: Show spare bits in IE UP Function Selection Indication Flags. Change-Id: Ic1983617e6b21114d55d834780627b0c928c2b83 Reviewed-on: https://code.wireshark.org/review/26365 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5c25e1b2c1e986df36ea95047a891e… commit 5c25e1b2c1e986df36ea95047a891e1d54070694 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Thu Mar 8 15:09:09 2018 +0100 S1AP: EmergencyAreaIDListForRestart is not an extension IE. Change-Id: I3dd623e1a2ec3005ee2c810492e4d0fad39ce1d0 Reviewed-on: https://code.wireshark.org/review/26364 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b91ef7da5168143ff558785b6bc04a… commit b91ef7da5168143ff558785b6bc04a68f72b19ec Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Mar 8 10:20:27 2018 +0100 ieee80211: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I0f945332c8aebb66ee5748506f3aa3b5dedb6323 Reviewed-on: https://code.wireshark.org/review/26358 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7ddfccec199f21bb9d9f23ff99e663… commit 7ddfccec199f21bb9d9f23ff99e663299371a395 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Mar 8 10:13:50 2018 +0100 gryphon: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I08b59156dbe537c6c4a6b3502ab469c88e984b67 Reviewed-on: https://code.wireshark.org/review/26357 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6a62e2d22d5f83455aba2b61971440… commit 6a62e2d22d5f83455aba2b619714409983498fc8 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Mar 8 10:35:35 2018 +0100 gryphon(.h): fix indent (use 4 spaces) Change-Id: Ic3ba745e22b5c28ffb8dd9d7fe513c4d86f3d603 Reviewed-on: https://code.wireshark.org/review/26360 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c4d2ad476d09029255669319eb2931… commit c4d2ad476d09029255669319eb2931727adce597 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Mar 8 10:23:36 2018 +0100 ieee80211: fix indent (use 2 spaces) Change-Id: I2bb28dfd59fcb8098b52236b6a3c77307b840fc3 Reviewed-on: https://code.wireshark.org/review/26359 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e5de1f199499219b297d581d60546f… commit e5de1f199499219b297d581d60546f2c5b51a87a Author: Robert Sauter <sauter(a)locoslab.com> Date: Wed Mar 7 09:47:09 2018 +0100 wisun: Netricity segment control and reassembly support While based on IEEE 802.15.4, the protocol breaks the standard by having frames where the FCF Security Enabled flag is set but no Auxiliary Security Header is present. Add handling of this special case to the IEEE 802.15.4 dissector. Change-Id: I0e678d5fc999ead740c0c27f51a699559c6cb21a Reviewed-on: https://code.wireshark.org/review/26336 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3905c0d5d5532d10fa79b0481c9ce0… commit 3905c0d5d5532d10fa79b0481c9ce01e6752983d Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 23:11:59 2018 -0800 Don't unnecessarily cast away constness. Change-Id: Ib956667dec3ffdacbde3252da3242ea16819c266 Reviewed-on: https://code.wireshark.org/review/26356 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8a677354bd14eb1cff01c01bc9a303… commit 8a677354bd14eb1cff01c01bc9a303c502074d56 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 22:46:50 2018 -0800 The routines that implement a codec don't need to be public. Pointers to them are passed to register_codec(), so they can be static to l16decode.c. Change-Id: I2303cc4374e81a2e5a77eaa275ca601d99a4f608 Reviewed-on: https://code.wireshark.org/review/26355 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=241b274b5f8e6f7e3ea22f7598a271… commit 241b274b5f8e6f7e3ea22f7598a271f48ccd3191 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 21:17:03 2018 -0800 Don't cast away constness. Change-Id: I1d1f6338fcd4a7c5873a9d758cb56324a6ce0fcf Reviewed-on: https://code.wireshark.org/review/26354 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=695fbb9be0122e280755c11b9e0b89… commit 695fbb9be0122e280755c11b9e0b89e9e256875b Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 20:09:21 2018 -0800 Squelch some casting-away-constness warnings. In true_false_string_from_table(), keep the pointers to the "true" and "false" strings in local non-const pointer variables, so we can free them without a complaint. Only when we're finished, and have valid "true" and "false" strings, do we allocate the true_false_string structure and fill it in with those pointers. Change-Id: I6eb3ee46bdc47bf42d6e913c72884f0eac22997e Reviewed-on: https://code.wireshark.org/review/26353 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e7cf995b1e0a9b434782adf0e2ee40… commit e7cf995b1e0a9b434782adf0e2ee40bfb721aac2 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 19:17:46 2018 -0800 Squelch some casting-away-const warnings. Code *outside* this file isn't allowed to free or overwrite the structure members in question; code *inside* this file only does so when it's appropriate, so we just cast away the warnings. Use free_string_like_preference() in one place where the code was duplicated; add a pref_set_string_like_pref_value() routine to encapsulate the freeing. Remove some unnecessary casts. Change-Id: Ifc30a919cbd331367f5932ad23c3a1ed7cd4579f Reviewed-on: https://code.wireshark.org/review/26352 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e5cc633ee49823ac56350fd57fea3e… commit e5cc633ee49823ac56350fd57fea3e54717d85f7 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 17:49:42 2018 -0800 Constify an argument that doesn't need to be non-const. Change-Id: I59317862f57a41d1770c1cf6f8ec23662ae1c355 Reviewed-on: https://code.wireshark.org/review/26350 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=957845f5a4ed8919164dfd46989073… commit 957845f5a4ed8919164dfd469890732b65b40831 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Mar 7 17:02:59 2018 -0800 CMake: Don't bother compiling zlibstatic. We don't use zlibstatic so exclude it from ALL_BUILD and Wireshrk.sln. Change-Id: I9656b6f1c35e43cce89c8879f4521f6dc4a5cbdf Reviewed-on: https://code.wireshark.org/review/26349 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=39a65995ccaa45322b7ee870fe21a0… commit 39a65995ccaa45322b7ee870fe21a0daa6157242 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Mar 7 11:35:33 2018 -0800 CMake: Exclude test targets from the default build. For the Visual Studio generator, setting the EXCLUDE_FROM_ALL property on a target excludes it from ALL_BUILD.vcxproj, but we additionally need to set EXCLUDE_FROM_DEFAULT_BUILD to exclude it from Wireshark.sln. Do so for the test targets. Change-Id: Icd328f75d4927e5b7bb65b1833da4724f63476b6 Reviewed-on: https://code.wireshark.org/review/26345 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=eefa76a7c810bd74d95d571362f0ad… commit eefa76a7c810bd74d95d571362f0ad5fda691e70 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Feb 25 09:05:32 2018 +0100 address_types: fix returned length of eui64_addr_to_str Change-Id: I5ed1f20419b45c2d443953eaf74b540d4fcc23c6 Reviewed-on: https://code.wireshark.org/review/26090 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cc45082635c9cfed0112727b1b10a0… commit cc45082635c9cfed0112727b1b10a0f863bce13c Author: ciechanowski <markciechanowski(a)gmail.com> Date: Mon Mar 5 13:50:58 2018 -0500 Gryphon Protocol dissector fixes and updates. These updates fix the incorrect "malformed packet" errors. The updates include Gryphon Protocol commands that were not included in the prior version of the Gryphon dissector. Specifically, added LIN Protocol commands for LDF files, LIN ioctls, LIN signal conversion commands, and USDT ISO-15765-2 commands. Change-Id: I746aa871d8496f3a73374eefd52ed900a069d16b Reviewed-on: https://code.wireshark.org/review/26269 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fbb042336af42635eedabd7f1bb2eb… commit fbb042336af42635eedabd7f1bb2eb5c6bd35d5f Author: Robert Sauter <sauter(a)locoslab.com> Date: Wed Mar 7 17:13:44 2018 +0100 IEEE 802.15.4: support vendor specific commands; small cleanups - support vendor specific commands with a dissector table - add missing command IDs - add expert warnings for unsupported and unknown command IDs - fix indentation - correct spelling issues - small consistency changes Change-Id: Ifbe4a8aab1e5c953c1d3d264ab4f0913e6936e7f Reviewed-on: https://code.wireshark.org/review/26341 Reviewed-by: Ed Beroset <beroset(a)ieee.org> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a3e1967d8e6e3825c341cd39c48f31… commit a3e1967d8e6e3825c341cd39c48f31a5bc8cbe24 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Mar 7 09:33:22 2018 -0800 Debian: Fixup some symbols. Change-Id: I3744d9d4a9caf9b8c4ccceefce07e88e24406be2 Reviewed-on: https://code.wireshark.org/review/26342 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=e1790da88cb02dcc0764e58cc8b67a… commit e1790da88cb02dcc0764e58cc8b67afe9d8543a1 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 13:08:29 2018 -0800 Hack to fix ABI checking. Change-Id: I20f0fd8c7dc6f5276c19735025d719a2043c803a Reviewed-on: https://code.wireshark.org/review/26346 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1592587e6f9fd8c8aa8fc7f6798969… commit 1592587e6f9fd8c8aa8fc7f67989690d0c6882c4 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Mar 7 17:40:56 2018 +0100 LWAPP: define a recursion depth limit Altough the dissection consumes a few ytes each time it is called, it can trigger a stack overflow for big packets. Let's limmit the number of allowed encapsulation for a given packet. Bug: 14467 Change-Id: I73e82e01810b63a4f603907e69b20f3715a4ad55 Reviewed-on: https://code.wireshark.org/review/26338 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7dd7a05d480226736696aed4a6530b… commit 7dd7a05d480226736696aed4a6530b0e84526aea Author: AndersBroman <anders.broman(a)ericsson.com> Date: Tue Mar 6 09:25:35 2018 +0100 [NAS-5GS] Dissect more IEs Change-Id: I3670acb0c84a03a82036829ded018735722b6519 Reviewed-on: https://code.wireshark.org/review/26339 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3132a504489944b41522125f8e7aab… commit 3132a504489944b41522125f8e7aaba8ae50a66f Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Mar 7 16:57:40 2018 +0000 Autotools: Build rawshark. a1da75c554 inadvertently removed rawshark from bin_PROGRAMS. Add it back. Sort bin_PROGRAMS while we're here. Change-Id: I6f71b43efd52ed116ea5fb9567b7ff1a94db58c7 Reviewed-on: https://code.wireshark.org/review/26340 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Reviewed-by: Ed Beroset <beroset(a)ieee.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=692cef88c7f68af53e9487e3e2264d… commit 692cef88c7f68af53e9487e3e2264de8d98b230b Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Mar 7 14:08:18 2018 +0100 dissectors: more SPDX license convertions. Change-Id: I96e1f1cdbaaf49d65705ecacc903f73cf0e47d7c Reviewed-on: https://code.wireshark.org/review/26334 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=5375283f9294d444fcda14df74fed7… commit 5375283f9294d444fcda14df74fed77160bf1d1d Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Mar 1 13:35:42 2018 +0100 Qt: remove leak in simple_statistics_dialog (found by clang). Change-Id: Ie1b6d6e8039eeaeb08f2d59c21a88298d55ea797 Reviewed-on: https://code.wireshark.org/review/26145 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Roland Knall <rknall(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4f36a28acbc06781740cf4105375ae… commit 4f36a28acbc06781740cf4105375ae7759b6606b Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Mar 1 13:45:55 2018 +0100 Qt: remove leak from protocol_preferences_menu (found by clang). Change-Id: I8ea4f550cbce934335e8d8e7d7c6b5fba7bcacfe Reviewed-on: https://code.wireshark.org/review/26141 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fe71e26af27a01173f3029a7d848b9… commit fe71e26af27a01173f3029a7d848b9ba65a0defb Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Mar 6 15:31:02 2018 +0100 spdx: more licenses converted. Change-Id: I3861061ec261e63b23621799e020e811ed78a343 Reviewed-on: https://code.wireshark.org/review/26333 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=71f36379aef2ff9fcf092619011f02… commit 71f36379aef2ff9fcf092619011f02f68ce9d3b2 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Mar 7 15:39:29 2018 +0100 licensecheck: add BSD licenses. Change-Id: I764d03e4dc6d8925e656f37c98ece3da1fb1f001 Reviewed-on: https://code.wireshark.org/review/26335 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8a5385b9c9ec4ccfd692263eb7c59b… commit 8a5385b9c9ec4ccfd692263eb7c59b09f9bc1a15 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Mar 6 15:31:02 2018 +0100 More licenses converted to SPDX. Change-Id: Id4f987dcdacf06622d70263f4659a4400e30dc39 Reviewed-on: https://code.wireshark.org/review/26332 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=830adb2a02c3ef5209bf79c933879b… commit 830adb2a02c3ef5209bf79c933879b49b12b7902 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Mar 1 13:42:09 2018 +0100 Qt: rework routine in module_preferences_scroll_area. This removes a check that confuses clang and generates a false poritive. Change-Id: Ib28b88b40e16ad300ba6d3df8334bd752a4fa7f1 Reviewed-on: https://code.wireshark.org/review/26171 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3a54fd1d7d5d0ee1635e7100635ad3… commit 3a54fd1d7d5d0ee1635e7100635ad3cad0ffbcd1 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Mar 7 08:22:55 2018 +0100 bluetooth: Update Assigned Numbers Update URLs for sources. Change-Id: Ia70bc657210e867abea1eb25c5feab189c53a230 Reviewed-on: https://code.wireshark.org/review/26324 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=f7897365213111fa86fa940ddea6c3… commit f7897365213111fa86fa940ddea6c3e191b0b429 Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Sep 16 17:45:05 2017 -0400 Qt: Handle UAT editor dialogs explicitly. QAbstractItemView assumes that editors are widgets, not windows. QAbstractItemView::edit calls QAbstractItemViewPrivate::openEditor, which simply calls show() and setFocus() on the editor widget. If that widget happens to be a native dialog, its event loop might not be processed. This is the case on macOS at least. Create widgets derived from QLineEdit that edit the value directly along with a button that can open the associated modal dialog. Install event filters so that we keep the correct tab behavior between fields of the UAT. Bug: 13958 Ping-Bug: 14031 Bug: 7761 Change-Id: Ie5f0a5cbde33bb9add8217029c2063a0bbfd804a Reviewed-on: https://code.wireshark.org/review/23015 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9a5217bdd4680e36f2e92838348bd4… commit 9a5217bdd4680e36f2e92838348bd4ea010d28a0 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Mar 7 00:49:28 2018 -0800 Fix another leak, which happens with -E occurrence=l. For each occurrence, if there was already an occurrence in the array, we were just removing it. not freeing what it pointed to. While we're at it, expand comments. and always check the array size with "!= 0", not "> 0" - the value is unsigned, so they're equivalent, but this makes the code more self-consistent. Change-Id: I538f46b296a7721a39ba4366c2f6269e7e097b0d Reviewed-on: https://code.wireshark.org/review/26328 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=37723968d2b37c52f5809398b85adf… commit 37723968d2b37c52f5809398b85adffdc815ce9d Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Mar 6 10:27:01 2018 -0800 WIP:ieee80211: HotSpot 2.0 fixes. This bring the IEEE802.11 dissector further into conformance with the HS2.0 spec. I have concerns at how complex the handling of dissect_advertisement_protocol_common has become. I also have some bugs reported by the WFA to deal with. Change-Id: I69caca7d568562b752a70e5f73a7fa395364bc23 Reviewed-on: https://code.wireshark.org/review/26279 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6db59affd9c9b20f2ce725cd2ce7a8… commit 6db59affd9c9b20f2ce725cd2ce7a88c71982a07 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 28 19:04:25 2018 +0100 print: free memory if not used (found by clang). Change-Id: Ib6dc913ab1eeff7b29e18930b66b728080629773 Reviewed-on: https://code.wireshark.org/review/26183 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8a5cd7a5c67cdca5eed91ec6a36ba3… commit 8a5cd7a5c67cdca5eed91ec6a36ba310772e795f Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Mar 7 08:25:18 2018 +0100 ieee802154: fix 'wpan.tsch.timeslot' exists multiple times with NOT compatible types: FT_UINT16 and FT_NONE Change-Id: I36ca5c469281f17e3ed9aebe1899648533a9b1a5 Reviewed-on: https://code.wireshark.org/review/26323 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=99a329891dca9e1e033313aad2a844… commit 99a329891dca9e1e033313aad2a8445e2d5206af Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Mar 7 08:21:38 2018 +0100 nas_5gs: fix duplicate entry Field 'Request type' (nas_5gs.mm.req_typ) has a conflicting entry in its value_string: 3 is at indices 2 (Initial emergency request) and 3 (Existing emergency PDU session) Change-Id: I64c6222033efa64c3f730b2be7e92c731d71d43c Reviewed-on: https://code.wireshark.org/review/26322 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f38e895dfc0d97bce64f73ce99df70… commit f38e895dfc0d97bce64f73ce99df706911d9aa07 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Mar 6 23:17:31 2018 -0800 Plug another leak for Wiretap errors. Clean up comments while we're at it. Change-Id: I7e218ba3f998804045e3d7fab08d85d09a293d69 Reviewed-on: https://code.wireshark.org/review/26320 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=68216fa2da7bf608441356593a5059… commit 68216fa2da7bf608441356593a5059913c7e1a97 Author: Ed Beroset <beroset(a)ieee.org> Date: Tue Mar 6 13:38:39 2018 -0500 IEEE 802.15.4: Add expert warning for Payload IE in header Change-Id: I34f4814ff0a93f9ef149241fd9899b50199955c5 Reviewed-on: https://code.wireshark.org/review/26280 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b94d3af3039b8bdfbd4d760fda412f… commit b94d3af3039b8bdfbd4d760fda412fdfa121b732 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 22:56:20 2018 +0100 failure_message.c: fix a memory leak if err is not negative Bug: 14489 Change-Id: I958cfae824c50263913ba9df8128e34e9466cb67 Reviewed-on: https://code.wireshark.org/review/26294 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=035f49d2c85ff9e0bab74e5af4c990… commit 035f49d2c85ff9e0bab74e5af4c990ab2beea170 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 22:43:31 2018 +0100 PCP: allocate conversation info in file scope Bug: 14488 Change-Id: I9bb85cfd58ace721ba8b957bc3351f6c017a8b69 Reviewed-on: https://code.wireshark.org/review/26293 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8f81eb2cf671573461ccba3bde6ce5… commit 8f81eb2cf671573461ccba3bde6ce5ec99016afa Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 22:39:01 2018 +0100 H223: fix a memory leak in conversation management Bug: 14487 Change-Id: I75089ccfa2896b357f775fea67fd6b76500fc5dc Reviewed-on: https://code.wireshark.org/review/26292 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=89a715eba45d89bd65ee9a190bb130… commit 89a715eba45d89bd65ee9a190bb1300ac6ea6fd4 Author: Ronnie Sahlberg <ronniesahlberg(a)gmail.com> Date: Wed Mar 7 09:50:22 2018 +1000 SMB1/2: Update some FileFS fields with new flags Change-Id: I7fbf874c8f9f7fcbcdecd07b04762688d080b961 Signed-off-by: Ronnie Sahlberg <ronniesahlberg(a)gmail.com> Reviewed-on: https://code.wireshark.org/review/26300 Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=05c4705a19448646ca316ba3b1eb33… commit 05c4705a19448646ca316ba3b1eb333a05482956 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 22:33:49 2018 +0100 multipart: use packet scope memory to avoid leaking in case an exception is triggered by subdissectors Bug: 14486 Change-Id: I275f8c962f126ad55fc7086012e7b67cc0dc60b3 Reviewed-on: https://code.wireshark.org/review/26291 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4581eb2de2e5aacfc9a2224df18101… commit 4581eb2de2e5aacfc9a2224df181010dc8e6141b Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 22:03:50 2018 +0100 GIOP: use wmem packet scope for get_modname_from_repoid() Bug: 14484 Change-Id: Ie2a4cc179ba25a1e3e50d689e21f003001a301fa Reviewed-on: https://code.wireshark.org/review/26289 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bf4e620e2d15689e8582425224160f… commit bf4e620e2d15689e8582425224160f39dcc8589c Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 21:49:41 2018 +0100 LAPD: fix some memory leaks in conversation management Bug: 14482 Change-Id: Ia49705e13f1071a69d61ba1d6bd331e3e7734d81 Reviewed-on: https://code.wireshark.org/review/26287 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4945c50d3f8269c56d9d087d16d080… commit 4945c50d3f8269c56d9d087d16d080144de146dc Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 23:26:10 2018 +0100 SMB2: use file scope to avoid leaking memory Bug: 14483 Change-Id: I1532fa57cd9a847c0408db95744eb7af3a6f4ee5 Reviewed-on: https://code.wireshark.org/review/26295 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: ronnie sahlberg <ronniesahlberg(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cc764b92acc65f7727fc53180a09ba… commit cc764b92acc65f7727fc53180a09ba2088a8751b Author: Paul Zander <p.j.zander(a)lighting.com> Date: Tue Mar 6 20:32:35 2018 +0100 Add additional dissect information in the ZCL Level Control Cluster. Change-Id: I46f5ee8cc0aff39a01289be5f9cea86640f0a72d Reviewed-on: https://code.wireshark.org/review/26282 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1b18b1dd0e171ec660ad1ce5d47bab… commit 1b18b1dd0e171ec660ad1ce5d47bab80ddc3da86 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 21:44:54 2018 +0100 ISUP: plug some memory leaks Bug: 14481 Change-Id: I940dc4c7ac197deb1f925418bbcdebb30285a775 Reviewed-on: https://code.wireshark.org/review/26286 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f46d129f21ee0c2b43545c500a8ea4… commit f46d129f21ee0c2b43545c500a8ea4dbc4d59815 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 22:15:22 2018 +0100 oids.c: fix a memory leak in oid_string2subid() Bug: 14485 Change-Id: Ia0ccd4480808c4f5da228975c7a076cd3f5d332b Reviewed-on: https://code.wireshark.org/review/26290 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: ronnie sahlberg <ronniesahlberg(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fd62e506b93cb2d9d7d77d7282e522… commit fd62e506b93cb2d9d7d77d7282e522532c70025b Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Mar 6 17:08:29 2018 -0800 Eliminate unused structure members and an unused list. We don't use the addresses, and don't use the inbound port. We also don't need a list of tn5250_conv_info_t's - they're allocated with wmem, so they get freed when we're done with a file, and they're attached to conversations, so we don't need a list to find them. Change-Id: Id3b44fb11cf353d7d15a58938883f2460cf642a0 Reviewed-on: https://code.wireshark.org/review/26301 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e3c263c01236e7c31ec23f6c3d8750… commit e3c263c01236e7c31ec23f6c3d8750d7e92fb5a3 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Mar 6 15:29:34 2018 -0800 NSIS, WiX: Handle the presence or absence of mmdbresolve. Only install mmdbresolve if MAXMINDDB_FOUND is true. Fixup the Qt about box and WiX GTK defines while we're here. Change-Id: I7ac3c21ddb4aebc1dae1c3d8cfd2bcafc4139d2e Reviewed-on: https://code.wireshark.org/review/26299 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f0fb6ee50c953ac07eb76d47036a76… commit f0fb6ee50c953ac07eb76d47036a761a57f35491 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Mar 6 12:37:27 2018 -0800 mmdbresolve: Process our command line arguments by hand. Visual Studio doesn't ship with a getopt implementation, so process our arguments ourselves. Note that if we add support for more flags we'll probably want to use GOption. Change-Id: Ie78204aa64321ca68f3e66195b8c39e47ca410d9 Reviewed-on: https://code.wireshark.org/review/26288 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=0ddaec13a162c01928e310c4f92532… commit 0ddaec13a162c01928e310c4f92532cdb70d45c0 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Mar 6 15:17:13 2018 -0800 Get rid of unused information. We only need to know the outbound port, so we can determine whether this is to or from the host. Fix a comment to reflect reality while we're at it. Change-Id: If01df5aeb73900850a0de9f9f9731c6fa7f094bb Reviewed-on: https://code.wireshark.org/review/26298 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=98ab887a2d4ffbe7b255655c510b67… commit 98ab887a2d4ffbe7b255655c510b676c32e93608 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 21:41:57 2018 +0100 TN3270: fix memory leaks in conversation management Bug: 14480 Change-Id: I9148bef80492426195a1673f8367a39c02c432ce Reviewed-on: https://code.wireshark.org/review/26285 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=76267f4bc5d8c62eaf72af6a8a2fba… commit 76267f4bc5d8c62eaf72af6a8a2fbadeb75730c2 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 21:40:24 2018 +0100 maxmind_db.c: fix a memory leak Change-Id: Ie3484e863363a8d2b9ccb435088886020678d15d Reviewed-on: https://code.wireshark.org/review/26284 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f0f4adc9d9962376b545a72f5448be… commit f0f4adc9d9962376b545a72f5448be8f51676725 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Mar 6 21:36:22 2018 +0100 maxmind_db.c: add an explicit cast to please gcc 7.3.1 Change-Id: Idb2ae052804fb523d6769fe50b5bb4ba45e40f79 Reviewed-on: https://code.wireshark.org/review/26283 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=b0b87e4b5f8dbdd69c515d63fa4413… commit b0b87e4b5f8dbdd69c515d63fa4413347179beb4 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Mar 4 16:31:18 2018 +0100 IEEE 802.15.4: individual functions for MHR/PIE/payload processing - reduce scope of special handling for ZBOSS and 'options' - move -2015 command byte handling to corresponding function - fix data handling for unimplemented command types Rationale: this allows reusing the individual functions for protocols that are based on IEEE 802.15.4 but require additional transformation of the payload without adding special cases within the functions. Change-Id: I5447620f6779031c4f9b280b16de9678b255b06f Reviewed-on: https://code.wireshark.org/review/26262 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Ed Beroset <beroset(a)ieee.org> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=99240e62bfad757cd50ac0fc38ce6e… commit 99240e62bfad757cd50ac0fc38ce6e75ea3debc0 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Mar 6 08:30:42 2018 -0800 Docs: Updates for xsltproc and Asciidoctor. Change-Id: I3cfe2121beaab0fe09228ec277997d68fe824693 Reviewed-on: https://code.wireshark.org/review/26281 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f52bb2bf27cc55285398bbf6acb188… commit f52bb2bf27cc55285398bbf6acb1884b10b8d3a4 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Mar 6 09:34:36 2018 -0800 CMake: Fixup our Chocolatey bin path discovery. Search for choco.exe directly instead of using PATHS + PATH_SUFFIXES. Look in %ChocolateyInstall%\bin first. CHOCOLATEY_BIN_PATH is the binary path. There's no need to append /bin to it. Change-Id: I732db398bd989bf12222a5cee2c79c0bd4161638 Reviewed-on: https://code.wireshark.org/review/26276 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=2eb6f3b5de46bb4d52775df919e2a5… commit 2eb6f3b5de46bb4d52775df919e2a55a3f606d9c Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Mar 6 10:19:19 2018 -0800 CMake: Remove SH from the packate list. Change-Id: Idafd85df598e0c58fc8252574ce0478b3e1464a9 Reviewed-on: https://code.wireshark.org/review/26278 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=a1da75c554881667dd92e11f098630… commit a1da75c554881667dd92e11f098630f2d604872b Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 8 17:20:26 2018 -0800 Transition from GeoIP Legacy to MaxMindDB. MaxMind is discontinuing its legacy databases in April in favor of GeoIP2, which use a newer database format (MaxMind DB). The reference C library (libmaxminddb) is available under the Apache 2.0 license which isn't quite compatible with ours. Add mmdbresolve, a utility that reads IPv4 and IPv6 addresses on stdin and prints resolved information on stdout. Place it under a liberal license (MIT) so that we can keep libmaxminddb at arm's length. Add epan/maxmind_db.[ch], which spawns mmdbresolve and communicates with it via stdio. Migrate the preferences and documentation to MaxMindDB. Change the IPv4 and IPv6 asnum fields to FT_UINT32s. Change the geographic coordinate fields to FT_DOUBLEs. Bug: 10658 Change-Id: I24aeed637bea1b41d173270bda413af230f4425f Reviewed-on: https://code.wireshark.org/review/26214 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=b2d3680558d19998c55b48e9807a26… commit b2d3680558d19998c55b48e9807a26e145756eba Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Mar 6 09:59:00 2018 -0800 CMake: Remove FindSH. We haven't used SH_EXECUTABLE since the Asciidoctor migration. Change-Id: I93e8245ea02ed994ebb62942d5ea4ec890e35a97 Reviewed-on: https://code.wireshark.org/review/26277 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=69ddfecb7605683ddb194a9d0e19de… commit 69ddfecb7605683ddb194a9d0e19dedeffbd4a08 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 26 16:27:09 2018 +0100 ipsec: zero memory in get_full_ipv6_addr (found by clang). Change-Id: I5a1c8cccd40867b70e64c8763a56da6a77c164b2 Reviewed-on: https://code.wireshark.org/review/26116 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=186714314d546c2155cb0942724e8b… commit 186714314d546c2155cb0942724e8bafb9bd879f Author: david-aggeler <david_aggeler(a)yahoo.com> Date: Mon Mar 5 11:54:55 2018 +0100 dcm: Fixed crash in dissector, and other bugs Some tag descriptions which are added to the parent item (32 tags). If one of those was empty a crash occurred. Mainly the RTPlan modality was affected. Fixed length decoding for OD, OL, UC, UR Fixed hf_dcm_assoc_item_type to be interpreted as 1 byte Fixed pdu_type to be interpreted as 1 byte Fixed decoding of AT type, where value length was wrongly reported in capture as 2 (instead of n*4) Removed tailing white spaces Please merge to 2.4 once ok. Bug: 14415 Change-Id: I7857ef107e7e599c7dd9f8d069daa5b3bfb4122f Reviewed-on: https://code.wireshark.org/review/26268 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=063277032130721ab9513b3525b249… commit 063277032130721ab9513b3525b24914db41ca7a Author: Paul Zander <p.j.zander(a)lighting.com> Date: Tue Mar 6 12:32:39 2018 +0100 Use the generic function decode_zcl_time_in_100ms instead of the local zcl_fmt_time_tenths. Change-Id: Id79b59c77083e6fb236d4137820182616f5b83c1 Reviewed-on: https://code.wireshark.org/review/26275 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4d3721b1db229b985d6f45b5bd0813… commit 4d3721b1db229b985d6f45b5bd0813a6ab5a63d1 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Tue Mar 6 09:27:04 2018 +0100 [Diameter] Added extended AVPs for Gx and Rx Change-Id: Ic795a84dfb42868a34707142ce31ec77cd855e44 Reviewed-on: https://code.wireshark.org/review/26273 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0d9d69a1e639ece0ad3218851771d6… commit 0d9d69a1e639ece0ad3218851771d662e2528d45 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Mon Mar 5 23:06:25 2018 +0100 [Diameter] fixed valid Diameter xml Change-Id: Iacbbbb359885468e056dee3f8fa401223a38ca3c Reviewed-on: https://code.wireshark.org/review/26271 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b434e0a03be45ed796af7271972672… commit b434e0a03be45ed796af7271972672a0b43cffa8 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Mon Mar 5 21:51:11 2018 +0100 VLAN: define a recursion depth limit Altough the dissection consumes 4 bytes each time it is called, it can trigger a stack overflow for big packets. Let's limmit the number of allowed VLAN tags for a given packet. Bug: 14469 Change-Id: Ieb6834ab3350dc7e8c301e6479577855a253897e Reviewed-on: https://code.wireshark.org/review/26270 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c39dbd68d472046cf97211c86267e0… commit c39dbd68d472046cf97211c86267e0305630d934 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 27 14:52:31 2018 +0100 extcap: add g_free to extcap_free_toolbar_value (found by clang). Change-Id: I81ca1665913f54333fe638208c99c4eef4ed2cc7 Reviewed-on: https://code.wireshark.org/review/26139 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=60f2c8e5885f48cd8e884ea2edefec… commit 60f2c8e5885f48cd8e884ea2edefec17f539acbc Author: Robert Sauter <sauter(a)locoslab.com> Date: Mon Mar 5 07:59:08 2018 +0100 wisun: fix, improve, and refactor Wi-SUN IEs Change-Id: I6e67d01c06536da5b41f9cf5b09b5f44393e6956 Reviewed-on: https://code.wireshark.org/review/26266 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c4f224c092c470bd1d8a1f4a0d6a28… commit c4f224c092c470bd1d8a1f4a0d6a28c24af87b2d Author: Paul Zander <p.j.zander(a)lighting.com> Date: Thu Mar 1 07:59:25 2018 +0100 Add missing ZigBee ZCL Scene cluster commands. The following commands are added: 0x40 - Enhanced add scene 0x41 - Enhanced view scene 0x42 - Copy scene Change-Id: If7f921f7ede7518ecbb88395d6200f600a47bd85 Reviewed-on: https://code.wireshark.org/review/26202 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=dd21b8130c6470d2d5076fcc46d5e9… commit dd21b8130c6470d2d5076fcc46d5e9c3866f4609 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Mar 4 22:05:06 2018 +0100 IEEE 802.15.4: always allocate protocol data if not present When using 2 passes, L2TP dissector can set a session info for previous packets, breaking the assumption that IEEE 802.15.4 dissector will always be called on first pass. Let's always allocate the protocol data if missing, even if this is not the first pass. Bug: 14468 Change-Id: I4cb7ea2e54c1b763a48b99c0d64f542552789d18 Reviewed-on: https://code.wireshark.org/review/26260 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cde7cc54a33659222ee8ee05d34691… commit cde7cc54a33659222ee8ee05d346918da45e4c82 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Mar 4 19:01:11 2018 +0100 NBAP: avoid linking a DCH-ID to itself Otherwise it can create an infinite loop, leading to a buffer overflow. Also add explicit cheks on the buffer usage and set its maximum size to 128 instead of 32 per ASN.1 description. Bug: 14471 Change-Id: I805f4ce09347bc35143b010b4a558a0d090c0159 Reviewed-on: https://code.wireshark.org/review/26259 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=df83de9b6442e02047ca9c68d55cfc… commit df83de9b6442e02047ca9c68d55cfc314788f00e Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Mar 4 19:21:30 2018 +0100 wisun: dissect Wi-SUN Netricity IEs Change-Id: Icae32b9934549891fab0683fa055fe16d01fdd90 Reviewed-on: https://code.wireshark.org/review/26258 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=6bb0d8b7ff64ef7f6afba1a03cac6a… commit 6bb0d8b7ff64ef7f6afba1a03cac6a4894a5db64 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Mar 4 23:10:24 2018 +0100 6LoWPAN: fix cast-qual warning Change-Id: I688c2052b2e242664d31d995583330715ace37cd Reviewed-on: https://code.wireshark.org/review/26261 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b99b9b81dd436826128dc6dbaf5d97… commit b99b9b81dd436826128dc6dbaf5d9796bbe261ab Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 28 13:05:49 2018 +0100 dof: use tvb_memdup instead of g_memdup. Change-Id: I0d1e6a09fa6fcf09c40c6e77b79cc97e0723bff5 Reviewed-on: https://code.wireshark.org/review/26144 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5e03b4e3427e1c49241f14fa51daea… commit 5e03b4e3427e1c49241f14fa51daea82aa0acb2b Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 28 18:47:48 2018 +0100 dot11decrypt: free memory on exit (found by clang). Change-Id: I1af895accdd52fe64fc156905c549e719aaba304 Reviewed-on: https://code.wireshark.org/review/26182 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5a05aa238ca69adfffcad21c755464… commit 5a05aa238ca69adfffcad21c755464bafa24249f Author: Jiri Novak <j.novak(a)netsystem.cz> Date: Fri Mar 2 14:59:43 2018 +0100 RTSP: Fixed missing space in column info between multiple pipelined messages When there is multiple RTSP messages in one packet, info column shows its headers right next to each other. It is ugly: Reply: RTSP/1.0 200 OKReply: RTSP/1.0 200 OK Patch adds ', ' between messages: Reply: RTSP/1.0 200 OK, Reply: RTSP/1.0 200 OK Ping-Bug: 14450 Change-Id: I151dbc72b669002ed02d91af43d683c5fc4fe4ba Reviewed-on: https://code.wireshark.org/review/26222 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cf373df7963d9ed6afee8285e2e163… commit cf373df7963d9ed6afee8285e2e1633ff6f7d93f Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 12:52:11 2018 +0100 coloring rules dialogue: remove unused signal View / Coloring Rules... shows this warning 12:02:26.401 Main Warn QObject::connect: No such signal ColoringRulesModel::dragDropComplete() in ../ui/qt/coloring_rules_dialog.cpp:61 12:02:26.401 Main Warn QObject::connect: (receiver name: 'ColoringRulesDialog') Remove the unused signal. Change-Id: Id42c249ac9252269eb31e4971e62e927a28c88ed Reviewed-on: https://code.wireshark.org/review/26239 Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=5b079291c41ae4f8abe7a33fa7b886… commit 5b079291c41ae4f8abe7a33fa7b886ae0a314a30 Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Sat Mar 3 17:55:36 2018 +0000 Windows: Remove support for MSVC older than VS2015 Cleanup the support for older versions of Visual Studio Change-Id: Ieb97d56e9bff6a5902433e8d99b27276bc7034f7 Reviewed-on: https://code.wireshark.org/review/26247 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c37eeafe8100624fb0c315ac607db3… commit c37eeafe8100624fb0c315ac607db32f7ad2c941 Author: Hauke Mehrtens <hauke(a)hauke-m.de> Date: Sat Mar 3 14:00:35 2018 +0100 dissectors: epon: Improve preamble detection The full EPON preamble is 55 55 D5 55, sometimes some bits are getting lost so this dissector supports multiple parts of this preamble. Add also the full preamble to detect also such packets correctly. Change-Id: I6d74694601bf2a430e24f8c9c004f3558aa056c5 Reviewed-on: https://code.wireshark.org/review/26240 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0fcfc634ddf7b54ca1352eb7413f93… commit 0fcfc634ddf7b54ca1352eb7413f93aedc2b54df Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Mar 4 08:18:26 2018 +0000 [Automatic update for 2018-03-04] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I95feebf818e68804d287e011f4c6ee2cd244b2f3 Reviewed-on: https://code.wireshark.org/review/26254 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=177962a5b4a05759b40fb6fc07a4a6… commit 177962a5b4a05759b40fb6fc07a4a6eec306a9bf Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 19:49:22 2018 +0100 enip: use wmem for copied addresses When we copy an address from pinfo into connInfo->O2T.ipaddress, a shallow copy is not sufficient. connInfo->O2T.ipaddress is kept across packets whereas pinfo is valid only for the current packet. Use wmem with file scope for the copied address. This fixes a use-after-free error when we access the address in a subsequent packet. Bug: 14470 Change-Id: I8b74037020189485485a506af6510cb45828e3c4 Reviewed-on: https://code.wireshark.org/review/26248 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b70eb189bb906d0b03ca95219a4c9c… commit b70eb189bb906d0b03ca95219a4c9c82eee43f97 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 16:33:40 2018 +0100 mmse: remove a ton of if (tree) checks Keep the "global" check where the entire processing was under if (tree). Move this check in front of the while loop and exit if we have no tree. Remove the subsequent (duplicate) checks for indivial proto_tre_add_...() calls. Change-Id: I6b978b438b9f1c84c8927ae4eb9c53a8eaadb4ef Reviewed-on: https://code.wireshark.org/review/26246 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4630b4fcf835b91d043ad12818d666… commit 4630b4fcf835b91d043ad12818d666c7321e28a4 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 16:22:33 2018 +0100 clean up tvb_get_guintvar() a bit more Wrap long lines. Use a do-while loop. We know up-front that we'll go into the loop at least once. Remove the cont variable, use the exit condition directly. Set *octetCount = 0 if we return 0 because of an error. In that case, we did not process any bytes and should inform the caller about this. Change-Id: I222270939e42e0096b6f5a25b197bd4bae12235e Reviewed-on: https://code.wireshark.org/review/26245 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=59af408e9ead20d96fb2991a7c6295… commit 59af408e9ead20d96fb2991a7c629534939475d0 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 16:04:46 2018 +0100 wap: include stdio.h Otherwise, fprintf() is not defined and the debug prints don't work. Change-Id: I9bc791dfc829cf9e7b1b6e61b0090d2fb94bebb2 Reviewed-on: https://code.wireshark.org/review/26244 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=41f18ae7f5c13d55ada84e3895f0cb… commit 41f18ae7f5c13d55ada84e3895f0cb656043e826 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 16:02:14 2018 +0100 tvb_get_guintvar: correct a debug print We always start with counter=0, guint *octetCount is used only as a return value. Change-Id: I3c080c59ef7620c5007f6dc3139a78a72cff2a21 Reviewed-on: https://code.wireshark.org/review/26243 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b475758123fde5fae476cd275958ac… commit b475758123fde5fae476cd275958ac16d8eac7bd Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sat Mar 3 15:25:56 2018 +0100 tvb_get_guintvar: don't overflow our return value tvb_get_guintvar() returns a guint. If we haven't seen the final byte after sizeof(guint) bytes, something is wrong. Abort and return 0. This is the minimum fix for Bug: 14473 Change-Id: Ibe8a1239c1cbbeec0591c66710416bb56f9f60dc Reviewed-on: https://code.wireshark.org/review/26242 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b580bdb9ddd5459bcdac95948ec41e… commit b580bdb9ddd5459bcdac95948ec41eae55be734f Author: Nicolas Darchis <ndarchis(a)cisco.com> Date: Wed Feb 28 15:26:03 2018 +0100 Add support for new peekremote features. Enhanced peekremote dissector to take into account the new extended flags written by Cisco APs in sniffer mode after WLC version 8.5. Support for 80mhz channel flag (bit 9), short preamble (bit 8), amount of spatial streams (bit 14-16) dot11_ht_vht_flags=0x00000551 <--short preamble encoded to 10th bit of dot11_ht_vht_flags. dot11_ht_vht_flags=0x00008bc8 <--80MHz info encoded to 9th bit of dot11_ht_vht_flags. The spatial streams information is already encoded to 16:15:14 bits of dot11_ht_vht_flags. The following are the bit pattern representation, 000 - 1 spatial stream 001 - 2 spatial streams 010 - 3 spatial streams Bug: 14452 Change-Id: If0539e356b32a791901d213a653f7a98521667ee Reviewed-on: https://code.wireshark.org/review/26178 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7b7e53e6bd7e7610b71ba3a5f9ddc8… commit 7b7e53e6bd7e7610b71ba3a5f9ddc87f5c583004 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Mar 3 22:31:13 2018 +0000 PDCP: show wrong calculated digest on MAC item, and add some comments about calculation Change-Id: I97445f87abd59761fb14b05dad2df98d2b127f7a Reviewed-on: https://code.wireshark.org/review/26250 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=eccbc4bade52bdd557a5c416693536… commit eccbc4bade52bdd557a5c416693536ca08a293b5 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Mar 3 13:39:18 2018 +0000 PDCP: don't link back security setup to self Change-Id: If74714846463394d99ec34bc36960c872f9726a9 Reviewed-on: https://code.wireshark.org/review/26241 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=432166de1e115df93b606378372855… commit 432166de1e115df93b606378372855cee4ba8ffc Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Wed Feb 28 13:36:55 2018 +0100 WiX: install the other plugin types as well The WiX toolset configuration files have to be extended to handle the new plugin directory structure as well. Apart from the EPAN plugins the wiretap and codec plugins have to be included as well. Change-Id: I173e6b87a88e4ef8aa3283a308e2b5207f0d6ba2 Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/26176 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=302fa6881751e5a8f9c8c197ab0008… commit 302fa6881751e5a8f9c8c197ab0008ee336e821a Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Mar 3 00:07:26 2018 -0800 Don't crash in manually_resolve_cleanup() if there's nothing to clean up. We might not yet have allocated the manually-resolved address lists; only free the if we have. Change-Id: Iff9864e397a04cdcb613268603c073ecd1fa77fb Reviewed-on: https://code.wireshark.org/review/26236 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=07cb624e48a8606ba4b603f94caa0e… commit 07cb624e48a8606ba4b603f94caa0e92853a1559 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 2 22:55:11 2018 -0800 Move what capture_info_close() does into its only caller. Change-Id: If9539142100fb2079cbbe247d8975778b183ece8 Reviewed-on: https://code.wireshark.org/review/26235 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c7872232e5661af50368d5d6154db1… commit c7872232e5661af50368d5d6154db13047320673 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 2 22:43:16 2018 -0800 More indentation cleanups. Change-Id: If24cf44a1ba9772d8fe2e026d19e6838cf8e0949 Reviewed-on: https://code.wireshark.org/review/26234 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=39dfda115ae1f89158cc56936db3c1… commit 39dfda115ae1f89158cc56936db3c110ce1d7ff2 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 2 22:39:12 2018 -0800 Clean up indentation. Change-Id: Id3d84d33590b12a91f15e7c2d8af350fb630b7b2 Reviewed-on: https://code.wireshark.org/review/26233 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=aeed520cd88a713d7eacd2fdc7e38c… commit aeed520cd88a713d7eacd2fdc7e38ca8b5f783cd Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 2 22:33:23 2018 -0800 Fix a warning message. Change-Id: Ice2ed63bb3785323949c466a67b287fd4f80fd12 Reviewed-on: https://code.wireshark.org/review/26232 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5bac06f00b6efa36fb497db4fb82f6… commit 5bac06f00b6efa36fb497db4fb82f6c06286886c Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 2 22:31:11 2018 -0800 Remove declaration of routine that no longer exists. The routine was removed in Id302e88bed4da8b9b457049fb78b0bc7d7ffabe3. Change-Id: I1874be1cb666d42011cc9b4ab9360dc885d3622c Reviewed-on: https://code.wireshark.org/review/26231 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d95d6a59c74c3e3e60d6de2159679e… commit d95d6a59c74c3e3e60d6de2159679e46b78c46e0 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Mar 2 14:43:12 2018 -0800 Remove an ipmap remnant. Change-Id: I391043aa0fdfce132a552e063d850d17bcf5a4de Reviewed-on: https://code.wireshark.org/review/26230 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f529ab5d0a27173ed68aa017a638b3… commit f529ab5d0a27173ed68aa017a638b36b3dcf585f Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Mar 2 11:24:31 2018 -0800 Remove the endpoint "Map" feature. Remove the endpoint map and its button from the Qt and GTK+ UIs. It depends on GeoIP Legacy for coordinate information and those databases are being deprecated in favor of MaxMind DB. We *could* upgrade the code to use mmdbresolve, but according to https://dev.maxmind.com/geoip/geoip2/geolite2/ they're also going to remove coordinate information from GeoLite2: "In addition, in 2019, latitude and longitude coordinates in the GeoLite2 databases will be removed.* Latitude and longitude coordinates will continue to be provided in GeoIP2 databases. Please check back for updates." Change-Id: I43e1593d282a0f1aae897b1f4724117d1496b21e Reviewed-on: https://code.wireshark.org/review/26229 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=84c7246e4c086f7bcfd7646a1d9f0c… commit 84c7246e4c086f7bcfd7646a1d9f0c08c13dd41b Author: Roland Knall <roland.knall(a)br-automation.com> Date: Fri Mar 2 13:48:39 2018 +0100 extcap: Make settings dialog modal Otherwise dialogs could be opened multiple times Change-Id: I19f9c11395b5f5ba41c00ff78ab9794064562d29 Reviewed-on: https://code.wireshark.org/review/26221 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0de7313fe24f96eaf48983906b8dbf… commit 0de7313fe24f96eaf48983906b8dbf3702f88470 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Fri Mar 2 16:00:31 2018 +0100 [NAS-5GS] Dissect more IEs. Change-Id: I67a86383688089f59573f6549e02d5e0027e1b4b Reviewed-on: https://code.wireshark.org/review/26224 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=80d652f06e205be070ba151158042c… commit 80d652f06e205be070ba151158042c12adbb2d7e Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Mar 2 09:11:31 2018 -0800 More spawned process handling updates. Document ws_pipe.h. Define invalid PIDs in one place. Extcap didn't use stdin before 1a0987904f. Make sure we close it. Change-Id: I7a69cd9b5137ae82435e64628a22e4d812d58f89 Reviewed-on: https://code.wireshark.org/review/26226 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=184ef021110d52d123104c77863df9… commit 184ef021110d52d123104c77863df92f7ecc5f6e Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Mar 2 09:58:07 2018 -0800 Fuzz-test: Handle ABRT. Trap ABRT and try to pass it on to our runners. Change-Id: I6e5a9fd63822c9bc84e116b3574abc4ccca448f5 Reviewed-on: https://code.wireshark.org/review/26227 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=51165cfcb741319925322d3779d7e2… commit 51165cfcb741319925322d3779d7e2214b890fd7 Author: Mathias Kurth <mathias.kurth(a)commsolid.com> Date: Fri Feb 23 15:31:18 2018 +0100 NAS-EPS: added heuristic udp dissector Change-Id: I5df909ac55be5d00f73bd2403b2c7d4b3d1494ca Reviewed-on: https://code.wireshark.org/review/26050 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=8451a8efdacc4a43d9df10571c7b09… commit 8451a8efdacc4a43d9df10571c7b09610eca7295 Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com> Date: Fri Mar 2 10:06:12 2018 +0100 XRA: added upstream channel id, sid and iuc to burstinfo dissect Change-Id: Ib46f5dd7199143847c83a77d19f9dd114ef9005c Reviewed-on: https://code.wireshark.org/review/26220 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=59b0d22ec00154a6a314a7f988e4b3… commit 59b0d22ec00154a6a314a7f988e4b393d1f966ee Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Thu Mar 1 23:18:17 2018 +0000 Windows: Update target version info Set the API target level to Win7, along with installer changes to match. Change-Id: Icd93964eadf93018c56218e3efdfed10b9f8959a Reviewed-on: https://code.wireshark.org/review/26218 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=13bb4911af9e36d9b95a9db5d6d9e9… commit 13bb4911af9e36d9b95a9db5d6d9e9058b710cff Author: AndersBroman <anders.broman(a)ericsson.com> Date: Thu Mar 1 17:00:19 2018 +0100 [NAS-EPS] Use proto_tree_add_bitmask_list() for some bitfields. Change-Id: I0b241a1e553beaf7527948ef067cc1f9356754c8 Reviewed-on: https://code.wireshark.org/review/26210 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e8088329ec35ad7c178695594996e6… commit e8088329ec35ad7c178695594996e6ea102ba7ea Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Mar 2 00:59:47 2018 -0800 One strstr() call suffices. If we've found "interleaved=" in the buffer *and*, if so, know where we've found it, we don't need to find it again; we can just use the result of the first strstr() call. That should also keep Visual Studio Code Analyzer from bogusly saying "hey, we might not have found it, maybe we're handing a bad pointer to sscanf()". Change-Id: I9d8f5c0b38038a3f05b8e5343f965f1676105875 Reviewed-on: https://code.wireshark.org/review/26219 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=24b5a55393bba27327998f2d608706… commit 24b5a55393bba27327998f2d608706dc73902aa9 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Thu Mar 1 08:42:14 2018 -0800 quic: Make sure that we still build when certain libraries not found. This adds some _U_ to prevent build failures when the build platform does not have certain libraries or more recent versions of those libraries. Change-Id: I82a1c14dd250181af189bd8564afc47180385e60 Reviewed-on: https://code.wireshark.org/review/26211 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=68e16ab05b7d6e726bd6adb7fab488… commit 68e16ab05b7d6e726bd6adb7fab48875f28a6631 Author: Lutz Kresge <LutzKr(a)protonmail.ch> Date: Thu Mar 1 16:25:40 2018 +0200 RLC: Fix duplication check after sqn reset When rlc sequence number wrapped around, duplicate frames wouldn't be marked because they were compared to the sqn from the first round. Change-Id: Ia57aac9b86b4cc84dd8ec411fe0a94972acb9526 Reviewed-on: https://code.wireshark.org/review/26208 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1fa2781b7a2e97a77b8ef7ddb3b3c4… commit 1fa2781b7a2e97a77b8ef7ddb3b3c48a93f2516d Author: Ajay Panicker <apanicke(a)google.com> Date: Thu Mar 1 18:18:18 2018 -0800 Bluetooth: Initialize ett features for Media Player Dissection The ett_btavrcp_features and ett_btavrcp_featuers_not_used fields were not initialzed causing an abort when dissecting. Change-Id: I3ee2f557ace1643dfba5a978add66c3c7ba7d895 Reviewed-on: https://code.wireshark.org/review/26217 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6e09b8b3913df943377b7710bbd059… commit 6e09b8b3913df943377b7710bbd0598f296be8fd Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Thu Mar 1 01:10:45 2018 +0000 PDCP: speed up dissection of status PDU. N.B. In normal traffic status PDUs do not appear very often, but if the config of RLC/PDCP are wrong, every PDU can appear to be a status PDU and it can take a long time to print out the list of missing sequence numbers. Change-Id: I9514b505639fa58d86bf5ebb3fb2bcf1f8e65aa8 Reviewed-on: https://code.wireshark.org/review/26197 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1a0987904fa571dc5abce03726e4ca… commit 1a0987904fa571dc5abce03726e4ca3e17793574 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Mar 1 15:31:45 2018 -0800 Generalize our process spawning code. Move the contents of extcap_spawn to ws_pipe. Rename various extcap_* prefixes to ws_pipe_*. Open stdin when we spawn processes. Change-Id: I9286295443ee955bb6328b0ed6f945ee0bb2a798 Reviewed-on: https://code.wireshark.org/review/26216 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bf4c2fd82b30d8b088fcb1235263dc… commit bf4c2fd82b30d8b088fcb1235263dce9173d4cd7 Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Thu Mar 1 00:01:45 2018 +0000 Windows: Remove cruft for unsupported versons Remove all the existing LoadDLL\GetProcAddress combinations that allowed conditional Win32 API usage if supported on the running OS version. All the required functions are present in the versions we support. Change-Id: Ibc43e51cefcd1c7562d4e251784362509f224ed6 Reviewed-on: https://code.wireshark.org/review/26215 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=92bb9ec9da549991f402082794638a… commit 92bb9ec9da549991f402082794638a4458e77a81 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Mar 1 18:19:57 2018 +0100 Fix compilation without pcap. Change-Id: Id9f6b9189c7663062ecc569a33ca2c30c4c86760 Reviewed-on: https://code.wireshark.org/review/26213 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=363ebc01ee5c4cf7bf75dd1a21b322… commit 363ebc01ee5c4cf7bf75dd1a21b322aa31d4772b Author: AndersBroman <anders.broman(a)ericsson.com> Date: Thu Mar 1 14:15:30 2018 +0100 [NAS-5GS] Dissect more IEs. Change-Id: Ief8d55bbee921e701c3374ce4073ae4587177989 Reviewed-on: https://code.wireshark.org/review/26209 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=85e7e61e5f001210af0b6d8f63315c… commit 85e7e61e5f001210af0b6d8f63315cf3317a4d0e Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Wed Feb 28 19:20:23 2018 -0800 ieee80211: Fix some issues with VHT/HE NDP Announcements. George Baltatanu noticed some issues, including subtrees in the wrong place, some spelling errors, bit display order, etc. Change-Id: I7e30e0e27e302bdd2b870a2bb01e7926336b413e Reviewed-on: https://code.wireshark.org/review/26188 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cca89ca8375328981c0d8373974e88… commit cca89ca8375328981c0d8373974e8891c01092e0 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 26 16:27:57 2018 -0500 gitlab-ci: add clang 7 builds. Compile nopcap with clang 7 instead of 6. Change-Id: Icc3ffc895e2b97feadca719b45ef72a5d79098cd Reviewed-on: https://code.wireshark.org/review/26207 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9e02ae10d51cb6e5c8d6fd8be62f11… commit 9e02ae10d51cb6e5c8d6fd8be62f119ee0a00b59 Author: Pavel Strnad <pavel_strnad(a)hotmail.com> Date: Thu Mar 1 10:00:45 2018 +0100 NAS-5GS: fix PD values for 5GS SM and 5GS MM -based on agreed cr https://portal.3gpp.org/ngppapp/CreateTdoc.aspx?mode=view&contributionUid=C… Change-Id: I1c382cee9bb2120d1df1db0f6436e5f139803a43 Reviewed-on: https://code.wireshark.org/review/26206 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4b4d11e4c350380be2f99f28bfec0a… commit 4b4d11e4c350380be2f99f28bfec0a4058f51dd8 Author: Dana Sy <dana.hayden.sy(a)gmail.com> Date: Wed Feb 28 16:37:37 2018 -0800 ZigBee TP2 buffer test request malformed packet Test profile 2 buffer test request is trying to parse "octet sequence" which is not part of the command frame for the buffer test request. Change-Id: I9f35aacbb3c70b5daed07a0ea29b1bec1cf7741a Reviewed-on: https://code.wireshark.org/review/26196 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cd83fc508793a01998ae04fbdde25d… commit cd83fc508793a01998ae04fbdde25d70d9b7a179 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Wed Feb 28 22:51:36 2018 +0100 [PFCP] improved various value printout Change-Id: Ica2ce06d69c6fb2812c1ddb17a2dcce6e58e1a96 Reviewed-on: https://code.wireshark.org/review/26193 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b5b5f08be1ec26340235b5b7eed411… commit b5b5f08be1ec26340235b5b7eed411a2083f73dc Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 26 10:39:27 2018 -0800 Qt: Make we shut down cleanly when exiting early. Add an exit_application() routine that calls wsApp->quit() + exit() in the Qt UI and exit() in the GTK+ UI. Make sure we call it instead of exit() when needed. Bug: 14395 Change-Id: I171b5fd19ce4664db4a2ebb4b8c33e278dcec427 Reviewed-on: https://code.wireshark.org/review/26121 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e70e560cab016f5170dc0d00726e80… commit e70e560cab016f5170dc0d00726e80ff0de1b11a Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Feb 28 08:04:25 2018 +0100 QUIC: Add heuristic for avoid conflict with GQUIC and UDP port 443 is not (yet) official port for QUIC... Bug: 13881 Change-Id: I637241bd327adc6c5cccbcd68524d2ef3811e8e8 Reviewed-on: https://code.wireshark.org/review/26166 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c332f6e1f9f90df90cd62c4108f95a… commit c332f6e1f9f90df90cd62c4108f95a85515f34a4 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Feb 24 17:53:33 2018 +0100 QUIC: Add dissection of RETRY Bug: 13881 Change-Id: I49075dc227c0b132ef4bc37d1ff28b14bbfd3e4f Reviewed-on: https://code.wireshark.org/review/26083 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8c85f0c35c4383919e0467b44cd3f2… commit 8c85f0c35c4383919e0467b44cd3f208f280404d Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Feb 24 17:44:37 2018 +0100 QUIC: use switch/case for long_packet_type and move to function Ping-Bug: 13881 Change-Id: If601344d042909ae190226f8039f0b9d016fb8d7 Reviewed-on: https://code.wireshark.org/review/26082 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1e26cb242fc4e52b3c99663fa1abd3… commit 1e26cb242fc4e52b3c99663fa1abd3a187aa8d7d Author: AndersBroman <anders.broman(a)ericsson.com> Date: Wed Feb 28 16:54:01 2018 +0100 NAS-5GS: More dissection. Change-Id: Iedf85db2b1da07f1a6b87db20250034b795cfd34 Reviewed-on: https://code.wireshark.org/review/26179 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=00373a1fd4f4cd75a0fb2f2c21b7d9… commit 00373a1fd4f4cd75a0fb2f2c21b7d9fd567a41b9 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 18:43:44 2018 -0800 Simplify the mode passed to CreateNamedPipe(). There's one mode you use if byte_mode is true, and another mode you use if it's false. My head hurts when I try to pretend to be a top-down parser for C and feed myself the existing expression, and Visual Studio Code Analyzer says "are you sure that's what you had in mind?", so I'm guessing the modes are: byte mode: PIPE_TYPE_BYTE | PIPE_READMODE_BYTE | PIPE_WAIT not byte mode: PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT and am just using one test of byte_mode to choose between them. Put the entire function under an #ifdef, so we can mark the byte_mode argument as unused on UN*X but not on Windows. Change-Id: Ib2d0b80f870b1789c1375ccb017bd90e93dca5ce Reviewed-on: https://code.wireshark.org/review/26201 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=efd8beff4f9a6b39a7b43b18716bce… commit efd8beff4f9a6b39a7b43b18716bceb4a9f07e1f Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 17:52:34 2018 -0800 Don't handle various "command to send" values in the default case. The default case ignores the high-order bit, which is set in all the values for "command to send", so they will never be matched. The values moved out of the default case, if their upper bit is clear, either don't correspond to any command in T.30 or correspond to an initial identification command, which never has the upper bit set, so there's no risk of misidentification by processing all of the "command to send" values outside the default case. Thanks and a tip of the Hatlo hat to Visual Studio Code Analysis for catching this one. Change-Id: I6192b0c5a6dcfd31b9fd757be736a311a9d089e6 Reviewed-on: https://code.wireshark.org/review/26198 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=620f69a74b18908e3424920c7bb01c… commit 620f69a74b18908e3424920c7bb01cb5e4cbd8b1 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Mon Feb 26 23:19:15 2018 +0100 mp4: limit the recursion depth for boxes Although the dissection of each box header consumes a couple of bytes, it turned out that it's still possible to crash wireshark with a sample file that contains a large number of nested boxes. The stack will fill up before we reach the end of the data bytes. Keep track of the recursion depth as we walk through the hierarchy of boxes. Abort if we reach the (locally defined) upper limit. Bug: 13777 Change-Id: I0f67245a5c74131f10d0f9d99b39ad31711b9775 Reviewed-on: https://code.wireshark.org/review/26167 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=94d3f0afc5ad2cdcbba126ed9c16eb… commit 94d3f0afc5ad2cdcbba126ed9c16eb933e86cc54 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Wed Feb 28 21:20:49 2018 +0100 [PFCP] added two more IEs 8.2.86 Subsequent Volume Quota 8.2.87 Subsequent Time Quota Change-Id: I00b99c5fcc9fc7c157a048c1cbd901b56e12a8d7 Reviewed-on: https://code.wireshark.org/review/26189 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7df07eb9227fc35cf82d7edacf4a3d… commit 7df07eb9227fc35cf82d7edacf4a3d792c368314 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 13:55:02 2018 -0800 Print the right value for signed statistics tap table items. Thanks and a tip of the Hatlo hat to Visual Studio Code Analysis for finding this one. Change-Id: If2312ba98d1c3060e525dd8b2afe3e0ff07fb5bd Reviewed-on: https://code.wireshark.org/review/26194 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9226ea8dee19d509b7c430970d2905… commit 9226ea8dee19d509b7c430970d29055cc199b2dd Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Feb 22 08:03:12 2018 +0100 flex: add also (-W)unreachable-code to ignore warning (for flex generate file) Change-Id: I09ab6d91b45113432255cb20ae30440ea0438b23 Reviewed-on: https://code.wireshark.org/review/25984 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=16ac61e2a353fbf940cf8eeee9d501… commit 16ac61e2a353fbf940cf8eeee9d5018ea2a12641 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 12:23:57 2018 -0800 Fix StringCchPrintf() calls. One was missing an argument; supply the necessary string. The other was assuming that an LPARAM was 32 bits when that's not the case on 64-bit Windows - the underlying value is 32-bit, so we just cast to int. Change-Id: Ie2a38e27f2ea211628d2c751a7807bb9ed396c64 Reviewed-on: https://code.wireshark.org/review/26190 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ea0b580b978834a4ce0ea8c29cf02d… commit ea0b580b978834a4ce0ea8c29cf02da1a3512c0a Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 12:07:55 2018 -0800 Fix a check. Presumably the intent is to check for unsigned integer and signed integer types, not to check twice for unsigned integer types. Thanks and a tip of the Hatlo hat to Visual Studio Code Analyzer for finding this. Change-Id: Ie8e4d231af929ee8e626c5c9258c3356d5209f4f Reviewed-on: https://code.wireshark.org/review/26187 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=03474c1303faeed68631e4074ba692… commit 03474c1303faeed68631e4074ba692bdc193323d Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 11:45:32 2018 -0800 Redo the way we choose N/S/E/W. This should squelch a warning from Visual Studio Code Analyzer. Change-Id: Ie66e45276458a6f880c9b020ff541b7d2a71433a Reviewed-on: https://code.wireshark.org/review/26184 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d11f43a30e89dbeb56115824b9a132… commit d11f43a30e89dbeb56115824b9a1329b0d77f95e Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Feb 8 15:06:39 2018 +0100 QUIC: Display GREASE version.. Change-Id: I1005bbaf528e91dd8244fb94a0530d9152db38a0 Reviewed-on: https://code.wireshark.org/review/25691 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9f2dff98f6526412e8065a8c9ade81… commit 9f2dff98f6526412e8065a8c9ade811dcb1974fe Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 28 01:27:27 2018 -0800 Include <config.h> so UNICODE is defined. All other files should do so; this file should, so that we're using the Unicode versions of Windows APIs (especially given that other files that include wsutil/unicode-utils.h will be doing so and expecting UTF-16 strings from utf_8to16_snprintf()). Change-Id: I7eccf580ab0dc504aa78b345e36e2fcda818a7c5 Reviewed-on: https://code.wireshark.org/review/26170 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7eff18a997a81935f22833b69af730… commit 7eff18a997a81935f22833b69af730f786865204 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 27 14:42:57 2018 +0100 t38: allocate memory in pinfo pool scope. Change-Id: I627f21f2f67589374749f4f16f5d71cf45d98d68 Reviewed-on: https://code.wireshark.org/review/26137 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=07bb8fc04794a1d8e76bb1bee34011… commit 07bb8fc04794a1d8e76bb1bee3401122d054b32d Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 28 13:59:13 2018 +0100 dof: don't initialize nonce it is useless. Change-Id: I300145c04293fa06ea6af0a5797d27023c3b2fbc Reviewed-on: https://code.wireshark.org/review/26177 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=87dfaa72cfa24b92fdd1e60deccfda… commit 87dfaa72cfa24b92fdd1e60deccfda3b3eb2fd78 Author: Robert Sauter <sauter(a)locoslab.com> Date: Fri Feb 23 16:10:27 2018 +0100 6LoWPAN: Less scary display if UDP checksum is elided Set the 'recomputed' checksum to 0xffff instead of 0 so that the UDP dissector does not show an 'Illegal Checksum value (0)' PI_ERROR. Bug 14458 Change-Id: I0fba0979be5a5b2957a7cec98c0df7996491d3b5 Reviewed-on: https://code.wireshark.org/review/26052 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=389a680cf766436e261c369243e8f5… commit 389a680cf766436e261c369243e8f58728801990 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 28 11:37:11 2018 +0100 csn1: set pointer before using it (found by clang). Change-Id: I4ff2fb3861725a492736facd2d084baeef8fd09f Reviewed-on: https://code.wireshark.org/review/25993 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0fb38879af867b147d2ad73616f0c0… commit 0fb38879af867b147d2ad73616f0c0ec08a0fc92 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Tue Feb 27 08:22:25 2018 +0100 L16_mono: Add L16 monaural codec plugin as functional example This codec plugin serves a dual purpose. First it is to add L16 codec suppport to Wireshark. Second it is an illustration of a basic codec plugin module. Change-Id: I64394dab3257ae49dece0257b16cd969503918e2 Reviewed-on: https://code.wireshark.org/review/26131 Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b405a9f0d2af056dd0c0e4d15271ff… commit b405a9f0d2af056dd0c0e4d15271ff7dfdd5c928 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 28 12:38:06 2018 +0100 rrc: remove unused function. Change-Id: Id3d0c8ffb7a2f4c1a51678aa112beb56adc84609 Reviewed-on: https://code.wireshark.org/review/26174 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b8101ed9a905460050d5dfc1ad03e2… commit b8101ed9a905460050d5dfc1ad03e2af6c24fea2 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 27 17:32:24 2018 +0100 rrc: move allocation within if statement. Change-Id: I2282a834560ef81a4f974e80fd6a0286e83a5461 Reviewed-on: https://code.wireshark.org/review/26143 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2db0957d49df502b556adf99c88fca… commit 2db0957d49df502b556adf99c88fcaba646ec165 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Feb 28 09:02:15 2018 +0100 tshark(.pod): fix spelling-error-in-manpage found by lintian inital => initial Change-Id: Id92a853bd6b24e06b2f6074903f8e89249c6c2cc Reviewed-on: https://code.wireshark.org/review/26168 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dfd0e65e3087548bb7216dce7ad2e3… commit dfd0e65e3087548bb7216dce7ad2e332292f9d14 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Feb 27 22:33:32 2018 +0100 GQUIC: Try to fix ACK frame with Q039 Change-Id: Id717c5354826c6aac0b72426213a128e0f501377 Reviewed-on: https://code.wireshark.org/review/26154 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5488c29b15cc505a048283f6292ade… commit 5488c29b15cc505a048283f6292ade8e41129840 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Feb 27 20:05:39 2018 +0100 GQUIC: Change all integers (and floating) encoding Change-Id: I197bf7f47685b9d66e5df5cc091904834eea20cd Reviewed-on: https://code.wireshark.org/review/26153 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=417028073a037fa4fb5daac6cc9c16… commit 417028073a037fa4fb5daac6cc9c168354675619 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Feb 27 19:14:21 2018 +0100 GQUIC: for item with length = 1, use ENC_NA for encoding Change-Id: I3b65e7a2c27763448717415a12a59d773fdb5d65 Reviewed-on: https://code.wireshark.org/review/26152 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d8e73722185f5876adf0524dc4e48f… commit d8e73722185f5876adf0524dc4e48f6e858872f4 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Feb 27 19:11:36 2018 +0100 GQUIC: Packet Number is now big endian With Q039 is now big endian for integers and floating number Bug: 14462 Change-Id: Ifc2bd4454830e2f4328c4c1d8d1ea37d3542e8da Reviewed-on: https://code.wireshark.org/review/26151 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=eb15a1ed19bb4be5c03aaf39e87cd5… commit eb15a1ed19bb4be5c03aaf39e87cd5c25fe1d907 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Tue Feb 27 22:56:29 2018 +0100 BGP: Heuristic for IPv6 NLRI path identifier NLRIs can contain path identifiers as defined in RFC7911. This commit adopts the IPv4 heuristic to IPv6 to detect usage of additional path identifier. Bug: 14241 Change-Id: I6b99c079b12d1f9a3e05b152a5540a621076e965 Reviewed-on: https://code.wireshark.org/review/26157 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=faf6ee9ada079e80d03b937df0d828… commit faf6ee9ada079e80d03b937df0d8285a84bd2c37 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Wed Feb 28 00:13:29 2018 +0100 [PFCP] added Aggregated URRs IE Added Table 7.5.2.4-2 Aggregated URRs 8.2.84 Multiplier 8.2.85 Aggregated URR ID IE Change-Id: Ic7b25d155c4c113503319e1360910dd09407a55f Reviewed-on: https://code.wireshark.org/review/26161 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d023a7b2311e5094fa3e4d541a0200… commit d023a7b2311e5094fa3e4d541a0200901a4a7a7f Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Tue Feb 27 22:31:25 2018 +0100 [PFCP] Name update of IEs 8.2.31 SxSMReq-Flags -> PFCPSMReq-Flags 8.2.32 SxSRRsp-Flags -> PFCPSRRsp-Flags In accordance with 3GPP TS 29.244 V15.0 Change-Id: I5650366bd061ffd51f8577aeb420681abced5889 Reviewed-on: https://code.wireshark.org/review/26150 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fe363c540e0a16d7d27891030dbd15… commit fe363c540e0a16d7d27891030dbd15ab241046ea Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 27 20:19:48 2018 -0800 Make sure GetModuleHandle(_T("kernel32.dll") succeeds. If it doesn't, we're living in the Twilight Zone - that's like not finding libc/libSystem/whatever-your-UN*X-calls-it on a UN*X - but this should at least remove one complaint from Visual Studio Code Analyzer. Change-Id: Iccb568ea022ac28be962ab3fec5bccdfdf69ac13 Reviewed-on: https://code.wireshark.org/review/26165 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=768488d21e0de005b61026a1d234ad… commit 768488d21e0de005b61026a1d234ad52b5b632cf Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Feb 27 17:08:50 2018 -0800 ieee80211: Fix handling of compressed block acks. Thomas Derham pointed out that there was a problem with my changes and supplied a fix. The pronblem was that I was fetching important info after offset had moved on. This change is slightly different but works for Thomas. Change-Id: I45862b87f3d9626285111dab83a0067d3d529ab2 Reviewed-on: https://code.wireshark.org/review/26162 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=48a4ed105882684e58d01d8edb7b3e… commit 48a4ed105882684e58d01d8edb7b3ebdacf1e975 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 27 20:12:53 2018 -0800 Squelch some Visual Studio Code Analyzer warnings in Flex-generated scanners. Hopefully this filters out stuff about which we can't do very much (other than send off a Flex fix and wait for it to be accepted and end up in a WinFlexBison package), making it easier to find the stuff about which we *can* directly do something (i.e., problems in code *we* wrote). Change-Id: I9dec0389c3e126697acb307d30a823b9b285ef45 Reviewed-on: https://code.wireshark.org/review/26164 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d4ef22db8f21f7ed5ebf16bfcf335e… commit d4ef22db8f21f7ed5ebf16bfcf335e32102bfe8d Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 27 18:50:33 2018 -0800 Make sure CAPACITY() doesn't shift the 1 out of range. Make the 1 we shift left the size of a size_t, so it'll only go out of range if the result couldn't possibly fit in a size_t. (That should also make the object of the shift unsigned, which may squelch some other complaints.) Not that the map is *likely* to be bigger than 4GB, but it should squelch some complaints from Visual Studio Code Analysis. Change-Id: I489bfe6b1d9d4329c267936d9106dbba4388c492 Reviewed-on: https://code.wireshark.org/review/26163 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ac69a67112a776f857614e7a11ffd7… commit ac69a67112a776f857614e7a11ffd7012d7e80e8 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Feb 27 13:50:31 2018 -0800 ieee80211: Fix the handling of PPE Thresholds for 802.11ax. Change-Id: I74b9e3e6d459378bc9cc308d13375d2e13b64f73 Reviewed-on: https://code.wireshark.org/review/26160 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7176b321660fe70ca1fa6706cc184a… commit 7176b321660fe70ca1fa6706cc184af8e4cb80ea Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 27 23:15:16 2018 +0100 addr: Include trailing '\0' in length from ipv6_to_str() All other 'addr_to_str' functions does include the trailing '\0'. This is a bug introduced in g7507b11e. Change-Id: I6ac2be6d8aedf5c7fbea9dfe67b4d2b4c7f50a6f Reviewed-on: https://code.wireshark.org/review/26159 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bbb6bcbbab9c35caecc8e0ff997b6d… commit bbb6bcbbab9c35caecc8e0ff997b6da6b2e91210 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 27 15:05:27 2018 +0100 rtspstat: use integer cast in g_hash_table. Change-Id: I5ebdbe5a94ed377c120411c46daca3903036fe42 Reviewed-on: https://code.wireshark.org/review/26140 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7a79a6019e21257a7d6f275ce8d644… commit 7a79a6019e21257a7d6f275ce8d6441034a945ab Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Tue Feb 27 22:47:17 2018 +0100 [PFCP] updated Report Type IE Added Bit 4 – UPIR (User Plane Inactivity Report) Change-Id: Ic39161dab608252386fcac350ca2c93991ef6f6f Reviewed-on: https://code.wireshark.org/review/26155 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2024eb1fbcb025e79f777db01e16cf… commit 2024eb1fbcb025e79f777db01e16cf9a55cf2a8d Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Tue Feb 27 22:56:45 2018 +0100 [PFCP] updated Measurement Information IE Added Bit 3 – RADI (Reduced Application Detection Information) Change-Id: If55db7f72148fb6faa9b3400a85b041e60761da3 Reviewed-on: https://code.wireshark.org/review/26156 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=04c2cbc9a8b34fd875470053a7e332… commit 04c2cbc9a8b34fd875470053a7e332f5a544469a Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Tue Feb 27 23:08:05 2018 +0100 [PFCP] more name changes 8.2.77 Sx Association Release Request -> PFCP Association Release Request Change-Id: I325d299a2d9d5c0bee40c2a7650906026cee02b5 Reviewed-on: https://code.wireshark.org/review/26158 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1055a6a76decc40e5d9233909303b1… commit 1055a6a76decc40e5d9233909303b1f0f507ad7b Author: Joerg Mayer <jmayer(a)loplof.de> Date: Mon Feb 26 17:50:49 2018 +0100 lacp: Info column and display filter rework - Add key and flags to info column - More hierachical display filter names - Remove almost all verbose field descriptions Change-Id: Iffa24321f2ee36034fb315714506da200e17e760 Reviewed-on: https://code.wireshark.org/review/26127 Petri-Dish: Jörg Mayer <jmayer(a)loplof.de> Tested-by: Petri Dish Buildbot Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=32e99b355dca8a047259819942e6c0… commit 32e99b355dca8a047259819942e6c0bdbdfe219a Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 27 10:10:54 2018 -0800 CMake: Add more .PDBs to pdb_zip_package. Add .PDBs under the extcap and plugin directories to the Wireshark-pdb-xxx.zip package. Change-Id: Icc003a212f21c02bcf8ccf326b43cfebbf32a9a3 Reviewed-on: https://code.wireshark.org/review/26146 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=8f4ea952b4a962453f279c7259baad… commit 8f4ea952b4a962453f279c7259baad9ce98feee7 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 27 21:47:07 2018 +0100 6lowpan: Use correct offset for "UDP header compression" header Change-Id: I900dce329a593e55b894faf3e41071893ed91c46 Reviewed-on: https://code.wireshark.org/review/26147 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=c7c034172ed4fc4e8d6982f598db82… commit c7c034172ed4fc4e8d6982f598db82c80d930ee2 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Feb 26 17:19:54 2018 +0100 [NAS-5GS] Dissect more of the protocol. Change-Id: Id398922f86902cc23053191e6f22b77511270077 Reviewed-on: https://code.wireshark.org/review/26134 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9a512f7aa69fd82841d2367c0bb63c… commit 9a512f7aa69fd82841d2367c0bb63cecd45ff315 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 27 14:05:31 2018 +0100 lacp: remove unused assignments (found by clang). Change-Id: I230eec0649bb421bac2762b674bf6d0ae5e3afdb Reviewed-on: https://code.wireshark.org/review/26135 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b0328ae52e95fb0eae14e11c7b13d3… commit b0328ae52e95fb0eae14e11c7b13d3591836db60 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Feb 25 09:38:16 2018 +0100 wisun: extend EDFE display; fix Authenticator EUI-64 field name Change-Id: Ia0ef5d4f982a39c8addf5208481378f50d0f8bcf Reviewed-on: https://code.wireshark.org/review/26094 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=4314ac72c1ecfee5b39d5d9af12711… commit 4314ac72c1ecfee5b39d5d9af12711dd39ee4ab3 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Tue Feb 27 12:32:36 2018 +0100 [XML] Add application/rs-metadata+xml Change-Id: I766ece91273603d6dd53a05771631dfc10b17566 Reviewed-on: https://code.wireshark.org/review/26133 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1653ea5fcedf369452c0cf41e09e57… commit 1653ea5fcedf369452c0cf41e09e57666525615c Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Feb 25 21:16:52 2018 +0100 adb: fix buffer overflow while processing message payload Fix a heap buffer overflow (write) when the message header length is smaller than the actual message payload length. Add expert info to detect this since it can also occur when the header is wrongly matched with a data fragment (this dissector issue is not fixed here). Bug: 14460 Change-Id: I12f411a5189809a0931dfcdb2797997d5e19efc1 Reviewed-on: https://code.wireshark.org/review/26104 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba0f4b9d9f954c985cd260feeae456… commit ba0f4b9d9f954c985cd260feeae4560b5f54668a Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Feb 25 17:53:21 2018 +0100 adb: fix Malformed packet while parsing CONNECT command Previous adb versions included a NULL terminator in the banner, but this is not required by the specification[1] and in newer versions there is no such terminator. This patch fixes issue 1 of bug 14460. [1]: https://android.googlesource.com/platform/system/core/+/android-8.1.0_r7/ad… Change-Id: I0a3ad1499d68d38c430dd386854ddba0ce755538 Ping-Bug: 14460 Reviewed-on: https://code.wireshark.org/review/26097 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=61d033645d7b146c2535fce8ed1cbb… commit 61d033645d7b146c2535fce8ed1cbb6272dde2d7 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Feb 25 15:41:02 2018 +0100 Qt/USB: Allow USB src/dst addresses to be selected for columns Make "Prepare a Filter" from the Source and Destination columns work for USB source and destination address, this value must be quoted as well. Change-Id: Ib7a772050c204e716781cc27f9eddbdb7971e547 Reviewed-on: https://code.wireshark.org/review/26096 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=30692e2f3a872a91d5c41cf59badf3… commit 30692e2f3a872a91d5c41cf59badf3eb393c5734 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Feb 25 01:11:25 2018 +0100 Allow hexadecimal and octal numbers for tshark Decode As tshark(1) documents "-d ethertype==0x0800" which suggests that hexadecimal values must be accepted. While at it, be a bit more stricter about the selector match (previously "1-2 junk" was accepted too, reject trailing spaces now). Change-Id: I85fbd2f55eaef51902ddaf2e559ab08ad59a5af7 Reviewed-on: https://code.wireshark.org/review/26089 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5cbc09e937a9827219938165a69200… commit 5cbc09e937a9827219938165a6920079737a643e Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Feb 25 00:19:43 2018 +0100 Qt: accept hexadecimal input in Decode As dialog The usb.product dissector table displays vendor+product values as hexadecimal, ensure that these are not parsed as zero. While at it, clarify the meaning of the model contents. Ideally the model should store numeric selectors as integers rather than strings, but that requires more work. Change-Id: I3bb17ad0d0a03c8813ded4ea6890dbc2aedd738d Reviewed-on: https://code.wireshark.org/review/26087 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=15c261e94b888b0ae4e6122fb11fba… commit 15c261e94b888b0ae4e6122fb11fba2219c932fa Author: Anthony Coddington <anthony.coddington(a)endace.com> Date: Mon Feb 26 11:21:25 2018 +1300 ERF: Add support for new extension header and Provenance tags Add support for Entropy Extension header, currently with one field. Uses a conversion function to convert representation to bits. Add various entropy and tap mode Provenance (ERF_TYPE_META) tags. The only complex tag is ext_hdrs_added/removed. This tag consist of up to 4 big endian uint32 bitfields, with each bit representing an extension header number. ehdr_type_vals and a new ehdr_type_vals_short are used to generate the tags. Custom printing is used for the header line to display unknown values as integer and support the special case of <All>: all supplied bits 1 meaning all extension headers removed. Storage for the up to 4 subtree header_field id entries is in the first 4 extra hf_values[] for now, the ett value is reused. Increase erfmeta_tag_info_ext_t ERF_HF_VALUES_PER_TAG to 32. A better solution is needed sooner rather than later but the structure is only allocated for tags that need it. Change-Id: I9e359f044131bce2afc189bebc21239eed429b21 Reviewed-on: https://code.wireshark.org/review/26111 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=21b4d6ecf1e287658565092720870f… commit 21b4d6ecf1e287658565092720870f0b6aba1c15 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 26 14:00:56 2018 +0100 multipart: initialize value before function call (found by clang). Change-Id: I0883526b064b044bbfb188e14e20cc95270f1e6a Reviewed-on: https://code.wireshark.org/review/26115 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=629e68828c3fe751c1e00d033227f2… commit 629e68828c3fe751c1e00d033227f23ccc3bb0f8 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 26 17:15:03 2018 +0100 rrc: check parameter when creating cipher info (found by clang). Change-Id: I85e4d0f62b4c4c16f74f229a8dfcea0e27048def Reviewed-on: https://code.wireshark.org/review/26117 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f31bc46948695d7156f2f130733a29… commit f31bc46948695d7156f2f130733a29706b900621 Author: Paul Zander <p.j.zander(a)lighting.com> Date: Mon Feb 26 21:44:43 2018 +0100 Add ZigBee ZCL Identify cluster command. Change-Id: Ie0ed2388c2f0d992e053166d740209a8e354f31e Reviewed-on: https://code.wireshark.org/review/26122 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0a113beceabcc0cd731874cc482dbb… commit 0a113beceabcc0cd731874cc482dbb83e9bcdf4e Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Tue Feb 27 00:44:26 2018 +0100 [PFCP] refactor flags and triggers Change-Id: I78bd69f9ac1e3279f90687272fc3056ec2d1d633 Reviewed-on: https://code.wireshark.org/review/26128 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c4521c24f6bfb727d0ff77506cc926… commit c4521c24f6bfb727d0ff77506cc926b3f9d98e06 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Mon Feb 26 23:19:06 2018 +0100 [PFCP] fixed Graceful Release Period IE * If stopped there is no time to show * Default shall be multiple of 1 min Change-Id: I68c170501923e689c1e18f40fed8e134ff4e7d69 Reviewed-on: https://code.wireshark.org/review/26126 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7dc9392deaee381b0b3e9c7855a68b… commit 7dc9392deaee381b0b3e9c7855a68b0caf54d1cb Author: Paul Zander <p.j.zander(a)lighting.com> Date: Mon Feb 26 17:58:24 2018 +0100 Add undefined ZigBee ZCL Power cluster attribute. Change-Id: I47b70bcc16f03967110b8867e85645ae124e229d Reviewed-on: https://code.wireshark.org/review/26118 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=09765707a7a65c9ff3fc89899647e9… commit 09765707a7a65c9ff3fc89899647e977c230d9bf Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Mon Feb 26 23:10:18 2018 +0100 [PFCP] Fixed order of IPv4 and IPv6 in Remote GTP-U Peer IE In accordance with 3GPP TS 29.244 Section 8.2.70 Change-Id: I6d6bc47426b3449cc751b9c3a6d7f2c35f257b41 Reviewed-on: https://code.wireshark.org/review/26125 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6b66e764eeb864e559c9c87d427f98… commit 6b66e764eeb864e559c9c87d427f98b3848fd78f Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Tue Feb 27 01:06:39 2018 +0000 catapult dct2000: don't dump comments one char at a time, and other fussing Change-Id: Ib9dc06aabdcd4c8da9e0f6512cafc306ceeedd5f Reviewed-on: https://code.wireshark.org/review/26130 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1c1498834d0bb14a1d53db5fd0b39a… commit 1c1498834d0bb14a1d53db5fd0b39acada71bf66 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 26 13:51:12 2018 -0800 Squelch some warning noise when dsymifying. Change-Id: I1e6c05ce9d2f08abb7e3f86a95cc7b8f8af56ab2 Reviewed-on: https://code.wireshark.org/review/26124 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7b3ce599ece41d9199965069488f00… commit 7b3ce599ece41d9199965069488f00bf30edc4dd Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 26 13:19:38 2018 -0800 Dsymify binary files. See if that makes it possible for CrashReporter to fully symbolicate crash dumps, so the user gets line numbers and the like in crash dumps from the OS, and we get them if the user sends a crash dump to us. Change-Id: I8bb48b2d2f6b3e23fea43c1a3bd3a5a9a97a5c2c Reviewed-on: https://code.wireshark.org/review/26123 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=12f8f43893ea3d31e4f18b356af581… commit 12f8f43893ea3d31e4f18b356af581e14becd8a3 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 26 09:47:07 2018 -0800 NAS 5GS: Comment out unused variables. Comment out a couple of as-yet-unused variables. Change-Id: I4a5b16f58f18bbb71a003379c623a82377585d82 Reviewed-on: https://code.wireshark.org/review/26119 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=74641daaae226adf2b248ada91697c… commit 74641daaae226adf2b248ada91697cf3e244ec74 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Feb 25 21:31:07 2018 +0100 adb: fix decoding of local-id argument of Write Tested with adb-oreo.pcapng from bug 14460, packet 110 should show "Write(10, 1)" instead of "Write(0, 1)" per spec: https://android.googlesource.com/platform/system/core/+/android-8.1.0_r7/ad… Change-Id: Ifa9fb43979237b7a28586e1d41859b455d3cf5ab Reviewed-on: https://code.wireshark.org/review/26105 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michal Labedzki <michal.labedzki(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ef0e8416d58d7ff9be336f26f183c2… commit ef0e8416d58d7ff9be336f26f183c27a3387e71b Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Feb 26 10:51:55 2018 +0100 [GTPv2] Add new IE UP Function Selection Indication Flags Change-Id: I2eeecea0ae907c6bdcc75dc9d9ee4e35d8adcf44 Reviewed-on: https://code.wireshark.org/review/26114 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=43038830050fddeb2bed423bbe3fdd… commit 43038830050fddeb2bed423bbe3fdd62f9429309 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Feb 19 10:27:08 2018 +0100 [NAS 5GS] Add dissector for NAS5GS 3GPP TS 24.501. This is not a complete dissector but can be commited as is. To be worked on. Change-Id: I2e698b57c849013657a1eeacef4b984c8b8c39ee Reviewed-on: https://code.wireshark.org/review/26051 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=73e9605adb42f2b6955104a39e2d66… commit 73e9605adb42f2b6955104a39e2d66573d8d9792 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Thu Feb 22 11:09:47 2018 +0100 LACP: Begin adding more info to the INFO column Change-Id: I77dae1ab7f5327e1a2e8f405fab20e06624c584e Reviewed-on: https://code.wireshark.org/review/26112 Petri-Dish: Jörg Mayer <jmayer(a)loplof.de> Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=7fadcdb7ac5b19c50e7f2f78a4485d… commit 7fadcdb7ac5b19c50e7f2f78a4485d6d9577082e Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Feb 26 10:21:00 2018 +0100 [Diameter-3gpp] Add bit 8 in Access-Restriction-Data according to 3GPP TS 29.272 V15.2.0 Change-Id: I1a9db8f0350f6b8916a321ddfcdf6d9ccc9f462a Reviewed-on: https://code.wireshark.org/review/26113 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=be1c9336000c0941fd763f9bceb39b… commit be1c9336000c0941fd763f9bceb39bf6958165cb Author: Peter Wu <peter(a)lekensteyn.nl> Date: Thu Feb 15 19:09:50 2018 +0100 DNS: add partial DOH (DNS Queries over HTTPS) support Add support for POST requests, and GET and POST responses containing a DNS (UDP) payload. GET requests are still unsupported. (DOH is sent over HTTP2/TLS/TCP which means that a special check is needed in dissect_dns to avoid matching DNS over TCP). Change-Id: I82bfcda068baf6f06c5a0159d73e6d40d1d9a758 Ping-Bug: 14433 Reviewed-on: https://code.wireshark.org/review/25806 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f220073eec4b951d6d0179068d5d4f… commit f220073eec4b951d6d0179068d5d4ffb59537881 Author: Jiri Novak <j.novak(a)netsystem.cz> Date: Fri Feb 23 13:47:12 2018 +0100 RTSP: Added support for pipelined RTSP responses Patch allow RTSP dissector to decode multiple RTSP responses in one packet. Decoded without the patch shows second and subsequent responses as "data". Bug: 14450 Change-Id: I2cc42b1544dd6b4f6a7e5eea67b0b2a10eed0fc6 Reviewed-on: https://code.wireshark.org/review/26049 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e9ffd03be350fcb1c6710e8a40c259… commit e9ffd03be350fcb1c6710e8a40c2591629553500 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Feb 25 10:44:29 2018 +0100 wisun: support EAPOL Relay (1v21 format) Change-Id: I6b4644f7ad8061e8f9fc11238e17e6d01596cb39 Reviewed-on: https://code.wireshark.org/review/26095 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9e487bc46511b1044d11e42ec42672… commit 9e487bc46511b1044d11e42ec42672753360cffb Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Mon Feb 26 00:10:07 2018 +0000 PDCP: trivial changes Change-Id: Id18da688a7ed056055b0dc30eced12797955e243 Reviewed-on: https://code.wireshark.org/review/26107 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f5cd52c0fb8933973003e07ab130fe… commit f5cd52c0fb8933973003e07ab130fefbdabfb4f4 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 25 18:40:11 2018 -0800 Docs: Reduce our TOC depth. Reduce the TOC depth so that it's not quite so huge. Change-Id: I5748edf0e715961da57eff7e0ade6fad175ab24b Reviewed-on: https://code.wireshark.org/review/26110 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=03718fee4dfc3a711532a9ddf9bf25… commit 03718fee4dfc3a711532a9ddf9bf250255d2944c Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Feb 25 17:33:06 2018 +0100 zbee zcl se: fix duplicate entry Field 'Attribute' (zbee_zcl_se.met.attr_id) has a conflicting entry in its value_string: 1045 is at indices 183 (Current Year Max Energy Carrier Demand) and 184 (Current Year Min Energy Carrier Demand)) Change-Id: I6ceb6091d6b37d9467f21037280f9d1251a103ff Reviewed-on: https://code.wireshark.org/review/26098 Reviewed-by: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=331ffaf3238708fdc28a6fa903c411… commit 331ffaf3238708fdc28a6fa903c4116210c3ee62 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 25 17:50:01 2018 -0800 WSUG: Fixup an apostrophe. Change-Id: I36b5ca5f182697a4b6cbd69da2a708453cb8a876 Reviewed-on: https://code.wireshark.org/review/26109 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c1e5e6c92d7a2af922bbfd7e5b474b… commit c1e5e6c92d7a2af922bbfd7e5b474baf122cf9d5 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 25 17:50:01 2018 -0800 WSUG: Fixup some quotes and apostrophes. Switch from AsciiDoc's smart quotes markup to the quotes themselves, along with apostrophes. Change-Id: I78930d6902e2691b6a2cb35ed5bae6fef4bb7257 Reviewed-on: https://code.wireshark.org/review/26108 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=1585aa950ccfb3a564aa263de5f01c… commit 1585aa950ccfb3a564aa263de5f01c4ab01cc5f1 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 25 09:17:14 2018 -0800 Docbook: Update our CSS. Use the CSS generated from the "wireshark" theme at https://github.com/geraldcombs/asciidoctor-stylesheet-factory Make sure the release notes use an external CSS file instead of inlining. Change-Id: I13daa41f4a9e6f76b323bd9f483af98e20d6c1f2 Reviewed-on: https://code.wireshark.org/review/26106 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=8b810d2d4214371084124089f2dff3… commit 8b810d2d4214371084124089f2dff3b69a059701 Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Feb 25 18:52:03 2018 +0100 wisun: wisun remove unused ei_wisun_wsie_short_format Change-Id: I8dfee4f222236892585295e6b1d1e53bb2237238 Reviewed-on: https://code.wireshark.org/review/26103 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3fb9882a207d281ac9a28a718ef601… commit 3fb9882a207d281ac9a28a718ef6018990d7b510 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Feb 25 17:40:51 2018 +0100 mq: fix duplicate entry Field 'ParmID...' (mqpcf.parm.id) has a conflicting entry in its value_string: 1008 is at indices 385 (MQIACF_MODE) and 386 (MQIACF_QUIESCE)) Field 'ParmID...' (mqpcf.parm.id) has a conflicting entry in its value_string: 1532 is at indices 762 (MQIACH_CURRENT_SEQ_NUMBER) and 763 (MQIACH_CURRENT_SEQUENCE_NUMBER)) Field 'ParmID...' (mqpcf.parm.id) has a conflicting entry in its value_string: 1536 is at indices 767 (MQIACH_BYTES_RCVD) and 768 (MQIACH_BYTES_RECEIVED)) Field 'ParmID...' (mqpcf.parm.id) has a conflicting entry in its value_string: 1539 is at indices 771 (MQIACH_BUFFERS_RCVD) and 772 (MQIACH_BUFFERS_RECEIVED)) Change-Id: Ieca064b54c7e25e9a78f037c7b46382dfe159df0 Reviewed-on: https://code.wireshark.org/review/26099 Reviewed-by: Robert Grange <robionekenobi(a)bluewin.ch> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a29d697a25bca1e0ce6109f705f43d… commit a29d697a25bca1e0ce6109f705f43db05e4d6f97 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Feb 25 18:11:20 2018 +0100 kerberos: fix duplicate entry Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its value_string: 1 is at indices 1 (kRB5-PADATA-TGS-REQ) and 2 (kRB5-PADATA-AP-REQ)) Field 'padata-type' (kerberos.padata_type) has a conflicting entry in its value_string: 132 is at indices 40 (kRB5-PADATA-AS-CHECKSUM) and 41 (kRB5-PADATA-PK-AS-09-BINDING)) Change-Id: I1069dec9cb59f753f2a9a2c4fd901f836f689a87 Reviewed-on: https://code.wireshark.org/review/26101 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a35592eb20ae4371da99788e3c5a87… commit a35592eb20ae4371da99788e3c5a8796616390f3 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Feb 25 18:30:25 2018 +0100 proto(.c): remove extra bracket Change-Id: Iccf76c35be36e0e806d8878b93902d6984a815da Reviewed-on: https://code.wireshark.org/review/26102 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6580e3f19f66b1d8873944a434041c… commit 6580e3f19f66b1d8873944a434041c3f843538a6 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Feb 25 18:05:10 2018 +0100 isup fix duplicate entry Field 'Mandatory Parameter' (isup.parameter_type) has a conflicting entry in its value_string: 168 is at indices 133 (IEPS call information) and 134 (VED information)) Field 'Upgraded parameter' (isup.upgraded_parameter) has a conflicting entry in its value_string: 168 is at indices 133 (IEPS call information) and 134 (VED information)) Change-Id: I8bf3421ed21e50e4b607ac70faa568112e7c46ae Reviewed-on: https://code.wireshark.org/review/26100 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d7e1970cbeb1107b058adbd3bdafcb… commit d7e1970cbeb1107b058adbd3bdafcbea5013c89b Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 25 08:19:31 2018 +0000 [Automatic update for 2018-02-25] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I543fa77cb9f26353fe3ea64f5e236d540d971a90 Reviewed-on: https://code.wireshark.org/review/26091 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=20d7254cb6b30324b76355c76c1852… commit 20d7254cb6b30324b76355c76c1852e802edd647 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Thu Feb 22 22:36:06 2018 +0100 Bootp: Adding some DHCP options Used Ref: * https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameter… * RFC 6225: Dynamic Host Configuration Protocol Options for Coordinate-Based Location Configuration Information * RFC 6704: Forcerenew Nonce Authentication * RFC 6731: Improved Recursive DNS Server Selection for Multi-Interfaced Nodes * RFC 6926: DHCPv4 Bulk Leasequery * RFC 7291: DHCP Options for the Port Control Protocol (PCP) * RFC 7618: Dynamic Allocation of Shared IPv4 Addresses Change-Id: Ied53f88b2018f1d054a8ba22f1a1d6f7c075621a Reviewed-on: https://code.wireshark.org/review/26063 Reviewed-by: Craig Jackson <cejackson51(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba4ff84e94f5e1edcc520a06d0dbaf… commit ba4ff84e94f5e1edcc520a06d0dbafbede59b437 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Feb 24 18:19:03 2018 +0100 TDS: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Iac95d4d588670b75fbb9e99095e5c0a562460000 Reviewed-on: https://code.wireshark.org/review/26085 Reviewed-by: Craig Jackson <cejackson51(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b4368e14b0f082313de17e29f7cd62… commit b4368e14b0f082313de17e29f7cd62a251c0c9a9 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Feb 24 18:17:07 2018 +0100 802.11: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ie0c4a4703c1ae035dc1051569927b72f075823d7 Reviewed-on: https://code.wireshark.org/review/26084 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ec99b833d2569ecfcbec11bb0ea724… commit ec99b833d2569ecfcbec11bb0ea72444e2e10caf Author: Paul Zander <p.j.zander(a)lighting.com> Date: Sat Feb 24 16:21:22 2018 +0100 Add undefined ZigBee ZCL Basic cluster attribute. Change-Id: I3ed2750f13b9cd29654c693ff31796c56d57106a Reviewed-on: https://code.wireshark.org/review/26081 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b3bc6dcc02a7851000d58417f81d75… commit b3bc6dcc02a7851000d58417f81d75d918ab34f8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 24 16:16:08 2018 -0800 I don't see a need to treat ipmap.html specially. It's in the INSTALL_FILES list, and all of those end up being dropped into the run directory, so there's no need to copy it individually; all the data files, as enumerated in INSTALL_FILES, are expected to be in the same directory, whatever it is, and that's what happens to those files. Change-Id: I58df330c7d6886c87d91c0e0df73000c028fc312 Reviewed-on: https://code.wireshark.org/review/26088 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ee2bfbf7b4f9ddcc7446756608f7ac… commit ee2bfbf7b4f9ddcc7446756608f7aca89726bfbb Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 24 13:59:22 2018 -0800 The parser is at the bottom, so the shadow warning must be turned off there. The parser is what declares the local yylval, and that's generated below all the user-specified code, so we have to turn diagnostics off at the bottom. Change-Id: I33d5f53c1fd67014ae7fe2b851d45d0c5e80becd Reviewed-on: https://code.wireshark.org/review/26086 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=852e3378b6c0eb73ee453d77f7f4ac… commit 852e3378b6c0eb73ee453d77f7f4ac20469f10e7 Author: Robert Sauter <sauter(a)locoslab.com> Date: Mon Feb 19 14:33:11 2018 +0100 IEEE 802.15.4: Rename ieee802154_payload_* to ieee802154_decrypt_* - Rename to better reflect functionality - Add some comments Change-Id: Ia3bf5655323a3d6fab18fd68dd3d048bd97f8c44 Reviewed-on: https://code.wireshark.org/review/26053 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c316799e49faac41e8629ce32a46b3… commit c316799e49faac41e8629ce32a46b3b25b01206a Author: Craig Jackson <cejackson51(a)gmail.com> Date: Fri Feb 23 11:05:08 2018 -0500 TDS: Minor updates to TDS 5 Response token handling Fix a couple of cases where endianness was not handled properly when using FT_UINT_STRING. Use FT_UINT_STRING to streamline some of the decodes which were previously merged. Change-Id: I72196d2146fe1884f2d0af01bd1185a662923226 Reviewed-on: https://code.wireshark.org/review/26056 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c0b2d82fc4462370f7a280c14c61e5… commit c0b2d82fc4462370f7a280c14c61e57bc5a7f239 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 24 03:52:23 2018 -0800 Suppress some warnings caused by a Berkeley YACC bug/misfeature. Berkeley YACC generates a global declaration of yylval, or the appropriately prefixed version of yylval, in the .h file, *even though it's been told to generate a pure parser, meaning it doesn't have any global variables*. Bison doesn't do this. That causes a warning due to the local declaration in the parser shadowing the global declaration. So, if this is Berkeley YACC, and we have _Pragma, and have pragmas to suppress diagnostics, we use it to turn off -Wshadow warnings. Change-Id: Ia3fecd99fa18ca9b85f6b25f53ed36c60730fad9 Reviewed-on: https://code.wireshark.org/review/26080 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f07d295fcf89f5a9bb58fd09bb875d… commit f07d295fcf89f5a9bb58fd09bb875d56260faaab Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Feb 23 10:09:56 2018 +0100 TLS1.3: Add support of draft-24 Only add version (no frame change) Change-Id: I437f7f9e1962f5fff35d187b559ec3943b683fd0 Reviewed-on: https://code.wireshark.org/review/26044 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e73e3580f6050e98cf5affa8f23d94… commit e73e3580f6050e98cf5affa8f23d941845e77ecc Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 23 09:43:29 2018 -0800 Rename airpdcap to dot11decrypt. Our 802.11 decryption code isn't tied to any specific product. Change the file and API names to dot11decrypt. Change-Id: I14fd951be3ae9b656a4e1959067fc0bdcc681ee2 Reviewed-on: https://code.wireshark.org/review/26058 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3785f53089eb4197d93574ebe7ff8e… commit 3785f53089eb4197d93574ebe7ff8eba51bc7266 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Fri Feb 23 18:41:42 2018 +0100 User Guide: add additional use category Add "QA engineers use it to verify network applications", as suggested by Alexander Sashnov. Change-Id: Ia9c83fd2f2610db747043f861931470e3f4e4c53 Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/26057 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6c7a5b488902e4420f864afe6f1400… commit 6c7a5b488902e4420f864afe6f14009e942b3673 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 23 18:33:05 2018 -0800 Fix capitalization and white space. Change-Id: I3b93716421169b2c9ce51da6116223e62fa6a241 Reviewed-on: https://code.wireshark.org/review/26077 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6a2ec55d6e7f69161b003a0f2f19be… commit 6a2ec55d6e7f69161b003a0f2f19be01cafd35ca Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Fri Feb 23 03:49:36 2018 -0800 radiotap: Fix bug 14455. Use an int instead of a uint so that sign extension does not occur and fix the field labels and make them all use the correct units. They conform closer to the spec now. Bug 14455 Change-Id: Ic57207d10565690a6e2ed66693dcdf294d421b22 Reviewed-on: https://code.wireshark.org/review/26046 Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c3c053ba1c9e7c7a6f4b446e742ad5… commit c3c053ba1c9e7c7a6f4b446e742ad5ca3e04e097 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 23 14:16:46 2018 -0800 Get rid of the ipmap.html that got dropped into Contents/MacOS. Change-Id: Ieb94ca78a92fc5369fe3b396373c2f7a31d8894a Reviewed-on: https://code.wireshark.org/review/26072 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=53744af1821137df82ba415524e3ec… commit 53744af1821137df82ba415524e3ec9fa2f605e1 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 23 14:13:20 2018 -0800 The DOCSIS dissector isn't a plugin any more, either. Change-Id: Ibd4b775af335a34ec27efe7454a460cd47720954 Reviewed-on: https://code.wireshark.org/review/26071 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=656439db2612878b52422d209443c1… commit 656439db2612878b52422d209443c17ebbb70c47 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 23 14:05:11 2018 -0800 Clean up description of power and attenuation fields. Change-Id: I36433f37e4e33260b41a2b35ca49e844fe76baf3 Reviewed-on: https://code.wireshark.org/review/26068 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e3db7c581cd9facc01015d81e5c63a… commit e3db7c581cd9facc01015d81e5c63a24032556a7 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 23 11:00:37 2018 -0800 I don't think ipmap.html belongs in the same directory as the binaries. Change-Id: I1a15ec77786f6a141e78c62885343f8cc51c73bf Reviewed-on: https://code.wireshark.org/review/26059 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a8ed879d7e9cae014d768ae10c7f40… commit a8ed879d7e9cae014d768ae10c7f407c3831ef10 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Thu Feb 22 07:59:52 2018 +0100 Work around a duplicate dest mac that appears in *some* frames captured on a FEX Change-Id: I6604c764d4b354653280891c8bf50a73954370b3 Reviewed-on: https://code.wireshark.org/review/25994 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=24ba73ccf0bd850ea7d423f7f07f15… commit 24ba73ccf0bd850ea7d423f7f07f150b7e43c676 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Fri Feb 23 13:18:05 2018 +0100 [PFCP] fixed Timer IE * If stopped there is no time to show * Default shall be multiple of 1 min Change-Id: Ib42c19f536ee0af5d8f83cceb8f84ad3b3a2f36c Reviewed-on: https://code.wireshark.org/review/26047 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=38425dd78d5fc38921b1b7aec98339… commit 38425dd78d5fc38921b1b7aec98339c2bfdd97af Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Feb 23 10:01:11 2018 +0100 QUIC (TLS): Remove support of draft < 08 negotiated_version is encrypted_extensions now No longer supported by QUIC dissector ( >= draft-08) Bug:13881 Change-Id: Id1fca0b5b6ce59c854b50d7091cce1079213db68 Reviewed-on: https://code.wireshark.org/review/26043 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=794b1e75697363aa289cbbfb216297… commit 794b1e75697363aa289cbbfb21629775bf509f6d Author: Jiri Novak <j.novak(a)netsystem.cz> Date: Fri Feb 23 12:20:02 2018 +0100 RTSP: Dissector should create RTP conversation if only server port was negotiated RTSP dissector now creates RTP conversation for UDP stream if only server_port in RTP response is sent (which is legal option). Bug: 14451 Change-Id: Id0ff0047a5708f45795440ae965c1ab67841b613 Reviewed-on: https://code.wireshark.org/review/26045 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1248c658d115a4c4908824c9c392ec… commit 1248c658d115a4c4908824c9c392ecf6859fd6c3 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 22 12:26:14 2018 +0100 mate: change strcmp in g_strcmp0 that supports NULL (found by clang). Change-Id: I66e6183a4f356adfdfd9c55b7b39245a9913857e Reviewed-on: https://code.wireshark.org/review/25988 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9c11de60de8d3294b1933a710887dd… commit 9c11de60de8d3294b1933a710887dd9487fa2ad5 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 22 12:34:01 2018 +0100 wiretap: zero memory on allocation. Change-Id: I0801725e2f6b17a5a3d3985b5039fa362694c7c7 Reviewed-on: https://code.wireshark.org/review/25989 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4d3b39938d88c782bd146da59866df… commit 4d3b39938d88c782bd146da59866df89aaf9b80f Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Thu Feb 22 23:48:55 2018 +0100 [PFCP] fixed DL Buffering Duration * If stopped there is no time to show * Default shall be multiple of 1 min Change-Id: Id9c489688abc30f28a6fb4efbde263409ae92873 Reviewed-on: https://code.wireshark.org/review/26022 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=017167fb34220a17af361d50b2d239… commit 017167fb34220a17af361d50b2d239927acac7c1 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 21:21:19 2018 -0800 Just use tvb_memeql() to check the signature. That's one of the things it's intended to do - check the values of parts of the packet that might not actually be there. The comparison fails if either 1) it's all there and doesn't match or 2) it's not all there. Change-Id: I0f97ea5f75c2cada511e254ec096d294ea710f45 Reviewed-on: https://code.wireshark.org/review/26040 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=86f329aa940388d981b25c2b3c9663… commit 86f329aa940388d981b25c2b3c966313335c2ed9 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Thu Feb 22 12:06:53 2018 +0000 LTE MAC: check direction and lcid before looking up msg3 table Change-Id: I26238e96510e9ccb73ebc4b6c4e8e9e5bc724a91 Reviewed-on: https://code.wireshark.org/review/25991 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1ccfef8b3fca63cbdd7839ebf205bd… commit 1ccfef8b3fca63cbdd7839ebf205bd6d1f7193bb Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Thu Feb 22 22:43:24 2018 +0100 ans: remove unnecessary if (tree) checks Change-Id: I381fbb7d5654c4061ed35db94269f50d49fbeafe Reviewed-on: https://code.wireshark.org/review/26014 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=51cd1db521131239af212ac0424eb7… commit 51cd1db521131239af212ac0424eb7b2319cdd5f Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Thu Feb 22 23:19:50 2018 +0100 [PFCP] fixed Unsigned32 in Time Threshold Change-Id: Ie60038d76faee04585e2b1100afb13301b1d1769 Reviewed-on: https://code.wireshark.org/review/26017 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3a79b6f87c806b83932eae15bde6ae… commit 3a79b6f87c806b83932eae15bde6ae1dce983285 Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Thu Feb 22 23:12:15 2018 +0100 [PFCP] Improve Traffic class field Change-Id: I6e6197f476fce591972e90f9943d7156bfe06921 Reviewed-on: https://code.wireshark.org/review/26016 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e3fcac94b8f3cadc75dc53e08f4c7f… commit e3fcac94b8f3cadc75dc53e08f4c7f7757766a2f Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Thu Feb 22 22:56:40 2018 +0100 [PFCP] fix UL Gate bits in Gates Status Change-Id: Ief03ead2a85233d1b61905d5c39d8fbcf9ab1cb2 Reviewed-on: https://code.wireshark.org/review/26015 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=06bb9450ddd644707c2913c2cf4305… commit 06bb9450ddd644707c2913c2cf43053867bc5d7e Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Thu Feb 22 22:28:25 2018 +0100 [PFCP] Improve SDF filter - part2 Adding subtrees Change-Id: I5a9d49af0bc00f26d8d0576c84ae2d4b33b5736f Reviewed-on: https://code.wireshark.org/review/26013 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4031e19e124bef499fab82c9762edb… commit 4031e19e124bef499fab82c9762edbce5085101e Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Thu Feb 22 21:54:52 2018 +0100 [PFCP] Improve SDF filter Change-Id: Icd045464ab38a33104713e2b99344faed9bd5f5e Reviewed-on: https://code.wireshark.org/review/26012 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=eb2e9101243fed7f47bf7ade9eacbc… commit eb2e9101243fed7f47bf7ade9eacbca0b1ac4c7e Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 20:54:56 2018 -0800 Remove more cruft. There's no Wireshark.app/Contents/Resources/bin directory; remove the variable containing its path, and the part of an error message that refers to it. Change-Id: Id41cc00a2671925c50b2075dd3e9d0f84d5bd921 Reviewed-on: https://code.wireshark.org/review/26039 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dfe22ab861e7f2b618bbe65b0fca32… commit dfe22ab861e7f2b618bbe65b0fca32898433216d Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 20:44:04 2018 -0800 Get rid of the -sdkroot option; it doesn't affect anything. Change-Id: I9797eea30594f5e48b21f1c2daede18777e690b1 Reviewed-on: https://code.wireshark.org/review/26036 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=316b858d28092bb1c55ff50cfe68ae… commit 316b858d28092bb1c55ff50cfe68ae51f34425de Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 20:37:47 2018 -0800 Fix stripping of binaries. Instead of using the never-defined $binpath (undefined going back to at least Wireshark 1.0.0 - is it a leftover from the Inkscape version?), use $bundle_binary_list, to strip all the executables with strip -ur. (Not that we want to strip anything - we don't even want the debugging symbols stripped! - but for cleanliness.) Change-Id: I9c3520ffb418bf9dc206d3ccb55d347c208f3be2 Reviewed-on: https://code.wireshark.org/review/26033 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=434d1c975979bd39f42a16622db4c9… commit 434d1c975979bd39f42a16622db4c94f04ab66ce Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 20:22:19 2018 -0800 Remove a bunch of obsolete code. We no longer have the code to create a bundle, as we rely on CMake having done so, at least to the extent of populating the bundle with all the files we've generated. Get rid of the code that used to support it, and the command-line options that are no longer necessary now that we no longer build code bundles. Don't have explicit lists of CLI or extcap binaries; instead, just look for all plain files in Wireshark.app/Contents/MacOS that have read and execute permissions for owner/group/user. That way, we don't have to update the script if we add new binaries or new directories of binaries. Change-Id: I047296a7889bea71165eebde10f34bec6ea96cc5 Reviewed-on: https://code.wireshark.org/review/26032 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=529bb0491043cc716c9e8e72e78492… commit 529bb0491043cc716c9e8e72e78492bed6dbb076 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 17:09:09 2018 -0800 Don't use find to find files to check for dependencies. It may find files that aren't Mach-O binary files. Instead, rename cs_binary_list to bundle_binary_list, and use it when checking for dependencies as well as when code-signing binaries. Change-Id: I9d17a4ba137e494fbd38db1b62f5cc7e4b620fc9 Reviewed-on: https://code.wireshark.org/review/26028 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9dcded61a1f5634861d9abfcddc45a… commit 9dcded61a1f5634861d9abfcddc45ab972fe30a3 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 16:02:54 2018 -0800 Code-sign extcap binaries. Change-Id: Icfca94774b929767560a06f873fbf90c3d0bebef Reviewed-on: https://code.wireshark.org/review/26024 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=727c815ad2b22aeb183c40e8fa78c6… commit 727c815ad2b22aeb183c40e8fa78c640cff56f99 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 22 12:42:28 2018 -0800 IPMI: Disable bus command dissection. This dissector has had multiple, severe issues over the years. Disable bus command dissection by default. Add a warning about re-enabling it. Change-Id: I9f71fafe2961f349825e6eda1f351025e00be182 Reviewed-on: https://code.wireshark.org/review/26008 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f14f76d12a3107f0a89884f0846409… commit f14f76d12a3107f0a89884f084640925ba033b28 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 22 22:01:20 2018 +0100 dmp: Allow multiple SecurityCategories again A Security Classification in DMP may have multiple Security Categories so don't restrict this to only one. Add a arbitrary limit of 255 to avoid a long dissector loop in malformed packets. This fixes a bug introduced in g85bbda51. Bug: 14408 Change-Id: I48e7a61a097c58dfcf21e9c9ed3147cf1573dae6 Reviewed-on: https://code.wireshark.org/review/26011 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=380381ce72e00db3e845eb6507c55b… commit 380381ce72e00db3e845eb6507c55b61739d783a Author: Valentin Vidic <Valentin.Vidic(a)CARNet.hr> Date: Thu Feb 22 10:11:54 2018 +0100 TWAMP: Reassemble only the Server-Greeting message Recursion fix forces all the messages to reassemble into 64 byte chunks breaking the dissector for later (smaller) messages. Change-Id: I4ab8ab4259aac5d5fc5a19ce10c6cab2db5ae3e0 Reviewed-on: https://code.wireshark.org/review/25985 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4c8c59ca7d1fd7be949e8dc32697ba… commit 4c8c59ca7d1fd7be949e8dc32697ba67b3541e88 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 22 14:05:46 2018 +0100 csn1: fix indentation. Change-Id: I7832cea4d1073df854852aa598c04bcab68bf94c Reviewed-on: https://code.wireshark.org/review/25992 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=eb2b8dd98ae8c298c484e61ddc4ad1… commit eb2b8dd98ae8c298c484e61ddc4ad1fcf632ad5b Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 11:49:25 2018 -0800 Check for dependencies in all subdirectories of $pkglib and $pkgexec. Just use "find" to find plain files under $pkglib and $pkgexec; this avoids trying to run otool on directories, which can cause it to stop looking in $pkgexec/* past the extcap directory, and does try to run it on the Qt frameworks in subdirectories under $pkglib. Add a comment giving more details about the big command to find dependencies. Change-Id: Ife3c3a8493ca0b6ea28f1bb108f63714366abeed Reviewed-on: https://code.wireshark.org/review/26003 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2e139a15fab0206403e66abaf43545… commit 2e139a15fab0206403e66abaf435456007cb5e1f Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 22 11:36:51 2018 -0800 SIGCOMP: Disable UDVM dissection and decompression. This dissector has had multiple, severe issues over the years. Set the display.udvm.code and decomp.msg preferences to FALSE by default. Add warnings about re-enabling them. Change-Id: Ib23ab1b2cd23b35f2377416c7d197730dedbd9e2 Reviewed-on: https://code.wireshark.org/review/26002 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=05cd2b6c1cc52aca95a822096f77ae… commit 05cd2b6c1cc52aca95a822096f77aec203f34622 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 10:53:14 2018 -0800 Update comments to reflect current reality. Change-Id: Ie0fcc197ed8841b5f7098a5129b774507646f2de Reviewed-on: https://code.wireshark.org/review/26001 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ba58d62cd13b2dfe39d62022cc0666… commit ba58d62cd13b2dfe39d62022cc066687019685de Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 22 10:25:00 2018 -0800 Fix endianness. Make the 1-byte fields little-endian (it doesn't matter, but it's more consistent that way), and make the transmission attenuation fields little-endian (where it *does* matter - making them big-endian was probably a copy-and-pasteo). Note that the OUI field being "big-endian" is correct, however. (Radiotap specifies it as an array of 3 octets containing an OUI, and we display OUIs as big-endian 24-bit quantities.) Change-Id: I42d19f7ec0d066ce89dbef78d11dff900c0a6b60 Reviewed-on: https://code.wireshark.org/review/25998 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=21124903d5c6ffbddfe54db9b9490c… commit 21124903d5c6ffbddfe54db9b9490c095428909e Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 22 17:40:14 2018 +0100 nettrace: remove wrong frees (found by clang). Change-Id: I5d8c81a4ebb89dfc6b6e9103a407cf24f1aa34d0 Reviewed-on: https://code.wireshark.org/review/25995 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=032cb4b79fdb207e18bf121140d7c7… commit 032cb4b79fdb207e18bf121140d7c7c66f9b5cf2 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Thu Feb 22 12:02:10 2018 +0000 Catapult DCT2000: Update sscanf patterns, and avoid calling if possible Change-Id: Iafb7d62ab4a0431a00eaa284d421ea38b568533f Reviewed-on: https://code.wireshark.org/review/25990 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=01e8f509d7425dbc5fb4f467087a70… commit 01e8f509d7425dbc5fb4f467087a70b3e8f7f4ea Author: Valentin Vidic <Valentin.Vidic(a)CARNet.hr> Date: Thu Feb 22 11:50:44 2018 +0100 TWAMP: Fix packets changing type in wireshark GUI Since the type detection runs with every click, depending on the order packets are selected their type can change. With this change the type detection is run only once during the first pass through the packet list and the results are saved for later use. Change-Id: Ie0b16c4b6e3372fcf72a246987fe7f23bc33fa14 Reviewed-on: https://code.wireshark.org/review/25987 Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e57ecf4acd280e972449558e58d573… commit e57ecf4acd280e972449558e58d57307338bca86 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Feb 22 11:27:41 2018 +0100 IEEE 802.11: fix build with gcc7 Remove an unused hf entry. Remove an unused true_false value string. Fix an indentation so that the compiler does not think backets are missing. Change-Id: Id6c0597b68674fd17f750379f941698d72b0cbba Reviewed-on: https://code.wireshark.org/review/25986 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e510ceed0563a5b37481339beb1a8c… commit e510ceed0563a5b37481339beb1a8cb61809d164 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Thu Feb 22 07:46:37 2018 +0100 Reenable ieee 802.3 encapsulation and small cleanups/updates Change-Id: I6674140b79bb21121edbd3caa371b7d0f179811a Reviewed-on: https://code.wireshark.org/review/25982 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=818b58da97d55af5fe0a0d7de72518… commit 818b58da97d55af5fe0a0d7de72518f865730f20 Author: Craig Jackson <cejackson51(a)gmail.com> Date: Fri Feb 16 18:53:48 2018 -0500 TDS: Improve dissection of TDS5 responses. Add dissection of the TDS5 packets for transmitting column information (ROWFMT, ROWFMT2) and extended error messages. Change-Id: Ib85c91b7ea007ce8bdc602bf6b607ab7a5cf1be5 Reviewed-on: https://code.wireshark.org/review/25855 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1f95d39b623a3127e493446f773a22… commit 1f95d39b623a3127e493446f773a22289637e6f1 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Feb 22 07:56:37 2018 +0100 rawshark(.c): fix parameter 'phdr' not found in the function declaration [-Wdocumentation] Change-Id: If5c8fbb77acdf75ba273a6b77d7f338381c229f6 Reviewed-on: https://code.wireshark.org/review/25983 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba72f731c3e8cbeb698ec17beecf59… commit ba72f731c3e8cbeb698ec17beecf599c24dea1cc Author: Graham Shanks <graham.shanks(a)blueyonder.co.uk> Date: Wed Feb 21 22:48:03 2018 +0000 DIS: move modulation parameters to correct place in tree Move the modulation parameters record in the Transmitter PDU to its correct place in the tree, i.e. under the Transmitter PDU element instead of under the Encryption Key field. Change-Id: I77b379823d5a43bd943ffabac2d9fa050b19abcd Reviewed-on: https://code.wireshark.org/review/25972 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c95424a8a41af26fbae90e8ebbbc65… commit c95424a8a41af26fbae90e8ebbbc652c4a7ba071 Author: Harald Welte <laforge(a)gnumonks.org> Date: Wed Feb 21 23:26:32 2018 +0100 packet-rsl: Add RLL UNITDATA INDICATION I'm not quite sure why this message is missing from the wireshark dissector. It's not particularly new, at least I don't recall ever having seen a spec document in the past decade or so that was missing this message type. Perhaps a simple oversight. Change-Id: Idb6c53ff6dc6d65f6ca7ce30a89499d8383d01f6 Reviewed-on: https://code.wireshark.org/review/25974 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0f4495079639a9a6baf97d2eada68b… commit 0f4495079639a9a6baf97d2eada68b9ae5f59349 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Feb 20 08:00:24 2018 -0800 radiotap: Fixes because the meaning of some fields changed. Two sets of reserved bits now have a meaning: 1. The pri/sec 80 MHz fields in D2 2. The RU allocation offset fields, also in D2. Change-Id: I9acfce4e3dc61579a686fd53c570c9aceebad10b Reviewed-on: https://code.wireshark.org/review/25927 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b443d4646e57012661c40011e287cb… commit b443d4646e57012661c40011e287cb9d67245ca7 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 21 15:27:10 2018 -0800 Qt+Windows: Adjust our DBAR check logic. Don't bother fetching a file's version if its name doesn't match any of the DBAR DLL list entries. Otherwise we try to open a bunch of DLLs we don't care about. Change-Id: Icab11450839195c1259bb307ae88988f52917487 Reviewed-on: https://code.wireshark.org/review/25973 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b293c97ad3f128eb25e3af8d345493… commit b293c97ad3f128eb25e3af8d34549368544df708 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Feb 20 08:36:59 2018 -0800 ieee80211: Start to dissect 80211ax trigger frames and other fields. Here we have dissected much of the Common Info and the user info but there are still things to fix. This set also refactors the block ack handling code so I can use it from the HE Trigger dissection code. We have enough to use in Trigger requests I think but there are still new block ack requests to be dealt with. Also refactored the VHT NDP Announcements so we can handle HE NDP annoucements and added some custom handling of Target RSSI fields. Many thanks to George Baltatanu who has found many issues along the way with his testing. Change-Id: Ia41e1153d7331d24b8ae0b6871935f4fa806d188 Reviewed-on: https://code.wireshark.org/review/25685 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c76b37845333a62b66a570e59edef9… commit c76b37845333a62b66a570e59edef976cfae7cf9 Author: Darien Spencer <cusneud(a)mail.com> Date: Wed Feb 21 19:34:55 2018 +0200 FP: Fix U-RNTI issue in E-DCH When configured a E-DCH, the first packet in the channel used the CRNCC instead of U-RNTI (if found) Change-Id: I31b50af8a44c6f637ac2eefd4caf319bec44c3c6 Reviewed-on: https://code.wireshark.org/review/25929 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=205424287b0ff732ad555ddc2026f1… commit 205424287b0ff732ad555ddc2026f1422633cb12 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 21 10:56:05 2018 -0800 Qt: Improve our capture filter completions. Use libpcap's pcap-filter.manmisc to create our capture filter completion list instead of scanner.l. Bug: 14430 Change-Id: I11f6eb5679dc93561dce62f28149e103ac9b4a2b Reviewed-on: https://code.wireshark.org/review/25971 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5d45b69b590cabc5127282d1ade3bc… commit 5d45b69b590cabc5127282d1ade3bca1598e5f5c Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 21 09:41:24 2018 -0800 WCCP: Make sure our offset increases. Make sure we advance our offset in various places. Clarify a macro name. Bug: 14412 Change-Id: I9b2af4bb57d039febe16f0c6d74ebb12fa34693c Reviewed-on: https://code.wireshark.org/review/25965 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=85bbda514af5bac1042dd2fd2f8690… commit 85bbda514af5bac1042dd2fd2f869021e2afcaa1 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 21 09:19:13 2018 -0800 DMP: Recurse only once. Make sure we call dissect_dmp_security_category from itself only once. Bug: 14408 Change-Id: Ia03fb32ca414e78ede572d3093b84f9d53ceb0b9 Reviewed-on: https://code.wireshark.org/review/25964 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5aaf741c812bc6f21b6014c7b54908… commit 5aaf741c812bc6f21b6014c7b549089bfd20920f Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 21 18:49:41 2018 -0800 And systemd weighs in on how to find out the distribution you're on.... Change-Id: I84e957617b81b6cfad815dc84439e166c0f936b6 Reviewed-on: https://code.wireshark.org/review/25980 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0161a5ba52db4e499e471d6482dc92… commit 0161a5ba52db4e499e471d6482dc923b495b9989 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 21 16:00:53 2018 -0800 Don't strip debugging symbols from the binaries in the macOS image. Unstripped binaries should allow better stack traces in the CrashReporter files. Change-Id: Idb2f11cd664dc62331f3394dee09abcd4e88f897 Reviewed-on: https://code.wireshark.org/review/25977 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=95e33c7097fb5c858e1fc34ee9e92c… commit 95e33c7097fb5c858e1fc34ee9e92c15b788c0db Author: Dario Lombardo <lomato(a)gmail.com> Date: Sun Feb 18 18:42:31 2018 +0100 dof: use g_malloc0 to prevent uninitialized memory (found by clang). Change-Id: Iac8b077e7223668b58158a29628748aae85ed73e Reviewed-on: https://code.wireshark.org/review/25885 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=7802bbb09163e3a91cf68e2ba9ef03… commit 7802bbb09163e3a91cf68e2ba9ef03dc18c99372 Author: Valentin Vidic <Valentin.Vidic(a)CARNet.hr> Date: Tue Feb 20 23:33:00 2018 +0100 TWAMP: Avoid triggering an infinite recursion Restore the original dissect_twamp_control and introduce a small dissect_twamp_server_greeting to reassemble the TCP packets before calling dissect_twamp_control. Change-Id: I9927bc24bc5e5640bd021a12ba7fd98235fefbfb Link: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14448 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6481 Reviewed-on: https://code.wireshark.org/review/25951 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4c9cb5220dab050f9160e990375a08… commit 4c9cb5220dab050f9160e990375a0816eee7d3ac Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Wed Feb 21 14:17:30 2018 +0000 ftp: calculate bitrate of ft-data session Change-Id: I54beaa799db07c2cd1a1814c0851a45fd23386cc Reviewed-on: https://code.wireshark.org/review/25963 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=70554429a6aaeab8302766ed878b98… commit 70554429a6aaeab8302766ed878b981404d16e7e Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 21 10:08:49 2018 -0800 Fix detection of file type. Some versions of otool print the file name as the first line when you run it with -hv, so that the line containing the file type is the fourth line; others don't print it, so that it's the third line. Instead, look for the line that has MH_MAGIC. Change-Id: Ib14f6b24f14069532263332e53a1e9895663641a Reviewed-on: https://code.wireshark.org/review/25968 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9788199a61f201cf0347400e05cc10… commit 9788199a61f201cf0347400e05cc10a62bb7b3e6 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Wed Feb 21 13:43:08 2018 +0100 [GSM A RR] RXLEV-SUB-SERVING-CELL displayed with wrong bitmask. https://ask.wireshark.org/question/1757/gsm-measurement-report-decoding-pro… Change-Id: I67f0aaffb1c7b7f4307d5017a2f3858528e3ace6 Reviewed-on: https://code.wireshark.org/review/25962 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=566d20f444f1a526910e4c78579e87… commit 566d20f444f1a526910e4c78579e8703c63c19aa Author: Dario Lombardo <lomato(a)gmail.com> Date: Sun Feb 18 18:36:49 2018 +0100 dfilter: use g_malloc0 to prevent uninitialized memory to be used. Found by clang. Change-Id: I89497bd0f32c79f82218c6d254a214364c930eb3 Reviewed-on: https://code.wireshark.org/review/25884 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0a3c713d8c87ef64761027012e33f5… commit 0a3c713d8c87ef64761027012e33f54507521fc4 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Feb 21 11:31:38 2018 +0100 QUIC: Use new labels for decryption (draft-09). Support for draft-08 is still maintained. Bug: 13881 Change-Id: I6cb4b716772e43223b7da4400ef32c56b0191864 Reviewed-on: https://code.wireshark.org/review/25689 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=acb6781012409b391592096127460f… commit acb6781012409b391592096127460fcfd9b648d7 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Wed Feb 21 11:22:18 2018 +0100 TLS: allow QUIC dissector to pass HKDF label for ciphers To support decryption of future drafts of QUIC, the HKDF label must be configurable by the QUIC dissector. Currently it can only select between "tls13 " and "TLS 1.3, " which is not sufficient (it needs "QUIC "). Change "tls13_hkdf_expand_label" and "tls13_cipher_create" to accept the label prefix directly instead of just a TLS 1.3 draft version number. Change-Id: I466a6e1a8f4b051f5775e7d8d6658641a1ae7fb1 Reviewed-on: https://code.wireshark.org/review/25961 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=62d34fcc2cecf560b0b8f3c897cb3f… commit 62d34fcc2cecf560b0b8f3c897cb3f0f8df31b99 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 21 00:27:43 2018 -0800 Squelch some cating-away-constness warnings. Change-Id: I1ebe9b42957e0db5cc04f44e31f291cb40ba14e1 Reviewed-on: https://code.wireshark.org/review/25960 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b96eba436b8e4b2028e7764c1757fd… commit b96eba436b8e4b2028e7764c1757fd34ab1c4d38 Author: Jakub Pawlowski <jpawlowski(a)google.com> Date: Tue Feb 20 10:06:16 2018 -0800 Bluetooth: HCI_EVT: implement LE Extended Advertising Report Change-Id: I2d316e671a8342b040899e4e3674cca055e4d1a6 Reviewed-on: https://code.wireshark.org/review/25930 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=9efce5c916535211643a3faeef2d0a… commit 9efce5c916535211643a3faeef2d0a05dcb6aa17 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 21 00:19:51 2018 -0800 Don't unnecessarily cast away constness. Change-Id: Ia7e6f55d4398ec2d1d35f3dc4ef5ff0c51b9746d Reviewed-on: https://code.wireshark.org/review/25959 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a888bf7e68ac0ff178b8fc77fbcac6… commit a888bf7e68ac0ff178b8fc77fbcac64415c0cf9d Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Feb 21 09:15:59 2018 +0100 wisun: Small comment fix Change-Id: I6d30cbd602aba4677e9205759f2f416ecaf4c157 Reviewed-on: https://code.wireshark.org/review/25958 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=748ea162c3f870271c2f180fdc1b61… commit 748ea162c3f870271c2f180fdc1b6123ae8dfe57 Author: Ed Beroset <beroset(a)ieee.org> Date: Tue Feb 20 21:51:26 2018 -0500 Updated Wi-SUN dissector to latest specification. Change-Id: Iaa3dc73fecf0a5e323fe6306b049514bfd09399d Reviewed-on: https://code.wireshark.org/review/25956 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=d0b07245ec7878fceba1cb6b272d3e… commit d0b07245ec7878fceba1cb6b272d3efb333b7dd6 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 20 12:23:32 2018 +0100 tools: add git to optional pkgs in debian-setup script. Change-Id: I2931ee2bee9a719596318615d2cba7973e30e082 Reviewed-on: https://code.wireshark.org/review/25921 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=238550b9c5aad47448cc5ac537108e… commit 238550b9c5aad47448cc5ac537108ee23125a252 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 21:34:04 2018 -0800 Make some arguments const, and remove casting-away of constness. Change-Id: Iaa43b4b355179a265975f67952feac819e79f7a6 Reviewed-on: https://code.wireshark.org/review/25957 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1c5e6a1b3470b23554ddbd3718bc81… commit 1c5e6a1b3470b23554ddbd3718bc815f19bf8684 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 18:32:02 2018 -0800 Eliminate another casting-away-constness warning. Don't fill in a structure if you're not going to use it. Fixing that means you don't have to free something you've allocated for the structure. Change-Id: I6b151b2df43a6444c25583a100f142a51d922c2f Reviewed-on: https://code.wireshark.org/review/25955 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dc1ab9f32b9bdf3135a377ebec0a0c… commit dc1ab9f32b9bdf3135a377ebec0a0c944d577f47 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 18:16:57 2018 -0800 Remove a casting-away-constness warning. Keep the pointer to the allocated data in a non-const pointer, and free it using *that* pointer. Change-Id: I7d29b6768be58ed0181cd64c68ac0b7d03ec5611 Reviewed-on: https://code.wireshark.org/review/25954 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=65aa59d28ab5f41a06dbfcf25b191f… commit 65aa59d28ab5f41a06dbfcf25b191f2b3547b78e Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 20 12:32:22 2018 -0800 RPCoRDMA: Set an upper bound for our chunk size. Make sure our write chunk size doesn't exceed our tvbuff. Adjust a few length checks. Bug: 14449 Change-Id: If9dd8a6094830c5b47adfff0acb3ff726168e801 Reviewed-on: https://code.wireshark.org/review/25943 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2b74b5c4c8836f413c675d8f7f80c8… commit 2b74b5c4c8836f413c675d8f7f80c8356b6b1722 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 20 11:29:49 2018 -0800 BER: Add a length check. Add a common large length reporting function. Add a length check to dissect_ber_set. Bug: 14444. Change-Id: I6093b5342439cd0ee08f060b8d74b3ae54b3b8f8 Reviewed-on: https://code.wireshark.org/review/25931 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9c5803ff7618002b8d18cfcd65fa44… commit 9c5803ff7618002b8d18cfcd65fa44ec20fb1c76 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 20 11:48:11 2018 -0800 Airpdcap: Add length checks. Make sure we don't underflow length values. Bug: 14442 Change-Id: I71baac428ba3b07fe4cd5a7f60fbe2a957ac460e Reviewed-on: https://code.wireshark.org/review/25937 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c9a081c3dcf1d66d1117a67b45e7ad… commit c9a081c3dcf1d66d1117a67b45e7ad7fcf9e065f Author: Joerg Mayer <jmayer(a)loplof.de> Date: Wed Feb 21 00:21:20 2018 +0100 Add a CheckPoint specific mac address Change-Id: Id9a30ed4d301c4c2d81fdf626d1134e9585c2f79 Reviewed-on: https://code.wireshark.org/review/25953 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=bc43d687f0751cb95ecd9446589e7b… commit bc43d687f0751cb95ecd9446589e7b37506ff1c6 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Tue Feb 20 23:16:58 2018 +0100 fuzzshark: don't fuzz udplite. Don't fuzz IP->udplite protocol. It's using most of UDP code, but cause udplite calls also udp dissectors it duplicates work of UDP fuzzer. This should also decrease IP corpus size, cause in IP corpus ~7.6% (9 165 out of 119 780) is udplite ip.proto Change-Id: I1d3bde6dd34f76696a34b1c728ce36f3c802e6c9 Link: https://github.com/google/oss-fuzz/issues/1087 Reviewed-on: https://code.wireshark.org/review/25950 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=e788fac9fa13b2e5977c27ada03bbe… commit e788fac9fa13b2e5977c27ada03bbe9ff934d9f6 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 14:41:34 2018 -0800 Squelch some casting-away-constness warnings. If we're constructing the string, assign the pointer to it to a non-const pointer variable, set the stat_tap_ui cli_string member to that variable, and then use the variable to free it when we're done. Don't cast away constness if we don't have to. Change-Id: If3b24dbf1c910e1e6eceb76f2f6a7ae3898315f9 Reviewed-on: https://code.wireshark.org/review/25952 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=cb31f5620458420eba8857247caf33… commit cb31f5620458420eba8857247caf33925a42465f Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 14:08:16 2018 -0800 Don't cast away constness. Change-Id: I04cb49a5fe52bc6de66575228b81db1288bd1959 Reviewed-on: https://code.wireshark.org/review/25948 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=bc4e15b57901c74d844545ab401231… commit bc4e15b57901c74d844545ab40123188625fd23d Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 12:12:43 2018 -0800 Don't cast away constness. Change-Id: Ib69274a8bc6092129a7754c8d21aa2e6f160e242 Reviewed-on: https://code.wireshark.org/review/25942 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=95cb454355be5b9de7582d2e0e2af3… commit 95cb454355be5b9de7582d2e0e2af30bf816dd60 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 12:06:00 2018 -0800 Constify an argument, remove no-longer-necessary removal of constness. Change-Id: Ic0a70b28bfdb57c4c2ddf07cf071a85042672c9e Reviewed-on: https://code.wireshark.org/review/25941 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b00e7fc088df2865fa918b4c73705d… commit b00e7fc088df2865fa918b4c73705d0e725fc7f2 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 12:00:30 2018 -0800 Constify some method arguments, and don't cast away constness. Change-Id: I266a724ff672026b3fdf07ac2eb2260f37c04247 Reviewed-on: https://code.wireshark.org/review/25940 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ba7657cb19f3a221c842bbf12b1efc… commit ba7657cb19f3a221c842bbf12b1efc2ac12c9dc0 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 11:51:40 2018 -0800 Cast away constness at the point where it can't be avoided. The only reason why we have to cast it away is that C doesn't have a good framework for creating collections of objects of arbitrary type (where type includes constness) and we're using a datatype (GHashTable) implemented and declared in C here. Do it in the g_hash_table_insert() call. Change-Id: Ibd7706255519a97b77e4e4a52fada43e050f2bf0 Reviewed-on: https://code.wireshark.org/review/25938 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=442e06d9c67434fa60df82abefc400… commit 442e06d9c67434fa60df82abefc4005a36fb102e Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 11:47:16 2018 -0800 Don't gratuitously cast away constness. Change-Id: I235aacba37e6383d3b369ec0c9b39c9f37db5ff5 Reviewed-on: https://code.wireshark.org/review/25936 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=209f7700b3c281c3819d16f9f1ef7b… commit 209f7700b3c281c3819d16f9f1ef7b4990f7304b Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 11:44:08 2018 -0800 Don't cast away constness. Change-Id: I2b9534e8240e9b0daf4250575f0c17551ee920fd Reviewed-on: https://code.wireshark.org/review/25935 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4e857ad20cccd7d4c5d9076e19bd69… commit 4e857ad20cccd7d4c5d9076e19bd690f06033ac0 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 20 11:37:58 2018 -0800 Type casts without const lose constness. Don't do const foo *x = (foo *)a_const_pointer; do const foo *x = (const foo *)a_const_pointer; Change-Id: Iee04f71e19fcbe8b8e9a099bad52c8f15577e3e8 Reviewed-on: https://code.wireshark.org/review/25934 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3366317943ad7d135bbd8b5db13fd8… commit 3366317943ad7d135bbd8b5db13fd80edfd811a1 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 20 16:11:28 2018 +0100 ieee80211: Remove obsolete assignments Change-Id: If1de0970e4baf49419238553ba93ab13ad5b94cc Reviewed-on: https://code.wireshark.org/review/25926 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=d209fe6e18b44d98e3760d542acf61… commit d209fe6e18b44d98e3760d542acf61b2d82f056f Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 20 15:07:08 2018 +0100 pcapng: Free option_content on error Change-Id: If36b92def61112f8ebe8cfda0edfb63a15c46af0 Reviewed-on: https://code.wireshark.org/review/25925 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=fc9ee03ada78922be31977126263e0… commit fc9ee03ada78922be31977126263e047077f98e8 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 20 13:34:36 2018 +0100 gitlab-ci: speed up the builds a little bit. Change-Id: I29756429d106b56e5c0b9b61d92f4c6ca8629b36 Reviewed-on: https://code.wireshark.org/review/25923 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=224215cb42e24dc23a26e491ca8fe1… commit 224215cb42e24dc23a26e491ca8fe11d8d64687e Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 20 10:05:07 2018 +0100 Qt: Right justify custom columns with multiple fields Default right justify custom columns with multiple fields when all fields meet the right-justify criteria. Include double, float and relative time in the right-justify criteria. Change-Id: I438eab03e3575ca551cab1a547e4f8f00e4792b2 Reviewed-on: https://code.wireshark.org/review/25919 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1044d56e3dd2b029a13964badc28da… commit 1044d56e3dd2b029a13964badc28da7d16d19b00 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 20 10:05:48 2018 +0100 Qt: Improve sorting of custom columns with multiple fields Use the already parsed col_custom_fields_ids to loop all fields in custom columns. Change-Id: I937e10e087feadc788591f2e3d49568611fda69b Reviewed-on: https://code.wireshark.org/review/25918 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f7c8f0c8a5bfb04052b7084b00c5d8… commit f7c8f0c8a5bfb04052b7084b00c5d85b756f14db Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 19 15:27:21 2018 +0100 snmp: add missing initializers in deep copies. Change-Id: I0a9ef25fc79c47b329a3aed6e0de456ab905c971 Reviewed-on: https://code.wireshark.org/review/25901 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fa1635f5b077caca91021389c6ef02… commit fa1635f5b077caca91021389c6ef029528b8bab5 Author: Neil Ostroff <neil(a)mangosoup.com> Date: Mon Feb 19 12:26:48 2018 -0800 ieee80211: fix preamble duration calculation Preamble duration calculation duplicated the number of HT-LTF symbols resulting in an incorrect preamble calculation. This fix removes the duplicated code in file: epan/dissectors/packet-ieee80211-radio.c. Bug: 14439 Change-Id: I550066a41c24948e16da6a43cf403cf206b7f32d Reviewed-on: https://code.wireshark.org/review/25903 Reviewed-by: Simon Barber <simon.barber(a)meraki.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=647e5b449a9af1b553698f2f62e70a… commit 647e5b449a9af1b553698f2f62e70afd05850bf9 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 22:29:03 2018 -0800 Use units for the server recv->send duration. We *do* support units for FT_FLOAT and FT_DOUBLE, so use them. Change-Id: I94dbce89c785109b2c6ef89243f5611963e63dc8 Reviewed-on: https://code.wireshark.org/review/25917 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0a8152c260b7939633e91202ae6f5c… commit 0a8152c260b7939633e91202ae6f5c8075405f97 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 19 17:13:08 2018 -0800 Use ws.css in the release notes. Use the standard Wireshark style sheet for the release notes. Add a note about updating them via themes.asciidoctor.org. Change-Id: Ic6b66308cf1e1bea7b34a09963f92881d01eda8c Reviewed-on: https://code.wireshark.org/review/25911 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a82621eecb45b29288006437416815… commit a82621eecb45b2928800643741681556d6b1ea03 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 22:22:03 2018 -0800 FT_FLOAT and FT_DOUBLE support BASE_UNIT_STRING, too. Handle them in free_deregistered_field() and proto_registrar_dump_values(). Change-Id: I38c7b440adc46e32dde8bd629e58535baac9dd6d Reviewed-on: https://code.wireshark.org/review/25916 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=91409213ad111fb1607636dcb0b69d… commit 91409213ad111fb1607636dcb0b69dac9fb2d0c5 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 19 13:15:57 2018 -0800 DOCSIS: Remove concatenated PDU dissection. The current concatenation PDU support has had serious, repeated problems over the years: fb1ef7b8da f6d48e45c8 3e1828e351 26a6881014 625bab309d Remove it and add a comment recommending iteration. Bug: 14446 Change-Id: I947ff8e40e18c4628c9df9233b72dd7776e8233d Reviewed-on: https://code.wireshark.org/review/25905 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8a173c9812dd2396258012ddbd13c3… commit 8a173c9812dd2396258012ddbd13c37ea9c61a18 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 21:58:34 2018 -0800 Clean up the way we handle the server recv->send duration. There's no guarantee that it'll be integral, and the spec doesn't seem to imply that it's necessarily integral, so don't convert it to an integer. Given that it's a floating-point number, we might as well represent it as an FT_DOUBLE. (XXX - we should support units for FT_FLOAT and FT_DOUBLE.) Change-Id: Ica43510ac147231f5530359cc78bb467f8d3be24 Reviewed-on: https://code.wireshark.org/review/25915 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a8ff1335f99e91569ad8eaf497bc56… commit a8ff1335f99e91569ad8eaf497bc565f980dd8e4 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 21:35:13 2018 -0800 Extract bits by shifting, not using exponentiation. That makes it much clearer what's being done here; it matches what the 802.11ac spec actually says (we have an array of bits and an array of 2-bit items). Clean up indentation while we're at it. Change-Id: I8a4640662c54d6a2621990df778fd2d2c2695b78 Reviewed-on: https://code.wireshark.org/review/25914 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dc6b9dfcd635a1ca97a218bcdaf16a… commit dc6b9dfcd635a1ca97a218bcdaf16a2ee5f7b693 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 21:27:03 2018 -0800 Define macros to calculate (2^N)^M, and use them in more places. Change-Id: I4df1b35d8d2233c301f0ba9e119d012aebe9cd17 Reviewed-on: https://code.wireshark.org/review/25913 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e4787a9190c82dadae7e57c0847e25… commit e4787a9190c82dadae7e57c0847e2529bb2a9bbf Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 18:43:00 2018 -0800 Don't use floating point to calculate 4^N, for integer N. You don't need floating-point, you can just calculate 1<<2N. Change-Id: Iec9ebf02bba3e8bcce344be7f0366f7f258da403 Reviewed-on: https://code.wireshark.org/review/25912 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5c0cf42243e02ca5a6a4efb1005738… commit 5c0cf42243e02ca5a6a4efb1005738beb1879601 Author: Robert Sauter <sauter(a)locoslab.com> Date: Mon Feb 19 14:53:11 2018 +0100 packet-thread: fix cast-align warning Change-Id: I38381800c8cb227146e9a18285d2b73aec7a97d5 Reviewed-on: https://code.wireshark.org/review/25898 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a806389e50abdbbb5dbdd2071c04ad… commit a806389e50abdbbb5dbdd2071c04ad73beaaadf9 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 19 14:48:24 2018 -0800 RELOAD: Fix a length check. Make sure a length value isn't too large. Bug: 14445 Change-Id: Ie630d59aea744554da22a2b904aca06624c73f7a Reviewed-on: https://code.wireshark.org/review/25908 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3576ca2cd8325175f84698b5b15830… commit 3576ca2cd8325175f84698b5b158309481d55c04 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 19 14:00:44 2018 -0800 Remove eproto2sgml. IIRC this was used to generate a list of display filters for the User's Guide. We stopped doing that a long time ago. Change-Id: Ib18f3982169ebda133f05e5fcad4083f75051286 Reviewed-on: https://code.wireshark.org/review/25907 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=e2fbca05bc382a0b9c966ab6768985… commit e2fbca05bc382a0b9c966ab67689850749cba434 Author: Valentin Vidic <Valentin.Vidic(a)CARNet.hr> Date: Mon Feb 19 11:52:35 2018 +0100 TWAMP: Try to reassemble Server-Greeting message Some servers send Server-Greeting split into multiple packets. Change-Id: I56155eef1a20ded5c06c4a43cbc8d52961d029d0 Reviewed-on: https://code.wireshark.org/review/25896 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cf2a29f0838699e16d273b50bde02f… commit cf2a29f0838699e16d273b50bde02fa9c33795d5 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 13:06:16 2018 -0800 Check whether to do dissection after starting taps. One reason to do dissection is if a tap requires it, so we have to check after starting the taps. Change-Id: Ic7910449c3f85df2a52065e789986d970d13c253 Reviewed-on: https://code.wireshark.org/review/25904 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e2d5c537df39f35628c25e148f2a92… commit e2d5c537df39f35628c25e148f2a9238b74e1a45 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 19 09:41:09 2018 -0800 Reorganize and expand the description section. Try to do a better job of explaining the behavior with various combination of options. There are a lot of different output options, and combinations of those options, for TShark; try to cover more of them - it's complicated. Consistently refer to command-line "options" rather than "flags". Change-Id: Idbe6d22a07920789b3d5ed46a700e654a5ac0ae3 Reviewed-on: https://code.wireshark.org/review/25902 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=70608effe4d23bb5f05dc783b21c1a… commit 70608effe4d23bb5f05dc783b21c1ab9d2e5aa66 Author: Valentin Vidic <Valentin.Vidic(a)CARNet.hr> Date: Mon Feb 19 12:10:03 2018 +0100 TWAMP: Handle short TWAMP-Test packets Requests packets have a minimum length of 14 bytes and only responses have additional 27 bytes of fields. Without this patch short packets generate an exception and get reported as malformed. Change-Id: If75fa5556059b13f40fc49273edcbd32508fa0fc Reviewed-on: https://code.wireshark.org/review/25897 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8da569b6ad5beb9fa8c6aa49279e8a… commit 8da569b6ad5beb9fa8c6aa49279e8a805ffbdfda Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Mon Feb 19 14:57:05 2018 +0000 WSDG: Update docbook info The docbook info is now in README.adoc Change-Id: Ifbc6a1803d23835d9b2b91a9fd6df34002cc3e8f Reviewed-on: https://code.wireshark.org/review/25900 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=dbb5c73fec950c8909726ad471a204… commit dbb5c73fec950c8909726ad471a204a951a03756 Author: Matej Tkac <matej.tkac.mt(a)gmail.com> Date: Mon Feb 19 11:36:57 2018 +0100 [PFCP] Added missing User Plane Inactivity Timer IE value_string Change-Id: I043884300f3c5d4911c02f9c17d631e52700a793 Reviewed-on: https://code.wireshark.org/review/25895 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=042cfea07c8fd723a763d52378ae19… commit 042cfea07c8fd723a763d52378ae197a53b444fe Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Feb 17 19:50:48 2018 -0800 Qt: Use QFrames as separators in the filter expression toolbar. Use QFrames instead of QActions as separators in the filter expression toolbar. This keeps them from showing up in the overflow menu. Change-Id: I60f6f0434fe5ba88fe1b4221e9e70640eed840bb Reviewed-on: https://code.wireshark.org/review/25860 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c61b543e97f85fbe6a30f0368a7c69… commit c61b543e97f85fbe6a30f0368a7c6975bdd21fc8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 18 14:39:49 2018 -0800 Get rid of more new_ prefixes for statistics functions and types. There are no "old" versions of them that we're keeping around. Change-Id: I3c76a14d0ec1a06df39c547da37f4dea9987df4d Reviewed-on: https://code.wireshark.org/review/25892 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6a0a56ed078ef8a51b7c7b26acd0ba… commit 6a0a56ed078ef8a51b7c7b26acd0baa700b5c8d4 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 18 15:14:41 2018 -0800 Note that -P can override -Q's suppression of packet output. Change-Id: I38da07fb68a3b8c62e2267a06a9ba41ff80e7497 Reviewed-on: https://code.wireshark.org/review/25893 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f81f2c4a6ff405fcdeb1866d2bcb2d… commit f81f2c4a6ff405fcdeb1866d2bcb2d3018f39c6e Author: Robert Sauter <sauter(a)locoslab.com> Date: Sun Feb 18 14:03:05 2018 +0100 release-notes: Add 802.15.9, RFC 4108, and Wi-SUN FAN; sort new protocols list Change-Id: I31781ee7aef0547f86120c1d2e6adfd2dd6bdec8 Reviewed-on: https://code.wireshark.org/review/25870 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ca7ac05cf00bca96a0123540beceb2… commit ca7ac05cf00bca96a0123540beceb206a788906f Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Sun Feb 18 22:40:50 2018 +0100 Fix some source headers, reformat SPDX license lines in comment block. Change-Id: Ibae6a64a9915003435a3fb17763535a3844143be Reviewed-on: https://code.wireshark.org/review/25891 Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=44a6e2dea8be8e02cdc62a2a89dc79… commit 44a6e2dea8be8e02cdc62a2a89dc79f734ab9f9b Author: Dario Lombardo <lomato(a)gmail.com> Date: Sun Feb 18 18:26:46 2018 +0100 marker: return unused offset (found by clang). Remove if (tree) as well. Change-Id: I618ce6e081eced8c5bf0a8d3e8acb7476538e841 Reviewed-on: https://code.wireshark.org/review/25883 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bd9d79fcd7b1e950c3e27d5b26e906… commit bd9d79fcd7b1e950c3e27d5b26e90688056d4d01 Author: Dario Lombardo <lomato(a)gmail.com> Date: Sun Feb 18 21:06:52 2018 +0100 marker: fix indentation. Change-Id: Ie59d25950dba92fe23e71fadb0884ae545bd882c Reviewed-on: https://code.wireshark.org/review/25886 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e090683aff0763c4604d8ea8d060cf… commit e090683aff0763c4604d8ea8d060cf9a1a8cfc79 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 18 13:02:15 2018 -0800 TFshark requires a file to be specified. It's not a capture program, so you can't say "capture on this interface"; you need a file to read. Change-Id: I8498001e06974ecd4678a48ac7b17f6fc60f7911 Reviewed-on: https://code.wireshark.org/review/25890 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0347538758f29b056c2e04959539bd… commit 0347538758f29b056c2e04959539bdc32f0291b6 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 18 12:52:21 2018 -0800 Don't start command-line taps until we've opened a file. We shouldn't do so until we have something on which to compute statistics and until we're in file scope, as the taps may use file-scoped memory, given that statistics pertain to a file. Change-Id: I08b6e5ed145d7a25056857cc570f383f5116d6ce Reviewed-on: https://code.wireshark.org/review/25889 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=da861e431135c620a879358b327311… commit da861e431135c620a879358b32731125b3e7b495 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 18 12:46:55 2018 -0800 We don't do taps in rawshark, so there are no taps to start. Change-Id: I53c75a91f11bf885e227c133dea8c546e751b274 Reviewed-on: https://code.wireshark.org/review/25888 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=22dc113852fb512f81c68ae1eb6914… commit 22dc113852fb512f81c68ae1eb6914f27f616f12 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 18 12:39:34 2018 -0800 Don't start command-line taps until we've opened a file or started capturing. We shouldn't do so until we have something on which to compute statistics and until we're in file scope, as the taps may use file-scoped memory, given that statistics pertain to a file. Change-Id: Ifb568480a3cbbd4dc891015b3bb42da1511ca514 Reviewed-on: https://code.wireshark.org/review/25887 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d9d6106044065ed748748ba2135a9a… commit d9d6106044065ed748748ba2135a9ac3cd6c5108 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Feb 18 15:19:48 2018 +0100 ASN.1: update auto generated dissectors Change-Id: Ic73e72b3d2e7590eaed07f6eb30f74f4303e7a65 Reviewed-on: https://code.wireshark.org/review/25880 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=47726eafe572686e5b36ea2e879809… commit 47726eafe572686e5b36ea2e8798096cf1a07bf9 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Feb 18 15:09:49 2018 +0100 NBAP: check that DCH ID was initialized before using it Bug: 14443 Change-Id: I184ed60d09576c00133c74b4376b2cb7106e5f80 Reviewed-on: https://code.wireshark.org/review/25874 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8760999f646fb398fa0c824f3539ce… commit 8760999f646fb398fa0c824f3539cee4a4911d13 Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Feb 17 13:33:44 2018 -0500 LLTD: use wider variables to prevent overflow and infinite loops Bug: 14419 Change-Id: I1adf186a56e87a043077d330d59f18b8e5823cd7 Reviewed-on: https://code.wireshark.org/review/25871 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b6328eba6a3d33930489709ee1e471… commit b6328eba6a3d33930489709ee1e47140dcc30dfb Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Feb 17 22:20:29 2018 -0500 DICOM: Prevent infinite loop (dissect_dcm_tag) uint32 value could wrap around, resulting in infinite loop. Bug: 14411 Change-Id: I26c73f74adc65c7a5acf22970a54c93a7f7a2344 Reviewed-on: https://code.wireshark.org/review/25873 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=95affa1ef1484741156a34aface45a… commit 95affa1ef1484741156a34aface45aa5e16c02c9 Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Feb 17 13:40:55 2018 -0500 USB: Sanity check Darwin USB header to prevent infinite loop. Bug: 14421 Change-Id: Ifb492b776182507c10664d067f99312af250e6ff Reviewed-on: https://code.wireshark.org/review/25872 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bee04353b91cbec90c9377f74ceeef… commit bee04353b91cbec90c9377f74ceeefa374757c65 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Sun Feb 18 11:27:13 2018 +0100 DIS: fix Modulation paremter length According to https://www.sisostds.org/DigitalLibrary.aspx?Command=Core_Download&EntryId=… table 5.2.1 modulation paremter is 8 bytes long (and not 16). Bug: 14441 Change-Id: I5d43411124e554721cfaa6c33561a04c91688aee Reviewed-on: https://code.wireshark.org/review/25866 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=aef93dba8c44c010a598cde60a5bf2… commit aef93dba8c44c010a598cde60a5bf25226c25676 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 16 16:46:16 2018 -0500 gitlab-ci: remove not working clang repos. Change-Id: Id1a6f07747dec45619b89daa0d8f7acb2bd425ca Reviewed-on: https://code.wireshark.org/review/25865 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=632c6261caa68405f67495ee715936… commit 632c6261caa68405f67495ee71593654e7e23177 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 18 08:15:50 2018 +0000 [Automatic update for 2018-02-18] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I5b5b729c83aa7017454b7c7d8230415e1834587f Reviewed-on: https://code.wireshark.org/review/25862 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=fcea7205a471c4353847bebaafec7d… commit fcea7205a471c4353847bebaafec7d0c2a72618f Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 19:33:20 2018 -0800 Get rid of unnecessary casts. Change-Id: I6b911dc2fa9b95ce16c63b13bf8cf10f8a1ce7d7 Reviewed-on: https://code.wireshark.org/review/25859 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=38d784d54734a4f8e561f6df3460d0… commit 38d784d54734a4f8e561f6df3460d02aac53015e Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sat Feb 17 23:22:31 2018 +0100 6LoWPAN: break loop in case of unexpected loRHE type Bug: 14422 Change-Id: I5875dd63282ff645e78a4b0cf5f34ea746ec7dfd Reviewed-on: https://code.wireshark.org/review/25852 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5d99febe66e96b55a1defa58a906be… commit 5d99febe66e96b55a1defa58a906be254bad3a51 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sat Feb 17 22:51:39 2018 +0100 S7comm: fix range check to prevent infinite loop when upper bound is 255 While we are at it, fix identification of not last element in a few places Bug: 14423 Change-Id: I568530949d09ddfd8c5c58d24050dfed32ce10f5 Reviewed-on: https://code.wireshark.org/review/25851 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cae52d27d646c04734726b54edf9aa… commit cae52d27d646c04734726b54edf9aacddc3153e8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 15:24:07 2018 -0800 Don't gratuitously cast away constness. Change-Id: I5d953ba2f89d8c65ae62012f32757acc14108f81 Reviewed-on: https://code.wireshark.org/review/25857 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e61257988e3024b6ee21a99f32d82b… commit e61257988e3024b6ee21a99f32d82bc2a7ab5c8e Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 15:17:40 2018 -0800 Make all versions of add_unix_interface_ifinfo() static. That routine is not used outside this file. Change-Id: I50bd1aee564df1b4bb38602a1a40377b5dd86d5f Reviewed-on: https://code.wireshark.org/review/25856 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=16348cbddb604b267b63c84f30bb2b… commit 16348cbddb604b267b63c84f30bb2b0a72778dcc Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 14:53:30 2018 -0800 Clean up missing-prototype warnings. Add prototypes for the registration routines. Make routines not used outside this file static. Change-Id: Icaa7e5877888a0e0299cfd94d7921df8a138d0e1 Reviewed-on: https://code.wireshark.org/review/25854 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=04704e289fbc0b06dc1352da841648… commit 04704e289fbc0b06dc1352da8416488425650cc2 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 14:48:16 2018 -0800 Don't gratuitously cast away constness. Change-Id: I778deaaee1d52c4a5a716f6d23f787e041664deb Reviewed-on: https://code.wireshark.org/review/25853 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=137da3f1064c89c98cdd9fe66a707a… commit 137da3f1064c89c98cdd9fe66a707a7d3fe05e00 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:57:26 2018 -0800 Don't gratuitously cast away constness. Change-Id: If442abf521ee79bbaac0a133a64e8c9de3e31c59 Reviewed-on: https://code.wireshark.org/review/25850 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2530b75e1da0f715a6b712ee9b12be… commit 2530b75e1da0f715a6b712ee9b12beb6e7d604e4 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:53:31 2018 -0800 Don't gratuitously cast away constness. Change-Id: I5c80e50c524db6ee80e1529af447db9a26e02f48 Reviewed-on: https://code.wireshark.org/review/25849 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=55042dc15b9b6611c01f8eacf193d2… commit 55042dc15b9b6611c01f8eacf193d2fb6556afc9 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:42:02 2018 -0800 Don't gratuitiously cast constness away. Change-Id: Ie373b7e1079092e01c99939f29d7afdbf465bd8b Reviewed-on: https://code.wireshark.org/review/25848 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=23b8d11546c3c05e967b7d00e5dbb2… commit 23b8d11546c3c05e967b7d00e5dbb2659200eb4f Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:32:22 2018 -0800 Don't gratuitiously cast constness away. Change-Id: Ibd43d689cd4d00c26440589a772a818f6c5905c3 Reviewed-on: https://code.wireshark.org/review/25847 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ef96c91060d31d546f96adfeef779f… commit ef96c91060d31d546f96adfeef779f79c75c36da Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:22:26 2018 -0800 Put back casts needed for C++ compatibility. Change-Id: Ia83d08f62e97478f532da9af0c1cbfef7532b1c7 Reviewed-on: https://code.wireshark.org/review/25846 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=92f3a0f3e9c0480abb6f1cc2e51e5e… commit 92f3a0f3e9c0480abb6f1cc2e51e5e32a17ae155 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:17:21 2018 -0800 Don't gratuitously cast away constness. Change-Id: I51e7207835190fc87cf7c7cb0cf3a09a0588629a Reviewed-on: https://code.wireshark.org/review/25845 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a14c6a849090e32fcdf8136be8ba93… commit a14c6a849090e32fcdf8136be8ba9360c371bf5c Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 13:11:10 2018 -0800 Constify a pointer to squelch a warning. Change-Id: I3e83f79227b080d336b5fef14df1ea75a13238de Reviewed-on: https://code.wireshark.org/review/25844 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1c5d6881de42d9093933718e7bec62… commit 1c5d6881de42d9093933718e7bec6211222fb7d6 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Feb 17 11:44:41 2018 -0800 Qt: Another filter expression toolbar layout attempt. Try hiding and showing the filter expression toolbar in order to update its layout. This is a bit ham-fisted but seems to be the only way to get it to work properly after clearing and inserting buttons. Bug: 14121 Change-Id: Iea851c029c1586abfdb01c639914f6fe97ea29b3 Reviewed-on: https://code.wireshark.org/review/25840 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=9826cde91d56be3cbbaf7609a29e2b… commit 9826cde91d56be3cbbaf7609a29e2bbb3478835c Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 12:42:51 2018 -0800 Constify a bunch of pointers and some casts. This squelches a bunch of "constness casted away" warnings. Change-Id: I95949ccbecceea651e7e4acb99f8e69ee0bfc475 Reviewed-on: https://code.wireshark.org/review/25843 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4fe475492cfd94df8542edc20b22bc… commit 4fe475492cfd94df8542edc20b22bc6a531cad32 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 12:33:20 2018 -0800 Use appropriate pointer types rather than guint8 *. This means we don't lose alignment information that causes spurious compiler warnings. Change-Id: I721f180c137bcffbcf7edf88cf8caf52c33fa545 Reviewed-on: https://code.wireshark.org/review/25842 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=397d32b863b640ccded140acd6eec9… commit 397d32b863b640ccded140acd6eec94da367264b Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 12:19:33 2018 -0800 dcerpc_decode_as_change() doesn't need to change the old binding. The search doesn't use the fields we change (if it did, we probably shouldn't change them, as the old binding might not be found), so don't change them. Instead, when we allocate a *new* binding structure, put the new values into *that* structure. Squelches a "casting away constness" warning. Change-Id: I6dbd1a4cbc2415373f4926f443f9756c8113c0be Reviewed-on: https://code.wireshark.org/review/25841 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=86f2ff6ec027514d067fd6ec054b6b… commit 86f2ff6ec027514d067fd6ec054b6b2fa7c3afe1 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 11:36:52 2018 -0800 Yet Another Narrowing Warning to suppress. Change-Id: I6ec0a04a0ad074849f447164270a7ff4851b698f Reviewed-on: https://code.wireshark.org/review/25839 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=cd443126a4d73612f27286b0f548a0… commit cd443126a4d73612f27286b0f548a07b63553a5c Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 11:33:30 2018 -0800 No need to cast away constness. Change-Id: I9778f2bf867539f83835d6c04bac201e66b1e5ee Reviewed-on: https://code.wireshark.org/review/25838 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8b9dfbaba9f10cffd41b0cca1446a7… commit 8b9dfbaba9f10cffd41b0cca1446a7a6c5b6eb90 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 11:30:01 2018 -0800 The CRC8 routines don't modify the buffer; make the pointers to it const. This lets us get rid of some casts that provoke "drops const qualifier" warnings. Change-Id: Ia7e0863bd97bc20dbbb810e13778ec78d0cf3c91 Reviewed-on: https://code.wireshark.org/review/25837 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dc8bd7c3a9efd30651c5c31b37ae27… commit dc8bd7c3a9efd30651c5c31b37ae27b2169592db Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 11:03:32 2018 -0800 Fix argument list in comment. Oh, and change something up with which we have no evidence whether Winston Churchill would put or not: http://itre.cis.upenn.edu/~myl/languagelog/archives/001715.html http://itre.cis.upenn.edu/~myl/languagelog/archives/001702.html Change-Id: I7a76d564bdd481de2a56d32aa44c9dfe98a270f6 Reviewed-on: https://code.wireshark.org/review/25836 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5bf8da8a4cd5381d1d206ce7074690… commit 5bf8da8a4cd5381d1d206ce7074690dba463dba0 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 10:40:23 2018 -0800 Fix casts. A gconstpointer is a "pointer to const void", so it should be cast to "pointer to const XXX". A "pointer to const pointer to plugin" is a "plugin *const *". C's declaration syntax is not one of its strong points. There's a reason why the cdecl program, and the Web site that uses it, http://cdecl.org, exists (as the tag line says, "C gibberish <-> English"), and why I used it to make sure I got this working. Change-Id: Ia29bb25d17a1255a06b4ace542643c4b494d4977 Reviewed-on: https://code.wireshark.org/review/25835 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f0393a5975e96665c6d828ec2d7d10… commit f0393a5975e96665c6d828ec2d7d103372e18acd Author: Robert Sauter <sauter(a)locoslab.com> Date: Fri Feb 16 12:58:12 2018 +0100 wisun: Add EDFE support During an EDFE exchange the source addresses are omitted after the first frame. Restore the information to enable decryption and 6LoWPAN reassembly. Change-Id: I9660c81e0536cea56caf104a16e41eaf6c123e09 Reviewed-on: https://code.wireshark.org/review/25819 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=306c1c85cdf321ba81e5ccf0c62991… commit 306c1c85cdf321ba81e5ccf0c6299182f66ea34c Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 15 20:17:30 2018 +0100 ldap: Format text used in COL_INFO Use format_text() on strings from packet used in COL_INFO to show non-printable characters as C-style escapes. Bug: 14424 Change-Id: Ibeb18958e0c5877681a18873377ad96d7237490c Reviewed-on: https://code.wireshark.org/review/25808 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6be0444caf472125fd765107be5b04… commit 6be0444caf472125fd765107be5b04c6c50dc928 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 17 00:10:43 2018 -0800 Don't make separate libXXX_generated libraries. We no longer use different compiler flags for generated and non-generated files, so we don't need to put them into separate libraries and then add the files from the generated library into the main library. Change-Id: Idbd35510ccb8c9107b4de4199c8b1bcaa6f7a060 Reviewed-on: https://code.wireshark.org/review/25831 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=49e331c4cec96a1ca2637eed48f675… commit 49e331c4cec96a1ca2637eed48f67553bc53a5b9 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sat Feb 17 14:25:36 2018 +0100 Thread: use wider variables to prevent overflow and infinite loops Bug: 14428 Change-Id: I5536bdca23b24e41c13c0837d1f50d9db26f864a Reviewed-on: https://code.wireshark.org/review/25832 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0fa1176c22d83728b83111d9847510… commit 0fa1176c22d83728b83111d984751093c46a4106 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 16 16:02:26 2018 -0800 Add `-z http_ref,tree` to the tshark man page. Change-Id: Ia7b229fc4c42bd967ee4315543f58f6c05be5510 Reviewed-on: https://code.wireshark.org/review/25827 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a9823dddf3dfdf0f048fcc1ecc0b95… commit a9823dddf3dfdf0f048fcc1ecc0b951c87b91c6b Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 16 11:47:35 2018 -0800 Qt: Replace the toolbar extension icon. The QToolBar extension button icon is ugly, particularly on HiDPI displays. Replace it with a RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK. Change-Id: I8822252ff5c328acd23aad345313e7cfafdffa47 Reviewed-on: https://code.wireshark.org/review/25821 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d0b9db8cd8f9290173860f8cc52e89… commit d0b9db8cd8f9290173860f8cc52e89834b253331 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 16 09:29:38 2018 -0800 Qt: Add separators between filter expression buttons. I've noticed at SharkFest and other places that people sometimes put square brackets around their filter expression names so that it's easier to distinguish one button from another. Add separators between buttons so that this shouldn't be necessary. Change-Id: I3b1ca42f6417d2045781fc14d594faba4fd00fd5 Reviewed-on: https://code.wireshark.org/review/25820 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=459bd4646d15c56b14f9f10d86c6f5… commit 459bd4646d15c56b14f9f10d86c6f5d342174c98 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 18:22:31 2018 -0800 Don't have CLEAN_FILES variables for the "clean" source files. Except for the one directory that (currently) has "not yet clean" files, epan/dissectors, we don't need a separate variable to keep track of the "clean" source files. In the cases where not all files were in CLEAN_FILES, put them into the variable used to enable -Werror or its equivalent. Change-Id: Ic4119861c1d9e381adfe31e9977e1ac71d623f5b Reviewed-on: https://code.wireshark.org/review/25830 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5f0d50690ae01427ae310e15989cbe… commit 5f0d50690ae01427ae310e15989cbe3780a241ad Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 17:22:23 2018 -0800 Use -Werror except for explicitly listed dirty dissectors. Use AM_CFLAGS for everything except for libdirtydissectors in epan/dissectors. Rename GENERATED_CFLAGS/GENERATED_CXXFLAGS to DIRTY_CFLAGS/DIRTY_CXXFLAGS, as it doesn't apply to all generated files. Change-Id: I702b53e185d6972c08d68ef31c05df7b03669daa Reviewed-on: https://code.wireshark.org/review/25829 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0ac5c797fec5759483dd7b48816f83… commit 0ac5c797fec5759483dd7b48816f836f8c1beeea Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 16:56:27 2018 -0800 Don't use GENERATED_CFLAGS on generated files, use AM_CFLAGS. They're now warning-free, as we're disabling the warnings in Flex-generated code. Change-Id: I628a60cc416bcab16258124bf3e266ae6e9201b5 Reviewed-on: https://code.wireshark.org/review/25828 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=eb6eee72d616d7edf962d913463bc7… commit eb6eee72d616d7edf962d913463bc70995caa76c Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 16:00:10 2018 -0800 Don't treat radius_dict.l specially. The warning it gets is for one of the extra warning flags, not turned on by default, and is rather common (and hard to fix). Change-Id: Icbc9156ab3862e5921d86b39b936754abe15968d Reviewed-on: https://code.wireshark.org/review/25826 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a931f49dbb489c9062154df0fcc4cd… commit a931f49dbb489c9062154df0fcc4cd9222003c99 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 16 15:28:29 2018 -0800 Update the release notes. Change-Id: If2899febb07a18baf6b0020244ed1b5408c45998 Reviewed-on: https://code.wireshark.org/review/25825 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=0ee6e43478912f2aad6c24bb54b9f2… commit 0ee6e43478912f2aad6c24bb54b9f2c3a89279a3 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 15:43:45 2018 -0800 Compile text2pcap with -Werror. Change-Id: If411c518c2373a21b0a601526a8e632be88d65c5 Reviewed-on: https://code.wireshark.org/review/25824 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f4cd45f6fea693f8ab82fb3264bea7… commit f4cd45f6fea693f8ab82fb3264bea717b32d4947 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 14:51:51 2018 -0800 Treat the text2pcap scanner as clean. We now disable some warnings on Flex-generated code. Change-Id: I8ff242dc17e7345e9d5883354e921642cb0118fd Reviewed-on: https://code.wireshark.org/review/25823 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4a69d10920c47fbbb5522adbb478cf… commit 4a69d10920c47fbbb5522adbb478cfeb8f6785dc Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 14:10:47 2018 -0800 Squelch redundant declaration warnings. Have the text-to-pcap scanners define a routine that the main code calls, which both allocates and destroys the scanner. Don't declare the Lex-generated routines in a header file we create, declare that routine, instead. Change-Id: Icad6a83db1a0dea8ac390315af72383fc99f8513 Reviewed-on: https://code.wireshark.org/review/25822 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c881ee37d955428cea8f377aaa0a66… commit c881ee37d955428cea8f377aaa0a66d5c0b0e60d Author: Matej Tkac <matej.tkac.mt(a)gmail.com> Date: Thu Feb 15 16:04:34 2018 +0100 [PFCP] Added dissect function for User Plane Inactivity Timer IE in accordance with 3GPP 29.244 v15.0.0 Change-Id: I27d65d591976edfef13a713cf3a0768915e29256 Reviewed-on: https://code.wireshark.org/review/25803 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=72b57ac4ef653c1909e4c1d1daf40d… commit 72b57ac4ef653c1909e4c1d1daf40de2357b77e8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 16 03:15:32 2018 -0800 Use DIAG_OFF_FLEX/DIAG_ON_FLEX more consistently. Add warning C4267 (size_t to int conversion) with MSVC to DIAG_OFF_FLEX. Addd -Wshorten-64-to-32 with Clang and GCC to DIAG_OFF_FLEX. Don't explicitly use #pragma to turn off warnings; use DIAG_OFF_FLEX for all of them. If we use DIAG_OFF_FLEX, use DIAG_ON_FLEX, even if we have no section of entirely included code at the end. Change-Id: Ibfd44e8954704e9a8bcb1bd8e54f31d28357fffb Reviewed-on: https://code.wireshark.org/review/25817 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=09671923adcb745381fc4b276085d0… commit 09671923adcb745381fc4b276085d0ac7cb8ee94 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Fri Feb 16 12:49:00 2018 +0100 mac-lte: fix memory leak of mac_lte_msg3_cr_hash Found by LeakSanitizer with "tshark -i dbus-session -c1". Change-Id: Icef967755088ef25a9b1f2cd7def97078b274966 Fixes: v2.5.0rc0-1865-g52365a55e4 ("LTE L2 protocols: add FT_FRAMENUM_TYPE for most FT_FRAMENUM fields.") Reviewed-on: https://code.wireshark.org/review/25818 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=cfafb915d1f4741996b085336ac139… commit cfafb915d1f4741996b085336ac13998e573d9cd Author: Joakim Karlsson <oakimk(a)gmail.com> Date: Fri Feb 16 11:21:00 2018 +0100 [Diameter] Gx Supported-Features AVP, List-ID 2 Change-Id: I5cf5adf8c8ae8cbfb9c4c6369454ab4b3ee230a4 Reviewed-on: https://code.wireshark.org/review/25816 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1b574b907f8ce97b00d402e0374b89… commit 1b574b907f8ce97b00d402e0374b8943c83543d4 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Jan 18 16:45:52 2018 +0100 capchild: remove double free (found by clang). Now the callers are responsible for deallocating argv: not doing it can lead to memleaks. Change-Id: I45dc0826c0430e38426eb64555664892744aa2d5 Reviewed-on: https://code.wireshark.org/review/25369 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=8bc1c6e3e8c0a84ee656d1e1d68530… commit 8bc1c6e3e8c0a84ee656d1e1d68530fc9bf2e35d Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 15 23:17:04 2018 -0800 Add DIAG_OFF_FLEX and DIAG_ON_FLEX for use in Flex scanners. DIAG_OFF_FLEX turns off all warnings that we want to disable for Flex-generated code due to some versions of Flex generating code that triggers those warnings. DIAG_ON_FLEX restores those warnings, so we do the checks for code that *we* wrote. Use them in .l files. Change-Id: I613a20309a30cd4c61111a1edbe27a5d05fcbf59 Reviewed-on: https://code.wireshark.org/review/25815 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b6bec7d1fdf537f12968276344e619… commit b6bec7d1fdf537f12968276344e6191394249b8b Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 15 19:38:36 2018 -0800 Treat most Lex-generated and all Lemon-generated files as clean. Now that we're suppressing warnings that come from Flex generating insufficiently fussy code, just treat many of the Lex-generated files as clean; we don't seem to be getting warnings from Lemon-generated ones. Change-Id: Ib53ced6d8cb80645234929afca343d047d30f7f7 Reviewed-on: https://code.wireshark.org/review/25813 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=08754c3893befe1bc2377b8b30abef… commit 08754c3893befe1bc2377b8b30abef00aa5e52d0 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 15 11:25:31 2018 -0800 Suppress more PortAudio + Win64 compiler warnings. Add C4311 and C4312 to the suppression list. Change-Id: I90c85ee5cd3f7c3f235ed89b78d04f34bf0db449 Reviewed-on: https://code.wireshark.org/review/25810 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=a5094050e4f024a17f3abaab1c406f… commit a5094050e4f024a17f3abaab1c406fcf18244155 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Thu Feb 15 20:23:12 2018 +0100 Fix a case of copy - too little modify - paste Change-Id: I4c9ef6b89e0a07d2f9cac59221e0a8ac8f907883 Reviewed-on: https://code.wireshark.org/review/25809 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=11e0df5e3aa1644eefd3e3ed5d8d41… commit 11e0df5e3aa1644eefd3e3ed5d8d419b6d61f138 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Thu Feb 15 19:08:30 2018 +0100 Put some info into the INFO column Change-Id: I4ee22454d45edb382a76603fe21360719c5fa27f Reviewed-on: https://code.wireshark.org/review/25805 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=364d9a999d697c4aa0304733e36345… commit 364d9a999d697c4aa0304733e363454f17ab5fba Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 15 08:38:34 2018 -0800 Look in %VCToolsRedistDir% for the VC++ redistributable. Look in %VCToolsRedistDir% for the redistributable that we ship with the NSIS installer. Clarify a couple of status messages. Change-Id: I965d15947c3d3422d7c722afa581f4f7dfc2725a Reviewed-on: https://code.wireshark.org/review/25804 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d45bd7cb2424d4f99924aacf415c92… commit d45bd7cb2424d4f99924aacf415c92cd7e61329a Author: Peter Wu <peter(a)lekensteyn.nl> Date: Thu Feb 15 15:23:50 2018 +0100 Move hkdf_extract to wsgcrypt.h HKDF-Extract is not used in TLS, but in QUIC. For reuse in OSCORE, move it to wsutil. Adjust comments slightly to emphasize precondition. Change-Id: I5105e7416037697b383ad58f62be285c2b7ab8b7 Reviewed-on: https://code.wireshark.org/review/25802 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Reviewed-by: Mališa Vučinić <malishav(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7ae954c7ac934ea5748b6d65f1c04e… commit 7ae954c7ac934ea5748b6d65f1c04e8c9b90e27f Author: Jan Holthuis <jan.holthuis(a)ruhr-uni-bochum.de> Date: Tue Sep 12 15:53:32 2017 +0200 steam-ihs: Add dissector for the Steam IHS Discovery Protocol This adds a dissector for the Steam In-Home Streaming Discovery Protocol by Valve Software. Useful documentation can be found at: https://codingrange.com/blog/steam-in-home-streaming-discovery-protocol Change-Id: I26a79e201cfb0aad0ca702ac962e1e7b1b541517 Reviewed-on: https://code.wireshark.org/review/23615 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a660215deab1ce881e9066e0d89ba9… commit a660215deab1ce881e9066e0d89ba93445fff7bf Author: Your Name <you(a)example.com> Date: Thu Feb 15 00:39:53 2018 +0100 fuzzshark: disable reassembly for few protocols Reassembly (or in general being stateful) doesn't help when fuzzing, even if wireshark will crash oss-fuzz will try to reproduce the crash with just single sample. Single sample will not reproduce the crash, so being stateful makes wireshark 'buggy target'. I hope change will also make IP corpus a little bit smaller. Change-Id: I01ba8177a653d220c4cfe8a56a5836c96010c6fe Reviewed-on: https://code.wireshark.org/review/25799 Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=010c73daa65847035cab3f64367300… commit 010c73daa65847035cab3f64367300b6cba2d038 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 14 16:02:14 2018 -0800 Disable warning C4267 in generated files. Disable warning C4267 in Visual C++ in order to squelch the following warnings: 125>dtd_parse.c(1699): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\epan\epan.vcxproj] 125>diam_dict.c(2348): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\epan\epan.vcxproj] 125>C:/buildbot/builders/windows-x86-64-petri-dish/windows-x86-64-petri-dish/build/cmbuild/epan/uat_load.c(1476): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\epan\epan.vcxproj] 130>wimaxasncp_dict.c(2103): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\buildbot\builders\windows-x86-64-petri-dish\windows-x86-64-petri-dish\build\cmbuild\plugins\epan\wimaxasncp\wimaxasncp.vcxproj] Change-Id: Ie29ae096e5a8b5037abaf3f2aa97754260f4cace Reviewed-on: https://code.wireshark.org/review/25800 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6325ceb5e5cc58a8ed57029a6f4c98… commit 6325ceb5e5cc58a8ed57029a6f4c984e669e59fd Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Wed Feb 14 19:40:55 2018 +0000 DCT2000: read new LTE MAC outheader values Also extend the carrier id enum to r10 levels. Change-Id: I1eac50c54801010f0ad7408debb80ad811e03fbe Reviewed-on: https://code.wireshark.org/review/25793 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2934683aa1887e247f15bc04ab705c… commit 2934683aa1887e247f15bc04ab705c52fbb225df Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 14 14:02:04 2018 -0800 Fix a typo in the I/O tests. Change-Id: I45bfa6eb9245d0f470a0316141f81c99cc5a9754 Reviewed-on: https://code.wireshark.org/review/25797 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=bfedd74e99a04fb4ef802fb8a663e3… commit bfedd74e99a04fb4ef802fb8a663e3bf76721992 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 14 12:01:35 2018 -0800 CMake: Try to avoid Strawberry Perl's xsltproc. Search for Chocolatey's and Cygwin's respective xsltprocs before searching %PATH%. Strawberry Perl doesn't include DocBook, which makes it useless as far as we're concerned. Another approach would be to look in various locations for an XML catalog files and set %XML_CATALOG_FILES%. However, Cygwin's /etc/xml/catalog contains Cygwin-specific URLs, e.g. file:///etc/xml/docbook and can't be used with a non-Cygwin xsltproc. Change-Id: Iaebfdff922a6574581b9bd207625f03598c166e0 Reviewed-on: https://code.wireshark.org/review/25794 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=7da66f8676cc663d8898b5ff9cf41c… commit 7da66f8676cc663d8898b5ff9cf41cad80df4900 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Feb 14 14:35:49 2018 +0100 SIGCOMP: check operand offset when accessing UDVM memory Bug: 14398 Change-Id: Iae786d6766f63926766ab6139d76bdc24fa37103 Reviewed-on: https://code.wireshark.org/review/25790 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6c00182e1aab846ab45ff5043cc94a… commit 6c00182e1aab846ab45ff5043cc94a42b5f86b96 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 14 12:48:23 2018 +0100 travis: add asciidoctor. Change-Id: I82e72bf194c37001190868257fb7bef499e38ede Reviewed-on: https://code.wireshark.org/review/25789 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f7e90534fa66244c1c4cf00c4131f8… commit f7e90534fa66244c1c4cf00c4131f805924a4541 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Wed Feb 14 13:25:25 2018 +0100 [nb_rtpmux] Register dissector by name. Change-Id: I6aca4e84e44cad42bff969d55371d6ac6c5e9600 Reviewed-on: https://code.wireshark.org/review/25788 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9198448f9db7b77af8d19f8265d678… commit 9198448f9db7b77af8d19f8265d6785fb005dc58 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Tue Jan 23 17:56:42 2018 +0100 Qt: fix crash in packet dialog on changing selection "((capture_file_t *)cap_file_)->edt" is documented in cfile.h to cover the currently selected packet (in the packet list). But in the packet dialog, the packet selection is irrelevant and the data from a different dissection tree must be used. Change-Id: Ieaea3cf862d47540e7f6b6c84c1a2fa6945a877b Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy") Bug: 14246 Reviewed-on: https://code.wireshark.org/review/25437 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f0db412f57effe6234edc78e1f438b… commit f0db412f57effe6234edc78e1f438b735efae805 Author: Michael Mann <mmann78(a)netscape.net> Date: Mon Jan 8 19:43:36 2018 -0500 Convert coloring rules dialog to use model. Change-Id: I12a465b5451bdbaea871828329d48fda3627fca3 Reviewed-on: https://code.wireshark.org/review/25372 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a3e14cb514976a9354676a2caa7b00… commit a3e14cb514976a9354676a2caa7b001e50dc6189 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 13 16:33:37 2018 -0800 Debian: Update Build-Depends. Sync the required CMake version and remove w3m. Change-Id: I6c74bb5eb42c678bc91911085b270a9c60095135 Reviewed-on: https://code.wireshark.org/review/25783 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=30841256963df53292a6904952ed42… commit 30841256963df53292a6904952ed4288e85d0ff6 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 13 17:08:14 2018 -0800 Qt: Fix the filter expression toolbar layout. Take a hint from the QToolButton sources and update the filter expression toolbar using updateGeometry instead of adjustSize. This appears to do the layout updates and other changes required to draw the dropdown in the correct place. Bug: 14121 Change-Id: I45d5a1173703f9c16d89841a57f651935da43d92 Reviewed-on: https://code.wireshark.org/review/25784 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6f2d4c27126f3d1a73494ceafc464d… commit 6f2d4c27126f3d1a73494ceafc464df99e081494 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 13 16:15:22 2018 -0800 Wix: Look for merge modules in %VCToolsRedistDir%. Add "%VCToolsRedistDir%\MergeModules" to the merge module search path. This is required for Visual Studio 2017 here. Change-Id: I91cd1527ae80c85ed304c1233436cae52aa0a501 Reviewed-on: https://code.wireshark.org/review/25782 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=944e661514feca102e49e2d776f0a4… commit 944e661514feca102e49e2d776f0a484e24fc597 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Feb 13 23:25:40 2018 +0100 OpenFlow 1.5: add extra property length checks Bug: 14420 Change-Id: I1813bc6285f950d86dc569f4286bf34c120b5e3c Reviewed-on: https://code.wireshark.org/review/25780 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4904dd5517dd1b9f7096a3b61d91f3… commit 4904dd5517dd1b9f7096a3b61d91f32c8ea14331 Author: Robert Grange <robionekenobi(a)bluewin.ch> Date: Tue Feb 13 14:52:38 2018 +0100 packet-mq: Code reformat Only reformated code (VS2017 with Ctrl K + Ctrl D) No code logic change Change-Id: If574c50cf0efb75984beb45df958be991ea63819 Reviewed-on: https://code.wireshark.org/review/25771 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=621d1496d70951bedc19adb1f5a185… commit 621d1496d70951bedc19adb1f5a1854ba4fd60ea Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Feb 13 23:34:49 2018 +0100 OpenFlow: update openflow_version_values value_string Change-Id: I0552770981d56c1a530b65e755146ec1314fccd8 Reviewed-on: https://code.wireshark.org/review/25781 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2bff4c197b9bb9c60de37cc036af9c… commit 2bff4c197b9bb9c60de37cc036af9cd60a17245a Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Feb 13 21:51:08 2018 +0100 XRA: protect against potential infinite loops and add protocol to release notes Change-Id: Ib1dc560e0c0c83ada668ada2da799808d5d10fc2 Reviewed-on: https://code.wireshark.org/review/25776 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=af6433196edb6bd86764e851a49606… commit af6433196edb6bd86764e851a4960667c3eeacc4 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 13 13:14:40 2018 -0800 Update symbol lists. Change-Id: Iafc539a6ced0f81e2ebf796ccb490119fe2ff3f6 Reviewed-on: https://code.wireshark.org/review/25779 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8c814239128c813445fcf10d43869d… commit 8c814239128c813445fcf10d43869d0ca920f03e Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 13 13:05:36 2018 -0800 Add the Excentis XRA DOCSIS header dissector to CMake. All changes to the set of Wireshark source files must be done in both Makefile.am and CMakeLists.txt files. Change-Id: Iad0db912dcfd149d0f5acbb38489e0a34c6dac89 Reviewed-on: https://code.wireshark.org/review/25778 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c82abe48a54cd7cdf589dda6cbbe5f… commit c82abe48a54cd7cdf589dda6cbbe5fd2d7b9ab5f Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 13 12:52:55 2018 -0800 Update the introductory comment. Update the URL for the Cisco CMTS. Remove the stuff about the Arris devices; the link doesn't work, their site doesn't seem to mention "Cadant", and the C4 page I did find doesn't say anything about how to do captures (that's probably hidden behind a customerwall). Emphasize that, if you can, and do, select "DOCSIS" as the link-layer type when capturing on an Ethernet, the file (for pcap) or interface (for pcapng) will be handled as DOCSIS, even if you don't set the "force all frames to be dissected as DOCSIS" preference. Change-Id: Iec44d4b9c6af231e9b7f36962515b566b3433fb4 Reviewed-on: https://code.wireshark.org/review/25777 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b4dc30ce73b2bc1da842a66420b89c… commit b4dc30ce73b2bc1da842a66420b89cd70f296935 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Mon Feb 12 08:54:49 2018 -0800 ieee80211: Correct the actual bit positions of the reserved bits. The reserved bit positions should match the bit positions of the fields that are reserved. Also, the hf_he_srg_information_present bit was nibble reversed. Errors found by George Baltatanu. Change-Id: I218ff9aa7bdabc4ec6e470c3ef1be230ce341b34 Reviewed-on: https://code.wireshark.org/review/25760 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6a910946cd5f921500abe806621407… commit 6a910946cd5f921500abe806621407fd5086398f Author: Bruno Verstuyft <bruno.verstuyft(a)excentis.com> Date: Tue Feb 13 11:45:41 2018 +0100 Added dissector for Excentis DOCSIS31 XRA header. DLT 273. Builtin version. Change-Id: I7d4a9cf094e8ae6af05d5599489fc609456c5645 Reviewed-on: https://code.wireshark.org/review/25768 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9eee872f8aaa7d50205983b3ce1c89… commit 9eee872f8aaa7d50205983b3ce1c892c49389d6e Author: Robert Sauter <sauter(a)locoslab.com> Date: Tue Feb 13 17:15:47 2018 +0100 cms: Add support for RFC 4108 Change-Id: I1ab32240e00c7682074e7bc9d1b05e6daa6b69b4 Reviewed-on: https://code.wireshark.org/review/25769 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=feb8f6b14d7e342db369656ab44c38… commit feb8f6b14d7e342db369656ab44c38546b0140bb Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 13 11:47:23 2018 -0800 Make the DOCSIS dissector a built-in dissector. Stuff that calls it is built in, and stuff it calls is built in, so there's not much point in having it be a plugin; we already have examples of plugin dissectors. Change-Id: I512e0fda62faedb5f03f476fbece2e267e1d644f Reviewed-on: https://code.wireshark.org/review/25775 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=048c4373e15a401a8700bc57b40328… commit 048c4373e15a401a8700bc57b403282c7830d27e Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 13 10:25:47 2018 -0800 Asciidoctor macro fixups. Fix a few errors in the Asciidoctor macros. Use the new macro names in the release notes and gen-bugnote. Change-Id: I2ca672949c59ca3da8a6b963cb5bd9abd66c348d Reviewed-on: https://code.wireshark.org/review/25774 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d332507ef2771f5c623a6768caadca… commit d332507ef2771f5c623a6768caadcabe6dd5583d Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 13 10:05:31 2018 -0800 Fix the "pointer to function that generates a label" values. build_label_func is a pointer type, pointing to a function that can be used to generate a label for a "Decode As" entry. There's no need to have pointers to those pointers; have register_decode_as_next_proto() take a build_label_func, not a build_label_func *, as its last argument, assign that value rather than dereferencing it, get rid of unnecessary casts, and fix the comment in epan/decode_as.h for that argument. Change-Id: Idc3cf18204c543a2191b122c8129b362562c0ecd Reviewed-on: https://code.wireshark.org/review/25773 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=bb9e26eb49ef33ca00a3f85fa15de8… commit bb9e26eb49ef33ca00a3f85fa15de862677688ec Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Feb 13 15:52:20 2018 +0100 ssl: Add session ticket lifetime units in seconds Also show the seconds in a human readable string. Change-Id: I124bfc12954fb7c2c65777c028986d18c5686c7b Reviewed-on: https://code.wireshark.org/review/25772 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=765015131124bd54492bbda11aadb7… commit 765015131124bd54492bbda11aadb75a1fa3b60f Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 12 14:07:48 2018 +0100 more SPDX convertions. Change-Id: I6b8404c28b31a81767a3b64ffe9ba96156c4c217 Reviewed-on: https://code.wireshark.org/review/25757 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3db1c064045cb496a31adf5a2bc2fa… commit 3db1c064045cb496a31adf5a2bc2faddaff4bdad Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 13 10:03:24 2018 +0100 tools: fix zlib check in licensecheck.pl. Change-Id: I0b1708c6e4530115698d050e41b691af2a948578 Reviewed-on: https://code.wireshark.org/review/25766 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bc72f7cf5808d17e66b38fa4b98043… commit bc72f7cf5808d17e66b38fa4b98043efc5f1ce29 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Mon Feb 12 20:00:34 2018 +0100 data: Add option to uncompress compressed data Change-Id: I7bb212a9638c7b946294b7c805d9167ce7235e90 Reviewed-on: https://code.wireshark.org/review/25761 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7fd6abc1eb7e3b2a5f3ea1a587f6cd… commit 7fd6abc1eb7e3b2a5f3ea1a587f6cd7e2c582c75 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 13 10:45:33 2018 +0100 tools: remove extra spaces from licensecheck.pl. Change-Id: Iab25373f047cc084efaf751cb9a3cfbf62fd1f7a Reviewed-on: https://code.wireshark.org/review/25767 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d2af01684cc445e98fb10666ba42c8… commit d2af01684cc445e98fb10666ba42c8a9e4b79d81 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Mon Feb 12 21:00:12 2018 +0100 IPv6: SLAAC ether address is 8 bytes Change-Id: Id1ea9bb985b0e83c11d64cce4bb33ea7a65c794f Reviewed-on: https://code.wireshark.org/review/25763 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=0b1e354458c9df6498d8a4065ee0d7… commit 0b1e354458c9df6498d8a4065ee0d77eb250b4b0 Author: Jim Walker <jim(a)couchbase.com> Date: Mon Feb 5 14:40:33 2018 +0000 Update couchbase dissector with 'flexible framing extras' Add support to decode the new response message and then decode the array of flexible frames, currently only the "tracing" durations ID is fully decoded. See: https://github.com/couchbase/kv_engine/blob/master/docs/BinaryProtocol.md#r… Change-Id: I9ea1e3bb898d9c4dd3b30cd1109b7b70fc17b19e Reviewed-on: https://code.wireshark.org/review/25613 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9cc4a3b9674c2b5b53bd32b54dfe86… commit 9cc4a3b9674c2b5b53bd32b54dfe863bb08b81ed Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 11 14:34:04 2018 -0800 CMake: Install the HTML guides. Add a "FileInstall.cmake" module that installs files and directories. Use it to install the chunked HTML guides. Install the guides into CMAKE_INSTALL_FULL_DOCDIR. By default this is /usr/local/share/doc/Wireshark. Define DOC_DIR to match. Add explicit file and directory permissions to the default install targets. Remove the PDF install target. Bug: 14258 Change-Id: I4712a4047a54627b7520b5bf5f191e0761d19606 Reviewed-on: https://code.wireshark.org/review/25737 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d1ce1baf63c96f9bddfe8577a82568… commit d1ce1baf63c96f9bddfe8577a82568b21295fd96 Author: Craig Jackson <cejackson51(a)gmail.com> Date: Mon Feb 12 21:47:44 2018 -0500 WMEM: Add strjoin routines. Add wmem versions corresponding to g_strjoin() and g_strjoinv(). Modify packet-rtps.c to use wmem routines_ where it is now using g_ routines causing mallocs. Change-Id: I92c890a8b8f29a973e103676d8e5a681ee5abd50 Reviewed-on: https://code.wireshark.org/review/25764 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2cf6517ec088cadf60dec1f1c93b85… commit 2cf6517ec088cadf60dec1f1c93b8575e4a4f40a Author: Nick James <mookito(a)tuta.io> Date: Mon Feb 12 18:39:45 2018 +0200 NBAP: Fix and enhance SIB parsing 1. Parsing of complete-sib-short was wrong - did not consider the 8 bits of length in the begining 2. Added re-assembly logic for SIBs segmented into first/subsequent/last payloads Change-Id: I2c4aab2cace795c3e47a22921a34efc4ee26a25f Reviewed-on: https://code.wireshark.org/review/25598 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=045c48e81e0a74d5bf82d77c778a14… commit 045c48e81e0a74d5bf82d77c778a14cd4fee421d Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 12 11:23:04 2018 -0800 html2text: Prefix lists with a bullet. Prefix lists with a bullet symbol (U+2022) instead on an asterisk. Skip the <head> tag while we're here so that we don't print the title twice. Change-Id: I1dfad1fc70aa05319e14c55b663dd2183ab87d79 Reviewed-on: https://code.wireshark.org/review/25762 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=8ebbf99173984bf44e78ff7fec2a8a… commit 8ebbf99173984bf44e78ff7fec2a8ab082c1c8ae Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 11 11:03:56 2018 -0800 Remove Lynx. Use tools/html2text.py to convert HTML to text. Remove some now-obsolete documentation. Change-Id: Ib21a1ab10c789182da5fcc68e98917a00f2fa650 Reviewed-on: https://code.wireshark.org/review/25733 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=3b940d2a83a8d51f3de1284acec281… commit 3b940d2a83a8d51f3de1284acec28171f6cac8c9 Author: Matej Tkac <matej.tkac.mt(a)gmail.com> Date: Mon Feb 12 15:30:00 2018 +0100 [PFCP] Fixed a typo in Outer Header Creation IE Corrected octet order 3GPP TS 29.244 V15.0.0 Section 8.2.56 Change-Id: I9d4795641749481d7efea0b9b1743a0a94044aa2 Reviewed-on: https://code.wireshark.org/review/25759 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fe219637a6748130266a0b02781660… commit fe219637a6748130266a0b0278166046e60a2d68 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Feb 12 12:23:27 2018 +0100 dissectors: use SPDX identifiers. Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e9376e47307daf4dd81658b8d0c356… commit e9376e47307daf4dd81658b8d0c356e0936b692c Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Sun Feb 4 10:12:31 2018 +0100 h225: Fix use after free. next_tvb_add_handle() allocates memory in packet scope. When dissecting another packet from dissect_h225_h225_RasMessage() handler [it don't call next_tvb_init()] next_tvb_add_handle() will write to freed pointer. Fix by calling next_tvb_init() after leaving scope in order to clear list->last pointer. ASAN report: ERROR: AddressSanitizer: heap-use-after-free on address 0x6070000854f0 at pc 0x00000208574a bp 0x7ffca839cf00 sp 0x7ffca839cef8 WRITE of size 8 at 0x6070000854f0 thread T0 #0 0x2085749 in next_tvb_add_handle /src/wireshark/epan/next_tvb.c #1 0xef8728 in dissect_h225_ParallelH245Control_item /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:368:3 (...) #21 0x168f460 in dissect_per_sequence /src/wireshark/epan/dissectors/packet-per.c:1920:12 #22 0xef31d3 in dissect_h225_InfoRequestResponse /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:910:12 #23 0x168e7db in dissect_per_choice /src/wireshark/epan/dissectors/packet-per.c #24 0xeed6e3 in dissect_h225_RasMessage /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:298:12 #25 0xef97af in dissect_RasMessage_PDU /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:339:12 #26 0xeef872 in dissect_h225_h225_RasMessage /src/wireshark/epan/dissectors/./asn1/h225/packet-h225-template.c:385:12 0x6070000854f0 is located 0 bytes inside of 72-byte region [0x6070000854f0,0x607000085538) freed by thread T0 here: #0 0x4e2528 in __interceptor_cfree.localalias.0 /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:76 #1 0x21263a1 in wmem_simple_free_all /src/wireshark/epan/wmem/wmem_allocator_simple.c:107:9 #2 0x205aa4d in wmem_leave_packet_scope /src/wireshark/epan/wmem/wmem_scopes.c:81:5 (...) previously allocated by thread T0 here: #0 0x4e26e8 in __interceptor_malloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88 #1 0x225c588 in g_malloc (/out/fuzzshark_test+0x225c588) #2 0x20855e0 in next_tvb_add_handle /src/wireshark/epan/next_tvb.c:40:10 #3 0xef8728 in dissect_h225_ParallelH245Control_item /src/wireshark/epan/dissectors/./asn1/h225/h225.cnf:368:3 Found by oss-fuzz/5921 Change-Id: Iea006914a9e0c433d2073f6f4c7a2973d5a33a11 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5921 Reviewed-on: https://code.wireshark.org/review/25593 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=27b571e62f6a672804c6f8e7b0558c… commit 27b571e62f6a672804c6f8e7b0558ccfb589cf9b Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Mon Feb 12 10:37:00 2018 +0100 NBAP: copy address in pinfo->pool They are copied in structures using pinfo lifetime. Let's use the same scope. Bug: 14416 Change-Id: I5f8ee6fff49d63584a246936f551db1803ff9816 Reviewed-on: https://code.wireshark.org/review/25748 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ae91f43155662d857b6e4e07a67c24… commit ae91f43155662d857b6e4e07a67c244f921e0a8b Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sat Feb 10 14:06:17 2018 +0100 Extract HKDF-Expand from TLS 1.3 dissector HKDF (RFC 5869) is a standard construct used in TLS 1.3, QUIC and OSCORE, generalize it for use outside the TLS dissector. Since none of the users need the "context" (formerly "hash_value") field, remove the parameter. Change-Id: Id952de8cb3000f6f6eda844d17c78bbd3906a84d Reviewed-on: https://code.wireshark.org/review/25723 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d2016c6a1bb9a1688da684825cbda8… commit d2016c6a1bb9a1688da684825cbda889d95238a6 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Feb 11 19:49:56 2018 +0100 RPC Netlogon: do not leak memory each time a hash is generated Use copy_address_swallow() instead of copy_address(). When inserting the key in the hash map, copy it in wmem file scope. Bug: 14407 Change-Id: Ida524d314c943f480dd0e1bf44fd0ded01aafaeb Reviewed-on: https://code.wireshark.org/review/25731 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a958533c6a2bd3e971352a5bcad490… commit a958533c6a2bd3e971352a5bcad490526c34f6ea Author: Jakub Zawadzki <darkjames(a)darkjames.pl> Date: Mon Feb 12 00:08:07 2018 +0100 fuzzshark: disable protocol in fuzzer if it's used by other fuzzer. Change-Id: I4dcc38b2ac9711660c8cf27cbbabd879c2eee930 Link: https://github.com/google/oss-fuzz/issues/1087 Reviewed-on: https://code.wireshark.org/review/25738 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0bd863ae4696858b67b72bf1b0a323… commit 0bd863ae4696858b67b72bf1b0a32377877a5a38 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Feb 11 23:08:40 2018 -0500 packet-ipmi-picmg.c: Add NULL check in rq17. Crafted packets may not have ipmi_header. Bug: 14409 Change-Id: Ib6a8eceab13525c6c8dca5cef8bce3532dc50911 Reviewed-on: https://code.wireshark.org/review/25745 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba3cfb403a403647241062b933ff82… commit ba3cfb403a403647241062b933ff82808ac62a59 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Feb 11 22:53:40 2018 -0500 WCCP: Prevent very long loop in dissect_wccp2_alternate_mask_value_set_element Sanity check the total_length to make sure it doesn't go negative. Bug: 14412 Change-Id: I87e38f6c792fa81184e4c412d6433fbbf2060f28 Reviewed-on: https://code.wireshark.org/review/25744 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=620647a3e01d65fef985093cefb935… commit 620647a3e01d65fef985093cefb9352e21603261 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Feb 11 22:36:33 2018 -0500 SCCP: Use int datatype for offset to prevent infinite loops Fields are 16-bit values and large 16-bit values can be incorrectly treated as negative, causing infinite loops in offset calculations. Bug: 14413 Change-Id: I44334c3e9ced0734f4e1a70720859c0abf4a05c8 Reviewed-on: https://code.wireshark.org/review/25743 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5e8391ff900db18ccf8663918919b1… commit 5e8391ff900db18ccf8663918919b16085406874 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Feb 11 20:17:39 2018 -0500 RPKI-Router: Sanity check length field to prevent infinite loop Bug: 14414 Change-Id: I39843e8959510a0efa1add51a16e207fc63f88b1 Reviewed-on: https://code.wireshark.org/review/25742 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0c425e857aa9b0c81b38404f78b4d6… commit 0c425e857aa9b0c81b38404f78b4d613cc9167a1 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Sun Feb 11 21:38:40 2018 +0100 ceph: clear_address() to make sure to use initialized memory in set_address() oss-fuzz triggered: set_address: assertion failed: (addr_data == NULL). Valgrind confirms that ceph was passing uninitialized value to set_address() ==16301== Conditional jump or move depends on uninitialised value(s) ==16301== at 0x6C37762: set_address (address.h:78) ==16301== by 0x6C37762: copy_address_shallow (address.h:253) ==16301== by 0x6C37762: c_node_copy (packet-ceph.c:1433) ==16301== by 0x6C37F72: c_conv_data_copy (packet-ceph.c:1455) ==16301== by 0x6C37F72: c_conv_data_clone (packet-ceph.c:1464) ==16301== by 0x6C37F72: c_pkt_data_save.isra.4.part.5 (packet-ceph.c:1593) ==16301== by 0x6C40EAE: c_pkt_data_save (packet-ceph.c:1561) ==16301== by 0x6C40EAE: dissect_ceph.isra.60 (packet-ceph.c:7046) ==16301== by 0x6C4186A: dissect_ceph_heur (packet-ceph.c:7111) Found by oss-fuzz/6148. Change-Id: I8ec762d541fd8cfd919710cf460c44968707dcc5 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6148 Reviewed-on: https://code.wireshark.org/review/25736 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=32ab83436d29754479e584c9a2c6a3… commit 32ab83436d29754479e584c9a2c6a322cce794cd Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Feb 11 20:52:42 2018 +0100 SIGCOMP: use correct message length Since g2a80fe283c (2005-10-06!) length initialization was moved, and the message length is no more correct (previously tvb_length_remaining() was called with offset equal to 0, which is no more the case after the change). Bug: 14410 Change-Id: I2f00be83fa17ad7344d0d75f4a899f169d7a622b Reviewed-on: https://code.wireshark.org/review/25735 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=443921983ee20c1fa0bc7f0a44ad56… commit 443921983ee20c1fa0bc7f0a44ad56e5d19714a6 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 11 11:59:09 2018 -0800 Fix dist. Add asciidoctor-macros. Change-Id: Ib3ee30f6da69bad585028eb8f1274a052114630b Reviewed-on: https://code.wireshark.org/review/25734 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=86376e8447aef9ee182dc34b98d61b… commit 86376e8447aef9ee182dc34b98d61bb37f3bb841 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 11 11:06:04 2018 -0800 Fix ASCIIDOCTORJ_OPTS. Avoid excessive quoting. Change-Id: I0dd7593d464851bd34cfc7a5a99a21a2a826dd7a Reviewed-on: https://code.wireshark.org/review/25732 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=94a0f7c6414cb83535e89557ce3cce… commit 94a0f7c6414cb83535e89557ce3cce47a1808fec Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Oct 19 15:03:55 2017 -0700 Switch from AsciiDoc to Asciidoctor. Switch the markup text processor for files in the docbook directory from AsciiDoc to Asciidoctor. Asciidoctor has several useful features (such as direct PDF output) and is actively developed. It's written in Ruby but that dependency can be sidestepped with AsciidoctorJ, a self-contained bundle that only depends on the JRE. The current toolchain targets require Python, AsciiDoc, DocBook XML, DocBook XSL, Java, FOP, xsltproc, lynx, and the HTMLHelp compiler: HTML: AsciiDoc → DocBook XML → xsltproc + DocBook XSL Chunked HTML: AsciiDoc → DocBook XML → xsltproc + DocBook XSL PDF: AsciiDoc → DocBook XML → xsltproc + DocBook XSL → FOP HTMLHelp: AsciiDoc → DocBook XML → xsltproc + DocBook XSL → HHC This change removes the AsciiDoc and FOP requirements and adds either AsciidoctorJ or Asciidoctor + Ruby: HTML: Asciidoctor → DocBook XML → xsltproc + DocBook XSL Chunked HTML: Asciidoctor → DocBook XML → xsltproc + DocBook XSL PDF: Asciidoctor HTMLHelp: Asciidoctor → DocBook XML → xsltproc + DocBook XSL → HHC Ideally we could generate all of these using AsciidoctorJ, Java, and lynx. Unfortunately we're not there yet. The release notes depend on several macros (ws-buglink, ws-salink, cve-idlink, sort-and-group). Add Asciidoctor (Ruby) equivalents. Remove the BUILD_xxx_GUIDES CMake options and add various output targets automatically. This means that you have to build the various documentation targets explicitly. Change-Id: I31930677a656b99b1c6839bb6c33a13db951eb9a Reviewed-on: https://code.wireshark.org/review/25668 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=5a674d05c900be0007b71d11ff52e7… commit 5a674d05c900be0007b71d11ff52e7f972359b5d Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 9 12:56:58 2018 -0800 wslua: Convert more comment markup to Asciidoctor. Convert links, source code blocks, and admonitions. Change-Id: I50c8daa19a115c23f7501b91dbfd904779a609c9 Reviewed-on: https://code.wireshark.org/review/25720 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=04df34909f02013c36bc1e9ab33a52… commit 04df34909f02013c36bc1e9ab33a52b34f374f80 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Feb 11 09:09:10 2018 -0500 ModelHelperTreeItem: Rename appendChild -> prependChild The function was actually calling QList<QVariant>.prepend underneath and some users of the class may need "append" to mean "append". prepend() is faster, but current users are sorting all lists anyway. Change-Id: I65cb02f4a2d1960cc2c49034963b191156789cc9 Reviewed-on: https://code.wireshark.org/review/25730 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e438cf2e89e3336d0d882b86ffb548… commit e438cf2e89e3336d0d882b86ffb54872ec478e34 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Sat Feb 10 08:51:30 2018 -0800 ieee80211: Fix reserved bit positions 18 & 19 when HE Support not set. These were initially coded incorrectly. The problem was found by George Baltatanu and a fix supplied by him. Change-Id: I1de86ca7c5428efbcdd0fb39244a1cafbbcd32ab Reviewed-on: https://code.wireshark.org/review/25724 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fa258523a939fe68b4c8ad6d4103e6… commit fa258523a939fe68b4c8ad6d4103e6033c389087 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 11 10:27:10 2018 +0000 [Automatic update for 2018-02-11] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I1d8d8ecda65cb10240b7897399b32fb2c173003f Reviewed-on: https://code.wireshark.org/review/25727 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=991974db7f71f2441d8ba674989035… commit 991974db7f71f2441d8ba674989035fe13c184a8 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Feb 10 22:03:14 2018 +0000 dct2000: avoid allocating/storing/freeing empty string Change-Id: I06bf5ce8bf04b87dd67fb562eb149b39dd16bd76 Reviewed-on: https://code.wireshark.org/review/25726 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=aee743f9edde1f0a575d8384c54c23… commit aee743f9edde1f0a575d8384c54c23376d00865c Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Feb 10 13:26:57 2018 -0800 Write our NSIS installer to the build directory. Write our NSIS installer to ${CMAKE_BINARY_DIR}/packaging/nsis instead of ${CMAKE_SOURCE_DIR}/packaging/nsis. Change-Id: I6d662b2726dc61fb199509575797b5dfe0d8fdfa Reviewed-on: https://code.wireshark.org/review/25725 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d16308c89a4399897874ea660267f0… commit d16308c89a4399897874ea660267f0c6303872dc Author: Robert Jongbloed <robertj(a)voxlucida.com.au> Date: Tue Jan 23 10:48:57 2018 +0000 UDP: Heuristic dissector for conversation taking precedence When a single UDP port is supporting multiple protocols, for example RTP and RTCP can share a port, and one of these protocols is detected through a heuristic before a superior protocol (e.g. SIP/SDP) has established that the port has multiple protocols, then only the heuristic is used. This is due to only looking for an exact match with find_conversation() and not going any further. The superior protocol only adds the dissector by source address/port. So, to fix, if we do not find the exact match, we continue serching for a dissector on the partial matches. Bug: 14370 Change-Id: Icdded9ca1637cd594b920f979f6f0a003bef9aae Reviewed-on: https://code.wireshark.org/review/25432 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9ff64c8d7c43cc7c819e0fdce4476b… commit 9ff64c8d7c43cc7c819e0fdce4476b606e1cb28b Author: Dan Robertson <danlrobertson89(a)gmail.com> Date: Wed Feb 7 03:22:22 2018 +0000 musl: compile with musl libc Ensure that wsutil/ws_pipe.c includes <sys/select.h> as as both the timeval struct and the select function are used. Change-Id: Idbd9e9a5b9cbee9977a423c32e55be81bb6425c3 Reviewed-on: https://code.wireshark.org/review/25616 Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6176441f6157cfbd537dd2b61bab26… commit 6176441f6157cfbd537dd2b61bab269a32fcb2fa Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Thu Jan 25 09:27:44 2018 -0800 radiotap: Add support for the EOF bit in the A-MPDU Status flags. Change-Id: I80577a0082227d892426f478ffcfff23d6ba0daa Reviewed-on: https://code.wireshark.org/review/25472 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=02a3056af383f4230873d7cd1a7665… commit 02a3056af383f4230873d7cd1a76654e1ab19969 Author: Florian Bezold <florian.bezold(a)esrlabs.com> Date: Fri Feb 9 15:32:36 2018 +0100 androiddump: Fix non-blocking connect on Windows Commit 043ed1f6 enabled non-blocking connect on Windows. This seems to break androiddump on Windows completely, since a successful connection always returns SOCKET_ERROR on connect, with WSAGetLastError() set to WSAEWOULDBLOCK. Apparently, the only way to check for a real connection is to try a write select on the socket: https://stackoverflow.com/questions/35370239/timeout-in-connect-function-fr… This fixes androiddump on Windows: - If ADB server is running, extcap interfaces are listed - If ADB is not running, there is no noticeable delay in Wireshark Change-Id: I6bd772215c7b232c8fe8e840cb7ad1d54c7d8860 Reviewed-on: https://code.wireshark.org/review/25715 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bfef57ebb708445c55876b8768aad1… commit bfef57ebb708445c55876b8768aad1a0b98cd29d Author: Florian Bezold <florian.bezold(a)esrlabs.com> Date: Tue Feb 6 12:39:36 2018 +0100 androiddump: Fix and simplify tcpdump capture 1. Use "exec:" ADB command to get raw (non-PTY) tcpdump output This is also supported on Android devices before Android 7, and is a much easier approach than testing the new "shell,raw:" command and falling back if unsupported. This basically undoes commit 5ebc3277. 2. Pass "-U" to tcpdump to prevent on-target buffering Before using the "shell,raw" approach in commit 5ebc3277, I tried the "exec:" command already, but experienced extreme buffering of the tcpdump output, which is unacceptable for live trace viewing. Turns out, the buffering is determined "automatically" by libpcap: - When running in a PTY, output is flushed fast for viewing - When _not_ in a PTY, output is not flushed and thus heavily buffered. The "exec" command obviously doesn't use a PTY. Fortunately, tcpdump has a "-U" option to flush the output after each catpured packet, which is exactly what we need. 3. Ignore tcpdump stderr output Enabling "-U" caused androiddump to fail, because it happened that the tcpdump stderr logs were mixed with the stdout data. (We were probably lucky this didn't happen without -U as well). To fix this, we just ignore stderr completely by adding "2>/dev/null" to the tcpdump command. 4. Get linktype from pcap global header The stderr logs were previously parsed to get the textual linktype. This is now replaced by a simpler & less fragile approach: tcpdump prints the global pcap header, which contains precicesly the linktype info we need. 5. Parse pcap global header magic correctly for timestamps & endianness The previous code only supported the "classic" pcap header magic and might also been incorrect on big-endian host machines. Now, endian handling is simplified and we can detect the "nanosecond timestamp" magic values as well. This fixes the problem that extcap_dumper_dump expects *nano*second timestamps, but the previous code supplied *micro*seconds if on-target tcpdump outputs microseconds. 6. The parsing simplifications above allowed the main loop for tcpdump capture to be simplified considerably. Change-Id: Id66791e700a8943b86128f044f080bee60a9fa79 Reviewed-on: https://code.wireshark.org/review/25713 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=78b7da77164298343ad92de5b9dfef… commit 78b7da77164298343ad92de5b9dfef2f7d46b7d6 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 9 13:59:15 2018 -0800 CMake: Don't shadow PROCESSOR_ARCHITECTURE. PROCESSOR_ARCHITECTURE is a standard Windows environment variable. Rename the CMake variable WIRESHARK_TARGET_PROCESSOR_ARCHITECTURE. Change-Id: I03109d45d6fb5f00742cd43085a9d33d9e5ddf1f Reviewed-on: https://code.wireshark.org/review/25721 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0b649a09100813151555308d6ccdbd… commit 0b649a09100813151555308d6ccdbd18ec43accd Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 9 18:45:14 2018 -0800 Separately count all records and data records. A file might contain only metadata records, which exist only to provide information needed to interpret data records; no point in showing them in record counts. Put the counts into the structure that we fill in, and rename the structure and the routine to reflect that it determines statistics other than just times. Speak of data records rather than packets; the file might be full of Sysdig event records but not have any packets in it, for example. Change-Id: I8553181dca4129736bdae2c0cbba92becc28d6ef Reviewed-on: https://code.wireshark.org/review/25722 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9797f340747e3f47191fe6b8df2dee… commit 9797f340747e3f47191fe6b8df2dee657aa2179d Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 9 12:42:32 2018 -0800 Move the merge_action_e enum to the Win32 file dialog source file. It's only used with the Windows dialog, so no need to make it public. Change-Id: I4976748d642399b57abc89bccc26f680e3938509 Reviewed-on: https://code.wireshark.org/review/25719 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=794596d9367526a34eb9f8bdefbcc0… commit 794596d9367526a34eb9f8bdefbcc0675c07535d Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 9 12:35:33 2018 -0800 Fix indentation. Change-Id: I7f19b35032a686dfb2f776e8ff3527366b008331 Reviewed-on: https://code.wireshark.org/review/25718 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=25d90cb13c6f4296fd0c698ea8b2b6… commit 25d90cb13c6f4296fd0c698ea8b2b67766bfbc88 Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 9 11:18:22 2018 -0800 Put the preview-generation loop into a common routine. Don't have all the file open dialogs have their own copies. Change-Id: Icd6f2fd44b081575e6481a134027c90046938c64 Reviewed-on: https://code.wireshark.org/review/25717 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=be38102eea170403b66d57d3f8f01e… commit be38102eea170403b66d57d3f8f01ea4d49eaf29 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 9 10:14:34 2018 +0100 caputils/tools: more SPDX convertions. Change-Id: I44a8d1848f768acf4c3b31a68c845264c74e4bba Reviewed-on: https://code.wireshark.org/review/25709 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5a94c7d14e992590c7ca7336821b83… commit 5a94c7d14e992590c7ca7336821b8368b8559e09 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 9 10:12:31 2018 +0100 epan: more SPDX convertions. Change-Id: I3c9ba4542c50321ce60cba68696d99575a735392 Reviewed-on: https://code.wireshark.org/review/25708 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a9733b5cd536c0cd37d7be82152328… commit a9733b5cd536c0cd37d7be82152328e2a4d7c112 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 9 14:58:53 2018 +0100 tools: fix BSD license name in licensecheck.pl. Change-Id: I401efcbb4f8f9eec5ef38f3788e979a3752c4a7f Reviewed-on: https://code.wireshark.org/review/25714 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d2d1f793f81904b26d4cfc4525abe5… commit d2d1f793f81904b26d4cfc4525abe52aba18341d Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 9 09:52:20 2018 +0100 plugins: use SPDX identifiers. Change-Id: I8155573933daeb69c6e4c95c6702bdd6fc1fa89b Reviewed-on: https://code.wireshark.org/review/25707 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ff6e2fbb1bd49e0e6d1f748092eb0d… commit ff6e2fbb1bd49e0e6d1f748092eb0d3102262689 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 8 17:33:09 2018 +0100 wslua: use SPDX identifiers. Change-Id: I80d9d4e3ffc25eebf09e6ef693c378b77554e1b8 Reviewed-on: https://code.wireshark.org/review/25693 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=99e645bfdb48349c3adcbe1fe22b97… commit 99e645bfdb48349c3adcbe1fe22b97ef801c944b Author: AndersBroman <anders.broman(a)ericsson.com> Date: Fri Feb 9 10:50:12 2018 +0100 Do changes from Generalize wtap_pkthdr into a structure for packet and non-packet records for file_dlg_win32.c Change-Id: I34ce10e574036b2d857675008c7109d5e38be6e7 Reviewed-on: https://code.wireshark.org/review/25710 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=12cc2ca8f4fcc74e4de9905f2f6650… commit 12cc2ca8f4fcc74e4de9905f2f6650855abeaf0e Author: Guy Harris <guy(a)alum.mit.edu> Date: Fri Feb 9 03:04:29 2018 -0800 Update symbols lists. Change-Id: Iecdef99d172fad793fd98ae10a6f03bb425d73de Reviewed-on: https://code.wireshark.org/review/25712 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=589aa9070ae6d77a52018fc34605cf… commit 589aa9070ae6d77a52018fc34605cfe5c2e56b22 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Feb 9 09:24:40 2018 +0100 pcap: Update link_type_vals Change-Id: I7d26883344f908f86bf7b2b4beb359db014fb28b Reviewed-on: https://code.wireshark.org/review/25705 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=f73ae69ba917abd34db434b7ead03d… commit f73ae69ba917abd34db434b7ead03d4bc0e9c279 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 8 21:34:53 2018 -0800 Do the maximum block size check in pcap_read_block(). Do it before we even *try* to read the block, so that it's done in one place rather than having to be done in every routine to handle particular block types. The check was missing in the routine to read sysdig event blocks, so if we got a huge sysdig even block we'd try to allocate a huge amount of memory. Bug: 14403 Change-Id: Iff0fb0387e4499420598361be6d241f2832042d7 Reviewed-on: https://code.wireshark.org/review/25702 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=bd41b8e417e2f769ca318388a8cdcc… commit bd41b8e417e2f769ca318388a8cdccb1a5064bae Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Thu Feb 8 09:51:13 2018 +0000 RLC graph: fix zooming, both in normal case and when graph direction has been switched Change-Id: I05e02b2821367ef1a78b9ededd462324053cf06e Reviewed-on: https://code.wireshark.org/review/25683 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b5113126338b7d16b08a5b0a482b07… commit b5113126338b7d16b08a5b0a482b07e856818f33 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 8 17:21:24 2018 -0800 html2text: Skip some tags and add references. Skip the contents of <style> and <script> tags. Add URL footnotes similar to `lynx -dump`. Change-Id: I721bdfabeacc000d604aa8475f13be1d797ad0fb Reviewed-on: https://code.wireshark.org/review/25697 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=228b122dc973916b7ee53256794584… commit 228b122dc973916b7ee532567945845c50ff27fa Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 8 20:29:25 2018 -0800 Rename ft_specific_data to reflect what we're actually using it for. It's only being used as a working buffer to hold the raw options data we read in. Change-Id: I17b812e447f575ad92394b9f957658fc655cdf8e Reviewed-on: https://code.wireshark.org/review/25701 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9425d6e9014895fca1301a2d4f5689… commit 9425d6e9014895fca1301a2d4f5689cead37f1a2 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 8 18:38:22 2018 -0800 Remove redundant members from wtap_syscall_header. No need for len, and call caplen event_filelen and move it after event_len. Change-Id: I8b3825d4022ee083ee52f83f7a69f22829ed9fc4 Reviewed-on: https://code.wireshark.org/review/25698 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1f5f63f8ef98bfe9c4d734674cee0d… commit 1f5f63f8ef98bfe9c4d734674cee0df64855555d Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 8 16:19:12 2018 -0800 Generalize wtap_pkthdr into a structure for packet and non-packet records. Separate the stuff that any record could have from the stuff that only particular record types have; put the latter into a union, and put all that into a wtap_rec structure. Add some record-type checks as necessary. Change-Id: Id6b3486858f826fce4b096c59231f463e44bfaa2 Reviewed-on: https://code.wireshark.org/review/25696 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e4c5efafb7da2d25b7d47fe2dac3b1… commit e4c5efafb7da2d25b7d47fe2dac3b1556c0b67b0 Author: Dylan Ulis <daulis0(a)gmail.com> Date: Wed Feb 7 16:34:11 2018 -0500 CIP: Highlight correct bytes in Req/Rsp processing Previously, dissect_cip_generic_service_req and dissect_cip_generic_service_rsp set lengths at different levels of the packet. In some cases, this would cause a malformed packet when the data length was zero. This fixes the malformed error by explicitly setting the length, instead of using -1. The length of the service data set is not the data paylod for both cases. Previously, for requests, it attempted to highlight the whole CIP layer, but this was already covered by the full CIP protocol layer length. Change-Id: I4b4a99d30b9e04872fcf7ffb127c496e6062856c Reviewed-on: https://code.wireshark.org/review/25672 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=60c5ec67f81393d979534c47a069c1… commit 60c5ec67f81393d979534c47a069c154277e477b Author: Dylan Ulis <daulis0(a)gmail.com> Date: Wed Feb 7 08:53:45 2018 -0500 CIP Safety: Add decode options for I/O Payloads 1. Add Decode Options for 4 Safety I/O types. Previously, you could only decode as "CIP Safety", which only showed as a generic data block (because all important things for parsing are in the FwdOpen). 2. Change some timestamp display formatting to match other related timestamp fields (now all Dec) 3. Don't create connections for Null Forward Opens. Change-Id: Ia1031b3887739a864a453b9e566ebe6f29fa5b8b Reviewed-on: https://code.wireshark.org/review/25664 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=41812f2d685d6a4f6d586972db1e10… commit 41812f2d685d6a4f6d586972db1e10102e2f3021 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Feb 7 17:01:09 2018 +0100 QUIC: Add initial draft-09 support Bug:13881 Change-Id: I4127330ff6af96291452dd31086b57d24ec368ab Reviewed-on: https://code.wireshark.org/review/25687 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=55c68ee69cce06fbe1b9549e27e5ff… commit 55c68ee69cce06fbe1b9549e27e5ff524bed22fd Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 8 17:59:17 2018 +0100 epan: use SPDX indentifiers. Skipping dissectors dir for now. Change-Id: I717b66bfbc7cc81b83f8c2cbc011fcad643796aa Reviewed-on: https://code.wireshark.org/review/25694 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fc082fa2a9908a150fe6c44a63eb08… commit fc082fa2a9908a150fe6c44a63eb0852221c65f6 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 8 17:31:35 2018 +0100 wmem: use SPDX identifiers. Change-Id: Iad9a7a8a26bc6a7189a4578dfbcec1c2b3cc376e Reviewed-on: https://code.wireshark.org/review/25692 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1a9c364198e8b576dc554a904ff857… commit 1a9c364198e8b576dc554a904ff8576b83c51c36 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Feb 8 10:29:04 2018 -0800 Get rid of no-longer-used variables. They were used by the now-removed draft-07 support. Change-Id: I4762d2a6bb81e231010f1fd4b2b51278bb3c4329 Reviewed-on: https://code.wireshark.org/review/25695 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=544f7a26da096586992fee32faf499… commit 544f7a26da096586992fee32faf4991cb4fda943 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Feb 7 15:22:52 2018 +0100 QUIC: remove draft-07 support Bug: 13881 Change-Id: I6e85eb99e8f9a75772f4752657d3706402bc17fe Reviewed-on: https://code.wireshark.org/review/25686 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1d6ce5af723fc0ad6df966fd4ca99a… commit 1d6ce5af723fc0ad6df966fd4ca99a7ddbe7b4b1 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Feb 7 17:14:35 2018 +0100 QUIC: QUIC is not longer a ACRONYM of Quick UDP Internet Connection Change-Id: Ibe18191fca6495d817f6bc10ec4b5df552548396 Reviewed-on: https://code.wireshark.org/review/25690 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=16b07fa6bcaa3a3618222de9d08056… commit 16b07fa6bcaa3a3618222de9d080565e60cfeb82 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 7 13:46:48 2018 +0100 writecap: use SPDX identifiers. Change-Id: I800f8ccb516f69a15b535ee96a4b34754c008028 Reviewed-on: https://code.wireshark.org/review/25663 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ec2d31049f2236746b238cc5682081… commit ec2d31049f2236746b238cc5682081ea3151a7cf Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 7 13:20:20 2018 +0100 debian: use SPDX identifiers. Change-Id: Ib9e31d1fe917557a5e5c8bf6002afc2438c0baf4 Reviewed-on: https://code.wireshark.org/review/25662 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8cd389e16166fa4c075fbddfe69f26… commit 8cd389e16166fa4c075fbddfe69f26653a0169b3 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Feb 7 12:26:45 2018 +0100 replace SPDX identifier GPL-2.0+ with GPL-2.0-or-later. The first is deprecated, as per https://spdx.org/licenses/. Change-Id: I8e21e1d32d09b8b94b93a2dc9fbdde5ffeba6bed Reviewed-on: https://code.wireshark.org/review/25661 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bfd2dbcf25749d9f1481c479af4aab… commit bfd2dbcf25749d9f1481c479af4aab098069c303 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 8 14:36:53 2018 +0100 tools: remove garbage from licensecheck.pl. Change-Id: I9a0e00c9e033618ee2ced94dadf1a98640e0d914 Reviewed-on: https://code.wireshark.org/review/25684 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f814c40ad3d60529fd16ee43464aa4… commit f814c40ad3d60529fd16ee43464aa45b5c5bdcb8 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Feb 8 08:55:45 2018 +0100 tools: add new SPDX GPL format to licensecheck.pl. Change-Id: Ie148f8a660027df8194bd3890a108c0639a18823 Reviewed-on: https://code.wireshark.org/review/25680 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8eed71f53974a0274f901edb63e947… commit 8eed71f53974a0274f901edb63e9476c452e9eaa Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 6 16:59:40 2018 +0100 tools: remake the indentation of licencecheck.pl. Change-Id: Ib1b320e5b99e8842df61fd3dc584b6df4fc461f8 Reviewed-on: https://code.wireshark.org/review/25639 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a2265f73b58ea91c3ae13ed5b863f8… commit a2265f73b58ea91c3ae13ed5b863f844936f61d3 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 8 09:31:29 2018 +0100 packet: Whitespace cleanup Change-Id: I47d7994b5670ec6b954444b53aa9572f3ba5a047 Reviewed-on: https://code.wireshark.org/review/25682 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=a56d9ba30ebeeca4ea12d4ee5f5d45… commit a56d9ba30ebeeca4ea12d4ee5f5d45ddec2a450d Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 8 09:29:42 2018 +0100 json: Add for decode-as udp.port Change-Id: Ibd03cd64aa8de7fee8ad3cc7b7cc61e0370399ff Reviewed-on: https://code.wireshark.org/review/25681 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=58d5baf3c081b5d6aa795cd9e05d54… commit 58d5baf3c081b5d6aa795cd9e05d547927d89001 Author: Moshe Kaplan <me(a)moshekaplan.com> Date: Wed Feb 7 12:35:32 2018 -0500 Cleanup HTTP Referer tracking code and use less memory Change-Id: I7d9d8a1ab6ed9f180511281348d6b679b5fba1fb Reviewed-on: https://code.wireshark.org/review/25665 Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Reviewed-by: Moshe Kaplan <me(a)moshekaplan.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0f721985f1d8e75a7db419402436bc… commit 0f721985f1d8e75a7db419402436bcf0637b23e6 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 19:30:24 2018 -0800 Get rid of unneeded #includes. Change-Id: Ica457e3fb2a6e2318ca1e03fb7b2569c7d8e6aba Reviewed-on: https://code.wireshark.org/review/25679 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=390e80ee58cf528f6d064595693667… commit 390e80ee58cf528f6d06459569366799d449dda4 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 19:27:40 2018 -0800 Fix white space. Change-Id: I90047f070f42991a67da5215b6eda60f70d7945f Reviewed-on: https://code.wireshark.org/review/25678 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a0e76588bb9162ddccc56cd61127ce… commit a0e76588bb9162ddccc56cd61127ce009c3511cc Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 19:25:35 2018 -0800 Get rid of unused structure member. Change-Id: I86c32f18f8168d776fc5eb2116bc600a87ab57e0 Reviewed-on: https://code.wireshark.org/review/25677 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e5ac9e4cf00e2efe6872177e81f7f0… commit e5ac9e4cf00e2efe6872177e81f7f0d655c80021 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 19:15:13 2018 -0800 Get rid of a calculation whose result is not used. Change-Id: Ic481636d35953476b26be15d169f22e6db149828 Reviewed-on: https://code.wireshark.org/review/25676 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=18bbdb478e8b3ffa353810d6df19b2… commit 18bbdb478e8b3ffa353810d6df19b2b217a2c24d Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 14:51:12 2018 -0800 Distinguish between "probably not pcapng" and "probably bad pcapng" errors. Go back to having pcapng_read_block() and pcapng_read_section_header_block() treating SHB read errors that might be due to the file not being a pcapng file separately from other errors. This keeps us from treating pcapng files with malformed SHBs as not being pcapng files, making us dissect them using the pcapng file dissector rather than reporting the malformation. Change-Id: I1d92cc4ac521668b88638b2b3ed5257340451798 Ping-Bug: 14402 Reviewed-on: https://code.wireshark.org/review/25675 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=600b84f4c1f35252f8d748098b838c… commit 600b84f4c1f35252f8d748098b838c3f4ca20d09 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 14:20:12 2018 -0800 Clean up the null pointer check in profile_exists(). Check only in the if (global) case, and note that it's necessary in that case; in the !global case, note why we don't have to check for a null pointer. Change-Id: I80322204ec94eb3901f7bceabccb29351794adc8 Reviewed-on: https://code.wireshark.org/review/25674 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=62fc862bc60f2a044dcae2191aca7f… commit 62fc862bc60f2a044dcae2191aca7f6bd54f3afc Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 7 13:22:13 2018 -0800 Squelch an rc warning. Don't include glib if RC_INVOKED is defined so that the Microsoft Windows Resource Compiler doesn't generate the following complaint: \path\to\glib/gatomic.h(87): warning RC4011: identifier truncated to '__GCC_HAVE_SYNC_COMPARE_AND_SWA' Change-Id: I6637aee2842de4e7041b66ff4428f617478efcb4 Reviewed-on: https://code.wireshark.org/review/25670 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=32923b94a140ecbe39a419e71d828c… commit 32923b94a140ecbe39a419e71d828c5a1cf9bc48 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 14:07:24 2018 -0800 Don't crash if an IDB resolution value is too high. When dissecting an if_tsresol option in an IDB, calculate the resolution from the base and the offset. If the result overflows, mark it as an overflow; otherwise, mark it with the units for more values than 1 microsecond. Store the calculated resolution, which we initialize to the default of 1 microsecond. When displaying time stamps in blocks, use the calculated resolution, rather than re-calculating it. If it's 0, it means the resolution is too high, so don't calculate it and end up dividing by zero. Bug: 14402 Change-Id: Idc34ededb4f7250b3604b14d4468c32f6592793f Reviewed-on: https://code.wireshark.org/review/25673 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c0a00038246ed89bae04554b84b20a… commit c0a00038246ed89bae04554b84b20ad275b10e15 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 7 13:32:36 2018 -0800 WSDG: Remove references to Windows XP and Vista. Change-Id: Id3945f53722b7a69afa4a62eb3cfc2f8e8193d74 Reviewed-on: https://code.wireshark.org/review/25671 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=8ae0467e61cbf8a6256826ba0aac2c… commit 8ae0467e61cbf8a6256826ba0aac2cb5b8734c26 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Feb 7 11:22:56 2018 -0800 tools: Add SPDX MIT to licensecheck.pl. Add a check for "SPDX-License-Identifier: MIT". Change-Id: Id69c87e7d8d7fd3904a02f9fb410bae8e9d99d10 Reviewed-on: https://code.wireshark.org/review/25669 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=80a1dd70295ce06d55ba1b9e7b5864… commit 80a1dd70295ce06d55ba1b9e7b58647c74ae77c0 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Feb 7 18:32:50 2018 +0100 NSRPC: fix heuristic dissector Do not check reported length but captured length, otherwise it can can trigger an exception when trying to fetch at offset 4. Once the (very basic heuristic) is verified, cann the right dissection function. Bug: 14399 Change-Id: Ie09d80e04f2501c940693a2ea9ecbd2f84d1e22f Reviewed-on: https://code.wireshark.org/review/25666 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=22824478d1bdab6b8b62c8d9a43952… commit 22824478d1bdab6b8b62c8d9a43952279abf5064 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Feb 7 10:10:32 2018 +0100 wsutil: Allow NULL as profile name Using NULL as profile name indicates the Default profile and profile_exists() must not return FALSE for the Default profile. This is a regression from ge0d04a75. Change-Id: I2463a7d3e12dda794f3391d999442a303d80621c Reviewed-on: https://code.wireshark.org/review/25659 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=28960d79cca262ac6b974f339697b2… commit 28960d79cca262ac6b974f339697b299a1e28fef Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Feb 7 10:20:50 2018 +0100 netmon: Initialize struct netmonrec_comment on alloc This avoids an illegal pointer to free() on error. Bug: 14397 Change-Id: Id6e535141c7a3ee7b3d1822875b571e2199a5387 Reviewed-on: https://code.wireshark.org/review/25660 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=7ee8ead85cbde1724b672f7723eada… commit 7ee8ead85cbde1724b672f7723eadaeeebf8e4be Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 01:07:03 2018 -0800 Include as "ui/summary.h", as is done elsewhere. Change-Id: I832c74554854bf380984cab83a53e7ffe165ad84 Reviewed-on: https://code.wireshark.org/review/25658 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=40a533abe1cc7c9992a20842ef84cc… commit 40a533abe1cc7c9992a20842ef84cc75dea1dc5a Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Feb 7 00:28:59 2018 -0800 Move summary.[ch] to libui. Change-Id: I49f1eeb4fc3a90e436da116577a7d0c5ba982eee Reviewed-on: https://code.wireshark.org/review/25657 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=908e25d5aaba5496e73940709e921f… commit 908e25d5aaba5496e73940709e921f45870b849e Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:50:31 2018 +0100 caputils: use SPDX identifiers. Change-Id: I7c30002025c31a74dfa60c10ca7f7c0dd384e1c9 Reviewed-on: https://code.wireshark.org/review/25559 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=782054c2d54d5d4bc79c602ee01b5f… commit 782054c2d54d5d4bc79c602ee01b5f79a4941662 Author: Matej Tkac <matej.tkac.mt(a)gmail.com> Date: Tue Feb 6 10:45:55 2018 +0100 [PFCP] Fixed order of bytes in UP Function Features IE 3GPP TS 29.244 V14.2.0 Section 8.2.25 Change-Id: I22395d05bfcdb5dce5355c0836ffb9bbdef7a8dd Reviewed-on: https://code.wireshark.org/review/25631 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cd8c73a35591d409b3efaba6485844… commit cd8c73a35591d409b3efaba648584418bc8bb540 Author: Moshe Kaplan <me(a)moshekaplan.com> Date: Sun Jan 14 20:19:06 2018 -0500 Generate HTTP Referer statistics The main benefit of this feature is that it enables users to see the succession of HTTP requests that led to a specific request. A sample PCAP is available here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=16085 Change-Id: I7c521315b848fbce659fdc01e43f261d804a3a48 Reviewed-on: https://code.wireshark.org/review/25319 Reviewed-by: Moshe Kaplan <me(a)moshekaplan.com> Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=71844ed50a35d8bfb03e10061846f7… commit 71844ed50a35d8bfb03e10061846f726d7f9af9e Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:44:16 2018 +0100 wsutil: use SPDX identifiers. Change-Id: I4863416ddc425b9138ffa47621eee823db9e7fda Reviewed-on: https://code.wireshark.org/review/25557 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c1f37d25c3aafcf6d84e757df849ba… commit c1f37d25c3aafcf6d84e757df849bad5ea184eb6 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 6 18:08:18 2018 +0100 tools: add files from wsutil and caputils to checklicense whitelist. Change-Id: I35b6df8fbb31c209e7e79d5c002568d5194f3485 Reviewed-on: https://code.wireshark.org/review/25641 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0fdbc5e2474c4f857cf8503c2ca7fa… commit 0fdbc5e2474c4f857cf8503c2ca7fa7e837f4a98 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Feb 6 23:28:06 2018 +0100 LPPe: use V1_0-20160714-C specification Bug: 14361 Change-Id: I845e732100d866913bd17742dc18593938baac4a Reviewed-on: https://code.wireshark.org/review/25646 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c4a6016be24b922c1f7399134acd2a… commit c4a6016be24b922c1f7399134acd2a6d4908be2a Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Feb 6 10:35:02 2018 -0500 tools: add licenses to licensecheck.pl. Include the following licenses in licensecheck.pl 1. LGPL-2.0-or-later 2. Zlib 3. BSD-3-Clause Change-Id: I65f0ca1f957ee072ed595ab56d20ec200bd7047e Reviewed-on: https://code.wireshark.org/review/25638 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9beab2d89f624389643a38a9a5af91… commit 9beab2d89f624389643a38a9a5af9104209fc833 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Feb 6 19:56:49 2018 -0800 ieee1905: Fix the handling of AP Metric Queries. They changed when the spec was updated. This seems to be the last change needed here. Change-Id: Id47c1de5b5890bffa0842c33ae02033ddf6c8325 Reviewed-on: https://code.wireshark.org/review/25656 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b13678fd3703607953fc4627461d06… commit b13678fd3703607953fc4627461d069314f7e990 Author: Moshe Kaplan <me(a)moshekaplan.com> Date: Mon Feb 5 23:31:58 2018 -0500 Added wmem_map_contains and wmem_map_lookup_extended Change-Id: I2943c67238fb913258f0f1f15df968c17b1ea002 Reviewed-on: https://code.wireshark.org/review/25626 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=32ce1fd3ddd4b9d218302c699c9514… commit 32ce1fd3ddd4b9d218302c699c9514045f9a4bf5 Author: Michael Mann <mmann78(a)netscape.net> Date: Tue Feb 6 22:28:22 2018 -0500 Remove range_foreach_r from debian symbols Change-Id: I209fde24ca421b8e2dfd982408b4610bc5e63d82 Reviewed-on: https://code.wireshark.org/review/25655 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f4f44caa3525bb382f903f3abda387… commit f4f44caa3525bb382f903f3abda387ccc0cad806 Author: Michael Mann <mmann78(a)netscape.net> Date: Tue Feb 6 21:36:05 2018 -0500 FCP: Add NULL check to prevent crash. Fragmented FCP may not be called on the first pass, so add a NULL check for proto_data that may not be there. Bug: 14374 Change-Id: Icbbee8f0eb3a33655323283dbb5a01c350d784dc Reviewed-on: https://code.wireshark.org/review/25649 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f29bafff465a072bb9c819598b1d90… commit f29bafff465a072bb9c819598b1d900f50fea59c Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 6 19:09:44 2018 -0800 Don't assume all packets have time stamps. We explicitly allow the not to, and, for example, Simple Packet Blocks in pcapng files don't have time stamps. Change-Id: If1db5747c9e06faa7550162df8e04dc60b71d954 Reviewed-on: https://code.wireshark.org/review/25650 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=fa76cd57ff169510e59836b5e71844… commit fa76cd57ff169510e59836b5e71844832c3fda3e Author: Justin Dailey <justin(a)mti-systems.com> Date: Tue Feb 6 11:28:51 2018 -0500 Reapply "Fix typo in DTN dissector" Sgement -> Segment Change-Id: Ibf4aa2db14fd87c854a65da0de979ad4772243d8 Reviewed-on: https://code.wireshark.org/review/25640 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Reviewed-on: https://code.wireshark.org/review/25648 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c061522765a5553c25f51792d0dc3e… commit c061522765a5553c25f51792d0dc3ede45e9abe9 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 6 15:52:09 2018 -0800 2.5.0 → 2.5.1. Change-Id: I185a3f359acfe5dfd06c0b7f5fff3b6586be1ff9 Reviewed-on: https://code.wireshark.org/review/25647 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=59e4311fadead99523eef7a4454f86… commit 59e4311fadead99523eef7a4454f86d5e02fd517 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 6 20:55:20 2018 +0000 Temporarily revert "Fix typo in DTN dissector" This will be restored after the 2.5.0 release is complete. This reverts commit 61cc7691691c5f8bd2e11b2caffe52cd8e14aab2. Change-Id: I0b7d2435fe010070aaced5f395c75a1cd65b3f83 Reviewed-on: https://code.wireshark.org/review/25645 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=61cc7691691c5f8bd2e11b2caffe52… commit 61cc7691691c5f8bd2e11b2caffe52cd8e14aab2 Author: Justin Dailey <justin(a)mti-systems.com> Date: Tue Feb 6 11:28:51 2018 -0500 Fix typo in DTN dissector Sgement -> Segment Change-Id: I275495fafdf76308ca36083256d6fcd2bed35203 Reviewed-on: https://code.wireshark.org/review/25640 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5df9b1d5d7ef35b529d5a7d4f21cee… commit 5df9b1d5d7ef35b529d5a7d4f21cee50683a8240 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Feb 6 12:35:21 2018 -0800 Build 2.5.0. Change-Id: I8be543c87d289b616b92ab178458382c93580f12 Reviewed-on: https://code.wireshark.org/review/25644 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=cb1a6528f968c3cd97660217abc1a6… commit cb1a6528f968c3cd97660217abc1a6725ff5ba92 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 6 12:35:11 2018 -0800 Get rid of the pkt_encap field in struct packet_info. pinfo->pkt_encap is jsut a copy of pinfo->phdr->pkt_encap; no need for the copy. Expand a comment while we're at it. Change-Id: I5fcfe694ecba42507f1d629d01440da0a0989501 Reviewed-on: https://code.wireshark.org/review/25643 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6db88da7f7ffd7f75bb2e06e269bd2… commit 6db88da7f7ffd7f75bb2e06e269bd28537f10ac1 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 6 12:03:58 2018 -0800 Change the way we infer the type of the physical address. Use the address type of the link-layer source address, rather than the encapsulation of the outermost packet layer, to determine the type of the physical client address in a Dead Station frame. That should, for example, handle cases where the actual Ethernet packets are being carried within packets on some non-Ethernet network, or where the packets aren't Ethernet packets but are packets on some other network using MAC-48 addresses. Change-Id: Ibd2e2322b03e81aa52c71b080f3c91d2f83fc3b4 Reviewed-on: https://code.wireshark.org/review/25642 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7e76e5f2c865fa868b551fb974f71d… commit 7e76e5f2c865fa868b551fb974f71dade1972383 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 5 14:28:10 2018 -0800 Make sure we pass valid addresses to find_conversation. Pass empty (AT_NONE) addresses to find_conversation and conversation_create_endpoint instead of NULL, similar to the LBTxx and other dissectors. Bug: 14394 Change-Id: Ia4573b276551a9c3d2da155faf786e8d15229100 Reviewed-on: https://code.wireshark.org/review/25620 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=395016356cca7f9c162ac974c3b889… commit 395016356cca7f9c162ac974c3b889461965a5ba Author: AndersBroman <anders.broman(a)ericsson.com> Date: Tue Feb 6 14:54:01 2018 +0100 [SBC-AP] Enhance info column information. Change-Id: If02d2b1dcda5df8a09b3689b2ba3dc5914db3420 Reviewed-on: https://code.wireshark.org/review/25635 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e6c0f03a42a3dda02066537c481e96… commit e6c0f03a42a3dda02066537c481e96eed98fd486 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Feb 4 21:49:29 2018 +0100 about_dialog (qt): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ib7c673980909551d9f817d60bbe2d77ed180b661 Reviewed-on: https://code.wireshark.org/review/25599 Reviewed-by: Roland Knall <rknall(a)gmail.com> Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=64c32c672c938b4a412fcb81d8e184… commit 64c32c672c938b4a412fcb81d8e18447acf3cb3c Author: AndersBroman <anders.broman(a)ericsson.com> Date: Tue Feb 6 14:21:23 2018 +0100 [Thrift] Handle optional elememts in struct. Change-Id: Iee494c299f8f10588146f0b41b759ce0272d9caf Reviewed-on: https://code.wireshark.org/review/25634 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=41b571f9bdef6ea310fde062634245… commit 41b571f9bdef6ea310fde062634245d3f48de8ea Author: AndersBroman <anders.broman(a)ericsson.com> Date: Tue Feb 6 10:40:46 2018 +0100 [Thrift] Add methods for the 64bit types. Change-Id: I4a3ca0eb715562c9ed535df471edb62830215369 Reviewed-on: https://code.wireshark.org/review/25630 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3eb8784140dd6f3dfdf4865caa338f… commit 3eb8784140dd6f3dfdf4865caa338f7434141620 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 6 00:32:38 2018 -0800 Use the Wayback Machine for a reference. Change-Id: I4745cdf6ba863674525851e98c8a52422d4e65f0 Reviewed-on: https://code.wireshark.org/review/25628 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ea7a5bd02ca43d738c33b6f7dcf60d… commit ea7a5bd02ca43d738c33b6f7dcf60db5f5e2e163 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Feb 6 00:15:44 2018 -0800 Use separate dissectors for LAPD and LAPD-with-Linux-SLL-header. That obviates the need to check pinfo->pkt_encap. Change-Id: I038e065932282ce9d3362fbc9ba6ea653a63f399 Reviewed-on: https://code.wireshark.org/review/25627 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3ec83384977a6711e6c43906bf6118… commit 3ec83384977a6711e6c43906bf6118187be0bdde Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 5 15:34:41 2018 -0800 BACapp: Fix a loop check. Fix an offset check in a nested loop. Make our offset checks more paranoid. Bug: 14387 Change-Id: I2890b27731ec293a3cb08dcfdf7a18aef808ad31 Reviewed-on: https://code.wireshark.org/review/25622 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dcfc57486de36a0cbef9b102b24011… commit dcfc57486de36a0cbef9b102b24011230b62f5cb Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 5 15:24:19 2018 -0800 IPMI: Add NULL pointer checks. Check for a valid data->curr_frame in ipmi_set_data and ipmi_get_data. Bug: 14393 Change-Id: I615975015da864718dbd486d875aa3020db94edd Reviewed-on: https://code.wireshark.org/review/25621 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ab202adb0ae95de3d63b7ba43a0621… commit ab202adb0ae95de3d63b7ba43a062133f38ee299 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 5 16:48:13 2018 -0800 Proto tree: Update left arrow navigation behavior. If the user presses the left arrow when a non-expaned proto tree item is selected, jump to its parent item as described in the "Main Window Navigation" section of the User's Guide.. Change-Id: Ie7478a2c292df9a225555f5539d7ba90ab5e132d Reviewed-on: https://code.wireshark.org/review/25623 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8ab3060aace7b20c2845f2f725d4f3… commit 8ab3060aace7b20c2845f2f725d4f306cca61dd4 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Mon Feb 5 22:35:10 2018 +0100 Thrift: stop dissection when encountering an unknown/unexpected type Let's add an expert info, and set offset to the end of the current tvb. Bug: 14379 Change-Id: Iaccf862c451eef58aaed11b26fceebf26bc2c818 Reviewed-on: https://code.wireshark.org/review/25619 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5fcf5b9cc37160ef071206d8cf0ec8… commit 5fcf5b9cc37160ef071206d8cf0ec84a5c1a2205 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 5 20:24:33 2018 -0800 Don't assume all packets have time stamps. We explicitly allow the not to, and, for example, Simple Packet Blocks in pcapng files don't have time stamps. Change-Id: I6c8921cf092de7831d0a3d6dab8467388f4e6286 Reviewed-on: https://code.wireshark.org/review/25625 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1bed07558c6de2d8311c91b2735dd4… commit 1bed07558c6de2d8311c91b2735dd4da48e8a697 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 5 16:57:28 2018 -0800 WSUG: Minor edits. Use "or" instead of a comma for alternate keyboard shortcuts. Change-Id: I3f2abf63b4c437ca0fe439d91dfac44e24d9d8e5 Reviewed-on: https://code.wireshark.org/review/25624 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d4e974553f425f7adf6109a47f4591… commit d4e974553f425f7adf6109a47f4591d2c3a5e284 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 5 13:26:40 2018 -0800 Don't assume records all have time stamps and captured lengths. Not all do, so test the preference bits for them. Change-Id: I62976f5d17de3611c4d2f9eb64a0763c0b698c8d Reviewed-on: https://code.wireshark.org/review/25618 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4f9f1011db084c6d1e7ed381909cd7… commit 4f9f1011db084c6d1e7ed381909cd7d6c6a4b556 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Feb 5 12:55:00 2018 -0800 Speak of records, not packets. Not everything wtap_read() returns is a packet. Change-Id: I3784bbfa308da52f4c55db2a90f9b55f8bfbb2ef Reviewed-on: https://code.wireshark.org/review/25617 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=746511d5ba415fb6e90bed31e4a5a5… commit 746511d5ba415fb6e90bed31e4a5a5ff67e61c66 Author: Robert Grange <robionekenobi(a)bluewin.ch> Date: Mon Feb 5 00:09:47 2018 +0100 packet-mq: Fix a wrong offset+Add value in val_str fixed an offset error for mqmo in gmo Added value in comment when defining val_str Change-Id: Ie29f65f96d2ffb96c0cc0623346432f1f8380168 Reviewed-on: https://code.wireshark.org/review/25604 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0420088e9f5100852e51c0d1df9ad4… commit 0420088e9f5100852e51c0d1df9ad4be825b7fba Author: Jim Walker <jim(a)couchbase.com> Date: Mon Feb 5 09:30:43 2018 +0000 Update couchbase dissector with collections and delete_time DCP Add support for collection commands * SET/GET manifest * DCP changes (mutation/deletion/system_event) Add support for DCP delete_time, a new format for DCP deletion Change-Id: Iec2000a40da37dcb1edf665a157dc7ab30d4c9d0 Reviewed-on: https://code.wireshark.org/review/25612 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e4a6383cafa83c025bdffe1f29795d… commit e4a6383cafa83c025bdffe1f29795d9a3d6fd028 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Mon Feb 5 16:53:23 2018 +0100 Amend the comment with some background for the workaround. The added comment only explains what the cause of the problem is, and the subsequent workaround, without going into how this could be properly addressed. Add some lines to add that information. Change-Id: I74e4df0e0c4b41fe8d52d9abf2d15335d2b327d6 Reviewed-on: https://code.wireshark.org/review/25614 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4adb67fc163f1094e14083cb6183b8… commit 4adb67fc163f1094e14083cb6183b8e882a81767 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Feb 5 08:59:45 2018 -0800 AsciiDoc: Convert some comments. Convert some passthrough XML comments left over from the DocBook → AsciiDoc conversion to AsciiDoc / Asciidoctor comments. Change-Id: Iaf44bcf0b8a3a383e735b2b4394722cbbb2bdff3 Reviewed-on: https://code.wireshark.org/review/25615 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=80150df416910ceb2669e406b78b0c… commit 80150df416910ceb2669e406b78b0cfc59c9949e Author: Jim Walker <jim(a)couchbase.com> Date: Mon Feb 5 09:34:13 2018 +0000 Update couchbase dissector with new HELLO feature values Simply add missing feature values to the existing table Change-Id: Ie4b0876df1d736af1cd1171a6645df75e2eb8cf2 Reviewed-on: https://code.wireshark.org/review/25611 Reviewed-by: Dave Rigby <daver(a)couchbase.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1d999dea5c441131abfcfd8464f766… commit 1d999dea5c441131abfcfd8464f766f649f9a10f Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Feb 3 09:51:14 2018 -0800 Qt: Update recent status via a non-blocking connection. Connect our recent file status signal using a Qt::QueuedConnection instead of a Qt::BlockingQueuedConnection. As described at https://woboq.com/blog/how-qt-signals-slots-work-part3-queuedconnection.html, QueuedConnection makes a copy of the argument list while BlockingQueuedConnection passess the list directly. This fixes what appears to be a false positive reported by ThreadSanitizer. Cross-thread signals are protected by a QMutex, but qmutex_mac.cpp in the Qt5 sources uses a Mach semaphore. The ThreadSanitizer manual says it supports pthread mutexes and compiler atomic operations but doesn't mention Mach semaphores. Change-Id: Icb8a63d7d0bdfe985ab8274757043ef45ae4bcde Reviewed-on: https://code.wireshark.org/review/25576 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=90b3e725d48686b6de40bc409e94b5… commit 90b3e725d48686b6de40bc409e94b5babcb841b8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 21:07:12 2018 -0800 Delete an out-of-date comment. Change-Id: Idc86f8fbb401fd0da39ef3b5e7aff04173006b22 Reviewed-on: https://code.wireshark.org/review/25610 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b8121932e9be9d61e3dff8f608d1d4… commit b8121932e9be9d61e3dff8f608d1d438dd163f27 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 20:33:02 2018 -0800 Have block read routines indicate whether the block should be returned. Some blocks should be returned by wtap_read(), others are just processed internally. Add a Boolean flag to wtapng_block_t, have the routines that read particular block types set it appropriately, and have the read and seek-read routines check that flag rather than checking for the block types that should be returned. Pass a pointer to the wtapng_block_t to packet type plugin read routines, rather than passing it some members of the wtapng_block_t. This means that 1) for new block types, we don't have to update any tests and 2) plugin handlers for block types can indicate whether they processed the block internally and the caller shouldn't see it or 2) the block should be provided to the caller. Bug: 14388 Change-Id: Iccc2031a277f55c7fa8b4f692c776b482b792b4f Reviewed-on: https://code.wireshark.org/review/25609 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8556f65e0740af647482a6fca86371… commit 8556f65e0740af647482a6fca86371bbc498b68e Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 19:28:41 2018 -0800 pcapng_read_block() should just return a Boolean. It either returns "OK" or "fail", so we might as well make it a Boolean. While we're at it, in pcapng_open(), handle EOF/short read and "invalid file" errors when trying to read the first block differently; for the first of those, we don't need to free *err_info, and this may be a bit safer in case *err_info didn't happen to be set to NULL somewhere along the line. Change-Id: If8135624e3efb7838dceeb28e30e5c8c4b064786 Reviewed-on: https://code.wireshark.org/review/25608 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f53750ac930216b4fdbc3b16d6c8d0… commit f53750ac930216b4fdbc3b16d6c8d0b340104c17 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 19:13:06 2018 -0800 pcapng_read_section_header_block() should just return a Boolean. It either returns "OK" or "fail", so we might as well make it a Boolean, just as is the case with read routines for other block types. Update some comments while we're at it. Change-Id: I40b378d4e3c3cfb96687298b22a6f8f9f78d9240 Reviewed-on: https://code.wireshark.org/review/25607 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dabb19572d954ac9d7b0771d79bdb5… commit dabb19572d954ac9d7b0771d79bdb594fcaadcde Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 4 15:15:02 2018 -0800 More AsciiDoc → Asciidoctor updates. Switch from AsciiDoc's smart quotes markup to the quotes themselves. Use double curly quotes in place of singles. Switch from XML entities to their direct equivalents where we can. Switch from hex entities to decimal entities where we can't or it's not convenient. (Asciidoctor PDF doesn't yet handle hex entities). Change-Id: Iaf5ec33249e1c91b3d50b5d96251763243b72836 Reviewed-on: https://code.wireshark.org/review/25606 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=444cac45b2f845dc0e0baf9110b8ad… commit 444cac45b2f845dc0e0baf9110b8ad5b9bd2709d Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 15:18:23 2018 -0800 valid_but_empty_file is a Boolean, so declare it as such. If it's either going to be -1 or 1, and any value > 0 is "valid but empty", that's just a Boolean, with -1 corresponding to false and 1 corresponding to true. Make it so. Change-Id: Ib7418fe7573b5d2cd1e2ef5de601c0262c8d9de1 Reviewed-on: https://code.wireshark.org/review/25605 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a44eece9aaea9a4e6a854d7897fc0c… commit a44eece9aaea9a4e6a854d7897fc0c4cebf65084 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 15:00:55 2018 -0800 Check for read errors by checking for PCAPNG_BLOCK_ERROR. Check for "is an error" rather than "isn't OK". Change-Id: Ib8f4ac44f70d71ff44658801e01807344032dd60 Reviewed-on: https://code.wireshark.org/review/25603 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7b169cdedd93d5bc072e6582dde643… commit 7b169cdedd93d5bc072e6582dde6430457ece505 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 14:53:58 2018 -0800 Don't treat short reads as errors when checking the file type. A short read isn't a clear error when you don't have a magic number and are doing "does this look somewhat like a file of this type" test, it's probably an indication that it's *not* a file of that type. Change-Id: Iab2f32e7d169a777c50a36958eeb4e82a3809227 Reviewed-on: https://code.wireshark.org/review/25602 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=df088de18b9a2375f6797ac4c62a6d… commit df088de18b9a2375f6797ac4c62a6d29aa49d00f Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 4 11:39:56 2018 -0800 Docs: Make our AsciiDoc markup more compatible with AsciiDoctor. Start using markup that is preferred by Asciidoctor but compatible with both generators. Add a missing "cpp" attribute and set a couple of Asciidoctor-specific compatibility attributes. Change-Id: Iff4c31362e4493b97a85f46db2c39b18c336536f Reviewed-on: https://code.wireshark.org/review/25600 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=bb2680d9b45275b6c9ada4c55cb067… commit bb2680d9b45275b6c9ada4c55cb0678a8e79b95a Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Feb 4 14:16:37 2018 -0800 Don't put knowledge about the "is this pcapng" test in the block-reading code. Have pcapng_read_section_header_block(), pcapng_read_section_header_block(), and pcapng_read_block() just return errors when they get errors or get a non-SHB block; let pcap_open() turn EOF, short read, and "bad file" into "not a pcapng file" rather than "read error". Change-Id: If018d21ffe3de3fe7eb1f8f2973f80f685c89274 Reviewed-on: https://code.wireshark.org/review/25601 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d447467eb5a7b609d1594d9efacbd9… commit d447467eb5a7b609d1594d9efacbd91e4ffad50d Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Feb 4 17:31:23 2018 +0100 MQ: use real string length when calling strip_trailing_blanks() Bug: 14390 Change-Id: I5acfc651237da55c3ee907f21d89a3add6edeeef Reviewed-on: https://code.wireshark.org/review/25596 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=551f6bdd8c2fe9ab5655f403c92667… commit 551f6bdd8c2fe9ab5655f403c92667d759276a70 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sun Feb 4 16:47:21 2018 +0100 MQ: keep extended value string array sorted Change-Id: If7d6c8d75179eca213a90977657c61e9a9677474 Reviewed-on: https://code.wireshark.org/review/25595 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ad76b31c3f26ab1427920936b22ee0… commit ad76b31c3f26ab1427920936b22ee0d8fcdc8d68 Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Sun Feb 4 10:22:58 2018 +0000 Don't install test programs (fuzzshark and dftest) These binaries are not intended for end-users. Change-Id: I1e1ecd7424bbbe1b2935390e2daf7e3f1089ee28 Reviewed-on: https://code.wireshark.org/review/25594 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=3aff56076167c5ea8fbed9eba32b0f… commit 3aff56076167c5ea8fbed9eba32b0f81b6fe3aca Author: Robert Grange <robionekenobi(a)bluewin.ch> Date: Sat Feb 3 12:09:11 2018 +0100 packet-mq: Fix problem in get_mq_pdu_len Found during fuzz test that the get_mq_pdu_len can return a 0 length pdu. Fix to at least return tvb_reported_length_remaining Change-Id: I6410f71724a6288fe42a4f600e72a8af787aa7eb Reviewed-on: https://code.wireshark.org/review/25574 Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=ffc200ade3789dc4a8c8b14dfa5bbd… commit ffc200ade3789dc4a8c8b14dfa5bbd4a0754de29 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Feb 4 08:14:31 2018 +0000 [Automatic update for 2018-02-04] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I66df4a62ae7fb7c986130fec01359ebb7b00d71f Reviewed-on: https://code.wireshark.org/review/25590 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c2debddb2cd2ab8b0eff87ce37578c… commit c2debddb2cd2ab8b0eff87ce37578c1f78f6864d Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 20:10:19 2018 -0800 Don't assume address data is aligned. The data for an address is *not* guaranteed to be aligned on any particular boundary, so, for IPv4 addresses, don't assume it's aligned on a 32-bit boundary - to get it in host byte order, fetch it with pntoh32(), which fetches a 32-bit value that's in network byte order, and isn't necessarily aligned on any particular boundary, and returns it in host byte order. Change-Id: Ic512ab4b1e0f2815d9f0af0e33714f456a08a45d Reviewed-on: https://code.wireshark.org/review/25589 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=676d4668c83f8c78f35098d9c4ef88… commit 676d4668c83f8c78f35098d9c4ef8851729460fc Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 18:31:10 2018 -0800 Note that we should show ISBs in the "packet" list. Change-Id: Id39712f9926f05528e4e6120d0feba7c319b3bb2 Reviewed-on: https://code.wireshark.org/review/25588 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2385ec8776eb3d04fd29b40f7bc802… commit 2385ec8776eb3d04fd29b40f7bc8029f5390c652 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 18:23:42 2018 -0800 Give an IDB and an NRB as examples of the third type of block. There are events, there are reports, and there are "here's metadata that doesn't correspond to something that happened at this point in the capture"; IDBs and NRBs are the third type. Change-Id: I89e4f9bf51dc1be5766e8df61c6337ed3e484577 Reviewed-on: https://code.wireshark.org/review/25587 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=121abba1a237fba2c9a9377ced3ca7… commit 121abba1a237fba2c9a9377ced3ca7a47b5eef25 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 17:22:09 2018 -0800 Have individual plugin CMakeLists.txt files add library dependencies. This removes any knowledge of plugin types from cmake/modules/WiresharkPlugin.cmake, so that it doesn't have to be changed if we add a new plugin type. Revert to the second argument to add_plugin_library() and install_plugin() being the subfolder. Change-Id: I668ab90b28c73a8b12ca8e3e906b8de2f9395ca5 Reviewed-on: https://code.wireshark.org/review/25585 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ebef0b0dda3dd6aba4e81bb583b012… commit ebef0b0dda3dd6aba4e81bb583b0128a6032e451 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 17:45:43 2018 -0800 New symbols. Change-Id: I3ddb5d89a0b1e1afc5979b2e028030ff61f1ee05 Reviewed-on: https://code.wireshark.org/review/25586 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=656c42646a5b22ee4068e1b0fa6405… commit 656c42646a5b22ee4068e1b0fa6405bdd9d9d2f9 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 16:58:24 2018 -0800 Process all subdirectories of $pkgplugin as directories of plugins. That way we don't have to change the script if we add new plugin subdirectories. Change-Id: Ic788807c723306e461b7c1f8721b48a46d4fff96 Reviewed-on: https://code.wireshark.org/review/25584 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0c781eeef7a5322de2e96bb77b1029… commit 0c781eeef7a5322de2e96bb77b1029db35b4b2bc Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 16:41:13 2018 -0800 Disallow registration of some block type values for plugins. Don't allow overriding of the block types we support in libwiretap - it won't work anyway, as we check for those types first, and only look for plugins for types we don't support. Don't allow registering for any of the reserved types; if you aren't going to use a local type, you have to get your type registered. We *do* allow registering plugins for types that are registered but that we don't support natively. Change-Id: I2046d297b0503d3a77c83166b07ca226c0b18e82 Reviewed-on: https://code.wireshark.org/review/25583 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3d574a4b2b462e42d767635db9a76f… commit 3d574a4b2b462e42d767635db9a76f4c10c521c8 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Sat Feb 3 21:04:47 2018 +0100 mqtt: Put msgid and topic in Info column Change-Id: If6e149f21a9c8bd122daa6d751f72b8d8c0454ff Reviewed-on: https://code.wireshark.org/review/25578 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6fd153181402f897577aebb3943a23… commit 6fd153181402f897577aebb3943a23c2666c2864 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 13:32:50 2018 -0800 Add a comment explaining why err is volatile. And also indicate that perhaps the right solution was just to close the CID as a false positive, as Coverity doesn't have a deep enough understanding of libnl to know that the loop isn't guaranteed to be infinite. Change-Id: Ieb0651c803a5939fb54f2bc68bdf8c5485dafaf2 Reviewed-on: https://code.wireshark.org/review/25582 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ebb471f2116494f2c56124b03a5f21… commit ebb471f2116494f2c56124b03a5f21818e8cc71b Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 13:15:30 2018 -0800 Clean up addition of FT_IPv{4,6} fields. The data for an address is *not* guaranteed to be aligned on any particular boundary, so, for IPv4 addresses, don't assume it's aligned on a 32-bit boundary - copy it with memcpy() and use the result of the copy. For IPv6 addresses, cast the data pointer to a pointer to a *const* ws_in6_addr, so we don't throw away constness. Change-Id: I0e00263f594d7778c3bd9b98e4336cb201c1f3d5 Reviewed-on: https://code.wireshark.org/review/25580 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d5f52cfaf51e81db8b268da0b4c572… commit d5f52cfaf51e81db8b268da0b4c572d19b809432 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 12:25:24 2018 -0800 Don't link wiretap plugins with libwireshark. Make the second argument to add_plugin_library() and install_plugin() be a plugin type - currently, either "epan" or "wiretap" - and, based on its value, set the subfolder and required libraries in add_plugin_library() and the subfolder in install_plugin(). If it's not one of the known values, fail. Change-Id: I556863772c59330d2854fbb4673f544f8359dcd2 Reviewed-on: https://code.wireshark.org/review/25579 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d8551c42473bc345840cccc3a5ba71… commit d8551c42473bc345840cccc3a5ba710ab1649b55 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Feb 3 10:38:58 2018 -0800 Handle separate directories for libwireshark and libwiretap plugins. We now have "epan" and "wiretap" subdirectories of the plugin directory, with the first containing libwireshark plugins and the second containing libwiretap plugins. Look for plugins in those directories, rather than in the top-level plugin directory. Bug: 14389 Change-Id: Ia3bd4d27e82215207e7a7dcfc8f91042bbc61737 Reviewed-on: https://code.wireshark.org/review/25577 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2fecc9686864a7ef346220825eecbb… commit 2fecc9686864a7ef346220825eecbba1c3304987 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Sat Feb 3 13:31:58 2018 +0100 dmp: fix memleaks dmp_long_id_hash_table is wmem_map autoreset on file scope. Don't put there g_strdup() data. Valgrind log: ==15134== 8 bytes in 2 blocks are definitely lost in loss record 3,988 of 49,961 ==15134== at 0x4C29C4F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==15134== by 0xA94E405: g_malloc (gmem.c:97) ==15134== by 0xA966C4E: g_strdup (gstrfuncs.c:356) ==15134== by 0x6CFC301: dissect_mts_identifier (packet-dmp.c:2684) ==15134== by 0x6D01A8F: dissect_dmp_envelope (packet-dmp.c:2935) ==15134== by 0x6D01A8F: dissect_dmp (packet-dmp.c:3909) Found by oss-fuzz. Change-Id: I7c3896a9b64c25035fbe8b4ef6130cd693a515db Reviewed-on: https://code.wireshark.org/review/25575 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=2d8606b584025bb80c3935aa3ecc57… commit 2d8606b584025bb80c3935aa3ecc57b512c61360 Author: Dylan Ulis <daulis0(a)gmail.com> Date: Fri Feb 2 11:47:44 2018 -0500 CIP Motion: Support Format Revision 3 See Volume 9, version 1.2, sections "6-2.7.1.1" and "7-1.1" 1. Pass Connection Point from FwdOpen to Motion dissector, since that is now needed to parse I/O payload. 2. Move Run/Idle Header function to CIP dissector, since it's a CIP feature, not ENIP. 3. Add a protocol so that Format Revision 3 can be dissected without the Forward Open in the capture. 4. Minor: Highlight more bytes in some EPATH parsing. 5. Minor: Renaming some things to match spec wording. Change-Id: I93626a6492be2675206d38c04fa1c7ce534c04ca Reviewed-on: https://code.wireshark.org/review/25570 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a4bb6c2d395ac1e30e116bc2780fa1… commit a4bb6c2d395ac1e30e116bc2780fa143df2dc1ab Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Feb 2 09:37:50 2018 -0800 Make a deep copy of our filename in RecentFileStatus. QStrings are implictly shared as described at http://doc.qt.io/qt-5/implicit-sharing.html. This is normally useful, but RecentFileStatus is passed a QString before it does its work in a separate thread. Make a deep copy of the filename in order to ensure local ownership and to avoid having to fool around with a QMutex (which might not be recognized by ThreadSanitizer[1] or Helgrind[2]). Remove getFilename since it was unused. [1] https://github.com/google/sanitizers/issues/460 [2] http://valgrind.org/docs/manual/hg-manual.html Change-Id: I5b5c329505ed8c02d30043a2a6d1ded625924b9f Reviewed-on: https://code.wireshark.org/review/25572 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e3a76761861cf3baad8e9c998345be… commit e3a76761861cf3baad8e9c998345be59bc725a2b Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Fri Feb 2 18:35:38 2018 +0100 quic: fix secret memleaks. It looks like that quic_create_cleartext_decoders() need to free secrets, tls13_cipher_create() only use it as const. ASAN report: ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x4e26e8 in __interceptor_malloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88 #1 0x225b038 in g_malloc #2 0x1742014 in quic_derive_cleartext_secrets /src/wireshark/epan/dissectors/packet-quic.c:1071:10 #3 0x173e579 in quic_create_cleartext_decoders /src/wireshark/epan/dissectors/packet-quic.c:1091:10 #4 0x173dc89 in dissect_quic_long_header /src/wireshark/epan/dissectors/packet-quic.c:1221:14 #5 0x173ced6 in dissect_quic /src/wireshark/epan/dissectors/packet-quic.c:1402:18 (...) Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x4e26e8 in __interceptor_malloc /src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:88 #1 0x225b038 in g_malloc #2 0x1741fd5 in quic_derive_cleartext_secrets /src/wireshark/epan/dissectors/packet-quic.c:1065:10 #3 0x173e579 in quic_create_cleartext_decoders /src/wireshark/epan/dissectors/packet-quic.c:1091:10 #4 0x173dc89 in dissect_quic_long_header /src/wireshark/epan/dissectors/packet-quic.c:1221:14 #5 0x173ced6 in dissect_quic /src/wireshark/epan/dissectors/packet-quic.c:1402:18 (...) Found by oss-fuzz/5902. Change-Id: I6f8a4597411ee267773225e45043addb69928d66 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5902 Reviewed-on: https://code.wireshark.org/review/25571 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=f244742b46af8ec402761dee9240e2… commit f244742b46af8ec402761dee9240e25c2856cb77 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Fri Feb 2 20:44:39 2018 +0100 epl: fix map.title memleak. Valgrind report: ==642== 14 bytes in 1 blocks are definitely lost in loss record 5,705 of 49,814 ==642== by 0xA966DCC: g_strdup_vprintf (gstrfuncs.c:507) ==642== by 0xA966E88: g_strdup_printf (gstrfuncs.c:533) ==642== by 0x6D523F4: dissect_object_mapping (packet-epl.c:4216) ==642== by 0x6D56394: dissect_epl_sdo_command (packet-epl.c:3862) ==642== by 0x6D56394: dissect_epl_asnd_sdo (packet-epl.c:3572) ==642== by 0x6D59BC5: dissect_epl_asnd (packet-epl.c:3053) ==642== by 0x6D59BC5: dissect_eplpdu.part.21 (packet-epl.c:2627) Found by oss-fuzz/5907. Change-Id: I6f4d2cea761581260af396c848ab1fded5641b44 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5907 Reviewed-on: https://code.wireshark.org/review/25573 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d8565d8f1b8bf9653e0ff8847b7276… commit d8565d8f1b8bf9653e0ff8847b72765861eff5c2 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Feb 2 15:59:04 2018 +0100 Qt: Keep auto-scroll when starting a new capture Avoid turning off actionGoAutoScroll when going to the first packet when starting a new capture. Bug: 14257 Change-Id: I676139696cf4917b779c5fd390d7a22fb373a6b5 Reviewed-on: https://code.wireshark.org/review/25568 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=5cb7a729d3a33fe219317f61e7da41… commit 5cb7a729d3a33fe219317f61e7da41d46a836153 Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Fri Feb 2 12:30:19 2018 +0000 Increase PROTO_PRE_ALLOC_HF_FIELDS_MEM We've added more fields, increment the pre-allocation amount. Change-Id: Ia5f1aab7a2fa120049162d17a63f99bf21a3fe37 Reviewed-on: https://code.wireshark.org/review/25566 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8604242e8f84a2526bca13e9c8571f… commit 8604242e8f84a2526bca13e9c8571f3b5fc2e766 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Feb 2 13:58:44 2018 +0100 Qt: Avoid divide-by-zero if missing AUTHORS file When debugging with at least Xcode the AUTHORS file is missing, so ensure we don't divide by zero when this happens. Change-Id: Idd7cdf8137998c872f80108662fbb8a133110af2 Reviewed-on: https://code.wireshark.org/review/25567 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=819b8174a909db13a36637ede5835e… commit 819b8174a909db13a36637ede5835e29aa2efe8f Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 12:00:51 2018 +0100 cli: use SPDX identifiers. Change-Id: I7ce9b2a32f4ddad93ca1d9697c2a76b067f9e5f7 Reviewed-on: https://code.wireshark.org/review/25564 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d93db54dc0dcdbf4931e3b491de623… commit d93db54dc0dcdbf4931e3b491de6232f844f8629 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:45:42 2018 +0100 capchild: use SPDX identifiers. Change-Id: I123e043c3266993081f9bff404da5d7db76ee68e Reviewed-on: https://code.wireshark.org/review/25558 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e52172c775dd057eec74b659a2403a… commit e52172c775dd057eec74b659a2403a04d7ac3e9d Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:57:21 2018 +0100 Qt: use SPDX identifiers. Change-Id: I111945c08f99818c249a868c12d9a7b3a3df64b3 Reviewed-on: https://code.wireshark.org/review/25563 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e5f4ef0c42219e45498dd8a418464a… commit e5f4ef0c42219e45498dd8a418464ab5d5263d22 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 12:06:07 2018 +0100 ui: use SPDX identifiers. Change-Id: I6b05399395bcc35e59b73b4030ba4a05711a7b1a Reviewed-on: https://code.wireshark.org/review/25565 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d9368545f40e2b1b309976a8ed7204… commit d9368545f40e2b1b309976a8ed720437d7ea69fa Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:54:24 2018 +0100 fuzzshark: use SPDX identifier. Change-Id: I9c786b8bbb96a4bfa1560536c3929b844aa8afb7 Reviewed-on: https://code.wireshark.org/review/25562 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=45e7297c3ae900a8149d4b7ad27aa4… commit 45e7297c3ae900a8149d4b7ad27aa43e4b53640f Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:53:50 2018 +0100 randpkt_core: use SPDX identifiers. Change-Id: I3b8bb17c0c679533cc5281aaf18881e859fe7cf6 Reviewed-on: https://code.wireshark.org/review/25561 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=016e407702a7b0e308d4beb9aff8cd… commit 016e407702a7b0e308d4beb9aff8cdd4e9291806 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Feb 2 11:52:41 2018 +0100 codex: use SPDX identifiers. Change-Id: I02f43e660484e9c0ebce96b42dbdd7b4229a1198 Reviewed-on: https://code.wireshark.org/review/25560 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c55974facc30d1bc6a07599bb17a27… commit c55974facc30d1bc6a07599bb17a27fa1399afdc Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Feb 2 09:40:43 2018 +0100 Qt: Add a missing HAVE_LUA guard Change-Id: I0ee67e769c2c9030da1844a6631dac9a494d0f06 Reviewed-on: https://code.wireshark.org/review/25556 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6c13f7070c138ca4a21eea6e71af07… commit 6c13f7070c138ca4a21eea6e71af072c009d57e1 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Jan 22 09:42:09 2018 +0100 Qt: add initializers in PacketDialog() (CID: 1427679). Change-Id: Id2f16d849b85275308101f49a5ea22fbddf66f3b Reviewed-on: https://code.wireshark.org/review/25411 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bec60fa461dc2f225929cbcec33308… commit bec60fa461dc2f225929cbcec33308b430f55a08 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 14:40:06 2018 +0100 packet-mq: Add support for IMS+TM Struct Added support for IMS, TM, TMC2 Struct Improve display some Flags in ID Struct Fix display for FCNO Struct Fix error in get_mq_pdu_len Code reformat (VS2017) Moved DEFINE to header file More struct display fixed Fix for IMS Msg len display Change-Id: I80bfd25a5079598fc44124dc2c7b850640a38b00 Reviewed-on: https://code.wireshark.org/review/25295 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0fda778b45bc2d6977a87404bc3fac… commit 0fda778b45bc2d6977a87404bc3fac5c30826b8a Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 1 15:06:23 2018 +0100 Qt: Fix splash screen "Registering dissectors" message Adjust splash screen message used for registering dissectors when finished fast from "Registering dissectors Registration finished" to "Registering dissectors finished". Change-Id: Id81cf08bb02bea0baa3ac0575b487e271641e27d Reviewed-on: https://code.wireshark.org/review/25546 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dc86a285c1c7c23309728d587c3aae… commit dc86a285c1c7c23309728d587c3aaeeef3db6238 Author: Michael Mann <mmann78(a)netscape.net> Date: Thu Feb 1 19:51:36 2018 -0500 SoupBinTCP: Remove try_conversation_dissector call As stated in the #if 0ed out comments, It's not valid for a soupbintcp subdissector to call conversation_set_dissector(), so it shouldn't call try_conversation_dissector. Just remove the call entirely so it doesn't look like the removal is temporary. Change-Id: I68d9b72360b52002692c369d7b202a8a215c0a96 Reviewed-on: https://code.wireshark.org/review/25555 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8bf837eddc0ab120ad16273b773fa6… commit 8bf837eddc0ab120ad16273b773fa6cd8ec5c9f4 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 1 20:38:04 2018 +0100 Qt: Always update splash screen on action change On a "fast" computer this is needed to find any action which is taking long time during startup. Without this the splash screen may show a random action message happening before the slow action. Also optimize splashUpdate() when nothing to update. Change-Id: I0946353dbcf12e78323361f2cb4410c6c5605d76 Reviewed-on: https://code.wireshark.org/review/25552 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=6adc7550a800142a82cc66da3cc4b3… commit 6adc7550a800142a82cc66da3cc4b305f6a985fc Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Feb 1 15:16:10 2018 -0800 Note that /guard:cf requires CMake 3.9 or newer. Change-Id: I775daafdba012deb2eac5cf8d895be55243d9440 Reviewed-on: https://code.wireshark.org/review/25554 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=4a417149d42517037ee7a6c8aebc7b… commit 4a417149d42517037ee7a6c8aebc7b792f00260f Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Thu Feb 1 23:48:29 2018 +0100 Fix memleak in color_filters_read_globals() Valgrind log: ==6102== Thread 1: ==6102== 32 bytes in 1 blocks are definitely lost in loss record 24,851 of 49,782 ==6102== at 0x4C29C4F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==6102== by 0xB17B7F7: __vasprintf_chk (vasprintf_chk.c:80) ==6102== by 0xA98C2AB: vasprintf (stdio2.h:210) ==6102== by 0xA98C2AB: g_vasprintf (gprintf.c:316) ==6102== by 0xA966DCC: g_strdup_vprintf (gstrfuncs.c:507) ==6102== by 0xA966E88: g_strdup_printf (gstrfuncs.c:533) ==6102== by 0x6A66B8C: color_filters_read_globals (color_filters.c:704) ==6102== by 0x6A66FBE: color_filters_get (color_filters.c:317) ==6102== by 0x402313: fuzz_init (fuzzshark.c:237) ==6102== by 0x40252D: LLVMFuzzerInitialize (fuzzshark.c:322) ==6102== by 0x401E33: main (StandaloneFuzzTargetMain.c:125) Change-Id: Ibc18edff6097eca736328810c903a151ddee22bc Reviewed-on: https://code.wireshark.org/review/25553 Tested-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=5c511d23e36b098c93ed1b3070a445… commit 5c511d23e36b098c93ed1b3070a445c8e16185d2 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Feb 1 17:31:23 2018 +0100 RTP: ensure that bta2dp_info and btvdp_info are always initialized Bug: 14380 Change-Id: Ib691b067f25d7281be2f6b4387552252d16d0064 Reviewed-on: https://code.wireshark.org/review/25550 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d7be8465b9defa2a54946892dbc389… commit d7be8465b9defa2a54946892dbc389d222ad2d1f Author: Lazar Sumar <bugzilla(a)lazar.co.nz> Date: Thu Feb 1 16:17:04 2018 +0000 Fix endianness of CAN-ETH CAN packet The CAN-ETH protocol explicitly states that the CAN identifiers are transmitted in little-endian order, and the dissector now decodes it as little-endian rather than host-endian. Change-Id: I92c44b809caace31726e0d355363355eb32efa3e Reviewed-on: https://code.wireshark.org/review/25549 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=142c03516ec93948ad30191730ace0… commit 142c03516ec93948ad30191730ace09baa57aa8d Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 31 12:03:49 2018 -0800 Qt: Show Lua scripts as links in the about box. Add UrlLinkDelegate::setColCheck, which lets you render strings as URLs or plain text according to a regex. Use it to show Lua scripts as URLs in the about box. Open links on double clicks and add column checks. Change-Id: Iaf5cd8a46a0b66a7d45079ba045ed2bbcb0ed005 Reviewed-on: https://code.wireshark.org/review/25542 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=d1b1575f6d1e0f922aead77b2933f9… commit d1b1575f6d1e0f922aead77b2933f9be55d1107b Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Thu Feb 1 18:32:31 2018 +0100 oss-fuzzshark: try to fix oss-fuzz assert fails. Change-Id: Ic4ff70dfc55b2694f761cdadcac1962242fca753 Reviewed-on: https://code.wireshark.org/review/25551 Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=d25e7885e6652525525a81d2b876d2… commit d25e7885e6652525525a81d2b876d2998ed0daf0 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 1 15:09:22 2018 +0100 base64: Adjust whitespace for readability Change-Id: Ibf72dddceac925521a0fec3ab0bed7ed360e7c06 Reviewed-on: https://code.wireshark.org/review/25547 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3f93c6e7996a12cdb50c37e73a6628… commit 3f93c6e7996a12cdb50c37e73a662863061697a2 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Feb 1 15:11:08 2018 +0100 json: Adjust whitespace Change-Id: Ifa10ca415d291ab6b0cb06c475ac8697b5fc96da Reviewed-on: https://code.wireshark.org/review/25548 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d4b5943ba895c2d96c360ef6f1785f… commit d4b5943ba895c2d96c360ef6f1785f1940592ea3 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 31 13:45:22 2018 -0800 Qt: Always show the Plugins tab in the about box. Always show the Plugins tab. We probably have plugins via extcap even if Lua and dissector plugins are disabled. Tell the user if we don't find any plugins. Change-Id: I7ab1fb302298232a847193754b53688620855959 Reviewed-on: https://code.wireshark.org/review/25543 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c84b0aeead7cfaf595b546b99ff8bb… commit c84b0aeead7cfaf595b546b99ff8bb73f73c8fc5 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 31 11:26:18 2018 -0800 Qt: More byte view and proto tree fixes. 47e1798762 broke byte view highlighting when selecting a proto tree item. Switch back to emitting fieldSelected from selectionChanged. Force a new selection in selectedFieldChanged, which does what we were trying to do in 47e1798762. Clear our marked byte offset in the byte view when we mark a field. Emit byteSelected whenever we click the mouse. Don't highlight anything when a tree item is deselected. Deselect a tree item if we click on something that's not a byte in the byte view. Change-Id: Ibf419ccb005d69f733b2fe12ce674e1fe504bb96 Reviewed-on: https://code.wireshark.org/review/25541 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d3e50fedf744a7fbef9535c750f0ea… commit d3e50fedf744a7fbef9535c750f0eafe5f6f83b7 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 30 17:39:03 2018 +0100 buffer: add g_assert to all functions. This pacify clang warnings as well. Change-Id: I5d61a82bfc43b93281f0d0caabcb7109c849788b Reviewed-on: https://code.wireshark.org/review/25518 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dd3b82ebc87bee5bb61d64d1a14173… commit dd3b82ebc87bee5bb61d64d1a1417364e013a505 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Thu Feb 1 08:07:00 2018 +0100 oss-fuzzshark: test code to debug some oss-fuzz assert fails. Change-Id: I5dbe899ca8a4f9107d62667ca107a4d3a48fe51b Reviewed-on: https://code.wireshark.org/review/25545 Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=40f0f6885f5d14e5e66f5f3237a000… commit 40f0f6885f5d14e5e66f5f3237a0001612f781b5 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 31 15:32:29 2018 +0100 TDS: ensure to always initialize tds_encoding_char even when protocol is unknown Otherwise we use an uninitialized variable Bug: 14372 Change-Id: Idacdb40569421f7e41e181c14fb2bc033b0645b8 Reviewed-on: https://code.wireshark.org/review/25529 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0c7bbc75364ce21e6e911c93da748a… commit 0c7bbc75364ce21e6e911c93da748abf854999b1 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 31 09:31:47 2018 -0800 Qt: Avoid a potentially large memdup. Use QByteArray::fromRawData + tvb_get_ptr to create our ByteViewText data instead of tvb_memdup. If our tvb lifetime is shorter than our ByteViewText lifetime then that's a bug. Change-Id: Iede275578a1493b8658308e0778f7f0799d6c6cd Reviewed-on: https://code.wireshark.org/review/25534 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b14e32cc77ded4a4db6f9cc6e207ce… commit b14e32cc77ded4a4db6f9cc6e207ce39f55637e9 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Mon Jan 15 11:15:04 2018 +0100 New dissector Session Multiplex Protocol SMP Adding Session Multiplex Protocol SMP SMP is used by TDS when MARS in enabled. Bug: 14110 Change-Id: Ia4113c627d107da6c3d51e4004265efb228a297b Reviewed-on: https://code.wireshark.org/review/25509 Reviewed-by: Craig Jackson <cejackson51(a)gmail.com> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=66af843eb502a16a2428e899b44939… commit 66af843eb502a16a2428e899b44939cfe3925863 Author: Jakub Zawadzki <darkjames(a)darkjames.pl> Date: Thu Feb 1 02:25:24 2018 +0100 bacapp: make sure to NUL terminate bf_arr. bf_arr is used as %s argument to proto_tree_add_subtree_format(), so it need to be NUL terminated. Add + 1 to bf_arr size, and use sizeof() in memset() calls. ASAN report: ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ff1b179f150 at pc 0x00000044cf31 bp 0x7ffdc7493cf0 sp 0x7ffdc74934a0 READ of size 258 at 0x7ff1b179f150 thread T0 SCARINESS: 41 (multi-byte-read-stack-buffer-overflow) #0 0x44cf30 in printf_common(void*, char const*, __va_list_tag*) /src/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_format.inc:548 #1 0x498cfc in __vsnprintf_chk /src/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc:1558 #2 0x5775cf in proto_tree_set_representation /src/wireshark/epan/proto.c:5508:9 #3 0x577eb1 in proto_tree_add_text_valist_internal /src/wireshark/epan/proto.c:1226:2 #4 0x5782d5 in proto_tree_add_subtree_format /src/wireshark/epan/proto.c:1249:7 #5 0x73c73f in fBitStringTagVS /src/wireshark/epan/dissectors/packet-bacapp.c:7490:15 #6 0x73ad20 in fApplicationTypesEnumeratedSplit /src/wireshark/epan/dissectors/packet-bacapp.c:7569:26 #7 0x73a484 in fApplicationTypes /src/wireshark/epan/dissectors/packet-bacapp.c:7635:12 #8 0x7395db in fIAmRequest /src/wireshark/epan/dissectors/packet-bacapp.c:13412:14 #9 0x7383e1 in dissect_bacapp /src/wireshark/epan/dissectors/packet-bacapp.c:14163:9 Found by oss-fuzz/5452. Change-Id: I57e948904f707c5003a389431b009a37c1212e04 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5452 Reviewed-on: https://code.wireshark.org/review/25544 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=85fed81b6360078127a1f3fbd6b3c7… commit 85fed81b6360078127a1f3fbd6b3c7e6ae005c04 Author: Adrian Granados <adrian(a)adriangranados.com> Date: Wed Jan 31 09:43:57 2018 -0500 ieee80211: various fixes to the 802.11ax support. Fixes/improves a few filter identifiers, typos, consistent use of MHz (as opposed to Mhz), and fixes to the MCS map trees in the HE Capabilities tag. Change-Id: I5c761990237ccc241d95fb0b9b2d3f8f1263b460 Reviewed-on: https://code.wireshark.org/review/25530 Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot http://cgit.osmocom.org/wireshark/commit/?id=8398488b8cb52518d4ad6271cc95e5… commit 8398488b8cb52518d4ad6271cc95e56e8513fa55 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 31 15:59:16 2018 +0100 IAX2: always initialize src_vformat and dst_vformat Bug: 14371 Change-Id: Icc027151fafd6db6ef8be18c9fc2ccf39518907f Reviewed-on: https://code.wireshark.org/review/25531 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1e05b8c894d9a3699ffa22a21492d3… commit 1e05b8c894d9a3699ffa22a21492d39634c8c8c3 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Wed Jan 31 14:44:20 2018 +0100 [MEGACO] Clear megaco_command between commands. Change-Id: I62b9c9e192a6d5079c183a5b2e3ca7fa82c5bf39 Reviewed-on: https://code.wireshark.org/review/25528 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f23feb339ea40192c05cb29a4123ad… commit f23feb339ea40192c05cb29a4123adcc67c9a918 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Jan 31 13:54:47 2018 +0100 hsrp: Fix UDP port number for HSRPv6 The UDP port for HSRPv6 was mistyped when UDP dissectors was converted to use "auto" preferences in g2eb7b05b8c. Change-Id: I4b6f634677d23d81fc197dbeb43ee3d91d9a111f Reviewed-on: https://code.wireshark.org/review/25526 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=210db80a54c998fe78cb2ca6493ed4… commit 210db80a54c998fe78cb2ca6493ed4efc62a5feb Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 31 12:23:42 2018 +0100 Qt: fix compilation when building without Lua Change-Id: Idb5d1016637c5d8968eae533d7688099edbeae3a Reviewed-on: https://code.wireshark.org/review/25525 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f5a8711ef195d1bc538a05a4602ee9… commit f5a8711ef195d1bc538a05a4602ee9388da81561 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 29 14:40:45 2018 -0800 Qt: About dialog updates. Open lua scripts when double-clicked. Behavior depends on your system configuration. Add tooltips accordingly. Let Qt wrap the "Wireshark" tab information. Set column widths by eyeballing their contents. Elide the Folders and Plugins strings in the middle. Fixup placeholder text capitalization. Draw links using the palette link color. Change-Id: Ic141eae05541480ec1e254c55fd81728d04713d9 Reviewed-on: https://code.wireshark.org/review/25510 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=47e1798762478ae19354297e5a95d4… commit 47e1798762478ae19354297e5a95d46487cafd42 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 30 14:59:35 2018 -0800 Qt: Byte view and proto tree fixes. Select our byte field only when we enter marked / locked mode. Emit fieldSelected from autoScrollTo so that we always set the marked protocol. Don't clobber the current index in saveSelectedField. Change-Id: I967b20608f991a5f3e6a0979b1f702f874ce27b4 Reviewed-on: https://code.wireshark.org/review/25521 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=55e74ba841126797b2a5b82142fb1d… commit 55e74ba841126797b2a5b82142fb1db8f61a1288 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 30 13:17:01 2018 +0100 Qt: Write recent before applying profile changes The selected profile may be renamed in apply_profile_changes() so write the recent file before renaming the directory to ensure that we reload the latest changes. Change-Id: I8988a00647926d93b0a1903090aadc8c61f1a34e Reviewed-on: https://code.wireshark.org/review/25516 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=043b45e840bf742bb54749b2f4cec2… commit 043b45e840bf742bb54749b2f4cec2a722109b79 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 30 12:27:30 2018 +0100 UI: Rename profiles without delete Do not try to delete the old profile name after renaming. In most cases it will not exist, but when using a case-insensitive file system this will delete the renamed profile if only changing capitalizations (first it's renamed and then it's deleted). Change-Id: I27d2d22d2353b09f2041d82ea1cf1bae37a1ce3d Reviewed-on: https://code.wireshark.org/review/25515 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=eda5c950b61486770ad5c3ddc78fe3… commit eda5c950b61486770ad5c3ddc78fe3860d03e8a7 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 29 16:26:13 2018 -0800 IO Graph: Add some vector checks. Use Qvector::value in a few places instead of an array index. Change-Id: I821ef4b16df919977739c12ccaa3b9c3d53f049c Ping-bug: 14357 Reviewed-on: https://code.wireshark.org/review/25511 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b81c5ad26f879bc0e949a4dc42cb5e… commit b81c5ad26f879bc0e949a4dc42cb5e234c2ad371 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Tue Jan 30 23:23:17 2018 +0100 ieee1905: add missing NULL terminatator to ieee1905_reporting_policy_flags[]. Add missing NULL terminator to ieee1905_reporting_policy_flags[], in order to fix buffer overflow. ASAN report: ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000092a4af8 at pc 0x00000062afd2 bp 0x7ffce7e468d0 sp 0x7ffce7e468c8 READ of size 8 at 0x0000092a4af8 thread T0 #0 0x62afd1 in proto_item_add_bitmask_tree /src/wireshark/epan/proto.c:10406:9 #1 0x62953f in proto_tree_add_bitmask_with_flags /src/wireshark/epan/proto.c:10786:3 #2 0xfb8271 in dissect_metric_reporting_policy /src/wireshark/epan/dissectors/packet-ieee1905.c:2762:9 #3 0xfb2997 in dissect_ieee1905_tlv_data /src/wireshark/epan/dissectors/packet-ieee1905.c:4390:18 #4 0xfb23c8 in dissect_ieee1905 /src/wireshark/epan/dissectors/packet-ieee1905.c:4577:18 Found by oss-fuzz/5298. Change-Id: I35dbd6d29d0a3a5560286146fbed172c810e5b2d Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5298 Reviewed-on: https://code.wireshark.org/review/25520 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=18f16c8b93cea32d617e7e846b45a1… commit 18f16c8b93cea32d617e7e846b45a16f00b02018 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Tue Jan 30 17:22:09 2018 +0100 Qt: Fix crash when no plugins are configured Configuring Wireshark with Cmake using -DENABLE_LUA:BOOL=OFF and -DENABLE_PLUGINS:BOOL=OFF causes all plugin support to be removed. The about Wireshark dialog wasn't made aware of that trying to manipulate the related mdoel anyway, causing a crash. Make the compilation of the offending code conditional. Change-Id: Ifa51f40fda7f019d09327dc5650e5a55da2daf2a Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25517 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=228a919366993c70ae13581079dd26… commit 228a919366993c70ae13581079dd261df667d7e4 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 30 08:54:18 2018 -0800 Remove more unused images. We stopped using various images in the following commits: 307c0d70fb (2011, not sure how they lasted that long) clist_*.xpm 20cc0d7ce9 (2010) stock_dialog_error_48.xpm stock_dialog_info_48.xpm stock_dialog_warning_48.xpm stock_dialog_stop_48.xpm 2e4e229739 (2004) stock_dialog_question_48.xpm 1a3e596609 (2011) voip_select.xpm 194a145c8f (2013) wssplash*.xpm 07c3d057b8 (2013) openhand-16.png rubberband-16.png Change-Id: I3647cb2cb47e3927a4359f519ce45eb57e5aa534 Reviewed-on: https://code.wireshark.org/review/25519 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=461fb517d1f75f607eb3cb670b8775… commit 461fb517d1f75f607eb3cb670b87754bc24b82ca Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 29 09:42:08 2018 -0800 Qt: Check for a valid capture file in the status bar. Rearrange the logic in showCaptureStatistics. Fixes a crash here when capturing from stdin. Change-Id: I7ec15a556579afe968a06a36d7914aa1631666df Reviewed-on: https://code.wireshark.org/review/25507 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=709757e996b88aa2995c65e7030d5f… commit 709757e996b88aa2995c65e7030d5fd440078ef8 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Jan 23 06:56:15 2018 -0800 radiotap: Refactor some aspects of the radiotap dissector. One thing I hate is big slabs of open coding. Compilers are very good these days and will inline functions if they are used in only one place. By using functions we make the code very much more readible. There is also a big opportunity to use functions like proto_tree_add_bitmask. Change-Id: I66d1509f577d2955996f4649e05494ab0370ed01 Reviewed-on: https://code.wireshark.org/review/24964 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fc6c5be22972d7193ca8ec1bfddd00… commit fc6c5be22972d7193ca8ec1bfddd00acb7241aea Author: Robert Jongbloed <robertj(a)voxlucida.com.au> Date: Tue Jan 23 10:21:58 2018 +0000 SIP: Fixed matching of INVITE request to INVITE response. The sip_is_packet_resend() function sets the internal transaction_state to final_response_seen, the prevents the sip_find_request() from finding the matching INVITE as it expects transaction_state == request_seen. Simply reversing the order of these functions seems to fix the problem. Change-Id: I61d085c979dee24ad88b4eea26dfa002fd9cd213 Reviewed-on: https://code.wireshark.org/review/25429 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9d87994b671e099b31525e92085fcd… commit 9d87994b671e099b31525e92085fcde0a503b3ab Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 29 17:20:36 2018 -0800 Byte view: Mark bytes using an outline. Distinguish between hovered and marked bytes using a lighter and heavier outline. Remove the "mark" color definitions. Change-Id: Icf6363e920a634574b7a42a10ea77b538ce78290 Reviewed-on: https://code.wireshark.org/review/25513 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cdcf9d0817f8e789d667ef41730d59… commit cdcf9d0817f8e789d667ef41730d59f0723d39e6 Author: Mališa Vučinić <malishav(a)gmail.com> Date: Tue Dec 26 16:35:55 2017 +0100 ieee802154: Allow generic nonce to be passed in CCM* API. CCM* algorithm implemented as part of ieee802154 dissector can be leveraged for higher layer protocols, e.g. OSCORE. This change adds an additional parameter to the CCM* API in order to allow passing a generic 13-byte nonce. Bug: 14367 Change-Id: Ib2da1146659f67ffb3a4767ec093f8b7f09461ce Reviewed-on: https://code.wireshark.org/review/25455 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7207c82464a225a1d167c397dcef12… commit 7207c82464a225a1d167c397dcef1232b0224467 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 20:09:46 2018 +0100 wiretap/merge.c: Fix memory leak, fix description. If merge_open_in_files() is going to fail, free files array to avoid memleak. Found by clang. Change-Id: I156c5f1c041cd7779ff0a0095bc2810f50768ab6 Reviewed-on: https://code.wireshark.org/review/25421 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c9d98323f62d3fd1a1a3ee598c991a… commit c9d98323f62d3fd1a1a3ee598c991a03a1fdb3af Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Wed Jan 24 03:34:48 2018 +0100 file.c: Fix read from array index out of bounds. callback_args.col_widths[] is allocated only for visible columns, use 'visible_col_count' index instead of 'i' one, which is incremented only for visible columns. Found by clang. Change-Id: I4e3c05fd372585295e3a0d7427497a46f32f93bb Reviewed-on: https://code.wireshark.org/review/25444 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a584eab239d55e441433ead40c993e… commit a584eab239d55e441433ead40c993e08a24c59fe Author: ZHANG Rui <rzhang(a)grandstream.cn> Date: Thu Jan 18 17:45:49 2018 +0800 New RTCP dissector for transport-cc Bug: 14332 Change-Id: I49642a9880fc03d38942eebfd6b1015894fef23d Reviewed-on: https://code.wireshark.org/review/25255 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=27ae22bd2538ff7391a5e567237159… commit 27ae22bd2538ff7391a5e56723715932ecf80b0e Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Sat Jan 27 00:46:32 2018 +0100 usbdump: Add usbdump wiretap plugin as functional example This wiretap plugin serves a dual purpose. One is to add usbdump file reading capability to wiretap and therefore Wireshark and Tshark. Second it is an illustration of a basic wiretap plugin module. Change-Id: Iefbb156ea1bc5d90dabc1753942cdb9e393714ad Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25487 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=94d7500a7d2589548f210ef0e9cb6d… commit 94d7500a7d2589548f210ef0e9cb6d9eba796239 Author: Robert Jongbloed <robertj(a)voxlucida.com.au> Date: Tue Jan 23 12:13:43 2018 +0000 SDP/RTP: Support for "bundled" media. Modern SDP usage (e.g. SIP, WebRTC) can "bundle" multiple RTP media streams on a single port. Thus the RTP dissector has to be able to handle audio and video at the same time, so the gboolean flag in _rtp_info was changed to a bit mask. The SDP parsing was then changed to detect multiple "m=" lines using the same port, and combine their audio/video bit masks, and the rtp_dyn_payload used has all the audio and video payload descriptions. Change-Id: Ifa3c034260f892ed005fe28647d28f3b0b1b05cf Reviewed-on: https://code.wireshark.org/review/25431 Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d328a58fc6ef90db94bb591b949802… commit d328a58fc6ef90db94bb591b949802abbc91a332 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Mon Jan 29 18:29:58 2018 -0800 wifi-dpp: A number of further changes from the recent testing. 1. Add the crypto suite that came in with a spec change (v171212). 2. Add two additional fields that need handling. 3. Make the attribute value a separate sub-tree. Change-Id: Ic01527bcd0361bf2522d2efbc91cd8191d7b2e27 Reviewed-on: https://code.wireshark.org/review/25514 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3dd5574800f6043a87926fb1b0445d… commit 3dd5574800f6043a87926fb1b0445d01ad2306cf Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 29 17:01:52 2018 -0800 Remove some unused images. The NSIS checkboxes were last used in 2003. I'm not sure if the KDE icons ({hi,lo}??-app-wireshark.png) were ever used. Change-Id: Ib548b0fcfb650b279e8d475f350cdba663f903c0 Reviewed-on: https://code.wireshark.org/review/25512 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=42322ac8cf2d99cb15d60a8d6d4053… commit 42322ac8cf2d99cb15d60a8d6d4053b19f6b60a5 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Mon Jan 29 19:44:07 2018 +0000 dct2000 wiretap: expect all lines to have exactly 4 subsecond digits. Should fix clang warning created by https://code.wireshark.org/review/#/c/25492. Change-Id: Iafa31e24cd786a510f3a953d615df4cbc3930fa6 Reviewed-on: https://code.wireshark.org/review/25508 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8342e5f97b7564ec423507453f7b5e… commit 8342e5f97b7564ec423507453f7b5e4e5f48fffe Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Mon Jan 29 11:00:57 2018 +0100 codecs: register SBC codec once. Somehow the registration of the SBC codec was duplicated, which does not (yet) cause an error message, but also doesn't work. Remove the duplicate registration. Change-Id: Ic22ba66fd65b326fb2688300dad8f9b81081c7e5 Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25506 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=38c0ffe4c6683a4ed8493f42dbe865… commit 38c0ffe4c6683a4ed8493f42dbe8658098a921aa Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Sun Jan 28 17:40:52 2018 +0000 Avoid #ifdef'ing out translation units Change-Id: Ibef0120184ae577f11059fcaf0eaa24a32820273 Reviewed-on: https://code.wireshark.org/review/25502 Petri-Dish: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=6d29434c3ff737de9f66f66213827b… commit 6d29434c3ff737de9f66f66213827b7eddb56ce6 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Jan 28 12:47:42 2018 -0500 DNP3: Limit the amount of "empty" objects/fields can be present in a packet. Chances are if there are a large number of "empty objects" (that don't increment packet counter) it's an intentionally malicious packet and we should break the loop. Bug: 14362 Change-Id: Id9a6f4270cc47188becdf4652f903d0ba4478dcb Reviewed-on: https://code.wireshark.org/review/25497 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8333c02731b23d364dd84b210d3cd0… commit 8333c02731b23d364dd84b210d3cd0f0a164f7da Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Jan 27 23:35:03 2018 +0000 dct2000: for speed, avoid ws_strtoi32() while reading timestamp Change-Id: I5d8797b68c53168d4c00be8c3c3a3325b370e38c Reviewed-on: https://code.wireshark.org/review/25492 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c21b2e7f94feabd35672c3a56f3ec1… commit c21b2e7f94feabd35672c3a56f3ec17fa6675c9e Author: Michail Koreshkov <drkor(a)bk.ru> Date: Thu Jan 25 15:54:26 2018 +0300 Display JSON in compact form JSON will be display like in browswer developer tool (Firefox or Chrome). Change-Id: Ib504f4828d9fd8d25d9564b93717007ac021713c Reviewed-on: https://code.wireshark.org/review/25474 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=f8bb0757f33e00b33fda174910c2cf… commit f8bb0757f33e00b33fda174910c2cfcf8f12f9bc Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Sun Jan 21 10:44:05 2018 -0800 ieee80211: Implement two more extended IE from IEEE STD 802.11. Handle the Estimated Service Parameters tagged element and the Future channel guidance one. The second may need more work in future. These are defined in IEEE STD 802.11-2016 but may have been defined earlier. Change-Id: I1c67a0ea6df9c1cc89bb3a34da921f3938e0a012 Reviewed-on: https://code.wireshark.org/review/25407 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=67b28510029b88e5a26b98602b71a5… commit 67b28510029b88e5a26b98602b71a551b4d26c0b Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Sat Jan 27 13:36:33 2018 -0800 radiotap: Mark unknown fields as unknown instead of reserved. Change-Id: Iecfb705b37f54119eaec75ab8df8c7ee3c76bfec Reviewed-on: https://code.wireshark.org/review/25503 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bc36e2a113112c7ee1abe904434723… commit bc36e2a113112c7ee1abe9044347237c626a2161 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 14:24:31 2018 +0100 cli: free memory on exit in tap-comparestat (found by clang). Change-Id: Ie4dfc68583fa6fc742baeaf9d9fd1c7d2f783f38 Reviewed-on: https://code.wireshark.org/review/25435 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=907d8ff41f37f8eaed5e4c64ab322f… commit 907d8ff41f37f8eaed5e4c64ab322f33ea2c6802 Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Jan 28 16:26:31 2018 -0500 Protect UAT color "datatype" from an empty string UAT color "datatype" has the format of #XXXXXX so the XXXXXX is strduped to pass to strtol(). The "pointer math" assumed the # was always present and would result in large memory allocation if string was empty. Bug: 14357 Change-Id: Idc43b17f0e07705880d0d77f106991d10e09f072 Reviewed-on: https://code.wireshark.org/review/25504 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5c1247301461b842d8a624195bb057… commit 5c1247301461b842d8a624195bb057b534e0a17e Author: Craig Jackson <cejackson51(a)gmail.com> Date: Thu Jan 25 00:09:31 2018 -0500 TDS: Dissect TDS4.2 response packet Add dissection of the TDS response packet for TDS 4.2. In order to share code, this required parameterizing TDS 7.x token-handling routines for things such as endian-ness and one-byte vs two-byte character encodings. This required ascertaining accurately when TDS 7.x is in use as early in the conversation as possible. This in turn required knowing the program versions downloaded in the prelogin packet in the case where the login packet is encrypted. (Listening to the LoginAck token is a little too late.) Add more support routines to parameterize the endian nature of each connection. Although the particular tokens decoded here are documented for TDS 4.2, it has only been tested with a trace from TDS 4.6. TDS 4.6 didn't change much, but there may be a few minor errors. Change-Id: I6f8f136bcc565640fbea4302cb79ea29a118d9a1 Reviewed-on: https://code.wireshark.org/review/25464 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=20d4c7bb62fc8641643e1101b215bd… commit 20d4c7bb62fc8641643e1101b215bd4c2e6e23b0 Author: Florian Bezold <florian.bezold(a)esrlabs.com> Date: Wed Dec 6 11:31:18 2017 +0100 androiddump: Raise ADB timeout to 2s for slower devices Running "tcpdump -D" on target seems to be a expensive operation in some cases, not finishing within the 500ms timeout on several devices (~1000 ms in one of our cases). Change-Id: I57e4d31f12c4e393ff84e79b64cb024b74a11f0e Reviewed-on: https://code.wireshark.org/review/24719 Reviewed-by: Michal Labedzki <michal.labedzki(a)wireshark.org> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3d94f624d152068cd597e139d58073… commit 3d94f624d152068cd597e139d5807357fa285ac6 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Wed Jan 24 03:41:12 2018 +0100 wsutil/filesystem.c: fix memory leak in init_progfile_dir() If file wasn't found in PATH, there is a leak of path. Don't break the loop after reaching NUL character. Check for NUL character will be done in while() start condition. Found by clang. Change-Id: I0111a71853ffd485ee1096296f92de4472409c66 Reviewed-on: https://code.wireshark.org/review/25445 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1b467b11add2fdf7a40bb86ffb78b6… commit 1b467b11add2fdf7a40bb86ffb78b63a28b27f87 Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Sun Jan 28 17:31:40 2018 +0000 Minor Makefile.am cleanup. Change-Id: I3670c86a695cbea00be39d0c274a5bef0ef31cbf Reviewed-on: https://code.wireshark.org/review/25501 Petri-Dish: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=66f85c65d55df62fffb9e9acf99f88… commit 66f85c65d55df62fffb9e9acf99f882e7c664b2d Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Mon Jan 22 08:20:42 2018 +0000 plugins: Remove nordic_ble.dll exception This should no longer be necessary with the sub-version directory struture. If the user is installing a DLL for a built-in plugin, an error message is appropriate. Change-Id: I80842f1ea03a08594321a674650a1373aaa48712 Reviewed-on: https://code.wireshark.org/review/25500 Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=5d1687e449a8441f606a4559734f2f… commit 5d1687e449a8441f606a4559734f2fae5879f4f5 Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Mon Jan 22 08:16:42 2018 +0000 Rename plugins_scan_dir() This makes it more obvious that it is a static function. Change-Id: I7348c4326b1e388870cb6657d9c67bd1086357b0 Reviewed-on: https://code.wireshark.org/review/25499 Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=285a0f5a967fd0a473611599a1677b… commit 285a0f5a967fd0a473611599a1677bf96038d6fe Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Mon Jan 22 08:14:41 2018 +0000 Use g_str_has_suffix() Change-Id: Ida335462efdfeef88a7afb3f27caf274632ca879 Reviewed-on: https://code.wireshark.org/review/25498 Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=15d9ab22c33ffcd02bcad33866ccd7… commit 15d9ab22c33ffcd02bcad33866ccd7899e2f17f0 Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Sun Jan 28 12:00:29 2018 +0000 plugins: Use per-library data structures This is cleaner and allows the "duplicate plugin name check" to be performed correctly (per module and not globally). Change-Id: I2b2122495dc047af5b7043dcf020a525766b7c30 Reviewed-on: https://code.wireshark.org/review/25496 Petri-Dish: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=10b9472659722d8f390170dae8b5ee… commit 10b9472659722d8f390170dae8b5ee8612925c53 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Jan 28 08:18:32 2018 +0000 [Automatic update for 2018-01-28] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0b47c83ca6e62a24043fb5d546141e3e9af1e7b8 Reviewed-on: https://code.wireshark.org/review/25493 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=21ee658f91aaf33241c230c5953613… commit 21ee658f91aaf33241c230c59536132992f65281 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Fri Jan 26 22:51:03 2018 +0100 Infiniband: Decode AETH syndrome byte Used reference: Book "InfiniBand Network Architecture" by Tom Shanley; page 369 ff Bug: 14359 Change-Id: I77e64ca16ccc5f193eac34b304165f722ffb0748 Reviewed-on: https://code.wireshark.org/review/25489 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=baca10e725d312d067c45b5394d32f… commit baca10e725d312d067c45b5394d32f32a4f11ac6 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Fri Jan 26 23:14:45 2018 +0000 DCT2000: after profiling, speed up some parts Change-Id: Ia335aaca3368608fe495c887d846fe3f057b74dd Reviewed-on: https://code.wireshark.org/review/25486 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9972110f319c1525412cbc7e06783d… commit 9972110f319c1525412cbc7e06783d6dd19dbd56 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Jan 27 22:55:03 2018 +0000 valgrind-wireshark.sh: fix typo in usage Change-Id: If9210c6f71d4e258a489d254482cf5543b818e11 Reviewed-on: https://code.wireshark.org/review/25491 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ea6c209758da5a55dadf8cceb192d1… commit ea6c209758da5a55dadf8cceb192d1eaf1486e96 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Sat Jan 27 18:03:09 2018 +0100 Reset file permissions Some oddities with regard to file permissions have crept into the repository. Reset execute rights on various files which do not need them. Change-Id: Ib05658072925d59fc682173673c5638d157a269a Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25490 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=557f6a4aed085ec21981ae842b84d0… commit 557f6a4aed085ec21981ae842b84d0061d519171 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 25 09:31:54 2018 -0800 Qt: Translate some about box strings. Change-Id: I2f9d1be83a26129e1206f32133b5ba6705f4dd85 Reviewed-on: https://code.wireshark.org/review/25471 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=98a218dcd350b420f57faa10e79525… commit 98a218dcd350b420f57faa10e79525a12bda6089 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Fri Jan 26 21:05:03 2018 +0000 Snort: speed up parsing of options by avoiding g_snprintf() Change-Id: Ibe12ce69b139752e60b66a2af63e31244321bec5 Reviewed-on: https://code.wireshark.org/review/25484 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=31769615bbea590cd98b8f1926641a… commit 31769615bbea590cd98b8f1926641a2ddbe04de7 Author: Alexander Gryanko <xpahos(a)gmail.com> Date: Fri Jan 26 16:19:38 2018 +0300 http2: underscore replaced by dash in static headers name Headers field "name" is used in the hash table for matching field type while processing data. Browsers use dash as delimiter while in the code we use underscore. Change-Id: I6342af9328118b41a8c71e034ef5913a83a84459 Reviewed-on: https://code.wireshark.org/review/25478 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ad6ab481519fb57cd96111ab7069eb… commit ad6ab481519fb57cd96111ab7069eb4cb3d95c8d Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 26 13:12:43 2018 -0800 Release notes: We ship Qt 5.9.4 on Windows. Change-Id: Id4190dee99ade7bf4568010109c1e4dfd0013873 Reviewed-on: https://code.wireshark.org/review/25485 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=98d1069066724477156aedf1d18e0d… commit 98d1069066724477156aedf1d18e0dc72c204ead Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Jan 26 07:47:41 2018 +0100 Qt: Allow filter with deprecated syntax as button Also update widgets at startup. Bug: 14369 Change-Id: I2621b78289620a131bcad21d5ec23b048e4b218c Reviewed-on: https://code.wireshark.org/review/25475 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=4762b78e452d636ba2262d1e3ca7b2… commit 4762b78e452d636ba2262d1e3ca7b29ed459dfff Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Jan 25 19:47:49 2018 +0100 Qt: Remove unused label_folders Change-Id: I42d7ba0eed9cf2ad50e02a5385c6929e9b31882b Reviewed-on: https://code.wireshark.org/review/25473 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4398a92be20289e900bbf229f209b7… commit 4398a92be20289e900bbf229f209b718af1ec668 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Thu Jan 25 14:36:03 2018 +0100 Qt: Simplify files column in about dialog HTMLTextDelegate fails to build in Qt 4.8, partially because QStyleOptionViewItem.text is introduced with Qt 5. Another issue with the current implementation is that the "Copy" action includes the HTML tags for italics. To fix these, just remove the italics formatting. Change-Id: I63aed7c3d0da3d9829d410d75fc18daa4049c0ca Fixes: v2.5.0rc0-1822-g73c01d6d05 ("Qt: Rewrite the About dialog to use models") Reviewed-on: https://code.wireshark.org/review/25470 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0d5cbc7303dec4c7239b1df8fd152b… commit 0d5cbc7303dec4c7239b1df8fd152b58ce99a098 Author: Lazar Sumar <bugzilla(a)lazar.co.nz> Date: Tue Jan 23 02:33:14 2018 +0000 Added the Proconx CAN-ETH protocol dissector Change-Id: I306341c7cddf8facb4a9ca62254a465a1da22174 Reviewed-on: https://code.wireshark.org/review/25423 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fb2fa4d7769c025c9328562bf51cf9… commit fb2fa4d7769c025c9328562bf51cf9fa44d1dce5 Author: Joerg Mayer <jmayer(a)loplof.de> Date: Thu Jan 25 03:12:25 2018 +0100 Get rid of the necessity to use a preference to dissect ERSPAN type I packets. Change-Id: I52c4c1fa5601bc66396f397ad23a9e53285a5926 Reviewed-on: https://code.wireshark.org/review/25463 Reviewed-by: Jörg Mayer <jmayer(a)loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=9be01dc6161acb0b11ce82d1e0475d… commit 9be01dc6161acb0b11ce82d1e0475d06f8cc1c40 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Thu Jan 25 14:11:57 2018 +0100 Qt 4.8 compatibility fixes Add missing include headers, define Q_NULLPTR for all Qt objects (to avoid having to include an ugly compat header), use old signal/slot syntax (Q_SIGNALS are protected in Qt 4.8), disable Qt 5 log message handler, etc. Change-Id: I449beb0b74050fdfb0fc5828d8fb74eedb2b45bf Reviewed-on: https://code.wireshark.org/review/25469 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=6bd9be470e9c78ed8dfff31912c12e… commit 6bd9be470e9c78ed8dfff31912c12eb138f5bf5f Author: AndersBroman <anders.broman(a)ericsson.com> Date: Thu Jan 25 13:55:48 2018 +0100 [PER] Fix the bitmask to calculate the number of bits needed to hold the length. Bug:14366 Change-Id: I79a8051b94feffeb5d667a664fdcff6680dec620 Reviewed-on: https://code.wireshark.org/review/25468 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=77a665a75c140585946db663e50fe4… commit 77a665a75c140585946db663e50fe42ee5ee0975 Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Date: Thu Jan 25 13:13:35 2018 +0100 ZigBee: Fix change 25456 - Wrong attribute ID corrected Change-Id: I06251e47feb6593bd940c3a719922abfa3241205 Reviewed-on: https://code.wireshark.org/review/25466 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=8022f12151fdfc9d23e2a2ca7c8847… commit 8022f12151fdfc9d23e2a2ca7c884729ebe66587 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Jan 25 12:24:38 2018 +0100 gitlab-ci: fix clang repos. Change-Id: If0dd9074b0c2493c1f66f26271018f5dadc91e3d Reviewed-on: https://code.wireshark.org/review/25467 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=350ca99d1797a2701e40d198a8ff17… commit 350ca99d1797a2701e40d198a8ff17cfb19d0adc Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 24 10:39:39 2018 -0800 Qt: Adjust the about box layout. Make sure the compile and build information is centered. Change-Id: I2bfe502df4339c28d8c88553419b7d4d412a2be2 Reviewed-on: https://code.wireshark.org/review/25461 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba3f29b62fcb362b5385b7e35691f0… commit ba3f29b62fcb362b5385b7e35691f0c466d811fd Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 24 13:00:29 2018 -0800 Don't use static GMutexes. They're not supported in older versions of GLib. Change-Id: I8342048bab90fb192b8d7f0253f8b3207be8c5b1 Reviewed-on: https://code.wireshark.org/review/25460 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9149af994817b89fdb37be96359682… commit 9149af994817b89fdb37be963596828cb2b27a1b Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Date: Wed Jan 24 20:36:51 2018 +0100 ZigBee: Add remaining attributes from Smart Energy Prepayment cluster Change-Id: I7e35dd26d7369cbc39cdb1e078200306d6ada619 Reviewed-on: https://code.wireshark.org/review/25456 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=686aad42e9d650fb321adf58b359dc… commit 686aad42e9d650fb321adf58b359dcd44675f8c3 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 24 15:52:49 2018 -0800 Minor wireshark-qt.cpp cleanups. Remove duplicate and unneeded code. Remove placeholder markers left over from the initial port from GTK+. Change-Id: I4b372057c40cce53d0a00a54e490dec2097a7423 Reviewed-on: https://code.wireshark.org/review/25462 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=55fbeec607013a681dbb0e60645dca… commit 55fbeec607013a681dbb0e60645dca6c89b8df80 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Wed Jan 24 15:32:25 2018 +0100 bootp: DHCP User Class Data iPXE exception iPXE seems to violate RFC 3004 by ommitting the UC_Len_i field in the User Class Data field. Since this seems to be a 'well known' issue, which is not going to be corrected, detect and circumvent the error detection for this specific use. Bug: 14312 Change-Id: I2a15c336d7f67ee5fd83f955de7126eac146bfb1 Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25450 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=369f8195e8ce054c457ebca29ed658… commit 369f8195e8ce054c457ebca29ed6581d11ac7e69 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 24 14:10:39 2018 -0800 Qt+WiX: Skip translations. We handle translations in QtTranslation.wxs so we need to skip them when generating QtDependentComponents.wxs. Change-Id: I05586c7f8fbbaf72fc30564a157ba1175154d1d3 Reviewed-on: https://code.wireshark.org/review/25459 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ae5e83a25c7a75dea3553a32de8bae… commit ae5e83a25c7a75dea3553a32de8bae1cc036f7f9 Author: Laszlo Papp <laszlo.papp(a)hubersuhner.com> Date: Wed Jan 24 16:57:10 2018 +0000 OpenFlow(v5&v6) : Fix RX_PWR/TX_BIAS Change-Id: Iae6fe2473d80cb14d5a9676b7efce41dc59a30e2 Reviewed-on: https://code.wireshark.org/review/25454 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=50b4ff6db8b1d66caa17307d793756… commit 50b4ff6db8b1d66caa17307d79375695dccb212a Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 24 13:01:17 2018 -0800 CMake: Create directories one at a time. Older versions of CMake don't support passing multiple arguments to `-E make_directory`. Change-Id: I62f76753a0ec1a96849de3a1131869f08303dbfc Reviewed-on: https://code.wireshark.org/review/25458 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=66a9f27dd1790deae574c3198aa617… commit 66a9f27dd1790deae574c3198aa61742ba18ba5d Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 24 11:49:12 2018 -0800 Qt+WiX: Check windeployqt --list output. Windeployqt 5.9.4 can print translation files that don't exist (QTBUG-65974). Fix up whitespace. Change-Id: If0a4ad6e24023707fa7e9cb1132af8a8dc425627 Reviewed-on: https://code.wireshark.org/review/25457 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=fe007542268e0261aceb698d5f6d64… commit fe007542268e0261aceb698d5f6d64384167695e Author: Laszlo Papp <laszlo.papp(a)hubersuhner.com> Date: Wed Jan 24 16:53:10 2018 +0000 Openflow: Use offset 2 for tx_min/max as they are uint16_t Change-Id: I2f47e0ede2a31cfdadc69ab125a739b3deaa297e Reviewed-on: https://code.wireshark.org/review/25453 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b3cf908ffe567c9da124c3056dddab… commit b3cf908ffe567c9da124c3056dddab0c3cb0d5b8 Author: Laszlo Papp <laszlo.papp(a)hubersuhner.com> Date: Wed Jan 24 16:03:00 2018 +0000 Fix the display of Length and Pad2 in the openflow dissector Change-Id: I12194d1449812c43c062c50d319d44d6d7437c51 Reviewed-on: https://code.wireshark.org/review/25451 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ccd2b53f40ffbd0a29741203febd8c… commit ccd2b53f40ffbd0a29741203febd8cf7c701ff8f Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 24 16:25:29 2018 +0000 byte_view_text (qt): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ibfaac5e1d8cc30d6bb8917d0c0e10a79e059a53e Reviewed-on: https://code.wireshark.org/review/25452 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=0ef0f4ceb589051d6be769afe6325a… commit 0ef0f4ceb589051d6be769afe6325abedb12300f Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Wed Jan 24 12:29:01 2018 +0000 Windows: Modify position of compress checkbox in Export Packets dialog The "Compress with gzip" checkbox was over on the right and cut-off. Move it to a (somewhat) better place. Change-Id: I241e6216ba69c5fa4e4709e311d45dfecdad2c2d Reviewed-on: https://code.wireshark.org/review/25448 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=92af82aaa76a081130798893f1b752… commit 92af82aaa76a081130798893f1b752ba17efbc26 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 24 11:57:55 2018 +0100 CVS pserver: fix infinite loop Bug: 14364 Change-Id: I49377c5b06a7b3f2e919c8f8ae2c4d95b9b2c7eb Reviewed-on: https://code.wireshark.org/review/25446 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fa26a00876167346f5aae7d1968c9e… commit fa26a00876167346f5aae7d1968c9ea9ebb66b7f Author: Matej Tkac <matej.tkac.mt(a)gmail.com> Date: Wed Jan 24 12:14:37 2018 +0100 [PFCP] Fixed Outer Header Creation IE 3GPP TS 29.244 V14.2.0 (2017-12) Change-Id: If99b0701541a32e393d3fd19bbd013fd4abcbcc8 Reviewed-on: https://code.wireshark.org/review/25447 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=954fd253e4633a3be080c386e10e6f… commit 954fd253e4633a3be080c386e10e6f4ba41350d5 Author: Michael Mann <mmann78(a)netscape.net> Date: Tue Mar 28 21:49:47 2017 -0400 Add duplicate value_string in check filter Change-Id: Ie00d057f5bc36d65b6bba790169543a65b068e47 Signed-off-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-on: https://code.wireshark.org/review/20744 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=289cbd76d9171b804d601c30d1438d… commit 289cbd76d9171b804d601c30d1438d579f4b1c6a Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Wed Jan 24 03:20:50 2018 +0100 wiretap/k12: fix memory leak. Free state.bb in error path. Found by clang. Change-Id: Ic9f2e1383a5219de465a6f22f7b382ac8b1f9cbf Reviewed-on: https://code.wireshark.org/review/25443 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0d584d9fedb1050d4b8a1ec024f36c… commit 0d584d9fedb1050d4b8a1ec024f36cff1ca48935 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Tue Jan 23 07:52:23 2018 +0100 ui: don't g_assert() in get_args_as_string(), but return empty string for no arguments case. Rework e861a112103ed4d1f2fa153932bcf86f120e3907 by returning empty string. g_assert() seems to be not understand by clang scan. Change-Id: Iade2d81aa22eecf563a465cb86e694e3e0f853df Reviewed-on: https://code.wireshark.org/review/25441 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7e37a7db558563e665f7b356d6ee4e… commit 7e37a7db558563e665f7b356d6ee4e8a1bd82f9c Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 16 13:56:58 2018 -0800 CMake: Compile and link flag updates. Add /guard:cf and /Qspectre to the Visual C++ 2015 compile and link flags. Don't bother trying to pass -Wl,--as-needed or -pie to Visual C++. Remove some unneeded quotes. Change-Id: I4d89d61ce9dd579e7cfbcd49df6116810bfb0178 Reviewed-on: https://code.wireshark.org/review/25356 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d672ee93724999d93763fa513dcefe… commit d672ee93724999d93763fa513dcefef5858e919c Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Wed Jan 24 03:06:06 2018 +0100 wslua: fix nstime memory leak after passing unknown encoding to TvbRange_nstime() Move checking of encoding before allocating nstime. Found by clang. Change-Id: I3c1de5fae6fcf52393cc38302359f21f17808087 Reviewed-on: https://code.wireshark.org/review/25442 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cde023c3c5a08131495eb2574c00ff… commit cde023c3c5a08131495eb2574c00ff1f34cdce55 Author: Robert Jongbloed <robertj(a)voxlucida.com.au> Date: Tue Jan 23 10:38:44 2018 +0000 SDP: Added support for "a=rtcp" and "a=rtcp-mux". Modern SIP endpoints often use non adjacent, or the same, port for the RTCP protocol as the RTP protocol. This is indicated via attributes in the SDP, which should be used to set up the correct dissector for the correct port on this SIP session. Change-Id: I37bf30b71541b6f924fbda5ac1cb29f3ba171515 Reviewed-on: https://code.wireshark.org/review/25430 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=99b7776d5f4ec28120cb3d3fd77220… commit 99b7776d5f4ec28120cb3d3fd77220c8707b405d Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 23 12:05:10 2018 -0800 CMake: Copy multiple data files at a time. Copy the DTD, DIAMETER, RADIUS, and profile files all at once instead of individually. Change-Id: I7c75c4a784956b998a82fd627dd17843820096ff Reviewed-on: https://code.wireshark.org/review/25439 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=59c958d7cb58f003371826ec72f0cd… commit 59c958d7cb58f003371826ec72f0cd93c3e7a7a6 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Tue Jan 23 09:31:22 2018 +0100 cvspserver: Add basic cvs pserver protocol dissector Change-Id: I049c8b9b9a0a1da2243217532186ba5a19cf5671 Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25424 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c9a89e29e8c156c1c7edf8c0c1703f… commit c9a89e29e8c156c1c7edf8c0c1703f072bdc8554 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 23 17:17:11 2018 -0800 Qt: Add back the "ready to go" startup message. The stdin capture test and at least one external application depends on the "Wireshark is up and ready to go" startup message, so we need to print it even when DEBUG_STARTUP_TIME isn't defined. Print the startup time in seconds. Change-Id: Ic1683b751f9cce30b8ca8a6122eddff44fcda015 Reviewed-on: https://code.wireshark.org/review/25440 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=958ef99edf4d32acb8db5878fa8f7e… commit 958ef99edf4d32acb8db5878fa8f7eed4acd26e4 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Fri Jan 19 19:06:10 2018 +0100 sharkd: try to fix clang uninitialized value stored to field 'protocol'. Instead of using g_memdup(), make it more C-like. Change-Id: Ifde75801a261f9e269391fabf323f34a4e3508ac Reviewed-on: https://code.wireshark.org/review/25395 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=787b93fd071e1537b33e8d2f894bbc… commit 787b93fd071e1537b33e8d2f894bbc3cc0ed5595 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 23 11:02:16 2018 -0800 Docbook: Generate one PDF paper size. Generate a single PA4-sized PDF. PA4 is the approximate intersection of A4 and Letter[1]. This gives us one less file to build and distribute. If you're printing out hard copies of the guides this wastes a few pages compared to an A4-sized PDF, but if you're printing out hard copies of the guides you've already made a strong commitment to waste paper. Page counts: Guide Size Pages WSDG A4 203 WSDG Letter 217 WSDG PA4 217 WSUG A4 192 WSUG Letter 204 WSUG PA4 205 [1] https://en.wikipedia.org/wiki/Paper_size#PA4_or_L4 Change-Id: If43d4b19947c77a51b3943a2b329dbab45025d79 Reviewed-on: https://code.wireshark.org/review/25438 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=6605d844afa3d804da89970ee46845… commit 6605d844afa3d804da89970ee46845cfa986994b Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Tue Jan 23 19:21:10 2018 +0100 QUIC: fix build with older Libgcrypt RHEL7 ships with Libgcrypt 1.5.3 which does not support AEAD, add guards to fix -Wunused-function errors. Change-Id: I230a66eff0dca9a882bf87f2f740ee0d36cd1dc6 Reviewed-on: https://code.wireshark.org/review/25434 Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7ecf93c83334867b9040bf147e249a… commit 7ecf93c83334867b9040bf147e249a5118275fad Author: AndersBroman <anders.broman(a)ericsson.com> Date: Tue Jan 23 15:23:11 2018 +0100 [MEGACO] Priority value gets displayed as Termitation Id. Change-Id: If176231d1c71692b1d6a2627934d211e4f2476a7 Reviewed-on: https://code.wireshark.org/review/25433 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5d5482e2e6504a04c092341aa60eb9… commit 5d5482e2e6504a04c092341aa60eb9d0008cce8c Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Jan 23 10:02:02 2018 +0100 USBMS: fix endianness of GET MAX LUN and RESET While we are at it, let's add the protocol item to allow filtering on protocol. Bug: 14360 Change-Id: I4973a6e657dccd71af4f798584cc118b75bedd20 Reviewed-on: https://code.wireshark.org/review/25425 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c2daa6bc73148aaa2ae2eb3f762f2d… commit c2daa6bc73148aaa2ae2eb3f762f2d2f39a0f491 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Jan 23 11:37:25 2018 +0100 LTE RRC: register dissectors for UERadioAccessCapabilityInformation(-NB) and UERadioPagingInformation(-NB) Change-Id: Idb3c3fe2cab4ce7aff2bfe108a6bd4fb07fe44b3 Reviewed-on: https://code.wireshark.org/review/25426 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3a9da2e707924ba0be453c65274d88… commit 3a9da2e707924ba0be453c65274d881cb845c4b1 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 21:16:01 2018 +0100 gtk: fix memory leak in profile dialog. fill_list() don't break the loop when it founds first profile matching name, and it can memleak if somehow it found more than one. Don't break the loop to avoid regressions. Just g_free() previously found. Found by clang. Change-Id: I082b3f1d16f07580a6d7c814d2a8ee5463a44b0f Reviewed-on: https://code.wireshark.org/review/25422 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=e6eb4815cd426d8ea30d0ef3225bc2… commit e6eb4815cd426d8ea30d0ef3225bc27f39dab776 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 18:28:16 2018 +0100 gtk: Fix memory error/double free. pathname is freed by caller of firewall_save_as_ok_cb(). Make pathname const. Found by clang scan. Change-Id: I3a0ab85494a9194edb825bae33eca979c7f8faf3 Reviewed-on: https://code.wireshark.org/review/25417 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=862c881318b80070d4394726a64feb… commit 862c881318b80070d4394726a64feb538999269f Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 19:02:27 2018 +0100 traffic table: Fix memory leak Free tpl_line in error path. Founded by clang scan. Change-Id: Iaaaaed155d859171ee880d520c11594b2d4d0b59 Reviewed-on: https://code.wireshark.org/review/25420 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=6e31943cd4f21a31602eafb59ac07a… commit 6e31943cd4f21a31602eafb59ac07a1df3b67a91 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 18:24:33 2018 +0100 gtk: Fix memory leak. free buffer in error path. Found by clang scan. Change-Id: I7c271b74e3e5ac9d4f2a550f3c83988a4594133d Reviewed-on: https://code.wireshark.org/review/25416 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=257e7d19fd204d5a27a8adcdf50602… commit 257e7d19fd204d5a27a8adcdf50602738891b5c0 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 18:45:47 2018 +0100 gtk: fix multiple memory leaks in prefs_capture All leaks follow the same pattern if not gtk_tree_model_get_iter_first(), than memory allocated was not used/ freed. Put memory allocation under gtk_tree_model_get_iter_first() block. Found by clang scan. Change-Id: I8f9671ae5fb043343ab5dcdc39a57f1d28fec15b Reviewed-on: https://code.wireshark.org/review/25418 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=98305ba621f0e50199372fb31e4675… commit 98305ba621f0e50199372fb31e4675b594830af9 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Mon Jan 22 18:49:42 2018 +0100 packet-ieee80211: fix dead store/ dead increment and assignment. offset was not used after increment/assignment, just return it to relax clang. Found by clang scan. Change-Id: I21dece4e31075ca2da8d3ba942336fb4858636b6 Reviewed-on: https://code.wireshark.org/review/25419 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=ebc01bcce5f022662a516d0035bfda… commit ebc01bcce5f022662a516d0035bfda2e1a6b9bad Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Mon Jan 22 10:48:01 2018 +0000 release-notes: Add note about support of 802.11ax Change-Id: I361dceb79bed6c2a201db115dba1fad3cad2f659 Reviewed-on: https://code.wireshark.org/review/25414 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a6ae7f75714d6a7cb0f8d0ea2b1a4e… commit a6ae7f75714d6a7cb0f8d0ea2b1a4e649da59533 Author: Martin Boye Petersen <martinboyepetersen(a)gmail.com> Date: Sun Jan 21 21:17:08 2018 +0100 ZigBee: Add a preference to choose ZigBee Smart Energy version used for dissecting Some ZigBee commands within the Smart Energy Profile does not have the same payload across different specifications. With this preference it is possible to choose what version of the specification to use when dissecting payloads. The default version is set to the latest one, which is Smart Energy 1.4, even though it is still under development. Change-Id: Iaec5528f2a418aeec4e39cfa087a58e531570d42 Reviewed-on: https://code.wireshark.org/review/25409 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3e14d3b440eb85fce8e48d5d0326c6… commit 3e14d3b440eb85fce8e48d5d0326c60dff7fe10a Author: Anthony Coddington <anthony.coddington(a)endace.com> Date: Mon Jan 22 17:38:44 2018 +1300 ERF: Fix broken erf_open ethernet checking Was copying 8 byte extension header instead of 2 byte ethernet padding subheader. Introduced recently by I8ede5c733867ccc98ab2d470181d1e4a29ae5b49. Change-Id: I95a8604ed6204dff33f1794601342e090f6b7eb3 Reviewed-on: https://code.wireshark.org/review/25410 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6358aadfd62ffe24e3b8ba5b8b6b6a… commit 6358aadfd62ffe24e3b8ba5b8b6b6ac50d633f80 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Thu Jan 18 09:40:24 2018 -0800 ieee80211: 802.11ax support. This is based on Draft 2 of the standard. Draft 2 did not get approved, but is close to what the final version will be and support is needed now by the teams working on this. Change-Id: I837df05a288b815e1e455883f4f165721104d51f Reviewed-on: https://code.wireshark.org/review/24861 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4d639b6f0e78602678c59a0d6270d8… commit 4d639b6f0e78602678c59a0d6270d89835f3980e Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 17:45:02 2018 +0100 tap-httpstat: cast memory instead of reallocate it in glib hash table. Change-Id: I74db1247f15bdd12fb3ef7fa258d0018605caa30 Reviewed-on: https://code.wireshark.org/review/25346 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f0e1faac66b94f162a47623dc2ee16… commit f0e1faac66b94f162a47623dc2ee1673ad0c7606 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Jan 19 23:01:13 2018 +0100 QUIC: Add define value for Long Packet Type (Initial, Handshake...) Bug: 13881 Change-Id: Ia733a9e84e6a7dea58a62bcc1c9d79f51e5b46ff Reviewed-on: https://code.wireshark.org/review/25401 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=34a02eb70b892e06b2f33b8df6885a… commit 34a02eb70b892e06b2f33b8df6885aa46ed56b33 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Jan 19 22:40:13 2018 +0100 QUIC: Remove draft-05 and draft-06 All tools use draft-07 or draft-08 Bug: 13881 Change-Id: I539e34324f16149fe8c0d05d938bae1298b9eb15 Reviewed-on: https://code.wireshark.org/review/25399 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=68b20efb49ae90dc31f68783d0b8bf… commit 68b20efb49ae90dc31f68783d0b8bfe88560cef9 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Jan 19 22:46:44 2018 +0100 QUIC: Update IETF draft URL (draft-08) and add also IETF QUIC TLS (-08) draft Bug: 13881 Change-Id: I5662faeb5d1738c896ba66b6857e70baafd3afee Reviewed-on: https://code.wireshark.org/review/25400 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=00a528f1231a819ca06eda45b3d59d… commit 00a528f1231a819ca06eda45b3d59de9bd0221ac Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 18 23:02:12 2018 +0000 Qt: Translate files in subdirectories. Make sure we pass ui/qt/*/*.{cpp,h} to lupdate. Make update-tx a bash script and make sure it passes ShellCheck. Add a -n flag, which disables pushing back to Transifex. Change-Id: Ia7d6564bbdbf69285f1f9b88cde09e37da4f916c Reviewed-on: https://code.wireshark.org/review/25382 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=145e3a5dc3ad2c8191696fa4748b1f… commit 145e3a5dc3ad2c8191696fa4748b1f3d8352252c Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 19 11:02:07 2018 -0800 Qt: Proto tree fixes Make sure ProtoTree::toString stops at the right place. Don't emit fieldSelected when we're processing a context menu event. It doesn't appear to be needed and it triggers unwanted automatic scrolling when prefs.gui_auto_scroll_on_expand is enabled. Change-Id: I351a6974d07aea6fdd3eb0b5c1975a1b8d8eb7da Reviewed-on: https://code.wireshark.org/review/25396 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=73f5afb75fa211a6c5a4ca189b5f4a… commit 73f5afb75fa211a6c5a4ca189b5f4a15c87c9d73 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 18 10:45:43 2018 -0800 Qt: Implement ProtoTreeModel::flags. QTreeView checks to see if Qt::ItemNeverHasChildren is set in various places, particularly when updating its set of expanded items. Implement ProtoTreeModel::flags and set Qt::ItemNeverHasChildren when needed so that QTreeView won't mark a leaf node expanded. Otherwise ProtoTree::isExpanded will return true when it shouldn't and break the iterator in ProtoTree::toString. Bug: 14355 Change-Id: Id89be9911aa14dbbb52725f7203ac26a747c42fc Reviewed-on: https://code.wireshark.org/review/25376 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3efcc9bd53c65844397fa81c96c2a8… commit 3efcc9bd53c65844397fa81c96c2a86e71ac8ec4 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 18 08:31:58 2018 -0800 Qt: Create byte views at the proper zoom level. Add a zoomed argument to WiresharkApplication::monospaceFont so that we can easily fetch the font at its current zoom level. Set the zoomed font when we create new ByteViewTexts. Change-Id: I1293f206e37bb798247b1ac4b314fdfe88d4c55c Reviewed-on: https://code.wireshark.org/review/25371 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=064bec879791122aa8411de021d7c2… commit 064bec879791122aa8411de021d7c2a9444f8b33 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 19 16:02:20 2018 -0800 CMake: File copy updates. Switch from `xcopy`-ing single files to `cmake -E copy_if_different`-ing multiple files on Windows. Add a comment about using copy_if_different for our data files. Switch from `cmake -E copy` to `cmake -E copy_if_different` in a couple of other places. Change-Id: I6bf72f02a66c46a4440280305479f41ffb4e987a Reviewed-on: https://code.wireshark.org/review/25402 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=903c143769da90b78502971951e6a1… commit 903c143769da90b78502971951e6a1d681b7f8b7 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Fri Jan 19 21:20:38 2018 +0100 autotools: Rework the plugin Makefiles The plugin.c generation in an autotools build comes in from an included Makefile.am file. The various types of plugins need different parameters for the generation script. Put the plugin.c production rule is a seperate include file so each plugin type build can include its own variant. Also amend the README.plugins file with regards to the new directory structure and the fact that there are multiple types of plugins, not just dissector plugins. Change-Id: I3a815d0d767baa555356cf428861b18697401355 Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25398 Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j(a)v6e.pt> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=47351fb617aaa1be83d2b1db60dc31… commit 47351fb617aaa1be83d2b1db60dc31344c1d01d2 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sat Jan 20 13:26:13 2018 -0800 Qt: Initialize a struct (found by Coverity) CID: 1427679 Change-Id: I2ed276f0da413b4853b7dc9ccde3530e655ad760 Reviewed-on: https://code.wireshark.org/review/25403 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5242dd48b447d3151714aad4f8457c… commit 5242dd48b447d3151714aad4f8457c05f0649a9c Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Jan 21 08:18:39 2018 +0000 [Automatic update for 2018-01-21] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I60c7bef36988fd487d9088880b1d27818723f0b7 Reviewed-on: https://code.wireshark.org/review/25404 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c440a24b1b076ef71fbcc33565dbef… commit c440a24b1b076ef71fbcc33565dbefc3d0d763ed Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 12:33:53 2018 +0100 wiretap: use SPDX identifiers (partial work). Change-Id: I28436e003ce7fe31d53e6663f3cc7aca00845e4b Reviewed-on: https://code.wireshark.org/review/25392 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=9e3e02f5e5662b4edb4cd273305f82… commit 9e3e02f5e5662b4edb4cd273305f82000d84e039 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 15:34:23 2018 +0100 wiretap: more SPDX license convertions. Change-Id: I12695d0713b1d7fe58f09b2037303fab523085e9 Reviewed-on: https://code.wireshark.org/review/25394 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=731a901a3e25839ef3e0d89a0a21ed… commit 731a901a3e25839ef3e0d89a0a21edc69ae474df Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Fri Jan 19 06:57:56 2018 -0800 radiotap: Updates to the radiotap dissector to avoid confusion. If a field is indicated as not known, then display that field as reserved which will prevent people from searching for fields that are not known and makes more sense. Also, rename some of the hf fields to be more in line with standard practice. Change-Id: I5cbbd682acbea3713b7b19325fe1a36cc0e36aa1 Reviewed-on: https://code.wireshark.org/review/25397 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=655892c0a673bb3893b502c2bdab63… commit 655892c0a673bb3893b502c2bdab63dcb663fc08 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 18 14:07:57 2018 -0800 Qt: Force integer font metrics in the byte view. Force the layout engine to use integer arithmetic so that we don't run into wierd rounding artifacts. Include the leading when applying formats. Restrict the hover line width to either 0.5 or 1 logical pixels. Change-Id: Icc992e085e96e328ed4ed247271f75ddd69637bc Reviewed-on: https://code.wireshark.org/review/25381 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=8d06115dbf72f652d464ea80ffdabe… commit 8d06115dbf72f652d464ea80ffdabe2b1a0cb67e Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Fri Jan 19 07:25:27 2018 -0800 ieee1905: Bring AP Metric TLVs into conformance with the SPEC There was a missing field in the initial version of the spec. Add the flags bits that define the subsequenct fields. Change-Id: Ie237075f4f7f30adc4b280358fe5c985c63f5281 Reviewed-on: https://code.wireshark.org/review/25375 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=804c4b1653ff8d4f8f5471aa4c6f11… commit 804c4b1653ff8d4f8f5471aa4c6f114423ed5a66 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Jan 18 17:24:25 2018 +0100 Qt: add sanity check in InterfaceTreeCacheModel (found by clang). Change-Id: I8f73254d8ac4b560937431b592a81ad726ce43a9 Reviewed-on: https://code.wireshark.org/review/25370 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=24cd7a9a1fc0d5a845e99029647604… commit 24cd7a9a1fc0d5a845e99029647604877b492fdc Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Jan 18 18:29:24 2018 +0100 Qt: remove leak from PathChooserDelegate (found by clang). Change-Id: I71d73c8464450f8cbc655f8f99f54bd34eddd344 Reviewed-on: https://code.wireshark.org/review/25374 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8631ceaefc44bb2246f05cfbe5db8a… commit 8631ceaefc44bb2246f05cfbe5db8aedbcdefa78 Author: Roland Knall <roland.knall(a)br-automation.com> Date: Fri Jan 19 13:47:01 2018 +0100 epl: Correctly display the error for available bytes Don't break the remaining length by setting and invalid one Change-Id: Ia32798db73937ada6c99a6927cc87402603a9e75 Reviewed-on: https://code.wireshark.org/review/25391 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3438092b27b52c561dc2e5a8ca0b32… commit 3438092b27b52c561dc2e5a8ca0b322b0320658c Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 09:32:27 2018 +0100 file: free memory on exit (found by clang). Change-Id: I8d57ae2f6aa114f64d7cd11ca63ce6ae88fd4b68 Reviewed-on: https://code.wireshark.org/review/25385 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6d82ea91fd86bd2400617645b0937c… commit 6d82ea91fd86bd2400617645b0937c1581a1f81c Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Jan 19 12:04:02 2018 +0000 RVSP: fix typo found by conflict hf 'rsvp.template_filter.ipv4_tunnel_sender_address' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'rsvp.template_filter.sub_group_originator_id' exists multiple times with NOT compatible types: FT_UINT16 and FT_BYTES Change-Id: I922ef6742c7f340519adc6014ec37e29cb0e34c7 Reviewed-on: https://code.wireshark.org/review/25390 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1b5624a71814baa38d9019d2c2d2a7… commit 1b5624a71814baa38d9019d2c2d2a7e9d3437aeb Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 16:38:50 2018 +0100 plugin_if: don't allocate memory and cast it instead. Glib hash table can use integers as pointer by casting them using GINT_TO_POINTER. This prevents alloc/free of memory. Leak found by clang. Change-Id: Ieae4d1ec787e41aef0657d27bdaefe30d12e2b80 Reviewed-on: https://code.wireshark.org/review/25341 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a8d40532c328282a04d2dc940e902f… commit a8d40532c328282a04d2dc940e902f51bcf5adfd Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 10:38:05 2018 +0100 extcap: add g_free (found by clang). Change-Id: Ibb3f8e576f36447daeff7abe00153e0aa31e4022 Reviewed-on: https://code.wireshark.org/review/25389 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4444561ef83df484bb098af87afbe1… commit 4444561ef83df484bb098af87afbe1299f0c4f24 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 10:24:11 2018 +0100 tap-sctp: change if to switch for a default case (found by clang). Change-Id: I5158c1db63258e194cdad987529019069e537ab3 Reviewed-on: https://code.wireshark.org/review/25387 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b31cda28f7329a76b5eec1583a1844… commit b31cda28f7329a76b5eec1583a18441e8e7f86e4 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 19 10:38:50 2018 +0100 tap-wspstat: cast memory instead of allocate. Change-Id: Ia878a871702718093bd483fe83ecb9ba7328b7db Reviewed-on: https://code.wireshark.org/review/25386 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ceddf703883eedb26df1ee6f5e010b… commit ceddf703883eedb26df1ee6f5e010ba879733b05 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Jan 19 09:13:01 2018 +0000 wimax (plugins): fix no previous prototype for function 'proto_reg_handoff_wimax' [-Wmissing-prototypes] Change-Id: Icc79994ace4e32def3f03cf62b49f3c7dd3011df Reviewed-on: https://code.wireshark.org/review/25384 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1ea4abd838923b605b11401ad8a0e2… commit 1ea4abd838923b605b11401ad8a0e2fd085de6e0 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Fri Jan 19 10:33:17 2018 +0100 Be accurate in release notes Codecs in general come in many flavours, G.729 non in the least. Be accurate about what codec implementation is actually provided. Change-Id: I372062906bef973c8e19b63e5296574780d8a89e Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25388 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5b9e9b3fe3fdf2094405d88617a1de… commit 5b9e9b3fe3fdf2094405d88617a1debfbb2d5d73 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 18 23:06:24 2018 -0800 Don't do pcap heuristics on a pipe. Instead, just: assume a file with the regular pcap magic number is a regular pcap file, not an unhelpfully-modified-without-changing-the-magic-number format such as one of the (fortunately, short-lived) memory-mapped capture formats or the Nokia format; reject a file with the memory-mapped-capture-finally-changed-the- magic-number magic number, as they then changed the *new* format without changing its magic number; and don't even leave a provision for multiple formats using the "nanosecond pcap" magic number - not even when reading from a file - so we can punish bad behavior (which is what changing the format without changing the magic number is). This should get rid of the last place where, when reading a pcap file from a pipe, the first packet isn't displayed as soon as it arrives. Bug: 14345 Change-Id: I2fcb3354dc84cdd2d8ec749a0db883e56971c4b4 Reviewed-on: https://code.wireshark.org/review/25383 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ecced16299baab9d3066308c577577… commit ecced16299baab9d3066308c577577b8422a0eb0 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Jan 18 22:37:39 2018 +0100 S1AP: upgrade dissector to v15.0.0 Change-Id: I2c2a0f8093678769427ff4303ad41a5c97bdd05c Reviewed-on: https://code.wireshark.org/review/25379 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0870d4665d17ce2e7a1fe53362fb89… commit 0870d4665d17ce2e7a1fe53362fb89fb0231be38 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 18 14:12:42 2018 -0800 Remove an unnecessary test. out.next is initialized to point to the beginning of the buffer when a FILE_T is created, so it won't be null. Change-Id: Ib29f713ab3c524c9c7d83e8d9f3bef89fde1d5b5 Reviewed-on: https://code.wireshark.org/review/25380 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3eb253b74811992ea2ac0e0db4f489… commit 3eb253b74811992ea2ac0e0db4f4897a6f83220d Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 18 11:29:36 2018 -0800 Use separate pointers for the input expert info and the copy we make. That eliminates the need for qualifier-removing casts. Change-Id: I90728858ec43ddabf663f30258df6e9c41aa191a Reviewed-on: https://code.wireshark.org/review/25378 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b0c0490fe073b19e1d67d928bc22c6… commit b0c0490fe073b19e1d67d928bc22c64666f8a48b Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 18 11:19:36 2018 -0800 Don't overwrite the struct wtap_pkthdr; copy and change it instead. Do as we do in other cases - copy the current struct wtap_pkthdr to a temporary one (which might copy the temporary one to itself), modify it, and set the pointer to the struct wtap_pkthdr to point to the temporary one. Note all the places wherw we do this with a comment. Change-Id: Ia11df6b997a5369d96436d3bd825ab0138742504 Reviewed-on: https://code.wireshark.org/review/25377 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=682fe39422b01fe850a8718766766f… commit 682fe39422b01fe850a8718766766f5f32ecf908 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 18 08:46:41 2018 -0800 Qt: Fixup a cast. Change-Id: I25dbf6c91bd3ca1f16a01c937a3830010adcd197 Reviewed-on: https://code.wireshark.org/review/25373 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws(a)gmail.com> Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c5560babbd2656f49b5dc8a32f6c2e… commit c5560babbd2656f49b5dc8a32f6c2ea67a276d57 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 14:40:06 2018 +0100 Qt: return if cf_read_record() fails in PacketDialog (found by clang). Change-Id: I5187b378db9bae092052ce50b337f266e08e4332 Reviewed-on: https://code.wireshark.org/review/25340 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dcacea5c1542611bbd8ca3a403f909… commit dcacea5c1542611bbd8ca3a403f9099508aef67f Author: Prashanth Pai <ppai(a)redhat.com> Date: Tue Jan 16 14:42:42 2018 +0530 glusterfs: Add support for getvolumeinfo procedure Bug: 14347 Change-Id: Ib8fcaa5f0af06d1f1141dbb51696d88fde7d71ba Signed-off-by: Prashanth Pai <ppai(a)redhat.com> Reviewed-on: https://code.wireshark.org/review/25335 Tested-by: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Niels de Vos <ndevos(a)redhat.com> Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a6e64bfc78f2e8502dc616c5d23dd2… commit a6e64bfc78f2e8502dc616c5d23dd28186656291 Author: Matej Tkac <matej.tkac.mt(a)gmail.com> Date: Thu Jan 18 11:55:53 2018 +0100 [PFCP] Corrected Header Fields in Report Type IE Change-Id: If50a4bf79edd69d14015b4262d5195d581082cc4 Reviewed-on: https://code.wireshark.org/review/25367 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8791e0b61ff9a5b460932b16e77c70… commit 8791e0b61ff9a5b460932b16e77c7091a23f9c4e Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Jan 18 11:54:24 2018 +0100 3GPP NAS: rework PCO loop to better report extra data at the end of the payload This will help identifying that the packet contains unexpected data at the end rather than triggering a malformed error when trying to fetch outside of the tvb. Change-Id: Ieb71204f3c364e809447157e7a71c3eb92620d85 Reviewed-on: https://code.wireshark.org/review/25366 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=de0872971ad613b865464e160f30c4… commit de0872971ad613b865464e160f30c4c4f0519bc7 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Jan 15 21:54:17 2018 +0100 cmake: add ps.c to the checkAPI list with the proper path. This removes an error when running cmake target checkAPI_epan. No such file: "ps.c" at wireshark/tools/checkAPIs.pl line 2144. This error is related to out-of-tree builds. In-tree builds are not affected since the generated files live next to the versioned ones. Change-Id: I3a6b05eaf4b7bb703222c47233576d0cb77e66d1 Reviewed-on: https://code.wireshark.org/review/25330 Reviewed-by: João Valverde <j(a)v6e.pt> Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2996ef23044dc1e082c14675a9f3fe… commit 2996ef23044dc1e082c14675a9f3fee80661b7ad Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Jan 18 10:34:36 2018 +0100 LPP: upgrade dissector to v14.4.0 Change-Id: I87406dd9311bd6e379a38c66ec61c1c2d8d9412f Reviewed-on: https://code.wireshark.org/review/25365 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3a93855b05009a2ce679360dd52551… commit 3a93855b05009a2ce679360dd52551ed589bbc9e Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 23:33:03 2018 -0800 Make apply_profile_changes() return a non-const pointer. It returns a pointer to a g_mallocated string, which the caller has to free, so its return value shouldn't be a const pointer. Change-Id: I76f288379a5c1eff580c391bdc9019ab7fe8f336 Reviewed-on: https://code.wireshark.org/review/25364 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=be958a71160f09b537871712edda41… commit be958a71160f09b537871712edda417eae0c4464 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 17 23:34:00 2018 +0100 X2AP: upgrade dissector to v15.0.0 Change-Id: Ib2e01a19f5b4f37fcee7bdf3b2ed231c5606162a Reviewed-on: https://code.wireshark.org/review/25357 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6efce7db7c487a506230ac774965b7… commit 6efce7db7c487a506230ac774965b77a624ca54d Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 23:11:07 2018 -0800 Don't cast away constness. Change-Id: I76656dbb950589c8936a01574c747fc8f3a7f864 Reviewed-on: https://code.wireshark.org/review/25363 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c327f7d599d417cef0c80be2a61276… commit c327f7d599d417cef0c80be2a6127654d6562282 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 22:08:46 2018 -0800 Constify some pointers. Change-Id: I4f443f777c92fa62fbe2448e891ba93d02fde3ad Reviewed-on: https://code.wireshark.org/review/25362 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d9158e680a6c9f3380190eadd3d049… commit d9158e680a6c9f3380190eadd3d049c3d398898a Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 17 16:49:21 2018 +0100 sharkd: set uninitialized values (found by clang). Change-Id: Ie68c23be4e40b815c995008a43e3c5443a9de5f6 Reviewed-on: https://code.wireshark.org/review/25353 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=afcff2dcd1c5e10e634c8310791d59… commit afcff2dcd1c5e10e634c8310791d59969e70045e Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 12:43:34 2018 +0100 sharkd: check for NULL before dereference (found by clang). Change-Id: If49504b3360e325555a624b11a43ac30884748c9 Reviewed-on: https://code.wireshark.org/review/25337 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=48b4b3bdad38d0a2c597b50cea1e18… commit 48b4b3bdad38d0a2c597b50cea1e18c60614d091 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 17 15:00:03 2018 +0100 dcerpc: remove use-after-free (found by clang). Change-Id: I6db7e47fc5e67afcad78763cb739a3f13a47b923 Reviewed-on: https://code.wireshark.org/review/25352 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c3e6597f2034c183f74258c1dd0314… commit c3e6597f2034c183f74258c1dd03146c98d4688b Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 17 14:54:36 2018 +0100 file: stop printing packets if 0 columns are asked (found by clang). This prevents a 0 bytes memory allocation (line 2383/4) and its subsequent dereference (line 2399). Change-Id: Ie88293699a55b9b48afe23d7371798e709bc1eaa Reviewed-on: https://code.wireshark.org/review/25351 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e6d47cb7b3319f134dcc2a38885d19… commit e6d47cb7b3319f134dcc2a38885d1917218f6e7a Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 22:00:30 2018 -0800 Don't cast away constness if it's not necessary. Change-Id: Ic5ecf4628f03c63b68fadd9ffed49cfd5497d99c Reviewed-on: https://code.wireshark.org/review/25361 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a6167ef73d8eb458996a20ec530f00… commit a6167ef73d8eb458996a20ec530f003a994d283f Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 21:51:12 2018 -0800 Don't cast away constness if it's not necessary. Change-Id: Ie87983f5cbe38266e4f522613b21d25d67ef328f Reviewed-on: https://code.wireshark.org/review/25360 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=eec528cc70632469b94896474644e1… commit eec528cc70632469b94896474644e1b67d7b37dd Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 21:47:49 2018 -0800 Make a pointer const that has no need not to be const. Change-Id: I32c86988823fcea96239b199bf21b98ee3ec8a5e Reviewed-on: https://code.wireshark.org/review/25359 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ab6d2c6ac364577e49baa52b7b00d1… commit ab6d2c6ac364577e49baa52b7b00d1a91d3a1a50 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 17 20:02:56 2018 -0800 Don't insist on reading a full buffer from the input file. Don't loop trying to read a full buffer from the input file. If you're reading from a file, on UN*X or Windows, you should get the entire read count unless you're fewer than buffer-size bytes from the end of the file, in which case you should get what remains in the file. If you're reading from a pipe, however, that could cause you to block longer than necessary waiting for a full buffer rather than just for the next chunk of data from the pipe - which might not be a bufferful, if the program writing to the file is itself writing less-than-bufferful chunks, as may be the case in, for example, a pipeline coming from a live capture and with the intent that TShark display the packets as they arrive. While we're at it, if we're trying to do a seek and the seek takes place within the buffer of uncompressed data, just adjust the position within that buffer for forward seeks as well as backward seeks; this substantially reduces the number of ws_lseek64() calls when making a sequential pass through the file in Wireshark (e.g., running a tap or filtering the display) and, as we purge the buffer after the ws_lseek64(), substantically reduces the number of ws_read() calls in that situation as well. Have a data structure for a file data buffer, and use it for both the "input" (compressed data) and "output" (uncompressed data) buffers. Rename raw_read() to buf_read(), as it reads into a buffer. Change-Id: I7982b3499a7613a993913a6db887054730764160 Ping-Bug: 14345 Reviewed-on: https://code.wireshark.org/review/25358 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0bb501a6554bd54540abada98936d1… commit 0bb501a6554bd54540abada98936d1f5ce8ae4c1 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 17 10:32:11 2018 -0800 Qt: Fix bits highlighting in the byte view. When the byte view is set to "Show bytes as bits" make sure we highlight all eight bits instead of just two. Change-Id: I1ece65032fa32f7274f4e7383e538b92e8fa4f65 Reviewed-on: https://code.wireshark.org/review/25354 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0aad2bbc360d8a3ad7b610067c9f04… commit 0aad2bbc360d8a3ad7b610067c9f04ab0f681b91 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 17 13:50:56 2018 -0800 Qt: I/O graph fixes. Use Qt::DecorationRole when setting and getting a color and Qt::CheckStateRole when setting and getting the check state of UatModel items. Add a default role for UatModel::data. Convert between value strings and their respective values where needed. Bug: 14317 Change-Id: Idd3eb773dc9944f982f6dbd7d49f73f4a60dd5a2 Reviewed-on: https://code.wireshark.org/review/25355 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d86f8202067e3671d2039a315e1abb… commit d86f8202067e3671d2039a315e1abbd8cd6f1db9 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Jan 17 13:38:41 2018 +0100 coap: Change Uri-Path from hidden to generated This field is generated so mark it so. It may also be usable so make it visible. Change-Id: I10d951f234f1fba240059bc791b40d25dede07a9 Reviewed-on: https://code.wireshark.org/review/25350 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d1254247b7db596cc3863652e2093f… commit d1254247b7db596cc3863652e2093f7d0e79d402 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 16 16:41:36 2018 -0800 Qt: ByteViewText hover fixes & updates. Add back field highlighting during hover. Instead of marking hovered bytes using an underline+overline, draw a border rect. Change-Id: I574dd074cfa021ac0dec3cdea6c5f9b0b4da6d0e Reviewed-on: https://code.wireshark.org/review/25348 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=34381ed20c7e1005dec1e13ab90edd… commit 34381ed20c7e1005dec1e13ab90edd736238f2d7 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 14:11:58 2018 +0100 stat_tap: don't use-after-free (found by clang). Change-Id: Ie7304ad70c8cf3ac62abdf07aaa94d12c409f1b0 Reviewed-on: https://code.wireshark.org/review/25339 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f3b71f597c0da82217643ff8ae3735… commit f3b71f597c0da82217643ff8ae37354308070134 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 16 12:06:33 2018 -0800 Wiretap: Add a missing comma. Found via CID 1427615. Change-Id: I519b3905d33b0b2aa3ce164810b9e6358f6df1bd Reviewed-on: https://code.wireshark.org/review/25347 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2f759ce7a7afb58f86006aaefcf475… commit 2f759ce7a7afb58f86006aaefcf475941e5a9e05 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Tue Jan 16 16:59:28 2018 +0100 Update paths after dissector plugin move. With the change in paths of the dissector plugins in the repository some other paths require adjustment. These are the obvious changes remaining. Change-Id: Id49ac6aaf1a29d9eb37f4c32226a4597d5e32edd Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25343 Reviewed-by: João Valverde <j(a)v6e.pt> Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=634ba24b0aca74a547503556f89a69… commit 634ba24b0aca74a547503556f89a6928cb89ee20 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 17:05:54 2018 +0100 capchild: free memory on error. Change-Id: If2cd8d344dced80b16789744a0b504c505ba0824 Reviewed-on: https://code.wireshark.org/review/25344 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d77d5c9d206a1c395ac4762938d6dd… commit d77d5c9d206a1c395ac4762938d6ddf19e92f314 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 16 17:28:56 2018 +0100 Qt: add more sanity checks in utils (found by clang). Ensure the pointer exist before dereference them. Change-Id: I7c2881c9c74b88517d01d9306507c14ff2a7b257 Reviewed-on: https://code.wireshark.org/review/25345 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=107a91a8cc283f648552a4924fade2… commit 107a91a8cc283f648552a4924fade2216670fb23 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 15 17:13:45 2018 -0800 Qt: Fix proto tree links and related frames. Add FieldInformation::isLink and use it to style link items. Add back a related frame information. Get rid of rowsInserted() and just visit each tree node starting from the root. Change-Id: I0e7ef6b2e11d25465705adffbb77d6f6cfb2a435 Reviewed-on: https://code.wireshark.org/review/25342 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=96e865b4b80595b49edfe294729ac7… commit 96e865b4b80595b49edfe294729ac7de054fe33c Author: Michalis Kapsalakis <kapsalis1989(a)gmail.com> Date: Tue Jan 16 13:06:38 2018 +0100 EtherCAT: Add Mailbox as a string in EtherCAT Frame Types. This commit adds the missing mailbox type to the EthercatFrameTypes array. Change-Id: I0710b723cdfa6cff28b6655729dafb68678518cb Reviewed-on: https://code.wireshark.org/review/25338 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5352ef42f94b5c14a24eb2e5559440… commit 5352ef42f94b5c14a24eb2e5559440c71fdcae8f Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Mon Jan 15 12:40:55 2018 +0000 plugins: Add source tree subfolder for plugin library This allows some simplification and makes things more consistent, particularly for loading plugins from the build dir. Also fixes the issue reported here: https://www.wireshark.org/lists/wireshark-dev/201801/msg00061.html Change-Id: I0d8a000ee679172bccad546a3b0c47a79486f44d Reviewed-on: https://code.wireshark.org/review/25329 Petri-Dish: João Valverde <j(a)v6e.pt> Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=a069a4f856c29b25bae05f2a91d7b2… commit a069a4f856c29b25bae05f2a91d7b2b71e1905f3 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Mon Jan 15 19:37:56 2018 -0800 ieee80211: Add support for EAPOL Key MIC lengths other than 16. This allows the user to override the EAPOL Key MIC length for those crypto suites where the Key MIC length is greater than 16 bytes. This works in the DPP case where the Key MIC length is supposed to be the same as the Nonce length. Change-Id: I8ef6bc978e0a44ece0e95d76b231a02c7f15c89b Reviewed-on: https://code.wireshark.org/review/25332 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a165a80452a49ef383a313b21ebc02… commit a165a80452a49ef383a313b21ebc02925104abaf Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Dec 25 23:33:55 2017 +0100 dumpcap: remove dead code (CID: 1188011). Change-Id: I55149733ae420d32c6dd86c3c61baef57cc2082f Reviewed-on: https://code.wireshark.org/review/24996 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e861a112103ed4d1f2fa153932bcf8… commit e861a112103ed4d1f2fa153932bcf86f120e3907 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 10 23:20:36 2018 +0100 ui: check g_malloc return (found by clang scan). Change-Id: I96df8a87f5f213fc1b77c485899cf373987413ac Reviewed-on: https://code.wireshark.org/review/25252 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d3c6cdde5bf5ade070f3d3ecf66b74… commit d3c6cdde5bf5ade070f3d3ecf66b74f32e8ad9a8 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Mon Jan 15 09:16:57 2018 +0100 QUIC: fix Padding Frame Padding frame can be anywhere on QUIC payload Add loop check if it is always padding frame (0x00) Bug: 13881 Change-Id: I3d50e5347aeca9738aeac3287ddba7fd30fc72b1 Reviewed-on: https://code.wireshark.org/review/25324 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9937973431a01b9711a17fbe8aa0d2… commit 9937973431a01b9711a17fbe8aa0d2f6f2755032 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Jan 15 17:51:55 2018 +0100 [VoIP calls] Make ISUP over M3UA work. I'm not sure how this tap_base_to_id() works but this seems to fix the problem. Change-Id: I98663a9560a38de03c130181dfa43b43befc612f Reviewed-on: https://code.wireshark.org/review/25327 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6b2764a41e5b7aac4a161d4dd8309d… commit 6b2764a41e5b7aac4a161d4dd8309dfb3b48e333 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 15 10:18:48 2018 -0800 ProtoTree behavior fixes. Sync our expansion state for every node since we might have mixed expanded/collapsed hierarchies. Move the prefs.gui_auto_scroll_on_expand code from expand() to its own function (autoScrollTo()). Rename expand() and collapse() to syncExpanded() and syncCollapsed(). We can update tree_is_expanded without overriding our base class. Ping-Bug: 14340 Change-Id: Ibf758809ea26dcc3f79bd0201168fae35d7cce8d Reviewed-on: https://code.wireshark.org/review/25328 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e502d933c5d0c116b3c3a3f9a25b15… commit e502d933c5d0c116b3c3a3f9a25b1547392c3689 Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt> Date: Mon Jan 15 21:59:10 2018 +0000 CMake: Remove incorrect comment Change-Id: Ie58b172f5c465d92d8100ac39cfd8c905586e9f7 Reviewed-on: https://code.wireshark.org/review/25331 Reviewed-by: João Valverde <j(a)v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=ef7d5daf420f2932da5f82396b3e25… commit ef7d5daf420f2932da5f82396b3e258d8bec21e6 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 09:13:09 2018 +0100 Qt: add assert to avoid null dereference (CID: 1427426). Change-Id: Ib3a5830a4ae07ebb9bd2657599d668af03c896c8 Reviewed-on: https://code.wireshark.org/review/25275 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1b9de188ff78beaaac89aca32ca0e0… commit 1b9de188ff78beaaac89aca32ca0e0f98dd98503 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Jan 15 14:49:51 2018 +0100 [SIP] Display tel uri in VoIP calls. Change-Id: I0a4eb85abd75ed706ea519371f2c62b172c05297 Reviewed-on: https://code.wireshark.org/review/25326 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=282436a762927a5a5831c78de6133a… commit 282436a762927a5a5831c78de6133add25b5d566 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Jan 15 12:26:22 2018 +0100 Qt: rename index to tab_index to pacify checkAPI. Change-Id: Ib171c835ca1e2a3b00ac6d6d495b41c70084b52f Reviewed-on: https://code.wireshark.org/review/25325 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=43833239fc2fc0e109743abc69dd39… commit 43833239fc2fc0e109743abc69dd39226b0caf7b Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Jan 15 08:53:55 2018 +0100 Qt: change obsolete qVariantFromValue into QVariant::fromValue. Change-Id: I767b06c0e316347cdb28b769f1032e6d44cba45b Reviewed-on: https://code.wireshark.org/review/25321 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Roland Knall <rknall(a)gmail.com> Reviewed-by: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=56a991710bf6dbd64080c5795eec46… commit 56a991710bf6dbd64080c5795eec4609c9360f4e Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Jan 14 15:37:16 2018 -0500 Bugfix VoipCallsDialog tap handling voip's special tap unregistering should be happening when WiresharkDialog unregisters its taps. Change-Id: I8f28b1ed31617b47870cb7a429d43f52fb8c4a86 Reviewed-on: https://code.wireshark.org/review/25294 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2f31016e6c292899c36f90c736c0c8… commit 2f31016e6c292899c36f90c736c0c84fbe9ee539 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Jan 14 12:23:07 2018 -0800 Qt: Expand subtrees when a packet is selected. ProtoTree::rowsInserted was expanding top-level items properly but not subtrees. Make sure we do so. Bug: 14340 Change-Id: I6c73fd09643b52d43014352816d0dd4838dbcb1d Reviewed-on: https://code.wireshark.org/review/25316 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e2ab8151b6255dce8f3e841f9b17e4… commit e2ab8151b6255dce8f3e841f9b17e487f4ba05d2 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Mon Jan 15 08:16:18 2018 +0100 QUIC(TLS): Add new error code from draft-07 Bug: 13881 Change-Id: I7ef7fd2081d74991219e40f695635e4c00d20365 Reviewed-on: https://code.wireshark.org/review/25320 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=39e612dee8ab97c1361f174ffdb360… commit 39e612dee8ab97c1361f174ffdb3608189be0631 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Jan 14 20:58:28 2018 +0100 radius: Sync with FreeRADIUS commit 671cf8c3956c137ee089b7647cd81c182e201ef5 Author: Alan T. DeKok <aland(a)freeradius.org> Date: Fri Jan 12 10:34:11 2018 -0500 these attributes are "string". Fixes #2130 Change-Id: I0656f699958f583215551b3be2b2ab3dfdea6cfb Reviewed-on: https://code.wireshark.org/review/25313 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=df9044794ab9f842d45babc04dcc11… commit df9044794ab9f842d45babc04dcc110354158e71 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Jan 14 16:05:32 2018 -0800 Test explicitly against 0 for integers and NULL for pointers, but not booleans. That makes it clearer what's being tested, and makes the tests more consistent, so we're always, not just sometimes, testing that way. Change-Id: Ifac4a86d16d0652d04db3dec572c11e1335c945d Reviewed-on: https://code.wireshark.org/review/25318 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1d1e511ed9e2312f7f2b667e4b7b8b… commit 1d1e511ed9e2312f7f2b667e4b7b8b48a33a1556 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Jan 14 15:47:22 2018 -0800 Add a URL for RFC 1952. Change-Id: I951829e173ef7a37ea1de7576ff919470e746974 Reviewed-on: https://code.wireshark.org/review/25317 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6b4d1cf931c31edcd6dc27a4c20fb9… commit 6b4d1cf931c31edcd6dc27a4c20fb90a76bf122f Author: Michael Mann <mmann78(a)netscape.net> Date: Fri Jan 12 12:50:52 2018 -0500 InterfaceFrame: don't use pointers for models Change-Id: I6d41ba89006abb8f8e703f6d703370169062f7e9 Reviewed-on: https://code.wireshark.org/review/25285 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9cc00c562369fe0b9149eb2aeee090… commit 9cc00c562369fe0b9149eb2aeee090cf52167285 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Jan 14 13:07:17 2018 -0800 Check for gzipped files even if we don't have libz. If we aren't built with libz, report a new "decompression not supported" error if the file is gzipped; the problem isn't that it's a new capture file format we don't support, it's that a *compressed* capture file, in some format, but we don't support the *compression* format used. This can be extended if we add support for other compression formats. Change-Id: I19239525d4e02357e3ca7189996556839af8fce2 Reviewed-on: https://code.wireshark.org/review/25315 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c3190d9d70febdd1dbc15269e970f3… commit c3190d9d70febdd1dbc15269e970f32aeda33f76 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Jan 14 12:39:24 2018 -0800 Fix build with libz not configured in. Change-Id: I1a336eb5a19ddc9215a9598d176794cfa214863c Reviewed-on: https://code.wireshark.org/review/25314 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2cfceb2700c9af0ea0f6429f214116… commit 2cfceb2700c9af0ea0f6429f214116e9d90b43d8 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Sun Jan 14 16:38:55 2018 +0100 sharkd: keep filtered data in GHashTable. Change-Id: Ica0d953d93e35eab88b27a4d6bb8fbb75edb7e27 Reviewed-on: https://code.wireshark.org/review/25312 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=2c3c49cd374050bcc30145c929a1dd… commit 2c3c49cd374050bcc30145c929a1dd9eef019cc5 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Jan 14 15:29:26 2018 +0100 ssl: fix reassembly for very small TCP segments A capture with a Server Hello failed to be dissected because the record was split in TCP segments of one byte each. This resulted in a "Malformed Packet" exception because ssl_looks_like_sslv2 looks at the third byte which. To fix this, ensure that at least the size of a TLS record is available. Change-Id: I8558028a28169020bc6549fdac29e07ecedf6ce2 Reviewed-on: https://code.wireshark.org/review/25310 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e8089003caf0ab2eb1f2afa2d54842… commit e8089003caf0ab2eb1f2afa2d548422cb4377ab9 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Jan 14 13:44:38 2018 +0100 TLS13: update for draft -23 (new version and extensions) Renumber key_share extension, display the old codepoint as "Reserved (key_share)" in case an older draft version is loaded. The old codepoint (40) was apparently used for different purposes: https://www.ietf.org/mail-archive/web/tls/current/msg25168.html Add a new "signature_algorithms_cert" extension which is similar to "signature_algorithms", except that it advertises the supported algorithms in certificates rather than handshake messages. Change-Id: Ibbb09100e2540deea8f652ba0685feadb68f33e7 Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/25309 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d06b60db7151a6d79697866da15afa… commit d06b60db7151a6d79697866da15afa23cd99c703 Author: Alexander Gryanko <xpahos(a)gmail.com> Date: Sat Nov 18 05:09:50 2017 +0300 http2: headers filter with UAT support Make HTTP2 headers filterable. Change-Id: I1a1a42ccdb41461f048e9ae462421ecad79da61b Reviewed-on: https://code.wireshark.org/review/24475 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=9922dc263ea7f5584dc20003e998ad… commit 9922dc263ea7f5584dc20003e998ad69812a8988 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 18:27:21 2017 +0100 firewall_rules: rewrite all the defines (CID: 1158734). Change-Id: I7d39fe8eccb853723b75318590cbcfca8655245f Reviewed-on: https://code.wireshark.org/review/25016 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=db5d4e10de0b603330523b4ef9b81d… commit db5d4e10de0b603330523b4ef9b81d6fdce18ecc Author: Anton Glukhov <anton.a.glukhov(a)gmail.com> Date: Fri Jan 12 18:51:58 2018 +0100 Fix lldp 802.3br typo Change-Id: I8b69922c2bbb7905480277e7b28d9894453e785b Signed-off-by: Anton Glukhov <anton.a.glukhov(a)gmail.com> Reviewed-on: https://code.wireshark.org/review/25284 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=57230a2e8ca2287beeefff93477aca… commit 57230a2e8ca2287beeefff93477aca344af845d4 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Sat Jan 13 13:23:01 2018 +0100 Qt: Reword text shown when no interfaces displayed Change-Id: Ic5ba4e562fe031b95fd2a7ab2d86de9bc09d5311 Reviewed-on: https://code.wireshark.org/review/25300 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=df45d5b1acb0ed76c06d09ae82a46f… commit df45d5b1acb0ed76c06d09ae82a46fbaf3795593 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 21:17:31 2018 +0100 extcap: check preference in extcap_ensure_interface(). Change-Id: I2b854b410e54b9f85ce26212d908c474f4611929 Reviewed-on: https://code.wireshark.org/review/25289 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=73f26e4d24b5b05d816cd5c301c958… commit 73f26e4d24b5b05d816cd5c301c958b6049c550a Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 19:04:34 2018 +0100 extcap: check preference in extcap_loaded_interfaces(). Change-Id: Ie1fd214eb8f9d55f1ce400b7227ad9887f05da76 Reviewed-on: https://code.wireshark.org/review/25286 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7bf0620eb5848cf0a13e4a3b6eee45… commit 7bf0620eb5848cf0a13e4a3b6eee45f880d8dd01 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Jan 14 08:15:59 2018 +0000 [Automatic update for 2018-01-14] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie096b93a5c9476d763fb6677d0d9ab54c3c4744c Reviewed-on: https://code.wireshark.org/review/25306 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ae199f2eb9f7b104e5aeaeea6301cc… commit ae199f2eb9f7b104e5aeaeea6301cc025dba23e3 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Jan 13 19:14:14 2018 -0800 Add packet-nr-rrc.h to the list of headers. Change-Id: I7c59fef73a267aeb427eafff1e12e0b2b5ee05a1 Reviewed-on: https://code.wireshark.org/review/25305 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c634a73c95ee11a09e84dbc40e10ae… commit c634a73c95ee11a09e84dbc40e10aec24ffddc36 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sat Jan 13 18:34:14 2018 +0100 LTE RRC: upgrade dissector to v15.0.1 Change-Id: If0b6fe029b5f852250fde36ead5dc5bb03d44e28 Reviewed-on: https://code.wireshark.org/review/25304 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bd857b6a9cddffa0412044bad85d88… commit bd857b6a9cddffa0412044bad85d88db5b3c0468 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Sat Jan 13 13:46:09 2018 +0100 Qt: Use the text "Initializing external capture plugins" Change-Id: Ic46dc0220722bf6ae3af857dcdac83d451772262 Reviewed-on: https://code.wireshark.org/review/25301 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=d1db7f1edfabdc4da52b46b7251e81… commit d1db7f1edfabdc4da52b46b7251e8118fec7a57d Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Fri Jan 12 22:12:08 2018 +0100 NTP: Updated system and peer status codes Used reference: https://tools.ietf.org/html/draft-ietf-ntp-mode-6-cmds-03 http://doc.ntp.org/current-stable/decode.html Bug: 14271 Change-Id: Iab829e31206f99b3458f68c6c65cc6188916a3bb Reviewed-on: https://code.wireshark.org/review/25296 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=98f41223981f667deeae57aea200c1… commit 98f41223981f667deeae57aea200c12d6e108900 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Sat Jan 13 13:21:09 2018 +0100 Qt: Put all startup time logs in DEBUG_STARTUP_TIME Change-Id: I545674ecae45458860627f8cf430b6fa524274fd Reviewed-on: https://code.wireshark.org/review/25299 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=55553f1a38d6e016affcacd0d406ae… commit 55553f1a38d6e016affcacd0d406aedbb77692b2 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Sat Jan 13 13:19:18 2018 +0100 Qt: Don't use the term "extcap" interfaces in UI Use the term "external capture interfaces". Change-Id: I216ce2273737b58e4922c476416333ba16d6cb30 Reviewed-on: https://code.wireshark.org/review/25298 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9dfd17b104fd048aa07ab2ae5b87bf… commit 9dfd17b104fd048aa07ab2ae5b87bfd94b07c807 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Sat Jan 13 12:46:45 2018 +0100 UMTS MAC: protect against an out of bounds access Bug: 14339 Change-Id: Idd145b00218fb37c0c193df5af2f89a9503a036e Reviewed-on: https://code.wireshark.org/review/25297 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4fdf79332798732a18dbf1877c4635… commit 4fdf79332798732a18dbf1877c46353cd1b6250b Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 12 15:14:17 2018 -0800 PortableApps: Exclude a bunch of files. Add fuzzshark.exe idl2wrs.exe lemon.exe make- test.exe uninstall.exe to the xcopy exlusion patterns. Change-Id: Ibf7b4711a51b9eca2b5947edc8d3d007c718a395 Reviewed-on: https://code.wireshark.org/review/25291 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e5eb3e480dd2d1212e969a39ae238d… commit e5eb3e480dd2d1212e969a39ae238df8c59c79e8 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Fri Jan 12 17:34:08 2018 -0800 ieee1905: More changes from the recent bakathon including two more TLVs. Change-Id: I010c9aa1a3ad7c599a6de13ac79320233698426b Reviewed-on: https://code.wireshark.org/review/25293 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=807a6c93d8c04403c10196ae3ba2b9… commit 807a6c93d8c04403c10196ae3ba2b96136899e96 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 12 14:05:14 2018 -0800 netfilter: Make sure our bitmask field arrays are NULL terminated. Add a trailing NULLs so that we don't read past the end of hfi_nfct_attr_status_flags and hfi_nfexp_attr_flags_bitfield. Bug: 14336 Change-Id: I1e96a89f60df2d653c4f3ad63f29cf57eb0224a5 Reviewed-on: https://code.wireshark.org/review/25290 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=777932efc61a62d6ad56ecd620a769… commit 777932efc61a62d6ad56ecd620a76972e438478a Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 12 15:46:38 2018 -0800 make-dissectors depends on copy_cli_dlls. Have the make-dissectors CMake target explicitly depend on copy_cli_dlls, otherwise we might try to create dissectors.c before libglib-2.0-0.dll has been copied into place. It looks like this is what's been causing our random Windows PD failures. Change-Id: Ia2445f17abd2c73113ab269ba6c606f48e724d93 Reviewed-on: https://code.wireshark.org/review/25292 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=554d3c9cd206827d066bc650109077… commit 554d3c9cd206827d066bc65010907750fdd01199 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 21:16:11 2018 +0100 Qt: fix compilation without pcap. Change-Id: If4ee4908b66a05fba1dba653ba887caa559aa7c2 Reviewed-on: https://code.wireshark.org/review/25288 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3fb92333aeb8134b2afaacf4c72170… commit 3fb92333aeb8134b2afaacf4c721704947552b82 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 12 10:51:33 2018 -0800 Qt: Add some translation hints. Add translation hints for the PrefsModel names. Change-Id: I003bea668cdb3340182227722cef42f7007bba1e Reviewed-on: https://code.wireshark.org/review/25287 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ff58d9bca21271910571fbb11bed8… commit 7ff58d9bca21271910571fbb11bed80cfac16083 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 08:55:14 2018 +0100 ctdb: don't dereference a null ptr (CID: 1427427). Change-Id: Icb20a3c496e76be530a7c72336bf3b866d6edfcd Reviewed-on: https://code.wireshark.org/review/25274 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=42100cb868eb3c50c7752f2adaf396… commit 42100cb868eb3c50c7752f2adaf396bda6e894a1 Author: Roland Knall <roland.knall(a)br-automation.com> Date: Fri Jan 12 13:15:58 2018 +0100 Qt: add info for extcap disabled in main window. Add an item to the end of the interface list, if the extcap interfaces have been disabled. Change-Id: I2643efb5dda9045e9e00fa3f815014f26a78085f Reviewed-on: https://code.wireshark.org/review/25218 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f98cf967bd38eb52a321321cb555c0… commit f98cf967bd38eb52a321321cb555c0c302a14318 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Fri Jan 12 14:04:10 2018 +0100 NTP: Decode data of opcodes 8,9,10,11,12 Decode additional data of NTP opcodes 8,9,10,11,12 only as one string. There's room for improvement to dissect the string for all the name=value pairs. To do so more samples of different implementations are needed. Used reference: * https://tools.ietf.org/html/draft-ietf-ntp-mode-6-cmds-03 * http://doc.ntp.org/ * sample captures attached to bug Bug: 14270 Change-Id: I4da537bf2a984b673845333714d8a8cb873f3147 Reviewed-on: https://code.wireshark.org/review/25281 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2d7c2421f6f87440332617870b620e… commit 2d7c2421f6f87440332617870b620e6ecb16a031 Author: AndersBroman <anders.broman(a)ericsson.com> Date: Fri Jan 12 14:34:07 2018 +0100 [Diameter] Add command code 8388637 and 8388638. Change-Id: Ia135204ba4931ca0805f49b99b937a6185807ca2 Reviewed-on: https://code.wireshark.org/review/25282 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b08dc851c768f9f365127546f66414… commit b08dc851c768f9f365127546f66414a00eca46bd Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 11:21:57 2018 +0100 prefs: init capture_no_extcap. Change-Id: Id5706f5268735e051dbd8e824ab909e91fea691b Reviewed-on: https://code.wireshark.org/review/25279 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ac9c89de65f29411c435a3ed38abf3… commit ac9c89de65f29411c435a3ed38abf333fd7b1b09 Author: Roland Knall <roland.knall(a)br-automation.com> Date: Fri Jan 12 13:15:20 2018 +0100 Qt: Add InfoProxyModel Add an identity model, which can be used to display non-selectable information at the end of any list Change-Id: Iaca436f34cb8e5b251eb0dc00ea2c0ce1bd9e0e2 Reviewed-on: https://code.wireshark.org/review/25280 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c1301a486217f0027e11ae90816006… commit c1301a486217f0027e11ae90816006f723bf4b9e Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 10:06:12 2018 +0100 extcap: add more checks for extcap disabled. Change-Id: I914efbb4293518a8a3f8aaa8739c9915c63d941c Reviewed-on: https://code.wireshark.org/review/25278 Petri-Dish: Roland Knall <rknall(a)gmail.com> Reviewed-by: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9b705928c2088a2c380800eed72c04… commit 9b705928c2088a2c380800eed72c04b5b730ff92 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Jan 12 10:22:07 2018 +0100 Lustre: add missing NULL terminator to flags lists Bug: 14331 Change-Id: I439b1fe36ecb2e063146d7aebf517d842d4f8a4c Reviewed-on: https://code.wireshark.org/review/25277 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f942ad09f67f1467b11f678d9c17ec… commit f942ad09f67f1467b11f678d9c17ecedb0b3db45 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Jan 12 09:47:58 2018 +0100 Qt: add initializer (CID: 1427425). Change-Id: Id476db10688f8b06bf6e8499a6e011f8605c66c0 Reviewed-on: https://code.wireshark.org/review/25276 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4df45ca7ced59a0d6dcc603d898e6c… commit 4df45ca7ced59a0d6dcc603d898e6cc41bfc2aed Author: Nick James <mookito(a)tuta.io> Date: Thu Jan 11 18:50:51 2018 +0200 FP: Removed channels UAT This UAT was limited (allowed configuring RACH channels only) and hasn't been extended for 4 years now. There is also a heuristic dissector for RACH channels so pre-configuring them is unnecessary. Change-Id: I266d2a0aba179318e1c28e0d5bc2b60860962fb2 Reviewed-on: https://code.wireshark.org/review/25270 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ddf8d8704d333454ca0e8ba3650835… commit ddf8d8704d333454ca0e8ba3650835aa86f6abfc Author: AndersBroman <anders.broman(a)ericsson.com> Date: Thu Jan 11 13:47:08 2018 +0100 [Thrift] Make it easier to make specific Thrift dissectors Introduce functionallity simmilar to packet-ber.c Change-Id: Ibb76e2db870c9a9dd8b26067b59a20044aafbd85 Reviewed-on: https://code.wireshark.org/review/25266 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a106c762efecc9ed00cae26dac02b1… commit a106c762efecc9ed00cae26dac02b19359b8dcf8 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 11 08:27:52 2018 -0800 Test: Fix the plugin check. Change-Id: I9724fa36070635bfd1392167eb362cf8631611fa Reviewed-on: https://code.wireshark.org/review/25267 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=690f1c3c400f46a19bef82aeeb1521… commit 690f1c3c400f46a19bef82aeeb15210667ad0843 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 10 12:43:50 2018 -0800 Qt: Adjust About box column sizing. Setting column sizes when we resize will clobber any adjustments made by the user. Set them when we show the dialog instead. The plugin text varies quite a bit from column to column. Resize each column to its contents instead of setting uniform widths. Change-Id: I1ed9b115665b4dd99a4ff9ee94701f449b8413de Reviewed-on: https://code.wireshark.org/review/25250 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2aa826095739b5357350895b57dd99… commit 2aa826095739b5357350895b57dd9980fc06f8a0 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Jan 11 11:14:18 2018 +0000 wireshark_preference (Qt): fix extra ';' outside of a function is a C++11 extension [-Wc++11-extra-semi] Change-Id: Ided4470e26f67f82fc90244560603e97b1d4d4b5 Reviewed-on: https://code.wireshark.org/review/25265 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4e13791a09a034c043f6296c001566… commit 4e13791a09a034c043f6296c001566b6ab33b668 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 10 10:48:28 2018 +0100 LNet: fix memory illegal access reported by Coverity (CID 1427262) Change-Id: Iad925f32364eb9fb21da7032284044469dcbddc5 Reviewed-on: https://code.wireshark.org/review/25241 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=997cf938bd56c83642e39e517de7f6… commit 997cf938bd56c83642e39e517de7f6c077683076 Author: Jaap Keuter <jaap.keuter(a)xs4all.nl> Date: Thu Jan 11 10:23:50 2018 +0100 Add message number for wlan eapol 4-way key exchange Since the message number isn't explicitly encoded in the protocol there is no field to filter on. It is however derived from the message contents and added in the info column. Adding this as a generated field allows searching for and filtering of these messages. As requested before, last at SF'17 EU. Change-Id: Id77612f0178710d30ea815335b0a54339d5d7b2c Signed-off-by: Jaap Keuter <jaap.keuter(a)xs4all.nl> Reviewed-on: https://code.wireshark.org/review/25257 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a6f58356dcaf09c3fffaad1c4ec1e3… commit a6f58356dcaf09c3fffaad1c4ec1e3488840a43c Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Jan 11 12:06:54 2018 +0100 NAS EPS: make some helpers functions static Change-Id: I6a98c10687a6ffbbe6aa59d91fa52fed47dcae66 Reviewed-on: https://code.wireshark.org/review/25264 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=72edf4e2506f20f0d3ade69582c48f… commit 72edf4e2506f20f0d3ade69582c48f1b7521c610 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 11 01:37:19 2018 -0800 Another fix for AT_STRINGZ addresses. Change-Id: Ib1dc1b59851b87e7e3f83cfc888a494ca94cb289 Reviewed-on: https://code.wireshark.org/review/25261 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=eb5d12c4b97b11c3dcf16cc9d245b6… commit eb5d12c4b97b11c3dcf16cc9d245b631f4389e59 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 11 01:31:08 2018 -0800 For AT_STRINGZ, the length *includes* the null terminator. The correct length for an AT_STRINGZ address of "" is 1, not 0. A length of 0 for an address is valid only if the pointer-to-address-data is null. Change-Id: I1da6de5ed402020ed5c8389a911870a54fa8b14a Reviewed-on: https://code.wireshark.org/review/25258 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3d38b87d86736a976dd28f03b98928… commit 3d38b87d86736a976dd28f03b989282e093191bb Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Jan 11 00:47:38 2018 -0800 Fix registration. Some routines are registered by the standard plugin mechanism, others are registered internally. If a first-stage ("register") routine is registered internally, we must register the second-stage ("reg_handoff") routine internally as well, otherwise the second-stage routine isn't recognized by tools/make-plugin-reg.py and is never called. Bug: 14322 Change-Id: I6eb94c0b74b6fb4d60eb57113d4ada73f4240150 Reviewed-on: https://code.wireshark.org/review/25256 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=93ea677ec4bc61966966cc71a67bbb… commit 93ea677ec4bc61966966cc71a67bbbca4125d607 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 10 15:31:03 2018 -0800 Test: Add a plugin check. Add a test for `tshark -G plugins`. Change-Id: I9ddced8ad5c200bd11433c7b30038f83da8d7460 Reviewed-on: https://code.wireshark.org/review/25253 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c7217638586c0f12ac02f4cf424f3e… commit c7217638586c0f12ac02f4cf424f3eae070dcd2d Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 10 20:06:56 2018 -0800 Update a comment to reflect current reality. All plugin types now have plugin_register() as the registration function, so it's an entry point for the plugin registration function, not the particular plugin type. Clean up white space while we're at it. Change-Id: I166359deac57512cb6e87b2c7388c4b25cc54e10 Reviewed-on: https://code.wireshark.org/review/25254 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c1719a8bf385fc1919b814d2ba3746… commit c1719a8bf385fc1919b814d2ba37464691fa82b4 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Wed Jan 10 18:44:28 2018 +0100 h223: fix warning related to circuit_id in circuit_chain_lookup Fixes a build failure when building the wireshark-git package on Arch Linux using GCC 7.2.1: epan/dissectors/packet-h223.c: In function ‘dissect_mux_sdu_fragment’: epan/dissectors/packet-h223.c:207:13: error: variable ‘circuit_id’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Fixes: v2.5.0rc0-1698-g800b26edbe ("Remove circuit API") Change-Id: I0b63f692e840e852680467b25ba3c3dfd31392ed Reviewed-on: https://code.wireshark.org/review/25251 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5639b8014afd467ddf25b18dcfe993… commit 5639b8014afd467ddf25b18dcfe993b497c97caa Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 5 09:09:40 2018 -0800 Use an enum for plugin types. Make plugins.c the source of truth for plugin names. Where plugins reside and what they do are two different things, so split the plugin directory and description into two separate elements. CMake creates portable[1] builds on Windows and macOS. That is, the build-time directory layout is the same as the installation directory layout. Adjust various plugin paths macOS accordingly. [1] You have to run osx-app.sh on macOS to prepare the application bundle, but the goal is to create a directory/bundle that can be moved or copied to a different system and run in the new location. Change-Id: Icf9d02e61918fdf1404468baf52542910edf2743 Reviewed-on: https://code.wireshark.org/review/25166 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=841e24d304312cf89c5841f6624ae9… commit 841e24d304312cf89c5841f6624ae99f7ed0a589 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Jan 7 19:15:52 2018 +0100 TLS(QUIC): minimal Transport Parameter Length is 22 only 3 parameters are mandatory, so 3 * 4 (type + length), 2 * 4 (initial_max_stream_data + initial_max_data) + 2 (idle_timeout) = 22 See https://github.com/quicwg/base-drafts/issues/1042 Bug: 13881 Change-Id: I971b0badb81086bb4bf018cb4471973a3950ee50 Reviewed-on: https://code.wireshark.org/review/25184 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d122ba3a53d33d08b92ec5436ea819… commit d122ba3a53d33d08b92ec5436ea819a1ee52be42 Author: Niels Widger <niels(a)qacafe.com> Date: Wed Jan 10 14:01:47 2018 -0500 CoAP: Shift block mflag so it is 0/1 instead of 0/8 Shift the value stored in coinfo->block_mflag in dissect_coap_opt_block so that we store 0/1 instead of 0/8. Change-Id: I45ac08564ff1fdcaf4e7306692db862b6a70989b Reviewed-on: https://code.wireshark.org/review/25248 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Niels Widger <niels(a)qacafe.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=37e364b2411a9bead0d35192f7f9bb… commit 37e364b2411a9bead0d35192f7f9bbb7d66bc775 Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 10 12:16:30 2018 -0800 Improve handling of VOIP VLAN queries and replies. For queries, there appear to be two different versions, one with a 2-byte value of some unknown type and one with a 1-byte value that appears to be an "appliance type" code followed by a 2-byte VLAN ID. For replies, there only appears to be a version with a 1-byte "appliance type" followed by a 2-byte VLAN ID, but handle a too-short payload. Also point to http://www.rhyshaden.com/cdp.htm in some comments. Change-Id: If1b476d5e6b23c7e0ba027835c6f0c84c8b723b7 Reviewed-on: https://code.wireshark.org/review/25249 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=182112c10de7ad8082f2fce02d714c… commit 182112c10de7ad8082f2fce02d714cb8fb8c7b27 Author: Erik de Jong <erikdejong(a)gmail.com> Date: Wed Jan 10 19:13:27 2018 +0100 LoRaTap: decode as for UDP Allow decoding of LoRaTap in UDP packets like used by gr-lora (https:// github.com/rpp0/gr-lora) for instance. Change-Id: I812c428db840a646b6fb22437037dcb8fab39370 Reviewed-on: https://code.wireshark.org/review/25247 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2a368b3ab6ae4197141b386e669956… commit 2a368b3ab6ae4197141b386e669956530c74aa8f Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 10 08:20:01 2018 +0100 QUIC: Add new error code from draft-08 UNSOLICITED_PONG (0xB): An endpoint received a PONG frame that did not correspond to any PING frame that it previously sent. Bug: 13881 Change-Id: I8f3daf46965b93007dd178622f3ebd7c187b11e7 Reviewed-on: https://code.wireshark.org/review/25239 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=83e8adccde258256aae115e684be6e… commit 83e8adccde258256aae115e684be6ebeebb02d2b Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 10 08:16:59 2018 +0100 QUIC: Add PONG frame type from draft-08 Bug: 13881 Change-Id: I2f67e6f0fa8c517e143b3e352b0bc0297994d439 Reviewed-on: https://code.wireshark.org/review/25238 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=85c9780f43fb215258f66ab6a55d1e… commit 85c9780f43fb215258f66ab6a55d1ed4ba0af474 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 10 11:23:59 2018 +0100 NAS EPS: upgrade dissector to v15.1.1 Change-Id: I52a7124cf6f6c6e267525514e44e6c2903a11725 Reviewed-on: https://code.wireshark.org/review/25243 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bcefb0c8e6d9f87430cdee5ec96644… commit bcefb0c8e6d9f87430cdee5ec966443f1c6cbfcf Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 10 11:23:11 2018 +0100 Lustre: capitalize comment to please GCC7 Change-Id: I30c31dcdbfdfd99dfe204e2ba67a221f356a5088 Reviewed-on: https://code.wireshark.org/review/25242 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5dbc1d8d1c14aea4fda820567d6ac0… commit 5dbc1d8d1c14aea4fda820567d6ac0e226027ed3 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 9 09:45:13 2018 -0800 IxVeriWave: Adjust signature timestamp checking. Move the signature timestamp bounds checks inside get_signature_ts. Fix what appears to be an off-by-one error. Bug: 14297 Change-Id: I9ca1762a8418e47153f270a1a62b2d0d3a800130 Reviewed-on: https://code.wireshark.org/review/25229 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=33708998b4e0fdc47132f00b6d1e08… commit 33708998b4e0fdc47132f00b6d1e081c86fdbf6a Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Jan 10 01:17:53 2018 -0800 Fix build with GTK+ and without libsmi and GeoIP. Bug: 14318 Change-Id: I2121f3fec3f366ff77615be5a4d6518e02e4d07d Reviewed-on: https://code.wireshark.org/review/25240 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7c6f5c9172734c044a02ed15330021… commit 7c6f5c9172734c044a02ed15330021be49d47cfa Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 9 13:57:29 2018 +0100 Qt: refresh interfaces on exit if extcap status has changed. Change-Id: I113f5ae3d72f647ddf0783dd4bcbdf42715dcbdc Reviewed-on: https://code.wireshark.org/review/25223 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=80cd3859d1db72d77a85035d572d8a… commit 80cd3859d1db72d77a85035d572d8a02aa3d8d84 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Fri Jan 5 22:12:15 2018 +0100 BGP: Resolve AS23456 to AS_TRANS AS23456 is reserved in RFC6793 for 32-bit AS number range as AS_TRANS. Add an additional text "(AS_TRANS)" to AS 23456 items. Bug: 14305 Change-Id: I1a0ea9e07c74b7e409cb32e2da55dbf233a2348d Reviewed-on: https://code.wireshark.org/review/25172 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=be143963f6de7f33ec9c3f300efabf… commit be143963f6de7f33ec9c3f300efabf156596b7d7 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Jan 9 08:20:43 2018 +0100 BGP: Add dissection of data field on BGP NOTIFICATION message (OPEN/Bad Peer AS) Bug: 14304 Change-Id: Ic69b43c58f9e02f91900dc618e4429cfc6ddfcac Reviewed-on: https://code.wireshark.org/review/25217 Reviewed-by: Uli Heilmeier <openid(a)heilmeier.eu> Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=88abff68df5fcea46e1f7f0a32d7fe… commit 88abff68df5fcea46e1f7f0a32d7fe8718fd67c0 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Jan 9 23:38:47 2018 +0100 NR RRC: add initial dissector based on v15.0.0 ASN.1 prose imported from the specification and heavily modified manually to workaround its poor quality. Some of them are marked with -- WS modification comment, some are not. Probably useless as-is, but it is an initial start until an updated version is available. Change-Id: I19ab6cedb6aa23c8ed57bae525ee4a3391494e32 Reviewed-on: https://code.wireshark.org/review/25235 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fb4953a13c1ac6e5b54a347769c5f0… commit fb4953a13c1ac6e5b54a347769c5f05e8fd6ab28 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Tue Jan 9 21:08:03 2018 +0100 lustre: fix format 'long unsinged int' error Change-Id: I764aa32c5571e667917c202feb70612dd877fc40 Reviewed-on: https://code.wireshark.org/review/25231 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fc9af81a13ec53ca15cbd28ce1896d… commit fc9af81a13ec53ca15cbd28ce1896d407ab2bf8a Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Jan 9 09:55:37 2018 +0100 wiretap: add a parameter to wtap_init() indicating whether plugins must be loaded g995812c5f1 moved wiretap plugins registration from applications to wiretap library init function. As we do not want to load plugins for all users of libwiretap, let's make it configurable. Bug: 14314 Change-Id: Id8fdcc484e2d0d31d3ab0bd357d3a6678570f700 Reviewed-on: https://code.wireshark.org/review/25194 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a7e29d8b66dd7c1cb691966938404d… commit a7e29d8b66dd7c1cb691966938404dafc6b89689 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Jan 9 11:31:40 2018 -0800 WCP: Add a length check. Add a bounds check for the current window. Blind attempt at fixing bug 14251. Bug: 14251 Change-Id: Ia3775bcabb2dc633b6994547125e53a4fe23451e Reviewed-on: https://code.wireshark.org/review/25230 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=369cdcc5533e46cb28437557d6827b… commit 369cdcc5533e46cb28437557d6827ba0172710c3 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Tue Jan 9 21:28:12 2018 +0100 NTP: Update values for opcode Used refs: https://github.com/ntp-project/ntp/blob/stable/include/ntp_control.h https://tools.ietf.org/html/draft-ietf-ntp-mode-6-cmds-03#section-4 Ping-Bug: 14270 Change-Id: Ie2a30ef316f85313f6f626772c6544c315db5b68 Reviewed-on: https://code.wireshark.org/review/25232 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c51560985a43592a79c29baba4f79f… commit c51560985a43592a79c29baba4f79f399a8e15dd Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 9 15:27:46 2018 +0100 Fix tvbparse recursion limit check. When doing recursion check we must also count down when done. Bug: 14253 Change-Id: Icacc86e8b25e106e151117dbcc2f132b1bbe898e Reviewed-on: https://code.wireshark.org/review/25226 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d769b7cb7ae203b784a4f440d93624… commit d769b7cb7ae203b784a4f440d93624bb5c6bae81 Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 9 14:44:24 2018 +0100 lustre: add missing breaks (fix gcc-7 compilation). Change-Id: I00f0901853818df5f6bf67d7d75720067d66ee50 Reviewed-on: https://code.wireshark.org/review/25225 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Nathaniel Clark <nathaniel.clark(a)misrule.us> Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3f2f16411fb2f9582294227594549f… commit 3f2f16411fb2f9582294227594549fb8fdd9a227 Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Jan 6 19:03:36 2018 -0500 Convert GUI layout preferences to use preference effects. Another simple example of how to use preference effects to limit the times a capture file is redissected unnecessarily. Also clean up some of the grammar of preference effect descriptions. Change-Id: I2db92e8e3ee913d3b37162916bd0ef7ac8ecd794 Reviewed-on: https://code.wireshark.org/review/25175 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4e87f6c01a7bd0dc29959492e758eb… commit 4e87f6c01a7bd0dc29959492e758eb6fae0a9fc9 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 9 13:28:17 2018 +0100 proto: Small code cleanup in proto_register_protocol - Remove unneeded assignments - Fix some comments and whitespace Change-Id: I79de66315db29fe7c59fc18f3b3b464ac55121c8 Reviewed-on: https://code.wireshark.org/review/25221 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5f24a78113ab01b68d36dc7263e23a… commit 5f24a78113ab01b68d36dc7263e23adb39dc1707 Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Tue Jan 9 11:14:40 2018 +0000 Increase PROTO_PRE_ALLOC_HF_FIELDS_MEM We've added more fields, increment the pre-allocation amount Change-Id: If0e68697c797e8709349a59b86fbcd4397730476 Reviewed-on: https://code.wireshark.org/review/25220 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=21c0ba7bfe41df434e0896d3c42a8d… commit 21c0ba7bfe41df434e0896d3c42a8d2c816911fb Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Tue Jan 9 11:06:53 2018 +0100 Update libwireshark0.symbols Change-Id: I3699e8589f5e4fefd7a4cbfad69039f0cfc00fe3 Reviewed-on: https://code.wireshark.org/review/25219 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=22b5ffad861b2efede6d64d16e3871… commit 22b5ffad861b2efede6d64d16e38710d2c713ba1 Author: Dario Lombardo <lomato(a)gmail.com> Date: Sun Jan 7 22:06:13 2018 +0100 extcap: add preference to prevent interfaces loading. Change-Id: Ia5865a40c75e582f28408a0515c5c0b38e43a916 Reviewed-on: https://code.wireshark.org/review/25188 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0a8d6cf97e0dccc02cb36f2636feb0… commit 0a8d6cf97e0dccc02cb36f2636feb053725118da Author: Erik de Jong <erikdejong(a)gmail.com> Date: Mon Jan 8 21:09:51 2018 +0100 LoRaTap/LoRaWAN: Add decode as and fix field types Allow LoRaTap syncword field to be used for "decode as". Fix field types for LoRaWAN EUI fields to display as EUI-64 little endian. Change-Id: I584f338031a4bc87e127d35a7bf8751a60e93d55 Reviewed-on: https://code.wireshark.org/review/25199 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=958374f352c0d1c238355a6434e022… commit 958374f352c0d1c238355a6434e0222e754f43f1 Author: Nathaniel Clark <nathaniel.l.clark(a)intel.com> Date: Tue Dec 19 13:06:46 2017 -0500 [lustre] Initial Lustre support This interperates the main body of Lustre traffic. This dissects all current Lustre OPCODES (as of Lustre 2.10.2) This dissects MDS REINT sub-opcodes This dissects LDLM Intent opcodes This dissects LLOG EADATA Conversation matching is just IP based and not IP/port based. Only one lustre "instance" can be running on a given host at a given time, and request / reply pairs aren't don't always match by port numbers. Add exception for lustre_* structure names in PROTOABBREV. We have several lustre.lustre_* because the internal lustre structre is named lustre_ (i.e. lustre_handle or lustre_msg_v2) This is still a work in progress, as there are missing FLAG values and some LLOG EADATA structures that aren't fully decoded. Change-Id: If57085e2692565336e49f40fb475ca1035da7a35 Signed-off-by: Nathaniel Clark <nathaniel.l.clark(a)intel.com> Reviewed-on: https://code.wireshark.org/review/24800 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7c56f4776b0e78ae0581e5df672e20… commit 7c56f4776b0e78ae0581e5df672e20f6ee1bf56d Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Jan 8 21:08:32 2018 -0800 Clean up dissection of "power requested" and "power available" TLVs. Fix the addition of power values to the top-level item for the TLV so that it actually adds power values. Make the list of power values in that item display correctly, without extra commas. Fail if the length of the TLV is less than 8. (We should really add an expert info item for that.) Change-Id: Ic4229c0652306f69156b8341c9fbb67cacc8154c Reviewed-on: https://code.wireshark.org/review/25215 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8934ddfe73762e6226c2c8b7b21119… commit 8934ddfe73762e6226c2c8b7b21119e3d0b13604 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 22:26:42 2017 +0100 mate: check LoAL existence (CID: 1159338). Change-Id: I4acd9d57866c0832241973d349c84b6346a293f5 Reviewed-on: https://code.wireshark.org/review/25046 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=af0f49e80dce20b50ca757b52c2454… commit af0f49e80dce20b50ca757b52c2454e137ce1c74 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Jan 8 16:38:10 2018 -0800 Use pcapng as the name of the file format. At one point, I remember a discussion resulting in the official name of the next-generation replacement for pcap format being changed to "pcapng", with no hyphen. Make Wireshark reflect that. Change-Id: Ie66fb13a0fe3a8682143106dab601952e9154e2a Reviewed-on: https://code.wireshark.org/review/25214 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=94479aded162aecce6289bdf26f950… commit 94479aded162aecce6289bdf26f95073bed0dc55 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 8 13:54:00 2018 -0800 Limit tvbparse recursion. Add a recursion check to tvbparse so that we don't overflow our stack. Bug: 14253 Change-Id: I0f667c3720311318267a1184b33e33253f8ff729 Reviewed-on: https://code.wireshark.org/review/25202 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ec5dead2ffc03f009398a0a302170… commit 7ec5dead2ffc03f009398a0a30217052e6749ad0 Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Jan 8 15:40:50 2018 -0800 Copy preferences to capture options after the preferences are initially loaded. We copy them after, for example, switching profiles; we should do so when they're initially loaded as well. Change-Id: Iadd67d20b1be8cc14be1b19543f914f71e4c9c00 Reviewed-on: https://code.wireshark.org/review/25208 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=51e0d22ec6db124abca69a1cc35905… commit 51e0d22ec6db124abca69a1cc35905c9342c884a Author: Jon DeVree <nuxi(a)vault24.org> Date: Mon Jan 8 01:22:53 2018 -0500 Do not automatically enable the linux kernel's BPF JIT compiler The default value of kernel.unprivileged_bpf_disabled is 0 which means this is enabling the BPF JIT compiler for unprivileged users. Given that this is a known attack vector for Spectre variant 1 (CVE-2017-5753) this is not a setting that a utility should be tampering with. Tshark's and dumpcap's help message is changed by Balint Reczey to suggest enabling BPF manually after considering security-related implications. Change-Id: I1cc34cbd6e84485eba9dee79a8700aa388354885 Signed-off-by: Balint Reczey <balint.reczey(a)canonical.com> Bug: 14313 Reviewed-on: https://code.wireshark.org/review/25192 Reviewed-by: Balint Reczey <balint(a)balintreczey.hu> Petri-Dish: Balint Reczey <balint(a)balintreczey.hu> Reviewed-by: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=aaa980e356a844b89f0a25ce34bd88… commit aaa980e356a844b89f0a25ce34bd88956d8fc79d Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 5 17:02:57 2018 -0800 Update the release notes. Change-Id: I95de800a01c539835fb12ae1dca4f396a4a206cd Reviewed-on: https://code.wireshark.org/review/25197 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=7a911f29271d1e075ff1861eafa939… commit 7a911f29271d1e075ff1861eafa9393589c9896a Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Jan 8 14:02:15 2018 -0800 Fix comment, get rid of extra blank line. Change-Id: I073975f6468b5fb6c4d404f3778427786e0a3137 Reviewed-on: https://code.wireshark.org/review/25203 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=69e1bdd62bcb32291b9ba4ac414be5… commit 69e1bdd62bcb32291b9ba4ac414be5bfab34de2b Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Jan 8 13:08:55 2018 -0800 More information on the Windows Console and escape sequences. Change-Id: I8a57053658ef17d28c28c458e8fe5350332a953b Reviewed-on: https://code.wireshark.org/review/25201 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=bde402840f9930e8930d2f31ce1922… commit bde402840f9930e8930d2f31ce19229e00496954 Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com> Date: Mon Jan 8 20:02:08 2018 +0100 androiddump: Fix crash in add_tcpdump_interfaces If there's a network interface on the device without the 'flags' field and at the same time exist other network interfaces with the 'flags' field present a null-dereference happens accessing the non-matched regex flags field. Fix crash by adding explicit null check to ensure (optional) regex group really matched. Fixes: 7dcf57719f ("androiddump: Support older on-target tcpdump versions") Change-Id: Ia08dd8547c9cdda96b3c62b99d98ff1d85bd6cd2 Reviewed-on: https://code.wireshark.org/review/25198 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0655931f606efc086e8526c7f4a687… commit 0655931f606efc086e8526c7f4a687ac6477686e Author: Guy Harris <guy(a)alum.mit.edu> Date: Mon Jan 8 12:50:23 2018 -0800 Point to the MSDN blog post about 24-bit color support in cmd.exe. Change-Id: Ic23f1d6ee35333ab4775970455f71315925f4cc6 Reviewed-on: https://code.wireshark.org/review/25200 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a6a5b552ece22737d04cdd92b05eda… commit a6a5b552ece22737d04cdd92b05edacc0a3accf6 Author: Gerald Combs <gerald(a)wireshark.org> Date: Mon Jan 8 10:04:18 2018 -0800 Update a comment about Windows Console color support. Change-Id: I39171a3c95ca48a39fbbc90ceadb9b1436f2402c Reviewed-on: https://code.wireshark.org/review/25196 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=15746e5922159265468e3d5d19b2fe… commit 15746e5922159265468e3d5d19b2feb7b769a57a Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Jan 7 09:30:04 2018 -0800 Add a mutex for the protocol registration callback name. Fixes TSAN warnings on macOS. Change-Id: I6cef7b49874011fd2da2c8dd15b59ce2ae08537a Reviewed-on: https://code.wireshark.org/review/25185 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=7a19320df18adae30d974949f20cba… commit 7a19320df18adae30d974949f20cbae976b4b0ed Author: AndersBroman <anders.broman(a)ericsson.com> Date: Mon Jan 8 15:05:21 2018 +0100 [Thrift] Dissect Thrift over SSL. Change-Id: Ifa7676decc3b853a41c16bd962a25da6ccfac7c7 Reviewed-on: https://code.wireshark.org/review/25193 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b5e744bca246072d4d2c446752f909… commit b5e744bca246072d4d2c446752f909dd1081bfcf Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Sun Jan 7 15:30:37 2018 +0100 OSPF: Dissect LS Type bytes of OSPFv3 LS Request Dissecting of LS Types bytes for LS Requests was missing. Dissecting of LS Types bytes for LS Acknowledgments have been implemented. Bug: 14310 Change-Id: I13d5b564a1e97f0c5a33c749273b11f94c90cbc0 Reviewed-on: https://code.wireshark.org/review/25183 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8738b3e45ac131322ed6f1700b1ce7… commit 8738b3e45ac131322ed6f1700b1ce77f8e8f5d8f Author: Will Robertson <aliask(a)gmail.com> Date: Mon Jan 8 19:23:29 2018 +1100 [Kingfisher] Include extra function types to allow dissection of additional messages Change-Id: I6a2c17785ea58a1c0661bee5879099bc838f6bc3 Reviewed-on: https://code.wireshark.org/review/25191 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c53412f7db226b99e6e747364ff75e… commit c53412f7db226b99e6e747364ff75e7788ed3575 Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Jan 6 21:40:19 2018 -0500 Bugfix the sort order of protocols in Preference dialog. Sort properly by module title. Also consolidate some of the searching in PrefModuleTreeView. Change-Id: I5312581c63f8626de08bd9f03613219b34bf968a Reviewed-on: https://code.wireshark.org/review/25176 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=985f7d023e1461b5e58b37b4e207b3… commit 985f7d023e1461b5e58b37b4e207b3665278df51 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Mon Jan 8 09:26:29 2018 +0100 tetra: Capitalize protocol short name Change-Id: I8287c4492b9eab087b98820f7bd69b1bbe3b66fa Reviewed-on: https://code.wireshark.org/review/25190 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=5699243ce1bea325e552566ac75472… commit 5699243ce1bea325e552566ac75472254bf75ee0 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Mon Jan 8 09:26:25 2018 +0100 chargen: Capitalize protocol short name Change-Id: I26b938a44e696fafb715eb30f2e6780ec812fb2f Reviewed-on: https://code.wireshark.org/review/25189 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=e80b40adbe823be084fb49cd843369… commit e80b40adbe823be084fb49cd84336939916120bb Author: Dario Lombardo <lomato(a)gmail.com> Date: Sat Jan 6 21:39:26 2018 +0100 extcap: remove conditional compilation. Change-Id: Ia54bba388755cf27a343fe6d69d244bf1ab897f9 Reviewed-on: https://code.wireshark.org/review/25186 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6f93baced0fba7d07425e14ea698f4… commit 6f93baced0fba7d07425e14ea698f4607964c6ed Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Fri Jan 5 22:58:49 2018 +0100 CDP: Resolve 802.2 Protocol type protocols, show IPv6 Protocols of protocol type 802.2 (PT = 2) are encoded with the "normal" ethernet type when PT length == 8. Used reference: https://docs.fd.io/vpp/17.10/d2/d71/cdp__protocol_8h_source.html Show IPv6 addresses as IPv6 and not as bytes. Change-Id: I0f192e758bcc1a562f042609fa5d0d9527551bb8 Bug: 14311 Reviewed-on: https://code.wireshark.org/review/25168 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b3394a76ab58d7e604e67e4b6f54ad… commit b3394a76ab58d7e604e67e4b6f54ad3c6d157b4e Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Date: Sun Jan 7 10:52:59 2018 +0100 ZigBee: Enable heuristic dissection of Tunneling cluster payload The Smart Energy Tunneling cluster can carry various payloads. The type of payload is determined when the tunnel is established. However, we cannot be sure to capture the tunnel establishment and therefore heuristics are used to determine the payload type. The IP protocol is added as a heuristic dissector because the specification allows IP in the tunnel payload. However, the only real life payload type I am aware of is GBCS messages in UK Smart Metering (https://smartenergycodecompany.co.uk). Finally, if a heuristic dissector cannot be found, the Data dissector is used. Change-Id: I4942bf00d0d0efe7047db6494cd4f8a9d19c96b6 Reviewed-on: https://code.wireshark.org/review/25181 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Boye Petersen <martinboyepetersen(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f5f6ceeb66a1d81ef4e10059dae9c7… commit f5f6ceeb66a1d81ef4e10059dae9c713eb8cded2 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Jan 7 08:16:04 2018 +0000 [Automatic update for 2018-01-07] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I65801bc1440f64c28ee003e23be2ca528bc1adc8 Reviewed-on: https://code.wireshark.org/review/25178 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=e429e9ac7ed044c361d2306bdd1c30… commit e429e9ac7ed044c361d2306bdd1c30290daf1814 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Jan 6 19:02:16 2018 -0800 Do SMB_COM_SEARCH or SMB_COM_FIND results ever have a Unicode file name? Change-Id: I11d3091bdaa7d4ecff66c238e45b265a57ef1af7 Reviewed-on: https://code.wireshark.org/review/25177 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=603bb5097d01740edc20c279d8d8f7… commit 603bb5097d01740edc20c279d8d8f7aea1949710 Author: Michael Mann <mmann78(a)netscape.net> Date: Sat Jan 6 12:10:06 2018 -0500 Set captures preferences for PREF_EFFECT_CAPTURE. This is a simple example of changing preferences that don't affect dissection to something else, so that changing them doesn't cause a file to be redissected unnecessarily Change-Id: I77c64c739e8bbc9f2a202f744f27cb07be4a822b Reviewed-on: https://code.wireshark.org/review/25173 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7165b608794566d6bdb973bdc20706… commit 7165b608794566d6bdb973bdc20706dc0aaeab51 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Jan 6 15:32:25 2018 -0800 Note that the object size type is, in effect, size_t. We currently accumulate all of the object data in memory, so we can't support objects whose size doesn't fit in a size_t; that means the maximum object size is 2^32-1 bytes on ILP32 platforms, even though we allow the size to be up to 2^63-1 bytes. Change-Id: I2b45f2f1a6a4a68c97d34931aea6f5294db41b6e Reviewed-on: https://code.wireshark.org/review/25174 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2941018a721b362d13e7fd854dff56… commit 2941018a721b362d13e7fd854dff56221aac00f7 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Jan 6 00:01:30 2018 +0000 WLAN stats: make filter + apply button work Also export as text just the networks. Change-Id: I228d65cb219792a70c6077932dbe9cf65b92eb6e Reviewed-on: https://code.wireshark.org/review/25169 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=eef3c8434d556ad4d3fd9b0f4fdf91… commit eef3c8434d556ad4d3fd9b0f4fdf912145f2670d Author: Michael Mann <mmann78(a)netscape.net> Date: Fri Jan 5 23:39:55 2018 -0500 Add ability for preferences to determine what they can change. Add flags field to preference structure to help determine what areas of Wireshark are affected by a preference changing. The intent is to be able to distinguish dissection from GUI or other changes that are not dissection. The default is to have all preferences affect dissection, but their flags can be changed. This patch doesn't change any flags from the default. Change-Id: Ied5ae961bc3f33f5b730b2892fff3fa0898380b8 Reviewed-on: https://code.wireshark.org/review/25171 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a65391f9014acd5cb8e4fe09ef8b2f… commit a65391f9014acd5cb8e4fe09ef8b2fac4716c024 Author: Gerald Combs <gerald(a)wireshark.org> Date: Fri Jan 5 15:40:19 2018 -0800 TShark: Fix color handling on Windows. Use SetConsoleTextAttribute to reset our colors on Windows. Update the release notes and man page. Change-Id: I2bc309787f9c2331324503092bd1c9ae6360eb55 Reviewed-on: https://code.wireshark.org/review/25170 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=29798bb8c931ca6a999bc5fccf1487… commit 29798bb8c931ca6a999bc5fccf14877f6ffcc1fb Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Jan 5 14:00:44 2018 +0100 bluetooth: Group Bluetooth dissector preferences Change-Id: Ib5360fcbfd8f6b2aee6b33ec7d9dc77362feb50e Reviewed-on: https://code.wireshark.org/review/25162 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=929553522037cfd909f8aada07adec… commit 929553522037cfd909f8aada07adec1a6b582612 Author: Nick James <mookito(a)tuta.io> Date: Sat Jan 6 11:44:42 2018 +0200 RRC: Fix direction values Values were swapped: uplink is 0, downlink is 1. Change-Id: I30dbb6d89ea832741c3ce4a319be1cb261b1565b Reviewed-on: https://code.wireshark.org/review/25143 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ae2e9d669be1f769105580ae6faf12… commit ae2e9d669be1f769105580ae6faf1270bc1543c5 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Jan 5 17:03:08 2018 +0100 Diameter: fix retrieval of message flags Bug introduced in g7ade1695ba Change-Id: I83e2c2df4f7764130ebe342170f40de5e7610611 Reviewed-on: https://code.wireshark.org/review/25164 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5a5d9348b0c3aa7780afc588293233… commit 5a5d9348b0c3aa7780afc588293233133a063636 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Jan 5 18:09:51 2018 +0100 wireshark_preference.cpp: rework comments to please MSVC2015 Change-Id: Ic7a1f51df833e8aec7555f796e9a86f1d120cdc1 Reviewed-on: https://code.wireshark.org/review/25165 Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3b64fc008f17d9a35120897f838874… commit 3b64fc008f17d9a35120897f838874e821423bee Author: Roland Knall <roland.knall(a)br-automation.com> Date: Fri Jan 5 15:21:17 2018 +0100 Qt: Fix windows version of Preference Dialog Initializing a static member on Windows C++ has to be done differently. This fixes the segfault introduced with Ia611ec192dcc1ad638a997182cec1ab5bdb7859c Change-Id: Ib7a9840feda74830f835345c666f57e23e9e4e0b Reviewed-on: https://code.wireshark.org/review/25163 Reviewed-by: Roland Knall <rknall(a)gmail.com> Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=82b26b686e49dcb0fa15f8d585d47a… commit 82b26b686e49dcb0fa15f8d585d47a569f798403 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Fri Jan 5 12:43:51 2018 +0100 NAS EPS: upgrade dissector to v15.1.0 Change-Id: I0ea263b693910c1d8036a18e612c1daf538482dd Reviewed-on: https://code.wireshark.org/review/25161 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c0226ea401fd13f4f368ddf1d7013a… commit c0226ea401fd13f4f368ddf1d7013aaf6049978f Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 3 13:50:46 2018 +0100 ctdb: check return value from wmem_tree_lookup32_array (CID: 1073824). Change-Id: I0f504ea8ab0608e41566996d380b05ca5d77e3c4 Reviewed-on: https://code.wireshark.org/review/25160 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f0681d01759a876101c3210c8a5b8b… commit f0681d01759a876101c3210c8a5b8bbb0e4d22a2 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 22:17:51 2017 +0100 erf: remove redundant check (CID: 1159076). This check has been alreay done in line 433: since then packet_size is only decreased, then the check is redudant. Change-Id: I8ede5c733867ccc98ab2d470181d1e4a29ae5b49 Reviewed-on: https://code.wireshark.org/review/25023 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ae613193856c363c3492ec20cfd8af… commit ae613193856c363c3492ec20cfd8af6543271f3b Author: Laszlo Papp <laszlo.papp(a)hubersuhner.com> Date: Wed Jan 3 13:51:32 2018 +0000 OpenFlow 1.5: fix port_stats dissector Change-Id: Id8f078d9f9c327f3e9c2b50daaf23639cad1ae8f Reviewed-on: https://code.wireshark.org/review/25157 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d19fa312475089553a47be9057082b… commit d19fa312475089553a47be9057082b10b633679d Author: AndersBroman <anders.broman(a)ericsson.com> Date: Fri Jan 5 10:55:03 2018 +0100 [SBC-AP] Update to 3GPP TS 29.168 V14.2.0 (2017-12) Change-Id: I84c178c01cfa6d3765d672d6ebbb842e4de55f26 Reviewed-on: https://code.wireshark.org/review/25156 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1a07d97fd70d1d0f2f22ccf41d09a1… commit 1a07d97fd70d1d0f2f22ccf41d09a1a5e0050666 Author: Michael Mann <mmann78(a)netscape.net> Date: Fri Dec 29 11:23:07 2017 -0500 Qt: Add manager for preference dialog Abstract out the different types of preferences into a visitor and factory pattern to handle the preference dialog. Change-Id: Ia611ec192dcc1ad638a997182cec1ab5bdb7859c Reviewed-on: https://code.wireshark.org/review/25142 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1e16be7556eddc913fb1d5410a22f9… commit 1e16be7556eddc913fb1d5410a22f95a77cb37ff Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Jan 5 11:31:21 2018 +0100 Qt: Bring back correct profile_status font size The refactoring in ga79b7986 did not preserve the font size for the profile name in the status bar. Change-Id: If38224a43043dd572992836b6fe78f1829f9cccd Reviewed-on: https://code.wireshark.org/review/25159 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fdfa22979374b9790667232f33347a… commit fdfa22979374b9790667232f33347a08c297aba4 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Jan 5 09:58:39 2018 +0100 btsmp: Put <none> in COL_INFO when having no keys Change-Id: If2db9fa1894f586523df882dca224b3b7b0eecb0 Reviewed-on: https://code.wireshark.org/review/25153 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=fb9abcf2d4c50c2ff528ee2ed5750f… commit fb9abcf2d4c50c2ff528ee2ed5750fbab48743bf Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Fri Jan 5 09:45:20 2018 +0100 btatt: Avoid duplicate "Handle:" in COL_INFO Do not add two "Handle:" in COL_INFO for opcode "Error Response". Change-Id: I13dd5fc3bbef1762c2e868dfe885fa5d6437412e Reviewed-on: https://code.wireshark.org/review/25152 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=4690aa119c4a94d85b18e34828cb90… commit 4690aa119c4a94d85b18e34828cb9016574ecd77 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Wed Jan 3 19:31:30 2018 -0800 ieee1905: Fix a bunch of issues after testing and spec changes. Change-Id: I8f61ed9866760d13daa0cc65c2a771da3dcf280f Reviewed-on: https://code.wireshark.org/review/25151 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3b2e9998132d28b73f311727b7b2fd… commit 3b2e9998132d28b73f311727b7b2fd6803f42a66 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 3 13:29:55 2018 -0800 Qt: Byte view recent updates. Add a recent.gui_bytes_encoding preference and use it for the byte view encoding as requested in bug 14044. The recent.gui_bytes_view preference is an enum, so make it one. Bug: 14044 Change-Id: Ibc40721c29465aca1940467e41d71e9dd2485e71 Reviewed-on: https://code.wireshark.org/review/25147 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=96cb041ea3e62ca557514ee3a05a0b… commit 96cb041ea3e62ca557514ee3a05a0b13a104465b Author: Laszlo Papp <laszlo.papp(a)hubersuhner.com> Date: Wed Jan 3 13:51:32 2018 +0000 OpenFlow 1.4: fix port_stats dissector Change-Id: I3ebe1590b9d5fd864746339612ac1396c13196b9 Reviewed-on: https://code.wireshark.org/review/25128 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c29da51613747278bd1a3744cdc191… commit c29da51613747278bd1a3744cdc191de68d7933b Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Thu Jan 4 22:29:26 2018 +0100 QUIC: Add Payload (length and data) of PING frame (draft-08) Bug: 13881 Change-Id: I44a924da6e8da52bdee0f397545d504aee5290bc Reviewed-on: https://code.wireshark.org/review/25145 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3a622f976405402cc5f0db4d8dcfa1… commit 3a622f976405402cc5f0db4d8dcfa182f08f646d Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 20:15:24 2018 +0100 QUIC: Dissect Version Negotiation of draft-08 If on Long Header, the version field is set to 0x00000000, it is a version Negotiation Packet with the list of all supported version (with some GREASE) Bug: 13881 Change-Id: I56b7cecd112950fb557aadc434f367b74eebe07b Reviewed-on: https://code.wireshark.org/review/25138 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=58e4910ee70ba5dbcbc2e0dbaf2b46… commit 58e4910ee70ba5dbcbc2e0dbaf2b4673ec70af90 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 20:09:47 2018 +0100 QUIC: Display Connection in hex on Short Header too Bug: 13881 Change-Id: Ifc6e4b7be78fe00fce780e002dd77d67f17ebdaf Reviewed-on: https://code.wireshark.org/review/25137 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cc040d88c8c16b7560faeef0cc8005… commit cc040d88c8c16b7560faeef0cc800513dd3e2e5a Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 20:07:41 2018 +0100 QUIC: Fix Connection ID flag with draft-08 With draft-08 Connection ID is changed to Omit Connection ID in Short Header frame Bug: 13881 Change-Id: I9e53dc370ea692636143d2129754a3dc62d068bd Reviewed-on: https://code.wireshark.org/review/25136 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0f3aa8522e966205039a88f1ce7faa… commit 0f3aa8522e966205039a88f1ce7faae4adaefa23 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Dec 21 15:06:20 2017 -0800 Qt: Move sized toolbar images to stock_icons. The sized (WWxHH) icons in the toolbar directory aren't limited to toolbars. Create a "stock_icons" directory and move them and their related SVGs there. Change-Id: I2c1852499594aa738371c79542f24bd3351653bb Reviewed-on: https://code.wireshark.org/review/25133 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dbe9be2f0628914491e3e4265511b6… commit dbe9be2f0628914491e3e4265511b6c3026ed6ac Author: Michael Mann <mmann78(a)netscape.net> Date: Thu Jan 4 17:24:05 2018 -0500 Qt: Cleanup cases where QTreeWidgetItem is no longer used Change-Id: Ib2b6d4f73a6c9f1dacb728f6275a240487a73a02 Reviewed-on: https://code.wireshark.org/review/25149 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6b22e4e85af3f8df9e1d1bc71a95c3… commit 6b22e4e85af3f8df9e1d1bc71a95c3f8898324e5 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 4 15:04:18 2018 -0800 Add an exit code to make-dissectors. Explicitly return 0 from make-dissectors on success. Hopefully this will fix some Windows builder failures. Change-Id: I0c172597584c52ced2380719135e8559ef83392a Reviewed-on: https://code.wireshark.org/review/25150 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=dce8682e10622aa24ee1d7bbe499d8… commit dce8682e10622aa24ee1d7bbe499d8107e429011 Author: Michael Mann <mmann78(a)netscape.net> Date: Thu Jan 4 16:57:01 2018 -0500 Qt: Reexpand dissector table and enabled protocol trees when dialog is searched. If search text ends up with no results, the tree is cleared. When the search text is removed, it results in all but main leaf being collapsed. Restore the search tree to its default state after any search text has been entered. Change-Id: Id7d1a4fcb4355c6e2551cf3dfd300e26bf683ca3 Reviewed-on: https://code.wireshark.org/review/25148 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0b997f3a3aa63224f4a4578c34cee4… commit 0b997f3a3aa63224f4a4578c34cee4f074d66876 Author: Tom Haynes <loghyr(a)primarydata.com> Date: Wed Jan 3 22:19:30 2018 -0800 nfs: Add the second version of the Primary Data NFSv4 file handle dissector Change-Id: I05da9a546f5de81783e4c9d004aff7dbb3ead44b Signed-off-by: Tom Haynes <loghyr(a)primarydata.com> Reviewed-on: https://code.wireshark.org/review/25146 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8bf24f51cbb285c31a6b7101f63257… commit 8bf24f51cbb285c31a6b7101f63257d2010f7082 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Jan 4 12:34:22 2018 -0800 Pre-commit: Don't force whitespace checks everywhere. Move the whitespace check (git diff-index --check --cached) inside the CHECK_FILES loop, otherwise editing SVGs with Inkscape will be much less convenient. Change-Id: I2b9e3575d54091572caa89e3e317e5e121984010 Reviewed-on: https://code.wireshark.org/review/25144 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d239da264c5d0ca2ecfd609ae3eccc… commit d239da264c5d0ca2ecfd609ae3eccced939a4c46 Author: Michael Mann <mmann78(a)netscape.net> Date: Fri Dec 29 11:23:07 2017 -0500 Convert preference dialog to use more models. Convert Advanced view and Modules view to use a single base model, loading the preferences once and then filter and display what they need with QSortFilterProxyModel derived classes. Convert the PreferencePane "types" to just strings. This allows a more straightforward relationship between the "special" modules that need custom widgets for preference manipulation and it also removes dependency on preferences_dialog.h for many files. Change-Id: I091deb3061564aa4d1564e9ca1c792715961b083 Reviewed-on: https://code.wireshark.org/review/25134 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a79b7986cddf40a8ade57638916951… commit a79b7986cddf40a8ade57638916951323fff581e Author: Roland Knall <roland.knall(a)br-automation.com> Date: Thu Jan 4 15:55:33 2018 +0100 Qt: Redesign profile menu in status bar Remove global variables and move menu to where it is created. Additionally exchange LabelStack with ClickableLable, as it was overkill. Change-Id: I04528b707e9e491d0dd43063f5a47b08dfdb3471 Reviewed-on: https://code.wireshark.org/review/25140 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7ade1695baf1f32333bc2a3498c35e… commit 7ade1695baf1f32333bc2a3498c35ef7659af77f Author: Anders <anders.broman(a)ericsson.com> Date: Thu Jan 4 14:14:43 2018 +0100 [Diameter] Use proto_tree_add_item_ret..() and proto_tree_add_bitmask_with_flags() Change-Id: I864a385283aa6975a075f8621d871b73356ecf57 Reviewed-on: https://code.wireshark.org/review/25139 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba3830e03bad6e5e5cfb9d88342e99… commit ba3830e03bad6e5e5cfb9d88342e9953efba520b Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 3 15:05:03 2018 +0100 Qt: add conditional compilation in switches. Compiling without pcap, the lack of all the cases causes an error. ../ui/qt/main_window_slots.cpp:756:13: error: enumeration values 'Capture', 'Update', and 'Fixed' not handled in switch [-Werror,-Wswitch] switch (ev->captureContext()) { ^ 1 error generated. Change-Id: I36c0bc854b1d864ebf54ac59ca15743918bc7d2b Reviewed-on: https://code.wireshark.org/review/25127 Reviewed-by: Roland Knall <rknall(a)gmail.com> Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5a9edf2a91476453aaee3137b704a1… commit 5a9edf2a91476453aaee3137b704a1af80b33a44 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Jan 4 09:26:20 2018 +0100 btatt: Support BBC micro:bit Bluetooth profile Change-Id: I32e47e1eef57bb5f8e15e8d83219d6ab034bab73 Reviewed-on: https://code.wireshark.org/review/25135 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1e05c57cca59c0469e19b74ec6a47a… commit 1e05c57cca59c0469e19b74ec6a47a1669059d41 Author: Gerald Combs <gerald(a)wireshark.org> Date: Wed Jan 3 08:49:57 2018 -0800 Qt: Fix capture file properties averages. Round our average packet sizes to the nearest whole number as described in bug 9836 and change 687. Change-Id: I842eca7650d19be66eb35c40a886bd591a86650d Reviewed-on: https://code.wireshark.org/review/25129 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=51d83583c1b6fcaafa8c31e76568b8… commit 51d83583c1b6fcaafa8c31e76568b861d1144787 Author: Dirk Römmen <dirk.roemmen(a)cslab.de> Date: Wed Jan 3 21:55:43 2018 +0100 bacapp: Add more enumerated values Ping-Bug: 12457 Change-Id: Ie97747704b12a0ba70bb6adb1a8c251dfcaca08f Reviewed-on: https://code.wireshark.org/review/25132 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8a08237d23017644336fa895b5bbde… commit 8a08237d23017644336fa895b5bbde1a3d18fe57 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Wed Jan 3 19:22:38 2018 +0100 3GPP NAS: upgrade dissector to v15.1.0 Change-Id: Ibfbed335d842e53eabce36e2955a9bb2790d46fb Reviewed-on: https://code.wireshark.org/review/25131 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e0d04a752aebd91bc368932364c086… commit e0d04a752aebd91bc368932364c086576962c26d Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Jan 3 12:08:49 2018 +0100 wsutil: return false if NULL is asked as profile name (CID: 1405202). Better not rely on the fact that the caller won't pass NULL. A NULL profile would be lead to a wrong behaviour. Change-Id: I281f0d2364af9f7b78268580dd73024b07bcba83 Reviewed-on: https://code.wireshark.org/review/25124 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e7b50f47519637d4e21eb25d7ef30f… commit e7b50f47519637d4e21eb25d7ef30f14cf5d10fc Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Jan 3 12:14:41 2018 +0100 bthci: Update bthci_cmd_appearance_vals Change-Id: I385808b95f823a2242844173927cc6abd05c1905 Reviewed-on: https://code.wireshark.org/review/25125 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=61c6f1a62227c75464beb39f184ea8… commit 61c6f1a62227c75464beb39f184ea8e658a6c763 Author: Anders <anders.broman(a)ericsson.com> Date: Wed Jan 3 11:38:34 2018 +0100 [glib-compat] Include <wsutil/glib-compat.h> Change-Id: Id505f1dc8dbbeb241162156fc3ef557599a251fb Reviewed-on: https://code.wireshark.org/review/25123 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c6a065ee7ae37449a5491a12f29561… commit c6a065ee7ae37449a5491a12f2956119a2095a28 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 29 19:26:11 2017 +0100 dcerpc-spoolss: use value_name variable to store string (CID: 1158734). Change-Id: I30780134b3d8a8e48b8b4997ea27ce82171b4508 Reviewed-on: https://code.wireshark.org/review/25069 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6bd539d51f45a756f40ee2a5c37128… commit 6bd539d51f45a756f40ee2a5c3712845c6f5a1a4 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 09:57:19 2018 +0000 wireshark-qt(.cpp): fix no previous declaration for ‘void g_log_message_handler(QtMsgType, const QMessageLogContext&, const QString&)’ [-Wmissing-declarations] Change-Id: Ia08cf5a03be10b8553516196e24d51e5f48934a7 Reviewed-on: https://code.wireshark.org/review/25122 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e3ce3a6f793ab995b48766533f0a0d… commit e3ce3a6f793ab995b48766533f0a0d25356d09bf Author: Anders <anders.broman(a)ericsson.com> Date: Tue Jan 2 15:35:44 2018 +0100 [SIP] Use proto_tree_add_item_ret_string() to get the method string. Change-Id: I8c1933d17a613917c6b6482199949e103c3d1eaf Reviewed-on: https://code.wireshark.org/review/25112 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a3857b2f6f47928f2d9f4bbdeb57ca… commit a3857b2f6f47928f2d9f4bbdeb57ca26a3728981 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 08:30:08 2018 +0100 QUIC: Enhance *BLOCKED* frame Add new offset field in BLOCKED and STREAM_BLOCKED frame Add new stream_id field in STREAM_ID_BLOCKED Bug: 13881 Change-Id: If030728c46607ea9ea3a500d925b30aaf9a841a8 Reviewed-on: https://code.wireshark.org/review/25121 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f1c87809deceacb59f61055f674c77… commit f1c87809deceacb59f61055f674c7778376f2d6e Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 08:16:45 2018 +0100 TLS(QUIC): Enhance MAX_STREAM_ID parameter (from draft-08) MAX_STREAM_ID is rename to MAX_STREAM_ID_BIDI and there is a new paramter MAX_STREAM_ID_UNI Bug: 13881 Change-Id: I99bcc559a133ded88f4caedd887f481147063496 Reviewed-on: https://code.wireshark.org/review/25120 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b10179faf2706cc4182534f93b571b… commit b10179faf2706cc4182534f93b571b30fef4505b Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 08:04:43 2018 +0100 TLS(QUIC): Add ACK_delay_exponent parameter from draft-07 Bug: 13881 Change-Id: I56ac681174e4058c4d4fefe40084905538222c1b Reviewed-on: https://code.wireshark.org/review/25119 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=df6b67d54d1bd8d7dbba132d9d58dc… commit df6b67d54d1bd8d7dbba132d9d58dc50afbb1116 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Jan 3 07:53:20 2018 +0100 QUIC(TLS): Fix length of parameter tree Bug: 13881 Change-Id: I583c9290c5e4d2aaefc2d3ae09babfa82dfbd299 Reviewed-on: https://code.wireshark.org/review/25118 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d1fe22d14e6a4cbc27728bcd45b5f6… commit d1fe22d14e6a4cbc27728bcd45b5f646dc59a5ac Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Jan 3 10:38:13 2018 +0100 Qt: Use switch/case in MainWindow::captureEventHandler Change-Id: I765667465e08ec51a107edbee3c2026a52cacb74 Reviewed-on: https://code.wireshark.org/review/25117 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=f71b148eddc49ab59409999a497b88… commit f71b148eddc49ab59409999a497b88db488f0fe9 Author: Anders <anders.broman(a)ericsson.com> Date: Tue Jan 2 17:30:38 2018 +0100 [BTMESH] Dissect more of Upper transport Layer. Change-Id: I5d33c64a57689939c9915336701accba8b893415 Reviewed-on: https://code.wireshark.org/review/25115 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a382ed35fed2b1104fc588e5d665be… commit a382ed35fed2b1104fc588e5d665be76af42cd98 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Wed Jan 3 10:00:39 2018 +0100 Qt: Fix CaptureEvent::Reload event handling Fix an error introduced in signal/slot redesign in gd5d81518. This error disabled all capture file menu items after doing a rescan, like when adding a display filter. Change-Id: Ib468051c15b9f1a15faa2ed07b958340b82a662b Reviewed-on: https://code.wireshark.org/review/25116 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Reviewed-by: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=4f146fa95f21f01ad09e62a3dcc557… commit 4f146fa95f21f01ad09e62a3dcc557b1a355a64c Author: Dario Lombardo <lomato(a)gmail.com> Date: Tue Jan 2 15:38:25 2018 +0100 gitlab-ci: install ninja-build using debian script. Change-Id: I5bf1f1ea36f970be4ccf1a11b3da4198f83a6e68 Reviewed-on: https://code.wireshark.org/review/25114 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5dc7ce6cccd8c4671ca609ae24cdb2… commit 5dc7ce6cccd8c4671ca609ae24cdb28c77ea811b Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Tue Jan 2 12:11:08 2018 +0100 ws_pipe: fix format error for size_t buffer_size Fix error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' Change-Id: I86ec4076bb7e8c11d5cf82187a46a528bf43c514 Reviewed-on: https://code.wireshark.org/review/25109 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9b4c96334d18dec20f19e4db174f2e… commit 9b4c96334d18dec20f19e4db174f2eef28d03522 Author: Anders <anders.broman(a)ericsson.com> Date: Tue Jan 2 14:06:30 2018 +0100 [NAS-EPS] 5G NAS EPS network feature supported and capability info update. Change-Id: I243b52e8c448541636f3f94007ee3d850a5811ab Reviewed-on: https://code.wireshark.org/review/25111 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=07e8707d7346fc359a342877f919f2… commit 07e8707d7346fc359a342877f919f2a8c231a47b Author: Roland Knall <roland.knall(a)br-automation.com> Date: Tue Jan 2 13:23:08 2018 +0100 wsutil: Add missing include Otherwise gboolean is undeclared in files depending on the functionality, like extcap.c for instance Change-Id: I329715b2bb7bfd5d12ce3f1a035ecda6dff16a2d Reviewed-on: https://code.wireshark.org/review/25110 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ea60ed427e00232c306ae3e5ffd5ea… commit ea60ed427e00232c306ae3e5ffd5ea0ddccb8160 Author: Robert Grange <robionekenobi(a)bluewin.ch> Date: Tue Jan 2 10:17:09 2018 +0100 packet-mq: Fix after change 25009 Fix for unused variable mq_MQPRI_vals Fix test when displaying unique MQ Segment (vs multi MQ segment) Changed my name in AUTHORS Change-Id: I8ffa5523dbf8469d2814d2a90348eea61a05823a Reviewed-on: https://code.wireshark.org/review/25106 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=3d846aceabb6426d1ec8f21761234e… commit 3d846aceabb6426d1ec8f21761234ed384003ecb Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 2 10:30:41 2018 +0100 btatt: Remove custom UUID dissectors from btatt.handle DecodeAs Do not add custom UUID dissectors to the DecodeAs "btatt.handle" table because it does not work to DecodeAs this attributes using the "BT ATT Handle" field. This removes some of the artificial protocols which is generated from BT attributes, and avoids adding new ones when extending the custom UUID dissection support. Change-Id: I8384a56b49cac2ea64508470d67c67b6ec7cd13e Reviewed-on: https://code.wireshark.org/review/25107 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d20629e0f087c8e1aff261a7a15d0a… commit d20629e0f087c8e1aff261a7a15d0a8aac83e54b Author: Roland Knall <roland.knall(a)br-automation.com> Date: Tue Jan 2 11:19:55 2018 +0100 Build: Fix Ubuntu moc build Includepaths for moc where not correctly applied Change-Id: I1e3df133736372f3e4139957dc2e426f51764c86 Reviewed-on: https://code.wireshark.org/review/25108 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5bb763a9187397d3a6dd81c50cfc5f… commit 5bb763a9187397d3a6dd81c50cfc5f1a9db7eff5 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 31 16:02:12 2017 +0100 QUIC: use varint for all type (draft-08) Bug: 13881 Change-Id: Ia68659fed9b884bd99de8179e4a320089920df4d Reviewed-on: https://code.wireshark.org/review/25088 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4ac11e0fa1ed1aea6853693aea04d0… commit 4ac11e0fa1ed1aea6853693aea04d0c691ef7127 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 2 09:07:22 2018 +0100 mq: DEF_VALSB(MQPRI) is still unused Change-Id: I269c2f367d1d65b006ad881976085dbdf983c407 Reviewed-on: https://code.wireshark.org/review/25105 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=08fda63936f044e5e61f48f11067f5… commit 08fda63936f044e5e61f48f11067f5b80eac045c Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Tue Jan 2 09:05:19 2018 +0100 tfshark: Fix arguments to write_pdml_proto_tree Change-Id: Iae6b7940213ea702d72870f1f27c694fd41ba983 Ping-Bug: 13020 Reviewed-on: https://code.wireshark.org/review/25104 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=7a2fae2b796550eecaa03cf5e6631f… commit 7a2fae2b796550eecaa03cf5e6631fa6a73ff7b5 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Mon Jan 1 23:38:13 2018 +0100 nxp802154: Remove unused code The IEEE 802.15.4 dissector is built-in and will never be not present, and if disabled then call_dissector() will call data handle. Change-Id: Ie8d2a1bed1ba540df1a5bc239b57e475b346c8f1 Reviewed-on: https://code.wireshark.org/review/25103 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d383e34408a2183a1e97273ea27895… commit d383e34408a2183a1e97273ea2789511e0a7d1ae Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 31 10:58:09 2017 +0100 QUIC: Add new ACK type (0x0e) of draft-08 Bug: 13881 Change-Id: I7340c6cf2c149cbc547133ea89083c75a5ad05f1 Reviewed-on: https://code.wireshark.org/review/25084 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8c87af98801626cb557eb3b06ab47c… commit 8c87af98801626cb557eb3b06ab47cda853ec3e2 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 31 08:51:42 2017 +0100 QUIC: Add decrypt Handshake Packet From/to Server/Client Store the port destination to found key need to be used Change-Id: If7f2edcdb21f5b5aa9de28431db8dc3ec6d76602 Reviewed-on: https://code.wireshark.org/review/25083 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1a7d65d08557c2b1ad9a4a563fc4dc… commit 1a7d65d08557c2b1ad9a4a563fc4dc86ed1af269 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Dec 27 22:10:33 2017 +0100 TLS(QUIC): update TransportParameter to draft-08 not longer negotiated version on Client Hello but on encrypted extensions Missing add new TransportParameterId (ack_delay_exponent and initial_max_stream_id_uni) Bug: 13881 Change-Id: I5d76662b8c7767c48fdec460e2249d49c6693f18 Reviewed-on: https://code.wireshark.org/review/25018 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c8c268626c3219bbb20c639b88f186… commit c8c268626c3219bbb20c639b88f18656081869e2 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 24 15:03:58 2017 +0100 QUIC: Add new STREAM type (0x10 to 0x17) of draft-08 using varint for Stream ID/Offset/Length Bug: 13881 Change-Id: I9c9524e494e6cb8785d919fee596f94401b12fed Reviewed-on: https://code.wireshark.org/review/24991 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0bde3e96f0c51ed141e94ae82eed24… commit 0bde3e96f0c51ed141e94ae82eed24f1a38f712c Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 24 08:29:50 2017 +0100 Add ENC_VARINT_QUIC Used to support variable length in QUIC protocol Bug: 13881 Change-Id: Ia274b1530152376c5fb4e364fc4cf5ab246be1b3 Reviewed-on: https://code.wireshark.org/review/24990 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=af6dee35715a4079acaa7d9a413b6f… commit af6dee35715a4079acaa7d9a413b6f7d859c8c8b Author: Merlin Chlosta <merlin.chlosta+gnuradio(a)ruhr-uni-bochum.de> Date: Thu Dec 21 14:58:07 2017 +0100 Add columns (_ws.col) to output formats json, ek, pdml Bug: 13020 Change-Id: Ia83797a4e390be7cc59a9718735edc1c7f9a5712 Reviewed-on: https://code.wireshark.org/review/24928 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=487eae350743ede43432ebef49268c… commit 487eae350743ede43432ebef49268cc670d82fb2 Author: Robert Grange <robionekenobi(a)bluewin.ch> Date: Wed Dec 27 08:17:19 2017 +0100 packet-mq: Improve display of ID Struct + Segmented Msgs Improve display of ID Struct for FAP Lvl 13 Improve display for Segmented MQ Mesages Add also the ReasonCode of the ASYNCH_MESSAGE in column and tre node Added various new CONST for display Change-Id: I458296e466d0744627e0b4f645d634b0c6d930de Reviewed-on: https://code.wireshark.org/review/25009 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7dcf57719f6470cdfab4e3972d3009… commit 7dcf57719f6470cdfab4e3972d30097840b6fb11 Author: Florian Bezold <florian.bezold(a)esrlabs.com> Date: Thu Dec 7 08:54:41 2017 +0100 androiddump: Support older on-target tcpdump versions The output of 'tcpdump -D' only outputs interface flags from Android 7 onwards. Since it would be sad to lose the great androiddump support for all older devices because of this, the logic is extended so that it lists all interfaces if no '[' and ']' is found in the output. Also, the used regex seemed to require an interface description, which might not exist (even with new tcpdump versions). Now, interfaces without description are not filtered. Change-Id: I92b550a37b9bc0d0142aed68ee98f26de79be759 Reviewed-on: https://code.wireshark.org/review/24720 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4b7700db4b4a352db05e59e48cb729… commit 4b7700db4b4a352db05e59e48cb729045e805295 Author: Michael Mann <mmann78(a)netscape.net> Date: Mon Jan 1 14:11:26 2018 -0500 LNET: Fix gcc 7 compiler complaints Change-Id: Idad6411139226cb6694b8dad5cb2107882f90848 Reviewed-on: https://code.wireshark.org/review/25102 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=098fbc70ee43f0b38208068e842325… commit 098fbc70ee43f0b38208068e842325a252770fda Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 29 20:07:24 2017 +0100 ws_pipe: provide a null terminated string anyway (CID: 1364684). Change-Id: I4143b499986cbd31db524db73dde72ddbe26077d Reviewed-on: https://code.wireshark.org/review/25072 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9aa42e89c3fdc83ad2fa4ab17a2686… commit 9aa42e89c3fdc83ad2fa4ab17a2686d79be44a62 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 29 23:00:50 2017 +0100 dmp: rework build_national_strings() to avoid read/write overrun. CID: 1417455 CID: 1417459 Change-Id: Idb63e21608825562f61c445309c1b95bb5b3692c Reviewed-on: https://code.wireshark.org/review/25075 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=404d004907228c14fe66959f5d34d5… commit 404d004907228c14fe66959f5d34d52d0cae3f13 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Sun Dec 17 18:40:17 2017 +0100 IPv6: Add segmentation offload (TSO) support When capturing on hardware with segmentation offload enabled IPv6 payload size can be reported as zero. This commit adds a preference to dissect such frames. Heavily based on the TSO code of packet-ip.c Bug: 14155 Change-Id: Ibec3c35c739d8673fa655bde4f66198a22f567c4 Reviewed-on: https://code.wireshark.org/review/24900 Petri-Dish: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3d58a16038731bfe3f234756830ab3… commit 3d58a16038731bfe3f234756830ab300cf5c4dea Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Mon Jan 1 19:54:57 2018 +0100 TDS: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3345246de63781decc1046834f82f60f02ad54c0 Reviewed-on: https://code.wireshark.org/review/25101 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=296f1f35d87935869f8b646c86430f… commit 296f1f35d87935869f8b646c86430f39a1904ba2 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Mon Jan 1 19:49:31 2018 +0100 QUIC: fix build when don't have libgcrypt with AEAD (< 1.6.0) Change-Id: Ic77d12ac07f82ea315734782f97b035376b8b2e8 Reviewed-on: https://code.wireshark.org/review/25099 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws(a)gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=25a0583ec8d760bb6aacf52b672556… commit 25a0583ec8d760bb6aacf52b672556e57029727b Author: Lee Mitchell <lee(a)indigopepper.com> Date: Sun Dec 31 17:23:53 2017 +0000 Add dissector for NXP's 802.15.4 sniffer server messages Change-Id: I360bc4f802e28e9fc64cbd5cc06e514cbaf3b25f Reviewed-on: https://code.wireshark.org/review/25091 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=077124097d457514fdffa77209e661… commit 077124097d457514fdffa77209e6615b97dc6753 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Mon Jan 1 17:22:25 2018 +0100 ICMP: Resolve Extension Object Class value Resolve ICMP Extension Object Class value to name as defined at https://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml#icmp… Ping-Bug: 6632 Change-Id: I73ce9dbef5b09aa49f16c73a04ce474cd46f5695 Reviewed-on: https://code.wireshark.org/review/25098 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=564a3fae124afaaf6b2d7f2b9cda71… commit 564a3fae124afaaf6b2d7f2b9cda716fbd7f6f14 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Mon Jan 1 12:24:06 2018 +0100 Happy New Year 2018! Change-Id: I61ece8256384786c718fe2c1bc8813560fa372eb Reviewed-on: https://code.wireshark.org/review/25094 Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=3ab56e1c2af911ad532f77dd03653d… commit 3ab56e1c2af911ad532f77dd03653d82aeadd0ea Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Sun Dec 31 20:49:17 2017 +0000 sharkd: Add narrowing cast Needed on x86 windows as size_t < gint64 Change-Id: I2d5ca99c71a9f3a0138da786d10b111867337904 Reviewed-on: https://code.wireshark.org/review/25093 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=9b5e56802309f04eb7172cf94927c8… commit 9b5e56802309f04eb7172cf94927c8caa3bfb401 Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Sun Dec 31 19:10:44 2017 +0000 nfapi: Fix spurious checkAPI warnings Uppercase a lot of "index" words in strings to quieten checkAPI. Removed some redundant double spaces. Change-Id: Ica5915095037ec3da1d7c92d05c3a4d155bb302c Reviewed-on: https://code.wireshark.org/review/25092 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=1fa22c2ee9afd8e2d2b39c24428779… commit 1fa22c2ee9afd8e2d2b39c24428779b7ca815aa2 Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Sun Dec 31 16:58:05 2017 +0000 btmesh: replace\convert g_warning Replace g_warning with ws_g_warning, add expert info. Change-Id: I54ae5959f89ee85bdd821f07af8cf4ec3172748e Reviewed-on: https://code.wireshark.org/review/25090 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=3c35f278b99ad3f6b4ab6d58bc3405… commit 3c35f278b99ad3f6b4ab6d58bc3405e008c2021e Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Sun Dec 31 16:36:46 2017 +0000 nfapi: fix typo, correct expert info message assignmnet => assignment update message to show its the length value in error Change-Id: Ic320dafb00d4e6ceb7b3b7addaf2bff25739851f Reviewed-on: https://code.wireshark.org/review/25089 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=771e581b94b66c17033e5490f6d1fd… commit 771e581b94b66c17033e5490f6d1fd591da9026f Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Sun Dec 31 15:06:16 2017 +0000 Debian Packaging: Add new symbol wtap_addrinfo_list_empty added by 9bf40d Change-Id: I461560afe2dcf7da33c5730562d18c15fae9959e Reviewed-on: https://code.wireshark.org/review/25087 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=b9210c72f547b5f9b0fb84f28c68a8… commit b9210c72f547b5f9b0fb84f28c68a801acaa54fe Author: Graham Bloice <graham.bloice(a)trihedral.com> Date: Thu Nov 16 18:23:01 2017 +0000 DNP3: Add support for new Group 0 variations Add support for new objects g0v196-210 Rework handling of g0 objects Change-Id: I64c46cf4709799711a7cc6ca77fe356e47dced62 Reviewed-on: https://code.wireshark.org/review/25086 Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=a8088cce8806d78eb6f9c203009699… commit a8088cce8806d78eb6f9c20300969901c9258068 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Dec 23 15:57:18 2017 +0100 QUIC: Add decrypt of Initial Packet Missing Handshake and need to fix dissection of payload with varint change... Bug: 13881 Change-Id: Ib8fb6321436d72c8c4dba172dd43ef31288615d9 Reviewed-on: https://code.wireshark.org/review/24962 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1fcc10c17e78617dad08fa32e692ac… commit 1fcc10c17e78617dad08fa32e692ac03988cc12c Author: Nathaniel Clark <nathaniel.l.clark(a)intel.com> Date: Thu Nov 2 11:47:33 2017 -0400 [lnet] Initial Lustre Network Support Add Lustre Networking layer LNET. Change-Id: I36eb9eac7e0f5e40dece0ef2ad7c038fab10e192 Signed-off-by: Nathaniel Clark <nathaniel.l.clark(a)intel.com> Reviewed-on: https://code.wireshark.org/review/24795 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=de1017462905748e92c328559683d5… commit de1017462905748e92c328559683d55569f0b68f Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 31 14:05:14 2017 +0000 transum(plugin) fix typo reponse => response found by lintian Change-Id: I8a15c7ba236024448e2ad328b200872b0c622988 Reviewed-on: https://code.wireshark.org/review/25085 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=6f84e1b5f3a87489785a7ee31049d8… commit 6f84e1b5f3a87489785a7ee31049d83823ceb0b9 Author: Gerald Combs <gerald(a)wireshark.org> Date: Tue Dec 26 10:03:09 2017 -0600 Qt: Fixup fieldSelected behavior. Check the originating sender of fieldSelected in a couple of places so that we don't re-emit it. This fixes an issue that was keeping the byte view from marking the protocol. Remove duplicate signal+slot connections in MainWindow. Remove an unused member function. Change-Id: Ia876bb4117d1e30a56f4c335a65f6976c8058f9d Reviewed-on: https://code.wireshark.org/review/25077 Petri-Dish: Gerald Combs <gerald(a)wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f9307105855036231db67a840b9d1b… commit f9307105855036231db67a840b9d1be464750990 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Dec 31 08:16:10 2017 +0000 [Automatic update for 2017-12-31] Update manuf, services enterprise numbers, translations, and other items. Change-Id: I38b0274b93baf3e2d307827f04960f4bf7407842 Reviewed-on: https://code.wireshark.org/review/25080 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d17c26eafb44a5d2b9728285e018a6… commit d17c26eafb44a5d2b9728285e018a6b984d4cb14 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 29 23:36:25 2017 +0100 profinet: add a nested fake variable to avoid null dereference. CID: 1373682 CID: 1394504 Change-Id: I12ac26aad43ba817f71638605ecd6ad05d1af455 Reviewed-on: https://code.wireshark.org/review/25076 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5daead33aedc5df06da0aacfeb0513… commit 5daead33aedc5df06da0aacfeb05136fdfd625a0 Author: Kenneth Soerensen <knnthsrnsn(a)gmail.com> Date: Fri Dec 29 19:55:50 2017 +0100 ZigBee: Add remaining attributes from Smart Energy Price cluster Change-Id: I365e40d1e0c287ecfcee30fb72538d360926b827 Reviewed-on: https://code.wireshark.org/review/25068 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3b4aabe8181a7636d09aae7b926e9d… commit 3b4aabe8181a7636d09aae7b926e9d3b00be0294 Author: Thomas Chen <funorpain(a)gmail.com> Date: Fri Dec 29 21:36:00 2017 +0800 websocket: All decompressed payloads are same when more than one compressed data payload in a TCP PDU. Change-Id: Ie31721a34518dd87a99621ea6f0234f2cd7d9e85 Reviewed-on: https://code.wireshark.org/review/25066 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=998507d327b9c57d5b3a9627bc5a1d… commit 998507d327b9c57d5b3a9627bc5a1dcd40e4756d Author: Thomas Chen <funorpain(a)gmail.com> Date: Fri Dec 29 21:26:42 2017 +0800 proto_data.c: Fix bug in p_remove_proto_data. Change-Id: I44654b1aa6f513a0bccb88cba3181f5c52073832 Reviewed-on: https://code.wireshark.org/review/25065 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ea8d0c51b3a7ec0331e7c09c45a8d0… commit ea8d0c51b3a7ec0331e7c09c45a8d05267f6163a Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Dec 29 07:56:09 2017 +0100 proto(.h): fix indent (align...) Change-Id: Ie3f41b76719a5e91c27b5ae2805f23cd26f1fa11 Reviewed-on: https://code.wireshark.org/review/25059 Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5bdd3332407e22d044df97dfa4e4e0… commit 5bdd3332407e22d044df97dfa4e4e08e66352d60 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 19:52:12 2017 +0100 Qt: add check after cast. CID: 1396367. CID: 1373059. Change-Id: Icf47537608166ccd7c2028b71c0169d3469da9c0 Reviewed-on: https://code.wireshark.org/review/25043 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c7c5e2abb1d75d252f0b48e98ba1de… commit c7c5e2abb1d75d252f0b48e98ba1de1f2b40e8cc Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 22:52:26 2017 +0100 Qt: handle a failed open file the right way (CID: 1159174). Change-Id: Ia639a4b530cc9fdf7b72887031bc029c065d2162 Reviewed-on: https://code.wireshark.org/review/25048 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=727fac4559402b0efbe64309355db1… commit 727fac4559402b0efbe64309355db1c86babb9fc Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 19:34:36 2017 +0100 Qt: remove unneeded check (CID: 1415729). base_graph_ is always set in the constructor. Change-Id: I760e26a612458c15b47cd5381a6b7eb284b2cdf4 Reviewed-on: https://code.wireshark.org/review/25041 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0b124bff9b5e6c185e941520624e7c… commit 0b124bff9b5e6c185e941520624e7c4cd43dcbae Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 29 19:51:18 2017 +0100 cip: initialize variable (CID: 1403067). Change-Id: I65c1b59f8dd6adb471872b74ec9963066053ec66 Reviewed-on: https://code.wireshark.org/review/25071 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d5f0157c0967eb547de1799331163c… commit d5f0157c0967eb547de1799331163ce5cbd88b00 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 29 19:37:45 2017 +0100 Qt: add initializers (CID: 1412975). This commit completes change I5a161a98a90efb7dda95646c4f025c34623b0327, incomplete by mistake. Change-Id: I5236a8cd86b4955e5605c234bc04f832ff3e4f47 Reviewed-on: https://code.wireshark.org/review/25070 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0c4a307ee5d94bedf7410c5b0d0e18… commit 0c4a307ee5d94bedf7410c5b0d0e18ae502561f5 Author: Dirk Römmen <dirk.roemmen(a)cslab.de> Date: Fri Dec 29 08:05:42 2017 +0100 Corrected gcc-7 compilation warning "implicit fallthrough" in BACnet dissector. Change-Id: I28c1d2b811209f9e3e606244cf420356af1ddecf Reviewed-on: https://code.wireshark.org/review/25060 Reviewed-by: Dario Lombardo <lomato(a)gmail.com> Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d089cca16b56fd72a69373e97b79ea… commit d089cca16b56fd72a69373e97b79eaca8f9e154b Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Dec 28 21:16:25 2017 -0600 Qt: Miscellaneous translation hints. Add QT_TR_NOOP and comments in a few places. Change-Id: I77c964a4be463aa61de73fdd6af43623edc55474 Reviewed-on: https://code.wireshark.org/review/25051 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f31e9b31545b814e77e30b9a0f70e2… commit f31e9b31545b814e77e30b9a0f70e2f0e3f0afa4 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Fri Dec 29 13:15:05 2017 +0100 Use gcry_strerror() to get crypt error description. It seems using gcry_strerror() should be correct, it also fix building when --without-gnutls (when -lgpg-error is not added): /usr/bin/ld: epan/.libs/libwireshark.a(packet-ipsec.o): undefined reference to symbol 'gpg_strerror@@GPG_ERROR_1.0' Change-Id: I142e2e553fd7da501bd57635b8826ff42e114085 Reviewed-on: https://code.wireshark.org/review/25064 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=95bb65ff258e2c818a1233887f3932… commit 95bb65ff258e2c818a1233887f3932fa9a0e856a Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sat Dec 23 15:17:36 2017 +0100 QUIC: Initial draft-08 support Add new Long and Short Packet type Set version field before packet number Bug: 13881 Change-Id: I894bc5ada0d5d0269c8d12749533eaa07c553635 Reviewed-on: https://code.wireshark.org/review/24961 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b60a60717f8d3ac23253f5cc1767c8… commit b60a60717f8d3ac23253f5cc1767c8a8c58f06a3 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Dec 28 23:10:38 2017 +0100 btatt: Skip Units and Members UUIDs in decode-as Change-Id: I926c2abdfb6620236fabd6ae5aa1aa35d1fa79d2 Reviewed-on: https://code.wireshark.org/review/25050 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ead32b56281f2f33b4b9bdc69df795… commit ead32b56281f2f33b4b9bdc69df79516e515860b Author: Michael Mann <mmann78(a)netscape.net> Date: Thu Dec 28 12:34:20 2017 -0500 Populate Remote Interfaces with data from recent file Remote Interfaces have been saved in the recent_common file however they were never populated by the GUI. Bug: 8557 Change-Id: Ib68a75ce02f5b5e2c115b72d58c3e781a5122f9f Reviewed-on: https://code.wireshark.org/review/25039 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c693522e3312d4b7c4e4f68409e39f… commit c693522e3312d4b7c4e4f68409e39f1000644631 Author: Stig Bjørlykke <stig(a)bjorlykke.org> Date: Thu Dec 28 23:09:46 2017 +0100 bluetooth: Update Assigned Numbers Change-Id: I1565d8fa8983c36a6efe6ffbdb97b1e874632891 Reviewed-on: https://code.wireshark.org/review/25049 Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c791549a778aa34d83154b27fc9cd2… commit c791549a778aa34d83154b27fc9cd272e0d14881 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Dec 28 22:10:59 2017 -0800 No need to remove the old name after a save-with-move; it was, well, *moved*. Change-Id: Ic76eee870aff69b9daaf80d99fa619bf762258a1 Reviewed-on: https://code.wireshark.org/review/25058 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9bf40d4a6e507e10c8429a758ac190… commit 9bf40d4a6e507e10c8429a758ac190146caf48d6 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Dec 28 20:58:38 2017 -0800 Do the right check for "no name resolution information to save". The check that the pcapng code does is "do we have a non-null addrinfo_lists_t * and, if so, does it have a non-null ipv4_addr_list or ipv6_addr_list"? The check that the file-save code was using was just "do we have a non-null addrinfo_lists_t *", so sometimes it'd think we couldn't do a "quick save" even though we had no name resolution information to write out to the capture file. Make a routine that does that check, and use it in *both* places. Change-Id: Id4720f4fe4940354320b2b7621ca5e37e45ec1f3 Reviewed-on: https://code.wireshark.org/review/25055 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c5dbcca2e4f3613f04e74715269c61… commit c5dbcca2e4f3613f04e74715269c611dbb5259d1 Author: Guy Harris <guy(a)alum.mit.edu> Date: Thu Dec 28 19:58:04 2017 -0800 If we save a temporary file by copying or writing, remove it when we're done. Temporary files aren't supposed to stay around once we've done a save; the packets are now in the file to which we saved the contents. Bug: 14298 Change-Id: Ic64b1324fe92bda66ccbb82475ff75ad67637304 Reviewed-on: https://code.wireshark.org/review/25052 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=26222c96bb5708fdff87d1d8ebbab5… commit 26222c96bb5708fdff87d1d8ebbab57f8b4b1fef Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 19:48:17 2017 +0100 nvme-rdma: check return value of find_conversation() (CID: 1398218). Change-Id: I091471cbc59170f21f55aee0b29f1733f269cd05 Reviewed-on: https://code.wireshark.org/review/25042 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2677b07073c6b45a286532b05b9fc2… commit 2677b07073c6b45a286532b05b9fc26c9e1b4d70 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 22:40:31 2017 +0100 Qt: check preference existence. CID: 1159290 CID: 1159292 CID: 1159290 Change-Id: I7c4218f3aa67a2eaea5b052c751cb8757bcd168d Reviewed-on: https://code.wireshark.org/review/25047 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fb8b28005f53909e5b5a2ad8dc083b… commit fb8b28005f53909e5b5a2ad8dc083b1a9e2a0fed Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 20:20:14 2017 +0100 amqp: check return value of conversation_get_proto_data(). CID: 1325720. CID: 1325721. Change-Id: Ia781c70a3580fbd534b470664451e4838948dce4 Reviewed-on: https://code.wireshark.org/review/25045 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=422f1c0fb1daa84cb14982defe62c0… commit 422f1c0fb1daa84cb14982defe62c067bf8e5342 Author: Dario Lombardo <lomato(a)gmail.com> Date: Thu Dec 28 19:55:59 2017 +0100 Qt: check return value of strtok() (CID: 1372271). Change-Id: I588ecf79f53181af8ca48c5b32de54437d6275d3 Reviewed-on: https://code.wireshark.org/review/25044 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=456c3ff4a3fb10d959fea5d8a277e1… commit 456c3ff4a3fb10d959fea5d8a277e13fb0a76b62 Author: Pascal Quantin <pascal.quantin(a)gmail.com> Date: Thu Dec 28 18:39:25 2017 +0100 3GPP NAS: upgrade dissector to v14.6.0 Change-Id: If8d0ab933285f8398b0e8625e7c6e2ef0345fc95 Reviewed-on: https://code.wireshark.org/review/25040 Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2980e2523ada89017037e2125cebbf… commit 2980e2523ada89017037e2125cebbfb47e2f3578 Author: Michael Mann <mmann78(a)netscape.net> Date: Thu Dec 28 10:27:17 2017 -0500 recent.c: Make some capture_remote_* APIs static capture_remote_combo_add_recent and capture_remote_combo_recent_write_all aren't used outside of ui/recent.c (and shouldn't be) Change-Id: Iaef374edfa0b2c7afa8e76cd6403d3f56dfc5539 Reviewed-on: https://code.wireshark.org/review/25038 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=005ddc1d8b2aa079a39ace6cd65a5d… commit 005ddc1d8b2aa079a39ace6cd65a5d2ed24aed11 Author: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Date: Thu Dec 28 13:07:54 2017 +0100 sharkd: support for reference and previous displayed frame number Change-Id: Iced96044a8fc414d4cb1c62bcc67f61cf44c4515 Reviewed-on: https://code.wireshark.org/review/25033 Petri-Dish: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Jakub Zawadzki <darkjames-ws(a)darkjames.pl> http://cgit.osmocom.org/wireshark/commit/?id=f8670a96c8c23af062f08a218fc160… commit f8670a96c8c23af062f08a218fc160219412ea9d Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 22:48:03 2017 +0100 Qt: use QVariant::String instead of QMetaType::QString. They both have the value 10, but the checks are run against methods that return a QVariant::Type, then is formally more correct to use that. This also removes the need for a cast. CID: 1323929. CID: 1311958. CID: 1268202. CID: 1268201. CID: 1238868. Change-Id: I792c0e3b70b0f181867648d8f47a02c675200b10 Reviewed-on: https://code.wireshark.org/review/25036 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=02f7c444691239a79520e1420035e4… commit 02f7c444691239a79520e1420035e4bf215b4d1a Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 22:09:33 2017 +0100 rtps: remove unused ei entry. Change-Id: I3bb1470e6c5225a431bc49de9e6032e2016a1824 Reviewed-on: https://code.wireshark.org/review/25020 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b9341ad2d98af1a2c22b339dd2990f… commit b9341ad2d98af1a2c22b339dd2990f527d339a91 Author: Roland Knall <rknall(a)gmail.com> Date: Thu Dec 28 12:57:08 2017 +0100 Qt: Fix moc interface issue moc has an issue with interfaces defined in classes, where also other Qt objects are being defined. At least in some versions for Qt, this may lead to the interface declaration not being found Change-Id: Id143311322086abe23085d2482957ec330ae67c8 Reviewed-on: https://code.wireshark.org/review/25032 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6aa3502306ca6acc7f15f894731b84… commit 6aa3502306ca6acc7f15f894731b847bd75f6a4b Author: Dirk Römmen <dirk.roemmen(a)cslab.de> Date: Wed Dec 27 07:06:24 2017 -0500 Enhanced BACnet dissectors supporting BACnet revision 19. Bug: 12448 Bug: 12453 Bug: 12457 Change-Id: Ia8ed69ae1014f01ae246b31f6bb5aaedfc4656d2 Reviewed-on: https://code.wireshark.org/review/25010 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e3329cdc313e2a4c1e35a0f9d4f877… commit e3329cdc313e2a4c1e35a0f9d4f8777e3f9a77e1 Author: Roland Knall <rknall(a)gmail.com> Date: Thu Dec 28 11:22:06 2017 +0100 Qt: Remove duplicate copy actions Remove the final copy actions from MainWindow and use DataPrinter instead. This way, MainWindow no longer is involved in copying data, and the actions purely are defined by DataPrinter Change-Id: Ib70ad6394dee501bb2c8d58c9d174a0eb04b47de Reviewed-on: https://code.wireshark.org/review/25031 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fbeca26f035fe6a2a9632dee6d6916… commit fbeca26f035fe6a2a9632dee6d691629a6003d28 Author: Gizem Yurdagul <gizemnuryurdagul(a)gmail.com> Date: Wed Dec 27 14:48:16 2017 +0300 CMake: Additional default Cygwin location On 64bit Windows, Cygwin installer sets the installation path as "C:/tools/cygwin64", add this to the set of default locations when searching for Cygwin. Change-Id: I2d6ff0dfb18f24a595583c5a9c4b05d573e05e75 Reviewed-on: https://code.wireshark.org/review/25029 Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=25425839cfe06b6d6b3dbd5a0fc6c4… commit 25425839cfe06b6d6b3dbd5a0fc6c4ed6fed9546 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Wed Dec 27 23:38:42 2017 +0000 LTE stats: trivial changes after review Change-Id: Ibcb755440180fc761a547de55d14c3fdc32973de Reviewed-on: https://code.wireshark.org/review/25024 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=538f0883f73d385922a47ac7a2cd13… commit 538f0883f73d385922a47ac7a2cd13f0e5c5ec9e Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 17:47:26 2017 +0100 dcerpc-spoolss: remove unneeded check (CID: 1158734). Change-Id: Ie4f827835b9d59838d90d00e57f729c6a8004b19 Reviewed-on: https://code.wireshark.org/review/25015 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9b9f3098aca13e76eed16d085bb8bf… commit 9b9f3098aca13e76eed16d085bb8bf156f630558 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 21:57:25 2017 +0100 rtps: remove unneeded check (CID: 1158869). Change-Id: Ib9b2902c56fb569366e62a1d85b173862d29e61f Reviewed-on: https://code.wireshark.org/review/25019 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ccc931b0a7568b468d4eac61333400… commit ccc931b0a7568b468d4eac613334000de82ded90 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Sun Dec 24 13:12:19 2017 +0100 Netflow: Updated IEs (RFC8038, RFC8158, et al.) Updated InformationElements as defined at https://www.iana.org/assignments/ipfix/ipfix.xhtml Includes updates for RFC8038 and RFC8158. Change-Id: I66411428d0faee4290b5134b1c31c84b49996f2e Reviewed-on: https://code.wireshark.org/review/25013 Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bdccb597fee6dc6a8455c6727ca81d… commit bdccb597fee6dc6a8455c6727ca81ddcc912acf4 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Mon Dec 25 11:17:41 2017 +0100 ltp: don't assign a gint64 value to a guint64 variable evaluate_sdnv_64() returns gint64 and does indeed return -1 for errors. Use a gint64 variable to hold the return value, cast to guint64 if necessary. Change-Id: I2aa6f95302cf20f758a872c00c3d49857f2faea4 Reviewed-on: https://code.wireshark.org/review/24989 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a094154abefe7edced12cc06ded556… commit a094154abefe7edced12cc06ded5563756847f83 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 22:14:43 2017 +0100 scsi-smc: remove dead code (CID: 1159071). Change-Id: I1ecee4343b46da01ec60a8db76f19ca4c1996b34 Reviewed-on: https://code.wireshark.org/review/25022 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3a2773c9efd9da84c807150e32819b… commit 3a2773c9efd9da84c807150e32819b2c4afe6286 Author: Dario Lombardo <lomato(a)gmail.com> Date: Wed Dec 27 22:12:04 2017 +0100 nlsp: remove logically dead code (CID: 1158979). Change-Id: I2a6c6bb78a165f7fbc3864c4b721c0bf9064d12b Reviewed-on: https://code.wireshark.org/review/25021 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5c52ab7e45241af5c936ac391cac38… commit 5c52ab7e45241af5c936ac391cac386d224f2e86 Author: Michael Mann <mmann78(a)netscape.net> Date: Wed Dec 27 21:08:26 2017 -0500 extcap: Have extcap_spawn_sync use return value from ws_read_string_from_pipe Continuation from I162b1322fd970777d2156d869e95b005b0f045ac Change-Id: I5c93ad7eb5145577403721f3dd1ee8e836a4a828 Ping-Bug: 12845 Reviewed-on: https://code.wireshark.org/review/25025 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=22f17f918c20c6934edfdffd96942e… commit 22f17f918c20c6934edfdffd96942e45c0b2e28b Author: Guy Harris <guy(a)alum.mit.edu> Date: Wed Dec 27 19:38:27 2017 -0800 No need for read_new_line to return a packet offset. We can just call file_tell() before reading the line when doing sequential reads. Change-Id: Ide36d0b7d99ef3e76dbe1ddfad6c99972c04739a Reviewed-on: https://code.wireshark.org/review/25027 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9715aff0bd9c84a76e0dd364829cec… commit 9715aff0bd9c84a76e0dd364829cecde2a8a3610 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Dec 27 21:05:40 2017 +0000 capture_file(.h): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] Change-Id: I64c9fdefcf72add83944a6c38d5aa4e42dbaacb9 Reviewed-on: https://code.wireshark.org/review/25017 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3939ebe2738f85962d2a6152174d6e… commit 3939ebe2738f85962d2a6152174d6e555aa82ff0 Author: Roland Knall <rknall(a)gmail.com> Date: Wed Dec 27 19:19:49 2017 +0100 extcap: Increase spawn size Increase the spawn size to prevent windows from stopping if the output of the extcap utility is too long Bug: 12845 Change-Id: I162b1322fd970777d2156d869e95b005b0f045ac Reviewed-on: https://code.wireshark.org/review/25014 Reviewed-by: Michael Mann <mmann78(a)netscape.net> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e65ce97f1ad432519a6dc2e6618683… commit e65ce97f1ad432519a6dc2e6618683d9f7dbf27b Author: Michael Mann <mmann78(a)netscape.net> Date: Sun Dec 24 20:44:46 2017 -0500 Add template helper for simple Qt tree models Provide template class for data item of a tree model that has simple parent/child relationship and can handle the APIs necessary to navigate between parent/children. Also provide template class to shim between QAbstractItemModel and inherited class to handle "tree navigation" API. It's not supported by Qt 4.8, so hold off on actually using it. This saves a bunch of typing and enforces type safety. Change-Id: I431dee73625f5335b45fe9c6e4c2973932860ad8 Reviewed-on: https://code.wireshark.org/review/24988 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e641846837477b6cefa3e70d25ee45… commit e641846837477b6cefa3e70d25ee45f4713096b2 Author: Gerald Combs <gerald(a)wireshark.org> Date: Thu Dec 21 10:59:45 2017 -0800 Qt: Add "Copy as…" to the byte view. Make ByteViewText an IDataPrintable and add "Copy as…" context menu actions. Remove some unused functions. Bug: 14276 Change-Id: Ie48c7c9b016de19fd8978397d03d23e9a7fe247a Reviewed-on: https://code.wireshark.org/review/24933 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f1edf22602cf5bdab93c4e1f636241… commit f1edf22602cf5bdab93c4e1f6362419a0c261200 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Tue Dec 26 23:02:44 2017 +0000 Cleanup of tap-rlc-graph - fix type of callback function - prune unneeded includes - make a function static Change-Id: Ibfcf47016b2cde3d771dc7ec2b41f8296f108e2c Reviewed-on: https://code.wireshark.org/review/25006 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=4b1bd4742ce8049b9c349ce155c1da… commit 4b1bd4742ce8049b9c349ce155c1da7d0f18fa59 Author: Krishnamurthy Mayya <krishnamurthymayya(a)gmail.com> Date: Fri Oct 27 20:32:58 2017 -0700 LTP : Header and Trailer extension Corrections. This patchset involves the changes done to decode header and trailer extensions correctly. There were places where the frame offset was not handled properly leading to the improper decoding of the subsequent fields. Also, the subtree name for Trailer extension was not proper. Change-Id: Ia38ddddbcd83435ce8aaa73791a2f5a14918b48f Reviewed-on: https://code.wireshark.org/review/24140 Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=777acc73daaaca7bfe040354a6bacb… commit 777acc73daaaca7bfe040354a6bacbc905329e45 Author: Michael Mann <mmann78(a)netscape.net> Date: Tue Dec 26 19:42:08 2017 -0500 Apply new CaptureEvents to statistics dialogs. Refactoring from If366d42b07dc822636404ac44ba2306ec4418b4e ignored dialogs outside of the main window. Searched for removed signals from CaptureFile class and applied new CaptureEvent handling. Change-Id: I9e0aaa0dc1c702ce04810d27c8f9273997f7ca30 Reviewed-on: https://code.wireshark.org/review/25007 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cb7eef8ff8a33ff2513e2e28a63922… commit cb7eef8ff8a33ff2513e2e28a63922003e0cf9c3 Author: Michael Mann <mmann78(a)netscape.net> Date: Tue Dec 26 11:46:48 2017 -0500 Convert Export Objects dialog to use a model. Change-Id: I4be2c83755be95ab0deec15f066dd3e89b96a240 Reviewed-on: https://code.wireshark.org/review/25005 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=71c68662c85cdc786068d7c784d459… commit 71c68662c85cdc786068d7c784d459cf2c14c4a9 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Dec 26 18:21:18 2017 -0800 Add lzip to the "other compressed formats" comment. Change-Id: Ic54840f5ed52387f1fac2296cb251ba521d3a392 Reviewed-on: https://code.wireshark.org/review/25008 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=137ab7d5681486c6d6cc8faac4300b… commit 137ab7d5681486c6d6cc8faac4300b7cd4ec0cf1 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Tue Dec 26 11:48:04 2017 +0000 potential buffer underflow in File_read_line function in epan/wslua/wslua_file.c Putting up for review, though I am not completely convinced that file_gets() can return an empty line. Bug: 14295 Change-Id: If36761ea511b66c01a9f167809a218a7eadbfcc5 Reviewed-on: https://code.wireshark.org/review/24997 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5153a7aba255cfcecb6e766e6dfc90… commit 5153a7aba255cfcecb6e766e6dfc90ab82e8f8f7 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Dec 26 11:41:29 2017 -0800 Don't close something we didn't manage to open. Addresses Coverity CID 1426950. Change-Id: I5e47d1ede0ed8a56597fe71dad5a3e48191a0ad8 Reviewed-on: https://code.wireshark.org/review/25003 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6e844dc46ad56d5ea9439c7e49c672… commit 6e844dc46ad56d5ea9439c7e49c67251fdfb9900 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Dec 26 10:33:22 2017 -0800 Fix some comments. Change-Id: I8f22a38a944573e43f6232e0fab6188967deefd6 Reviewed-on: https://code.wireshark.org/review/24999 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9578e70d72c392d3491f1caead54fa… commit 9578e70d72c392d3491f1caead54fa8b1cc44165 Author: Guy Harris <guy(a)alum.mit.edu> Date: Tue Dec 26 10:06:52 2017 -0800 Handle DLT_ENC files *not* written on the same OS and byte-order host. Some fields in the header are in the byte order of the host that wrote them; one of them is a 32-bit AF_ value, and those are not likely ever to be > 65535, so they should never have any of the upper 16 bits set, and are also unlikely ever to be AF_UNSPEC, i.e. 0, so they should have at least one of the lower 16 bits set. This means that they will have at least one of the upper 16 bits set iff the host that wrote the file has the opposite byte order of the host that's reading the file; use that to determine whether to byte-swap the address-family or flags fields. (The SPI field is in *network* byte order.) Change-Id: I2d483c75d5c6bbab8fd16c5dc0a800f8710f764c Reviewed-on: https://code.wireshark.org/review/24998 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=540cdaf54c19ab11b93fa8b25da600… commit 540cdaf54c19ab11b93fa8b25da6009fb53d8961 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Dec 23 23:10:08 2017 +0000 RLC Stats: SaveAs working for all columns Note that when the iterator was used for the items within the tree (in TapParameterDialog::getTreeAsString()), the last 2 items/headers were not being seen. Don't know why, but when instead iterate by index, all column headers are visible. Change-Id: Ib5f38d1af0ecbefd400041584ba1d59d235dcbd1 Reviewed-on: https://code.wireshark.org/review/24969 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=971333665c1c74f22c3c6cd211f3ed… commit 971333665c1c74f22c3c6cd211f3edc5c0b28e00 Author: Martin Kaiser <wireshark(a)kaiser.cx> Date: Sun Dec 24 14:00:37 2017 +0100 qt: follow stream: use the new CaptureEvent signal The signals related to capture events were refactored recently. Adjust the follow stream dialogue to use the new CaptureEvent signal instead of the now removed signal CaptureFileClosing. Filter for context==file, event==closing in the signal handler. Change-Id: I2d75b424fbf0a6734b0290aa205dd3d0c1ce053f Reviewed-on: https://code.wireshark.org/review/24980 Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c18bc1291d42423e907d2ce0b3d4f3… commit c18bc1291d42423e907d2ce0b3d4f39ecd59e675 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Dec 25 23:12:55 2017 +0100 wiretap: remove unneeded check (CID: 1396988). Existence of in_file has been checked in line 908. Change-Id: Ida6c06362a1f88caec40701be7f3e42133ce404a Reviewed-on: https://code.wireshark.org/review/24994 Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=62f06b71962063736bfa359074802e… commit 62f06b71962063736bfa359074802e3a51271308 Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Dec 25 23:24:22 2017 +0100 epl: remove dead code and corresponding ei. Due to mask EPL_ASND_SDO_SEQ_CON_MASK, scon and rcon can't be > 3. Change-Id: Iaa2e8bae657ad57e4548a3f4749feda19ffaaf52 CID: 1220185. CID: 1220186. Reviewed-on: https://code.wireshark.org/review/24995 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b8ea5eb69df28601affec012dd3ae9… commit b8ea5eb69df28601affec012dd3ae93799e6293b Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Dec 25 23:07:29 2017 +0100 Qt: remove unneeded check. CID: 1402186. CID: 1402182. Change-Id: Icaae5e8b0459a4df751e08f45ce3f461a21499e8 Reviewed-on: https://code.wireshark.org/review/24993 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=588bcb172312d3e178ef8627b2fd2e… commit 588bcb172312d3e178ef8627b2fd2eee4bcd0c0f Author: Dario Lombardo <lomato(a)gmail.com> Date: Mon Dec 25 23:04:11 2017 +0100 epl: remove unreachable case (CID: 1412051). Change-Id: I0caa56ecfb2327dd9da55eb8a53d0c075061e8a2 Reviewed-on: https://code.wireshark.org/review/24992 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e0ccf38585115aa6c3ebe14f41353d… commit e0ccf38585115aa6c3ebe14f41353d5d78e2d039 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Nov 15 08:27:27 2017 +0100 QUIC: Add decrypt Cleartext Implements decryption of the four cleartext messages from https://tools.ietf.org/html/draft-ietf-quic-transport-07#section-5.4 Change-Id: I9d656613433251bd52d8614fdae5bbe37d4194ff Reviewed-on: https://code.wireshark.org/review/24504 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=56f1feb678c7dc1f3a26dfbad921bb… commit 56f1feb678c7dc1f3a26dfbad921bbc2605e0711 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Wed Nov 15 06:41:45 2017 +0000 TLS13,QUIC: prepare for QUIC decryption Add interface to expand the QUIC cleartext secrets (quic_derive_cleartext_secrets), an interface to create the cleartext ciphers (quic_create_cleartext_decoders), an interface to decrypt messages using this cipher (quic_decrypt_message). Change-Id: Id546150be2964959388b7ef69984b891521e5caa Reviewed-on: https://code.wireshark.org/review/24435 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5a3addd8eb3f7d2d8c8ceaf2789881… commit 5a3addd8eb3f7d2d8c8ceaf2789881ff9540bf31 Author: Ahmad Fatoum <ahmad(a)a3f.at> Date: Thu Dec 21 16:23:42 2017 +0100 Fix possible signed overflow Shouldn't have led to problems so far, assuming sane overflow behavior and sizeof (int) == sizeof (guint32), but better safe than sorry. Change-Id: I1e154b311b9f0e3113bc9c7b4d8456ede16804ef Reviewed-on: https://code.wireshark.org/review/24930 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=5f0f2d610fe0a53ff15d60821f77b3… commit 5f0f2d610fe0a53ff15d60821f77b3aec0f75b22 Author: Nick James <mookito(a)tuta.io> Date: Sat Dec 23 19:23:28 2017 +0200 RRC: Spot more UE transitions Adding support for URNTI mapping when UE is moving from PCH/FACH to DCH Change-Id: Iad67d7a88aac619171886cf35285e03d848146ae Reviewed-on: https://code.wireshark.org/review/24963 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8bc43e66a90b60a10d78a18b0a2f9c… commit 8bc43e66a90b60a10d78a18b0a2f9caf55378435 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Fri Dec 22 21:55:44 2017 +0100 fpp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ia396355d706f08772a597ecc45746d8d4bb0b0c1 Reviewed-on: https://code.wireshark.org/review/24952 Reviewed-by: Anton Glukhov <anton.a.glukhov(a)gmail.com> Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=340fc6f08aa4282440df4038721a21… commit 340fc6f08aa4282440df4038721a2153fc7ebb12 Author: Dario Lombardo <lomato(a)gmail.com> Date: Sat Dec 23 21:31:41 2017 +0100 Qt: rework ByteViewText::addFormatRange to avoid dead code (CID: 1426074). Change-Id: I8341a6106cd38118f0bf1bdb87aa87cc90e89eee Reviewed-on: https://code.wireshark.org/review/24966 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ca62cc8159ba6e62a81aba712e797… commit 7ca62cc8159ba6e62a81aba712e79792f78318f8 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Dec 20 20:32:09 2017 +0000 ipsec: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I5364e3deed22f98b77e2a6390e4cce6de3a9c7bd Reviewed-on: https://code.wireshark.org/review/24918 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4d0e0da64f19c40c1ebef0b1511e17… commit 4d0e0da64f19c40c1ebef0b1511e17272bcd33a8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Dec 24 15:14:17 2017 -0800 Another new symbol. Change-Id: I52c5825ea149e4fb22b6202c3f2c17e0a9e1ea06 Reviewed-on: https://code.wireshark.org/review/24987 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5f6571913b74c251abb45d2fec8c66… commit 5f6571913b74c251abb45d2fec8c66f3c7cbe36d Author: Guy Harris <guy(a)alum.mit.edu> Date: Sun Dec 24 13:15:38 2017 -0800 Note that the HE information is not yet a defined radiotap field. Warn that it is subject to change, although there is an experimental Linux patch using it, so it's probably *unlikely* to change. Update another comment while we're at it. Change-Id: I4d5eb1461a83b990b75312ebab9471c2fe4749af Reviewed-on: https://code.wireshark.org/review/24985 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=bad83f249fa583e1f26224a9bd7b55… commit bad83f249fa583e1f26224a9bd7b557f6d790c08 Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Dec 24 12:59:47 2017 +0100 Fix build and thread runtime compat with older GLib CentOS 6 ships with glib 2.28.8 which do not support g_ptr_array_new_full (make-taps/make-dissectors) and need to link with wsutil for glib-compat. g_thread_new was only introduced with GLib 2.32 (not 2.31), so adjust the check accordingly. Abort in case thread creation fails (as documented). Properly initialize threads or it will abort on runtime (this also requires linking epan with gthreads in CMake, autotools already includes it with GLIB_LIBS). Change-Id: Ie81d6df7b3b26aaa4eb25e23719a220755e2c13c Reviewed-on: https://code.wireshark.org/review/24978 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Reviewed-by: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8642d72f36239267c474ef096252dc… commit 8642d72f36239267c474ef096252dc64ac6fd710 Author: Uli Heilmeier <uh(a)heilmeier.eu> Date: Sun Dec 24 13:48:13 2017 +0100 Netflow: Fix typo for ntop_radius_acct_in_pkts Change-Id: If531189c0409050bf7213d3488ab32ccc0ee1000 Reviewed-on: https://code.wireshark.org/review/24979 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f5e7f273c98aadc26cd2549df84a24… commit f5e7f273c98aadc26cd2549df84a24ead50182dc Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Sun Dec 24 07:18:36 2017 -0800 ieee80211: Fix an unused variable error I introduced yesterday. Some compilers are more picky than others and I eliminated the use of a value_string array that I should not have in reorganizing the Extended Capabilities info. Change-Id: I1dcb09bf9f8df69445ebde8b88897482ddd1fa82 Reviewed-on: https://code.wireshark.org/review/24984 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f8b67cb931a94ba3e2e2bd252b05c4… commit f8b67cb931a94ba3e2e2bd252b05c4779cc0ecda Author: Peter Wu <peter(a)lekensteyn.nl> Date: Thu Nov 30 02:05:07 2017 +0000 Rename dissectors.c.in and fix CMake on removals "dissectors.c.in" is an input file for "make-dissectors" which outputs "dissectors.c", but does not contain C code. Rename it to "dissectors.in.txt" instead. When a dissector is removed from the list, the dissectors.c file was not properly generated even if CMake was re-run. Fix this by adding an additional dependency on the input file. autotools likely suffers from the same problem with removed files, I have not tried to fix that. Restore's João's original approach using file(GENERATE) to avoid using configure_file, this requires CMake 2.8.12. Change-Id: Id07cd8ef502186a90d41b3bb77ed0d9c94845af9 Fixes: v2.5.0rc0-1763-gfe0c2b0485 ("Rewrite make-dissector-reg.py in C") Reviewed-on: https://code.wireshark.org/review/24659 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j(a)v6e.pt> Reviewed-by: Peter Wu <peter(a)lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=28b463649fcc02fa5e639b5ae65313… commit 28b463649fcc02fa5e639b5ae65313ad2f6fb0d1 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sun Dec 24 09:10:29 2017 +0000 ieee80211: hide unused value_string variable packet-ieee80211.c:2326:27: error: ‘vht_max_mpdu_in_amsdu’ defined but not used [-Werror=unused-const-variable=] static const value_string vht_max_mpdu_in_amsdu[] = { Change-Id: If4cc416b7fe92dc7915e26d2d89abaa17b081c09 Reviewed-on: https://code.wireshark.org/review/24977 Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=c7ce426f84a8fb5f7f4739b15d85f6… commit c7ce426f84a8fb5f7f4739b15d85f68ef2a05e03 Author: Gerald Combs <gerald(a)wireshark.org> Date: Sun Dec 24 08:10:37 2017 +0000 [Automatic update for 2017-12-24] Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ia4acffe0372de93476cb677b1859509cec39216a Reviewed-on: https://code.wireshark.org/review/24974 Reviewed-by: Gerald Combs <gerald(a)wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=5bb5158b2e58614daa1226154a5b72… commit 5bb5158b2e58614daa1226154a5b72caa3c8bf03 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Sun Dec 24 08:11:34 2017 +0100 QUIC: fix 'num_ts' may be used uninitialized in this function [-Werror=maybe-uninitialized] with some old (and buggy) compiler (gcc 4.8.5) Change-Id: Ie5e4f71d3f4a12f786f2c8b139bba7a0688a8d29 Reviewed-on: https://code.wireshark.org/review/24973 Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=386f354f878c1a72ef3c3eba708f93… commit 386f354f878c1a72ef3c3eba708f936261fb7e09 Author: Michael Mann <mmann78(a)netscape.net> Date: Fri Dec 22 20:05:44 2017 -0500 Add Service Response Time dialog for SCSI. SCSI requires parameter data to be passed into the tap. Provide a new dialog that can handle SCSI commands. Bug: 14144 Change-Id: I4561f251ec38753a28befee33b8b994b04b92230 Reviewed-on: https://code.wireshark.org/review/24955 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5fcb223263880ad71b86b164d6dbc0… commit 5fcb223263880ad71b86b164d6dbc020c75e0549 Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Sat Dec 23 17:05:23 2017 -0800 ieee80211: More support for IEEE802.11 2016 around Extended Capabilities. This change handles both 8-byte and 9-byte extended capabilities fields by handling them as an 8-bit field if there are only 8 bytes, but handling them as a 16-bit field if there are 9 bytes. This is because one field straddles the bytes, but I have seen captures where only 8 bytes are present. Change-Id: I624fe34dd9c8ba7f25a451a172048897d867fcb5 Reviewed-on: https://code.wireshark.org/review/24971 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8d6202df4559d144bc8edc6fdf4bfa… commit 8d6202df4559d144bc8edc6fdf4bfa6112fe746f Author: Richard Sharpe <realrichardsharpe(a)gmail.com> Date: Sat Dec 23 07:31:19 2017 -0800 ieee80211-radiotap: Add definitions for HE information and dissect it. Now that HE Information is starting to be used in radiotap headers we need to start defining and showing these. More will be comming, especially the dissection of the header itself and carrying info in the ieee_802_11_phdr structure. Change-Id: I94c2184e83243656764147029295ad4ce4254416 Reviewed-on: https://code.wireshark.org/review/24945 Petri-Dish: Richard Sharpe <realrichardsharpe(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e30374d1691c5728cc979e9682ad4e… commit e30374d1691c5728cc979e9682ad4e99ea5c8252 Author: Dario Lombardo <lomato(a)gmail.com> Date: Sat Dec 23 21:52:20 2017 +0100 airpdcap: check return value for gcry_mac_read (CID: 1420699). Change-Id: Ifdf044d99e912ac90044aca7be503fdf39b4fe74 Reviewed-on: https://code.wireshark.org/review/24967 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c2dee336304a0bfb4e53ec3786c637… commit c2dee336304a0bfb4e53ec3786c637b5c96903ba Author: Dario Lombardo <lomato(a)gmail.com> Date: Sat Dec 23 21:24:15 2017 +0100 Qt: add initializer (CID: 1412975). Change-Id: I5a161a98a90efb7dda95646c4f025c34623b0327 Reviewed-on: https://code.wireshark.org/review/24965 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b1a2bef8bda4e8472757549b567fe5… commit b1a2bef8bda4e8472757549b567fe5b775d481aa Author: Peter Wu <peter(a)lekensteyn.nl> Date: Sun Dec 24 02:04:44 2017 +0100 mip: properly advance offset if !tree The offset must be advanced or else dissection of the following extensions will result in a malformed packet exception. Bug: 14292 Change-Id: I8b5cb2f377c8d3e01677b76f5bb6c3126dea64f9 Reviewed-on: https://code.wireshark.org/review/24970 Petri-Dish: Peter Wu <peter(a)lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=59688d3ec68818db7649b8cab9127f… commit 59688d3ec68818db7649b8cab9127f09ff6f5a1c Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Dec 23 14:16:10 2017 -0800 Update symbols. Change-Id: I9f4c20cdfc276a6c1faff2ee988846f0bbdc99a5 Reviewed-on: https://code.wireshark.org/review/24968 Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6a949ed1556f239a84a7ccb8d3b207… commit 6a949ed1556f239a84a7ccb8d3b207f99cdf71c8 Author: Guy Harris <guy(a)alum.mit.edu> Date: Sat Dec 23 00:05:21 2017 -0800 Put special pipe-handling code into libwsutil. Ask, in a comment, why we're doing PeekNamedPipe() when we're trying to read everyting in the pipe, up to the EOF, into a string. On UN*X, do the same "read up to an EOF and then NUL-terminate the result" stuff that we did on Windows; nothing guarantees that, on all UN*Xes, in all circumstances, until the end of time, world without end, amen, we can do one read and get the entire string. Change-Id: I578802b23fec1051139eaefd9a09fe2a6de06a11 Reviewed-on: https://code.wireshark.org/review/24959 Petri-Dish: Guy Harris <guy(a)alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy(a)alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=13a9c636a52ae2c6e2bc2070f4a4f0… commit 13a9c636a52ae2c6e2bc2070f4a4f047afe6a6ef Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Nov 15 07:20:36 2017 +0100 QUIC: STOP_SENDING error code is now application error code (with 2 bytes) Change-Id: I14ce4dc790da6d0b59514a5dcf28504d780934ea Reviewed-on: https://code.wireshark.org/review/24434 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5f1ed2b221758c317b639dd1823b3d… commit 5f1ed2b221758c317b639dd1823b3d7b957c0c8f Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Nov 15 07:02:22 2017 +0100 QUIC: RST_STREAM error code is now application error code (with 2 bytes) Change-Id: I2f5702069d494f535e4b1b8743e76a9e0a3e5945 Reviewed-on: https://code.wireshark.org/review/24433 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c60d7bb199afbd752aaa3640cfee22… commit c60d7bb199afbd752aaa3640cfee222585dd3e25 Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Date: Sat Dec 23 14:58:29 2017 +0000 LTE RLC stats: supply fields for Save As.. Also use double rather than float for bandwidth calculations. There is an issue where TapParameterDialog is not showing the last 2 column headings - most likely because 2 of the column headings are not used by UE entries (only channel entries). Will investigate after this. Change-Id: I3f691990b723434176060916153786665034b8d1 Reviewed-on: https://code.wireshark.org/review/24960 Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=7d88ca5cf98d8b3dab93e02f4e9136… commit 7d88ca5cf98d8b3dab93e02f4e9136ca699a0400 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Nov 15 06:57:08 2017 +0100 QUIC: not longer Timestamp Section/block with draft07 Change-Id: I37061bfc49324a1c621c9211571c7bbc26c26474 Reviewed-on: https://code.wireshark.org/review/24432 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5e202c026803954b8e3b709e335b10… commit 5e202c026803954b8e3b709e335b10da6bc93dbc Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Nov 14 23:09:44 2017 +0100 QUIC: Update Error Code (and not it is only 16 bytes) and update FT_CONNECTION_CLOSE Change-Id: I2758fb5b2b036d01c4fce3ef90bcafa0b000ee7d Reviewed-on: https://code.wireshark.org/review/24431 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=22d791d0aa2b80bb44aa9bcfbbc8b2… commit 22d791d0aa2b80bb44aa9bcfbbc8b20c545bf1eb Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Nov 14 22:49:45 2017 +0100 QUIC: Add APPLICATION_CLOSE (0x03) from draft07 Change-Id: Ief1a569659cfd4f2aeae5fd46d2de9548df5124a Reviewed-on: https://code.wireshark.org/review/24430 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=04685ac8fc200cec4582e923db0d09… commit 04685ac8fc200cec4582e923db0d0989b59d6d21 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Tue Nov 14 22:31:13 2017 +0100 QUIC: Add conversation support (to store version) and not for draft >= 07, display Cleartext Protected Payload (don't decrypt Cleartext AEAD yet...) Change-Id: I7f581d58371710c50d7d4631ad1c55da41e57444 Reviewed-on: https://code.wireshark.org/review/24425 Petri-Dish: Anders Broman <a.broman58(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=65276a4ebb734ffcd3e33defed23af… commit 65276a4ebb734ffcd3e33defed23af9e637ec116 Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com> Date: Wed Dec 20 20:40:11 2017 +0000 plugins: fix no previous prototype for function 'plugin_register' [-Wmissing-prototypes] Change-Id: I84f1fd02f99e7d4757e418539f932c550e409f92 Reviewed-on: https://code.wireshark.org/review/24920 Petri-Dish: João Valverde <j(a)v6e.pt> Reviewed-by: João Valverde <j(a)v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d5d815189d98745e3b33a6caadd4c2… commit d5d815189d98745e3b33a6caadd4c2dc5648a114 Author: Roland Knall <roland.knall(a)br-automation.com> Date: Fri Dec 22 13:58:02 2017 +0100 Qt: Redesign signal/slot concept of capture_file This is in preparation to make it easier for other classes to get the right signals from the capture file. Also the decision on what signals to listen to now resides with the final classes, not main window, and it no longer needs to be changed if the statusbar or wsapp needs additional signals. Change-Id: If366d42b07dc822636404ac44ba2306ec4418b4e Reviewed-on: https://code.wireshark.org/review/24941 Petri-Dish: Roland Knall <rknall(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d41d0f71485fdad56b27eac08c06cd… commit d41d0f71485fdad56b27eac08c06cd3d0235013d Author: Craig Jackson <cejackson51(a)gmail.com> Date: Thu Dec 14 17:43:17 2017 -0500 TDS: Dissect TDS4/5 login packet Add dissection of the TDS_BUF_LOGIN (aka TDS4/TDS5 login) packet. Add some support routines to remember the endian nature of each connection. Dissecting the TDS5 login requires dissecting the TDS_CAPABILITY token as well. Change-Id: Id92dedeaf4b5d192bab7ec99775e371f229db3e3 Reviewed-on: https://code.wireshark.org/review/24831 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58(a)gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7c149491452e605bdd1df225abf11d… commit 7c149491452e605bdd1df225abf11de7b5e61ccf Author: Michalis Kapsalakis <kapsalis1989(a)gmail.com> Date: Fri Dec 22 23:06:09 2017 +0100 EtherCAT: Fix unreached register This commit fixes the order of register 0x0012 in ecat_esc_registers array after the changes in 24949 Change-Id: If63921a5e3eb845e470b608161946f0477ff6e21 Reviewed-on: https://code.wireshark.org/review/24953 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=14009cefe89df8e50224c448874828… commit 14009cefe89df8e50224c44887482842668b9dab Author: Pascal S. de Kloe <pascal(a)quies.net> Date: Sat Dec 23 02:08:41 2017 +0100 IEC104: add section 7 [security] cause of transmission & type identifiers Change-Id: I960c1e1860bf4ec80260a105b7a5abbf5d8db386 Reviewed-on: https://code.wireshark.org/review/24958 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=271d6c14ef598e18e335a932d46626… commit 271d6c14ef598e18e335a932d466265376ac6c6f Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 22 17:21:25 2017 +0100 extcap: null terminate the string that will be used in strlen (CID 1364684). Change-Id: Ie4c7eed2ac24327292af9a45ffc7e4630338a6b4 Reviewed-on: https://code.wireshark.org/review/24948 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8a83e4d9ea7f75030e41396ce66abb… commit 8a83e4d9ea7f75030e41396ce66abbec4c6e8be4 Author: Dario Lombardo <lomato(a)gmail.com> Date: Fri Dec 22 23:43:59 2017 +0100 Qt: close file exiting from scope (CID: 1418343). Change-Id: Ie54fcf5c16f98addd512ef8efcfadfebac56177a Reviewed-on: https://code.wireshark.org/review/24954 Petri-Dish: Dario Lombardo <lomato(a)gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=54f6df525e57513398e348b76cd739… commit 54f6df525e57513398e348b76cd7395e6a4b1298 Author: Michael Mann <mmann78(a)netscape.net> Date: Fri Dec 22 15:50:16 2017 -0500 RPC Service Response Time dialog: Fix crash There were a few use-after-free situations. Fix one by using epan API to get program name for tap structure. tap structure shouldn't be deleted because it's needed. Will be freed by the tap reset/free function. Change-Id: Ia18d84340362839926036c777106ca1c6d1b18f5 Ping-Bug: 14141 Reviewed-on: https://code.wireshark.org/review/24950 Petri-Dish: Michael Mann <mmann78(a)netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78(a)netscape.net> ----------------------------------------------------------------------- Summary of changes: .gitignore | 8 +- .gitlab-ci.yml | 53 +- .travis.yml | 4 +- AUTHORS | 44 +- AUTHORS.src | 6 +- CMakeLists.txt | 596 +- CMakeListsCustom.txt.example | 14 +- CMakeOptions.txt | 10 +- ChangeLog | 10118 +++-------- ConfigureChecks.cmake | 15 +- Makefile.am | 58 +- Makefile.am.inc | 4 +- NEWS | 181 +- README.macos | 7 - acinclude.m4 | 47 +- autogen.sh | 14 +- capchild/CMakeLists.txt | 20 +- capchild/capture_ifinfo.c | 37 +- capchild/capture_session.h | 15 +- capchild/capture_sync.c | 168 +- capchild/capture_sync.h | 15 +- capinfos.c | 56 +- capture_info.c | 29 +- capture_info.h | 5 +- capture_opts.c | 51 +- capture_opts.h | 16 +- capture_stop_conditions.c | 2 +- capture_stop_conditions.h | 2 +- captype.c | 4 +- caputils/CMakeLists.txt | 20 +- caputils/airpcap.h | 16 +- caputils/airpcap_loader.c | 17 +- caputils/airpcap_loader.h | 17 +- caputils/capture-pcap-util-int.h | 15 +- caputils/capture-pcap-util-unix.c | 15 +- caputils/capture-pcap-util.c | 26 +- caputils/capture-pcap-util.h | 15 +- caputils/capture-wpcap.c | 15 +- caputils/capture-wpcap.h | 15 +- caputils/capture_ifinfo.h | 19 +- caputils/capture_win_ifnames.c | 129 +- caputils/capture_win_ifnames.h | 15 +- caputils/capture_wpcap_packet.c | 15 +- caputils/capture_wpcap_packet.h | 15 +- caputils/iface_monitor.c | 15 +- caputils/iface_monitor.h | 15 +- caputils/ws80211_utils.c | 31 +- caputils/ws80211_utils.h | 15 +- cfile.c | 2 +- cfile.h | 6 +- cmake/modules/FileInstall.cmake | 33 + cmake/modules/FindASCIIDOC.cmake | 262 - cmake/modules/FindAsciidoctor.cmake | 143 + cmake/modules/FindChocolatey.cmake | 26 +- cmake/modules/FindCygwin.cmake | 29 +- cmake/modules/FindFOP.cmake | 37 - cmake/modules/FindGEOIP.cmake | 74 - cmake/modules/FindLEX.cmake | 2 +- cmake/modules/FindLYNX.cmake | 22 - cmake/modules/FindMaxMindDB.cmake | 75 + cmake/modules/FindSH.cmake | 36 - cmake/modules/FindXSLTPROC.cmake | 78 +- cmake/modules/FindYACC.cmake | 2 +- cmake/modules/WiresharkPlugin.cmake | 9 +- cmakeconfig.h.in | 19 +- codecs/CMakeLists.txt | 14 +- codecs/G711a/G711adecode.c | 15 +- codecs/G711a/G711adecode.h | 15 +- codecs/G711a/G711atable.h | 15 +- codecs/G711u/G711udecode.c | 15 +- codecs/G711u/G711udecode.h | 15 +- codecs/G711u/G711utable.h | 15 +- codecs/G722/G722decode.c | 15 +- codecs/G722/G722decode.h | 15 +- codecs/G726/G726decode.c | 15 +- codecs/G726/G726decode.h | 15 +- codecs/G729/G729decode.c | 15 +- codecs/G729/G729decode.h | 15 +- codecs/codecs.c | 20 +- codecs/codecs.h | 15 +- codecs/sbc/sbc.c | 15 +- codecs/sbc/sbc_private.h | 15 +- conditions.c | 2 +- conditions.h | 2 +- configure.ac | 160 +- debian/changelog | 2 +- debian/control | 10 +- debian/headers-check.c | 14 +- debian/libwireshark-data.install | 2 +- debian/libwireshark0.symbols | 58 +- debian/libwiretap0.install | 1 + debian/libwiretap0.symbols | 9 +- debian/libwscodecs0.install | 1 + debian/libwsutil0.symbols | 9 +- debian/{geoip_db_paths => maxmind_db_paths} | 0 debian/patches/02_use_packaged_openlayers_js.patch | 17 - debian/patches/series | 1 - debian/po/de.po | 3 +- debian/rules | 3 +- dftest.c | 4 +- diameter/Huawei.xml | 28 +- diameter/Inovar.xml | 133 +- diameter/Juniper.xml | 4 +- diameter/TGPP.xml | 41 + diameter/dictionary.xml | 129 +- doc/CMakeLists.txt | 31 +- doc/Makefile.am | 16 +- doc/README.extcap | 10 +- doc/README.plugins | 89 +- doc/README.stats_tree | 2 +- doc/dumpcap.pod | 12 +- doc/eproto2sgml | 66 - doc/extcap_example.py | 2 +- doc/make-authors-format.pl | 2 +- doc/make-authors-short.pl | 2 +- doc/mmdbresolve.pod | 69 + doc/packet-PROTOABBREV.c | 2 +- doc/perlnoutf.pl | 2 +- doc/plugins.example/Makefile.am | 2 +- doc/plugins.example/hello.c | 2 +- doc/text2pcap.pod | 4 +- doc/tshark.pod | 250 +- doc/wireshark.pod.template | 4 +- docbook/CMakeLists.txt | 203 +- docbook/Makefile.am | 185 +- docbook/README.adoc | 144 + docbook/README.txt | 273 - docbook/asciidoctor-asciidoc.conf | 400 - docbook/asciidoctor-macros/README.adoc | 5 + docbook/asciidoctor-macros/commaize-block.rb | 6 + .../asciidoctor-macros/commaize-block/extension.rb | 46 + .../asciidoctor-macros/commaize-block/sample.adoc | 31 + .../asciidoctor-macros/cve_idlink-inline-macro.rb | 8 + .../cve_idlink-inline-macro/extension.rb | 30 + .../asciidoctor-macros/ws_buglink-inline-macro.rb | 8 + .../ws_buglink-inline-macro/extension.rb | 36 + .../asciidoctor-macros/ws_salink-inline-macro.rb | 8 + .../ws_salink-inline-macro/extension.rb | 29 + docbook/attributes.asciidoc | 14 +- docbook/common_src/GPL_appendix.asciidoc | 10 +- .../common_src/typographic_conventions.asciidoc | 11 +- docbook/custom_layer_pdf.xsl | 81 - docbook/custom_layer_single_html.xsl | 16 + docbook/developer-guide.asciidoc | 7 +- docbook/make-wsluarm.pl | 70 +- docbook/release-notes.asciidoc | 157 +- docbook/user-guide.asciidoc | 2 +- docbook/ws.css | 1037 +- docbook/wsdg_src/WSDG_chapter_build_intro.asciidoc | 16 +- docbook/wsdg_src/WSDG_chapter_capture.asciidoc | 72 +- docbook/wsdg_src/WSDG_chapter_dissection.asciidoc | 194 +- docbook/wsdg_src/WSDG_chapter_env_intro.asciidoc | 44 +- docbook/wsdg_src/WSDG_chapter_libraries.asciidoc | 51 +- docbook/wsdg_src/WSDG_chapter_quick_setup.asciidoc | 89 +- docbook/wsdg_src/WSDG_chapter_sources.asciidoc | 136 +- docbook/wsdg_src/WSDG_chapter_tools.asciidoc | 213 +- .../wsdg_src/WSDG_chapter_userinterface.asciidoc | 84 +- docbook/wsdg_src/WSDG_chapter_works.asciidoc | 28 +- docbook/wsdg_src/WSDG_preface.asciidoc | 6 +- docbook/wsluarm.asciidoc | 76 +- docbook/wsug_src/WSUG_app_files.asciidoc | 156 +- docbook/wsug_src/WSUG_app_howitworks.asciidoc | 22 +- docbook/wsug_src/WSUG_app_messages.asciidoc | 22 +- docbook/wsug_src/WSUG_app_protocols.asciidoc | 10 +- docbook/wsug_src/WSUG_app_tools.asciidoc | 58 +- docbook/wsug_src/WSUG_chapter_advanced.asciidoc | 266 +- .../wsug_src/WSUG_chapter_build_install.asciidoc | 52 +- docbook/wsug_src/WSUG_chapter_capture.asciidoc | 204 +- docbook/wsug_src/WSUG_chapter_customize.asciidoc | 215 +- .../wsug_src/WSUG_chapter_introduction.asciidoc | 69 +- docbook/wsug_src/WSUG_chapter_io.asciidoc | 211 +- docbook/wsug_src/WSUG_chapter_statistics.asciidoc | 80 +- docbook/wsug_src/WSUG_chapter_telephony.asciidoc | 16 +- .../wsug_src/WSUG_chapter_troubleshoot.asciidoc | 24 +- docbook/wsug_src/WSUG_chapter_use.asciidoc | 217 +- docbook/wsug_src/WSUG_chapter_work.asciidoc | 170 +- docbook/wsug_src/WSUG_preface.asciidoc | 6 +- docbook/wsug_src/dumpcap-h.txt | 9 +- docbook/wsug_src/editcap-T.txt | 1 + docbook/wsug_src/text2pcap-h.txt | 4 +- docbook/wsug_src/tshark-h.txt | 9 +- dumpcap.c | 69 +- editcap.c | 330 +- enterprises.tsv | 489 +- epan/CMakeLists.txt | 49 +- epan/Makefile.am | 45 +- epan/addr_and_mask.c | 14 +- epan/addr_and_mask.h | 14 +- epan/addr_resolv.c | 36 +- epan/addr_resolv.h | 20 +- epan/address.h | 14 +- epan/address_types.c | 20 +- epan/address_types.h | 14 +- epan/afn.c | 14 +- epan/afn.h | 14 +- epan/aftypes.c | 14 +- epan/aftypes.h | 14 +- epan/app_mem_usage.c | 14 +- epan/app_mem_usage.h | 14 +- epan/arcnet_pids.h | 14 +- epan/arptypes.h | 14 +- epan/asn1.c | 14 +- epan/asn1.h | 14 +- epan/ax25_pids.h | 14 +- epan/bridged_pids.h | 14 +- epan/capture_dissectors.c | 14 +- epan/capture_dissectors.h | 14 +- epan/charsets.c | 18 +- epan/charsets.h | 14 +- epan/chdlctypes.h | 14 +- epan/color_filters.c | 15 +- epan/color_filters.h | 14 +- epan/column-info.h | 14 +- epan/column-utils.c | 14 +- epan/column-utils.h | 14 +- epan/column.c | 14 +- epan/column.h | 14 +- epan/conv_id.h | 14 +- epan/conversation.c | 90 +- epan/conversation.h | 16 +- epan/conversation_debug.h | 14 +- epan/conversation_table.c | 14 +- epan/conversation_table.h | 14 +- epan/crc10-tvb.c | 14 +- epan/crc10-tvb.h | 14 +- epan/crc16-tvb.c | 14 +- epan/crc16-tvb.h | 14 +- epan/crc32-tvb.c | 14 +- epan/crc32-tvb.h | 14 +- epan/crc6-tvb.c | 14 +- epan/crc6-tvb.h | 14 +- epan/crc8-tvb.c | 14 +- epan/crc8-tvb.h | 14 +- epan/crypt/CMakeLists.txt | 22 +- epan/crypt/CMakeListsCustom.txt.example | 14 +- epan/crypt/Makefile.am | 28 +- epan/crypt/airpdcap.c | 2304 --- epan/crypt/airpdcap_ccmp.c | 280 - epan/crypt/airpdcap_debug.h | 121 - epan/crypt/airpdcap_int.h | 172 - epan/crypt/airpdcap_interop.h | 103 - epan/crypt/airpdcap_rijndael.c | 98 - epan/crypt/airpdcap_rijndael.h | 58 - epan/crypt/airpdcap_system.h | 354 - epan/crypt/airpdcap_tkip.c | 250 - epan/crypt/airpdcap_user.h | 242 - epan/crypt/airpdcap_ws.h | 51 - epan/crypt/dot11decrypt.c | 2289 +++ epan/crypt/dot11decrypt_ccmp.c | 256 + epan/crypt/dot11decrypt_debug.h | 95 + epan/crypt/dot11decrypt_int.h | 146 + epan/crypt/dot11decrypt_interop.h | 64 + epan/crypt/dot11decrypt_rijndael.c | 98 + epan/crypt/dot11decrypt_rijndael.h | 58 + epan/crypt/dot11decrypt_system.h | 328 + epan/crypt/dot11decrypt_tkip.c | 226 + epan/crypt/dot11decrypt_user.h | 216 + epan/crypt/dot11decrypt_ws.h | 25 + epan/crypt/kasumi.h | 14 +- epan/crypt/wep-wpadefs.h | 28 +- epan/decode_as.c | 24 +- epan/decode_as.h | 19 +- epan/dfilter/CMakeLists.txt | 40 +- epan/dfilter/Makefile.am | 24 +- epan/dfilter/dfilter-int.h | 14 +- epan/dfilter/dfilter-macro.c | 14 +- epan/dfilter/dfilter-macro.h | 14 +- epan/dfilter/dfilter.c | 14 +- epan/dfilter/dfilter.h | 14 +- epan/dfilter/dfunctions.c | 14 +- epan/dfilter/dfunctions.h | 14 +- epan/dfilter/dfvm.c | 14 +- epan/dfilter/dfvm.h | 14 +- epan/dfilter/drange.c | 14 +- epan/dfilter/drange.h | 14 +- epan/dfilter/gencode.c | 17 +- epan/dfilter/gencode.h | 14 +- epan/dfilter/scanner.l | 30 +- epan/dfilter/semcheck.c | 14 +- epan/dfilter/semcheck.h | 14 +- epan/dfilter/sttype-function.c | 14 +- epan/dfilter/sttype-function.h | 14 +- epan/dfilter/sttype-integer.c | 14 +- epan/dfilter/sttype-pointer.c | 14 +- epan/dfilter/sttype-range.c | 14 +- epan/dfilter/sttype-range.h | 14 +- epan/dfilter/sttype-set.c | 14 +- epan/dfilter/sttype-set.h | 14 +- epan/dfilter/sttype-string.c | 14 +- epan/dfilter/sttype-test.c | 14 +- epan/dfilter/sttype-test.h | 14 +- epan/dfilter/syntax-tree.c | 14 +- epan/dfilter/syntax-tree.h | 14 +- epan/diam_dict.h | 14 +- epan/diam_dict.l | 15 +- epan/disabled_protos.c | 14 +- epan/disabled_protos.h | 14 +- epan/dissector_filters.c | 14 +- epan/dissector_filters.h | 14 +- epan/dissectors/CMakeLists.txt | 51 +- epan/dissectors/CMakeListsCustom.txt.example | 14 +- epan/dissectors/Makefile.am | 45 +- epan/dissectors/asn1/CMakeLists.txt | 15 +- epan/dissectors/asn1/CMakeListsCustom.example.txt | 14 +- epan/dissectors/asn1/Custom.make | 14 +- epan/dissectors/asn1/HI2Operations/CMakeLists.txt | 14 +- epan/dissectors/asn1/HI2Operations/Makefile.am | 14 +- .../HI2Operations/packet-HI2Operations-template.c | 14 +- epan/dissectors/asn1/Makefile.am | 15 +- epan/dissectors/asn1/Makefile.inc | 14 +- epan/dissectors/asn1/acp133/CMakeLists.txt | 14 +- epan/dissectors/asn1/acp133/Makefile.am | 14 +- .../asn1/acp133/packet-acp133-template.c | 14 +- .../asn1/acp133/packet-acp133-template.h | 14 +- epan/dissectors/asn1/acse/CMakeLists.txt | 14 +- epan/dissectors/asn1/acse/Makefile.am | 14 +- epan/dissectors/asn1/acse/packet-acse-template.c | 14 +- epan/dissectors/asn1/acse/packet-acse-template.h | 14 +- epan/dissectors/asn1/ansi_map/CMakeLists.txt | 14 +- epan/dissectors/asn1/ansi_map/Makefile.am | 14 +- .../asn1/ansi_map/packet-ansi_map-template.c | 48 +- .../asn1/ansi_map/packet-ansi_map-template.h | 14 +- epan/dissectors/asn1/ansi_tcap/CMakeLists.txt | 14 +- epan/dissectors/asn1/ansi_tcap/Makefile.am | 14 +- .../asn1/ansi_tcap/packet-ansi_tcap-template.c | 14 +- .../asn1/ansi_tcap/packet-ansi_tcap-template.h | 14 +- epan/dissectors/asn1/atn-cm/CMakeLists.txt | 14 +- epan/dissectors/asn1/atn-cm/Makefile.am | 14 +- .../asn1/atn-cm/packet-atn-cm-template.c | 14 +- epan/dissectors/asn1/atn-cpdlc/CMakeLists.txt | 14 +- epan/dissectors/asn1/atn-cpdlc/Makefile.am | 14 +- .../asn1/atn-cpdlc/packet-atn-cpdlc-template.c | 14 +- epan/dissectors/asn1/atn-ulcs/CMakeLists.txt | 14 +- epan/dissectors/asn1/atn-ulcs/Makefile.am | 14 +- .../asn1/atn-ulcs/packet-atn-ulcs-template.c | 14 +- .../asn1/atn-ulcs/packet-atn-ulcs-template.h | 14 +- epan/dissectors/asn1/c1222/CMakeLists.txt | 14 +- epan/dissectors/asn1/c1222/Makefile.am | 14 +- epan/dissectors/asn1/c1222/packet-c1222-template.c | 14 +- epan/dissectors/asn1/c1222/packet-c1222-template.h | 14 +- epan/dissectors/asn1/camel/CMakeLists.txt | 14 +- epan/dissectors/asn1/camel/Makefile.am | 14 +- epan/dissectors/asn1/camel/packet-camel-template.c | 32 +- epan/dissectors/asn1/camel/packet-camel-template.h | 14 +- epan/dissectors/asn1/cdt/CMakeLists.txt | 14 +- epan/dissectors/asn1/cdt/Makefile.am | 14 +- epan/dissectors/asn1/cdt/packet-cdt-template.c | 14 +- epan/dissectors/asn1/cdt/packet-cdt-template.h | 14 +- epan/dissectors/asn1/charging_ase/CMakeLists.txt | 14 +- epan/dissectors/asn1/charging_ase/Makefile.am | 14 +- .../charging_ase/packet-charging_ase-template.c | 14 +- .../charging_ase/packet-charging_ase-template.h | 14 +- epan/dissectors/asn1/cmip/CMakeLists.txt | 14 +- epan/dissectors/asn1/cmip/Makefile.am | 14 +- epan/dissectors/asn1/cmip/packet-cmip-template.c | 14 +- epan/dissectors/asn1/cmip/packet-cmip-template.h | 14 +- epan/dissectors/asn1/cmp/CMakeLists.txt | 14 +- epan/dissectors/asn1/cmp/Makefile.am | 14 +- epan/dissectors/asn1/cmp/packet-cmp-template.c | 14 +- epan/dissectors/asn1/cmp/packet-cmp-template.h | 14 +- epan/dissectors/asn1/cms/CMSFirmwareWrapper.asn | 220 + epan/dissectors/asn1/cms/CMakeLists.txt | 15 +- epan/dissectors/asn1/cms/Makefile.am | 17 +- epan/dissectors/asn1/cms/cms.cnf | 17 + epan/dissectors/asn1/cms/packet-cms-template.c | 14 +- epan/dissectors/asn1/cms/packet-cms-template.h | 14 +- epan/dissectors/asn1/credssp/CMakeLists.txt | 14 +- epan/dissectors/asn1/credssp/Makefile.am | 14 +- .../asn1/credssp/packet-credssp-template.c | 14 +- .../asn1/credssp/packet-credssp-template.h | 14 +- epan/dissectors/asn1/crmf/CMakeLists.txt | 14 +- epan/dissectors/asn1/crmf/Makefile.am | 14 +- epan/dissectors/asn1/crmf/packet-crmf-template.c | 14 +- epan/dissectors/asn1/crmf/packet-crmf-template.h | 14 +- epan/dissectors/asn1/dap/CMakeLists.txt | 14 +- epan/dissectors/asn1/dap/Makefile.am | 14 +- epan/dissectors/asn1/dap/packet-dap-template.c | 14 +- epan/dissectors/asn1/dap/packet-dap-template.h | 14 +- epan/dissectors/asn1/disp/CMakeLists.txt | 14 +- epan/dissectors/asn1/disp/Makefile.am | 14 +- epan/dissectors/asn1/disp/packet-disp-template.c | 14 +- epan/dissectors/asn1/disp/packet-disp-template.h | 14 +- epan/dissectors/asn1/dop/CMakeLists.txt | 14 +- epan/dissectors/asn1/dop/Makefile.am | 14 +- epan/dissectors/asn1/dop/packet-dop-template.c | 14 +- epan/dissectors/asn1/dop/packet-dop-template.h | 14 +- epan/dissectors/asn1/dsp/CMakeLists.txt | 14 +- epan/dissectors/asn1/dsp/Makefile.am | 14 +- epan/dissectors/asn1/dsp/packet-dsp-template.c | 14 +- epan/dissectors/asn1/dsp/packet-dsp-template.h | 14 +- epan/dissectors/asn1/ess/CMakeLists.txt | 14 +- epan/dissectors/asn1/ess/Makefile.am | 14 +- epan/dissectors/asn1/ess/packet-ess-template.c | 14 +- epan/dissectors/asn1/ess/packet-ess-template.h | 14 +- epan/dissectors/asn1/ftam/CMakeLists.txt | 14 +- epan/dissectors/asn1/ftam/Makefile.am | 14 +- epan/dissectors/asn1/ftam/packet-ftam-template.c | 14 +- epan/dissectors/asn1/ftam/packet-ftam-template.h | 14 +- epan/dissectors/asn1/goose/CMakeLists.txt | 14 +- epan/dissectors/asn1/goose/Makefile.am | 14 +- epan/dissectors/asn1/goose/packet-goose-template.c | 14 +- epan/dissectors/asn1/gprscdr/CMakeLists.txt | 14 +- epan/dissectors/asn1/gprscdr/Makefile.am | 14 +- .../asn1/gprscdr/packet-gprscdr-template.c | 14 +- .../asn1/gprscdr/packet-gprscdr-template.h | 14 +- epan/dissectors/asn1/gsm_map/CMakeLists.txt | 14 +- epan/dissectors/asn1/gsm_map/Makefile.am | 14 +- .../asn1/gsm_map/packet-gsm_map-template.c | 56 +- .../asn1/gsm_map/packet-gsm_map-template.h | 14 +- epan/dissectors/asn1/h225/CMakeLists.txt | 14 +- epan/dissectors/asn1/h225/Makefile.am | 14 +- epan/dissectors/asn1/h225/packet-h225-template.c | 76 +- epan/dissectors/asn1/h225/packet-h225-template.h | 14 +- epan/dissectors/asn1/h235/CMakeLists.txt | 14 +- epan/dissectors/asn1/h235/Makefile.am | 14 +- epan/dissectors/asn1/h235/packet-h235-template.c | 14 +- epan/dissectors/asn1/h235/packet-h235-template.h | 14 +- epan/dissectors/asn1/h245/CMakeLists.txt | 14 +- epan/dissectors/asn1/h245/Makefile.am | 14 +- epan/dissectors/asn1/h245/packet-h245-template.c | 14 +- epan/dissectors/asn1/h245/packet-h245-template.h | 14 +- epan/dissectors/asn1/h248/CMakeLists.txt | 14 +- epan/dissectors/asn1/h248/Makefile.am | 14 +- epan/dissectors/asn1/h248/packet-h248-template.c | 13 +- epan/dissectors/asn1/h248/packet-h248-template.h | 14 +- epan/dissectors/asn1/h282/CMakeLists.txt | 14 +- epan/dissectors/asn1/h282/Makefile.am | 14 +- epan/dissectors/asn1/h282/packet-h282-template.c | 14 +- epan/dissectors/asn1/h283/CMakeLists.txt | 14 +- epan/dissectors/asn1/h283/Makefile.am | 14 +- epan/dissectors/asn1/h283/packet-h283-template.c | 14 +- epan/dissectors/asn1/h323/CMakeLists.txt | 14 +- epan/dissectors/asn1/h323/Makefile.am | 14 +- epan/dissectors/asn1/h323/packet-h323-template.c | 14 +- epan/dissectors/asn1/h323/packet-h323-template.h | 14 +- epan/dissectors/asn1/h450-ros/CMakeLists.txt | 14 +- epan/dissectors/asn1/h450-ros/Makefile.am | 14 +- .../asn1/h450-ros/packet-h450-ros-template.c | 14 +- .../asn1/h450-ros/packet-h450-ros-template.h | 14 +- epan/dissectors/asn1/h450/CMakeLists.txt | 14 +- epan/dissectors/asn1/h450/Makefile.am | 14 +- epan/dissectors/asn1/h450/packet-h450-template.c | 14 +- epan/dissectors/asn1/h460/CMakeLists.txt | 14 +- epan/dissectors/asn1/h460/Makefile.am | 14 +- epan/dissectors/asn1/h460/packet-h460-template.c | 14 +- epan/dissectors/asn1/h501/CMakeLists.txt | 14 +- epan/dissectors/asn1/h501/Makefile.am | 14 +- epan/dissectors/asn1/h501/packet-h501-template.c | 14 +- epan/dissectors/asn1/hnbap/CMakeLists.txt | 14 +- epan/dissectors/asn1/hnbap/Makefile.am | 14 +- epan/dissectors/asn1/hnbap/packet-hnbap-template.c | 14 +- epan/dissectors/asn1/idmp/CMakeLists.txt | 14 +- epan/dissectors/asn1/idmp/Makefile.am | 14 +- epan/dissectors/asn1/idmp/packet-idmp-template.c | 14 +- epan/dissectors/asn1/idmp/packet-idmp-template.h | 14 +- epan/dissectors/asn1/ilp/CMakeLists.txt | 14 +- epan/dissectors/asn1/ilp/Makefile.am | 14 +- epan/dissectors/asn1/ilp/packet-ilp-template.c | 14 +- epan/dissectors/asn1/inap/CMakeLists.txt | 14 +- epan/dissectors/asn1/inap/Makefile.am | 14 +- epan/dissectors/asn1/inap/packet-inap-template.c | 14 +- epan/dissectors/asn1/inap/packet-inap-template.h | 14 +- epan/dissectors/asn1/isdn-sup/CMakeLists.txt | 14 +- epan/dissectors/asn1/isdn-sup/Makefile.am | 14 +- .../asn1/isdn-sup/packet-isdn-sup-template.c | 14 +- epan/dissectors/asn1/kerberos/CMakeLists.txt | 14 +- epan/dissectors/asn1/kerberos/Makefile.am | 14 +- epan/dissectors/asn1/kerberos/k5.asn | 4 +- .../asn1/kerberos/packet-kerberos-template.c | 30 +- .../asn1/kerberos/packet-kerberos-template.h | 14 +- epan/dissectors/asn1/lcsap/CMakeLists.txt | 14 +- epan/dissectors/asn1/lcsap/Makefile.am | 14 +- epan/dissectors/asn1/lcsap/packet-lcsap-template.c | 14 +- epan/dissectors/asn1/lcsap/packet-lcsap-template.h | 14 +- epan/dissectors/asn1/ldap/CMakeLists.txt | 14 +- epan/dissectors/asn1/ldap/Makefile.am | 14 +- epan/dissectors/asn1/ldap/ldap.cnf | 6 +- epan/dissectors/asn1/ldap/packet-ldap-template.c | 14 +- epan/dissectors/asn1/ldap/packet-ldap-template.h | 14 +- .../asn1/logotypecertextn/CMakeLists.txt | 14 +- epan/dissectors/asn1/logotypecertextn/Makefile.am | 14 +- .../packet-logotypecertextn-template.c | 14 +- .../packet-logotypecertextn-template.h | 14 +- epan/dissectors/asn1/lpp/CMakeLists.txt | 14 +- epan/dissectors/asn1/lpp/LPP.asn | 4 +- epan/dissectors/asn1/lpp/Makefile.am | 14 +- epan/dissectors/asn1/lpp/lpp.cnf | 10 +- epan/dissectors/asn1/lpp/packet-lpp-template.c | 18 +- epan/dissectors/asn1/lpp/packet-lpp-template.h | 18 +- epan/dissectors/asn1/lppa/CMakeLists.txt | 14 +- epan/dissectors/asn1/lppa/Makefile.am | 14 +- epan/dissectors/asn1/lppa/packet-lppa-template.c | 14 +- epan/dissectors/asn1/lppe/CMakeLists.txt | 14 +- epan/dissectors/asn1/lppe/LPPe.asn | 5788 +++---- epan/dissectors/asn1/lppe/Makefile.am | 14 +- epan/dissectors/asn1/lppe/lppe.cnf | 7 +- epan/dissectors/asn1/lppe/packet-lppe-template.c | 18 +- epan/dissectors/asn1/lte-rrc/CMakeLists.txt | 14 +- .../asn1/lte-rrc/EUTRA-InterNodeDefinitions.asn | 8 +- .../asn1/lte-rrc/EUTRA-RRC-Definitions.asn | 808 +- .../asn1/lte-rrc/EUTRA-Sidelink-Preconf.asn | 2 +- .../dissectors/asn1/lte-rrc/EUTRA-UE-Variables.asn | 2 +- epan/dissectors/asn1/lte-rrc/Makefile.am | 14 +- .../asn1/lte-rrc/NBIOT-InterNodeDefinitions.asn | 26 +- .../asn1/lte-rrc/NBIOT-RRC-Definitions.asn | 59 +- .../dissectors/asn1/lte-rrc/NBIOT-UE-Variables.asn | 2 +- .../asn1/lte-rrc/PC5-RRC-Definitions.asn | 2 +- epan/dissectors/asn1/lte-rrc/lte-rrc.cnf | 182 +- .../asn1/lte-rrc/packet-lte-rrc-template.c | 43 +- .../asn1/lte-rrc/packet-lte-rrc-template.h | 16 +- epan/dissectors/asn1/m2ap/CMakeLists.txt | 14 +- epan/dissectors/asn1/m2ap/Makefile.am | 14 +- epan/dissectors/asn1/m2ap/packet-m2ap-template.c | 14 +- epan/dissectors/asn1/m3ap/CMakeLists.txt | 14 +- epan/dissectors/asn1/m3ap/Makefile.am | 14 +- epan/dissectors/asn1/m3ap/packet-m3ap-template.c | 14 +- epan/dissectors/asn1/mms/CMakeLists.txt | 14 +- epan/dissectors/asn1/mms/Makefile.am | 14 +- epan/dissectors/asn1/mms/packet-mms-template.c | 14 +- epan/dissectors/asn1/mms/packet-mms-template.h | 14 +- epan/dissectors/asn1/mpeg-audio/CMakeLists.txt | 14 +- epan/dissectors/asn1/mpeg-audio/Makefile.am | 14 +- .../asn1/mpeg-audio/packet-mpeg-audio-template.c | 14 +- epan/dissectors/asn1/mpeg-pes/CMakeLists.txt | 14 +- epan/dissectors/asn1/mpeg-pes/Makefile.am | 14 +- .../asn1/mpeg-pes/packet-mpeg-pes-template.c | 14 +- epan/dissectors/asn1/mudurl/CMakeLists.txt | 14 +- epan/dissectors/asn1/mudurl/Makefile.am | 14 +- .../asn1/mudurl/packet-mudurl-template.c | 14 +- epan/dissectors/asn1/nbap/CMakeLists.txt | 14 +- epan/dissectors/asn1/nbap/Makefile.am | 14 +- epan/dissectors/asn1/nbap/nbap.cnf | 435 +- epan/dissectors/asn1/nbap/packet-nbap-template.c | 60 +- epan/dissectors/asn1/nbap/packet-nbap-template.h | 14 +- epan/dissectors/asn1/novell_pkis/CMakeLists.txt | 14 +- epan/dissectors/asn1/novell_pkis/Makefile.am | 14 +- .../asn1/novell_pkis/packet-novell_pkis-template.c | 14 +- epan/dissectors/asn1/nr-rrc/CMakeLists.txt | 40 + epan/dissectors/asn1/nr-rrc/Makefile.am | 32 + .../asn1/nr-rrc/NR-InterNodeDefinitions.asn | 184 + epan/dissectors/asn1/nr-rrc/NR-RRC-Definitions.asn | 3063 ++++ epan/dissectors/asn1/nr-rrc/nr-rrc.cnf | 180 + .../asn1/nr-rrc/packet-nr-rrc-template.c | 109 + .../asn1/nr-rrc/packet-nr-rrc-template.h | 16 + epan/dissectors/asn1/ns_cert_exts/CMakeLists.txt | 14 +- epan/dissectors/asn1/ns_cert_exts/Makefile.am | 14 +- .../ns_cert_exts/packet-ns_cert_exts-template.c | 14 +- epan/dissectors/asn1/ocsp/CMakeLists.txt | 14 +- epan/dissectors/asn1/ocsp/Makefile.am | 14 +- epan/dissectors/asn1/ocsp/packet-ocsp-template.c | 14 +- epan/dissectors/asn1/ocsp/packet-ocsp-template.h | 14 +- epan/dissectors/asn1/p1/CMakeLists.txt | 14 +- epan/dissectors/asn1/p1/Makefile.am | 14 +- epan/dissectors/asn1/p1/packet-p1-template.c | 14 +- epan/dissectors/asn1/p1/packet-p1-template.h | 14 +- epan/dissectors/asn1/p22/CMakeLists.txt | 14 +- epan/dissectors/asn1/p22/Makefile.am | 14 +- epan/dissectors/asn1/p22/packet-p22-template.c | 14 +- epan/dissectors/asn1/p22/packet-p22-template.h | 14 +- epan/dissectors/asn1/p7/CMakeLists.txt | 14 +- epan/dissectors/asn1/p7/Makefile.am | 14 +- epan/dissectors/asn1/p7/packet-p7-template.c | 14 +- epan/dissectors/asn1/p7/packet-p7-template.h | 14 +- epan/dissectors/asn1/p772/CMakeLists.txt | 14 +- epan/dissectors/asn1/p772/Makefile.am | 14 +- epan/dissectors/asn1/p772/packet-p772-template.c | 14 +- epan/dissectors/asn1/p772/packet-p772-template.h | 14 +- epan/dissectors/asn1/pcap/CMakeLists.txt | 14 +- epan/dissectors/asn1/pcap/Makefile.am | 14 +- epan/dissectors/asn1/pcap/packet-pcap-template.c | 14 +- epan/dissectors/asn1/pkcs1/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkcs1/Makefile.am | 14 +- epan/dissectors/asn1/pkcs1/packet-pkcs1-template.c | 14 +- epan/dissectors/asn1/pkcs1/packet-pkcs1-template.h | 14 +- epan/dissectors/asn1/pkcs12/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkcs12/Makefile.am | 14 +- .../asn1/pkcs12/packet-pkcs12-template.c | 14 +- .../asn1/pkcs12/packet-pkcs12-template.h | 14 +- epan/dissectors/asn1/pkinit/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkinit/Makefile.am | 14 +- .../asn1/pkinit/packet-pkinit-template.c | 14 +- .../asn1/pkinit/packet-pkinit-template.h | 14 +- epan/dissectors/asn1/pkix1explicit/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkix1explicit/Makefile.am | 14 +- .../pkix1explicit/packet-pkix1explicit-template.c | 14 +- .../pkix1explicit/packet-pkix1explicit-template.h | 14 +- epan/dissectors/asn1/pkix1implicit/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkix1implicit/Makefile.am | 14 +- .../pkix1implicit/packet-pkix1implicit-template.c | 14 +- .../pkix1implicit/packet-pkix1implicit-template.h | 14 +- epan/dissectors/asn1/pkixac/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkixac/Makefile.am | 14 +- .../asn1/pkixac/packet-pkixac-template.c | 14 +- .../asn1/pkixac/packet-pkixac-template.h | 14 +- epan/dissectors/asn1/pkixproxy/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkixproxy/Makefile.am | 14 +- .../asn1/pkixproxy/packet-pkixproxy-template.c | 14 +- .../asn1/pkixproxy/packet-pkixproxy-template.h | 14 +- epan/dissectors/asn1/pkixqualified/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkixqualified/Makefile.am | 14 +- .../pkixqualified/packet-pkixqualified-template.c | 14 +- .../pkixqualified/packet-pkixqualified-template.h | 14 +- epan/dissectors/asn1/pkixtsp/CMakeLists.txt | 14 +- epan/dissectors/asn1/pkixtsp/Makefile.am | 14 +- .../asn1/pkixtsp/packet-pkixtsp-template.c | 14 +- .../asn1/pkixtsp/packet-pkixtsp-template.h | 14 +- epan/dissectors/asn1/pres/CMakeLists.txt | 14 +- epan/dissectors/asn1/pres/Makefile.am | 14 +- epan/dissectors/asn1/pres/packet-pres-template.c | 14 +- epan/dissectors/asn1/pres/packet-pres-template.h | 14 +- epan/dissectors/asn1/q932-ros/CMakeLists.txt | 14 +- epan/dissectors/asn1/q932-ros/Makefile.am | 14 +- .../asn1/q932-ros/packet-q932-ros-template.c | 14 +- epan/dissectors/asn1/q932/CMakeLists.txt | 14 +- epan/dissectors/asn1/q932/Makefile.am | 14 +- epan/dissectors/asn1/q932/packet-q932-template.c | 14 +- epan/dissectors/asn1/q932/packet-q932-template.h | 14 +- epan/dissectors/asn1/qsig/CMakeLists.txt | 14 +- epan/dissectors/asn1/qsig/Makefile.am | 14 +- epan/dissectors/asn1/qsig/packet-qsig-template.c | 14 +- epan/dissectors/asn1/qsig/packet-qsig-template.h | 14 +- epan/dissectors/asn1/ranap/CMakeLists.txt | 14 +- epan/dissectors/asn1/ranap/Makefile.am | 14 +- epan/dissectors/asn1/ranap/packet-ranap-template.c | 14 +- epan/dissectors/asn1/ranap/packet-ranap-template.h | 14 +- epan/dissectors/asn1/rnsap/CMakeLists.txt | 14 +- epan/dissectors/asn1/rnsap/Makefile.am | 14 +- epan/dissectors/asn1/rnsap/packet-rnsap-template.c | 14 +- epan/dissectors/asn1/ros/CMakeLists.txt | 14 +- epan/dissectors/asn1/ros/Makefile.am | 14 +- epan/dissectors/asn1/ros/packet-ros-template.c | 14 +- epan/dissectors/asn1/ros/packet-ros-template.h | 14 +- epan/dissectors/asn1/rrc/CMakeLists.txt | 14 +- epan/dissectors/asn1/rrc/Makefile.am | 14 +- epan/dissectors/asn1/rrc/packet-rrc-template.c | 67 +- epan/dissectors/asn1/rrc/packet-rrc-template.h | 29 +- epan/dissectors/asn1/rrc/rrc.cnf | 168 +- epan/dissectors/asn1/rrlp/CMakeLists.txt | 14 +- epan/dissectors/asn1/rrlp/Makefile.am | 14 +- epan/dissectors/asn1/rrlp/packet-rrlp-template.c | 14 +- epan/dissectors/asn1/rtse/CMakeLists.txt | 14 +- epan/dissectors/asn1/rtse/Makefile.am | 14 +- epan/dissectors/asn1/rtse/packet-rtse-template.c | 14 +- epan/dissectors/asn1/rtse/packet-rtse-template.h | 14 +- epan/dissectors/asn1/rua/CMakeLists.txt | 14 +- epan/dissectors/asn1/rua/Makefile.am | 14 +- epan/dissectors/asn1/rua/packet-rua-template.c | 14 +- epan/dissectors/asn1/s1ap/CMakeLists.txt | 14 +- epan/dissectors/asn1/s1ap/Makefile.am | 14 +- epan/dissectors/asn1/s1ap/S1AP-CommonDataTypes.asn | 2 +- epan/dissectors/asn1/s1ap/S1AP-Constants.asn | 24 +- epan/dissectors/asn1/s1ap/S1AP-Containers.asn | 2 +- epan/dissectors/asn1/s1ap/S1AP-IEs.asn | 185 +- epan/dissectors/asn1/s1ap/S1AP-PDU-Contents.asn | 87 +- .../dissectors/asn1/s1ap/S1AP-PDU-Descriptions.asn | 17 +- epan/dissectors/asn1/s1ap/S1AP-SonTransfer-IEs.asn | 2 +- epan/dissectors/asn1/s1ap/packet-s1ap-template.c | 81 +- epan/dissectors/asn1/s1ap/packet-s1ap-template.h | 14 +- epan/dissectors/asn1/s1ap/s1ap.cnf | 123 +- epan/dissectors/asn1/sabp/CMakeLists.txt | 14 +- epan/dissectors/asn1/sabp/Makefile.am | 14 +- epan/dissectors/asn1/sabp/packet-sabp-template.c | 14 +- epan/dissectors/asn1/sbc-ap/CMakeLists.txt | 14 +- epan/dissectors/asn1/sbc-ap/Makefile.am | 14 +- .../asn1/sbc-ap/SBC-AP-CommonDataTypes.asn | 2 +- epan/dissectors/asn1/sbc-ap/SBC-AP-Constants.asn | 39 +- epan/dissectors/asn1/sbc-ap/SBC-AP-Containers.asn | 2 +- epan/dissectors/asn1/sbc-ap/SBC-AP-IEs.asn | 221 +- .../dissectors/asn1/sbc-ap/SBC-AP-PDU-Contents.asn | 166 +- .../asn1/sbc-ap/SBC-AP-PDU-Descriptions.asn | 59 +- .../asn1/sbc-ap/packet-sbc-ap-template.c | 14 +- epan/dissectors/asn1/sbc-ap/sbc-ap.cnf | 104 +- epan/dissectors/asn1/smrse/CMakeLists.txt | 14 +- epan/dissectors/asn1/smrse/Makefile.am | 14 +- epan/dissectors/asn1/smrse/packet-smrse-template.c | 14 +- epan/dissectors/asn1/smrse/packet-smrse-template.h | 14 +- epan/dissectors/asn1/snmp/CMakeLists.txt | 14 +- epan/dissectors/asn1/snmp/Makefile.am | 14 +- epan/dissectors/asn1/snmp/packet-snmp-template.c | 26 +- epan/dissectors/asn1/snmp/packet-snmp-template.h | 14 +- epan/dissectors/asn1/spnego/CMakeLists.txt | 14 +- epan/dissectors/asn1/spnego/Makefile.am | 14 +- .../asn1/spnego/packet-spnego-template.c | 14 +- epan/dissectors/asn1/sv/CMakeLists.txt | 14 +- epan/dissectors/asn1/sv/Makefile.am | 14 +- epan/dissectors/asn1/sv/packet-sv-template.c | 14 +- epan/dissectors/asn1/sv/packet-sv-template.h | 14 +- epan/dissectors/asn1/t124/CMakeLists.txt | 14 +- epan/dissectors/asn1/t124/Makefile.am | 14 +- epan/dissectors/asn1/t124/packet-t124-template.c | 14 +- epan/dissectors/asn1/t124/packet-t124-template.h | 14 +- epan/dissectors/asn1/t125/CMakeLists.txt | 14 +- epan/dissectors/asn1/t125/Makefile.am | 14 +- epan/dissectors/asn1/t125/packet-t125-template.c | 14 +- epan/dissectors/asn1/t38/CMakeLists.txt | 14 +- epan/dissectors/asn1/t38/Makefile.am | 14 +- epan/dissectors/asn1/t38/packet-t38-template.c | 16 +- epan/dissectors/asn1/t38/packet-t38-template.h | 14 +- epan/dissectors/asn1/tcap/CMakeLists.txt | 14 +- epan/dissectors/asn1/tcap/Makefile.am | 14 +- epan/dissectors/asn1/tcap/packet-tcap-template.c | 14 +- epan/dissectors/asn1/tcap/packet-tcap-template.h | 14 +- epan/dissectors/asn1/tetra/CMakeLists.txt | 14 +- epan/dissectors/asn1/tetra/Makefile.am | 14 +- epan/dissectors/asn1/tetra/packet-tetra-template.c | 16 +- epan/dissectors/asn1/tetra/packet-tetra-template.h | 14 +- epan/dissectors/asn1/ulp/CMakeLists.txt | 14 +- epan/dissectors/asn1/ulp/Makefile.am | 14 +- epan/dissectors/asn1/ulp/packet-ulp-template.c | 14 +- epan/dissectors/asn1/wlancertextn/CMakeLists.txt | 14 +- epan/dissectors/asn1/wlancertextn/Makefile.am | 14 +- .../wlancertextn/packet-wlancertextn-template.c | 14 +- .../wlancertextn/packet-wlancertextn-template.h | 14 +- epan/dissectors/asn1/x2ap/CMakeLists.txt | 14 +- epan/dissectors/asn1/x2ap/Makefile.am | 14 +- epan/dissectors/asn1/x2ap/X2AP-CommonDataTypes.asn | 2 +- epan/dissectors/asn1/x2ap/X2AP-Constants.asn | 112 +- epan/dissectors/asn1/x2ap/X2AP-Containers.asn | 2 +- epan/dissectors/asn1/x2ap/X2AP-IEs.asn | 307 +- epan/dissectors/asn1/x2ap/X2AP-PDU-Contents.asn | 1587 +- .../dissectors/asn1/x2ap/X2AP-PDU-Descriptions.asn | 162 +- epan/dissectors/asn1/x2ap/packet-x2ap-template.c | 80 +- epan/dissectors/asn1/x2ap/x2ap.cnf | 948 +- epan/dissectors/asn1/x509af/CMakeLists.txt | 14 +- epan/dissectors/asn1/x509af/Makefile.am | 14 +- .../asn1/x509af/packet-x509af-template.c | 14 +- .../asn1/x509af/packet-x509af-template.h | 14 +- epan/dissectors/asn1/x509ce/CMakeLists.txt | 14 +- epan/dissectors/asn1/x509ce/Makefile.am | 14 +- .../asn1/x509ce/packet-x509ce-template.c | 14 +- .../asn1/x509ce/packet-x509ce-template.h | 14 +- epan/dissectors/asn1/x509if/CMakeLists.txt | 14 +- epan/dissectors/asn1/x509if/Makefile.am | 14 +- .../asn1/x509if/packet-x509if-template.c | 14 +- .../asn1/x509if/packet-x509if-template.h | 14 +- epan/dissectors/asn1/x509sat/CMakeLists.txt | 14 +- epan/dissectors/asn1/x509sat/Makefile.am | 14 +- .../asn1/x509sat/packet-x509sat-template.c | 14 +- .../asn1/x509sat/packet-x509sat-template.h | 14 +- epan/dissectors/asn1/x721/CMakeLists.txt | 14 +- epan/dissectors/dcerpc/CMakeLists.txt | 14 +- epan/dissectors/dcerpc/Makefile.am | 14 +- .../dcerpc/budb/packet-dcerpc-budb-template.c | 14 +- .../dcerpc/budb/packet-dcerpc-budb-template.h | 14 +- .../dcerpc/butc/packet-dcerpc-butc-template.c | 14 +- .../dcerpc/butc/packet-dcerpc-butc-template.h | 14 +- .../drsuapi/packet-dcerpc-drsuapi-template.c | 14 +- .../drsuapi/packet-dcerpc-drsuapi-template.h | 14 +- epan/dissectors/dcerpc/idl2wrs.c | 14 +- epan/dissectors/dissectors.h | 2 +- epan/dissectors/errno.c | 14 +- epan/dissectors/file-btsnoop.c | 14 +- epan/dissectors/file-elf.c | 20 +- epan/dissectors/file-file.c | 22 +- epan/dissectors/file-file.h | 14 +- epan/dissectors/file-gif.c | 14 +- epan/dissectors/file-jpeg.c | 14 +- epan/dissectors/file-mp4.c | 83 +- epan/dissectors/file-pcap.c | 14 +- epan/dissectors/file-pcapng.c | 135 +- epan/dissectors/file-png.c | 14 +- epan/dissectors/make-dissectors.c | 4 +- epan/dissectors/packet-2dparityfec.c | 14 +- epan/dissectors/packet-3com-njack.c | 14 +- epan/dissectors/packet-3com-xns.c | 14 +- epan/dissectors/packet-3g-a11.c | 14 +- epan/dissectors/packet-6lowpan.c | 40 +- epan/dissectors/packet-6lowpan.h | 14 +- epan/dissectors/packet-9p.c | 14 +- epan/dissectors/packet-HI2Operations.c | 24 +- epan/dissectors/packet-a21.c | 14 +- epan/dissectors/packet-a21.h | 14 +- epan/dissectors/packet-aarp.c | 14 +- epan/dissectors/packet-aastra-aasp.c | 14 +- epan/dissectors/packet-acap.c | 14 +- epan/dissectors/packet-acn.c | 14 +- epan/dissectors/packet-acp133.c | 26 +- epan/dissectors/packet-acp133.h | 14 +- epan/dissectors/packet-acr122.c | 14 +- epan/dissectors/packet-acse.c | 24 +- epan/dissectors/packet-acse.h | 16 +- epan/dissectors/packet-actrace.c | 14 +- epan/dissectors/packet-actrace.h | 14 +- epan/dissectors/packet-adb.c | 77 +- epan/dissectors/packet-adb_cs.c | 30 +- epan/dissectors/packet-adb_service.c | 14 +- epan/dissectors/packet-adb_service.h | 14 +- epan/dissectors/packet-adwin-config.c | 14 +- epan/dissectors/packet-adwin.c | 14 +- epan/dissectors/packet-aeron.c | 14 +- epan/dissectors/packet-afp.c | 14 +- epan/dissectors/packet-afp.h | 14 +- epan/dissectors/packet-afs.c | 14 +- epan/dissectors/packet-agentx.c | 14 +- epan/dissectors/packet-aim.c | 14 +- epan/dissectors/packet-ajp13.c | 14 +- epan/dissectors/packet-alcap.c | 14 +- epan/dissectors/packet-alcap.h | 14 +- epan/dissectors/packet-alljoyn.c | 14 +- epan/dissectors/packet-amqp.c | 19 +- epan/dissectors/packet-amr.c | 14 +- epan/dissectors/packet-amt.c | 14 +- epan/dissectors/packet-ancp.c | 14 +- epan/dissectors/packet-ans.c | 33 +- epan/dissectors/packet-ansi_637.c | 14 +- epan/dissectors/packet-ansi_683.c | 14 +- epan/dissectors/packet-ansi_801.c | 14 +- epan/dissectors/packet-ansi_a.c | 46 +- epan/dissectors/packet-ansi_a.h | 14 +- epan/dissectors/packet-ansi_map.c | 58 +- epan/dissectors/packet-ansi_map.h | 14 +- epan/dissectors/packet-ansi_tcap.c | 24 +- epan/dissectors/packet-ansi_tcap.h | 14 +- epan/dissectors/packet-aodv.c | 14 +- epan/dissectors/packet-aoe.c | 14 +- epan/dissectors/packet-aol.c | 14 +- epan/dissectors/packet-ap1394.c | 14 +- epan/dissectors/packet-app-pkix-cert.c | 14 +- epan/dissectors/packet-applemidi.c | 14 +- epan/dissectors/packet-aprs.c | 14 +- epan/dissectors/packet-ar_drone.c | 14 +- epan/dissectors/packet-arcnet.c | 14 +- epan/dissectors/packet-armagetronad.c | 14 +- epan/dissectors/packet-arp.c | 14 +- epan/dissectors/packet-arp.h | 14 +- epan/dissectors/packet-artemis.c | 2 +- epan/dissectors/packet-artnet.c | 14 +- epan/dissectors/packet-aruba-adp.c | 14 +- epan/dissectors/packet-aruba-erm.c | 16 +- epan/dissectors/packet-aruba-iap.c | 14 +- epan/dissectors/packet-aruba-papi.c | 14 +- epan/dissectors/packet-asap.c | 14 +- epan/dissectors/packet-ascend.c | 14 +- epan/dissectors/packet-asf.c | 14 +- epan/dissectors/packet-assa_r3.c | 14 +- epan/dissectors/packet-asterix.c | 14 +- epan/dissectors/packet-at.c | 14 +- epan/dissectors/packet-atalk.c | 16 +- epan/dissectors/packet-atalk.h | 14 +- epan/dissectors/packet-ath.c | 14 +- epan/dissectors/packet-atm.c | 14 +- epan/dissectors/packet-atm.h | 14 +- epan/dissectors/packet-atmtcp.c | 14 +- epan/dissectors/packet-atn-cm.c | 24 +- epan/dissectors/packet-atn-cpdlc.c | 24 +- epan/dissectors/packet-atn-ulcs.c | 24 +- epan/dissectors/packet-atn-ulcs.h | 14 +- epan/dissectors/packet-auto_rp.c | 14 +- epan/dissectors/packet-ax25-kiss.c | 14 +- epan/dissectors/packet-ax25-nol3.c | 14 +- epan/dissectors/packet-ax25.c | 14 +- epan/dissectors/packet-ax4000.c | 14 +- epan/dissectors/packet-ayiya.c | 14 +- epan/dissectors/packet-babel.c | 14 +- epan/dissectors/packet-bacapp.c | 5508 ++++-- epan/dissectors/packet-bacapp.h | 18 +- epan/dissectors/packet-bacnet.c | 1398 +- epan/dissectors/packet-bacnet.h | 30 + epan/dissectors/packet-banana.c | 14 +- epan/dissectors/packet-bat.c | 14 +- epan/dissectors/packet-batadv.c | 14 +- epan/dissectors/packet-bctp.c | 14 +- epan/dissectors/packet-beep.c | 14 +- epan/dissectors/packet-bencode.c | 14 +- epan/dissectors/packet-ber.c | 60 +- epan/dissectors/packet-ber.h | 14 +- epan/dissectors/packet-bfcp.c | 14 +- epan/dissectors/packet-bfd.c | 14 +- epan/dissectors/packet-bfd.h | 14 +- epan/dissectors/packet-bgp.c | 108 +- epan/dissectors/packet-bgp.h | 14 +- epan/dissectors/packet-bitcoin.c | 14 +- epan/dissectors/packet-bittorrent.c | 14 +- epan/dissectors/packet-bjnp.c | 14 +- epan/dissectors/packet-bluecom.c | 14 +- epan/dissectors/packet-bluetooth.c | 274 +- epan/dissectors/packet-bluetooth.h | 14 +- epan/dissectors/packet-bmc.c | 14 +- epan/dissectors/packet-bmp.c | 14 +- epan/dissectors/packet-bofl.c | 14 +- epan/dissectors/packet-bootp.c | 380 +- epan/dissectors/packet-bootparams.c | 14 +- epan/dissectors/packet-bpdu.c | 14 +- epan/dissectors/packet-bpq.c | 14 +- epan/dissectors/packet-brcm-tag.c | 14 +- epan/dissectors/packet-brdwlk.c | 14 +- epan/dissectors/packet-brp.c | 14 +- epan/dissectors/packet-bssap.c | 14 +- epan/dissectors/packet-bssap.h | 14 +- epan/dissectors/packet-bssgp.c | 14 +- epan/dissectors/packet-bssgp.h | 14 +- epan/dissectors/packet-bt-dht.c | 14 +- epan/dissectors/packet-bt-utp.c | 14 +- epan/dissectors/packet-bt3ds.c | 16 +- epan/dissectors/packet-btamp.c | 14 +- epan/dissectors/packet-btatt.c | 955 +- epan/dissectors/packet-btatt.h | 14 +- epan/dissectors/packet-btavctp.c | 16 +- epan/dissectors/packet-btavctp.h | 14 +- epan/dissectors/packet-btavdtp.c | 24 +- epan/dissectors/packet-btavdtp.h | 14 +- epan/dissectors/packet-btavrcp.c | 18 +- epan/dissectors/packet-btavrcp.h | 14 +- epan/dissectors/packet-btbnep.c | 16 +- epan/dissectors/packet-btbredr_rf.c | 14 +- epan/dissectors/packet-bthci_acl.c | 16 +- epan/dissectors/packet-bthci_acl.h | 14 +- epan/dissectors/packet-bthci_cmd.c | 124 +- epan/dissectors/packet-bthci_cmd.h | 14 +- epan/dissectors/packet-bthci_evt.c | 202 +- epan/dissectors/packet-bthci_evt.h | 14 +- epan/dissectors/packet-bthci_sco.c | 14 +- epan/dissectors/packet-bthci_sco.h | 14 +- epan/dissectors/packet-bthci_vendor.c | 14 +- epan/dissectors/packet-bthcrp.c | 16 +- epan/dissectors/packet-bthfp.c | 16 +- epan/dissectors/packet-bthid.c | 16 +- epan/dissectors/packet-bthsp.c | 16 +- epan/dissectors/packet-btl2cap.c | 61 +- epan/dissectors/packet-btl2cap.h | 14 +- epan/dissectors/packet-btle.c | 20 +- epan/dissectors/packet-btle.h | 14 +- epan/dissectors/packet-btle_rf.c | 14 +- epan/dissectors/packet-btmcap.c | 16 +- epan/dissectors/packet-btmesh.c | 108 +- epan/dissectors/packet-btrfcomm.c | 16 +- epan/dissectors/packet-btrfcomm.h | 14 +- epan/dissectors/packet-btsap.c | 16 +- epan/dissectors/packet-btsdp.c | 16 +- epan/dissectors/packet-btsdp.h | 14 +- epan/dissectors/packet-btsmp.c | 22 +- epan/dissectors/packet-bvlc.c | 591 +- epan/dissectors/packet-bzr.c | 14 +- epan/dissectors/packet-c1222.c | 24 +- epan/dissectors/packet-c1222.h | 14 +- epan/dissectors/packet-c15ch.c | 14 +- epan/dissectors/packet-calcappprotocol.c | 14 +- epan/dissectors/packet-camel.c | 50 +- epan/dissectors/packet-camel.h | 14 +- epan/dissectors/packet-caneth.c | 300 + epan/dissectors/packet-canopen.c | 14 +- epan/dissectors/packet-capwap.c | 14 +- epan/dissectors/packet-carp.c | 14 +- epan/dissectors/packet-cast.c | 14 +- epan/dissectors/packet-catapult-dct2000.c | 250 +- epan/dissectors/packet-cattp.c | 14 +- epan/dissectors/packet-cbor.c | 14 +- epan/dissectors/packet-ccsds.c | 14 +- epan/dissectors/packet-cdp.c | 192 +- epan/dissectors/packet-cdt.c | 26 +- epan/dissectors/packet-cdt.h | 16 +- epan/dissectors/packet-cell_broadcast.c | 14 +- epan/dissectors/packet-cell_broadcast.h | 14 +- epan/dissectors/packet-ceph.c | 15 +- epan/dissectors/packet-cfdp.c | 14 +- epan/dissectors/packet-cfm.c | 14 +- epan/dissectors/packet-cgmp.c | 14 +- epan/dissectors/packet-chargen.c | 16 +- epan/dissectors/packet-charging_ase.c | 24 +- epan/dissectors/packet-charging_ase.h | 16 +- epan/dissectors/packet-chdlc.c | 14 +- epan/dissectors/packet-chdlc.h | 14 +- epan/dissectors/packet-cigi.c | 14 +- epan/dissectors/packet-cimd.c | 14 +- epan/dissectors/packet-cimetrics.c | 14 +- epan/dissectors/packet-cip.c | 77 +- epan/dissectors/packet-cip.h | 17 +- epan/dissectors/packet-cipmotion.c | 70 +- epan/dissectors/packet-cipsafety.c | 141 +- epan/dissectors/packet-cipsafety.h | 15 +- epan/dissectors/packet-cisco-erspan.c | 38 +- epan/dissectors/packet-cisco-fp-mim.c | 14 +- epan/dissectors/packet-cisco-marker.c | 14 +- epan/dissectors/packet-cisco-metadata.c | 14 +- epan/dissectors/packet-cisco-oui.c | 14 +- epan/dissectors/packet-cisco-sm.c | 14 +- epan/dissectors/packet-cisco-ttag.c | 14 +- epan/dissectors/packet-cisco-wids.c | 14 +- epan/dissectors/packet-classicstun.c | 14 +- epan/dissectors/packet-clearcase.c | 14 +- epan/dissectors/packet-clearcase.h | 14 +- epan/dissectors/packet-clip.c | 14 +- epan/dissectors/packet-clique-rm.c | 14 +- epan/dissectors/packet-clnp.c | 14 +- epan/dissectors/packet-cmip.c | 30 +- epan/dissectors/packet-cmip.h | 16 +- epan/dissectors/packet-cmp.c | 26 +- epan/dissectors/packet-cmp.h | 16 +- epan/dissectors/packet-cmpp.c | 14 +- epan/dissectors/packet-cms.c | 937 +- epan/dissectors/packet-cms.h | 18 +- epan/dissectors/packet-cnip.c | 14 +- epan/dissectors/packet-coap.c | 22 +- epan/dissectors/packet-coap.h | 14 +- epan/dissectors/packet-collectd.c | 16 +- epan/dissectors/packet-componentstatus.c | 14 +- epan/dissectors/packet-cops.c | 14 +- epan/dissectors/packet-corosync-totemnet.c | 14 +- epan/dissectors/packet-corosync-totemsrp.c | 14 +- epan/dissectors/packet-coseventcomm.c | 14 +- epan/dissectors/packet-cosine.c | 14 +- epan/dissectors/packet-cosnaming.c | 14 +- epan/dissectors/packet-couchbase.c | 264 +- epan/dissectors/packet-cp2179.c | 14 +- epan/dissectors/packet-cpfi.c | 14 +- epan/dissectors/packet-cpha.c | 14 +- epan/dissectors/packet-cql.c | 14 +- epan/dissectors/packet-credssp.c | 24 +- epan/dissectors/packet-credssp.h | 16 +- epan/dissectors/packet-crmf.c | 26 +- epan/dissectors/packet-crmf.h | 16 +- epan/dissectors/packet-csm-encaps.c | 14 +- epan/dissectors/packet-csn1.c | 133 +- epan/dissectors/packet-csn1.h | 14 +- epan/dissectors/packet-ctdb.c | 26 +- epan/dissectors/packet-cups.c | 14 +- epan/dissectors/packet-cvspserver.c | 97 + epan/dissectors/packet-daap.c | 14 +- epan/dissectors/packet-dap.c | 32 +- epan/dissectors/packet-dap.h | 16 +- epan/dissectors/packet-data.c | 50 +- epan/dissectors/packet-daytime.c | 14 +- epan/dissectors/packet-db-lsp.c | 14 +- epan/dissectors/packet-dbus.c | 14 +- epan/dissectors/packet-dcc.c | 14 +- epan/dissectors/packet-dcc.h | 27 +- epan/dissectors/packet-dccp.c | 16 +- epan/dissectors/packet-dccp.h | 14 +- epan/dissectors/packet-dcerpc-bossvr.c | 14 +- epan/dissectors/packet-dcerpc-browser.c | 14 +- epan/dissectors/packet-dcerpc-browser.h | 14 +- epan/dissectors/packet-dcerpc-budb.c | 14 +- epan/dissectors/packet-dcerpc-budb.h | 14 +- epan/dissectors/packet-dcerpc-butc.c | 14 +- epan/dissectors/packet-dcerpc-butc.h | 14 +- epan/dissectors/packet-dcerpc-cds_clerkserver.c | 14 +- epan/dissectors/packet-dcerpc-cds_solicit.c | 14 +- epan/dissectors/packet-dcerpc-conv.c | 14 +- epan/dissectors/packet-dcerpc-cprpc_server.c | 14 +- epan/dissectors/packet-dcerpc-dce122.c | 14 +- epan/dissectors/packet-dcerpc-dce122.h | 14 +- epan/dissectors/packet-dcerpc-dcom.h | 14 +- epan/dissectors/packet-dcerpc-drsuapi.c | 14 +- epan/dissectors/packet-dcerpc-drsuapi.h | 14 +- epan/dissectors/packet-dcerpc-dtsprovider.c | 14 +- epan/dissectors/packet-dcerpc-dtsstime_req.c | 14 +- epan/dissectors/packet-dcerpc-epm.c | 14 +- epan/dissectors/packet-dcerpc-fileexp.c | 14 +- epan/dissectors/packet-dcerpc-fldb.c | 14 +- epan/dissectors/packet-dcerpc-frsapi.c | 14 +- epan/dissectors/packet-dcerpc-frsapi.h | 14 +- epan/dissectors/packet-dcerpc-ftserver.c | 14 +- epan/dissectors/packet-dcerpc-icl_rpc.c | 14 +- epan/dissectors/packet-dcerpc-krb5rpc.c | 14 +- epan/dissectors/packet-dcerpc-llb.c | 14 +- epan/dissectors/packet-dcerpc-messenger.c | 14 +- epan/dissectors/packet-dcerpc-mgmt.c | 14 +- epan/dissectors/packet-dcerpc-ndr.c | 14 +- epan/dissectors/packet-dcerpc-netlogon.c | 43 +- epan/dissectors/packet-dcerpc-netlogon.h | 14 +- epan/dissectors/packet-dcerpc-nt.c | 14 +- epan/dissectors/packet-dcerpc-nt.h | 14 +- epan/dissectors/packet-dcerpc-pnp.c | 14 +- epan/dissectors/packet-dcerpc-pnp.h | 14 +- epan/dissectors/packet-dcerpc-rdaclif.c | 14 +- epan/dissectors/packet-dcerpc-rep_proc.c | 14 +- epan/dissectors/packet-dcerpc-roverride.c | 14 +- epan/dissectors/packet-dcerpc-rpriv.c | 14 +- epan/dissectors/packet-dcerpc-rras.c | 14 +- epan/dissectors/packet-dcerpc-rras.h | 14 +- epan/dissectors/packet-dcerpc-rs_acct.c | 14 +- epan/dissectors/packet-dcerpc-rs_attr.c | 14 +- epan/dissectors/packet-dcerpc-rs_attr_schema.c | 14 +- epan/dissectors/packet-dcerpc-rs_bind.c | 14 +- epan/dissectors/packet-dcerpc-rs_misc.c | 14 +- epan/dissectors/packet-dcerpc-rs_pgo.c | 14 +- epan/dissectors/packet-dcerpc-rs_plcy.c | 14 +- epan/dissectors/packet-dcerpc-rs_prop_acct.c | 14 +- epan/dissectors/packet-dcerpc-rs_prop_acl.c | 14 +- epan/dissectors/packet-dcerpc-rs_prop_attr.c | 14 +- epan/dissectors/packet-dcerpc-rs_prop_pgo.c | 14 +- epan/dissectors/packet-dcerpc-rs_prop_plcy.c | 14 +- epan/dissectors/packet-dcerpc-rs_pwd_mgmt.c | 14 +- epan/dissectors/packet-dcerpc-rs_repadm.c | 14 +- epan/dissectors/packet-dcerpc-rs_replist.c | 14 +- epan/dissectors/packet-dcerpc-rs_repmgr.c | 14 +- epan/dissectors/packet-dcerpc-rs_unix.c | 14 +- epan/dissectors/packet-dcerpc-rsec_login.c | 14 +- epan/dissectors/packet-dcerpc-secidmap.c | 14 +- epan/dissectors/packet-dcerpc-spoolss.c | 24 +- epan/dissectors/packet-dcerpc-spoolss.h | 14 +- epan/dissectors/packet-dcerpc-svcctl.c | 14 +- epan/dissectors/packet-dcerpc-svcctl.h | 14 +- epan/dissectors/packet-dcerpc-tapi.c | 14 +- epan/dissectors/packet-dcerpc-tapi.h | 14 +- epan/dissectors/packet-dcerpc-tkn4int.c | 14 +- epan/dissectors/packet-dcerpc-trksvr.c | 14 +- epan/dissectors/packet-dcerpc-ubikdisk.c | 14 +- epan/dissectors/packet-dcerpc-ubikvote.c | 14 +- epan/dissectors/packet-dcerpc-update.c | 14 +- epan/dissectors/packet-dcerpc.c | 32 +- epan/dissectors/packet-dcerpc.h | 14 +- epan/dissectors/packet-dcm.c | 408 +- epan/dissectors/packet-dcom-dispatch.c | 14 +- epan/dissectors/packet-dcom-dispatch.h | 14 +- epan/dissectors/packet-dcom-oxid.c | 14 +- epan/dissectors/packet-dcom-remact.c | 14 +- epan/dissectors/packet-dcom-remunkn.c | 14 +- epan/dissectors/packet-dcom-sysact.c | 14 +- epan/dissectors/packet-dcom.c | 14 +- epan/dissectors/packet-dcom.h | 14 +- epan/dissectors/packet-dcp-etsi.c | 14 +- epan/dissectors/packet-ddtp.c | 14 +- epan/dissectors/packet-dec-bpdu.c | 14 +- epan/dissectors/packet-dec-dnart.c | 14 +- epan/dissectors/packet-dect.c | 14 +- epan/dissectors/packet-devicenet.c | 14 +- epan/dissectors/packet-dhcp-failover.c | 14 +- epan/dissectors/packet-dhcpv6.c | 14 +- epan/dissectors/packet-diameter.c | 124 +- epan/dissectors/packet-diameter.h | 14 +- epan/dissectors/packet-diameter_3gpp.c | 365 +- epan/dissectors/packet-diameter_3gpp.h | 14 +- epan/dissectors/packet-diffserv-mpls-common.c | 14 +- epan/dissectors/packet-diffserv-mpls-common.h | 14 +- epan/dissectors/packet-dis.c | 20 +- epan/dissectors/packet-disp.c | 26 +- epan/dissectors/packet-disp.h | 16 +- epan/dissectors/packet-distcc.c | 14 +- epan/dissectors/packet-dji-uav.c | 14 +- epan/dissectors/packet-dlm3.c | 14 +- epan/dissectors/packet-dlsw.c | 14 +- epan/dissectors/packet-dmp.c | 73 +- epan/dissectors/packet-dmx.c | 15 +- epan/dissectors/packet-dnp.c | 2431 +-- epan/dissectors/packet-dns.c | 52 +- epan/dissectors/packet-dns.h | 14 +- epan/dissectors/packet-docsis-macmgmt.c | 8607 ++++++++++ epan/dissectors/packet-docsis-tlv.c | 6518 ++++++++ epan/dissectors/packet-docsis-tlv.h | 472 + epan/dissectors/packet-docsis-vendor.c | 887 + epan/dissectors/packet-docsis.c | 1129 ++ epan/dissectors/packet-dof.c | 30 +- epan/dissectors/packet-dop.c | 26 +- epan/dissectors/packet-dop.h | 16 +- epan/dissectors/packet-dplay.c | 15 +- epan/dissectors/packet-dpnet.c | 15 +- epan/dissectors/packet-dpnss-link.c | 14 +- epan/dissectors/packet-dpnss.c | 14 +- epan/dissectors/packet-drda.c | 14 +- epan/dissectors/packet-dsi.c | 14 +- epan/dissectors/packet-dsp.c | 26 +- epan/dissectors/packet-dsp.h | 16 +- epan/dissectors/packet-dsr.c | 14 +- epan/dissectors/packet-dtcp-ip.c | 14 +- epan/dissectors/packet-dtls.c | 14 +- epan/dissectors/packet-dtls.h | 14 +- epan/dissectors/packet-dtn.c | 20 +- epan/dissectors/packet-dtn.h | 14 +- epan/dissectors/packet-dtp.c | 14 +- epan/dissectors/packet-dtpt.c | 14 +- epan/dissectors/packet-dua.c | 14 +- epan/dissectors/packet-dvb-ait.c | 14 +- epan/dissectors/packet-dvb-bat.c | 14 +- epan/dissectors/packet-dvb-data-mpe.c | 14 +- epan/dissectors/packet-dvb-eit.c | 14 +- epan/dissectors/packet-dvb-ipdc.c | 14 +- epan/dissectors/packet-dvb-nit.c | 14 +- epan/dissectors/packet-dvb-s2-bb.c | 14 +- epan/dissectors/packet-dvb-sdt.c | 14 +- epan/dissectors/packet-dvb-tdt.c | 14 +- epan/dissectors/packet-dvb-tot.c | 14 +- epan/dissectors/packet-dvbci.c | 14 +- epan/dissectors/packet-dvbci.h | 14 +- epan/dissectors/packet-dvmrp.c | 14 +- epan/dissectors/packet-e100.c | 14 +- epan/dissectors/packet-e164.c | 14 +- epan/dissectors/packet-e164.h | 14 +- epan/dissectors/packet-e212.c | 14 +- epan/dissectors/packet-e212.h | 14 +- epan/dissectors/packet-eap.c | 14 +- epan/dissectors/packet-eapol.c | 14 +- epan/dissectors/packet-eapol.h | 14 +- epan/dissectors/packet-echo.c | 14 +- epan/dissectors/packet-ecmp.c | 14 +- epan/dissectors/packet-ecp-oui.c | 14 +- epan/dissectors/packet-ecp.c | 14 +- epan/dissectors/packet-edonkey.c | 14 +- epan/dissectors/packet-edonkey.h | 14 +- epan/dissectors/packet-egd.c | 14 +- epan/dissectors/packet-ehdlc.c | 14 +- epan/dissectors/packet-ehs.c | 14 +- epan/dissectors/packet-eigrp.c | 14 +- epan/dissectors/packet-eigrp.h | 14 +- epan/dissectors/packet-eiss.c | 14 +- epan/dissectors/packet-elasticsearch.c | 14 +- epan/dissectors/packet-elcom.c | 14 +- epan/dissectors/packet-elmi.c | 14 +- epan/dissectors/packet-enc.c | 62 +- epan/dissectors/packet-enip.c | 91 +- epan/dissectors/packet-enip.h | 15 +- epan/dissectors/packet-enrp.c | 14 +- epan/dissectors/packet-enttec.c | 14 +- epan/dissectors/packet-epl-profile-parser.c | 32 +- epan/dissectors/packet-epl.c | 75 +- epan/dissectors/packet-epl.h | 14 +- epan/dissectors/packet-epl_v1.c | 14 +- epan/dissectors/packet-epmd.c | 14 +- epan/dissectors/packet-epmd.h | 14 +- epan/dissectors/packet-epon.c | 22 +- epan/dissectors/packet-erf.c | 314 +- epan/dissectors/packet-erf.h | 14 +- epan/dissectors/packet-erldp.c | 14 +- epan/dissectors/packet-esio.c | 14 +- epan/dissectors/packet-esis.c | 14 +- epan/dissectors/packet-ess.c | 28 +- epan/dissectors/packet-ess.h | 16 +- epan/dissectors/packet-etag.c | 14 +- epan/dissectors/packet-etch.c | 14 +- epan/dissectors/packet-eth.c | 49 +- epan/dissectors/packet-eth.h | 14 +- epan/dissectors/packet-etherip.c | 20 +- epan/dissectors/packet-ethertype.c | 14 +- epan/dissectors/packet-etsi_card_app_toolkit.c | 14 +- epan/dissectors/packet-etv.c | 14 +- epan/dissectors/packet-evrc.c | 14 +- epan/dissectors/packet-exec.c | 14 +- epan/dissectors/packet-exported_pdu.c | 14 +- epan/dissectors/packet-extreme.c | 14 +- epan/dissectors/packet-f5ethtrailer.c | 2713 +++ epan/dissectors/packet-f5ethtrailer.h | 215 + epan/dissectors/packet-fbzero.c | 14 +- epan/dissectors/packet-fc.c | 14 +- epan/dissectors/packet-fc.h | 14 +- epan/dissectors/packet-fc00.c | 14 +- epan/dissectors/packet-fcbls.h | 14 +- epan/dissectors/packet-fcct.c | 14 +- epan/dissectors/packet-fcct.h | 14 +- epan/dissectors/packet-fcdns.c | 14 +- epan/dissectors/packet-fcels.c | 14 +- epan/dissectors/packet-fcels.h | 14 +- epan/dissectors/packet-fcfcs.c | 14 +- epan/dissectors/packet-fcfcs.h | 14 +- epan/dissectors/packet-fcfzs.c | 14 +- epan/dissectors/packet-fcfzs.h | 14 +- epan/dissectors/packet-fcgi.c | 14 +- epan/dissectors/packet-fcip.c | 14 +- epan/dissectors/packet-fclctl.c | 14 +- epan/dissectors/packet-fclctl.h | 14 +- epan/dissectors/packet-fcoe.c | 14 +- epan/dissectors/packet-fcoib.c | 14 +- epan/dissectors/packet-fcp.c | 16 +- epan/dissectors/packet-fcp.h | 14 +- epan/dissectors/packet-fcsb3.c | 14 +- epan/dissectors/packet-fcsb3.h | 14 +- epan/dissectors/packet-fcsp.c | 14 +- epan/dissectors/packet-fcswils.c | 14 +- epan/dissectors/packet-fcswils.h | 14 +- epan/dissectors/packet-fddi.c | 14 +- epan/dissectors/packet-fefd.c | 14 +- epan/dissectors/packet-ff.c | 14 +- epan/dissectors/packet-ff.h | 14 +- epan/dissectors/packet-finger.c | 14 +- epan/dissectors/packet-fip.c | 14 +- epan/dissectors/packet-fix.c | 14 +- epan/dissectors/packet-flexnet.c | 14 +- epan/dissectors/packet-flexray.c | 14 +- epan/dissectors/packet-flip.c | 16 +- epan/dissectors/packet-fmp.c | 14 +- epan/dissectors/packet-fmp.h | 14 +- epan/dissectors/packet-fmp_notify.c | 14 +- epan/dissectors/packet-fmtp.c | 14 +- epan/dissectors/packet-force10-oui.c | 14 +- epan/dissectors/packet-forces.c | 14 +- epan/dissectors/packet-foundry.c | 14 +- epan/dissectors/packet-fp_hint.c | 14 +- epan/dissectors/packet-fp_mux.c | 16 +- epan/dissectors/packet-fpp.c | 26 +- epan/dissectors/packet-fr.c | 14 +- epan/dissectors/packet-fractalgeneratorprotocol.c | 14 +- epan/dissectors/packet-frame.c | 130 +- epan/dissectors/packet-frame.h | 14 +- epan/dissectors/packet-ftam.c | 24 +- epan/dissectors/packet-ftam.h | 16 +- epan/dissectors/packet-ftp.c | 39 +- epan/dissectors/packet-fw1.c | 14 +- epan/dissectors/packet-g723.c | 14 +- epan/dissectors/packet-gadu-gadu.c | 14 +- epan/dissectors/packet-gdb.c | 14 +- epan/dissectors/packet-gdsdb.c | 14 +- epan/dissectors/packet-gearman.c | 14 +- epan/dissectors/packet-ged125.c | 14 +- epan/dissectors/packet-geneve.c | 14 +- epan/dissectors/packet-gfp.c | 14 +- epan/dissectors/packet-gias.c | 14 +- epan/dissectors/packet-gift.c | 14 +- epan/dissectors/packet-giop.c | 16 +- epan/dissectors/packet-giop.h | 14 +- epan/dissectors/packet-git.c | 14 +- epan/dissectors/packet-glbp.c | 14 +- epan/dissectors/packet-gluster.h | 17 +- epan/dissectors/packet-gluster_cli.c | 14 +- epan/dissectors/packet-gluster_pmap.c | 14 +- epan/dissectors/packet-glusterd.c | 14 +- epan/dissectors/packet-glusterfs.c | 14 +- epan/dissectors/packet-glusterfs_hndsk.c | 46 +- epan/dissectors/packet-gmhdr.c | 14 +- epan/dissectors/packet-gmr1_bcch.c | 14 +- epan/dissectors/packet-gmr1_common.c | 14 +- epan/dissectors/packet-gmr1_common.h | 14 +- epan/dissectors/packet-gmr1_dtap.c | 14 +- epan/dissectors/packet-gmr1_rach.c | 14 +- epan/dissectors/packet-gmr1_rr.c | 14 +- epan/dissectors/packet-gmr1_rr.h | 14 +- epan/dissectors/packet-gmrp.c | 14 +- epan/dissectors/packet-gnutella.c | 14 +- epan/dissectors/packet-gnutella.h | 14 +- epan/dissectors/packet-goose.c | 24 +- epan/dissectors/packet-gopher.c | 14 +- epan/dissectors/packet-gpef.c | 14 +- epan/dissectors/packet-gprs-llc.c | 14 +- epan/dissectors/packet-gprscdr.c | 24 +- epan/dissectors/packet-gprscdr.h | 16 +- epan/dissectors/packet-gquic.c | 226 +- epan/dissectors/packet-gre.c | 19 +- epan/dissectors/packet-gre.h | 14 +- epan/dissectors/packet-grpc.c | 14 +- epan/dissectors/packet-gsm_a_bssmap.c | 14 +- epan/dissectors/packet-gsm_a_common.c | 61 +- epan/dissectors/packet-gsm_a_common.h | 96 +- epan/dissectors/packet-gsm_a_dtap.c | 14 +- epan/dissectors/packet-gsm_a_gm.c | 108 +- epan/dissectors/packet-gsm_a_rp.c | 14 +- epan/dissectors/packet-gsm_a_rr.c | 85 +- epan/dissectors/packet-gsm_a_rr.h | 14 +- epan/dissectors/packet-gsm_abis_om2000.c | 14 +- epan/dissectors/packet-gsm_abis_oml.c | 14 +- epan/dissectors/packet-gsm_abis_pgsl.c | 14 +- epan/dissectors/packet-gsm_abis_tfp.c | 14 +- epan/dissectors/packet-gsm_bsslap.c | 14 +- epan/dissectors/packet-gsm_bssmap_le.c | 14 +- epan/dissectors/packet-gsm_cbch.c | 14 +- epan/dissectors/packet-gsm_ipa.c | 14 +- epan/dissectors/packet-gsm_map.c | 72 +- epan/dissectors/packet-gsm_map.h | 16 +- epan/dissectors/packet-gsm_osmux.c | 16 +- epan/dissectors/packet-gsm_rlcmac.c | 14 +- epan/dissectors/packet-gsm_rlcmac.h | 14 +- epan/dissectors/packet-gsm_sim.c | 14 +- epan/dissectors/packet-gsm_sms.c | 14 +- epan/dissectors/packet-gsm_sms.h | 14 +- epan/dissectors/packet-gsm_sms_ud.c | 14 +- epan/dissectors/packet-gsm_um.c | 14 +- epan/dissectors/packet-gsmtap.c | 14 +- epan/dissectors/packet-gsmtap.h | 14 +- epan/dissectors/packet-gsmtap_log.c | 14 +- epan/dissectors/packet-gssapi.c | 14 +- epan/dissectors/packet-gssapi.h | 14 +- epan/dissectors/packet-gtp.c | 14 +- epan/dissectors/packet-gtp.h | 14 +- epan/dissectors/packet-gtpv2.c | 60 +- epan/dissectors/packet-gtpv2.h | 14 +- epan/dissectors/packet-gvcp.c | 14 +- epan/dissectors/packet-gvrp.c | 14 +- epan/dissectors/packet-gvsp.c | 14 +- epan/dissectors/packet-h1.c | 14 +- epan/dissectors/packet-h221_nonstd.c | 14 +- epan/dissectors/packet-h223.c | 24 +- epan/dissectors/packet-h223.h | 14 +- epan/dissectors/packet-h225.c | 82 +- epan/dissectors/packet-h225.h | 16 +- epan/dissectors/packet-h235.c | 24 +- epan/dissectors/packet-h235.h | 16 +- epan/dissectors/packet-h245.c | 26 +- epan/dissectors/packet-h245.h | 16 +- epan/dissectors/packet-h248.c | 23 +- epan/dissectors/packet-h248.h | 14 +- epan/dissectors/packet-h248_10.c | 14 +- epan/dissectors/packet-h248_2.c | 14 +- epan/dissectors/packet-h248_3gpp.c | 14 +- epan/dissectors/packet-h248_7.c | 14 +- epan/dissectors/packet-h248_annex_c.c | 14 +- epan/dissectors/packet-h248_annex_e.c | 14 +- epan/dissectors/packet-h248_q1950.c | 14 +- epan/dissectors/packet-h261.c | 14 +- epan/dissectors/packet-h263.c | 14 +- epan/dissectors/packet-h263.h | 14 +- epan/dissectors/packet-h263p.c | 14 +- epan/dissectors/packet-h264.c | 14 +- epan/dissectors/packet-h264.h | 14 +- epan/dissectors/packet-h282.c | 24 +- epan/dissectors/packet-h283.c | 24 +- epan/dissectors/packet-h323.c | 24 +- epan/dissectors/packet-h323.h | 14 +- epan/dissectors/packet-h450-ros.c | 24 +- epan/dissectors/packet-h450-ros.h | 16 +- epan/dissectors/packet-h450.c | 32 +- epan/dissectors/packet-h460.c | 24 +- epan/dissectors/packet-h501.c | 24 +- epan/dissectors/packet-hartip.c | 14 +- epan/dissectors/packet-hazelcast.c | 14 +- epan/dissectors/packet-hci_h1.c | 14 +- epan/dissectors/packet-hci_h4.c | 14 +- epan/dissectors/packet-hci_mon.c | 16 +- epan/dissectors/packet-hci_usb.c | 16 +- epan/dissectors/packet-hclnfsd.c | 14 +- epan/dissectors/packet-hcrt.c | 14 +- epan/dissectors/packet-hdcp.c | 14 +- epan/dissectors/packet-hdcp2.c | 14 +- epan/dissectors/packet-hdfs.c | 14 +- epan/dissectors/packet-hdfsdata.c | 14 +- epan/dissectors/packet-hdmi.c | 14 +- epan/dissectors/packet-hip.c | 14 +- epan/dissectors/packet-hiqnet.c | 14 +- epan/dissectors/packet-hislip.c | 14 +- epan/dissectors/packet-hl7.c | 14 +- epan/dissectors/packet-hnbap.c | 28 +- epan/dissectors/packet-homeplug-av.c | 14 +- epan/dissectors/packet-homeplug.c | 14 +- epan/dissectors/packet-homepna.c | 14 +- epan/dissectors/packet-hp-erm.c | 14 +- epan/dissectors/packet-hpext.c | 14 +- epan/dissectors/packet-hpext.h | 14 +- epan/dissectors/packet-hpfeeds.c | 14 +- epan/dissectors/packet-hpsw.c | 14 +- epan/dissectors/packet-hpteam.c | 15 +- epan/dissectors/packet-hsms.c | 14 +- epan/dissectors/packet-hsr-prp-supervision.c | 14 +- epan/dissectors/packet-hsr.c | 14 +- epan/dissectors/packet-hsrp.c | 16 +- epan/dissectors/packet-http-urlencoded.c | 14 +- epan/dissectors/packet-http.c | 189 +- epan/dissectors/packet-http.h | 16 +- epan/dissectors/packet-http2.c | 616 +- epan/dissectors/packet-http2.h | 14 +- epan/dissectors/packet-hyperscsi.c | 14 +- epan/dissectors/packet-i2c.c | 16 +- epan/dissectors/packet-iana-oui.c | 14 +- epan/dissectors/packet-iana-oui.h | 14 +- epan/dissectors/packet-iapp.c | 14 +- epan/dissectors/packet-iax2.c | 16 +- epan/dissectors/packet-iax2.h | 14 +- epan/dissectors/packet-icap.c | 14 +- epan/dissectors/packet-icep.c | 14 +- epan/dissectors/packet-icmp.c | 42 +- epan/dissectors/packet-icmp.h | 14 +- epan/dissectors/packet-icmpv6.c | 20 +- epan/dissectors/packet-icp.c | 14 +- epan/dissectors/packet-icq.c | 14 +- epan/dissectors/packet-idmp.c | 24 +- epan/dissectors/packet-idmp.h | 14 +- epan/dissectors/packet-idp.c | 14 +- epan/dissectors/packet-idp.h | 14 +- epan/dissectors/packet-idrp.c | 14 +- epan/dissectors/packet-iec104.c | 76 +- epan/dissectors/packet-ieee1722.c | 14 +- epan/dissectors/packet-ieee17221.c | 14 +- epan/dissectors/packet-ieee1905.c | 372 +- epan/dissectors/packet-ieee80211-netmon.c | 14 +- epan/dissectors/packet-ieee80211-prism.c | 14 +- epan/dissectors/packet-ieee80211-radio.c | 24 +- epan/dissectors/packet-ieee80211-radio.h | 14 +- epan/dissectors/packet-ieee80211-radiotap-defs.h | 110 +- epan/dissectors/packet-ieee80211-radiotap-iter.c | 22 +- epan/dissectors/packet-ieee80211-radiotap-iter.h | 19 +- epan/dissectors/packet-ieee80211-radiotap.c | 1952 ++- epan/dissectors/packet-ieee80211-wlancap.c | 14 +- epan/dissectors/packet-ieee80211.c | 7171 ++++++-- epan/dissectors/packet-ieee80211.h | 30 +- epan/dissectors/packet-ieee802154.c | 604 +- epan/dissectors/packet-ieee802154.h | 109 +- epan/dissectors/packet-ieee8021ah.c | 14 +- epan/dissectors/packet-ieee8023.c | 14 +- epan/dissectors/packet-ieee8023.h | 14 +- epan/dissectors/packet-ieee802a.c | 14 +- epan/dissectors/packet-ieee802a.h | 14 +- epan/dissectors/packet-ifcp.c | 14 +- epan/dissectors/packet-igap.c | 14 +- epan/dissectors/packet-igmp.c | 14 +- epan/dissectors/packet-igmp.h | 14 +- epan/dissectors/packet-igrp.c | 14 +- epan/dissectors/packet-ilp.c | 26 +- epan/dissectors/packet-imap.c | 14 +- epan/dissectors/packet-imf.c | 14 +- epan/dissectors/packet-imf.h | 14 +- epan/dissectors/packet-inap.c | 30 +- epan/dissectors/packet-inap.h | 16 +- epan/dissectors/packet-indigocare-icall.c | 14 +- epan/dissectors/packet-indigocare-netrix.c | 14 +- epan/dissectors/packet-infiniband.c | 135 +- epan/dissectors/packet-infiniband.h | 14 +- epan/dissectors/packet-infiniband_sdp.c | 14 +- epan/dissectors/packet-interlink.c | 14 +- epan/dissectors/packet-ip.c | 309 +- epan/dissectors/packet-ip.h | 14 +- epan/dissectors/packet-ipars.c | 14 +- epan/dissectors/packet-ipdc.c | 14 +- epan/dissectors/packet-ipdr.c | 14 +- epan/dissectors/packet-iperf.c | 14 +- epan/dissectors/packet-ipfc.c | 14 +- epan/dissectors/packet-ipmi-app.c | 14 +- epan/dissectors/packet-ipmi-bridge.c | 14 +- epan/dissectors/packet-ipmi-chassis.c | 14 +- epan/dissectors/packet-ipmi-picmg.c | 20 +- epan/dissectors/packet-ipmi-pps.c | 14 +- epan/dissectors/packet-ipmi-se.c | 14 +- epan/dissectors/packet-ipmi-session.c | 14 +- epan/dissectors/packet-ipmi-storage.c | 14 +- epan/dissectors/packet-ipmi-trace.c | 14 +- epan/dissectors/packet-ipmi-transport.c | 14 +- epan/dissectors/packet-ipmi-update.c | 14 +- epan/dissectors/packet-ipmi-vita.c | 14 +- epan/dissectors/packet-ipmi.c | 47 +- epan/dissectors/packet-ipmi.h | 14 +- epan/dissectors/packet-ipnet.c | 14 +- epan/dissectors/packet-ipoib.c | 18 +- epan/dissectors/packet-ipos.c | 14 +- epan/dissectors/packet-ipp.c | 14 +- epan/dissectors/packet-ipsec-tcp.c | 14 +- epan/dissectors/packet-ipsec-udp.c | 20 +- epan/dissectors/packet-ipsec.c | 31 +- epan/dissectors/packet-ipsec.h | 14 +- epan/dissectors/packet-ipsi-ctl.c | 14 +- epan/dissectors/packet-ipv6.c | 358 +- epan/dissectors/packet-ipvs-syncd.c | 14 +- epan/dissectors/packet-ipx.c | 14 +- epan/dissectors/packet-ipx.h | 14 +- epan/dissectors/packet-ipxwan.c | 14 +- epan/dissectors/packet-irc.c | 14 +- epan/dissectors/packet-isakmp.c | 14 +- epan/dissectors/packet-isakmp.h | 14 +- epan/dissectors/packet-iscsi.c | 14 +- epan/dissectors/packet-isdn-sup.c | 36 +- epan/dissectors/packet-isdn.c | 14 +- epan/dissectors/packet-iser.c | 14 +- epan/dissectors/packet-isi.c | 14 +- epan/dissectors/packet-isis-clv.c | 14 +- epan/dissectors/packet-isis-clv.h | 14 +- epan/dissectors/packet-isis-hello.c | 14 +- epan/dissectors/packet-isis-lsp.c | 14 +- epan/dissectors/packet-isis-snp.c | 14 +- epan/dissectors/packet-isis.c | 14 +- epan/dissectors/packet-isis.h | 14 +- epan/dissectors/packet-isl.c | 14 +- epan/dissectors/packet-isl.h | 14 +- epan/dissectors/packet-ismacryp.c | 14 +- epan/dissectors/packet-ismp.c | 14 +- epan/dissectors/packet-isns.c | 14 +- epan/dissectors/packet-iso14443.c | 23 +- epan/dissectors/packet-iso15765.c | 14 +- epan/dissectors/packet-iso7816.c | 14 +- epan/dissectors/packet-iso8583.c | 14 +- epan/dissectors/packet-isobus-vt.c | 14 +- epan/dissectors/packet-isobus.c | 14 +- epan/dissectors/packet-isup.c | 22 +- epan/dissectors/packet-isup.h | 14 +- epan/dissectors/packet-itdm.c | 14 +- epan/dissectors/packet-iua.c | 14 +- epan/dissectors/packet-iuup.c | 14 +- epan/dissectors/packet-iwarp-ddp-rdmap.c | 15 +- epan/dissectors/packet-iwarp-ddp-rdmap.h | 15 +- epan/dissectors/packet-iwarp-mpa.c | 15 +- epan/dissectors/packet-ixiatrailer.c | 14 +- epan/dissectors/packet-ixveriwave.c | 14 +- epan/dissectors/packet-j1939.c | 14 +- epan/dissectors/packet-jmirror.c | 14 +- epan/dissectors/packet-jpeg.c | 14 +- epan/dissectors/packet-json.c | 194 +- epan/dissectors/packet-juniper.c | 14 +- epan/dissectors/packet-juniper.h | 14 +- epan/dissectors/packet-jxta.c | 14 +- epan/dissectors/packet-jxta.h | 14 +- epan/dissectors/packet-k12.c | 14 +- epan/dissectors/packet-kadm5.c | 14 +- epan/dissectors/packet-kafka.c | 14 +- epan/dissectors/packet-kdp.c | 14 +- epan/dissectors/packet-kdsp.c | 14 +- epan/dissectors/packet-kerberos.c | 44 +- epan/dissectors/packet-kerberos.h | 16 +- epan/dissectors/packet-kerberos4.c | 14 +- epan/dissectors/packet-kingfisher.c | 21 +- epan/dissectors/packet-kink.c | 14 +- epan/dissectors/packet-kismet.c | 14 +- epan/dissectors/packet-klm.c | 14 +- epan/dissectors/packet-klm.h | 14 +- epan/dissectors/packet-knet.c | 14 +- epan/dissectors/packet-knxnetip.c | 14 +- epan/dissectors/packet-kpasswd.c | 14 +- epan/dissectors/packet-kt.c | 14 +- epan/dissectors/packet-l1-events.c | 14 +- epan/dissectors/packet-l2tp.c | 14 +- epan/dissectors/packet-l2tp.h | 14 +- epan/dissectors/packet-lacp.c | 446 +- epan/dissectors/packet-lanforge.c | 14 +- epan/dissectors/packet-lapb.c | 14 +- epan/dissectors/packet-lapbether.c | 14 +- epan/dissectors/packet-lapd.c | 47 +- epan/dissectors/packet-lapdm.c | 14 +- epan/dissectors/packet-lapdm.h | 14 +- epan/dissectors/packet-laplink.c | 14 +- epan/dissectors/packet-lapsat.c | 14 +- epan/dissectors/packet-lat.c | 14 +- epan/dissectors/packet-lbm.c | 14 +- epan/dissectors/packet-lbm.h | 14 +- epan/dissectors/packet-lbmc.c | 20 +- epan/dissectors/packet-lbmpdm.c | 14 +- epan/dissectors/packet-lbmpdmtcp.c | 14 +- epan/dissectors/packet-lbmr.c | 14 +- epan/dissectors/packet-lbtrm.c | 14 +- epan/dissectors/packet-lbtrm.h | 14 +- epan/dissectors/packet-lbtru.c | 14 +- epan/dissectors/packet-lbtru.h | 14 +- epan/dissectors/packet-lbttcp.c | 14 +- epan/dissectors/packet-lbttcp.h | 14 +- epan/dissectors/packet-lcsap.c | 28 +- epan/dissectors/packet-lcsap.h | 16 +- epan/dissectors/packet-ldap.c | 8 +- epan/dissectors/packet-ldap.h | 14 +- epan/dissectors/packet-ldp.c | 14 +- epan/dissectors/packet-ldp.h | 14 +- epan/dissectors/packet-ldss.c | 14 +- epan/dissectors/packet-lg8979.c | 14 +- epan/dissectors/packet-lge_monitor.c | 14 +- epan/dissectors/packet-link16.c | 14 +- epan/dissectors/packet-link16.h | 14 +- epan/dissectors/packet-linx.c | 14 +- epan/dissectors/packet-lisp-data.c | 15 +- epan/dissectors/packet-lisp-tcp.c | 15 +- epan/dissectors/packet-lisp.c | 15 +- epan/dissectors/packet-llc.c | 14 +- epan/dissectors/packet-llc.h | 14 +- epan/dissectors/packet-lldp.c | 92 +- epan/dissectors/packet-llrp.c | 14 +- epan/dissectors/packet-llt.c | 14 +- epan/dissectors/packet-lltd.c | 18 +- epan/dissectors/packet-lmi.c | 14 +- epan/dissectors/packet-lmp.c | 14 +- epan/dissectors/packet-lnet.c | 1086 ++ epan/dissectors/packet-lnet.h | 58 + epan/dissectors/packet-logcat-text.c | 22 +- epan/dissectors/packet-logcat.c | 14 +- epan/dissectors/packet-logotypecertextn.c | 26 +- epan/dissectors/packet-logotypecertextn.h | 14 +- epan/dissectors/packet-lon.c | 14 +- epan/dissectors/packet-loop.c | 14 +- epan/dissectors/packet-loratap.c | 37 +- epan/dissectors/packet-lorawan.c | 22 +- epan/dissectors/packet-lpd.c | 14 +- epan/dissectors/packet-lpp.c | 236 +- epan/dissectors/packet-lpp.h | 29 +- epan/dissectors/packet-lppa.c | 28 +- epan/dissectors/packet-lppe.c | 3704 ++-- epan/dissectors/packet-lsc.c | 14 +- epan/dissectors/packet-lsd.c | 14 +- epan/dissectors/packet-lte-rrc.c | 8669 +++++++--- epan/dissectors/packet-lte-rrc.h | 23 +- epan/dissectors/packet-ltp.c | 99 +- epan/dissectors/packet-lustre.c | 8082 +++++++++ epan/dissectors/packet-lwapp.c | 38 +- epan/dissectors/packet-lwm.c | 14 +- epan/dissectors/packet-lwm2mtlv.c | 14 +- epan/dissectors/packet-lwres.c | 14 +- epan/dissectors/packet-m2ap.c | 28 +- epan/dissectors/packet-m2pa.c | 14 +- epan/dissectors/packet-m2tp.c | 14 +- epan/dissectors/packet-m2ua.c | 14 +- epan/dissectors/packet-m3ap.c | 28 +- epan/dissectors/packet-m3ua.c | 14 +- epan/dissectors/packet-maap.c | 14 +- epan/dissectors/packet-mac-lte-framed.c | 14 +- epan/dissectors/packet-mac-lte.c | 56 +- epan/dissectors/packet-mac-lte.h | 41 +- epan/dissectors/packet-maccontrol.c | 14 +- epan/dissectors/packet-macsec.c | 14 +- epan/dissectors/packet-mactelnet.c | 14 +- epan/dissectors/packet-manolito.c | 14 +- epan/dissectors/packet-marker.c | 194 +- epan/dissectors/packet-mausb.c | 14 +- epan/dissectors/packet-mausb.h | 14 +- epan/dissectors/packet-mbim.c | 14 +- epan/dissectors/packet-mbim.h | 14 +- epan/dissectors/packet-mbtcp.c | 14 +- epan/dissectors/packet-mbtcp.h | 14 +- epan/dissectors/packet-mcpe.c | 14 +- epan/dissectors/packet-mdshdr.c | 14 +- epan/dissectors/packet-media.c | 14 +- epan/dissectors/packet-megaco.c | 51 +- epan/dissectors/packet-memcache.c | 14 +- epan/dissectors/packet-mesh.c | 14 +- epan/dissectors/packet-messageanalyzer.c | 15 +- epan/dissectors/packet-meta.c | 14 +- epan/dissectors/packet-metamako.c | 14 +- epan/dissectors/packet-mgcp.c | 14 +- epan/dissectors/packet-mgcp.h | 14 +- epan/dissectors/packet-mih.c | 14 +- epan/dissectors/packet-mikey.c | 14 +- epan/dissectors/packet-mime-encap.c | 14 +- epan/dissectors/packet-mint.c | 14 +- epan/dissectors/packet-miop.c | 14 +- epan/dissectors/packet-mip.c | 33 +- epan/dissectors/packet-mip6.c | 14 +- epan/dissectors/packet-mka.c | 14 +- epan/dissectors/packet-mle.c | 84 +- epan/dissectors/packet-mle.h | 14 +- epan/dissectors/packet-mms.c | 24 +- epan/dissectors/packet-mms.h | 16 +- epan/dissectors/packet-mmse.c | 1019 +- epan/dissectors/packet-mndp.c | 14 +- epan/dissectors/packet-mojito.c | 14 +- epan/dissectors/packet-moldudp.c | 16 +- epan/dissectors/packet-moldudp64.c | 16 +- epan/dissectors/packet-mongo.c | 14 +- epan/dissectors/packet-mount.c | 14 +- epan/dissectors/packet-mount.h | 14 +- epan/dissectors/packet-mp2t.c | 14 +- epan/dissectors/packet-mp4ves.c | 14 +- epan/dissectors/packet-mp4ves.h | 14 +- epan/dissectors/packet-mpeg-audio.c | 24 +- epan/dissectors/packet-mpeg-ca.c | 14 +- epan/dissectors/packet-mpeg-descriptor.c | 14 +- epan/dissectors/packet-mpeg-descriptor.h | 14 +- epan/dissectors/packet-mpeg-dsmcc.c | 14 +- epan/dissectors/packet-mpeg-pat.c | 14 +- epan/dissectors/packet-mpeg-pes.c | 24 +- epan/dissectors/packet-mpeg-pmt.c | 14 +- epan/dissectors/packet-mpeg-pmt.h | 14 +- epan/dissectors/packet-mpeg-sect.c | 14 +- epan/dissectors/packet-mpeg-sect.h | 14 +- epan/dissectors/packet-mpeg1.c | 14 +- epan/dissectors/packet-mpls-echo.c | 14 +- epan/dissectors/packet-mpls-mac.c | 14 +- epan/dissectors/packet-mpls-pm.c | 14 +- epan/dissectors/packet-mpls-psc.c | 14 +- epan/dissectors/packet-mpls-y1711.c | 14 +- epan/dissectors/packet-mpls.c | 14 +- epan/dissectors/packet-mpls.h | 14 +- epan/dissectors/packet-mplstp-oam.c | 14 +- epan/dissectors/packet-mq-base.c | 205 +- epan/dissectors/packet-mq-pcf.c | 356 +- epan/dissectors/packet-mq.c | 2398 ++- epan/dissectors/packet-mq.h | 493 +- epan/dissectors/packet-mqtt-sn.c | 14 +- epan/dissectors/packet-mqtt.c | 46 +- epan/dissectors/packet-mrcpv2.c | 14 +- epan/dissectors/packet-mrdisc.c | 14 +- epan/dissectors/packet-mrp-mmrp.c | 14 +- epan/dissectors/packet-mrp-msrp.c | 14 +- epan/dissectors/packet-mrp-mvrp.c | 14 +- epan/dissectors/packet-ms-mms.c | 20 +- epan/dissectors/packet-msdp.c | 14 +- epan/dissectors/packet-msn-messenger.c | 14 +- epan/dissectors/packet-msnip.c | 14 +- epan/dissectors/packet-msnlb.c | 14 +- epan/dissectors/packet-msproxy.c | 14 +- epan/dissectors/packet-msrp.c | 14 +- epan/dissectors/packet-msrp.h | 14 +- epan/dissectors/packet-mstp.c | 14 +- epan/dissectors/packet-mstp.h | 14 +- epan/dissectors/packet-mswsp.c | 14 +- epan/dissectors/packet-mtp2.c | 14 +- epan/dissectors/packet-mtp3.c | 62 +- epan/dissectors/packet-mtp3.h | 14 +- epan/dissectors/packet-mtp3mg.c | 14 +- epan/dissectors/packet-mudurl.c | 22 +- epan/dissectors/packet-multipart.c | 38 +- epan/dissectors/packet-mux27010.c | 14 +- epan/dissectors/packet-mysql.c | 14 +- epan/dissectors/packet-nas_5gs.c | 4293 +++++ epan/dissectors/packet-nas_eps.c | 1206 +- epan/dissectors/packet-nasdaq-itch.c | 14 +- epan/dissectors/packet-nasdaq-soup.c | 14 +- epan/dissectors/packet-nat-pmp.c | 14 +- epan/dissectors/packet-nb_rtpmux.c | 15 +- epan/dissectors/packet-nbap.c | 633 +- epan/dissectors/packet-nbap.h | 14 +- epan/dissectors/packet-nbd.c | 14 +- epan/dissectors/packet-nbifom.c | 14 +- epan/dissectors/packet-nbipx.c | 14 +- epan/dissectors/packet-nbt.c | 14 +- epan/dissectors/packet-ncp-int.h | 14 +- epan/dissectors/packet-ncp-nmas.c | 14 +- epan/dissectors/packet-ncp-nmas.h | 14 +- epan/dissectors/packet-ncp-sss.c | 14 +- epan/dissectors/packet-ncp-sss.h | 14 +- epan/dissectors/packet-ncp.c | 14 +- epan/dissectors/packet-ncp2222.inc | 14 +- epan/dissectors/packet-ncs.c | 14 +- epan/dissectors/packet-ndmp.c | 14 +- epan/dissectors/packet-ndmp.h | 14 +- epan/dissectors/packet-ndp.c | 14 +- epan/dissectors/packet-ndps.c | 14 +- epan/dissectors/packet-ndps.h | 14 +- epan/dissectors/packet-negoex.c | 14 +- epan/dissectors/packet-netanalyzer.c | 14 +- epan/dissectors/packet-netbios.c | 14 +- epan/dissectors/packet-netbios.h | 14 +- epan/dissectors/packet-netdump.c | 15 +- epan/dissectors/packet-netflow.c | 660 +- epan/dissectors/packet-netgear-ensemble.c | 14 +- epan/dissectors/packet-netlink-generic.c | 14 +- epan/dissectors/packet-netlink-netfilter.c | 16 +- epan/dissectors/packet-netlink-nl80211.c | 14 +- epan/dissectors/packet-netlink-route.c | 14 +- epan/dissectors/packet-netlink-sock_diag.c | 14 +- epan/dissectors/packet-netlink.c | 14 +- epan/dissectors/packet-netlink.h | 14 +- epan/dissectors/packet-netmon.c | 15 +- epan/dissectors/packet-netmon.h | 14 +- epan/dissectors/packet-netperfmeter.c | 14 +- epan/dissectors/packet-netrom.c | 14 +- epan/dissectors/packet-netsync.c | 34 +- epan/dissectors/packet-nettl.c | 16 +- epan/dissectors/packet-newmail.c | 14 +- epan/dissectors/packet-nfapi.c | 212 +- epan/dissectors/packet-nflog.c | 14 +- epan/dissectors/packet-nfs.c | 41 +- epan/dissectors/packet-nfs.h | 14 +- epan/dissectors/packet-nfsacl.c | 14 +- epan/dissectors/packet-nfsauth.c | 14 +- epan/dissectors/packet-nhrp.c | 14 +- epan/dissectors/packet-nisplus.c | 14 +- epan/dissectors/packet-nisplus.h | 14 +- epan/dissectors/packet-nlm.c | 14 +- epan/dissectors/packet-nlm.h | 14 +- epan/dissectors/packet-nlsp.c | 20 +- epan/dissectors/packet-nntp.c | 14 +- epan/dissectors/packet-noe.c | 14 +- epan/dissectors/packet-nordic_ble.c | 14 +- epan/dissectors/packet-novell_pkis.c | 26 +- epan/dissectors/packet-nr-rrc.c | 16694 +++++++++++++++++++ epan/dissectors/packet-nr-rrc.h | 37 + epan/dissectors/packet-ns-ha.c | 14 +- epan/dissectors/packet-ns-mep.c | 14 +- epan/dissectors/packet-ns-rpc.c | 28 +- epan/dissectors/packet-ns_cert_exts.c | 26 +- epan/dissectors/packet-nsh.c | 14 +- epan/dissectors/packet-nsh.h | 14 +- epan/dissectors/packet-nsip.c | 14 +- epan/dissectors/packet-nsrp.c | 14 +- epan/dissectors/packet-nstrace.c | 14 +- epan/dissectors/packet-nt-oui.c | 14 +- epan/dissectors/packet-nt-tpcp.c | 14 +- epan/dissectors/packet-ntlmssp.c | 14 +- epan/dissectors/packet-ntlmssp.h | 14 +- epan/dissectors/packet-ntp.c | 145 +- epan/dissectors/packet-ntp.h | 14 +- epan/dissectors/packet-null.c | 14 +- epan/dissectors/packet-nvme-rdma.c | 16 +- epan/dissectors/packet-nvme.c | 14 +- epan/dissectors/packet-nvme.h | 14 +- epan/dissectors/packet-nwmtp.c | 14 +- epan/dissectors/packet-nwp.c | 14 +- epan/dissectors/packet-nxp_802154_sniffer.c | 148 + epan/dissectors/packet-oampdu.c | 14 +- epan/dissectors/packet-obd-ii.c | 14 +- epan/dissectors/packet-obex.c | 14 +- epan/dissectors/packet-ocfs2.c | 14 +- epan/dissectors/packet-ocsp.c | 26 +- epan/dissectors/packet-ocsp.h | 14 +- epan/dissectors/packet-oicq.c | 14 +- epan/dissectors/packet-oipf.c | 14 +- epan/dissectors/packet-olsr.c | 14 +- epan/dissectors/packet-omapi.c | 14 +- epan/dissectors/packet-omron-fins.c | 15 +- epan/dissectors/packet-opa-fe.c | 14 +- epan/dissectors/packet-opa-mad.c | 14 +- epan/dissectors/packet-opa-snc.c | 14 +- epan/dissectors/packet-opa.c | 14 +- epan/dissectors/packet-openflow.c | 25 +- epan/dissectors/packet-openflow_v1.c | 14 +- epan/dissectors/packet-openflow_v4.c | 14 +- epan/dissectors/packet-openflow_v5.c | 468 +- epan/dissectors/packet-openflow_v6.c | 561 +- epan/dissectors/packet-opensafety.c | 14 +- epan/dissectors/packet-opensafety.h | 14 +- epan/dissectors/packet-openthread.c | 14 +- epan/dissectors/packet-openvpn.c | 14 +- epan/dissectors/packet-openwire.c | 14 +- epan/dissectors/packet-opsi.c | 14 +- epan/dissectors/packet-optommp.c | 14 +- epan/dissectors/packet-osc.c | 14 +- epan/dissectors/packet-osi-options.c | 14 +- epan/dissectors/packet-osi-options.h | 14 +- epan/dissectors/packet-osi.c | 14 +- epan/dissectors/packet-osi.h | 14 +- epan/dissectors/packet-ositp.c | 14 +- epan/dissectors/packet-ospf.c | 21 +- epan/dissectors/packet-ossp.c | 14 +- epan/dissectors/packet-ouch.c | 16 +- epan/dissectors/packet-p1.c | 34 +- epan/dissectors/packet-p1.h | 18 +- epan/dissectors/packet-p22.c | 28 +- epan/dissectors/packet-p22.h | 16 +- epan/dissectors/packet-p7.c | 34 +- epan/dissectors/packet-p7.h | 16 +- epan/dissectors/packet-p772.c | 28 +- epan/dissectors/packet-p772.h | 14 +- epan/dissectors/packet-p_mul.c | 14 +- epan/dissectors/packet-packetbb.c | 14 +- epan/dissectors/packet-packetlogger.c | 14 +- epan/dissectors/packet-pagp.c | 14 +- epan/dissectors/packet-paltalk.c | 14 +- epan/dissectors/packet-pana.c | 14 +- epan/dissectors/packet-parlay.c | 14 +- epan/dissectors/packet-pathport.c | 14 +- epan/dissectors/packet-pcap.c | 28 +- epan/dissectors/packet-pcap_pktdata.c | 34 +- epan/dissectors/packet-pcap_pktdata.h | 14 +- epan/dissectors/packet-pcapng_block.c | 30 +- epan/dissectors/packet-pcep.c | 14 +- epan/dissectors/packet-pcli.c | 16 +- epan/dissectors/packet-pcnfsd.c | 14 +- epan/dissectors/packet-pcnfsd.h | 14 +- epan/dissectors/packet-pcp.c | 16 +- epan/dissectors/packet-pdc.c | 14 +- epan/dissectors/packet-pdcp-lte.c | 123 +- epan/dissectors/packet-pdcp-lte.h | 14 +- epan/dissectors/packet-peekremote.c | 45 +- epan/dissectors/packet-per.c | 18 +- epan/dissectors/packet-per.h | 14 +- epan/dissectors/packet-pfcp.c | 1400 +- epan/dissectors/packet-pflog.c | 21 +- epan/dissectors/packet-pgm.c | 14 +- epan/dissectors/packet-pgsql.c | 14 +- epan/dissectors/packet-pim.c | 14 +- epan/dissectors/packet-pingpongprotocol.c | 14 +- epan/dissectors/packet-pkcs1.c | 26 +- epan/dissectors/packet-pkcs1.h | 16 +- epan/dissectors/packet-pkcs12.c | 26 +- epan/dissectors/packet-pkcs12.h | 14 +- epan/dissectors/packet-pkinit.c | 26 +- epan/dissectors/packet-pkinit.h | 16 +- epan/dissectors/packet-pkix1explicit.c | 26 +- epan/dissectors/packet-pkix1explicit.h | 16 +- epan/dissectors/packet-pkix1implicit.c | 26 +- epan/dissectors/packet-pkix1implicit.h | 16 +- epan/dissectors/packet-pkixac.c | 28 +- epan/dissectors/packet-pkixac.h | 14 +- epan/dissectors/packet-pkixproxy.c | 26 +- epan/dissectors/packet-pkixproxy.h | 14 +- epan/dissectors/packet-pkixqualified.c | 26 +- epan/dissectors/packet-pkixqualified.h | 14 +- epan/dissectors/packet-pkixtsp.c | 26 +- epan/dissectors/packet-pkixtsp.h | 14 +- epan/dissectors/packet-pktap.c | 14 +- epan/dissectors/packet-pktc.c | 14 +- epan/dissectors/packet-pktc.h | 14 +- epan/dissectors/packet-pktgen.c | 14 +- epan/dissectors/packet-pmproxy.c | 14 +- epan/dissectors/packet-pnrp.c | 14 +- epan/dissectors/packet-pop.c | 14 +- epan/dissectors/packet-portmap.c | 14 +- epan/dissectors/packet-portmap.h | 14 +- epan/dissectors/packet-ppcap.c | 14 +- epan/dissectors/packet-ppi-antenna.c | 14 +- epan/dissectors/packet-ppi-geolocation-common.c | 14 +- epan/dissectors/packet-ppi-geolocation-common.h | 14 +- epan/dissectors/packet-ppi-gps.c | 14 +- epan/dissectors/packet-ppi-sensor.c | 14 +- epan/dissectors/packet-ppi-vector.c | 14 +- epan/dissectors/packet-ppi.c | 28 +- epan/dissectors/packet-ppp.c | 14 +- epan/dissectors/packet-ppp.h | 14 +- epan/dissectors/packet-pppoe.c | 14 +- epan/dissectors/packet-pptp.c | 14 +- epan/dissectors/packet-pres.c | 24 +- epan/dissectors/packet-pres.h | 14 +- epan/dissectors/packet-protobuf.c | 22 +- epan/dissectors/packet-protobuf.h | 14 +- epan/dissectors/packet-prp.c | 14 +- epan/dissectors/packet-ptp.c | 14 +- epan/dissectors/packet-ptp.h | 14 +- epan/dissectors/packet-ptpip.c | 14 +- epan/dissectors/packet-ptpip.h | 14 +- epan/dissectors/packet-pulse.c | 14 +- epan/dissectors/packet-pvfs2.c | 14 +- epan/dissectors/packet-pw-atm.c | 14 +- epan/dissectors/packet-pw-atm.h | 14 +- epan/dissectors/packet-pw-cesopsn.c | 14 +- epan/dissectors/packet-pw-common.c | 14 +- epan/dissectors/packet-pw-common.h | 14 +- epan/dissectors/packet-pw-eth.c | 14 +- epan/dissectors/packet-pw-fr.c | 14 +- epan/dissectors/packet-pw-hdlc.c | 14 +- epan/dissectors/packet-pw-oam.c | 14 +- epan/dissectors/packet-pw-satop.c | 14 +- epan/dissectors/packet-q2931.c | 14 +- epan/dissectors/packet-q708.c | 14 +- epan/dissectors/packet-q708.h | 14 +- epan/dissectors/packet-q931.c | 14 +- epan/dissectors/packet-q931.h | 14 +- epan/dissectors/packet-q932-ros.c | 24 +- epan/dissectors/packet-q932.c | 24 +- epan/dissectors/packet-q932.h | 16 +- epan/dissectors/packet-q933.c | 14 +- epan/dissectors/packet-qllc.c | 14 +- epan/dissectors/packet-qnet6.c | 14 +- epan/dissectors/packet-qsig.c | 32 +- epan/dissectors/packet-qsig.h | 16 +- epan/dissectors/packet-quake.c | 14 +- epan/dissectors/packet-quake2.c | 14 +- epan/dissectors/packet-quake3.c | 14 +- epan/dissectors/packet-quakeworld.c | 14 +- epan/dissectors/packet-quic.c | 1466 +- epan/dissectors/packet-radius.c | 14 +- epan/dissectors/packet-radius.h | 14 +- epan/dissectors/packet-radius_packetcable.c | 14 +- epan/dissectors/packet-raknet.c | 14 +- epan/dissectors/packet-raknet.h | 14 +- epan/dissectors/packet-ranap.c | 28 +- epan/dissectors/packet-ranap.h | 16 +- epan/dissectors/packet-raw.c | 14 +- epan/dissectors/packet-rdm.c | 15 +- epan/dissectors/packet-rdm.h | 14 +- epan/dissectors/packet-rdp.c | 14 +- epan/dissectors/packet-rdt.c | 14 +- epan/dissectors/packet-rdt.h | 14 +- epan/dissectors/packet-redback.c | 14 +- epan/dissectors/packet-redbackli.c | 14 +- epan/dissectors/packet-reload-framing.c | 14 +- epan/dissectors/packet-reload.c | 16 +- epan/dissectors/packet-reload.h | 14 +- epan/dissectors/packet-retix-bpdu.c | 14 +- epan/dissectors/packet-rfc2190.c | 14 +- epan/dissectors/packet-rfid-felica.c | 14 +- epan/dissectors/packet-rfid-mifare.c | 14 +- epan/dissectors/packet-rfid-pn532-hci.c | 14 +- epan/dissectors/packet-rfid-pn532.c | 14 +- epan/dissectors/packet-rftap.c | 14 +- epan/dissectors/packet-rgmp.c | 14 +- epan/dissectors/packet-riemann.c | 14 +- epan/dissectors/packet-rip.c | 14 +- epan/dissectors/packet-ripng.c | 14 +- epan/dissectors/packet-rlc-lte.c | 14 +- epan/dissectors/packet-rlc-lte.h | 14 +- epan/dissectors/packet-rlm.c | 14 +- epan/dissectors/packet-rlogin.c | 14 +- epan/dissectors/packet-rmcp.c | 14 +- epan/dissectors/packet-rmi.c | 14 +- epan/dissectors/packet-rmi.h | 14 +- epan/dissectors/packet-rmp.c | 14 +- epan/dissectors/packet-rmt-alc.c | 14 +- epan/dissectors/packet-rmt-common.h | 14 +- epan/dissectors/packet-rmt-fec.c | 14 +- epan/dissectors/packet-rmt-lct.c | 14 +- epan/dissectors/packet-rmt-norm.c | 14 +- epan/dissectors/packet-rnsap.c | 28 +- epan/dissectors/packet-rohc.c | 14 +- epan/dissectors/packet-rohc.h | 14 +- epan/dissectors/packet-roofnet.c | 14 +- epan/dissectors/packet-ros.c | 24 +- epan/dissectors/packet-ros.h | 16 +- epan/dissectors/packet-rpc.c | 60 +- epan/dissectors/packet-rpc.h | 14 +- epan/dissectors/packet-rpcap.c | 14 +- epan/dissectors/packet-rpcrdma.c | 25 +- epan/dissectors/packet-rpki-rtr.c | 25 +- epan/dissectors/packet-rpl.c | 14 +- epan/dissectors/packet-rquota.c | 14 +- epan/dissectors/packet-rquota.h | 14 +- epan/dissectors/packet-rrc.c | 699 +- epan/dissectors/packet-rrc.h | 50 +- epan/dissectors/packet-rrlp.c | 26 +- epan/dissectors/packet-rsh.c | 14 +- epan/dissectors/packet-rsip.c | 14 +- epan/dissectors/packet-rsl.c | 25 +- epan/dissectors/packet-rstat.c | 14 +- epan/dissectors/packet-rsvd.c | 14 +- epan/dissectors/packet-rsvp.c | 18 +- epan/dissectors/packet-rsvp.h | 14 +- epan/dissectors/packet-rsync.c | 14 +- epan/dissectors/packet-rtacser.c | 16 +- epan/dissectors/packet-rtcdc.c | 14 +- epan/dissectors/packet-rtcp.c | 375 +- epan/dissectors/packet-rtcp.h | 14 +- epan/dissectors/packet-rtitcp.c | 14 +- epan/dissectors/packet-rtls.c | 14 +- epan/dissectors/packet-rtmpt.c | 14 +- epan/dissectors/packet-rtnet.c | 26 +- epan/dissectors/packet-rtp-events.c | 14 +- epan/dissectors/packet-rtp-events.h | 14 +- epan/dissectors/packet-rtp-midi.c | 14 +- epan/dissectors/packet-rtp.c | 42 +- epan/dissectors/packet-rtp.h | 29 +- epan/dissectors/packet-rtpproxy.c | 14 +- epan/dissectors/packet-rtps.c | 40 +- epan/dissectors/packet-rtps.h | 14 +- epan/dissectors/packet-rtse.c | 24 +- epan/dissectors/packet-rtse.h | 16 +- epan/dissectors/packet-rtsp.c | 108 +- epan/dissectors/packet-rtsp.h | 14 +- epan/dissectors/packet-rua.c | 28 +- epan/dissectors/packet-rudp.c | 14 +- epan/dissectors/packet-rwall.c | 14 +- epan/dissectors/packet-rwall.h | 14 +- epan/dissectors/packet-rx.c | 14 +- epan/dissectors/packet-rx.h | 14 +- epan/dissectors/packet-s1ap.c | 1179 +- epan/dissectors/packet-s1ap.h | 16 +- epan/dissectors/packet-s5066dts.c | 14 +- epan/dissectors/packet-s5066sis.c | 14 +- epan/dissectors/packet-s5066sis.h | 14 +- epan/dissectors/packet-s7comm.c | 36 +- epan/dissectors/packet-s7comm.h | 14 +- epan/dissectors/packet-s7comm_szl_ids.c | 14 +- epan/dissectors/packet-s7comm_szl_ids.h | 14 +- epan/dissectors/packet-sabp.c | 28 +- epan/dissectors/packet-sadmind.c | 14 +- epan/dissectors/packet-sametime.c | 14 +- epan/dissectors/packet-sap.c | 14 +- epan/dissectors/packet-sasp.c | 14 +- epan/dissectors/packet-sbc-ap.c | 1632 +- epan/dissectors/packet-sbc.c | 16 +- epan/dissectors/packet-sbus.c | 14 +- epan/dissectors/packet-sccp.c | 22 +- epan/dissectors/packet-sccp.h | 14 +- epan/dissectors/packet-sccpmg.c | 14 +- epan/dissectors/packet-scop.c | 14 +- epan/dissectors/packet-scriptingservice.c | 14 +- epan/dissectors/packet-scsi-mmc.c | 14 +- epan/dissectors/packet-scsi-mmc.h | 14 +- epan/dissectors/packet-scsi-osd.c | 14 +- epan/dissectors/packet-scsi-osd.h | 14 +- epan/dissectors/packet-scsi-sbc.c | 14 +- epan/dissectors/packet-scsi-sbc.h | 14 +- epan/dissectors/packet-scsi-smc.c | 16 +- epan/dissectors/packet-scsi-smc.h | 14 +- epan/dissectors/packet-scsi-ssc.c | 14 +- epan/dissectors/packet-scsi-ssc.h | 14 +- epan/dissectors/packet-scsi.c | 17 +- epan/dissectors/packet-scsi.h | 25 +- epan/dissectors/packet-scte35.c | 14 +- epan/dissectors/packet-sctp.c | 14 +- epan/dissectors/packet-sctp.h | 14 +- epan/dissectors/packet-sdh.c | 14 +- epan/dissectors/packet-sdlc.c | 14 +- epan/dissectors/packet-sdp.c | 105 +- epan/dissectors/packet-sdp.h | 14 +- epan/dissectors/packet-sebek.c | 14 +- epan/dissectors/packet-selfm.c | 14 +- epan/dissectors/packet-sercosiii.c | 14 +- epan/dissectors/packet-ses.c | 14 +- epan/dissectors/packet-ses.h | 14 +- epan/dissectors/packet-sflow.c | 18 +- epan/dissectors/packet-sflow.h | 14 +- epan/dissectors/packet-sgsap.c | 14 +- epan/dissectors/packet-shim6.c | 14 +- epan/dissectors/packet-sigcomp.c | 228 +- epan/dissectors/packet-simple.c | 14 +- epan/dissectors/packet-simulcrypt.c | 14 +- epan/dissectors/packet-sip.c | 262 +- epan/dissectors/packet-sip.h | 16 +- epan/dissectors/packet-sipfrag.c | 14 +- epan/dissectors/packet-sita.c | 14 +- epan/dissectors/packet-skinny.c | 14 +- epan/dissectors/packet-skinny.c.in | 14 +- epan/dissectors/packet-skinny.h | 14 +- epan/dissectors/packet-skinny.h.in | 14 +- epan/dissectors/packet-skype.c | 14 +- epan/dissectors/packet-slimp3.c | 14 +- epan/dissectors/packet-sll.c | 14 +- epan/dissectors/packet-sll.h | 14 +- epan/dissectors/packet-slowprotocols.c | 14 +- epan/dissectors/packet-slsk.c | 14 +- epan/dissectors/packet-smb-browse.c | 14 +- epan/dissectors/packet-smb-browse.h | 14 +- epan/dissectors/packet-smb-common.c | 14 +- epan/dissectors/packet-smb-common.h | 14 +- epan/dissectors/packet-smb-direct.c | 14 +- epan/dissectors/packet-smb-logon.c | 14 +- epan/dissectors/packet-smb-mailslot.c | 14 +- epan/dissectors/packet-smb-mailslot.h | 14 +- epan/dissectors/packet-smb-pipe.c | 14 +- epan/dissectors/packet-smb-pipe.h | 14 +- epan/dissectors/packet-smb-sidsnooping.c | 14 +- epan/dissectors/packet-smb-sidsnooping.h | 14 +- epan/dissectors/packet-smb.c | 134 +- epan/dissectors/packet-smb.h | 14 +- epan/dissectors/packet-smb2.c | 38 +- epan/dissectors/packet-smb2.h | 14 +- epan/dissectors/packet-smcr.c | 14 +- epan/dissectors/packet-sml.c | 14 +- epan/dissectors/packet-smp.c | 266 + epan/dissectors/packet-smpp.c | 14 +- epan/dissectors/packet-smpp.h | 14 +- epan/dissectors/packet-smrse.c | 24 +- epan/dissectors/packet-smrse.h | 14 +- epan/dissectors/packet-smtp.c | 14 +- epan/dissectors/packet-sna.c | 14 +- epan/dissectors/packet-snaeth.c | 14 +- epan/dissectors/packet-sndcp-xid.c | 14 +- epan/dissectors/packet-sndcp.c | 14 +- epan/dissectors/packet-snmp.c | 36 +- epan/dissectors/packet-snmp.h | 14 +- epan/dissectors/packet-snort.c | 44 +- epan/dissectors/packet-socketcan.c | 16 +- epan/dissectors/packet-socketcan.h | 17 +- epan/dissectors/packet-socks.c | 14 +- epan/dissectors/packet-solaredge.c | 14 +- epan/dissectors/packet-soupbintcp.c | 32 +- epan/dissectors/packet-spdy.c | 14 +- epan/dissectors/packet-spice.c | 14 +- epan/dissectors/packet-spnego.c | 24 +- epan/dissectors/packet-spp.c | 14 +- epan/dissectors/packet-spray.c | 14 +- epan/dissectors/packet-spray.h | 14 +- epan/dissectors/packet-sprt.c | 14 +- epan/dissectors/packet-sprt.h | 14 +- epan/dissectors/packet-srp.c | 14 +- epan/dissectors/packet-srvloc.c | 14 +- epan/dissectors/packet-sscf-nni.c | 14 +- epan/dissectors/packet-sscop.c | 14 +- epan/dissectors/packet-sscop.h | 14 +- epan/dissectors/packet-ssh.c | 14 +- epan/dissectors/packet-ssl-utils.c | 254 +- epan/dissectors/packet-ssl-utils.h | 70 +- epan/dissectors/packet-ssl.c | 31 +- epan/dissectors/packet-ssl.h | 14 +- epan/dissectors/packet-sstp.c | 14 +- epan/dissectors/packet-stanag4607.c | 15 +- epan/dissectors/packet-starteam.c | 14 +- epan/dissectors/packet-stat-notify.c | 14 +- epan/dissectors/packet-stat-notify.h | 14 +- epan/dissectors/packet-stat.c | 14 +- epan/dissectors/packet-stat.h | 14 +- epan/dissectors/packet-steam-ihs-discovery.c | 1464 ++ epan/dissectors/packet-stt.c | 14 +- epan/dissectors/packet-stun.c | 14 +- epan/dissectors/packet-sua.c | 14 +- epan/dissectors/packet-sv.c | 24 +- epan/dissectors/packet-sv.h | 14 +- epan/dissectors/packet-swipe.c | 14 +- epan/dissectors/packet-symantec.c | 14 +- epan/dissectors/packet-sync.c | 14 +- epan/dissectors/packet-synergy.c | 14 +- epan/dissectors/packet-synphasor.c | 14 +- epan/dissectors/packet-sysdig-event.c | 28 +- epan/dissectors/packet-sysex.c | 14 +- epan/dissectors/packet-syslog.c | 14 +- epan/dissectors/packet-t124.c | 24 +- epan/dissectors/packet-t124.h | 16 +- epan/dissectors/packet-t125.c | 24 +- epan/dissectors/packet-t30.c | 22 +- epan/dissectors/packet-t30.h | 14 +- epan/dissectors/packet-t38.c | 26 +- epan/dissectors/packet-t38.h | 16 +- epan/dissectors/packet-tacacs.c | 14 +- epan/dissectors/packet-tacacs.h | 14 +- epan/dissectors/packet-tali.c | 14 +- epan/dissectors/packet-tango.c | 14 +- epan/dissectors/packet-tapa.c | 14 +- epan/dissectors/packet-tcap.c | 26 +- epan/dissectors/packet-tcap.h | 16 +- epan/dissectors/packet-tcp.c | 18 +- epan/dissectors/packet-tcp.h | 14 +- epan/dissectors/packet-tcpros.c | 14 +- epan/dissectors/packet-tdmoe.c | 14 +- epan/dissectors/packet-tdmop.c | 14 +- epan/dissectors/packet-tds.c | 3838 ++++- epan/dissectors/packet-teamspeak2.c | 14 +- epan/dissectors/packet-teimanagement.c | 14 +- epan/dissectors/packet-teklink.c | 14 +- epan/dissectors/packet-telkonet.c | 14 +- epan/dissectors/packet-telnet.c | 14 +- epan/dissectors/packet-teredo.c | 14 +- epan/dissectors/packet-tetra.c | 26 +- epan/dissectors/packet-tetra.h | 14 +- epan/dissectors/packet-text-media.c | 14 +- epan/dissectors/packet-tfp.c | 14 +- epan/dissectors/packet-tftp.c | 14 +- epan/dissectors/packet-tftp.h | 14 +- epan/dissectors/packet-thread.c | 33 +- epan/dissectors/packet-thrift.c | 535 +- epan/dissectors/packet-thrift.h | 75 + epan/dissectors/packet-tibia.c | 16 +- epan/dissectors/packet-time.c | 14 +- epan/dissectors/packet-tipc.c | 14 +- epan/dissectors/packet-tivoconnect.c | 14 +- epan/dissectors/packet-tn3270.c | 24 +- epan/dissectors/packet-tn3270.h | 14 +- epan/dissectors/packet-tn5250.c | 24 +- epan/dissectors/packet-tn5250.h | 14 +- epan/dissectors/packet-tnef.c | 14 +- epan/dissectors/packet-tns.c | 14 +- epan/dissectors/packet-tpkt.c | 14 +- epan/dissectors/packet-tpkt.h | 14 +- epan/dissectors/packet-tpncp.c | 14 +- epan/dissectors/packet-tr.c | 14 +- epan/dissectors/packet-tr.h | 14 +- epan/dissectors/packet-trill.c | 14 +- epan/dissectors/packet-trmac.c | 14 +- epan/dissectors/packet-tsp.c | 14 +- epan/dissectors/packet-tte-pcf.c | 15 +- epan/dissectors/packet-tte.c | 15 +- epan/dissectors/packet-tte.h | 15 +- epan/dissectors/packet-turbocell.c | 14 +- epan/dissectors/packet-turnchannel.c | 14 +- epan/dissectors/packet-tuxedo.c | 14 +- epan/dissectors/packet-twamp.c | 221 +- epan/dissectors/packet-tzsp.c | 14 +- epan/dissectors/packet-u3v.c | 14 +- epan/dissectors/packet-ua.c | 14 +- epan/dissectors/packet-ua.h | 14 +- epan/dissectors/packet-ua3g.c | 14 +- epan/dissectors/packet-uasip.c | 14 +- epan/dissectors/packet-uaudp.c | 14 +- epan/dissectors/packet-uaudp.h | 14 +- epan/dissectors/packet-ubertooth.c | 14 +- epan/dissectors/packet-ubertooth.h | 14 +- epan/dissectors/packet-ucp.c | 14 +- epan/dissectors/packet-udld.c | 14 +- epan/dissectors/packet-udp-nm.c | 14 +- epan/dissectors/packet-udp.c | 16 +- epan/dissectors/packet-udp.h | 14 +- epan/dissectors/packet-uds.c | 14 +- epan/dissectors/packet-udt.c | 14 +- epan/dissectors/packet-uftp.c | 14 +- epan/dissectors/packet-uftp4.c | 14 +- epan/dissectors/packet-uhd.c | 14 +- epan/dissectors/packet-ulp.c | 26 +- epan/dissectors/packet-uma.c | 14 +- epan/dissectors/packet-umts_fp.c | 247 +- epan/dissectors/packet-umts_fp.h | 20 +- epan/dissectors/packet-umts_mac.c | 27 +- epan/dissectors/packet-umts_mac.h | 14 +- epan/dissectors/packet-umts_rlc.c | 57 +- epan/dissectors/packet-umts_rlc.h | 14 +- epan/dissectors/packet-usb-audio.c | 14 +- epan/dissectors/packet-usb-ccid.c | 14 +- epan/dissectors/packet-usb-com.c | 14 +- epan/dissectors/packet-usb-dfu.c | 14 +- epan/dissectors/packet-usb-hid.c | 14 +- epan/dissectors/packet-usb-hid.h | 14 +- epan/dissectors/packet-usb-hub.c | 14 +- epan/dissectors/packet-usb-i1d3.c | 14 +- epan/dissectors/packet-usb-masstorage.c | 36 +- epan/dissectors/packet-usb-video.c | 14 +- epan/dissectors/packet-usb.c | 24 +- epan/dissectors/packet-usb.h | 14 +- epan/dissectors/packet-usbip.c | 14 +- epan/dissectors/packet-usbip.h | 14 +- epan/dissectors/packet-user_encap.c | 14 +- epan/dissectors/packet-userlog.c | 14 +- epan/dissectors/packet-uts.c | 14 +- epan/dissectors/packet-v120.c | 14 +- epan/dissectors/packet-v150fw.c | 14 +- epan/dissectors/packet-v52.c | 14 +- epan/dissectors/packet-v5dl.c | 14 +- epan/dissectors/packet-v5ef.c | 14 +- epan/dissectors/packet-v5ua.c | 14 +- epan/dissectors/packet-vcdu.c | 14 +- epan/dissectors/packet-vicp.c | 14 +- epan/dissectors/packet-vines.c | 14 +- epan/dissectors/packet-vlan.c | 32 +- epan/dissectors/packet-vmlab.c | 14 +- epan/dissectors/packet-vnc.c | 14 +- epan/dissectors/packet-vntag.c | 74 +- epan/dissectors/packet-vp8.c | 14 +- epan/dissectors/packet-vrrp.c | 14 +- epan/dissectors/packet-vrt.c | 14 +- epan/dissectors/packet-vsip.c | 14 +- epan/dissectors/packet-vsock.c | 14 +- epan/dissectors/packet-vssmonitoring.c | 14 +- epan/dissectors/packet-vtp.c | 14 +- epan/dissectors/packet-vuze-dht.c | 14 +- epan/dissectors/packet-vxi11.c | 14 +- epan/dissectors/packet-vxlan.c | 14 +- epan/dissectors/packet-vxlan.h | 14 +- epan/dissectors/packet-wai.c | 14 +- epan/dissectors/packet-wap.c | 74 +- epan/dissectors/packet-wap.h | 14 +- epan/dissectors/packet-wassp.c | 14 +- epan/dissectors/packet-waveagent.c | 14 +- epan/dissectors/packet-wbxml.c | 14 +- epan/dissectors/packet-wccp.c | 53 +- epan/dissectors/packet-wccp.h | 14 +- epan/dissectors/packet-wcp.c | 24 +- epan/dissectors/packet-websocket.c | 32 +- epan/dissectors/packet-wfleet-hdlc.c | 14 +- epan/dissectors/packet-who.c | 14 +- epan/dissectors/packet-whois.c | 14 +- epan/dissectors/packet-wifi-display.c | 14 +- epan/dissectors/packet-wifi-dpp.c | 53 +- epan/dissectors/packet-wifi-p2p.c | 14 +- epan/dissectors/packet-windows-common.c | 14 +- epan/dissectors/packet-windows-common.h | 14 +- epan/dissectors/packet-winsrepl.c | 14 +- epan/dissectors/packet-wisun.c | 824 +- epan/dissectors/packet-wlancertextn.c | 26 +- epan/dissectors/packet-wlancertextn.h | 14 +- epan/dissectors/packet-wlccp.c | 14 +- epan/dissectors/packet-wol.c | 14 +- epan/dissectors/packet-wow.c | 15 +- epan/dissectors/packet-wps.c | 14 +- epan/dissectors/packet-wps.h | 14 +- epan/dissectors/packet-wreth.c | 15 +- epan/dissectors/packet-wsmp.c | 14 +- epan/dissectors/packet-wsp.c | 54 +- epan/dissectors/packet-wsp.h | 14 +- epan/dissectors/packet-wtls.c | 14 +- epan/dissectors/packet-wtls.h | 14 +- epan/dissectors/packet-wtp.c | 14 +- epan/dissectors/packet-wtp.h | 14 +- epan/dissectors/packet-x11-keysymdef.h | 14 +- epan/dissectors/packet-x11.c | 14 +- epan/dissectors/packet-x11.h | 14 +- epan/dissectors/packet-x25.c | 14 +- epan/dissectors/packet-x29.c | 14 +- epan/dissectors/packet-x2ap.c | 9952 ++++++++--- epan/dissectors/packet-x509af.c | 26 +- epan/dissectors/packet-x509af.h | 16 +- epan/dissectors/packet-x509ce.c | 26 +- epan/dissectors/packet-x509ce.h | 16 +- epan/dissectors/packet-x509if.c | 26 +- epan/dissectors/packet-x509if.h | 16 +- epan/dissectors/packet-x509sat.c | 28 +- epan/dissectors/packet-x509sat.h | 16 +- epan/dissectors/packet-xcsl.c | 14 +- epan/dissectors/packet-xdmcp.c | 14 +- epan/dissectors/packet-xip-serval.c | 14 +- epan/dissectors/packet-xip.c | 14 +- epan/dissectors/packet-xmcp.c | 14 +- epan/dissectors/packet-xml.c | 15 +- epan/dissectors/packet-xml.h | 14 +- epan/dissectors/packet-xmpp-conference.c | 14 +- epan/dissectors/packet-xmpp-conference.h | 14 +- epan/dissectors/packet-xmpp-core.c | 14 +- epan/dissectors/packet-xmpp-core.h | 14 +- epan/dissectors/packet-xmpp-gtalk.c | 14 +- epan/dissectors/packet-xmpp-gtalk.h | 14 +- epan/dissectors/packet-xmpp-jingle.c | 14 +- epan/dissectors/packet-xmpp-jingle.h | 14 +- epan/dissectors/packet-xmpp-other.c | 14 +- epan/dissectors/packet-xmpp-other.h | 14 +- epan/dissectors/packet-xmpp-utils.c | 14 +- epan/dissectors/packet-xmpp-utils.h | 14 +- epan/dissectors/packet-xmpp.c | 14 +- epan/dissectors/packet-xmpp.h | 14 +- epan/dissectors/packet-xot.c | 14 +- epan/dissectors/packet-xra.c | 1212 ++ epan/dissectors/packet-xtp.c | 14 +- epan/dissectors/packet-xyplex.c | 14 +- epan/dissectors/packet-yami.c | 14 +- epan/dissectors/packet-yhoo.c | 14 +- epan/dissectors/packet-ymsg.c | 14 +- epan/dissectors/packet-ypbind.c | 14 +- epan/dissectors/packet-ypbind.h | 14 +- epan/dissectors/packet-yppasswd.c | 14 +- epan/dissectors/packet-yppasswd.h | 14 +- epan/dissectors/packet-ypserv.c | 14 +- epan/dissectors/packet-ypserv.h | 14 +- epan/dissectors/packet-ypxfr.c | 14 +- epan/dissectors/packet-ypxfr.h | 14 +- epan/dissectors/packet-zbee-aps.c | 40 +- epan/dissectors/packet-zbee-aps.h | 25 +- epan/dissectors/packet-zbee-nwk-gp.c | 14 +- epan/dissectors/packet-zbee-nwk.c | 14 +- epan/dissectors/packet-zbee-nwk.h | 14 +- epan/dissectors/packet-zbee-security.c | 14 +- epan/dissectors/packet-zbee-security.h | 14 +- epan/dissectors/packet-zbee-zcl-closures.c | 32 +- epan/dissectors/packet-zbee-zcl-general.c | 590 +- epan/dissectors/packet-zbee-zcl-ha.c | 38 +- epan/dissectors/packet-zbee-zcl-hvac.c | 50 +- epan/dissectors/packet-zbee-zcl-lighting.c | 32 +- epan/dissectors/packet-zbee-zcl-meas-sensing.c | 37 +- epan/dissectors/packet-zbee-zcl-misc.c | 32 +- epan/dissectors/packet-zbee-zcl-sas.c | 32 +- epan/dissectors/packet-zbee-zcl-se.c | 1312 +- epan/dissectors/packet-zbee-zcl.c | 47 +- epan/dissectors/packet-zbee-zcl.h | 17 +- epan/dissectors/packet-zbee-zdp-binding.c | 14 +- epan/dissectors/packet-zbee-zdp-discovery.c | 14 +- epan/dissectors/packet-zbee-zdp-management.c | 14 +- epan/dissectors/packet-zbee-zdp.c | 14 +- epan/dissectors/packet-zbee-zdp.h | 14 +- epan/dissectors/packet-zbee.h | 14 +- epan/dissectors/packet-zebra.c | 14 +- epan/dissectors/packet-zep.c | 14 +- epan/dissectors/packet-ziop.c | 14 +- epan/dissectors/packet-ziop.h | 14 +- epan/dissectors/packet-zrtp.c | 18 +- epan/dissectors/packet-zvt.c | 14 +- epan/dissectors/pidl/CMakeLists.txt | 14 +- epan/dissectors/read_keytab_file.h | 14 +- epan/dissectors/snort-config.c | 21 +- epan/dissectors/snort-config.h | 14 +- epan/dissectors/usb.c | 68 +- epan/dissectors/x11-declarations.h | 14 +- epan/dissectors/x11-enum.h | 14 +- epan/dissectors/x11-extension-errors.h | 14 +- epan/dissectors/x11-extension-implementation.h | 14 +- epan/dissectors/x11-fields | 14 +- epan/dissectors/x11-glx-render-enum.h | 14 +- epan/dissectors/x11-keysym.h | 14 +- epan/dissectors/x11-register-info.h | 14 +- epan/dtd.h | 14 +- epan/dtd_grammar.lemon | 14 +- epan/dtd_parse.h | 14 +- epan/dtd_parse.l | 10 +- epan/dtd_preparse.l | 16 +- epan/dvb_chartbl.c | 14 +- epan/dvb_chartbl.h | 14 +- epan/eap.h | 14 +- epan/eapol_keydes_types.h | 14 +- epan/epan.c | 67 +- epan/epan.h | 22 +- epan/epan_dissect.h | 14 +- epan/etypes.h | 14 +- epan/ex-opt.c | 14 +- epan/ex-opt.h | 14 +- epan/exceptions.h | 14 +- epan/exntest.c | 14 +- epan/expert.c | 14 +- epan/expert.h | 14 +- epan/export_object.c | 14 +- epan/export_object.h | 22 +- epan/exported_pdu.c | 14 +- epan/exported_pdu.h | 14 +- epan/filter_expressions.c | 14 +- epan/filter_expressions.h | 14 +- epan/follow.c | 14 +- epan/follow.h | 14 +- epan/frame_data.c | 61 +- epan/frame_data.h | 16 +- epan/frame_data_sequence.c | 14 +- epan/frame_data_sequence.h | 14 +- epan/ftypes/CMakeLists.txt | 14 +- epan/ftypes/ftype-bytes.c | 14 +- epan/ftypes/ftype-double.c | 14 +- epan/ftypes/ftype-guid.c | 14 +- epan/ftypes/ftype-ieee-11073-float.c | 14 +- epan/ftypes/ftype-integer.c | 14 +- epan/ftypes/ftype-ipv4.c | 14 +- epan/ftypes/ftype-ipv6.c | 14 +- epan/ftypes/ftype-none.c | 14 +- epan/ftypes/ftype-pcre.c | 14 +- epan/ftypes/ftype-protocol.c | 14 +- epan/ftypes/ftype-string.c | 14 +- epan/ftypes/ftype-time.c | 14 +- epan/ftypes/ftypes-int.h | 14 +- epan/ftypes/ftypes.c | 14 +- epan/ftypes/ftypes.h | 14 +- epan/funnel.c | 14 +- epan/funnel.h | 14 +- epan/garrayfix.h | 14 +- epan/geoip_db.c | 650 - epan/geoip_db.h | 116 - epan/golay.c | 14 +- epan/golay.h | 14 +- epan/guid-utils.c | 14 +- epan/guid-utils.h | 14 +- epan/iana_charsets.c | 14 +- epan/iana_charsets.h | 14 +- epan/iax2_codec_type.h | 14 +- epan/in_cksum.c | 24 +- epan/in_cksum.h | 24 +- epan/ip_opts.h | 14 +- epan/ipproto.c | 14 +- epan/ipproto.h | 14 +- epan/ipv4.h | 14 +- epan/ipv6.h | 14 +- epan/lapd_sapi.h | 14 +- epan/llcsaps.h | 14 +- epan/maxmind_db.c | 550 + epan/maxmind_db.h | 94 + epan/media_params.c | 19 +- epan/media_params.h | 18 +- epan/next_tvb.c | 14 +- epan/next_tvb.h | 14 +- epan/nlpid.h | 14 +- epan/oids.c | 63 +- epan/oids.h | 14 +- epan/oids_test.c | 14 +- epan/osi-utils.c | 14 +- epan/osi-utils.h | 14 +- epan/oui.h | 14 +- epan/packet.c | 131 +- epan/packet.h | 10 +- epan/packet_info.h | 18 +- epan/params.h | 14 +- epan/plugin_if.c | 54 +- epan/plugin_if.h | 14 +- epan/ppptypes.h | 14 +- epan/prefs-int.h | 99 +- epan/prefs.c | 244 +- epan/prefs.h | 17 +- epan/print.c | 78 +- epan/print.h | 20 +- epan/print_stream.c | 82 +- epan/print_stream.h | 17 +- epan/proto.c | 148 +- epan/proto.h | 21 +- epan/proto_data.c | 16 +- epan/proto_data.h | 14 +- epan/ps.h | 14 +- epan/ptvcursor.h | 14 +- epan/radius_dict.l | 16 +- epan/range.c | 14 +- epan/range.h | 14 +- epan/reassemble.c | 14 +- epan/reassemble.h | 14 +- epan/reassemble_test.c | 14 +- epan/reedsolomon.c | 14 +- epan/reedsolomon.h | 14 +- epan/register.c | 29 +- epan/register.h | 2 +- epan/req_resp_hdrs.c | 14 +- epan/req_resp_hdrs.h | 14 +- epan/rtd_table.c | 14 +- epan/rtd_table.h | 14 +- epan/rtp_pt.h | 14 +- epan/sctpppids.h | 14 +- epan/sequence_analysis.c | 14 +- epan/sequence_analysis.h | 14 +- epan/show_exception.c | 14 +- epan/show_exception.h | 14 +- epan/slow_protocol_subtypes.h | 14 +- epan/sminmpec.h | 14 +- epan/srt_table.c | 14 +- epan/srt_table.h | 14 +- epan/stat_groups.h | 14 +- epan/stat_tap_ui.c | 40 +- epan/stat_tap_ui.h | 48 +- epan/stats_tree.c | 14 +- epan/stats_tree.h | 14 +- epan/stats_tree_priv.h | 14 +- epan/stream.c | 14 +- epan/stream.h | 14 +- epan/strutil.c | 14 +- epan/strutil.h | 14 +- epan/t35.c | 14 +- epan/t35.h | 14 +- epan/tap-voip.h | 14 +- epan/tap.c | 14 +- epan/tap.h | 14 +- epan/tfs.c | 17 +- epan/tfs.h | 17 +- epan/time_fmt.h | 14 +- epan/timestamp.c | 14 +- epan/timestamp.h | 14 +- epan/timestats.c | 14 +- epan/timestats.h | 14 +- epan/to_str-int.h | 14 +- epan/to_str.c | 14 +- epan/to_str.h | 14 +- epan/tvbparse.c | 66 +- epan/tvbparse.h | 15 +- epan/tvbtest.c | 14 +- epan/tvbuff-int.h | 14 +- epan/tvbuff.c | 57 +- epan/tvbuff.h | 19 +- epan/tvbuff_base64.c | 14 +- epan/tvbuff_composite.c | 14 +- epan/tvbuff_real.c | 14 +- epan/tvbuff_subset.c | 14 +- epan/tvbuff_zlib.c | 14 +- epan/uat-int.h | 14 +- epan/uat.c | 14 +- epan/uat.h | 20 +- epan/uat_load.l | 16 +- epan/unit_strings.c | 21 +- epan/unit_strings.h | 21 +- epan/value_string.c | 14 +- epan/value_string.h | 14 +- epan/wmem/CMakeLists.txt | 14 +- epan/wmem/wmem.h | 14 +- epan/wmem/wmem_allocator.h | 14 +- epan/wmem/wmem_allocator_block.c | 14 +- epan/wmem/wmem_allocator_block.h | 14 +- epan/wmem/wmem_allocator_block_fast.c | 14 +- epan/wmem/wmem_allocator_block_fast.h | 14 +- epan/wmem/wmem_allocator_simple.c | 14 +- epan/wmem/wmem_allocator_simple.h | 14 +- epan/wmem/wmem_allocator_strict.c | 14 +- epan/wmem/wmem_allocator_strict.h | 14 +- epan/wmem/wmem_array.c | 14 +- epan/wmem/wmem_array.h | 14 +- epan/wmem/wmem_core.c | 14 +- epan/wmem/wmem_core.h | 14 +- epan/wmem/wmem_interval_tree.c | 14 +- epan/wmem/wmem_interval_tree.h | 14 +- epan/wmem/wmem_list.c | 14 +- epan/wmem/wmem_list.h | 14 +- epan/wmem/wmem_map.c | 70 +- epan/wmem/wmem_map.h | 37 +- epan/wmem/wmem_map_int.h | 14 +- epan/wmem/wmem_miscutl.c | 14 +- epan/wmem/wmem_miscutl.h | 14 +- epan/wmem/wmem_queue.h | 14 +- epan/wmem/wmem_scopes.c | 14 +- epan/wmem/wmem_scopes.h | 14 +- epan/wmem/wmem_stack.c | 14 +- epan/wmem/wmem_stack.h | 14 +- epan/wmem/wmem_strbuf.c | 14 +- epan/wmem/wmem_strbuf.h | 14 +- epan/wmem/wmem_strutl.c | 95 +- epan/wmem/wmem_strutl.h | 26 +- epan/wmem/wmem_test.c | 37 +- epan/wmem/wmem_tree-int.h | 14 +- epan/wmem/wmem_tree.c | 14 +- epan/wmem/wmem_tree.h | 14 +- epan/wmem/wmem_user_cb.c | 14 +- epan/wmem/wmem_user_cb.h | 14 +- epan/wmem/wmem_user_cb_int.h | 14 +- epan/wslua/CMakeLists.txt | 14 +- epan/wslua/console.lua | 14 +- epan/wslua/dtd_gen.lua | 14 +- epan/wslua/init_wslua.c | 20 +- epan/wslua/init_wslua.h | 15 +- epan/wslua/lrexlib.c | 22 +- epan/wslua/lrexlib.h | 22 +- epan/wslua/lrexlib_algo.h | 22 +- epan/wslua/lrexlib_glib.c | 18 +- epan/wslua/lrexlib_glib_f.c | 18 +- epan/wslua/lua_bitop.c | 20 +- epan/wslua/lua_bitop.h | 20 +- epan/wslua/make-init-lua.pl | 14 +- epan/wslua/make-reg.pl | 14 +- epan/wslua/make-taps.pl | 14 +- epan/wslua/taps | 14 +- epan/wslua/template-init.lua | 14 +- epan/wslua/wslua.h | 22 +- epan/wslua/wslua_address.c | 14 +- epan/wslua/wslua_byte_array.c | 14 +- epan/wslua/wslua_capture_info.c | 28 +- epan/wslua/wslua_column.c | 14 +- epan/wslua/wslua_dir.c | 19 +- epan/wslua/wslua_dissector.c | 20 +- epan/wslua/wslua_dumper.c | 74 +- epan/wslua/wslua_field.c | 16 +- epan/wslua/wslua_file.c | 24 +- epan/wslua/wslua_file_common.c | 14 +- epan/wslua/wslua_file_common.h | 18 +- epan/wslua/wslua_file_handler.c | 40 +- epan/wslua/wslua_frame_info.c | 111 +- epan/wslua/wslua_gui.c | 14 +- epan/wslua/wslua_int64.c | 26 +- epan/wslua/wslua_internals.c | 22 +- epan/wslua/wslua_listener.c | 38 +- epan/wslua/wslua_nstime.c | 18 +- epan/wslua/wslua_pinfo.c | 14 +- epan/wslua/wslua_pinfo_common.h | 14 +- epan/wslua/wslua_pref.c | 14 +- epan/wslua/wslua_proto.c | 16 +- epan/wslua/wslua_proto_expert.c | 14 +- epan/wslua/wslua_proto_field.c | 48 +- epan/wslua/wslua_struct.c | 31 +- epan/wslua/wslua_tree.c | 40 +- epan/wslua/wslua_tvb.c | 32 +- epan/wslua/wslua_util.c | 20 +- epan/x264_prt_id.h | 14 +- epan/xdlc.c | 14 +- epan/xdlc.h | 14 +- extcap.c | 165 +- extcap.h | 2 +- extcap/Makefile.am | 2 +- extcap/androiddump.c | 346 +- extcap/ciscodump.c | 2 +- extcap/extcap-base.c | 2 +- extcap/extcap-base.h | 2 +- extcap/randpktdump.c | 4 +- extcap/ssh-base.c | 2 +- extcap/ssh-base.h | 2 +- extcap/sshdump.c | 2 +- extcap/udpdump.c | 2 +- extcap_parser.c | 4 +- extcap_parser.h | 2 +- extcap_spawn.c | 404 - extcap_spawn.h | 55 - file.c | 276 +- file.h | 6 +- file_packet_provider.c | 2 +- fileset.c | 2 +- fileset.h | 2 +- frame_tvbuff.c | 14 +- frame_tvbuff.h | 2 +- globals.h | 2 +- help/faq.py | 14 +- image/README.image | 17 +- image/clist_ascend.xpm | 9 - image/clist_descend.xpm | 9 - image/file_dlg_win32.rc | 56 +- image/hi16-app-wireshark.png | Bin 701 -> 0 bytes image/hi32-app-wireshark.png | Bin 1460 -> 0 bytes image/hi48-app-wireshark.png | Bin 2571 -> 0 bytes image/lo16-app-wireshark.png | Bin 328 -> 0 bytes image/lo32-app-wireshark.png | Bin 616 -> 0 bytes image/lo48-app-wireshark.png | Bin 984 -> 0 bytes image/nsis-checked.bmp | Bin 358 -> 0 bytes image/nsis-unchecked.bmp | Bin 358 -> 0 bytes image/openhand-16.png | Bin 154 -> 0 bytes image/rubberband-16.png | Bin 203 -> 0 bytes image/stock_dialog_error_48.xpm | 525 - image/stock_dialog_info_48.xpm | 641 - image/stock_dialog_question_48.xpm | 532 - image/stock_dialog_stop_48.xpm | 978 -- image/stock_dialog_warning_48.xpm | 276 - image/stock_icons.qrc | 143 + .../14x14/x-capture-comment-update.png | Bin .../14x14/x-capture-comment-update.svg | 0 .../14x14/x-capture-comment-update(a)2x.png | Bin .../14x14/x-capture-filter-bookmark.active.png | Bin .../14x14/x-capture-filter-bookmark.active.svg | 0 .../14x14/x-capture-filter-bookmark.active(a)2x.png | Bin .../14x14/x-capture-filter-bookmark.png | Bin .../14x14/x-capture-filter-bookmark.selected.png | Bin .../14x14/x-capture-filter-bookmark.selected.svg | 0 .../x-capture-filter-bookmark.selected(a)2x.png | Bin .../14x14/x-capture-filter-bookmark.svg | 0 .../14x14/x-capture-filter-bookmark(a)2x.png | Bin .../14x14/x-display-filter-bookmark.active.png | Bin .../14x14/x-display-filter-bookmark.active.svg | 0 .../14x14/x-display-filter-bookmark.active(a)2x.png | Bin .../14x14/x-display-filter-bookmark.png | Bin .../14x14/x-display-filter-bookmark.selected.png | Bin .../14x14/x-display-filter-bookmark.selected.svg | 0 .../x-display-filter-bookmark.selected(a)2x.png | Bin .../14x14/x-display-filter-bookmark.svg | 0 .../14x14/x-display-filter-bookmark(a)2x.png | Bin .../14x14/x-expert-chat.png | Bin .../14x14/x-expert-chat(a)2x.png | Bin .../14x14/x-expert-error.png | Bin .../14x14/x-expert-error(a)2x.png | Bin .../14x14/x-expert-indicators-all.svg | 0 .../14x14/x-expert-none.png | Bin .../14x14/x-expert-none(a)2x.png | Bin .../14x14/x-expert-note.png | Bin .../14x14/x-expert-note(a)2x.png | Bin .../14x14/x-expert-warn.png | Bin .../14x14/x-expert-warn(a)2x.png | Bin .../14x14/x-filter-clear.active.png | Bin .../14x14/x-filter-clear.active.svg | 0 .../14x14/x-filter-clear.active(a)2x.png | Bin .../14x14/x-filter-clear.png | Bin .../14x14/x-filter-clear.selected.png | Bin .../14x14/x-filter-clear.selected.svg | 0 .../14x14/x-filter-clear.selected(a)2x.png | Bin .../14x14/x-filter-clear.svg | 0 .../14x14/x-filter-clear(a)2x.png | Bin .../14x14/x-filter-dropdown.png | Bin .../14x14/x-filter-dropdown.svg | 0 .../14x14/x-filter-dropdown(a)2x.png | Bin .../14x14/x-filter-matching-bookmark.active.png | Bin .../14x14/x-filter-matching-bookmark.active.svg | 0 .../14x14/x-filter-matching-bookmark.active(a)2x.png | Bin .../14x14/x-filter-matching-bookmark.png | Bin .../14x14/x-filter-matching-bookmark.selected.png | Bin .../14x14/x-filter-matching-bookmark.selected.svg | 0 .../x-filter-matching-bookmark.selected(a)2x.png | Bin .../14x14/x-filter-matching-bookmark.svg | 0 .../14x14/x-filter-matching-bookmark(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/edit-find.png | Bin image/{toolbar => stock_icons}/16x16/edit-find.svg | 0 .../16x16/edit-find(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/go-first.png | Bin image/{toolbar => stock_icons}/16x16/go-first.svg | 0 .../{toolbar => stock_icons}/16x16/go-first(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/go-jump.png | Bin image/{toolbar => stock_icons}/16x16/go-jump.svg | 0 .../{toolbar => stock_icons}/16x16/go-jump(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/go-last.png | Bin image/{toolbar => stock_icons}/16x16/go-last.svg | 0 .../{toolbar => stock_icons}/16x16/go-last(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/go-next.png | Bin image/{toolbar => stock_icons}/16x16/go-next.svg | 0 .../{toolbar => stock_icons}/16x16/go-next(a)2x.png | Bin .../{toolbar => stock_icons}/16x16/go-previous.png | Bin .../{toolbar => stock_icons}/16x16/go-previous.svg | 0 .../16x16/go-previous(a)2x.png | Bin .../16x16/x-capture-file-close.png | Bin .../16x16/x-capture-file-close.svg | 0 .../16x16/x-capture-file-close(a)2x.png | Bin .../16x16/x-capture-file-close(a)2x.svg | 0 .../16x16/x-capture-file-reload.png | Bin .../16x16/x-capture-file-reload.svg | 0 .../16x16/x-capture-file-reload(a)2x.png | Bin .../16x16/x-capture-file-reload(a)2x.svg | 0 .../16x16/x-capture-file-save.png | Bin .../16x16/x-capture-file-save.svg | 0 .../16x16/x-capture-file-save(a)2x.png | Bin .../16x16/x-capture-file-save(a)2x.svg | 0 .../16x16/x-capture-options-gear.svg | 0 .../16x16/x-capture-options-wrench.svg | 0 .../16x16/x-capture-options.png | Bin .../16x16/x-capture-options(a)2x.png | Bin .../16x16/x-capture-restart-fin.svg | 0 .../16x16/x-capture-restart-triangle1.svg | 0 .../16x16/x-capture-restart-triangle2.svg | 0 .../16x16/x-capture-restart-turn1.svg | 0 .../16x16/x-capture-restart-turn2.svg | 0 .../16x16/x-capture-restart.png | Bin .../16x16/x-capture-restart(a)2x.png | Bin .../16x16/x-capture-start.on.png | Bin .../16x16/x-capture-start.on.svg | 0 .../16x16/x-capture-start.on(a)2x.png | Bin .../16x16/x-capture-start.png | Bin .../16x16/x-capture-start.svg | 0 .../16x16/x-capture-start(a)2x.png | Bin .../16x16/x-capture-stop-red.svg | 0 .../16x16/x-capture-stop-white.svg | 0 .../16x16/x-capture-stop.png | Bin .../16x16/x-capture-stop(a)2x.png | Bin .../16x16/x-colorize-packets.png | Bin .../16x16/x-colorize-packets.svg | 0 .../16x16/x-colorize-packets(a)2x.png | Bin .../16x16/x-resize-columns.png | Bin .../16x16/x-resize-columns.svg | 0 .../16x16/x-resize-columns(a)2x.png | Bin .../{toolbar => stock_icons}/16x16/x-stay-last.png | Bin .../{toolbar => stock_icons}/16x16/x-stay-last.svg | 0 .../16x16/x-stay-last(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/zoom-in.png | Bin image/{toolbar => stock_icons}/16x16/zoom-in.svg | 0 .../{toolbar => stock_icons}/16x16/zoom-in(a)2x.png | Bin .../16x16/zoom-original.png | Bin .../16x16/zoom-original.svg | 0 .../16x16/zoom-original(a)2x.png | Bin image/{toolbar => stock_icons}/16x16/zoom-out.png | Bin image/{toolbar => stock_icons}/16x16/zoom-out.svg | 0 .../{toolbar => stock_icons}/16x16/zoom-out(a)2x.png | Bin .../24x14/x-filter-apply.active.png | Bin .../24x14/x-filter-apply.active.svg | 0 .../24x14/x-filter-apply.active(a)2x.png | Bin .../24x14/x-filter-apply.png | Bin .../24x14/x-filter-apply.selected.png | Bin .../24x14/x-filter-apply.selected.svg | 0 .../24x14/x-filter-apply.selected(a)2x.png | Bin .../24x14/x-filter-apply.svg | 0 .../24x14/x-filter-apply(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/edit-find.png | Bin image/{toolbar => stock_icons}/24x24/edit-find.svg | 0 .../24x24/edit-find(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/go-first.png | Bin image/{toolbar => stock_icons}/24x24/go-first.svg | 0 .../{toolbar => stock_icons}/24x24/go-first(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/go-jump.png | Bin image/{toolbar => stock_icons}/24x24/go-jump.svg | 0 .../{toolbar => stock_icons}/24x24/go-jump(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/go-last.png | Bin image/{toolbar => stock_icons}/24x24/go-last.svg | 0 .../{toolbar => stock_icons}/24x24/go-last(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/go-next.png | Bin image/{toolbar => stock_icons}/24x24/go-next.svg | 0 .../{toolbar => stock_icons}/24x24/go-next(a)2x.png | Bin .../{toolbar => stock_icons}/24x24/go-previous.png | Bin .../{toolbar => stock_icons}/24x24/go-previous.svg | 0 .../24x24/go-previous(a)2x.png | Bin .../24x24/x-capture-file-close.png | Bin .../24x24/x-capture-file-close.svg | 0 .../24x24/x-capture-file-close(a)2x.png | Bin .../24x24/x-capture-file-close(a)2x.svg | 0 .../24x24/x-capture-file-reload.png | Bin .../24x24/x-capture-file-reload.svg | 0 .../24x24/x-capture-file-reload(a)2x.png | Bin .../stock_icons/24x24/x-capture-file-reload(a)2x.svg | 113 + .../24x24/x-capture-file-save.png | Bin .../24x24/x-capture-file-save.svg | 0 .../24x24/x-capture-file-save(a)2x.png | Bin .../24x24/x-capture-file-save(a)2x.svg | 0 .../24x24/x-capture-options-gear.svg | 0 .../24x24/x-capture-options-wrench.svg | 0 .../24x24/x-capture-options.png | Bin .../24x24/x-capture-options(a)2x.png | Bin .../24x24/x-capture-restart-fin.svg | 0 .../24x24/x-capture-restart-triangle1.svg | 0 .../24x24/x-capture-restart-triangle2.svg | 0 .../24x24/x-capture-restart-turn1.svg | 0 .../24x24/x-capture-restart-turn2.svg | 0 .../24x24/x-capture-restart.png | Bin .../24x24/x-capture-restart(a)2x.png | Bin .../24x24/x-capture-start.on.png | Bin .../24x24/x-capture-start.on.svg | 0 .../24x24/x-capture-start.on(a)2x.png | Bin .../24x24/x-capture-start.png | Bin .../24x24/x-capture-start.svg | 0 .../24x24/x-capture-start(a)2x.png | Bin .../24x24/x-capture-stop-red.svg | 0 .../24x24/x-capture-stop-white.svg | 0 .../24x24/x-capture-stop.png | Bin .../24x24/x-capture-stop(a)2x.png | Bin .../24x24/x-colorize-packets.png | Bin .../24x24/x-colorize-packets.svg | 0 .../24x24/x-colorize-packets(a)2x.png | Bin .../24x24/x-resize-columns-motion.svg | 0 .../24x24/x-resize-columns.png | Bin .../24x24/x-resize-columns.svg | 0 .../24x24/x-resize-columns(a)2x.png | Bin .../{toolbar => stock_icons}/24x24/x-stay-last.png | Bin .../{toolbar => stock_icons}/24x24/x-stay-last.svg | 0 .../24x24/x-stay-last(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/zoom-in.png | Bin image/{toolbar => stock_icons}/24x24/zoom-in.svg | 0 .../{toolbar => stock_icons}/24x24/zoom-in(a)2x.png | Bin .../24x24/zoom-original.png | Bin .../24x24/zoom-original.svg | 0 .../24x24/zoom-original(a)2x.png | Bin image/{toolbar => stock_icons}/24x24/zoom-out.png | Bin image/{toolbar => stock_icons}/24x24/zoom-out.svg | 0 .../{toolbar => stock_icons}/24x24/zoom-out(a)2x.png | Bin image/stock_icons/svg-to-png.sh | 134 + .../svg/x-filter-apply.svg | 0 .../svg/x-filter-bookmark.svg | 0 .../svg/x-filter-clear.svg | 0 image/toolbar.qrc | 143 - image/toolbar/24x24/x-capture-file-reload(a)2x.svg | 114 - image/toolbar/svg-to-png.sh | 146 - image/voip_select.xpm | 116 - image/wireshark.exe.manifest.in | 6 +- image/wssplash-dev.xpm | 1876 --- image/wssplash.xpm | 878 - ipmap.html | 106 - log.h | 2 +- m4/ax_append_flag.m4 | 13 +- m4/ax_check_compile_flag.m4 | 13 +- m4/ax_compiler_vendor.m4 | 13 +- macosx-support-lib-patches/qt-fix-pc-file | 14 +- macosx-support-lib-patches/qt-fix-pc-files | 14 +- make-version.pl | 16 +- manuf | 794 +- manuf.tmpl | 14 +- mergecap.c | 6 +- mmdbresolve.c | 179 + packaging/macosx/Info.plist.in | 6 +- packaging/macosx/Scripts/cli-postinstall.sh | 1 + packaging/macosx/Scripts/wireshark-postinstall.sh | 2 +- packaging/macosx/osx-app.sh.in | 221 +- packaging/nsis/CMakeLists.txt | 33 +- packaging/nsis/common.nsh | 0 packaging/nsis/config.nsh.in | 6 +- packaging/nsis/uninstall.nsi | 22 +- packaging/nsis/windeployqt-to-nsis.ps1 | 14 +- packaging/nsis/wireshark.nsi | 67 +- packaging/portableapps/CMakeLists.txt | 14 +- packaging/portableapps/appinfo.tmpl | 0 packaging/portableapps/xcopy-deploy-exclude.txt | 6 + packaging/rpm/SPECS/wireshark.spec.in | 4 +- packaging/wix/CMakeLists.txt | 50 +- packaging/wix/ComponentGroups.wxi | 24 +- packaging/wix/DirectoryStructure.wxi | 4 +- packaging/wix/Features.wxi | 5 + packaging/wix/Plugins.wxi | 32 +- packaging/wix/Prerequisites.wxi | 8 +- packaging/wix/WiresharkOptionsDlg.wxs | 2 + packaging/wix/windeployqt-to-wix.ps1 | 55 +- pdml2html.xsl | 14 +- plugins/Custom.m4.example | 2 +- plugins/Custom.make.example | 2 +- plugins/Makefile.am | 27 +- plugins/Makefile.am.inc | 33 - plugins/codecs/Makefile.am.inc | 42 + plugins/codecs/l16_mono/AUTHORS | 2 + plugins/codecs/l16_mono/CMakeLists.txt | 68 + plugins/codecs/l16_mono/Makefile.am | 48 + plugins/codecs/l16_mono/README | 3 + plugins/codecs/l16_mono/l16decode.c | 83 + plugins/docsis/AUTHORS | 3 - plugins/docsis/CMakeLists.txt | 83 - plugins/docsis/ChangeLog | 15 - plugins/docsis/Makefile.am | 71 - plugins/docsis/README | 52 - plugins/docsis/packet-docsis.c | 1189 -- plugins/docsis/packet-macmgmt.c | 8619 ---------- plugins/docsis/packet-tlv.c | 6530 -------- plugins/docsis/packet-tlv.h | 484 - plugins/docsis/packet-vendor.c | 899 - plugins/epan/Makefile.am.inc | 43 + plugins/{ => epan}/ethercat/AUTHORS | 0 plugins/epan/ethercat/CMakeLists.txt | 71 + plugins/epan/ethercat/Makefile.am | 77 + plugins/epan/ethercat/packet-ams.c | 1245 ++ plugins/epan/ethercat/packet-ams.h | 1153 ++ plugins/epan/ethercat/packet-ecatmb.c | 1987 +++ plugins/epan/ethercat/packet-ecatmb.h | 471 + plugins/epan/ethercat/packet-esl.c | 371 + plugins/epan/ethercat/packet-ethercat-datagram.c | 3739 +++++ plugins/epan/ethercat/packet-ethercat-datagram.h | 36 + plugins/epan/ethercat/packet-ethercat-frame.c | 153 + plugins/epan/ethercat/packet-ethercat-frame.h | 33 + plugins/epan/ethercat/packet-ioraw.c | 120 + plugins/epan/ethercat/packet-ioraw.h | 21 + plugins/epan/ethercat/packet-nv.c | 241 + plugins/epan/ethercat/packet-nv.h | 34 + plugins/epan/gryphon/AUTHORS | 8 + plugins/epan/gryphon/CMakeLists.txt | 65 + plugins/epan/gryphon/Makefile.am | 66 + plugins/epan/gryphon/README | 11 + plugins/epan/gryphon/packet-gryphon.c | 5155 ++++++ plugins/epan/gryphon/packet-gryphon.h | 600 + plugins/epan/irda/CMakeLists.txt | 67 + plugins/epan/irda/Makefile.am | 74 + plugins/epan/irda/irda-appl.h | 87 + plugins/epan/irda/packet-ircomm.c | 424 + plugins/epan/irda/packet-irda.c | 2247 +++ plugins/epan/irda/packet-sir.c | 236 + plugins/{ => epan}/mate/AUTHORS | 0 plugins/epan/mate/CMakeLists.txt | 85 + plugins/epan/mate/Makefile.am | 129 + plugins/{ => epan}/mate/examples/call.mate | 0 plugins/{ => epan}/mate/examples/mms.mate | 0 plugins/{ => epan}/mate/examples/pasv_ftp.mate | 0 plugins/{ => epan}/mate/examples/tcp.mate | 0 plugins/{ => epan}/mate/examples/web.mate | 0 plugins/epan/mate/mate.h | 376 + plugins/epan/mate/mate_grammar.lemon | 720 + plugins/epan/mate/mate_parser.l | 404 + plugins/epan/mate/mate_runtime.c | 924 + plugins/epan/mate/mate_setup.c | 658 + plugins/epan/mate/mate_util.c | 1688 ++ plugins/epan/mate/mate_util.h | 249 + plugins/{ => epan}/mate/matelib/dns.mate | 0 plugins/{ => epan}/mate/matelib/h225_ras.mate | 0 plugins/{ => epan}/mate/matelib/isup.mate | 0 plugins/{ => epan}/mate/matelib/megaco.mate | 0 plugins/{ => epan}/mate/matelib/q931.mate | 0 plugins/{ => epan}/mate/matelib/radius.mate | 0 plugins/{ => epan}/mate/matelib/rtsp.mate | 0 plugins/{ => epan}/mate/matelib/sip.mate | 0 plugins/epan/mate/packet-mate.c | 400 + plugins/{ => epan}/opcua/AUTHORS | 0 plugins/epan/opcua/CMakeLists.txt | 82 + plugins/{ => epan}/opcua/ChangeLog | 0 plugins/{ => epan}/opcua/Doxyfile | 0 plugins/epan/opcua/Makefile.am | 91 + plugins/{ => epan}/opcua/README | 0 plugins/epan/opcua/opcua.c | 435 + plugins/epan/opcua/opcua_application_layer.c | 112 + plugins/epan/opcua/opcua_application_layer.h | 20 + plugins/epan/opcua/opcua_complextypeparser.c | 2264 +++ plugins/epan/opcua/opcua_complextypeparser.h | 445 + plugins/epan/opcua/opcua_enumparser.c | 664 + plugins/epan/opcua/opcua_enumparser.h | 81 + plugins/epan/opcua/opcua_extensionobjectids.h | 159 + plugins/epan/opcua/opcua_extensionobjecttable.c | 215 + plugins/epan/opcua/opcua_hfindeces.c | 630 + plugins/epan/opcua/opcua_hfindeces.h | 322 + plugins/epan/opcua/opcua_identifiers.h | 43 + plugins/epan/opcua/opcua_security_layer.c | 60 + plugins/epan/opcua/opcua_security_layer.h | 18 + plugins/epan/opcua/opcua_serviceids.h | 187 + plugins/epan/opcua/opcua_serviceparser.c | 1317 ++ plugins/epan/opcua/opcua_serviceparser.h | 273 + plugins/epan/opcua/opcua_servicetable.c | 300 + plugins/epan/opcua/opcua_servicetable.h | 17 + plugins/epan/opcua/opcua_simpletypes.c | 1350 ++ plugins/epan/opcua/opcua_simpletypes.h | 105 + plugins/epan/opcua/opcua_statuscode.c | 267 + plugins/epan/opcua/opcua_statuscode.h | 16 + plugins/epan/opcua/opcua_transport_layer.c | 233 + plugins/epan/opcua/opcua_transport_layer.h | 26 + plugins/{ => epan}/pluginifdemo/AUTHORS | 0 plugins/epan/pluginifdemo/CMakeLists.txt | 65 + plugins/epan/pluginifdemo/Makefile.am | 66 + plugins/{ => epan}/pluginifdemo/README | 0 plugins/epan/pluginifdemo/pluginifdemo.c | 145 + plugins/epan/pluginifdemo/pluginifdemo.h | 11 + .../epan/pluginifdemo/ui/pluginifdemo_about.cpp | 49 + plugins/epan/pluginifdemo/ui/pluginifdemo_about.h | 53 + .../pluginifdemo/ui/pluginifdemo_about.ui | 0 plugins/epan/pluginifdemo/ui/pluginifdemo_main.cpp | 382 + plugins/epan/pluginifdemo/ui/pluginifdemo_main.h | 124 + .../pluginifdemo/ui/pluginifdemo_main.ui | 0 plugins/epan/pluginifdemo/ui/uiclasshandler.cpp | 116 + plugins/epan/pluginifdemo/ui/uihandler.cpp | 69 + plugins/epan/pluginifdemo/ui/uihandler.h | 89 + plugins/{ => epan}/profinet/AUTHORS | 0 plugins/epan/profinet/CMakeLists.txt | 80 + plugins/{ => epan}/profinet/ChangeLog | 0 plugins/epan/profinet/Makefile.am | 76 + plugins/epan/profinet/packet-dcerpc-pn-io.c | 15157 +++++++++++++++++ plugins/epan/profinet/packet-dcom-cba-acco.c | 5158 ++++++ plugins/epan/profinet/packet-dcom-cba-acco.h | 59 + plugins/epan/profinet/packet-dcom-cba.c | 1730 ++ plugins/epan/profinet/packet-pn-dcp.c | 1388 ++ plugins/epan/profinet/packet-pn-mrp.c | 668 + plugins/epan/profinet/packet-pn-mrrt.c | 247 + plugins/epan/profinet/packet-pn-ptcp.c | 1093 ++ plugins/epan/profinet/packet-pn-rt.c | 1159 ++ plugins/epan/profinet/packet-pn-rtc-one.c | 1091 ++ plugins/epan/profinet/packet-pn.c | 382 + plugins/epan/profinet/packet-pn.h | 162 + plugins/{ => epan}/stats_tree/AUTHORS | 0 plugins/epan/stats_tree/CMakeLists.txt | 54 + plugins/epan/stats_tree/Makefile.am | 55 + plugins/epan/stats_tree/pinfo_stats_tree.c | 323 + plugins/epan/stats_tree/pinfo_stats_tree.h | 13 + plugins/epan/stats_tree/stats_tree_plugin.c | 47 + plugins/{ => epan}/transum/AUTHORS | 0 plugins/epan/transum/CMakeLists.txt | 73 + plugins/epan/transum/Makefile.am | 71 + plugins/{ => epan}/transum/README | 0 plugins/epan/transum/decoders.c | 324 + plugins/epan/transum/decoders.h | 32 + plugins/epan/transum/extractors.c | 141 + plugins/epan/transum/extractors.h | 21 + plugins/epan/transum/packet-transum.c | 1360 ++ plugins/epan/transum/packet-transum.h | 189 + plugins/epan/transum/preferences.h | 42 + plugins/{ => epan}/unistim/AUTHORS | 0 plugins/epan/unistim/CMakeLists.txt | 65 + plugins/{ => epan}/unistim/ChangeLog | 0 plugins/epan/unistim/Makefile.am | 75 + plugins/{ => epan}/unistim/TODO | 0 plugins/epan/unistim/audio.h | 560 + plugins/epan/unistim/basic.h | 71 + plugins/epan/unistim/broadcast.h | 88 + plugins/epan/unistim/defines.h | 228 + plugins/epan/unistim/display.h | 261 + plugins/epan/unistim/expansion.h | 27 + plugins/epan/unistim/key.h | 152 + plugins/epan/unistim/network.h | 221 + plugins/epan/unistim/packet-unistim.c | 4047 +++++ plugins/epan/unistim/packet-unistim.h | 37 + plugins/epan/unistim/uftp.h | 34 + plugins/{ => epan}/wimax/AUTHORS | 0 plugins/epan/wimax/CMakeLists.txt | 113 + plugins/epan/wimax/Makefile.am | 116 + plugins/{ => epan}/wimax/README.wimax | 0 plugins/epan/wimax/crc.c | 198 + plugins/epan/wimax/crc.h | 33 + plugins/epan/wimax/crc_data.c | 171 + plugins/epan/wimax/mac_hd_generic_decoder.c | 2300 +++ plugins/epan/wimax/mac_hd_type1_decoder.c | 560 + plugins/epan/wimax/mac_hd_type2_decoder.c | 1370 ++ plugins/epan/wimax/mac_mgmt_msg_decoder.c | 367 + plugins/epan/wimax/msg_aas_beam.c | 341 + plugins/epan/wimax/msg_aas_fbck.c | 349 + plugins/epan/wimax/msg_arq.c | 443 + plugins/epan/wimax/msg_clk_cmp.c | 150 + plugins/epan/wimax/msg_dcd.c | 1251 ++ plugins/epan/wimax/msg_dlmap.c | 3474 ++++ plugins/epan/wimax/msg_dreg.c | 527 + plugins/epan/wimax/msg_dsa.c | 183 + plugins/epan/wimax/msg_dsc.c | 186 + plugins/epan/wimax/msg_dsd.c | 278 + plugins/epan/wimax/msg_dsx_rvd.c | 107 + plugins/epan/wimax/msg_fpc.c | 166 + plugins/epan/wimax/msg_pkm.c | 177 + plugins/epan/wimax/msg_pmc.c | 246 + plugins/epan/wimax/msg_prc_lt_ctrl.c | 136 + plugins/epan/wimax/msg_reg_req.c | 1440 ++ plugins/epan/wimax/msg_reg_rsp.c | 367 + plugins/epan/wimax/msg_rep.c | 1564 ++ plugins/epan/wimax/msg_res_cmd.c | 154 + plugins/epan/wimax/msg_rng_req.c | 631 + plugins/epan/wimax/msg_rng_rsp.c | 963 ++ plugins/epan/wimax/msg_sbc.c | 2837 ++++ plugins/epan/wimax/msg_ucd.c | 1243 ++ plugins/epan/wimax/msg_ulmap.c | 2942 ++++ plugins/epan/wimax/packet-m2m.c | 809 + plugins/epan/wimax/packet-wmx.c | 366 + plugins/epan/wimax/wimax-int.h | 30 + plugins/epan/wimax/wimax_bits.h | 194 + plugins/epan/wimax/wimax_cdma_code_decoder.c | 116 + .../epan/wimax/wimax_compact_dlmap_ie_decoder.c | 2111 +++ .../epan/wimax/wimax_compact_dlmap_ie_decoder.h | 20 + .../epan/wimax/wimax_compact_ulmap_ie_decoder.c | 2125 +++ .../epan/wimax/wimax_compact_ulmap_ie_decoder.h | 20 + plugins/epan/wimax/wimax_fch_decoder.c | 246 + plugins/epan/wimax/wimax_ffb_decoder.c | 129 + plugins/epan/wimax/wimax_hack_decoder.c | 141 + plugins/epan/wimax/wimax_harq_map_decoder.c | 230 + plugins/epan/wimax/wimax_mac.h | 689 + plugins/epan/wimax/wimax_pdu_decoder.c | 255 + plugins/epan/wimax/wimax_phy_attributes_decoder.c | 178 + plugins/epan/wimax/wimax_tlv.c | 175 + plugins/epan/wimax/wimax_tlv.h | 45 + plugins/epan/wimax/wimax_utils.c | 3395 ++++ plugins/epan/wimax/wimax_utils.h | 58 + plugins/{ => epan}/wimaxasncp/AUTHORS | 0 plugins/epan/wimaxasncp/CMakeLists.txt | 71 + plugins/{ => epan}/wimaxasncp/ChangeLog | 0 plugins/epan/wimaxasncp/Makefile.am | 100 + plugins/epan/wimaxasncp/packet-wimaxasncp.c | 3452 ++++ plugins/epan/wimaxasncp/wimaxasncp_dict.h | 114 + plugins/epan/wimaxasncp/wimaxasncp_dict.l | 867 + plugins/{ => epan}/wimaxmacphy/AUTHORS | 0 plugins/epan/wimaxmacphy/CMakeLists.txt | 65 + plugins/{ => epan}/wimaxmacphy/ChangeLog | 0 plugins/epan/wimaxmacphy/Makefile.am | 66 + plugins/epan/wimaxmacphy/packet-wimaxmacphy.c | 5446 ++++++ plugins/epan/wimaxmacphy/packet-wimaxmacphy.h | 18 + plugins/ethercat/CMakeLists.txt | 85 - plugins/ethercat/Makefile.am | 77 - plugins/ethercat/packet-ams.c | 1257 -- plugins/ethercat/packet-ams.h | 1165 -- plugins/ethercat/packet-ecatmb.c | 1999 --- plugins/ethercat/packet-ecatmb.h | 483 - plugins/ethercat/packet-esl.c | 383 - plugins/ethercat/packet-ethercat-datagram.c | 3751 ----- plugins/ethercat/packet-ethercat-datagram.h | 48 - plugins/ethercat/packet-ethercat-frame.c | 164 - plugins/ethercat/packet-ethercat-frame.h | 45 - plugins/ethercat/packet-ioraw.c | 132 - plugins/ethercat/packet-ioraw.h | 33 - plugins/ethercat/packet-nv.c | 253 - plugins/ethercat/packet-nv.h | 46 - plugins/gryphon/AUTHORS | 5 - plugins/gryphon/CMakeLists.txt | 79 - plugins/gryphon/Makefile.am | 66 - plugins/gryphon/README | 9 - plugins/gryphon/packet-gryphon.c | 2866 ---- plugins/gryphon/packet-gryphon.h | 462 - plugins/irda/CMakeLists.txt | 81 - plugins/irda/Makefile.am | 74 - plugins/irda/irda-appl.h | 99 - plugins/irda/packet-ircomm.c | 436 - plugins/irda/packet-irda.c | 2259 --- plugins/irda/packet-sir.c | 248 - plugins/mate/CMakeLists.txt | 105 - plugins/mate/Makefile.am | 129 - plugins/mate/mate.h | 388 - plugins/mate/mate_grammar.lemon | 732 - plugins/mate/mate_parser.l | 404 - plugins/mate/mate_runtime.c | 936 -- plugins/mate/mate_setup.c | 670 - plugins/mate/mate_util.c | 1697 -- plugins/mate/mate_util.h | 261 - plugins/mate/packet-mate.c | 412 - plugins/opcua/CMakeLists.txt | 96 - plugins/opcua/Makefile.am | 91 - plugins/opcua/opcua.c | 438 - plugins/opcua/opcua_application_layer.c | 115 - plugins/opcua/opcua_application_layer.h | 23 - plugins/opcua/opcua_complextypeparser.c | 2267 --- plugins/opcua/opcua_complextypeparser.h | 448 - plugins/opcua/opcua_enumparser.c | 667 - plugins/opcua/opcua_enumparser.h | 84 - plugins/opcua/opcua_extensionobjectids.h | 162 - plugins/opcua/opcua_extensionobjecttable.c | 218 - plugins/opcua/opcua_hfindeces.c | 633 - plugins/opcua/opcua_hfindeces.h | 325 - plugins/opcua/opcua_identifiers.h | 46 - plugins/opcua/opcua_security_layer.c | 63 - plugins/opcua/opcua_security_layer.h | 21 - plugins/opcua/opcua_serviceids.h | 190 - plugins/opcua/opcua_serviceparser.c | 1320 -- plugins/opcua/opcua_serviceparser.h | 276 - plugins/opcua/opcua_servicetable.c | 303 - plugins/opcua/opcua_servicetable.h | 20 - plugins/opcua/opcua_simpletypes.c | 1353 -- plugins/opcua/opcua_simpletypes.h | 108 - plugins/opcua/opcua_statuscode.c | 270 - plugins/opcua/opcua_statuscode.h | 19 - plugins/opcua/opcua_transport_layer.c | 236 - plugins/opcua/opcua_transport_layer.h | 29 - plugins/pluginifdemo/CMakeLists.txt | 83 - plugins/pluginifdemo/Makefile.am | 66 - plugins/pluginifdemo/pluginifdemo.c | 157 - plugins/pluginifdemo/pluginifdemo.h | 23 - plugins/pluginifdemo/ui/pluginifdemo_about.cpp | 61 - plugins/pluginifdemo/ui/pluginifdemo_about.h | 65 - plugins/pluginifdemo/ui/pluginifdemo_main.cpp | 394 - plugins/pluginifdemo/ui/pluginifdemo_main.h | 136 - plugins/pluginifdemo/ui/uiclasshandler.cpp | 128 - plugins/pluginifdemo/ui/uihandler.cpp | 81 - plugins/pluginifdemo/ui/uihandler.h | 101 - plugins/profinet/CMakeLists.txt | 94 - plugins/profinet/Makefile.am | 76 - plugins/profinet/packet-dcerpc-pn-io.c | 15163 ----------------- plugins/profinet/packet-dcom-cba-acco.c | 5170 ------ plugins/profinet/packet-dcom-cba-acco.h | 71 - plugins/profinet/packet-dcom-cba.c | 1742 -- plugins/profinet/packet-pn-dcp.c | 1400 -- plugins/profinet/packet-pn-mrp.c | 680 - plugins/profinet/packet-pn-mrrt.c | 259 - plugins/profinet/packet-pn-ptcp.c | 1105 -- plugins/profinet/packet-pn-rt.c | 1171 -- plugins/profinet/packet-pn-rtc-one.c | 1103 -- plugins/profinet/packet-pn.c | 394 - plugins/profinet/packet-pn.h | 174 - plugins/stats_tree/CMakeLists.txt | 68 - plugins/stats_tree/Makefile.am | 55 - plugins/stats_tree/pinfo_stats_tree.c | 335 - plugins/stats_tree/pinfo_stats_tree.h | 25 - plugins/stats_tree/stats_tree_plugin.c | 57 - plugins/transum/CMakeLists.txt | 87 - plugins/transum/Makefile.am | 71 - plugins/transum/decoders.c | 336 - plugins/transum/decoders.h | 44 - plugins/transum/extractors.c | 153 - plugins/transum/extractors.h | 33 - plugins/transum/packet-transum.c | 1372 -- plugins/transum/packet-transum.h | 201 - plugins/transum/preferences.h | 54 - plugins/unistim/CMakeLists.txt | 79 - plugins/unistim/Makefile.am | 75 - plugins/unistim/audio.h | 572 - plugins/unistim/basic.h | 83 - plugins/unistim/broadcast.h | 100 - plugins/unistim/defines.h | 240 - plugins/unistim/display.h | 273 - plugins/unistim/expansion.h | 39 - plugins/unistim/key.h | 164 - plugins/unistim/network.h | 233 - plugins/unistim/packet-unistim.c | 4059 ----- plugins/unistim/packet-unistim.h | 49 - plugins/unistim/uftp.h | 46 - plugins/wimax/CMakeLists.txt | 127 - plugins/wimax/Makefile.am | 116 - plugins/wimax/crc.c | 210 - plugins/wimax/crc.h | 45 - plugins/wimax/crc_data.c | 183 - plugins/wimax/mac_hd_generic_decoder.c | 2312 --- plugins/wimax/mac_hd_type1_decoder.c | 572 - plugins/wimax/mac_hd_type2_decoder.c | 1382 -- plugins/wimax/mac_mgmt_msg_decoder.c | 379 - plugins/wimax/msg_aas_beam.c | 353 - plugins/wimax/msg_aas_fbck.c | 361 - plugins/wimax/msg_arq.c | 455 - plugins/wimax/msg_clk_cmp.c | 162 - plugins/wimax/msg_dcd.c | 1263 -- plugins/wimax/msg_dlmap.c | 3486 ---- plugins/wimax/msg_dreg.c | 539 - plugins/wimax/msg_dsa.c | 195 - plugins/wimax/msg_dsc.c | 198 - plugins/wimax/msg_dsd.c | 290 - plugins/wimax/msg_dsx_rvd.c | 119 - plugins/wimax/msg_fpc.c | 178 - plugins/wimax/msg_pkm.c | 189 - plugins/wimax/msg_pmc.c | 258 - plugins/wimax/msg_prc_lt_ctrl.c | 148 - plugins/wimax/msg_reg_req.c | 1452 -- plugins/wimax/msg_reg_rsp.c | 379 - plugins/wimax/msg_rep.c | 1576 -- plugins/wimax/msg_res_cmd.c | 166 - plugins/wimax/msg_rng_req.c | 643 - plugins/wimax/msg_rng_rsp.c | 975 -- plugins/wimax/msg_sbc.c | 2849 ---- plugins/wimax/msg_ucd.c | 1255 -- plugins/wimax/msg_ulmap.c | 2954 ---- plugins/wimax/packet-m2m.c | 821 - plugins/wimax/packet-wmx.c | 365 - plugins/wimax/wimax-int.h | 39 - plugins/wimax/wimax_bits.h | 206 - plugins/wimax/wimax_cdma_code_decoder.c | 128 - plugins/wimax/wimax_compact_dlmap_ie_decoder.c | 2123 --- plugins/wimax/wimax_compact_dlmap_ie_decoder.h | 32 - plugins/wimax/wimax_compact_ulmap_ie_decoder.c | 2137 --- plugins/wimax/wimax_compact_ulmap_ie_decoder.h | 32 - plugins/wimax/wimax_fch_decoder.c | 258 - plugins/wimax/wimax_ffb_decoder.c | 141 - plugins/wimax/wimax_hack_decoder.c | 153 - plugins/wimax/wimax_harq_map_decoder.c | 242 - plugins/wimax/wimax_mac.h | 701 - plugins/wimax/wimax_pdu_decoder.c | 267 - plugins/wimax/wimax_phy_attributes_decoder.c | 190 - plugins/wimax/wimax_tlv.c | 187 - plugins/wimax/wimax_tlv.h | 57 - plugins/wimax/wimax_utils.c | 3407 ---- plugins/wimax/wimax_utils.h | 70 - plugins/wimaxasncp/CMakeLists.txt | 86 - plugins/wimaxasncp/Makefile.am | 100 - plugins/wimaxasncp/packet-wimaxasncp.c | 3464 ---- plugins/wimaxasncp/wimaxasncp_dict.h | 127 - plugins/wimaxasncp/wimaxasncp_dict.l | 866 - plugins/wimaxmacphy/CMakeLists.txt | 79 - plugins/wimaxmacphy/Makefile.am | 66 - plugins/wimaxmacphy/packet-wimaxmacphy.c | 5459 ------ plugins/wimaxmacphy/packet-wimaxmacphy.h | 30 - plugins/wiretap/Makefile.am.inc | 42 + plugins/wiretap/usbdump/AUTHORS | 2 + plugins/wiretap/usbdump/CMakeLists.txt | 68 + plugins/wiretap/usbdump/Makefile.am | 48 + plugins/wiretap/usbdump/README | 3 + plugins/wiretap/usbdump/usbdump.c | 351 + radius/dictionary.zte | 6 +- randpkt.c | 4 +- randpkt_core/CMakeLists.txt | 20 +- randpkt_core/randpkt_core.c | 39 +- randpkt_core/randpkt_core.h | 15 +- rawshark.c | 70 +- reordercap.c | 30 +- ringbuffer.c | 2 +- ringbuffer.h | 2 +- services | 20 +- sharkd.c | 88 +- sharkd.h | 8 +- sharkd_daemon.c | 2 +- sharkd_session.c | 155 +- summary.c | 230 - summary.h | 94 - sync_pipe.h | 2 +- sync_pipe_write.c | 2 +- test/config.sh | 14 +- test/lua/acme_file.lua | 6 +- test/run_and_catch_crashes | 14 +- test/suite-capture.sh | 14 +- test/suite-clopts.sh | 27 +- test/suite-decryption.sh | 14 +- test/suite-dissection.sh | 14 +- test/suite-fileformats.sh | 38 +- test/suite-io.sh | 16 +- test/suite-mergecap.sh | 14 +- test/suite-nameres.sh | 14 +- test/suite-text2pcap.sh | 14 +- test/suite-unittests.sh | 14 +- test/suite-wslua.sh | 14 +- test/test-backend.sh | 14 +- test/test.sh | 14 +- text2pcap-scanner.l | 42 +- text2pcap.c | 11 +- text2pcap.h | 6 +- tfshark.c | 166 +- tools/Get-HardenFlags.ps1 | 16 +- tools/Makefile.am | 1 - tools/WiresharkXML.py | 14 +- tools/asn2deb | 14 +- tools/asn2wrs.py | 25 +- tools/checkAPIs.pl | 15 +- tools/checkfiltername.pl | 16 +- tools/checkhf.pl | 14 +- tools/checklicenses.py | 59 +- tools/colorfilters2js.pl | 14 +- tools/commit-msg | 12 +- tools/compare-abis.sh | 14 +- tools/compress-pngs.sh | 14 +- tools/convert_expert_add_info_format.pl | 14 +- tools/convert_proto_tree_add_text.pl | 14 +- tools/cppcheck/cppcheck.sh | 14 +- tools/debian-nightly-package.sh | 14 +- tools/debian-setup.sh | 25 +- tools/delete_includes.py | 14 +- tools/dfilter-test.py | 14 +- tools/dftestlib/__init__.py | 14 +- tools/dftestlib/bytes_ether.py | 14 +- tools/dftestlib/bytes_ipv6.py | 14 +- tools/dftestlib/bytes_type.py | 14 +- tools/dftestlib/dftest.py | 14 +- tools/dftestlib/double.py | 14 +- tools/dftestlib/integer.py | 14 +- tools/dftestlib/integer_1byte.py | 14 +- tools/dftestlib/ipv4.py | 14 +- tools/dftestlib/range_method.py | 14 +- tools/dftestlib/scanner.py | 14 +- tools/dftestlib/string_type.py | 14 +- tools/dftestlib/stringz.py | 14 +- tools/dftestlib/time_relative.py | 14 +- tools/dftestlib/time_type.py | 14 +- tools/dftestlib/tvb.py | 14 +- tools/dftestlib/uint64.py | 14 +- tools/dftestlib/util.py | 14 +- tools/extract_asn1_from_spec.pl | 18 +- tools/fix-encoding-args.pl | 14 +- tools/fixhf.pl | 14 +- tools/ftsanity.py | 14 +- tools/fuzz-test.sh | 31 +- tools/gen-bugnote | 16 +- tools/generate-bacnet-vendors.py | 14 +- tools/generate-nl80211-fields.py | 14 +- tools/generate-sysdig-event.py | 14 +- tools/generate_authors.pl | 14 +- tools/git-compare-abis.sh | 14 +- tools/git-export-release.sh | 14 +- tools/html2text.py | 57 +- tools/idl2deb | 14 +- tools/indexcap.py | 14 +- tools/install_rpms_for_devel.sh | 22 +- tools/json2pcap/json2pcap.py | 14 +- tools/lemon/CMakeLists.txt | 20 +- tools/lex.py | 25 +- tools/licensecheck.pl | 1099 +- tools/list_protos_in_cap.sh | 14 +- tools/macos-setup-brew.sh | 14 +- tools/macos-setup.sh | 102 +- tools/make-pixbuf-csource.pl | 14 +- tools/make-plugin-reg.py | 32 +- tools/make-services.py | 14 +- tools/make-sminmpec.pl | 14 +- tools/make-usb.py | 14 +- tools/msnchat | 14 +- tools/ncp2222.py | 14 +- tools/netscreen2dump.py | 14 +- tools/npl/ast.h | 14 +- tools/npl/npl.c | 14 +- tools/npl/parser.l | 14 +- tools/npl/xmem.h | 14 +- tools/oss-fuzzshark/FuzzerInterface.h | 18 +- tools/oss-fuzzshark/StandaloneFuzzTargetMain.c | 18 +- tools/oss-fuzzshark/build.sh | 23 +- tools/oss-fuzzshark/fuzzshark.c | 121 +- tools/parse_xml2skinny_dissector.py | 14 +- tools/pidl/lib/Parse/Pidl/Samba4/Template.pm | 13 +- tools/pkt-from-core.py | 14 +- tools/pre-commit | 6 +- tools/pre-commit-ignore.conf | 2 + tools/pre-commit-ignore.py | 14 +- tools/process-x11-fields.pl | 14 +- tools/process-x11-xcb.pl | 14 +- tools/rdps.py | 28 +- tools/release-update-debian-soversions.sh | 14 +- tools/rpm_setup.sh | 23 +- tools/runa2x.sh | 53 - tools/test-captures.sh | 14 +- tools/test-common.sh | 14 +- tools/textify.ps1 | 14 +- tools/update-tx | 24 +- tools/usb-ptp-extract-models.pl | 14 +- tools/valgrind-wireshark.sh | 16 +- tools/validate-diameter-xml.sh | 14 +- tools/win-setup.ps1 | 23 +- tools/wireshark_be.py | 14 +- tools/wireshark_gen.py | 14 +- tools/yacc.py | 25 +- trigcap.c | 2 +- tshark.c | 163 +- ui/CMakeLists.txt | 48 +- ui/Makefile.am | 6 +- ui/alert_box.c | 32 +- ui/alert_box.h | 15 +- ui/all_files_wildcard.h | 15 +- ui/capture.c | 45 +- ui/capture.h | 5 +- ui/capture_globals.h | 15 +- ui/capture_ui_utils.c | 2 +- ui/capture_ui_utils.h | 2 +- ui/cli/tap-camelsrt.c | 15 +- ui/cli/tap-comparestat.c | 22 +- ui/cli/tap-diameter-avp.c | 15 +- ui/cli/tap-endpoints.c | 15 +- ui/cli/tap-expert.c | 14 +- ui/cli/tap-exportobject.c | 17 +- ui/cli/tap-exportobject.h | 15 +- ui/cli/tap-flow.c | 21 +- ui/cli/tap-follow.c | 21 +- ui/cli/tap-funnel.c | 15 +- ui/cli/tap-gsm_astat.c | 15 +- ui/cli/tap-hosts.c | 15 +- ui/cli/tap-httpstat.c | 40 +- ui/cli/tap-icmpstat.c | 15 +- ui/cli/tap-icmpv6stat.c | 15 +- ui/cli/tap-iostat.c | 17 +- ui/cli/tap-iousers.c | 15 +- ui/cli/tap-macltestat.c | 14 +- ui/cli/tap-protocolinfo.c | 15 +- ui/cli/tap-protohierstat.c | 15 +- ui/cli/tap-rlcltestat.c | 14 +- ui/cli/tap-rpcprogs.c | 15 +- ui/cli/tap-rtd.c | 21 +- ui/cli/tap-rtp.c | 15 +- ui/cli/tap-rtspstat.c | 44 +- ui/cli/tap-sctpchunkstat.c | 15 +- ui/cli/tap-simple_stattable.c | 49 +- ui/cli/tap-sipstat.c | 35 +- ui/cli/tap-smbsids.c | 15 +- ui/cli/tap-srt.c | 21 +- ui/cli/tap-stats_tree.c | 15 +- ui/cli/tap-sv.c | 15 +- ui/cli/tap-wspstat.c | 27 +- ui/cli/tshark-tap.h | 15 +- ui/commandline.c | 43 +- ui/commandline.h | 18 +- ui/console.c | 15 +- ui/console.h | 15 +- ui/decode_as_utils.c | 61 +- ui/decode_as_utils.h | 15 +- ui/dissect_opts.c | 15 +- ui/dissect_opts.h | 15 +- ui/export_object_ui.c | 15 +- ui/export_object_ui.h | 15 +- ui/export_pdu_ui_utils.c | 17 +- ui/export_pdu_ui_utils.h | 17 +- ui/failure_message.c | 55 +- ui/failure_message.h | 15 +- ui/file_dialog.c | 108 + ui/file_dialog.h | 39 +- ui/filter_files.c | 15 +- ui/filter_files.h | 15 +- ui/firewall_rules.c | 88 +- ui/firewall_rules.h | 14 +- ui/gtk/CMakeLists.txt | 40 +- ui/gtk/Makefile.am | 37 +- ui/gtk/about_dlg.c | 10 +- ui/gtk/airpcap_gui_utils.c | 84 +- ui/gtk/capture_dlg.c | 79 +- ui/gtk/capture_file_dlg.c | 139 +- ui/gtk/capture_if_dlg.c | 2 - ui/gtk/decode_as_dlg.c | 6 +- ui/gtk/expert_comp_dlg.c | 8 +- ui/gtk/export_pdu_dlg.c | 2 +- ui/gtk/fileset_dlg.c | 2 +- ui/gtk/firewall_dlg.c | 3 +- ui/gtk/gsm_map_summary.c | 2 +- ui/gtk/gui_utils.c | 5 + ui/gtk/hostlist_table.c | 101 - ui/gtk/iax2_analysis.c | 2 +- ui/gtk/main.c | 26 +- ui/gtk/main.gresources.xml | 30 +- ui/gtk/main_airpcap_toolbar.c | 2 +- ui/gtk/main_menubar.c | 37 +- ui/gtk/main_statusbar.c | 12 +- ui/gtk/main_welcome.c | 1 + ui/gtk/mtp3_summary.c | 2 +- ui/gtk/packet_list_store.c | 12 +- ui/gtk/packet_win.c | 12 +- ui/gtk/prefs_capture.c | 46 +- ui/gtk/prefs_dlg.c | 39 +- ui/gtk/prefs_font_color.c | 2 +- ui/gtk/prefs_font_color.h | 2 +- ui/gtk/profile_dlg.c | 5 +- ui/gtk/rtp_analysis.c | 2 +- ui/gtk/sctp_assoc_analyse.c | 2 +- ui/gtk/simple_stattable.c | 52 +- ui/gtk/stock_icons.c | 20 +- ui/gtk/summary_dlg.c | 2 +- ui/gtk/uat_gui.c | 1 + ui/help_url.c | 17 +- ui/help_url.h | 17 +- ui/iface_lists.c | 23 +- ui/iface_lists.h | 15 +- ui/iface_toolbar.c | 15 +- ui/iface_toolbar.h | 15 +- ui/io_graph_item.c | 15 +- ui/io_graph_item.h | 15 +- ui/language.c | 15 +- ui/language.h | 15 +- ui/last_open_dir.h | 15 +- ui/main_statusbar.h | 15 +- ui/make-taps.c | 2 +- ui/mcast_stream.c | 14 +- ui/mcast_stream.h | 14 +- ui/packet_list_utils.c | 45 +- ui/packet_list_utils.h | 15 +- ui/packet_range.c | 15 +- ui/packet_range.h | 15 +- ui/persfilepath_opt.c | 15 +- ui/persfilepath_opt.h | 15 +- ui/preference_utils.c | 28 +- ui/preference_utils.h | 6 +- ui/profile.c | 27 +- ui/profile.h | 18 +- ui/progress_dlg.h | 15 +- ui/proto_hier_stats.c | 12 +- ui/proto_hier_stats.h | 2 +- ui/qt/CMakeLists.txt | 99 +- ui/qt/CMakeListsCustom.txt.example | 14 +- ui/qt/Makefile.am | 84 +- ui/qt/about_dialog.cpp | 198 +- ui/qt/about_dialog.h | 10 +- ui/qt/about_dialog.ui | 86 +- ui/qt/accordion_frame.cpp | 15 +- ui/qt/accordion_frame.h | 15 +- ui/qt/address_editor_frame.cpp | 17 +- ui/qt/address_editor_frame.h | 15 +- ui/qt/bluetooth_att_server_attributes_dialog.cpp | 28 +- ui/qt/bluetooth_att_server_attributes_dialog.h | 15 +- ui/qt/bluetooth_device_dialog.cpp | 15 +- ui/qt/bluetooth_device_dialog.h | 15 +- ui/qt/bluetooth_devices_dialog.cpp | 24 +- ui/qt/bluetooth_devices_dialog.h | 15 +- ui/qt/bluetooth_hci_summary_dialog.cpp | 24 +- ui/qt/bluetooth_hci_summary_dialog.h | 15 +- ui/qt/byte_view_tab.cpp | 149 +- ui/qt/byte_view_tab.h | 27 +- ui/qt/capture_file.cpp | 141 +- ui/qt/capture_file.h | 95 +- ui/qt/capture_file_dialog.cpp | 135 +- ui/qt/capture_file_dialog.h | 15 +- ui/qt/capture_file_properties_dialog.cpp | 25 +- ui/qt/capture_file_properties_dialog.h | 15 +- ui/qt/capture_file_properties_dialog.ui | 3 - ui/qt/capture_filter_syntax_worker.cpp | 25 +- ui/qt/capture_filter_syntax_worker.h | 15 +- ui/qt/capture_info_dialog.cpp | 15 +- ui/qt/capture_info_dialog.h | 15 +- ui/qt/capture_interfaces_dialog.cpp | 25 +- ui/qt/capture_interfaces_dialog.h | 17 +- ui/qt/capture_interfaces_dialog.ui | 2 +- ui/qt/capture_preferences_frame.cpp | 23 +- ui/qt/capture_preferences_frame.h | 21 +- ui/qt/capture_preferences_frame.ui | 11 +- ui/qt/coloring_rules_dialog.cpp | 429 +- ui/qt/coloring_rules_dialog.h | 62 +- ui/qt/coloring_rules_dialog.ui | 44 +- ui/qt/column_editor_frame.cpp | 15 +- ui/qt/column_editor_frame.h | 15 +- ui/qt/column_preferences_frame.cpp | 15 +- ui/qt/column_preferences_frame.h | 15 +- ui/qt/column_preferences_frame.ui | 6 +- ui/qt/compiled_filter_output.cpp | 15 +- ui/qt/compiled_filter_output.h | 15 +- ui/qt/conversation_colorize_action.cpp | 15 +- ui/qt/conversation_colorize_action.h | 15 +- ui/qt/conversation_dialog.cpp | 35 +- ui/qt/conversation_dialog.h | 15 +- ui/qt/conversation_hash_tables_dialog.cpp | 15 +- ui/qt/conversation_hash_tables_dialog.h | 15 +- ui/qt/decode_as_dialog.cpp | 15 +- ui/qt/decode_as_dialog.h | 16 +- ui/qt/decode_as_dialog.ui | 8 +- ui/qt/display_filter_expression_dialog.cpp | 19 +- ui/qt/display_filter_expression_dialog.h | 15 +- ui/qt/dissector_tables_dialog.cpp | 5 +- ui/qt/dissector_tables_dialog.h | 2 +- ui/qt/enabled_protocols_dialog.cpp | 18 +- ui/qt/enabled_protocols_dialog.h | 15 +- ui/qt/endpoint_dialog.cpp | 232 +- ui/qt/endpoint_dialog.h | 40 +- ui/qt/expert_info_dialog.cpp | 46 +- ui/qt/expert_info_dialog.h | 18 +- ui/qt/export_dissection_dialog.cpp | 15 +- ui/qt/export_dissection_dialog.h | 15 +- ui/qt/export_object_action.cpp | 30 +- ui/qt/export_object_action.h | 20 +- ui/qt/export_object_dialog.cpp | 283 +- ui/qt/export_object_dialog.h | 47 +- ui/qt/export_object_dialog.ui | 37 +- ui/qt/export_pdu_dialog.cpp | 17 +- ui/qt/export_pdu_dialog.h | 15 +- ui/qt/extcap_argument.cpp | 15 +- ui/qt/extcap_argument.h | 15 +- ui/qt/extcap_argument_file.cpp | 15 +- ui/qt/extcap_argument_file.h | 15 +- ui/qt/extcap_argument_multiselect.cpp | 15 +- ui/qt/extcap_argument_multiselect.h | 15 +- ui/qt/extcap_options_dialog.cpp | 19 +- ui/qt/extcap_options_dialog.h | 19 +- ui/qt/file_set_dialog.cpp | 3 +- ui/qt/file_set_dialog.h | 4 +- ui/qt/filter_action.cpp | 15 +- ui/qt/filter_action.h | 15 +- ui/qt/filter_dialog.cpp | 15 +- ui/qt/filter_dialog.h | 15 +- ui/qt/filter_dialog.ui | 8 +- ui/qt/filter_expression_frame.cpp | 24 +- ui/qt/filter_expression_frame.h | 17 +- ui/qt/firewall_rules_dialog.cpp | 15 +- ui/qt/firewall_rules_dialog.h | 15 +- ui/qt/follow_stream_dialog.cpp | 31 +- ui/qt/follow_stream_dialog.h | 17 +- ui/qt/font_color_preferences_frame.cpp | 24 +- ui/qt/font_color_preferences_frame.h | 19 +- ui/qt/funnel_statistics.cpp | 17 +- ui/qt/funnel_statistics.h | 15 +- ui/qt/funnel_string_dialog.cpp | 15 +- ui/qt/funnel_string_dialog.h | 15 +- ui/qt/funnel_text_dialog.cpp | 15 +- ui/qt/funnel_text_dialog.h | 15 +- ui/qt/geometry_state_dialog.cpp | 15 +- ui/qt/geometry_state_dialog.h | 15 +- ui/qt/gpl-template.txt | 15 +- ui/qt/gsm_map_summary_dialog.cpp | 17 +- ui/qt/gsm_map_summary_dialog.h | 15 +- ui/qt/iax2_analysis_dialog.cpp | 32 +- ui/qt/iax2_analysis_dialog.h | 16 +- ui/qt/import_text_dialog.cpp | 15 +- ui/qt/import_text_dialog.h | 15 +- ui/qt/interface_frame.cpp | 127 +- ui/qt/interface_frame.h | 23 +- ui/qt/interface_toolbar.cpp | 17 +- ui/qt/interface_toolbar.h | 15 +- ui/qt/interface_toolbar_reader.cpp | 15 +- ui/qt/interface_toolbar_reader.h | 15 +- ui/qt/io_graph_dialog.cpp | 101 +- ui/qt/io_graph_dialog.h | 18 +- ui/qt/io_graph_dialog.ui | 8 +- ui/qt/layout_preferences_frame.cpp | 17 +- ui/qt/layout_preferences_frame.h | 17 +- ui/qt/lbm_lbtrm_transport_dialog.cpp | 15 +- ui/qt/lbm_lbtrm_transport_dialog.h | 15 +- ui/qt/lbm_lbtrm_transport_dialog.ui | 7 +- ui/qt/lbm_lbtru_transport_dialog.cpp | 15 +- ui/qt/lbm_lbtru_transport_dialog.h | 15 +- ui/qt/lbm_lbtru_transport_dialog.ui | 2 +- ui/qt/lbm_stream_dialog.cpp | 15 +- ui/qt/lbm_stream_dialog.h | 15 +- ui/qt/lte_mac_statistics_dialog.cpp | 54 +- ui/qt/lte_mac_statistics_dialog.h | 17 +- ui/qt/lte_rlc_graph_dialog.cpp | 29 +- ui/qt/lte_rlc_graph_dialog.h | 15 +- ui/qt/lte_rlc_statistics_dialog.cpp | 138 +- ui/qt/lte_rlc_statistics_dialog.h | 17 +- ui/qt/main_status_bar.cpp | 251 +- ui/qt/main_status_bar.h | 28 +- ui/qt/main_welcome.cpp | 20 +- ui/qt/main_welcome.h | 20 +- ui/qt/main_window.cpp | 160 +- ui/qt/main_window.h | 31 +- ui/qt/main_window.ui | 73 +- ui/qt/main_window_preferences_frame.cpp | 15 +- ui/qt/main_window_preferences_frame.h | 16 +- ui/qt/main_window_slots.cpp | 326 +- ui/qt/manage_interfaces_dialog.cpp | 70 +- ui/qt/manage_interfaces_dialog.h | 15 +- ui/qt/manage_interfaces_dialog.ui | 10 +- ui/qt/manager/preference_manager.cpp | 82 + ui/qt/manager/preference_manager.h | 80 + ui/qt/manager/wireshark_preference.cpp | 241 + ui/qt/manager/wireshark_preference.h | 39 + ui/qt/models/astringlist_list_model.cpp | 29 +- ui/qt/models/astringlist_list_model.h | 7 +- ui/qt/models/cache_proxy_model.cpp | 15 +- ui/qt/models/cache_proxy_model.h | 15 +- ui/qt/models/coloring_rules_delegate.cpp | 134 + ui/qt/models/coloring_rules_delegate.h | 42 + ui/qt/models/coloring_rules_model.cpp | 557 + ui/qt/models/coloring_rules_model.h | 98 + ui/qt/models/decode_as_delegate.cpp | 15 +- ui/qt/models/decode_as_delegate.h | 15 +- ui/qt/models/decode_as_model.cpp | 25 +- ui/qt/models/decode_as_model.h | 25 +- ui/qt/models/dissector_tables_model.cpp | 84 +- ui/qt/models/dissector_tables_model.h | 21 +- ui/qt/models/enabled_protocols_model.cpp | 71 +- ui/qt/models/enabled_protocols_model.h | 26 +- ui/qt/models/expert_info_model.cpp | 2 +- ui/qt/models/expert_info_model.h | 2 +- ui/qt/models/expert_info_proxy_model.cpp | 2 +- ui/qt/models/expert_info_proxy_model.h | 2 +- ui/qt/models/export_objects_model.cpp | 285 + ui/qt/models/export_objects_model.h | 81 + ui/qt/models/fileset_entry_model.cpp | 4 +- ui/qt/models/fileset_entry_model.h | 3 +- ui/qt/models/html_text_delegate.cpp | 66 - ui/qt/models/html_text_delegate.h | 48 - ui/qt/models/info_proxy_model.cpp | 142 + ui/qt/models/info_proxy_model.h | 61 + ui/qt/models/interface_sort_filter_model.cpp | 17 +- ui/qt/models/interface_sort_filter_model.h | 15 +- ui/qt/models/interface_tree_cache_model.cpp | 28 +- ui/qt/models/interface_tree_cache_model.h | 15 +- ui/qt/models/interface_tree_model.cpp | 25 +- ui/qt/models/interface_tree_model.h | 17 +- ui/qt/models/numeric_value_chooser_delegate.cpp | 19 +- ui/qt/models/numeric_value_chooser_delegate.h | 15 +- ui/qt/models/packet_list_model.cpp | 30 +- ui/qt/models/packet_list_model.h | 15 +- ui/qt/models/packet_list_record.cpp | 25 +- ui/qt/models/packet_list_record.h | 15 +- ui/qt/models/path_chooser_delegate.cpp | 20 +- ui/qt/models/path_chooser_delegate.h | 15 +- ui/qt/models/percent_bar_delegate.cpp | 15 +- ui/qt/models/percent_bar_delegate.h | 15 +- ui/qt/models/pref_delegate.cpp | 92 + ui/qt/models/pref_delegate.h | 51 + ui/qt/models/pref_models.cpp | 777 + ui/qt/models/pref_models.h | 174 + ui/qt/models/proto_tree_model.cpp | 28 +- ui/qt/models/proto_tree_model.h | 3 +- ui/qt/models/related_packet_delegate.cpp | 15 +- ui/qt/models/related_packet_delegate.h | 15 +- ui/qt/models/sparkline_delegate.cpp | 15 +- ui/qt/models/sparkline_delegate.h | 15 +- ui/qt/models/supported_protocols_model.cpp | 37 +- ui/qt/models/supported_protocols_model.h | 16 +- ui/qt/models/timeline_delegate.cpp | 15 +- ui/qt/models/timeline_delegate.h | 15 +- ui/qt/models/tree_model_helpers.h | 185 + ui/qt/models/uat_delegate.cpp | 77 +- ui/qt/models/uat_delegate.h | 19 +- ui/qt/models/uat_model.cpp | 28 +- ui/qt/models/uat_model.h | 17 +- ui/qt/models/url_link_delegate.cpp | 37 +- ui/qt/models/url_link_delegate.h | 16 +- ui/qt/models/voip_calls_info_model.cpp | 15 +- ui/qt/models/voip_calls_info_model.h | 15 +- ui/qt/module_preferences_scroll_area.cpp | 22 +- ui/qt/module_preferences_scroll_area.h | 15 +- ui/qt/mtp3_summary_dialog.cpp | 18 +- ui/qt/mtp3_summary_dialog.h | 15 +- ui/qt/multicast_statistics_dialog.cpp | 33 +- ui/qt/multicast_statistics_dialog.h | 17 +- ui/qt/packet_comment_dialog.cpp | 15 +- ui/qt/packet_comment_dialog.h | 15 +- ui/qt/packet_dialog.cpp | 21 +- ui/qt/packet_dialog.h | 17 +- ui/qt/packet_format_group_box.cpp | 15 +- ui/qt/packet_format_group_box.h | 15 +- ui/qt/packet_list.cpp | 266 +- ui/qt/packet_list.h | 20 +- ui/qt/packet_range_group_box.cpp | 15 +- ui/qt/packet_range_group_box.h | 15 +- ui/qt/preference_editor_frame.cpp | 17 +- ui/qt/preference_editor_frame.h | 15 +- ui/qt/preferences_dialog.cpp | 850 +- ui/qt/preferences_dialog.h | 66 +- ui/qt/preferences_dialog.ui | 78 +- ui/qt/print_dialog.cpp | 15 +- ui/qt/print_dialog.h | 15 +- ui/qt/profile_dialog.cpp | 33 +- ui/qt/profile_dialog.h | 15 +- ui/qt/profile_dialog.ui | 8 +- ui/qt/progress_frame.cpp | 15 +- ui/qt/progress_frame.h | 15 +- ui/qt/proto_tree.cpp | 393 +- ui/qt/proto_tree.h | 13 +- ui/qt/protocol_hierarchy_dialog.cpp | 17 +- ui/qt/protocol_hierarchy_dialog.h | 15 +- ui/qt/protocol_preferences_menu.cpp | 38 +- ui/qt/protocol_preferences_menu.h | 2 +- ui/qt/recent_file_status.cpp | 16 +- ui/qt/recent_file_status.h | 6 +- ui/qt/remote_capture_dialog.cpp | 15 +- ui/qt/remote_capture_dialog.h | 15 +- ui/qt/remote_settings_dialog.cpp | 15 +- ui/qt/remote_settings_dialog.h | 15 +- ui/qt/resolved_addresses_dialog.cpp | 15 +- ui/qt/resolved_addresses_dialog.h | 15 +- ui/qt/response_time_delay_dialog.cpp | 15 +- ui/qt/response_time_delay_dialog.h | 15 +- ui/qt/rpc_service_response_time_dialog.cpp | 26 +- ui/qt/rpc_service_response_time_dialog.h | 21 +- ui/qt/rtp_analysis_dialog.cpp | 25 +- ui/qt/rtp_analysis_dialog.h | 18 +- ui/qt/rtp_audio_stream.cpp | 15 +- ui/qt/rtp_audio_stream.h | 15 +- ui/qt/rtp_player_dialog.cpp | 15 +- ui/qt/rtp_player_dialog.h | 15 +- ui/qt/rtp_stream_dialog.cpp | 17 +- ui/qt/rtp_stream_dialog.h | 15 +- ui/qt/scsi_service_response_time_dialog.cpp | 98 + ui/qt/scsi_service_response_time_dialog.h | 47 + ui/qt/sctp_all_assocs_dialog.cpp | 15 +- ui/qt/sctp_all_assocs_dialog.h | 15 +- ui/qt/sctp_assoc_analyse_dialog.cpp | 15 +- ui/qt/sctp_assoc_analyse_dialog.h | 15 +- ui/qt/sctp_assoc_analyse_dialog.ui | 3 - ui/qt/sctp_chunk_statistics_dialog.cpp | 41 +- ui/qt/sctp_chunk_statistics_dialog.h | 15 +- ui/qt/sctp_graph_arwnd_dialog.cpp | 15 +- ui/qt/sctp_graph_arwnd_dialog.h | 15 +- ui/qt/sctp_graph_byte_dialog.cpp | 15 +- ui/qt/sctp_graph_byte_dialog.h | 15 +- ui/qt/sctp_graph_dialog.cpp | 15 +- ui/qt/sctp_graph_dialog.h | 15 +- ui/qt/search_frame.cpp | 15 +- ui/qt/search_frame.h | 15 +- ui/qt/sequence_diagram.cpp | 15 +- ui/qt/sequence_diagram.h | 15 +- ui/qt/sequence_dialog.cpp | 16 +- ui/qt/sequence_dialog.h | 15 +- ui/qt/service_response_time_dialog.cpp | 20 +- ui/qt/service_response_time_dialog.h | 20 +- ui/qt/show_packet_bytes_dialog.cpp | 16 +- ui/qt/show_packet_bytes_dialog.h | 15 +- ui/qt/simple_dialog.cpp | 15 +- ui/qt/simple_dialog.h | 15 +- ui/qt/simple_statistics_dialog.cpp | 35 +- ui/qt/simple_statistics_dialog.h | 19 +- ui/qt/splash_overlay.cpp | 35 +- ui/qt/splash_overlay.h | 15 +- ui/qt/stats_tree_dialog.cpp | 15 +- ui/qt/stats_tree_dialog.h | 15 +- ui/qt/supported_protocols_dialog.cpp | 2 +- ui/qt/supported_protocols_dialog.h | 2 +- ui/qt/tabnav_tree_widget.cpp | 15 +- ui/qt/tabnav_tree_widget.h | 15 +- ui/qt/tap_parameter_dialog.cpp | 23 +- ui/qt/tap_parameter_dialog.h | 15 +- ui/qt/tcp_stream_dialog.cpp | 17 +- ui/qt/tcp_stream_dialog.h | 15 +- ui/qt/time_shift_dialog.cpp | 15 +- ui/qt/time_shift_dialog.h | 15 +- ui/qt/traffic_table_dialog.cpp | 48 +- ui/qt/traffic_table_dialog.h | 18 +- ui/qt/uat_dialog.cpp | 15 +- ui/qt/uat_dialog.h | 15 +- ui/qt/uat_dialog.ui | 14 +- ui/qt/uat_frame.cpp | 15 +- ui/qt/uat_frame.h | 15 +- ui/qt/uat_frame.ui | 14 +- ui/qt/utils/color_utils.cpp | 23 +- ui/qt/utils/color_utils.h | 18 +- ui/qt/utils/data_printer.cpp | 100 +- ui/qt/utils/data_printer.h | 22 +- ui/qt/utils/field_information.cpp | 17 +- ui/qt/utils/field_information.h | 5 +- ui/qt/utils/frame_information.cpp | 21 +- ui/qt/utils/frame_information.h | 15 +- ui/qt/utils/idata_printable.h | 47 + ui/qt/utils/proto_node.cpp | 2 +- ui/qt/utils/proto_node.h | 2 +- ui/qt/utils/qt_ui_utils.cpp | 15 +- ui/qt/utils/qt_ui_utils.h | 24 +- ui/qt/utils/stock_icon.cpp | 18 +- ui/qt/utils/stock_icon.h | 15 +- ui/qt/utils/tango_colors.h | 15 +- ui/qt/utils/variant_pointer.h | 17 +- ui/qt/utils/wireshark_mime_data.cpp | 15 +- ui/qt/utils/wireshark_mime_data.h | 15 +- ui/qt/voip_calls_dialog.cpp | 19 +- ui/qt/voip_calls_dialog.h | 19 +- ui/qt/widgets/additional_toolbar.cpp | 21 +- ui/qt/widgets/additional_toolbar.h | 15 +- ui/qt/widgets/apply_line_edit.cpp | 15 +- ui/qt/widgets/apply_line_edit.h | 15 +- ui/qt/widgets/byte_view_text.cpp | 235 +- ui/qt/widgets/byte_view_text.h | 27 +- ui/qt/widgets/capture_filter_combo.cpp | 17 +- ui/qt/widgets/capture_filter_combo.h | 15 +- ui/qt/widgets/capture_filter_edit.cpp | 102 +- ui/qt/widgets/capture_filter_edit.h | 15 +- ui/qt/widgets/clickable_label.cpp | 33 +- ui/qt/widgets/clickable_label.h | 18 +- ui/qt/widgets/display_filter_combo.cpp | 17 +- ui/qt/widgets/display_filter_combo.h | 15 +- ui/qt/widgets/display_filter_edit.cpp | 18 +- ui/qt/widgets/display_filter_edit.h | 17 +- ui/qt/widgets/dissector_tables_view.cpp | 2 +- ui/qt/widgets/dissector_tables_view.h | 2 +- ui/qt/widgets/drag_drop_toolbar.cpp | 36 +- ui/qt/widgets/drag_drop_toolbar.h | 17 +- ui/qt/widgets/drag_label.cpp | 15 +- ui/qt/widgets/drag_label.h | 15 +- ui/qt/widgets/editor_color_dialog.cpp | 74 +- ui/qt/widgets/editor_color_dialog.h | 33 +- ui/qt/widgets/editor_file_dialog.cpp | 109 +- ui/qt/widgets/editor_file_dialog.h | 41 +- ui/qt/widgets/elided_label.cpp | 15 +- ui/qt/widgets/elided_label.h | 15 +- ui/qt/widgets/expert_info_view.cpp | 2 +- ui/qt/widgets/expert_info_view.h | 2 +- ui/qt/widgets/export_objects_view.cpp | 39 + ui/qt/widgets/export_objects_view.h | 42 + ui/qt/widgets/field_filter_edit.cpp | 15 +- ui/qt/widgets/field_filter_edit.h | 15 +- ui/qt/widgets/find_line_edit.cpp | 15 +- ui/qt/widgets/find_line_edit.h | 15 +- ui/qt/widgets/follow_stream_text.cpp | 15 +- ui/qt/widgets/follow_stream_text.h | 15 +- ui/qt/widgets/interface_toolbar_lineedit.cpp | 15 +- ui/qt/widgets/interface_toolbar_lineedit.h | 15 +- ui/qt/widgets/label_stack.cpp | 15 +- ui/qt/widgets/label_stack.h | 15 +- ui/qt/widgets/overlay_scroll_bar.cpp | 15 +- ui/qt/widgets/overlay_scroll_bar.h | 15 +- ui/qt/widgets/pref_module_view.cpp | 106 + ui/qt/widgets/pref_module_view.h | 50 + ui/qt/widgets/range_syntax_lineedit.cpp | 57 + ui/qt/widgets/range_syntax_lineedit.h | 45 + ui/qt/widgets/stock_icon_tool_button.cpp | 15 +- ui/qt/widgets/stock_icon_tool_button.h | 15 +- ui/qt/widgets/syntax_line_edit.cpp | 15 +- ui/qt/widgets/syntax_line_edit.h | 15 +- ui/qt/widgets/tabnav_tree_view.cpp | 15 +- ui/qt/widgets/tabnav_tree_view.h | 15 +- ui/qt/wireless_frame.cpp | 15 +- ui/qt/wireless_frame.h | 15 +- ui/qt/wireless_timeline.cpp | 29 +- ui/qt/wireless_timeline.h | 15 +- ui/qt/wireshark_application.cpp | 90 +- ui/qt/wireshark_application.h | 16 +- ui/qt/wireshark_de.ts | 1103 +- ui/qt/wireshark_dialog.cpp | 62 +- ui/qt/wireshark_dialog.h | 26 +- ui/qt/wireshark_en.ts | 959 +- ui/qt/wireshark_fr.ts | 1088 +- ui/qt/wireshark_it.ts | 1128 +- ui/qt/wireshark_ja_JP.ts | 1087 +- ui/qt/wireshark_pl.ts | 1231 +- ui/qt/wireshark_zh_CN.ts | 1081 +- ui/qt/wlan_statistics_dialog.cpp | 57 +- ui/qt/wlan_statistics_dialog.h | 21 +- ui/recent.c | 57 +- ui/recent.h | 24 +- ui/recent_utils.h | 32 +- ui/rtp_media.c | 15 +- ui/rtp_media.h | 15 +- ui/rtp_stream.c | 14 +- ui/rtp_stream.h | 14 +- ui/service_response_time.c | 15 +- ui/service_response_time.h | 15 +- ui/simple_dialog.h | 15 +- ui/software_update.c | 15 +- ui/software_update.h | 15 +- ui/ssl_key_export.c | 15 +- ui/ssl_key_export.h | 15 +- ui/summary.c | 230 + ui/summary.h | 94 + ui/tap-iax2-analysis.c | 14 +- ui/tap-iax2-analysis.h | 14 +- ui/tap-rlc-graph.c | 47 +- ui/tap-rlc-graph.h | 23 +- ui/tap-rtp-analysis.h | 14 +- ui/tap-rtp-common.c | 2 +- ui/tap-rtp-common.h | 2 +- ui/tap-sctp-analysis.c | 32 +- ui/tap-sctp-analysis.h | 2 +- ui/tap-tcp-stream.c | 17 +- ui/tap-tcp-stream.h | 15 +- ui/tap_export_pdu.c | 46 +- ui/tap_export_pdu.h | 15 +- ui/taps.h | 2 +- ui/text_import.c | 52 +- ui/text_import.h | 15 +- ui/text_import_scanner.h | 17 +- ui/text_import_scanner.l | 47 +- ui/time_shift.c | 15 +- ui/time_shift.h | 15 +- ui/traffic_table_ui.c | 255 +- ui/traffic_table_ui.h | 37 +- ui/util.c | 21 +- ui/util.h | 15 +- ui/voip_calls.c | 36 +- ui/voip_calls.h | 14 +- ui/win32/console_win32.c | 2 +- ui/win32/console_win32.h | 2 +- ui/win32/file_dlg_win32.c | 138 +- ui/win32/file_dlg_win32.h | 4 +- ui/win32/print_win32.c | 2 +- ui/win32/print_win32.h | 2 +- ui/ws_ui_util.h | 17 +- vagrant_build.sh | 14 +- vagrant_provision.sh | 14 +- version_info.c | 2 +- version_info.h | 2 +- wireshark-qt.cpp | 83 +- wiretap/5views.c | 68 +- wiretap/5views.h | 14 +- wiretap/CMakeLists.txt | 38 +- wiretap/Makefile.am | 15 +- wiretap/aethra.c | 54 +- wiretap/aethra.h | 14 +- wiretap/ascend-int.h | 16 +- wiretap/ascend.y | 27 +- wiretap/ascend_scanner.l | 27 +- wiretap/ascendtext.c | 54 +- wiretap/ascendtext.h | 14 +- wiretap/atm.c | 56 +- wiretap/atm.h | 18 +- wiretap/ber.c | 34 +- wiretap/ber.h | 14 +- wiretap/btsnoop.c | 98 +- wiretap/btsnoop.h | 14 +- wiretap/camins.c | 32 +- wiretap/camins.h | 14 +- wiretap/capsa.c | 44 +- wiretap/capsa.h | 14 +- wiretap/catapult_dct2000.c | 240 +- wiretap/catapult_dct2000.h | 15 +- wiretap/commview.c | 171 +- wiretap/commview.h | 15 +- wiretap/cosine.c | 40 +- wiretap/cosine.h | 14 +- wiretap/csids.c | 46 +- wiretap/csids.h | 14 +- wiretap/daintree-sna.c | 49 +- wiretap/daintree-sna.h | 16 +- wiretap/dbs-etherwatch.c | 48 +- wiretap/dbs-etherwatch.h | 14 +- wiretap/dct3trace.c | 73 +- wiretap/dct3trace.h | 14 +- wiretap/erf.c | 193 +- wiretap/erf.h | 52 +- wiretap/eyesdn.c | 78 +- wiretap/eyesdn.h | 14 +- wiretap/file_access.c | 39 +- wiretap/file_wrappers.c | 485 +- wiretap/file_wrappers.h | 14 +- wiretap/hcidump.c | 36 +- wiretap/hcidump.h | 14 +- wiretap/i4b_trace.h | 21 +- wiretap/i4btrace.c | 54 +- wiretap/i4btrace.h | 14 +- wiretap/ipfix.c | 39 +- wiretap/ipfix.h | 14 +- wiretap/iptrace.c | 96 +- wiretap/iptrace.h | 14 +- wiretap/iseries.c | 46 +- wiretap/iseries.h | 14 +- wiretap/json.c | 34 +- wiretap/json.h | 14 +- wiretap/k12.c | 76 +- wiretap/k12.h | 15 +- wiretap/k12text.l | 70 +- wiretap/lanalyzer.c | 58 +- wiretap/lanalyzer.h | 14 +- wiretap/libpcap.c | 212 +- wiretap/libpcap.h | 14 +- wiretap/logcat.c | 42 +- wiretap/logcat.h | 14 +- wiretap/logcat_text.c | 66 +- wiretap/logcat_text.h | 14 +- wiretap/merge.c | 139 +- wiretap/merge.h | 21 +- wiretap/mime_file.c | 35 +- wiretap/mime_file.h | 14 +- wiretap/mp2t.c | 36 +- wiretap/mp2t.h | 14 +- wiretap/mpeg.c | 32 +- wiretap/mpeg.h | 14 +- wiretap/mplog.c | 38 +- wiretap/mplog.h | 14 +- wiretap/netmon.c | 142 +- wiretap/netmon.h | 14 +- wiretap/netscaler.c | 566 +- wiretap/netscaler.h | 14 +- wiretap/netscreen.c | 58 +- wiretap/netscreen.h | 14 +- wiretap/nettl.c | 112 +- wiretap/nettl.h | 14 +- wiretap/nettrace_3gpp_32_423.c | 160 +- wiretap/nettrace_3gpp_32_423.h | 14 +- wiretap/network_instruments.c | 81 +- wiretap/network_instruments.h | 5 +- wiretap/netxray.c | 242 +- wiretap/netxray.h | 14 +- wiretap/ngsniffer.c | 76 +- wiretap/ngsniffer.h | 14 +- wiretap/packetlogger.c | 43 +- wiretap/packetlogger.h | 16 +- wiretap/pcap-common.c | 140 +- wiretap/pcap-common.h | 22 +- wiretap/pcap-encap.h | 18 +- wiretap/pcapng.c | 598 +- wiretap/pcapng.h | 14 +- wiretap/pcapng_module.h | 65 +- wiretap/peekclassic.c | 116 +- wiretap/peekclassic.h | 14 +- wiretap/peektagged.c | 62 +- wiretap/peektagged.h | 14 +- wiretap/pppdump.c | 44 +- wiretap/pppdump.h | 14 +- wiretap/radcom.c | 42 +- wiretap/radcom.h | 14 +- wiretap/snoop.c | 74 +- wiretap/snoop.h | 14 +- wiretap/stanag4607.c | 40 +- wiretap/stanag4607.h | 14 +- wiretap/tnef.c | 34 +- wiretap/tnef.h | 14 +- wiretap/toshiba.c | 46 +- wiretap/toshiba.h | 14 +- wiretap/visual.c | 142 +- wiretap/visual.h | 14 +- wiretap/vms.c | 38 +- wiretap/vms.h | 14 +- wiretap/vwr.c | 175 +- wiretap/vwr.h | 14 +- wiretap/wtap-int.h | 26 +- wiretap/wtap.c | 129 +- wiretap/wtap.h | 148 +- wiretap/wtap_opttypes.c | 14 +- wiretap/wtap_opttypes.h | 14 +- wka | 15 +- writecap/CMakeLists.txt | 20 +- writecap/pcapio.c | 16 +- writecap/pcapio.h | 16 +- ws_attributes.h | 2 +- ws_compiler_tests.h | 2 +- ws_diag_control.h | 113 +- ws_symbol_export.h | 2 +- wsutil/.editorconfig | 2 +- wsutil/CMakeLists.txt | 34 +- wsutil/Makefile.am | 15 +- wsutil/adler32.c | 2 +- wsutil/adler32.h | 2 +- wsutil/airpdcap_wep.c | 111 - wsutil/base32.c | 2 +- wsutil/base32.h | 2 +- wsutil/base64.c | 22 +- wsutil/base64.h | 2 +- wsutil/bits_count_ones.h | 2 +- wsutil/bits_ctz.h | 2 +- wsutil/bitswap.c | 2 +- wsutil/bitswap.h | 2 +- wsutil/buffer.c | 13 +- wsutil/buffer.h | 2 +- wsutil/cfutils.c | 2 +- wsutil/cfutils.h | 2 +- wsutil/clopts_common.c | 2 +- wsutil/clopts_common.h | 2 +- wsutil/cmdarg_err.c | 2 +- wsutil/cmdarg_err.h | 2 +- wsutil/color.h | 2 +- wsutil/copyright_info.c | 4 +- wsutil/copyright_info.h | 2 +- wsutil/cpu_info.c | 2 +- wsutil/cpu_info.h | 2 +- wsutil/crash_info.c | 2 +- wsutil/crash_info.h | 2 +- wsutil/crc10.c | 2 +- wsutil/crc10.h | 2 +- wsutil/crc11.c | 2 +- wsutil/crc11.h | 2 +- wsutil/crc16-plain.c | 2 +- wsutil/crc16-plain.h | 2 +- wsutil/crc16.c | 2 +- wsutil/crc16.h | 2 +- wsutil/crc32.c | 2 +- wsutil/crc32.h | 4 +- wsutil/crc6.c | 2 +- wsutil/crc6.h | 2 +- wsutil/crc7.c | 2 +- wsutil/crc7.h | 2 +- wsutil/crc8.c | 10 +- wsutil/crc8.h | 8 +- wsutil/dot11decrypt_wep.c | 87 + wsutil/eax.c | 2 +- wsutil/eax.h | 2 +- wsutil/file_util.c | 44 +- wsutil/file_util.h | 2 +- wsutil/filesystem.c | 31 +- wsutil/filesystem.h | 2 +- wsutil/frequency-utils.c | 2 +- wsutil/frequency-utils.h | 2 +- wsutil/g711.h | 2 +- wsutil/getopt_long.c | 16 +- wsutil/getopt_long.h | 16 +- wsutil/glib-compat.c | 14 +- wsutil/glib-compat.h | 3 +- wsutil/inet_addr.c | 2 +- wsutil/inet_addr.h | 2 +- wsutil/inet_ipv4.h | 2 +- wsutil/inet_ipv6.h | 2 +- wsutil/interface.c | 2 +- wsutil/interface.h | 2 +- wsutil/mpeg-audio.c | 2 +- wsutil/mpeg-audio.h | 2 +- wsutil/nstime.c | 2 +- wsutil/nstime.h | 2 +- wsutil/os_version_info.c | 41 +- wsutil/os_version_info.h | 2 +- wsutil/pint.h | 2 +- wsutil/plugins.c | 229 +- wsutil/plugins.h | 10 +- wsutil/popcount.c | 2 +- wsutil/popcount.h | 2 +- wsutil/pow2.h | 29 + wsutil/privileges.c | 21 +- wsutil/privileges.h | 2 +- wsutil/processes.h | 2 +- wsutil/report_message.c | 2 +- wsutil/report_message.h | 2 +- wsutil/rsa.c | 2 +- wsutil/rsa.h | 2 +- wsutil/sign_ext.h | 2 +- wsutil/socket.h | 2 +- wsutil/str_util.c | 2 +- wsutil/str_util.h | 2 +- wsutil/strnatcmp.c | 18 +- wsutil/strnatcmp.h | 18 +- wsutil/strptime.c | 15 +- wsutil/strptime.h | 2 +- wsutil/strtoi.c | 2 +- wsutil/strtoi.h | 2 +- wsutil/tempfile.c | 2 +- wsutil/tempfile.h | 2 +- wsutil/time_util.c | 2 +- wsutil/time_util.h | 2 +- wsutil/type_util.c | 2 +- wsutil/type_util.h | 2 +- wsutil/unicode-utils.c | 4 +- wsutil/unicode-utils.h | 2 +- wsutil/utf8_entities.h | 3 +- wsutil/win32-utils.c | 2 +- wsutil/win32-utils.h | 10 +- wsutil/ws_cpuid.h | 2 +- wsutil/ws_mempbrk.c | 2 +- wsutil/ws_mempbrk.h | 2 +- wsutil/ws_mempbrk_int.h | 2 +- wsutil/ws_mempbrk_sse42.c | 15 +- wsutil/ws_pipe.c | 608 + wsutil/ws_pipe.h | 117 + wsutil/ws_printf.h | 2 +- wsutil/wsgcrypt.c | 40 +- wsutil/wsgcrypt.h | 31 +- wsutil/wsgetopt.h | 15 +- wsutil/wsjsmn.c | 2 +- wsutil/wsjsmn.h | 2 +- wsutil/wspcap.h | 2 +- wsutil/xtea.c | 2 +- wsutil/xtea.h | 2 +- 4463 files changed, 282104 insertions(+), 242188 deletions(-) create mode 100644 cmake/modules/FileInstall.cmake delete mode 100644 cmake/modules/FindASCIIDOC.cmake create mode 100644 cmake/modules/FindAsciidoctor.cmake delete mode 100644 cmake/modules/FindFOP.cmake delete mode 100644 cmake/modules/FindGEOIP.cmake delete mode 100644 cmake/modules/FindLYNX.cmake create mode 100644 cmake/modules/FindMaxMindDB.cmake delete mode 100644 cmake/modules/FindSH.cmake rename debian/{geoip_db_paths => maxmind_db_paths} (100%) delete mode 100644 debian/patches/02_use_packaged_openlayers_js.patch delete mode 100644 doc/eproto2sgml create mode 100644 doc/mmdbresolve.pod create mode 100644 docbook/README.adoc delete mode 100644 docbook/README.txt delete mode 100644 docbook/asciidoctor-asciidoc.conf create mode 100644 docbook/asciidoctor-macros/README.adoc create mode 100644 docbook/asciidoctor-macros/commaize-block.rb create mode 100644 docbook/asciidoctor-macros/commaize-block/extension.rb create mode 100644 docbook/asciidoctor-macros/commaize-block/sample.adoc create mode 100644 docbook/asciidoctor-macros/cve_idlink-inline-macro.rb create mode 100644 docbook/asciidoctor-macros/cve_idlink-inline-macro/extension.rb create mode 100644 docbook/asciidoctor-macros/ws_buglink-inline-macro.rb create mode 100644 docbook/asciidoctor-macros/ws_buglink-inline-macro/extension.rb create mode 100644 docbook/asciidoctor-macros/ws_salink-inline-macro.rb create mode 100644 docbook/asciidoctor-macros/ws_salink-inline-macro/extension.rb delete mode 100644 docbook/custom_layer_pdf.xsl create mode 100644 docbook/custom_layer_single_html.xsl delete mode 100644 epan/crypt/airpdcap.c delete mode 100644 epan/crypt/airpdcap_ccmp.c delete mode 100644 epan/crypt/airpdcap_debug.h delete mode 100644 epan/crypt/airpdcap_int.h delete mode 100644 epan/crypt/airpdcap_interop.h delete mode 100644 epan/crypt/airpdcap_rijndael.c delete mode 100644 epan/crypt/airpdcap_rijndael.h delete mode 100644 epan/crypt/airpdcap_system.h delete mode 100644 epan/crypt/airpdcap_tkip.c delete mode 100644 epan/crypt/airpdcap_user.h delete mode 100644 epan/crypt/airpdcap_ws.h create mode 100644 epan/crypt/dot11decrypt.c create mode 100644 epan/crypt/dot11decrypt_ccmp.c create mode 100644 epan/crypt/dot11decrypt_debug.h create mode 100644 epan/crypt/dot11decrypt_int.h create mode 100644 epan/crypt/dot11decrypt_interop.h create mode 100644 epan/crypt/dot11decrypt_rijndael.c create mode 100644 epan/crypt/dot11decrypt_rijndael.h create mode 100644 epan/crypt/dot11decrypt_system.h create mode 100644 epan/crypt/dot11decrypt_tkip.c create mode 100644 epan/crypt/dot11decrypt_user.h create mode 100644 epan/crypt/dot11decrypt_ws.h create mode 100644 epan/dissectors/asn1/cms/CMSFirmwareWrapper.asn create mode 100644 epan/dissectors/asn1/nr-rrc/CMakeLists.txt create mode 100644 epan/dissectors/asn1/nr-rrc/Makefile.am create mode 100644 epan/dissectors/asn1/nr-rrc/NR-InterNodeDefinitions.asn create mode 100644 epan/dissectors/asn1/nr-rrc/NR-RRC-Definitions.asn create mode 100644 epan/dissectors/asn1/nr-rrc/nr-rrc.cnf create mode 100644 epan/dissectors/asn1/nr-rrc/packet-nr-rrc-template.c create mode 100644 epan/dissectors/asn1/nr-rrc/packet-nr-rrc-template.h create mode 100644 epan/dissectors/packet-bacnet.h create mode 100644 epan/dissectors/packet-caneth.c create mode 100644 epan/dissectors/packet-cvspserver.c create mode 100644 epan/dissectors/packet-docsis-macmgmt.c create mode 100644 epan/dissectors/packet-docsis-tlv.c create mode 100644 epan/dissectors/packet-docsis-tlv.h create mode 100644 epan/dissectors/packet-docsis-vendor.c create mode 100644 epan/dissectors/packet-docsis.c create mode 100644 epan/dissectors/packet-f5ethtrailer.c create mode 100644 epan/dissectors/packet-f5ethtrailer.h create mode 100644 epan/dissectors/packet-lnet.c create mode 100644 epan/dissectors/packet-lnet.h create mode 100644 epan/dissectors/packet-lustre.c create mode 100755 epan/dissectors/packet-nas_5gs.c create mode 100644 epan/dissectors/packet-nr-rrc.c create mode 100644 epan/dissectors/packet-nr-rrc.h create mode 100644 epan/dissectors/packet-nxp_802154_sniffer.c create mode 100644 epan/dissectors/packet-smp.c create mode 100644 epan/dissectors/packet-steam-ihs-discovery.c create mode 100644 epan/dissectors/packet-thrift.h create mode 100644 epan/dissectors/packet-xra.c mode change 100755 => 100644 epan/dissectors/packet-zbee-zcl-se.c delete mode 100644 epan/geoip_db.c delete mode 100644 epan/geoip_db.h create mode 100644 epan/maxmind_db.c create mode 100644 epan/maxmind_db.h mode change 100755 => 100644 epan/print.c delete mode 100644 extcap_spawn.c delete mode 100644 extcap_spawn.h delete mode 100644 image/clist_ascend.xpm delete mode 100644 image/clist_descend.xpm delete mode 100644 image/hi16-app-wireshark.png delete mode 100644 image/hi32-app-wireshark.png delete mode 100644 image/hi48-app-wireshark.png delete mode 100644 image/lo16-app-wireshark.png delete mode 100644 image/lo32-app-wireshark.png delete mode 100644 image/lo48-app-wireshark.png delete mode 100644 image/nsis-checked.bmp delete mode 100644 image/nsis-unchecked.bmp delete mode 100644 image/openhand-16.png delete mode 100644 image/rubberband-16.png delete mode 100644 image/stock_dialog_error_48.xpm delete mode 100644 image/stock_dialog_info_48.xpm delete mode 100644 image/stock_dialog_question_48.xpm delete mode 100644 image/stock_dialog_stop_48.xpm delete mode 100644 image/stock_dialog_warning_48.xpm create mode 100644 image/stock_icons.qrc rename image/{toolbar => stock_icons}/14x14/x-capture-comment-update.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-comment-update.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-comment-update(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.active.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.active.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.active(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.selected.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.selected.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.selected(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-capture-filter-bookmark(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.active.png (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.active.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.active(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.png (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.selected.png (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.selected.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.selected(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-display-filter-bookmark(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-chat.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-chat(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-error.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-error(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-indicators-all.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-none.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-none(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-note.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-note(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-warn.png (100%) rename image/{toolbar => stock_icons}/14x14/x-expert-warn(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.active.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.active.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.active(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.selected.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.selected.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.selected(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-clear(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-dropdown.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-dropdown.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-dropdown(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.active.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.active.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.active(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.selected.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.selected.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.selected(a)2x.png (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark.svg (100%) rename image/{toolbar => stock_icons}/14x14/x-filter-matching-bookmark(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/edit-find.png (100%) rename image/{toolbar => stock_icons}/16x16/edit-find.svg (100%) rename image/{toolbar => stock_icons}/16x16/edit-find(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/go-first.png (100%) rename image/{toolbar => stock_icons}/16x16/go-first.svg (100%) rename image/{toolbar => stock_icons}/16x16/go-first(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/go-jump.png (100%) rename image/{toolbar => stock_icons}/16x16/go-jump.svg (100%) rename image/{toolbar => stock_icons}/16x16/go-jump(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/go-last.png (100%) rename image/{toolbar => stock_icons}/16x16/go-last.svg (100%) rename image/{toolbar => stock_icons}/16x16/go-last(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/go-next.png (100%) rename image/{toolbar => stock_icons}/16x16/go-next.svg (100%) rename image/{toolbar => stock_icons}/16x16/go-next(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/go-previous.png (100%) rename image/{toolbar => stock_icons}/16x16/go-previous.svg (100%) rename image/{toolbar => stock_icons}/16x16/go-previous(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-close.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-close.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-close(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-close(a)2x.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-reload.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-reload.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-reload(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-reload(a)2x.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-save.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-save.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-save(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-file-save(a)2x.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-options-gear.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-options-wrench.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-options.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-options(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart-fin.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart-triangle1.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart-triangle2.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart-turn1.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart-turn2.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-restart(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-start.on.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-start.on.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-start.on(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-start.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-start.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-start(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-stop-red.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-stop-white.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-stop.png (100%) rename image/{toolbar => stock_icons}/16x16/x-capture-stop(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-colorize-packets.png (100%) rename image/{toolbar => stock_icons}/16x16/x-colorize-packets.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-colorize-packets(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-resize-columns.png (100%) rename image/{toolbar => stock_icons}/16x16/x-resize-columns.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-resize-columns(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/x-stay-last.png (100%) rename image/{toolbar => stock_icons}/16x16/x-stay-last.svg (100%) rename image/{toolbar => stock_icons}/16x16/x-stay-last(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/zoom-in.png (100%) rename image/{toolbar => stock_icons}/16x16/zoom-in.svg (100%) rename image/{toolbar => stock_icons}/16x16/zoom-in(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/zoom-original.png (100%) rename image/{toolbar => stock_icons}/16x16/zoom-original.svg (100%) rename image/{toolbar => stock_icons}/16x16/zoom-original(a)2x.png (100%) rename image/{toolbar => stock_icons}/16x16/zoom-out.png (100%) rename image/{toolbar => stock_icons}/16x16/zoom-out.svg (100%) rename image/{toolbar => stock_icons}/16x16/zoom-out(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.active.png (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.active.svg (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.active(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.png (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.selected.png (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.selected.svg (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.selected(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply.svg (100%) rename image/{toolbar => stock_icons}/24x14/x-filter-apply(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/edit-find.png (100%) rename image/{toolbar => stock_icons}/24x24/edit-find.svg (100%) rename image/{toolbar => stock_icons}/24x24/edit-find(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/go-first.png (100%) rename image/{toolbar => stock_icons}/24x24/go-first.svg (100%) rename image/{toolbar => stock_icons}/24x24/go-first(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/go-jump.png (100%) rename image/{toolbar => stock_icons}/24x24/go-jump.svg (100%) rename image/{toolbar => stock_icons}/24x24/go-jump(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/go-last.png (100%) rename image/{toolbar => stock_icons}/24x24/go-last.svg (100%) rename image/{toolbar => stock_icons}/24x24/go-last(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/go-next.png (100%) rename image/{toolbar => stock_icons}/24x24/go-next.svg (100%) rename image/{toolbar => stock_icons}/24x24/go-next(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/go-previous.png (100%) rename image/{toolbar => stock_icons}/24x24/go-previous.svg (100%) rename image/{toolbar => stock_icons}/24x24/go-previous(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-close.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-close.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-close(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-close(a)2x.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-reload.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-reload.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-reload(a)2x.png (100%) create mode 100644 image/stock_icons/24x24/x-capture-file-reload(a)2x.svg rename image/{toolbar => stock_icons}/24x24/x-capture-file-save.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-save.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-save(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-file-save(a)2x.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-options-gear.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-options-wrench.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-options.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-options(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart-fin.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart-triangle1.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart-triangle2.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart-turn1.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart-turn2.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-restart(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-start.on.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-start.on.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-start.on(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-start.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-start.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-start(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-stop-red.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-stop-white.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-stop.png (100%) rename image/{toolbar => stock_icons}/24x24/x-capture-stop(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-colorize-packets.png (100%) rename image/{toolbar => stock_icons}/24x24/x-colorize-packets.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-colorize-packets(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-resize-columns-motion.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-resize-columns.png (100%) rename image/{toolbar => stock_icons}/24x24/x-resize-columns.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-resize-columns(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/x-stay-last.png (100%) rename image/{toolbar => stock_icons}/24x24/x-stay-last.svg (100%) rename image/{toolbar => stock_icons}/24x24/x-stay-last(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/zoom-in.png (100%) rename image/{toolbar => stock_icons}/24x24/zoom-in.svg (100%) rename image/{toolbar => stock_icons}/24x24/zoom-in(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/zoom-original.png (100%) rename image/{toolbar => stock_icons}/24x24/zoom-original.svg (100%) rename image/{toolbar => stock_icons}/24x24/zoom-original(a)2x.png (100%) rename image/{toolbar => stock_icons}/24x24/zoom-out.png (100%) rename image/{toolbar => stock_icons}/24x24/zoom-out.svg (100%) rename image/{toolbar => stock_icons}/24x24/zoom-out(a)2x.png (100%) create mode 100755 image/stock_icons/svg-to-png.sh rename image/{toolbar => stock_icons}/svg/x-filter-apply.svg (100%) rename image/{toolbar => stock_icons}/svg/x-filter-bookmark.svg (100%) rename image/{toolbar => stock_icons}/svg/x-filter-clear.svg (100%) delete mode 100644 image/toolbar.qrc delete mode 100644 image/toolbar/24x24/x-capture-file-reload(a)2x.svg delete mode 100755 image/toolbar/svg-to-png.sh delete mode 100644 image/voip_select.xpm delete mode 100644 image/wssplash-dev.xpm delete mode 100644 image/wssplash.xpm delete mode 100644 ipmap.html create mode 100644 mmdbresolve.c mode change 100755 => 100644 packaging/nsis/common.nsh mode change 100755 => 100644 packaging/nsis/uninstall.nsi mode change 100755 => 100644 packaging/portableapps/appinfo.tmpl create mode 100644 plugins/codecs/Makefile.am.inc create mode 100644 plugins/codecs/l16_mono/AUTHORS create mode 100644 plugins/codecs/l16_mono/CMakeLists.txt create mode 100644 plugins/codecs/l16_mono/Makefile.am create mode 100644 plugins/codecs/l16_mono/README create mode 100644 plugins/codecs/l16_mono/l16decode.c delete mode 100644 plugins/docsis/AUTHORS delete mode 100644 plugins/docsis/CMakeLists.txt delete mode 100644 plugins/docsis/ChangeLog delete mode 100644 plugins/docsis/Makefile.am delete mode 100644 plugins/docsis/README delete mode 100644 plugins/docsis/packet-docsis.c delete mode 100644 plugins/docsis/packet-macmgmt.c delete mode 100644 plugins/docsis/packet-tlv.c delete mode 100644 plugins/docsis/packet-tlv.h delete mode 100644 plugins/docsis/packet-vendor.c create mode 100644 plugins/epan/Makefile.am.inc rename plugins/{ => epan}/ethercat/AUTHORS (100%) create mode 100644 plugins/epan/ethercat/CMakeLists.txt create mode 100644 plugins/epan/ethercat/Makefile.am create mode 100644 plugins/epan/ethercat/packet-ams.c create mode 100644 plugins/epan/ethercat/packet-ams.h create mode 100644 plugins/epan/ethercat/packet-ecatmb.c create mode 100644 plugins/epan/ethercat/packet-ecatmb.h create mode 100644 plugins/epan/ethercat/packet-esl.c create mode 100644 plugins/epan/ethercat/packet-ethercat-datagram.c create mode 100644 plugins/epan/ethercat/packet-ethercat-datagram.h create mode 100644 plugins/epan/ethercat/packet-ethercat-frame.c create mode 100644 plugins/epan/ethercat/packet-ethercat-frame.h create mode 100644 plugins/epan/ethercat/packet-ioraw.c create mode 100644 plugins/epan/ethercat/packet-ioraw.h create mode 100644 plugins/epan/ethercat/packet-nv.c create mode 100644 plugins/epan/ethercat/packet-nv.h create mode 100644 plugins/epan/gryphon/AUTHORS create mode 100644 plugins/epan/gryphon/CMakeLists.txt create mode 100644 plugins/epan/gryphon/Makefile.am create mode 100644 plugins/epan/gryphon/README create mode 100644 plugins/epan/gryphon/packet-gryphon.c create mode 100644 plugins/epan/gryphon/packet-gryphon.h create mode 100644 plugins/epan/irda/CMakeLists.txt create mode 100644 plugins/epan/irda/Makefile.am create mode 100644 plugins/epan/irda/irda-appl.h create mode 100644 plugins/epan/irda/packet-ircomm.c create mode 100644 plugins/epan/irda/packet-irda.c create mode 100644 plugins/epan/irda/packet-sir.c rename plugins/{ => epan}/mate/AUTHORS (100%) create mode 100644 plugins/epan/mate/CMakeLists.txt create mode 100644 plugins/epan/mate/Makefile.am rename plugins/{ => epan}/mate/examples/call.mate (100%) rename plugins/{ => epan}/mate/examples/mms.mate (100%) rename plugins/{ => epan}/mate/examples/pasv_ftp.mate (100%) rename plugins/{ => epan}/mate/examples/tcp.mate (100%) rename plugins/{ => epan}/mate/examples/web.mate (100%) create mode 100644 plugins/epan/mate/mate.h create mode 100644 plugins/epan/mate/mate_grammar.lemon create mode 100644 plugins/epan/mate/mate_parser.l create mode 100644 plugins/epan/mate/mate_runtime.c create mode 100644 plugins/epan/mate/mate_setup.c create mode 100644 plugins/epan/mate/mate_util.c create mode 100644 plugins/epan/mate/mate_util.h rename plugins/{ => epan}/mate/matelib/dns.mate (100%) rename plugins/{ => epan}/mate/matelib/h225_ras.mate (100%) rename plugins/{ => epan}/mate/matelib/isup.mate (100%) rename plugins/{ => epan}/mate/matelib/megaco.mate (100%) rename plugins/{ => epan}/mate/matelib/q931.mate (100%) rename plugins/{ => epan}/mate/matelib/radius.mate (100%) rename plugins/{ => epan}/mate/matelib/rtsp.mate (100%) rename plugins/{ => epan}/mate/matelib/sip.mate (100%) create mode 100644 plugins/epan/mate/packet-mate.c rename plugins/{ => epan}/opcua/AUTHORS (100%) create mode 100644 plugins/epan/opcua/CMakeLists.txt rename plugins/{ => epan}/opcua/ChangeLog (100%) rename plugins/{ => epan}/opcua/Doxyfile (100%) create mode 100644 plugins/epan/opcua/Makefile.am rename plugins/{ => epan}/opcua/README (100%) create mode 100644 plugins/epan/opcua/opcua.c create mode 100644 plugins/epan/opcua/opcua_application_layer.c create mode 100644 plugins/epan/opcua/opcua_application_layer.h create mode 100644 plugins/epan/opcua/opcua_complextypeparser.c create mode 100644 plugins/epan/opcua/opcua_complextypeparser.h create mode 100644 plugins/epan/opcua/opcua_enumparser.c create mode 100644 plugins/epan/opcua/opcua_enumparser.h create mode 100644 plugins/epan/opcua/opcua_extensionobjectids.h create mode 100644 plugins/epan/opcua/opcua_extensionobjecttable.c create mode 100644 plugins/epan/opcua/opcua_hfindeces.c create mode 100644 plugins/epan/opcua/opcua_hfindeces.h create mode 100644 plugins/epan/opcua/opcua_identifiers.h create mode 100644 plugins/epan/opcua/opcua_security_layer.c create mode 100644 plugins/epan/opcua/opcua_security_layer.h create mode 100644 plugins/epan/opcua/opcua_serviceids.h create mode 100644 plugins/epan/opcua/opcua_serviceparser.c create mode 100644 plugins/epan/opcua/opcua_serviceparser.h create mode 100644 plugins/epan/opcua/opcua_servicetable.c create mode 100644 plugins/epan/opcua/opcua_servicetable.h create mode 100644 plugins/epan/opcua/opcua_simpletypes.c create mode 100644 plugins/epan/opcua/opcua_simpletypes.h create mode 100644 plugins/epan/opcua/opcua_statuscode.c create mode 100644 plugins/epan/opcua/opcua_statuscode.h create mode 100644 plugins/epan/opcua/opcua_transport_layer.c create mode 100644 plugins/epan/opcua/opcua_transport_layer.h rename plugins/{ => epan}/pluginifdemo/AUTHORS (100%) create mode 100644 plugins/epan/pluginifdemo/CMakeLists.txt create mode 100644 plugins/epan/pluginifdemo/Makefile.am rename plugins/{ => epan}/pluginifdemo/README (100%) create mode 100644 plugins/epan/pluginifdemo/pluginifdemo.c create mode 100644 plugins/epan/pluginifdemo/pluginifdemo.h create mode 100644 plugins/epan/pluginifdemo/ui/pluginifdemo_about.cpp create mode 100644 plugins/epan/pluginifdemo/ui/pluginifdemo_about.h rename plugins/{ => epan}/pluginifdemo/ui/pluginifdemo_about.ui (100%) create mode 100644 plugins/epan/pluginifdemo/ui/pluginifdemo_main.cpp create mode 100644 plugins/epan/pluginifdemo/ui/pluginifdemo_main.h rename plugins/{ => epan}/pluginifdemo/ui/pluginifdemo_main.ui (100%) create mode 100644 plugins/epan/pluginifdemo/ui/uiclasshandler.cpp create mode 100644 plugins/epan/pluginifdemo/ui/uihandler.cpp create mode 100644 plugins/epan/pluginifdemo/ui/uihandler.h rename plugins/{ => epan}/profinet/AUTHORS (100%) create mode 100644 plugins/epan/profinet/CMakeLists.txt rename plugins/{ => epan}/profinet/ChangeLog (100%) create mode 100644 plugins/epan/profinet/Makefile.am create mode 100644 plugins/epan/profinet/packet-dcerpc-pn-io.c create mode 100644 plugins/epan/profinet/packet-dcom-cba-acco.c create mode 100644 plugins/epan/profinet/packet-dcom-cba-acco.h create mode 100644 plugins/epan/profinet/packet-dcom-cba.c create mode 100644 plugins/epan/profinet/packet-pn-dcp.c create mode 100644 plugins/epan/profinet/packet-pn-mrp.c create mode 100644 plugins/epan/profinet/packet-pn-mrrt.c create mode 100644 plugins/epan/profinet/packet-pn-ptcp.c create mode 100644 plugins/epan/profinet/packet-pn-rt.c create mode 100644 plugins/epan/profinet/packet-pn-rtc-one.c create mode 100644 plugins/epan/profinet/packet-pn.c create mode 100644 plugins/epan/profinet/packet-pn.h rename plugins/{ => epan}/stats_tree/AUTHORS (100%) create mode 100644 plugins/epan/stats_tree/CMakeLists.txt create mode 100644 plugins/epan/stats_tree/Makefile.am create mode 100644 plugins/epan/stats_tree/pinfo_stats_tree.c create mode 100644 plugins/epan/stats_tree/pinfo_stats_tree.h create mode 100644 plugins/epan/stats_tree/stats_tree_plugin.c rename plugins/{ => epan}/transum/AUTHORS (100%) create mode 100644 plugins/epan/transum/CMakeLists.txt create mode 100644 plugins/epan/transum/Makefile.am rename plugins/{ => epan}/transum/README (100%) create mode 100644 plugins/epan/transum/decoders.c create mode 100644 plugins/epan/transum/decoders.h create mode 100644 plugins/epan/transum/extractors.c create mode 100644 plugins/epan/transum/extractors.h create mode 100644 plugins/epan/transum/packet-transum.c create mode 100644 plugins/epan/transum/packet-transum.h create mode 100644 plugins/epan/transum/preferences.h rename plugins/{ => epan}/unistim/AUTHORS (100%) create mode 100644 plugins/epan/unistim/CMakeLists.txt rename plugins/{ => epan}/unistim/ChangeLog (100%) create mode 100644 plugins/epan/unistim/Makefile.am rename plugins/{ => epan}/unistim/TODO (100%) create mode 100644 plugins/epan/unistim/audio.h create mode 100644 plugins/epan/unistim/basic.h create mode 100644 plugins/epan/unistim/broadcast.h create mode 100644 plugins/epan/unistim/defines.h create mode 100644 plugins/epan/unistim/display.h create mode 100644 plugins/epan/unistim/expansion.h create mode 100644 plugins/epan/unistim/key.h create mode 100644 plugins/epan/unistim/network.h create mode 100644 plugins/epan/unistim/packet-unistim.c create mode 100644 plugins/epan/unistim/packet-unistim.h create mode 100644 plugins/epan/unistim/uftp.h rename plugins/{ => epan}/wimax/AUTHORS (100%) create mode 100644 plugins/epan/wimax/CMakeLists.txt create mode 100644 plugins/epan/wimax/Makefile.am rename plugins/{ => epan}/wimax/README.wimax (100%) create mode 100644 plugins/epan/wimax/crc.c create mode 100644 plugins/epan/wimax/crc.h create mode 100644 plugins/epan/wimax/crc_data.c create mode 100644 plugins/epan/wimax/mac_hd_generic_decoder.c create mode 100644 plugins/epan/wimax/mac_hd_type1_decoder.c create mode 100644 plugins/epan/wimax/mac_hd_type2_decoder.c create mode 100644 plugins/epan/wimax/mac_mgmt_msg_decoder.c create mode 100644 plugins/epan/wimax/msg_aas_beam.c create mode 100644 plugins/epan/wimax/msg_aas_fbck.c create mode 100644 plugins/epan/wimax/msg_arq.c create mode 100644 plugins/epan/wimax/msg_clk_cmp.c create mode 100644 plugins/epan/wimax/msg_dcd.c create mode 100644 plugins/epan/wimax/msg_dlmap.c create mode 100644 plugins/epan/wimax/msg_dreg.c create mode 100644 plugins/epan/wimax/msg_dsa.c create mode 100644 plugins/epan/wimax/msg_dsc.c create mode 100644 plugins/epan/wimax/msg_dsd.c create mode 100644 plugins/epan/wimax/msg_dsx_rvd.c create mode 100644 plugins/epan/wimax/msg_fpc.c create mode 100644 plugins/epan/wimax/msg_pkm.c create mode 100644 plugins/epan/wimax/msg_pmc.c create mode 100644 plugins/epan/wimax/msg_prc_lt_ctrl.c create mode 100644 plugins/epan/wimax/msg_reg_req.c create mode 100644 plugins/epan/wimax/msg_reg_rsp.c create mode 100644 plugins/epan/wimax/msg_rep.c create mode 100644 plugins/epan/wimax/msg_res_cmd.c create mode 100644 plugins/epan/wimax/msg_rng_req.c create mode 100644 plugins/epan/wimax/msg_rng_rsp.c create mode 100644 plugins/epan/wimax/msg_sbc.c create mode 100644 plugins/epan/wimax/msg_ucd.c create mode 100644 plugins/epan/wimax/msg_ulmap.c create mode 100644 plugins/epan/wimax/packet-m2m.c create mode 100644 plugins/epan/wimax/packet-wmx.c create mode 100644 plugins/epan/wimax/wimax-int.h create mode 100644 plugins/epan/wimax/wimax_bits.h create mode 100644 plugins/epan/wimax/wimax_cdma_code_decoder.c create mode 100644 plugins/epan/wimax/wimax_compact_dlmap_ie_decoder.c create mode 100644 plugins/epan/wimax/wimax_compact_dlmap_ie_decoder.h create mode 100644 plugins/epan/wimax/wimax_compact_ulmap_ie_decoder.c create mode 100644 plugins/epan/wimax/wimax_compact_ulmap_ie_decoder.h create mode 100644 plugins/epan/wimax/wimax_fch_decoder.c create mode 100644 plugins/epan/wimax/wimax_ffb_decoder.c create mode 100644 plugins/epan/wimax/wimax_hack_decoder.c create mode 100644 plugins/epan/wimax/wimax_harq_map_decoder.c create mode 100644 plugins/epan/wimax/wimax_mac.h create mode 100644 plugins/epan/wimax/wimax_pdu_decoder.c create mode 100644 plugins/epan/wimax/wimax_phy_attributes_decoder.c create mode 100644 plugins/epan/wimax/wimax_tlv.c create mode 100644 plugins/epan/wimax/wimax_tlv.h create mode 100644 plugins/epan/wimax/wimax_utils.c create mode 100644 plugins/epan/wimax/wimax_utils.h rename plugins/{ => epan}/wimaxasncp/AUTHORS (100%) create mode 100644 plugins/epan/wimaxasncp/CMakeLists.txt rename plugins/{ => epan}/wimaxasncp/ChangeLog (100%) create mode 100644 plugins/epan/wimaxasncp/Makefile.am create mode 100644 plugins/epan/wimaxasncp/packet-wimaxasncp.c create mode 100644 plugins/epan/wimaxasncp/wimaxasncp_dict.h create mode 100644 plugins/epan/wimaxasncp/wimaxasncp_dict.l rename plugins/{ => epan}/wimaxmacphy/AUTHORS (100%) create mode 100644 plugins/epan/wimaxmacphy/CMakeLists.txt rename plugins/{ => epan}/wimaxmacphy/ChangeLog (100%) create mode 100644 plugins/epan/wimaxmacphy/Makefile.am create mode 100644 plugins/epan/wimaxmacphy/packet-wimaxmacphy.c create mode 100644 plugins/epan/wimaxmacphy/packet-wimaxmacphy.h delete mode 100644 plugins/ethercat/CMakeLists.txt delete mode 100644 plugins/ethercat/Makefile.am delete mode 100644 plugins/ethercat/packet-ams.c delete mode 100644 plugins/ethercat/packet-ams.h delete mode 100644 plugins/ethercat/packet-ecatmb.c delete mode 100644 plugins/ethercat/packet-ecatmb.h delete mode 100644 plugins/ethercat/packet-esl.c delete mode 100644 plugins/ethercat/packet-ethercat-datagram.c delete mode 100644 plugins/ethercat/packet-ethercat-datagram.h delete mode 100644 plugins/ethercat/packet-ethercat-frame.c delete mode 100644 plugins/ethercat/packet-ethercat-frame.h delete mode 100644 plugins/ethercat/packet-ioraw.c delete mode 100644 plugins/ethercat/packet-ioraw.h delete mode 100644 plugins/ethercat/packet-nv.c delete mode 100644 plugins/ethercat/packet-nv.h delete mode 100644 plugins/gryphon/AUTHORS delete mode 100644 plugins/gryphon/CMakeLists.txt delete mode 100644 plugins/gryphon/Makefile.am delete mode 100644 plugins/gryphon/README delete mode 100644 plugins/gryphon/packet-gryphon.c delete mode 100644 plugins/gryphon/packet-gryphon.h delete mode 100644 plugins/irda/CMakeLists.txt delete mode 100644 plugins/irda/Makefile.am delete mode 100644 plugins/irda/irda-appl.h delete mode 100644 plugins/irda/packet-ircomm.c delete mode 100644 plugins/irda/packet-irda.c delete mode 100644 plugins/irda/packet-sir.c delete mode 100644 plugins/mate/CMakeLists.txt delete mode 100644 plugins/mate/Makefile.am delete mode 100644 plugins/mate/mate.h delete mode 100644 plugins/mate/mate_grammar.lemon delete mode 100644 plugins/mate/mate_parser.l delete mode 100644 plugins/mate/mate_runtime.c delete mode 100644 plugins/mate/mate_setup.c delete mode 100644 plugins/mate/mate_util.c delete mode 100644 plugins/mate/mate_util.h delete mode 100644 plugins/mate/packet-mate.c delete mode 100644 plugins/opcua/CMakeLists.txt delete mode 100644 plugins/opcua/Makefile.am delete mode 100644 plugins/opcua/opcua.c delete mode 100644 plugins/opcua/opcua_application_layer.c delete mode 100644 plugins/opcua/opcua_application_layer.h delete mode 100644 plugins/opcua/opcua_complextypeparser.c delete mode 100644 plugins/opcua/opcua_complextypeparser.h delete mode 100644 plugins/opcua/opcua_enumparser.c delete mode 100644 plugins/opcua/opcua_enumparser.h delete mode 100644 plugins/opcua/opcua_extensionobjectids.h delete mode 100644 plugins/opcua/opcua_extensionobjecttable.c delete mode 100644 plugins/opcua/opcua_hfindeces.c delete mode 100644 plugins/opcua/opcua_hfindeces.h delete mode 100644 plugins/opcua/opcua_identifiers.h delete mode 100644 plugins/opcua/opcua_security_layer.c delete mode 100644 plugins/opcua/opcua_security_layer.h delete mode 100644 plugins/opcua/opcua_serviceids.h delete mode 100644 plugins/opcua/opcua_serviceparser.c delete mode 100644 plugins/opcua/opcua_serviceparser.h delete mode 100644 plugins/opcua/opcua_servicetable.c delete mode 100644 plugins/opcua/opcua_servicetable.h delete mode 100644 plugins/opcua/opcua_simpletypes.c delete mode 100644 plugins/opcua/opcua_simpletypes.h delete mode 100644 plugins/opcua/opcua_statuscode.c delete mode 100644 plugins/opcua/opcua_statuscode.h delete mode 100644 plugins/opcua/opcua_transport_layer.c delete mode 100644 plugins/opcua/opcua_transport_layer.h delete mode 100644 plugins/pluginifdemo/CMakeLists.txt delete mode 100644 plugins/pluginifdemo/Makefile.am delete mode 100644 plugins/pluginifdemo/pluginifdemo.c delete mode 100644 plugins/pluginifdemo/pluginifdemo.h delete mode 100644 plugins/pluginifdemo/ui/pluginifdemo_about.cpp delete mode 100644 plugins/pluginifdemo/ui/pluginifdemo_about.h delete mode 100644 plugins/pluginifdemo/ui/pluginifdemo_main.cpp delete mode 100644 plugins/pluginifdemo/ui/pluginifdemo_main.h delete mode 100644 plugins/pluginifdemo/ui/uiclasshandler.cpp delete mode 100644 plugins/pluginifdemo/ui/uihandler.cpp delete mode 100644 plugins/pluginifdemo/ui/uihandler.h delete mode 100644 plugins/profinet/CMakeLists.txt delete mode 100644 plugins/profinet/Makefile.am delete mode 100644 plugins/profinet/packet-dcerpc-pn-io.c delete mode 100644 plugins/profinet/packet-dcom-cba-acco.c delete mode 100644 plugins/profinet/packet-dcom-cba-acco.h delete mode 100644 plugins/profinet/packet-dcom-cba.c delete mode 100644 plugins/profinet/packet-pn-dcp.c delete mode 100644 plugins/profinet/packet-pn-mrp.c delete mode 100644 plugins/profinet/packet-pn-mrrt.c delete mode 100644 plugins/profinet/packet-pn-ptcp.c delete mode 100644 plugins/profinet/packet-pn-rt.c delete mode 100644 plugins/profinet/packet-pn-rtc-one.c delete mode 100644 plugins/profinet/packet-pn.c delete mode 100644 plugins/profinet/packet-pn.h delete mode 100644 plugins/stats_tree/CMakeLists.txt delete mode 100644 plugins/stats_tree/Makefile.am delete mode 100644 plugins/stats_tree/pinfo_stats_tree.c delete mode 100644 plugins/stats_tree/pinfo_stats_tree.h delete mode 100644 plugins/stats_tree/stats_tree_plugin.c delete mode 100644 plugins/transum/CMakeLists.txt delete mode 100644 plugins/transum/Makefile.am delete mode 100644 plugins/transum/decoders.c delete mode 100644 plugins/transum/decoders.h delete mode 100644 plugins/transum/extractors.c delete mode 100644 plugins/transum/extractors.h delete mode 100644 plugins/transum/packet-transum.c delete mode 100644 plugins/transum/packet-transum.h delete mode 100644 plugins/transum/preferences.h delete mode 100644 plugins/unistim/CMakeLists.txt delete mode 100644 plugins/unistim/Makefile.am delete mode 100644 plugins/unistim/audio.h delete mode 100644 plugins/unistim/basic.h delete mode 100644 plugins/unistim/broadcast.h delete mode 100644 plugins/unistim/defines.h delete mode 100644 plugins/unistim/display.h delete mode 100644 plugins/unistim/expansion.h delete mode 100644 plugins/unistim/key.h delete mode 100644 plugins/unistim/network.h delete mode 100644 plugins/unistim/packet-unistim.c delete mode 100644 plugins/unistim/packet-unistim.h delete mode 100644 plugins/unistim/uftp.h delete mode 100644 plugins/wimax/CMakeLists.txt delete mode 100644 plugins/wimax/Makefile.am delete mode 100644 plugins/wimax/crc.c delete mode 100644 plugins/wimax/crc.h delete mode 100644 plugins/wimax/crc_data.c delete mode 100644 plugins/wimax/mac_hd_generic_decoder.c delete mode 100644 plugins/wimax/mac_hd_type1_decoder.c delete mode 100644 plugins/wimax/mac_hd_type2_decoder.c delete mode 100644 plugins/wimax/mac_mgmt_msg_decoder.c delete mode 100644 plugins/wimax/msg_aas_beam.c delete mode 100644 plugins/wimax/msg_aas_fbck.c delete mode 100644 plugins/wimax/msg_arq.c delete mode 100644 plugins/wimax/msg_clk_cmp.c delete mode 100644 plugins/wimax/msg_dcd.c delete mode 100644 plugins/wimax/msg_dlmap.c delete mode 100644 plugins/wimax/msg_dreg.c delete mode 100644 plugins/wimax/msg_dsa.c delete mode 100644 plugins/wimax/msg_dsc.c delete mode 100644 plugins/wimax/msg_dsd.c delete mode 100644 plugins/wimax/msg_dsx_rvd.c delete mode 100644 plugins/wimax/msg_fpc.c delete mode 100644 plugins/wimax/msg_pkm.c delete mode 100644 plugins/wimax/msg_pmc.c delete mode 100644 plugins/wimax/msg_prc_lt_ctrl.c delete mode 100644 plugins/wimax/msg_reg_req.c delete mode 100644 plugins/wimax/msg_reg_rsp.c delete mode 100644 plugins/wimax/msg_rep.c delete mode 100644 plugins/wimax/msg_res_cmd.c delete mode 100644 plugins/wimax/msg_rng_req.c delete mode 100644 plugins/wimax/msg_rng_rsp.c delete mode 100644 plugins/wimax/msg_sbc.c delete mode 100644 plugins/wimax/msg_ucd.c delete mode 100644 plugins/wimax/msg_ulmap.c delete mode 100644 plugins/wimax/packet-m2m.c delete mode 100644 plugins/wimax/packet-wmx.c delete mode 100644 plugins/wimax/wimax-int.h delete mode 100644 plugins/wimax/wimax_bits.h delete mode 100644 plugins/wimax/wimax_cdma_code_decoder.c delete mode 100644 plugins/wimax/wimax_compact_dlmap_ie_decoder.c delete mode 100644 plugins/wimax/wimax_compact_dlmap_ie_decoder.h delete mode 100644 plugins/wimax/wimax_compact_ulmap_ie_decoder.c delete mode 100644 plugins/wimax/wimax_compact_ulmap_ie_decoder.h delete mode 100644 plugins/wimax/wimax_fch_decoder.c delete mode 100644 plugins/wimax/wimax_ffb_decoder.c delete mode 100644 plugins/wimax/wimax_hack_decoder.c delete mode 100644 plugins/wimax/wimax_harq_map_decoder.c delete mode 100644 plugins/wimax/wimax_mac.h delete mode 100644 plugins/wimax/wimax_pdu_decoder.c delete mode 100644 plugins/wimax/wimax_phy_attributes_decoder.c delete mode 100644 plugins/wimax/wimax_tlv.c delete mode 100644 plugins/wimax/wimax_tlv.h delete mode 100644 plugins/wimax/wimax_utils.c delete mode 100644 plugins/wimax/wimax_utils.h delete mode 100644 plugins/wimaxasncp/CMakeLists.txt delete mode 100644 plugins/wimaxasncp/Makefile.am delete mode 100644 plugins/wimaxasncp/packet-wimaxasncp.c delete mode 100644 plugins/wimaxasncp/wimaxasncp_dict.h delete mode 100644 plugins/wimaxasncp/wimaxasncp_dict.l delete mode 100644 plugins/wimaxmacphy/CMakeLists.txt delete mode 100644 plugins/wimaxmacphy/Makefile.am delete mode 100644 plugins/wimaxmacphy/packet-wimaxmacphy.c delete mode 100644 plugins/wimaxmacphy/packet-wimaxmacphy.h create mode 100644 plugins/wiretap/Makefile.am.inc create mode 100644 plugins/wiretap/usbdump/AUTHORS create mode 100644 plugins/wiretap/usbdump/CMakeLists.txt create mode 100644 plugins/wiretap/usbdump/Makefile.am create mode 100644 plugins/wiretap/usbdump/README create mode 100644 plugins/wiretap/usbdump/usbdump.c delete mode 100644 summary.c delete mode 100644 summary.h delete mode 100755 tools/runa2x.sh create mode 100644 ui/file_dialog.c create mode 100644 ui/qt/manager/preference_manager.cpp create mode 100644 ui/qt/manager/preference_manager.h create mode 100644 ui/qt/manager/wireshark_preference.cpp create mode 100644 ui/qt/manager/wireshark_preference.h create mode 100644 ui/qt/models/coloring_rules_delegate.cpp create mode 100644 ui/qt/models/coloring_rules_delegate.h create mode 100644 ui/qt/models/coloring_rules_model.cpp create mode 100644 ui/qt/models/coloring_rules_model.h create mode 100644 ui/qt/models/export_objects_model.cpp create mode 100644 ui/qt/models/export_objects_model.h delete mode 100644 ui/qt/models/html_text_delegate.cpp delete mode 100644 ui/qt/models/html_text_delegate.h create mode 100644 ui/qt/models/info_proxy_model.cpp create mode 100644 ui/qt/models/info_proxy_model.h create mode 100644 ui/qt/models/pref_delegate.cpp create mode 100644 ui/qt/models/pref_delegate.h create mode 100644 ui/qt/models/pref_models.cpp create mode 100644 ui/qt/models/pref_models.h create mode 100644 ui/qt/models/tree_model_helpers.h create mode 100644 ui/qt/scsi_service_response_time_dialog.cpp create mode 100644 ui/qt/scsi_service_response_time_dialog.h create mode 100644 ui/qt/utils/idata_printable.h create mode 100644 ui/qt/widgets/export_objects_view.cpp create mode 100644 ui/qt/widgets/export_objects_view.h create mode 100644 ui/qt/widgets/pref_module_view.cpp create mode 100644 ui/qt/widgets/pref_module_view.h create mode 100644 ui/qt/widgets/range_syntax_lineedit.cpp create mode 100644 ui/qt/widgets/range_syntax_lineedit.h create mode 100644 ui/summary.c create mode 100644 ui/summary.h delete mode 100644 wsutil/airpdcap_wep.c create mode 100644 wsutil/dot11decrypt_wep.c create mode 100644 wsutil/pow2.h create mode 100644 wsutil/ws_pipe.c create mode 100644 wsutil/ws_pipe.h hooks/post-receive -- wireshark with Osmocom specific dissectors

6 years, 1 month

1
0
0 0

osmo-pcu.git branch neels/mnc3 deleted. 0.4.0-100-gf5f1c03

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, neels/mnc3 has been deleted was f5f1c03753728e6da49e5acd8dd6682d5f90426a ----------------------------------------------------------------------- f5f1c03753728e6da49e5acd8dd6682d5f90426a implement support for 3-digit MNC with leading zeros ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

6 years, 1 month

1
0
0 0

osmo-bts.git branch master updated. 0.7.0-154-g7d648b4

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 7d648b46579a557bd6bd96fceaf2f8c53b10cb1b (commit) via f72bdfaaa98b84d7b2b0fba977af70e2ac82018e (commit) from 02d1fe87f0fdf4d9e08cde9f727f00e17343c20c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=7d648b46579a557bd6bd96fceaf2f8c… commit 7d648b46579a557bd6bd96fceaf2f8c53b10cb1b Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Mar 11 21:20:41 2018 +0100 sysinfo: Fix scheduling of downlink SACCH information The existing algorithm (present since 2012!) failed to work in the sole case that only *one* SACCH filling type was present. So if you had your BTS configured to only broadcast SI5, but not broadcast SI5ter, SI6 or any other SACCH filling, it would send the SI5 message only once on a newly-established channel, and never again. The old code was working for more-than-one SACCH filling, as well as for no SACCH filling at all. Let's also add a NOTICE message if there is no SACCH filling available at all. This is highly unusual and definitely a noticeable event. Change-Id: Ica801f9b9c118f00d9e3dc2780b3123e925f59b4 Closes: OS#3057 Related: OS#2963 http://cgit.osmocom.org/osmo-bts/commit/?id=f72bdfaaa98b84d7b2b0fba977af70e… commit f72bdfaaa98b84d7b2b0fba977af70e2ac82018e Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Mar 11 20:49:19 2018 +0100 cosmetic: Document some SI scheduling related function API Change-Id: I7e61639349deda28846810c4f52dbea78dccda38 ----------------------------------------------------------------------- Summary of changes: src/common/rsl.c | 17 ++++++++++++++++- src/common/sysinfo.c | 7 +++++-- 2 files changed, 21 insertions(+), 3 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmo-bts.git branch neels/33c3 deleted. 0.4.0-349-ge95410d

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, neels/33c3 has been deleted was e95410db2b4d816fecea99514b1a3958cd720fa8 ----------------------------------------------------------------------- e95410db2b4d816fecea99514b1a3958cd720fa8 ho hack ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmo-bts.git branch neels/trx_test2 deleted. 0.4.0-503-gd79d9e6

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, neels/trx_test2 has been deleted was d79d9e674df7b4d2d710c1031d0ad66ce9ae0c63 ----------------------------------------------------------------------- d79d9e674df7b4d2d710c1031d0ad66ce9ae0c63 TRX: Use timerfd and CLOCK_MONOTONIC for GSM frame timer ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmo-bts.git branch neels/trx_test deleted. 0.4.0-512-gbbc2000

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, neels/trx_test has been deleted was bbc20004809aeb36c1a4cd2709c46ffec44719e0 ----------------------------------------------------------------------- bbc20004809aeb36c1a4cd2709c46ffec44719e0 TRX: Remove bogus extern global variable declarations ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmo-bts.git branch neels/mnc3 deleted. 0.7.0-141-g02ab01b

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, neels/mnc3 has been deleted was 02ab01b28e5b6ba3e5e7e5fdd1cc6f181102ae63 ----------------------------------------------------------------------- 02ab01b28e5b6ba3e5e7e5fdd1cc6f181102ae63 implement support for 3-digit MNC with leading zeros ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-2064-g4ccb2261

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via 4ccb2261b1ac2e207303393fe509878f160dd96b (commit) via 40e71126abc26eb4d3deea580ca8c8f1c6c8c73b (commit) via 47aaf962fbd358f5b66a2d349160f25c521e6393 (commit) via caebbebd164d5cfc4d1625cf5c11f64e85078f7f (commit) via 633c806a2bc25bac0abce6b48c5cf255cc99f8a1 (commit) via ddddf9e0c488b51d08f6127e29a2d2e48e440095 (commit) from d316b84413a4646b440ff5a5ab198a9f10aa9459 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=4ccb2261b1ac2e207303393fe5098… commit 4ccb2261b1ac2e207303393fe509878f160dd96b Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 17:28:57 2018 +0700 trxcon/sched_lchan_tchf.c: always send traffic indications We shall always send traffic frame indications, even if received frame is incomplete or decoding was failed. This is required for proper Measurement Reporting. Change-Id: I99e134699796c7075299459e96b2f2d462636619 http://cgit.osmocom.org/osmocom-bb/commit/?id=40e71126abc26eb4d3deea580ca8c… commit 40e71126abc26eb4d3deea580ca8c8f1c6c8c73b Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 17:09:44 2018 +0700 trxcon/sched_lchan_xcch.c: always send data indications We shall always send data frame indications, even if received frame is incomplete or decoding was failed. This is required for proper Measurement Reporting. Change-Id: I7beee7e797f488d04c3b59bee9501ce823717092 http://cgit.osmocom.org/osmocom-bb/commit/?id=47aaf962fbd358f5b66a2d349160f… commit 47aaf962fbd358f5b66a2d349160f25c521e6393 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 15:24:20 2018 +0700 trxcon/scheduler: enforce lchan handlers to set message type Since this change, each lchan handler shall manually indicate a type of both message indications and confirmations. Change-Id: I02e0b87d61c127d2f6f5b9532909af78332bf707 http://cgit.osmocom.org/osmocom-bb/commit/?id=caebbebd164d5cfc4d1625cf5c11f… commit caebbebd164d5cfc4d1625cf5c11f64e85078f7f Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 15:07:17 2018 +0700 trxcon/sched_lchan_common.c: use static memory allocation There is no need to allocate the DL header for each new message. Change-Id: Id7ad815c6b403f5c3d15fc02022397188f1d87fd http://cgit.osmocom.org/osmocom-bb/commit/?id=633c806a2bc25bac0abce6b48c5cf… commit 633c806a2bc25bac0abce6b48c5cf255cc99f8a1 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 14:52:35 2018 +0700 trxcon: clean up DATA / TRAFFIC indication API - change 'l1ctl_tx_data_ind' symbol to 'l1ctl_tx_dt_ind' in order to indicate that it's used for both DATA and TRAFFIC; - introduce a 'traffic' flag, which is used to define either TRAFFIC or DATA indication type; - pass L2 payload and its length separately from the Downlink info header. Change-Id: I9fe65ee9b2d772576b86b7bc85d53518530d1579 http://cgit.osmocom.org/osmocom-bb/commit/?id=ddddf9e0c488b51d08f6127e29a2d… commit ddddf9e0c488b51d08f6127e29a2d2e48e440095 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 14:34:21 2018 +0700 trxcon: clean up DATA / TRAFFIC confirmation API - change 'l1ctl_tx_data_conf' symbol to 'l1ctl_tx_dt_conf' in order to indicate that it's used for both DATA and TRAFFIC; - introduce a 'traffic' flag, which is used to define either TRAFFIC or DATA confirmation type; Change-Id: Iedd569086a264dc7d8740abea5c6e5ca21e299f6 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/l1ctl.c | 47 ++++++++++++------------ src/host/trxcon/l1ctl.h | 8 ++--- src/host/trxcon/sched_lchan_common.c | 70 +++++++++++++----------------------- src/host/trxcon/sched_lchan_tchf.c | 53 ++++++++++++++++----------- src/host/trxcon/sched_lchan_xcch.c | 17 +++++---- src/host/trxcon/sched_trx.h | 8 ++--- 6 files changed, 99 insertions(+), 104 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-2058-gd316b844

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via d316b84413a4646b440ff5a5ab198a9f10aa9459 (commit) from eb3a1cde8c29f90044ba7a0a180f7c8dc835952f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=d316b84413a4646b440ff5a5ab198… commit d316b84413a4646b440ff5a5ab198a9f10aa9459 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 14:26:20 2018 +0700 trxcon/l1ctl.c: combine both DATA and TRAFFIC REQ handlers Both functions are almost identical, and the only difference is the message type they set. Let's combine them into a single function and introduce a 'traffic' flag, which can be used to define a message type. Change-Id: I288f5d7b6cd242c4793973dcb3d2b1b6925d61a7 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/l1ctl.c | 60 +++++++++++++------------------------------------ 1 file changed, 16 insertions(+), 44 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-2057-geb3a1cde

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via eb3a1cde8c29f90044ba7a0a180f7c8dc835952f (commit) via 2136891b7bbdfbd62f28f63c8a16711d9562ec1c (commit) via a92fd3388cd7eac69e18938832be688c9a425613 (commit) from 5eae19098ac6e0563d3e176818ca6a6a4fb8656a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=eb3a1cde8c29f90044ba7a0a180f7… commit eb3a1cde8c29f90044ba7a0a180f7c8dc835952f Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 14:20:41 2018 +0700 trxcon/l1ctl_link.c: allocate msgb after its length is read Change-Id: I2b941c5ed91097c4ed2d859634bbe89f44546061 http://cgit.osmocom.org/osmocom-bb/commit/?id=2136891b7bbdfbd62f28f63c8a167… commit 2136891b7bbdfbd62f28f63c8a16711d9562ec1c Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 06:34:04 2018 +0700 trxcon: clarify L1CTL message length field Each L1CTL message gets its own length pushed in front before sending. This isn't specified in the 'l1ctl_proto.h', but assumed in the code. Let's clarify this. Change-Id: I118d00613aeaf5ff0bad1188fa5f7450d4ca8122 http://cgit.osmocom.org/osmocom-bb/commit/?id=a92fd3388cd7eac69e18938832be6… commit a92fd3388cd7eac69e18938832be688c9a425613 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Thu Mar 8 20:51:52 2018 +0700 trxcon: use meaningful names for L1CTL messages There are two types of L1CTL messages: received and to be transmitted. Let's use proper names to indicate this. Change-Id: I7c17687579282fa389bca35dc7edbc3582e55701 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/l1ctl.c | 8 +++++++- src/host/trxcon/l1ctl_link.c | 26 ++++++++++++-------------- src/host/trxcon/l1ctl_link.h | 8 ++++++++ 3 files changed, 27 insertions(+), 15 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmo-ci.git branch master updated. 07653276019511efe7e188a80c307225ac78230d

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CI scripts". The branch, master has been updated via 07653276019511efe7e188a80c307225ac78230d (commit) from a45a34e9d05d6b11430b1c33810f795afd75fe58 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-ci/commit/?id=07653276019511efe7e188a80c307225… commit 07653276019511efe7e188a80c307225ac78230d Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Wed Mar 7 14:08:35 2018 +0100 osmocom-latest-packages.sh: Catch latest tags outside master branch Some projects, like osmo-trx, may have tags created in a non-master branch. Let's catch those too. Tested with several osmocom repositories. The ones showing different behaviour are osmo-trx (expected) and other repositories which have wrong or no tags and are anyway not used since there's no OBS build for them. Old cmdline is left of ==, new is right: artwork: ( == ) asn1c: ( == ) docker-playground: (debian-jessie-buildslave-0.1.0 == ) layer1-api: (superfemto_v3.8.1 == ) libasn1c: (0.9.28 == 0.9.28) libgtpnl: (1.1.0 == 1.1.0) libosmo-abis: (0.4.0 == 0.4.0) libosmocore: (0.10.2 == 0.10.2) libosmo-netif: (0.1.1 == 0.1.1) libosmo-sccp: (0.8.1 == 0.8.1) libsmpp34: (1.12.0 == 1.12.0) meta-telephony: ( == ) mncc-python: ( == ) octphy-2g-headers: (OCTSDR-OPENBSC-02.09.00-B1121 == ) openbsc: (1.0.0 == 1.0.0) osmo-bsc: (1.1.2 == 1.1.2) osmo-bts: (0.7.0 == 0.7.0) osmo-ci: ( == ) osmocom-bb: (osmocon_v0.0.0 == ) osmo-ggsn: (1.1.0 == 1.1.0) osmo-gsm-manuals: ( == v1) osmo-gsm-tester: ( == 0.1) osmo-gsm-tester-conf: ( == ) osmo-gsm-tester-sysmocom: ( == ) osmo-hlr: (0.1.0 == 0.1.0) osmo-iuh: (0.2.0 == 0.2.0) osmo-mgw: (1.2.0 == 1.2.0) osmo-msc: (1.1.2 == 1.1.2) osmo-pcu: (0.4.0 == 0.4.0) osmo-python-tests: ( == ) osmo-sgsn: (1.2.0 == 1.2.0) osmo-sip-connector: (1.1.0 == 1.1.0) osmo-trx: (0.2.0 == 0.3.0) pysim: ( == ) python-smpplib: ( == ) Change-Id: I3b521a194f0ae9fdfa358423e66f30c1316c23e8 ----------------------------------------------------------------------- Summary of changes: scripts/osmocom-latest-packages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CI scripts

6 years, 1 month

1
0
0 0

osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-2054-g5eae1909

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via 5eae19098ac6e0563d3e176818ca6a6a4fb8656a (commit) via 4cf722364bdafd90d12984531e4ec8c8548d6579 (commit) from c00985bf99cd38cab7f50855866524a4a60d47dd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=5eae19098ac6e0563d3e176818ca6… commit 5eae19098ac6e0563d3e176818ca6a6a4fb8656a Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Sun Mar 11 04:18:06 2018 +0700 trxcon/scheduler: transmit dummy frames on CBTX lchans If at the moment of transmission there are no frames in TX buffer, then either a dummy LAPDm frame (0x01, 0x03, 0x01, 0x2b ...) or a silence frame (depending on a codec in use) shall be transmitted. This is required for proper measurements on the BTS side. Change-Id: Ie590990f2274ea476678f6b2079f90eeadab6501 http://cgit.osmocom.org/osmocom-bb/commit/?id=4cf722364bdafd90d12984531e4ec… commit 4cf722364bdafd90d12984531e4ec8c8548d6579 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Sun Mar 11 03:19:33 2018 +0700 trxcon/scheduler: introduce a new CBTX lchan flag This new flag is intended to indicate that continuous burst transmission is assumed on particular logical channel. In other words, if a logical channel has this flag, but there is nothing to transmit in a TX buffer, then either a dummy LAPDm frame or a silence frame shall be sent. Change-Id: I25fcf9eeb787ffe5378d92532439e67d7d42fa65 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/sched_lchan_desc.c | 60 ++++++++++++------------- src/host/trxcon/sched_prim.c | 89 ++++++++++++++++++++++++++++++++++++++ src/host/trxcon/sched_trx.c | 13 ++++++ src/host/trxcon/sched_trx.h | 14 ++++++ src/host/trxcon/trxcon.c | 4 ++ 5 files changed, 150 insertions(+), 30 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmocom-bb.git branch fixeria/trx updated. osmocon_v0.0.0-2052-gc00985bf

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, fixeria/trx has been updated via c00985bf99cd38cab7f50855866524a4a60d47dd (commit) via 2778e4ef432c261cbeaeb344137c465adc8393dd (commit) via f06f31fdf7e0fc4fd2d4cb3a444855bfaafd59da (commit) via cbf818d4dcba53b226df8d36966482dc8b6d6ef4 (commit) from 7fd8ef2d3f3d296a6032745396d3af8e8e3d4da2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmocom-bb/commit/?id=c00985bf99cd38cab7f5085586652… commit c00985bf99cd38cab7f50855866524a4a60d47dd Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Sun Mar 11 03:16:40 2018 +0700 trxcon/sched_trx.h: clarify lchan flags meaning Change-Id: I51b663dd16e46a4523488c3d3000922a7c3640d1 http://cgit.osmocom.org/osmocom-bb/commit/?id=2778e4ef432c261cbeaeb344137c4… commit 2778e4ef432c261cbeaeb344137c465adc8393dd Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Sun Mar 11 04:20:57 2018 +0700 trxcon/sched_trx.c: fix: omit inactive logical channels The sched_frame_clck_cb() is responsible for UL burst transmission. Iterating over each timeslot, it chooses a proper lchan handler according to a current frame number and a multiframe layout in use, takes a L2 UL frame from a TX buffer, and finally calls the chosen handler in order to to encode and transmit a taken frame. A handler should be called only for activated logical channels... but for some long time, there was a bug, so each lchan was processed, including inactive ones. It's time to fix this. Change-Id: I33e3ecc14be3ae64dfd02789c7f0970c945582c9 http://cgit.osmocom.org/osmocom-bb/commit/?id=f06f31fdf7e0fc4fd2d4cb3a44485… commit f06f31fdf7e0fc4fd2d4cb3a444855bfaafd59da Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 15:33:59 2018 +0700 trxcon/sched_trx.c: fix: properly deallocate lchans The llist_for_each_entry_safe() should be used instead of the llist_for_each_entry(), because it's safe against removal of llist entry. Found using Valgrind's memcheck tool. Change-Id: I65234971ec152df038c5388da537a503060c215b http://cgit.osmocom.org/osmocom-bb/commit/?id=cbf818d4dcba53b226df8d3696648… commit cbf818d4dcba53b226df8d36966482dc8b6d6ef4 Author: Vadim Yanitskiy <axilirator(a)gmail.com> Date: Fri Mar 9 16:20:12 2018 +0700 trxcon/configure.ac: add --enable-sanitize option Change-Id: I099de726f9d67213c56d996039b4207f80a727c6 ----------------------------------------------------------------------- Summary of changes: src/host/trxcon/configure.ac | 11 +++++++++++ src/host/trxcon/sched_trx.c | 10 ++++++++-- src/host/trxcon/sched_trx.h | 4 +++- 3 files changed, 22 insertions(+), 3 deletions(-) hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmo-bts.git branch master updated. 0.7.0-152-g02d1fe8

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 02d1fe87f0fdf4d9e08cde9f727f00e17343c20c (commit) from 29cd7a84089b4a29748a0c9723f539bc6005ad99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=02d1fe87f0fdf4d9e08cde9f727f00e… commit 02d1fe87f0fdf4d9e08cde9f727f00e17343c20c Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Wed Feb 21 00:38:05 2018 +0100 implement support for 3-digit MNC with leading zeros Record the mnc_3_digits flag from SI and pass on via the PCU interface. Instead of changing to e.g. osmo_plmn_id, add the flag separately, and instead of bool use a uint8_t, to not raise any struct packing issues and clarify the flag's size beyond any doubt. Bump the PCU interface version to 9. This is one part of the three identical pcuif_proto.h patches: - I49cd762c3c9d7ee6a82451bdf3ffa2a060767947 (osmo-bts) - I787fed84a7b613158a5618dd5cffafe4e4927234 (osmo-pcu) - I78f30aef7aa224b2e9db54c3a844d8f520b3aee0 (osmo-bsc) Depends: Id2240f7f518494c9df6c8bda52c0d5092f90f221 (libosmocore) Change-Id: I49cd762c3c9d7ee6a82451bdf3ffa2a060767947 ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/gsm_data.h | 3 ++- include/osmo-bts/pcuif_proto.h | 6 ++++-- src/common/pcu_sock.c | 15 +++++---------- 3 files changed, 11 insertions(+), 13 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmo-pcu.git branch master updated. 0.4.0-100-gbdc55fa

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via bdc55fad62e333951a0eb1fc7b96aaaec16dd6ff (commit) from 8343b4adbbe9afd4294232429696ee9736ec1004 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=bdc55fad62e333951a0eb1fc7b96aaa… commit bdc55fad62e333951a0eb1fc7b96aaaec16dd6ff Author: Neels Hofmeyr <neels(a)hofmeyr.de> Date: Wed Feb 21 00:39:07 2018 +0100 implement support for 3-digit MNC with leading zeros Receive the mnc_3_digits flag from the PCU interface. Bump the PCU interface to 9. This is one part of the three identical pcuif_proto.h patches: - I49cd762c3c9d7ee6a82451bdf3ffa2a060767947 (osmo-bts) - I787fed84a7b613158a5618dd5cffafe4e4927234 (osmo-pcu) - I78f30aef7aa224b2e9db54c3a844d8f520b3aee0 (osmo-bsc) Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout the code base to be able to handle an MNC < 100 that has three digits (leading zeros). Depends: Id2240f7f518494c9df6c8bda52c0d5092f90f221 (libosmocore), Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6 (libosmocore) Change-Id: I787fed84a7b613158a5618dd5cffafe4e4927234 ----------------------------------------------------------------------- Summary of changes: include/osmocom/pcu/pcuif_proto.h | 6 ++++-- src/gprs_bssgp_pcu.cpp | 15 +++++++++------ src/gprs_bssgp_pcu.h | 2 +- src/pcu_l1_if.cpp | 11 ++++++----- src/pcu_main.cpp | 6 +++++- tests/alloc/AllocTest.cpp | 1 + tests/alloc/MslotTest.cpp | 1 + tests/edge/EdgeTest.cpp | 1 + tests/emu/pcu_emu.cpp | 3 ++- tests/fn/FnTest.cpp | 1 + tests/llc/LlcTest.cpp | 1 + tests/ms/MsTest.cpp | 1 + tests/tbf/TbfTest.cpp | 11 ++++++----- tests/types/TypesTest.cpp | 1 + 14 files changed, 40 insertions(+), 21 deletions(-) hooks/post-receive -- UNNAMED PROJECT

6 years, 1 month

1
0
0 0

osmocom-bb.git branch stumpf/virt-phy deleted. osmocon_v0.0.0-1781-gbdf22f10

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The Open Source GSM Base Band stack". The branch, stumpf/virt-phy has been deleted was bdf22f106290cbb48f6bbe0c3515c4270f2b581b ----------------------------------------------------------------------- bdf22f106290cbb48f6bbe0c3515c4270f2b581b VIRT-PHY: Configurable signal power reductions for multiple arfcns. ----------------------------------------------------------------------- hooks/post-receive -- The Open Source GSM Base Band stack

6 years, 1 month

1
0
0 0

osmo-bts.git branch master updated. 0.7.0-151-g29cd7a8

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 29cd7a84089b4a29748a0c9723f539bc6005ad99 (commit) from 58a95ac799034fdb60ec277eb23bc3c411d7c5e6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=29cd7a84089b4a29748a0c9723f539b… commit 29cd7a84089b4a29748a0c9723f539bc6005ad99 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Mar 10 11:27:43 2018 +0100 sysmobts: Compatibility with older firmware versions When using a firmware version < 3.6, the call to l1if_mute_rf() returned an error, which caused an OML CHG ADM STATE NACK. Let's check if the l1if_mute_rf() call is an un-mute for all timeslots (which apparently we do always at start-up). If it is, then acknowledge it even if muting is not supported by earlier firmwares. I suppose the change causing this problem was introduced in: commit b26b8fc77692e851469f3e27b9aeaeff233ffd2e Author: Holger Hans Peter Freyther <zecke(a)selfish.org> Date: Tue Mar 4 15:03:59 2014 +0100 sysmobts: Do a RF mute at initialization when the RC is locked With the current change applied, we can run the BTS with earlier firmware versions than 3.6.0 again. Tested with 3.1 and 2.4 Change-Id: I1a29c1031d96e65a0111bc812a90f2dbaf2a5aa3 ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-sysmo/l1_if.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0

osmo-bts.git branch master updated. 0.7.0-150-g58a95ac

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 58a95ac799034fdb60ec277eb23bc3c411d7c5e6 (commit) from c2045474b1b500a6cc38c00cc807978ce9e8c5e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=58a95ac799034fdb60ec277eb23bc3c… commit 58a95ac799034fdb60ec277eb23bc3c411d7c5e6 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Mar 9 22:15:53 2018 +0100 sysinfo.c: SI1 is optional; Send SI2 at TC=0 if no SI1 exists SI1 is only required if frequency hopping is used or if NCH is used. So it's optional. If OsmoBTS has no SI1 configured, it will transmit the empty SI1 buffer at TC=0, and as a result no valid SI will be broadcast at TC=0. Change-Id: I41ab885c00e943199b2e939e98f30e267ecffbee Closes: OS#3051 ----------------------------------------------------------------------- Summary of changes: src/common/sysinfo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

6 years, 1 month

1
0
0 0