This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 89d20b60efd408d79328869f97a8103c776bf0ef (commit)
via 23d37c91aff55a741d62b5d348cf791a1df6a6c8 (commit)
from a9f2bb5ab878ad192cd5a593596a6450e6ff7b58 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=89d20b60efd408d79328869f97a8103c…
commit 89d20b60efd408d79328869f97a8103c776bf0ef
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 26 12:59:36 2016 +0200
vty_test_runner.py: raise exception when MSC socket connection fails
Instead of below error, raise an exception to describe what's happening.
Seen in a jenkins run on https://gerrit.osmocom.org/#/c/945/2:
ERROR: testBSCreload (__main__.TestVTYNAT)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./vty_test_runner.py", line 787, in testBSCreload
msc = nat_msc_test(self, ip, port)
File "./vty_test_runner.py", line 1251, in nat_msc_test
return conn
UnboundLocalError: local variable 'conn' referenced before assignment
Change-Id: Iae26e7345267a21aed0b108b089453832889c9fa
http://cgit.osmocom.org/openbsc/commit/?id=23d37c91aff55a741d62b5d348cf791a…
commit 23d37c91aff55a741d62b5d348cf791a1df6a6c8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 26 03:18:32 2016 +0200
cosmetic: vty_test_runner.py: add comment for vim auto settings
Change-Id: I61a0476a0317b011432bb4f6f593cfdcaf1c072b
-----------------------------------------------------------------------
Summary of changes:
openbsc/tests/vty_test_runner.py | 6 ++++++
1 file changed, 6 insertions(+)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, neels/sock_err_msg has been deleted
was 96a94347798540e8918fcaca84ce2aac53a9373e
-----------------------------------------------------------------------
96a94347798540e8918fcaca84ce2aac53a9373e osmo_sock_init(): include host and port in error messages
-----------------------------------------------------------------------
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/dyn_fixes2 has been updated
discards f3f9d145485283422ea4dec7a13f1a2b1e6290dd (commit)
discards babda0e61b06f30df8d2fb5333bde756cce7e3fd (commit)
discards 22687129cda65bafbc7b19e2f97e1e5822edbae8 (commit)
discards fbcbbef242c281378eeff0396bd719ceeedb6000 (commit)
discards aecaee097d8deb27928186bebca272b5c838f3d7 (commit)
discards 508a0786fd23407c358c8fe2a4c56dfff7eb8fc5 (commit)
via dbeff7df7fd32505831ffaee6dc1a9fcb615a42b (commit)
via 722349ea9b68b3ffed1e403998eba2a003fed2d8 (commit)
via f7a4652a6e457560b836d9888e107bb7487c5ad8 (commit)
via 29868172586c8920c902a22dca30c3b01baa8c0b (commit)
via 5e1fa3e58c99f00ba7b1d492597a830df33f00f4 (commit)
via 6cc709d4b1e2552dddcb9611173ec24f7f9e9afc (commit)
via a9f2bb5ab878ad192cd5a593596a6450e6ff7b58 (commit)
via 5e0b0a658fdc8d42de434eb1939352c55eeed30f (commit)
via 663debcb90022f1ca53b0d947162774c8a1ec9c5 (commit)
via 43d86bfc94969ac9738ce398d13bd0a974e90df0 (commit)
via c13e68774215c4156925e8a2012fcb9169cf70b2 (commit)
via 77c8d5ffb52bd5da405fc869286b4f7aa7f88d4d (commit)
via d90fa42dc9f1fbf3d1d92a1749742ecb1c5d537e (commit)
via 0ce98c749a37cc365ab77224d36d6f68061ef727 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (f3f9d145485283422ea4dec7a13f1a2b1e6290dd)
\
N -- N -- N (dbeff7df7fd32505831ffaee6dc1a9fcb615a42b)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=dbeff7df7fd32505831ffaee6dc1a9fc…
commit dbeff7df7fd32505831ffaee6dc1a9fcb615a42b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:15:59 2016 +0200
dyn TS: fix: abis_om2000: also handle dyn TS as TCH
Add ts2comb() to switch on dyn TS so that dyn TS in TCH mode are also treated
like normal TCH/H or TCH/F pchans. Use ts2comb() instead of pchan2comb().
Change-Id: Iddc51a4409488d91db59228ca66aaab73ce3f1df
http://cgit.osmocom.org/openbsc/commit/?id=722349ea9b68b3ffed1e403998eba2a0…
commit 722349ea9b68b3ffed1e403998eba2a003fed2d8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:07:01 2016 +0200
dyn TS: fix: bs11, om2000: two switch(pchan) for dyn TS
Add ts_is_tch() in gsm_data_shared.h/.c and use it to replace a switch on the
pchan in two (unrelated) places: libbsc/bts_siemens_bs11.c and e1_config.c.
This patch is not due to an actual observed failure. A general grep for switch
on pchan turned up these two instances that don't handle dyn TS properly. Hence
this patch is not actually tested with real equipment.
Change-Id: Ide4f156034bab77140d2d9a8c462d68ae6f0d6a6
http://cgit.osmocom.org/openbsc/commit/?id=f7a4652a6e457560b836d9888e107bb7…
commit f7a4652a6e457560b836d9888e107bb7487c5ad8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:33:02 2016 +0200
dyn TS: fix: ts_subslots() for TCH/F_PDCH in PDCH mode
In gsm_data_shared.c, add ts_pchan() to determine actual pchan type for dynamic
and non-dynamic TS.
Use in ts_subslots() to fix the value returned for TCH/F_PDCH in PDCH mode.
Adjust the assertion in channel_test.c accordingly.
Drop GSM_PCHAN_TCH_F_PDCH, which is now handled in ts_pchan().
Explicitly add GSM_PCHAN_PDCH as zero in subslots_per_pchan[] (cosmetic).
Adjust the comment in subslots_per_pchan[].
The fix for the number of subslots affects only one caller: bts_chan_load() in
chan_alloc.c. Before this, it would always include a TCH/F_PDCH in the
load_counter->total, now it is skipped when in PDCH mode. Whether this is the
way bts_chan_load() should handle dynamic TS is a separate discussion, so far
I'm only making sure that the two dyn TS kinds act in the same way:
TCH/F_TCH/H_PDCH is only counted when in TCH mode, and TCH/F_PDCH should match.
Change-Id: Icd6668667ad2be7ad20866ffd185bf3b8711ccd6
http://cgit.osmocom.org/openbsc/commit/?id=29868172586c8920c902a22dca30c3b0…
commit 29868172586c8920c902a22dca30c3b01baa8c0b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 17:01:20 2016 +0200
Revert "bts: extend bts_chan_load to allow counting tch only"
This reverts commit 308cb0719dca3ba8eed1eff2a2124d44f34d9a28.
Problems in this commit:
openbsc/src/libbsc/chan_alloc.c:523: case GSM_PCHAN_TCH_F_PDCH:
This is actually wrong, GSM_PCHAN_TCH_F_PDCH use ts->flags, not ts->dyn below
(due to historical reasons and could be unified).
560: if (only_count_tch && !chan_is_tch(ts))
This has exactly one effect: it excludes GSM_PCHAN_TCH_F_PDCH when in PDCH
mode, because for all other PDCH (plain PDCH and TCH/F_TCH/H_PDCH in PDCH mode)
below ts_subslots() returns 0 and skips the for() loop. I consider this a bug
in TCH/F_PDCH, to be fixed in an upcoming commit.
I don't see why we need the only_count_tch argument, because this should
normally only count TCH, weren't it for the TCH/F_PDCH bug.
If dyn TS should be counted differently, we should do this in a different way.
Change-Id: I34dbbaf53a800115e3d03bd44028cad675f3b525
http://cgit.osmocom.org/openbsc/commit/?id=5e1fa3e58c99f00ba7b1d492597a830d…
commit 5e1fa3e58c99f00ba7b1d492597a830df33f00f4
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:58:01 2016 +0200
channel_test: test nr of subslots for dyn pchan, with error
Add test_dyn_ts_subslots() and call from main(). Update channel_test.ok.
This includes erratic assert to show a bug for TCH/F_PDCH in PDCH mode: the nr
of subslots should be the same as for a normal PDCH, i.e. zero. This will be
adjusted along with the fix in an upcoming commit.
Change-Id: I09685be3fb3ed1ead4577b772a9fbc31967980d1
http://cgit.osmocom.org/openbsc/commit/?id=6cc709d4b1e2552dddcb9611173ec24f…
commit 6cc709d4b1e2552dddcb9611173ec24f7f9e9afc
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:47:36 2016 +0200
channel test: prepare to add another test function
Move the main() guts to test_request_chan(), so that I can add another test in
an upcoming commit.
Change-Id: I1349d0f416806416080d4667ad697f7db1ea252d
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/bsc_api.h | 2 -
openbsc/include/openbsc/gsm_data.h | 12 +++++-
openbsc/include/openbsc/vty.h | 4 +-
openbsc/src/ipaccess/ipaccess-config.c | 2 +-
openbsc/src/libbsc/abis_nm_vty.c | 4 +-
openbsc/src/libbsc/abis_om2000_vty.c | 4 +-
openbsc/src/libbsc/bsc_api.c | 23 +++++------
openbsc/src/libbsc/bsc_init.c | 7 +---
openbsc/src/libbsc/bsc_vty.c | 2 +-
openbsc/src/libbsc/net_init.c | 7 +++-
openbsc/src/libcommon/talloc_ctx.c | 33 ++++++++-------
openbsc/src/libmsc/gsm_04_08.c | 73 +++++++++++++++-------------------
openbsc/src/libmsc/gsm_04_11.c | 22 +++++-----
openbsc/src/libmsc/rrlp.c | 2 +-
openbsc/src/libmsc/transaction.c | 4 +-
openbsc/src/osmo-bsc/osmo_bsc_ctrl.c | 2 +-
openbsc/src/osmo-bsc/osmo_bsc_main.c | 2 +-
openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 2 +-
openbsc/src/osmo-nitb/bsc_hack.c | 6 +--
openbsc/src/utils/bs11_config.c | 2 +-
openbsc/tests/channel/channel_test.c | 2 +-
openbsc/tests/gsm0408/gsm0408_test.c | 4 +-
22 files changed, 109 insertions(+), 112 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom code for Iuh interface".
The branch, neels/ipa_nano3g has been updated
discards 5e21c59988f1d8067562c1dfab73536134b80087 (commit)
discards 33802daf23372019c92f49fa73fc5cf0038dc3ce (commit)
discards 75a61858d5bdee9afed1be059b45666702dfdda0 (commit)
discards bc03eeeee2dc9b330a7775e652d19b269530c5e9 (commit)
via e5c5fd80e1fa77fc766e43003c35947fe99a0840 (commit)
via 8823fc735777e5bc06993845a2ce8c8de5fd090c (commit)
via deb302cb613157b4ee439cc803537684f7ec64ab (commit)
via 56d16886a379270ae4afea9245182b4fa3763e2b (commit)
via e6877b1e35fa339b572f2f393a014036047b1ca5 (commit)
via 74b0565d9f1a7abbd665b8456b7a851e1d47f0a8 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (5e21c59988f1d8067562c1dfab73536134b80087)
\
N -- N -- N (e5c5fd80e1fa77fc766e43003c35947fe99a0840)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/iuh/hnbgw.h | 3 +-
src/hnbgw.c | 6 +-
src/hnbgw_hnbap.c | 150 ++++++++++++++++++++++++++++++++++++++++++--
src/hnbgw_vty.c | 25 ++++++--
4 files changed, 169 insertions(+), 15 deletions(-)
hooks/post-receive
--
Osmocom code for Iuh interface
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom code for Iuh interface".
The branch, sysmocom/ipa_nano3G has been updated
discards 75a61858d5bdee9afed1be059b45666702dfdda0 (commit)
discards bc03eeeee2dc9b330a7775e652d19b269530c5e9 (commit)
via e5c5fd80e1fa77fc766e43003c35947fe99a0840 (commit)
via 8823fc735777e5bc06993845a2ce8c8de5fd090c (commit)
via deb302cb613157b4ee439cc803537684f7ec64ab (commit)
via 56d16886a379270ae4afea9245182b4fa3763e2b (commit)
via e6877b1e35fa339b572f2f393a014036047b1ca5 (commit)
via 74b0565d9f1a7abbd665b8456b7a851e1d47f0a8 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (75a61858d5bdee9afed1be059b45666702dfdda0)
\
N -- N -- N (e5c5fd80e1fa77fc766e43003c35947fe99a0840)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-iuh/commit/?id=e5c5fd80e1fa77fc766e43003c35947…
commit e5c5fd80e1fa77fc766e43003c35947fe99a0840
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 26 01:07:19 2016 +0200
hnbgw: vty conformance: rename iuh 'bind' command to 'local-ip'
The standard osmo VTY terminology is 'remote-ip', 'remote-port', 'local-ip',
'local-port'. Conform to that. osmo-hnbgw is so far not rolled out widely, so
it makes sense to do this now.
Change-Id: Ifda2653bf58044552a5f1477cd7008dec3fb9100
http://cgit.osmocom.org/osmo-iuh/commit/?id=8823fc735777e5bc06993845a2ce8c8…
commit 8823fc735777e5bc06993845a2ce8c8de5fd090c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 19:37:29 2016 +0200
log: hnbgw: add hnbap UE context allocation info log
Change-Id: Iac0ca948d6e699d984c6e424afe7106dcaf2ab1e
http://cgit.osmocom.org/osmo-iuh/commit/?id=deb302cb613157b4ee439cc80353768…
commit deb302cb613157b4ee439cc803537684f7ec64ab
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Apr 25 15:05:32 2016 +0200
hnbap: accept UE Register Requests with TMSI and pTMSI
Add the option to allow UE Register Requests with a TMSI identity.
Add VTY command to enable this option, 'hnbap-allow-tmsi'.
Add hnbgw_tx_ue_register_acc_tmsi().
HNBGW so far keeps track of UEs that have registered, with their IMSI. When a
UE registers with only a TMSI, we obviously can't store an IMSI. However, since
we're so far never *using* the list of UEs in osmo-hnbgw, we might as well just
accept the TMSI registration and carry on as usual. All that is needed for
proper operation is a valid UE context.
This is aimed at the ip.access nano3G femto cell, as it apparently feeds
whichever identification the UE sends through to HNBAP (TMSI+LAI, pTMSI+RAI),
instead of an IMSI as expected. So far this caused failures and the need to
make the UE clear its TMSI (wait several minutes or attempt to subscribe to a
different network), so that UE registration switched back to IMSI. When simply
accepting the TMSI in osmo-hngw, no problems are apparent in our current code
state.
For example, a Samsung Galaxy S4 seems to send a UE_Identity_PR_tMSILAI (CS
identity), and a GT-I9100 seems to send a UE_Identity_PR_pTMSIRAI (PS identity)
upon first registration to the network.
Recording the IMSI in hnbgw: we could use the subscriber list during paging, to
page a UE on only its last seen HNB. On the other hand, it doesn't hurt to
anyway always page to all HNBs connected to osmo-hnbgw. The paging procedure
does include a page-to-all-HNBs in case the first HNB paging fails. But we must
be aware that UEs that register by TMSI will simply not have an IMSI recorded
in the list of UE contexts, so a lookup based on IMSI may fail.
Patch-by: Harald Welte <laforge(a)gnumonks.org>, me
Change-Id: I87bc1aa3e85815ded7ac1dbdca48f1680b468589
http://cgit.osmocom.org/osmo-iuh/commit/?id=56d16886a379270ae4afea9245182b4…
commit 56d16886a379270ae4afea9245182b4fa3763e2b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Sep 22 18:06:59 2016 +0200
hnbgw: UE context: add handling by tmsi identification
To prepare for an upcoming commit that accepts TMSI identification upon UE
Register Requests:
Add tmsi arg to ue_context_alloc().
Add ue_context_by_tmsi().
This is aimed at the ip.access nano3G femto cell, as it apparently feeds
whichever identification the UE sends through to HNBAP (TMSI+LAI, pTMSI+RAI),
instead of an IMSI as expected.
See the upcoming commit that enables accepting TMSI identities for further
detail.
Change-Id: I138458443319cc4cbea5ee7906cf5dd72d582130
http://cgit.osmocom.org/osmo-iuh/commit/?id=e6877b1e35fa339b572f2f393a01403…
commit e6877b1e35fa339b572f2f393a014036047b1ca5
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 26 01:27:55 2016 +0200
hnbap: add UE Register Reject for pTMSIRAI identity
This is aimed at the ip.access nano3G femto cell, as it apparently feeds
whichever identification the UE sends through to HNBAP (TMSI+LAI, pTMSI+RAI),
instead of an IMSI as expected.
Sending a proper registration reject speeds up the response seen on the UE and
avoids needless waiting.
See the upcoming commit that enables accepting TMSI identities for further
detail.
Change-Id: I03b69613e6ddd8a08d9358ffc2f74954c231fd2c
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/iuh/hnbgw.h | 3 +-
src/hnbgw.c | 5 +-
src/hnbgw_hnbap.c | 150 ++++++++++++++++++++++++++++++++++++++++++--
src/hnbgw_vty.c | 25 ++++++--
src/ranap_msg_factory.c | 5 +-
5 files changed, 174 insertions(+), 14 deletions(-)
hooks/post-receive
--
Osmocom code for Iuh interface
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/ipa_nano3G has been updated
via 374c6957a665c8fc589b405cd0cc59cd750933b0 (commit)
from 621dfcbad2a8f56064823d2d21bd99ed1e76d825 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=374c6957a665c8fc589b405cd0cc59cd…
commit 374c6957a665c8fc589b405cd0cc59cd750933b0
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Sep 26 22:49:12 2016 +0200
log VTY telnet bind only once
After libosmocore 55dc2edc89c1a85187ef8aafc09f7d922383231f which outputs
'telnet at <ip> <port>' from telnet_init_dynif(), there's no need to log the
telnet VTY bind here anymore.
Change-Id: I97a730b28759df1d549a5049f47a3da1c16a3447
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gb_proxy_main.c | 2 --
openbsc/src/gprs/gtphub_main.c | 2 --
openbsc/src/gprs/sgsn_main.c | 2 --
openbsc/src/libbsc/bsc_init.c | 2 --
openbsc/src/osmo-bsc_mgcp/mgcp_main.c | 2 --
openbsc/src/osmo-bsc_nat/bsc_nat.c | 2 --
6 files changed, 12 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/dyn_fixes2 has been created
at f3f9d145485283422ea4dec7a13f1a2b1e6290dd (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=f3f9d145485283422ea4dec7a13f1a2b…
commit f3f9d145485283422ea4dec7a13f1a2b1e6290dd
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:15:59 2016 +0200
dyn TS: fix: abis_om2000: also handle dyn TS as TCH
Add ts2comb() to switch on dyn TS so that dyn TS in TCH mode are also treated
like normal TCH/H or TCH/F pchans. Use ts2comb() instead of pchan2comb().
Change-Id: Iddc51a4409488d91db59228ca66aaab73ce3f1df
http://cgit.osmocom.org/openbsc/commit/?id=babda0e61b06f30df8d2fb5333bde756…
commit babda0e61b06f30df8d2fb5333bde756cce7e3fd
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:07:01 2016 +0200
dyn TS: fix: bs11, om2000: two switch(pchan) for dyn TS
Add ts_is_tch() in gsm_data_shared.h/.c and use it to replace a switch on the
pchan in two (unrelated) places: libbsc/bts_siemens_bs11.c and e1_config.c.
This patch is not due to an actual observed failure. A general grep for switch
on pchan turned up these two instances that don't handle dyn TS properly. Hence
this patch is not actually tested with real equipment.
Change-Id: Ide4f156034bab77140d2d9a8c462d68ae6f0d6a6
http://cgit.osmocom.org/openbsc/commit/?id=22687129cda65bafbc7b19e2f97e1e58…
commit 22687129cda65bafbc7b19e2f97e1e5822edbae8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:33:02 2016 +0200
dyn TS: fix: ts_subslots() for TCH/F_PDCH in PDCH mode
In gsm_data_shared.c, add ts_pchan() to determine actual pchan type for dynamic
and non-dynamic TS.
Use in ts_subslots() to fix the value returned for TCH/F_PDCH in PDCH mode.
Adjust the assertion in channel_test.c accordingly.
Drop GSM_PCHAN_TCH_F_PDCH, which is now handled in ts_pchan().
Explicitly add GSM_PCHAN_PDCH as zero in subslots_per_pchan[] (cosmetic).
Adjust the comment in subslots_per_pchan[].
The fix for the number of subslots affects only one caller: bts_chan_load() in
chan_alloc.c. Before this, it would always include a TCH/F_PDCH in the
load_counter->total, now it is skipped when in PDCH mode. Whether this is the
way bts_chan_load() should handle dynamic TS is a separate discussion, so far
I'm only making sure that the two dyn TS kinds act in the same way:
TCH/F_TCH/H_PDCH is only counted when in TCH mode, and TCH/F_PDCH should match.
Change-Id: Icd6668667ad2be7ad20866ffd185bf3b8711ccd6
http://cgit.osmocom.org/openbsc/commit/?id=fbcbbef242c281378eeff0396bd719ce…
commit fbcbbef242c281378eeff0396bd719ceeedb6000
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 17:01:20 2016 +0200
Revert "bts: extend bts_chan_load to allow counting tch only"
This reverts commit 308cb0719dca3ba8eed1eff2a2124d44f34d9a28.
Problems in this commit:
openbsc/src/libbsc/chan_alloc.c:523: case GSM_PCHAN_TCH_F_PDCH:
This is actually wrong, GSM_PCHAN_TCH_F_PDCH use ts->flags, not ts->dyn below
(due to historical reasons and could be unified).
560: if (only_count_tch && !chan_is_tch(ts))
This has exactly one effect: it excludes GSM_PCHAN_TCH_F_PDCH when in PDCH
mode, because for all other PDCH (plain PDCH and TCH/F_TCH/H_PDCH in PDCH mode)
below ts_subslots() returns 0 and skips the for() loop. I consider this a bug
in TCH/F_PDCH, to be fixed in an upcoming commit.
I don't see why we need the only_count_tch argument, because this should
normally only count TCH, weren't it for the TCH/F_PDCH bug.
If dyn TS should be counted differently, we should do this in a different way.
Change-Id: I34dbbaf53a800115e3d03bd44028cad675f3b525
http://cgit.osmocom.org/openbsc/commit/?id=aecaee097d8deb27928186bebca272b5…
commit aecaee097d8deb27928186bebca272b5c838f3d7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:58:01 2016 +0200
channel_test: test nr of subslots for dyn pchan, with error
Add test_dyn_ts_subslots() and call from main(). Update channel_test.ok.
This includes erratic assert to show a bug for TCH/F_PDCH in PDCH mode: the nr
of subslots should be the same as for a normal PDCH, i.e. zero. This will be
adjusted along with the fix in an upcoming commit.
Change-Id: I09685be3fb3ed1ead4577b772a9fbc31967980d1
http://cgit.osmocom.org/openbsc/commit/?id=508a0786fd23407c358c8fe2a4c56dff…
commit 508a0786fd23407c358c8fe2a4c56dfff7eb8fc5
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Sun Sep 25 15:47:36 2016 +0200
channel test: prepare to add another test function
Move the main() guts to test_request_chan(), so that I can add another test in
an upcoming commit.
Change-Id: I1349d0f416806416080d4667ad697f7db1ea252d
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 8319a6799ffc9d4c5e7e094b96af30cbebf89f65 (commit)
via 4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6 (commit)
from e31cf8057f65ec0d8d141eb8f64d5c0e61204f6c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=8319a6799ffc9d4c5e7e094b96af…
commit 8319a6799ffc9d4c5e7e094b96af30cbebf89f65
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Sep 21 18:30:01 2016 +0200
bitrev_test: don't omit last byte from test result check
The osmo_hexdump of the output in sh_chk() omitted the last byte of the
returned bytes from the osmo_nibble_shift_*() functions.
Determine the number of bytes from nibbles divided by two plus one for any odd
nibble number. Output this number of bytes of output data.
Memset the output buffer to get well-defined bytes for unwritten places.
Also assert that we have enough buffer length for all nibbles.
Change-Id: I011f42bca555caec0dfe8688ff1f28303fa04fad
http://cgit.osmocom.org/libosmocore/commit/?id=4fd6023b0383e7efa3b7b0211104…
commit 4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6
Author: Max <msuraev(a)sysmocom.de>
Date: Tue Sep 20 16:33:50 2016 +0200
Fix ASAN failure in bitrev_test
Previously while testing osmo_nibble_shift_left_unal() following error was
triggered by AddressSanitizer upon offs == 12 and the last sh_chk line, i.e.
shift left of 12 nibbles from in2:
==3890== ERROR: AddressSanitizer: stack-buffer-overflow on address 0xbff5b5b6 at pc 0xb6186862 bp 0xbff5b4a8 sp 0xbff5b49c
READ of size 1 at 0xbff5b5b6 thread T0
#0 0xb6186861 (/home/msuraev/source/gsm/libosmocore/src/.libs/libosmocore.so.7.0.0+0xc861)
#1 0x8049d8b (/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x8049d8b)
#2 0x804a9d1 (/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x804a9d1)
#3 0xb5fe3af2 (/lib/i386-linux-gnu/libc-2.19.so+0x19af2)
#4 0x8048a30 (/home/msuraev/source/gsm/libosmocore/tests/bits/.libs/lt-bitrev_test+0x8048a30)
Address 0xbff5b5b6 is located at offset 38 in frame <main> of T0's stack:
This frame has 3 object(s):
[32, 38) 'in2'
[96, 104) 'out'
[160, 168) 'in1'
The reason is incorrect range in test cycle. Fix it and adjust test
output accordingly.
Tweaked-by: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Fixes: OW#1589 ("undefined behavior in libosmocore triggered by tests")
Change-Id: I5eb3f600290c05b4ab9ac2450a28d616e6b415fd
-----------------------------------------------------------------------
Summary of changes:
tests/bits/bitrev_test.c | 9 +++++++--
tests/bits/bitrev_test.ok | 50 +++++++++++++++++++++++------------------------
2 files changed, 31 insertions(+), 28 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via a9f2bb5ab878ad192cd5a593596a6450e6ff7b58 (commit)
via 5e0b0a658fdc8d42de434eb1939352c55eeed30f (commit)
via 663debcb90022f1ca53b0d947162774c8a1ec9c5 (commit)
via 43d86bfc94969ac9738ce398d13bd0a974e90df0 (commit)
via c13e68774215c4156925e8a2012fcb9169cf70b2 (commit)
via 77c8d5ffb52bd5da405fc869286b4f7aa7f88d4d (commit)
via d90fa42dc9f1fbf3d1d92a1749742ecb1c5d537e (commit)
via 0ce98c749a37cc365ab77224d36d6f68061ef727 (commit)
from 73f83d533ba8d929a840ab76efb099da4d5b6174 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/bsc_api.h | 2 -
openbsc/include/openbsc/gsm_data.h | 12 +++++-
openbsc/include/openbsc/vty.h | 4 +-
openbsc/src/ipaccess/ipaccess-config.c | 2 +-
openbsc/src/libbsc/abis_nm_vty.c | 4 +-
openbsc/src/libbsc/abis_om2000_vty.c | 4 +-
openbsc/src/libbsc/bsc_api.c | 23 +++++------
openbsc/src/libbsc/bsc_init.c | 7 +---
openbsc/src/libbsc/bsc_vty.c | 2 +-
openbsc/src/libbsc/net_init.c | 7 +++-
openbsc/src/libcommon/talloc_ctx.c | 33 ++++++++-------
openbsc/src/libmsc/gsm_04_08.c | 73 +++++++++++++++-------------------
openbsc/src/libmsc/gsm_04_11.c | 22 +++++-----
openbsc/src/libmsc/rrlp.c | 2 +-
openbsc/src/libmsc/transaction.c | 4 +-
openbsc/src/osmo-bsc/osmo_bsc_ctrl.c | 2 +-
openbsc/src/osmo-bsc/osmo_bsc_main.c | 2 +-
openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 2 +-
openbsc/src/osmo-nitb/bsc_hack.c | 6 +--
openbsc/src/utils/bs11_config.c | 2 +-
openbsc/tests/channel/channel_test.c | 2 +-
openbsc/tests/gsm0408/gsm0408_test.c | 4 +-
22 files changed, 109 insertions(+), 112 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)