osmocom-commitlog March 2016

osmocom-commitlog@lists.osmocom.org

1 participants
177 discussions

openbsc.git branch master updated. 0.15.0-187-g961bd0b
by gitosis＠osmocom.org 16 Mar '16

16 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 961bd0b121d604612ea27bd2c83edd73290b2cb6 (commit) via 531734a547f16de08ce94ec64d58cf94c2230893 (commit) from 51273157fa18034349d6ac1395c6d43e80cc07c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=961bd0b121d604612ea27bd2c83edd73… commit 961bd0b121d604612ea27bd2c83edd73290b2cb6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 16:13:25 2016 +0100 04.08: apply new transaction id inline functions libosmocore recently added inline functions to relieve callers from applying bitmasks and bit shifts to access the transaction id of a GSM 04.08 header. Apply these functions. http://cgit.osmocom.org/openbsc/commit/?id=531734a547f16de08ce94ec64d58cf94… commit 531734a547f16de08ce94ec64d58cf94c2230893 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 16:13:24 2016 +0100 04.08: apply new bitmask functions, fix bitmask use Replace hardcoded protocol discriminator and message type bitmasks with function calls recently introduced in libosmocore. Note that the release 98 bitmasks slightly differ from the release 99 bitmasks. This patch uses the "default" gsm48_hdr_msg_type invocation, thus it depends on libosmocore whether 98 or 99 bitmasks are used. In some places, use of the bitmask was erratic. Fix these implicitly by employing the bitmask functions: * silent_call.c: silent_call_reroute(): add missing bitmask for MM. * bsc_msg_filter.c: bsc_msg_filter_initial(): RR vs. MM messages. * osmo_bsc_filter.c: bsc_find_msc() and bsc_scan_bts_msg(): RR vs. MM messages. * bsc_nat_rewrite.c: bsc_nat_rewrite_msg(): SMS vs. CC messages. * bsc_ussd.c: no bitmask is applicable for the message types used here. * gb_proxy.c: gbproxy_imsi_acquisition(): missing bit mask for pdisc. In gprs_gb_parse.c: gprs_gb_parse_dtap(), add a log notice for unexpected message types. ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gb_proxy.c | 4 ++-- openbsc/src/gprs/gprs_gb_parse.c | 13 ++++++++++--- openbsc/src/gprs/gprs_gmm.c | 10 +++++----- openbsc/src/libbsc/bsc_api.c | 8 +++++--- openbsc/src/libfilter/bsc_msg_filter.c | 10 +++++----- openbsc/src/libmsc/gsm_04_08.c | 13 ++++++------- openbsc/src/libmsc/gsm_04_11.c | 2 +- openbsc/src/libmsc/silent_call.c | 5 +++-- openbsc/src/osmo-bsc/osmo_bsc_api.c | 8 ++++---- openbsc/src/osmo-bsc/osmo_bsc_filter.c | 10 +++++----- openbsc/src/osmo-bsc_nat/bsc_nat.c | 4 ++-- openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c | 4 ++-- openbsc/src/osmo-bsc_nat/bsc_ussd.c | 6 +++--- 13 files changed, 53 insertions(+), 44 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch master updated. 0.9.0-99-gda7bf4d
by gitosis＠osmocom.org 16 Mar '16

16 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via da7bf4d55a896034320aa4466b9644083093acd1 (commit) via c656faed122b8d858e937d3262acb1925ed6e3d1 (commit) via 282e90843476989629f8ae7e36e4a59b69da40eb (commit) from c0d9a6c083aa7e35174093c7a7265319bf993a9d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=da7bf4d55a896034320aa4466b96… commit da7bf4d55a896034320aa4466b9644083093acd1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 16:06:48 2016 +0100 04.08: add inline funcs for transaction id bits Various users of gsm48_hdr apply the same hardcoded shifts/bitmasks to obtain the transaction ID encoded in the upper nibble of the protocol discriminator. Centralize. Patch for openbsc.git will follow. http://cgit.osmocom.org/libosmocore/commit/?id=c656faed122b8d858e937d3262ac… commit c656faed122b8d858e937d3262acb1925ed6e3d1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 16:06:47 2016 +0100 04.08: switch to r99 msg type bitmasks by default [hfreyther: Separated from the previous patch to allow an easy revert] http://cgit.osmocom.org/libosmocore/commit/?id=282e90843476989629f8ae7e36e4… commit 282e90843476989629f8ae7e36e4a59b69da40eb Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 16:06:46 2016 +0100 04.08: add inline funcs for pdisc + msg type bitmasks Add inline functions for both release <= 98 and release >= 99 as well as a default define. Use the release 98 by default since the current code base uses the r98 bitmasks. These inline functions relieve callers of the decision on masking bits of the protocol discriminator and message type octets. Also add a define for the protocol discriminator extension to one octet length (GSM48_PDISC_EXTEND). Apply new pdisc function in gsm0480.c. [hfreyther: Make the hdr param const] ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/protocol/gsm_04_08.h | 75 ++++++++++++++++++++++++++++++++ src/gsm/gsm0480.c | 4 +- 2 files changed, 77 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmocore.git branch neels/pending-patches updated. 0.9.0-101-g45c4a70
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/pending-patches has been updated via 45c4a706cc6443da1209630d6d466c0e3a979d01 (commit) via 47533774a6d03a3d11e98823963de6a01f2e8e3b (commit) from c04abfa3b358308f6d923a2aeee145bf49075246 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=45c4a706cc6443da1209630d6d46… commit 45c4a706cc6443da1209630d6d466c0e3a979d01 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Mar 15 13:26:42 2016 +0100 gsm48: factor out MCC+MNC BCD parsing for re-use in UMTS For 3G, I need a BCD composer/parser similar to gsm48_generate_lai()/ gsm48_decode_lai(). Those functions also handle a trivial extra member (lac) which I don't need in this way for 3G. So create new functions to take on the MCC+MNC BCD handling and call those from gsm48_generate_lai() and gsm48_decode_lai(). In this way, the 3G code in openbsc can use only the BCD functionality without code duplication. http://cgit.osmocom.org/libosmocore/commit/?id=47533774a6d03a3d11e98823963d… commit 47533774a6d03a3d11e98823963de6a01f2e8e3b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 23:50:33 2016 +0100 gsm0480.c: squelch compiler warning due to const (caused recently) The introduction of gsm48_hdr_pdisc() caused a new compiler warning. In gsm0480_decode_*(), the gsm48_hdr is const, which we can safely cast away to avoid the warning. ----------------------------------------------------------------------- Summary of changes: include/osmocom/gsm/gsm48.h | 3 +++ src/gsm/gsm0480.c | 4 ++-- src/gsm/gsm48.c | 55 ++++++++++++++++++++++++++++----------------- src/gsm/libosmogsm.map | 2 ++ 4 files changed, 41 insertions(+), 23 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch neels/cscn updated. 0.15.0-335-gce05c2e
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

1 0

openbsc.git branch sysmocom/iu updated. 0.15.0-334-g3c94c2c
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, sysmocom/iu has been updated discards c4628732483e3b24de5df3fae6c295056ce8b2de (commit) discards a86eb00676f594ece27972344a2b73b16c67ee38 (commit) discards 837c6e43019a0afcf255640d591f16b3b0bb59ce (commit) discards 9499d053f96ae8e5cb75a189317b5232504d0f0d (commit) discards 49ee79f132b54346dfbd2fab44ebfb25e2126640 (commit) discards 9337c71bf2cb786fc716c4a4cf2bdd7783e8b189 (commit) discards 6d9deeace50a849fe648173a904dcc228a851b1a (commit) discards 324ffc91028099fafde06089ff2288df6b082b2c (commit) discards 0c39c0d08e2c76f91128b39b9e83e7d857b5204a (commit) discards 8ac13ec22931e147864c363c6bece158f56bed9e (commit) via 3c94c2c5975774282e49d2d9a1d2041b01c8378e (commit) via 372a3bd346d481bec4fd754b46ff7c8e380c012c (commit) via 51bf76ef478085a030382e91212e108f71537ccc (commit) via aa6058203665aa2fb9edd033e852dcb1bf2c003f (commit) via 6b2623d94469f2d92117af581f12ffa270d5748d (commit) via 8b1272a6d300b391efda52cac7dddab7ccc320ef (commit) via 080921a5510323f6cbb0924328c0bb364afd08ce (commit) via 8e7f4c6f21f32ed5afb356e3279aba4023e08569 (commit) via 4a9b871de5fb8167ba678165ccdbad808fec4116 (commit) via 93f6fa5a814e888e8ed93c0536e0d94beed8f144 (commit) via f1777ee8433626f8bc62b71f984b36d017e9b76c (commit) via 9e8e0e6a2930afbf3e156e3be945f17c117086ea (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c4628732483e3b24de5df3fae6c295056ce8b2de) \ N -- N -- N (3c94c2c5975774282e49d2d9a1d2041b01c8378e) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3c94c2c5975774282e49d2d9a1d2041b… commit 3c94c2c5975774282e49d2d9a1d2041b01c8378e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 13:41:20 2016 +0100 bsc_scan_msc_msg: check protocol discriminator The function assumed an MM protocol discriminator without verifying it. http://cgit.osmocom.org/openbsc/commit/?id=372a3bd346d481bec4fd754b46ff7c8e… commit 372a3bd346d481bec4fd754b46ff7c8e380c012c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 14:36:56 2016 +0100 04.08: apply new transaction id inline functions libosmocore recently added inline functions to relieve callers from applying bitmasks and bit shifts to access the transaction id of a GSM 04.08 header. Apply these functions. http://cgit.osmocom.org/openbsc/commit/?id=51bf76ef478085a030382e91212e108f… commit 51bf76ef478085a030382e91212e108f71537ccc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Mar 10 12:19:13 2016 +0100 04.08: apply new bitmask functions, fix bitmask use Replace hardcoded protocol discriminator and message type bitmasks with function calls recently introduced in libosmocore. Note that the release 98 bitmasks slightly differ from the release 99 bitmasks. This patch uses the "default" gsm48_hdr_msg_type invocation, thus it depends on libosmocore whether 98 or 99 bitmasks are used. In some places, use of the bitmask was erratic. Fix these implicitly by employing the bitmask functions: * silent_call.c: silent_call_reroute(): add missing bitmask for MM. * bsc_msg_filter.c: bsc_msg_filter_initial(): RR vs. MM messages. * osmo_bsc_filter.c: bsc_find_msc() and bsc_scan_bts_msg(): RR vs. MM messages. * bsc_nat_rewrite.c: bsc_nat_rewrite_msg(): SMS vs. CC messages. * bsc_ussd.c: no bitmask is applicable for the message types used here. * gb_proxy.c: gbproxy_imsi_acquisition(): missing bit mask for pdisc. In gprs_gb_parse.c: gprs_gb_parse_dtap(), add a log notice for unexpected message types. http://cgit.osmocom.org/openbsc/commit/?id=aa6058203665aa2fb9edd033e852dcb1… commit aa6058203665aa2fb9edd033e852dcb1bf2c003f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 23:57:14 2016 +0100 cosmetic: comments ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gb_proxy.c | 4 ++-- openbsc/src/gprs/gprs_gb_parse.c | 13 ++++++++++--- openbsc/src/gprs/gprs_gmm.c | 10 +++++----- openbsc/src/libbsc/bsc_api.c | 8 +++++--- openbsc/src/libfilter/bsc_msg_filter.c | 15 +++++++-------- openbsc/src/libmsc/gsm_04_08.c | 12 ++++++------ openbsc/src/libmsc/gsm_04_11.c | 2 +- openbsc/src/libmsc/gsm_subscriber.c | 2 +- openbsc/src/libmsc/silent_call.c | 5 +++-- openbsc/src/osmo-bsc/osmo_bsc_api.c | 8 ++++---- openbsc/src/osmo-bsc/osmo_bsc_filter.c | 22 ++++++++++++---------- openbsc/src/osmo-bsc_nat/bsc_nat.c | 4 ++-- openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c | 9 ++++----- openbsc/src/osmo-bsc_nat/bsc_ussd.c | 6 +++--- 14 files changed, 65 insertions(+), 55 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch neels/cscn updated. 0.15.0-339-g92c9f4a
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

1 0

osmo-pcu.git branch master updated. 0.2-754-gbacb65b
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via bacb65b48b520ace03c877d3092b58e50cb68266 (commit) via 656eed59758fdcd51d219070209591597a978e7e (commit) from 173ef90a539dc33bb8fc395c0315320a4525a8d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=bacb65b48b520ace03c877d3092b58e… commit bacb65b48b520ace03c877d3092b58e50cb68266 Author: Saurabh Sharan <saurabh.sharan(a)radisys.com> Date: Thu Mar 10 17:24:49 2016 +0530 Add test vectors for EGPRS messages This patch is the test suite modification for the fix encoding of padding bits. New test vectors have been added both in downlink and uplink. http://cgit.osmocom.org/osmo-pcu/commit/?id=656eed59758fdcd51d2190702095915… commit 656eed59758fdcd51d219070209591597a978e7e Author: Saurabh Sharan <saurabh.sharan(a)radisys.com> Date: Thu Mar 10 14:15:29 2016 +0530 Fix encoding of padding bits to start with 0 bit This patch is for fixing encoding of padding bits according to the 3gpp spec 44.060 section 11, wherein it shall always start with 0 bit followed with spare padding bits. During introduction of basic EGPRS feature new hex dump messages from a different working network log were used in Unit test. These exposed the issue of incorrect handling of padding bits encoding in osmo-pcu. Corrections in the existing test vector of rlcmac is also updated. In testsuite tbf appropriate corrections for the Tbftest.err is also done. ----------------------------------------------------------------------- Summary of changes: src/csn1.cpp | 7 ++++++- tests/rlcmac/RLCMACTest.cpp | 13 +++++++----- tests/rlcmac/RLCMACTest.ok | 50 +++++++++++++++++++++++++++++++++++++-------- tests/tbf/TbfTest.err | 18 ++++++++-------- 4 files changed, 64 insertions(+), 24 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

openbsc.git branch neels/cscn updated. 0.15.0-338-g7265a5e
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/cscn has been updated discards c4628732483e3b24de5df3fae6c295056ce8b2de (commit) discards a86eb00676f594ece27972344a2b73b16c67ee38 (commit) discards 837c6e43019a0afcf255640d591f16b3b0bb59ce (commit) discards 9499d053f96ae8e5cb75a189317b5232504d0f0d (commit) discards 49ee79f132b54346dfbd2fab44ebfb25e2126640 (commit) discards 9337c71bf2cb786fc716c4a4cf2bdd7783e8b189 (commit) discards 6d9deeace50a849fe648173a904dcc228a851b1a (commit) discards 324ffc91028099fafde06089ff2288df6b082b2c (commit) discards 0c39c0d08e2c76f91128b39b9e83e7d857b5204a (commit) discards 8ac13ec22931e147864c363c6bece158f56bed9e (commit) via 7265a5e843f7f8b4b2bbf3175d4854230e379f8e (commit) via 31a7b36eb3dc2e152d91dd92959fa0b8a970d8f3 (commit) via 3a607b70f7a7a01991e75c27a92b1f3ff7fcc32c (commit) via 6b2623d94469f2d92117af581f12ffa270d5748d (commit) via 8b1272a6d300b391efda52cac7dddab7ccc320ef (commit) via 080921a5510323f6cbb0924328c0bb364afd08ce (commit) via 8e7f4c6f21f32ed5afb356e3279aba4023e08569 (commit) via 4a9b871de5fb8167ba678165ccdbad808fec4116 (commit) via 93f6fa5a814e888e8ed93c0536e0d94beed8f144 (commit) via f1777ee8433626f8bc62b71f984b36d017e9b76c (commit) via 9e8e0e6a2930afbf3e156e3be945f17c117086ea (commit) via 1c02de7ae89ce1996dd52898f5dd36eae9532739 (commit) via c1eb1fcd5378897b6d1818481b5d0ea08cd73511 (commit) via a8e0f01025fff784d904531305807cb00dc579b2 (commit) via 9760079bfcf7f8b3783ec536485b255b7a8397ce (commit) via 530414d77e6f22c109257496cd0e1f1249acb06e (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c4628732483e3b24de5df3fae6c295056ce8b2de) \ N -- N -- N (7265a5e843f7f8b4b2bbf3175d4854230e379f8e) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7265a5e843f7f8b4b2bbf3175d485423… commit 7265a5e843f7f8b4b2bbf3175d4854230e379f8e Merge: 31a7b36 1c02de7 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Mar 15 00:02:25 2016 +0100 Merge branch 'neels/patches-pending' into neels/cscn Conflicts: openbsc/src/libmsc/gsm_04_08.c http://cgit.osmocom.org/openbsc/commit/?id=31a7b36eb3dc2e152d91dd92959fa0b8… commit 31a7b36eb3dc2e152d91dd92959fa0b8a970d8f3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 23:57:14 2016 +0100 cosmetic: comments http://cgit.osmocom.org/openbsc/commit/?id=3a607b70f7a7a01991e75c27a92b1f3f… commit 3a607b70f7a7a01991e75c27a92b1f3ff7fcc32c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 14 23:56:56 2016 +0100 wip: add rnc registry http://cgit.osmocom.org/openbsc/commit/?id=6b2623d94469f2d92117af581f12ffa2… commit 6b2623d94469f2d92117af581f12ffa270d5748d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Mar 10 22:58:21 2016 +0100 cscn: fix VTY port: don't use SGSN's port number http://cgit.osmocom.org/openbsc/commit/?id=8b1272a6d300b391efda52cac7dddab7… commit 8b1272a6d300b391efda52cac7dddab7ccc320ef Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Mar 9 01:31:20 2016 +0100 msc: allow only authentication without ciphering So far the code did only auth+ciph or none. Add case handling for only authentication without ciphering (basically just fill in the blanks). http://cgit.osmocom.org/openbsc/commit/?id=080921a5510323f6cbb0924328c0bb36… commit 080921a5510323f6cbb0924328c0bb364afd08ce Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Mar 8 15:14:59 2016 +0100 HACK: hardcode subscriber auth tuple for IuCS http://cgit.osmocom.org/openbsc/commit/?id=8e7f4c6f21f32ed5afb356e3279aba40… commit 8e7f4c6f21f32ed5afb356e3279aba4023e08569 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 7 16:53:45 2016 +0100 cosmetic http://cgit.osmocom.org/openbsc/commit/?id=4a9b871de5fb8167ba678165ccdbad80… commit 4a9b871de5fb8167ba678165ccdbad808fec4116 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 7 16:53:02 2016 +0100 Adjust authentication logic for Iu, move a log notice Depending on conn->via_iface, fail upon missing auth for 3G. Move the log notice saying "skipping auth" to gsm48_secure_channel() where conn->via_iface is actually known. http://cgit.osmocom.org/openbsc/commit/?id=93f6fa5a814e888e8ed93c0536e0d94b… commit 93f6fa5a814e888e8ed93c0536e0d94beed8f144 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 7 16:50:47 2016 +0100 spread a few debug logs around authentication http://cgit.osmocom.org/openbsc/commit/?id=f1777ee8433626f8bc62b71f984b36d0… commit f1777ee8433626f8bc62b71f984b36d017e9b76c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 7 16:48:38 2016 +0100 fix confusing typo in constant (THAN -> THEN) http://cgit.osmocom.org/openbsc/commit/?id=9e8e0e6a2930afbf3e156e3be945f17c… commit 9e8e0e6a2930afbf3e156e3be945f17c117086ea Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Mar 7 17:19:19 2016 +0100 Remove unused auth code and add comment As commented in the code, the GSM_SECURITY_AUTH_FAILED path is never invoked by the gsm48_secure_channel() function as it is today. Note that the upcoming Iu auth will probably add a GSM_SECURITY_AUTH_FAILED status. In that case, sending a LU Reject immediately may be desirable, but arguably a bit of timeout could make life harder for auth attackers. The code removed by this patch doesn't send out a LU Reject ever, since a call to release_loc_updating_req() only releases the connection. To reject, a call to gsm0408_loc_upd_rej() would be necessary, as seen in loc_upd_rej_cb(). And finally, if _gsm0408_authorize_sec_cb() doesn't do anything about anything, the same loc_upd_rej_cb() will be run by a timeout and send a LU Reject properly (as commented in the code). ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_data.h | 10 ++++++++++ openbsc/include/openbsc/iu.h | 24 ++++++++++++++++++++++++ openbsc/src/gprs/gb_proxy.c | 4 ++-- openbsc/src/gprs/gprs_gb_parse.c | 13 ++++++++++--- openbsc/src/gprs/gprs_gmm.c | 10 +++++----- openbsc/src/libbsc/bsc_api.c | 8 +++++--- openbsc/src/libfilter/bsc_msg_filter.c | 15 +++++++-------- openbsc/src/libiu/iu.c | 17 +++++++++++++++++ openbsc/src/libmsc/gsm_04_08.c | 12 ++++++------ openbsc/src/libmsc/gsm_04_11.c | 2 +- openbsc/src/libmsc/gsm_subscriber.c | 2 +- openbsc/src/libmsc/silent_call.c | 5 +++-- openbsc/src/libxsc/xsc.c | 2 ++ openbsc/src/osmo-bsc/osmo_bsc_api.c | 8 ++++---- openbsc/src/osmo-bsc/osmo_bsc_filter.c | 22 ++++++++++++---------- openbsc/src/osmo-bsc_nat/bsc_nat.c | 4 ++-- openbsc/src/osmo-bsc_nat/bsc_nat_rewrite.c | 9 ++++----- openbsc/src/osmo-bsc_nat/bsc_ussd.c | 6 +++--- 18 files changed, 118 insertions(+), 55 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch neels/patches-pending updated. 0.15.0-190-g1c02de7
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

1 0

osmo-trx.git branch edge deleted. 7fec3030d46b2c35c34d90507feab253cddb9c01
by gitosis＠osmocom.org 15 Mar '16

15 Mar '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "OpenBTS' transceiver retro-fit". The branch, edge has been deleted was 7fec3030d46b2c35c34d90507feab253cddb9c01 ----------------------------------------------------------------------- 7fec3030d46b2c35c34d90507feab253cddb9c01 EDGE: Combine shared GMSK and 8-PSK demodulator sections ----------------------------------------------------------------------- hooks/post-receive -- OpenBTS' transceiver retro-fit

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
18
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog March 2016