osmocom-commitlog February 2016

osmocom-commitlog@lists.osmocom.org

1 participants
159 discussions

libosmocore.git branch neels/bind updated. 0.9.0-80-g469390d
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/bind has been updated discards a60659327dec987d2e6cd92fecf9a5ee919eccd2 (commit) discards c1c9376a65ab21879470fe59573a6ddaf534b672 (commit) discards b8f79757ea9f0fd16fbfa65a9de4a550ff542f01 (commit) via 469390d8e461e178a48d1790d084ce559f9e9ca3 (commit) via b2f7b00356d2a32f8c3bf53636ea082a6cf0f6b2 (commit) via 00fe6d3b89f34bc1b5274bf71579af0cf7633ed3 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (a60659327dec987d2e6cd92fecf9a5ee919eccd2) \ N -- N -- N (469390d8e461e178a48d1790d084ce559f9e9ca3) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=469390d8e461e178a48d1790d084… commit 469390d8e461e178a48d1790d084ce559f9e9ca3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 00:10:41 2016 +0100 vty: add ctrl section for Control interface bind address This may seem like overkill for a mere const char * config item, but it makes the Control interface VTY commands reusable in any main() scope (inspired by libosmo-abis' VTY config). Add API functions ctrl_vty_init() and ctrl_vty_get_bind_addr(), in new files src/ctrl/control_vty.c and include/osmocom/ctrl/control_vty.h, compiled and/or installed dependent on ENABLE_VTY. Using these functions allows configuring a static const char* with the VTY commands ctrl bind A.B.C.D which callers shall subsequently use to bind the Control interface to a specific local interface address, by passing the return value of ctrl_vty_get_bind_addr() to control_interface_setup(). Add CTRL_NODE to enum node_type, "eating" RESERVED4_NODE to heed that comment on avoiding ABI changes. http://cgit.osmocom.org/libosmocore/commit/?id=b2f7b00356d2a32f8c3bf53636ea… commit b2f7b00356d2a32f8c3bf53636ea082a6cf0f6b2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 00:09:40 2016 +0100 add bind address parameter to ctrl_interface_setup() Make the ctrl interface bind address configurable, so that it may be made available on other addresses than 127.0.0.1. The specific aim is to allow running multiple osmo-nitbs alongside each other (commits in openbsc follow). http://cgit.osmocom.org/libosmocore/commit/?id=00fe6d3b89f34bc1b5274bf71579… commit 00fe6d3b89f34bc1b5274bf71579af0cf7633ed3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:01:41 2016 +0100 vty: add bind command for telnet vty line Add VTY command line vty bind A.B.C.D The command merely stores the configured IP-address, which can then be used by the calling main program to set the telnet port of the VTY line. (Commits in openbsc and osmo-iuh will follow up on this.) Add function vty_get_bind_addr() to publish the address in the vty.h API. Add static vty_bind_addr to store. For allocation/freeing reasons, a NULL address defaults to 127.0.0.1. BTW, I decided against allowing keywords 'any' and 'localhost' in place of an actual IP address to make sure a written config is always identical to the parsed config. ----------------------------------------------------------------------- Summary of changes: include/osmocom/ctrl/control_if.h | 8 ++++++-- src/ctrl/control_if.c | 12 ++++++++++-- src/vty/vty.c | 12 ++++-------- 3 files changed, 20 insertions(+), 12 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-pcu.git branch max/pacch updated. 0.2-751-g0ba0d18
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, max/pacch has been updated via 0ba0d186a558a9bcf75fabdb4649970439a58c29 (commit) from eebede68aa7a432733e18e5e890e4ae52ec5a838 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=0ba0d186a558a9bcf75fabdb4649970… commit 0ba0d186a558a9bcf75fabdb4649970439a58c29 Author: Max <msuraev(a)sysmocom.de> Date: Wed Feb 24 17:35:32 2016 +0100 Explicitly initialize m_v_n and m_v_b Call reset() to initialize m_v_b in gprs_rlc_dl_window() and m_v_n in gprs_rlc_ul_window() constructors. Fixes: Coverity: CID 1351738, 1351737 ----------------------------------------------------------------------- Summary of changes: src/rlc.h | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch max/pacch updated. 0.2-750-geebede6
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, max/pacch has been updated via eebede68aa7a432733e18e5e890e4ae52ec5a838 (commit) from db8254e9534510715e3e5c72b7fb02f037a22a53 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=eebede68aa7a432733e18e5e890e4ae… commit eebede68aa7a432733e18e5e890e4ae52ec5a838 Author: Max <msuraev(a)sysmocom.de> Date: Wed Feb 24 16:36:05 2016 +0100 Expand RLCMAC diagnostics output When smth bad happens (e. g. we hit timeout in RLCMAC) on TBF - obtain corresponding MS object and print extended information about it and its TBFs to aid troubleshooting. Diagnostic function should not change state hence make it const with no return value. ----------------------------------------------------------------------- Summary of changes: src/tbf.cpp | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++------ src/tbf.h | 2 +- 2 files changed, 76 insertions(+), 8 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

libosmocore.git branch max/dbg created. 0.9.0-78-gb6d8047
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, max/dbg has been created at b6d8047a70e0de4a5a736e8ffdf51700d67e1d1f (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=b6d8047a70e0de4a5a736e8ffdf5… commit b6d8047a70e0de4a5a736e8ffdf51700d67e1d1f Author: Max <msuraev(a)sysmocom.de> Date: Wed Feb 24 16:00:25 2016 +0100 Add byte printing macros It's sometimes handy for debugging to be able to immediately see which bits are set in a given byte. Generalize macro used for that in bitvec tests and make it available for the rest of the library. ----------------------------------------------------------------------- hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-pcu.git branch max/pacch created. 0.2-749-gdb8254e
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, max/pacch has been created at db8254e9534510715e3e5c72b7fb02f037a22a53 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=db8254e9534510715e3e5c72b7fb02f… commit db8254e9534510715e3e5c72b7fb02f037a22a53 Author: Max <msuraev(a)sysmocom.de> Date: Wed Feb 24 12:49:35 2016 +0100 Refactor coding scheme assignment code Previously this code used too much copy-paste of boilerplate code which is error-prone and hard to read. Factor out actual (M)CS assignment into separate function and use it for both DL and UL cases in respective mode. Fixes: Coverity: CID 1351733 ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

openbsc.git branch neels/bind updated. 0.15.0-175-g5e49041
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

1 0

openbsc.git branch neels/bind updated. 0.15.0-174-g3b017c7
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/bind has been updated discards f99e2722c1203456fdc5e798098ee433e876b403 (commit) discards b9a35ba970c31cafdc2d5954d47317570aab5ce9 (commit) discards 9566a666b187bca3ef3e3a4101692cc9d89f872c (commit) discards 89638275e2ec12e9f9fbdc0797ba75b0b456e02b (commit) discards d06c2082663241b9f0fab52c7448756f44fb307f (commit) via 3b017c73e40769f15ee76dfbb55e63b31c143958 (commit) via 5cf85a69e55e6eae3a26c7b72f1d0deb81afdcda (commit) via dfe28a47032700d4cbeaf051a40c0f1f1f8bd94a (commit) via c9ba14034b4f5a811aa6bba8657f08a84b4d4346 (commit) via 62320a2c970bdda0458ed12a2ea9bfa3cd496c2b (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (f99e2722c1203456fdc5e798098ee433e876b403) \ N -- N -- N (3b017c73e40769f15ee76dfbb55e63b31c143958) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3b017c73e40769f15ee76dfbb55e63b3… commit 3b017c73e40769f15ee76dfbb55e63b31c143958 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 15:10:33 2016 +0100 enable ctrl bind config for various programs Add ctrl_vty_init() calls and feed the ctrl_vty_get_bind_addr() return value to ctrl_interface_setup() in the following programs: osmo-bsc osmo-bsc_nat osmo-nitb osmo-sgsn For osmo-sgsn, move the control interface setup invocation below the config parsing, so that the ctrl_vty_get_bind_addr() can return the configured address. http://cgit.osmocom.org/openbsc/commit/?id=5cf85a69e55e6eae3a26c7b72f1d0deb… commit 5cf85a69e55e6eae3a26c7b72f1d0deb81afdcda Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:59:43 2016 +0100 osmo-nitb: be strict about cmdline args Abort upon unknown options and missing option arguments. This came to my attention while rewiring the -m and -M options: passing -M without argument would launch nitb with wrong configuration. So, rather exit immediately. If there are legacy options that should be ignored, they deserve an own 'case:' in the option switch. There are none that I'm aware of though. http://cgit.osmocom.org/openbsc/commit/?id=dfe28a47032700d4cbeaf051a40c0f1f… commit dfe28a47032700d4cbeaf051a40c0f1f1f8bd94a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:57:22 2016 +0100 osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path Strictly speaking, the unix domain socket location is not a name but a path. The MNCC socket is called path, so it is confusing to call the ctrl socket a 'name'. http://cgit.osmocom.org/openbsc/commit/?id=c9ba14034b4f5a811aa6bba8657f08a8… commit c9ba14034b4f5a811aa6bba8657f08a84b4d4346 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:55:17 2016 +0100 osmo-nitb: add -M to pass specific MNCC socket path The old -m option without argument is still available and marked deprecated, to not make users' lives more difficult than necessary. http://cgit.osmocom.org/openbsc/commit/?id=62320a2c970bdda0458ed12a2ea9bfa3… commit 62320a2c970bdda0458ed12a2ea9bfa3cd496c2b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:09:38 2016 +0100 enable telnet VTY bind address config for various programs Following the 'line vty'/'bind A.B.C.D' command added in libosmocore, use the configured address to set the telnet bind for the VTY line. It is now possible to publish the VTY on a specific local interface (including 0.0.0.0 aka "any"). Implement in all of: osmo-gbproxy osmo-gtphub osmo-sgsn osmo-bsc osmo-bsc_nat osmo-bsc_mgcp osmo-nitb In some of these main programs, move the telnet initialization below the configuration parsing. Historically, this was not a good idea for programs using bsc_init.c (aka bsc_bootstrap_network()), since they expected a gsm_network struct pointer in ((struct telnet_connection*)vty->priv)->priv, so that telnet had to be either initialized or replaced by a dummy struct. In the meantime, the gsm_network struct is not actually looked up in a priv pointer but in the static bsc_vty.c scope (bsc_gsmnet), so this limitation is mere legacy (even though said legacy is still there in an "#if 0" chunk). In the other binaries I have briefly looked at the init sequence dependencies and found no reason to initialize telnet above the config file parsing. In any case, I have tested every single one of abovementioned binaries to verify that they still parse the example config successfully and launch, allowing VTY connections on the configured address(es). I hope this suffices. In all of the above, log VTY address and port. LOGL_INFO is disabled by default in some of the logging scopes, and since it is a single log message right at program launch, I decided for the slightly more aggressive LOGL_NOTICE. ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.15.0-169-gfd1187e
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via fd1187e2e933122bdea20784a0b6b2a119351651 (commit) via 1901b92f0c1f20dad30c883d91cc82556b4f2ebd (commit) from 69da1d453cb46e4ad2383747e430a59a2b49a276 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/bsc_vty.c | 1 - openbsc/src/osmo-bsc/osmo_bsc_main.c | 2 +- openbsc/src/osmo-bsc_nat/bsc_nat.c | 5 +++-- 3 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch neels/bind updated. 0.15.0-174-gf99e272
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/bind has been updated discards 027758eaa04e1b39b57b360c38f0785623fca68e (commit) discards 29309bffaba0f579c10adc09d88d8e3a3b51a00f (commit) discards 81780f26f3e3e94f4241edcd30bfc3180c1f2dfc (commit) discards 2a3714624a442f6a7c26de784d31fe56d6c6ef32 (commit) discards 076fa5ad3202cb8147a61a9b222364775680a025 (commit) via f99e2722c1203456fdc5e798098ee433e876b403 (commit) via b9a35ba970c31cafdc2d5954d47317570aab5ce9 (commit) via 9566a666b187bca3ef3e3a4101692cc9d89f872c (commit) via 89638275e2ec12e9f9fbdc0797ba75b0b456e02b (commit) via d06c2082663241b9f0fab52c7448756f44fb307f (commit) via fd1187e2e933122bdea20784a0b6b2a119351651 (commit) via 1901b92f0c1f20dad30c883d91cc82556b4f2ebd (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (027758eaa04e1b39b57b360c38f0785623fca68e) \ N -- N -- N (f99e2722c1203456fdc5e798098ee433e876b403) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=f99e2722c1203456fdc5e798098ee433… commit f99e2722c1203456fdc5e798098ee433e876b403 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 15:10:33 2016 +0100 enable ctrl bind config for various programs Add ctrl_vty_init() calls and feed the ctrl_vty_get_bind_addr() return value to ctrl_interface_setup() in the following programs: osmo-bsc osmo-bsc_nat osmo-nitb osmo-sgsn http://cgit.osmocom.org/openbsc/commit/?id=b9a35ba970c31cafdc2d5954d4731757… commit b9a35ba970c31cafdc2d5954d47317570aab5ce9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:59:43 2016 +0100 osmo-nitb: be strict about cmdline args Abort upon unknown options and missing option arguments. This came to my attention while rewiring the -m and -M options: passing -M without argument would launch nitb with wrong configuration. So, rather exit immediately. If there are legacy options that should be ignored, they deserve an own 'case:' in the option switch. There are none that I'm aware of though. http://cgit.osmocom.org/openbsc/commit/?id=9566a666b187bca3ef3e3a4101692cc9… commit 9566a666b187bca3ef3e3a4101692cc9d89f872c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:57:22 2016 +0100 osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path Strictly speaking, the unix domain socket location is not a name but a path. The MNCC socket is called path, so it is confusing to call the ctrl socket a 'name'. http://cgit.osmocom.org/openbsc/commit/?id=89638275e2ec12e9f9fbdc0797ba75b0… commit 89638275e2ec12e9f9fbdc0797ba75b0b456e02b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:55:17 2016 +0100 osmo-nitb: add -M to pass specific MNCC socket path The old -m option without argument is still available and marked deprecated, to not make users' lives more difficult than necessary. http://cgit.osmocom.org/openbsc/commit/?id=d06c2082663241b9f0fab52c7448756f… commit d06c2082663241b9f0fab52c7448756f44fb307f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:09:38 2016 +0100 enable telnet VTY bind address config in various binaries Following the 'line vty'/'bind A.B.C.D' command added in libosmocore, use the configured address to set the telnet bind for the VTY line. It is now possible to publish the VTY on a specific local interface (including 0.0.0.0 aka "any"). Implement in all of: osmo-gbproxy osmo-gtphub osmo-sgsn osmo-bsc osmo-bsc_nat osmo-bsc_mgcp osmo-nitb In some of these main programs, move the telnet initialization below the configuration parsing. Historically, this was not a good idea for programs using bsc_init.c (aka bsc_bootstrap_network()), since they expected a gsm_network struct pointer in ((struct telnet_connection*)vty->priv)->priv, so that telnet had to be either initialized or replaced by a dummy struct. In the meantime, the gsm_network struct is not actually looked up in a priv pointer but in the static bsc_vty.c scope (bsc_gsmnet), so this limitation is mere legacy (even though said legacy is still there in an "#if 0" chunk). In the other binaries I have briefly looked at the init sequence dependencies and found no reason to initialize telnet above the config file parsing. In any case, I have tested every single one of abovementioned binaries to verify that they still parse the example config successfully and launch, allowing VTY connections on the configured address(es). I hope this suffices. In all of the above, log VTY address and port. LOGL_INFO is disabled by default in some of the logging scopes, and since it is a single log message right at program launch, I decided for the slightly more aggressive LOGL_NOTICE. http://cgit.osmocom.org/openbsc/commit/?id=fd1187e2e933122bdea20784a0b6b2a1… commit fd1187e2e933122bdea20784a0b6b2a119351651 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 00:28:13 2016 +0100 minor fixes in bsc_vty.c and bsc_nat.c Remove unused talloc.h from bsc_vty.c. In bsc_nat.c, use OSMO_CTRL_PORT_BSC_NAT instead of hardcoding port number, and include ctrl/ports.h for that. Fix comment typo "COMAMND" http://cgit.osmocom.org/openbsc/commit/?id=1901b92f0c1f20dad30c883d91cc8255… commit 1901b92f0c1f20dad30c883d91cc82556b4f2ebd Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 00:42:44 2016 +0100 osmo-bsc: fix checking wrong pointer for ctrl setup success ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/bsc_nat.h | 3 ++- openbsc/include/openbsc/gprs_sgsn.h | 3 ++- openbsc/src/gprs/sgsn_ctrl.c | 5 +++-- openbsc/src/gprs/sgsn_main.c | 31 ++++++++++++++++++++----------- openbsc/src/libbsc/bsc_vty.c | 1 - openbsc/src/osmo-bsc/osmo_bsc_main.c | 12 ++++++++++-- openbsc/src/osmo-bsc_nat/bsc_nat.c | 12 ++++++++++-- openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c | 5 +++-- openbsc/src/osmo-nitb/bsc_hack.c | 9 ++++++++- 9 files changed, 58 insertions(+), 23 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch neels/bind updated. 0.9.0-80-ga606593
by gitosis＠osmocom.org 24 Feb '16

24 Feb '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, neels/bind has been updated discards a74977772a2cba5eae9e11d9fdb67798469a4cf0 (commit) discards ab602da4c5002e64e9079ddd56d246d05b5ee7e1 (commit) via a60659327dec987d2e6cd92fecf9a5ee919eccd2 (commit) via c1c9376a65ab21879470fe59573a6ddaf534b672 (commit) via b8f79757ea9f0fd16fbfa65a9de4a550ff542f01 (commit) via cc00bf8779f48fd1e592fc7d0a60fc00b04826cd (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (a74977772a2cba5eae9e11d9fdb67798469a4cf0) \ N -- N -- N (a60659327dec987d2e6cd92fecf9a5ee919eccd2) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=a60659327dec987d2e6cd92fecf9… commit a60659327dec987d2e6cd92fecf9a5ee919eccd2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 00:10:41 2016 +0100 Add VTY section for Control interface bind address This may seem like overkill for a mere const char * config item, but it makes the Control interface VTY commands reusable in any main() scope (inspired by libosmo-abis' VTY config). Add API functions ctrl_vty_init() and ctrl_vty_get_bind_addr(), in new files src/ctrl/control_vty.c and include/osmocom/ctrl/control_vty.h, compiled and/or installed dependent on ENABLE_VTY. Using these functions allows configuring a static const char* with the VTY commands ctrl bind A.B.C.D which callers shall subsequently use to bind the Control interface to a specific local interface address, by passing the return value of ctrl_vty_get_bind_addr() to control_interface_setup(). Add CTRL_NODE to enum node_type, "eating" RESERVED4_NODE to heed that comment on avoiding ABI changes. http://cgit.osmocom.org/libosmocore/commit/?id=c1c9376a65ab21879470fe59573a… commit c1c9376a65ab21879470fe59573a6ddaf534b672 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 24 00:09:40 2016 +0100 add bind address parameter to ctrl_interface_setup() Make the ctrl interface bind address configurable, so that it may be made available on other addresses than 127.0.0.1. The specific aim is to allow running multiple osmo-nitbs alongside each other (commits in openbsc follow). http://cgit.osmocom.org/libosmocore/commit/?id=b8f79757ea9f0fd16fbfa65a9de4… commit b8f79757ea9f0fd16fbfa65a9de4a550ff542f01 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 23 14:01:41 2016 +0100 vty: add bind command for telnet vty line Add VTY command line vty bind A.B.C.D The command merely stores the configured IP-address, which can then be used by the calling main program to set the telnet port of the VTY line. (Commits in openbsc and osmo-iuh will follow up on this.) Add function vty_get_bind_addr() to publish the address in the vty.h API. Add static vty_bind_addr to store. For allocation/freeing reasons, a NULL address defaults to 127.0.0.1. BTW, I decided against allowing keywords 'any' and 'localhost' in place of an actual IP address to make sure a written config is always identical to the parsed config. ----------------------------------------------------------------------- Summary of changes: TODO-RELEASE | 1 + include/Makefile.am | 3 +- include/osmocom/ctrl/control_if.h | 4 +- include/osmocom/ctrl/control_vty.h | 9 ++++ include/osmocom/gsm/l1sap.h | 11 +++++ include/osmocom/vty/command.h | 3 +- src/ctrl/Makefile.am | 4 ++ src/ctrl/control_vty.c | 90 ++++++++++++++++++++++++++++++++++++++ 8 files changed, 121 insertions(+), 4 deletions(-) create mode 100644 include/osmocom/ctrl/control_vty.h create mode 100644 src/ctrl/control_vty.c hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
16
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog February 2016