November 2016 - osmocom-commitlog

openbsc.git branch master updated. 0.15.0-551-g3c165d0
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 3c165d02bb7f004ffcafdc281c03f45149850cb9 (commit) via 54f44ec5859cfe1b0dd3bf41762124f3ff4e27e0 (commit) via 18712f0bd1ea9dcad040da996e9f7071dfaec759 (commit) from 96df07708371313348d063032ee341592c27defc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3c165d02bb7f004ffcafdc281c03f451… commit 3c165d02bb7f004ffcafdc281c03f45149850cb9 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 14:09:34 2016 +0100 ipaccess-proxy: Check setsockopt() return value Change-Id: I34b082907b6f0b25fe2779f3a1f0a642a9002664 Fixes: Coverity CID 57642 http://cgit.osmocom.org/openbsc/commit/?id=54f44ec5859cfe1b0dd3bf41762124f3… commit 54f44ec5859cfe1b0dd3bf41762124f3ff4e27e0 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 14:06:52 2016 +0100 ipaccess-config: Handle setsockopt return value Change-Id: I8c2082f9a9c865cc663ad2abb63ee0f70914dabe Fixes: Coverity CID 57640 http://cgit.osmocom.org/openbsc/commit/?id=18712f0bd1ea9dcad040da996e9f7071… commit 18712f0bd1ea9dcad040da996e9f7071dfaec759 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 10:28:48 2016 +0100 Fix possible non-null-terminated buffer Change-Id: I22100c260856991b9a836135b3650e5b8c5449ca Fixes: Coverity CID 57623 ----------------------------------------------------------------------- Summary of changes: openbsc/src/ipaccess/ipaccess-config.c | 7 ++++++- openbsc/src/ipaccess/ipaccess-proxy.c | 8 +++++++- openbsc/src/libmsc/vty_interface_layer3.c | 1 + 3 files changed, 14 insertions(+), 2 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch master updated. 0.9.0-297-gedf6fe7
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via edf6fe75b72c10190057c65bdff467e5585ea6d7 (commit) from aeecc48c45e539e0e176dd13d86423e37ffbcee0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=edf6fe75b72c10190057c65bdff4… commit edf6fe75b72c10190057c65bdff467e5585ea6d7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 10:06:07 2016 +0100 ctrl_cmd_parse: Make coverity FORWARD_NULL happy The 'strtok_r' function requires passing a NULL as the first parameter on subsequent calls in order to ensure the code picks up where it left off on a previous call. However, Coverity doesn't quite realize this and points out that if a NULL was passed in as the third argument it would result in a possible NULL deref because the strtok_r function will assign the third argument to the first in the call is NULL. Change-Id: I7a9d08d0d4eae76a5207d285e32a25d1b384a57f Fixes: Coverity CID 135186 ----------------------------------------------------------------------- Summary of changes: src/ctrl/control_cmd.c | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmo-netif.git branch master updated. 0.0.6-25-gb2b2fe6
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom network interface library". The branch, master has been updated via b2b2fe643f5c1821c477f583a63a38838964bba7 (commit) from 7f0e9f117151d4a317628e089c22af6f921bf7b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-netif/commit/?id=b2b2fe643f5c1821c477f583a6… commit b2b2fe643f5c1821c477f583a63a38838964bba7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 15:42:16 2016 +0100 sctp_sock_activate_events(): Print error message on error When the setsockopt() in sctp_sock_activate_events() indicates an error, let's print an error message in the log about this. Change-Id: I5920154e23debe6d01eaa156005db0842f1a18cc Fixes: Coverity CID 57634 ----------------------------------------------------------------------- Summary of changes: src/stream.c | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- Osmocom network interface library

1 0

libosmocore.git branch master updated. 0.9.0-296-gaeecc48
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via aeecc48c45e539e0e176dd13d86423e37ffbcee0 (commit) from 1fa78567e4e1963a28711b9b47111b840b50cfdb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=aeecc48c45e539e0e176dd13d864… commit aeecc48c45e539e0e176dd13d86423e37ffbcee0 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 10:41:40 2016 +0100 Introduce osmo_strlcpy() function so we can stop using strncpy() I'm aware of the existing criticism on stlrcpy(), but I think it is still better than what we have now: stnrcpy(), sometimes with Coverity warnings and sometimes with a manual setting of the termination byte. The implementation follows the linux kernel strlcpy() which is claimed to be BSD compatible. We could of course link against libbsd on Linux instead, but I think it's reasonably small and simple to provide our own implementation. Future versions of libosmocore could use some autoconf magic and preprocessor macros to use the system-provided strlcpy() if it exists. Change-Id: Ifdc99b0e3b8631f1e771e58acaf9efb00a9cd493 ----------------------------------------------------------------------- Summary of changes: include/osmocom/core/utils.h | 2 ++ src/utils.c | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

openbsc.git branch master updated. 0.15.0-548-g96df077
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 96df07708371313348d063032ee341592c27defc (commit) via b0993e61d002b265048c3dc734c4fa89e0b1995f (commit) via 7b6bae65847e5ff6b695054fddca3080fc9d3d99 (commit) from 28f637ec2ca556896fce345f6dcb9b871a5ada53 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=96df07708371313348d063032ee34159… commit 96df07708371313348d063032ee341592c27defc Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 25 23:57:01 2016 +0100 libmsc/db: avoid subscr->name without terminating NULL char Change-Id: Ic8944ac4c5e940c9d835c52f1701461f274238db Fixes: Coverity CID 57621 http://cgit.osmocom.org/openbsc/commit/?id=b0993e61d002b265048c3dc734c4fa89… commit b0993e61d002b265048c3dc734c4fa89e0b1995f Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 25 23:54:18 2016 +0100 abis_nm: Fix non-null terminated buffer Unrealistic case (filename of 4096 bytes) Change-Id: Icf7b835f9edaf66976556fce1e9e0f66aa2010bc Fixes: Coverity CID 57620 http://cgit.osmocom.org/openbsc/commit/?id=7b6bae65847e5ff6b695054fddca3080… commit 7b6bae65847e5ff6b695054fddca3080fc9d3d99 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 25 23:52:46 2016 +0100 abis_nm: Fix possible not-null-terminated buffer Unrealistic case with file name of 4096 bytes length. Change-Id: I503200b879b854cf2dc218d5fe3059a555732d92 Fixes: Coverity CID 57619 ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/abis_nm.c | 2 ++ openbsc/src/libmsc/db.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch master updated. 0.9.0-295-g1fa7856
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 1fa78567e4e1963a28711b9b47111b840b50cfdb (commit) from 9533631e531671e7029bbe7bc2e264d9080f56c7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=1fa78567e4e1963a28711b9b4711… commit 1fa78567e4e1963a28711b9b47111b840b50cfdb Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 10:14:53 2016 +0100 osmo_gsup_encode(): Make coverity happy by invariant checking gsm48_encode_bcd_number() can theoretically return a length in excess of the size of the bcd_buf, but only in case an overly-long IMSI is passed into the function (which would be illegal in the first place). Change-Id: If3dc68ee13ff784b487bbc686b777cec9057d537 Fixes: Coverity CID 135216 ----------------------------------------------------------------------- Summary of changes: src/gsm/gsup.c | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

libosmocore.git branch master updated. 0.9.0-294-g9533631
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 9533631e531671e7029bbe7bc2e264d9080f56c7 (commit) from 4a1cb09a40aaba7f412d1384b2a1a06934310359 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=9533631e531671e7029bbe7bc2e2… commit 9533631e531671e7029bbe7bc2e264d9080f56c7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 09:54:40 2016 +0100 osmo-sim-test.c: Fix rmsg check we wanted to check for !rmsg, but used to check for !msg, missing error returns from read_record_nr(). Change-Id: I79b6a94b1aa947c8329317b0626865c3cd4159c1 Fixes: Coverity CID 57672 ----------------------------------------------------------------------- Summary of changes: utils/osmo-sim-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-bts.git branch master updated. 0.4.0-328-gae5405e
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via ae5405e2a434f008e9798d571072e4df0ec86493 (commit) from be671bc61f136a87c2705e11b0758e42ca72963d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=ae5405e2a434f008e9798d571072e4d… commit ae5405e2a434f008e9798d571072e4df0ec86493 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Nov 25 23:48:55 2016 +0100 vty: Ensure to not use negative (error) sapi value Change-Id: I282311de8514c1cc0a1b716e97e90ddf48863bb4 Fixes: Coverity CID 57617 Fixes: Coverity CID 57618 ----------------------------------------------------------------------- Summary of changes: src/common/vty.c | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

osmo-iuh.git branch master updated. e08cdd92a648ea8d9bb6ca405f04c91ca485db3c
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom code for Iuh interface". The branch, master has been updated via e08cdd92a648ea8d9bb6ca405f04c91ca485db3c (commit) from 5ee050c1e7fde4e32e3334e7bf02c4f663474d55 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-iuh/commit/?id=e08cdd92a648ea8d9bb6ca405f04c91… commit e08cdd92a648ea8d9bb6ca405f04c91ca485db3c Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 00:01:53 2016 +0100 ue_context_alloc(): Avoid ue->imsi without NULL termination Change-Id: I152e84206e0b2b80fa79956f5adbbe84ff10b4ab Fixes: Coverity CID 57625 ----------------------------------------------------------------------- Summary of changes: src/hnbgw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom code for Iuh interface

1 0

libosmocore.git branch master updated. 0.9.0-293-g4a1cb09
by gitosis＠osmocom.org 26 Nov '16

26 Nov '16

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 4a1cb09a40aaba7f412d1384b2a1a06934310359 (commit) via 0fc315dd9ed35ab9d32b60cbcd225f413b6a601e (commit) from 9d862c89989e5841a2242ed0cde0e6fa0f4a6d2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=4a1cb09a40aaba7f412d1384b2a1… commit 4a1cb09a40aaba7f412d1384b2a1a06934310359 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 00:11:53 2016 +0100 telnet_interface: Handle osmo_fd_register() eror return code Change-Id: I5bc1c2cbb04e363d868355b5ed866b4840f16c61 Fixes: Coverity 57637 http://cgit.osmocom.org/libosmocore/commit/?id=0fc315dd9ed35ab9d32b60cbcd22… commit 0fc315dd9ed35ab9d32b60cbcd225f413b6a601e Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Nov 26 10:18:24 2016 +0100 osmo_sock_init(): Fix memory leak in error path We forgot to call freeaddrinfo() in an error path. Change-Id: Iccbd3beef4c4a70dc443131b909c45e650d8c6a2 Fixes: Coverity CID 135217 ----------------------------------------------------------------------- Summary of changes: src/socket.c | 1 + src/vty/telnet_interface.c | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0