August 2015 - osmocom-commitlog

osmo-pcu.git branch jerlbeck/testing/pcu created. 0.2-558-g769e802
by gitosis＠osmocom.org 16 Aug '15

16 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/testing/pcu has been created at 769e802fc1114541013e2f2c058b2754a2b33a97 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=769e802fc1114541013e2f2c058b275… commit 769e802fc1114541013e2f2c058b2754a2b33a97 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Sun Aug 16 21:36:32 2015 +0200 ms: Do not retrieve MS with IMSI 000 from the storage The IMSI '000' is used as default value for an incoming BSSGP message's IMSI IE. This can lead to the retrieval of the wrong MS object from the storage. This commit changes the get_ms method to skip the IMSI search if such an IMSI is passed as selector. Note that changing the default value in the BSSGP code does not help here. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=118347847897bacb76d76d85e110ffb… commit 118347847897bacb76d76d85e110ffb129defd5c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Sun Aug 16 21:27:34 2015 +0200 tbf: Use update_ms instead of confirm_tlli in handle() The confirm_tlli method does not handle TLLI clashes in the MS storage. This commit changes gprs_rlcmac_dl_tbf::handle() to use update_ms instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=fa8d07c9f33db7a8ce1b28377a0e474… commit fa8d07c9f33db7a8ce1b28377a0e474fc57176d9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Sun Aug 16 18:19:32 2015 +0200 tbf: Clean old MS objects if they have the same TLLI Currently if an MS retries to access the PCU by using RACH and if there is already an entry for that MS, a duplicated MS object referring to the same TLLI is created. This is caused by blindly setting the TLLI without querying the MS storage to avoid inconsitencies. This leads to several entries in the MS storage that are assigned to the same TLLI. If that happens, 'show ms all' can display multiple entries with the same TLLI (note that an MS object can belong to several TLLIs, so there might be an intersection that is not visible in the list) or 'show tbf all' can show entries with MS_CLASS == 0 in some cases. This commit changes update_ms() to merge and clean up old entries that belong to the given TLLI if they exist. Some data (like the MS class) is copied to the new MS object. Note that TBF belonging to the old MS object are deleted immediately if they have not registered a timer. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=5d34536fcf205a4acda28a2b03d27d3… commit 5d34536fcf205a4acda28a2b03d27d3701420513 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Sun Aug 16 18:19:32 2015 +0200 tbf: Clean old MS objects (TODO) ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

libosmo-abis.git branch master updated. v0.3.1-3-gb37c5d4
by gitosis＠osmocom.org 15 Aug '15

15 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom A-bis protcol interface library". The branch, master has been updated via b37c5d48f0e5ceed98da7523ddab7878ab1b1cd9 (commit) from 3a580f263a24e0ce7d3ed544af0373c22ae9eeac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmo-abis/commit/?id=b37c5d48f0e5ceed98da7523dda… commit b37c5d48f0e5ceed98da7523ddab7878ab1b1cd9 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Aug 15 10:50:53 2015 +0200 configure.ac: Add subdir-objects ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Osmocom A-bis protcol interface library

1 0

libosmocore.git branch master updated. 0.8.0-47-g7c942ba
by gitosis＠osmocom.org 15 Aug '15

15 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 7c942ba1475a366cc7c8a129fbdd335166ce21c6 (commit) from a9e5252128d1d871739f067fe9b0ca9b9a75a6f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=7c942ba1475a366cc7c8a129fbdd… commit 7c942ba1475a366cc7c8a129fbdd335166ce21c6 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Aug 15 10:49:46 2015 +0200 configure.ac: Add subdir-objects Apparently this is required under latest autotools versions. ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-pcu.git branch je/master deleted. 0.2-552-g04e72d3
by gitosis＠osmocom.org 14 Aug '15

14 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, je/master has been deleted was 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007 ----------------------------------------------------------------------- 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007 tbf: Always start T3193 when changing state to GPRS_RLCMAC_WAIT_RELEASE ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch jerlbeck/master updated. 0.2-554-g1c3b899
by gitosis＠osmocom.org 14 Aug '15

14 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/master has been updated via 1c3b8998bc6d9d6f78a2bc29ac1f0ba9cffa4fb8 (commit) via ac289050825f23320ee60d9bfae87ee3a25fb2c5 (commit) via 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007 (commit) from 6eed1911fd619fb594a9d1a7fc734c1f62ff2f08 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=1c3b8998bc6d9d6f78a2bc29ac1f0ba… commit 1c3b8998bc6d9d6f78a2bc29ac1f0ba9cffa4fb8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Aug 14 16:01:36 2015 +0200 ms: Set default CoDel interval to 4s The current default interval is 2s which seems to be too short when the DL TBF has to be established. This may cause freezing or really slow TCP connections. This commit increases the default value to 4s. When the dl-tbf-idle-time is set, DL TBF are established less frequent, so smaller values (like 2s or below) can be used to improve the average latency when the load is high. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ac289050825f23320ee60d9bfae87ee… commit ac289050825f23320ee60d9bfae87ee3a25fb2c5 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Aug 14 12:50:54 2015 +0200 tbf: Handle TLLI change on DL When doing an RA Update the network can request to change the TLLI. In this case, there can be 2 MS objects with different TLLI for a single real MS. The first is associated with the old TLLI and the IMSI, while the second is associated with the new TLLI and no IMSI if it had been created for the uplink TBF. When the first message with the new TLLI and the IMSI arrives from the network, the PCU is able to detect this. Currently this is not handled properly. The TBFs of the old MS object are not cleaned up properly, keeping the old MS from being deleted. This patch modifies gprs_rlcmac_dl_tbf::handle to check for this and if neccessary to move an existing DL TBF and to clean up the old MS object to ensure its deletion. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/gprs_ms.cpp | 16 ++++++++++- src/gprs_ms.h | 2 ++ src/tbf_dl.cpp | 78 +++++++++++++++++++++++++++++++-------------------- tests/tbf/TbfTest.cpp | 4 +++ tests/tbf/TbfTest.err | 5 +++- 5 files changed, 73 insertions(+), 32 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

openbsc.git branch master updated. 0.14.0-154-ga334e90
by gitosis＠osmocom.org 14 Aug '15

14 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via a334e90ddf99697ad6b18df80f1cd7473b2314d4 (commit) via aeadf261e54d4e3987797b5818a8356441512568 (commit) via ca7d05bdb9e5be89442d6a2870e87919fdb11b98 (commit) via a611da8407a609a3a426c61e7fb10230a9320122 (commit) via 0eaad4f216637804458eacf31b0a1b10cff19e7b (commit) from e9f7c9925c26b23f7c29ace8da381e439a658eeb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=a334e90ddf99697ad6b18df80f1cd747… commit a334e90ddf99697ad6b18df80f1cd7473b2314d4 Merge: e9f7c99 aeadf26 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 14 15:48:54 2015 +0200 Merge branch 'zecke/features/sdp-codec-handling' Move forward while preserving the legacy handling. Beging to extract SDP rtpmap information and select codecs atfer this. It is a foundation we can now build further and better check ons. http://cgit.osmocom.org/openbsc/commit/?id=aeadf261e54d4e3987797b5818a83564… commit aeadf261e54d4e3987797b5818a8356441512568 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 14 15:43:06 2015 +0200 mgcp: Allow to enforce that the codecs need to match We have a lot of legacy that I am afraid to break. We have everything in place to make a good codec selection (e.g. if we can avoid transcoding, pick the one with best quality or the lowest speed). Right now I have a specific case where from all options I want to pick GSM. Guard the codec compat check behind the disallow transcoding option to make sure to not break legacy application. http://cgit.osmocom.org/openbsc/commit/?id=ca7d05bdb9e5be89442d6a2870e87919… commit ca7d05bdb9e5be89442d6a2870e87919fdb11b98 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 14 11:11:51 2015 +0200 mgcp: Turn SDP file parsing in a two stage process First collect everything we know and the mapping. E.g. a genuis could remap "3" to "AMR" so we only know the codecs once we are at the end of the SDP file. Once we have collected everything we can select the audio codecs. The current code is compatible in that two codecs will be selected regardless of if they make any sense or not. mgcp_set_audio_info could re-use some of our codec information but then the caller in the MGCP protocol needs to be updated as well as we use the "I: GSM" information to derive the codec from there. http://cgit.osmocom.org/openbsc/commit/?id=a611da8407a609a3a426c61e7fb10230… commit a611da8407a609a3a426c61e7fb10230a9320122 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 14 09:24:11 2015 +0200 mgcp: Move the SDP handling into a separate file/module The SDP file handling will get more complicated in terms of codec selection so let's remove it from the protocol handling before we start blowing it up in size. http://cgit.osmocom.org/openbsc/commit/?id=0eaad4f216637804458eacf31b0a1b10… commit 0eaad4f216637804458eacf31b0a1b10cff19e7b Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Fri Aug 14 08:54:58 2015 +0200 mgcp: Remove unused parsing data struct This struct was removed when we switched to strtok_r for parsing the data. Remove the left-over. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/mgcp_internal.h | 64 ++++++- openbsc/src/libmgcp/Makefile.am | 3 +- openbsc/src/libmgcp/mgcp_protocol.c | 222 +----------------------- openbsc/src/libmgcp/mgcp_sdp.c | 294 ++++++++++++++++++++++++++++++++ openbsc/tests/mgcp/mgcp_test.c | 59 +++++++ 5 files changed, 421 insertions(+), 221 deletions(-) create mode 100644 openbsc/src/libmgcp/mgcp_sdp.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

osmo-pcu.git branch je/master updated. 0.2-552-g04e72d3
by gitosis＠osmocom.org 13 Aug '15

13 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, je/master has been updated discards 81f2d449be7ab8c0d4b955b6c24a8cf646278ed3 (commit) via 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (81f2d449be7ab8c0d4b955b6c24a8cf646278ed3) \ N -- N -- N (04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=04e72d34f5cf885a4d6e2e6b2f2575a… commit 04e72d34f5cf885a4d6e2e6b2f2575ad09d0c007 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Aug 13 18:36:56 2015 +0200 tbf: Always start T3193 when changing state to GPRS_RLCMAC_WAIT_RELEASE Currently when receiving a PACKET DL ACK/NACK message with the Final Ack Indicator bit set, the TBF's state is set to GPRS_RLCMAC_WAIT_RELEASE but T3193 is only started when the LLC queue is empty. Otherwise the reuse_tbf() method is called to establish a new DL TBF. In that case, the timer is not started. This will leave the current TBF without a timer so it is potentially not released later on. This is recognisable by sticky entries in the output of the 'show tbf all' command and possibly allocation failures if there are too many of them. This commit changes the code to always start T3193 to make sure, that a timer is always active when the the state is set to GPRS_RLCMAC_WAIT_RELEASE. Note that TS 44.060, 9.3.2.6 requests to release the 'old' TBF immediately in some cases, which is not implemented by this change. This will lead to a longer reservation period of the TFI only, which is safer than reassigning it too early. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: tests/tbf/TbfTest.err | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch je/master created. 0.2-552-g81f2d44
by gitosis＠osmocom.org 13 Aug '15

13 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, je/master has been created at 81f2d449be7ab8c0d4b955b6c24a8cf646278ed3 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=81f2d449be7ab8c0d4b955b6c24a8cf… commit 81f2d449be7ab8c0d4b955b6c24a8cf646278ed3 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Aug 13 18:36:56 2015 +0200 tbf: Always start T3193 when changing state to GPRS_RLCMAC_WAIT_RELEASE Currently when receiving a PACKET DL ACK/NACK message with the Final Ack Indicator bit set, the TBF's state is set to GPRS_RLCMAC_WAIT_RELEASE but T3193 is only started when the LLC queue is empty. Otherwise the reuse_tbf() method is called to establish a new DL TBF. In that case, the timer is not started. This will leave the current TBF without a timer so it is potentially not released later on. This is recognisable by sticky entries in the output of the 'show tbf all' command and possibly allocation failures if there are too many of them. This commit changes the code to always start T3193 to make sure, that a timer is always active when the the state is set to GPRS_RLCMAC_WAIT_RELEASE. Note that TS 44.060, 9.3.2.6 requests to release the 'old' TBF immediately in some cases, which is not implemented by this change. This will lead to a longer reservation period of the TFI only, which is safer than reassigning it too early. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

openbsc.git branch master updated. 0.14.0-149-ge9f7c99
by gitosis＠osmocom.org 13 Aug '15

13 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via e9f7c9925c26b23f7c29ace8da381e439a658eeb (commit) from 29d58b734d169021bb794d259fa0dde205545bf1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=e9f7c9925c26b23f7c29ace8da381e43… commit e9f7c9925c26b23f7c29ace8da381e439a658eeb Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Thu Aug 13 18:31:09 2015 +0200 nat: Forward SDP files with multiple payload types in it The parsing code assumed that there will be a single payload type and this assumption is clearly wrong. Forward all of the payload types. The code is still only extracting the first type from the list. The variable name has been renamed to reflect this. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/bsc_nat.h | 2 +- openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c | 13 +++++++------ openbsc/tests/bsc-nat/bsc_data.c | 4 ++-- 3 files changed, 10 insertions(+), 9 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.14.0-148-g29d58b7
by gitosis＠osmocom.org 12 Aug '15

12 Aug '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 29d58b734d169021bb794d259fa0dde205545bf1 (commit) from c9dbe3c7b1fef1a4132a2415d3e74a04591735c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=29d58b734d169021bb794d259fa0dde2… commit 29d58b734d169021bb794d259fa0dde205545bf1 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Aug 12 13:35:46 2015 +0200 sms: Attempt to plug memory leaks seen at Rhizomatica Using the talloc leak report we see that there are some msgb's that are allocated for SMS but we don't have transactions or SMS around. We need to improve the name of the messages to uniquely dscribe where they are from but the obvious leak does occur in this routine. The no available transaction id is most likely the case where we leak memory. This should not occur and shows another issue with the smsqueue/smpp handling. It doesn't explain the subscr reference count issue either. Extract of the leak report: GSM 04.11 contains 1160 bytes in 1 blocks (ref 0) 0x2517dc0 GSM 04.11 contains 1160 bytes in 1 blocks (ref 0) 0x24b56e0 GSM 04.11 contains 1160 bytes in 1 blocks (ref 0) 0x23e7930 ----------------------------------------------------------------------- Summary of changes: openbsc/src/libmsc/gsm_04_11.c | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0