osmocom-commitlog July 2015

osmocom-commitlog@lists.osmocom.org

1 participants
113 discussions

osmo-pcu.git branch origin/jerlbeck/wip/pdch-alloc created. 0.2-520-g9c8b3e6
by gitosis＠osmocom.org 07 Jul '15

07 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, origin/jerlbeck/wip/pdch-alloc has been created at 9c8b3e69a971106f328ce52c877d8dfeb42c616e (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=9c8b3e69a971106f328ce52c877d8df… commit 9c8b3e69a971106f328ce52c877d8dfeb42c616e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jul 6 14:55:13 2015 +0200 alloc: Fix Tta/Tra handling (WIP, TODO) TODO: - cm - remove debug prints - fix MS_A/B/C ----------------------------------------------------------------------- hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch jerlbeck/master updated. 0.2-519-g9a2c665
by gitosis＠osmocom.org 07 Jul '15

07 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/master has been updated via 9a2c6655686fb773550b6e1050f60c821eee70b4 (commit) from efe62a73953349ba38781af2c264f273b2dde6e6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=9a2c6655686fb773550b6e1050f60c8… commit 9a2c6655686fb773550b6e1050f60c821eee70b4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jul 7 13:43:44 2015 +0200 llc: Fix comparison warning Fixes: Jenkins build 609 warning Addresses: llc.cpp:56, GNU C Compiler 3 (gcc), Priority: Normal comparison between signed and unsigned integer expressions Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/llc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch jerlbeck/master updated. 0.2-518-gefe62a7
by gitosis＠osmocom.org 07 Jul '15

07 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/master has been updated via efe62a73953349ba38781af2c264f273b2dde6e6 (commit) via 14376a73a5916a3dfa5bb65a2487d364a933e4c8 (commit) via 506f156f7a4aebb52dace00a760f86b2b4f5e19a (commit) via 1653f837e3be32d94eeaabf29ae89fdf1dc66bac (commit) via 20b7ba75017a590294dcd4e38135293f33f66740 (commit) via cc9358f95aca618db451faf53971c45dfe0b505a (commit) via 16c6ecc3657f62728845764731c189b3cb8daca2 (commit) via 5f494b8415ff4e5c9bf323ea7bc8326ad423c7ae (commit) via 9ae282372c9b3e10050244b8a1c9179122556175 (commit) via ed46afda6f647e47702379abacf632e7dcc9ee5b (commit) via ea65c72d069c279951c022daf337d99e3aaa670a (commit) from c91c18e6ef9ee5fca3d10b57ebddf211d3655a8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=efe62a73953349ba38781af2c264f27… commit efe62a73953349ba38781af2c264f273b2dde6e6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jul 2 15:48:25 2015 +0200 alloc: Use least reserved PDCH for algo A Currently the slot selection of algorithm A is based on the current slot usage by active TBF. Especially in the Dl after UL case which reflects the commen use case "MS initiates TCP connection", the resulting distribution is not optimal with respect to PDCH usage. This commit changes the implementation to use the slot reservation information instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=14376a73a5916a3dfa5bb65a2487d36… commit 14376a73a5916a3dfa5bb65a2487d364a933e4c8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jul 7 11:31:28 2015 +0200 alloc/test: Delete first TBF after the second is allocated Currently when using the test modes TEST_MODE_DL_AFTER_UL or TEST_MODE_UL_AFTER_DL, the first TBF is deleted before the second is allocated. The far more interesting case were to keep the first TBF a little bit longer until the second TBF has been created and delete then. This comes closer the the situation observed with real MS, where the first TBF takes some time (timeout or waiting for Ack) before it gets deleted and thus detached from the MS object. This commit delays the call to tbf_free accordingly. The effect can be observed in the results of the algo A tests, where the uniform distribution of the allocated PDCH is lost. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=506f156f7a4aebb52dace00a760f86b… commit 506f156f7a4aebb52dace00a760f86b2b4f5e19a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jul 2 13:19:49 2015 +0200 sba: Reverse TS search order Currently the search for an enabled PDCH slot for SBA start with the first TS. If there are more than 2 PDCH slots enabled, this slot will conflict with an existing multislot reservation for most multislot classes. This were less likely if the search were reversed and started with the last slot due to the 3 slot shift between Tx and Rx. When multislot allocation is enabled and several MS are connected, and increased rate of poll timeouts can be observed. This commit tries to reduce the number of poll timeouts by reverting the slot search order for SBA allocation. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=1653f837e3be32d94eeaabf29ae89fd… commit 1653f837e3be32d94eeaabf29ae89fdf1dc66bac Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 14:48:13 2015 +0200 alloc: Disable inner loop debugging by default The current logging statements within the inner loop of find_multi_slots drain quite a lot of CPU resources even if LOGL_DEBUG is not enabled. This might cause issues on the target hardware. This commit disables these LOGP calls unless the ENABLE_TS_ALLOC_DEBUG macro has been set explicitly. This results in a reduction in the CPU usage reported by callgrind for find_multi_slots from 42% to 25% when executing AllocTest. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=20b7ba75017a590294dcd4e38135293… commit 20b7ba75017a590294dcd4e38135293f33f66740 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 14:34:24 2015 +0200 alloc: Optimize find_free_usf According to callgrind, this function consumes 33% CPU when running the AllocTest program. This commit uses the assigned_usf() method to get the USFs allocated by a PDCH instead of traversing the TBFs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=cc9358f95aca618db451faf53971c45… commit cc9358f95aca618db451faf53971c45dfe0b505a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 14:10:13 2015 +0200 tbf: Keep a set of used TFI and USF per PDCH Currently is is rather expensive to get TFI and USF usage per PDCH, because the TBFs need to be scanned to get that information. This commit adds corresponding bit sets which get updated by the attach_tbf/detach_tbf methods of the gprs_rlcmac_pdch class. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=16c6ecc3657f62728845764731c189b… commit 16c6ecc3657f62728845764731c189b3cb8daca2 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 13:40:18 2015 +0200 alloc: Skip common TS without free USF when rating Currently the search of the "best" slot combination is done separately from the UL slot selection, which can lead to an allocation failure due to USF exhaustion even if another combination had been possible. This commit reduces the probability for this event by skipping UL slots without free USF while calculation the capacity. Note that the implementation is rather inefficient which will be fixed by the following commits. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=5f494b8415ff4e5c9bf323ea7bc8326… commit 5f494b8415ff4e5c9bf323ea7bc8326ad423c7ae Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Jul 1 13:10:41 2015 +0200 alloc: Only reserve 1 UL slot with algorithm B Since currently the algorithm B will only allocate a single UL slot and will have to stick to it (first common TS), the other possible UL slots will not be allocated while the reservation is kept. This commit adds code to update the reserved set of UL slots to only reserve the single common TS when the UL TBF is allocated. Interestingly this leads to fewer allocated TBF in some cases due to USF exhaustion. This will be improved by the following commit "alloc: Skip common TS without free USF". Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9ae282372c9b3e10050244b8a1c9179… commit 9ae282372c9b3e10050244b8a1c9179122556175 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Jul 1 12:27:30 2015 +0200 alloc: Set minimum slot capacity to 1 Currently the capacity of a PDCH slot is calculated as 32 - N_reserved for each direction. This can result in a capacity of 0 and even negative values. This commit forces the capacity of an usable slot to be at least zero under the assumption, that an overly reserved PDCH is still better than none. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ed46afda6f647e47702379abacf632e… commit ed46afda6f647e47702379abacf632e7dcc9ee5b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Jul 1 12:19:40 2015 +0200 alloc: Only use common UL slots when calculating the capacity Currently al possible UL slots are included in the capacity calculation which is the base of the slot selection. Nevertheless UL-only slots will never be used, since only one uplink slot (which must be a common slot) will be used. This patch changes the code to only include common slots in the capacity sum. Note that this might not be optimal if algorithm B supported multiple uplink slots. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ea65c72d069c279951c022daf337d99… commit ea65c72d069c279951c022daf337d99e3aaa670a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 22 16:14:23 2015 +0200 alloc: Replace Algorithm B implementation The current implementation always starts the downlink slot allocation with the first possible slot, depending on which channels are enabled and which multislot class is offered by the MS. So in configurations with many (>4) PDCH, some PDCH are not really used. The new implementation introduced by this commit differs as follows: - The reservation mechanism provided by GprsMs is used to avoid incompatibilities is used in the same way like algo A does. This basically means, that the allocation is done once when the first TBF is requested and then used until all TBF have been released. - All combinations of Rx and Tx slots are checked for compatibility with the multiscot class. Basically the combination with the most usable PDCH and the least number of reservations is used. - Only one UL slots is provided. - Tta and Tra are checked. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 28 +- src/bts.h | 15 + src/gprs_rlcmac_ts_alloc.cpp | 882 ++++++++++++++++++++++--------------------- src/sba.cpp | 4 +- tests/alloc/AllocTest.cpp | 46 +-- tests/alloc/AllocTest.err | 14 +- tests/alloc/AllocTest.ok | 470 ++++++++++++++--------- tests/tbf/TbfTest.err | 106 +++--- 8 files changed, 878 insertions(+), 687 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch jerlbeck/master updated. 0.2-507-gc91c18e
by gitosis＠osmocom.org 07 Jul '15

07 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/master has been updated discards 377250f3ada5701a104ccb5388bfe13640b53eb7 (commit) via c91c18e6ef9ee5fca3d10b57ebddf211d3655a8d (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (377250f3ada5701a104ccb5388bfe13640b53eb7) \ N -- N -- N (c91c18e6ef9ee5fca3d10b57ebddf211d3655a8d) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch master updated. 0.2-507-gc91c18e
by gitosis＠osmocom.org 07 Jul '15

07 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via c91c18e6ef9ee5fca3d10b57ebddf211d3655a8d (commit) via e0c734dcfe6501198e56bd3a89ad03ce5cfd5129 (commit) via 07111668d4b4bfe44c02077b29ed7d3cb8415134 (commit) via 4944c195d4a71f4aa5d9a3274907fa0bfed0e6ce (commit) via 5cd496d2083bef03d9f2425cabec9ec51c8e9254 (commit) via 83426b20a30832cbacd8165f5b757910e98f5417 (commit) via 617c7127f434fc866ca370e8812f1ad01ad90d27 (commit) via 23f93a15ca759b55b4713148f06d9a2d152278ab (commit) via ec478756ccc8e8df264811741bfc9c362cb9233d (commit) via 9380f5d2181c63922627cbff6abe5e3cd05523e4 (commit) via ac89a555fa73b24a77bb861811774a5af885bc84 (commit) via 699b8dca49df30b7bf6db7090eb416d1ad4fd46d (commit) via ccc34e4d30b962a2963c004d003d3851801ffb3b (commit) via c6d4ceeda6e6b96cc5bbc07fb9489587ed181f60 (commit) via 9ec49e2411abb206c82af643d18e2ada82e865e2 (commit) via fa464bbce90130a7f429cdbafac7b64b1fdacd32 (commit) via e565564bc9d74e09ec1962f86aa5155e97377e1f (commit) from cb1b494c896243a92a1969bb4c0ee4baddad2423 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=c91c18e6ef9ee5fca3d10b57ebddf21… commit c91c18e6ef9ee5fca3d10b57ebddf211d3655a8d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jul 7 09:33:29 2015 +0200 tbf: Add Poll Timeout counters This commits adds three poll timeout counters - RLC Assign Timeout - RLC Ack Timeout - RLC Release Timeout to help diagnosing to cause for these events. There seems to be an increased rate of these when a PDCH is shared by multiple TBFs. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 48 ++++++ src/bts.h | 37 +++++ src/gprs_ms.cpp | 83 +++++++++- src/gprs_ms.h | 29 ++++ src/gprs_rlcmac_ts_alloc.cpp | 153 +++++++++++++++++-- src/tbf.cpp | 59 ++++++- src/tbf.h | 7 + src/tbf_dl.cpp | 6 +- tests/alloc/AllocTest.cpp | 222 ++++++++++++++++++++++++++- tests/alloc/AllocTest.err | 19 ++- tests/alloc/AllocTest.ok | 355 +++++++++++++++++++++++++++++++++++++++++++ tests/ms/MsTest.cpp | 3 + tests/tbf/TbfTest.cpp | 14 ++ tests/tbf/TbfTest.err | 210 ++++++++++++++++++++++--- tests/tbf/TbfTest.ok | 2 + 15 files changed, 1188 insertions(+), 59 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

sdrangelove.git branch master updated. e8ad31d70f67d6b935ead1d124220e76499b358a
by gitosis＠osmocom.org 05 Jul '15

05 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Repository for OsmoSDR UI". The branch, master has been updated via e8ad31d70f67d6b935ead1d124220e76499b358a (commit) from 4dfb9844318374e0d22e543d3dfe1d67182b0d33 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/sdrangelove/commit/?id=e8ad31d70f67d6b935ead1d12422… commit e8ad31d70f67d6b935ead1d124220e76499b358a Author: Hoernchen <la(a)tfc-server.de> Date: Sun Jul 5 17:08:06 2015 +0200 allow building without sse ----------------------------------------------------------------------- Summary of changes: CMakeLists.txt | 25 +++++++++++++++++-------- include-gpl/dsp/interpolator.h | 2 ++ sdrbase/gui/glspectrum.cpp | 5 +++-- 3 files changed, 22 insertions(+), 10 deletions(-) hooks/post-receive -- Repository for OsmoSDR UI

1 0

simtrace.git branch v1.5 created. 6279da6fe08aa1a31d96d1cda4df40fe672274b7
by gitosis＠osmocom.org 05 Jul '15

05 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "SIM card APDU tracing based on AT91SAM7 and wireshark". The branch, v1.5 has been created at 6279da6fe08aa1a31d96d1cda4df40fe672274b7 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/simtrace/commit/?id=6279da6fe08aa1a31d96d1cda4df40f… commit 6279da6fe08aa1a31d96d1cda4df40fe672274b7 Author: King Kévin <kingkevin(a)cuvoodoo.info> Date: Sun Jul 5 09:58:19 2015 +0200 change microcontroller to SAM3S ----------------------------------------------------------------------- hooks/post-receive -- SIM card APDU tracing based on AT91SAM7 and wireshark

1 0

osmo-pcu.git branch jerlbeck/wip/pdch-alloc updated. 0.2-517-g838a3d1
by gitosis＠osmocom.org 03 Jul '15

03 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip/pdch-alloc has been updated discards 410d98e5d0c0eae76221a2d62a837b962f082506 (commit) discards eff0c350c848c642efad7ebe478a52c2c8c351ce (commit) discards a0ea29a5968308224b24b8718a8baa09806ad645 (commit) discards bdcfb71161aed1dd882ec7f9dcc4880146175155 (commit) discards 70960fb90cf4ab5efa2851f6927e53bb14878512 (commit) discards 9eb88f2348ce449deac1022950998ecef372a67b (commit) discards 5ef6a6028a1ed8aa59d3b2a701d53e4737c15478 (commit) discards 341c9189caf00c077ef73138d087bf29e3ae12d1 (commit) discards f5082f9372efa00090519a1b133b7eee88ea0d61 (commit) discards 6b3a27be054a2cc4667a22a4c435cd5d7ecb59ce (commit) discards 596f547a378786b2a9dea5a3b1e6182abf794e60 (commit) discards eb22ef5c755a3bacda653185f4ce63402bd95d93 (commit) discards 1e64bdbe3f7304fe5c5098ae0738d1ff06f14ad1 (commit) discards 4d4fb6597592dc16795868ab24cb9063765c5fb9 (commit) discards 8cee5c6d06ebc743414df3b3d8ea4af462db0851 (commit) discards 53cf1d4da78852cc168246cca1f4caa7e9acf837 (commit) discards 3ac16ddac029d00f71bfe722cb25d66c26961fc7 (commit) discards 0bb98075f4046e55c48478520752b09f71b545e0 (commit) discards 3c9fcfadc825256987ecb259b793c2f85ed5d21c (commit) discards ea061943e0d4179822224d7830d0f147ce90ba2c (commit) discards bbdca1b43caaa47ae71e35872909c25ffc091900 (commit) discards b70f7ca553b4747618383b5c631f7023dc0b2f84 (commit) discards 7e32903033af3f93dfe397e55de549870747d62c (commit) discards 3e4ac92f79446378fc4c4697d8f31ea1cdb6eafb (commit) discards 6f9587bd091ff95c7150646920bc3c8b1ea14d3b (commit) discards 6eca14991030ee87c9370c46d719e22763a65609 (commit) discards 8fb193a04767967350fd63501f2f46e8da3f1a66 (commit) discards 6ec4b962ba8be347708f3c4c3d3f1062ba1ffc91 (commit) discards 8b5add11527ee7108d0f11cf55d972651a4a0eb1 (commit) discards 8f37bfe3abfaeda30de7f1f2f813c7b9b20f39ac (commit) discards edcab1a0be452d8c977e35783ce489beb82da099 (commit) via 838a3d11815982f89f4ee33024795cfd91c795ae (commit) via f83fa4c3da863a35e3bf41d48d96e07a2267c380 (commit) via dcced44b6d4b7f16ba36311475ea78fb424b537f (commit) via aa2c339b1cf9bc7bd7562f046c4d738ce49f6e11 (commit) via 308175b012ff0de8490c312817567a18b4247d84 (commit) via 3c7ea0433dc690a45dcad0592990e8b39b6a5490 (commit) via 0272b8b8f69925e12a7f3bc281165afe061f982f (commit) via 6f094b3b61ae6b424866e8b6e06d8356b473d716 (commit) via ea79e641b653edce592d1b16602d0f4e49cdda73 (commit) via 4d6c8f423dcdd5c3d192332bd6d117811b119162 (commit) via 377250f3ada5701a104ccb5388bfe13640b53eb7 (commit) via e0c734dcfe6501198e56bd3a89ad03ce5cfd5129 (commit) via 07111668d4b4bfe44c02077b29ed7d3cb8415134 (commit) via 4944c195d4a71f4aa5d9a3274907fa0bfed0e6ce (commit) via 5cd496d2083bef03d9f2425cabec9ec51c8e9254 (commit) via 83426b20a30832cbacd8165f5b757910e98f5417 (commit) via 617c7127f434fc866ca370e8812f1ad01ad90d27 (commit) via 23f93a15ca759b55b4713148f06d9a2d152278ab (commit) via ec478756ccc8e8df264811741bfc9c362cb9233d (commit) via 9380f5d2181c63922627cbff6abe5e3cd05523e4 (commit) via ac89a555fa73b24a77bb861811774a5af885bc84 (commit) via 699b8dca49df30b7bf6db7090eb416d1ad4fd46d (commit) via ccc34e4d30b962a2963c004d003d3851801ffb3b (commit) via c6d4ceeda6e6b96cc5bbc07fb9489587ed181f60 (commit) via 9ec49e2411abb206c82af643d18e2ada82e865e2 (commit) via fa464bbce90130a7f429cdbafac7b64b1fdacd32 (commit) via e565564bc9d74e09ec1962f86aa5155e97377e1f (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (410d98e5d0c0eae76221a2d62a837b962f082506) \ N -- N -- N (838a3d11815982f89f4ee33024795cfd91c795ae) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=838a3d11815982f89f4ee33024795cf… commit 838a3d11815982f89f4ee33024795cfd91c795ae Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jul 2 15:48:25 2015 +0200 alloc: Use least reserved PDCH for algo A (TODO) TODO: - unify find_least_reserved_pdch and find_least_busy_pdch or - force find_multi_slots to single slot reservation - find a test case which reproduces the improvement observed with real MS http://cgit.osmocom.org/osmo-pcu/commit/?id=f83fa4c3da863a35e3bf41d48d96e07… commit f83fa4c3da863a35e3bf41d48d96e07a2267c380 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jul 2 13:19:49 2015 +0200 sba: Reverse TS search order (TODO) - when using multiple TS the first TS cannot be used for UL eventually if a TBF is still active or releasing. - Currently RACH requests are often accompanied by poll timeouts - This cannot prevent them completely (especially with multiple TRX in the future) http://cgit.osmocom.org/osmo-pcu/commit/?id=dcced44b6d4b7f16ba36311475ea78f… commit dcced44b6d4b7f16ba36311475ea78fb424b537f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 14:48:13 2015 +0200 alloc: Disable inner loop debugging by default (TODO) Callgrind: 42%-> 25% http://cgit.osmocom.org/osmo-pcu/commit/?id=aa2c339b1cf9bc7bd7562f046c4d738… commit aa2c339b1cf9bc7bd7562f046c4d738ce49f6e11 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 14:34:24 2015 +0200 alloc: Optimize find_free_usf According to callgrind, this function consumes 33% CPU when running the AllocTest program. This commit uses the assigned_usf() method to get the USFs allocated by a PDCH instead of traversing the TBFs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=308175b012ff0de8490c312817567a1… commit 308175b012ff0de8490c312817567a18b4247d84 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 14:10:13 2015 +0200 tbf: Keep a set of used TFI and USF per PDCH Currently is is rather expensive to get TFI and USF usage per PDCH, because the TBFs need to be scanned to get that information. This commit adds corresponding bit sets which get updated by the attach_tbf/detach_tbf methods of the gprs_rlcmac_pdch class. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=3c7ea0433dc690a45dcad0592990e8b… commit 3c7ea0433dc690a45dcad0592990e8b39b6a5490 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 13:40:18 2015 +0200 alloc: Skip common TS without free USF when rating (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=0272b8b8f69925e12a7f3bc281165af… commit 0272b8b8f69925e12a7f3bc281165afe061f982f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Jul 1 13:10:41 2015 +0200 alloc: Only reserve 1 UL slot with algorithm B (TODO) Since currently the algorithm B will only allocate a single UL slot and will have to stick to it (first common TS), the other possible UL slots will not be allocated while the reservation is kept. This commit adds code to update the reserved set of UL slots to the single common TS when the UL TBF is allocated. TODO: - test it Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=6f094b3b61ae6b424866e8b6e06d835… commit 6f094b3b61ae6b424866e8b6e06d8356b473d716 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Jul 1 12:27:30 2015 +0200 alloc: Set minimum slot capacity to 1 (TODO) - < 0 can only happen rarely (if at all ATM) - doesn't change anything TODO: - test it anyway http://cgit.osmocom.org/osmo-pcu/commit/?id=ea79e641b653edce592d1b16602d0f4… commit ea79e641b653edce592d1b16602d0f4e49cdda73 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Jul 1 12:19:40 2015 +0200 alloc: Only use common UL slots when calculating the capacity Currently al possible UL slots are included in the capacity calculation which is the base of the slot selection. Nevertheless UL-only slots will never be used, since only one uplink slot (which must be a common slot) will be used. This patch changes the code to only include common slots in the capacity sum. Note that this might not be optimal if algorithm B supported multiple uplink slots. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=4d6c8f423dcdd5c3d192332bd6d1178… commit 4d6c8f423dcdd5c3d192332bd6d117811b119162 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 22 16:14:23 2015 +0200 WIP Algorithm B UL (TODO) Select UL slot based on slot usage (similar to algorithm A) - Ensure to keep the first common TS - Some tests expected multiple UL slots which is disabled in the current algo B impl (and the former impl was labelled 'Assign one uplink slot' so it schouldn't have returned more than 1 UL slot either). TODO: - cm ----------------------------------------------------------------------- Summary of changes: src/tbf_dl.cpp | 2 - tests/alloc/AllocTest.cpp | 161 ++++++++++++++++++--- tests/alloc/AllocTest.err | 10 ++ tests/alloc/AllocTest.ok | 350 +++++++++++++++++++++++++++++++++++++++++++++- tests/tbf/TbfTest.err | 34 ----- 5 files changed, 494 insertions(+), 63 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch jerlbeck/master updated. 0.2-507-g377250f
by gitosis＠osmocom.org 03 Jul '15

03 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/master has been updated discards 0c0ed3e98aecb331d67910dad28842e97ece7ec8 (commit) via 377250f3ada5701a104ccb5388bfe13640b53eb7 (commit) via e0c734dcfe6501198e56bd3a89ad03ce5cfd5129 (commit) via 07111668d4b4bfe44c02077b29ed7d3cb8415134 (commit) via 4944c195d4a71f4aa5d9a3274907fa0bfed0e6ce (commit) via 5cd496d2083bef03d9f2425cabec9ec51c8e9254 (commit) via 83426b20a30832cbacd8165f5b757910e98f5417 (commit) via 617c7127f434fc866ca370e8812f1ad01ad90d27 (commit) via 23f93a15ca759b55b4713148f06d9a2d152278ab (commit) via ec478756ccc8e8df264811741bfc9c362cb9233d (commit) via 9380f5d2181c63922627cbff6abe5e3cd05523e4 (commit) via ac89a555fa73b24a77bb861811774a5af885bc84 (commit) via 699b8dca49df30b7bf6db7090eb416d1ad4fd46d (commit) via ccc34e4d30b962a2963c004d003d3851801ffb3b (commit) via c6d4ceeda6e6b96cc5bbc07fb9489587ed181f60 (commit) via 9ec49e2411abb206c82af643d18e2ada82e865e2 (commit) via fa464bbce90130a7f429cdbafac7b64b1fdacd32 (commit) via e565564bc9d74e09ec1962f86aa5155e97377e1f (commit) via cb1b494c896243a92a1969bb4c0ee4baddad2423 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (0c0ed3e98aecb331d67910dad28842e97ece7ec8) \ N -- N -- N (377250f3ada5701a104ccb5388bfe13640b53eb7) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=377250f3ada5701a104ccb5388bfe13… commit 377250f3ada5701a104ccb5388bfe13640b53eb7 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jul 2 12:54:26 2015 +0200 tbf: Add Poll Timeout counters This commits adds three poll timeout counters - RLC Assign Timeout - RLC Ack Timeout - RLC Release Timeout to help diagnosing to cause for these events. There seems to be an increased rate of these when a PDCH is shared by multiple TBFs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=e0c734dcfe6501198e56bd3a89ad03c… commit e0c734dcfe6501198e56bd3a89ad03ce5cfd5129 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jul 3 14:03:33 2015 +0200 Revert "tbf: Add GprsMs* argument to update() and use it in reuse_tbf" This reverts commit 2272a83a13b57ea7e99fe96ac76e4ad892e19e90. The modification is no longer needed, since the call to update has been removed from reuse_tbf(). Conflicts: src/tbf_dl.cpp Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=07111668d4b4bfe44c02077b29ed7d3… commit 07111668d4b4bfe44c02077b29ed7d3cb8415134 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 13:30:43 2015 +0200 tbf: Remove call to update() in reuse_tbf Since both TBF are based on the same reservation which means that they should be compatible with respect to the slot usage, and since the new TBF has not been forced to single slot usage, an update of the allocation is not necessary now. This commit removes the call to update() from within reuse_tbf(). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=4944c195d4a71f4aa5d9a3274907fa0… commit 4944c195d4a71f4aa5d9a3274907fa0bfed0e6ce Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jul 2 12:04:20 2015 +0200 tbf: Set ms in call to tbf_alloc_dl_tbf The call to tbf_alloc_dl_tbf misses the pointer to the GprsMs object which is already known in that case (tbf_reuse). This leads to a full reallocation of the PDCH slots, which is possibly incompatible with the old set of slots. This can result in hanging TCP connections and TCP connection failures. This commit replaces the old NULL value by the actual GprsMs object. Since the set_ms() is also done within the tbf_alloc_dl_tbf method, that call is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=5cd496d2083bef03d9f2425cabec9ec… commit 5cd496d2083bef03d9f2425cabec9ec51c8e9254 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 10:24:37 2015 +0200 alloc: Base algo A on reserved PDCHs Currently algorithm A bases its time slots selection on the number of TBF actively using the PDCHs. This statistically prefers the first time slots, especially with short living TBFs. So when the first TBF is triggered by an uplink transfer (which generally results in a short-lived TBF) the potentially longer living DL TBF will be bound to the same slot. When another MS then requests an uplink TBF, it will get the same slot (no UL TBF currently active). This commit changes the algorithm to base its selection on reserved slots instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=83426b20a30832cbacd8165f5b75791… commit 83426b20a30832cbacd8165f5b757910e98f5417 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 09:44:05 2015 +0200 alloc: Ignore slots with differing TSC if multiple slots are requested According to TS 45.002, 6.4.2 the training sequence (TSC) must be the same for all slots in a multi-slot set. This commit updates find_possible_pdchs() to only consider slots with the same TSC if more that 1 slot shall be assigned. Note that the first PDCH's TSC will be used as reference, so if two or more groups with a common TSC are configured, only the first will be used. This restriction does not apply to algorithm A, since it will not assign more than one slot and therefore sets the max_slots parameter to 1. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=617c7127f434fc866ca370e8812f1ad… commit 617c7127f434fc866ca370e8812f1ad01ad90d27 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 09:18:30 2015 +0200 ms: Get the set of slots currently active This commits adds methods to GprsMs and gprs_rlcmac_tbf to retrieve the slots that are actively used. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=23f93a15ca759b55b4713148f06d9a2… commit 23f93a15ca759b55b4713148f06d9a2d152278ab Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jun 30 08:52:54 2015 +0200 ms: Add support for slot reservation In contrast to the slots currently used by existing TBFs, the reserved slots refer to the time slots that can be used for newly allocated TBFs without causing conflicts (given that the first common TS does not change). They correspond to the potential use of the PDCHs and can be used to achieve a more uniform slot allocation. This commit adds bit set based methods to GprsMs and gprs_rlcmac_trx and a counter to gprs_rlcmac_pdch. The current TRX will also be stored in the MS object. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ec478756ccc8e8df264811741bfc9c3… commit ec478756ccc8e8df264811741bfc9c362cb9233d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jun 19 16:35:38 2015 +0200 alloc: Load balancing for algo A Currently only the first enabled PDCH will be used. Beside the throughput this will also limit the number of TBFs: - number of UL TBFs <= 7 - number of DL TBFs <= 32 This commit changes the allocation algorithm to use the PDCH with the least number of attached TBFs. This will improve the troughput in both directions and the UL limits: - number of UL TBFs <= min(32, N_PDCH * 7) UL TBFs Ticket: #1794 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9380f5d2181c63922627cbff6abe5e3… commit 9380f5d2181c63922627cbff6abe5e3cd05523e4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jul 3 12:38:59 2015 +0200 tbf: Add GprsMs* argument to update() and use it in reuse_tbf Since set_ms() is caled on the new DL TBF, the old DL TBF loses the reference to the MS object. This will lead to a segfault, when update() is called in reuse_tbf(). This commit adds an optional GprsMs* parameter to update() and uses it for the slot allocation. This fixes a TbfTest crash that would otherwise occur after applying the next commit. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ac89a555fa73b24a77bb861811774a5… commit ac89a555fa73b24a77bb861811774a5af885bc84 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 14:18:46 2015 +0200 ms: Add tbf() method to get the TBF based on the direction To avoid the need for a switch or conditional statement when needing a TBF from an MS object in direction independant code, this method contains that case distinction. For additional flexibility, a reverse() function is added to get the opposite direction. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=699b8dca49df30b7bf6db7090eb416d… commit 699b8dca49df30b7bf6db7090eb416d1ad4fd46d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 14:05:55 2015 +0200 ms: Add first_common_ts method to GprsMs This method gets the index (0 based) of first common time slot used by the TBFs attach to it. It expects that all of them have the same notion of this. If no TBF is attached, -1 will be returned. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=ccc34e4d30b962a2963c004d003d385… commit ccc34e4d30b962a2963c004d003d3851801ffb3b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 13:45:05 2015 +0200 tbf: Maintain the number of TBF per PDCH Currently the PDCH object do not know anything about the TBFs using them. To make the slot allocation load dependant, at least some numbers are required. This commit adds TBF counters (one per direction) and the related methods attach_tbf, detach_tbf, and num_tbfs to gprs_rlcmac_pdch. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=c6d4ceeda6e6b96cc5bbc07fb948958… commit c6d4ceeda6e6b96cc5bbc07fb9489587ed181f60 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 13:03:46 2015 +0200 tbf/test: Add assertions These assertions check for the TBF allocation result before the tbf object is dereferenced the first time. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9ec49e2411abb206c82af643d18e2ad… commit 9ec49e2411abb206c82af643d18e2ada82e865e2 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 13:00:20 2015 +0200 alloc/test: Use LOGL_DEBUG environment variable When this environment variable is set, the logging level is set to LOGL_DEBUG to help debugging without putting everything into AllocTest.err. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=fa464bbce90130a7f429cdbafac7b64… commit fa464bbce90130a7f429cdbafac7b64b1fdacd32 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 12:45:11 2015 +0200 alloc/test: Enhance test_alloc_a This commit adds: - an assertion to check that count is valid, - an assertion the verify that tbf_alloc did not fail - a slots parameter to specify the enabled slots - additional test invocations with more slots enabled Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=e565564bc9d74e09ec1962f86aa5155… commit e565564bc9d74e09ec1962f86aa5155e97377e1f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jun 29 12:19:52 2015 +0200 alloc/test: Add test for successive allocation This test allocates as many as possible UL/DL TBF pairs, shows their PDCH usage, and checks how many of them has been created successfully. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 48 ++++++ src/bts.h | 37 +++++ src/gprs_ms.cpp | 83 +++++++++- src/gprs_ms.h | 29 ++++ src/gprs_rlcmac_ts_alloc.cpp | 153 +++++++++++++++++-- src/tbf.cpp | 59 ++++++- src/tbf.h | 7 + src/tbf_dl.cpp | 6 +- tests/alloc/AllocTest.cpp | 222 ++++++++++++++++++++++++++- tests/alloc/AllocTest.err | 19 ++- tests/alloc/AllocTest.ok | 355 +++++++++++++++++++++++++++++++++++++++++++ tests/ms/MsTest.cpp | 3 + tests/tbf/TbfTest.cpp | 14 ++ tests/tbf/TbfTest.err | 210 ++++++++++++++++++++++--- tests/tbf/TbfTest.ok | 2 + 15 files changed, 1188 insertions(+), 59 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

osmo-pcu.git branch mmcternan/bb_maint updated. 0.2-322-g331dd01
by gitosis＠osmocom.org 03 Jul '15

03 Jul '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, mmcternan/bb_maint has been updated via 331dd016059b6dae03032c320c4b32a85d8d26ea (commit) from f3405e5b0342362d5d592f013014847a4dc135d8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=331dd016059b6dae03032c320c4b32a… commit 331dd016059b6dae03032c320c4b32a85d8d26ea Author: Michael McTernan <mike.mcternan(a)wavemobile.com> Date: Fri Jul 3 11:12:03 2015 +0100 Changes to compile with mnc_t. Signed-off-by: Michael McTernan <mike.mcternan(a)wavemobile.com> ----------------------------------------------------------------------- Summary of changes: src/gprs_bssgp_pcu.cpp | 12 ++++++++---- src/gprs_bssgp_pcu.h | 2 +- src/pcu_l1_if.cpp | 3 ++- src/pcu_main.cpp | 7 ++++--- src/pcuif_proto.h | 4 +++- tests/emu/pcu_emu.cpp | 2 +- 6 files changed, 19 insertions(+), 11 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog July 2015