This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
discards 50a88f8eb4ad183bfc1f870a99c7f0f1f2022acb (commit)
discards e201bf5778b073e7101a707435de0777a38b832f (commit)
discards 192cf8b56ace2ea168153571f9c5eae53fd47365 (commit)
discards 7f2d40ceb755943d52fcae8ddb12c09e2d0c623f (commit)
discards c1e297a9f030429a075392b4888d26539a333dbf (commit)
discards 444fe1be787fd291b5bc9c347303047e78089c35 (commit)
discards 3bf4d4ddd97383a98d3da56f3b57e7aac2adcf54 (commit)
discards da53b650561f5c2e81bd499657497713a7276725 (commit)
discards 036874d27b458d4359a9132e3361e47b42935117 (commit)
discards 3c4c17178f6d41ee83b441b9ce7d55d4e404b73d (commit)
discards 89a83524dc4dcf73bedd8c98659bfd006a422a3b (commit)
discards 5b3ed5a6cd4bc03b225e59910d647a5d4d21243a (commit)
discards 5b231c38318754de6b9b16e91d0f1dc29290872d (commit)
discards a0e2c562de54d87a48bdd059e18ef782f18c3cc8 (commit)
discards d369720ec8bda4f2fb3ee0b1a719211d66df247a (commit)
discards f397ca83bea6f15f194b522d9278695c7a27765f (commit)
discards 402b117fe1ec63fe9c30eaa38850a477601799e9 (commit)
discards fce0d1ee3b0717d18d081db9ceadbab2525441b8 (commit)
discards 786d555de00d65e6c0b07008fe1cc8f593118c2e (commit)
discards 42d114b846a4a1852f22ecfd56d8872cae83018a (commit)
discards 03203415845cd646c748983f8ab49ecb8ca0581a (commit)
discards fa74d6dd746e65166d4f7d62d7c6ff698bec2900 (commit)
discards 6de6ea937eae341577dedb93d95bd9ded7fd440f (commit)
via 041995dacf26082cb4883a99f8d5a30c109efff7 (commit)
via ae1e7a00efcdea016008c54cd442e38c141e4200 (commit)
via cf6ba14087de5ae464528280be3a784f8c6c6d6d (commit)
via 22174abe556b8419a42b3b67b191ac94e30d81c5 (commit)
via 79dce146fbb4096f737776d5c217b71a31b16eb9 (commit)
via c33ac58604665455699eddb2bad5cfd8242f193c (commit)
via 310b8bf647c8b2478dec3a27c11942cf4b6f1e6a (commit)
via 97c5e61b0a58a507a5ad5ee0559da9182596d287 (commit)
via 9586e51efd243cce41a887448bf442f3f49d4c5f (commit)
via 58e14c99f4c6b9be3a7b15c72d0f669b05d713cf (commit)
via 4395a3d823a2243531ef15d05ef498427d9c409b (commit)
via d4c79db2905f6380773adc8d12ddcddc5e21077e (commit)
via a5f12d907cc6554b7c1a0e7c63b6a7287796f149 (commit)
via 27883dd1891686ed50d9fff017b07416ef785cce (commit)
via f9f6739cece7073aca938b5258ab7d590efd9f0f (commit)
via d9e3579689f5678d761ac331c152d1286e8f94ef (commit)
via c80f953d117a8d2406e37f200bf4aa62ef7d3cf2 (commit)
via 70cb65941457b29bf811ee570b3cf21ae48e99bc (commit)
via 3d53bfd7668f491f2904580c33f1a461fa631132 (commit)
via e243b5c6b6183d911dc6a9a245e1c95a798ec280 (commit)
via a63c177aa3ab50a7a00c04ac10ea282376ea4bc7 (commit)
via 42acf2cd2cc4ebbd2611c67aeb0744778e0ba72a (commit)
via 8fbfaa51bb3f583eeebc1239388832b2e966d424 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (50a88f8eb4ad183bfc1f870a99c7f0f1f2022acb)
\
N -- N -- N (041995dacf26082cb4883a99f8d5a30c109efff7)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=041995dacf26082cb4883a99f8d5a30c…
commit 041995dacf26082cb4883a99f8d5a30c109efff7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 22:19:22 2015 +0100
gtphub: use file for incremental restart counter.
Force passing a restart counter, by adding such arg to gtphub_start().
In gtphub_main.c, add -r,--restart-file <path> and next_restart_count() to
maintain the counter file.
While at it, tweak the cmdline help to unify the formatting.
http://cgit.osmocom.org/openbsc/commit/?id=ae1e7a00efcdea016008c54cd442e38c…
commit ae1e7a00efcdea016008c54cd442e38c141e4200
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 05:20:18 2015 +0100
gtphub: complain about excess cmdline args.
http://cgit.osmocom.org/openbsc/commit/?id=cf6ba14087de5ae464528280be3a784f…
commit cf6ba14087de5ae464528280be3a784f8c6c6d6d
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 03:33:29 2015 +0100
gtphub: track tunnels explicitly.
So far, gtphub worked perfectly by only tracking single TEIs ... for probably
most uses. But a Ctrl plane tunnel may have expired despite a still active
corresponding User plane tunnel. The User plane would continue to work
indefinitely, but if any Ctrl messages followed after more than six hours of
Ctrl silence, they would have been dropped due to an expired TEI mapping.
We want to
- combine expiry of a user TEI with its ctrl TEI. (done in this patch)
- upon delete PDP context, remove both user and ctrl TEI mappings. (future)
- when a peer indicates a restart counter bump, invalidate its tunnels.
(future)
To facilitate these, track tunnels, complete with both SGSN's and GGSN's
address, original and replaced TEIs, all for both user and ctrl plane, in a
single struct. A single expiry entry handles the entire tunnel, instead of
previously four separate expiries for each endpoint identifier.
Add the concept of a "side", being either GGSN or SGSN.
Track the originating side in the gtp_packet_desc. For clarity, explicitly
track the received header TEI in header_tei_rx, since set_tei() overwrites
header_tei to reflect the packet's replaced header TEI, and the originally
received header TEI still needs to be used for matching a Create PDP Context
Response up with its Request (and for logging).
Adjust the test suite to expect tunnel listing strings instead of TEI mappings,
with a bonus of making it a lot easier to grok and including the IP addresses.
Note: the current implementation is as slow as can possibly be, iterating all
the tunnels all the time. Optimizations are kept for a future commit, on
purpose.
BTW, the sequence number mapping/unmapping structures remain unchanged.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=22174abe556b8419a42b3b67b191ac94…
commit 22174abe556b8419a42b3b67b191ac94e30d81c5
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 25 16:50:19 2015 +0100
gtphub: fix filename mentioned in comment
http://cgit.osmocom.org/openbsc/commit/?id=79dce146fbb4096f737776d5c217b71a…
commit 79dce146fbb4096f737776d5c217b71a31b16eb9
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 25 16:45:59 2015 +0100
gtphub: cosmetic/prepare: rename expiry queues.
The expiry queues are already used for resolved GGSN addresses, and will
soon enlist tunnel structs. Hence the naming should be more general.
http://cgit.osmocom.org/openbsc/commit/?id=c33ac58604665455699eddb2bad5cfd8…
commit c33ac58604665455699eddb2bad5cfd8242f193c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:32:23 2015 +0100
gtphub: add assertion to ensure expiry ordering.
Make 100% sure the user adds expiring_items in chronological order by asserting
that a newly added expiry is >= the last expiry in the queue. Add llist_last()
to facilitate.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=310b8bf647c8b2478dec3a27c11942cf…
commit 310b8bf647c8b2478dec3a27c11942cf4b6f1e6a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:31:06 2015 +0100
gtphub: refresh TEI timeout when TEI is used.
Make sure a TEI mapping remains valid when it is in use (so far all mappings
would expire after 6 hours, in use or not).
Add regression test for this.
Note: this does not yet refresh a Ctrl TEI mapping when a corresponding User
TEI is used (todo?).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=97c5e61b0a58a507a5ad5ee0559da918…
commit 97c5e61b0a58a507a5ad5ee0559da9182596d287
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:30:38 2015 +0100
gtphub: cosmetic/prepare: add nr_map_refresh().
http://cgit.osmocom.org/openbsc/commit/?id=9586e51efd243cce41a887448bf442f3…
commit 9586e51efd243cce41a887448bf442f3f49d4c5f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:27:13 2015 +0100
gtphub: move timestamp into packet struct.
Instead of passing the current time around in function arguments ('now'),
rather store the current time once upon decoding a GTP packet in the
gtp_packet_desc passed around anyway ('p->timestamp').
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=58e14c99f4c6b9be3a7b15c72d0f669b…
commit 58e14c99f4c6b9be3a7b15c72d0f669b05d713cf
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:23:44 2015 +0100
gtphub: cosmetic: fix an argument name.
http://cgit.osmocom.org/openbsc/commit/?id=4395a3d823a2243531ef15d05ef49842…
commit 4395a3d823a2243531ef15d05ef498427d9c409b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 03:16:19 2015 +0100
gtphub: first vty show commands.
Start adding VTY commands to show rate counters / statistics / cache dumps.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=d4c79db2905f6380773adc8d12ddcddc…
commit d4c79db2905f6380773adc8d12ddcddc5e21077e
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 01:28:40 2015 +0100
gtphub: add first rate counters
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=a5f12d907cc6554b7c1a0e7c63b6a728…
commit a5f12d907cc6554b7c1a0e7c63b6a7287796f149
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 01:27:22 2015 +0100
gtphub: cosmetic: clarify bind pointer naming.
Some gtphub_bind pointers point to an array of binds, some point directly at
instances. Make the distinction between the two more obvious by adding an
'_arr' suffix to the array ones.
Partly in preparation for upcoming rate counters.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=27883dd1891686ed50d9fff017b07416…
commit 27883dd1891686ed50d9fff017b07416ef785cce
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 00:08:28 2015 +0100
gtphub: add explicit cleanup handles.
Clean up functionality is added for the test suite only, to be able to clean
out all allocations and test against memory leaks.
So far, it was sufficient to expire everything to free a gtphub. In preparation
for the upcoming rate counters, which will need to be freed explicitly, add
gtphub functions to clean up everything.
As added bonus, also close the sockets explicitly -- not really needed upon
program exit, neither by the test suite, but *if* we have a cleanup function,
it should clean up everything properly.
Closing the sockets is however kept separate, for the test suite.
gtphub_start() and gtphub_stop() are for normal use (published in gtphub.h),
and gtphub_init() and gtphub_free() are for the test suite, without sockets.
(gtphub_stop() will probably never be called by anyone, but its existence
completes the picture.)
In gtphub_test.c, have a function to clean up the testing gtphub struct. First,
expire everything by timeout, assert emptiness, then call the cleanup function.
Call from each test in the end.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=f9f6739cece7073aca938b5258ab7d59…
commit f9f6739cece7073aca938b5258ab7d590efd9f0f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 00:04:41 2015 +0100
gtphub: ensure cleanup of peer addresses.
Upon calling gtphub_peer_del(), all addresses and ports should already have
expired (by force). Make sure the code heeds that with a so far missing
assertion.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=d9e3579689f5678d761ac331c152d128…
commit d9e3579689f5678d761ac331c152d1286e8f94ef
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 19 00:44:52 2015 +0100
gtphub: send gtphub's own restart counter, fix type.
So far, the sender's restart counter was copied through, which would break as
soon as more than one SGSN or more than one GGSN would talk to the same peer.
Also fix the restart counter data type (just one octet after all).
gtphub should also persist its restart counter and handle peers that have
rebooted, both of which is still not implemented.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=c80f953d117a8d2406e37f200bf4aa62…
commit c80f953d117a8d2406e37f200bf4aa62ef7d3cf2
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 18:11:32 2015 +0100
gtphub: ares vty and init
From sgsn_vty.c, copy the cfg_grx_ggsn_cmd to add an ares server to the static
sgsn_instance.
This is sort of preliminary. As described in comments, the sgsn_ares functions
should actually be separated from the static sgsn structure. gtphub keeps such
an sgsn structure just for the sgsn_ares functions.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=70cb65941457b29bf811ee570b3cf21a…
commit 70cb65941457b29bf811ee570b3cf21ae48e99bc
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 18:11:09 2015 +0100
gtphub: review some logging.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=3d53bfd7668f491f2904580c33f1a461…
commit 3d53bfd7668f491f2904580c33f1a461fa631132
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 17:53:00 2015 +0100
gtphub: cosmetic: rename a file.
gtphub_ext.c's initial purpose was to wrap a specific function. The file
then turned into everything related to DNS, which fits pretty well. Rename
to gtphub_ares.c.
Tweak the header comment to reflect the new file name.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e243b5c6b6183d911dc6a9a245e1c95a…
commit e243b5c6b6183d911dc6a9a245e1c95a798ec280
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 17 14:30:37 2015 +0100
gtphub: nr_map: add min,max and wrap.
Implement min/max bounds for nr_pool, adjust nr_pool_init() and current tests,
and create unit tests for nr_map wrapping.
Sequence numbers range from 0 to 65535, while TEIs range from 1 to 0xffffffff.
Both cause problems when the nr_pool surpasses the range: seq exit their valid
range, causing unmappings to fail, and a TEI would be mapped as zero (invalid).
Add a comment about TEI wrapping, and lose the comment about random TEIs (not
really important).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=a63c177aa3ab50a7a00c04ac10ea2823…
commit a63c177aa3ab50a7a00c04ac10ea282376ea4bc7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 17 14:24:46 2015 +0100
gtphub: fix number map range for TEIs.
Use unsigned int for nr_map, just large enough to fit the TEI space.
Adjust log output formats and casts accordingly.
Fixes: TEIs are uint32_t, but the nr_map so far used int. This would cause TEIs
from 0x80000000 on to be handled and printed as a negative value.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=42acf2cd2cc4ebbd2611c67aeb074477…
commit 42acf2cd2cc4ebbd2611c67aeb0744778e0ba72a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 17:09:22 2015 +0100
gtphub: add to debian build
By the example of osmo-sgsn, package osmo-gtphub for debian.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=8fbfaa51bb3f583eeebc1239388832b2…
commit 8fbfaa51bb3f583eeebc1239388832b2e966d424
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 22:20:50 2015 +0100
gtphub: remove another obsolete comment.
-----------------------------------------------------------------------
Summary of changes:
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
discards cb591d0e9175dad898de019612a68f9adfd25f4b (commit)
discards 88d06caa712a3fd40960c0d11d45373dc9341659 (commit)
discards 2d228573f2df28be5d185d8d93ec3b887f526eb7 (commit)
discards f0dc0f3bd9d702c59d46cd358ba9915377136cfc (commit)
discards ad51b759181064c87f26ed702c16d3edc3bc12ec (commit)
discards e6b56c49fd36757aa507bbbef868cdc98d2cd3ca (commit)
discards 5d2e92036d0bc6fbcab522e3eb3cb71cf62d80cc (commit)
discards 628c0c8f82673390e92cc5f532f7f1e0d368c26c (commit)
discards eb7b0a83b4555222215a0ec6155e0eecaadf3f24 (commit)
discards 1c31e9a0793c90c856f6537d31b8f20e5d93ff4b (commit)
discards e68fee7637ac953837adddb8c3428909a07ecfcb (commit)
discards b30bfedb11e10ea7f99a5e98d5b8274cb866baa8 (commit)
discards 5171ef9d2059625cf4d4c5775fe8e0c18ee5cd8b (commit)
discards 25a88f932df6ea89d33da5ffafc883f735462636 (commit)
discards 105b984f6af0907838529755efc6cf3ba3f5bad8 (commit)
discards bbef1e556ad3d2968ad2baa9f41b4e932b0ec556 (commit)
discards 8a9ebc14bfc2937d0402aa9f8cba82a323f4889a (commit)
discards bf6ac16ae3f906accb7b68ed9fffd343bcc1f148 (commit)
discards 5bdd48daaf45e824f3a683933617f41f65543d71 (commit)
discards 47493b5d258e66dcc8760f477aa6ecfb9dcbd442 (commit)
discards c0e13b2dbd36015f25bdeb8c07abb13ac4ef65ec (commit)
via 50a88f8eb4ad183bfc1f870a99c7f0f1f2022acb (commit)
via e201bf5778b073e7101a707435de0777a38b832f (commit)
via 192cf8b56ace2ea168153571f9c5eae53fd47365 (commit)
via 7f2d40ceb755943d52fcae8ddb12c09e2d0c623f (commit)
via c1e297a9f030429a075392b4888d26539a333dbf (commit)
via 444fe1be787fd291b5bc9c347303047e78089c35 (commit)
via 3bf4d4ddd97383a98d3da56f3b57e7aac2adcf54 (commit)
via da53b650561f5c2e81bd499657497713a7276725 (commit)
via 036874d27b458d4359a9132e3361e47b42935117 (commit)
via 3c4c17178f6d41ee83b441b9ce7d55d4e404b73d (commit)
via 89a83524dc4dcf73bedd8c98659bfd006a422a3b (commit)
via 5b3ed5a6cd4bc03b225e59910d647a5d4d21243a (commit)
via 5b231c38318754de6b9b16e91d0f1dc29290872d (commit)
via a0e2c562de54d87a48bdd059e18ef782f18c3cc8 (commit)
via d369720ec8bda4f2fb3ee0b1a719211d66df247a (commit)
via f397ca83bea6f15f194b522d9278695c7a27765f (commit)
via 402b117fe1ec63fe9c30eaa38850a477601799e9 (commit)
via fce0d1ee3b0717d18d081db9ceadbab2525441b8 (commit)
via 786d555de00d65e6c0b07008fe1cc8f593118c2e (commit)
via 42d114b846a4a1852f22ecfd56d8872cae83018a (commit)
via 03203415845cd646c748983f8ab49ecb8ca0581a (commit)
via fa74d6dd746e65166d4f7d62d7c6ff698bec2900 (commit)
via 6de6ea937eae341577dedb93d95bd9ded7fd440f (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (cb591d0e9175dad898de019612a68f9adfd25f4b)
\
N -- N -- N (50a88f8eb4ad183bfc1f870a99c7f0f1f2022acb)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=50a88f8eb4ad183bfc1f870a99c7f0f1…
commit 50a88f8eb4ad183bfc1f870a99c7f0f1f2022acb
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 22:19:22 2015 +0100
gtphub: use file for incremental restart counter.
Force passing a restart counter, by adding such arg to gtphub_start().
In gtphub_main.c, add -r,--restart-file <path> and next_restart_count() to
maintain the counter file.
While at it, tweak the cmdline help to unify the formatting.
http://cgit.osmocom.org/openbsc/commit/?id=e201bf5778b073e7101a707435de0777…
commit e201bf5778b073e7101a707435de0777a38b832f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 05:20:18 2015 +0100
gtphub: complain about excess cmdline args.
http://cgit.osmocom.org/openbsc/commit/?id=192cf8b56ace2ea168153571f9c5eae5…
commit 192cf8b56ace2ea168153571f9c5eae53fd47365
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 03:33:29 2015 +0100
gtphub: track tunnels explicitly.
So far, gtphub worked perfectly by only tracking single TEIs ... for probably
most uses. But a Ctrl plane tunnel may have expired despite a still active
corresponding User plane tunnel. The User plane would continue to work
indefinitely, but if any Ctrl messages followed after more than six hours of
Ctrl silence, they would have been dropped due to an expired TEI mapping.
We want to
- combine expiry of a user TEI with its ctrl TEI. (done in this patch)
- upon delete PDP context, remove both user and ctrl TEI mappings. (future)
- when a peer indicates a restart counter bump, invalidate its tunnels.
(future)
To facilitate these, track tunnels, complete with both SGSN's and GGSN's
address, original and replaced TEIs, all for both user and ctrl plane, in a
single struct. A single expiry entry handles the entire tunnel, instead of
previously four separate expiries for each endpoint identifier.
Add the concept of a "side", being either GGSN or SGSN.
Track the originating side in the gtp_packet_desc. For clarity, explicitly
track the received header TEI in header_tei_rx, since set_tei() overwrites
header_tei to reflect the packet's replaced header TEI, and the originally
received header TEI still needs to be used for matching a Create PDP Context
Response up with its Request (and for logging).
Adjust the test suite to expect tunnel listing strings instead of TEI mappings,
with a bonus of making it a lot easier to grok and including the IP addresses.
Note: the current implementation is as slow as can possibly be, iterating all
the tunnels all the time. Optimizations are kept for a future commit, on
purpose.
BTW, the sequence number mapping/unmapping structures remain unchanged.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=7f2d40ceb755943d52fcae8ddb12c09e…
commit 7f2d40ceb755943d52fcae8ddb12c09e2d0c623f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 25 16:50:19 2015 +0100
gtphub: fix filename mentioned in comment
http://cgit.osmocom.org/openbsc/commit/?id=c1e297a9f030429a075392b4888d2653…
commit c1e297a9f030429a075392b4888d26539a333dbf
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 25 16:45:59 2015 +0100
gtphub: cosmetic/prepare: rename expiry queues.
The expiry queues are already used for resolved GGSN addresses, and will
soon enlist tunnel structs. Hence the naming should be more general.
http://cgit.osmocom.org/openbsc/commit/?id=444fe1be787fd291b5bc9c347303047e…
commit 444fe1be787fd291b5bc9c347303047e78089c35
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:32:23 2015 +0100
gtphub: add assertion to ensure expiry ordering.
Make 100% sure the user adds expiring_items in chronological order by asserting
that a newly added expiry is >= the last expiry in the queue. Add llist_last()
to facilitate.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=3bf4d4ddd97383a98d3da56f3b57e7aa…
commit 3bf4d4ddd97383a98d3da56f3b57e7aac2adcf54
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:31:06 2015 +0100
gtphub: refresh TEI timeout when TEI is used.
Make sure a TEI mapping remains valid when it is in use (so far all mappings
would expire after 6 hours, in use or not).
Add regression test for this.
Note: this does not yet refresh a Ctrl TEI mapping when a corresponding User
TEI is used (todo?).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=da53b650561f5c2e81bd499657497713…
commit da53b650561f5c2e81bd499657497713a7276725
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:30:38 2015 +0100
gtphub: cosmetic/prepare: add nr_map_refresh().
http://cgit.osmocom.org/openbsc/commit/?id=036874d27b458d4359a9132e3361e47b…
commit 036874d27b458d4359a9132e3361e47b42935117
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:27:13 2015 +0100
gtphub: move timestamp into packet struct.
Instead of passing the current time around in function arguments ('now'),
rather store the current time once upon decoding a GTP packet in the
gtp_packet_desc passed around anyway ('p->timestamp').
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=3c4c17178f6d41ee83b441b9ce7d55d4…
commit 3c4c17178f6d41ee83b441b9ce7d55d4e404b73d
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:23:44 2015 +0100
gtphub: cosmetic: fix an argument name.
http://cgit.osmocom.org/openbsc/commit/?id=89a83524dc4dcf73bedd8c98659bfd00…
commit 89a83524dc4dcf73bedd8c98659bfd006a422a3b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 03:16:19 2015 +0100
gtphub: first vty show commands.
Start adding VTY commands to show rate counters / statistics / cache dumps.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=5b3ed5a6cd4bc03b225e59910d647a5d…
commit 5b3ed5a6cd4bc03b225e59910d647a5d4d21243a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 01:28:40 2015 +0100
gtphub: add first rate counters
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=5b231c38318754de6b9b16e91d0f1dc2…
commit 5b231c38318754de6b9b16e91d0f1dc29290872d
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 01:27:22 2015 +0100
gtphub: cosmetic: clarify bind pointer naming.
Some gtphub_bind pointers point to an array of binds, some point directly at
instances. Make the distinction between the two more obvious by adding an
'_arr' suffix to the array ones.
Partly in preparation for upcoming rate counters.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=a0e2c562de54d87a48bdd059e18ef782…
commit a0e2c562de54d87a48bdd059e18ef782f18c3cc8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 00:08:28 2015 +0100
gtphub: add explicit cleanup handles.
Clean up functionality is added for the test suite only, to be able to clean
out all allocations and test against memory leaks.
So far, it was sufficient to expire everything to free a gtphub. In preparation
for the upcoming rate counters, which will need to be freed explicitly, add
gtphub functions to clean up everything.
As added bonus, also close the sockets explicitly -- not really needed upon
program exit, neither by the test suite, but *if* we have a cleanup function,
it should clean up everything properly.
Closing the sockets is however kept separate, for the test suite.
gtphub_start() and gtphub_stop() are for normal use (published in gtphub.h),
and gtphub_init() and gtphub_free() are for the test suite, without sockets.
(gtphub_stop() will probably never be called by anyone, but its existence
completes the picture.)
In gtphub_test.c, have a function to clean up the testing gtphub struct. First,
expire everything by timeout, assert emptiness, then call the cleanup function.
Call from each test in the end.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=d369720ec8bda4f2fb3ee0b1a719211d…
commit d369720ec8bda4f2fb3ee0b1a719211d66df247a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 00:04:41 2015 +0100
gtphub: ensure cleanup of peer addresses.
Upon calling gtphub_peer_del(), all addresses and ports should already have
expired (by force). Make sure the code heeds that with a so far missing
assertion.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=f397ca83bea6f15f194b522d9278695c…
commit f397ca83bea6f15f194b522d9278695c7a27765f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 19 00:44:52 2015 +0100
gtphub: send gtphub's own restart counter, fix type.
So far, the sender's restart counter was copied through, which would break as
soon as more than one SGSN or more than one GGSN would talk to the same peer.
Also fix the restart counter data type (just one octet after all).
gtphub should also persist its restart counter and handle peers that have
rebooted, both of which is still not implemented.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=402b117fe1ec63fe9c30eaa38850a477…
commit 402b117fe1ec63fe9c30eaa38850a477601799e9
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 18:11:32 2015 +0100
gtphub: ares vty and init
From sgsn_vty.c, copy the cfg_grx_ggsn_cmd to add an ares server to the static
sgsn_instance.
This is sort of preliminary. As described in comments, the sgsn_ares functions
should actually be separated from the static sgsn structure. gtphub keeps such
an sgsn structure just for the sgsn_ares functions.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=fce0d1ee3b0717d18d081db9ceadbab2…
commit fce0d1ee3b0717d18d081db9ceadbab2525441b8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 18:11:09 2015 +0100
gtphub: review some logging.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=786d555de00d65e6c0b07008fe1cc8f5…
commit 786d555de00d65e6c0b07008fe1cc8f593118c2e
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 17:53:00 2015 +0100
gtphub: cosmetic: rename a file.
gtphub_ext.c's initial purpose was to wrap a specific function. The file
then turned into everything related to DNS, which fits pretty well. Rename
to gtphub_ares.c.
Tweak the header comment to reflect the new file name.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=42d114b846a4a1852f22ecfd56d8872c…
commit 42d114b846a4a1852f22ecfd56d8872cae83018a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 17 14:30:37 2015 +0100
gtphub: nr_map: add min,max and wrap.
Implement min/max bounds for nr_pool, adjust nr_pool_init() and current tests,
and create unit tests for nr_map wrapping.
Sequence numbers range from 0 to 65535, while TEIs range from 1 to 0xffffffff.
Both cause problems when the nr_pool surpasses the range: seq exit their valid
range, causing unmappings to fail, and a TEI would be mapped as zero (invalid).
Add a comment about TEI wrapping, and lose the comment about random TEIs (not
really important).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=03203415845cd646c748983f8ab49ecb…
commit 03203415845cd646c748983f8ab49ecb8ca0581a
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 17 14:24:46 2015 +0100
gtphub: fix number map range for TEIs.
Use unsigned int for nr_map, just large enough to fit the TEI space.
Adjust log output formats and casts accordingly.
Fixes: TEIs are uint32_t, but the nr_map so far used int. This would cause TEIs
from 0x80000000 on to be handled and printed as a negative value.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=fa74d6dd746e65166d4f7d62d7c6ff69…
commit fa74d6dd746e65166d4f7d62d7c6ff698bec2900
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 18 17:09:22 2015 +0100
gtphub: add to debian build
By the example of osmo-sgsn, package osmo-gtphub for debian.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=6de6ea937eae341577dedb93d95bd9de…
commit 6de6ea937eae341577dedb93d95bd9ded7fd440f
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 22:20:50 2015 +0100
gtphub: remove obsolete comment.
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gtphub.h | 3 +-
openbsc/src/gprs/gtphub.c | 131 ++++++++++++++-------------------------
openbsc/src/gprs/gtphub_main.c | 88 +++++++++++++++++++++++---
3 files changed, 128 insertions(+), 94 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via ee702cd590688c1e65296319c5bc4c9cf160ba65 (commit)
via f13de868be052f96325c337f25453f1d97777005 (commit)
via 46b703d083a57d7718340f8f71da29d96ce15170 (commit)
via 2e8f9ed5560ac6286b1fe70ade868569d30cb392 (commit)
via b6e6bea4ecea4b0769fc56136321f01f553459ba (commit)
from 5fa0dcc2750a79920d4a6404e960c50667840058 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=ee702cd590688c1e65296319c5bc…
commit ee702cd590688c1e65296319c5bc4c9cf160ba65
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 10 11:38:25 2015 +0100
stats: Add TODO comment to rate_ctr
Currently the counters are scanned twice, once for interval
computation and once for reporting.
This adds a reminder to move the interval computation code to a
special stats reporter which just shall update the fields.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/libosmocore/commit/?id=f13de868be052f96325c337f2545…
commit f13de868be052f96325c337f25453f1d97777005
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 10 11:36:58 2015 +0100
stats/test: Add memory leak check
Adds a rudimentary leak check for the counters and stat items.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/libosmocore/commit/?id=46b703d083a57d7718340f8f71da…
commit 46b703d083a57d7718340f8f71da29d96ce15170
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 17:25:27 2015 +0100
stats/test: Add test for reporting
This tests uses a dedicated test reported to check several aspects of
the value reporting.
- addition/removal of stats reporter
- addition/removal of counters/items
- setting of max_class
- initial value flush
- updating single counters/items
- reporter retrieval
- enable/disable
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/libosmocore/commit/?id=2e8f9ed5560ac6286b1fe70ade86…
commit 2e8f9ed5560ac6286b1fe70ade868569d30cb392
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 15:48:25 2015 +0100
stats: Reorder functions in stats.c
Due to prior refactoring, the functions do not have an sensible order
in the file. This commit tries to improve that a little bit.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/libosmocore/commit/?id=b6e6bea4ecea4b0769fc56136321…
commit b6e6bea4ecea4b0769fc56136321f01f553459ba
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 9 15:33:44 2015 +0100
stats: Move statsd related code into a separate file
This commit moves the stats specific code parts into stats_statsd.c
while keeping the generic parts in stats.c. The code in stats.c no
longer contains references to statsd symbols.
Note that the VTY code still needs to know about every stats reporter
backend.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/core/stats.h | 16 ++-
src/Makefile.am | 2 +-
src/rate_ctr.c | 3 +
src/stats.c | 256 ++++++++++----------------------------
src/stats_statsd.c | 158 ++++++++++++++++++++++++
tests/stats/stats_test.c | 283 ++++++++++++++++++++++++++++++++++++++++---
tests/stats/stats_test.ok | 108 +++++++++++++++++
7 files changed, 612 insertions(+), 214 deletions(-)
create mode 100644 src/stats_statsd.c
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
via cb591d0e9175dad898de019612a68f9adfd25f4b (commit)
from 88d06caa712a3fd40960c0d11d45373dc9341659 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=cb591d0e9175dad898de019612a68f9a…
commit cb591d0e9175dad898de019612a68f9adfd25f4b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 05:20:18 2015 +0100
gtphub: complain about excess cmdline args.
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gtphub_main.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
via 88d06caa712a3fd40960c0d11d45373dc9341659 (commit)
via 2d228573f2df28be5d185d8d93ec3b887f526eb7 (commit)
via f0dc0f3bd9d702c59d46cd358ba9915377136cfc (commit)
from ad51b759181064c87f26ed702c16d3edc3bc12ec (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=88d06caa712a3fd40960c0d11d45373d…
commit 88d06caa712a3fd40960c0d11d45373dc9341659
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 26 03:33:29 2015 +0100
gtphub: track tunnels explicitly.
So far, gtphub worked perfectly by only tracking single TEIs ... for probably
most uses. But a Ctrl plane tunnel may have expired despite a still active
corresponding User plane tunnel. The User plane would continue to work
indefinitely, but if any Ctrl messages followed after more than six hours of
Ctrl silence, they would have been dropped due to an expired TEI mapping.
We want to
- combine expiry of a user TEI with its ctrl TEI. (done in this patch)
- upon delete PDP context, remove both user and ctrl TEI mappings. (future)
- when a peer indicates a restart counter bump, invalidate its tunnels.
(future)
To facilitate these, track tunnels, complete with both SGSN's and GGSN's
address, original and replaced TEIs, all for both user and ctrl plane, in a
single struct. A single expiry entry handles the entire tunnel, instead of
previously four separate expiries for each endpoint identifier.
Add the concept of a "side", being either GGSN or SGSN.
Track the originating side in the gtp_packet_desc. For clarity, explicitly
track the received header TEI in header_tei_rx, since set_tei() overwrites
header_tei to reflect the packet's replaced header TEI, and the originally
received header TEI still needs to be used for matching a Create PDP Context
Response up with its Request (and for logging).
Adjust the test suite to expect tunnel listing strings instead of TEI mappings,
with a bonus of making it a lot easier to grok and including the IP addresses.
Note: the current implementation is as slow as can possibly be, iterating all
the tunnels all the time. Optimizations are kept for a future commit, on
purpose.
BTW, the sequence number mapping/unmapping structures remain unchanged.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=2d228573f2df28be5d185d8d93ec3b88…
commit 2d228573f2df28be5d185d8d93ec3b887f526eb7
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 25 16:50:19 2015 +0100
gtphub: fix filename mentioned in comment
http://cgit.osmocom.org/openbsc/commit/?id=f0dc0f3bd9d702c59d46cd358ba99153…
commit f0dc0f3bd9d702c59d46cd358ba9915377136cfc
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Wed Nov 25 16:45:59 2015 +0100
gtphub: cosmetic/prepare: rename expiry queues.
The expiry queues are already used for resolved GGSN addresses, and will
soon enlist tunnel structs. Hence the naming should be more general.
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gtphub.h | 43 ++++-
openbsc/src/gprs/gtphub.c | 338 ++++++++++++++++++++++++++++++-------
openbsc/src/gprs/gtphub_ares.c | 2 +-
openbsc/src/gprs/gtphub_vty.c | 158 ++++++++---------
openbsc/tests/gtphub/gtphub_test.c | 73 +++++---
5 files changed, 434 insertions(+), 180 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, fairwaves/dynamic-rtp-pt-fix has been updated
via 871cbd3ea56485fe60ac88634c1ef2c887c0d5c2 (commit)
from b8e04d4041c1805e161bd17dbf846293457dccea (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=871cbd3ea56485fe60ac88634c1ef2c8…
commit 871cbd3ea56485fe60ac88634c1ef2c887c0d5c2
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Tue Nov 24 21:28:58 2015 -0500
rtp_proxy: Fix out of bound access when AMR is enabled.
One extra byte is used for the AMR frame size, which was not accounted for.
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libtrau/rtp_proxy.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, fairwaves/dynamic-rtp-pt-fix has been created
at b8e04d4041c1805e161bd17dbf846293457dccea (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=b8e04d4041c1805e161bd17dbf846293…
commit b8e04d4041c1805e161bd17dbf846293457dccea
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Tue Nov 24 21:18:01 2015 -0500
rtp_proxy: Use actual codec type instead of payload type.
http://cgit.osmocom.org/openbsc/commit/?id=bbb158bb1091974f1ce2cab2e95cddd3…
commit bbb158bb1091974f1ce2cab2e95cddd3eb9bfb28
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Tue Nov 24 21:16:40 2015 -0500
rtp_proxy: Don't try to guess codec by payload type - it'll be wrong anyway.
We should use msg_type instead, which has information about the actual codec.
http://cgit.osmocom.org/openbsc/commit/?id=f8caeb27a158082d9dd79bab976c11e5…
commit f8caeb27a158082d9dd79bab976c11e53d117445
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Tue Nov 24 21:14:52 2015 -0500
rtp_proxy: Always pass RTP codec into rtp_decode().
We can't rely on payload type for decoding, so lets use actual codec type.
http://cgit.osmocom.org/openbsc/commit/?id=945fb547dba1f562538de718bad69d57…
commit 945fb547dba1f562538de718bad69d5780b467ce
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Tue Nov 24 21:13:23 2015 -0500
rtp_proxy: Fix debug output for rtp_socket_upstream().
http://cgit.osmocom.org/openbsc/commit/?id=ccdd23317062d7e94f5eb40f025ab21c…
commit ccdd23317062d7e94f5eb40f025ab21c9bdaa50f
Author: Alexander Chemeris <Alexander.Chemeris(a)gmail.com>
Date: Tue Nov 24 21:09:27 2015 -0500
rtp_proxy: Pass RTP message type to rtp_socket_upstream().
This allows us to decode incoming RTP packet based on the codec instead
of relying on payload type. Payload type is dynamic for HR, EFR and AMR,
so we can't rely on it.
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom code for Iuh interface".
The branch, master has been updated
via 1a86955288e44041e56c411f59407a04e49739b5 (commit)
via 39e643a62d6cfccf993a06be611f251b75c4074f (commit)
from 8ea918d772ec2e9eac460844c0c66f829dfa9c97 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-iuh/commit/?id=1a86955288e44041e56c411f59407a0…
commit 1a86955288e44041e56c411f59407a04e49739b5
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Tue Nov 24 18:11:03 2015 +0100
tests/test-hnbap: Decode HNBAP UE Register accept as well
http://cgit.osmocom.org/osmo-iuh/commit/?id=39e643a62d6cfccf993a06be611f251…
commit 39e643a62d6cfccf993a06be611f251b75c4074f
Author: Daniel Willmann <dwillmann(a)sysmocom.de>
Date: Tue Nov 24 18:03:29 2015 +0100
tests: Add test-hnbap to test en-/decoding of HNBAP messages
Decode a HNBAP UE register request and check the result.
-----------------------------------------------------------------------
Summary of changes:
src/tests/Makefile | 5 +-
src/tests/test-hnbap.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 132 insertions(+), 1 deletion(-)
create mode 100644 src/tests/test-hnbap.c
hooks/post-receive
--
Osmocom code for Iuh interface
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
discards a43c956c928b5c0a0fca1f3f79d77293c3648be3 (commit)
discards 634178aa7792db4d396b00aaf72d5ad82b5a730b (commit)
discards 137a202032455ecf05594c0e75d806ff90876e48 (commit)
discards f4ec777f932c510fd04fa5113db650a0861ee961 (commit)
discards 3ed33b61d72eef110e12478f6cbbc0931210b0bb (commit)
discards 254714ceb1e9581b170044f35257b50d36d659b1 (commit)
discards bd6f15c2664de6d53c6129f86cf104fa7fa75495 (commit)
discards 52712a4a879cbe1be066e50c0f9e8efb3a3cab24 (commit)
discards bd49d8a4b599796369b845b2763f87f39a2d8354 (commit)
discards 88f25563c31fb68d3f0a67d8c80dadc3492d43fa (commit)
discards 57e34eb473562bf71962f01efaa1db875dd424c5 (commit)
via ad51b759181064c87f26ed702c16d3edc3bc12ec (commit)
via e6b56c49fd36757aa507bbbef868cdc98d2cd3ca (commit)
via 5d2e92036d0bc6fbcab522e3eb3cb71cf62d80cc (commit)
via 628c0c8f82673390e92cc5f532f7f1e0d368c26c (commit)
via eb7b0a83b4555222215a0ec6155e0eecaadf3f24 (commit)
via 1c31e9a0793c90c856f6537d31b8f20e5d93ff4b (commit)
via e68fee7637ac953837adddb8c3428909a07ecfcb (commit)
via b30bfedb11e10ea7f99a5e98d5b8274cb866baa8 (commit)
via 5171ef9d2059625cf4d4c5775fe8e0c18ee5cd8b (commit)
via 25a88f932df6ea89d33da5ffafc883f735462636 (commit)
via 105b984f6af0907838529755efc6cf3ba3f5bad8 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (a43c956c928b5c0a0fca1f3f79d77293c3648be3)
\
N -- N -- N (ad51b759181064c87f26ed702c16d3edc3bc12ec)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=ad51b759181064c87f26ed702c16d3ed…
commit ad51b759181064c87f26ed702c16d3edc3bc12ec
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:32:23 2015 +0100
gtphub: add assertion to ensure expiry ordering.
Make 100% sure the user adds expiring_items in chronological order by asserting
that a newly added expiry is >= the last expiry in the queue. Add llist_last()
to facilitate.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e6b56c49fd36757aa507bbbef868cdc9…
commit e6b56c49fd36757aa507bbbef868cdc98d2cd3ca
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:31:06 2015 +0100
gtphub: refresh TEI timeout when TEI is used.
Make sure a TEI mapping remains valid when it is in use (so far all mappings
would expire after 6 hours, in use or not).
Add regression test for this.
Note: this does not yet refresh a Ctrl TEI mapping when a corresponding User
TEI is used (todo?).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=5d2e92036d0bc6fbcab522e3eb3cb71c…
commit 5d2e92036d0bc6fbcab522e3eb3cb71cf62d80cc
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:30:38 2015 +0100
gtphub: cosmetic/prepare: add nr_map_refresh().
http://cgit.osmocom.org/openbsc/commit/?id=628c0c8f82673390e92cc5f532f7f1e0…
commit 628c0c8f82673390e92cc5f532f7f1e0d368c26c
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:27:13 2015 +0100
gtphub: move timestamp into packet struct.
Instead of passing the current time around in function arguments ('now'),
rather store the current time once upon decoding a GTP packet in the
gtp_packet_desc passed around anyway ('p->timestamp').
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=eb7b0a83b4555222215a0ec6155e0eec…
commit eb7b0a83b4555222215a0ec6155e0eecaadf3f24
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Nov 24 13:23:44 2015 +0100
gtphub: cosmetic: fix an argument name.
http://cgit.osmocom.org/openbsc/commit/?id=1c31e9a0793c90c856f6537d31b8f20e…
commit 1c31e9a0793c90c856f6537d31b8f20e5d93ff4b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 03:16:19 2015 +0100
gtphub: first vty show commands.
Start adding VTY commands to show rate counters / statistics / cache dumps.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e68fee7637ac953837adddb8c3428909…
commit e68fee7637ac953837adddb8c3428909a07ecfcb
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 01:28:40 2015 +0100
gtphub: add first rate counters
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=b30bfedb11e10ea7f99a5e98d5b8274c…
commit b30bfedb11e10ea7f99a5e98d5b8274cb866baa8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 01:27:22 2015 +0100
gtphub: cosmetic: clarify bind pointer naming.
Some gtphub_bind pointers point to an array of binds, some point directly at
instances. Make the distinction between the two more obvious by adding an
'_arr' suffix to the array ones.
Partly in preparation for upcoming rate counters.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=5171ef9d2059625cf4d4c5775fe8e0c1…
commit 5171ef9d2059625cf4d4c5775fe8e0c18ee5cd8b
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 00:08:28 2015 +0100
gtphub: add explicit cleanup handles.
Clean up functionality is added for the test suite only, to be able to clean
out all allocations and test against memory leaks.
So far, it was sufficient to expire everything to free a gtphub. In preparation
for the upcoming rate counters, which will need to be freed explicitly, add
gtphub functions to clean up everything.
As added bonus, also close the sockets explicitly -- not really needed upon
program exit, neither by the test suite, but *if* we have a cleanup function,
it should clean up everything properly.
Closing the sockets is however kept separate, for the test suite.
gtphub_start() and gtphub_stop() are for normal use (published in gtphub.h),
and gtphub_init() and gtphub_free() are for the test suite, without sockets.
(gtphub_stop() will probably never be called by anyone, but its existence
completes the picture.)
In gtphub_test.c, have a function to clean up the testing gtphub struct. First,
expire everything by timeout, assert emptiness, then call the cleanup function.
Call from each test in the end.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=25a88f932df6ea89d33da5ffafc883f7…
commit 25a88f932df6ea89d33da5ffafc883f735462636
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Fri Nov 20 00:04:41 2015 +0100
gtphub: ensure cleanup of peer addresses.
Upon calling gtphub_peer_del(), all addresses and ports should already have
expired (by force). Make sure the code heeds that with a so far missing
assertion.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=105b984f6af0907838529755efc6cf3b…
commit 105b984f6af0907838529755efc6cf3ba3f5bad8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Thu Nov 19 00:44:52 2015 +0100
gtphub: send gtphub's own restart counter, fix type.
So far, the sender's restart counter was copied through, which would break as
soon as more than one SGSN or more than one GGSN would talk to the same peer.
Also fix the restart counter data type (just one octet after all).
gtphub should also persist its restart counter and handle peers that have
rebooted, both of which is still not implemented.
Sponsored-by: On-Waves ehi
-----------------------------------------------------------------------
Summary of changes:
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)