Attention is currently required from: pespin, fixeria.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 )
Change subject: gsm/ipa: Add segmentation callback ......................................................................
Patch Set 4:
(4 comments)
File include/osmocom/gsm/ipa.h:
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/539c9206_4a3fa969 PS2, Line 74: int ipa_iofd_segmentation_cb(struct msgb *msg, int read);
what does "read" mean here? read_bytes? read_rc?
ah I had deleted this line, but that must have gotten lost somehow in a local change after I changed my workflow
File src/gsm/ipa.c:
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/995caa9c_cdd4d12a PS2, Line 724: if (msgb_length(msg) < sizeof(struct ipaccess_head))
cosmetic: more than one line, add curly braces please
Done
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/dfdfae1a_12d9218a PS2, Line 727: struct ipaccess_head *hh
const?
Done
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/10d48632_720d9922 PS2, Line 730: payload_len < 0
I doubt this is possible, because a) `size_t` unsigned, and b) neither `hh->len` nor `sizeof(*hh)` c […]
Done
-
arehbein