Attention is currently required from: pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 ) Change subject: gsm/ipa: Add segmentation callback ...................................................................... Patch Set 4: (4 comments) File include/osmocom/gsm/ipa.h: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/539c9206_4a3fa969 PS2, Line 74: int ipa_iofd_segmentation_cb(struct msgb *msg, int read); ah I had deleted this line, but that must have gotten lost somehow in a local change after I changed my workflow File src/gsm/ipa.c: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/995caa9c_cdd4d12a PS2, Line 724: if (msgb_length(msg) < sizeof(struct ipaccess_head)) Done https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/dfdfae1a_12d9218a PS2, Line 727: struct ipaccess_head *hh Done https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/10d48632_720d9922 PS2, Line 730: payload_len < 0 Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Gerrit-Change-Number: 33083 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein &lt;arehbein(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 06 Jun 2023 14:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-MessageType: comment